WebKit.git
12 years agowx build fix. Allow waf build to support Python < 2.6.
kevino@webkit.org [Tue, 15 Sep 2009 19:25:00 +0000 (19:25 +0000)]
wx build fix. Allow waf build to support Python < 2.6.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore: Document.elementFromPoint() and Document.caretRangeFromPoint() erroneously...
mrowe@apple.com [Tue, 15 Sep 2009 18:40:11 +0000 (18:40 +0000)]
WebCore: Document.elementFromPoint() and Document.caretRangeFromPoint() erroneously returning null at points visible only after scrolling.
https://bugs.webkit.org/show_bug.cgi?id=29245

Patch by Andrew Richards <randrew@gmail.com> on 2009-09-14
Reviewed by Sam Weinig.

Use visibleContentRect() instead of boundsRect() when checking hit point bounds on viewport.

* dom/Document.cpp:
(WebCore::Document::elementFromPoint):
(WebCore::Document::caretRangeFromPoint):

LayoutTests: Document.elementFromPoint() and Document.caretRangeFromPoint() returning null at points visible only after scrolling.
https://bugs.webkit.org/show_bug.cgi?id=29245

Patch by Andrew Richards <randrew@gmail.com> on 2009-09-14
Reviewed by Sam Weinig.

Extend tests to include hits in areas that are not in the initial containing block of the page.

* fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt:
* fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html:
* fast/dom/elementFromPoint-relative-to-viewport-expected.txt:
* fast/dom/elementFromPoint-relative-to-viewport.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-15 Jungshik Shin <jshin@chromium.org>
jshin@chromium.org [Tue, 15 Sep 2009 18:36:44 +0000 (18:36 +0000)]
2009-09-15  Jungshik Shin  <jshin@chromium.org>

        Reviewed by Eric Seidel

        http://bugs.webkit.org/show_bug.cgi?id=26660

        Chromium Windows: When rotated, the baseline for a span of complex
        script is completely misaligned with that of the adjacent
        simple script text. It's fixed by not applying the baseline offset for
        the Skia code path.

        Test: transforms/2d/hindi-rotated.html

        * platform/graphics/chromium/UniscribeHelper.cpp:
        (WebCore::UniscribeHelper::draw):

2009-09-15  Jungshik Shin  <jshin@chromium.org>

        Reviewed by Eric Seidel

        http://bugs.webkit.org/show_bug.cgi?id=26660

        Chromium Windows: When rotated, the baseline for a span of complex
        script is completely misaligned with that of the adjacent simple
        script text.

        * transforms/2d/hindi-rotated.html: Added.
        * platform/mac/transforms/2d/hindi-rotated-expected.checksum: Added.
        * platform/mac/transforms/2d/hindi-rotated-expected.png: Added.
        * platform/mac/transforms/2d/hindi-rotated-expected.txt: Added.
        * platform/win/transforms: Added.
        * platform/win/transforms/2d: Added.
        * platform/win/transforms/2d/hindi-rotated-expected.checksum: Added.
        * platform/win/transforms/2d/hindi-rotated-expected.png: Added.
        * platform/win/transforms/2d/hindi-rotated-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoPass the PopupMenu pointer to CreateWindowEx and then get it from the LPCREATESTRUCT in
andersca@apple.com [Tue, 15 Sep 2009 18:30:41 +0000 (18:30 +0000)]
Pass the PopupMenu pointer to CreateWindowEx and then get it from the LPCREATESTRUCT in
the WM_CREATE handler. This way we don't have to first create an zero size window and then size it.

Reviewed by Adam Roben.

* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenu::show):
(WebCore::PopupMenu::PopupMenuWndProc):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMessageEvent should not be cancelable by default
atwilson@chromium.org [Tue, 15 Sep 2009 18:27:45 +0000 (18:27 +0000)]
MessageEvent should not be cancelable by default
https://bugs.webkit.org/show_bug.cgi?id=27846

Reviewed by Darin Adler.

WebCore:

* dom/MessageEvent.cpp:
(WebCore::MessageEvent::MessageEvent):
Changed constructor to set cancelable=false by default, per the HTML5 spec.

LayoutTests:

* fast/events/message-port-expected.txt:
* fast/events/message-port.html:
Added test case to check state of MessageEvent.cancelable attribute.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/7224378> REGRESSION(r48360): Dragging a tab with a plug-in out of...
mrowe@apple.com [Tue, 15 Sep 2009 18:20:31 +0000 (18:20 +0000)]
<rdar://problem/7224378> REGRESSION(r48360): Dragging a tab with a plug-in out of a window, the plug-in gets slow and confused

Reviewed by Anders Carlsson.

In r48360, the fix for <rdar://problem/7090444>, I neglected to consider the case where the plug-in had already been started and
-start would do an early-return rather than calling -restartTimers and -addWindowObservers itself.

* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView viewDidMoveToWindow]): Reinstate the call to -restartTimers and -addWindowObservers, but guard them
with a check that the view is still in the window.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-15 Charles Wei <charles.wei@torchmobile.com.cn>
eric@webkit.org [Tue, 15 Sep 2009 17:52:08 +0000 (17:52 +0000)]
2009-09-15  Charles Wei  <charles.wei@torchmobile.com.cn>

        Reviewed by George Staikos.

        Add a new test case for SVG Path parsing with a default command and starts with dot '.'
        https://bugs.webkit.org/show_bug.cgi?id=29123

        * svg/dom/path-parser-expected.txt:
        * svg/dom/resources/path-parser.js:
2009-09-15  Charles Wei  <charles.wei@torchmobile.com.cn>

        Reviewed by George Staikos.

        Fix SVG path parsing error if a command starts with dot '.'
        https://bugs.webkit.org/show_bug.cgi?id=29123

        * svg/SVGParserUtilities.cpp:
        (WebCore::SVGPathParser::parseSVG):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoImplement conditional breakpoints in the Web Inspector frontend.
rik@webkit.org [Tue, 15 Sep 2009 13:14:50 +0000 (13:14 +0000)]
Implement conditional breakpoints in the Web Inspector frontend.
https://bugs.webkit.org/show_bug.cgi?id=28908

Patch by Alexander Pavlov <apavlov@chromium.org> on 2009-09-15
Reviewed by Timothy Hatcher.

* English.lproj/localizedStrings.js:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/Breakpoint.js:
(WebInspector.Breakpoint.prototype.set condition):
* inspector/front-end/Popup.js: Added.
(WebInspector.Popup):
(WebInspector.Popup.prototype.show):
(WebInspector.Popup.prototype.hide):
(WebInspector.Popup.prototype.get visible):
(WebInspector.Popup.prototype.set element):
(WebInspector.Popup.prototype.get element):
(WebInspector.Popup.prototype.positionElement):
(WebInspector.Popup.prototype.set anchor):
(WebInspector.Popup.prototype.get anchor):
(WebInspector.Popup.prototype.set autoHide):
(WebInspector.Popup.prototype._checkNotVisible):
(WebInspector.Popup.prototype._keyEventHandler):
(WebInspector.Popup.prototype._mouseDownEventHandler):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.revealLine):
(WebInspector.SourceFrame.prototype._loaded):
(WebInspector.SourceFrame.prototype._documentContextMenu):
(WebInspector.SourceFrame.prototype._documentMouseDown):
(WebInspector.SourceFrame.prototype._editBreakpointCondition.committed):
(WebInspector.SourceFrame.prototype._editBreakpointCondition.dismissed):
(WebInspector.SourceFrame.prototype._editBreakpointCondition):
(WebInspector.SourceFrame.prototype._showBreakpointConditionPopup):
(WebInspector.SourceFrame.prototype._createPopupElement):
(WebInspector.SourceFrame.prototype._addBreakpointToSource):
(WebInspector.SourceFrame.prototype._removeBreakpointFromSource):
(WebInspector.SourceFrame.prototype._drawBreakpointImagesIfNeeded.drawBreakpoint):
(WebInspector.SourceFrame.prototype._drawBreakpointImagesIfNeeded):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
(WebInspector.set currentFocusElement):
(WebInspector.set currentPanel):
(WebInspector.loaded):
(WebInspector.contextMenu):
(WebInspector.elementDragStart):
(WebInspector.updateResource):
(WebInspector.drawLoadingPieChart):
(WebInspector.linkifyURLAsNode):
(WebInspector.startEditing.getContent):
(WebInspector.startEditing.editingCancelled):
(WebInspector.startEditing.editingCommitted):
* inspector/front-end/utilities.js:
(Element.prototype.positionAt):
(Element.prototype.offsetRelativeToWindow):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Build fix for windows.
vestbo@webkit.org [Tue, 15 Sep 2009 13:03:32 +0000 (13:03 +0000)]
[Qt] Build fix for windows.

Patch by Csaba Osztrogonac <oszi@inf.u-szeged.hu> on 2009-09-15
Reviewed by Tor Arne Vestbø.

After http://trac.webkit.org/changeset/47795 the MinGW build broke,
because MinGW has __mingw_aligned_malloc instead of _aligned_malloc.

* runtime/Collector.cpp:
(JSC::Heap::allocateBlock): MinGW case added.
(JSC::Heap::freeBlock): MinGW case added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Build fix for Windows/MinGW
vestbo@webkit.org [Tue, 15 Sep 2009 12:51:51 +0000 (12:51 +0000)]
[Qt] Build fix for Windows/MinGW

Patch by Csaba Osztrogonac <oszi@inf.u-szeged.hu> on 2009-09-15
Reviewed by Tor Arne Vestbø.

https://bugs.webkit.org/show_bug.cgi?id=29268

* wtf/Platform.h: JSVALUE32_64 temporarily disabled on PLATFORM(WIN_OS) with COMPILER(MINGW)

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-14 Gabor Loki <loki@inf.u-szeged.hu>
zoltan@webkit.org [Tue, 15 Sep 2009 11:29:33 +0000 (11:29 +0000)]
2009-09-14  Gabor Loki  <loki@inf.u-szeged.hu>

        Reviewed by Gavin Barraclough.

        Detect VFP at runtime in generic ARM port on Linux platform.
        https://bugs.webkit.org/show_bug.cgi?id=29076

        * JavaScriptCore.pri:
        * assembler/MacroAssemblerARM.cpp: Added.
        (JSC::isVFPPresent):
        * assembler/MacroAssemblerARM.h:
        (JSC::MacroAssemblerARM::supportsFloatingPoint):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoPage cache should support pages with unload handlers as an experiment.
beidson@apple.com [Tue, 15 Sep 2009 04:25:02 +0000 (04:25 +0000)]
Page cache should support pages with unload handlers as an experiment.
<rdar://problem/7196485> and https://bugs.webkit.org/show_bug.cgi?id=29021

Reviewed by Darin Adler.

WebCore:

For the experiment, only allow pages with unload handlers into the Page Cache on
Mac and Windows.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::canCachePageContainingThisFrame):
(WebCore::FrameLoader::logCanCacheFrameDecision):

LayoutTests:

Disable fast/loader/frames-with-unload-handlers-in-page-cache.html as it doesn't
make sense in the context of this experiment.

* platform/mac/Skipped:
* platform/win/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUndoing mess: committing test code
kov@webkit.org [Tue, 15 Sep 2009 02:11:40 +0000 (02:11 +0000)]
Undoing mess: committing test code

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-14 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Tue, 15 Sep 2009 02:11:24 +0000 (02:11 +0000)]
2009-09-14  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez and Jan Alonzo.

        https://bugs.webkit.org/show_bug.cgi?id=29134
        [GTK] Add API to access sub resources

        Implement getting subresources, and improve testing of
        main, and sub resources loading.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJava
kov@webkit.org [Tue, 15 Sep 2009 02:08:46 +0000 (02:08 +0000)]
Java

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Add LayoutTests infrastructure to enable and disable webgl tests.
cmarrin@apple.com [Tue, 15 Sep 2009 01:28:20 +0000 (01:28 +0000)]
    Add LayoutTests infrastructure to enable and disable webgl tests.
        Also added a webgl test.
        https://bugs.webkit.org/show_bug.cgi?id=29254

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-14 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 15 Sep 2009 01:07:46 +0000 (01:07 +0000)]
2009-09-14  Simon Fraser  <simon.fraser@apple.com>

        Fix the change in r48376 to do a null-check to fix a crashing test.

        * dom/SelectElement.cpp:
        (WebCore::SelectElement::menuListDefaultEventHandler):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-14 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 15 Sep 2009 00:54:15 +0000 (00:54 +0000)]
2009-09-14  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        Add --iterations option to run-webkit-tests to repeat the tests N times
        https://bugs.webkit.org/show_bug.cgi?id=29263

        When run with --iterations N, run-webkit-tests will repeat the tests N times.

        * Scripts/run-webkit-tests:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agogit-svn-id: http://svn.webkit.org/repository/webkit/trunk@48377 268f45cc-cd09-0410...
beidson@apple.com [Tue, 15 Sep 2009 00:28:00 +0000 (00:28 +0000)]
git-svn-id: svn.webkit.org/repository/webkit/trunk@48377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-14 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 15 Sep 2009 00:19:57 +0000 (00:19 +0000)]
2009-09-14  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/7047282> Safari crashes at WebCore::RenderMenuList::adjustInnerStyle() + 436

        Avoid a crash when a mouse event handler on a <select> changes the select from a popup
        to a list (by setting the 'size' property) inside the event handler.

        Test: fast/forms/select-change-popup-to-listbox-in-event-handler.html

        * dom/SelectElement.cpp:
        (WebCore::SelectElement::menuListDefaultEventHandler):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMore PopupMenu cleanup.
andersca@apple.com [Mon, 14 Sep 2009 23:52:40 +0000 (23:52 +0000)]
More PopupMenu cleanup.

Reviewed by Jon Honeycutt.

* platform/PopupMenu.h:
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenu::show):
Call registerClass.

(WebCore::PopupMenu::registerClass):
Make this a private static member function so it can refer to PopupMenuWndProc.

(WebCore::PopupMenu::PopupMenuWndProc):
Try to get the PopupMenu and call its wndProc member function.

(WebCore::PopupMenu::wndProc):
Make this a member function.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix more fallout I wrought on myself by not testing the final authentication patch...
beidson@apple.com [Mon, 14 Sep 2009 23:08:44 +0000 (23:08 +0000)]
Fix more fallout I wrought on myself by not testing the final authentication patch on Windows.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoGTK build fix.
jhoneycutt@apple.com [Mon, 14 Sep 2009 22:46:38 +0000 (22:46 +0000)]
GTK build fix.

Unreviewed.

* DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
(AccessibilityController::setLogScrollingStartEvents):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSpeculative Qt build fix.
andersca@apple.com [Mon, 14 Sep 2009 22:45:59 +0000 (22:45 +0000)]
Speculative Qt build fix.

* platform/qt/QWebPopup.cpp:
(WebCore::QWebPopup::hidePopup):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-14 Dirk Pranke <dpranke@chromium.org>
eric@webkit.org [Mon, 14 Sep 2009 22:38:38 +0000 (22:38 +0000)]
2009-09-14  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Darin Fisher.

        Fix RenderThemeChromiumWin::determineClassicState so that classic_state
        matches the state values (and you get a single classic_state value
        for a given {part,state} value. This change will be tested by a
        chromium patch that will land after this.

        This will be tested by code landing downstream on Chromium.org; the
        code does not execute on webkit.org.

        * rendering/RenderThemeChromiumWin.cpp:
        (WebCore::RenderThemeChromiumWin::determineClassicState):
        (WebCore::RenderThemeChromiumWin::getThemeData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agohttps://bugs.webkit.org/show_bug.cgi?id=29138
andersca@apple.com [Mon, 14 Sep 2009 22:14:13 +0000 (22:14 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=29138
Simplify popup menu handling.

Reviewed by Adam Roben.

* platform/PopupMenuClient.h:
Rename hidePopup to popupDidHide.

* platform/chromium/PopupMenuChromium.cpp:
(WebCore::PopupListBox::handleKeyEvent):
(WebCore::PopupListBox::abandon):
(WebCore::PopupListBox::acceptIndex):
Call popupDidHide instead of hidePopup.

* platform/gtk/PopupMenuGtk.cpp:
(WebCore::PopupMenu::menuUnmapped):
Ditto.

* platform/mac/PopupMenuMac.mm:
(WebCore::PopupMenu::show):
Ditto.

* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenu::hide):
Call popupDidHide.

(WebCore::PopupWndProc):
Call PopupMenu::hide.

* platform/wx/PopupMenuWx.cpp:
(WebCore::PopupMenu::OnMenuItemSelected):
Call popupDidHide.

* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::hidePopup):
(WebCore::RenderMenuList::popupDidHide):
* rendering/RenderMenuList.h:
Set the "popup is visible" flag in popupDidHide.

* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::hidePopup):
(WebCore::RenderTextControlSingleLine::popupDidHide):
* rendering/RenderTextControlSingleLine.h:
Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago- Fix <rdar://problem/7182275>.
andersca@apple.com [Mon, 14 Sep 2009 21:27:08 +0000 (21:27 +0000)]
- Fix <rdar://problem/7182275>.

Reviewed by David Hyatt.

Make sure that the newly created scrollbar's style is up to date.

* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenu::~PopupMenu):
Call setParent so that the scrollbar's parts are torn down correctly.

(WebCore::PopupMenu::show):
Call styleChanged.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoDRT/test part of
jhoneycutt@apple.com [Mon, 14 Sep 2009 21:25:24 +0000 (21:25 +0000)]
DRT/test part of
<rdar://problem/7197644> WebKit should broadcast an MSAA event when
jumping to a named anchor

https://bugs.webkit.org/show_bug.cgi?id=28899

Reviewed by Adam Roben.

WebKitTools:

* DumpRenderTree/AccessibilityController.cpp:
(logScrollingStartEventsCallback):
Turn on logging of scrolling start events.
(AccessibilityController::getJSClass):
Add a "logScrollingStartEvents" to the AccessibilityController's JS
class definition.
(AccessibilityController::resetToConsistentState):
Turn off logging of scrolling start events.

* DumpRenderTree/AccessibilityController.h:
Declare setLogScrollingStartEvents(). Add a member for the scrolling
start event hook.

* DumpRenderTree/mac/AccessibilityControllerMac.cpp:
(AccessibilityController::setLogScrollingStartEvents):
Stubbed.

* DumpRenderTree/win/AccessibilityControllerWin.cpp:
(AccessibilityController::AccessibilityController):
Initialize the handle to 0.
(logEventProc):
Renamed from logFocusEventProc; now logs scrolling start events, too.
Removed the assertion that the event is a focus event. Added a switch
to print a message for focus, scrolling start, and other, unknown
events.
(AccessibilityController::setLogFocusEvents):
Changed to use logEventProc.
(AccessibilityController::setLogScrollingStartEvents):
If turning logging off, unhook the scrolling start event hook, and clear
the member holding the handle. If turning on, query for the root
accessible, so that accessibility is enabled for the WebView, and call
SetWinEventHook to setup an event hook using logEventProc as the
callback function.

LayoutTests:

* platform/win/accessibility/scroll-to-anchor-expected.txt: Added.
* platform/win/accessibility/scroll-to-anchor.html:
Added. Turns on scrolling start event logging, then jumps to an
anchor at the bottom of the page.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/7197644> WebKit should broadcast an MSAA event when
jhoneycutt@apple.com [Mon, 14 Sep 2009 21:25:08 +0000 (21:25 +0000)]
<rdar://problem/7197644> WebKit should broadcast an MSAA event when
jumping to a named anchor

https://bugs.webkit.org/show_bug.cgi?id=28899

Reviewed by Adam Roben.

* accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::):
Added declaration for handleScrolledToAnchor(). Added a new entry to
the enum of accessibility notifications.

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::firstAccessibleObjectFromNode):
Code moved from AccessibilityRenderObject::internalLinkElement() and
refactored slightly; walks the tree until it finds a Node (with a
renderer) whose accessibility is not ignored.

* accessibility/AccessibilityObject.h:
Added a declaration for firstAccessibleObjectFromNode().

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::internalLinkElement):
Code moved to AccessibilityObject::firstAccessibleObjectFromNode().

* accessibility/chromium/AXObjectCacheChromium.cpp:
(WebCore::AXObjectCache::handleScrolledToAnchor):
Stubbed.

* accessibility/gtk/AXObjectCacheAtk.cpp:
(WebCore::AXObjectCache::handleScrolledToAnchor):
Stubbed.

* accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postPlatformNotification):
Add a default case that returns early for notifications that Mac
doesn't handle.
(WebCore::AXObjectCache::handleScrolledToAnchor):
Stubbed.

* accessibility/win/AXObjectCacheWin.cpp:
(WebCore::AXObjectCache::handleScrolledToAnchor):
Post an AXScrolledToAnchor notification for the first accessible from
the anchor Node.
(WebCore::AXObjectCache::postPlatformNotification):
If the notification is AXFocusedUIElementChanged, fire an
EVENT_OBJECT_FOCUS. If the notification is AXScrolledToAnchor, fire
EVENT_SYSTEM_SCROLLINGSTART, matching Firefox.
(WebCore::AXObjectCache::handleFocusedUIElementChanged):
Code moved to postPlatformNotification().

* page/FrameView.cpp:
(WebCore::FrameView::scrollToAnchor):
Call AXObjectCache::handleScrolledToAnchor().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCookies are not inspectable after reloading a page
rik@webkit.org [Mon, 14 Sep 2009 21:09:04 +0000 (21:09 +0000)]
Cookies are not inspectable after reloading a page
https://bugs.webkit.org/show_bug.cgi?id=29222

Patch by Anthony Ricaud <rik@webkit.org> on 2009-09-14
Reviewed by Timothy Hatcher.

Create the cookieTreeElement on initialization instead of when the view is shown.
Reset the selected element of the sidebar on reset.

* inspector/front-end/StoragePanel.js:
(WebInspector.StoragePanel):
(WebInspector.StoragePanel.prototype.show):
(WebInspector.StoragePanel.prototype.reset):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWindows DRT build fix.
beidson@apple.com [Mon, 14 Sep 2009 20:32:19 +0000 (20:32 +0000)]
Windows DRT build fix.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWindows build fix.
beidson@apple.com [Mon, 14 Sep 2009 20:12:51 +0000 (20:12 +0000)]
Windows build fix.

* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
(WebCore::ResourceHandle::receivedCredential):
(WebCore::WebCoreSynchronousLoader::didReceiveChallenge):
(WebCore::WebCoreSynchronousLoader::load):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSafari 4 cannot be used to update firmware on Linksys routers.
beidson@apple.com [Mon, 14 Sep 2009 20:05:30 +0000 (20:05 +0000)]
Safari 4 cannot be used to update firmware on Linksys routers.
<rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160

Reviewed by Alexey Proskuryakov.

WebCore:

In http://trac.webkit.org/changeset/42483, we disabled CFNetwork's session credential storage and
implemented our own in WebCore.

One feature we lost is that CFNetwork would automatically send previously authenticated credentials
with new connections when the paths match, as allowed by RFC 2617 for HTTP Basic and Digest Authentication.

Even though it's optional for User Agents to do this, (some?) Linksys routers rely on this behavior for
HTTP Basic Authentication.  So now WebCore's CredentialStorage will track URL paths for Basic credentials.

We're not making this enhancement for Digest at this time, since we don't know of anything that broke
due to the change in Digest behavior.

Test: http/tests/loading/basic-credentials-sent-automatically.html
      http/tests/loading/basic-auth-resend-wrong-credentials.html

* WebCore.base.exp:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:

* platform/network/Credential.cpp:
(WebCore::Credential::isEmpty):
* platform/network/Credential.h:

Add a slightly more full featured CredentialStore that will track URL paths a credential belongs to:
* platform/network/CredentialStorage.cpp: Added.
(WebCore::protectionSpaceToCredentialMap):
(WebCore::originToDefaultCredentialMap):
(WebCore::originStringFromURL):
(WebCore::CredentialStorage::set):
(WebCore::CredentialStorage::get):
(WebCore::CredentialStorage::getDefaultAuthenticationCredential):
* platform/network/CredentialStorage.h: Added.

Allow ProtectionSpace to be a hash key:
* platform/network/ProtectionSpace.cpp:
(WebCore::ProtectionSpace::ProtectionSpace):
* platform/network/ProtectionSpace.h:
(WebCore::ProtectionSpace::ProtectionSpace):
(WebCore::ProtectionSpace::isHashTableDeletedValue):
* platform/network/ProtectionSpaceHash.h: Added.
(WebCore::ProtectionSpaceHash::hash):
(WebCore::ProtectionSpaceHash::equal):

Allow ResourceHandles to remember the initial credential they used:
* platform/network/ResourceHandleInternal.h:

Allow mutable ResourceRequests to update their platform object if HTTP header fields change:
* platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::addHTTPHeaderField):

Remove WebCoreCredentialStorage:
* platform/network/cf/AuthenticationCF.cpp:
* platform/network/cf/AuthenticationCF.h:
* platform/network/mac/AuthenticationMac.h:
* platform/network/mac/AuthenticationMac.mm:

Change ResourceHandleCFNet to try to use stored credentials on new connections, if appropriate:
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Only try the ProtectionSpace key'ed
  Credential if it does not match the initially used Credential.
(WebCore::ResourceHandle::receivedCredential):
(WebCore::WebCoreSynchronousLoader::didReceiveChallenge): Only try the ProtectionSpace key'ed
  Credential if it does not match the initially used Credential.
(WebCore::WebCoreSynchronousLoader::load):

Change ResourceHandleMac to try to use stored credentials on new connections, if appropriate:
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Only try the ProtectionSpace key'ed
  Credential if it does not match the initially used Credential.
(WebCore::ResourceHandle::receivedCredential):
(-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): Only try the
  ProtectionSpace key'ed Credential if it does not match the initially used Credential.
(+[WebCoreSynchronousLoader loadRequest:allowStoredCredentials:returningResponse:error:]):

Add base64-ability to CString:
* platform/text/CString.cpp:
(WebCore::CStringBuffer::base64Encode):
(WebCore::CString::base64Encode):
* platform/text/CString.h:
(WebCore::CStringBuffer::create):
(WebCore::CStringBuffer::CStringBuffer):

WebKit/mac:

Adopt the new WebCore::CredentialStorage in WebKit/Mac.

* Misc/WebDownload.mm:
(-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
* Plugins/WebBaseNetscapePluginView.mm:
(WebKit::getAuthenticationInfo):

WebKit/win:

Adopt the new WebCore::CredentialStorage in WebKit/Win.

* WebDownloadCFNet.cpp:
(WebDownload::didReceiveAuthenticationChallenge):

WebKitTools:

Add the ability for DRT to handle authentication challenges.

* DumpRenderTree/LayoutTestController.cpp:
(setAuthenticationPasswordCallback):
(setAuthenticationUsernameCallback):
(setHandlesAuthenticationChallengesCallback):
(LayoutTestController::staticFunctions):

* DumpRenderTree/LayoutTestController.h:
(LayoutTestController::handlesAuthenticationChallenges):
(LayoutTestController::setHandlesAuthenticationChallenges):
(LayoutTestController::authenticationUsername):
(LayoutTestController::setAuthenticationUsername):
(LayoutTestController::authenticationPassword):
(LayoutTestController::setAuthenticationPassword):

* DumpRenderTree/mac/ResourceLoadDelegate.mm:
(-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):

* DumpRenderTree/win/ResourceLoadDelegate.cpp:
(ResourceLoadDelegate::didReceiveAuthenticationChallenge):
* DumpRenderTree/win/ResourceLoadDelegate.h:

LayoutTests:

* http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt: Added.
* http/tests/loading/basic-auth-resend-wrong-credentials.html: Added.
* http/tests/loading/basic-credentials-sent-automatically-expected.txt: Added.
* http/tests/loading/basic-credentials-sent-automatically.html: Added.
* http/tests/loading/resources/basic-auth-testing.php: Added.
* http/tests/loading/resources/othersubresources: Added.
* http/tests/loading/resources/othersubresources/protected-resource.php: Added.
* http/tests/loading/resources/protected-resource.php: Added.
* http/tests/loading/resources/subresources: Added.
* http/tests/loading/resources/subresources/protected-resource.php: Added.
* http/tests/loading/resources/test2: Added.
* http/tests/loading/resources/test2/basic-auth-testing.php: Added.
* http/tests/loading/resources/test2/protected-resource.php: Added.
* platform/gtk/Skipped:
* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-14 Zan Dobersek <zandobersek@gmail.com>
kov@webkit.org [Mon, 14 Sep 2009 19:01:41 +0000 (19:01 +0000)]
2009-09-14  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by Gustavo Noronha.

        Add some tests that fail to the skipped list and rebaseline two tests
        to pass them.

        * platform/gtk/Skipped: Populate with more failing tests.
        * platform/gtk/fast/dom/Window/window-properties-expected.txt: Rebaseline.
        * platform/gtk/fast/dom/prototype-inheritance-2-expected.txt: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTest for <rdar://problem/6954546> and <rdar://problem/7090444>.
mrowe@apple.com [Mon, 14 Sep 2009 18:10:32 +0000 (18:10 +0000)]
Test for <rdar://problem/6954546> and <rdar://problem/7090444>.

Reviewed by Dan Bernstein.

WebKitTools:

Add a flag on the test plug-in that asks it to clear the document during the call to NPP_New.
This is the trigger for both <rdar://problem/6954546> and <rdar://problem/7090444>.

* DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
(NPP_New):

LayoutTests:

* plugins/destroy-during-npp-new-expected.txt: Added.
* plugins/destroy-during-npp-new.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix <rdar://problem/7090444> Crashes in-[WebBaseNetscapePluginView stop] handling...
mrowe@apple.com [Mon, 14 Sep 2009 18:10:27 +0000 (18:10 +0000)]
Fix <rdar://problem/7090444> Crashes in-[WebBaseNetscapePluginView stop] handling NSWindowWillCloseNotification.

Reviewed by Anders Carlsson.

It's not valid to call -addWindowObservers when the view is not in a window, but this can happen when -start
initializes a plug-in and the plug-in removes itself from the document during initialization.  -viewDidMoveToWindow
calls -start and then calls -addWindowObservers without ensuring that the view is still in a window.

If -[WebBaseNetscapePluginView addWindowObservers] is incorrectly called when the view is not in a window, it will
observe NSWindowWillCloseNotification on all windows.  This unexpected observer registration is not balanced by an
unregistration so the notification can be delivered after the view is deallocated, causing the crash seen in
<rdar://problem/7090444>.

* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView start]): Only call -updateAndSetWindow if we still have a current window.
(-[WebBaseNetscapePluginView viewDidMoveToWindow]): Remove unnecessary calls to -restartTimers and -addWindowObservers
from -[WebBaseNetscapePluginView viewDidMoveToWindow].  They are already called from within -start with the extra benefit
of ensuring that the view is still in a window when they are called.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix <rdar://problem/6954546> Crashes in WebCore::RenderPart::setWidget below FrameLoa...
mrowe@apple.com [Mon, 14 Sep 2009 18:10:23 +0000 (18:10 +0000)]
Fix <rdar://problem/6954546> Crashes in WebCore::RenderPart::setWidget below FrameLoader::loadPlugin.

Reviewed by Dan Bernstein.

The calls to FrameLoader::requestObject within RenderPartObject::updateWidget can result in a plug-in
being initialized.  This can run cause arbitrary JavaScript to run and may result in the RenderPartObject
being detached from the render tree and destroyed, causing a crash like <rdar://problem/6954546>.

No test is possible until <rdar://problem/7090444> is fixed

* rendering/RenderPartObject.cpp:
(WebCore::RenderPartObject::updateWidget): Ensure that we stay alive for the duration of plug-in initialization.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd RenderWidgetProtector to simplify protecting a RenderWidget from destruction...
mrowe@apple.com [Mon, 14 Sep 2009 18:10:19 +0000 (18:10 +0000)]
Add RenderWidgetProtector to simplify protecting a RenderWidget from destruction for the duration of a function.  Deploy it within RenderWidget.

Reviewed by Dan Bernstein.

* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidgetGeometry):
(WebCore::RenderWidget::updateWidgetPosition): Use a RefPtr rather than explicitly
ref'ing and deref'ing the node.
* rendering/RenderWidget.h:
* rendering/RenderWidgetProtector.h:
(WebCore::RenderWidgetProtector::RenderWidgetProtector):
(WebCore::RenderWidgetProtector::~RenderWidgetProtector):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-14 Jakub Wieczorek <faw217@gmail.com>
eric@webkit.org [Mon, 14 Sep 2009 17:26:46 +0000 (17:26 +0000)]
2009-09-14  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Simon Hausmann.

        [Qt] QWebGraphicsItem should check for null QWebPage.
        https://bugs.webkit.org/show_bug.cgi?id=29185

        Don't crash in QWebGraphicsItem when the page is still null, by
        either checking if it's the case or constructing the default one.

        * Api/qwebgraphicsitem.cpp:
        (QWebGraphicsItem::icon):
        (QWebGraphicsItem::setZoomFactor):
        (QWebGraphicsItem::zoomFactor):
        (QWebGraphicsItem::setGeometry):
        (QWebGraphicsItem::load):
        (QWebGraphicsItem::setHtml):
        (QWebGraphicsItem::toHtml):
        (QWebGraphicsItem::setContent):
        (QWebGraphicsItem::history):
        (QWebGraphicsItem::settings):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-14 Cameron McCormack <cam@mcc.id.au>
eric@webkit.org [Mon, 14 Sep 2009 17:19:07 +0000 (17:19 +0000)]
2009-09-14  Cameron McCormack  <cam@mcc.id.au>

        Reviewed by Eric Seidel.

        CodeGenerator.pm needs some cleaning up
        https://bugs.webkit.org/show_bug.cgi?id=29238

        * bindings/scripts/CodeGenerator.pm:
        (FindParentsRecursively): Removed; its functionality is now handled in
        AddMethodsConstantsAndAttributesFromParentClasses.
        (ForAllParents): New function that visits an interface's ancestors and
        invokes a callback for each one.
        (AddMethodsConstantsAndAttributesFromParentClasses): Simplified by using
        ForAllParents.
        (GetMethodsAndAttributesFromParentClasses): Ditto.
        (IDLFileForInterface): Factored out previous calls to ScanDirectory into
        this new function, which returns the filename containing a given IDL
        interface definition.
        (ParseInterface): Simplified by using IDLFileForInterface.
        (ScanDirectory): Removed in lieu of IDLFileForInterface.
        * bindings/scripts/CodeGeneratorV8.pm: Drop call to
        FindParentsRecursively and get the list of parents from the
        AddMethodsConstantsAndAttributesFromParentClasses call instead.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowx build fix for non-wxPython builds and a fix for errors when updating swig.py.
kevino@webkit.org [Mon, 14 Sep 2009 17:06:51 +0000 (17:06 +0000)]
wx build fix for non-wxPython builds and a fix for errors when updating swig.py.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Assert hit when dropping a file in QtLauncher
yael.aharon@nokia.com [Mon, 14 Sep 2009 14:46:26 +0000 (14:46 +0000)]
[Qt] Assert hit when dropping a file in QtLauncher
https://bugs.webkit.org/show_bug.cgi?id=29242

Patch by Yael Aharon <yael.aharon@nokia.com> on 2009-09-14
Reviewed by Tor Arne Vestbø.

Qt's implementation of DropData::asURL does not return a URL encoded string
as expected.

* platform/qt/DragDataQt.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Build fix for windows build.
vestbo@webkit.org [Mon, 14 Sep 2009 12:45:27 +0000 (12:45 +0000)]
[Qt] Build fix for windows build.

Patch by Csaba Osztrogonac <oszi@inf.u-szeged.hu> on 2009-09-14
Reviewed by Tor Arne Vestbø.

JavaScriptCore

* JavaScriptCore.pri: Correct a logic error.
* pcre/dftables: Add missing paranthesis for tmpdir function.

WebKitTools:

* Scripts/bisect-builds: Add missing paranthesis for tmpdir function.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowx build fix, file was missed during TLS.cpp removal.
kevino@webkit.org [Mon, 14 Sep 2009 05:47:33 +0000 (05:47 +0000)]
wx build fix, file was missed during TLS.cpp removal.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: Add "New Style Rule" to the localizedStrings
rik@webkit.org [Mon, 14 Sep 2009 02:29:12 +0000 (02:29 +0000)]
Web Inspector: Add "New Style Rule" to the localizedStrings
https://bugs.webkit.org/show_bug.cgi?id=29237

Patch by Anthony Ricaud <rik@webkit.org> on 2009-09-13
Reviewed by Oliver Hunt.

* English.lproj/localizedStrings.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix typo accidently landed in last commit.
kevino@webkit.org [Mon, 14 Sep 2009 02:03:17 +0000 (02:03 +0000)]
Fix typo accidently landed in last commit.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowx build fix, error out if using the wrong Python.
kevino@webkit.org [Mon, 14 Sep 2009 01:52:32 +0000 (01:52 +0000)]
wx build fix, error out if using the wrong Python.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Mon, 14 Sep 2009 01:32:47 +0000 (01:32 +0000)]
Reviewed by Kevin Ollivier.

Allow a way to set the cache policy via wx API.

https://bugs.webkit.org/show_bug.cgi?id=29200

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Mon, 14 Sep 2009 01:20:53 +0000 (01:20 +0000)]
Reviewed by Kevin Ollivier.

Allow the user to query Frame::shouldClose via wx API.

https://bugs.webkit.org/show_bug.cgi?id=29199

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Mon, 14 Sep 2009 01:12:38 +0000 (01:12 +0000)]
Reviewed by Kevin Ollivier.

Fix mouse handling when the mouse leaves the window during mouse down.

https://bugs.webkit.org/show_bug.cgi?id=29198

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Mon, 14 Sep 2009 01:04:29 +0000 (01:04 +0000)]
Reviewed by Kevin Ollivier.

Add support for console MessageLevel at wx API level.

https://bugs.webkit.org/show_bug.cgi?id=29197

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Mon, 14 Sep 2009 00:34:19 +0000 (00:34 +0000)]
Reviewed by Kevin Ollivier.

[wx] Implement filesystem functions.

https://bugs.webkit.org/show_bug.cgi?id=29196

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-13 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Sun, 13 Sep 2009 10:45:48 +0000 (10:45 +0000)]
2009-09-13  Xan Lopez  <xlopez@igalia.com>

        Build fix for GTK+ < 2.14.

        Do not use gtk_widget_get_window, access the window directly
        through the struct.

        * DumpRenderTree/gtk/EventSender.cpp:
        (contextClickCallback):
        (mouseDownCallback):
        (mouseUpCallback):
        (mouseMoveToCallback):
        (keyDownCallback):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-13 Martin Robinson <martin.james.robinson@gmail.com>
jmalonzo@webkit.org [Sun, 13 Sep 2009 10:23:16 +0000 (10:23 +0000)]
2009-09-13  Martin Robinson  <martin.james.robinson@gmail.com>

        Reviewed by Xan Lopez and Jan Alonzo.

        [GTK] EventSender does not set 'window' property on synthesized GDK events
        https://bugs.webkit.org/show_bug.cgi?id=29169

        Set the window property on synthesized GDK events in the GTK+ EventSender.

        * DumpRenderTree/gtk/EventSender.cpp:
        (contextClickCallback):
        (mouseDownCallback):
        (mouseUpCallback):
        (mouseMoveToCallback):
        (keyDownCallback):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowx build fixes for wx 2.9.
kevino@webkit.org [Sun, 13 Sep 2009 07:14:11 +0000 (07:14 +0000)]
wx build fixes for wx 2.9.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix for windows exports (again).
oliver@apple.com [Sun, 13 Sep 2009 03:24:12 +0000 (03:24 +0000)]
Build fix for windows exports (again).

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix for windows exports
oliver@apple.com [Sun, 13 Sep 2009 03:10:36 +0000 (03:10 +0000)]
Build fix for windows exports

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCorrect fix for non-allinonefile builds
oliver@apple.com [Sun, 13 Sep 2009 03:03:55 +0000 (03:03 +0000)]
Correct fix for non-allinonefile builds

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix non-allinonefile builds
oliver@apple.com [Sun, 13 Sep 2009 03:00:49 +0000 (03:00 +0000)]
Fix non-allinonefile builds

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[ES5] Implement Object.keys
oliver@apple.com [Sun, 13 Sep 2009 02:44:32 +0000 (02:44 +0000)]
[ES5] Implement Object.keys
https://bugs.webkit.org/show_bug.cgi?id=29170

Reviewed by Maciej Stachowiak.

This patch basically requires two separate steps, the first is to split getPropertyNames
into two functions -- getOwnPropertyNames and getPropertyNames, basically making them behave
in the same way as getOwnPropertySlot and getPropertySlot.  In essence getOwnPropertyNames
produces the list of properties on an object excluding its prototype chain and getPropertyNames
just iterates the the object and its prototype chain calling getOwnPropertyNames at each level.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agorun-webkit-tests has a timeout value that is too low
atwilson@chromium.org [Sun, 13 Sep 2009 01:17:03 +0000 (01:17 +0000)]
run-webkit-tests has a timeout value that is too low
https://bugs.webkit.org/show_bug.cgi?id=29223

Reviewed by Mark Rowe.

* Scripts/run-webkit-tests:
Changed timeout value to 20 seconds to avoid timing out too early.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=29219
weinig@apple.com [Sat, 12 Sep 2009 19:11:55 +0000 (19:11 +0000)]
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=29219
Document.elementFromPoint() should take page scroll into consideration

Reviewed by Anders Carlsson.

Test: fast/dom/elementFromPoint-relative-to-viewport.html

* dom/Document.cpp:
(WebCore::Document::elementFromPoint):
(WebCore::Document::caretRangeFromPoint):

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=29219
Document.elementFromPoint() should take page scroll into consideration

Reviewed by Anders Carlsson.

* fast/dom/elementFromPoint-relative-to-viewport-expected.txt: Added.
* fast/dom/elementFromPoint-relative-to-viewport.html: Added.
* fast/events/offsetX-offsetY.html: Change to use clientX/Y instead of pageX/Y.
* fast/forms/slider-transformed.html: Ditto.
* fast/forms/slider-zoomed.html: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=29217
weinig@apple.com [Sat, 12 Sep 2009 08:14:53 +0000 (08:14 +0000)]
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=29217
Document.caretRangeFromPoint should take the scroll offset into account before hit testing

Reviewed by Maciej Stachowiak.

In accordance with the CSSOM View Module spec, Document.caretRangeFromPoint should interpret
the point passed to it as relative to the viewport, not the document.

Test: fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html

* dom/Document.cpp:
(WebCore::Document::caretRangeFromPoint):

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=29217
Document.caretRangeFromPoint should take the scroll offset into account before hit testing

Reviewed by Maciej Stachowiak.

* fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt: Added.
* fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-11 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Sat, 12 Sep 2009 06:55:13 +0000 (06:55 +0000)]
2009-09-11  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Jan Alonzo.

        [GTK] Use gtk_style_set_background instead of gdk_window_set_background
        https://bugs.webkit.org/show_bug.cgi?id=29173

        Use gtk_style_set_background instead of gdk_window_set_background,
        as suggested by the documentation. Also, use GTK_STATE_NORMAL
        directly, since that's the default state of a GtkWidget.

        * webkit/webkitwebview.cpp:
        (webkit_web_view_realize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agogetPropertyNames caching is invalid when the prototype chain contains objects with...
oliver@apple.com [Sat, 12 Sep 2009 04:52:39 +0000 (04:52 +0000)]
getPropertyNames caching is invalid when the prototype chain contains objects with custom getPropertyNames
https://bugs.webkit.org/show_bug.cgi?id=29214

Reviewed by Sam Weinig.

Add a flag to TypeInfo to indicate whether a type overrides getPropertyNames.
This flag is used to make sure that caching of the property name data is safe.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Added some manual tests to show WebGL in action
cmarrin@apple.com [Sat, 12 Sep 2009 03:40:41 +0000 (03:40 +0000)]
    Added some manual tests to show WebGL in action
        https://bugs.webkit.org/show_bug.cgi?id=29215

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowx build fix. Mark dependencies as mandatory and declare which MSVC versions and
kevino@webkit.org [Sat, 12 Sep 2009 03:33:28 +0000 (03:33 +0000)]
wx build fix. Mark dependencies as mandatory and declare which MSVC versions and
architectures are supported for building wxWebKit.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoaria definition role spelled wrong "defintion"
cfleizach@apple.com [Sat, 12 Sep 2009 03:31:05 +0000 (03:31 +0000)]
aria definition role spelled wrong "defintion"
https://bugs.webkit.org/show_bug.cgi?id=28840

Reviewed by Darin Adler.

WebCore:

Test: accessibility/aria-slider-value-change.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::RoleEntry::):

LayoutTests:

* platform/mac/accessibility/aria-grouping-roles-expected.txt:
* platform/mac/accessibility/aria-grouping-roles.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-11 Erik Arvidsson <arv@chromium.org>
eric@webkit.org [Sat, 12 Sep 2009 02:17:57 +0000 (02:17 +0000)]
2009-09-11  Erik Arvidsson  <arv@chromium.org>

        Reviewed by Eric Seidel.

        Fixes an assert in Node::isFocusable which was causing crashes in certain cases.
        https://bugs.webkit.org/show_bug.cgi?id=29210

        * fast/events/resources/tab-is-focusable-assert.js:
        * fast/events/tab-is-focusable-assert-expected.txt: Added.
2009-09-11  Erik Arvidsson  <arv@chromium.org>

        Reviewed by Eric Seidel.

        Fixes an assert in Node::isFocusable which was causing crashes in certain cases.
        https://bugs.webkit.org/show_bug.cgi?id=29210

        * dom/Node.cpp:
        (WebCore::Node::isFocusable):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix <rdar://problem/7145242> Crashes inside WTF::HashTable below NetscapePluginInstan...
mrowe@apple.com [Sat, 12 Sep 2009 01:48:02 +0000 (01:48 +0000)]
Fix <rdar://problem/7145242> Crashes inside WTF::HashTable below NetscapePluginInstanceProxy::disconnectStream

Reviewed by Jon Honeycutt.

* Plugins/Hosted/HostedNetscapePluginStream.mm:
(WebKit::HostedNetscapePluginStream::cancelLoad): Canceling the load can result in calling through to disconnectStream.
If the plug-in instance holds the last reference to the plug-in stream this will result in the stream being deallocated.
This leads to HostedNetscapePluginStream::cancelLoad's call to disconnectStream being passed a deallocated stream object.
Since the stream was already disconnected by the call to cancel there's no need to call disconnectStream a second time.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Added variants to uniform* and vertexAttrib* calls which take sequence<>...
cmarrin@apple.com [Sat, 12 Sep 2009 00:13:32 +0000 (00:13 +0000)]
    Added variants to uniform* and vertexAttrib* calls which take sequence<> in place of CanvasArray
        https://bugs.webkit.org/show_bug.cgi?id=29139

        I also added a data() call to each of the CanvasArray subclasses to give back a types pointer
        to the baseAddress().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-11 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Sat, 12 Sep 2009 00:00:40 +0000 (00:00 +0000)]
2009-09-11  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Dan Bernstein.

        Properly propagate preference from WebPreferences to WebCore::Settings.
        https://bugs.webkit.org/show_bug.cgi?id=29192

        * WebView.cpp:
        (WebView::initWithFrame): Apply setting when creating a new WebView.
        (WebView::notifyPreferencesChanged): Apply setting when preferences change.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-11 Fumitoshi Ukai <ukai@chromium.org>
eric@webkit.org [Fri, 11 Sep 2009 23:59:38 +0000 (23:59 +0000)]
2009-09-11  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Eric Seidel.

        Add ENABLE(WEB_SOCKETS) guards.
        https://bugs.webkit.org/show_bug.cgi?id=29174

        * bindings/v8/custom/V8WebSocketCustom.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-11 Brian Weinstein <bweinstein@apple.com>
bweinstein@apple.com [Fri, 11 Sep 2009 23:57:45 +0000 (23:57 +0000)]
2009-09-11  Brian Weinstein  <bweinstein@apple.com>

        Rubber-stamped by Mark Rowe.

        Add the http/tests/security/mixedContent to the Skipped list while
        test failures are being investigated.

        * platform/win/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-11 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 11 Sep 2009 23:34:45 +0000 (23:34 +0000)]
2009-09-11  Eric Seidel  <eric@webkit.org>

        No review, rolling out r48229.
        http://trac.webkit.org/changeset/48229

        * fast/events/drag-dropeffect-expected.txt: Removed.
        * fast/events/drag-dropeffect.html: Removed.
2009-09-11  Eric Seidel  <eric@webkit.org>

        No review, rolling out r48229.
        http://trac.webkit.org/changeset/48229

        * WebCore.base.exp:
        * dom/Clipboard.cpp:
        (WebCore::Clipboard::Clipboard):
        (WebCore::Clipboard::sourceOperation):
        * page/DragController.cpp:
        (WebCore::DragController::DragController):
        (WebCore::DragController::dragExited):
        (WebCore::DragController::performDrag):
        (WebCore::DragController::dragEnteredOrUpdated):
        (WebCore::DragController::tryDHTMLDrag):
        (WebCore::DragController::startDrag):
        * page/DragController.h:
        * page/EventHandler.cpp:
        (WebCore::EventHandler::updateDragAndDrop):
        (WebCore::EventHandler::dragSourceMovedTo):
        (WebCore::EventHandler::handleDrag):
        * page/EventHandler.h:
2009-09-11  Eric Seidel  <eric@webkit.org>

        No review, rolling out r48229.
        http://trac.webkit.org/changeset/48229

        * WebView/WebFrame.mm:
        (-[WebFrame _dragSourceMovedTo:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-11 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 11 Sep 2009 23:28:12 +0000 (23:28 +0000)]
2009-09-11  Eric Seidel  <eric@webkit.org>

        Reviewed by David Levin.

        bugzilla-tool rollout threw exception under svn
        https://bugs.webkit.org/show_bug.cgi?id=29211

        * Scripts/modules/scm.py: add missing return, and convert number arguments to strings.
        * Scripts/modules/scm_unittest.py: add testing for this fix.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix the build.
mrowe@apple.com [Fri, 11 Sep 2009 22:18:44 +0000 (22:18 +0000)]
Fix the build.

2009-09-11  Michelangelo De Simone  <micdesim@gmail.com>

        Fix the build.

        * html/ValidityState.cpp:
        (WebCore::ValidityState::typeMismatch):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-11 Michelangelo De Simone <micdesim@gmail.com>
eric@webkit.org [Fri, 11 Sep 2009 22:01:03 +0000 (22:01 +0000)]
2009-09-11  Michelangelo De Simone  <micdesim@gmail.com>

        Reviewed by Antti Koivisto.

        https://bugs.webkit.org/show_bug.cgi?id=27456
        Test case for url validation in ValidityState.

        * fast/forms/ValidityState-typeMismatch-url-expected.txt: Added.
        * fast/forms/ValidityState-typeMismatch-url.html: Added.
        * fast/forms/resources/ValidityState-typeMismatch-url.js: Added.
        (check):
2009-09-11  Michelangelo De Simone  <micdesim@gmail.com>

        Reviewed by Antti Koivisto.

        https://bugs.webkit.org/show_bug.cgi?id=27456
        Added support for static validation of url in
        ValidityState, for url state inputs.
        From HTML5 specs:
        http://www.whatwg.org/specs/web-apps/current-work/#url-state

        Test: fast/forms/ValidityState-typeMismatch-url.html

        * html/ValidityState.cpp:
        (WebCore::ValidityState::typeMismatch):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-11 Evan Stade <estade@chromium.org>
eric@webkit.org [Fri, 11 Sep 2009 21:52:24 +0000 (21:52 +0000)]
2009-09-11  Evan Stade  <estade@chromium.org>

        Reviewed by Darin Adler.

        Revert r47992: Expose functions to change the focus ring color for
        Linux Chromium.

        As Darin Fisher has pointed out, there is a better way to do this.

        * rendering/RenderThemeChromiumLinux.cpp:
        (WebCore::RenderThemeChromiumLinux::RenderThemeChromiumLinux):
        * rendering/RenderThemeChromiumLinux.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-11 Brian Weinstein <bweinstein@apple.com>
bweinstein@apple.com [Fri, 11 Sep 2009 21:47:42 +0000 (21:47 +0000)]
2009-09-11  Brian Weinstein  <bweinstein@apple.com>

        Add myself to the committers list.

        * Scripts/modules/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Geoff Garen.
ap@apple.com [Fri, 11 Sep 2009 21:34:55 +0000 (21:34 +0000)]
    Reviewed by Geoff Garen.

        https://bugs.webkit.org/show_bug.cgi?id=29207
        Add checks for using WebCore JS context on secondary threads

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-11 Brian Weinstein <bweinstein@apple.com>
bweinstein@apple.com [Fri, 11 Sep 2009 20:21:29 +0000 (20:21 +0000)]
2009-09-11  Brian Weinstein  <bweinstein@apple.com>

        Reviewed by Timothy Hatcher.

        The inspector should have scope bars.
        https://bugs.webkit.org/show_bug.cgi?id=14353

        Add scope bars to the console, so the user can choose which category
        of messages they want to see (All, Errors, Warnings, Logs), and they
        can choose from one or more of {Errors, Warnings, Logs}.

        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.createFilterElement):
        (WebInspector.ConsoleView):
        (WebInspector.ConsoleView.prototype._updateFilter):
        (WebInspector.ConsoleView.prototype.filter):
        (WebInspector.ConsoleView.prototype.attach):
        * inspector/front-end/inspector.css:
        * inspector/front-end/inspector.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-11 Yusuke Sato <yusukes@chromium.org>
eric@webkit.org [Fri, 11 Sep 2009 20:09:13 +0000 (20:09 +0000)]
2009-09-11  Yusuke Sato  <yusukes@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Complex text doesn't show up with text stroking
        https://bugs.webkit.org/show_bug.cgi?id=28707

        Added extra NULL checks for HDC. This is the second fix for issue 28707,
        and the fix is similar to http://trac.webkit.org/changeset/45482.

        * platform/graphics/chromium/FontChromiumWin.cpp:
        (WebCore::Font::drawComplexText):
        * platform/graphics/chromium/UniscribeHelper.cpp:
        (WebCore::UniscribeHelper::draw):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-11 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 11 Sep 2009 19:05:58 +0000 (19:05 +0000)]
2009-09-11  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        bugzilla-tool land-patches should only fail-fast in --commit-queue mode
        https://bugs.webkit.org/show_bug.cgi?id=29201

        * Scripts/bugzilla-tool:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-11 Cameron McCormack <cam@mcc.id.au>
eric@webkit.org [Fri, 11 Sep 2009 18:47:48 +0000 (18:47 +0000)]
2009-09-11  Cameron McCormack  <cam@mcc.id.au>

        Reviewed by Eric Seidel.

        Make ElementTimeControl methods return void and not throw.
        https://bugs.webkit.org/show_bug.cgi?id=28831

        SVG 1.1 erratum:
        http://www.w3.org/2003/01/REC-SVG11-20030114-errata#elementtimecontrol-interface

        * svg/dom/smil-methods-expected.txt: Added.
        * svg/dom/smil-methods.svg: Added.
2009-09-11  Cameron McCormack  <cam@mcc.id.au>

        Reviewed by Eric Seidel.

        Make ElementTimeControl methods return void and not throw.
        https://bugs.webkit.org/show_bug.cgi?id=28831

        SVG 1.1 erratum:
        http://www.w3.org/2003/01/REC-SVG11-20030114-errata#elementtimecontrol-interface

        Test: svg/dom/smil-methods.svg

        * svg/ElementTimeControl.h: Change return type from bool to void and remove exception argument.
        * svg/ElementTimeControl.idl: Change return type from bool to void and remove raises claus.
        * svg/SVGAnimationElement.cpp:
        (WebCore::SVGAnimationElement::beginElement): Change return type from bool to void and remove exception argument.
        (WebCore::SVGAnimationElement::beginElementAt): Ditto.
        (WebCore::SVGAnimationElement::endElement): Ditto.
        (WebCore::SVGAnimationElement::endElementAt): Ditto.
        * svg/SVGAnimationElement.h: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Added support for texImage2D which takes CanvasArray
cmarrin@apple.com [Fri, 11 Sep 2009 18:31:22 +0000 (18:31 +0000)]
    Added support for texImage2D which takes CanvasArray
        https://bugs.webkit.org/show_bug.cgi?id=29191

        * bindings/js/JSCanvasRenderingContext3DCustom.cpp:
        (WebCore::JSCanvasRenderingContext3D::texImage2D):
        * platform/graphics/mac/GraphicsContext3DMac.cpp:
        (WebCore::GraphicsContext3D::texImage2D):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-11 David Kilzer <ddkilzer@apple.com>
wsiegrist@apple.com [Fri, 11 Sep 2009 18:15:22 +0000 (18:15 +0000)]
2009-09-11 David Kilzer <ddkilzer@apple.com>

Apply fix for http://www.bugzilla.org/security/3.0.8/

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore: Allow WebKit clients to opt out of high resolution timers on Windows.
sfalken@apple.com [Fri, 11 Sep 2009 18:04:24 +0000 (18:04 +0000)]
WebCore: Allow WebKit clients to opt out of high resolution timers on Windows.
https://bugs.webkit.org/show_bug.cgi?id=29192

Reviewed by Darin Adler.

* page/Settings.cpp:
(WebCore::Settings::setShouldUseHighResolutionTimers): Added.
* page/Settings.h: Added getter/setter for shouldUseHighResolutionTimers.
(WebCore::Settings::shouldUseHighResolutionTimers): Added.
* platform/win/SharedTimerWin.cpp:
(WebCore::setSharedTimerFireTime): Don't run high resolution timer code if it is disabled.

WebKit/win: Allow WebKit clients to opt out of high resolution timers on Windows.
https://bugs.webkit.org/show_bug.cgi?id=29192

Reviewed by Darin Adler.

* Interfaces/IWebPreferencesPrivate.idl: Added getter/setter.
Put this just after last 4.0.3 method for future merging.
* Interfaces/WebKit.idl: Touched to force a rebuild.
* WebPreferenceKeysPrivate.h: Added prefs key for high res timers.
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings): Initialize high res timers to enabled.
(WebPreferences::setShouldUseHighResolutionTimers): Added.
(WebPreferences::shouldUseHighResolutionTimers): Added.
* WebPreferences.h: Added getter/setter.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMake commit-log-editor move common prefixes to the top of the log
aroben@apple.com [Fri, 11 Sep 2009 18:03:21 +0000 (18:03 +0000)]
Make commit-log-editor move common prefixes to the top of the log

Fies <http://webkit.org/b/29190> commit-log-editor should move common
prefixes to the top of the commit log

Reviewed by Darin Adler.

* Scripts/commit-log-editor: Find and remove the longest common prefix
ending in a double newline from each ChangeLog entry, then put that
common prefix at the top of the commit log.
(removeLongestCommonPrefixEndingInDoubleNewline): Added. Finds,
removes, and returns the longest common prefix ending in a double
newline from a hash of strings

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-11 Christian Plesner Hansen <christian.plesner.hansen@gmail.com>
eric@webkit.org [Fri, 11 Sep 2009 17:59:14 +0000 (17:59 +0000)]
2009-09-11  Christian Plesner Hansen  <christian.plesner.hansen@gmail.com>

        Reviewed by Adam Barth.

        [v8] Share persistent context handles between events
        Change events to use a single ref-counted shared persistent handle
        to the context in which to run, rather than create a new
        persistent handle for each new event which puts pressure on the
        gc.

        https://bugs.webkit.org/show_bug.cgi?id=29077

        * bindings/v8/ScheduledAction.cpp:
        (WebCore::ScheduledAction::execute):
        * bindings/v8/SharedPersistent.h: Added.
        (WebCore::SharedPersistent::set):
        (WebCore::SharedPersistent::get):
        (WebCore::SharedPersistent::disposeHandle):
        (WebCore::SharedPersistent::create):
        (WebCore::SharedPersistent::SharedPersistent):
        * bindings/v8/V8AbstractEventListener.cpp:
        (WebCore::V8AbstractEventListener::V8AbstractEventListener):
        (WebCore::V8AbstractEventListener::handleEvent):
        * bindings/v8/V8AbstractEventListener.h:
        * bindings/v8/V8IsolatedWorld.cpp:
        (WebCore::V8IsolatedWorld::V8IsolatedWorld):
        (WebCore::V8IsolatedWorld::~V8IsolatedWorld):
        * bindings/v8/V8IsolatedWorld.h:
        (WebCore::V8IsolatedWorld::context):
        (WebCore::V8IsolatedWorld::shared_context):
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::evaluateInNewContext):
        (WebCore::V8Proxy::createWrapperFromCacheSlowCase):
        (WebCore::V8Proxy::isContextInitialized):
        (WebCore::V8Proxy::updateDocumentWrapperCache):
        (WebCore::V8Proxy::clearDocumentWrapperCache):
        (WebCore::V8Proxy::disposeContextHandles):
        (WebCore::V8Proxy::clearForClose):
        (WebCore::V8Proxy::clearForNavigation):
        (WebCore::V8Proxy::setSecurityToken):
        (WebCore::V8Proxy::updateDocument):
        (WebCore::V8Proxy::initContextIfNeeded):
        (WebCore::V8Proxy::shared_context):
        (WebCore::V8Proxy::mainWorldContext):
        (WebCore::V8Proxy::setContextDebugId):
        * bindings/v8/V8Proxy.h:
        (WebCore::V8Proxy::V8Proxy):
        (WebCore::V8Proxy::context):
        (WebCore::V8Proxy::shared_context):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-11 Anton Muhin <antonm@chromium.org>
eric@webkit.org [Fri, 11 Sep 2009 17:20:34 +0000 (17:20 +0000)]
2009-09-11  Anton Muhin  <antonm@chromium.org>

        Reviewed by David Levin.

        Create a real handle (one which would save an object from GC).
        https://bugs.webkit.org/show_bug.cgi?id=29150

        * bindings/v8/V8Binding.cpp:
        (WebCore::v8ExternalString):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-11 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 11 Sep 2009 17:12:05 +0000 (17:12 +0000)]
2009-09-11  Eric Seidel  <eric@webkit.org>

        Fix obvious typo in previous commit, no review.

        bugzilla-tool should automate rollouts
        https://bugs.webkit.org/show_bug.cgi?id=26715

        * Scripts/bugzilla-tool: add back missing "scm" argument.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-11 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 11 Sep 2009 16:54:42 +0000 (16:54 +0000)]
2009-09-11  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        bugzilla-tool should automate rollouts
        https://bugs.webkit.org/show_bug.cgi?id=26715

        bugzilla-tool rollout will do the rollout locally and leave the diff for you to verify and commit.
        The --complete-rollout option will automatically land and update the bug.
        Eventually --complete-rollout will be default, but that will require more testing.

        This first pass is good enough for others to try and file bugs about.

        * Scripts/bugzilla-tool:
         - Move modified_changelogs into scm.py.
         - Move svn_revision_from_commit_text logic into scm.py.
         - Add RolloutCommit command.
        * Scripts/modules/bugzilla.py:
         - Add reopen_bug command used by RolloutCommit.
        * Scripts/modules/scm.py:
         - Add functions to support RolloutCommit.
         - Abstract find_uuid into value_from_svn_info so it can be re-used for _repository_url (needed by svn merge).
         - Add a str() call so that svn_commit_log can take a numeric argument.
         - Remove a bunch of very slow code from last_svn_commit_log and used the built-in 'BASE' alias instead.
         - Made dry_run commits return something that svn_revision_from_commit_text can parse.
        * Scripts/modules/scm_unittest.py:
         - Add read_from_path for easy file reading.
         - Put test4 on a new line to make reverts work w/o conflict.
         - Add an "svn update" call so that the checkout revision matches the server revision.
         - Add tests for svn_revision_from_commit_text.
         - Add a simple test for apply_reverse_diff.
         - Add a new self.scm member and use it in the new tests (eventually other tests can use it too).
         - Add test for svn_commit_log to make sure my 'BASE' change above worked as expected.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoGet user script/stylesheet tests running on Windows
aroben@apple.com [Fri, 11 Sep 2009 16:35:16 +0000 (16:35 +0000)]
Get user script/stylesheet tests running on Windows

Fixes <http://webkit.org/b/29181> User script/stylesheet tests are
skipped on Windows

Reviewed by John Sullivan.

WebKit/win:

* Interfaces/IWebViewPrivate.idl: Added addUserScriptToGroup,
addUserStyleSheetToGroup, removeUserContentFromGroup,
removeAllUserContentFromGropu to match the Mac SPI.

* WebView.cpp:
(WebView::addUserScriptToGroup):
(WebView::addUserStyleSheetToGroup):
(WebView::removeUserContentFromGroup):
(WebView::removeAllUserContentFromGroup):
* WebView.h:
Added. Implementation was based on similar methods in WebView.mm.

WebKitTools:

* DumpRenderTree/win/DumpRenderTree.vcproj: Link all configurations
against comsuppw.lib so we can use _bstr_t.

* DumpRenderTree/win/LayoutTestControllerWin.cpp: Fixed #include
order, added #include of comutil.h for _bstr_t.

(bstrT): Helper function to convert a JSStringRef to a _bstr_t.
(LayoutTestController::addUserScript):
(LayoutTestController::addUserStyleSheet):
Implemented. Implementations were based on those in
LayoutTestControllerMac.mm.

LayoutTests:

* platform/win/Skipped: Removed the userscripts directory.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-11 Anton Muhin <antonm@chromium.org>
eric@webkit.org [Fri, 11 Sep 2009 14:47:27 +0000 (14:47 +0000)]
2009-09-11  Anton Muhin  <antonm@chromium.org>

        Reviewed by David Levin.

        Inline WebCore::v8String as it only invokes WebCore::v8ExternalString.
        https://bugs.webkit.org/show_bug.cgi?id=29152

        * bindings/v8/V8Binding.cpp:
        * bindings/v8/V8Binding.h:
        (WebCore::v8String):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-11 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
eric@webkit.org [Fri, 11 Sep 2009 13:29:25 +0000 (13:29 +0000)]
2009-09-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>

        Reviewed by Simon Hausmann.

        Compiling JavaScriptCore on sparc 64 with gcc fails.

        ThreadSafeShared uses the atomic __gnu_cxx::__exchange_and_add with an int,
        however on sparc 64 the _Atomic_word argument is typedefed to long (8 bytes).

        The patch disables WTF_USE_LOCKFREE_THREADSAFESHARED in ThreadSafeShared to use
        a mutex instead when compiling for sparc 64 with gcc.

        https://bugs.webkit.org/show_bug.cgi?id=29175

        * wtf/Platform.h:
        __sparc64__ is not defined on all OS.
        Uses instead: __sparc__ && __arch64__ || __sparcv9
        * wtf/Threading.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoDoc: Note that Netscape plugins are only available on desktop platforms.
hausmann@webkit.org [Fri, 11 Sep 2009 12:58:29 +0000 (12:58 +0000)]
Doc: Note that Netscape plugins are only available on desktop platforms.

Patch by David Boddie <dboddie@trolltech.com> on 2009-09-11
Reviewed by Simon Hausmann.

* docs/qtwebkit.qdoc:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix compile error on Windows7(64Bit) with latest SDK.
hausmann@webkit.org [Fri, 11 Sep 2009 12:58:22 +0000 (12:58 +0000)]
Fix compile error on Windows7(64Bit) with latest SDK.

Patch by Prasanth Ullattil <prasanth.ullattil@nokia.com> on 2009-09-11
Reviewed by Simon Hausmann.

Added the missing include file.

* runtime/UString.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdjust the name of the contentspage for the documentation
hausmann@webkit.org [Fri, 11 Sep 2009 12:58:15 +0000 (12:58 +0000)]
Adjust the name of the contentspage for the documentation
to the new name used in Qt 4.6.

Patch by Martin Smith <msmith@trolltech.com> on 2009-09-11
Reviewed by Simon Hausmann.

* docs/qtwebkit.qdoc:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoQt/Windows CE compile fix, include the executable allocator and
hausmann@webkit.org [Fri, 11 Sep 2009 12:58:08 +0000 (12:58 +0000)]
Qt/Windows CE compile fix, include the executable allocator and
markstack implementation in the windows build.

Patch by Joerg Bornemann <joerg.bornemann@trolltech.com> on 2009-09-11
Reviewed by Simon Hausmann.

* JavaScriptCore.pri:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48296 268f45cc-cd09-0410-ab3c-d52691b4dbfc