WebKit.git
9 years ago2010-08-09 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Mon, 9 Aug 2010 08:49:47 +0000 (08:49 +0000)]
2010-08-09  Shinichiro Hamaji  <hamaji@chromium.org>

        Update chromium's expectation.

        * platform/chromium/test_expectations.txt: Mark fast/parser/residual-style-hang as a slow test.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-09 François Sausset <sausset@gmail.com>
eric@webkit.org [Mon, 9 Aug 2010 07:53:33 +0000 (07:53 +0000)]
2010-08-09  François Sausset  <sausset@gmail.com>

        Reviewed by Kenneth Rohde Christiansen.

        Add a test for the mfenced MathML element and update tests with stretched parenthesis/brackets/operators
        https://bugs.webkit.org/show_bug.cgi?id=42472

        * mathml/presentation/fenced.xhtml: Added.
        * mathml/presentation/row.xhtml:
        * platform/mac/mathml/presentation/fenced-expected.checksum: Added.
        * platform/mac/mathml/presentation/fenced-expected.png: Added.
        * platform/mac/mathml/presentation/fenced-expected.txt: Added.
        * platform/mac/mathml/presentation/mo-expected.checksum:
        * platform/mac/mathml/presentation/mo-expected.png:
        * platform/mac/mathml/presentation/mo-expected.txt:
        * platform/mac/mathml/presentation/over-expected.checksum:
        * platform/mac/mathml/presentation/over-expected.png:
        * platform/mac/mathml/presentation/over-expected.txt:
        * platform/mac/mathml/presentation/row-alignment-expected.checksum:
        * platform/mac/mathml/presentation/row-alignment-expected.png:
        * platform/mac/mathml/presentation/row-alignment-expected.txt:
        * platform/mac/mathml/presentation/row-expected.checksum:
        * platform/mac/mathml/presentation/row-expected.png:
        * platform/mac/mathml/presentation/row-expected.txt:
        * platform/mac/mathml/presentation/tables-expected.checksum:
        * platform/mac/mathml/presentation/tables-expected.png:
2010-08-09  François Sausset  <sausset@gmail.com>

        Reviewed by Kenneth Rohde Christiansen.

        Implement mfenced MathML element
        Update stretchy operator code to take into account new brackets and to tune layout parameters
        https://bugs.webkit.org/show_bug.cgi?id=42472

        Test: mathml/presentation/fenced.xhtml

        * WebCore.xcodeproj/project.pbxproj:
        * mathml/MathMLInlineContainerElement.cpp:
        (WebCore::MathMLInlineContainerElement::MathMLInlineContainerElement):
        (WebCore::MathMLInlineContainerElement::createRenderer):
        * mathml/RenderMathMLFenced.cpp: Added.
        (WebCore::RenderMathMLFenced::RenderMathMLFenced):
        (WebCore::RenderMathMLFenced::updateFromElement):
        (WebCore::RenderMathMLFenced::makeOperatorStyle):
        (WebCore::RenderMathMLFenced::makeFences):
        (WebCore::RenderMathMLFenced::addChild):
        (WebCore::RenderMathMLFenced::layout):
        * mathml/RenderMathMLFenced.h: Added.
        * mathml/RenderMathMLOperator.cpp:
        (WebCore::RenderMathMLOperator::RenderMathMLOperator):
        (WebCore::RenderMathMLOperator::stretchToHeight):
        (WebCore::):
        (WebCore::RenderMathMLOperator::updateFromElement):
        (WebCore::RenderMathMLOperator::createStackableStyle):
        (WebCore::RenderMathMLOperator::createGlyph):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-08 ryuan choi <ryuan.choi@samsung.com>
eric@webkit.org [Mon, 9 Aug 2010 06:56:22 +0000 (06:56 +0000)]
2010-08-08  ryuan choi  <ryuan.choi@samsung.com>

        Reviewed by Darin Adler.

        REGRESSION(64898,64949) build break because of wrong filename
        https://bugs.webkit.org/show_bug.cgi?id=43701

        add SVGPathStringSource.cpp and modify SVGPathSourceString.cpp to
        SVGPathStringSource.cpp

        simple fixing build break, so No new tests.

        * CMakeLists.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-08 Ariya Hidayat <ariya@sencha.com>
ariya@webkit.org [Mon, 9 Aug 2010 05:47:58 +0000 (05:47 +0000)]
2010-08-08  Ariya Hidayat  <ariya@sencha.com>

        Reviewed by Antonio Gomes.

        Inconsistent Qt version checks
        https://bugs.webkit.org/show_bug.cgi?id=43695

        Use QT_VERSION_CHECK macro instead of encoded hex.

        * Api/qgraphicswebview.cpp:
        (QGraphicsWebView::QGraphicsWebView):
        (QGraphicsWebViewPrivate::detachCurrentPage):
        * Api/qwebframe.cpp:
        (QWebFrame::load):
        * Api/qwebpage.cpp:
        (QWebPagePrivate::QWebPagePrivate):
        (QWebPagePrivate::inputMethodEvent):
        (QWebPage::inputMethodQuery):
        (QWebPage::view):
        * Api/qwebview.cpp:
        (QWebViewPrivate::detachCurrentPage):
        * WebCoreSupport/EditorClientQt.cpp:
        (WebCore::EditorClientQt::setInputMethodState):
        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::createPlugin):
        * WebCoreSupport/PageClientQt.cpp:
        * WebCoreSupport/PageClientQt.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-08 Csaba Osztrogonác <ossy@webkit.org>
ossy@webkit.org [Mon, 9 Aug 2010 05:43:49 +0000 (05:43 +0000)]
2010-08-08  Csaba Osztrogonác  <ossy@webkit.org>

        Reviewed by Antonio Gomes.

        Web Inspector: Fix warning in WebCore/inspector/InspectorDebuggerAgent.cpp
        https://bugs.webkit.org/show_bug.cgi?id=43698

        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::editScriptSource): Add suggested parentheses.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-04 MORITA Hajime <morrita@google.com>
morrita@google.com [Mon, 9 Aug 2010 05:26:47 +0000 (05:26 +0000)]
2010-08-04  MORITA Hajime  <morrita@google.com>

        Reviewed by Tony Chang.

        Pasting should fire textInput event.
        https://bugs.webkit.org/show_bug.cgi?id=42958

        * editing/pasteboard/paste-text-events-expected.txt: Added.
        * editing/pasteboard/paste-text-events.html: Added.
        * editing/pasteboard/script-tests/paste-text-events.js: Added.
2010-08-05  MORITA Hajime  <morrita@google.com>

        Reviewed by Tony Chang.

        Pasting should fire textInput event.
        https://bugs.webkit.org/show_bug.cgi?id=42958

        - Extended TextEvents to hold paste-specific parameters
        - Did fire TextEvents at where we originally did immediate pastes.
        - Factored out TextEvent handling from EventHandler::defaultTextInputEventHandler()
          to Editor::handleTextEvent() because it's solely done by the editor.
        - move actual pasting logic to Editor::handleTextEvent()

        Test: editing/pasteboard/paste-text-events.html

        * WebCore.exp.in:
        * dom/TextEvent.cpp:
        (WebCore::TextEvent::create):
        (WebCore::TextEvent::createForPlainTextPaste):
        (WebCore::TextEvent::createForFragmentPaste):
        (WebCore::TextEvent::TextEvent):
        * dom/TextEvent.h:
        (WebCore::TextEvent::isPaste):
        (WebCore::TextEvent::shouldSmartReplace):
        (WebCore::TextEvent::shouldMatchStyle):
        (WebCore::TextEvent::pastingFragment):
        * editing/Editor.cpp:
        (WebCore::Editor::handleTextEvent):
        (WebCore::Editor::pasteAsPlainText):
        (WebCore::Editor::pasteAsFragment):
        (WebCore::Editor::pasteAsPlainTextWithPasteboard):
        (WebCore::Editor::pasteWithPasteboard):
        (WebCore::Editor::dispatchCPPEvent):
        (WebCore::Editor::findEventTargetFromSelection):
        * editing/Editor.h:
        * page/EventHandler.cpp:
        (WebCore::EventHandler::defaultTextInputEventHandler):
2010-08-04  MORITA Hajime  <morrita@google.com>

        Reviewed by Tony Chang.

        Pasting should fire textInput event.
        https://bugs.webkit.org/show_bug.cgi?id=42958

        On paste, invoke Editor instead of direct command invocation,
        which allows dispatching events before actual paste.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-05 MORITA Hajime <morrita@google.com>
morrita@google.com [Mon, 9 Aug 2010 04:29:38 +0000 (04:29 +0000)]
2010-08-05  MORITA Hajime  <morrita@google.com>

        Reviewed by Tony Chang.

        Should have test: textInput should not fired when preceding key events are cancelled.
        https://bugs.webkit.org/show_bug.cgi?id=43601

        * fast/events/inputText-never-fired-on-keydown-cancel-expected.txt: Added.
        * fast/events/inputText-never-fired-on-keydown-cancel.html: Added.
        * fast/events/script-tests/inputText-never-fired-on-keydown-cancel.js: Added.
        (handleTextInput):
        (mayCancel):
        (setup):
        (test):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-08 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Mon, 9 Aug 2010 04:05:21 +0000 (04:05 +0000)]
2010-08-08  Kent Tamura  <tkent@chromium.org>

        Unreviewed, trivial fix.

        Fix "WindowsError: [Error 32] The process cannot access the file
        because it is being used by another process" introduced by r64959.

        * BuildSlaveSupport/test-result-archive:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-08 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Mon, 9 Aug 2010 02:16:27 +0000 (02:16 +0000)]
2010-08-08  Kent Tamura  <tkent@chromium.org>

        Unreviewed, test expectation update

        * platform/chromium/drt_expectations.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChromium buildbot: Avoid "zip" command dependency
tkent@chromium.org [Mon, 9 Aug 2010 01:26:16 +0000 (01:26 +0000)]
Chromium buildbot: Avoid "zip" command dependency
https://bugs.webkit.org/show_bug.cgi?id=43470

Reviewed by Tony Chang.

* BuildSlaveSupport/test-result-archive:
 For Chromium port, creates a zip archive with zipfile package of Python
 instead of external "zip" command. We'd like to avoid additional
 command installation.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Build fix, add member needed to compile Mac-specific font code.
kevino@webkit.org [Mon, 9 Aug 2010 01:12:00 +0000 (01:12 +0000)]
[wx] Build fix, add member needed to compile Mac-specific font code.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-08 Csaba Osztrogonác <ossy@webkit.org>
ossy@webkit.org [Sun, 8 Aug 2010 22:27:23 +0000 (22:27 +0000)]
2010-08-08  Csaba Osztrogonác  <ossy@webkit.org>

        Reviewed by Eric Seidel.

        [Qt] Fix warnings in WebCore/platform/WindowsKeyboardCodes.h
        https://bugs.webkit.org/show_bug.cgi?id=43360

        * platform/WindowsKeyboardCodes.h: Undef macros which are also defined in MinGW/include/winuser.h to aviod gcc redefinition warning

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-08 James Robinson <jamesr@chromium.org>
jamesr@google.com [Sun, 8 Aug 2010 20:30:08 +0000 (20:30 +0000)]
2010-08-08  James Robinson  <jamesr@chromium.org>

        Unreviewed.  Rebaseline chromium results for r64954.

        * platform/chromium-linux/fast/forms/formmove3-expected.txt:
        * platform/chromium-win/fast/forms/formmove3-expected.txt:
        * platform/chromium-win/fast/forms/preserveFormDuringResidualStyle-expected.txt:
        * platform/chromium-win/fast/invalid/003-expected.txt:
        * platform/chromium-win/fast/invalid/019-expected.txt:
        * platform/chromium-win/tables/mozilla/bugs/bug647-expected.txt:
        * platform/chromium-win/tables/mozilla/other/wa_table_tr_align-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd more items to WebKit2 skipped list.
mjs@apple.com [Sun, 8 Aug 2010 20:24:45 +0000 (20:24 +0000)]
Add more items to WebKit2 skipped list.

Rubber stamped by Sam Weinig.

* platform/mac-wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-08 James Robinson <jamesr@chromium.org>
jamesr@google.com [Sun, 8 Aug 2010 19:29:54 +0000 (19:29 +0000)]
2010-08-08  James Robinson  <jamesr@chromium.org>

        Reviewed by Adam Barth.

        Set the shouldLazyAttach flag to true in the tree builder's adoption agency algorithm
        https://bugs.webkit.org/show_bug.cgi?id=43610

        Sets the shouldLazyAttach flag to true for appendChild() calls inside the HTML tree
        builder's adoption agency flag.  This is a speedup assuming that nodes subjected
        to the adoption agency are likely to be frequently reparented, and thus it is better
        to delay creating the render tree until later (when hopefully the DOM is finalized).

        On my mac pro this speeds up fast/parser/residual-style-hang.html by 2.6X.

        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
2010-08-08  James Robinson  <jamesr@chromium.org>

        Reviewed by Adam Barth.

        Set the shouldLazyAttach flag to true in the tree builder's adoption agency algorithm
        https://bugs.webkit.org/show_bug.cgi?id=43610

        New baselines for tests where the render tree depends on 0x0 render objects being
        created/destroyed during adoption agency fixups.

        * platform/mac/fast/forms/formmove3-expected.txt:
        * platform/mac/fast/forms/preserveFormDuringResidualStyle-expected.txt:
        * platform/mac/fast/invalid/003-expected.txt:
        * platform/mac/fast/invalid/019-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug647-expected.txt:
        * platform/mac/tables/mozilla/other/wa_table_tr_align-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-08 Mihai Parparita <mihaip@chromium.org>
eric@webkit.org [Sun, 8 Aug 2010 17:56:08 +0000 (17:56 +0000)]
2010-08-08  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Adam Barth.

        fast/events/onunload-back-to-page-cache.html does not pass with GTK DRT
        https://bugs.webkit.org/show_bug.cgi?id=43692

        Update onunload-back-to-page-cache.html to set the frame name later,
        so that the onunload handler console message doesn't have it. Also
        include a message about what exactly we're testing.

        * fast/events/onunload-back-to-page-cache-expected.txt:
        * fast/events/script-tests/onunload-back-to-page-cache.js:
        (onpageshow):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-08 Nikita Vasilyev <me@elv1s.ru>
eric@webkit.org [Sun, 8 Aug 2010 17:45:22 +0000 (17:45 +0000)]
2010-08-08  Nikita Vasilyev  <me@elv1s.ru>

        Reviewed by Pavel Feldman.

        Web Inspector: speed-up Element.prototype.removeChildren
        https://bugs.webkit.org/show_bug.cgi?id=43687

        * inspector/front-end/utilities.js:
        (Element.prototype.removeChildren):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-08 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Sun, 8 Aug 2010 16:47:39 +0000 (16:47 +0000)]
2010-08-08  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        WebInspector: remove hand written InspectorFrontend from almost all places.
        https://bugs.webkit.org/show_bug.cgi?id=43630

        * inspector/ConsoleMessage.cpp:
        * inspector/InjectedScriptHost.cpp:
        (WebCore::InjectedScriptHost::pushNodePathToFrontend):
        * inspector/InjectedScriptHost.h:
        * inspector/Inspector.idl:
        * inspector/InspectorBackend.cpp:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::inspectedPageDestroyed):
        (WebCore::InspectorController::inspect):
        (WebCore::InspectorController::focusNode):
        (WebCore::InspectorController::windowVisible):
        (WebCore::InspectorController::addConsoleMessage):
        (WebCore::InspectorController::inspectedWindowScriptObjectCleared):
        (WebCore::InspectorController::setSearchingForNode):
        (WebCore::InspectorController::setMonitoringXHR):
        (WebCore::InspectorController::connectFrontend):
        (WebCore::InspectorController::show):
        (WebCore::InspectorController::showPanel):
        (WebCore::InspectorController::close):
        (WebCore::InspectorController::disconnectFrontend):
        (WebCore::InspectorController::populateScriptObjects):
        (WebCore::InspectorController::didCommitLoad):
        (WebCore::InspectorController::enableResourceTracking):
        (WebCore::InspectorController::disableResourceTracking):
        (WebCore::InspectorController::startTimelineProfiler):
        (WebCore::InspectorController::stopTimelineProfiler):
        (WebCore::InspectorController::postWorkerNotificationToFrontend):
        (WebCore::InspectorController::didCreateWorker):
        (WebCore::InspectorController::didDestroyWorker):
        (WebCore::InspectorController::toggleRecordButton):
        (WebCore::InspectorController::enableProfiler):
        (WebCore::InspectorController::disableProfiler):
        (WebCore::InspectorController::enableDebuggerFromFrontend):
        (WebCore::InspectorController::enableDebugger):
        (WebCore::InspectorController::disableDebugger):
        (WebCore::InspectorController::evaluateForTestInFrontend):
        * inspector/InspectorFrontend.cpp:
        * inspector/InspectorFrontend.h:
        * inspector/InspectorFrontendClientLocal.cpp:
        * inspector/TimelineRecordFactory.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry to fix the Chromium Mac build after r64915.
mitz@apple.com [Sun, 8 Aug 2010 16:41:58 +0000 (16:41 +0000)]
Try to fix the Chromium Mac build after r64915.

* platform/graphics/chromium/FontPlatformDataChromiumMac.mm:
(WebCore::FontPlatformData::ctFont): Copied from mac/FontPlatformDataMac.mm.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-08 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Sun, 8 Aug 2010 16:10:48 +0000 (16:10 +0000)]
2010-08-08  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Add missing String builder for SVGPathParser
        https://bugs.webkit.org/show_bug.cgi?id=43682

        Introduces SVGPathStringBuilder. SVGPathParser clients, like normalized and unaltered
        SVGPathSegLists or SVGPathByteStreams, can be parsed and transformed to a string.
        StringBuilder can create a string of individual strings, seperated by spaces now.
        Share more code in SVGPathParserFactory and use a common general concept to manage SVG path
        data parsing.

        Doesn't affect any tests.

        * Android.mk:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/text/StringBuilder.cpp:
        (WebCore::StringBuilder::toString): Added possibility to use a space between individual strings.
        * platform/text/StringBuilder.h: Cleanup according to WebKit style.
        (WebCore::):
        (WebCore::StringBuilder::StringBuilder):
        (WebCore::StringBuilder::setNonNull):
        (WebCore::StringBuilder::isNull):
        * svg/SVGAllInOne.cpp:
        * svg/SVGPathBuilder.h:
        (WebCore::SVGPathBuilder::cleanup): Clear all references.
        * svg/SVGPathByteStreamBuilder.h:
        (WebCore::SVGPathByteStreamBuilder::cleanup): dito.
        * svg/SVGPathConsumer.h:
        * svg/SVGPathParser.cpp:
        (WebCore::SVGPathParser::cleanup): dito.
        * svg/SVGPathParser.h:
        * svg/SVGPathParserFactory.cpp: Cleanup of factory. More code get shared.
        (WebCore::globalSVGPathBuilder):
        (WebCore::globalSVGPathSegListBuilder):
        (WebCore::globalSVGPathByteStreamBuilder):
        (WebCore::globalSVGPathStringBuilder):
        (WebCore::globalSVGPathParser):
        (WebCore::SVGPathParserFactory::buildPathFromString):
        (WebCore::SVGPathParserFactory::buildPathFromByteStream):
        (WebCore::SVGPathParserFactory::buildSVGPathSegListFromString):
        (WebCore::SVGPathParserFactory::buildSVGPathSegListFromByteStream):
        (WebCore::SVGPathParserFactory::buildStringFromByteStream):
        (WebCore::SVGPathParserFactory::buildSVGPathByteStreamFromString):
        * svg/SVGPathParserFactory.h:
        * svg/SVGPathSegListBuilder.h:
        (WebCore::SVGPathSegListBuilder::cleanup):
        * svg/SVGPathStringBuilder.cpp: Added. Build string from parsed SVG data.
        (WebCore::SVGPathStringBuilder::SVGPathStringBuilder):
        (WebCore::SVGPathStringBuilder::moveTo):
        (WebCore::SVGPathStringBuilder::lineTo):
        (WebCore::SVGPathStringBuilder::lineToHorizontal):
        (WebCore::SVGPathStringBuilder::lineToVertical):
        (WebCore::SVGPathStringBuilder::curveToCubic):
        (WebCore::SVGPathStringBuilder::curveToCubicSmooth):
        (WebCore::SVGPathStringBuilder::curveToQuadratic):
        (WebCore::SVGPathStringBuilder::curveToQuadraticSmooth):
        (WebCore::SVGPathStringBuilder::arcTo):
        (WebCore::SVGPathStringBuilder::closePath):
        * svg/SVGPathStringBuilder.h: Added.
        (WebCore::SVGPathStringBuilder::cleanup):
        (WebCore::SVGPathStringBuilder::result):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKitTestRunner should add the QuickTime dir to the PATH environment
jhoneycutt@apple.com [Sun, 8 Aug 2010 08:32:18 +0000 (08:32 +0000)]
WebKitTestRunner should add the QuickTime dir to the PATH environment
variable
https://bugs.webkit.org/show_bug.cgi?id=43686

Reviewed by Dan Bernstein.

* WebKitTestRunner/win/TestControllerWin.cpp:
(WTR::addQTDirToPATH):
Copied from DRT.
(WTR::TestController::platformInitialize):
Call addQTDirToPath().
* WebKitTestRunner/win/WebKitTestRunner.vcproj:
Link to shlwapi.lib for SHGetValue.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-08 Adam Barth <abarth@webkit.org>
eric@webkit.org [Sun, 8 Aug 2010 08:07:20 +0000 (08:07 +0000)]
2010-08-08  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        cross_fuzz WebCore::SelectionController::isFocusedAndActive ReadAV@NULL (9e865de49b1800ec790dcc35d8ebd069)
        https://bugs.webkit.org/show_bug.cgi?id=43040

        The pointer from Document to Frame can be null.  See http://webkit.org/coding/major-objects.html.

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-08 Adam Barth <abarth@webkit.org>
eric@webkit.org [Sun, 8 Aug 2010 07:55:52 +0000 (07:55 +0000)]
2010-08-08  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        frame()->selection() can't be null
        https://bugs.webkit.org/show_bug.cgi?id=43681

        SelectionController is a component of Frame.  If frame is non-null, it
        can't possibly be null.

        * html/HTMLAnchorElement.cpp:
        (WebCore::HTMLAnchorElement::setActive):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-08 Adam Barth <abarth@webkit.org>
eric@webkit.org [Sun, 8 Aug 2010 07:45:00 +0000 (07:45 +0000)]
2010-08-08  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        SVGLength uses ASSERTs to validate user input
        https://bugs.webkit.org/show_bug.cgi?id=43680

        Send invalid input to trigger old ASSERTs.

        * svg/dom/svg-length-units-expected.txt: Added.
        * svg/dom/svg-length-units.html: Added.
2010-08-08  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        SVGLength uses ASSERTs to validate user input
        https://bugs.webkit.org/show_bug.cgi?id=43680

        ASSERTs aren't in release builds, so we can't use them to validate user
        input!  We've seen a bunch of examples of this in SVG code.  It might
        be worth auditing all the code to remove this misguided pattern.

        Test: svg/dom/svg-length-units.html

        * svg/SVGLength.cpp:
        (WebCore::SVGLength::newValueSpecifiedUnits):
        (WebCore::SVGLength::convertToSpecifiedUnits):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-08 Mihai Parparita <mihaip@chromium.org>
eric@webkit.org [Sun, 8 Aug 2010 07:33:37 +0000 (07:33 +0000)]
2010-08-08  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Adam Barth.

        Chromium: isindex tests timeout after r64712
        https://bugs.webkit.org/show_bug.cgi?id=43543

        Update isindex tests/expectactions after r64712 so that even though they
        stil fail, they fail immediately instead of timing out.

        * http/tests/misc/isindex-formdata-expected.txt:
        * http/tests/misc/isindex-formdata.html:
        * http/tests/misc/isindex-with-no-form-base-href-expected.txt:
        * http/tests/misc/resources/isindex-with-no-form-base-href.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-07 Sheriff Bot <webkit.review.bot@gmail.com>
eric@webkit.org [Sun, 8 Aug 2010 07:22:06 +0000 (07:22 +0000)]
2010-08-07  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r64938.
        http://trac.webkit.org/changeset/64938
        https://bugs.webkit.org/show_bug.cgi?id=43685

        Did not compile on several ports (Requested by abarth on
        #webkit).

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * JavaScriptCore.gypi:
        * JavaScriptCore.pro:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * assembler/AbstractMacroAssembler.h:
        * assembler/MacroAssembler.h:
        * assembler/MacroAssemblerX86.h:
        (JSC::MacroAssemblerX86::load32):
        (JSC::MacroAssemblerX86::store32):
        * assembler/X86Assembler.h:
        (JSC::X86Assembler::movl_rm):
        (JSC::X86Assembler::movl_mr):
        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::markAggregate):
        * bytecode/Instruction.h:
        (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::):
        (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
        (JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
        * bytecode/StructureStubInfo.cpp:
        (JSC::StructureStubInfo::deref):
        * bytecode/StructureStubInfo.h:
        (JSC::StructureStubInfo::initGetByIdProto):
        (JSC::StructureStubInfo::initGetByIdChain):
        (JSC::StructureStubInfo::):
        * jit/JIT.h:
        * jit/JITMarkObjects.cpp: Removed.
        * jit/JITPropertyAccess.cpp:
        (JSC::JIT::compileGetDirectOffset):
        (JSC::JIT::testPrototype):
        (JSC::JIT::privateCompilePutByIdTransition):
        (JSC::JIT::privateCompileGetByIdProto):
        (JSC::JIT::privateCompileGetByIdProtoList):
        (JSC::JIT::privateCompileGetByIdChainList):
        (JSC::JIT::privateCompileGetByIdChain):
        * jit/JITPropertyAccess32_64.cpp:
        (JSC::JIT::compileGetDirectOffset):
        (JSC::JIT::testPrototype):
        (JSC::JIT::privateCompilePutByIdTransition):
        (JSC::JIT::privateCompileGetByIdProto):
        (JSC::JIT::privateCompileGetByIdProtoList):
        (JSC::JIT::privateCompileGetByIdChainList):
        (JSC::JIT::privateCompileGetByIdChain):
        * jit/JITStubs.cpp:
        (JSC::setupPolymorphicProtoList):
        * wtf/Platform.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-07 Adam Barth <abarth@webkit.org>
eric@webkit.org [Sun, 8 Aug 2010 06:58:14 +0000 (06:58 +0000)]
2010-08-07  Adam Barth  <abarth@webkit.org>

        Reviewed by Sam Weinig.

        Empty strings can have more than one ref
        https://bugs.webkit.org/show_bug.cgi?id=43666

        These asserts are trying to say that we have a thread-safe copy of the
        string, but they're not accurate for empty strings because we use a
        special static empty string that magically has infinite refs.

        * storage/OriginUsageRecord.cpp:
        (WebCore::OriginUsageRecord::addDatabase):
        (WebCore::OriginUsageRecord::markDatabase):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-07 Gyuyoung Kim <gyuyoung.kim@samsung.com>
eric@webkit.org [Sun, 8 Aug 2010 06:45:34 +0000 (06:45 +0000)]
2010-08-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
        Reviewed by Eric Seidel.

        [WML] Add KURL parameter to WMLDocument::create()
        https://bugs.webkit.org/show_bug.cgi?id=43173

        To fix build break in WML, url parameter is added. Because,
        Document class has url parameter.

        * wml/WMLDocument.cpp:
        (WebCore::WMLDocument::WMLDocument):
        * wml/WMLDocument.h:
        (WebCore::WMLDocument::create): Add an url parameter to create() method

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-07 Gyuyoung Kim <gyuyoung.kim@samsung.com>
eric@webkit.org [Sun, 8 Aug 2010 06:32:23 +0000 (06:32 +0000)]
2010-08-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Eric Seidel.

        [WML] Change getIDAttribute() with getIdAttribute()
        https://bugs.webkit.org/show_bug.cgi?id=43175

        Change getIDAttribute() with getIdAttribute() because function
        name was changed.

        * wml/WMLCardElement.cpp:
        (WebCore::WMLCardElement::findNamedCardInDocument): Change getIDAttribute() with getIdAttribute().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-07 Mihai Parparita <mihaip@chromium.org>
eric@webkit.org [Sun, 8 Aug 2010 06:19:48 +0000 (06:19 +0000)]
2010-08-07  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Adam Barth.

        WebTiming does not take page cache into account
        https://bugs.webkit.org/show_bug.cgi?id=42772

        Adds tests that simulates flow from a page that's in the page cache to
        one that's not, and then back to the page cached page (where the
        DocumentLoader is reused, but we should have a new DocumentLoadTiming
        struct).

        * fast/events/onunload-back-to-page-cache-expected.txt: Added.
        * fast/events/onunload-back-to-page-cache.html: Added.
2010-08-07  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Adam Barth.

        WebTiming does not take page cache into account
        https://bugs.webkit.org/show_bug.cgi?id=42772

        When restoring a page from the page cache, reset its DocumentLoadTiming
        struct and record navigationStart.

        Test: fast/events/onunload-back-to-page-cache.html

        * loader/DocumentLoadTiming.h: removed Noncopyable, since it's just a simple struct.
        * loader/DocumentLoader.h:
        (WebCore::DocumentLoader::resetTiming): Added method.
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::stopLoading): Uncommented assert.
        (WebCore::FrameLoader::loadProvisionalItemFromCachedPage): Added resetTiming() call.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-07 Nathan Lawrence <nlawrence@apple.com>
eric@webkit.org [Sun, 8 Aug 2010 06:04:59 +0000 (06:04 +0000)]
2010-08-07  Nathan Lawrence  <nlawrence@apple.com>

        Reviewed by Geoffrey Garen.

        The JIT code contains a number of direct references to GC'd objects.
        When we have movable objects, these references will need to be
        updated.

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * JavaScriptCore.gypi:
        * JavaScriptCore.pro:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * assembler/AbstractMacroAssembler.h:
        (JSC::AbstractMacroAssembler::int32AtLocation):
        (JSC::AbstractMacroAssembler::pointerAtLocation):
        (JSC::AbstractMacroAssembler::jumpTarget):
        * assembler/MacroAssembler.h:
        (JSC::MacroAssembler::loadPtrWithPatch):
            Normally, loadPtr will optimize when the register is eax.  Since
            the slightly smaller instruction changes the offsets, it messes up
            our ability to repatch the code.  We added this new instruction
            that garuntees a constant size.
        * assembler/MacroAssemblerX86.h:
        (JSC::MacroAssemblerX86::load32WithPatch):
            Changed load32 in the same way described above.
        (JSC::MacroAssemblerX86::load32):
            Moved the logic to optimize laod32 from movl_mr to load32
        (JSC::MacroAssemblerX86::store32):
            Moved the logic to optimize store32 from movl_rm to store32
        * assembler/X86Assembler.h:
        (JSC::X86Assembler::movl_rm):
        (JSC::X86Assembler::movl_mr):
        (JSC::X86Assembler::int32AtLocation):
        (JSC::X86Assembler::pointerAtLocation):
        (JSC::X86Assembler::jumpTarget):
        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::markAggregate):
        * bytecode/Instruction.h:
            As described in StructureStubInfo.h, we needed to add additional
            fields to both StructureStubInfo and
            PolymorphicAccessStructureList so that we can determine the
            structure of the JITed code at patch time.
        (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
        (JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
        * bytecode/StructureStubInfo.cpp:
        (JSC::StructureStubInfo::markAggregate):
            Added this function to mark the JITed code that correosponds to
            this structure stub info.
        * bytecode/StructureStubInfo.h:
        (JSC::StructureStubInfo::initGetByIdProto):
        (JSC::StructureStubInfo::initGetByIdChain):
        (JSC::StructureStubInfo::):
        * jit/JIT.h:
        * jit/JITMarkObjects.cpp: Added.
        (JSC::JIT::patchPrototypeStructureAddress):
        (JSC::JIT::patchGetDirectOffset):
        (JSC::JIT::markGetByIdProto):
        (JSC::JIT::markGetByIdChain):
        (JSC::JIT::markGetByIdProtoList):
        (JSC::JIT::markPutByIdTransition):
        (JSC::JIT::markGlobalObjectReference):
        * jit/JITPropertyAccess.cpp:
            Added asserts for the patch offsets.
        (JSC::JIT::compileGetDirectOffset):
        (JSC::JIT::testPrototype):
        (JSC::JIT::privateCompilePutByIdTransition):
        (JSC::JIT::privateCompileGetByIdProto):
        (JSC::JIT::privateCompileGetByIdProtoList):
        (JSC::JIT::privateCompileGetByIdChainList):
        (JSC::JIT::privateCompileGetByIdChain):
        * jit/JITPropertyAccess32_64.cpp:
        (JSC::JIT::compileGetDirectOffset):
        (JSC::JIT::testPrototype):
        (JSC::JIT::privateCompilePutByIdTransition):
        (JSC::JIT::privateCompileGetByIdProto):
        (JSC::JIT::privateCompileGetByIdProtoList):
        (JSC::JIT::privateCompileGetByIdChainList):
        (JSC::JIT::privateCompileGetByIdChain):
        * jit/JITStubs.cpp:
        (JSC::setupPolymorphicProtoList):
        * wtf/Platform.h:
            Added ENABLE_MOVABLE_GC_OBJECTS flag

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-07 Michael Saboff <msaboff@apple.com>
eric@webkit.org [Sun, 8 Aug 2010 05:29:38 +0000 (05:29 +0000)]
2010-08-07  Michael Saboff  <msaboff@apple.com>

        Reviewed by Geoffrey Garen.

        Revert JSArray to point to the beginning of the contained ArrayStorage
        struct.  This is described in
        https://bugs.webkit.org/show_bug.cgi?id=43526.

        * jit/JITPropertyAccess.cpp:
        (JSC::JIT::emit_op_get_by_val):
        (JSC::JIT::emit_op_put_by_val):
        (JSC::JIT::privateCompilePatchGetArrayLength):
        * jit/JITPropertyAccess32_64.cpp:
        (JSC::JIT::emit_op_get_by_val):
        (JSC::JIT::emit_op_put_by_val):
        (JSC::JIT::privateCompilePatchGetArrayLength):
        * runtime/JSArray.cpp:
        (JSC::JSArray::JSArray):
        (JSC::JSArray::~JSArray):
        (JSC::JSArray::getOwnPropertySlot):
        (JSC::JSArray::getOwnPropertyDescriptor):
        (JSC::JSArray::put):
        (JSC::JSArray::putSlowCase):
        (JSC::JSArray::deleteProperty):
        (JSC::JSArray::getOwnPropertyNames):
        (JSC::JSArray::getNewVectorLength):
        (JSC::JSArray::increaseVectorLength):
        (JSC::JSArray::increaseVectorPrefixLength):
        (JSC::JSArray::setLength):
        (JSC::JSArray::pop):
        (JSC::JSArray::push):
        (JSC::JSArray::shiftCount):
        (JSC::JSArray::unshiftCount):
        (JSC::JSArray::sortNumeric):
        (JSC::JSArray::sort):
        (JSC::JSArray::fillArgList):
        (JSC::JSArray::copyToRegisters):
        (JSC::JSArray::compactForSorting):
        (JSC::JSArray::subclassData):
        (JSC::JSArray::setSubclassData):
        (JSC::JSArray::checkConsistency):
        * runtime/JSArray.h:
        (JSC::JSArray::length):
        (JSC::JSArray::canGetIndex):
        (JSC::JSArray::getIndex):
        (JSC::JSArray::setIndex):
        (JSC::JSArray::uncheckedSetIndex):
        (JSC::JSArray::markChildrenDirect):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-07 Zoltan Horvath <zoltan@webkit.org>
eric@webkit.org [Sun, 8 Aug 2010 05:01:05 +0000 (05:01 +0000)]
2010-08-07  Zoltan Horvath  <zoltan@webkit.org>

        Reviewed by Eric Seidel.

        Allow custom memory allocation control for EventHandlingState struct
        https://bugs.webkit.org/show_bug.cgi?id=43548

        Inherits the following class from FastAllocBase because it is
        instantiated by 'new':

        struct name         - instantiated at: WebCore/
        EventHandlingState  - html/HTMLInputElement.cpp:2051

        * html/HTMLInputElement.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-07 Jay Civelli <jcivelli@chromium.org>
eric@webkit.org [Sun, 8 Aug 2010 04:47:56 +0000 (04:47 +0000)]
2010-08-07  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by Eric Seidel.

        [Chromium] Remove unecessary focus code.
        https://bugs.webkit.org/show_bug.cgi?id=43542

        * platform/chromium/ChromiumBridge.h:
        * platform/chromium/WidgetChromium.cpp:
        (WebCore::Widget::setFocus):
2010-08-07  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by Eric Seidel.

        Removed unecessary focus code.
        https://bugs.webkit.org/show_bug.cgi?id=43542

        * src/ChromiumBridge.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-07 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Sun, 8 Aug 2010 03:55:50 +0000 (03:55 +0000)]
2010-08-07  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Eric Seidel.

        Add ENABLE(YARR) guard around JSGlobalData::m_regexAllocator
        https://bugs.webkit.org/show_bug.cgi?id=43399

        m_regexAllocator is used only by RegExp::compile which is guarded with ENABLE(YARR).

        * runtime/JSGlobalData.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-07 Patrick Roland Gansterer <paroga@paroga.com>
eric@webkit.org [Sun, 8 Aug 2010 03:25:35 +0000 (03:25 +0000)]
2010-08-07  Patrick Roland Gansterer  <paroga@paroga.com>

        Reviewed by Eric Seidel.

        [Qt] Enable JIT on WinCE
        https://bugs.webkit.org/show_bug.cgi?id=43303

        Add ExtraCompiler for generating GeneratedJITStubs_MSVC.asm.

        * DerivedSources.pro:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-07 Gyuyoung Kim <gyuyoung.kim@samsung.com>
eric@webkit.org [Sun, 8 Aug 2010 03:13:32 +0000 (03:13 +0000)]
2010-08-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Eric Seidel.

        [WML] Include FormDataBuilder.h in WMLGoElement.h
        https://bugs.webkit.org/show_bug.cgi?id=43177

        To fix build breaks in WMLGoElement.cpp, FormDataBuilder.h needs to be included.

        * wml/WMLGoElement.cpp: Include FormDataBuilder.h

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-07 Gyuyoung Kim <gyuyoung.kim@samsung.com>
eric@webkit.org [Sun, 8 Aug 2010 03:00:55 +0000 (03:00 +0000)]
2010-08-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Eric Seidel.

        [WML] Add dummy argument to SelectElement::defaultEventHandler() in WMLSelectElement
        https://bugs.webkit.org/show_bug.cgi?id=43176

        * wml/WMLSelectElement.cpp:
        (WebCore::WMLSelectElement::defaultEventHandler): Sets NULL parameter to SelectElement::defaultEventHandler.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-07 Gyuyoung Kim <gyuyoung.kim@samsung.com>
eric@webkit.org [Sun, 8 Aug 2010 02:38:22 +0000 (02:38 +0000)]
2010-08-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Eric Seidel.

        [WML] Change DocumentParser with ScriptableDocumentParser in WMLDocument
        https://bugs.webkit.org/show_bug.cgi?id=43174

        * wml/WMLDocument.cpp:
        (WebCore::WMLDocument::finishedParsing): Change DocumentParser with ScriptableDocumentParser.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKitTestRunner needs layoutTestController.dumpTitleChanges
weinig@apple.com [Sun, 8 Aug 2010 02:22:57 +0000 (02:22 +0000)]
WebKitTestRunner needs layoutTestController.dumpTitleChanges
<rdar://problem/8213861>
https://bugs.webkit.org/show_bug.cgi?id=42683

Reviewed by Maciej Stachowiak.

WebKitTools:

* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::didReceiveTitleForFrame):
(WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::LayoutTestController):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(WTR::LayoutTestController::dumpTitleChanges):
(WTR::LayoutTestController::shouldDumpTitleChanges):

LayoutTests:

* platform/mac-wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKitTestRunner needs to print onunload handler information
weinig@apple.com [Sun, 8 Aug 2010 01:59:00 +0000 (01:59 +0000)]
WebKitTestRunner needs to print onunload handler information
<rdar://problem/8213831>
https://bugs.webkit.org/show_bug.cgi?id=42703

Reviewed by Anders Carlsson.

WebKit2:

Add SPI to get the number of pending unload events.

* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameGetPendingUnloadCount):
* WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::pendingUnloadCount):
* WebProcess/WebPage/WebFrame.h:

WebKitTools:

* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::operator<<):
(WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):

LayoutTests:

* platform/mac-wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd additional loader client functions need to complete WebKitTestRunner
weinig@apple.com [Sat, 7 Aug 2010 23:26:19 +0000 (23:26 +0000)]
Add additional loader client functions need to complete WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=43684

Reviewed by Anders Carlsson.

WebKit2:

* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::didCancelClientRedirectForFrame):
(WebKit::InjectedBundlePageLoaderClient::willPerformClientRedirectForFrame):
(WebKit::InjectedBundlePageLoaderClient::didChangeLocationWithinPageForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFinishDocumentLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didHandleOnloadEventsForFrame):
(WebKit::InjectedBundlePageLoaderClient::didDisplayInsecureContentForFrame):
(WebKit::InjectedBundlePageLoaderClient::didRunInsecureContentForFrame):
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidHandleOnloadEvents):
(WebKit::WebFrameLoaderClient::dispatchDidCancelClientRedirect):
(WebKit::WebFrameLoaderClient::dispatchWillPerformClientRedirect):
(WebKit::WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
(WebKit::WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
(WebKit::WebFrameLoaderClient::didDisplayInsecureContent):
(WebKit::WebFrameLoaderClient::didRunInsecureContent):

WebKitTools:

Remove unnecessary and jarring underscores as well.

* MiniBrowser/mac/WebBundle/WebBundleMain.m:
(didClearWindowObjectForFrame):
(didCreatePage):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
(WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
(WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
(WTR::InjectedBundlePage::didCommitLoadForFrame):
(WTR::InjectedBundlePage::didFinishLoadForFrame):
(WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
(WTR::InjectedBundlePage::didReceiveTitleForFrame):
(WTR::InjectedBundlePage::didClearWindowForFrame):
(WTR::InjectedBundlePage::didCancelClientRedirectForFrame):
(WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
(WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
(WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
(WTR::InjectedBundlePage::didHandleOnloadEventsForFrame):
(WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
(WTR::InjectedBundlePage::didRunInsecureContentForFrame):
(WTR::InjectedBundlePage::willAddMessageToConsole):
(WTR::InjectedBundlePage::willSetStatusbarText):
(WTR::InjectedBundlePage::willRunJavaScriptAlert):
(WTR::InjectedBundlePage::willRunJavaScriptConfirm):
(WTR::InjectedBundlePage::willRunJavaScriptPrompt):
(WTR::InjectedBundlePage::shouldBeginEditing):
(WTR::InjectedBundlePage::shouldEndEditing):
(WTR::InjectedBundlePage::shouldInsertNode):
(WTR::InjectedBundlePage::shouldInsertText):
(WTR::InjectedBundlePage::shouldDeleteRange):
(WTR::InjectedBundlePage::shouldChangeSelectedRange):
(WTR::InjectedBundlePage::shouldApplyStyle):
(WTR::InjectedBundlePage::didBeginEditing):
(WTR::InjectedBundlePage::didEndEditing):
(WTR::InjectedBundlePage::didChange):
(WTR::InjectedBundlePage::didChangeSelection):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse ctFont() to get the CTFont.
mitz@apple.com [Sat, 7 Aug 2010 22:47:47 +0000 (22:47 +0000)]
Use ctFont() to get the CTFont.

Reviewed by Sam Weinig.

* platform/graphics/mac/FontMac.mm:
(WebCore::showGlyphsWithAdvances):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-07 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 7 Aug 2010 22:40:28 +0000 (22:40 +0000)]
2010-08-07  Adam Barth  <abarth@webkit.org>

        Reviewed by Sam Weinig.

        document->documentElement can always be null
        https://bugs.webkit.org/show_bug.cgi?id=43677

        This ASSERT is bogus.

        * css/StyleMedia.cpp:
        (WebCore::StyleMedia::matchMedium):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAnother fix for the windows build.
weinig@apple.com [Sat, 7 Aug 2010 22:32:57 +0000 (22:32 +0000)]
Another fix for the windows build.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::isAcceleratedCompositingEnabled):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix.
mitz@apple.com [Sat, 7 Aug 2010 22:26:36 +0000 (22:26 +0000)]
Build fix.

* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Made the references
to JSGCController.{cpp,h} relative to the build root.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix windows build.
weinig@apple.com [Sat, 7 Aug 2010 22:25:14 +0000 (22:25 +0000)]
Fix windows build.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::platformLayer):
* WebProcess/Plugins/PluginView.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKitTestRunner needs GCController
weinig@apple.com [Sat, 7 Aug 2010 21:42:06 +0000 (21:42 +0000)]
WebKitTestRunner needs GCController
<rdar://problem/8213834>
https://bugs.webkit.org/show_bug.cgi?id=42701

Reviewed by Anders Carlsson.

WebKit2:

* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleGarbageCollectJavaScriptObjects):
(WKBundleGarbageCollectJavaScriptObjectsOnAlternateThreadForDebugging):
(WKBundleGetJavaScriptObjectsCount):
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::garbageCollectJavaScriptObjects):
(WebKit::InjectedBundle::garbageCollectJavaScriptObjectsOnAlternateThreadForDebugging):
(WebKit::InjectedBundle::javaScriptObjectsCount):
* WebProcess/InjectedBundle/InjectedBundle.h:

WebKitTools:

* WebKitTestRunner/DerivedSources.make:
* WebKitTestRunner/InjectedBundle/Bindings/GCController.idl: Added.
* WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h:
(WTR::setProperty):
* WebKitTestRunner/InjectedBundle/GCController.cpp: Added.
(WTR::GCController::create):
(WTR::GCController::GCController):
(WTR::GCController::~GCController):
(WTR::GCController::wrapperClass):
(WTR::GCController::collect):
(WTR::GCController::collectOnAlternateThread):
(WTR::GCController::getJSObjectCount):
(WTR::GCController::makeWindowObject):
* WebKitTestRunner/InjectedBundle/GCController.h: Added.
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::reset):
* WebKitTestRunner/InjectedBundle/InjectedBundle.h:
(WTR::InjectedBundle::bundle):
(WTR::InjectedBundle::gcController):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::didClearWindowForFrame):
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::keepWebHistory):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
* WebKitTestRunner/win/InjectedBundle.vcproj:

LayoutTests:

* platform/mac-wk2/Skipped: Remove now passing tests and add some failing tests.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/8285090> First word on a line doesn’t hyphenate properly
mitz@apple.com [Sat, 7 Aug 2010 21:41:06 +0000 (21:41 +0000)]
<rdar://problem/8285090> First word on a line doesn’t hyphenate properly
https://bugs.webkit.org/show_bug.cgi?id=43679

Reviewed by Anders Carlsson.

WebCore:

Test: fast/text/hyphenate-first-word.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::tryHyphenating): The character at lastSpace is not necessarily a whitespace character
before the current word. It can also be part of the word, such as when the word is the first
one on the line. Include the charcater at lastSpace in the string passed to lastHyphenLocation().

LayoutTests:

* fast/text/hyphenate-first-word.html: Added.
* platform/mac/fast/text/hyphenate-first-word-expected.checksum: Added.
* platform/mac/fast/text/hyphenate-first-word-expected.png: Added.
* platform/mac/fast/text/hyphenate-first-word-expected.txt: Added.
* platform/mac/fast/text/hyphenate-locale-expected.checksum:
* platform/mac/fast/text/hyphenate-locale-expected.png:
* platform/mac/fast/text/hyphenate-locale-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCA drawing model support for Mac Plugins
andersca@apple.com [Sat, 7 Aug 2010 20:54:38 +0000 (20:54 +0000)]
CA drawing model support for Mac Plugins
https://bugs.webkit.org/show_bug.cgi?id=43678
<rdar://problem/7929701>

Reviewed by Sam Weinig.

* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue):
Handle WKNVSupportsCompositingCoreAnimationPluginsBool and
NPNVsupportsCoreAnimationBool and return true if accelerated compositing is enabled.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::isAcceleratedCompositingEnabled):
Call PluginController::isAcceleratedCompositingEnabled.

* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::platformPostInitialize):
If the plug-in uses the Core Animation drawing model, ask it for its layer.

(WebKit::NetscapePlugin::platformPaint):
Don't send draw events if the Core Animation drawing model is used.

(WebKit::NetscapePlugin::pluginLayer):
Return the plug-in layer.

* WebProcess/Plugins/Plugin.h:
Add a pluginLayer pure virtual member function.

* WebProcess/Plugins/PluginController.h:
Add an isAcceleratedCompositingEnabled pure virtual member function.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::initializePlugin):
If the plug-in has a layer, enter compositing mode.

(WebKit::PluginView::platformLayer):
Ask the plug-in for its layer.

(WebKit::PluginView::isAcceleratedCompositingEnabled):
Call Settings::acceleratedCompositingEnabled.

* WebProcess/Plugins/PluginView.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDelete key doesn't go Back in WebKit2
weinig@apple.com [Sat, 7 Aug 2010 20:45:36 +0000 (20:45 +0000)]
Delete key doesn't go Back in WebKit2
<rdar://problem/8272978>
https://bugs.webkit.org/show_bug.cgi?id=43665

Reviewed by Anders Carlsson.

- Adds support for delete key going back (mac only for now)
- Adds support for command-left/command right going back/forward
- Flesh out scrolling due to arrow keys on the mac to match old webkit.
- Made performDefaultBehaviorForKeyEvent platform specific and added
  a boolean return value which will be used later to inform the UI process
  about what events have been processed.

* Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:
(WebPageProxyMessage::):
* UIProcess/API/mac/WKView.mm:
(-[WKView _wantsKeyDownForEvent:]):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveSyncMessage):
* WebProcess/WebPage/WebBackForwardListProxy.cpp:
(WebKit::WebBackForwardListProxy::backItem):
(WebKit::WebBackForwardListProxy::forwardItem):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::keyEvent):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::scroll):
(WebKit::WebPage::performDefaultBehaviorForKeyEvent):
* WebProcess/WebPage/qt/WebPageQt.cpp:
(WebKit::scroll):
(WebKit::WebPage::performDefaultBehaviorForKeyEvent):
* WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::scroll):
(WebKit::WebPage::performDefaultBehaviorForKeyEvent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-07 Antonio Gomes <tonikitoo@webkit.org>
tonikitoo@webkit.org [Sat, 7 Aug 2010 20:07:47 +0000 (20:07 +0000)]
2010-08-07  Antonio Gomes  <tonikitoo@webkit.org>

        Another unreviewed missing bit of r64673

        * QtTestBrowser/launcherwindow.cpp:
        (LauncherWindow::createChrome):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix
mitz@apple.com [Sat, 7 Aug 2010 19:18:30 +0000 (19:18 +0000)]
Build fix

* platform/graphics/SimpleFontData.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCreated a separate SimpleFontData constructor exclusively for SVG fonts and moved...
mitz@apple.com [Sat, 7 Aug 2010 18:59:43 +0000 (18:59 +0000)]
Created a separate SimpleFontData constructor exclusively for SVG fonts and moved the CTFontRef
from SimpleFontData to FontPlatformData.
https://bugs.webkit.org/show_bug.cgi?id=43674

Reviewed by Anders Carlsson.

JavaScriptCore:

* wtf/Platform.h: Moved definitions of WTF_USE_CORE_TEXT and WTF_USE_ATSUI here from WebCore/config.h.

WebCore:

* config.h: Moved definitions of WTF_USE_CORE_TEXT and WTF_USE_ATSUI from here to wtf/Platform.h.
* css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData): Use new SimpleFontData constructor for SVG fonts.
* platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::SimpleFontData): Separated into two constructors, one for
PlatformFontData-based fonts and one for SVG fonts.
* platform/graphics/SimpleFontData.h: Moved the m_CTFont member variable and the getCTFont()
accessor from here…
* platform/graphics/mac/FontPlatformData.h: …to here, renaming the latter ctFont().
* platform/graphics/mac/FontPlatformDataMac.mm:
(WebCore::FontPlatformData::FontPlatformData): Copy m_CTFont.
(WebCore::FontPlatformData::operator=): Copy m_CTFont.
(WebCore::FontPlatformData::setFont): Clear m_CTFont.
(WebCore::FontPlatformData::ctFont): Moved here from SimpleFontDataCoreText.cpp and renamed.
* platform/graphics/mac/SimpleFontDataCoreText.cpp:
(WebCore::SimpleFontData::getCFStringAttributes): Updated to use FontPlatformData::ctFont().
* svg/SVGFontData.cpp:
(WebCore::SVGFontData::SVGFontData): Added an assertion.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFixed typos in the change log
mitz@apple.com [Sat, 7 Aug 2010 18:00:57 +0000 (18:00 +0000)]
Fixed typos in the change log

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-07 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 7 Aug 2010 17:52:20 +0000 (17:52 +0000)]
2010-08-07  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        Regression: Memory corruption in tree builder
        https://bugs.webkit.org/show_bug.cgi?id=43672

        Turns out this ASSERT was wrong and we need the branch.  Yay for
        test-driven development.

        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
2010-08-07  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        Regression: Memory corruption in tree builder
        https://bugs.webkit.org/show_bug.cgi?id=43672

        * html5lib/resources/adoption02.dat:
        * html5lib/runner-expected-html5.txt:
        * html5lib/runner-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBitmap.h has no default constructor
zherczeg@webkit.org [Sat, 7 Aug 2010 17:34:19 +0000 (17:34 +0000)]
Bitmap.h has no default constructor
https://bugs.webkit.org/show_bug.cgi?id=43619

Reviewed by Eric Seidel.

Without a constructor, the initial bits of the Bitmap class
are undefinied. If only a few, or zero bits are 0, the memory
area provided by AlignedMemoryAllocator can be easly exhausted.

Csaba Osztrogonác helped to find this bug.

* wtf/Bitmap.h:
(WTF::::Bitmap):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-07 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Sat, 7 Aug 2010 15:57:07 +0000 (15:57 +0000)]
2010-08-07  Dirk Schulze  <krit@webkit.org>

        Unreviewed build-fix.

        Come up with a more efficient way to represent Path segments
        https://bugs.webkit.org/show_bug.cgi?id=41159

        Landed wrong version of the patch.

        * svg/SVGPathByteStreamSource.cpp:
        (WebCore::SVGPathByteStreamSource::SVGPathByteStreamSource):
        (WebCore::SVGPathByteStreamSource::hasMoreData):
        * svg/SVGPathByteStreamSource.h:
        (WebCore::SVGPathByteStreamSource::moveToNextToken):
        * svg/SVGPathParserFactory.cpp:
        (WebCore::SVGPathParserFactory::buildSVGPathSegListFromByteStream):
        (WebCore::SVGPathParserFactory::createSVGPathByteStreamFromString):
        * svg/SVGPathParserFactory.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-07 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Sat, 7 Aug 2010 15:33:55 +0000 (15:33 +0000)]
2010-08-07  Dimitri Glazkov  <dglazkov@chromium.org>

        [Chromium]: Added port-specific expectations after http://trac.webkit.org/changeset/64901.
        https://bugs.webkit.org/show_bug.cgi?id=41596

        * platform/chromium-linux/http/tests/misc/slow-loading-image-in-pattern-expected.checksum: Added.
        * platform/chromium-linux/http/tests/misc/slow-loading-image-in-pattern-expected.png: Added.
        * platform/chromium-mac/http/tests/misc/slow-loading-image-in-pattern-expected.checksum: Added.
        * platform/chromium-mac/http/tests/misc/slow-loading-image-in-pattern-expected.png: Added.
        * platform/chromium-win/http/tests/misc/slow-loading-image-in-pattern-expected.checksum: Added.
        * platform/chromium-win/http/tests/misc/slow-loading-image-in-pattern-expected.png: Added.
        * platform/chromium-win/http/tests/misc/slow-loading-image-in-pattern-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-07 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Sat, 7 Aug 2010 15:17:47 +0000 (15:17 +0000)]
2010-08-07  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Come up with a more efficient way to represent Path segments
        https://bugs.webkit.org/show_bug.cgi?id=41159

        Introduce SVGPathByteStream as a fast and efficient way to organize the synchronization
        of Path, SVG path data string and SVGPathSegList in normalized and unaltered modes.
        Extended SVGPathParserFactory to accept SVGPathByteStreams as input source and to create
        a SVGPathByteStream from a SVG path data string.

        Doesn't affect any tests.

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * svg/SVGAllInOne.cpp:
        * svg/SVGPathByteStream.h: Added.
        (WebCore::):
        (WebCore::SVGPathByteStream::create):
        (WebCore::SVGPathByteStream::data):
        (WebCore::SVGPathByteStream::begin):
        (WebCore::SVGPathByteStream::end):
        (WebCore::SVGPathByteStream::append):
        (WebCore::SVGPathByteStream::clear):
        (WebCore::SVGPathByteStream::isEmpty):
        (WebCore::SVGPathByteStream::SVGPathByteStream):
        * svg/SVGPathByteStreamBuilder.cpp: Added.
        (WebCore::SVGPathByteStreamBuilder::SVGPathByteStreamBuilder):
        (WebCore::SVGPathByteStreamBuilder::moveTo):
        (WebCore::SVGPathByteStreamBuilder::lineTo):
        (WebCore::SVGPathByteStreamBuilder::lineToHorizontal):
        (WebCore::SVGPathByteStreamBuilder::lineToVertical):
        (WebCore::SVGPathByteStreamBuilder::curveToCubic):
        (WebCore::SVGPathByteStreamBuilder::curveToCubicSmooth):
        (WebCore::SVGPathByteStreamBuilder::curveToQuadratic):
        (WebCore::SVGPathByteStreamBuilder::curveToQuadraticSmooth):
        (WebCore::SVGPathByteStreamBuilder::arcTo):
        (WebCore::SVGPathByteStreamBuilder::closePath):
        * svg/SVGPathByteStreamBuilder.h: Added.
        (WebCore::SVGPathByteStreamBuilder::setCurrentByteStream):
        (WebCore::SVGPathByteStreamBuilder::writeType):
        (WebCore::SVGPathByteStreamBuilder::writeFlag):
        (WebCore::SVGPathByteStreamBuilder::writeFloat):
        (WebCore::SVGPathByteStreamBuilder::writeFloatPoint):
        (WebCore::SVGPathByteStreamBuilder::writeSegmentType):
        * svg/SVGPathByteStreamSource.cpp: Added.
        (WebCore::SVGPathByteStreamSource::SVGPathByteStreamSource):
        (WebCore::SVGPathByteStreamSource::~SVGPathByteStreamSource):
        (WebCore::SVGPathByteStreamSource::hasMoreData):
        (WebCore::SVGPathByteStreamSource::parseFloat):
        (WebCore::SVGPathByteStreamSource::parseFlag):
        (WebCore::SVGPathByteStreamSource::parseSVGSegmentType):
        (WebCore::SVGPathByteStreamSource::nextCommand):
        * svg/SVGPathByteStreamSource.h: Added.
        (WebCore::SVGPathByteStreamSource::create):
        (WebCore::SVGPathByteStreamSource::readType):
        (WebCore::SVGPathByteStreamSource::readFlag):
        (WebCore::SVGPathByteStreamSource::readFloat):
        (WebCore::SVGPathByteStreamSource::readSVGSegmentType):
        (WebCore::SVGPathByteStreamSource::readFloatPoint):
        * svg/SVGPathParserFactory.cpp:
        (WebCore::globalSVGPathByteStreamBuilder):
        (WebCore::SVGPathParserFactory::buildPathFromByteStream):
        (WebCore::SVGPathParserFactory::buildSVGPathSegListFromByteStream):
        (WebCore::SVGPathParserFactory::buildSVGPathByteStreamFromString):
        * svg/SVGPathParserFactory.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-07 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Sat, 7 Aug 2010 13:03:46 +0000 (13:03 +0000)]
2010-08-07  Dirk Schulze  <krit@webkit.org>

        Not reviewed. Sort XCode project file.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-06 Victor Wang <victorw@chromium.org>
victorw@chromium.org [Sat, 7 Aug 2010 12:42:36 +0000 (12:42 +0000)]
2010-08-06  Victor Wang  <victorw@chromium.org>

        Reviewed by Kent Tamura.

        [Chromium] Add dllimport/dllexport to WebSpeechInputControllerMock::create
        so it works for windows dll build.

        https://bugs.webkit.org/show_bug.cgi?id=43627

        * public/WebSpeechInputControllerMock.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-07 Sheriff Bot <webkit.review.bot@gmail.com>
abecsi@webkit.org [Sat, 7 Aug 2010 12:22:02 +0000 (12:22 +0000)]
2010-08-07  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r64904.
        http://trac.webkit.org/changeset/64904
        https://bugs.webkit.org/show_bug.cgi?id=43671

        Broke the Qt Windows builders. (Requested by bbandix on
        #webkit).

        * WebCore.pri:
        * WebCore.pro:
        * features.pri: Removed.
2010-08-07  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r64904.
        http://trac.webkit.org/changeset/64904
        https://bugs.webkit.org/show_bug.cgi?id=43671

        Broke the Qt Windows builders. (Requested by bbandix on
        #webkit).

        * WebKit.pro:
2010-08-07  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r64904.
        http://trac.webkit.org/changeset/64904
        https://bugs.webkit.org/show_bug.cgi?id=43671

        Broke the Qt Windows builders. (Requested by bbandix on
        #webkit).

        * WebKit2.pri: Removed.
        * WebKit2.pro:
        * WebProcess.pro: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-07 Balazs Kelemen <kb@inf.u-szeged.hu>
abecsi@webkit.org [Sat, 7 Aug 2010 11:47:55 +0000 (11:47 +0000)]
2010-08-07  Balazs Kelemen  <kb@inf.u-szeged.hu>

        Reviewed by Eric Seidel.

        NPAPI headers should be included through npruntime_internal.h

        https://bugs.webkit.org/show_bug.cgi?id=43620

        * DerivedSources.pro:
        * WebProcess/Plugins/NPJSObject.h:
        * WebProcess/Plugins/NPRuntimeUtilities.h:
        * WebProcess/Plugins/Netscape/NetscapePluginStream.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-07 Balazs Kelemen <kb@inf.u-szeged.hu>
abecsi@webkit.org [Sat, 7 Aug 2010 11:44:03 +0000 (11:44 +0000)]
2010-08-07  Balazs Kelemen  <kb@inf.u-szeged.hu>

        Reviewed by Eric Seidel.

        [Qt] Build WebKit2 into a static lib

        https://bugs.webkit.org/show_bug.cgi?id=43621

        Just build changes so no new tests.

        * WebCore.pri: Moved feature detection logic into features.pri since we need this in WebKit2.pro as well.
        * WebCore.pro: Moved the specification of the WebKit2 build to WebKit2.pro. Link against the static lib.
        * features.pri: Added.
2010-08-07  Balazs Kelemen  <kb@inf.u-szeged.hu>

        Reviewed by Eric Seidel.

        [Qt] Build WebKit2 into a static lib

        https://bugs.webkit.org/show_bug.cgi?id=43621

        * WebKit.pro: Moved WebKit2 into the subdirs before WebCore since WebCore links against the WebKit2 lib.
2010-08-07  Balazs Kelemen  <kb@inf.u-szeged.hu>

        Reviewed by Eric Seidel.

        [Qt] Build WebKit2 into a static lib

        https://bugs.webkit.org/show_bug.cgi?id=43621

        * WebKit2.pri: Added. Defined addWebKit2Lib function that defines how to link against the static lib.
        * WebKit2.pro:  Build specification for the WebKit2 framework.
        * WebProcess.pro: Copied from WebKit2/WebKit2.pro. Build specification for the WebProcess binary.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, test expectation update.
tkent@chromium.org [Sat, 7 Aug 2010 09:32:18 +0000 (09:32 +0000)]
Unreviewed, test expectation update.

* platform/chromium/drt_expectations.txt:
 Update DRT expectation.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-07 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sat, 7 Aug 2010 09:28:58 +0000 (09:28 +0000)]
2010-08-07  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Remove workarounds in two dynamic-updates scripts, that now work without it.

        * svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-dom-result-attr.js:
        * svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-07 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sat, 7 Aug 2010 09:25:48 +0000 (09:25 +0000)]
2010-08-07  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Daniel Bates.

        Pattern fill with image not rendered after reload
        https://bugs.webkit.org/show_bug.cgi?id=41596

        Fixed by a one-liner. Instead of just invalidating it's own resources, images also have to update
        resources in the ancestor chain, if imageChanged() has been called (for example, a slow loading image)

        Test: http/tests/misc/slow-loading-image-in-pattern.html

        * rendering/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::imageChanged):

2010-08-07  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Daniel Bates.

        Pattern fill with image not rendered after reload
        https://bugs.webkit.org/show_bug.cgi?id=41596

        Added test verifying that resources are properly updated, if an image child element has changed.

        * http/tests/misc/slow-loading-image-in-pattern.html: Added.
        * platform/mac/http/tests/misc/slow-loading-image-in-pattern-expected.checksum: Added.
        * platform/mac/http/tests/misc/slow-loading-image-in-pattern-expected.png: Added.
        * platform/mac/http/tests/misc/slow-loading-image-in-pattern-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-07 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Sat, 7 Aug 2010 09:17:33 +0000 (09:17 +0000)]
2010-08-07  Kent Tamura  <tkent@chromium.org>

        Unreviewed, test expectation update.

        * platform/chromium-win/fast/parser/nofoo-tags-inside-paragraph-expected.txt:
          Rebaseline for r64890.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-07 Alex Nicolaou <anicolao@chromium.org>
zimmermann@webkit.org [Sat, 7 Aug 2010 07:13:12 +0000 (07:13 +0000)]
2010-08-07  Alex Nicolaou  <anicolao@chromium.org>

        Reviewed by Nikolas Zimmermann.

        Remove obsolete baselines for win-xp and win-vista, all windows platforms are the same for this test
        https://bugs.webkit.org/show_bug.cgi?id=43669

        * platform/chromium-win-vista/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum: Removed.
        * platform/chromium-win-vista/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png: Removed.
        * platform/chromium-win-xp/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum: Removed.
        * platform/chromium-win-xp/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-06 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Sat, 7 Aug 2010 06:27:28 +0000 (06:27 +0000)]
2010-08-06  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Generalize SVGPathParser to allow more than just strings as input source
        https://bugs.webkit.org/show_bug.cgi?id=43618

        Generalize SVGPathParser, by allowing different parsing sources than just strings.
        For now only a SVGPathStringSource is available, parsing from bytestreams follows soon.
        Each client that wants to parse strings, like Path or SVGPathSegList objects, only
        needs to use the new central SVGPathParserFactory, which glues consumer and sources together.
        Moved the SVGPathSegType enum from SVGPathSeg class in WebCore namespace, for
        easier access throughout the SVG code.

        Doesn't affect any tests.

        * Android.mk:
        * CMakeLists.txt
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj
        * svg/SVGAllInOne.cpp:
        * svg/SVGAnimateElement.cpp:
        (WebCore::SVGAnimateElement::calculateFromAndToValues):
        * svg/SVGAnimateMotionElement.cpp:
        (WebCore::SVGAnimateMotionElement::parseMappedAttribute):
        * svg/SVGGlyphElement.cpp:
        (WebCore::parsePathData):
        * svg/SVGPathBuilder.cpp:
        (WebCore::SVGPathBuilder::SVGPathBuilder):
        (WebCore::SVGPathBuilder::moveTo):
        (WebCore::SVGPathBuilder::lineTo):
        (WebCore::SVGPathBuilder::curveToCubic):
        (WebCore::SVGPathBuilder::closePath):
        * svg/SVGPathBuilder.h:
        (WebCore::SVGPathBuilder::setCurrentPath):
        (WebCore::SVGPathBuilder::arcTo):
        * svg/SVGPathConsumer.h:
        * svg/SVGPathElement.cpp:
        (WebCore::SVGPathElement::parseMappedAttribute):
        * svg/SVGPathParser.cpp:
        (WebCore::SVGPathParser::SVGPathParser):
        (WebCore::SVGPathParser::parseClosePathSegment):
        (WebCore::SVGPathParser::parseMoveToSegment):
        (WebCore::SVGPathParser::parseLineToSegment):
        (WebCore::SVGPathParser::parseLineToHorizontalSegment):
        (WebCore::SVGPathParser::parseLineToVerticalSegment):
        (WebCore::SVGPathParser::parseCurveToCubicSegment):
        (WebCore::SVGPathParser::parseCurveToCubicSmoothSegment):
        (WebCore::SVGPathParser::parseCurveToQuadraticSegment):
        (WebCore::SVGPathParser::parseCurveToQuadraticSmoothSegment):
        (WebCore::SVGPathParser::parseArcToSegment):
        (WebCore::SVGPathParser::parsePathDataFromSource):
        (WebCore::SVGPathParser::decomposeArcToCubic):
        * svg/SVGPathParser.h:
        (WebCore::SVGPathParser::setCurrentConsumer):
        * svg/SVGPathParserFactory.cpp: Added.
        (WebCore::globalSVGPathBuilder):
        (WebCore::globalSVGPathSegListBuilder):
        (WebCore::globalSVGPathParser):
        (WebCore::SVGPathParserFactory::self):
        (WebCore::SVGPathParserFactory::SVGPathParserFactory):
        (WebCore::SVGPathParserFactory::~SVGPathParserFactory):
        (WebCore::SVGPathParserFactory::buildPathFromString):
        (WebCore::SVGPathParserFactory::buildSVGPathSegListFromString):
        * svg/SVGPathParserFactory.h: Added.
        * svg/SVGPathSeg.h:
        (WebCore::):
        (WebCore::SVGPathSeg::~SVGPathSeg):
        (WebCore::SVGPathSeg::):
        (WebCore::SVGPathSeg::pathSegType):
        (WebCore::SVGPathSeg::pathSegTypeAsLetter):
        (WebCore::SVGPathSeg::toString):
        (WebCore::SVGPathSeg::associatedAttributeName):
        (WebCore::SVGPathSeg::SVGPathSeg):
        (WebCore::SVGPathSegSingleCoord::SVGPathSegSingleCoord):
        (WebCore::SVGPathSegSingleCoord::setX):
        (WebCore::SVGPathSegSingleCoord::x):
        (WebCore::SVGPathSegSingleCoord::setY):
        (WebCore::SVGPathSegSingleCoord::y):
        (WebCore::SVGPathSegSingleCoord::toString):
        * svg/SVGPathSegList.cpp:
        (WebCore::SVGPathSegList::getPathSegAtLength):
        (WebCore::SVGPathSegList::toPathData):
        (WebCore::SVGPathSegList::createAnimated):
        * svg/SVGPathSegListBuilder.cpp:
        (WebCore::SVGPathSegListBuilder::SVGPathSegListBuilder):
        (WebCore::SVGPathSegListBuilder::moveTo):
        (WebCore::SVGPathSegListBuilder::lineTo):
        (WebCore::SVGPathSegListBuilder::curveToCubic):
        (WebCore::SVGPathSegListBuilder::curveToCubicSmooth):
        (WebCore::SVGPathSegListBuilder::curveToQuadratic):
        (WebCore::SVGPathSegListBuilder::curveToQuadraticSmooth):
        (WebCore::SVGPathSegListBuilder::arcTo):
        * svg/SVGPathSegListBuilder.h:
        (WebCore::SVGPathSegListBuilder::setCurrentSVGPathSegList):
        * svg/SVGPathSource.h: Added.
        (WebCore::SVGPathSource::~SVGPathSource):
        (WebCore::SVGPathSource::SVGPathSource):
        * svg/SVGPathStringSource.cpp: Added.
        (WebCore::SVGPathStringSource::SVGPathStringSource):
        (WebCore::SVGPathStringSource::~SVGPathStringSource):
        (WebCore::SVGPathStringSource::endOfStream):
        (WebCore::SVGPathStringSource::parseFloat):
        (WebCore::SVGPathStringSource::parseFlag):
        (WebCore::SVGPathStringSource::skipSpaces):
        (WebCore::SVGPathStringSource::parseSVGSegmentType):
        (WebCore::SVGPathStringSource::hasRemainingCoordinatesInCurrentCommand):
        * svg/SVGPathStringSource.h: Added.
        (WebCore::SVGPathStringSource::create):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-06 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sat, 7 Aug 2010 06:20:21 +0000 (06:20 +0000)]
2010-08-06  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Add missing files from last commit - per Alex request.

        * platform/chromium-win/svg/custom/mask-colorspace-expected.checksum: Added.
        * platform/chromium-win/svg/custom/mask-colorspace-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-06 Alex Nicolaou <anicolao@chromium.org>
abarth@webkit.org [Sat, 7 Aug 2010 05:03:10 +0000 (05:03 +0000)]
2010-08-06  Alex Nicolaou  <anicolao@chromium.org>

        Reviewed by Darin Adler.

        recent colorspace changes have fixed svg/custom/grayscale-gradient-mask.svg
        https://bugs.webkit.org/show_bug.cgi?id=43104

        New baselines for windows and linux for two tests affected by the bug fix
        for https://bugs.webkit.org/show_bug.cgi?id=42228 where I failed to rebaseline
        them properly at that time.

        * platform/chromium-linux/svg/custom/grayscale-gradient-mask-expected.checksum:
        * platform/chromium-win/svg/custom/grayscale-gradient-mask-expected.checksum:
        * platform/chromium-win/svg/custom/grayscale-gradient-mask-expected.png:
        * platform/chromium-win/svg/custom/mask-colorspace-expected.checksum: Added.
        * platform/chromium-win/svg/custom/mask-colorspace-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-06 Alex Nicolaou <anicolao@chromium.org>
abarth@webkit.org [Sat, 7 Aug 2010 04:27:34 +0000 (04:27 +0000)]
2010-08-06  Alex Nicolaou  <anicolao@chromium.org>

        Reviewed by Dirk Schulze.

        can't see anything wrong with the output for circle-in-mask-with-shadow.svg
        https://bugs.webkit.org/show_bug.cgi?id=43106

        This test has been affected by recent colorspace changes but the diffs are
        so slight as to be very difficult to detect. I'm reasonably confident
        these new baselines are OK.

        * platform/chromium-linux/svg/css/circle-in-mask-with-shadow-expected.checksum:
        * platform/chromium-linux/svg/css/circle-in-mask-with-shadow-expected.png:
        * platform/chromium-win/svg/css/circle-in-mask-with-shadow-expected.checksum:
        * platform/chromium-win/svg/css/circle-in-mask-with-shadow-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-06 Alex Nicolaou <anicolao@chromium.org>
abarth@webkit.org [Sat, 7 Aug 2010 04:11:20 +0000 (04:11 +0000)]
2010-08-06  Alex Nicolaou  <anicolao@chromium.org>

        Reviewed by Darin Adler.

        rebaseline masking-intro-01-f.svg - diffs are in the antialiasing
        https://bugs.webkit.org/show_bug.cgi?id=43107

        After some investigation, the antialiasing diffs were
        definitely verified to be due to the colorspace change
        made for https://bugs.webkit.org/show_bug.cgi?id=42228
        and I'm reasonably confident that these rebaselined
        outputs are good.

        * platform/chromium-linux/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-06 Robert Hogan <robert@webkit.org>
abarth@webkit.org [Sat, 7 Aug 2010 03:37:40 +0000 (03:37 +0000)]
2010-08-06  Robert Hogan  <robert@webkit.org>

        Reviewed by Adam Barth.

        Define setPrivateBrowsingEnabled()
        https://bugs.webkit.org/show_bug.cgi?id=42283

        Define the scope of 'private browsing' in WebKit
        See also https://bugs.webkit.org/show_bug.cgi?id=41801

        * page/Settings.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-06 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 7 Aug 2010 03:30:25 +0000 (03:30 +0000)]
2010-08-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Ojan Vafai.

        dump-as-markup should work in Firefox
        https://bugs.webkit.org/show_bug.cgi?id=43606

        Apparently Firefox lacks this API.

        * resources/dump-as-markup.js:
        (Markup._getMarkupForTextNode):
        (Markup._getSelectionMarker):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-06 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Sat, 7 Aug 2010 03:09:20 +0000 (03:09 +0000)]
2010-08-06  Dimitri Glazkov  <dglazkov@chromium.org>

        [Chromium/DRT] One more tweak to the expectation overrides to pacify the bot.

        * platform/chromium/drt_expectations.txt: Removed duplicate expectations.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-06 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 7 Aug 2010 01:56:07 +0000 (01:56 +0000)]
2010-08-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        REGRESSION (r64712): YouTube video pages have contents of <noembed> elements overlapping the video description
        https://bugs.webkit.org/show_bug.cgi?id=43605

        Show test progression.  We missed this regression when analyzing the
        expectation diffs because the DOM was correct and was a progression.

        * fast/dom/no-elements-expected.txt:
        * platform/mac/fast/parser/nofoo-tags-inside-paragraph-expected.txt:
2010-08-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        REGRESSION (r64712): YouTube video pages have contents of <noembed> elements overlapping the video description
        https://bugs.webkit.org/show_bug.cgi?id=43605

        The old parser used to drop <noembed> on the floor.  We're supposed to
        add it to the DOM, but we don't want to create a renderer for it.

        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::rendererIsNeeded):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-06 Tony Gentilcore <tonyg@chromium.org>
abarth@webkit.org [Sat, 7 Aug 2010 01:30:16 +0000 (01:30 +0000)]
2010-08-06  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Adam Barth.

        Fix style violations in Document
        https://bugs.webkit.org/show_bug.cgi?id=43657

        No new tests because no new functionality.

        * dom/Document.cpp:
        (WebCore::acceptsEditingFocus):
        (WebCore::Document::Document):
        (WebCore::Document::importNode):
        (WebCore::Document::adoptNode):
        (WebCore::Document::getElementById):
        (WebCore::Document::readyState):
        (WebCore::Document::createTreeWalker):
        (WebCore::Document::shouldScheduleLayout):
        (WebCore::Document::nextFocusableNode):
        (WebCore::Document::previousFocusableNode):
        (WebCore::Document::nodeAbsIndex):
        (WebCore::Document::nodeWithAbsIndex):
        (WebCore::Document::childTypeAllowed):
        (WebCore::Document::canReplaceChild):
        (WebCore::Document::recalcStyleSelector):
        (WebCore::Document::setFocusedNode):
        (WebCore::Document::attachNodeIterator):
        (WebCore::Document::detachNodeIterator):
        (WebCore::Document::parseQualifiedName):
        (WebCore::Document::getImageMap):
        (WebCore::Document::setInPageCache):
        (WebCore::Document::addMarker):
        (WebCore::Document::copyMarkers):
        (WebCore::Document::shiftMarkers):
        (WebCore::Document::setMarkersActive):
        (WebCore::Document::parentDocument):
        (WebCore::Document::topDocument):
        (WebCore::FormElementKeyHash::hash):
        (WebCore::Document::initSecurityContext):
        * dom/Document.h:
        (WebCore::Document::incDOMTreeVersion):
        (WebCore::Document::domTreeVersion):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKitTestRunner needs to be able to set the font smoothing type
jhoneycutt@apple.com [Sat, 7 Aug 2010 00:34:39 +0000 (00:34 +0000)]
WebKitTestRunner needs to be able to set the font smoothing type
https://bugs.webkit.org/show_bug.cgi?id=43406

Reviewed by Adam Roben.

WebKit2:

* Shared/FontSmoothingLevel.h: Added.
(WebKit::):

* Shared/WebPreferencesStore.cpp:
(WebKit::WebPreferencesStore::WebPreferencesStore):
Initialize fontSmoothingLevel.
(WebKit::WebPreferencesStore::swap):
Copy fontSmoothingLevel.

* Shared/WebPreferencesStore.h:
(WebKit::WebPreferencesStore::encode):
Encode fontSmoothingLevel.
(WebKit::WebPreferencesStore::decode):
Decode it.

* UIProcess/API/C/WKPreferencesPrivate.cpp: Added.
(WKPreferencesSetFontSmoothingLevel):
Get the font smoothing level from the WKFontSmoothingLevel, and call
WebPreferences::setFontSmoothingLevel().
(WKPreferencesGetFontSmoothingLevel):
Get the font smoothing level from WebPreferences, and translate it to a
WKFontSmoothingLevel.

* UIProcess/API/C/WKPreferencesPrivate.h: Added.
Declare the font smoothing levels, and declare functions to get and set
the level.

* UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::setFontSmoothingLevel):
Set fontSmoothingLevel and call update().
(WebKit::WebPreferences::fontSmoothingLevel):
Return the level.

* UIProcess/WebPreferences.h:
Declare getter and setter for fontSmoothingLevel.

* WebKit2.xcodeproj/project.pbxproj:
Add new files to project.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::preferencesDidChange):
Call platformPreferencesDidChange().

* WebProcess/WebPage/WebPage.h:
Declare platformPreferencesDidChange().

* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::platformPreferencesDidChange):
Stubbed.

* WebProcess/WebPage/qt/WebPageQt.cpp:
(WebKit::WebPage::platformPreferencesDidChange):
Stubbed.

* WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::WebPage::platformPreferencesDidChange):
On CG platforms, call wkSetFontSmoothingLevel(). This matches the code
in old WebKit's WebPreferences. Set the font rendering mode to either
normal (CG) or alternative (GDI) based on the font smoothing level. This
matches what was done in old WebKit's WebView.

* win/WebKit2.vcproj:
Add FontSmoothingLevel.h and WKPreferencesPrivate.{h,cpp} to project.

* win/WebKit2Generated.make:
Copy WKPreferencesPrivate.h.

WebKitTools:

* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::resetPreferencesToConsistentValues):
Set the font smoothing level to
kWKFontSmoothingLevelNoSubpixelAntiAliasing to match DRT.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-06 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Sat, 7 Aug 2010 00:07:46 +0000 (00:07 +0000)]
2010-08-06  Dimitri Glazkov  <dglazkov@chromium.org>

        [Chromium/DRT] Adjust expectations after my unexpectedly awful search-and-replace performance.

        * platform/chromium/drt_expectations.txt: Un-bungled test names.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-06 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Fri, 6 Aug 2010 23:47:54 +0000 (23:47 +0000)]
2010-08-06  Eric Carlson  <eric.carlson@apple.com>

        Unreviewed, release Qt build fix.

        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::containsPaintedContent): Guard call to toRenderVideo()
        with #if ENABLE(VIDEO).

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-06 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Fri, 6 Aug 2010 23:35:55 +0000 (23:35 +0000)]
2010-08-06  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        HTML5 "video" tag with poster frame defined "flashes" right before movie displays
        https://bugs.webkit.org/show_bug.cgi?id=37591
        <rdar://problem/5650561>

        If a video element has a poster frame, display it until the playback is requested or the movie's
        time is changed.

        Test: compositing/video/video-poster.html

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_displayMode.
        (WebCore::HTMLMediaElement::prepareForLoad): Set m_displayMode to Unknown.
        (WebCore::HTMLMediaElement::loadResource): Call updateDisplayState to let it set configure
        the poster, if necessary.
        (WebCore::HTMLMediaElement::noneSupported): updatePosterImage -> updateDisplayState.
        (WebCore::HTMLMediaElement::setNetworkState): Ditto.
        (WebCore::HTMLMediaElement::setReadyState): Ditto.
        (WebCore::HTMLMediaElement::finishSeek): Set display mode to Video so a video frame will be
        displayed if a poster is currently visible.
        (WebCore::HTMLMediaElement::mediaPlayerRepaint): updatePosterImage -> updateDisplayState.
        (WebCore::HTMLMediaElement::updatePlayState): Set display mode to Video.
        * html/HTMLMediaElement.h:
        (WebCore::HTMLMediaElement::displayMode): New.
        (WebCore::HTMLMediaElement::setDisplayMode): Ditto.
        (WebCore::HTMLMediaElement::updateDisplayState): Ditto.

        * html/HTMLVideoElement.cpp:
        (WebCore::HTMLVideoElement::HTMLVideoElement): Remove m_shouldDisplayPosterImage.
        (WebCore::HTMLVideoElement::attach): Call shouldDisplayPosterImage instead of checking
        m_shouldDisplayPosterImage directly.
        (WebCore::HTMLVideoElement::detach): Ditto.
        (WebCore::HTMLVideoElement::parseMappedAttribute): Set m_displayMode to Unknown before calling
        updateDisplayState so shouldDisplayPosterImage() will return the correct result. Remove the
        PLUGIN_PROXY_FOR_VIDEO code, it is now in updateDisplayState.
        (WebCore::HTMLVideoElement::setDisplayMode): Renamed from updatePosterImage and rework logic
        so we tell the media engine it is OK to display video frames when there is no poster, or
        once the media engine has something to display and the movie has started or seeked.
        (WebCore::HTMLVideoElement::updateDisplayState): New, manage display mode based on poster
        attribute.
        * html/HTMLVideoElement.h:
        (WebCore::HTMLVideoElement::shouldDisplayPosterImage):

        * platform/graphics/MediaPlayer.cpp:
        (WebCore::MediaPlayer::prepareForRendering): New, call media engine's prepareForRendering.
        * platform/graphics/MediaPlayer.h:
        * platform/graphics/MediaPlayerPrivate.h:
        (WebCore::MediaPlayerPrivateInterface::prepareForRendering):

        * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_isAllowedToRender.
        (WebCore::MediaPlayerPrivate::setUpVideoRendering):
        (WebCore::MediaPlayerPrivate::isReadyForVideoSetup): Renamed from isReadyForRendering.
        (WebCore::MediaPlayerPrivate::prepareForRendering): New, set m_isAllowedToRender and
        inform the client that render tree should be updated so we correctly switch from showing
        the poster, which often doens't use a layer, to showing video frames, which do.
        (WebCore::MediaPlayerPrivate::updateStates): Don't call setUpVideoRendering until
        isReadyForVideoSetup() returns true.
        (WebCore::MediaPlayerPrivate::supportsAcceleratedRendering): isReadyForRendering -> isReadyForVideoSetup

        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::containsPaintedContent): Only consider video when displaying
        video frames so a poster won't force compositing mode.

        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::requiresCompositingForVideo): Ditto.

        * rendering/RenderVideo.cpp:
        (WebCore::RenderVideo::shouldDisplayVideo): New, return true when not displaying a poster.
        * rendering/RenderVideo.h:

2010-08-06  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        HTML5 "video" tag with poster frame defined "flashes" right before movie displays
        https://bugs.webkit.org/show_bug.cgi?id=37591
        <rdar://problem/5650561>

        If a video element has a poster frame, display it until the playback is requested or the movie's
        time is changed. Test this by ensuring that an element with a poster doesn't have layers while
        and element with one does.

        * compositing/video/video-poster-expected.txt: Added.
        * compositing/video/video-poster.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoVersioning.
mrowe@apple.com [Fri, 6 Aug 2010 23:35:49 +0000 (23:35 +0000)]
Versioning.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-06 James Robinson <jamesr@chromium.org>
jamesr@google.com [Fri, 6 Aug 2010 23:29:27 +0000 (23:29 +0000)]
2010-08-06  James Robinson  <jamesr@chromium.org>

        Reviewed by Simon Fraser.

        Accelerated 2d canvases should get compositing layers
        https://bugs.webkit.org/show_bug.cgi?id=43362

        Allows for 2d canvas rendering contexts to use a GraphicsContext3D for
        accelerated rendering.  The rendering context holds the GraphicsContext3D
        alive and exposes it to the compositor.  The 3d context itself is passed
        down through the GraphicsContext to use for actual rendering:
        https://bug-43362-attachments.webkit.org/attachment.cgi?id=63557

        This approach will let us simultaneously prototype accelerated techniques
        for canvas 2d and revise the design of canvas elements without destabilizing
        all ports.

        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::getContext):
        (WebCore::HTMLCanvasElement::willDraw):
        (WebCore::HTMLCanvasElement::makeRenderingResultsAvailable):
        * html/canvas/CanvasRenderingContext.h:
        (WebCore::CanvasRenderingContext::paintRenderingResultsToCanvas):
        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
        (WebCore::CanvasRenderingContext2D::isAccelerated):
        (WebCore::CanvasRenderingContext2D::reset):
        (WebCore::CanvasRenderingContext2D::willDraw):
        (WebCore::CanvasRenderingContext2D::paintRenderingResultsToCanvas):
        * html/canvas/CanvasRenderingContext2D.h:
        (WebCore::CanvasRenderingContext2D::graphicsContext3D):
        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):
        * html/canvas/WebGLRenderingContext.h:
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/skia/GraphicsContextSkia.cpp:
        (WebCore::GraphicsContext::syncSoftwareCanvas):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-06 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 6 Aug 2010 23:23:58 +0000 (23:23 +0000)]
2010-08-06  Dimitri Glazkov  <dglazkov@chromium.org>

        [Chromium/DRT] Update expectation overrides for Windows.

        * platform/chromium/drt_expectations.txt: Added a bunch of failing tests.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fixes.
andersca@apple.com [Fri, 6 Aug 2010 23:15:55 +0000 (23:15 +0000)]
Build fixes.

* Platform/win/SharedMemoryWin.cpp:
(WebKit::SharedMemory::Handle::encode):
(WebKit::SharedMemory::Handle::decode):
* Shared/qt/UpdateChunk.cpp:
(WebKit::UpdateChunk::encode):
(WebKit::UpdateChunk::decode):
* Shared/qt/UpdateChunk.h:
* Shared/win/UpdateChunk.cpp:
(WebKit::UpdateChunk::encode):
(WebKit::UpdateChunk::decode):
* Shared/win/UpdateChunk.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix a missed variable rename.
jhoneycutt@apple.com [Fri, 6 Aug 2010 23:07:27 +0000 (23:07 +0000)]
Fix a missed variable rename.

Unreviewed.

* Scripts/old-run-webkit-tests:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChange all ArgumentEncoder and ArgumentDecoder references to pointers
andersca@apple.com [Fri, 6 Aug 2010 23:04:20 +0000 (23:04 +0000)]
Change all ArgumentEncoder and ArgumentDecoder references to pointers
https://bugs.webkit.org/show_bug.cgi?id=43651

Reviewed by Sam Weinig.

* Platform/CoreIPC/ArgumentCoder.h:
* Platform/CoreIPC/ArgumentDecoder.h:
* Platform/CoreIPC/Arguments.h:
* Platform/CoreIPC/Attachment.cpp:
* Platform/CoreIPC/Attachment.h:
* Platform/CoreIPC/mac/MachPort.h:
* Platform/SharedMemory.h:
* Platform/mac/SharedMemoryMac.cpp:
* Shared/DrawingAreaBase.cpp:
* Shared/DrawingAreaBase.h:
* Shared/WebEvent.h:
* Shared/WebNavigationDataStore.h:
* Shared/WebPreferencesStore.h:
* Shared/mac/UpdateChunk.cpp:
* Shared/mac/UpdateChunk.h:
* UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:
* UIProcess/ChunkedUpdateDrawingAreaProxy.h:
* UIProcess/DrawingAreaProxy.h:
* UIProcess/LayerBackedDrawingAreaProxy.cpp:
* UIProcess/LayerBackedDrawingAreaProxy.h:
* UIProcess/WebContext.cpp:
* UIProcess/WebContext.h:
* UIProcess/WebPageProxy.cpp:
* UIProcess/WebPageProxy.h:
* UIProcess/WebProcessProxy.cpp:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
* WebProcess/InjectedBundle/InjectedBundle.h:
* WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
* WebProcess/WebPage/ChunkedUpdateDrawingArea.h:
* WebProcess/WebPage/DrawingArea.h:
* WebProcess/WebPage/LayerBackedDrawingArea.cpp:
* WebProcess/WebPage/LayerBackedDrawingArea.h:
* WebProcess/WebPage/WebPage.cpp:
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebProcess.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agomac-wk2/Skipped should be used on Windows when running regression tests
jhoneycutt@apple.com [Fri, 6 Aug 2010 22:59:11 +0000 (22:59 +0000)]
mac-wk2/Skipped should be used on Windows when running regression tests
https://bugs.webkit.org/show_bug.cgi?id=43494

Reviewed by Adam Roben.

WebKitTools:

* Scripts/old-run-webkit-tests:
If the platform is win-wk2, also read the mac-wk2 skipped list.

LayoutTests:

* platform/win-wk2/Skipped:
Remove the tests copied from the mac-wk2 skipped list.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDon't try to allocate a vector unless we know the buffer can contain it
andersca@apple.com [Fri, 6 Aug 2010 22:39:28 +0000 (22:39 +0000)]
Don't try to allocate a vector unless we know the buffer can contain it
https://bugs.webkit.org/show_bug.cgi?id=43647

Reviewed by Sam Weinig.

* Platform/CoreIPC/ArgumentCoders.h:
(CoreIPC::):
Check that the argument decoder buffer actually can hold all the vector elements.

* Platform/CoreIPC/ArgumentDecoder.cpp:
(CoreIPC::ArgumentDecoder::bufferIsLargeEnoughtToContain):
Align the current position to the given alignment, add the size and check if the position is
past the end of the buffer.

* Platform/CoreIPC/ArgumentDecoder.h:
(CoreIPC::ArgumentDecoder::bufferIsLargeEnoughtToContain):
Get the size and alignment and call the other bufferIsLargeEnoughtToContain overload.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-06 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 6 Aug 2010 22:20:36 +0000 (22:20 +0000)]
2010-08-06  Eric Seidel  <eric@webkit.org>

        Reviewed by Chris Fleizach.

        Make AX Code use more specific RenderObject subclass types
        https://bugs.webkit.org/show_bug.cgi?id=43632

        No functional change, thus no tests.

        * accessibility/AXObjectCache.cpp:
        (WebCore::nodeHasRole):
         - Make this take a String instead of AtomicString, to avoid
           thrashing the atomic string hash.
           It would be better to take a const char* here, except
           one caller passes nullAtom.
        (WebCore::createFromRenderer):
         - Split this out from getOrCreate to make it simpler.
         - No longer needs to deal with setting a "result"
           pointer and can instead just return.
         - I've also made this function use RenderBoxModelObject*
           where appropriate.
        (WebCore::AXObjectCache::getOrCreate):
        * accessibility/AXObjectCache.h:
        * accessibility/AccessibilityImageMapLink.cpp:
        (WebCore::AccessibilityImageMapLink::AccessibilityImageMapLink):
         - Fix style.
        * accessibility/AccessibilityMenuList.cpp:
        (WebCore::AccessibilityMenuList::AccessibilityMenuList):
         - Use a more specific type.
        (WebCore::AccessibilityMenuList::renderer):
        * accessibility/AccessibilityMenuList.h:
        (WebCore::AccessibilityMenuList::create):
        * accessibility/AccessibilityMenuListPopup.cpp:
         - Need RenderMenuList.h since renderer() is a RenderMenuList*
        * accessibility/AccessibilityObject.cpp:
        (WebCore::renderListItemContainerForNode):
        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::renderBoxModelObject):
         - New helper function, similar to Node::renderBoxModelObject()
        (WebCore::isInlineWithContinuation):
        (WebCore::AccessibilityRenderObject::isNativeImage):
        (WebCore::AccessibilityRenderObject::isAttachment):
        (WebCore::AccessibilityRenderObject::isMultiSelectable):
        (WebCore::AccessibilityRenderObject::isReadOnly):
        (WebCore::AccessibilityRenderObject::isFieldset):
        (WebCore::AccessibilityRenderObject::actionElement):
        (WebCore::AccessibilityRenderObject::stringValue):
        (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
        (WebCore::AccessibilityRenderObject::setValue):
        (WebCore::AccessibilityRenderObject::widget):
        (WebCore::AccessibilityRenderObject::visiblePositionForPoint):
        (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
        (WebCore::AccessibilityRenderObject::renderObjectIsObservable):
        (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
        (WebCore::AccessibilityRenderObject::addChildren):
        (WebCore::msaaRoleForRenderer):
        * accessibility/AccessibilityRenderObject.h:
        * accessibility/AccessibilityTable.cpp:
        (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
        * accessibility/AccessibilityTable.h:
         - Remove unneeded "using namespace std".

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-06 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Fri, 6 Aug 2010 22:07:50 +0000 (22:07 +0000)]
2010-08-06  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Eric Seidel.

        Factor an AsyncScriptRunner out of Document
        https://bugs.webkit.org/show_bug.cgi?id=43633

        This copies the existing implementation exactly. In the future
        this will use PendingScript which handles ref counting without
        the need for those manual ref()/deref()s. This is also currently
        a trivial class, but a little more logic will be added to it to
        support <script async>.

        No new tests because no new functionality.

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * dom/AsyncScriptRunner.cpp: Added.
        (WebCore::AsyncScriptRunner::AsyncScriptRunner):
        (WebCore::AsyncScriptRunner::~AsyncScriptRunner):
        (WebCore::AsyncScriptRunner::executeScriptSoon):
        (WebCore::AsyncScriptRunner::suspend):
        (WebCore::AsyncScriptRunner::resume):
        (WebCore::AsyncScriptRunner::timerFired):
        * dom/AsyncScriptRunner.h: Added.
        (WebCore::AsyncScriptRunner::create):
        (WebCore::AsyncScriptRunner::hasPendingScripts):
        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::~Document):
        * dom/Document.h:
        (WebCore::Document::asyncScriptRunner):
        * dom/ScriptElement.cpp:
        (WebCore::ScriptElementData::notifyFinished):
        * page/PageGroupLoadDeferrer.cpp:
        (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
        (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-06 James Robinson <jamesr@chromium.org>
jamesr@google.com [Fri, 6 Aug 2010 21:58:55 +0000 (21:58 +0000)]
2010-08-06  James Robinson  <jamesr@chromium.org>

        Reviewed by Dimitri Glazkov.

        [chromium] Implement GLES2Canvas/Texture in terms of GraphicsContext3D instead of direct OpenGL calls
        https://bugs.webkit.org/show_bug.cgi?id=43608

        This converts all OpenGL calls in GLES2(Canvas|Texture) to calls on the corresponding GraphicsContext3D
        API, due to feedback on https://bugs.webkit.org/show_bug.cgi?id=43362.  Nearly all the changes are
        applying the regex s/gl([A-Z])/m_context->%1</ and removing unnecessary makeCurrent() calls.
        Other changes hilighted below.

        * platform/graphics/chromium/GLES2Canvas.cpp:
        (WebCore::affineTo3x3):
        (WebCore::GLES2Canvas::GLES2Canvas):
        (WebCore::GLES2Canvas::~GLES2Canvas):
        (WebCore::GLES2Canvas::clearRect):
        (WebCore::GLES2Canvas::fillRect):
        (WebCore::GLES2Canvas::drawTexturedRect):
        (WebCore::GLES2Canvas::applyCompositeOperator):
        (WebCore::GLES2Canvas::getQuadVertices):
        (WebCore::GLES2Canvas::getQuadIndices):
            - use new typed XXArray classes for buffer uploads
        (WebCore::loadShader):
        (WebCore::GLES2Canvas::getSimpleProgram):
        (WebCore::GLES2Canvas::getTexProgram):
        (WebCore::GLES2Canvas::createTexture):
        (WebCore::GLES2Canvas::checkGLError):
        * platform/graphics/chromium/GLES2Canvas.h:
        (WebCore::GLES2Canvas::context):
        * platform/graphics/chromium/GLES2Texture.cpp:
        (WebCore::GLES2Texture::GLES2Texture):
        (WebCore::GLES2Texture::~GLES2Texture):
        (WebCore::GLES2Texture::create):
        (WebCore::convertFormat):
        (WebCore::GLES2Texture::load):
        (WebCore::GLES2Texture::bind):
        * platform/graphics/chromium/GLES2Texture.h:
        * platform/graphics/skia/GraphicsContextSkia.cpp:
        (WebCore::GraphicsContext::fillRect):
            - add a missing restore() call to the H/W path
        * platform/graphics/skia/ImageSkia.cpp:
        (WebCore::drawBitmapGLES2):
        * platform/graphics/skia/PlatformContextSkia.cpp:
        (WebCore::PlatformContextSkia::setGraphicsContext3D):
        (WebCore::PlatformContextSkia::uploadSoftwareToHardware):
            - avoid applying CTM to uploads
        (WebCore::PlatformContextSkia::readbackHardwareToSoftware):
        * platform/graphics/skia/PlatformContextSkia.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDetect invalid CoreIPC messages and call didReceiveInvalidMessage
andersca@apple.com [Fri, 6 Aug 2010 21:52:03 +0000 (21:52 +0000)]
Detect invalid CoreIPC messages and call didReceiveInvalidMessage
https://bugs.webkit.org/show_bug.cgi?id=43643
<rdar://problem/7891069>

Reviewed by Adam Roben.

* Platform/CoreIPC/ArgumentDecoder.cpp:
(CoreIPC::ArgumentDecoder::alignBufferPosition):
If we can't correctly align the buffer position, mark the decoder as invalid.

* Platform/CoreIPC/ArgumentDecoder.h:
(CoreIPC::ArgumentDecoder::isInvalid):
Check if the argument decoder is valid.

(CoreIPC::ArgumentDecoder::markInvalid):
Mark the argument decoder as invalid, by setting its buffer position past its end position.

* Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::dispatchMessages):
Check if m_client is null before dispatching messages. If an argument decoder was marked invalid, call
Connection::Client::didReceiveInvalidMessage.

* Platform/CoreIPC/Connection.h:
(CoreIPC::Connection::Message::releaseArguments):
Rename destroy to releaseArguments and make it return a PassOwnPtr.

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::~WebProcessProxy):
Call releaseArguments instead of destroy.

(WebKit::WebProcessProxy::didReceiveInvalidMessage):
Kill the web process and invalidate its connection.

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didReceiveInvalidMessage):
Don't do anything, if the UI process is sending invalid messages there's not much we can do.

* WebProcess/WebProcess.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-06 James Robinson <jamesr@chromium.org>
jamesr@google.com [Fri, 6 Aug 2010 21:49:20 +0000 (21:49 +0000)]
2010-08-06  James Robinson  <jamesr@chromium.org>

        Reviewed by Simon Fraser.

        Composited canvas should be treated the same by the compositor and not be WebGL specific
        https://bugs.webkit.org/show_bug.cgi?id=43589

        Initializes the platformLayer as a CanvasLayerChromium, not a WebGLLayerChromium.
        The layer itself isn't WebGL-specific.

        * src/GraphicsContext3D.cpp:
        (WebCore::GraphicsContext3DInternal::initialize):
        (WebCore::GraphicsContext3DInternal::platformLayer):
        (WebCore::GraphicsContext3D::platformLayer):
2010-08-06  James Robinson  <jamesr@chromium.org>

        Reviewed by Simon Fraser.

        Composited canvas should be treated the same by the compositor and not be WebGL specific
        https://bugs.webkit.org/show_bug.cgi?id=43589

        This treats all GraphicsContext3D-backed layers the same instead of special casing WebGL.
        The cross-platform change is to rename GraphicsLayer::setContentsToWebGL() to
        GraphicsLayer::setContentsToCanvas() and to rename all implementations.

        This patch also renames the chromium class used for accelerating these layers.

        Cross platform changes:
        * WebCore.gypi:
        * platform/graphics/GraphicsLayer.h:
        (WebCore::GraphicsLayer::setContentsToCanvas):
            Rename the function on the base class. GraphicsLayerCA and GraphicsLayerChromium implement this.
        * rendering/RenderLayerBacking.cpp:
        (WebCore::isAcceleratedCanvas):
            Helper function to see if a renderer is associated with an accelerated compositing layer.
        (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
        (WebCore::RenderLayerBacking::containsPaintedContent):
        (WebCore::RenderLayerBacking::rendererContentChanged):
       Chromium specific changes:
        * platform/graphics/chromium/CanvasLayerChromium.cpp: Added.
        (WebCore::CanvasLayerChromium::create):
        (WebCore::CanvasLayerChromium::CanvasLayerChromium):
        (WebCore::CanvasLayerChromium::textureId):
        (WebCore::CanvasLayerChromium::updateTextureContents):
        (WebCore::CanvasLayerChromium::setContext):
        * platform/graphics/chromium/CanvasLayerChromium.h: Added.
        (WebCore::CanvasLayerChromium::drawsContent):
        (WebCore::CanvasLayerChromium::ownsTexture):
        (WebCore::CanvasLayerChromium::shaderProgramId):
        (WebCore::CanvasLayerChromium::setShaderProgramId):
        * platform/graphics/chromium/GraphicsLayerChromium.cpp:
        (WebCore::GraphicsLayerChromium::setContentsNeedsDisplay):
        (WebCore::GraphicsLayerChromium::setContentsToCanvas):
        * platform/graphics/chromium/GraphicsLayerChromium.h:
        (WebCore::GraphicsLayerChromium::):
        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::drawLayer):
        (WebCore::LayerRendererChromium::initializeSharedGLObjects):
        * platform/graphics/chromium/LayerRendererChromium.h:
        (WebCore::LayerRendererChromium::):
        * platform/graphics/chromium/WebGLLayerChromium.cpp: Removed.
        * platform/graphics/chromium/WebGLLayerChromium.h: Removed.
        Mac specific changes:
        * platform/graphics/mac/GraphicsLayerCA.h:
        (WebCore::GraphicsLayerCA::):
        * platform/graphics/mac/GraphicsLayerCA.mm:
        (WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
        (WebCore::GraphicsLayerCA::updateContentsCanvasLayer):
        (WebCore::GraphicsLayerCA::setContentsToCanvas):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-06 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Fri, 6 Aug 2010 21:45:55 +0000 (21:45 +0000)]
2010-08-06  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Eric Seidel.

        Add PluginView::bindingInstance() to PluginViewNone
        https://bugs.webkit.org/show_bug.cgi?id=42936

        * bindings/js/ScriptControllerEfl.cpp:
        (WebCore::ScriptController::createScriptInstanceForWidget): Removed workaround.
        * plugins/PluginViewNone.cpp: Added property svn:eol-style.
        (WebCore::PluginView::bindingInstance): Added missing method and use it on WinCE.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-06 Yongjun Zhang <yongjun_zhang@apple.com>
joepeck@webkit.org [Fri, 6 Aug 2010 21:22:35 +0000 (21:22 +0000)]
2010-08-06  Yongjun Zhang  <yongjun_zhang@apple.com>

        Reviewed by Eric Seidel.

        add "const" to WebChromeClient::webView().
        https://bugs.webkit.org/show_bug.cgi?id=43631

        Change WebChromeClient::webView() to be const because ChromeClient::didReceiveViewportArguments
        is const method now, and calling webView() inside port-specific didReceiveViewportArguments
        implementation fails compiling if webView() is not const.

        * WebCoreSupport/WebChromeClient.h:
        (WebChromeClient::webView):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd CoreIPC::MessageReceiver class
andersca@apple.com [Fri, 6 Aug 2010 20:40:51 +0000 (20:40 +0000)]
Add CoreIPC::MessageReceiver class
https://bugs.webkit.org/show_bug.cgi?id=43637

Reviewed by Adam Roben.

* Platform/CoreIPC/Connection.h:
(CoreIPC::Connection::MessageReceiver::~MessageReceiver):
Add MessageReceiver class and make Client inherit from it.

(CoreIPC::Connection::MessageReceiver::didReceiveSyncMessage):
Change didReceiveSyncMessage from being a pure virtual member function and make it
assert by default instead.

* UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:
* UIProcess/ChunkedUpdateDrawingAreaProxy.h:
Remove ChunkedUpdateDrawingAreaProxy::didReceiveSyncMessage.

* Shared/DrawingAreaBase.h:
Include "Connection.h" instead.

* UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::didReceiveSyncMessage):
Change didReceiveSyncMessage from being a pure virtual member function and make it
assert by default instead.

* WebProcess/WebProcess.cpp:
* WebProcess/WebProcess.h:
Remove didReceiveSyncMessage.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64867 268f45cc-cd09-0410-ab3c-d52691b4dbfc