WebKit.git
9 years ago2011-06-03 Alexis Menard <alexis.menard@openbossa.org>
alexis.menard@openbossa.org [Fri, 3 Jun 2011 12:04:22 +0000 (12:04 +0000)]
2011-06-03  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Benjamin Poulain.

        [Qt] Build fix of QtWebKit 2.2 when inside Qt tree with GCC 4.6.
        https://bugs.webkit.org/show_bug.cgi?id=61957

        When building inside the Qt source tree, qmake always append the mkspecs
        defines after ours. We have to workaround and make sure that we append
        our flags after the qmake variable used inside Qt. This workaround was provided
        by our qmake folks. We need to append in both case because qmake behave differently
        when called with -spec or via SUBDIR+=.

        * Source/WebKit.pri:
2011-06-03  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Benjamin Poulain.

        [Qt] Build fix of QtWebKit 2.2 when inside Qt tree with GCC 4.6.
        https://bugs.webkit.org/show_bug.cgi?id=61957

        When building inside the Qt source tree, qmake always append the mkspecs
        defines after ours. We have to workaround and make sure that we append
        our flags after the qmake variable used inside Qt. This workaround was provided
        by our qmake folks. We need to append in both case because qmake behave differently
        when called with -spec or via SUBDIR+=. This patch unbreak r87950 on Mac for Qt port.

        * JavaScriptCore.pro:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Update platform specific expected file after r87873.
ossy@webkit.org [Fri, 3 Jun 2011 11:20:37 +0000 (11:20 +0000)]
[Qt][WK2] Update platform specific expected file after r87873.

* platform/qt-wk2/fast/events/overflow-viewport-renderer-deleted-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-03 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Fri, 3 Jun 2011 11:10:29 +0000 (11:10 +0000)]
2011-06-03  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Martin Robinson.

        Focus and caret position should be updated when same-page links are followed
        https://bugs.webkit.org/show_bug.cgi?id=59737

        Update the caret position to the anchor's position after scrolling.

        This behavior is specific to the Gtk port and requested because of
        accessibility needs, that's why it's implemented in AXObjectCache.

        Test: platform/gtk/accessibility/caret-browsing-anchor-followed.html

        * accessibility/gtk/AXObjectCacheAtk.cpp:
        (WebCore::AXObjectCache::handleScrolledToAnchor): Make sure the
        caret is updated to be in the anchor's position after scrolling.

2011-06-03  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Martin Robinson.

        Focus and caret position should be updated when same-page links are followed
        https://bugs.webkit.org/show_bug.cgi?id=59737

        New layout test for testing this GTK-specific feature.

        * platform/gtk/accessibility/caret-browsing-anchor-followed-expected.txt: Added.
        * platform/gtk/accessibility/caret-browsing-anchor-followed.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-03 Dominic Cooney <dominicc@chromium.org>
dominicc@chromium.org [Fri, 3 Jun 2011 10:35:54 +0000 (10:35 +0000)]
2011-06-03  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Kent Tamura.

        Adds a test that keygen clones have the right shadow pseudoclass.
        https://bugs.webkit.org/show_bug.cgi?id=61984

        * fast/html/clone-keygen-expected.txt: Added.
        * fast/html/clone-keygen.html: Added.
        * platform/win/Skipped: Test needs DRT functionality not in this port.
2011-06-03  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Kent Tamura.

        Cloned keygen shadows should have -webkit-keygen-select pseudoclass.
        https://bugs.webkit.org/show_bug.cgi?id=61984

        When cloneNode's tag name-based cloning algorithm clones the
        KeygenSelectElements of a keygen shadow as select elements. These
        lack the -webkit-keygen-select pseudoclass.

        Test: fast/html/clone-keygen.html

        * html/HTMLKeygenElement.cpp:
        (WebCore::KeygenSelectElement::cloneElementWithoutAttributesAndChildren): Create a KeygenSelectElement when being cloned.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 MORITA Hajime <morrita@google.com>
morrita@google.com [Fri, 3 Jun 2011 10:31:13 +0000 (10:31 +0000)]
2011-06-02  MORITA Hajime  <morrita@google.com>

        Unreviewed ChangeLog fix.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-03 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Fri, 3 Jun 2011 10:08:00 +0000 (10:08 +0000)]
2011-06-03  Mario Sanchez Prada  <msanchez@igalia.com>

        Unreviewed, skipping test with different results in 32-bit and 64-bit.

        * platform/gtk/Skipped: Skipped test.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-03 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Fri, 3 Jun 2011 10:05:24 +0000 (10:05 +0000)]
2011-06-03  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Unref the SoupSession used by WebKitGtk+ at exit
        https://bugs.webkit.org/show_bug.cgi?id=60165

        WebKitGtk+ creates a SoupSession instance to handle network stuff
        that is never freed. We should unref that object at exit time.

        * webkit/webkitglobals.cpp:
        (webkitExit):
        (webkitInit):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Update platform specific expected files after r87873.
ossy@webkit.org [Fri, 3 Jun 2011 09:53:09 +0000 (09:53 +0000)]
[Qt] Update platform specific expected files after r87873.

* platform/qt/fast/events/overflow-viewport-renderer-deleted-expected.txt: Added.
* platform/qt/plugins/document-open-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][V8] build fix.
pvarga@webkit.org [Fri, 3 Jun 2011 08:57:49 +0000 (08:57 +0000)]
[Qt][V8] build fix.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-03 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Fri, 3 Jun 2011 08:36:53 +0000 (08:36 +0000)]
2011-06-03  Mario Sanchez Prada  <msanchez@igalia.com>

        Unreviewed. Test rebaseline for GTK after revision 87936.

        * platform/gtk/fast/repaint/repaint-across-writing-mode-boundary-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-03 Dominic Cooney <dominicc@chromium.org>
dominicc@chromium.org [Fri, 3 Jun 2011 08:36:04 +0000 (08:36 +0000)]
2011-06-03  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Kent Tamura.

        Adds a test that range input clones have the right kind of slider.
        https://bugs.webkit.org/show_bug.cgi?id=61982

        * fast/html/clone-range-expected.txt: Added.
        * fast/html/clone-range.html: Added.
        * platform/win/Skipped: Test needs DRT functionality not in this port.
2011-06-03  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Kent Tamura.

        Cloned range input sliders should be SliderThumbElements, not divs.
        https://bugs.webkit.org/show_bug.cgi?id=61982

        Test: fast/html/clone-range.html

        * html/shadow/SliderThumbElement.h:
        (WebCore::SliderThumbElement::cloneElementWithoutAttributesAndChildren): Create a SliderThumbElement when being cloned.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-03 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Fri, 3 Jun 2011 08:22:42 +0000 (08:22 +0000)]
2011-06-03  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Csaba Osztrogon√°c.

        [Qt] Organize the disabled features section in the Skipped list
        https://bugs.webkit.org/show_bug.cgi?id=61994

        Move all the tests for disabled features under the "Disabled
        features" section in the Skipped list. Use the name of the build flags to
        identify the features for better tracking.

        * platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-03 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Fri, 3 Jun 2011 07:47:41 +0000 (07:47 +0000)]
2011-06-03  Mario Sanchez Prada  <msanchez@igalia.com>

        Unreviewed, unskipping tests, now passing after reverting r87901.

        * platform/gtk/Skipped: Unskipped 3 tests.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 3 Jun 2011 07:23:53 +0000 (07:23 +0000)]
2011-06-02  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: add an option for automatically attaching to new workers
        https://bugs.webkit.org/show_bug.cgi?id=61930

        Worker list is extended with a checkbox that makes inspector attach to each
        new worker. Whenever a new worker context starts a new inspector window will
        be opened for it.

        Also worker agent and worker list will be updated when worker context is terminated.

        * inspector/Inspector.json:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::workerContextTerminatedImpl):
        * inspector/InspectorInstrumentation.h:
        (WebCore::InspectorInstrumentation::workerContextTerminated):
        * inspector/InspectorWorkerAgent.cpp:
        (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::~WorkerFrontendChannel):
        (WebCore::InspectorWorkerAgent::create):
        (WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
        (WebCore::InspectorWorkerAgent::clearFrontend):
        (WebCore::InspectorWorkerAgent::setAutoconnectToWorkers):
        (WebCore::InspectorWorkerAgent::didStartWorkerContext):
        (WebCore::InspectorWorkerAgent::workerContextTerminated):
        * inspector/InspectorWorkerAgent.h:
        * inspector/front-end/WorkerManager.js:
        (WebInspector.WorkerManager.prototype._workerCreated):
        (WebInspector.WorkerManager.prototype._workerTerminated):
        (WebInspector.WorkerManager.prototype.openWorkerInspector):
        (WebInspector.WorkerManager.prototype._openInspectorWindow):
        (WebInspector.WorkerManager.prototype.reset):
        (WebInspector.WorkerMessageForwarder.prototype.workerCreated):
        (WebInspector.WorkerMessageForwarder.prototype.workerTerminated):
        * inspector/front-end/WorkersSidebarPane.js:
        (WebInspector.WorkerListSidebarPane):
        (WebInspector.WorkerListSidebarPane.prototype._workerAdded):
        (WebInspector.WorkerListSidebarPane.prototype._workerRemoved):
        (WebInspector.WorkerListSidebarPane.prototype._workersCleared):
        (WebInspector.WorkerListSidebarPane.prototype._addWorker):
        (WebInspector.WorkerListSidebarPane.prototype._workerItemClicked):
        (WebInspector.WorkerListSidebarPane.prototype._autoattachToWorkersClicked):
        * inspector/front-end/inspector.js:
        (WebInspector.reset):
2011-06-02  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: add an option for automatically attaching to new workers
        https://bugs.webkit.org/show_bug.cgi?id=61930

        Notification about worker context termination are now sent to the inspector.

        * src/WebWorkerClientImpl.cpp:
        (WebKit::WebWorkerClientImpl::terminateWorkerContext):
        (WebKit::WebWorkerClientImpl::disconnectFromInspector):
        (WebKit::WebWorkerClientImpl::workerContextDestroyed):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Hayato Ito <hayato@chromium.org>
hayato@chromium.org [Fri, 3 Jun 2011 05:17:28 +0000 (05:17 +0000)]
2011-06-02  Hayato Ito  <hayato@chromium.org>

        Reviewed by Ryosuke Niwa.

        Show a shadow root node itself in Node::traverseNextNodeAcrossFrame.
        https://bugs.webkit.org/show_bug.cgi?id=61992

        It's better to show a shadow root node itself for debugging.
        Skipping it didn't add any values.

        No new tests since the function is only available in debug builds.

        * dom/Node.cpp:
        (WebCore::traverseNextNodeAcrossFrame):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 James Robinson <jamesr@chromium.org>
jamesr@google.com [Fri, 3 Jun 2011 03:12:49 +0000 (03:12 +0000)]
2011-06-02  James Robinson  <jamesr@chromium.org>

        Unreviewed, rolling out r87901.
        http://trac.webkit.org/changeset/87901
        https://bugs.webkit.org/show_bug.cgi?id=61894

        Might be responsible for performance regression on Chromium page cyclers, reverting to see...

        * loader/DocumentLoader.h:
        (WebCore::DocumentLoader::didTellClientAboutLoad):
        (WebCore::DocumentLoader::haveToldClientAboutLoad):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::loadedResourceFromMemoryCache):
        * loader/ResourceLoadNotifier.cpp:
        (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Fri, 3 Jun 2011 02:41:09 +0000 (02:41 +0000)]
2011-06-02  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Eric Seidel.

        Switch paintReplaced to use IntPoint
        https://bugs.webkit.org/show_bug.cgi?id=61891

        Switching paintReplaced to use IntPoint to represent the paint offset instead
        of a pair of ints.

        Also renaming the IntPoint flavor of IntRect::move to moveBy to clear up the
        fact that the IntPoint is added as an offset as opposed to being relocated
        to that point.

        No tests because this is just a refactoring.

        * page/FrameView.cpp:
        (WebCore::FrameView::invalidateScrollbarRect):
        (WebCore::FrameView::convertFromRenderer):
        (WebCore::FrameView::convertToRenderer):
        * platform/ScrollView.cpp:
        (WebCore::ScrollView::wheelEvent):
        * platform/ScrollbarThemeComposite.cpp:
        (WebCore::ScrollbarThemeComposite::invalidatePart):
        * platform/graphics/gpu/Texture.cpp
        (WebCore::Texture::updateSubRect)
        * platform/graphics/IntRect.h:
        (WebCore::IntRect::moveBy):
        * platform/mac/WidgetMac.mm:
        (WebCore::Widget::paint):
        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::paint):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::logicalRectToPhysicalRect):
        (WebCore::RenderBlock::selectionGaps):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::offsetFromContainer):
        (WebCore::RenderBox::computeRectForRepaint):
        (WebCore::RenderBox::localCaretRect):
        * rendering/RenderDetailsMarker.cpp:
        (WebCore::RenderDetailsMarker::paint):
        * rendering/RenderEmbeddedObject.cpp:
        (WebCore::RenderEmbeddedObject::paintReplaced):
        * rendering/RenderEmbeddedObject.h:
        * rendering/RenderHTMLCanvas.cpp:
        (WebCore::RenderHTMLCanvas::paintReplaced):
        * rendering/RenderHTMLCanvas.h:
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::paintReplaced):
        * rendering/RenderImage.h:
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::culledInlineVisualOverflowBoundingBox):
        * rendering/RenderLayer.cpp:
        (WebCore::expandClipRectForDescendantsAndReflection):
        (WebCore::RenderLayer::paintScrollCorner):
        (WebCore::RenderLayer::paintResizer):
        (WebCore::RenderLayer::paintChildLayerIntoColumns):
        (WebCore::RenderLayer::hitTestChildLayerColumns):
        (WebCore::RenderLayer::boundingBox):
        (WebCore::RenderLayer::setBackingNeedsRepaintInRect):
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
        (WebCore::paintScrollbar):
        (WebCore::RenderLayerBacking::paintContents):
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::calculateCompositedBounds):
        (WebCore::RenderLayerCompositor::layerWillBeRemoved):
        (WebCore::paintScrollbar):
        (WebCore::RenderLayerCompositor::paintContents):
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::controlClipRect):
        * rendering/RenderListItem.cpp:
        (WebCore::RenderListItem::positionListMarker):
        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::paint):
        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::paint):
        * rendering/RenderReplaced.h:
        (WebCore::RenderReplaced::paintReplaced):
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::computeRectForRepaint):
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::controlClipRect):
        * rendering/RenderVideo.cpp:
        (WebCore::RenderVideo::paintReplaced):
        * rendering/RenderVideo.h:
        * rendering/RenderView.cpp:
        (WebCore::RenderView::repaintViewRectangle):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 James Robinson <jamesr@chromium.org>
commit-queue@webkit.org [Fri, 3 Jun 2011 02:34:31 +0000 (02:34 +0000)]
2011-06-02  James Robinson  <jamesr@chromium.org>

        Reviewed by Dimitri Glazkov.

        [chromium][V8] Add trace events for timer fires and event listener dispatches
        https://bugs.webkit.org/show_bug.cgi?id=61977

        Adds TRACE_EVENT macro around timer and event listener dispatches.  When tracing (a chromium feature) is
        enabled, this allows correlating these events with painting, compositing, and everything else in chromium that
        is traced.  When tracing is disabled, this macro does nothing useful.  Trace points are very cheap when tracing
        is disabled so this should have no performance impact for non-developers.

        * bindings/v8/ScheduledAction.cpp:
        (WebCore::ScheduledAction::execute):
        * bindings/v8/V8EventListener.cpp:
        (WebCore::V8EventListener::callListenerFunction):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 John Bates <jbates@google.com>
commit-queue@webkit.org [Fri, 3 Jun 2011 02:10:44 +0000 (02:10 +0000)]
2011-06-02  John Bates  <jbates@google.com>

        Reviewed by James Robinson.

        DrawingBufferChromium cleanup:
        - Correct FIXME comment about synchronization.
        - Remove unnecessary DrawingBufferInternal indirection struct
          and its unused offscreenColorTexture member.
        https://bugs.webkit.org/show_bug.cgi?id=61953

        * platform/graphics/chromium/DrawingBufferChromium.cpp:
        (WebCore::DrawingBuffer::DrawingBuffer):
        (WebCore::DrawingBuffer::~DrawingBuffer):
        (WebCore::DrawingBuffer::publishToPlatformLayer):
        (WebCore::DrawingBuffer::didReset):
        (WebCore::DrawingBuffer::platformLayer):
        * platform/graphics/gpu/DrawingBuffer.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
caio.oliveira@openbossa.org [Fri, 3 Jun 2011 01:44:54 +0000 (01:44 +0000)]
2011-06-02  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] Fix enum order in qwebpage.h public API header
        https://bugs.webkit.org/show_bug.cgi?id=61959

        Since qwebpage.h is a public header, we can't change the values of
        the enumerations. This patch moves the new enumeration to the end
        of the list. As a bonus, adds a missing entry in
        editorCommandWebActions table.

        * Api/qwebpage.cpp:
        * Api/qwebpage.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Fri, 3 Jun 2011 01:21:24 +0000 (01:21 +0000)]
2011-06-02  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: ResourceCookiesView.resize() is missing
        https://bugs.webkit.org/show_bug.cgi?id=61868

        * inspector/front-end/ResourceCookiesView.js:
        (WebInspector.ResourceCookiesView.prototype.resize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Fri, 3 Jun 2011 01:15:25 +0000 (01:15 +0000)]
2011-06-02  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        REGRESSION(r87014): Cloned text <input> doesn't work well.
        https://bugs.webkit.org/show_bug.cgi?id=61909

        * fast/forms/textfield-clone-expected.txt: Added.
        * fast/forms/textfield-clone.html: Added.
2011-06-02  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        REGRESSION(r87014): Cloned text <input> doesn't work well.
        https://bugs.webkit.org/show_bug.cgi?id=61909

        The default implementation of Element::cloneNode() creates a clone
        node by Document::createElement(). So, if a customized class is used for
        shadow nodes, cloneNode() doesn't create a node of the correct class.
        Such custom classes need to override Element::
        cloneElementWithoutAttributesAndChildren().

        TextFieldInputType and SearchInputType had references to shadow nodes
        initialized in createShadowSubtree(). However createShadowSubtree() is
        not called if the host node is cloned. The accessors for shadow nodes
        should search a shadow tree.

        Test: fast/forms/textfield-clone.html

        * html/SearchInputType.cpp:
          Remove data members for shadow nodes, and the accessors search the
          shadow tree for the requested node by TreeScope::getElementById().
        (WebCore::SearchInputType::SearchInputType):
        (WebCore::innerBlockId):
        (WebCore::resultButtonId):
        (WebCore::cancelButtonId):
        (WebCore::SearchInputType::createShadowSubtree):
        (WebCore::SearchInputType::innerBlockElement):
        (WebCore::SearchInputType::resultsButtonElement):
        (WebCore::SearchInputType::cancelButtonElement):
        * html/SearchInputType.h:
        * html/TextFieldInputType.cpp: ditto.
        (WebCore::TextFieldInputType::TextFieldInputType):
        (WebCore::TextFieldInputType::innerTextId):
        (WebCore::spinButtonId):
        (WebCore::TextFieldInputType::speechButtonId):
        (WebCore::TextFieldInputType::appendChildAndSetId):
        (WebCore::TextFieldInputType::createShadowSubtree):
        (WebCore::TextFieldInputType::getShadowElementById):
        (WebCore::TextFieldInputType::innerTextElement):
        (WebCore::TextFieldInputType::innerSpinButtonElement):
        (WebCore::TextFieldInputType::speechButtonElement):
        * html/TextFieldInputType.h:
        * html/shadow/TextControlInnerElements.cpp:
          Overrides cloneElementWithoutAttributesAndChildren() in order that cloneNode()
          produces an instance of the correct class.
        (WebCore::TextControlInnerElement::cloneElementWithoutAttributesAndChildren):
        (WebCore::TextControlInnerTextElement::cloneElementWithoutAttributesAndChildren):
        (WebCore::SearchFieldResultsButtonElement::cloneElementWithoutAttributesAndChildren):
        (WebCore::SearchFieldCancelButtonElement::cloneElementWithoutAttributesAndChildren):
        (WebCore::SpinButtonElement::cloneElementWithoutAttributesAndChildren):
        (WebCore::InputFieldSpeechButtonElement::cloneElementWithoutAttributesAndChildren):
        * html/shadow/TextControlInnerElements.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 3 Jun 2011 01:13:44 +0000 (01:13 +0000)]
2011-06-02  Adam Barth  <abarth@webkit.org>

        Tweaks to which kind of failure we expect.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-28 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 3 Jun 2011 01:05:56 +0000 (01:05 +0000)]
2011-05-28  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Remove PasteboardHelperGtk
        https://bugs.webkit.org/show_bug.cgi?id=61690

        Remove the virtual methods from PasteboardHelper, so that PasteboardHelperGtk
        can be removed. Since the GtkClipboard IDs are verified to be the same between
        WebKit and WebCore we no longer need to communicate from WebCore to WebKit to
        get them.

        No new tests. This is just a code refactor.

        * platform/Pasteboard.h: Remove GTK+ specific methods. They are no longer needed.
        * platform/gtk/ClipboardGtk.cpp: Remove the m_helper member and access the
        PasteboardHelper singleton directly.
        * platform/gtk/ClipboardGtk.h: Ditto.
        * platform/gtk/PasteboardGtk.cpp: Ditto.
        * platform/gtk/PasteboardHelper.cpp:
        (WebCore::removeMarkupPrefix): Remove an extra line.
        (WebCore::PasteboardHelper::defaultPasteboardHelper): Added this static getter
        for the singleton.
        (WebCore::PasteboardHelper::PasteboardHelper): Moved the contents of initTargetList here.
        (WebCore::PasteboardHelper::getCurrentClipboard): Instead of talking with WebKit to determine
        whether or not to use the primary selection clipboard, just use our new member.
        (WebCore::PasteboardHelper::fillSelectionData): Use our local enum to get the ID.
        (WebCore::PasteboardHelper::targetListForDataObject): Ditto.
        (WebCore::PasteboardHelper::dropAtomsForContext): Ditto.
        (WebCore::getClipboardContentsCallback): Ditto.
        * platform/gtk/PasteboardHelper.h: PasteboardHelper now keeps track of whether or
        not to use the primary selection clipboard internally.
        (WebCore::PasteboardHelper::setUsePrimarySelectionClipboard): Added.
        (WebCore::PasteboardHelper::usePrimarySelectionClipboard): Added.
2011-05-28  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Remove PastboardHelperGtk
        https://bugs.webkit.org/show_bug.cgi?id=61690

        Remove PasteboardHelperGtk and talk directly to WebCore for pasteboard
        activity. This change moves the PasteboardHelper singleton from WebKit
        to WebCore.

        * GNUmakefile.am: Remove PasteboardHelperGtk from the source list.
        * WebCoreSupport/AssertMatchingEnums.cpp: Added assertions verifying that the
        WebCore versions of the GtkClipboard enums match those in the WebKit API.
        * WebCoreSupport/DragClientGtk.cpp:
        (WebKit::DragClient::startDrag): Access the pasteboard helper via a static method.
        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::setSelectionPrimaryClipboardIfNeeded): Ditto. Call into the helper to specify
        that the current clipboard is selection primary now.
        * WebCoreSupport/PasteboardHelperGtk.cpp: Removed.
        * webkit/webkitglobals.cpp: Remove function to set and get the pasteboard helper.
        * webkit/webkitglobalsprivate.h: Ditto.
        * webkit/webkitwebview.cpp:
        (webkit_web_view_button_press_event): Access the pasteboard helper via a static method.
        (webkit_web_view_drag_data_get): Ditto.
        (webkit_web_view_drag_motion): Ditto.
        (webkit_web_view_drag_data_received): Ditto.
        (webkit_web_view_init): Ditto.
        (webkit_web_view_get_copy_target_list): Ditto.
        (webkit_web_view_get_paste_target_list): Ditto.
        * webkit/webkitwebviewprivate.h: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 3 Jun 2011 00:52:55 +0000 (00:52 +0000)]
2011-06-02  Adam Barth  <abarth@webkit.org>

        This process is converging (hopefully).

        * platform/chromium-mac/fast/backgrounds/svg-as-mask-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 3 Jun 2011 00:44:59 +0000 (00:44 +0000)]
2011-06-02  Adam Barth  <abarth@webkit.org>

        Some more fallout from http://trac.webkit.org/changeset/87955, this time on Windows.

        * platform/chromium-win-vista/fast/forms/validation-message-appearance-expected.png: Removed.
        * platform/chromium-win/fast/borders/border-radius-huge-assert-expected.png:
        * platform/chromium-win/fast/forms/validation-message-appearance-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 3 Jun 2011 00:30:58 +0000 (00:30 +0000)]
2011-06-02  Adam Barth  <abarth@webkit.org>

        This test is flaky on Linux.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 3 Jun 2011 00:28:10 +0000 (00:28 +0000)]
2011-06-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mark Rowe.

        Assert when trying to unload a module that failed to load
        https://bugs.webkit.org/show_bug.cgi?id=61980

        Remove an invalid ASSERT; it's OK for m_bundle to be null if the bundle failed to load.

        * Platform/mac/ModuleMac.mm:
        (WebKit::Module::unload):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 3 Jun 2011 00:21:04 +0000 (00:21 +0000)]
2011-06-02  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Tony Chang.

        NRWT needs a way to log to a file without including backspaces without needing --verbose
        https://bugs.webkit.org/show_bug.cgi?id=60328

        This change modifies NRWT so that if it can tell if it is
        writing to a terminal, it will overwrite any messages printed
        in the 'one-line-progress' and 'updates' print options, and if
        not (or if --verbose was specified) the messages will be printed
        without backspaces.

        If the overwriting updates are disabled, one-line-progress will
        only print every 10 seconds instead of on every update. This
        ensures that we still get updates once in a while while the
        tests are running, even if we're not in --verbose mode. Note
        that one-line-progress will now still be printed in --verbose,
        since it's useful as long as you're not flooded with the
        updates.

        * Scripts/webkitpy/layout_tests/layout_package/manager.py:
        * Scripts/webkitpy/layout_tests/layout_package/printing.py:
        * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 3 Jun 2011 00:16:38 +0000 (00:16 +0000)]
2011-06-02  Adam Barth  <abarth@webkit.org>

        The next round of updated baselines after
        http://trac.webkit.org/changeset/87955.  Again, these all look fine to
        visual inspection.

        * platform/chromium-mac-leopard/fast/css/shadow-multiple-expected.png: Added.
        * platform/chromium-mac/fast/backgrounds/background-leakage-expected.png: Added.
        * platform/chromium-mac/fast/backgrounds/background-leakage-transforms-expected.png: Added.
        * platform/chromium-mac/fast/backgrounds/svg-as-background-1-expected.png:
        * platform/chromium-mac/fast/backgrounds/svg-as-mask-expected.png: Removed.
        * platform/chromium-mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.png:
        * platform/chromium-mac/fast/blockflow/border-styles-vertical-lr-expected.png: Added.
        * platform/chromium-mac/fast/blockflow/border-styles-vertical-rl-expected.png: Added.
        * platform/chromium-mac/fast/blockflow/border-vertical-lr-expected.png:
        * platform/chromium-mac/fast/blockflow/box-shadow-horizontal-bt-expected.png:
        * platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.png:
        * platform/chromium-mac/fast/blockflow/box-shadow-vertical-rl-expected.png:
        * platform/chromium-mac/fast/borders/border-radius-circle-expected.png: Added.
        * platform/chromium-mac/fast/borders/border-radius-different-width-001-expected.png: Added.
        * platform/chromium-mac/fast/borders/border-radius-groove-01-expected.png: Added.
        * platform/chromium-mac/fast/borders/border-radius-groove-02-expected.png: Added.
        * platform/chromium-mac/fast/borders/border-radius-groove-03-expected.png: Added.
        * platform/chromium-mac/fast/borders/border-radius-huge-assert-expected.png: Added.
        * platform/chromium-mac/fast/borders/border-radius-inline-flow-expected.png: Added.
        * platform/chromium-mac/fast/borders/border-radius-inset-outset-expected.png: Added.
        * platform/chromium-mac/fast/borders/border-radius-wide-border-02-expected.png: Added.
        * platform/chromium-mac/fast/borders/border-radius-wide-border-03-expected.png: Added.
        * platform/chromium-mac/fast/borders/border-radius-wide-border-04-expected.png: Added.
        * platform/chromium-mac/fast/borders/border-styles-split-expected.png: Added.
        * platform/chromium-mac/fast/borders/borderRadiusDashed01-expected.png:
        * platform/chromium-mac/fast/borders/borderRadiusDashed04-expected.png:
        * platform/chromium-mac/fast/borders/borderRadiusDashed05-expected.png: Added.
        * platform/chromium-mac/fast/borders/borderRadiusDashed06-expected.png: Added.
        * platform/chromium-mac/fast/borders/borderRadiusDotted02-expected.png: Added.
        * platform/chromium-mac/fast/borders/borderRadiusDotted03-expected.png: Added.
        * platform/chromium-mac/fast/borders/borderRadiusDotted04-expected.png: Added.
        * platform/chromium-mac/fast/borders/borderRadiusDotted05-expected.png: Added.
        * platform/chromium-mac/fast/borders/borderRadiusDotted06-expected.png:
        * platform/chromium-mac/fast/borders/borderRadiusDouble04-expected.png: Added.
        * platform/chromium-mac/fast/borders/borderRadiusDouble05-expected.png: Added.
        * platform/chromium-mac/fast/borders/borderRadiusDouble06-expected.png: Added.
        * platform/chromium-mac/fast/borders/borderRadiusDouble07-expected.png: Added.
        * platform/chromium-mac/fast/borders/borderRadiusDouble08-expected.png: Added.
        * platform/chromium-mac/fast/borders/borderRadiusDouble09-expected.png: Added.
        * platform/chromium-mac/fast/borders/borderRadiusInvalidColor-expected.png: Added.
        * platform/chromium-mac/fast/borders/mixed-border-styles-radius-expected.png: Added.
        * platform/chromium-mac/fast/borders/mixed-border-styles-radius2-expected.png: Added.
        * platform/chromium-mac/fast/borders/webkit-border-radius-expected.png: Added.
        * platform/chromium-mac/fast/box-shadow/basic-shadows-expected.png:
        * platform/chromium-mac/fast/box-shadow/shadow-tiling-artifact-expected.png: Added.
        * platform/chromium-mac/fast/box-shadow/spread-expected.png:
        * platform/chromium-mac/fast/css/border-radius-non-negative-expected.png: Added.
        * platform/chromium-mac/fast/css/box-shadow-and-border-radius-expected.png: Added.
        * platform/chromium-mac/fast/css/shadow-multiple-expected.png: Added.
        * platform/chromium-mac/fast/forms/basic-selects-expected.png: Added.
        * platform/chromium-mac/fast/forms/menulist-clip-expected.png: Added.
        * platform/chromium-mac/fast/forms/menulist-option-wrap-expected.png: Added.
        * platform/chromium-mac/fast/forms/menulist-restrict-line-height-expected.png: Added.
        * platform/chromium-mac/fast/forms/menulist-separator-painting-expected.png: Added.
        * platform/chromium-mac/fast/forms/menulist-style-color-expected.png: Added.
        * platform/chromium-mac/fast/forms/select-background-none-expected.png:
        * platform/chromium-mac/fast/forms/select-baseline-expected.png: Added.
        * platform/chromium-mac/fast/forms/select-empty-option-height-expected.png: Added.
        * platform/chromium-mac/fast/forms/validation-message-appearance-expected.png: Added.
        * platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.png:
        * platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
        * platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png: Added.
        * platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.png: Added.
        * platform/chromium-mac/svg/carto.net/button-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Aaron Colwell <acolwell@chromium.org>
commit-queue@webkit.org [Fri, 3 Jun 2011 00:01:53 +0000 (00:01 +0000)]
2011-06-02  Aaron Colwell  <acolwell@chromium.org>

        Reviewed by David Levin.

        Add mediaTimeForTimeValue() implementation.
        https://bugs.webkit.org/show_bug.cgi?id=61555

        * public/WebMediaPlayer.h:
        * src/WebMediaPlayerClientImpl.cpp:
        (WebKit::WebMediaPlayerClientImpl::mediaTimeForTimeValue):
        * src/WebMediaPlayerClientImpl.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Thu, 2 Jun 2011 23:49:08 +0000 (23:49 +0000)]
2011-06-02  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Eric Seidel.

        Teach InlineBox about FloatPoint
        https://bugs.webkit.org/show_bug.cgi?id=44412

        Original patch by Eric Seidel. Updated by me.

        This is another step towards more point/size
        usage throughout the rendering tree.

        Added left(), right(), top(), and bottom() methods
        to InlineBox. Removed m_x, and m_y and replaced them
        with a single m_topLeft member.

        No new tests since this is just a refactoring.

        * rendering/EllipsisBox.cpp:
        (WebCore::EllipsisBox::paint):
        (WebCore::EllipsisBox::selectionRect):
        (WebCore::EllipsisBox::paintSelection):
        (WebCore::EllipsisBox::nodeAtPoint):
        * rendering/EllipsisBox.h:
        (WebCore::EllipsisBox::EllipsisBox):
        * rendering/InlineBox.cpp:
        (WebCore::InlineBox::adjustPosition):
        (WebCore::InlineBox::canAccommodateEllipsis):
        * rendering/InlineBox.h:
        (WebCore::InlineBox::InlineBox):
        (WebCore::InlineBox::setX):
        (WebCore::InlineBox::x):
        (WebCore::InlineBox::left):
        (WebCore::InlineBox::setY):
        (WebCore::InlineBox::y):
        (WebCore::InlineBox::top):
        (WebCore::InlineBox::topLeft):
        (WebCore::InlineBox::right):
        (WebCore::InlineBox::bottom):
        (WebCore::InlineBox::logicalLeft):
        (WebCore::InlineBox::setLogicalLeft):
        (WebCore::InlineBox::logicalTop):
        (WebCore::InlineBox::setLogicalTop):
        (WebCore::InlineBox::logicalFrameRect):
        * rendering/InlineFlowBox.h:
        (WebCore::InlineFlowBox::frameRectIncludingLineHeight):
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::placeEllipsisBox):
        (WebCore::InlineTextBox::paintTextMatchMarker):
        (WebCore::InlineTextBox::computeRectForReplacementMarker):
        * rendering/RenderText.cpp:
        (WebCore::RenderText::firstRunX):
        (WebCore::RenderText::firstRunY):
        * rendering/RenderTreeAsText.cpp:
        (WebCore::writeTextRun):
        * rendering/RootInlineBox.cpp:
        (WebCore::RootInlineBox::placeEllipsis):
        * rendering/svg/RenderSVGText.cpp:
        (WebCore::RenderSVGText::positionForPoint):
        * rendering/svg/SVGInlineTextBox.h:
        (WebCore::SVGInlineTextBox::selectionTop):
        * rendering/svg/SVGRootInlineBox.cpp:
        (WebCore::SVGRootInlineBox::closestLeafChildForPosition):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 2 Jun 2011 23:45:48 +0000 (23:45 +0000)]
2011-06-02  Adam Barth  <abarth@webkit.org>

        First round of baseline updates after
        http://trac.webkit.org/changeset/87955 changed some floating point
        calculations for borders.  Visually, these appear to all be fine.

        * platform/chromium-gpu-linux/media/video-zoom-controls-expected.png:
        * platform/chromium-gpu-mac/media/video-zoom-controls-expected.png:
        * platform/chromium-gpu-win/media/video-zoom-controls-expected.png:
        * platform/chromium-linux-x86/fast/backgrounds: Added.
        * platform/chromium-linux-x86/fast/backgrounds/border-radius-split-background-expected.png: Added.
        * platform/chromium-linux-x86/fast/backgrounds/border-radius-split-background-image-expected.png: Added.
        * platform/chromium-linux-x86/fast/borders/border-radius-constraints-expected.png: Added.
        * platform/chromium-linux-x86/fast/borders/border-radius-split-inline-expected.png: Added.
        * platform/chromium-linux-x86/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
        * platform/chromium-linux-x86/fast/borders/borderRadiusArcs01-expected.png:
        * platform/chromium-linux-x86/fast/borders/borderRadiusDashed02-expected.png:
        * platform/chromium-linux-x86/fast/borders/borderRadiusDashed03-expected.png:
        * platform/chromium-linux-x86/fast/borders/borderRadiusDotted01-expected.png:
        * platform/chromium-linux-x86/fast/borders/borderRadiusDouble01-expected.png:
        * platform/chromium-linux-x86/fast/borders/borderRadiusDouble02-expected.png:
        * platform/chromium-linux-x86/fast/borders/borderRadiusDouble03-expected.png:
        * platform/chromium-linux-x86/fast/borders/borderRadiusGroove01-expected.png:
        * platform/chromium-linux-x86/fast/borders/borderRadiusGroove02-expected.png:
        * platform/chromium-linux-x86/fast/borders/borderRadiusInset01-expected.png:
        * platform/chromium-linux-x86/fast/borders/borderRadiusOutset01-expected.png:
        * platform/chromium-linux-x86/fast/borders/borderRadiusRidge01-expected.png:
        * platform/chromium-linux-x86/fast/borders/borderRadiusSolid01-expected.png:
        * platform/chromium-linux-x86/fast/borders/borderRadiusSolid02-expected.png:
        * platform/chromium-linux-x86/fast/borders/borderRadiusSolid03-expected.png:
        * platform/chromium-linux-x86/fast/borders/borderRadiusSolid04-expected.png: Added.
        * platform/chromium-linux-x86/fast/borders/different-color-borders-expected.png: Added.
        * platform/chromium-linux-x86/fast/borders/fieldsetBorderRadius-expected.png: Added.
        * platform/chromium-linux-x86/fast/box-shadow/inset-box-shadows-expected.png: Added.
        * platform/chromium-linux-x86/fast/box-shadow/inset-expected.png: Added.
        * platform/chromium-linux-x86/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png:
        * platform/chromium-linux-x86/fast/box-shadow/spread-multiple-inset-expected.png: Added.
        * platform/chromium-linux-x86/fast/clip: Added.
        * platform/chromium-linux-x86/fast/clip/overflow-border-radius-clip-expected.png: Added.
        * platform/chromium-linux-x86/fast/css/nested-rounded-corners-expected.png: Added.
        * platform/chromium-linux-x86/fast/repaint/border-radius-repaint-expected.png:
        * platform/chromium-linux-x86/fast/transforms: Added.
        * platform/chromium-linux-x86/fast/transforms/shadows-expected.png: Added.
        * platform/chromium-linux-x86/media: Added.
        * platform/chromium-linux-x86/media/video-zoom-controls-expected.png: Added.
        * platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-52-t-expected.png: Added.
        * platform/chromium-linux-x86/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.png: Added.
        * platform/chromium-linux-x86/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.png: Added.
        * platform/chromium-linux-x86/svg/custom/dasharrayOrigin-expected.png: Added.
        * platform/chromium-linux-x86/svg/custom/fractional-rects-expected.png: Added.
        * platform/chromium-linux-x86/svg/custom/gradient-rotated-bbox-expected.png: Added.
        * platform/chromium-linux-x86/svg/custom/rounded-rects-expected.png: Added.
        * platform/chromium-linux-x86/svg/custom/svg-fonts-in-html-expected.png: Added.
        * platform/chromium-linux-x86/svg/hixie/perf/001-expected.png:
        * platform/chromium-linux-x86/svg/hixie/perf/002-expected.png:
        * platform/chromium-linux-x86/svg/wicd/rightsizing-grid-expected.png:
        * platform/chromium-linux-x86/svg/wicd/test-scalable-background-image1-expected.png:
        * platform/chromium-linux/fast/backgrounds/border-radius-split-background-expected.png:
        * platform/chromium-linux/fast/backgrounds/border-radius-split-background-image-expected.png:
        * platform/chromium-linux/fast/backgrounds/gradient-background-leakage-expected.png:
        * platform/chromium-linux/fast/borders/border-radius-constraints-expected.png:
        * platform/chromium-linux/fast/borders/border-radius-split-inline-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusArcs01-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusDashed02-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusDashed03-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusDotted01-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusDouble01-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusDouble02-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusDouble03-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusGroove01-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusGroove02-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusInset01-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusOutset01-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusRidge01-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusSolid01-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusSolid02-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusSolid03-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusSolid04-expected.png:
        * platform/chromium-linux/fast/borders/different-color-borders-expected.png:
        * platform/chromium-linux/fast/borders/fieldsetBorderRadius-expected.png:
        * platform/chromium-linux/fast/box-shadow/inset-box-shadows-expected.png:
        * platform/chromium-linux/fast/box-shadow/inset-expected.png:
        * platform/chromium-linux/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png:
        * platform/chromium-linux/fast/box-shadow/spread-multiple-inset-expected.png:
        * platform/chromium-linux/fast/clip/overflow-border-radius-clip-expected.png:
        * platform/chromium-linux/fast/css/nested-rounded-corners-expected.png:
        * platform/chromium-linux/fast/repaint/border-radius-repaint-expected.png:
        * platform/chromium-linux/fast/transforms/shadows-expected.png:
        * platform/chromium-linux/media/video-zoom-controls-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-52-t-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.png:
        * platform/chromium-linux/svg/custom/dasharrayOrigin-expected.png:
        * platform/chromium-linux/svg/custom/fractional-rects-expected.png:
        * platform/chromium-linux/svg/custom/gradient-rotated-bbox-expected.png:
        * platform/chromium-linux/svg/custom/rounded-rects-expected.png:
        * platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png:
        * platform/chromium-linux/svg/hixie/perf/001-expected.png:
        * platform/chromium-linux/svg/hixie/perf/002-expected.png:
        * platform/chromium-linux/svg/wicd/rightsizing-grid-expected.png:
        * platform/chromium-linux/svg/wicd/test-scalable-background-image1-expected.png:
        * platform/chromium-mac-leopard/fast/borders/border-radius-split-inline-expected.png: Added.
        * platform/chromium-mac-leopard/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Added.
        * platform/chromium-mac-leopard/fast/repaint/border-radius-repaint-expected.png: Added.
        * platform/chromium-mac-leopard/fast/transforms/shadows-expected.png: Added.
        * platform/chromium-mac-leopard/svg/hixie/perf: Added.
        * platform/chromium-mac-leopard/svg/hixie/perf/001-expected.png: Added.
        * platform/chromium-mac-leopard/svg/hixie/perf/002-expected.png: Added.
        * platform/chromium-mac/fast/backgrounds/border-radius-split-background-expected.png:
        * platform/chromium-mac/fast/backgrounds/border-radius-split-background-image-expected.png:
        * platform/chromium-mac/fast/backgrounds/gradient-background-leakage-expected.png: Added.
        * platform/chromium-mac/fast/borders/border-radius-constraints-expected.png: Added.
        * platform/chromium-mac/fast/borders/border-radius-split-inline-expected.png:
        * platform/chromium-mac/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
        * platform/chromium-mac/fast/borders/borderRadiusArcs01-expected.png: Added.
        * platform/chromium-mac/fast/borders/borderRadiusDashed02-expected.png: Added.
        * platform/chromium-mac/fast/borders/borderRadiusDashed03-expected.png: Added.
        * platform/chromium-mac/fast/borders/borderRadiusDotted01-expected.png: Added.
        * platform/chromium-mac/fast/borders/borderRadiusDouble01-expected.png: Added.
        * platform/chromium-mac/fast/borders/borderRadiusDouble02-expected.png: Added.
        * platform/chromium-mac/fast/borders/borderRadiusDouble03-expected.png: Added.
        * platform/chromium-mac/fast/borders/borderRadiusGroove01-expected.png: Added.
        * platform/chromium-mac/fast/borders/borderRadiusGroove02-expected.png: Added.
        * platform/chromium-mac/fast/borders/borderRadiusInset01-expected.png: Added.
        * platform/chromium-mac/fast/borders/borderRadiusOutset01-expected.png: Added.
        * platform/chromium-mac/fast/borders/borderRadiusRidge01-expected.png: Added.
        * platform/chromium-mac/fast/borders/borderRadiusSolid01-expected.png: Added.
        * platform/chromium-mac/fast/borders/borderRadiusSolid02-expected.png: Added.
        * platform/chromium-mac/fast/borders/borderRadiusSolid03-expected.png: Added.
        * platform/chromium-mac/fast/borders/borderRadiusSolid04-expected.png: Added.
        * platform/chromium-mac/fast/borders/different-color-borders-expected.png: Added.
        * platform/chromium-mac/fast/borders/fieldsetBorderRadius-expected.png: Added.
        * platform/chromium-mac/fast/box-shadow/inset-box-shadows-expected.png:
        * platform/chromium-mac/fast/box-shadow/inset-expected.png: Added.
        * platform/chromium-mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Added.
        * platform/chromium-mac/fast/box-shadow/spread-multiple-inset-expected.png:
        * platform/chromium-mac/fast/clip: Added.
        * platform/chromium-mac/fast/clip/overflow-border-radius-clip-expected.png: Added.
        * platform/chromium-mac/fast/css/nested-rounded-corners-expected.png:
        * platform/chromium-mac/fast/repaint/border-radius-repaint-expected.png: Added.
        * platform/chromium-mac/fast/transforms/shadows-expected.png:
        * platform/chromium-mac/media/video-zoom-controls-expected.png:
        * platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-52-t-expected.png: Added.
        * platform/chromium-mac/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.png: Added.
        * platform/chromium-mac/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.png: Added.
        * platform/chromium-mac/svg/custom/dasharrayOrigin-expected.png:
        * platform/chromium-mac/svg/custom/fractional-rects-expected.png: Added.
        * platform/chromium-mac/svg/custom/gradient-rotated-bbox-expected.png:
        * platform/chromium-mac/svg/custom/rounded-rects-expected.png: Added.
        * platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.png:
        * platform/chromium-mac/svg/hixie/perf/001-expected.png:
        * platform/chromium-mac/svg/hixie/perf/002-expected.png:
        * platform/chromium-mac/svg/wicd: Added.
        * platform/chromium-mac/svg/wicd/rightsizing-grid-expected.png: Added.
        * platform/chromium-mac/svg/wicd/test-scalable-background-image1-expected.png: Added.
        * platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-52-t-expected.png:
        * platform/chromium-win-vista/svg/wicd/rightsizing-grid-expected.png: Removed.
        * platform/chromium-win-vista/svg/wicd/test-scalable-background-image1-expected.png: Removed.
        * platform/chromium-win-xp/fast/transforms/shadows-expected.png: Removed.
        * platform/chromium-win/fast/backgrounds/border-radius-split-background-expected.png:
        * platform/chromium-win/fast/backgrounds/border-radius-split-background-image-expected.png:
        * platform/chromium-win/fast/backgrounds/gradient-background-leakage-expected.png:
        * platform/chromium-win/fast/borders/border-radius-constraints-expected.png:
        * platform/chromium-win/fast/borders/border-radius-split-inline-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusArcs01-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusDashed02-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusDashed03-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusDotted01-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusDouble01-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusDouble02-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusDouble03-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusGroove01-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusGroove02-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusInset01-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusOutset01-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusRidge01-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusSolid01-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusSolid02-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusSolid03-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusSolid04-expected.png:
        * platform/chromium-win/fast/borders/different-color-borders-expected.png:
        * platform/chromium-win/fast/borders/fieldsetBorderRadius-expected.png:
        * platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.png:
        * platform/chromium-win/fast/box-shadow/inset-expected.png:
        * platform/chromium-win/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png:
        * platform/chromium-win/fast/box-shadow/spread-multiple-inset-expected.png:
        * platform/chromium-win/fast/clip/overflow-border-radius-clip-expected.png:
        * platform/chromium-win/fast/css/nested-rounded-corners-expected.png:
        * platform/chromium-win/fast/repaint/border-radius-repaint-expected.png:
        * platform/chromium-win/fast/transforms/shadows-expected.png:
        * platform/chromium-win/media/video-zoom-controls-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-52-t-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.png:
        * platform/chromium-win/svg/custom/dasharrayOrigin-expected.png:
        * platform/chromium-win/svg/custom/fractional-rects-expected.png:
        * platform/chromium-win/svg/custom/gradient-rotated-bbox-expected.png:
        * platform/chromium-win/svg/custom/rounded-rects-expected.png:
        * platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
        * platform/chromium-win/svg/hixie/perf/001-expected.png:
        * platform/chromium-win/svg/hixie/perf/002-expected.png:
        * platform/chromium-win/svg/wicd/rightsizing-grid-expected.png:
        * platform/chromium-win/svg/wicd/test-scalable-background-image1-expected.png: Added.
        * platform/chromium-win/svg/wicd/test-scalable-background-image1-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 2 Jun 2011 23:02:28 +0000 (23:02 +0000)]
2011-06-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Need a way to install the memory pressure handler without initializing WebKit1
        https://bugs.webkit.org/show_bug.cgi?id=61975

        Add a WebInstallMemoryPressureHandler function which will install the memory pressure handler.
        -[WebView WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:] will do this,
        but we'd like to be able to install a memory pressure handler without creating a WebView or even
        calling any WebView method since that will call +[WebView initialize].

        * WebKit.exp:
        * WebView/WebView.mm:
        (WebInstallMemoryPressureHandler):
        * WebView/WebViewPrivate.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate the behavior of multiple reads for FileReader
jianli@chromium.org [Thu, 2 Jun 2011 22:26:10 +0000 (22:26 +0000)]
Update the behavior of multiple reads for FileReader
https://bugs.webkit.org/show_bug.cgi?id=61793

Reviewed by David Levin.

Source/WebCore:

Changed to throw an OperationNotAllowedException with the NOT_ALLOWED_ERR
status code on any of the read methods that occur when readyState = LOADING.
Otherwise, calling any of the read methods should work.

Test: fast/files/read-file-async.html

* CodeGenerators.pri:
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMBinding.cpp:
(WebCore::setDOMException):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::setDOMException):
* dom/ExceptionCode.cpp:
(WebCore::getExceptionCodeDescription):
* dom/ExceptionCode.h:
* fileapi/FileReader.cpp:
(WebCore::FileReader::FileReader):
(WebCore::FileReader::hasPendingActivity):
(WebCore::FileReader::readAsArrayBuffer):
(WebCore::FileReader::readAsBinaryString):
(WebCore::FileReader::readAsText):
(WebCore::FileReader::readAsDataURL):
(WebCore::FileReader::readInternal):
(WebCore::FileReader::abort):
(WebCore::FileReader::doAbort):
(WebCore::FileReader::terminate):
(WebCore::FileReader::start):
(WebCore::FileReader::didStartLoading):
(WebCore::FileReader::didFinishLoading):
(WebCore::FileReader::didFail):
* fileapi/FileReader.h:
(WebCore::FileReader::readyState):
* fileapi/FileReader.idl:
* fileapi/OperationNotAllowedException.h: Added.
(WebCore::OperationNotAllowedException::create):
(WebCore::OperationNotAllowedException::OperationNotAllowedException):
* fileapi/OperationNotAllowedException.idl: Added.

LayoutTests:

Added test cases to cover calling read methods multiple times.

* fast/files/read-file-async-expected.txt:
* fast/files/resources/read-file-test-cases.js:
(ensureInitialized):
(runNextTest):
(testMultipleReads):
(testReuseReaderStep1):
(testReuseReaderStep2):
* fast/files/workers/worker-read-file-async-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Adrienne Walker <enne@google.com>
enne@google.com [Thu, 2 Jun 2011 22:14:03 +0000 (22:14 +0000)]
2011-06-02  Adrienne Walker  <enne@google.com>

        Reviewed by James Robinson.

        [chromium] Compositor HUD should respect mapTexSubImage2D returning NULL
        https://bugs.webkit.org/show_bug.cgi?id=61954

        * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
        (WebCore::CCHeadsUpDisplay::draw):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/9539920> and https://bugs.webkit.org/show_bug.cgi?id=61950
beidson@apple.com [Thu, 2 Jun 2011 22:03:49 +0000 (22:03 +0000)]
<rdar://problem/9539920> and https://bugs.webkit.org/show_bug.cgi?id=61950
Repro crash loading certain webarchives after r87566.

Reviewed by Oliver Hunt.

Source/WebCore:

Test: webarchive/loading/javascript-url-iframe-crash.html

* bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::executeIfJavaScriptURL): DocumentWriter::replaceDocument can
  cause the DocumentLoader to be destroyed, so protect it with a Ref here.

LayoutTests:

* webarchive/loading/javascript-url-iframe-crash-expected.txt: Added.
* webarchive/loading/javascript-url-iframe-crash.html: Added.
* webarchive/loading/resources/javascript-url-iframe-crash.webarchive: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Jay Civelli <jcivelli@chromium.org>
jcivelli@chromium.org [Thu, 2 Jun 2011 21:59:29 +0000 (21:59 +0000)]
2011-06-02  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by Adam Barth.

        Added a method to generate RFC 2822 compliant date strings.
        https://bugs.webkit.org/show_bug.cgi?id=7169

        * wtf/DateMath.cpp:
        (WTF::twoDigitStringFromNumber):
        (WTF::makeRFC2822DateString):
        * wtf/DateMath.h:
2011-06-02  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by Adam Barth.

        Adding MHTML generation support to MHTMLArchive.
        https://bugs.webkit.org/show_bug.cgi?id=7169

        * loader/archive/mhtml/MHTMLArchive.cpp:
        (WebCore::generateRandomBoundary):
        (WebCore::replaceNonPrintableCharacters):
        (WebCore::MHTMLArchive::generateMHTMLData):
        * loader/archive/mhtml/MHTMLArchive.h:
        * page/PageSerializer.cpp:
        (WebCore::PageSerializer::serializeFrame):
        (WebCore::PageSerializer::serializeCSSStyleSheet):
        * platform/SharedBuffer.cpp:
        (WebCore::SharedBuffer::append):
        * platform/SharedBuffer.h:
2011-06-02  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by Adam Barth.

        Adding MHTML generation support to MHTMLArchive.
        https://bugs.webkit.org/show_bug.cgi?id=7169

        * public/WebPageSerializer.h:
        * src/WebPageSerializer.cpp:
        (WebKit::WebPageSerializer::serializeToMHTML):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 2 Jun 2011 21:50:34 +0000 (21:50 +0000)]
2011-06-02  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] autogen.sh is run twice for each buld on the bots
        https://bugs.webkit.org/show_bug.cgi?id=61951

        * Scripts/webkitdirs.pm: Only check the previous autotools arguments
        for the WebKit project. This prevents build-jsc runs from forcing subsequent
        build-webkit runs to re-rerun autogen.sh.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 2 Jun 2011 21:45:00 +0000 (21:45 +0000)]
2011-06-02  Tony Chang  <tony@chromium.org>

        [chromium] mark media/audio-delete-while-slider-thumb-clicked.html as passing
        https://bugs.webkit.org/show_bug.cgi?id=61967

        This test is passing now that we get proper click events on the
        slider and we no longer use absolute positions on the slider.  The
        test was updated in r78562 while it was disabled, so the chromium
        results were stale (thus I'm deleting them).

        * platform/chromium-win/media/audio-delete-while-slider-thumb-clicked-expected.txt: Removed.
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 2 Jun 2011 21:43:40 +0000 (21:43 +0000)]
2011-06-02  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Andreas Kling.

        Share Path code that uses beziers to construct a rounded rect
        https://bugs.webkit.org/show_bug.cgi?id=61960

        Have two methods in Path that construct beziers for rounded
        rects to share the same code.

        Make gCircleControlPoint a little more precise, and add
        a comment describing its derivation.

        Make use of FloatRect::maxX() and maxY().

        * platform/graphics/Path.cpp:
        (WebCore::Path::addRoundedRect):
        (WebCore::Path::addBeziersForRoundedRect):
        * platform/graphics/Path.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Thu, 2 Jun 2011 21:41:42 +0000 (21:41 +0000)]
2011-06-02  Stephen White  <senorblanco@chromium.org>

        Reviewed by Andreas Kling.

        Fix layout test compositing/images/direct-svg-image.html.
        https://bugs.webkit.org/show_bug.cgi?id=61966

        Change this test to get SVG resources from their new, post-r87782
        location (svg/as-image).

        * compositing/images/direct-svg-image.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Sheriff Bot <webkit.review.bot@gmail.com>
abarth@webkit.org [Thu, 2 Jun 2011 21:36:45 +0000 (21:36 +0000)]
2011-06-02  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r87946.
        http://trac.webkit.org/changeset/87946
        https://bugs.webkit.org/show_bug.cgi?id=61965

        Cause NRWT to break (Requested by abarth|gardener on #webkit).

        * Scripts/webkitpy/layout_tests/layout_package/worker.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 2 Jun 2011 21:35:16 +0000 (21:35 +0000)]
2011-06-02  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Enrica Casucci.

        ApplyStyleCommand shouldn't call collapseTextDecorationProperties
        https://bugs.webkit.org/show_bug.cgi?id=61887

        Removed the call to collapseTextDecorationProperties in ApplyStyleCommand::applyInlineStyle.

        No new tests because this is a code refactoring.

        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::applyInlineStyle): No loner calls collapseTextDecorationProperties.
        (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Updated comment.
        * editing/EditingStyle.cpp:
        (WebCore::HTMLElementEquivalent::propertyExistsInStyle): Added to check both text-decoration
        and -webkit-text-decorations-in-effect.
        (WebCore::HTMLTextDecorationEquivalent::HTMLTextDecorationEquivalent): Added a comment.
        (WebCore::HTMLTextDecorationEquivalent::propertyExistsInStyle): Checks both text-decoration
        and -webkit-text-decorations-in-effect.
        (WebCore::HTMLTextDecorationEquivalent::valueIsPresentInStyle): Checks if a text decoration
        is present in -webkit-text-decorations-in-effect or text-decoration preferring the former.
        (WebCore::EditingStyle::conflictsWithInlineStyleOfElement): Merged loops for when conflictingProperties
        is false and true. Added a support for -webkit-text-decorations-in-effect.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 2 Jun 2011 21:29:46 +0000 (21:29 +0000)]
2011-06-02  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        Make more functions static local in EventHandlers.cpp
        https://bugs.webkit.org/show_bug.cgi?id=58503

        Removed canHandleDragAndDropForTarget and made focusDirectionForKey local to EventHandler.cpp.

        * page/EventHandler.cpp:
        (WebCore::targetIsFrame): Extracted from canHandleDragAndDropForTarget.
        (WebCore::EventHandler::updateDragAndDrop): Calls contentFrameForTarget instead of canHandleDragAndDropForTarget.
        (WebCore::EventHandler::cancelDragAndDrop): Ditto.
        (WebCore::EventHandler::performDragAndDrop): Ditto.
        (WebCore::focusDirectionForKey): No longer a member function of EventHandler class.
        (WebCore::handleKeyboardSelectionMovement): No longer a member function of EventHandler class; also calls
        focusDirectionForKey instead of manually comparing.
        * page/EventHandler.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Alexis Menard <alexis.menard@openbossa.org>
alexis.menard@openbossa.org [Thu, 2 Jun 2011 20:37:58 +0000 (20:37 +0000)]
2011-06-02  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] Build fix of QtWebKit 2.2 when inside Qt tree with GCC 4.6.
        https://bugs.webkit.org/show_bug.cgi?id=61957

        When building inside the Qt source tree, qmake always append the mkspecs
        defines after ours. We have to workaround and make sure that we append
        our flags after the qmake variable used inside Qt. This workaround was provided
        by our qmake folks.

        * Source/WebKit.pri:
2011-06-02  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] Build fix of QtWebKit 2.2 when inside Qt tree with GCC 4.6.
        https://bugs.webkit.org/show_bug.cgi?id=61957

        When building inside the Qt source tree, qmake always append the mkspecs
        defines after ours. We have to workaround and make sure that we append
        our flags after the qmake variable used inside Qt. This workaround was provided
        by our qmake folks.

        * JavaScriptCore.pro:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Alok Priyadarshi <alokp@chromium.org>
alokp@chromium.org [Thu, 2 Jun 2011 20:20:34 +0000 (20:20 +0000)]
2011-06-02  Alok Priyadarshi  <alokp@chromium.org>

        Reviewed by James Robinson.

        [chromium] Things jump around when selecting anything on the page
        https://bugs.webkit.org/show_bug.cgi?id=61639

        WebCore::LayerTextureUpdaterSkPicture::updateTextureRect was not updating a tile sub-region properly.
        It did not consider dest-rect when selecting the clip and translation required to draw the content-rect into dest-rect.
        Also removed clearing of framebuffer because it used to clear the whole tile not just dest-rect.
        An appropriate viewport could be set to just clear the dest-rect, but it was debug only code and I did not want to mess
        with the viewport set by skia.

        No new tests. This case should be covered by most of the layout tests (pixel) targeting selection or hovering when chromium is run in compositing mode.
        Here is a non-exhaustive list of existing tests covering this case.
        Test: editing/selection/14971.html (existing)
              editing/selection/3690703-2.html (existing)
              editing/selection/4402375.html (existing)
              editing/selection/4818145.html (existing)

        * platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
        (WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):
        (WebCore::LayerTextureUpdaterSkPicture::createFrameBuffer):
        * platform/graphics/chromium/LayerTextureUpdaterCanvas.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 2 Jun 2011 20:15:34 +0000 (20:15 +0000)]
2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        Add build logistics and plumbing for window.internals object.
        https://bugs.webkit.org/show_bug.cgi?id=60313

        * fast/dom/Window/script-tests/window-property-descriptors.js: Added internals object to list of properties to skip.
        * fast/dom/Window/window-properties.html: Ditto.
        * fast/dom/script-tests/prototype-inheritance-2.js: Ditto.
        * fast/dom/script-tests/prototype-inheritance.js: Ditto.
        * fast/harness/internals-object-expected.txt: Added.
        * fast/harness/internals-object.html: Added.
        * platform/gtk/Skipped: Skipped the newly added test until platform supports window.internals.
        * platform/mac-wk2/Skipped: Ditto.
        * platform/qt/Skipped: Ditto.
        * platform/win/Skipped: Ditto.
2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        Add build logistics and plumbing for window.internals object.
        https://bugs.webkit.org/show_bug.cgi?id=60313

        Test: fast/harness/internals-object.html

        * Configurations/WebCoreTestSupport.xcconfig: Added.
        * DerivedSources.make: Added support for generating from Internals.idl.
        * WebCore.gyp/WebCore.gyp: Added new webcore_test_support library.
        * WebCore.gypi: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Added WebCoreTestSupport library.
        * testing/Internals.cpp: Added.
        * testing/Internals.h: Added.
        * testing/Internals.idl: Added.
        * testing/js/WebCoreTestSupport.cpp: Added.
        * testing/js/WebCoreTestSupport.h: Added.
        * testing/v8/WebCoreTestSupport.cpp: Added.
        * testing/v8/WebCoreTestSupport.h: Added.
2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        Add build logistics and plumbing for window.internals object.
        https://bugs.webkit.org/show_bug.cgi?id=60313

        * WebKit.gyp: Added linking new webkit_test_support library.
        * public/WebTestingSupport.h: Added.
        * src/WebTestingSupport.cpp: Added.
2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        Add build logistics and plumbing for window.internals object.
        https://bugs.webkit.org/show_bug.cgi?id=60313

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::bindJSObjectsToWindow): Added injection code.
        * DumpRenderTree/mac/FrameLoadDelegate.mm:
        (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 2 Jun 2011 20:01:35 +0000 (20:01 +0000)]
2011-06-02  Adam Barth  <abarth@webkit.org>

        More housekeep w.r.t. border-radius-clip.html.  These new image results
        look correct.  The "replaced" version is the one with the failure.

        * platform/chromium-linux-x86/fast/overflow/border-radius-clipping-expected.png: Added.
        * platform/chromium-linux/fast/overflow/border-radius-clipping-expected.png:
        * platform/chromium-mac-leopard/fast/overflow/border-radius-clipping-expected.png:
        * platform/chromium-mac/fast/overflow/border-radius-clipping-expected.png: Removed.
        * platform/chromium-win/fast/overflow/border-radius-clipping-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Hao Zheng <zhenghao@chromium.org>
commit-queue@webkit.org [Thu, 2 Jun 2011 20:01:02 +0000 (20:01 +0000)]
2011-06-02  Hao Zheng  <zhenghao@chromium.org>

        Reviewed by Dirk Pranke.

        Call cleanup() explicitly at the end of worker.run().
        https://bugs.webkit.org/show_bug.cgi?id=61847

        * Scripts/webkitpy/layout_tests/layout_package/worker.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 2 Jun 2011 19:59:17 +0000 (19:59 +0000)]
2011-06-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Simon Fraser.

        Add quirk for plug-ins that return a retained CALayer
        https://bugs.webkit.org/show_bug.cgi?id=61948
        <rdar://problem/9530390>

        * Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
        (WebKit::NetscapePluginModule::determineQuirks):
        Set the ReturnsRetainedCoreAnimationLayer quirk for Flash.

        * Shared/Plugins/PluginQuirks.h:
        Add ReturnsRetainedCoreAnimationLayer quirk.

        * WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
        (WebKit::NPN_GetValue):
        Handle WKNVExpectsNonretainedLayer by always returning true, and also
        call NetscapePlugin::setPluginReturnsNonretainedLayer(true) to add a way
        for plug-ins to opt into returning non-retained layers even if they have
        the quirk specified.

        * WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
        (WebKit::NetscapePlugin::NetscapePlugin):
        Initialize m_pluginReturnsNonretainedLayer to true.

        * WebProcess/Plugins/Netscape/NetscapePlugin.h:
        (WebKit::NetscapePlugin::setPluginReturnsNonretainedLayer):
        Add setter.

        * WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
        (WebKit::NetscapePlugin::platformPostInitialize):
        If m_pluginReturnsNonretainedLayer is false, adopt the layer.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Aaron Colwell <acolwell@chromium.org>
commit-queue@webkit.org [Thu, 2 Jun 2011 19:58:16 +0000 (19:58 +0000)]
2011-06-02  Aaron Colwell  <acolwell@chromium.org>

        Reviewed by David Levin.

        Update chromium version
        https://bugs.webkit.org/show_bug.cgi?id=61555

        * DEPS:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed WinCairo build correction.
bfulgham@webkit.org [Thu, 2 Jun 2011 19:54:06 +0000 (19:54 +0000)]
Unreviewed WinCairo build correction.

* UIProcess/win/WebView.cpp: Don't include CG file header
when building without CoreGraphics support.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-01 Adrienne Walker <enne@google.com>
enne@google.com [Thu, 2 Jun 2011 19:45:27 +0000 (19:45 +0000)]
2011-06-01  Adrienne Walker  <enne@google.com>

        Reviewed by Eric Seidel.

        [chromium] LayerChromium should use a RefPtr for replica layer
        https://bugs.webkit.org/show_bug.cgi?id=61898

        Having this member variable be a raw pointer is brittle and assumes
        that the GraphicsLayer tree keeps this in sync.  There aren't any
        known bugs caused by this, but it seems like good sense to do this.

        * platform/graphics/chromium/LayerChromium.h:
        (WebCore::LayerChromium::replicaLayer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoActually make the property change.
abarth@webkit.org [Thu, 2 Jun 2011 19:38:49 +0000 (19:38 +0000)]
Actually make the property change.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 2 Jun 2011 19:38:16 +0000 (19:38 +0000)]
2011-06-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Ryosuke Niwa.

        Update svn:ignore property on Source/WebKit/chromium
        https://bugs.webkit.org/show_bug.cgi?id=61952

        Add some more generated files and directories mapped in using DEPS to svn:ignore.

        * chromium: Modified property svn:ignore.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 2 Jun 2011 19:27:09 +0000 (19:27 +0000)]
2011-06-02  Adam Barth  <abarth@webkit.org>

        First cut at updating test expectations for Win 7.

        * platform/chromium-win/fast/dom/HTMLAnchorElement/set-href-attribute-hash-expected.txt: Removed.
        * platform/chromium-win/fullscreen/full-screen-zIndex-after-expected.png: Added.
        * platform/chromium-win/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt: Removed.
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Removed.
        * platform/chromium-win/svg/wicd/test-rightsizing-b-expected.png: Added.
        * platform/chromium-win/svg/wicd/test-rightsizing-b-expected.txt: Added.
        * platform/chromium-win/svg/wicd/test-scalable-background-image2-expected.png: Added.
        * platform/chromium-win/svg/wicd/test-scalable-background-image2-expected.txt: Added.
        * platform/chromium-win/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png:
        * platform/chromium-win/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 2 Jun 2011 19:10:16 +0000 (19:10 +0000)]
2011-06-02  Adam Barth  <abarth@webkit.org>

        These differ only by the scroll bar.

        * platform/chromium-linux-x86/fast/css: Added.
        * platform/chromium-linux-x86/fast/css/last-of-type-pseudo-class-expected.png: Added.
        * platform/chromium-linux/fast/css/last-of-type-pseudo-class-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 2 Jun 2011 19:07:56 +0000 (19:07 +0000)]
2011-06-02  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        REGRESSION: inline style is lost when deleting line break between paragraphs with same style
        https://bugs.webkit.org/show_bug.cgi?id=61899

        Added a regression test to ensure WebKit preserves font family for a paragraph being merged
        to the previous paragraph when deleting a line break between two paragraphs with the same style.

        * editing/deleting/delete-line-break-between-paragraphs-with-same-style-expected.txt: Added.
        * editing/deleting/delete-line-break-between-paragraphs-with-same-style.html: Added.
2011-06-02  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        REGRESSION: inline style is lost when deleting line break between paragraphs with same style
        https://bugs.webkit.org/show_bug.cgi?id=61899

        The bug was caused by ReplaceSelectionCommand::doApply's calling handleStyleSpansBeforeInsertion
        before insertionPos is adjusted by positionAvoidingPrecedingNodes and positionOutsideTabSpan.

        Fixed the bug by calling handleStyleSpansBeforeInsertion after the calls to these two functions.

        Test: editing/deleting/delete-line-break-between-paragraphs-with-same-style.html

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-01 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 2 Jun 2011 19:05:52 +0000 (19:05 +0000)]
2011-06-01  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Simon Fraser.

        REGRESSION: Text selection broken for text with line-height applied
        https://bugs.webkit.org/show_bug.cgi?id=54929

        The bug was caused by RenderText::positionForPoint's not considering the case where a point is
        above selectionTop and below lineTop of the first root inline box. Fixed the bug by considering
        any point between selectionTop and lineTop to be inside a root inline box. This condition is
        consistent with the condition we use to determine the bottom of a line.

        Test: editing/selection/hit-test-on-text-with-line-height.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::positionForPointWithInlineChildren): Fixed a condition to determine whether
        or not a point is above the first root line box. We need to check both selectionTop and logicalTop
        for the same reason explained above.
        * rendering/RenderText.cpp:
        (WebCore::RenderText::positionForPoint): See above.
2011-06-01  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Simon Fraser.

        REGRESSION: Text selection broken for text with line-height applied
        https://bugs.webkit.org/show_bug.cgi?id=54929

        Added a test to ensure WebKit can place caret in text with a line-height smaller than
        the height of the text.

        * editing/selection/hit-test-on-text-with-line-height-expected.txt: Added.
        * editing/selection/hit-test-on-text-with-line-height.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 2 Jun 2011 18:57:50 +0000 (18:57 +0000)]
2011-06-02  Adam Barth  <abarth@webkit.org>

        This test actually fails as IMAGE not as IMAGE+TEXT.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 2 Jun 2011 18:39:52 +0000 (18:39 +0000)]
2011-06-02  Adam Barth  <abarth@webkit.org>

        New baselines for these tests.  These only differ from the existing baselines by a handful of pixels.

        * platform/chromium-linux-x86/fast/borders/border-radius-huge-assert-expected.png: Added.
        * platform/chromium-linux-x86/fast/borders/borderRadiusAllStylesAllCorners-expected.png: Added.
        * platform/chromium-linux-x86/fast/borders/borderRadiusArcs01-expected.png: Added.
        * platform/chromium-linux-x86/fast/borders/borderRadiusDashed02-expected.png: Added.
        * platform/chromium-linux-x86/fast/borders/borderRadiusDashed03-expected.png: Added.
        * platform/chromium-linux-x86/fast/borders/borderRadiusDotted01-expected.png: Added.
        * platform/chromium-linux-x86/fast/borders/borderRadiusDouble01-expected.png: Added.
        * platform/chromium-linux-x86/fast/borders/borderRadiusDouble02-expected.png: Added.
        * platform/chromium-linux-x86/fast/borders/borderRadiusDouble03-expected.png: Added.
        * platform/chromium-linux-x86/fast/borders/borderRadiusGroove01-expected.png: Added.
        * platform/chromium-linux-x86/fast/borders/borderRadiusGroove02-expected.png: Added.
        * platform/chromium-linux-x86/fast/borders/borderRadiusInset01-expected.png: Added.
        * platform/chromium-linux-x86/fast/borders/borderRadiusInvalidColor-expected.png: Added.
        * platform/chromium-linux-x86/fast/borders/borderRadiusOutset01-expected.png: Added.
        * platform/chromium-linux-x86/fast/borders/borderRadiusRidge01-expected.png: Added.
        * platform/chromium-linux-x86/fast/borders/borderRadiusSolid01-expected.png: Added.
        * platform/chromium-linux-x86/fast/borders/borderRadiusSolid02-expected.png: Added.
        * platform/chromium-linux-x86/fast/borders/borderRadiusSolid03-expected.png: Added.
        * platform/chromium-linux-x86/fast/box-shadow: Added.
        * platform/chromium-linux-x86/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Added.
        * platform/chromium-linux-x86/fast/overflow: Added.
        * platform/chromium-linux-x86/fast/repaint/border-radius-repaint-expected.png: Added.
        * platform/chromium-linux-x86/fast/replaced: Added.
        * platform/chromium-linux/fast/borders/border-radius-huge-assert-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusArcs01-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusDashed02-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusDashed03-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusDotted01-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusDouble01-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusDouble02-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusDouble03-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusGroove01-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusGroove02-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusInset01-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusInvalidColor-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusOutset01-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusRidge01-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusSolid01-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusSolid02-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusSolid03-expected.png:
        * platform/chromium-linux/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png:
        * platform/chromium-linux/fast/repaint/border-radius-repaint-expected.png:
        * platform/chromium-mac-leopard/fast/borders/border-radius-huge-assert-expected.png:
        * platform/chromium-mac-leopard/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
        * platform/chromium-mac-leopard/fast/borders/borderRadiusInvalidColor-expected.png:
        * platform/chromium-mac/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
        * platform/chromium-mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Removed.
        * platform/chromium-win/fast/borders/border-radius-huge-assert-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusArcs01-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusDashed02-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusDashed03-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusDotted01-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusDouble01-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusDouble02-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusDouble03-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusGroove01-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusGroove02-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusInset01-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusInvalidColor-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusOutset01-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusRidge01-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusSolid01-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusSolid02-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusSolid03-expected.png:
        * platform/chromium-win/fast/repaint/border-radius-repaint-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Thu, 2 Jun 2011 18:27:27 +0000 (18:27 +0000)]
2011-06-02  Andreas Kling  <kling@webkit.org>

        Reviewed by James Robinson.

        Canvas/V8: Fix setting strokeStyle or fillStyle to a CSS system color.
        https://bugs.webkit.org/show_bug.cgi?id=61944

        * platform/chromium/test_expectations.txt: Unskip canvas/philip/tests/2d.fillStyle.parse.system.html.
2011-06-02  Andreas Kling  <kling@webkit.org>

        Reviewed by James Robinson.

        Canvas/V8: Fix setting strokeStyle or fillStyle to a CSS system color.
        https://bugs.webkit.org/show_bug.cgi?id=61944

        Call setFillColor/setStrokeColor (instead of setFillStyle/setStrokeStyle)
        for string styles. This ensures that system color resolution is performed,
        and matches what the JSC bindings do.

        Test: canvas/philip/tests/2d.fillStyle.parse.system.html

        * bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
        (WebCore::toCanvasStyle):
        (WebCore::V8CanvasRenderingContext2D::strokeStyleAccessorSetter):
        (WebCore::V8CanvasRenderingContext2D::fillStyleAccessorSetter):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Sheriff Bot <webkit.review.bot@gmail.com>
abarth@webkit.org [Thu, 2 Jun 2011 18:08:02 +0000 (18:08 +0000)]
2011-06-02  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r87920.
        http://trac.webkit.org/changeset/87920
        https://bugs.webkit.org/show_bug.cgi?id=61943

        This patch does not build in Win Builder (dbg)(shared)
        downstream (Requested by abarth|gardener on #webkit).

        * tests/PopupMenuTest.cpp:
        (WebKit::TestPopupMenuClient::TestPopupMenuClient):
        (WebKit::TestPopupMenuClient::valueChanged):
        (WebKit::TestPopupMenuClient::itemIsEnabled):
        (WebKit::SelectPopupMenuTest::TearDown):
        * tests/data/popup/select_event.html: Removed.
        * tests/data/popup/select_event_remove_on_change.html: Removed.
        * tests/data/popup/select_event_remove_on_click.html: Removed.
2011-06-02  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r87920.
        http://trac.webkit.org/changeset/87920
        https://bugs.webkit.org/show_bug.cgi?id=61943

        This patch does not build in Win Builder (dbg)(shared)
        downstream (Requested by abarth|gardener on #webkit).

        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupContainer::showPopup):
        (WebCore::PopupListBox::handleMouseReleaseEvent):
        (WebCore::PopupListBox::acceptIndex):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 2 Jun 2011 18:05:09 +0000 (18:05 +0000)]
2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, rolling out r87926.
        http://trac.webkit.org/changeset/87926
        https://bugs.webkit.org/show_bug.cgi?id=60313

        Fails to find WebCoreTestSupport.dylib on bots.

        * fast/dom/Window/script-tests/window-property-descriptors.js:
        * fast/dom/Window/window-properties.html:
        * fast/dom/script-tests/prototype-inheritance-2.js:
        * fast/dom/script-tests/prototype-inheritance.js:
        * fast/harness/internals-object-expected.txt: Removed.
        * fast/harness/internals-object.html: Removed.
        * platform/gtk/Skipped:
        * platform/mac-wk2/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, rolling out r87926.
        http://trac.webkit.org/changeset/87926
        https://bugs.webkit.org/show_bug.cgi?id=60313

        Fails to find WebCoreTestSupport.dylib on bots.

        * Configurations/WebCore.xcconfig:
        * Configurations/WebCoreTestSupport.xcconfig: Removed.
        * DerivedSources.make:
        * WebCore.exp.in:
        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSDOMWrapper.cpp:
        (WebCore::JSDOMWrapper::~JSDOMWrapper):
        * bindings/js/JSDOMWrapper.h:
        * testing/Internals.cpp: Removed.
        * testing/Internals.h: Removed.
        * testing/Internals.idl: Removed.
        * testing/js/WebCoreTestSupport.cpp: Removed.
        * testing/js/WebCoreTestSupport.h: Removed.
        * testing/v8/WebCoreTestSupport.cpp: Removed.
        * testing/v8/WebCoreTestSupport.h: Removed.
2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, rolling out r87926.
        http://trac.webkit.org/changeset/87926
        https://bugs.webkit.org/show_bug.cgi?id=60313

        Fails to find WebCoreTestSupport.dylib on bots.

        * WebKit.gyp:
        * public/WebTestingSupport.h: Removed.
        * src/WebTestingSupport.cpp: Removed.
2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, rolling out r87926.
        http://trac.webkit.org/changeset/87926
        https://bugs.webkit.org/show_bug.cgi?id=60313

        Fails to find WebCoreTestSupport.dylib on bots.

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::bindJSObjectsToWindow):
        * DumpRenderTree/mac/FrameLoadDelegate.mm:
        (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Thu, 2 Jun 2011 18:01:23 +0000 (18:01 +0000)]
2011-06-02  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Implement popup menus in Webkit2
        https://bugs.webkit.org/show_bug.cgi?id=61854

        Move common code into a new class to be used by both WebKit1 and
        WebKit2.

        * GNUmakefile.list.am: Add new files to compilation.
        * platform/gtk/GtkPopupMenu.cpp: Copied from Source/WebCore/platform/gtk/PopupMenuGtk.cpp.
        (WebCore::GtkPopupMenu::GtkPopupMenu):
        (WebCore::GtkPopupMenu::~GtkPopupMenu):
        (WebCore::GtkPopupMenu::clear): Remove all menu items.
        (WebCore::GtkPopupMenu::appendSeparator): Add a new separator
        item to the menu.
        (WebCore::GtkPopupMenu::appendItem): Add a new item to the menu for
        the given action.
        (WebCore::GtkPopupMenu::popUp): Show the menu.
        (WebCore::GtkPopupMenu::popDown): Hide the menu.
        (WebCore::GtkPopupMenu::menuRemoveItem):
        (WebCore::GtkPopupMenu::menuPositionFunction):
        (WebCore::GtkPopupMenu::resetTypeAheadFindState):
        (WebCore::GtkPopupMenu::typeAheadFind):
        (WebCore::GtkPopupMenu::selectItemCallback):
        (WebCore::GtkPopupMenu::keyPressEventCallback):
        * platform/gtk/GtkPopupMenu.h: Copied from Source/WebCore/platform/gtk/PopupMenuGtk.h.
        (WebCore::GtkPopupMenu::create):
        (WebCore::GtkPopupMenu::platformMenu):
        * platform/gtk/PopupMenuGtk.cpp:
        (WebCore::PopupMenuGtk::PopupMenuGtk):
        (WebCore::PopupMenuGtk::~PopupMenuGtk):
        (WebCore::PopupMenuGtk::show): Use GtkPopupMenu.
        (WebCore::PopupMenuGtk::hide): Ditto.
        (WebCore::PopupMenuGtk::menuItemActivated):
        (WebCore::PopupMenuGtk::menuUnmapped):
        * platform/gtk/PopupMenuGtk.h:
2011-06-02  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Implement popup menus in Webkit2
        https://bugs.webkit.org/show_bug.cgi?id=61854

        * GNUmakefile.am: Add new files to compilation.
        * UIProcess/API/gtk/PageClientImpl.cpp:
        (WebKit::PageClientImpl::createPopupMenuProxy): Create a new
        WebPopupMenuProxy.
        * UIProcess/gtk/WebPopupMenuProxyGtk.cpp: Added.
        (WebKit::WebPopupMenuProxyGtk::WebPopupMenuProxyGtk):
        (WebKit::WebPopupMenuProxyGtk::~WebPopupMenuProxyGtk):
        (WebKit::WebPopupMenuProxyGtk::showPopupMenu):
        (WebKit::WebPopupMenuProxyGtk::hidePopupMenu):
        (WebKit::WebPopupMenuProxyGtk::shutdownRunLoop):
        (WebKit::WebPopupMenuProxyGtk::menuItemActivated):
        (WebKit::WebPopupMenuProxyGtk::menuUnmapped):
        * UIProcess/gtk/WebPopupMenuProxyGtk.h: Added.
        (WebKit::WebPopupMenuProxyGtk::create):
        (WebKit::WebPopupMenuProxyGtk::setActiveItem):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 2 Jun 2011 17:50:48 +0000 (17:50 +0000)]
2011-06-02  Adam Barth  <abarth@webkit.org>

        More examples of SVG tests timing out in debug with Skia.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Adrienne Walker <enne@google.com>
enne@google.com [Thu, 2 Jun 2011 17:42:08 +0000 (17:42 +0000)]
2011-06-02  Adrienne Walker  <enne@google.com>

        [chromium] Unreviewed, rebaseline tests after r87822
        https://bugs.webkit.org/show_bug.cgi?id=60821

        * platform/chromium-gpu-mac/platform/chromium/compositing/layout-width-change-expected.png:
        * platform/chromium-gpu-win/platform/chromium/compositing/layout-width-change-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Aaron Colwell <acolwell@chromium.org>
commit-queue@webkit.org [Thu, 2 Jun 2011 17:40:53 +0000 (17:40 +0000)]
2011-06-02  Aaron Colwell  <acolwell@chromium.org>

        Reviewed by Dimitri Glazkov.

        Bring gyp_webkit up to date with changes made to
        gyp_chromium so chromium_rev can be advanced past
        revision 87140.
        https://bugs.webkit.org/show_bug.cgi?id=61881

        * gyp_webkit:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-21 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 2 Jun 2011 17:30:49 +0000 (17:30 +0000)]
2011-05-21  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        Add build logistics and plumbing for window.internals object.
        https://bugs.webkit.org/show_bug.cgi?id=60313

        * fast/dom/Window/script-tests/window-property-descriptors.js: Added internals object to list of properties to skip.
        * fast/dom/Window/window-properties.html: Ditto.
        * fast/dom/script-tests/prototype-inheritance-2.js: Ditto.
        * fast/dom/script-tests/prototype-inheritance.js: Ditto.
        * fast/harness/internals-object-expected.txt: Added.
        * fast/harness/internals-object.html: Added.
        * platform/gtk/Skipped: Skipped the newly added test until platform supports window.internals.
        * platform/mac-wk2/Skipped: Ditto.
        * platform/qt/Skipped: Ditto.
        * platform/win/Skipped: Ditto.
2011-05-21  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        Add build logistics and plumbing for window.internals object.
        https://bugs.webkit.org/show_bug.cgi?id=60313

        Test: fast/harness/internals-object.html

        * Configurations/WebCoreTestSupport.xcconfig: Added.
        * DerivedSources.make: Added support for generating from Internals.idl.
        * WebCore.gyp/WebCore.gyp: Added new webcore_test_support library.
        * WebCore.gypi: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Added WebCoreTestSupport library.
        * testing/Internals.cpp: Added.
        * testing/Internals.h: Added.
        * testing/Internals.idl: Added.
        * testing/js/WebCoreTestSupport.cpp: Added.
        * testing/js/WebCoreTestSupport.h: Added.
        * testing/v8/WebCoreTestSupport.cpp: Added.
        * testing/v8/WebCoreTestSupport.h: Added.
2011-05-21  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        Add build logistics and plumbing for window.internals object.
        https://bugs.webkit.org/show_bug.cgi?id=60313

        * WebKit.gyp: Added linking new webkit_test_support library.
        * public/WebTestingSupport.h: Added.
        * src/WebTestingSupport.cpp: Added.
2011-05-21  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        Add build logistics and plumbing for window.internals object.
        https://bugs.webkit.org/show_bug.cgi?id=60313

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::bindJSObjectsToWindow): Added injection code.
        * DumpRenderTree/mac/FrameLoadDelegate.mm:
        (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Joone Hur <joone.hur@collabora.co.uk>
joone.hur@collabora.co.uk [Thu, 2 Jun 2011 17:16:17 +0000 (17:16 +0000)]
2011-06-02  Joone Hur  <joone.hur@collabora.co.uk>

        Reviewed by Martin Robinson.

        [GTK] Only load dictionaries if spell check is enabled
        https://bugs.webkit.org/show_bug.cgi?id=32879

        We don't need to call enchant if enable-spell-checking is false.

        * webkit/webkitwebview.cpp:
        (webkit_web_view_update_settings): Skip loading dictionaries when enable-spell-checking is false.
        (webkit_web_view_settings_notify): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 2 Jun 2011 17:04:54 +0000 (17:04 +0000)]
2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>

        [Win] Start skipping a test that's now using shadowRoot machinery.

        * platform/win/Skipped: Skip fast/events/shadow-boundary-crossing.html, since it now uses shadowRoot accessors.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 John Knottenbelt <jknotten@chromium.org>
jknotten@chromium.org [Thu, 2 Jun 2011 17:00:11 +0000 (17:00 +0000)]
2011-06-02  John Knottenbelt  <jknotten@chromium.org>

        Unreviewed.

        [Chromium] Adjust test expectations.
        https://bugs.webkit.org/show_bug.cgi?id=61938

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Adrienne Walker <enne@google.com>
enne@google.com [Thu, 2 Jun 2011 16:50:30 +0000 (16:50 +0000)]
2011-06-02  Adrienne Walker  <enne@google.com>

        [chromium] Unreviewed, rebaseline tests after r87822
        https://bugs.webkit.org/show_bug.cgi?id=60821

        * platform/chromium-gpu-linux/compositing/geometry/fixed-position-expected.png:
        * platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.png:
        * platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.png:
        * platform/chromium-gpu-linux/compositing/overflow/fixed-position-ancestor-clip-expected.png:
        * platform/chromium-gpu-mac/compositing/geometry/fixed-position-expected.png:
        * platform/chromium-gpu-mac/compositing/geometry/horizontal-scroll-composited-expected.png:
        * platform/chromium-gpu-mac/compositing/geometry/vertical-scroll-composited-expected.png:
        * platform/chromium-gpu-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png:
        * platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.png:
        * platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.png:
        * platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.png:
        * platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Thu, 2 Jun 2011 16:48:04 +0000 (16:48 +0000)]
2011-06-02  Mario Sanchez Prada  <msanchez@igalia.com>

        Unreviewed, skipping another failing test in GTK after r87901.

        * platform/gtk/Skipped: Skipped test.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Naoki Takano <takano.naoki@gmail.com>
commit-queue@webkit.org [Thu, 2 Jun 2011 16:45:01 +0000 (16:45 +0000)]
2011-06-02  Naoki Takano  <takano.naoki@gmail.com>

        Reviewed by Dimitri Glazkov.

        [Chromium] Click event is not fired for a menulist <select>
        https://bugs.webkit.org/show_bug.cgi?id=60563

        Tests: SelectItemEventFire, SelectItemKeyEvent, SelectItemRemoveSelectOnChange and SelectItemRemoveSelectOnChange in webkit_unit_tests.

        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupContainer::showPopup): Set m_focusedNode from m_frameView.
        (WebCore::PopupListBox::handleMouseReleaseEvent): Call dispatchMouseEvent to forward the event only if select popup.
        (WebCore::PopupListBox::acceptIndex): Change to return accepted or not.
2011-06-02  Naoki Takano  <takano.naoki@gmail.com>

        Reviewed by Dimitri Glazkov.

        [Chromium] Click event is not fired for a menulist <select>
        https://bugs.webkit.org/show_bug.cgi?id=60563

        * tests/PopupMenuTest.cpp:
        (WebKit::TestPopupMenuClient::TestPopupMenuClient): Initialize m_node.
        (WebKit::TestPopupMenuClient::valueChanged): To fire 'change' event, forward the event like RenderMenuList.
        (WebKit::TestPopupMenuClient::itemIsEnabled): Change to return true or false according to disabled item or not.
        (WebKit::TestPopupMenuClient::setDisabledIndex): Set disabled index to simulate disabled item.
        (WebKit::TestPopupMenuClient::setFocusedNode): Set focused node to dispatch the event.
        (WebKit::SelectPopupMenuTest::SelectPopupMenuTest): Add baseURL.
        (WebKit::SelectPopupMenuTest::TearDown): Add UnregisterAllMockedURLs() call.
        (WebKit::SelectPopupMenuTest::registerMockedURLLoad): To simulate html load, call RegisterMockedURL().
        (WebKit::SelectPopupMenuTest::serveRequests): Call ServeAsynchronousMockedRequests().
        (WebKit::SelectPopupMenuTest::loadFrame): Simulate load frame with url string.
        (WebKit::TEST_F): Implement SelectItemEventFire, SelectItemKeyEvent, SelectItemRemoveSelectOnChange and SelectItemRemoveSelectOnChange.
        * tests/data/select_event.html: Added for SelectItemEventFire and SelectItemKeyEvent.
        * tests/data/select_event_remove_on_change.html: Added SelectItemRemoveSelectOnChange.
        * tests/data/select_event_remove_on_click.html: Added SelectItemRemoveSelectOnChange.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKitTestRunner needs an implementation of eventSender.
jberlin@webkit.org [Thu, 2 Jun 2011 16:36:55 +0000 (16:36 +0000)]
WebKitTestRunner needs an implementation of eventSender.
https://bugs.webkit.org/show_bug.cgi?id=42194

Add editing/pasteboard/copy-standalone-image-crash.html to the mac-wk2 skipped list to get
the bots green, as it uses eventSender.contextClick().

* platform/mac-wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 John Knottenbelt <jknotten@chromium.org>
jknotten@chromium.org [Thu, 2 Jun 2011 16:31:29 +0000 (16:31 +0000)]
2011-06-02  John Knottenbelt  <jknotten@chromium.org>

        Unreviewed.

        [Chromium] Rebaseline scaling-font-with-geometric-precision and navigator-detached-no-crash.
        https://bugs.webkit.org/show_bug.cgi?id=61934

        * platform/chromium-linux-x86/svg/text/scaling-font-with-geometric-precision-expected.png:
        * platform/chromium-mac-leopard/svg/text/scaling-font-with-geometric-precision-expected.png: Added.
        * platform/chromium-mac/fast/dom/navigator-detached-no-crash-expected.txt: Added.
        * platform/chromium-win/svg/text/scaling-font-with-geometric-precision-expected.png: Added.
        * platform/chromium-win/svg/text/scaling-font-with-geometric-precision-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKitTestRunner needs an implementation of setTextDirection.
jberlin@webkit.org [Thu, 2 Jun 2011 16:24:02 +0000 (16:24 +0000)]
WebKitTestRunner needs an implementation of setTextDirection.
https://bugs.webkit.org/show_bug.cgi?id=61931

Add fast/html/set-text-direction.html to the mac-wk2 skipped list to get the bots green.

* platform/mac-wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Thu, 2 Jun 2011 16:10:45 +0000 (16:10 +0000)]
2011-06-02  Mario Sanchez Prada  <msanchez@igalia.com>

        Unreviewed, skiping flaky test on GTK 32-bit Debug bot.

        * platform/gtk/Skipped: Skipped test.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Igor Oliveira <igor.oliveira@openbossa.org>
commit-queue@webkit.org [Thu, 2 Jun 2011 16:05:38 +0000 (16:05 +0000)]
2011-06-02  Igor Oliveira  <igor.oliveira@openbossa.org>

        Reviewed by Eric Seidel.

        [Qt] Rebaseline tables/mozilla/bugs/bug196870.html test after r73385
        https://bugs.webkit.org/show_bug.cgi?id=61781

        Rebaseline tables/mozilla/bugs/bug196870.html test after r73385.
        See bug #49220

        * platform/qt/Skipped:
        * platform/qt/tables/mozilla/bugs/bug196870-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 2 Jun 2011 15:59:38 +0000 (15:59 +0000)]
2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        Stop event propagation for cases where relatedTarget is both ancestor of the target and at shadow boundary.
        https://bugs.webkit.org/show_bug.cgi?id=61892

        * fast/events/shadow-boundary-crossing.html: Added a test that uses new shadow DOM testing machinery.
        * fast/events/shadow-boundary-crossing-expected.txt: Updated expectations.
2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        Stop event propagation for cases where relatedTarget is both ancestor of the target and at shadow boundary.
        https://bugs.webkit.org/show_bug.cgi?id=61892

        In the cases where the relatedTarget of an event is an ancestor of the target, and the relatedTarget is
        a shadow host, we should not allow events to escape out of the hosted shadow DOM subtree.

        * dom/EventDispatcher.cpp:
        (WebCore::EventDispatcher::adjustToShadowBoundaries): Added a check that is valid for both new and old shadow DOM.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Thu, 2 Jun 2011 15:48:11 +0000 (15:48 +0000)]
2011-06-02  Mario Sanchez Prada  <msanchez@igalia.com>

        Unreviewed, skipping failing tests in GTK after r87901.

        * platform/gtk/Skipped: Skipped 2 tests.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 John Knottenbelt <jknotten@chromium.org>
jknotten@chromium.org [Thu, 2 Jun 2011 15:46:45 +0000 (15:46 +0000)]
2011-06-02  John Knottenbelt  <jknotten@chromium.org>

        Unreviewed.

        Adjust test expectations, rebaseline windows SVG wicd tests.
        https://bugs.webkit.org/show_bug.cgi?id=61929

        * platform/chromium-win/svg/wicd/rightsizing-grid-expected.png: Added.
        * platform/chromium-win/svg/wicd/rightsizing-grid-expected.txt: Added.
        * platform/chromium-win/svg/wicd/test-rightsizing-a-expected.png: Added.
        * platform/chromium-win/svg/wicd/test-rightsizing-a-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Hans Wennborg <hans@chromium.org>
hans@chromium.org [Thu, 2 Jun 2011 15:32:57 +0000 (15:32 +0000)]
2011-06-02  Hans Wennborg  <hans@chromium.org>

        Reviewed by Tony Gentilcore.

        Fix LevelDBTransaction::clearTree()
        https://bugs.webkit.org/show_bug.cgi?id=61917

        This was broken in the code I copied it from; we can't delete and walk
        the tree at the same time.

        No new functionality, no new tests.

        * platform/leveldb/LevelDBTransaction.cpp:
        (WebCore::LevelDBTransaction::clearTree):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 John Knottenbelt <jknotten@chromium.org>
jknotten@chromium.org [Thu, 2 Jun 2011 14:53:41 +0000 (14:53 +0000)]
2011-06-02  John Knottenbelt  <jknotten@chromium.org>

        Unreviewed.

        Rebaseline SVG tests.
        https://bugs.webkit.org/show_bug.cgi?id=61927

        * platform/chromium-mac-leopard/svg/hixie/intrinsic/001-expected.png: Added.
        * platform/chromium-mac-leopard/svg/hixie/intrinsic/002-expected.png: Added.
        * platform/chromium-mac-leopard/svg/hixie/intrinsic/003-expected.png: Added.
        * platform/chromium-win/svg/as-image/svg-as-background-with-viewBox-expected.txt: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
        * platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png:
        * platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png:
        * platform/chromium-win/svg/hixie/intrinsic/001-expected.png: Added.
        * platform/chromium-win/svg/hixie/intrinsic/001-expected.txt: Added.
        * platform/chromium-win/svg/hixie/intrinsic/002-expected.png: Added.
        * platform/chromium-win/svg/hixie/intrinsic/002-expected.txt: Added.
        * platform/chromium-win/svg/hixie/intrinsic/003-expected.png: Added.
        * platform/chromium-win/svg/hixie/intrinsic/003-expected.txt: Added.
        * platform/chromium-win/svg/in-html/by-reference-expected.txt:
        * platform/chromium-win/svg/zoom/page/zoom-foreignObject-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Thu, 2 Jun 2011 14:44:48 +0000 (14:44 +0000)]
2011-06-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Eric Seidel.

        Adjust efl coding style to more efl directories
        https://bugs.webkit.org/show_bug.cgi?id=61903

        * Scripts/webkitpy/style/checker.py: Adjust efl coding style to efl directories.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Thu, 2 Jun 2011 14:40:00 +0000 (14:40 +0000)]
2011-06-02  Mario Sanchez Prada  <msanchez@igalia.com>

        Unreviewed, skipped tests crashing on GTK debug bots.

        * platform/gtk/Skipped: Skipped 2 more tests crashing on GTK debug
        bots because of the same reason than before (see WK bug 61924).

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Rob Buis <rbuis@rim.com>
rwlbuis@webkit.org [Thu, 2 Jun 2011 14:20:54 +0000 (14:20 +0000)]
2011-06-02  Rob Buis  <rbuis@rim.com>

        Reviewed by Nikolas Zimmermann.

        LayoutTests/svg/animations/animate-path-nested-transforms.html causes assertion in debug mode.
        https://bugs.webkit.org/show_bug.cgi?id=49045

        Fix mistake in id part of expected values.

        * svg/animations/script-tests/animate-mpath-insert.js:
        (executeTest):
        * svg/animations/script-tests/animate-path-nested-transforms.js:
        (executeTest):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 2 Jun 2011 14:12:10 +0000 (14:12 +0000)]
2011-06-02  Kent Tamura  <tkent@chromium.org>

        [Chromium] Update spinbutton expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Thu, 2 Jun 2011 14:00:38 +0000 (14:00 +0000)]
2011-06-02  Andreas Kling  <kling@webkit.org>

        Rubber-stamped by Simon Hausmann.

        Remove Qt's precompiled header hack as it was broken, and was not even
        used unless building WebKit inside a Qt tree.

        * WebKit_pch.h: Removed.
2011-06-02  Andreas Kling  <kling@webkit.org>

        Rubber-stamped by Simon Hausmann.

        Remove Qt's precompiled header hack as it was broken, and was not even
        used unless building WebKit inside a Qt tree.

        * WebCore.pri:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Thu, 2 Jun 2011 13:58:50 +0000 (13:58 +0000)]
2011-06-02  Mario Sanchez Prada  <msanchez@igalia.com>

        Unreviewed, skipped tests crashing on GTK debug bots.

        * platform/gtk/Skipped: Skipped 9 more tests crashing on GTK debug
        bots because of the same reason than before (see WK bug 61924).

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Thu, 2 Jun 2011 13:42:20 +0000 (13:42 +0000)]
2011-06-02  Mario Sanchez Prada  <msanchez@igalia.com>

        Unreviewed, skipped tests crashing on GTK debug bots.

        * platform/gtk/Skipped: Skipped 7 tests crashing, apparently all
        of them crash because of the same reason (see WK bug 61924).

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Thu, 2 Jun 2011 12:55:03 +0000 (12:55 +0000)]
2011-06-02  Andreas Kling  <kling@webkit.org>

        Unreviewed build fix.

        To support building namespaced Qt, we require that forward-declarations
        of Qt classes be wrapped in QT_BEGIN_NAMESPACE and QT_END_NAMESPACE.

        * WebCoreSupport/DumpRenderTreeSupportQt.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 James Robinson <jamesr@chromium.org>
commit-queue@webkit.org [Thu, 2 Jun 2011 12:52:37 +0000 (12:52 +0000)]
2011-06-02  James Robinson  <jamesr@chromium.org>

        Reviewed by Brady Eidson.

        DocumentLoader keeps a reference to all URL strings ever loaded leading to lots of memory waste
        https://bugs.webkit.org/show_bug.cgi?id=61894

        DocumentLoader::m_resourcesClientKnowsAbout is a set of all the URLs that have passed through
        FrameLoader::dispatchWillSendRequest() and is used by FrameLoader::loadedResourceFromMemoryCached to decide
        whether to inform the FrameLoader's m_client about this load.  Unfortunately, this set holds a reference to the
        URL string for every resource loaded, so on pages that use data URLs to "load" large amounts of data this leaks
        lots of memory.

        This set only has an effect on the Mac port, as the only two ports that implement
        FrameLoaderClient::dispatchDidLoadResourceFromMemoryCache() are Chromium and Mac and the Chromium implementation
        can correctly handle receiving multiple callbacks.  This patch limits the set to only PLATFORM(MAC) so other
        ports do not have to pay this memory cost.  It's possible that a better fix exists specifically for the Mac port
        implementation, but that would have to determined by someone who works on that port specifically.

        * loader/DocumentLoader.h:
        (WebCore::DocumentLoader::didTellClientAboutLoad):
        (WebCore::DocumentLoader::haveToldClientAboutLoad):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 John Knottenbelt <jknotten@chromium.org>
jknotten@chromium.org [Thu, 2 Jun 2011 12:52:17 +0000 (12:52 +0000)]
2011-06-02  John Knottenbelt  <jknotten@chromium.org>

        Unreviewed.

        [Chromium] Adjust test expectations.
        https://bugs.webkit.org/show_bug.cgi?id=61922

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Thu, 2 Jun 2011 12:48:52 +0000 (12:48 +0000)]
2011-06-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Implement hasWebView() in FrameLoaderClientEfl
        https://bugs.webkit.org/show_bug.cgi?id=61905

        * WebCoreSupport/FrameLoaderClientEfl.cpp:
        (WebCore::FrameLoaderClientEfl::hasWebView): Implement hasWebView() function.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Ryuan Choi <ryuan.choi@samsung.com>
commit-queue@webkit.org [Thu, 2 Jun 2011 12:24:29 +0000 (12:24 +0000)]
2011-06-02  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] No need to invalidate empty areas in ChromeClientEfl::invalidateContentsAndWindow
        https://bugs.webkit.org/show_bug.cgi?id=61902

        Just return to reduce unnecessary calls when invalidateContentsAndWindow
        received empty area.

        * WebCoreSupport/ChromeClientEfl.cpp:
        (WebCore::ChromeClientEfl::invalidateContentsAndWindow):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Aparna Nandyal <aparna.nand@wipro.com>
commit-queue@webkit.org [Thu, 2 Jun 2011 12:10:48 +0000 (12:10 +0000)]
2011-06-02  Aparna Nandyal  <aparna.nand@wipro.com>

        Reviewed by Andreas Kling.

        [Qt] Multiple drop events when doing DnD of images.
        https://bugs.webkit.org/show_bug.cgi?id=61504

        Duplicate entries of the url were getting added into drag data
        which is removed. The duplicate entries were causing the same image
        url to be copied twice. The code changes now match other webkit ports.

        * platform/qt/ClipboardQt.cpp:
        (WebCore::ClipboardQt::declareAndWriteDragImage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 Naiem Shaik <naiem.shaik@gmail.com>
commit-queue@webkit.org [Thu, 2 Jun 2011 12:00:55 +0000 (12:00 +0000)]
2011-06-02  Naiem Shaik  <naiem.shaik@gmail.com>

        Reviewed by Kent Tamura.

        Fixing invalid value being returned for default checkbox and radio state
        https://bugs.webkit.org/show_bug.cgi?id=61674

        As per http://www.w3.org/TR/html5/number-state.html#checkbox-state and
        http://www.w3.org/TR/html5/number-state.html#radio-button-state:
        The value IDL attribute is in mode default/on:
        If the element has a value attribute, it must return that attribute's
        value; otherwise, it must return the string "on".
        Currently default value is empty string;Default value of Radio button
        and checkbox should be "on"
        This works as per spec in IE9,Firefox and Opera

        * fast/forms/checkbox-default-value-expected.txt: Added.
        * fast/forms/checkbox-default-value.html: Added.
        * fast/forms/radio-default-value-expected.txt: Added.
        * fast/forms/radio-default-value.html: Added.
2011-06-02  Naiem Shaik  <naiem.shaik@gmail.com>

        Reviewed by Kent Tamura.

        Fixing invalid value being returned for default checkbox and radio state
        https://bugs.webkit.org/show_bug.cgi?id=61674

        As per http://www.w3.org/TR/html5/number-state.html#checkbox-state and
        http://www.w3.org/TR/html5/number-state.html#radio-button-state:
        The value IDL attribute is in mode default/on:
        If the element has a value attribute, it must return that attribute's
        value; otherwise, it must return the string "on".
        Currently default value is empty string;Default value of Radio button
        and checkbox should be "on".Changed fallbackValue function to return the same
        This works as per spec in IE9,Firefox and Opera

        Tests: fast/forms/checkbox-default-value.html
               fast/forms/radio-default-value.html

        * html/BaseCheckableInputType.cpp:
        (WebCore::BaseCheckableInputType::fallbackValue):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87896 268f45cc-cd09-0410-ab3c-d52691b4dbfc