WebKit.git
9 years agoRubberstamped by Eric Seidel.
kevino@webkit.org [Wed, 27 Apr 2011 01:08:59 +0000 (01:08 +0000)]
Rubberstamped by Eric Seidel.

Enable waf to be used to build other ports
https://bugs.webkit.org/show_bug.cgi?id=58213

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry again:
weinig@apple.com [Wed, 27 Apr 2011 00:53:55 +0000 (00:53 +0000)]
Try again:
    Remove JSDOMWrapperWithGlobalPointer now that all JSDOMWrappers have global objects
    https://bugs.webkit.org/show_bug.cgi?id=59310

Reviewed by Eric Seidel.

* bindings/js/JSDOMBinding.h:
(WebCore::DOMConstructorObject::DOMConstructorObject):
* bindings/js/JSDOMWrapper.h:
(WebCore::JSDOMWrapper::globalObject):
(WebCore::JSDOMWrapper::scriptExecutionContext):
(WebCore::JSDOMWrapper::createStructure):
(WebCore::JSDOMWrapper::JSDOMWrapper):
* bindings/scripts/CodeGeneratorJS.pm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Sam Weinig <sam@webkit.org>
weinig@apple.com [Wed, 27 Apr 2011 00:51:39 +0000 (00:51 +0000)]
2011-04-26  Sam Weinig  <sam@webkit.org>

        Reviewed by David Hyatt.

        Remove Datagrid from the tree
        https://bugs.webkit.org/show_bug.cgi?id=59543

        * Scripts/build-webkit:
        Remove feature.

        * iExploder/iexploder-1.3.2/htdocs/htmltags.in:
        * iExploder/iexploder-1.7.2/src/html-tags/webkit:
        Remove from fuzzer.
2011-04-26  Sam Weinig  <sam@webkit.org>

        Reviewed by David Hyatt.

        Remove Datagrid from the tree
        https://bugs.webkit.org/show_bug.cgi?id=59543

        * Configurations/FeatureDefines.xcconfig:
        Remove feature.
2011-04-26  Sam Weinig  <sam@webkit.org>

        Reviewed by David Hyatt.

        Remove Datagrid from the tree
        https://bugs.webkit.org/show_bug.cgi?id=59543

        * features.gypi:
        Remove feature.
2011-04-26  Sam Weinig  <sam@webkit.org>

        Reviewed by David Hyatt.

        Remove Datagrid from the tree
        https://bugs.webkit.org/show_bug.cgi?id=59543

        * Configurations/FeatureDefines.xcconfig:
        Remove feature.
2011-04-26  Sam Weinig  <sam@webkit.org>

        Reviewed by David Hyatt.

        Remove Datagrid from the tree
        https://bugs.webkit.org/show_bug.cgi?id=59543

        * Android.derived.jscbindings.mk:
        * Android.derived.v8bindings.mk:
        * Android.jscbindings.mk:
        * Android.v8bindings.mk:
        * CMakeLists.txt:
        * CodeGenerators.pri:
        * Configurations/FeatureDefines.xcconfig:
        * DerivedSources.cpp:
        * DerivedSources.make:
        * GNUmakefile.am:
        * GNUmakefile.list.am:
        * UseJSC.cmake:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSBindingsAllInOne.cpp:
        * bindings/js/JSDataGridColumnListCustom.cpp: Removed.
        * bindings/js/JSDataGridDataSource.cpp: Removed.
        * bindings/js/JSDataGridDataSource.h: Removed.
        * bindings/js/JSHTMLDataGridElementCustom.cpp: Removed.
        * bindings/v8/V8DataGridDataSource.cpp: Removed.
        * bindings/v8/V8DataGridDataSource.h: Removed.
        * bindings/v8/custom/V8DataGridColumnListCustom.cpp: Removed.
        * bindings/v8/custom/V8HTMLDataGridElementCustom.cpp: Removed.
        * css/CSSStyleSelector.cpp:
        * css/CSSStyleSelector.h:
        * css/html.css:
        (input, textarea, keygen, select, button, isindex):
        (select:disabled, keygen:disabled, optgroup:disabled, option:disabled):
        * editing/htmlediting.cpp:
        (WebCore::canHaveChildrenForEditing):
        * features.pri:
        * html/DOMDataGridDataSource.cpp: Removed.
        * html/DOMDataGridDataSource.h: Removed.
        * html/DataGridColumn.cpp: Removed.
        * html/DataGridColumn.h: Removed.
        * html/DataGridColumn.idl: Removed.
        * html/DataGridColumnList.cpp: Removed.
        * html/DataGridColumnList.h: Removed.
        * html/DataGridColumnList.idl: Removed.
        * html/DataGridDataSource.h: Removed.
        * html/HTMLDataGridCellElement.cpp: Removed.
        * html/HTMLDataGridCellElement.h: Removed.
        * html/HTMLDataGridCellElement.idl: Removed.
        * html/HTMLDataGridColElement.cpp: Removed.
        * html/HTMLDataGridColElement.h: Removed.
        * html/HTMLDataGridColElement.idl: Removed.
        * html/HTMLDataGridElement.cpp: Removed.
        * html/HTMLDataGridElement.h: Removed.
        * html/HTMLDataGridElement.idl: Removed.
        * html/HTMLDataGridRowElement.cpp: Removed.
        * html/HTMLDataGridRowElement.h: Removed.
        * html/HTMLDataGridRowElement.idl: Removed.
        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::ieForbidsInsertHTML):
        * html/HTMLElementsAllInOne.cpp:
        * html/HTMLTagNames.in:
        * page/DOMWindow.idl:
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::sizesToIntrinsicLogicalWidth):
        * rendering/RenderDataGrid.cpp: Removed.
        * rendering/RenderDataGrid.h: Removed.
        * rendering/RenderingAllInOne.cpp:
2011-04-26  Sam Weinig  <sam@webkit.org>

        Reviewed by David Hyatt.

        Remove Datagrid from the tree
        https://bugs.webkit.org/show_bug.cgi?id=59543

        * Configurations/FeatureDefines.xcconfig:
        Remove feature.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Brent Fulgham <bfulgham@webkit.org>
bfulgham@webkit.org [Wed, 27 Apr 2011 00:29:28 +0000 (00:29 +0000)]
2011-04-26  Brent Fulgham  <bfulgham@webkit.org>

        Reviewed by Adam Roben.

        Implement a transparent WebView under Windows.  This feature
        allows the user to create small web-based applications, similar
        to the dashboard on Mac OS X.
        https://bugs.webkit.org/show_bug.cgi?id=58300

        * Interfaces/IWebViewPrivate.idl: Add new set/get accessors to
        change the state of a WebView into a Layered Window, or back
        into a standard window.
        * Interfaces/WebKit.idl: touch to force clean build
        * WebView.cpp:
        (WebView::WebView): Set layered window state in constructor.
        (WebView::updateBackingStore): Cleanup old bitmap when finished.
        (WebView::performLayeredWindowUpdate): New method to do the work
        of calling ::UpdateLayeredWindow for the WebView with proper
        alpha blending.
        (WebView::paint): Small change to prevent accelerated compositing
        when using a layered window.  DirectX is not compatible with
        ::UpdateLayeredWindow (at least currently).
        (WebView::WebViewWndProc): Adjust main window procedure to avoid
        painting a default background on a layered window (this is handled
        by Windows during compositing), and to deal with paint messages
        properly in the layered window case.
        (WebView::active): The layered window is not a child window,
        so the active state logic is slightly different.
        (WebView::setUsesLayeredWindow): New set method for layered stated.
        When called, it will convert a WebView into a Layered Window.
        (WebView::usesLayeredWindow): Accessor
        * WebView.h:
        (WebView::setUsesLayeredWindow): Declare new accessor
        (WebView::usesLayeredWindow): Declare new accessor
2011-04-26  Brent Fulgham  <bfulgham@webkit.org>

        Reviewed by Adam Roben.

        Update WinLauncher with command-line arguments to allow the
        transparency to be tested.  Use --transparent to create a
        transparent view.  Use --desktop to have the view fill the
        desktop area of the screen.
        https://bugs.webkit.org/show_bug.cgi?id=58300

        * WinLauncher/WinLauncher.cpp:
        (usesLayeredWebView): New method to indicate that the
        program is running with layered windows (alpha-blended
        transparent windows).
        (shouldUseFullDesktop): New method to indicate that the
        program is running across the full desktop (less any
        task bars.)
        (resizeSubViews): Layered window mode doesn't have any
        winapi child windows, so this routine is exited early
        for that case.
        (subclassForLayeredWindow): Subclass the window so we can
        override its defaut message loop.
        (computeFullDesktopFrame): Convenience function to get the
        desktop region and update the frame dimensions appropriately.
        (_tWinMain): Updated to accept the new '--transparent' and
        '--desktop' arguments.
        (InitInstance): Modified to exit early for the transparent
        background case.  WebKit will construct our primary window (with
        appropriate settings) so we don't need to create one ourselves.
        (WndProc):
        (TransparentWndProc): New message loop for transparent windows,
        since they need special handling to support dragging.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Chun-Lung Huang <alvincl.huang@gmail.com>
commit-queue@webkit.org [Wed, 27 Apr 2011 00:17:41 +0000 (00:17 +0000)]
2011-04-26  Chun-Lung Huang  <alvincl.huang@gmail.com>

        Reviewed by Adele Peterson.

        On WebKit (Windows), glyphs in vertical text tests are rotated 90
        degrees clockwise.  https://bugs.webkit.org/show_bug.cgi?id=48459

        This platform dependent patch makes WebKit (Windows) show the
        vertical writing text correctly.  Job was done by adding a prefix '@'
        in front of the font family name (Windows Only). No new tests added.
        Some layout tests images:
        http://www.flickr.com/photos/burorly/sets/72157625585506341/

        * platform/graphics/FontPlatformData.h:
        * platform/graphics/win/FontCacheWin.cpp:
        (WebCore::FontCache::getFontDataForCharacters):
        (WebCore::FontCache::createFontPlatformData):
        * platform/graphics/win/FontCustomPlatformData.cpp:
        (WebCore::FontCustomPlatformData::fontPlatformData):
        * platform/graphics/win/FontPlatformDataCGWin.cpp:
        (WebCore::FontPlatformData::FontPlatformData):
        * platform/graphics/win/FontPlatformDataWin.cpp:
        (WebCore::FontPlatformData::FontPlatformData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Wed, 27 Apr 2011 00:15:31 +0000 (00:15 +0000)]
2011-04-26  Jer Noble  <jer.noble@apple.com>

        Reviewed by Brady Eidson.

        HTML5 video fullscreen transition causes an audio stutter
        https://bugs.webkit.org/show_bug.cgi?id=59544

        AVFoundation will momentarily stutter when you disconnect a AVPlayerLayer
        from its AVPlayer.  Since you shouldn't necessarily have to destroy the
        layer to render it invisible, instead just set the layer as hidden.

        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
        (WebCore::MediaPlayerPrivateAVFoundation::setVisible): Call through to platformSetVisible().
        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
        (WebCore::MediaPlayerPrivateAVFoundationObjC::platformSetVisible): Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Alejandro G. Castro <alex@igalia.com>
mrobinson@webkit.org [Wed, 27 Apr 2011 00:07:48 +0000 (00:07 +0000)]
2011-04-26  Alejandro G. Castro  <alex@igalia.com>

        Remove gtk specific render expectations after the tests were
        converted in text tests (r84873).

        * platform/gtk/animations/animation-drt-api-expected.txt: Removed.
        * platform/gtk/animations/animation-drt-api-multiple-keyframes-expected.txt: Removed.
2011-04-26  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] flaky crash  storage/open-database-set-empty-version.html
        https://bugs.webkit.org/show_bug.cgi?id=58988

        Construct the security origin directly instead of getting it from the WebKitWebFrame object.
        This prevents failing to create the WebKitSecurityOrigin in cases where the frame is in
        some inconsistent state.

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::exceededDatabaseQuota): Construct the origin directly.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Adrienne Walker <enne@google.com>
enne@google.com [Wed, 27 Apr 2011 00:06:48 +0000 (00:06 +0000)]
2011-04-26  Adrienne Walker  <enne@google.com>

        Reviewed by Geoffrey Garen.

        Fix incorrect use of OwnPtr<T*> in GCActivityCallback
        https://bugs.webkit.org/show_bug.cgi?id=59559

        * runtime/GCActivityCallback.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Alexandre MAzari <amazari@igalia.com>
commit-queue@webkit.org [Wed, 27 Apr 2011 00:05:24 +0000 (00:05 +0000)]
2011-04-26  Alexandre MAzari  <amazari@igalia.com>

        Reviewed by Xan Lopez.

        [Gtk] Implement LayoutTestController::setPluginsEnabled
        https://bugs.webkit.org/show_bug.cgi?id=59184

        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::setPluginsEnabled):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Wed, 27 Apr 2011 00:01:55 +0000 (00:01 +0000)]
2011-04-26  Alejandro G. Castro  <alex@igalia.com>

        Remove gtk specific render expectations after the tests were
        converted in text tests (r84873).

        * platform/gtk/animations/animation-drt-api-expected.txt: Removed.
        * platform/gtk/animations/animation-drt-api-multiple-keyframes-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Christian Dywan <christian@lanedo.com>
commit-queue@webkit.org [Tue, 26 Apr 2011 23:57:33 +0000 (23:57 +0000)]
2011-04-26  Christian Dywan  <christian@lanedo.com>

        Reviewed by Eric Seidel.

        Extra separator after Select All in context menu
        https://bugs.webkit.org/show_bug.cgi?id=54092

        * page/ContextMenuController.cpp: Move separator to non-GTK+
            port guards since it is for the spelling options menu
            which the GTK+ port doesn't use.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Sheriff Bot <webkit.review.bot@gmail.com>
dpranke@chromium.org [Tue, 26 Apr 2011 23:53:03 +0000 (23:53 +0000)]
2011-04-26  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r84951.
        http://trac.webkit.org/changeset/84951
        https://bugs.webkit.org/show_bug.cgi?id=59558

        "breaks chromium compile" (Requested by dpranke on #webkit).

        * WebKit.gyp:
        * public/WebFrame.h:
        * public/WebWidget.h:
        * public/mac/WebSubstringUtil.h: Removed.
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::firstRectForCharacterRange):
        * src/WebFrameImpl.h:
        * src/WebPopupMenuImpl.cpp:
        * src/WebPopupMenuImpl.h:
        * src/WebViewImpl.cpp:
        * src/WebViewImpl.h:
        * src/mac/WebSubstringUtil.mm: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 26 Apr 2011 23:51:05 +0000 (23:51 +0000)]
2011-04-26  James Robinson  <jamesr@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Clear out LayerTilerChromium's tiles on lost context
        https://bugs.webkit.org/show_bug.cgi?id=59233

        Clears out the LayerTilerChromium's tile set when the LayerRendererChromium is reset.  In this case the tiles are
        no longer valid since they exist in the previous LayerRendererChromium.

        Will be tested by a chrome test since we don't have any way to exercise the context lost case in layout tests.

        * platform/graphics/chromium/LayerTilerChromium.h:
        (WebCore::LayerTilerChromium::setLayerRenderer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Chang Shu <cshu@webkit.org>
commit-queue@webkit.org [Tue, 26 Apr 2011 23:43:03 +0000 (23:43 +0000)]
2011-04-26  Chang Shu  <cshu@webkit.org>

        Reviewed by Laszlo Gombos.

        WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
        https://bugs.webkit.org/show_bug.cgi?id=57572

        Remove the unnecessary code that updates preference.

        * Shared/WebPreferencesStore.cpp:
        (WebKit::WebPreferencesStore::decode):
        * Shared/WebPreferencesStore.h:
        * WebProcess/InjectedBundle/API/c/WKBundle.cpp:
        (WKBundleSetAllowUniversalAccessFromFileURLs):
        * WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
        * WebProcess/InjectedBundle/InjectedBundle.cpp:
        (WebKit::InjectedBundle::setAllowUniversalAccessFromFileURLs):
        (WebKit::InjectedBundle::setAllowFileAccessFromFileURLs):
        * WebProcess/InjectedBundle/InjectedBundle.h:
2011-04-26  Chang Shu  <cshu@webkit.org>

        Reviewed by Laszlo Gombos.

        WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
        https://bugs.webkit.org/show_bug.cgi?id=57572

        Remove the unnecessary code that updates preference.

        * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
        (WTR::InjectedBundle::beginTesting):
        * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
        (WTR::LayoutTestController::setAllowUniversalAccessFromFileURLs):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 26 Apr 2011 23:35:25 +0000 (23:35 +0000)]
2011-04-26  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Dirk Schulze.

        [GTK] Flash in divs with overflow: auto is not positioned and clipped properly
        https://bugs.webkit.org/show_bug.cgi?id=57644

        Manual test: plugins/windowed-in-iframe-2.html

        * manual-tests/plugins/windowed-in-iframe-2.html: Added.
        * platform/gtk/WidgetGtk.cpp:
        (WebCore::Widget::setFrameRect): Like the Qt port, we notify the widget via frameRectsChanged.
        * plugins/PluginView.h: Added helper method to set the allocation and clip.
        * plugins/gtk/PluginViewGtk.cpp:
        (WebCore::PluginView::setNPWindowIfNeeded):Call the helper method instead of setting
        the allocation immediately. Bring this method into sync with the implementation in
        the Qt port.
        (WebCore::PluginView::updateWidgetAllocationAndClip): Added.
        (WebCore::PluginView::plugAddedCallback): Call the new helper method.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 26 Apr 2011 23:31:59 +0000 (23:31 +0000)]
2011-04-26  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Eric Seidel.

        [GTK]  fast/block/float/overhanging-tall-block.html crashes in the bots
        https://bugs.webkit.org/show_bug.cgi?id=58818

        * platform/gtk/Skipped: Unskip a test which is no longer crashing.
2011-04-26  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Eric Seidel.

        [GTK]  fast/block/float/overhanging-tall-block.html crashes in the bots
        https://bugs.webkit.org/show_bug.cgi?id=58818

        Prevent allocating scratch buffers larger than the target GdkDrawable
        when creating a WidgetRenderingContext. This prevents incredibly large
        widgets from crashing the X Server. This change also allowed greatly
        simplifying the way that the painting offset is calculated.

        * platform/gtk/WidgetRenderingContext.cpp:
        (WebCore::WidgetRenderingContext::WidgetRenderingContext): Never allocate a pixmap
        larger than the target GdkDrawable.
        (WebCore::WidgetRenderingContext::~WidgetRenderingContext): Calculate the offset of the
        blit by looking at the location of the target rect itself, rather than delaying the
        calculation up to this point.
        (WebCore::WidgetRenderingContext::calculateClipRect): Added.
        (WebCore::WidgetRenderingContext::gtkPaintBox): Use the new calculateClipRectHelper.
        (WebCore::WidgetRenderingContext::gtkPaintFlatBox): Ditto.
        (WebCore::WidgetRenderingContext::gtkPaintFocus): Ditto.
        (WebCore::WidgetRenderingContext::gtkPaintSlider): Ditto.
        (WebCore::WidgetRenderingContext::gtkPaintCheck): Ditto.
        (WebCore::WidgetRenderingContext::gtkPaintOption): Ditto.
        (WebCore::WidgetRenderingContext::gtkPaintShadow): Ditto.
        (WebCore::WidgetRenderingContext::gtkPaintArrow): Ditto.
        (WebCore::WidgetRenderingContext::gtkPaintVLine): Ditto.
        * platform/gtk/WidgetRenderingContext.h: Remove some now unused members. Add
        a member to store the IntSize mapping from the coordinates of the target to the coordinates
        of the scratch buffer.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 26 Apr 2011 23:31:33 +0000 (23:31 +0000)]
2011-04-26  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Daniel Bates.

        Unused but set variable warning in MacroAssembelX86_64
        https://bugs.webkit.org/show_bug.cgi?id=59482

        * assembler/MacroAssemblerX86_64.h:
        (JSC::MacroAssemblerX86_64::call): do not declare the label
        variable if we are not going to use it.
        (JSC::MacroAssemblerX86_64::tailRecursiveCall): ditto.
        (JSC::MacroAssemblerX86_64::makeTailRecursiveCall): ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Tue, 26 Apr 2011 23:26:07 +0000 (23:26 +0000)]
2011-04-26  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Barth.

        Respect charset in handleDataURL
        https://bugs.webkit.org/show_bug.cgi?id=47746

        Original patch by Kwang Yul Seo <skyul@company100.net>

        We must use TextEncoding(charset) to encode data URL again. Otherwise TextEncoding::encode()
        returns an empty string because encoding name is not specified.

        Also use "US-ASCII" as fallback charset as extractCharsetFromMediaType can be empty.

        This change fixes over 130 layout tests when running GTK port with cURL network backend.

        * platform/network/DataURL.cpp:
        (WebCore::handleDataURL):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Tue, 26 Apr 2011 23:20:39 +0000 (23:20 +0000)]
2011-04-26  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Eric Seidel.

        [GTK] accessibility/aria-combobox-expected.txt
        https://bugs.webkit.org/show_bug.cgi?id=59399

        Unskip the test and provide expectations for Mac and GTK.

        * accessibility/aria-combobox.html: Do not check roles to be the
        right ones, print them and leave the check for the expected file.
        * platform/gtk/Skipped: Unskip the test.
        * platform/gtk/accessibility/aria-combobox-expected.txt: New.
        * platform/mac/accessibility/aria-combobox-expected.txt: Updated.
2011-04-26  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Eric Seidel.

        [GTK] accessibility/aria-combobox-expected.txt
        https://bugs.webkit.org/show_bug.cgi?id=59399

        Implement isExpanded(), as it's used in the layout test.

        * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
        (AccessibilityUIElement::isExpanded): Implemented.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Yi Shen <yi.4.shen@nokia.com>
yi.4.shen@nokia.com [Tue, 26 Apr 2011 23:18:50 +0000 (23:18 +0000)]
2011-04-26  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Tor Arne Vestbø.

        [Qt][Symbian] Fix Api test failure -- tst_QWebFrame::setHtmlWithBaseURL
        https://bugs.webkit.org/show_bug.cgi?id=56946

        Deployed the missing resource for Symbian platform.

        * tests/qwebframe/qwebframe.pro:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Adrienne Walker <enne@google.com>
enne@google.com [Tue, 26 Apr 2011 23:18:22 +0000 (23:18 +0000)]
2011-04-26  Adrienne Walker  <enne@google.com>

        Reviewed by Kent Tamura.

        [chromium] Fix memory leak in DRT due to OwnPtr<T*>
        https://bugs.webkit.org/show_bug.cgi?id=59489

        * DumpRenderTree/chromium/WebViewHost.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Grzegorz Czajkowski <g.czajkowski@samsung.com>
commit-queue@webkit.org [Tue, 26 Apr 2011 23:17:54 +0000 (23:17 +0000)]
2011-04-26  Grzegorz Czajkowski  <g.czajkowski@samsung.com>

        Reviewed by Antonio Gomes.

        [EFL] Update signals description
        https://bugs.webkit.org/show_bug.cgi?id=56904

        Add, fix signals description that are emitted by evas_object_smart_callcabck_call in
        ewk_view, ewk_frame, ewk_contextmenu.

        * ewk/ewk_contextmenu.h:
        * ewk/ewk_frame.h:
        * ewk/ewk_view.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix clang++ build.
andersca@apple.com [Tue, 26 Apr 2011 23:15:12 +0000 (23:15 +0000)]
Fix clang++ build.

You can never have too many casts!

* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper position]):
* editing/mac/SelectionControllerMac.mm:
(WebCore::accessibilityConvertScreenRect):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit2: Docked Inspector doesn't behave well if inspected web view isn't at 0,0
bweinstein@apple.com [Tue, 26 Apr 2011 23:12:18 +0000 (23:12 +0000)]
WebKit2: Docked Inspector doesn't behave well if inspected web view isn't at 0,0
https://bugs.webkit.org/show_bug.cgi?id=59554
<rdar://problem/9341188>

Reviewed by Steve Falkenburg.

Use GetWindowRect and ScreenToClient to properly place our inspector and inspected
web views instead of using GetClientRect. We need to correctly handle the case where
the inspected web view isn't at 0, 0.

* UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::platformSetAttachedWindowHeight):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Chris Rogers <crogers@google.com>
crogers@google.com [Tue, 26 Apr 2011 23:11:48 +0000 (23:11 +0000)]
2011-04-26  Chris Rogers  <crogers@google.com>

        Reviewed by Kenneth Russell.

        Fix web audio build on mac port
        https://bugs.webkit.org/show_bug.cgi?id=59355

        No new tests since audio API is not yet implemented.

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSAudioContextCustom.cpp:
        (WebCore::JSAudioContext::visitChildren):
        * bindings/js/JSJavaScriptAudioNodeCustom.cpp:
        (WebCore::JSJavaScriptAudioNode::visitChildren):
        * webaudio/AudioContext.idl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Chris Rogers <crogers@google.com>
crogers@google.com [Tue, 26 Apr 2011 23:01:36 +0000 (23:01 +0000)]
2011-04-26  Chris Rogers  <crogers@google.com>

        Reviewed by Kenneth Russell.

        Add FFTFrame implementation for FFmpeg
        https://bugs.webkit.org/show_bug.cgi?id=59408

        No new tests since audio API is not yet implemented.

        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:
        * platform/audio/FFTFrame.h:
        * platform/audio/FFTFrameStub.cpp:
        * platform/audio/ffmpeg: Added.
        * platform/audio/ffmpeg/FFTFrameFFMPEG.cpp: Added.
        (WebCore::FFTFrame::FFTFrame):
        (WebCore::FFTFrame::initialize):
        (WebCore::FFTFrame::cleanup):
        (WebCore::FFTFrame::~FFTFrame):
        (WebCore::FFTFrame::multiply):
        (WebCore::FFTFrame::doFFT):
        (WebCore::FFTFrame::doInverseFFT):
        (WebCore::FFTFrame::realData):
        (WebCore::FFTFrame::imagData):
        (WebCore::FFTFrame::getUpToDateComplexData):
        (WebCore::FFTFrame::contextForSize):
        * platform/audio/mac/FFTFrameMac.cpp:
        * webaudio/ConvolverNode.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Daniel Cheng <dcheng@chromium.org>
dcheng@chromium.org [Tue, 26 Apr 2011 22:59:06 +0000 (22:59 +0000)]
2011-04-26  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by Eric Seidel.

        [chromium] Implement EditorClient::canCopyCut and EditorClient::canPaste
        https://bugs.webkit.org/show_bug.cgi?id=59264

        * public/WebViewClient.h:
        (WebKit::WebViewClient::canTriggerClipboardRead):
        (WebKit::WebViewClient::canTriggerClipboardWrite):
        * src/EditorClientImpl.cpp:
        (WebKit::EditorClientImpl::canCopyCut):
        (WebKit::EditorClientImpl::canPaste):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Mario Sanchez Prada <msanchez@igalia.com>
commit-queue@webkit.org [Tue, 26 Apr 2011 22:58:25 +0000 (22:58 +0000)]
2011-04-26  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Eric Seidel.

        [GTK] Implement isChecked in DRT
        https://bugs.webkit.org/show_bug.cgi?id=59385

        * platform/gtk/Skipped: Unskip the layout test
        accessibility/aria-checkbox-checked.html.
2011-04-26  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Eric Seidel.

        [GTK] Implement isChecked in DRT
        https://bugs.webkit.org/show_bug.cgi?id=59385

        * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
        (AccessibilityUIElement::isChecked): Implemented.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Tue, 26 Apr 2011 22:47:27 +0000 (22:47 +0000)]
2011-04-26  Alejandro G. Castro  <alex@igalia.com>

        Unreviewed, rolling out r84949.
        http://trac.webkit.org/changeset/84949
        https://bugs.webkit.org/show_bug.cgi?id=58852

        Broke GTK+ compilation

        * GtkLauncher/main.c:
        (main):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Tue, 26 Apr 2011 22:10:11 +0000 (22:10 +0000)]
2011-04-26  Alejandro G. Castro  <alex@igalia.com>

        Skipped insecure-css-in-iframe.html, we are missing
        didRunInsecureContent notification.

        * platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Add platform specific expected results for new passing tests.
ossy@webkit.org [Tue, 26 Apr 2011 22:00:36 +0000 (22:00 +0000)]
[Qt] Add platform specific expected results for new passing tests.

* platform/qt/fast/backgrounds/background-leakage-expected.png: Added.
* platform/qt/fast/backgrounds/background-leakage-expected.txt: Added.
* platform/qt/fast/backgrounds/background-leakage-transforms-expected.png: Added.
* platform/qt/fast/backgrounds/background-leakage-transforms-expected.txt: Added.
* platform/qt/fast/backgrounds/gradient-background-leakage-expected.png: Added.
* platform/qt/fast/backgrounds/gradient-background-leakage-expected.txt: Added.
* platform/qt/fast/block/positioning/rtl-fixed-positioning-expected.png: Added.
* platform/qt/fast/block/positioning/rtl-fixed-positioning-expected.txt: Added.
* platform/qt/fast/block/positioning/vertical-rl/fixed-positioning-expected.png: Added.
* platform/qt/fast/block/positioning/vertical-rl/fixed-positioning-expected.txt: Added.
* platform/qt/fast/borders/bidi-002-expected.png: Added.
* platform/qt/fast/borders/bidi-002-expected.txt: Added.
* platform/qt/fast/borders/bidi-009a-expected.png: Added.
* platform/qt/fast/borders/bidi-009a-expected.txt: Added.
* platform/qt/fast/borders/bidi-012-expected.png: Added.
* platform/qt/fast/borders/bidi-012-expected.txt: Added.
* platform/qt/fast/borders/border-radius-different-width-001-expected.png: Added.
* platform/qt/fast/borders/border-radius-different-width-001-expected.txt: Added.
* platform/qt/fast/borders/border-radius-inset-outset-expected.png: Added.
* platform/qt/fast/borders/border-radius-inset-outset-expected.txt: Added.
* platform/qt/fast/borders/mixed-border-styles-expected.png: Added.
* platform/qt/fast/borders/mixed-border-styles-expected.txt: Added.
* platform/qt/fast/borders/mixed-border-styles-radius-expected.png: Added.
* platform/qt/fast/borders/mixed-border-styles-radius-expected.txt: Added.
* platform/qt/fast/borders/table-borders-expected.png: Added.
* platform/qt/fast/borders/table-borders-expected.txt: Added.
* platform/qt/fast/borders/webkit-border-radius-expected.png: Added.
* platform/qt/fast/borders/webkit-border-radius-expected.txt: Added.
* platform/qt/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Added.
* platform/qt/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Added.
* platform/qt/fast/dom/HTMLProgressElement/progress-writing-mode-expected.png: Added.
* platform/qt/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Added.
* platform/qt/fast/forms/select-background-none-expected.png: Added.
* platform/qt/fast/forms/select-background-none-expected.txt: Added.
* platform/qt/fast/html/details-add-child-1-expected.png: Added.
* platform/qt/fast/html/details-add-child-1-expected.txt: Added.
* platform/qt/fast/html/details-add-child-2-expected.png: Added.
* platform/qt/fast/html/details-add-child-2-expected.txt: Added.
* platform/qt/fast/html/details-add-summary-child-1-expected.png: Added.
* platform/qt/fast/html/details-add-summary-child-1-expected.txt: Added.
* platform/qt/fast/html/details-add-summary-child-2-expected.png: Added.
* platform/qt/fast/html/details-add-summary-child-2-expected.txt: Added.
* platform/qt/fast/html/details-remove-child-1-expected.png: Added.
* platform/qt/fast/html/details-remove-child-1-expected.txt: Added.
* platform/qt/fast/html/details-remove-child-2-expected.png: Added.
* platform/qt/fast/html/details-remove-child-2-expected.txt: Added.
* platform/qt/fast/html/details-remove-summary-child-1-expected.png: Added.
* platform/qt/fast/html/details-remove-summary-child-1-expected.txt: Added.
* platform/qt/fast/html/details-remove-summary-child-2-expected.png: Added.
* platform/qt/fast/html/details-remove-summary-child-2-expected.txt: Added.
* platform/qt/fast/inline/positioned-object-between-replaced-elements-expected.png: Added.
* platform/qt/fast/inline/positioned-object-between-replaced-elements-expected.txt: Added.
* platform/qt/fast/table/auto-100-percent-width-expected.png: Added.
* platform/qt/fast/table/auto-100-percent-width-expected.txt: Added.
* platform/qt/fast/text/zero-font-size-expected.png: Added.
* platform/qt/fast/text/zero-font-size-expected.txt: Added.
* platform/qt/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Added.
* platform/qt/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt: Added.
* platform/qt/svg/filters/feDropShadow-expected.png: Added.
* platform/qt/svg/filters/feDropShadow-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed.
antti@apple.com [Tue, 26 Apr 2011 21:52:33 +0000 (21:52 +0000)]
Not reviewed.

Flaky Test: fast/loader/file-protocol-fragment.html
https://bugs.webkit.org/show_bug.cgi?id=59488

* fast/loader/file-protocol-fragment.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 26 Apr 2011 21:49:10 +0000 (21:49 +0000)]
2011-04-26  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Daniel Bates.

        Convert some transition tests to use the pause API, and more cleanup
        https://bugs.webkit.org/show_bug.cgi?id=59490

        * animations/animation-drt-api.html:
        Fail message was the same as the pass message (doh!).

        * platform/chromium-linux/transitions/transition-drt-api-expected.png: Removed.
        * platform/chromium-win/transitions/transition-drt-api-expected.png: Removed.
        * platform/chromium-win/transitions/transition-drt-api-expected.txt: Removed.
        * platform/gtk/transitions/transition-drt-api-expected.txt: Removed.
        * platform/mac/transitions/transition-drt-api-expected.png: Removed.
        * platform/mac/transitions/transition-drt-api-expected.txt: Removed.
        * transitions/transition-drt-api-expected.txt: Added.
        * transitions/transition-drt-api.html:
        Made into a text test.
        * transitions/font-family-during-transition.html:
        Use the pause API.
        * transitions/transition-drt-api-delay.html:
        General cleanup.
        * transitions/bad-transition-shorthand-crash.html:
        Shorten the test.
        * transitions/border-radius-transition.html:
        * transitions/default-timing-function.html:
        * transitions/interrupt-zero-duration.html:
        Remove style attribute
        * transitions/color-transition-premultiplied.html:
        * transitions/transition-timing-function-expected.txt:
        * transitions/transition-timing-function.html:
        Use pause API.
        * transitions/inherit-other-props.html:
        * transitions/transform-op-list-match.html:
        Whitespace.
        * transitions/opacity-transition-zindex.html:
        Add FIXME.
        * transitions/transition-shorthand-delay-expected.txt:
        * transitions/transition-shorthand-delay.html:
        * transitions/zero-duration-with-non-zero-delay-start-expected.txt:
        * transitions/zero-duration-with-non-zero-delay-start.html:
        Use runTransitionTest().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Evan Martin <evan@chromium.org>
evan@chromium.org [Tue, 26 Apr 2011 21:44:08 +0000 (21:44 +0000)]
2011-04-26  Evan Martin  <evan@chromium.org>

        Unreviewed, Chrome/Mac build fix.

        * WebKit.gypi: Remove extra file.  (I removed a subtraction, but
        forgot to remove the corresponding addition that the subtraction
        was counteracting.)

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Tue, 26 Apr 2011 21:43:37 +0000 (21:43 +0000)]
2011-04-26  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Adam Barth.

        [Windows and Leopard Tests] media/invalid-media-url-crash.html failing since r84762
        https://bugs.webkit.org/show_bug.cgi?id=59324

        Use a properly invalid URL, instead of http:aa. This also allows the test to
        be unskipped on SL.

        * media/invalid-media-url-crash.html:
        * platform/mac-snowleopard/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a newline at the end of SVGFEDropShadowElement.idl.
jeffm@apple.com [Tue, 26 Apr 2011 21:37:17 +0000 (21:37 +0000)]
Add a newline at the end of SVGFEDropShadowElement.idl.

* svg/SVGFEDropShadowElement.idl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Tue, 26 Apr 2011 21:29:01 +0000 (21:29 +0000)]
2011-04-26  Stephen White  <senorblanco@chromium.org>

        Unreviewed; chromium test expectations update.

        * platform/chromium/test_expectations.txt:
        fast/css/table-border-spacing.html is flaky in Debug.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Tue, 26 Apr 2011 21:21:53 +0000 (21:21 +0000)]
2011-04-26  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Eric Seidel.

        InlineBox.h shouldn't include RenderBR.h
        https://bugs.webkit.org/show_bug.cgi?id=59480

        Per bug 59348 RenderBR.h is a "top header" by include * size, because
        InlineBox.h includes it. There's no reason why it has to.

        * rendering/InlineBox.h:
        * rendering/InlineTextBox.cpp:
        * rendering/RenderBlock.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 26 Apr 2011 21:21:44 +0000 (21:21 +0000)]
2011-04-26  Eric Seidel  <eric@webkit.org>

        Reviewed by Mihai Parparita.

        sheriff-bot should have a create-bug command
        https://bugs.webkit.org/show_bug.cgi?id=59491

        This patch has some stderr unittest spew, but I will
        fix it after my live demo.

        * Scripts/webkitpy/tool/bot/irc_command.py:
        * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
        * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNope, roll out r84950 and r84952. Working on a laptop is clearly not something
weinig@apple.com [Tue, 26 Apr 2011 21:15:28 +0000 (21:15 +0000)]
Nope, roll out r84950 and r84952. Working on a laptop is clearly not something
I should do.

* bindings/js/JSDOMBinding.h:
(WebCore::JSDOMWrapperWithGlobalPointer::globalObject):
(WebCore::JSDOMWrapperWithGlobalPointer::scriptExecutionContext):
(WebCore::JSDOMWrapperWithGlobalPointer::createStructure):
(WebCore::JSDOMWrapperWithGlobalPointer::JSDOMWrapperWithGlobalPointer):
(WebCore::DOMConstructorObject::DOMConstructorObject):
* bindings/js/JSDOMWrapper.h:
(WebCore::JSDOMWrapper::JSDOMWrapper):
* bindings/scripts/CodeGeneratorJS.pm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Evan Martin <evan@chromium.org>
evan@chromium.org [Tue, 26 Apr 2011 21:12:44 +0000 (21:12 +0000)]
2011-04-26  Evan Martin  <evan@chromium.org>

        Reviewed by Tony Chang.

        [chromium] refactor duplicated list of test source files
        https://bugs.webkit.org/show_bug.cgi?id=59478

        The platform-specific unit test files were listed twice in
        WebKit.gyp: once for the components build, once for the normal
        build.  Refactor this into the unified webkit_unittest_files
        variable.  (It appears the omission of WebPageSerializerTest
        in one instance was an oversight.)

        * WebKit.gyp:
        * WebKit.gypi:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix build.
weinig@apple.com [Tue, 26 Apr 2011 21:06:28 +0000 (21:06 +0000)]
Fix build.

* bindings/js/JSDOMWrapper.h:
(WebCore::JSDOMWrapper::globalObject):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Robert Sesek <rsesek@chromium.org>
commit-queue@webkit.org [Tue, 26 Apr 2011 21:06:09 +0000 (21:06 +0000)]
2011-04-26  Robert Sesek  <rsesek@chromium.org>

        Reviewed by Dimitri Glazkov.

        [Chromium] Implement WebKit methods to assist with Cocoa NSTextInput implementation
        https://bugs.webkit.org/show_bug.cgi?id=54969

        * WebKit.gyp:
        * public/WebFrame.h:
        * public/WebWidget.h:
        * public/mac/WebSubstringUtil.h: Added.
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::firstRectForCharacterRange): Return the result rect in window coordinates
        (WebKit::WebFrameImpl::characterIndexForPoint): New method on WebFrame
        * src/WebFrameImpl.h:
        * src/WebPopupMenuImpl.cpp:
        (WebKit::WebPopupMenuImpl::compositionRange): New method on WebWidget; empty impl
        (WebKit::WebPopupMenuImpl::caretOrSelectionRange): New method on WebWidget; empty impl
        * src/WebPopupMenuImpl.h:
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::compositionRange): New method on WebWidget
        (WebKit::WebViewImpl::caretOrSelectionRange): New method on WebWidget
        * src/WebViewImpl.h:
        * src/mac/WebSubstringUtil.mm: Added.
        (WebKit::WebSubstringUtil::attributedSubstringInRange):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRoll r84945 back in with infinite recursion removed.
weinig@apple.com [Tue, 26 Apr 2011 21:01:00 +0000 (21:01 +0000)]
Roll r84945 back in with infinite recursion removed.

* bindings/js/JSDOMBinding.h:
(WebCore::DOMConstructorObject::DOMConstructorObject):
* bindings/js/JSDOMWrapper.h:
(WebCore::JSDOMWrapper::globalObject):
(WebCore::JSDOMWrapper::scriptExecutionContext):
(WebCore::JSDOMWrapper::createStructure):
(WebCore::JSDOMWrapper::JSDOMWrapper):
* bindings/scripts/CodeGeneratorJS.pm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Ryuan Choi <ryuan.choi@samsung.com>
commit-queue@webkit.org [Tue, 26 Apr 2011 20:58:03 +0000 (20:58 +0000)]
2011-04-26  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Martin Robinson.

        [GTK] Add proxy support to GtkLauncher
        https://bugs.webkit.org/show_bug.cgi?id=58852

        Add SOUP_TYPE_PROXY_RESOLVER_DEFAULT feature or set SOUP_SESSION_PROXY_URI for developers behind proxy.

        * GtkLauncher/main.c:
        (main):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Tue, 26 Apr 2011 20:46:57 +0000 (20:46 +0000)]
2011-04-26  Stephen White  <senorblanco@chromium.org>

        Unreviewed; test expectations update.

        * platform/chromium/test_expectations.txt:
        Mark a test that seems to be passing IMAGE CRASH (I don't trust it
        enough yet to remove the CRASH).

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRollout previous patch. It broke stuff.
weinig@apple.com [Tue, 26 Apr 2011 20:30:49 +0000 (20:30 +0000)]
Rollout previous patch. It broke stuff.

* bindings/js/JSDOMBinding.h:
(WebCore::JSDOMWrapperWithGlobalPointer::globalObject):
(WebCore::JSDOMWrapperWithGlobalPointer::scriptExecutionContext):
(WebCore::JSDOMWrapperWithGlobalPointer::createStructure):
(WebCore::JSDOMWrapperWithGlobalPointer::JSDOMWrapperWithGlobalPointer):
(WebCore::DOMConstructorObject::DOMConstructorObject):
* bindings/js/JSDOMWrapper.h:
(WebCore::JSDOMWrapper::JSDOMWrapper):
* bindings/scripts/CodeGeneratorJS.pm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Add Qt specific expected result for new test introduced in r84930.
ossy@webkit.org [Tue, 26 Apr 2011 20:24:07 +0000 (20:24 +0000)]
[Qt] Add Qt specific expected result for new test introduced in r84930.

* platform/qt/fast/loader/file-protocol-fragment-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove JSDOMWrapperWithGlobalPointer now that all JSDOMWrappers have global objects
weinig@apple.com [Tue, 26 Apr 2011 20:22:49 +0000 (20:22 +0000)]
Remove JSDOMWrapperWithGlobalPointer now that all JSDOMWrappers have global objects
https://bugs.webkit.org/show_bug.cgi?id=59310

Reviewed by Maciej Stachowiak.

* bindings/js/JSDOMBinding.h:
(WebCore::DOMConstructorObject::DOMConstructorObject):
* bindings/js/JSDOMWrapper.h:
(WebCore::JSDOMWrapper::globalObject):
(WebCore::JSDOMWrapper::scriptExecutionContext):
(WebCore::JSDOMWrapper::createStructure):
(WebCore::JSDOMWrapper::JSDOMWrapper):
Merge JSDOMWrapperWithGlobalPointer with JSDOMWrapper.

* bindings/scripts/CodeGeneratorJS.pm:
Make JSDOMWrapper the base class.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChoose the compiler based on the Xcode version for Snow Leopard debug builds.
mitz@apple.com [Tue, 26 Apr 2011 20:20:10 +0000 (20:20 +0000)]
Choose the compiler based on the Xcode version for Snow Leopard debug builds.

Reviewed by Mark Rowe.

Source/JavaScriptCore:

* Configurations/Base.xcconfig:
* Configurations/CompilerVersion.xcconfig: Added.

Source/JavaScriptGlue:

* Configurations/Base.xcconfig:
* Configurations/CompilerVersion.xcconfig: Added.

Source/ThirdParty/ANGLE:

* Configurations/Base.xcconfig:
* Configurations/CompilerVersion.xcconfig: Added.

Source/WebCore:

* Configurations/Base.xcconfig:
* Configurations/CompilerVersion.xcconfig: Added.

Source/WebKit/mac:

* Configurations/Base.xcconfig:
* Configurations/CompilerVersion.xcconfig: Added.

Source/WebKit2:

* Configurations/Base.xcconfig:
* Configurations/CompilerVersion.xcconfig: Added.

Tools:

* DumpRenderTree/mac/Configurations/Base.xcconfig:
* DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig: Added.
* MiniBrowser/Configurations/Base.xcconfig:
* MiniBrowser/Configurations/CompilerVersion.xcconfig: Added.
* TestWebKitAPI/Configurations/Base.xcconfig:
* TestWebKitAPI/Configurations/CompilerVersion.xcconfig: Added.
* WebKitTestRunner/Configurations/Base.xcconfig:
* WebKitTestRunner/Configurations/CompilerVersion.xcconfig: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoediting/text-iterator/findString.html passes on Leopard after r84750, so remove the...
jberlin@webkit.org [Tue, 26 Apr 2011 20:05:27 +0000 (20:05 +0000)]
editing/text-iterator/findString.html passes on Leopard after r84750, so remove the expected
failing results to get the bots green.

* platform/mac-leopard/editing/text-iterator/findString-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Windows Tests] media/invalid-media-url-crash.html failing since r84726.
jberlin@webkit.org [Tue, 26 Apr 2011 19:35:48 +0000 (19:35 +0000)]
[Windows Tests] media/invalid-media-url-crash.html failing since r84726.
https://bugs.webkit.org/show_bug.cgi?id=59324

The test is timing out on all of the Windows bots, so skip it to get them green.

* platform/win/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed.
antti@apple.com [Tue, 26 Apr 2011 19:05:00 +0000 (19:05 +0000)]
Not reviewed.

Add fast/loader/file-protocol-fragment.html to WebKit2 skip list
(uses layoutTestController.dumpResourceLoadCallbacks).

* platform/mac-wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Adrienne Walker <enne@google.com>
enne@google.com [Tue, 26 Apr 2011 18:58:38 +0000 (18:58 +0000)]
2011-04-26  Adrienne Walker  <enne@google.com>

        Reviewed by Geoffrey Garen.

        Use OwnArrayPtr<T> instead of OwnPtr<T*> in ScopeTracer
        https://bugs.webkit.org/show_bug.cgi?id=59469

        * platform/chromium/TraceEvent.h:
        (WebCore::internal::ScopeTracer::ScopeTracer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Tue, 26 Apr 2011 18:57:21 +0000 (18:57 +0000)]
2011-04-26  Stephen White  <senorblanco@chromium.org>

        Unreviewed; chromium test expectations update.

        * platform/chromium/test_expectations.txt:
        Tracking yet more flaky tests.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Dmitry Titov <dimich@chromium.org>
dimich@chromium.org [Tue, 26 Apr 2011 18:53:45 +0000 (18:53 +0000)]
2011-04-26  Dmitry Titov  <dimich@chromium.org>

        Reviewed by Darin Adler.

        Convert fast/frames/contentWindow_Frame.html and fast/frames/contentWindow_IFrame.html to 'dumpAsText'
        https://bugs.webkit.org/show_bug.cgi?id=59436

        * fast/frames/contentWindow_Frame-expected.txt: Added.
        * fast/frames/contentWindow_Frame.html:
        * fast/frames/contentWindow_iFrame-expected.txt: Added.
        * fast/frames/contentWindow_iFrame.html:
        * platform/chromium-linux/fast/frames/contentWindow_Frame-expected.png: Removed.
        * platform/chromium-linux/fast/frames/contentWindow_iFrame-expected.png: Removed.
        * platform/chromium-win/fast/frames/contentWindow_Frame-expected.png: Removed.
        * platform/chromium-win/fast/frames/contentWindow_Frame-expected.txt: Removed.
        * platform/chromium-win/fast/frames/contentWindow_iFrame-expected.png: Removed.
        * platform/chromium-win/fast/frames/contentWindow_iFrame-expected.txt: Removed.
        * platform/gtk/fast/frames/contentWindow_Frame-expected.txt: Removed.
        * platform/gtk/fast/frames/contentWindow_iFrame-expected.txt: Removed.
        * platform/mac-leopard/fast/frames/contentWindow_Frame-expected.png: Removed.
        * platform/mac-leopard/fast/frames/contentWindow_iFrame-expected.png: Removed.
        * platform/mac/fast/frames/contentWindow_Frame-expected.png: Removed.
        * platform/mac/fast/frames/contentWindow_Frame-expected.txt: Removed.
        * platform/mac/fast/frames/contentWindow_iFrame-expected.png: Removed.
        * platform/mac/fast/frames/contentWindow_iFrame-expected.txt: Removed.
        * platform/qt/fast/frames/contentWindow_Frame-expected.txt: Removed.
        * platform/qt/fast/frames/contentWindow_iFrame-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Finnur Thorarinsson <finnur.webkit@gmail.com>
commit-queue@webkit.org [Tue, 26 Apr 2011 18:44:34 +0000 (18:44 +0000)]
2011-04-26  Finnur Thorarinsson  <finnur.webkit@gmail.com>

        Reviewed by David Levin.

        Adding myself as a Chromium contributors to committers.py.

        https://bugs.webkit.org/show_bug.cgi?id=59444

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Tue, 26 Apr 2011 18:43:43 +0000 (18:43 +0000)]
2011-04-26  Stephen White  <senorblanco@chromium.org>

        Unreviewed; chromium test expectations update.

        * platform/chromium/test_expectations.txt:
        Add a few flaky tests.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Tue, 26 Apr 2011 18:31:33 +0000 (18:31 +0000)]
2011-04-26  Stephen White  <senorblanco@chromium.org>

        Unreviewed; chromium test expectations update.

        * platform/chromium/test_expectations.txt:
        Add failing expectations for new test introduced in r84930.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-25 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Tue, 26 Apr 2011 18:31:03 +0000 (18:31 +0000)]
2011-04-25  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Nixed special finalizer handling for WebCore strings
        https://bugs.webkit.org/show_bug.cgi?id=59425

        SunSpider reports no change.

        Not needed anymore, since weak handles have finalizers.

        * runtime/JSString.cpp:
        (JSC::JSString::resolveRope):
        (JSC::JSString::resolveRopeSlowCase):
        (JSC::JSString::outOfMemory):
        (JSC::JSString::substringFromRope):
        (JSC::JSString::replaceCharacter): Updated for removal of union.

        * runtime/JSString.h:
        (JSC::RopeBuilder::JSString):
        (JSC::RopeBuilder::~JSString):
        (JSC::RopeBuilder::appendStringInConstruct):
        (JSC::RopeBuilder::appendValueInConstructAndIncrementLength): No need for
        union or special constructor anymore.
2011-04-25  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Nixed special finalizer handling for WebCore strings
        https://bugs.webkit.org/show_bug.cgi?id=59425

        Not needed anymore, since weak handles have finalizers.

        * WebCore.exp.in: Exports!

        * bindings/js/DOMWrapperWorld.cpp:
        (WebCore::JSStringOwner::finalize):
        (WebCore::DOMWrapperWorld::DOMWrapperWorld): Use a weak handle finalizer,
        so we don't need special treatment anymore.

        * bindings/js/DOMWrapperWorld.h:
        (WebCore::JSStringOwner::JSStringOwner):
        (WebCore::DOMWrapperWorld::stringWrapperOwner): Use a HashMap of Weak<T>
        instead of a WeakGCMap, so we can specify a custom finalizer.

        * bindings/js/JSDOMBinding.cpp:
        (WebCore::jsStringSlowCase):
        * bindings/js/JSDOMBinding.h:
        (WebCore::jsString): Updated for string map change.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 26 Apr 2011 18:23:21 +0000 (18:23 +0000)]
2011-04-26  Adam Barth  <abarth@webkit.org>

        Reviewed by David Levin.

        Moar strict OwnPtr fixes for WebKit/chromium
        https://bugs.webkit.org/show_bug.cgi?id=59437

        This patch fixes all but two strict OwnPtr issues in WebKit/chromium.

        * src/WebDataSourceImpl.cpp:
        (WebKit::WebDataSourceImpl::setExtraData):
        (WebKit::WebDataSourceImpl::setNextPluginLoadObserver):
        (WebKit::WebDataSourceImpl::WebDataSourceImpl):
        * src/WebDataSourceImpl.h:
        * src/WebDevToolsAgentImpl.cpp:
        (WebKit::WebDevToolsAgentImpl::attach):
        (WebKit::WebDevToolsAgentImpl::detach):
        (WebKit::WebDevToolsAgent::interruptAndDispatch):
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::printBegin):
        * src/WebMediaPlayerClientImpl.cpp:
        (WebKit::createWebMediaPlayer):
        (WebKit::WebMediaPlayerClientImpl::loadInternal):
        * src/WebSpeechInputControllerMockImpl.cpp:
        (WebKit::WebSpeechInputControllerMockImpl::WebSpeechInputControllerMockImpl):
        * src/WebStorageEventDispatcherImpl.cpp:
        (WebKit::WebStorageEventDispatcherImpl::WebStorageEventDispatcherImpl):
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::WebViewImpl):
        (WebKit::WebViewImpl::settings):
        (WebKit::WebViewImpl::applyAutoFillSuggestions):
        (WebKit::WebView::addUserScript):
        (WebKit::WebView::addUserStyleSheet):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<http://webkit.org/b/59372> Restore user default for enabling HTTP pipelining
ddkilzer@apple.com [Tue, 26 Apr 2011 18:13:11 +0000 (18:13 +0000)]
<webkit.org/b/59372> Restore user default for enabling HTTP pipelining

Reviewed by Antti Koivisto.

To enable HTTP pipelining post-SnowLeopard, use this command:

    defaults write BUNDLE.ID WebKitEnableHTTPPipelining -bool YES

* platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::readBooleanPreference): Re-added.  Originally added in
r76756 and removed in r84120.
(WebCore::initializeMaximumHTTPConnectionCountPerHost): Enable
HTTP pipelining if use default is set to true.  Added macro
guards to match those in ResourceRequestMac.mm.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Tue, 26 Apr 2011 18:03:58 +0000 (18:03 +0000)]
2011-04-26  Daniel Bates  <dbates@webkit.org>

        Add expected results for GTK and Qt ports for the test panScroll-click-hyperlink.html
        (added in <http://trac.webkit.org/changeset/84922>).

        * platform/gtk/fast/events/panScroll-click-hyperlink-expected.txt: Added; expected
          failure results since this port doesn't build with pan scrolling enabled.
        * platform/qt-win/fast: Added.
        * platform/qt-win/fast/events: Added.
        * platform/qt-win/fast/events/panScroll-click-hyperlink-expected.txt: Added.
        * platform/qt/fast/events/panScroll-click-hyperlink-expected.txt: Added; expected
          failure results since the port for the Linux platform doesn't build with pan scrolling
          enabled.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Don't strip fragments from file: urls in memory cache
antti@apple.com [Tue, 26 Apr 2011 17:56:25 +0000 (17:56 +0000)]
Source/WebCore: Don't strip fragments from file: urls in memory cache
https://bugs.webkit.org/show_bug.cgi?id=59463
<rdar://problem/9231130>

Reviewed by Adele Peterson.

Some clients expect file: resources to be unique based on fragment identifier.
Limit the changes in http://trac.webkit.org/changeset/74107 to the HTTP protocol only

Test: fast/loader/file-protocol-fragment.html

* loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::removeFragmentIdentifierIfNeeded):

LayoutTests: Don't strip fragments from file: urls in memory cache
https://bugs.webkit.org/show_bug.cgi?id=59463

Reviewed by Adele Peterson.

* fast/loader/file-protocol-fragment-expected.txt: Added.
* fast/loader/file-protocol-fragment.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Tue, 26 Apr 2011 17:40:35 +0000 (17:40 +0000)]
2011-04-26  Stephen White  <senorblanco@chromium.org>

        Unreviewed; chromium test expectations update.

        * platform/chromium/test_expectations.txt:
        Added expectations for new test
        fast/events/panScroll-click-hyperlink.html.  Added a flaky test.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Siddharth Mathur <siddharth.mathur@nokia.com>
yi.4.shen@nokia.com [Tue, 26 Apr 2011 17:33:14 +0000 (17:33 +0000)]
2011-04-26  Siddharth Mathur  <siddharth.mathur@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Build fix: QtDeclarative Webview element has a fixed white background
        https://bugs.webkit.org/show_bug.cgi?id=40918

        Macro Q_REVISION and associated qdeclarativeitem.h signals are not available in 4.7.3 headers in Nokia Qt SDK.

        * declarative/plugin.cpp: Bump up required version to 4.7.4+
        (WebKitQmlPlugin::registerTypes):
        * declarative/qdeclarativewebview.cpp: ditto
        * declarative/qdeclarativewebview_p.h: ditto
        * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: ditto

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Tue, 26 Apr 2011 17:22:55 +0000 (17:22 +0000)]
2011-04-26  Stephen White  <senorblanco@chromium.org>

        Unreviewed; chromium test expectations update.

        * platform/chromium/test_expectations.txt:
        Add some failing and flaky tests.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 26 Apr 2011 17:21:42 +0000 (17:21 +0000)]
2011-04-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        DumpRenderTree/chromium should play nice with strict OwnPtrs
        https://bugs.webkit.org/show_bug.cgi?id=59458

        All these changes are pretty straight forward.

        * DumpRenderTree/chromium/CppBoundClass.cpp:
        (GetterPropertyCallback::GetterPropertyCallback):
        (CppBoundClass::bindGetterCallback):
        * DumpRenderTree/chromium/CppBoundClass.h:
        (CppBoundClass::bindProperty):
        (CppBoundClass::bindFallbackCallback):
        (CppBoundClass::bindFallbackMethod):
        * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
        (DRTDevToolsClient::DRTDevToolsClient):
        * DumpRenderTree/chromium/TestEventPrinter.cpp:
        (TestEventPrinter::createDRTPrinter):
        (TestEventPrinter::createTestShellPrinter):
        * DumpRenderTree/chromium/TestEventPrinter.h:
        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::TestShell):
        (TestShell::createMainWindow):
        (TestShell::createDRTDevToolsClient):
        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::geolocationClientMock):
        (WebViewHost::speechInputController):
        (WebViewHost::deviceOrientationClientMock):
        (WebViewHost::reset):
        (WebViewHost::navigate):
        (WebViewHost::setPendingExtraData):
        (WebViewHost::canvas):
        * DumpRenderTree/chromium/WebViewHost.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 26 Apr 2011 17:19:20 +0000 (17:19 +0000)]
2011-04-26  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Adam Roben.

        Fix path to transition-test-helpers.js in a test that is skipped
        on Mac but not Windows.

        * compositing/animation/animated-composited-inside-hidden.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake DRT/win log loading errors the same way DRT/mac does
aroben@apple.com [Tue, 26 Apr 2011 17:16:36 +0000 (17:16 +0000)]
Make DRT/win log loading errors the same way DRT/mac does

Fixes <http://webkit.org/b/59303> [Windows WebKit1 Tests]
http/tests/misc/will-send-request-returns-null-on-redirect.html failing since r84742

Reviewed by Alexey Proskuryakov.

* DumpRenderTree/win/ResourceLoadDelegate.cpp:
(ResourceLoadDelegate::descriptionSuitableForTestResult): Removed the workaround for
<rdar://problem/5064234>, which has long since been fixed, and then made this function match
-[NSError(DRTExtras) _drt_descriptionSuitableForTestResult] more closely.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix more strict OwnPtr in WebCore (round N).
levin@chromium.org [Tue, 26 Apr 2011 17:16:27 +0000 (17:16 +0000)]
Fix more strict OwnPtr in WebCore (round N).
https://bugs.webkit.org/show_bug.cgi?id=59464

Reviewed by Darin Adler.

* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::attach):
* fileapi/FileReader.cpp:
(WebCore::FileReader::terminate):
* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::preflightFailure):
* workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerConnectTask::create):
(WebCore::SharedWorkerScriptLoader::load):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Tue, 26 Apr 2011 17:12:12 +0000 (17:12 +0000)]
2011-04-26  Daniel Bates  <dbates@rim.com>

        Reviewed by Adam Barth.

        Add layout test to ensure we don't regress clicking when exiting pan scrolling
        https://bugs.webkit.org/show_bug.cgi?id=58702

        On ports that build with PAN_SCROLLING enabled (includes all Windows ports at
        the time of writing), ensure that a mouse click is ignored when in pan scroll mode.

        This test is expected to fail on ports either built with PAN_SCROLLING disabled
        or don't support pan scrolling. In particular, this test is expected to fail on
        the Apple Mac and Chromium Mac port.

        * fast/events/panScroll-click-hyperlink.html: Added.
        * platform/mac/fast/events/panScroll-click-hyperlink-expected.txt: Added.
        * platform/win/fast/events/panScroll-click-hyperlink-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Ruben <chromium@hybridsource.org>
tony@chromium.org [Tue, 26 Apr 2011 17:09:04 +0000 (17:09 +0000)]
2011-04-26  Ruben  <chromium@hybridsource.org>

        Reviewed by Tony Chang.

        Change linux ifdefs for Chromium to Unix instead, allowing
        new Unix ports to be enabled by default
        https://bugs.webkit.org/show_bug.cgi?id=59297

        No new tests, just changing preprocessor defines.

        * bindings/js/JSInspectorFrontendHostCustom.cpp:
        * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
        * dom/SelectElement.cpp:
        * loader/cache/CachedFont.cpp:
        * page/EventHandler.cpp:
        * page/chromium/EventHandlerChromium.cpp:
        * platform/Scrollbar.cpp:
        * platform/chromium/PlatformBridge.h:
        * platform/graphics/chromium/FontPlatformData.h:
        * platform/graphics/skia/FontCustomPlatformData.cpp:
        * platform/graphics/skia/FontCustomPlatformData.h:
2011-04-26  Ruben  <chromium@hybridsource.org>

        Reviewed by Tony Chang.

        Change linux ifdefs for Chromium to Unix instead, allowing
        new Unix ports to be enabled by default
        https://bugs.webkit.org/show_bug.cgi?id=59297

        * src/PlatformBridge.cpp:
        * src/WebFrameImpl.cpp:
        * src/WebViewImpl.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 John Knottenbelt <jknotten@chromium.org>
jknotten@chromium.org [Tue, 26 Apr 2011 17:01:41 +0000 (17:01 +0000)]
2011-04-26  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by Ojan Vafai.

        [Chromium] Adjust expectation for animations/play-state.html
        https://bugs.webkit.org/show_bug.cgi?id=59441

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 26 Apr 2011 16:40:12 +0000 (16:40 +0000)]
2011-04-26  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Dan Bernstein.

        [RTL] Arabic/AB - after typing a date, cursors doesn't go back
        https://bugs.webkit.org/show_bug.cgi?id=49111

        Added a test to move left and right within Arabic numerals and Arabic letters.

        We still fail to set the position offset properly when we moving to the left from before B
        to before A in "ABC123" (logical order) in a LTR block where ABC and 123 are Arabic letters
        and numerals respectively. This bug is to be fixed in the followup bugs.

        * editing/selection/move-left-right-expected.txt:
        * editing/selection/move-left-right.html:
2011-04-26  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Dan Bernstein.

        [RTL] Arabic/AB - after typing a date, cursors doesn't go back
        https://bugs.webkit.org/show_bug.cgi?id=49111

        Even when the offset corresponds to a position visually left of the box
        and there aren't any inline boxes on the left, the previous/next position
        may still correspond to some position in the same line.

        The bug was caused by our ignoring such cases. Fixed the bug by comparing
        previous/next position's inline box to the current box. If they match,
        then we stay on the same position because moving to the left visually at
        the left edge should not result in a position on the same line.

        Also fixed a bug that WebKit uses offsets that are not extrema when moved to
        the left edge or to the right edge, and a bug that WebKit could not move to
        the left from 12^3 CBA abc to 123 C^BA abc (there is no offset between 3 and C).

        Test cases are added to editing/selection/move-left-right.html

        * editing/VisiblePosition.cpp:
        (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
        (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Tue, 26 Apr 2011 16:30:44 +0000 (16:30 +0000)]
2011-04-26  Stephen White  <senorblanco@chromium.org>

        Unreviewed; chromium test_expectations update.

        Updated expectations for newly-failing tests.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Tue, 26 Apr 2011 16:00:37 +0000 (16:00 +0000)]
2011-04-26  Stephen White  <senorblanco@chromium.org>

        Unreviewed; chromium test_expectations update.

        Remove duplicate expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Tue, 26 Apr 2011 15:36:30 +0000 (15:36 +0000)]
2011-04-26  Stephen White  <senorblanco@chromium.org>

        Reviewed by Kenneth Russell.

        Partial revert of http://trac.webkit.org/changeset/84893, since it
        triggered a large number of layout test failures.
        https://bugs.webkit.org/show_bug.cgi?id=59459

        * src/GraphicsContext3DChromium.cpp:
        (WebCore::GraphicsContext3DInternal::initialize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (84876): build-webkit produces an error message
mitz@apple.com [Tue, 26 Apr 2011 15:32:10 +0000 (15:32 +0000)]
REGRESSION (84876): build-webkit produces an error message
https://bugs.webkit.org/show_bug.cgi?id=59460

* Scripts/webkitdirs.pm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Hans Wennborg <hans@chromium.org>
hans@chromium.org [Tue, 26 Apr 2011 15:13:10 +0000 (15:13 +0000)]
2011-04-26  Hans Wennborg  <hans@chromium.org>

        Reviewed by Tony Gentilcore.

        IndexedDB: Enable compile-time flag for LevelDB
        https://bugs.webkit.org/show_bug.cgi?id=59457

        Set ENABLE_LEVELDB=1 in features.gypi.

        * features.gypi:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Tue, 26 Apr 2011 15:11:47 +0000 (15:11 +0000)]
2011-04-26  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: disable failing inspector test while I'm finding a better way to test what it does.

        * http/tests/inspector-enabled/dom-storage-open.html-disabled: Renamed from LayoutTests/http/tests/inspector-enabled/dom-storage-open.html.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Tue, 26 Apr 2011 14:47:15 +0000 (14:47 +0000)]
2011-04-26  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Eric Seidel.

        Fix timestamp comparison in check-for-weak-vtables-and-externals
        https://bugs.webkit.org/show_bug.cgi?id=59416

        We should only re-run the check-for-weak-vtables-and-externals script
        if the executable is more recent than the last run.

        * Scripts/check-for-weak-vtables-and-externals:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Gabor Loki <loki@webkit.org>
loki@webkit.org [Tue, 26 Apr 2011 14:40:47 +0000 (14:40 +0000)]
2011-04-26  Gabor Loki  <loki@webkit.org>

        Reviewed by Csaba Osztrogonác.

        Speeding up SVG filters with multicore (SMP) support
        https://bugs.webkit.org/show_bug.cgi?id=43903

        Some SVG filters execute a huge number of pixel manipulations, which
        cannot be sped up by graphics accelerators, since their algorithm is
        too complex. Using the power of Symmetric Multi Processing (SMP) we
        can split up a task to smaller (data independent) tasks, which can be
        executed independently.

        The ParallelJobs framework provides a simple way for distributed
        programming. The framework is based on WebKit's threading infrastructure,
        Open Multi-Processing's (OpenMP) API, and libdispatch API.

        * GNUmakefile.list.am:
        * JavaScriptCore.vcproj/WTF/WTF.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * wtf/CMakeLists.txt:
        * wtf/ParallelJobs.h: Added.
        (WTF::ParallelJobs::ParallelJobs):
        (WTF::ParallelJobs::numberOfJobs):
        (WTF::ParallelJobs::parameterForJob):
        (WTF::ParallelJobs::executeJobs):
        * wtf/ParallelJobsGeneric.cpp: Added.
        (WTF::ParallelEnvironment::ThreadPrivate::tryLockFor):
        (WTF::ParallelEnvironment::ThreadPrivate::executeJob):
        (WTF::ParallelEnvironment::ThreadPrivate::waitForFinish):
        (WTF::ParallelEnvironment::ThreadPrivate::workerThread):
        * wtf/ParallelJobsGeneric.h: Added.
        (WTF::ParallelEnvironment::ParallelEnvironment):
        (WTF::ParallelEnvironment::numberOfJobs):
        (WTF::ParallelEnvironment::parameterForJob):
        (WTF::ParallelEnvironment::executeJobs):
        (WTF::ParallelEnvironment::ThreadPrivate::ThreadPrivate):
        (WTF::ParallelEnvironment::ThreadPrivate::create):
        * wtf/ParallelJobsLibdispatch.h: Added.
        (WTF::ParallelEnvironment::ParallelEnvironment):
        (WTF::ParallelEnvironment::numberOfJobs):
        (WTF::ParallelEnvironment::parameterForJob):
        (WTF::ParallelEnvironment::executeJobs):
        * wtf/ParallelJobsOpenMP.h: Added.
        (WTF::ParallelEnvironment::ParallelEnvironment):
        (WTF::ParallelEnvironment::numberOfJobs):
        (WTF::ParallelEnvironment::parameterForJob):
        (WTF::ParallelEnvironment::executeJobs):
        * wtf/Platform.h:
        * wtf/wtf.pri:
2011-04-26  Gabor Loki  <loki@webkit.org>

        Reviewed by Csaba Osztrogonác.

        Speeding up SVG filters with multicore (SMP) support
        https://bugs.webkit.org/show_bug.cgi?id=43903

        Some SVG filters execute a huge number of pixel manipulations, which
        cannot be sped up by graphics accelerators, since their algorithm is
        too complex. Using the power of Symmetric Multi Processing (SMP) we
        can split up a task to smaller (data independent) tasks, which can be
        executed independently.

        The ParallelJobs framework provides a simple way for distributed
        programming. The framework is based on WebKit's threading infrastructure,
        Open Multi-Processing's (OpenMP) API, and libdispatch API.

        * ForwardingHeaders/wtf/ParallelJobs.h: Added.
        * platform/graphics/filters/FETurbulence.cpp:
        (WebCore::FETurbulence::PaintingData::PaintingData):
        (WebCore::FETurbulence::noise2D):
        (WebCore::FETurbulence::calculateTurbulenceValueForPoint):
        (WebCore::FETurbulence::fillRegion):
        (WebCore::FETurbulence::fillRegionWorker):
        (WebCore::FETurbulence::apply):
        * platform/graphics/filters/FETurbulence.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Tue, 26 Apr 2011 14:27:23 +0000 (14:27 +0000)]
2011-04-26  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: close button is off in docked mode on a mac.
        https://bugs.webkit.org/show_bug.cgi?id=59453

        * inspector/front-end/inspector.css:
        (.toolbar-item.close-left):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Tue, 26 Apr 2011 14:23:59 +0000 (14:23 +0000)]
2011-04-26  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: New Style is not working (UI glitch)
        https://bugs.webkit.org/show_bug.cgi?id=59451

        * inspector/InspectorDOMStorageAgent.cpp:
        (WebCore::InspectorDOMStorageAgent::setFrontend):
        * inspector/front-end/AuditRules.js:
        (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
        (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.externalStylesheetsReceived):
        (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.inlineStylesReceived):
        (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.cssBeforeInlineReceived):
        (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.lateStylesReceived):
        * inspector/front-end/CSSStyleModel.js:
        (WebInspector.CSSStyleModel.prototype.setRuleSelector):
        (WebInspector.CSSStyleModel.prototype.setRuleSelector.callback):
        (WebInspector.CSSStyleModel.prototype.addRule):
        (WebInspector.CSSStyleModel.prototype.addRule.callback):
        (WebInspector.CSSStyleModel.prototype._documentElementId):
        * inspector/front-end/DOMAgent.js:
        (WebInspector.DOMNode.prototype._addAttribute):
        (WebInspector.DOMNode.prototype.documentElement):
        * inspector/front-end/ResourceTreeModel.js:
        (WebInspector.PageDispatcher.prototype.frameDetached):
        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylesSidebarPane.prototype._createNewRule):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build fix.
kbalazs@webkit.org [Tue, 26 Apr 2011 14:03:53 +0000 (14:03 +0000)]
Unreviewed build fix.

* Platform/Region.cpp: Need to include stdio.h for printf
(at least in my Qt-Linux environment).

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] layoutTestController.overridePreference() is already implemented.
ossy@webkit.org [Tue, 26 Apr 2011 13:36:01 +0000 (13:36 +0000)]
[Qt] layoutTestController.overridePreference() is already implemented.

Patch by Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu> on 2011-04-26
Reviewed by Csaba Osztrogonác.

* platform/qt/Skipped: Unskip now passing tests:
 - fast/events/pageshow-pagehide-on-back-cached.html
 - fast/events/pageshow-pagehide-on-back-cached-with-frames.html

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Implement LayoutTestController::setAutofilled
ossy@webkit.org [Tue, 26 Apr 2011 13:19:53 +0000 (13:19 +0000)]
[Qt] Implement LayoutTestController::setAutofilled
https://bugs.webkit.org/show_bug.cgi?id=59439

Patch by Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu> on 2011-04-26
Reviewed by Csaba Osztrogonác.

Source/WebKit/qt:

* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::setAutofilled):
* WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::setAutofilled):
* DumpRenderTree/qt/LayoutTestControllerQt.h:

LayoutTests:

* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Tue, 26 Apr 2011 12:25:05 +0000 (12:25 +0000)]
2011-04-26  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: introduce DOMStorage::enable and disable.
        https://bugs.webkit.org/show_bug.cgi?id=59445

        * inspector/Inspector.json:
        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::InspectorAgent):
        (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
        * inspector/InspectorDOMStorageAgent.cpp:
        (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
        (WebCore::InspectorDOMStorageAgent::restore):
        (WebCore::InspectorDOMStorageAgent::enable):
        (WebCore::InspectorDOMStorageAgent::disable):
        * inspector/InspectorDOMStorageAgent.h:
        (WebCore::InspectorDOMStorageAgent::create):
        * inspector/front-end/DOMStorage.js:
        (WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype._reset):
        * inspector/front-end/inspector.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Tue, 26 Apr 2011 11:35:42 +0000 (11:35 +0000)]
2011-04-26  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: extract Page agent dispatcher into the ResourceTreeModel.
        https://bugs.webkit.org/show_bug.cgi?id=59440

        * inspector/Inspector.json:
        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
        * inspector/InspectorPageAgent.cpp:
        (WebCore::InspectorPageAgent::setFrontend):
        (WebCore::InspectorPageAgent::frameNavigated):
        * inspector/InspectorPageAgent.h:
        * inspector/front-end/AuditsPanel.js:
        (WebInspector.AuditsPanel):
        (WebInspector.AuditsPanel.prototype._onLoadEventFired):
        (WebInspector.AuditsPanel.prototype._domContentLoadedEventFired):
        * inspector/front-end/CSSStyleModel.js:
        (WebInspector.CSSStyleModelResourceBinding):
        (WebInspector.CSSStyleModelResourceBinding.prototype._inspectedURLChanged):
        * inspector/front-end/DOMBreakpointsSidebarPane.js:
        (WebInspector.DOMBreakpointsSidebarPane):
        (WebInspector.DOMBreakpointsSidebarPane.prototype._inspectedURLChanged):
        * inspector/front-end/DOMStorage.js:
        (WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
        * inspector/front-end/ExtensionServer.js:
        (WebInspector.ExtensionServer.prototype._inspectedURLChanged):
        (WebInspector.ExtensionServer.prototype.initExtensions):
        * inspector/front-end/NetworkPanel.js:
        (WebInspector.NetworkPanel):
        (WebInspector.NetworkPanel.prototype._onLoadEventFired):
        (WebInspector.NetworkPanel.prototype._domContentLoadedEventFired):
        (WebInspector.NetworkPanel.prototype._frameNavigated):
        * inspector/front-end/ResourceTreeModel.js:
        (WebInspector.ResourceTreeModel):
        (WebInspector.ResourceTreeModel.prototype._processCachedResources):
        (WebInspector.ResourceTreeModel.prototype._dispatchInspectedURLChanged):
        (WebInspector.ResourceTreeModel.prototype._frameNavigated):
        (WebInspector.ResourceTreeModel.prototype._frameDetached):
        (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
        (WebInspector.PageDispatcher):
        (WebInspector.PageDispatcher.prototype.domContentEventFired):
        (WebInspector.PageDispatcher.prototype.loadEventFired):
        (WebInspector.PageDispatcher.prototype.frameNavigated):
        (WebInspector.PageDispatcher.prototype.frameDetached):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel):
        (WebInspector.ResourcesPanel.prototype._onLoadEventFired):
        (WebInspector.ResourcesPanel.prototype._frameNavigated):
        * inspector/front-end/inspector.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
ossy@webkit.org [Tue, 26 Apr 2011 11:31:59 +0000 (11:31 +0000)]
Unreviewed.

[WK2] editing/pasteboard/paste-before-tab-span.html introdueced in r84885, but
it doesn't work with WK2 because of missing eventSender.keyDown() implementation.

* platform/mac-wk2/Skipped: Add editing/pasteboard/paste-before-tab-span.html until fix.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 John Knottenbelt <jknotten@chromium.org>
jknotten@chromium.org [Tue, 26 Apr 2011 10:46:07 +0000 (10:46 +0000)]
2011-04-26  John Knottenbelt  <jknotten@chromium.org>

        Unreviewed.

        [Chromium] Remove passing tests from test_expectations.txt
        https://bugs.webkit.org/show_bug.cgi?id=59443

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed rollout r84877 and StyleRareInheritedData.cpp changes of r84892,
ossy@webkit.org [Tue, 26 Apr 2011 10:35:13 +0000 (10:35 +0000)]
Unreviewed rollout r84877 and StyleRareInheritedData.cpp changes of r84892,
because it broke transitions/multiple-text-shadow-transition.html

Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=59377

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* page/animation/AnimationBase.cpp:
(WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
(WebCore::PropertyWrapperShadow::blend):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setTextShadow):
(WebCore::RenderStyle::setBoxShadow):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::textShadow):
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::~StyleRareInheritedData):
* rendering/style/StyleRareInheritedData.h:
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Tue, 26 Apr 2011 10:08:15 +0000 (10:08 +0000)]
2011-04-26  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Adam Barth.

        Turn off make built-in implicit rules for derived sources makefile
        https://bugs.webkit.org/show_bug.cgi?id=59418

        We don't use any of make's built-in implicit rules, turning them off
        speeds up parsing of the makefile.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * gyp/generate-derived-sources.sh:
2011-04-26  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Adam Barth.

        Turn off make built-in implicit rules for derived sources makefile
        https://bugs.webkit.org/show_bug.cgi?id=59418

        We don't use any of make's built-in implicit rules, turning them off
        speeds up parsing of the makefile.

        * WebCore.xcodeproj/project.pbxproj:
        * gyp/generate-derived-sources.sh:
2011-04-26  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Adam Barth.

        Turn off make built-in implicit rules for derived sources makefile
        https://bugs.webkit.org/show_bug.cgi?id=59418

        We don't use any of make's built-in implicit rules, turning them off
        speeds up parsing of the makefile.

        * WebKit2.xcodeproj/project.pbxproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Leo Yang <leo.yang@torchmobile.com.cn>
leo.yang@torchmobile.com.cn [Tue, 26 Apr 2011 09:57:11 +0000 (09:57 +0000)]
2011-04-26  Leo Yang  <leo.yang@torchmobile.com.cn>

        Reviewed by Nikolas Zimmermann.

        ASSERT failure in SVGUseElement
        https://bugs.webkit.org/show_bug.cgi?id=59313

        Test case to verify webkit doesn't crash when a <use> element
        is pending on resource and the document is not well-formed.
        Test passes if no crash occurs in debug mode.

        * svg/custom/use-crash-in-non-wellformed-document-expected.txt: Added.
        * svg/custom/use-crash-in-non-wellformed-document.svg: Added.
2011-04-26  Leo Yang  <leo.yang@torchmobile.com.cn>

        Reviewed by Nikolas Zimmermann.

        ASSERT failure in SVGUseElement
        https://bugs.webkit.org/show_bug.cgi?id=59313

        In SVGUseElement::insertedIntoDocument(), ASSERT(!m_isPendingResource)
        was wrong because the document may not be well-formed.

        This patch asserts the element is not pending on resource or the
        document is not well-formed.

        Test: svg/custom/use-crash-in-non-wellformed-document.svg

        * svg/SVGUseElement.cpp:
        (WebCore::isWellFormedDocument):
        (WebCore::SVGUseElement::insertedIntoDocument):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Tue, 26 Apr 2011 09:41:57 +0000 (09:41 +0000)]
2011-04-26  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Fix columns resizing in the detailed heap snapshot grids.
        https://bugs.webkit.org/show_bug.cgi?id=59438

        * inspector/front-end/DetailedHeapshotView.js:
        (WebInspector.DetailedHeapshotView.prototype._changeView):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Chang Shu <cshu@webkit.org>
commit-queue@webkit.org [Tue, 26 Apr 2011 08:38:28 +0000 (08:38 +0000)]
2011-04-26  Chang Shu  <cshu@webkit.org>

        Reviewed by Sam Weinig.

        Convert fast/dom/keydown-1.html to dumpAsText test
        https://bugs.webkit.org/show_bug.cgi?id=59390

        * fast/events/keydown-1-expected.txt: Added.
        * fast/events/keydown-1.html:
        * platform/mac/fast/events/keydown-1-expected.png: Removed.
        * platform/mac/fast/events/keydown-1-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Tue, 26 Apr 2011 08:37:25 +0000 (08:37 +0000)]
2011-04-26  Carlos Garcia Campos  <cgarcia@igalia.com>

        Unreviewed. Fix WebKit2 GTK build after r84785.

        * UIProcess/gtk/WebInspectorGtk.cpp:
        (WebKit::WebInspectorProxy::platformAttach):
        (WebKit::WebInspectorProxy::platformDetach):
        (WebKit::WebInspectorProxy::platformSetAttachedWindowHeight):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Tue, 26 Apr 2011 08:33:49 +0000 (08:33 +0000)]
2011-04-26  Carlos Garcia Campos  <cgarcia@igalia.com>

        Unreviewed. Fix WebKit2 GTK build after r84886

        * Platform/gtk/RunLoopGtk.cpp: Include WorkItem.h

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-26 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Tue, 26 Apr 2011 08:31:24 +0000 (08:31 +0000)]
2011-04-26  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Chromium DevTools: recognize WebP as a valid mimetype in the Chromium port.
        https://bugs.webkit.org/show_bug.cgi?id=59332

        * src/js/DevTools.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84894 268f45cc-cd09-0410-ab3c-d52691b4dbfc