kevino@webkit.org [Sat, 18 Sep 2010 22:52:49 +0000 (22:52 +0000)]
[wx] Build fix, fix use of wrong case in name.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67795
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 18 Sep 2010 22:48:44 +0000 (22:48 +0000)]
2010-09-18 Kwang Yul Seo <skyul@company100.net>
Reviewed by Andreas Kling.
[BREWMP] Wrong key code type in keyIdentifierForBrewKeyCode
https://bugs.webkit.org/show_bug.cgi?id=46005
The type of key code in Brew MP is uint16. Take uint16 instead of int16 in keyIdentifierForBrewKeyCode.
* platform/brew/PlatformKeyboardEventBrew.cpp:
(WebCore::keyIdentifierForBrewKeyCode):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67794
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sat, 18 Sep 2010 22:43:45 +0000 (22:43 +0000)]
2010-09-17 Mihai Parparita <mihaip@chromium.org>
Reviewed by James Robinson.
Remove passing animation tests from Chromium's test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=45996
Update Chromium test_expectations.txt to remove tests that now pass:
animations/animation-shorthand-removed.html, animations/
animation-shorthand.html, and transitions/inherit-other-props.html were
fixed by http://trac.webkit.org/changeset/67634.
transforms/2d/transform-value-types.html has not failed in the last
1,500 runs.
animations/animation-drt-api.html was most likely fixed by 66641 (it
hasn't failed in the last 1,500 runs either).
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67793
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 18 Sep 2010 21:47:04 +0000 (21:47 +0000)]
2010-09-18 Matthew Delaney <mdelaney@apple.com>
Reviewed by Oliver Hunt.
Canvas drawImage with source or destination widths/heights of -1 renders incorrectly.
https://bugs.webkit.org/show_bug.cgi?id=45976
* canvas/philip/tests/2d.drawImage.negativeOneDest-expected.txt: Added.
* canvas/philip/tests/2d.drawImage.negativeOneDest.html: Added. Tests that using -1
for the destination width/height renders correctly.
* canvas/philip/tests/2d.drawImage.negativeOneSource-expected.txt: Added.
* canvas/philip/tests/2d.drawImage.negativeOneSource.html: Added. Tests that using -1
for the source width/height renders correctly.
2010-09-18 Matthew Delaney <mdelaney@apple.com>
Reviewed by Oliver Hunt.
Canvas drawImage with source or destination widths/heights of -1 renders incorrectly.
https://bugs.webkit.org/show_bug.cgi?id=45976
Specifying a -1 width or height for either the source or destination rectangle in drawImage
get improperly drawn with -1 replaced as the corresponding image width or height. This was because
the value -1 was being passed around to signal non-specified widths and heights and thus was
interpreted lower down in the drawImage implementation which disallowed any calls that actually
wanted to use -1 as the widths or heights. Fixed this by moving the default logic up and not using
-1 in-band signaling to denote default behavior.
Tests: canvas/philip/tests/2d.drawImage.negativeOneDest.html
canvas/philip/tests/2d.drawImage.negativeOneSource.html
* platform/graphics/GraphicsContext.cpp: Removed -1 in-band signals and replaced cascased calls to have
the desired replaces for unspecified widths and heights earlier on.
* platform/graphics/GraphicsContext.h: Removed faulty default value.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67792
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sat, 18 Sep 2010 21:30:09 +0000 (21:30 +0000)]
2010-09-17 Eric Seidel <eric@webkit.org>
Unreviewed. Adding a shell script I use to run the
commit-queue. Now that multiple machines run the cq,
it makes sense to share the script between them.
* EWSTools/start-commit-queue.sh: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67791
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
msaboff@apple.com [Sat, 18 Sep 2010 21:04:15 +0000 (21:04 +0000)]
2010-09-18 Michael Saboff <msaboff@apple.com>
Reviewed by Gavin Barraclough.
Added code to unroll regular expressions containing ^.
Alternatives that begin with ^ are tagged during parsing
and rolled up in containing sub expression structs.
After parsing, a regular expression flagged as containing
a ^ (a.k.a. BOL) is processed further in optimizeBOL().
A copy of the disjunction is made excluding alternatives that
are rooted with BOL. The original alternatives are flagged
to only be executed once. The copy of the other alternatives are
added to the original expression.
In the case that all original alternatives are flagged, there
won't be any looping alternatives.
The JIT generator will emit code accordingly, executing the
original alternatives once and then looping over the
alternatives that aren't anchored with a BOL (if any).
https://bugs.webkit.org/show_bug.cgi?id=45787
* yarr/RegexCompiler.cpp:
(JSC::Yarr::RegexPatternConstructor::assertionBOL):
(JSC::Yarr::RegexPatternConstructor::atomParenthesesEnd):
(JSC::Yarr::RegexPatternConstructor::copyDisjunction):
(JSC::Yarr::RegexPatternConstructor::copyTerm):
(JSC::Yarr::RegexPatternConstructor::optimizeBOL):
(JSC::Yarr::compileRegex):
* yarr/RegexJIT.cpp:
(JSC::Yarr::RegexGenerator::generateDisjunction):
* yarr/RegexPattern.h:
(JSC::Yarr::PatternAlternative::PatternAlternative):
(JSC::Yarr::PatternAlternative::setOnceThrough):
(JSC::Yarr::PatternAlternative::onceThrough):
(JSC::Yarr::PatternDisjunction::PatternDisjunction):
(JSC::Yarr::RegexPattern::RegexPattern):
(JSC::Yarr::RegexPattern::reset):
2010-09-18 Michael Saboff <msaboff@apple.com>
Reviewed by Gavin Barraclough.
Added new tests to check for proper handling of ^ in multiline
regular expressions. Added as part of
https://bugs.webkit.org/show_bug.cgi?id=45787
* fast/js/regexp-bol-with-multiline-expected.txt: Added.
* fast/js/regexp-bol-with-multiline.html: Added.
* fast/js/script-tests/regexp-bol-with-multiline.js: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67790
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Sat, 18 Sep 2010 20:52:32 +0000 (20:52 +0000)]
2010-09-18 Dimitri Glazkov <dglazkov@chromium.org>
Remove duplicate expectations from platform/chromium-win-xp.
* platform/chromium-win-xp/css2.1/t1202-counter-09-b-expected.checksum: Removed.
* platform/chromium-win-xp/css2.1/t1202-counter-09-b-expected.png: Removed.
* platform/chromium-win-xp/css2.1/t1202-counters-09-b-expected.checksum: Removed.
* platform/chromium-win-xp/css2.1/t1202-counters-09-b-expected.png: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67789
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Sat, 18 Sep 2010 20:41:03 +0000 (20:41 +0000)]
2010-09-18 Patrick Gansterer <paroga@paroga.com>
Reviewed by Darin Adler.
Rename Wince files to WinCE
https://bugs.webkit.org/show_bug.cgi?id=37287
* wtf/unicode/Unicode.h:
* wtf/unicode/wince/UnicodeWinCE.cpp: Copied from JavaScriptCore/wtf/unicode/wince/UnicodeWince.cpp.
* wtf/unicode/wince/UnicodeWinCE.h: Copied from JavaScriptCore/wtf/unicode/wince/UnicodeWince.h.
* wtf/unicode/wince/UnicodeWince.cpp: Removed.
* wtf/unicode/wince/UnicodeWince.h: Removed.
* wtf/wince/FastMallocWinCE.h: Copied from JavaScriptCore/wtf/wince/FastMallocWince.h.
* wtf/wince/FastMallocWince.h: Removed.
2010-09-18 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Enable Platform Strategies on Qt
[Qt] Turn on PLATFORM_STRATEGIES
https://bugs.webkit.org/show_bug.cgi?id=45831
* WebCore.pro: Adding/removing implementation files
* platform/qt/Language.cpp: Added, WebCore::defaultLanguage() was
moved from platform/qt/Localizations.cpp
(WebCore::defaultLanguage): Moved from Localizations.cpp
* platform/qt/Localizations.cpp: Removed (code is now inside
WebCoreSupport/WebPlatformStrategies.cpp)
* plugins/qt/PluginDataQt.cpp: Removed (idem)
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67788
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 18 Sep 2010 20:15:52 +0000 (20:15 +0000)]
2010-09-18 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Enable Platform Strategies on Qt
[Qt] Turn on PLATFORM_STRATEGIES
https://bugs.webkit.org/show_bug.cgi?id=45831
* wtf/Platform.h: Enable Platform Strategies when building QtWebkit
2010-09-18 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Enable Platform Strategies on Qt
[Qt] Turn on PLATFORM_STRATEGIES
https://bugs.webkit.org/show_bug.cgi?id=45831
* WebCore.pro: Adding/removing implementation files
* platform/qt/Language.cpp: Added, WebCore::defaultLanguage() was
moved from platform/qt/Localizations.cpp
(WebCore::defaultLanguage): Moved from Localizations.cpp
* platform/qt/Localizations.cpp: Removed (code is now inside
WebCoreSupport/WebPlatformStrategies.cpp)
* plugins/qt/PluginDataQt.cpp: Removed (idem)
2010-09-18 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Enable Platform Strategies on Qt
[Qt] Turn on PLATFORM_STRATEGIES
https://bugs.webkit.org/show_bug.cgi?id=45831
* Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate): Initialize the PlatformStrategy
singleton.
* WebCoreSupport/WebPlatformStrategies.cpp: Added, code was moved
from platform/qt/Localizations.cpp and plugins/qt/PluginDataQt.cpp
(WebPlatformStrategies::initialize): create the singleton,
following the same "pattern" used by Mac and Win ports.
(WebPlatformStrategies::WebPlatformStrategies):
(WebPlatformStrategies::createPluginStrategy):
(WebPlatformStrategies::createLocalizationStrategy):
(WebPlatformStrategies::createVisitedLinkStrategy):
(WebPlatformStrategies::refreshPlugins):
(WebPlatformStrategies::getPluginInfo):
(WebPlatformStrategies::inputElementAltText):
(WebPlatformStrategies::resetButtonDefaultLabel):
(WebPlatformStrategies::searchableIndexIntroduction):
(WebPlatformStrategies::submitButtonDefaultLabel):
(WebPlatformStrategies::fileButtonChooseFileLabel):
(WebPlatformStrategies::fileButtonNoFileSelectedLabel):
(WebPlatformStrategies::contextMenuItemTagOpenLinkInNewWindow):
(WebPlatformStrategies::contextMenuItemTagDownloadLinkToDisk):
(WebPlatformStrategies::contextMenuItemTagCopyLinkToClipboard):
(WebPlatformStrategies::contextMenuItemTagOpenImageInNewWindow):
(WebPlatformStrategies::contextMenuItemTagDownloadImageToDisk):
(WebPlatformStrategies::contextMenuItemTagCopyImageToClipboard):
(WebPlatformStrategies::contextMenuItemTagOpenFrameInNewWindow):
(WebPlatformStrategies::contextMenuItemTagCopy):
(WebPlatformStrategies::contextMenuItemTagGoBack):
(WebPlatformStrategies::contextMenuItemTagGoForward):
(WebPlatformStrategies::contextMenuItemTagStop):
(WebPlatformStrategies::contextMenuItemTagReload):
(WebPlatformStrategies::contextMenuItemTagCut):
(WebPlatformStrategies::contextMenuItemTagPaste):
(WebPlatformStrategies::contextMenuItemTagNoGuessesFound):
(WebPlatformStrategies::contextMenuItemTagIgnoreSpelling):
(WebPlatformStrategies::contextMenuItemTagLearnSpelling):
(WebPlatformStrategies::contextMenuItemTagSearchWeb):
(WebPlatformStrategies::contextMenuItemTagLookUpInDictionary):
(WebPlatformStrategies::contextMenuItemTagOpenLink):
(WebPlatformStrategies::contextMenuItemTagIgnoreGrammar):
(WebPlatformStrategies::contextMenuItemTagSpellingMenu):
(WebPlatformStrategies::contextMenuItemTagShowSpellingPanel):
(WebPlatformStrategies::contextMenuItemTagCheckSpelling):
(WebPlatformStrategies::contextMenuItemTagCheckSpellingWhileTyping):
(WebPlatformStrategies::contextMenuItemTagCheckGrammarWithSpelling):
(WebPlatformStrategies::contextMenuItemTagFontMenu):
(WebPlatformStrategies::contextMenuItemTagBold):
(WebPlatformStrategies::contextMenuItemTagItalic):
(WebPlatformStrategies::contextMenuItemTagUnderline):
(WebPlatformStrategies::contextMenuItemTagOutline):
(WebPlatformStrategies::contextMenuItemTagWritingDirectionMenu):
(WebPlatformStrategies::contextMenuItemTagTextDirectionMenu):
(WebPlatformStrategies::contextMenuItemTagDefaultDirection):
(WebPlatformStrategies::contextMenuItemTagLeftToRight):
(WebPlatformStrategies::contextMenuItemTagRightToLeft):
(WebPlatformStrategies::contextMenuItemTagInspectElement):
(WebPlatformStrategies::searchMenuNoRecentSearchesText):
(WebPlatformStrategies::searchMenuRecentSearchesText):
(WebPlatformStrategies::searchMenuClearRecentSearchesText):
(WebPlatformStrategies::AXWebAreaText):
(WebPlatformStrategies::AXLinkText):
(WebPlatformStrategies::AXListMarkerText):
(WebPlatformStrategies::AXImageMapText):
(WebPlatformStrategies::AXHeadingText):
(WebPlatformStrategies::AXDefinitionListTermText):
(WebPlatformStrategies::AXDefinitionListDefinitionText):
(WebPlatformStrategies::AXButtonActionVerb):
(WebPlatformStrategies::AXRadioButtonActionVerb):
(WebPlatformStrategies::AXTextFieldActionVerb):
(WebPlatformStrategies::AXCheckedCheckBoxActionVerb):
(WebPlatformStrategies::AXUncheckedCheckBoxActionVerb):
(WebPlatformStrategies::AXMenuListActionVerb):
(WebPlatformStrategies::AXMenuListPopupActionVerb):
(WebPlatformStrategies::AXLinkActionVerb):
(WebPlatformStrategies::missingPluginText):
(WebPlatformStrategies::crashedPluginText):
(WebPlatformStrategies::multipleFileUploadText):
(WebPlatformStrategies::unknownFileSizeText):
(WebPlatformStrategies::imageTitle):
(WebPlatformStrategies::mediaElementLoadingStateText):
(WebPlatformStrategies::mediaElementLiveBroadcastStateText):
(WebPlatformStrategies::localizedMediaControlElementString):
(WebPlatformStrategies::localizedMediaControlElementHelpText):
(WebPlatformStrategies::localizedMediaTimeDescription):
(WebPlatformStrategies::validationMessageValueMissingText):
(WebPlatformStrategies::validationMessageTypeMismatchText):
(WebPlatformStrategies::validationMessagePatternMismatchText):
(WebPlatformStrategies::validationMessageTooLongText):
(WebPlatformStrategies::validationMessageRangeUnderflowText):
(WebPlatformStrategies::validationMessageRangeOverflowText):
(WebPlatformStrategies::validationMessageStepMismatchText):
(WebPlatformStrategies::isLinkVisited):
(WebPlatformStrategies::addVisitedLink):
* WebCoreSupport/WebPlatformStrategies.h: Added, based on Mac and Win
versions.
2010-09-18 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Enable Platform Strategies on Qt
[Qt] Turn on PLATFORM_STRATEGIES
https://bugs.webkit.org/show_bug.cgi?id=45831
* WebKit2.pro: Added Added WebPlatformStrategies.{cpp,h}
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67787
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 18 Sep 2010 19:33:23 +0000 (19:33 +0000)]
2010-09-18 Mike Lawther <mikelawther@chromium.org>
Reviewed by Nate Chapin.
Remove passing tests from chromium test_expectations
https://bugs.webkit.org/show_bug.cgi?id=45948
Removes tests the flakiness dashboard shows as having passed for a couple of weeks
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67786
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 18 Sep 2010 19:21:33 +0000 (19:21 +0000)]
2010-09-18 Patrick Gansterer <paroga@paroga.com>
Reviewed by Eric Seidel.
Move Plugin*None.cpp from CMakeLists.txt into CMakeListsEfl.txt
https://bugs.webkit.org/show_bug.cgi?id=45900
PluginDataNone.cpp and PluginViewNone.cpp are not used by all port.
Move them into plaform sepcific build system.
* CMakeLists.txt:
* CMakeListsEfl.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67785
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
wsiegrist@apple.com [Sat, 18 Sep 2010 19:03:54 +0000 (19:03 +0000)]
2010-09-18 William Siegrist <wsiegrist@apple.com>
Increase alternating row contract in result viewer.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67784
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Sat, 18 Sep 2010 18:16:35 +0000 (18:16 +0000)]
2010-09-18 Daniel Bates <dbates@rim.com>
Rubber-stamped by Sam Weinig.
REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
https://bugs.webkit.org/show_bug.cgi?id=42863
Fix some minor, non-visual typos that do not affect the test result.
* fast/css/preserve-user-specified-zoom-level-on-reload.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67783
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
krit@webkit.org [Sat, 18 Sep 2010 17:44:48 +0000 (17:44 +0000)]
2010-09-18 Mihai Parparita <mihaip@chromium.org>
Reviewed by Dirk Schulze.
fast/css/preserve-user-specified-zoom-level-on-reload.html does not clean up after itself
https://bugs.webkit.org/show_bug.cgi?id=46040
Delete the sessionStorage property that this test adds once it's complete.
Otherwise it fails when run with --iterations=2 and also causes a diff in
in fast/dom/prototype-inheritance-2.html (which runs after it).
* fast/css/preserve-user-specified-zoom-level-on-reload.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67782
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Sat, 18 Sep 2010 16:37:34 +0000 (16:37 +0000)]
2010-09-18 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Antonio Gomes.
[Qt] V8 port: Add FrameLoaderClientQt::allowScriptExtension()
https://bugs.webkit.org/show_bug.cgi?id=46034
r67749 added FrameLoaderClient::allowScriptExtension() (V8-specific)
Add a stub implementation that simply returns false for now.
* WebCoreSupport/FrameLoaderClientQt.h:
(WebCore::FrameLoaderClientQt::allowScriptExtension):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67781
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Sat, 18 Sep 2010 15:23:47 +0000 (15:23 +0000)]
2010-09-18 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Don't copy clip path to TransparencyLayer
https://bugs.webkit.org/show_bug.cgi?id=45965
We don't need to copy the GC's clip path to the TransparencyLayer since it will
clip anyway when ending the layer.
* platform/graphics/qt/TransparencyLayer.h:
(WebCore::TransparencyLayer::TransparencyLayer):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67780
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Sat, 18 Sep 2010 13:55:03 +0000 (13:55 +0000)]
2010-09-18 Patrick Gansterer <paroga@paroga.com>
Unreviewed.
[WINCE] Buildfix for FrameWince.cpp after r51353, r67762 and r67771.
* page/wince/FrameWince.cpp:
(WebCore::computePageRectsForFrame):
(WebCore::imageFromSelection):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67779
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Sat, 18 Sep 2010 12:19:09 +0000 (12:19 +0000)]
2010-09-18 Kent Tamura <tkent@chromium.org>
Unreviewed, a trivial change.
Run sort-Xcode-project-file.
* WebCore.xcodeproj/project.pbxproj:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67778
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sat, 18 Sep 2010 10:04:02 +0000 (10:04 +0000)]
REGRESSION (r67762): Over 160 layout tests failing due to incorrect zoom factors in subframes
https://bugs.webkit.org/show_bug.cgi?id=46031
Reviewed by Eric Seidel.
* page/Frame.cpp:
(WebCore::parentPageZoomFactor): Return the zoom factor of the parent frame.
(WebCore::parentTextZoomFactor): Ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67777
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sat, 18 Sep 2010 06:16:25 +0000 (06:16 +0000)]
Need a way to load data (as plain text) in a WKPage
<rdar://problem/
8424239>
Reviewed by Jon Honeycutt.
WebCore:
* WebCore.exp.in:
WebKit2:
* Shared/CoreIPCSupport/WebPageMessageKinds.h:
* UIProcess/API/C/WKPage.cpp:
(WKPageLoadHTMLString):
* UIProcess/API/C/WKPage.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadHTMLString):
* UIProcess/WebPageProxy.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::loadHTMLString):
(WebKit::WebPage::didReceiveMessage):
* WebProcess/WebPage/WebPage.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67776
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sat, 18 Sep 2010 05:34:21 +0000 (05:34 +0000)]
Replace all uses of WTF::String and WTF::AtomicString with
String and AtomicString.
Rubber-stamped by Anders Carlsson.
* Platform/Module.h:
* Shared/CommandLine.h:
(WebKit::CommandLine::operator[]):
* Shared/WebCoreArgumentCoders.h:
* Shared/WebEvent.h:
(WebKit::WebKeyboardEvent::WebKeyboardEvent):
(WebKit::WebKeyboardEvent::text):
(WebKit::WebKeyboardEvent::unmodifiedText):
(WebKit::WebKeyboardEvent::keyIdentifier):
(WebKit::WebKeyboardEvent::decode):
* Shared/WebNavigationDataStore.h:
* Shared/WebPreferencesStore.h:
* Shared/WebString.h:
(WebKit::WebString::create):
(WebKit::WebString::string):
(WebKit::WebString::WebString):
* Shared/WebURL.h:
(WebKit::WebURL::create):
(WebKit::WebURL::string):
(WebKit::WebURL::WebURL):
* UIProcess/API/C/WKAPICast.h:
(WebKit::toRef):
(WebKit::toURLRef):
(WebKit::toCopiedRef):
(WebKit::toCopiedURLRef):
(WebKit::toWTFString):
* UIProcess/API/C/WKContext.cpp:
(WKContextCreate):
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::nsStringFromWebCoreString):
* UIProcess/PageClient.h:
* UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::PluginInfoStore::setAdditionalPluginsDirectories):
* UIProcess/Plugins/PluginInfoStore.h:
* UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::PluginInfoStore::getPluginInfo):
(WebKit::PluginInfoStore::getMIMETypeForExtension):
* UIProcess/WebBackForwardListItem.h:
(WebKit::WebBackForwardListItem::create):
(WebKit::WebBackForwardListItem::setOriginalURL):
(WebKit::WebBackForwardListItem::originalURL):
(WebKit::WebBackForwardListItem::setURL):
(WebKit::WebBackForwardListItem::url):
(WebKit::WebBackForwardListItem::setTitle):
(WebKit::WebBackForwardListItem::title):
* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
(WebKit::WebContext::setAdditionalPluginsDirectory):
* UIProcess/WebContext.h:
(WebKit::WebContext::injectedBundlePath):
* UIProcess/WebContextInjectedBundleClient.h:
* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::didReceiveTitle):
* UIProcess/WebFrameProxy.h:
(WebKit::WebFrameProxy::url):
(WebKit::WebFrameProxy::provisionalURL):
* UIProcess/WebHistoryClient.h:
* UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::didReceiveTitleForFrame):
* UIProcess/WebLoaderClient.h:
* UIProcess/WebNavigationData.h:
(WebKit::WebNavigationData::title):
(WebKit::WebNavigationData::url):
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::pageTitle):
(WebKit::WebPageProxy::toolTip):
(WebKit::WebPageProxy::urlAtProcessExit):
* UIProcess/WebPolicyClient.h:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::getPluginHostConnection):
* UIProcess/WebProcessProxy.h:
* UIProcess/WebUIClient.h:
* WebProcess/InjectedBundle/InjectedBundle.h:
(WebKit::InjectedBundle::create):
(WebKit::InjectedBundle::setSandboxToken):
* WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::willPerformClientRedirectForFrame):
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
* WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
* WebProcess/Plugins/NPRuntimeObjectMap.h:
* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/Plugins/Netscape/NetscapePluginModule.h:
* WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:
(WebKit::NetscapePluginStream::start):
* WebProcess/Plugins/Netscape/NetscapePluginStream.h:
* WebProcess/Plugins/Plugin.h:
* WebProcess/Plugins/PluginController.h:
* WebProcess/Plugins/PluginView.h:
* WebProcess/WebCoreSupport/WebChromeClient.h:
* WebProcess/WebCoreSupport/WebContextMenuClient.h:
* WebProcess/WebCoreSupport/WebDragClient.h:
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::showCorrectionPanel):
* WebProcess/WebCoreSupport/WebEditorClient.h:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
* WebProcess/WebCoreSupport/WebInspectorClient.h:
* WebProcess/WebCoreSupport/WebPlatformStrategies.h:
* WebProcess/WebCoreSupport/WebSearchPopupMenu.cpp:
(WebKit::WebSearchPopupMenu::saveRecentSearches):
(WebKit::WebSearchPopupMenu::loadRecentSearches):
* WebProcess/WebCoreSupport/WebSearchPopupMenu.h:
* WebProcess/WebPage/WebFrame.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::runJavaScriptInMainFrame):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::registerURLSchemeAsEmptyDocument):
* WebProcess/WebProcess.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67775
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 18 Sep 2010 04:09:23 +0000 (04:09 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=46027, image on gamespot.com paginates without bringing its enclosing border along.
Reviewed by Sam Weinig.
Make sure that unsplittable objects like replaced elements propagate their pagination strut outward to the parent block
when appropriate. An image on a line did this, but a block-level image did not.
Added fast/multicol/image-inside-nested-blocks-with-border.html
WebCore:
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlockChild):
LayoutTests:
* fast/multicol/image-inside-nested-blocks-with-border-expected.txt: Added.
* fast/multicol/image-inside-nested-blocks-with-border.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67774
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Sat, 18 Sep 2010 03:38:02 +0000 (03:38 +0000)]
2010-09-17 Dimitri Glazkov <dglazkov@chromium.org>
Remove passing tests from expectations.
* platform/chromium/drt_expectations.txt: Removed tests that are now
consistently passing on Chromium Windows DRT.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67773
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Sat, 18 Sep 2010 02:59:25 +0000 (02:59 +0000)]
2010-09-17 Dimitri Glazkov <dglazkov@chromium.org>
Unreviewed, build fix.
Move calls from frameView->pageZoomFactor() to frame->pageZoomFactor().
* page/EventHandler.cpp:
(WebCore::EventHandler::handleTouchEvent): Removed a helper function,
added direct calls to frame->pageZoomFactor().
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67772
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 18 Sep 2010 02:13:48 +0000 (02:13 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=45993, convert printing to the new pagination model.
Reviewed by Simon Fraser.
WebCore:
Make printing store the page height in the RenderView and push that into the layout state to
use the new pagination model. The old pagination model is retained because it is still used
for embedded WebViews.
* page/FrameView.cpp:
(WebCore::FrameView::reset):
(WebCore::FrameView::layout):
(WebCore::FrameView::forceLayout):
(WebCore::FrameView::forceLayoutForPagination):
(WebCore::FrameView::adjustPageHeight):
* page/FrameView.h:
* page/PrintContext.cpp:
(WebCore::PrintContext::computePageRectsWithPageSizeInternal):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintChildren):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::calcHeight):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::paintReplaced):
* rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::paint):
* rendering/RenderVideo.cpp:
(WebCore::RenderVideo::paintReplaced):
* rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
(WebCore::RenderView::layout):
(WebCore::RenderView::paint):
(WebCore::RenderView::setBestTruncatedAt):
* rendering/RenderView.h:
(WebCore::RenderView::popLayoutState):
(WebCore::RenderView::pageHeight):
(WebCore::RenderView::setPageHeight):
(WebCore::RenderView::bestTruncatedAt):
(WebCore::RenderView::truncatedAt):
(WebCore::RenderView::setTruncatedAt):
(WebCore::RenderView::printRect):
(WebCore::RenderView::setPrintRect):
(WebCore::RenderView::pushLayoutState):
(WebCore::LayoutStateMaintainer::LayoutStateMaintainer):
(WebCore::LayoutStateMaintainer::push):
(WebCore::LayoutStateMaintainer::pop):
WebKit/mac:
Make printing store the page height in the RenderView and push that into the layout state to
use the new pagination model. The old pagination model is retained because it is still used
for embedded WebViews.
* WebView/WebHTMLView.mm:
(-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]):
LayoutTests:
Remove the overflow test, since the new model treats overflow:auto/scroll as unsplittable.
* printing/page-break-always-for-overflow-expected.txt: Removed.
* printing/page-break-always-for-overflow.html: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67771
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sat, 18 Sep 2010 02:09:08 +0000 (02:09 +0000)]
Canvas sizing ignores intrinsic size
https://bugs.webkit.org/show_bug.cgi?id=46024
Reviewed by Simon Fraser.
WebCore:
Updated fast/replaced/table-percent-height.html
* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::RenderEmbeddedObject): If this is used as a proxy
for <video>, behave like it has an intrinsic size (e.g. preserve aspect ratio when
width is auto and height is specified).
* rendering/RenderImage.cpp:
(WebCore::RenderImage::calcAspectRatioWidth): Changed to explicitly invoke
RenderBox::calcReplacedHeight(), now that RenderReplaced has its own implementation
which we don’t want.
(WebCore::RenderImage::calcAspectRatioHeight): Similarly with calcReplacedWidth().
* rendering/RenderImage.h:
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::RenderReplaced): Initialize m_hasIntrinsicSize.
(WebCore::lengthIsSpecified): Added this helper function, based on RenderImage’s
is{Width,Height}Specified().
(WebCore::RenderReplaced::calcReplacedWidth): Moved from RenderVideo all the way
up here so other replaced objects could use this logic.
(WebCore::RenderReplaced::calcReplacedHeight): Ditto.
(WebCore::RenderReplaced::calcAspectRatioWidth): Ditto.
(WebCore::RenderReplaced::calcAspectRatioHeight): Ditto.
(WebCore::RenderReplaced::calcPrefWidths): Replaced with the RenderImage version
of the logic.
(WebCore::RenderReplaced::setIntrinsicSize): Added an assertion.
* rendering/RenderReplaced.h:
(WebCore::RenderReplaced::minimumReplacedHeight): Promoted from private to protected
to allow RenderVideo to call through.
(WebCore::RenderReplaced::setHasIntrinsicSize): Added this setter.
* rendering/RenderVideo.cpp:
(WebCore::RenderVideo::updateIntrinsicSize): Factor zoom into the intrinsic size,
the way other RenderReplaced objects do.
(WebCore::RenderVideo::calcReplacedWidth): Invoke the RenderReplaced implementation,
which matches what used to be here, skipping over the RenderImage implementation.
(WebCore::RenderVideo::calcReplacedHeight): Ditto.
(WebCore::RenderVideo::minimumReplacedHeight): Ditto.
* rendering/RenderVideo.h:
LayoutTests:
* fast/replaced/table-percent-height-expected.txt: Updated.
* fast/replaced/table-percent-height.html: Changed to expect canvas to maintain
its intrinsic ratio.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67770
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Sat, 18 Sep 2010 01:06:59 +0000 (01:06 +0000)]
2010-09-17 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Imprecise tracking of variable capture leads to overly pessimistic creation of activations
https://bugs.webkit.org/show_bug.cgi?id=46020
The old logic for track free and captured variables would cause us
to decide we needed an activation in every function along the scope
chain between a variable capture and its declaration. We now track
captured variables precisely which requires a bit of additional work
The most substantial change is that the parsing routine needs to
be passed the list of function parameters when reparsing a function
as when reparsing we don't parse the function declaration itself only
its body.
* JavaScriptCore.exp:
* parser/JSParser.cpp:
(JSC::JSParser::Scope::Scope):
(JSC::JSParser::Scope::needsFullActivation):
We need to distinguish between use of a feature that requires
an activation and eval so we now get this additional flag.
(JSC::JSParser::Scope::collectFreeVariables):
(JSC::JSParser::Scope::getCapturedVariables):
We can't simply return the list of "capturedVariables" now as
is insufficiently precise, so we compute them instead.
(JSC::JSParser::popScope):
(JSC::jsParse):
(JSC::JSParser::JSParser):
(JSC::JSParser::parseProgram):
(JSC::JSParser::parseWithStatement):
(JSC::JSParser::parseTryStatement):
(JSC::JSParser::parseFunctionInfo):
(JSC::JSParser::parseFunctionDeclaration):
(JSC::JSParser::parseProperty):
(JSC::JSParser::parseMemberExpression):
* parser/JSParser.h:
* parser/Parser.cpp:
(JSC::Parser::parse):
* parser/Parser.h:
(JSC::Parser::parse):
* runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::checkSyntax):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
(JSC::FunctionExecutable::reparseExceptionInfo):
(JSC::EvalExecutable::reparseExceptionInfo):
(JSC::FunctionExecutable::fromGlobalCode):
Pass function parameters (if available) to the parser.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67769
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Sat, 18 Sep 2010 01:01:50 +0000 (01:01 +0000)]
The colors on the new build.webkit.org (after upgrading the master to 0.8.1) are
slightly harder to read, so this reverts the previous background colors for various
states, making it easier to read.
Reviewed by Jon Honeycutt.
* BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
(.success):
(.failure):
(.warnings):
(.exception):
(.start,.running,td.building):
(.offline,td.offline):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67768
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sat, 18 Sep 2010 01:00:10 +0000 (01:00 +0000)]
Build fix for platforms that compile Touch.
* dom/Touch.cpp:
(WebCore::contentsX):
(WebCore::contentsY):
Get zoom factor from Frame rather than FrameView.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67767
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sat, 18 Sep 2010 00:57:32 +0000 (00:57 +0000)]
2010-09-17 Adam Barth <abarth@webkit.org>
Remove Leopard specific expected results because these now match Snow
Leopard.
https://bugs.webkit.org/show_bug.cgi?id=38402
* platform/mac-leopard/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt: Removed.
* platform/mac-leopard/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt: Removed.
* platform/mac-leopard/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt: Removed.
* platform/mac-leopard/fast/multicol/span/span-as-immediate-columns-child-expected.txt: Removed.
* platform/mac-leopard/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67766
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sat, 18 Sep 2010 00:40:46 +0000 (00:40 +0000)]
Add IsFloatingPoint and IsArithmetic type traits
https://bugs.webkit.org/show_bug.cgi?id=46018
Reviewed by Sam Weinig.
* wtf/TypeTraits.h:
* wtf/TypeTraits.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67765
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sat, 18 Sep 2010 00:38:14 +0000 (00:38 +0000)]
2010-09-17 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r67692.
http://trac.webkit.org/changeset/67692
https://bugs.webkit.org/show_bug.cgi?id=46011
broke layout test dashboard (Requested by johnny_g on
#webkit).
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67764
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sat, 18 Sep 2010 00:34:04 +0000 (00:34 +0000)]
Fix Windows and Qt builds.
* Shared/qt/PlatformCertificateInfo.h:
(WebKit::PlatformCertificateInfo::decode):
* Shared/win/PlatformCertificateInfo.h:
(WebKit::PlatformCertificateInfo::decode):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67763
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sat, 18 Sep 2010 00:32:24 +0000 (00:32 +0000)]
2010-09-17 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
https://bugs.webkit.org/show_bug.cgi?id=42863
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::createPlugin):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setZoomLevel):
Call functions on Frame instead of FrameView.
2010-09-17 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
https://bugs.webkit.org/show_bug.cgi?id=42863
* Api/qwebframe.cpp:
(QWebFrame::setTextSizeMultiplier):
(QWebFrame::textSizeMultiplier):
(QWebFrame::setZoomFactor):
(QWebFrame::zoomFactor):
Call functions on Frame instead of FrameView.
2010-09-17 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
https://bugs.webkit.org/show_bug.cgi?id=42863
* webkit/webkitwebview.cpp:
(webkit_web_view_get_zoom_level):
(webkit_web_view_apply_zoom_level):
(webkit_web_view_set_full_content_zoom):
Call functions on Frame instead of FrameView.
2010-09-17 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
https://bugs.webkit.org/show_bug.cgi?id=42863
* WebView.cpp:
(WebView::setZoomMultiplier):
Call functions on Frame instead of FrameView.
2010-09-17 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
https://bugs.webkit.org/show_bug.cgi?id=42863
* WebFrame.cpp:
(wxWebFrame::IncreaseTextSize):
(wxWebFrame::DecreaseTextSize):
(wxWebFrame::ResetTextSize):
Call functions on Frame instead of FrameView.
2010-09-17 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
https://bugs.webkit.org/show_bug.cgi?id=42863
* WebView/WebView.mm:
(-[WebView _setZoomMultiplier:isTextOnly:]):
Call functions on Frame instead of FrameView.
2010-09-17 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
https://bugs.webkit.org/show_bug.cgi?id=42863
* ewk/ewk_frame.cpp:
(ewk_frame_zoom_get):
(ewk_frame_zoom_set):
(ewk_frame_zoom_text_only_set):
Call functions on Frame instead of FrameView.
2010-09-17 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
https://bugs.webkit.org/show_bug.cgi?id=42863
Moved zoom level back from FrameView to Frame.
I had forgotten that FrameView's lifetime is much shorter than
Frame's, and until that is fixed it's best to leave this on Frame.
* WebCore.exp.in: Updated.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::styleForDocument):
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
* dom/Document.cpp:
(WebCore::Document::nodesFromRect):
(WebCore::Document::elementFromPoint):
(WebCore::Document::caretRangeFromPoint):
* dom/MouseRelatedEvent.cpp:
(WebCore::contentsX):
(WebCore::contentsY):
(WebCore::pageZoomFactor):
* dom/Node.cpp:
(WebCore::Node::dispatchMouseEvent):
(WebCore::Node::dispatchWheelEvent):
* html/HTMLBodyElement.cpp:
(WebCore::adjustForZoom):
(WebCore::HTMLBodyElement::scrollLeft):
(WebCore::HTMLBodyElement::setScrollLeft):
(WebCore::HTMLBodyElement::scrollTop):
(WebCore::HTMLBodyElement::setScrollTop):
(WebCore::HTMLBodyElement::scrollHeight):
(WebCore::HTMLBodyElement::scrollWidth):
* html/ImageDocument.cpp:
(WebCore::pageZoomFactor):
(WebCore::ImageDocument::scale):
(WebCore::ImageDocument::imageFitsInWindow):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::innerHeight):
(WebCore::DOMWindow::innerWidth):
(WebCore::DOMWindow::scrollX):
(WebCore::DOMWindow::scrollY):
(WebCore::DOMWindow::scrollTo):
* page/DragController.cpp:
(WebCore::elementUnderMouse):
* rendering/RenderView.cpp:
(WebCore::RenderView::zoomFactor):
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::currentScale):
(WebCore::SVGSVGElement::setCurrentScale):
Get zoom factor from Frame rather than FrameView.
* page/Frame.cpp:
(WebCore::parentPageZoomFactor): Moved back here from FrameView.
(WebCore::parentTextZoomFactor): Ditto.
(WebCore::Frame::Frame): Ditto.
(WebCore::Frame::setPageZoomFactor): Ditto.
(WebCore::Frame::setTextZoomFactor): Ditto.
(WebCore::Frame::setPageAndTextZoomFactors): Ditto.
* page/Frame.h: Moved functions and data for zooming back here
from FrameView.
* page/FrameView.cpp:
(WebCore::FrameView::FrameView):
* page/FrameView.h:
Removed code from here.
2010-09-17 Daniel Bates <dbates@rim.com>
Reviewed by Darin Adler.
REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
https://bugs.webkit.org/show_bug.cgi?id=42863
* fast/css/preserve-user-specified-zoom-level-on-reload.html: Added.
* platform/mac/fast/css/preserve-user-specified-zoom-level-on-reload-expected.checksum: Added.
* platform/mac/fast/css/preserve-user-specified-zoom-level-on-reload-expected.png: Added.
* platform/mac/fast/css/preserve-user-specified-zoom-level-on-reload-expected.txt: Added.
2010-09-17 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
https://bugs.webkit.org/show_bug.cgi?id=42863
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::textZoomFactor):
(WebKit::WebPage::setTextZoomFactor):
(WebKit::WebPage::pageZoomFactor):
(WebKit::WebPage::setPageZoomFactor):
(WebKit::WebPage::setPageAndTextZoomFactors):
Call functions on Frame instead of FrameView.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67762
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sat, 18 Sep 2010 00:23:19 +0000 (00:23 +0000)]
Resize corner jiggles when resizing slowly in WebKit2
<rdar://problem/
7897425>
https://bugs.webkit.org/show_bug.cgi?id=45601
Reviewed by Anders Carlsson.
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::windowResizerRect):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::windowResizerRect):
* WebProcess/WebPage/WebPage.h:
Move resize corner logic to WebPage and use the FrameView's size instead of the WebPages
stored size, which doesn't get updated at the right time. This is in line with all other
scrollbar metrics which are in terms of the FrameView's size.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67761
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sat, 18 Sep 2010 00:20:23 +0000 (00:20 +0000)]
Make certificate data available to the WKFrameRef after it is committed
Part of <rdar://problem/
8350189>
https://bugs.webkit.org/show_bug.cgi?id=45998
Reviewed by Anders Carlsson.
* Shared/APIObject.h:
Add new type.
* Shared/WebCertificateInfo.h: Added.
(WebKit::WebCertificateInfo::create):
(WebKit::WebCertificateInfo::platformCertificateInfo):
(WebKit::WebCertificateInfo::WebCertificateInfo):
(WebKit::WebCertificateInfo::type):
Add API type for vending.
* Shared/mac/PlatformCertificateInfo.h: Added.
(WebKit::PlatformCertificateInfo::peerCertificates):
* Shared/mac/PlatformCertificateInfo.mm: Added.
(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::encode):
(WebKit::PlatformCertificateInfo::decode):
(WebKit::PlatformCertificateInfo::dump):
* Shared/qt/PlatformCertificateInfo.h: Added.
(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::encode):
(WebKit::PlatformCertificateInfo::decode):
* Shared/win/PlatformCertificateInfo.h: Added.
(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::encode):
(WebKit::PlatformCertificateInfo::decode):
Add platform specific holder for certificate data and encode/decode functions
to send it over the wire. Right now, this only implemented for the mac.
* UIProcess/API/C/WKAPICast.h:
* UIProcess/API/C/WKBase.h:
* UIProcess/API/C/WKCertificateInfo.cpp: Added.
(WKCertificateInfoGetTypeID):
* UIProcess/API/C/WKCertificateInfo.h: Added.
Add wrapper for WebCertificateInfo.
* UIProcess/API/C/WKFrame.cpp:
(WKFrameGetCertificateInfo):
* UIProcess/API/C/WKFrame.h:
Add getter for a WKCertificateInfo.
* UIProcess/API/C/mac/WKCertificateInfoMac.h: Added.
* UIProcess/API/C/mac/WKCertificateInfoMac.mm: Added.
(WKCertificateInfoGetPeerCertificates):
Add mac specific getters for the platform specific certificate
data.
* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::setCertificateInfo):
* UIProcess/WebFrameProxy.h:
(WebKit::WebFrameProxy::certificateInfo):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didCommitLoadForFrame):
* UIProcess/WebPageProxy.h:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
Pipe the certificate info through to the WebFrameProxy on
commit.
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
* win/WebKit2Generated.make:
Add new files.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67760
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Sat, 18 Sep 2010 00:09:35 +0000 (00:09 +0000)]
2010-09-17 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] 16 more chromium linux baselines (scrollbars change)
https://bugs.webkit.org/show_bug.cgi?id=46009
* platform/chromium-linux/tables/mozilla/bugs/bug137388-2-expected.checksum:
* platform/chromium-linux/tables/mozilla/bugs/bug137388-2-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug2479-1-expected.checksum:
* platform/chromium-linux/tables/mozilla/bugs/bug2479-1-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug29314-expected.checksum:
* platform/chromium-linux/tables/mozilla/bugs/bug29314-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug2997-expected.checksum:
* platform/chromium-linux/tables/mozilla/bugs/bug2997-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug32205-2-expected.checksum:
* platform/chromium-linux/tables/mozilla/bugs/bug32205-2-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug3977-expected.checksum:
* platform/chromium-linux/tables/mozilla/bugs/bug3977-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug43854-1-expected.checksum:
* platform/chromium-linux/tables/mozilla/bugs/bug43854-1-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug650-expected.checksum:
* platform/chromium-linux/tables/mozilla/bugs/bug650-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug73321-expected.checksum:
* platform/chromium-linux/tables/mozilla/bugs/bug73321-expected.png:
* platform/chromium-linux/tables/mozilla/core/captions-expected.checksum:
* platform/chromium-linux/tables/mozilla/core/captions-expected.png:
* platform/chromium-linux/tables/mozilla/core/cell_heights-expected.checksum:
* platform/chromium-linux/tables/mozilla/core/cell_heights-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-expected.checksum:
* platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-expected.checksum:
* platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.checksum:
* platform/chromium-linux/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.png:
* platform/chromium-linux/tables/mozilla/other/nestedTables-expected.checksum:
* platform/chromium-linux/tables/mozilla/other/nestedTables-expected.png:
* platform/chromium-linux/tables/mozilla/other/test3-expected.checksum:
* platform/chromium-linux/tables/mozilla/other/test3-expected.png:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67759
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 17 Sep 2010 23:23:17 +0000 (23:23 +0000)]
2010-09-17 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Reduce minimum DOMTimer interval
https://bugs.webkit.org/show_bug.cgi?id=45362
Reduced the minimum allowed DOMTimer interval to 4ms. This has us matching Chrome,
which hasn't had any problem with 4ms in the past 2 years, as well as increasing our
performance on perf tests that have tight frequent loops such as canvas "animation"
performance tests.
No new tests added. Can't reliably instrument a test in javascript to verify that
the minimum clamped interval time is in fact 4ms.
* WebCore.exp.in:
* page/DOMTimer.cpp: Removed old comments.
* page/DOMTimer.h: Removed old comments.
* page/Settings.cpp: Exposted new method to set minimum DOMTimer interval.
* page/Settings.h:
2010-09-17 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Reduce minimum DOMTimer interval
https://bugs.webkit.org/show_bug.cgi?id=45362
* WebView/WebView.mm: Added in a call to set the mimimum allowed DOMTimer to 4ms.
2010-09-17 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Reduce minimum DOMTimer interval
https://bugs.webkit.org/show_bug.cgi?id=45362
* WebView.cpp: Added in a call to set the mimimum allowed DOMTimer to 4ms.
2010-09-17 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Reduce minimum DOMTimer interval
https://bugs.webkit.org/show_bug.cgi?id=45362
* WebProcess/WebPage/WebPage.cpp: Added in a call to set the mimimum allowed DOMTimer to 4ms.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67758
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbr@google.com [Fri, 17 Sep 2010 23:12:35 +0000 (23:12 +0000)]
2010-09-17 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
[chromium] Roll forward Chromium DEPS to pick up Mesa DRT changes
https://bugs.webkit.org/show_bug.cgi?id=46006
* DEPS:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67757
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 17 Sep 2010 22:50:20 +0000 (22:50 +0000)]
Versioning.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67756
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 17 Sep 2010 22:48:42 +0000 (22:48 +0000)]
CoreIPC argument coder improvements
https://bugs.webkit.org/show_bug.cgi?id=45999
Reviewed by Sam Weinig.
* Platform/CoreIPC/ArgumentCoders.h:
Add explicit specialization for a vector of bytes.
* Platform/CoreIPC/Arguments.h:
(CoreIPC::Arguments1::decode):
(CoreIPC::Arguments2::decode):
(CoreIPC::Arguments3::decode):
(CoreIPC::Arguments4::decode):
(CoreIPC::Arguments5::decode):
(CoreIPC::Arguments6::decode):
Use the injected class name for less typing.
(CoreIPC::Arguments7::Arguments7):
(CoreIPC::Arguments7::encode):
(CoreIPC::Arguments7::decode):
(CoreIPC::In):
(CoreIPC::Out):
Add Arguments7 class.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67754
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Fri, 17 Sep 2010 22:43:42 +0000 (22:43 +0000)]
2010-09-17 Tony Chang <tony@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] rebaseline tests that are only scrollbar differences on Linux
https://bugs.webkit.org/show_bug.cgi?id=46000
* platform/chromium-linux/css1/basic/containment-expected.checksum:
* platform/chromium-linux/css1/basic/containment-expected.png:
* platform/chromium-linux/css1/box_properties/padding_right-expected.checksum:
* platform/chromium-linux/css1/box_properties/padding_right-expected.png:
* platform/chromium-linux/css1/font_properties/font_size-expected.checksum:
* platform/chromium-linux/css1/font_properties/font_size-expected.png:
* platform/chromium-linux/fast/block/float/nested-clearance-expected.checksum:
* platform/chromium-linux/fast/block/float/nested-clearance-expected.png:
* platform/chromium-linux/fast/block/positioning/051-expected.checksum:
* platform/chromium-linux/fast/block/positioning/051-expected.png:
* platform/chromium-linux/fast/block/positioning/055-expected.checksum:
* platform/chromium-linux/fast/block/positioning/055-expected.png:
* platform/chromium-linux/fast/forms/select-change-listbox-size-expected.checksum:
* platform/chromium-linux/fast/forms/select-change-listbox-size-expected.png:
* platform/chromium-linux/fast/frames/iframe-scrolling-attribute-expected.checksum:
* platform/chromium-linux/fast/frames/iframe-scrolling-attribute-expected.png:
* platform/chromium-linux/fast/multicol/positioned-with-constrained-height-expected.checksum:
* platform/chromium-linux/fast/multicol/positioned-with-constrained-height-expected.png:
* platform/chromium-linux/fast/repaint/overflow-scroll-delete-expected.checksum:
* platform/chromium-linux/fast/repaint/overflow-scroll-delete-expected.png:
* platform/chromium-linux/http/tests/navigation/error404-frames-expected.checksum:
* platform/chromium-linux/http/tests/navigation/error404-frames-expected.png:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67753
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbr@google.com [Fri, 17 Sep 2010 22:36:16 +0000 (22:36 +0000)]
2010-09-17 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
[chromium] Add mesa as DumpRenderTree dependency
https://bugs.webkit.org/show_bug.cgi?id=46001
* WebKit.gyp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67752
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 17 Sep 2010 22:23:22 +0000 (22:23 +0000)]
2010-09-17 Marc-Antoine Ruel <maruel@chromium.org>
Reviewed by Dimitri Glazkov.
[Chromium] Split webcore_platform off webcore_remaining
Further reduce webcore_remaining size by moving platform/ code in its
own static libary.
https://bugs.webkit.org/show_bug.cgi?id=45915
* WebCore.gyp/WebCore.gyp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67751
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 17 Sep 2010 21:59:09 +0000 (21:59 +0000)]
2010-09-17 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Martin Robinson.
http/tests/security/xss-DENIED-mime-type-execute-as-html.html fails
https://bugs.webkit.org/show_bug.cgi?id=37540
* platform/gtk/Skipped: test works fine after the fix for
https://bugs.webkit.org/show_bug.cgi?id=45377
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67750
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mpcomplete@chromium.org [Fri, 17 Sep 2010 21:57:37 +0000 (21:57 +0000)]
2010-09-13 Matt Perry <mpcomplete@chromium.org>
Reviewed by Darin Fisher.
Have V8DOMWindowShell ask the embedder whether to run a V8 extension
in a particular script context.
https://bugs.webkit.org/show_bug.cgi?id=45721
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::createNewContext):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::registeredExtensionWithV8):
(WebCore::V8Proxy::registerExtension):
* bindings/v8/V8Proxy.h:
* loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::allowScriptExtension):
* loader/FrameLoaderClient.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67749
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Fri, 17 Sep 2010 21:50:23 +0000 (21:50 +0000)]
2010-09-17 Andy Estes <aestes@apple.com>
Reviewed by Darin Adler.
<rdar://problem/
8440903> WK2: REGRESSION (r66156): Web sites using
AppleConnect fail to log in: "HTTP Status 404 - /ssowebapp/scriptFrame"
https://bugs.webkit.org/show_bug.cgi?id=45960
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createPlugin):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67748
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 17 Sep 2010 21:47:00 +0000 (21:47 +0000)]
2010-09-17 Mihai Parparita <mihaip@chromium.org>
Reviewed by Dimitri Glazkov.
http/tests/navigation/post-goback1.html should not be a pixel test
https://bugs.webkit.org/show_bug.cgi?id=45834
Convert post-goback1.html to be a simpler dumpAsText test. It can use
the form-target.pl that was added r67466 with some small modifications.
To be extra safe, clear the back forward list for all the tests that
were converted to use dumpAsText.
* http/tests/navigation/post-basic.html:
* http/tests/navigation/post-frames.html:
* http/tests/navigation/post-goback1-expected.txt: Added.
* http/tests/navigation/post-goback1.html:
* http/tests/navigation/resources/form-target.pl:
* http/tests/navigation/resources/go-back.html: Added.
* platform/chromium-linux/http/tests/navigation/post-goback1-expected.checksum: Removed.
* platform/chromium-linux/http/tests/navigation/post-goback1-expected.png: Removed.
* platform/chromium-win/http/tests/navigation/post-goback1-expected.checksum: Removed.
* platform/chromium-win/http/tests/navigation/post-goback1-expected.png: Removed.
* platform/chromium/test_expectations.txt:
* platform/mac/http/tests/navigation/post-goback1-expected.checksum: Removed.
* platform/mac/http/tests/navigation/post-goback1-expected.png: Removed.
* platform/mac/http/tests/navigation/post-goback1-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67747
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 17 Sep 2010 21:29:27 +0000 (21:29 +0000)]
REGRESSION (r66711): Plug-in replacement text is never shown
https://bugs.webkit.org/show_bug.cgi?id=45997
<rdar://problem/
8446766>
Reviewed by Sam Weinig.
Don't return when the plug-in has replacement text.
* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::paintReplaced):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67746
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric.carlson@apple.com [Fri, 17 Sep 2010 21:27:14 +0000 (21:27 +0000)]
2010-09-17 Eric Carlson <eric.carlson@apple.com>
Rubber-stamped by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=45983
* platform/win/Skipped: Skip media-can-play-mpeg4-video.html.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67745
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Fri, 17 Sep 2010 20:42:25 +0000 (20:42 +0000)]
2010-09-17 James Robinson <jamesr@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] Unskip the canvas philip suite
https://bugs.webkit.org/show_bug.cgi?id=45991
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67744
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 17 Sep 2010 20:27:44 +0000 (20:27 +0000)]
Reviewed, tweaked, and landed by Anders Carlsson.
Patch by Sam Weinig <sam@webkit.org> on 2010-09-17
Add WKCopyNSURLResponsePeerCertificates.
* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67743
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Fri, 17 Sep 2010 20:11:26 +0000 (20:11 +0000)]
Make WebNumbers immutable matching CF.
Reviewed by Anders Carlsson.
* Shared/WebNumber.h:
(WebKit::WebNumber::value):
(WebKit::WebNumber::WebNumber):
* UIProcess/API/C/WKNumber.cpp:
(WKUInt64GetValue):
* UIProcess/API/C/WKNumber.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67741
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Fri, 17 Sep 2010 20:04:47 +0000 (20:04 +0000)]
Remove unimplemented destructor declaration to fix Chromium build.
https://bugs.webkit.org/show_bug.cgi?id=45987
Patch by Eric Uhrhane <ericu@chromium.org> on 2010-09-17
Reviewed by David Levin.
* src/AsyncFileWriterChromium.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67740
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Fri, 17 Sep 2010 20:01:10 +0000 (20:01 +0000)]
<webkit.org/b/45989> Add WebArchiveInternal.h to Xcode project
Reviewed by Joseph Pecoraro.
* WebKit.xcodeproj/project.pbxproj: Added missing
WebArchiveInternal.h header file to the project. It has been
missing since r31281!
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67739
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Fri, 17 Sep 2010 19:35:33 +0000 (19:35 +0000)]
Add bool wrapper for WebKit2 API
https://bugs.webkit.org/show_bug.cgi?id=45985
Reviewed by John Sullivan.
* Shared/APIObject.h:
* Shared/WebNumber.h:
* UIProcess/API/C/WKAPICast.h:
* UIProcess/API/C/WKBase.h:
* UIProcess/API/C/WKNumber.cpp:
(WKBooleanGetTypeID):
(WKBooleanCreate):
(WKBooleanGetValue):
(WKBooleanSetValue):
* UIProcess/API/C/WKNumber.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67738
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jianli@chromium.org [Fri, 17 Sep 2010 19:25:08 +0000 (19:25 +0000)]
Skip the new test fast/files/create-blob-url-crash.html in unsupported
platforms.
* platform/gtk/Skipped:
* platform/mac-wk2/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67737
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
demarchi@webkit.org [Fri, 17 Sep 2010 19:07:50 +0000 (19:07 +0000)]
2010-09-17 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Unreviewed, build fix. Add files missed in r67704.
* CMakeLists.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67736
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 17 Sep 2010 19:00:03 +0000 (19:00 +0000)]
2010-09-17 Simon Fraser <simon.fraser@apple.com>
Reviewed by Chris Marrin.
Remove scroll and clip layers for WKCACFLayerRenderer
https://bugs.webkit.org/show_bug.cgi?id=45922
WKCACFLayerRenderer no longer needs its own layers for managing scrolling
and clipping, because RenderLayerCompositor provides this functionality.
* platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
(WebCore::MediaPlayerPrivateFullscreenWindow::setRootChildLayer): Remove call to setScrollFrame().
(WebCore::MediaPlayerPrivateFullscreenWindow::wndProc): Ditto.
* platform/graphics/win/WKCACFLayerRenderer.cpp: Remove references to scroll and clip layers
(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer):
(WebCore::WKCACFLayerRenderer::setRootChildLayer):
(WebCore::WKCACFLayerRenderer::destroyRenderer):
(WebCore::WKCACFLayerRenderer::resize):
* platform/graphics/win/WKCACFLayerRenderer.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::layerTreeAsText): Dump the layers from the root platform layer.
(WebCore::RenderLayerCompositor::requiresScrollLayer): On Windows,
always say yes.
2010-09-17 Simon Fraser <simon.fraser@apple.com>
Reviewed by Chris Marrin.
Remove scroll and clip layers for WKCACFLayerRenderer
https://bugs.webkit.org/show_bug.cgi?id=45922
WKCACFLayerRenderer no longer needs its own layers for managing scrolling
and clipping, because RenderLayerCompositor provides this functionality.
* WebView.cpp:
(WebView::sizeChanged): Moved code that handles the WM_SIZE message
into this method. Use it to resize the layer renderer.
(WebView::WebViewWndProc): Call sizeChanged().
(WebView::updateRootLayerContents): No need to call setScrollFrame() any more.
(WebView::layerRendererBecameVisible): Move this from the header (no need to be inline).
* WebView.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67735
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jianli@chromium.org [Fri, 17 Sep 2010 18:59:15 +0000 (18:59 +0000)]
createBlobURL with no argument causes crash.
https://bugs.webkit.org/show_bug.cgi?id=45880
Reviewed by Dmitry Titov.
WebCore:
The fix is to check if the passing blob argument is NULL or not.
Test: fast/files/create-blob-url-crash.html
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::createPublicBlobURL):
* page/DOMWindow.idl: Add attribute to convert null string to undefined.
LayoutTests:
* fast/files/create-blob-url-crash-expected.txt: Added.
* fast/files/create-blob-url-crash.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67734
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cmarrin@apple.com [Fri, 17 Sep 2010 18:35:46 +0000 (18:35 +0000)]
2010-09-17 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
Add WebKitAccelerated2dCanvasEnabled flag to WebKit for Mac
https://bugs.webkit.org/show_bug.cgi?id=45911
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67731
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Fri, 17 Sep 2010 18:34:37 +0000 (18:34 +0000)]
Fix the bug number in the ChangeLog.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67730
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Fri, 17 Sep 2010 18:32:40 +0000 (18:32 +0000)]
Skip some userscripts tests that are flaky on Windows (but pass on Mac),
this needs investigation, and is being tracked by <http://webkit.org/b/44199>.
Rubber-stamped by Adam Roben.
* platform/win/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67729
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 17 Sep 2010 18:04:20 +0000 (18:04 +0000)]
2010-09-17 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
ASSERTION FAILED: m_loadEventDelayCount
https://bugs.webkit.org/show_bug.cgi?id=45790
* dom/AsyncScriptRunner.cpp:
(WebCore::AsyncScriptRunner::timerFired): Protect document before we go running scripts.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67728
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
senorblanco@chromium.org [Fri, 17 Sep 2010 18:01:34 +0000 (18:01 +0000)]
2010-09-17 Stephen White <senorblanco@chromium.org>
Reviewed by Kenneth Russell.
[CHROMIUM] GPU-accelerated canvas should work in test_shell.
https://bugs.webkit.org/show_bug.cgi?id=45968
In order for the shaders in GPU-accelerated canvas to work in both the
GraphicsContext3D / GLES2 path as well as chromium's test_shell (which
passes them to the Mesa backend unmodified), the precision specifiers
in the fragment shader have to be wrapped in #if GL_ES.
Soon to be covered by many layout tests.
* platform/graphics/gpu/SolidFillShader.cpp:
(WebCore::SolidFillShader::create):
* platform/graphics/gpu/TexShader.cpp:
(WebCore::TexShader::create):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67727
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
wsiegrist@apple.com [Fri, 17 Sep 2010 18:00:08 +0000 (18:00 +0000)]
2010-09-17 William Siegrist <wsiegrist@apple.com>
Replaces branches option with ChangeFilter since branches is now deprecated.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67726
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Fri, 17 Sep 2010 17:47:59 +0000 (17:47 +0000)]
2010-09-17 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] [REGRESSION] Listbox rendering is incorrect
https://bugs.webkit.org/show_bug.cgi?id=45941
Only apply the shadow tiling optimization to a layer if the GraphicsContext
has a shadow.
This is covered by manual-tests/select-element-type-select.html.
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::drawBorderlessRectShadow): Before applying the tiled shadow optimization
first check to see if the context has a shadow at all.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67725
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Fri, 17 Sep 2010 17:42:17 +0000 (17:42 +0000)]
2010-09-17 Martin Robinson <mrobinson@igalia.com>
Reviewed by Oliver Hunt.
[GTK] FontPlatformDataFreeType should use smart pointers to hold its members
https://bugs.webkit.org/show_bug.cgi?id=45917
Added support to PlatformRefPtr for handling HashTableDeletedValue.
* wtf/PlatformRefPtr.h:
(WTF::PlatformRefPtr::PlatformRefPtr): Added a constructor that takes HashTableDeletedValue.
(WTF::PlatformRefPtr::isHashTableDeletedValue): Added.
2010-09-17 Martin Robinson <mrobinson@igalia.com>
Reviewed by Oliver Hunt.
[GTK] FontPlatformDataFreeType should use smart pointers to hold its members
https://bugs.webkit.org/show_bug.cgi?id=45917
Have FontPlatformDataFreeType use smart pointers to hold its reference-counted
members. Also move the FcPattern specialization from OwnPtrCairo to PlatformRefPtrCairo
as this type is reference-counted.
No new tests as this should not introduce any functionality changes.
* platform/graphics/cairo/FontCacheFreeType.cpp:
(WebCore::FontCache::getFontDataForCharacters): Updated to reflect smart pointer changes.
(WebCore::FontCache::createFontPlatformData): Ditto.
* platform/graphics/cairo/FontPlatformDataFreeType.cpp:
(WebCore::FontPlatformData::FontPlatformData): Ditto.
(WebCore::FontPlatformData::operator=): Ditto.
(WebCore::FontPlatformData::~FontPlatformData): Ditto.
(WebCore::FontPlatformData::isFixedPitch): Ditto.
(WebCore::FontPlatformData::operator==): Ditto.
* platform/graphics/cairo/FontPlatformDataFreeType.h:
(WebCore::FontPlatformData::FontPlatformData): Ditto.
(WebCore::FontPlatformData::scaledFont): Ditto.
(WebCore::FontPlatformData::hash): Ditto.
(WebCore::FontPlatformData::isHashTableDeletedValue): Ditto.
* platform/graphics/cairo/GlyphPageTreeNodeCairo.cpp:
(WebCore::GlyphPage::fill): Ditto.
* platform/graphics/cairo/OwnPtrCairo.cpp: Removed FcPattern specialization.
* platform/graphics/cairo/OwnPtrCairo.h: Ditto.
* platform/graphics/cairo/PlatformRefPtrCairo.cpp: Added FcPattern and cairo_scaled_font_t specializations.
(WTF::refPlatformPtr): Ditto.
(WTF::derefPlatformPtr): Ditto.
* platform/graphics/cairo/PlatformRefPtrCairo.h: Ditto.
* platform/graphics/cairo/SimpleFontDataCairo.cpp:
(WebCore::SimpleFontData::platformInit): Updated to reflect smart pointer changes.
(WebCore::SimpleFontData::containsCharacters): Ditto.
(WebCore::SimpleFontData::platformWidthForGlyph): Ditto.
* platform/graphics/gtk/FontGtk.cpp:
(WebCore::setPangoAttributes): Ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67724
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 17 Sep 2010 17:40:35 +0000 (17:40 +0000)]
Land new Windows results for fast/forms/file-input-disabled.html
This corresponds to the changes made in r64712.
Rubber-stamped by John Sullivan.
* platform/win/fast/forms/file-input-disabled-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67723
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Fri, 17 Sep 2010 17:20:13 +0000 (17:20 +0000)]
2010-09-17 Martin Robinson <mrobinson@igalia.com>
Reviewed by Oliver Hunt.
Style bot complains about cairo forward declaration naming
https://bugs.webkit.org/show_bug.cgi?id=45867
Exclude Cairo forward declarations from indentifiers with underscores checks.
* Scripts/webkitpy/style/checkers/cpp.py: Add exclusion for Cairo forward-declarations.
* Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67722
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 17 Sep 2010 17:16:10 +0000 (17:16 +0000)]
2010-09-14 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: show status message below call stack when debugger is paused on DOM breakpoint
https://bugs.webkit.org/show_bug.cgi?id=45114
* English.lproj/localizedStrings.js:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::performSearch):
(WebCore::InspectorDOMAgent::shouldBreakOnNodeInsertion):
(WebCore::InspectorDOMAgent::shouldBreakOnNodeRemoval):
(WebCore::InspectorDOMAgent::shouldBreakOnAttributeModification):
(WebCore::InspectorDOMAgent::descriptionForDOMEvent):
* inspector/InspectorDOMAgent.h:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::didPause):
* inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane):
(WebInspector.CallStackSidebarPane.prototype.updateStatus.formatters.s):
(WebInspector.CallStackSidebarPane.prototype.updateStatus.append):
(WebInspector.CallStackSidebarPane.prototype.updateStatus):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.linkifyNodeById):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.debuggerPaused):
* inspector/front-end/inspector.css:
(.pane > .body .placard + .info):
* inspector/front-end/inspector.js:
(WebInspector.pausedScript):
(WebInspector.formatLocalized):
2010-09-14 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: show status message below call stack when debugger is paused on DOM breakpoint
https://bugs.webkit.org/show_bug.cgi?id=45114
* http/tests/inspector/inspector-test2.js:
(initialize_InspectorTest.InspectorTest.evaluateInPageWithTimeout):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67721
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonyg@chromium.org [Fri, 17 Sep 2010 17:02:56 +0000 (17:02 +0000)]
2010-09-16 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Adding a timeline screenshot for blocking and defer scripts
https://bugs.webkit.org/show_bug.cgi?id=45933
* blog-files/timeline-blocking-script.png: Added.
* blog-files/timeline-defer-script.png: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67720
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Fri, 17 Sep 2010 16:36:53 +0000 (16:36 +0000)]
2010-09-17 Johnny Ding <jnd@chromium.org>
Reviewed by Adam Barth.
Stop history reload navigation to bypass WebKit's popup blocker.
Now history reload can only navigate the page in self frame, no matter
what target frame is defined in <base> and no new window can be created.
https://bugs.webkit.org/show_bug.cgi?id=45369
Test: fast/events/popup-blocked-from-history-reload.html
* loader/RedirectScheduler.cpp:
(WebCore::ScheduledNavigation::ScheduledNavigation):
(WebCore::ScheduledNavigation::wasUserGesture):
Move the m_wasUserGesture to base class ScheduledNavigation. Then all
asynchronous navigation situations can restore the correct gesture state
during the real navigation process.
(WebCore::ScheduledURLNavigation::ScheduledURLNavigation):
(WebCore::ScheduledURLNavigation::fire):
(WebCore::ScheduledURLNavigation::referrer):
(WebCore::ScheduledHistoryNavigation::ScheduledHistoryNavigation):
(WebCore::ScheduledHistoryNavigation::fire):
(WebCore::ScheduledFormSubmission::ScheduledFormSubmission):
(WebCore::ScheduledFormSubmission::fire):
(WebCore::RedirectScheduler::scheduleHistoryNavigation):
2010-09-17 Johnny Ding <jnd@chromium.org>
Reviewed by Adam Barth.
Stop history reload navigation to bypass WebKit's popup blocker.
https://bugs.webkit.org/show_bug.cgi?id=45369
* fast/events/popup-blocked-from-history-reload-expected.txt: Added.
* fast/events/popup-blocked-from-history-reload.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67716
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zmo@google.com [Fri, 17 Sep 2010 16:30:52 +0000 (16:30 +0000)]
2010-09-17 Zhenyao Mo <zmo@google.com>
Unreviewed.
Add failing WebGL tests in drt_expectations.txt.
* platform/chromium/drt_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67715
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vangelis@chromium.org [Fri, 17 Sep 2010 16:27:41 +0000 (16:27 +0000)]
2010-09-16 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by James Robinson.
[chromium] Clip the update region of an ImageLayerChromium to actual size
of the image bitmap to prevent uninitialized memory access when uploading
the dirty region to the texture.
https://bugs.webkit.org/show_bug.cgi?id=45937
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::updateContents):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67714
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 17 Sep 2010 16:13:52 +0000 (16:13 +0000)]
2010-09-17 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by David Hyatt.
Remove extraneous RenderObject traversal.
https://bugs.webkit.org/show_bug.cgi?id=45821
This code always exits in the first iteration of the loop,
because in the context of this call, node->renderer()->node() != 0
is always true.
No behavior change, covered by existing tests.
* page/EventHandler.cpp:
(WebCore::EventHandler::canMouseDownStartSelect): Removed the loop.
(WebCore::EventHandler::canMouseDragExtendSelect): Ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67710
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 17 Sep 2010 16:02:25 +0000 (16:02 +0000)]
2010-09-17 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: FrameLoader::loadedResourceFromMemoryCache reports
resource as not cached to InspectorController.
https://bugs.webkit.org/show_bug.cgi?id=45961
There is one path in control flow that leads to resources being
reported as not cached. Patch to follow.
* inspector/InspectorController.cpp:
(WebCore::InspectorController::markResourceAsCached):
* inspector/InspectorController.h:
* inspector/InspectorResource.cpp:
(WebCore::InspectorResource::markAsCached):
(WebCore::InspectorResource::updateResponse):
* inspector/InspectorResource.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadedResourceFromMemoryCache):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67709
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 17 Sep 2010 15:52:52 +0000 (15:52 +0000)]
Land new Windows results for html5lib/runner.html
This corresponds to the changes made in r67233 and r67356.
Rubber-stamped by Anders Carlsson.
* platform/win/html5lib/runner-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67708
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 17 Sep 2010 15:38:03 +0000 (15:38 +0000)]
Add some tests failing due to unimplemented DRT APIs to the Windows Skipped file
* platform/win/Skipped: Added two tests which fail due to
already-known limitations of Windows DRT.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67707
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
wsiegrist@apple.com [Fri, 17 Sep 2010 15:11:49 +0000 (15:11 +0000)]
2010-09-17 William Siegrist <wsiegrist@apple.com>
Remove centering on results directory listing.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67706
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Fri, 17 Sep 2010 15:00:19 +0000 (15:00 +0000)]
2010-09-17 Alexander Pavlov <apavlov@chromium.org>
Unreviewed, build fix. Add files missed in the previous commit.
* GNUmakefile.am:
* css/CSSPropertySourceData.cpp: Added.
(WebCore::SourceRange::SourceRange):
(WebCore::SourceRange::operator=):
(WebCore::CSSPropertySourceData::CSSPropertySourceData):
(WebCore::CSSPropertySourceData::operator=):
(WebCore::CSSPropertySourceData::toString):
(WebCore::CSSPropertySourceData::hash):
(WebCore::CSSPropertySourceData::init):
* css/CSSPropertySourceData.h: Added.
(WebCore::CSSPropertySourceData::~CSSPropertySourceData):
(WebCore::CSSStyleSourceData::create):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67705
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Fri, 17 Sep 2010 14:37:27 +0000 (14:37 +0000)]
2010-09-15 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Provide source-based properties for style declarations to CSSParser clients
This change:
- Enables InspectorCSSStore to extract CSS stylesheet text for all source-based stylesheets,
even with the resource tracking turned off.
- Adds to CSSParser a capability of source-related style declaration data extraction:
* Start/end source offsets for a declaration, relative to the parent stylesheet start or the "style" attribute value.
* Start/end source offsets for CSS properties, relative to the declaration start.
* CSS property data: name, value, priority, WebCore parsability (i.e. if the property is understood by WebCore).
- Provides the extracted data to the WebInspector frontend via InspectorDOMAgent::getStyleSourceData().
https://bugs.webkit.org/show_bug.cgi?id=44949
WebCore:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSGrammar.y:
* css/CSSMutableStyleDeclaration.h:
(WebCore::CSSMutableStyleDeclaration::node):
* css/CSSParser.cpp:
(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::parseSheet):
(WebCore::CSSParser::parseDeclaration):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::markRuleBodyStart):
(WebCore::CSSParser::markPropertyStart):
(WebCore::CSSParser::markPropertyEnd):
* css/CSSParser.h:
(WebCore::CSSParser::resetPropertyMarks):
* css/CSSPropertySourceData.cpp: Added.
(WebCore::SourceRange::SourceRange):
(WebCore::SourceRange::operator=):
(WebCore::CSSPropertySourceData::CSSPropertySourceData):
(WebCore::CSSPropertySourceData::operator=):
(WebCore::CSSPropertySourceData::toString):
(WebCore::CSSPropertySourceData::hash):
(WebCore::CSSPropertySourceData::init):
* css/CSSPropertySourceData.h: Added.
(WebCore::CSSPropertySourceData::~CSSPropertySourceData):
(WebCore::CSSStyleSourceData::create):
* inspector/Inspector.idl:
* inspector/InspectorCSSStore.cpp:
(WebCore::InspectorCSSStore::reset):
(WebCore::InspectorCSSStore::styleSheetText):
(WebCore::InspectorCSSStore::resourceStyleSheetText):
(WebCore::InspectorCSSStore::inlineStyleSheetText):
(WebCore::InspectorCSSStore::getStyleSourceData):
(WebCore::InspectorCSSStore::extractRanges):
(WebCore::InspectorCSSStore::getStyleAttributeRanges):
(WebCore::InspectorCSSStore::getParentStyleSheet):
(WebCore::InspectorCSSStore::inlineStyleElement):
* inspector/InspectorCSSStore.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::resourceContentForURL):
* inspector/InspectorController.h:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::getStyleSourceData):
(WebCore::InspectorDOMAgent::buildObjectForStyle):
* inspector/InspectorDOMAgent.h:
LayoutTests:
* inspector/resources/styles-source-offsets.css:
(body):
(/* comment before selector */body.main1/* comment after selector */):
(body.main2):
* inspector/styles-source-offsets-expected.txt:
* inspector/styles-source-offsets.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67704
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Fri, 17 Sep 2010 13:36:59 +0000 (13:36 +0000)]
2010-09-17 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Show node description in inspector highlight
https://bugs.webkit.org/show_bug.cgi?id=20930
* inspector/InspectorController.cpp:
(WebCore::InspectorController::drawNodeHighlight):
(WebCore::InspectorController::drawElementTitle):
* inspector/InspectorController.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67703
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Fri, 17 Sep 2010 13:06:06 +0000 (13:06 +0000)]
2010-09-17 Alejandro G. Castro <alex@igalia.com>
Unreviewed, GTK+ rebaselines.
* platform/gtk/fast/repaint/multicol-repaint-expected.txt:
* platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67702
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
satish@chromium.org [Fri, 17 Sep 2010 11:09:53 +0000 (11:09 +0000)]
2010-09-17 Satish Sampath <satish@chromium.org>
Unreviewed, updated chromium baselines and disabled a failing test.
* platform/chromium-linux/fast/css/getComputedStyle/computed-style-expected.txt
* platform/chromium-linux/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
* platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt
* platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt
* platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
* platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt
* platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt
* platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
* platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt
* platform/chromium/test_expectations.txt
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67701
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 17 Sep 2010 07:20:19 +0000 (07:20 +0000)]
WebKit should use system wide spell checking preference when application specific one isn't set.
https://bugs.webkit.org/show_bug.cgi?id=45789
<rdar://problem/
8416041>
Patch by Jia Pu <jpu@apple.com> on 2010-09-17
Reviewed by Dan Bernstein.
* WebView/WebView.mm:
(+[WebView initialize]): Use system wide autocorrection and text substitution preferences
when the application level preferences are not set.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67696
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Fri, 17 Sep 2010 06:20:48 +0000 (06:20 +0000)]
2010-09-16 takano takumi <takano1@asia.apple.com>
Reviewed by Kent Tamura.
https://bugs.webkit.org/show_bug.cgi?id=45020
Support "block-flow" and "writing-mode": interpret properties into RenderStyle
Fixed a regression in SVG test introduced by my previous change.
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::operator EWritingMode):
* css/SVGCSSParser.cpp:
(WebCore::CSSParser::parseSVGValue):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67695
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dumi@chromium.org [Fri, 17 Sep 2010 05:26:57 +0000 (05:26 +0000)]
2010-09-16 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r67693.
http://trac.webkit.org/changeset/67693
https://bugs.webkit.org/show_bug.cgi?id=45946
"Need to pick up a chromium change first" (Requested by dumi
on #webkit).
* public/WebHTTPBody.h:
* src/WebHTTPBody.cpp:
(WebKit::WebHTTPBody::elementAt):
(WebKit::WebHTTPBody::appendFileRange):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67694
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dumi@chromium.org [Fri, 17 Sep 2010 04:56:00 +0000 (04:56 +0000)]
Remove WebHTTPBody::appendFileRange(..., const WebFileInfo&).
Reviewed by Darin Fisher.
* public/WebHTTPBody.h:
* src/WebHTTPBody.cpp:
(WebKit::WebHTTPBody::elementAt):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67693
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kinuko@chromium.org [Fri, 17 Sep 2010 04:30:24 +0000 (04:30 +0000)]
2010-09-16 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Ojan Vafai.
Include detailed test modifiers (e.g. FLAKY) in results.json for failing non-layout tests
https://bugs.webkit.org/show_bug.cgi?id=45408
This change also tries to remove duplicated upload_results_json methods
in run_webkit_tests.py and json_results_generator.py.
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67692
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan@apple.com [Fri, 17 Sep 2010 04:05:37 +0000 (04:05 +0000)]
<rdar://problem/
8395558>
https://bugs.webkit.org/show_bug.cgi?id=45938
_web_makePluginViewsPerformSelector:: mutates subviews array while iterating it
Reviewed by Darin Adler.
* WebView/WebHTMLView.mm:
(-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
Converted from -[NSArray _web_makePluginViewsPerformSelector:withObject:]. The old method
was only ever called on the result of -[WebHTMLView subviews]. By moving that knowledge into
this helper method, it can't be used incorrectly. Now it makes a copy of [WebHTMLView subviews]
before enumerating it, to ensure that the selector can't mutate the array being enumerated.
(-[WebHTMLView viewWillMoveToHostWindow:]):
Updated for _web_makePluginSubviewsPerformSelector:: signature change.
(-[WebHTMLView viewDidMoveToHostWindow]):
Ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67691
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbr@google.com [Fri, 17 Sep 2010 01:53:40 +0000 (01:53 +0000)]
2010-09-16 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
Add entry points to GraphicsContext3D needed for Chromium compositor port
https://bugs.webkit.org/show_bug.cgi?id=45939
Added entry points for two Chromium-specific extensions, and added
a flag to the GraphicsContext3D constructor, currently unsupported
by all ports (including Chromium), indicating whether the context
should render directly to the passed HostWindow or off-screen per
the current semantics. The switch to use GraphicsContext3D in
Chromium's compositor will follow in a subsequent patch.
No new tests; functionality is unchanged. Built and tested
Chromium and WebKit on Mac OS X.
* src/GraphicsContext3D.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::create):
* src/GraphicsContext3DInternal.h:
2010-09-16 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
Add entry points to GraphicsContext3D needed for Chromium compositor port
https://bugs.webkit.org/show_bug.cgi?id=45939
Added entry points for two Chromium-specific extensions, and added
a flag to the GraphicsContext3D constructor, currently unsupported
by all ports (including Chromium), indicating whether the context
should render directly to the passed HostWindow or off-screen per
the current semantics. The switch to use GraphicsContext3D in
Chromium's compositor will follow in a subsequent patch.
No new tests; functionality is unchanged. Built and tested
Chromium and WebKit on Mac OS X.
* platform/graphics/GraphicsContext3D.cpp:
(WebCore::GraphicsContext3D::supportsMapSubCHROMIUM):
(WebCore::GraphicsContext3D::mapBufferSubDataCHROMIUM):
(WebCore::GraphicsContext3D::unmapBufferSubDataCHROMIUM):
(WebCore::GraphicsContext3D::mapTexSubImage2DCHROMIUM):
(WebCore::GraphicsContext3D::unmapTexSubImage2DCHROMIUM):
(WebCore::GraphicsContext3D::supportsCopyTextureToParentTextureCHROMIUM):
(WebCore::GraphicsContext3D::copyTextureToParentTextureCHROMIUM):
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/mac/GraphicsContext3DMac.mm:
(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::GraphicsContext3D):
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::GraphicsContext3D):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67690
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonikitoo@webkit.org [Fri, 17 Sep 2010 01:34:20 +0000 (01:34 +0000)]
2010-09-16 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Andreas Kling.
[Qt] When switching views (WebViewGraphicsBased <--> WebViewTraditional), QWebPage signals and QActions have to be re-set.
Recently r67554 changed the way different views use the WebPage class: it was previously being shared between
different views, but now for each view switch, a new WebPage class is constructed and set. Signals and QAction's
were not being set to the new WebPage though. Patch fix that, by re constructing the toolbar, and then re-hooking
all page specific stuff to the UI.
* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::initializeView):
* QtTestBrowser/mainwindow.cpp:
(MainWindow::MainWindow):
(MainWindow::buildUI):
(MainWindow::setPage):
* QtTestBrowser/mainwindow.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67689
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonikitoo@webkit.org [Fri, 17 Sep 2010 01:33:44 +0000 (01:33 +0000)]
2010-09-12 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Andreas Kling.
Make all accesses to m_item (GraphicsWebView) done by WebViewGraphicsBased class happen though graphicsWebView getter method.
This patch is mostly a preparation for another commit, where the ownership of the m_item/GraphicsWebView
object will move to the qgraphicsscene instead of the qgraphicsview.
* QtTestBrowser/webview.cpp:
(WebViewGraphicsBased::setPage):
(WebViewGraphicsBased::setResizesToContents):
(WebViewGraphicsBased::resizeEvent):
(WebViewGraphicsBased::animatedFlip):
* QtTestBrowser/webview.h:
(WebViewGraphicsBased::setItemCacheMode):
(WebViewGraphicsBased::itemCacheMode):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67688
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonikitoo@webkit.org [Fri, 17 Sep 2010 01:32:42 +0000 (01:32 +0000)]
2010-09-12 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Andreas Kling.
Moved setYRotation method body out of the class (WebViewGraphicsBased) definition.
We usually separate methods whose body are larger the a few lines from the class definition.
* QtTestBrowser/webview.h:
(WebViewGraphicsBased::yRotation):
(WebViewGraphicsBased::setYRotation):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67687
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonikitoo@webkit.org [Fri, 17 Sep 2010 01:32:12 +0000 (01:32 +0000)]
2010-09-12 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Andreas Kling.
Make initializeView method of LauncherWindow private.
No one else needs to be able to call it but LauncherWindow.
Also moving the declation of isGraphicsBased method down in the same file, in order
to better group related methods.
* QtTestBrowser/launcherwindow.h:
* QtTestBrowser/launcherwindow.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67686
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonikitoo@webkit.org [Fri, 17 Sep 2010 01:31:51 +0000 (01:31 +0000)]
2010-09-12 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Andreas Kling.
Make the getter 'page' method of MainWindow const.
* QtTestBrowser/mainwindow.cpp:
(MainWindow::page):
* QtTestBrowser/mainwindow.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67685
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonikitoo@webkit.org [Fri, 17 Sep 2010 01:31:34 +0000 (01:31 +0000)]
2010-09-12 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Andreas Kling.
Remove useless parameter from MainWindow class' constructor.
The parameter defaults to an empty URL and is not being used by any caller. Apart from that
and is also not referred in the constructor body and does not make much sense.
* QtTestBrowser/mainwindow.cpp:
(MainWindow::MainWindow):
* QtTestBrowser/mainwindow.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67684
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Fri, 17 Sep 2010 01:18:30 +0000 (01:18 +0000)]
2010-09-16 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Crash due to timer triggered GC on one heap while another heap is active
https://bugs.webkit.org/show_bug.cgi?id=45932
<rdar://problem/
8318446>
The GC timer may trigger for one heap while another heap is active. This
is safe, but requires us to ensure that we have temporarily associated the
thread's identifierTable with the heap we're collecting on. Otherwise we
may end up with the identifier tables in an inconsistent state leading to
an eventual crash.
* runtime/Collector.cpp:
(JSC::Heap::allocate):
(JSC::Heap::reset):
(JSC::Heap::collectAllGarbage):
Add assertions to ensure we have the correct identifierTable active
while collecting.
* runtime/GCActivityCallbackCF.cpp:
(JSC::DefaultGCActivityCallbackPlatformData::trigger):
Temporarily make the expected IdentifierTable active
* wtf/WTFThreadData.h:
(JSC::IdentifierTable::remove):
Make it possible to see when IdentifierTable::remove has succeeded
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::~StringImpl):
CRASH if an StringImpl is an Identifier but isn't present in the
active IdentifierTable. If we get to this state something has
gone wrong and we should just crash immediately.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67683
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 17 Sep 2010 01:04:46 +0000 (01:04 +0000)]
2010-09-16 Simon Fraser <simon.fraser@apple.com>
Reviewed by James Robinson.
In layerTreeAsText output, avoid printing properties which have their default values
https://bugs.webkit.org/show_bug.cgi?id=45931
Don't dump properties that have their default values to simplify output.
* platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::dumpProperties):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67682
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit.git / log