loki@webkit.org [Wed, 8 Sep 2010 22:43:25 +0000 (22:43 +0000)]
2010-09-08 Gabor Loki <loki@webkit.org>
Reviewed by Andreas Kling.
Fix increases required alignment of target type warning on ARM
https://bugs.webkit.org/show_bug.cgi?id=45301
No new tests needed.
* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneDeserializer::readLittleEndian):
(WebCore::CloneDeserializer::readString):
* plugins/PluginDatabase.cpp:
(WebCore::readTime):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67028
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 8 Sep 2010 22:30:03 +0000 (22:30 +0000)]
LayoutTest regressions due to trac.webkit.org/changeset/67001
https://bugs.webkit.org/show_bug.cgi?id=45411
* platform/qt/Skipped: Skip some flakey tests to make buildbot green.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67026
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonikitoo@webkit.org [Wed, 8 Sep 2010 22:16:12 +0000 (22:16 +0000)]
Make FocusController::focusedOrMainFrame method const
https://bugs.webkit.org/show_bug.cgi?id=45406
Reviewed by Daniel Bates.
Patch by Antonio Gomes <agomes@rim.com>
No new tests once it is not a behavior change.
* page/FocusController.cpp:
(WebCore::FocusController::focusedOrMainFrame):
* page/FocusController.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67025
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
victorw@chromium.org [Wed, 8 Sep 2010 22:15:20 +0000 (22:15 +0000)]
2010-09-08 Victor Wang <victorw@chromium.org>
Reviewed by Ojan Vafai.
[Chromium] Fix test results server to make sure
it does not have corrupted data.
results.json file size coulbe be >1M and we split
the data into multiple data store entries in this
case. This patch fixes the issue that the data may
be corrupted if data store error happens in the middle
of saving multiple entries.
https://bugs.webkit.org/show_bug.cgi?id=45063
* TestResultServer/model/datastorefile.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67024
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pkasting@chromium.org [Wed, 8 Sep 2010 22:10:09 +0000 (22:10 +0000)]
Not reviewed, build fix.
* WebScrollBar.cpp:
(WebScrollBar::setScrollOffsetFromAnimation):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67022
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pkasting@chromium.org [Wed, 8 Sep 2010 22:05:47 +0000 (22:05 +0000)]
Not reviewed, build fix.
* WebScrollBar.cpp:
(WebScrollBar::scrollSize):
(WebScrollBar::setScrollOffsetFromAnimation):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67020
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pkasting@chromium.org [Wed, 8 Sep 2010 21:49:49 +0000 (21:49 +0000)]
Not reviewed, build fix.
* WebScrollBar.cpp:
(WebScrollBar::setValue):
(WebScrollBar::scrollSize):
(WebScrollBar::setScrollOffsetFromAnimation):
* WebScrollBar.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67018
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jianli@chromium.org [Wed, 8 Sep 2010 21:40:37 +0000 (21:40 +0000)]
Fix a problem in createCanonicalUUIDString that causes the last digit
missing on Linux.
https://bugs.webkit.org/show_bug.cgi?id=45412
Reviewed by Darin Adler.
WebCore:
This is caused by not including the final null character into the count
that is provided to fgets.
This is covered by the existing test: send-form-data-with-sliced-file.html.
* platform/UUID.cpp:
(WebCore::createCanonicalUUIDString):
LayoutTests:
Remove the test that is now passing on Linux for chromium.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67017
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 8 Sep 2010 21:27:10 +0000 (21:27 +0000)]
Add a way to cause the web process to crash at a random time
Setting the WEBKIT2_CRASH_WEB_PROCESS_RANDOMLY environment variable
will cause the web process to crash at a random point up to 3 minutes
after launching.
Fixes <http://webkit.org/b/43058> <rdar://problem/
8240150>
Reviewed by Darin Adler.
* WebProcess/WebProcess.cpp:
(WebKit::sleep): Added an implementation of this function for Windows.
It just calls through to ::Sleep.
(WebKit::randomCrashThread): Added. Sleeps for a random amount of time
up to 3 minutes, then crashes.
(WebKit::startRandomCrashThreadIfRequested): Added. Starts the crash
thread if the WEBKIT2_CRASH_WEB_PROCESS_RANDOMLY environment variable
is set.
(WebKit::WebProcess::initialize): Added a call to
startRandomCrashThreadIfRequested.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67016
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thakis@chromium.org [Wed, 8 Sep 2010 21:25:00 +0000 (21:25 +0000)]
2010-09-08 Nico Weber <thakis@chromium.org>
Reviewed by Dimitri Glazkov.
chromium/mac: Fix overrelease in ImageLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=45360
Only release colorSpace if we created it.
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::updateContents):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67015
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 8 Sep 2010 21:17:06 +0000 (21:17 +0000)]
Fix potential ref-counting issues with WorkItemWin
Reviewed by Anders Carlsson.
* Platform/WorkQueue.h: Changed WorkItemWin to inherit from
ThreadSafeShared instead of RefCounted so that its ref-count will stay
consistent when used on multiple threads.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67014
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 8 Sep 2010 21:16:45 +0000 (21:16 +0000)]
Teach WorkQueue how to stop waiting on objects on Windows
WorkQueue now uses a subclass of WorkItemWin, HandleWorkItem, to hold
the waited-upon HANDLE and its corresponding wait handle. When a
HANDLE is unregistered, we use the HandleWorkItem to cancel the wait
and destroy the HANDLE.
Fixes <http://webkit.org/b/42826> <rdar://problem/
8222253> Crash in
thread pool because WorkQueue keeps waiting on closed HANDLEs
Reviewed by Anders Carlsson.
* Platform/CoreIPC/win/ConnectionWin.cpp:
(CoreIPC::Connection::platformInvalidate): Changed to call
WorkQueue::unregisterAndCloseHandle instead of closing our handles
manually.
(CoreIPC::Connection::readEventHandler):
(CoreIPC::Connection::writeEventHandler):
Handle cases where the pipe has already closed by just bailing out.
This can happen if a WorkItem to call one of these functions has
already been scheduled before platformInvalidate is called.
* Platform/WorkQueue.h: Gave WorkItemWin a virtual destructor, added
HandleWorkItem, changed m_handles to hold HandleWorkItems, and added
functions for unregistering waits.
* Platform/win/WorkQueueWin.cpp:
(WorkQueue::WorkItemWin::~WorkItemWin): Added. This virtual destructor
ensures that HandleWorkItem's destructor gets called.
(WorkQueue::HandleWorkItem::HandleWorkItem):
(WorkQueue::HandleWorkItem::createByAdoptingHandle):
Added simple constructor/creator.
(WorkQueue::HandleWorkItem::~HandleWorkItem): Closes the handle we
adopted.
(WorkQueue::registerHandle): Changed to create a HandleWorkItemWin and
to store the wait handle in it.
(WorkQueue::unregisterAndCloseHandle): Added. Removes the
HandleWorkItem for this HANDLE from m_handles and then schedules its
wait to be unregistered and the item to be destroyed.
(WorkQueue::platformInvalidate): Added an assertion and removed an
obsolete FIXME.
(WorkQueue::unregisterWaitAndDestroyItemSoon): Added. Calls
unregisterWaitAndDestroyItemCallback on a worker thread, passing it
ownership of the HandleWorkItem.
(WorkQueue::unregisterWaitAndDestroyItemCallback): Added. Adopts the
passed-in HandleWorkItem, then unregisters the handle's wait, then
destroys the HandleWorkItem when the RefPtr holding it goes out of
scope. Destroying the HandleWorkItem closes the handle.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67013
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Wed, 8 Sep 2010 20:57:33 +0000 (20:57 +0000)]
2010-09-08 Robert Hogan <robert@webkit.org>
Reviewed by Antonio Gomes.
Remove some unnecessary duplicate calls to string functions
https://bugs.webkit.org/show_bug.cgi?id=45314
* wtf/text/WTFString.cpp:
(WTF::String::format):
2010-09-08 Robert Hogan <robert@webkit.org>
Reviewed by Antonio Gomes.
Remove some unnecessary duplicate calls to string functions
https://bugs.webkit.org/show_bug.cgi?id=45314
* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::parseDataUrl):
* websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::send):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67012
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
demarchi@webkit.org [Wed, 8 Sep 2010 20:51:47 +0000 (20:51 +0000)]
2010-09-08 Ryuan Choi <ryuan.choi@samsung.com>
Unreviewed build fix.
[EFL] Need to add custom dependencies.
https://bugs.webkit.org/show_bug.cgi?id=45247
Add WebKit_Theme into WebKit_SOURCES to make it while building.
* CMakeListsEfl.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67011
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pkasting@chromium.org [Wed, 8 Sep 2010 20:33:06 +0000 (20:33 +0000)]
WebCore: Not reviewed, fallout from trac.webkit.org/changeset/67001
Fix compile failures and add svn:eol-style on two new files.
* platform/ScrollAnimator.h: Added property svn:eol-style.
* platform/ScrollAnimatorWin.cpp: Added property svn:eol-style.
* platform/win/PopupMenuWin.cpp: Fix compile errors.
(WebCore::PopupMenuWin::scrollToRevealSelection):
(WebCore::PopupMenuWin::scrollSize):
LayoutTests: Not reviewed, skip failing layout tests.
https://bugs.webkit.org/show_bug.cgi?id=45411
* platform/qt/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67009
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Wed, 8 Sep 2010 20:24:42 +0000 (20:24 +0000)]
2010-09-08 Martin Robinson <mrobinson@igalia.com>
Skip websocket tests until the GLib/GIO situation on the
Debug bots can be sorted out.
* platform/gtk/Skipped: Skip websocket tests.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67007
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Wed, 8 Sep 2010 20:18:38 +0000 (20:18 +0000)]
2010-09-08 Maciej Stachowiak <mjs@apple.com>
Reviewed by Anders Carlsson.
Add some entries to the WebKit2 skipped list, based on the buildbot
https://bugs.webkit.org/show_bug.cgi?id=45380
* platform/mac-wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67006
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 8 Sep 2010 20:14:51 +0000 (20:14 +0000)]
Remove WKSerializedScriptValue.cpp/h from the Copy Files build phase
* WebKit2.xcodeproj/project.pbxproj:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67005
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonikitoo@webkit.org [Wed, 8 Sep 2010 19:56:11 +0000 (19:56 +0000)]
2010-09-08 Antonio Gomes <agomes@rim.com>
Unreviewed: adding my new commit email to committers.py
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67004
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Wed, 8 Sep 2010 19:38:43 +0000 (19:38 +0000)]
2010-09-08 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Force canvas 2d draw calls to happen in software if a gradient, pattern, shadow, or clip are active
https://bugs.webkit.org/show_bug.cgi?id=45405
This forces all draw calls to happen in software instead of hardware if there is a fill pattern, gradient,
shadow, or clip applied; at least until we can handle these in hardware. Otherwise the pattern/gradient/etc
is completely ignored by the hardware drawing routine and we render incorrectly.
The test is slightly convervative - for example it will force drawImage() calls to happen in software if a
fill gradient is set even though it's irrelevant. This doesn't seem to be an issue in practice and we
can tighten the checks later if needed.
Tested by fast/canvas/canvas-incremental-repaint.html.
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::canvasClip):
(WebCore::GraphicsContext::fillRect):
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::draw):
* platform/graphics/skia/ImageSkia.cpp:
(WebCore::BitmapImage::draw):
(WebCore::BitmapImageSingleFrameSkia::draw):
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::State::State):
(WebCore::PlatformContextSkia::canvasClipPath):
(WebCore::PlatformContextSkia::canAccelerate):
* platform/graphics/skia/PlatformContextSkia.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67003
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
demarchi@webkit.org [Wed, 8 Sep 2010 19:38:38 +0000 (19:38 +0000)]
2010-09-08 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Export data directory through pkg-config
https://bugs.webkit.org/show_bug.cgi?id=45385
Using pkg-config it's possible for a browser to know the location of
installed themes. When compiling the browser, a variable might be
defined with the datadir, like below:
gcc -o browser browser.c $(pkg-config --libs --cflags ewebkit) \
-DEWEBKIT_DATA_DIR=$(pkg-config --variable=datadir)
* ewebkit.pc.in: Export datadir variable.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67002
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 8 Sep 2010 19:31:47 +0000 (19:31 +0000)]
2010-09-08 Peter Kasting <pkasting@google.com>
Reviewed by David Hyatt.
Add smooth scrolling framework, and a Windows implementation.
https://bugs.webkit.org/show_bug.cgi?id=32356
* wscript: Add Windows ScrollAnimator.
2010-09-08 Peter Kasting <pkasting@google.com>
Reviewed by David Hyatt.
Add smooth scrolling framework, and a Windows implementation.
https://bugs.webkit.org/show_bug.cgi?id=32356
* CMakeLists.txt: Add ScrollAnimator.
* GNUmakefile.am: Add ScrollAnimator.
* WebCore.gyp/WebCore.gyp: Add Windows ScrollAnimator.
* WebCore.gypi: Add ScrollAnimator.
* WebCore.pro: Add ScrollAnimator.
* WebCore.vcproj/WebCore.vcproj: Add ScrollAnimator.
* WebCore.xcodeproj/project.pbxproj: Add ScrollAnimator.
* platform/ScrollAnimator.cpp: Added base implementation that does no animation.
(WebCore::ScrollAnimator::create):
(WebCore::ScrollAnimator::scroll):
(WebCore::ScrollAnimator::setScrollPositionAndStopAnimation):
* platform/ScrollAnimator.h: Added base implementation that does no animation.
(WebCore::ScrollAnimator::ScrollAnimator):
(WebCore::ScrollAnimator::~ScrollAnimator):
* platform/ScrollAnimatorWin.cpp: Added Windows subclass that animates scrolls.
(WebCore::ScrollAnimator::create):
(WebCore::ScrollAnimatorWin::PerAxisData::PerAxisData):
(WebCore::ScrollAnimatorWin::ScrollAnimatorWin):
(WebCore::ScrollAnimatorWin::~ScrollAnimatorWin):
(WebCore::ScrollAnimatorWin::scroll):
(WebCore::ScrollAnimatorWin::setScrollPositionAndStopAnimation):
(WebCore::ScrollAnimatorWin::accelerationTime):
(WebCore::ScrollAnimatorWin::animationTimerFired):
(WebCore::ScrollAnimatorWin::stopAnimationTimerIfNeeded):
(WebCore::ScrollAnimatorWin::animateScroll):
* platform/ScrollAnimatorWin.h: Added Windows subclass that animates scrolls.
* platform/ScrollView.cpp: Implement new ScrollbarClient functions. Allow wheel scrolls to be animated.
(WebCore::ScrollView::scrollSize):
(WebCore::ScrollView::setScrollOffsetFromAnimation):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::wheelEvent):
* platform/ScrollView.h: Implement new ScrollbarClient functions.
* platform/Scrollbar.cpp: Allow ScrollAnimator to handle scrolls if present.
(WebCore::Scrollbar::setValue):
(WebCore::Scrollbar::scroll):
(WebCore::Scrollbar::moveThumb):
(WebCore::Scrollbar::setCurrentPos):
(WebCore::Scrollbar::mouseMoved):
* platform/Scrollbar.h:
* platform/ScrollbarClient.cpp: Added to avoid having to make ScrollAnimator.h non-private.
(WebCore::ScrollbarClient::ScrollbarClient):
(WebCore::ScrollbarClient::~ScrollbarClient):
(WebCore::ScrollbarClient::scroll):
(WebCore::ScrollbarClient::setScrollPositionAndStopAnimation):
* platform/ScrollbarClient.h: Add hooks for ScrollAnimator.
(WebCore::ScrollbarClient::convertFromScrollbarToContainingView):
(WebCore::ScrollbarClient::convertFromContainingViewToScrollbar):
* platform/gtk/MainFrameScrollbarGtk.cpp:
(MainFrameScrollbarGtk::gtkValueChanged):
* platform/qt/ScrollbarQt.cpp: Use scroll() in preference to setValue().
(WebCore::Scrollbar::contextMenu):
* platform/win/PopupMenuWin.cpp: Implement new ScrollbarClient functions.
(WebCore::PopupMenuWin::scrollSize):
(WebCore::PopupMenuWin::setScrollOffsetFromAnimation):
* platform/win/PopupMenuWin.h: Implement new ScrollbarClient functions.
* rendering/RenderDataGrid.cpp: Implement new ScrollbarClient functions.
(WebCore::RenderDataGrid::scrollSize):
(WebCore::RenderDataGrid::setScrollOffsetFromAnimation):
* rendering/RenderDataGrid.h: Implement new ScrollbarClient functions.
* rendering/RenderLayer.cpp: Implement new ScrollbarClient functions.
(WebCore::RenderLayer::scrollToOffset):
(WebCore::RenderLayer::scrollSize):
(WebCore::RenderLayer::setScrollOffsetFromAnimation):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
* rendering/RenderLayer.h: Implement new ScrollbarClient functions.
* rendering/RenderListBox.cpp: Implement new ScrollbarClient functions.
(WebCore::RenderListBox::scrollToRevealElementAtListIndex):
(WebCore::RenderListBox::scrollSize):
(WebCore::RenderListBox::setScrollOffsetFromAnimation):
(WebCore::RenderListBox::setScrollTop):
* rendering/RenderListBox.h: Implement new ScrollbarClient functions.
2010-09-08 Peter Kasting <pkasting@google.com>
Reviewed by David Hyatt.
Add smooth scrolling framework, and a Windows implementation.
https://bugs.webkit.org/show_bug.cgi?id=32356
* src/WebScrollbarImpl.cpp: Plumb new ScrollbarClient functions. Allow wheel scrolls to be animated.
(WebKit::WebScrollbarImpl::setLocation):
(WebKit::WebScrollbarImpl::setValue):
(WebKit::WebScrollbarImpl::scroll):
(WebKit::WebScrollbarImpl::onMouseWheel):
(WebKit::WebScrollbarImpl::onKeyDown):
(WebKit::WebScrollbarImpl::setScrollOffsetFromAnimation):
* src/WebScrollbarImpl.h: Plumb new ScrollbarClient functions.
* src/win/WebInputEventFactory.cpp: Update comments now that we have smooth scrolling.
(WebKit::WebInputEventFactory::mouseWheelEvent):
2010-09-08 Peter Kasting <pkasting@google.com>
Reviewed by David Hyatt.
Add smooth scrolling framework, and a Windows implementation.
https://bugs.webkit.org/show_bug.cgi?id=32356
* Api/qwebframe.cpp:
(QWebFrame::setScrollBarValue):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67001
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 8 Sep 2010 19:24:10 +0000 (19:24 +0000)]
2010-09-08 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
applyInlineStyleToRange needs cleanup
https://bugs.webkit.org/show_bug.cgi?id=45008
Removed rangeIsEmpty and extracted the entire loop into applyInlineStyleToNodeRange.
applyInlineStyleToRange is now a wrapper that fixes range and passes it on to applyInlineStyleToNodeRange.
No new tests are added since this is a cleanup.
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyInlineStyleToRange): Cleaned up.
(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): Extracted from applyInlineStyleToRange.
* editing/ApplyStyleCommand.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67000
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 8 Sep 2010 19:20:17 +0000 (19:20 +0000)]
Get rid of WorkQueue::m_performWorkEvent
We were signaling m_performWorkEvent to spawn a worker thread. We can
use ::QueueUserWorkItem to spawn the thread instead.
Fixes <http://webkit.org/b/45407> WorkQueue::m_performWorkEvent is
unnecessary
Reviewed by Anders Carlsson.
* Platform/WorkQueue.h: Removed m_performWorkEvent.
* Platform/win/WorkQueueWin.cpp:
(WorkQueue::workThreadCallback): Replaced eventCallback with this
function. Its functionality is unchanged.
(WorkQueue::platformInitialize):
(WorkQueue::platformInvalidate):
Removed code to set up and clean up m_performWorkEvent.
(WorkQueue::scheduleWork): Use ::QueueUserWorkItem instead of
signaling m_performWorkEvent to spawn a worker thread.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66999
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 8 Sep 2010 18:41:17 +0000 (18:41 +0000)]
Fix WebKit2Common.vsprops line-endings
* win/WebKit2Common.vsprops: Made all line-endings be CRLF, as this is
the format Visual Studio wants.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66998
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Wed, 8 Sep 2010 18:17:25 +0000 (18:17 +0000)]
Incorporate additional feedback from
https://bugs.webkit.org/show_bug.cgi?id=45364.
Rubber-stamped by Darin Adler.
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parametersForPlugin): Rename urlParam to
urlParameter.
* loader/SubframeLoader.h: Add argument names to the definition of
SubframeLoader::resourceWillUsePlugin().
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66997
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Wed, 8 Sep 2010 18:07:12 +0000 (18:07 +0000)]
2010-09-08 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Joseph Pecoraro.
Web Inspector: remove some obsolete interactive tests
https://bugs.webkit.org/show_bug.cgi?id=45371
* src/js/Tests.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66996
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Wed, 8 Sep 2010 17:58:23 +0000 (17:58 +0000)]
2010-09-07 Oliver Hunt <oliver@apple.com>
Reviewed by Anders Carlsson.
Support SerializedScriptValue in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=45340
Add a new constructor that allows WebKit2 to create a SerializedScriptValue
directly from serialized data.
* WebCore.exp.in:
* bindings/js/SerializedScriptValue.h:
(WebCore::SerializedScriptValue::adopt):
(WebCore::SerializedScriptValue::data):
2010-09-07 Oliver Hunt <oliver@apple.com>
Reviewed by Anders Carlsson.
Support SerializedScriptValue in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=45340
Add wrappers and IPC serialization for SerializedScriptValue
* Shared/APIObject.h:
* Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
* Shared/WebSerializedScriptValue.h: Added.
(WebKit::WebSerializedScriptValue::create):
(WebKit::WebSerializedScriptValue::adopt):
(WebKit::WebSerializedScriptValue::deserialize):
(WebKit::WebSerializedScriptValue::data):
(WebKit::WebSerializedScriptValue::WebSerializedScriptValue):
(WebKit::WebSerializedScriptValue::type):
* UIProcess/API/C/WKAPICast.h:
* UIProcess/API/C/WKBase.h:
* UIProcess/API/C/WKSerializedScriptValue.cpp: Added.
(WKSerializedScriptValueGetTypeID):
(WKSerializedScriptValueCreate):
(WKSerializedScriptValueDeserialize):
* UIProcess/API/C/WKSerializedScriptValue.h: Added.
* WebKit2.xcodeproj/project.pbxproj:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66995
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Wed, 8 Sep 2010 17:08:14 +0000 (17:08 +0000)]
2010-09-08 Andy Estes <aestes@apple.com>
Reviewed by Eric Carlson.
Fallback content should be rendered when an <object> doesn't specify a
data, type or classid attribute.
https://bugs.webkit.org/show_bug.cgi?id=45364
<rdar://problem/
8375816>
HTML5 says that if no data or type attribute is specified on an <object>,
fallback content should be rendered. However, WebKit has traditionally
supported specifying a URL and MIME type in <param> elements.
To more closely match the spec while maintaining compatibility with
content that relied on our old behavior, we will continue to load
a resource specified by <param> elements if we can determine a priori
that it will be handled by a plug-in.
If we can't make this determination, and the <object> element has no
"data" or "type" attribute, the <param> elements will be ignored and
fallback content will be rendered. Otherwise, there is no change in
behavior.
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parametersForPlugin): If an empty url is
passed to this function and a <param> exists that specifies a url that
references a plug-in resource, set it to url, making it the url that
will be loaded by the <object> element.
(WebCore::HTMLObjectElement::updateWidget): If no type attribute was
specified, but there is a classid attribute, try to map the classid to
a MIME type. This needs to be done before calling
HTMLObjectElement::parametersForPlugin().
* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::resourceWillUsePlugin): Make a public method
that determines if a resource will load a plug-in based on its url and
MIME type. This is equivalent to calling
SubframeLoader::shouldUsePlugin(), but does not burden the caller with
the details of fallback content.
* loader/SubframeLoader.h:
2010-09-08 Andy Estes <aestes@apple.com>
Reviewed by Eric Carlson.
Fallback content should be rendered when an <object> doesn't specify a
data, type or classid attribute.
https://bugs.webkit.org/show_bug.cgi?id=45364
<rdar://problem/
8375816>
* fast/replaced/object-param-url-control-char.html:
* fast/replaced/object-with-embed-url-param-expected.txt:
* fast/replaced/object-with-embed-url-param.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66992
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jocelyn.turcotte@nokia.com [Wed, 8 Sep 2010 16:52:44 +0000 (16:52 +0000)]
2010-09-08 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Andreas Kling.
Re-Disable JIT for MSVC 64bit to fix the build on this compiler.
https://bugs.webkit.org/show_bug.cgi?id=45382
It was enabled in the cleanup made in r64176, though it is still
not implemented.
* wtf/Platform.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66991
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 8 Sep 2010 16:35:40 +0000 (16:35 +0000)]
Unreviewed buildfix after r66972.
[Qt] Treat warnings as errors by default for gcc
https://bugs.webkit.org/show_bug.cgi?id=43191
* WebKit.pri: Don't add -Werror for maemo platforms.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66990
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 8 Sep 2010 16:11:12 +0000 (16:11 +0000)]
2010-09-08 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: add breakpoints to source frame after content is loaded.
https://bugs.webkit.org/show_bug.cgi?id=43056
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._resourceLoadingFinished):
(WebInspector.ScriptsPanel.prototype._showScriptOrResource):
* inspector/front-end/SourceView.js:
(WebInspector.SourceView.prototype._contentLoaded):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66989
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Wed, 8 Sep 2010 16:07:01 +0000 (16:07 +0000)]
2010-09-08 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Canvas: Remove unnecessary null-check of canvas() in getImageData()
https://bugs.webkit.org/show_bug.cgi?id=45394
canvas() is already dereferenced earlier in the function so there is
no use in checking it for null later.
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::getImageData):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66988
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Wed, 8 Sep 2010 15:55:44 +0000 (15:55 +0000)]
2010-09-08 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Carlson.
[GStreamer] cache media duration in READY instead of PLAYING
https://bugs.webkit.org/show_bug.cgi?id=39053
New cacheDuration private method used to in updateStates() and
durationChanged().
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::updateStates):
(WebCore::MediaPlayerPrivateGStreamer::cacheDuration):
(WebCore::MediaPlayerPrivateGStreamer::durationChanged):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66987
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Wed, 8 Sep 2010 15:27:17 +0000 (15:27 +0000)]
2010-09-08 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Need a WebSocket implementation
https://bugs.webkit.org/show_bug.cgi?id=45197
* configure.ac: Enable WebSocket by default.
2010-09-08 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Need a WebSocket implementation
https://bugs.webkit.org/show_bug.cgi?id=45197
Add a GIO-based WebSocket implementation.
* wtf/gobject/GRefPtr.cpp: Added PlatformRefPtr support for GSource.
(WTF::refPlatformPtr):
(WTF::derefPlatformPtr):
* wtf/gobject/GRefPtr.h: Added new template specialization declarations.
* wtf/gobject/GTypedefs.h: Add some more GLib/GIO forward declarations.
2010-09-08 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Need a WebSocket implementation
https://bugs.webkit.org/show_bug.cgi?id=45197
* platform/gtk/Skipped: Unskip all WebSocket tests, as they are passing.
2010-09-08 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Need a WebSocket implementation
https://bugs.webkit.org/show_bug.cgi?id=45197
Add a GIO-based WebSocket implementation. This does not yet support
SSL sockets or proxies, but these should be possible to add as support
arrives in GLib/GIO for them.
* platform/network/soup/SocketStreamHandle.h:
* platform/network/soup/SocketStreamHandleSoup.cpp: Add a GIO-based WebSocket implementation.
(WebCore::isActiveHandle): Added.
(WebCore::deactivateHandle): Added.
(WebCore::SocketStreamHandle::SocketStreamHandle): Filled out stub.
(WebCore::SocketStreamHandle::~SocketStreamHandle): Ditto.
(WebCore::SocketStreamHandle::connected): Added.
(WebCore::SocketStreamHandle::readBytes): Added.
(WebCore::SocketStreamHandle::writeReady): Added.
(WebCore::SocketStreamHandle::platformSend): Filled out stub.
(WebCore::SocketStreamHandle::platformClose): Filled out stub.
(WebCore::SocketStreamHandle::beginWaitingForSocketWritability): Added.
(WebCore::SocketStreamHandle::stopWaitingForSocketWritability):
(WebCore::connectedCallback): Added.
(WebCore::readReadyCallback): Added.
(WebCore::writeReadyCallback): Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66986
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 8 Sep 2010 15:18:36 +0000 (15:18 +0000)]
2010-09-08 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Adam Barth.
Errors in LayoutTests/http/tests/security/xss-DENIED-mime-type-execute-as-html.html
https://bugs.webkit.org/show_bug.cgi?id=45377
The test passes a MIME type as argument of a URL. A PHP code uses
that MIME type to fill the Content-Type of the response. If the
MIME type is application/rss+xml the php decodes the '+' as a
blank space and thus the returned content type is incorrectly set
to "rss xml" instead of "rss+xml".
* http/tests/security/resources/send-mime-types.php:
* http/tests/security/xss-DENIED-mime-type-execute-as-html.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66985
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 8 Sep 2010 15:11:42 +0000 (15:11 +0000)]
Fix ignoring return value warning in case of gcc 4.4.4
https://bugs.webkit.org/show_bug.cgi?id=45384
Patch by Peter Varga <pvarga@inf.u-szeged.hu> on 2010-09-08
Reviewed by Kenneth Rohde Christiansen.
* DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
(testPostURLFile):
If fwrite have written zero byte then the testPostURLFile function
returns with false as tempFile can't be opened.
* DumpRenderTree/qt/ImageDiff.cpp:
(main):
Put fwrite function into an if condition without body to avoid
warning. It is safe because this function writes to the stdout.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66984
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Wed, 8 Sep 2010 14:47:49 +0000 (14:47 +0000)]
2010-09-07 Martin Robinson <mrobinson@igalia.com>
Reviewed by Dirk Schulze.
[Cairo] Actually use the antialias parameter of GraphicsContext::clipConvexPolygon
https://bugs.webkit.org/show_bug.cgi?id=45355
Rebaseline all differing border tests and unskip any border tests without results.
* platform/gtk/Skipped: Unskip all border tests.
* platform/gtk/fast/borders/block-mask-overlay-image-expected.checksum: Added.
* platform/gtk/fast/borders/block-mask-overlay-image-expected.png: Added.
* platform/gtk/fast/borders/block-mask-overlay-image-expected.txt: Added.
* platform/gtk/fast/borders/border-color-inherit-expected.checksum: Added.
* platform/gtk/fast/borders/border-color-inherit-expected.png: Added.
* platform/gtk/fast/borders/border-color-inherit-expected.txt: Added.
* platform/gtk/fast/borders/border-fit-expected.checksum: Added.
* platform/gtk/fast/borders/border-fit-expected.png: Added.
* platform/gtk/fast/borders/border-fit-expected.txt: Added.
* platform/gtk/fast/borders/border-image-01-expected.checksum: Added.
* platform/gtk/fast/borders/border-image-01-expected.png: Added.
* platform/gtk/fast/borders/border-image-01-expected.txt: Added.
* platform/gtk/fast/borders/border-image-border-radius-expected.checksum: Added.
* platform/gtk/fast/borders/border-image-border-radius-expected.png: Added.
* platform/gtk/fast/borders/border-image-border-radius-expected.txt: Added.
* platform/gtk/fast/borders/border-image-omit-right-slice-expected.checksum: Added.
* platform/gtk/fast/borders/border-image-omit-right-slice-expected.png: Added.
* platform/gtk/fast/borders/border-image-omit-right-slice-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/border-image-omit-right-slice-expected.txt.
* platform/gtk/fast/borders/border-image-rotate-transform-expected.checksum: Added.
* platform/gtk/fast/borders/border-image-rotate-transform-expected.png: Added.
* platform/gtk/fast/borders/border-image-rotate-transform-expected.txt: Added.
* platform/gtk/fast/borders/border-image-scale-transform-expected.checksum: Added.
* platform/gtk/fast/borders/border-image-scale-transform-expected.png: Added.
* platform/gtk/fast/borders/border-image-scale-transform-expected.txt: Added.
* platform/gtk/fast/borders/border-radius-circle-expected.checksum:
* platform/gtk/fast/borders/border-radius-circle-expected.png:
* platform/gtk/fast/borders/border-radius-constraints-expected.checksum: Added.
* platform/gtk/fast/borders/border-radius-constraints-expected.png: Added.
* platform/gtk/fast/borders/border-radius-constraints-expected.txt: Added.
* platform/gtk/fast/borders/border-radius-groove-01-expected.checksum:
* platform/gtk/fast/borders/border-radius-groove-01-expected.png:
* platform/gtk/fast/borders/border-radius-groove-02-expected.checksum:
* platform/gtk/fast/borders/border-radius-groove-02-expected.png:
* platform/gtk/fast/borders/border-radius-groove-03-expected.checksum:
* platform/gtk/fast/borders/border-radius-groove-03-expected.png:
* platform/gtk/fast/borders/border-radius-huge-assert-expected.checksum: Added.
* platform/gtk/fast/borders/border-radius-huge-assert-expected.png: Added.
* platform/gtk/fast/borders/border-radius-huge-assert-expected.txt: Added.
* platform/gtk/fast/borders/border-radius-split-inline-expected.checksum: Added.
* platform/gtk/fast/borders/border-radius-split-inline-expected.png: Added.
* platform/gtk/fast/borders/border-radius-split-inline-expected.txt: Added.
* platform/gtk/fast/borders/border-radius-wide-border-01-expected.checksum:
* platform/gtk/fast/borders/border-radius-wide-border-01-expected.png:
* platform/gtk/fast/borders/border-radius-wide-border-02-expected.checksum:
* platform/gtk/fast/borders/border-radius-wide-border-02-expected.png:
* platform/gtk/fast/borders/border-radius-wide-border-03-expected.checksum:
* platform/gtk/fast/borders/border-radius-wide-border-03-expected.png:
* platform/gtk/fast/borders/border-radius-wide-border-04-expected.checksum:
* platform/gtk/fast/borders/border-radius-wide-border-04-expected.png:
* platform/gtk/fast/borders/borderRadiusAllStylesAllCorners-expected.checksum: Added.
* platform/gtk/fast/borders/borderRadiusAllStylesAllCorners-expected.png: Added.
* platform/gtk/fast/borders/borderRadiusAllStylesAllCorners-expected.txt: Added.
* platform/gtk/fast/borders/borderRadiusArcs01-expected.checksum: Added.
* platform/gtk/fast/borders/borderRadiusArcs01-expected.png: Added.
* platform/gtk/fast/borders/borderRadiusArcs01-expected.txt: Added.
* platform/gtk/fast/borders/borderRadiusDashed01-expected.checksum: Added.
* platform/gtk/fast/borders/borderRadiusDashed01-expected.png: Added.
* platform/gtk/fast/borders/borderRadiusDashed01-expected.txt: Added.
* platform/gtk/fast/borders/borderRadiusDashed02-expected.checksum: Added.
* platform/gtk/fast/borders/borderRadiusDashed02-expected.png: Added.
* platform/gtk/fast/borders/borderRadiusDashed02-expected.txt: Added.
* platform/gtk/fast/borders/borderRadiusDashed03-expected.checksum: Added.
* platform/gtk/fast/borders/borderRadiusDashed03-expected.png: Added.
* platform/gtk/fast/borders/borderRadiusDashed03-expected.txt: Added.
* platform/gtk/fast/borders/borderRadiusDashed04-expected.checksum:
* platform/gtk/fast/borders/borderRadiusDashed04-expected.png:
* platform/gtk/fast/borders/borderRadiusDashed05-expected.checksum:
* platform/gtk/fast/borders/borderRadiusDashed05-expected.png:
* platform/gtk/fast/borders/borderRadiusDashed06-expected.checksum:
* platform/gtk/fast/borders/borderRadiusDashed06-expected.png:
* platform/gtk/fast/borders/borderRadiusDotted01-expected.checksum: Added.
* platform/gtk/fast/borders/borderRadiusDotted01-expected.png: Added.
* platform/gtk/fast/borders/borderRadiusDotted01-expected.txt: Added.
* platform/gtk/fast/borders/borderRadiusDotted02-expected.checksum: Added.
* platform/gtk/fast/borders/borderRadiusDotted02-expected.png: Added.
* platform/gtk/fast/borders/borderRadiusDotted02-expected.txt: Added.
* platform/gtk/fast/borders/borderRadiusDotted03-expected.checksum: Added.
* platform/gtk/fast/borders/borderRadiusDotted03-expected.png: Added.
* platform/gtk/fast/borders/borderRadiusDotted03-expected.txt: Added.
* platform/gtk/fast/borders/borderRadiusDotted04-expected.checksum:
* platform/gtk/fast/borders/borderRadiusDotted04-expected.png:
* platform/gtk/fast/borders/borderRadiusDotted05-expected.checksum:
* platform/gtk/fast/borders/borderRadiusDotted05-expected.png:
* platform/gtk/fast/borders/borderRadiusDotted06-expected.checksum:
* platform/gtk/fast/borders/borderRadiusDotted06-expected.png:
* platform/gtk/fast/borders/borderRadiusDouble01-expected.checksum: Added.
* platform/gtk/fast/borders/borderRadiusDouble01-expected.png: Added.
* platform/gtk/fast/borders/borderRadiusDouble01-expected.txt: Added.
* platform/gtk/fast/borders/borderRadiusDouble02-expected.checksum: Added.
* platform/gtk/fast/borders/borderRadiusDouble02-expected.png: Added.
* platform/gtk/fast/borders/borderRadiusDouble02-expected.txt: Added.
* platform/gtk/fast/borders/borderRadiusDouble03-expected.checksum: Added.
* platform/gtk/fast/borders/borderRadiusDouble03-expected.png: Added.
* platform/gtk/fast/borders/borderRadiusDouble03-expected.txt: Added.
* platform/gtk/fast/borders/borderRadiusDouble04-expected.checksum:
* platform/gtk/fast/borders/borderRadiusDouble04-expected.png:
* platform/gtk/fast/borders/borderRadiusDouble05-expected.checksum:
* platform/gtk/fast/borders/borderRadiusDouble05-expected.png:
* platform/gtk/fast/borders/borderRadiusDouble06-expected.checksum:
* platform/gtk/fast/borders/borderRadiusDouble06-expected.png:
* platform/gtk/fast/borders/borderRadiusDouble07-expected.checksum:
* platform/gtk/fast/borders/borderRadiusDouble07-expected.png:
* platform/gtk/fast/borders/borderRadiusDouble08-expected.checksum:
* platform/gtk/fast/borders/borderRadiusDouble08-expected.png:
* platform/gtk/fast/borders/borderRadiusDouble09-expected.checksum:
* platform/gtk/fast/borders/borderRadiusDouble09-expected.png:
* platform/gtk/fast/borders/borderRadiusGroove01-expected.checksum: Added.
* platform/gtk/fast/borders/borderRadiusGroove01-expected.png: Added.
* platform/gtk/fast/borders/borderRadiusGroove01-expected.txt: Added.
* platform/gtk/fast/borders/borderRadiusGroove02-expected.checksum: Added.
* platform/gtk/fast/borders/borderRadiusGroove02-expected.png: Added.
* platform/gtk/fast/borders/borderRadiusGroove02-expected.txt: Added.
* platform/gtk/fast/borders/borderRadiusInset01-expected.checksum: Added.
* platform/gtk/fast/borders/borderRadiusInset01-expected.png: Added.
* platform/gtk/fast/borders/borderRadiusInset01-expected.txt: Added.
* platform/gtk/fast/borders/borderRadiusInvalidColor-expected.checksum: Added.
* platform/gtk/fast/borders/borderRadiusInvalidColor-expected.png: Added.
* platform/gtk/fast/borders/borderRadiusInvalidColor-expected.txt: Added.
* platform/gtk/fast/borders/borderRadiusOutset01-expected.checksum: Added.
* platform/gtk/fast/borders/borderRadiusOutset01-expected.png: Added.
* platform/gtk/fast/borders/borderRadiusOutset01-expected.txt: Added.
* platform/gtk/fast/borders/borderRadiusRidge01-expected.checksum: Added.
* platform/gtk/fast/borders/borderRadiusRidge01-expected.png: Added.
* platform/gtk/fast/borders/borderRadiusRidge01-expected.txt: Added.
* platform/gtk/fast/borders/borderRadiusSolid01-expected.checksum: Added.
* platform/gtk/fast/borders/borderRadiusSolid01-expected.png: Added.
* platform/gtk/fast/borders/borderRadiusSolid01-expected.txt: Added.
* platform/gtk/fast/borders/borderRadiusSolid02-expected.checksum: Added.
* platform/gtk/fast/borders/borderRadiusSolid02-expected.png: Added.
* platform/gtk/fast/borders/borderRadiusSolid02-expected.txt: Added.
* platform/gtk/fast/borders/borderRadiusSolid03-expected.checksum: Added.
* platform/gtk/fast/borders/borderRadiusSolid03-expected.png: Added.
* platform/gtk/fast/borders/borderRadiusSolid03-expected.txt: Added.
* platform/gtk/fast/borders/borderRadiusSolid04-expected.checksum: Added.
* platform/gtk/fast/borders/borderRadiusSolid04-expected.png: Added.
* platform/gtk/fast/borders/borderRadiusSolid04-expected.txt: Added.
* platform/gtk/fast/borders/different-color-borders-expected.checksum:
* platform/gtk/fast/borders/different-color-borders-expected.png:
* platform/gtk/fast/borders/fieldsetBorderRadius-expected.checksum: Added.
* platform/gtk/fast/borders/fieldsetBorderRadius-expected.png: Added.
* platform/gtk/fast/borders/fieldsetBorderRadius-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/fieldsetBorderRadius-expected.txt.
* platform/gtk/fast/borders/inline-mask-overlay-image-expected.checksum: Added.
* platform/gtk/fast/borders/inline-mask-overlay-image-expected.png: Added.
* platform/gtk/fast/borders/inline-mask-overlay-image-expected.txt: Added.
* platform/gtk/fast/borders/outline-offset-min-assert-expected.checksum: Added.
* platform/gtk/fast/borders/outline-offset-min-assert-expected.png: Added.
* platform/gtk/fast/borders/outline-offset-min-assert-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/outline-offset-min-assert-expected.txt.
* platform/gtk/fast/borders/svg-as-border-image-2-expected.checksum: Added.
* platform/gtk/fast/borders/svg-as-border-image-2-expected.png: Added.
* platform/gtk/fast/borders/svg-as-border-image-2-expected.txt: Added.
* platform/gtk/fast/borders/svg-as-border-image-expected.checksum: Added.
* platform/gtk/fast/borders/svg-as-border-image-expected.png: Added.
* platform/gtk/fast/borders/svg-as-border-image-expected.txt: Added.
2010-09-07 Martin Robinson <mrobinson@igalia.com>
Reviewed by Dirk Schulze.
[Cairo] Actually use the antialias parameter of GraphicsContext::clipConvexPolygon
https://bugs.webkit.org/show_bug.cgi?id=45355
r63864 added an additional boolean parameter to GraphicsContext::clipConvexPolygon,
which determines whether or not to render the render the clip with anti-aliasing
or not. The Cairo implementation now uses that parameter to determine the argument
to pass to cairo_set_antialias(...) when clipping.
Test: This is tested by many tests in fast/borders.
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::clipConvexPolygon): Actually use the boolean antialias parameter.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66983
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Wed, 8 Sep 2010 14:39:43 +0000 (14:39 +0000)]
2010-09-08 Martin Robinson <mrobinson@igalia.com>
Rebaseline mathml/presentation/attributes.xhtml.
* platform/gtk/mathml/presentation/attributes-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66982
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 8 Sep 2010 14:37:42 +0000 (14:37 +0000)]
Would like WKBundleFrameRef to turn into WKFrameRef across postMessage boundary, a la PageRef
<rdar://problem/
8402804>
https://bugs.webkit.org/show_bug.cgi?id=45370
Reviewed by Jon Honeycutt.
* UIProcess/WebContextUserMessageCoders.h:
(WebKit::WebContextUserMessageEncoder::encode):
(WebKit::WebContextUserMessageDecoder::decode):
* WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:
(WebKit::InjectedBundleUserMessageEncoder::encode):
(WebKit::InjectedBundleUserMessageDecoder::decode):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66981
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 8 Sep 2010 14:28:22 +0000 (14:28 +0000)]
2010-09-08 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Support to enable HTML5's Video based on gstreamer in WebKit-EFL
https://bugs.webkit.org/show_bug.cgi?id=44098
To support video of HTML5 based on gstreamer, add cmake files for gstreamer.
* cmake/FindGStreamer-App.cmake: Added.
* cmake/FindGStreamer-Base.cmake: Added.
* cmake/FindGStreamer-Interfaces.cmake: Added.
* cmake/FindGStreamer-Pbutils.cmake: Added.
* cmake/FindGStreamer-Plugins-Base.cmake: Added.
* cmake/FindGStreamer-Video.cmake: Added.
* cmake/FindGStreamer.cmake: Added.
* cmake/OptionsEfl.cmake:
2010-09-08 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Support to enable HTML5's Video based on gstreamer in WebKit-EFL
https://bugs.webkit.org/show_bug.cgi?id=44098
To support video of HTML5 based on gstreamer, add files regarding gstreamer to
CMakeListsEfl.txt.
* CMakeListsEfl.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66980
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 8 Sep 2010 14:07:01 +0000 (14:07 +0000)]
2010-09-08 Jan E Hanssen <jhanssen@sencha.com>
Reviewed by Dirk Schulze.
Add a test for getting a point beyond the length of the path
https://bugs.webkit.org/show_bug.cgi?id=43837
* svg/dom/path-pointAtLength-expected.txt:
* svg/dom/script-tests/path-pointAtLength.js:
2010-09-08 Jan E Hanssen <jhanssen@sencha.com>
Reviewed by Dirk Schulze.
[Qt] PathQt should use the QPainterPath functionality for calculations
https://bugs.webkit.org/show_bug.cgi?id=43837
Change PathQt to use the built-in functionality of QPainterPath for
calculating length(), pointAtLength() and normalAngleAtLength().
* platform/graphics/Path.cpp:
* platform/graphics/qt/PathQt.cpp:
(WebCore::Path::length):
(WebCore::Path::pointAtLength):
(WebCore::Path::normalAngleAtLength):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66979
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 8 Sep 2010 13:46:16 +0000 (13:46 +0000)]
2010-09-08 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Dirk Schulze.
[WML] Remove create() function in WMLTaskElement because of build break.
https://bugs.webkit.org/show_bug.cgi?id=44954
Remove create() function in WMLTaskElement.cpp because of build breaks.
* wml/WMLTaskElement.cpp:
* wml/WMLTaskElement.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66978
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 8 Sep 2010 13:27:44 +0000 (13:27 +0000)]
2010-09-08 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Dirk Schulze.
[WML] Add create functions to WML.
https://bugs.webkit.org/show_bug.cgi?id=44950
There are missing definitions of create function in WML area.
So, there are build breaks when enabling WML. The create functions and the construction
are added. In addition, a style error and duplicated adoptRef usage are fixed.
* wml/WMLDocument.h:
(WebCore::WMLDocument::create):
* wml/WMLFormControlElement.h:
* wml/WMLIntrinsicEvent.cpp:
(WebCore::WMLIntrinsicEvent::WMLIntrinsicEvent):
* wml/WMLIntrinsicEvent.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66977
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hans@chromium.org [Wed, 8 Sep 2010 13:16:48 +0000 (13:16 +0000)]
2010-09-08 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
Plug leak in WebDeviceOrientationClientMock
https://bugs.webkit.org/show_bug.cgi?id=45305
WebDeviceOrientationClientMock is responsible for destroying the
WebDeviceOrientationController object pointed to by the argument
passed to the setController() member function.
Also use the new WebPrivateOnwPtr for m_clientMock.
* public/WebDeviceOrientationClientMock.h:
* src/WebDeviceOrientationClientMock.cpp:
(WebKit::WebDeviceOrientationClientMock::setController):
(WebKit::WebDeviceOrientationClientMock::initialize):
(WebKit::WebDeviceOrientationClientMock::reset):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66976
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thakis@chromium.org [Wed, 8 Sep 2010 13:02:16 +0000 (13:02 +0000)]
2010-09-08 Nico Weber <thakis@chromium.org>
Reviewed by Kenneth Russell.
chromium/mac: Fix crash with compositor due to missing current NSGraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=45354
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::updateContents): Set a current local context.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66975
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yael.aharon@nokia.com [Wed, 8 Sep 2010 12:38:02 +0000 (12:38 +0000)]
2010-09-08 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Antonio Gomes.
Missing EOL in expected test results
https://bugs.webkit.org/show_bug.cgi?id=45352
Add the missing EOL.
* fast/notifications/notifications-click-event-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66974
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jschuh@chromium.org [Wed, 8 Sep 2010 12:08:46 +0000 (12:08 +0000)]
2010-09-08 Justin Schuh <jschuh@chromium.org>
Reviewed by Nikolas Zimmermann.
NULL deref when use target is reset, then set to display:none
https://bugs.webkit.org/show_bug.cgi?id=45345
* svg/custom/use-display-none-expected.txt: Added.
* svg/custom/use-display-none.svg: Added.
2010-09-08 Justin Schuh <jschuh@chromium.org>
Reviewed by Nikolas Zimmermann.
NULL deref when use target is reset, then set to display:none
https://bugs.webkit.org/show_bug.cgi?id=45345
Move the NULL check on shadowRoot earlier in SVGUseElement::recalcStyle
Test: svg/custom/use-display-none.svg
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::recalcStyle):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66973
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 8 Sep 2010 11:34:58 +0000 (11:34 +0000)]
2010-09-08 Csaba Osztrogonác <ossy@webkit.org>
Reviewed by Andreas Kling.
[Qt] Treat warnings as errors by default for gcc
https://bugs.webkit.org/show_bug.cgi?id=43191
* WebKit.pri: -Werror added to QMAKE_CXXFLAGS for x86 Linux platforms
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66972
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
satish@chromium.org [Wed, 8 Sep 2010 11:33:03 +0000 (11:33 +0000)]
Adding myself to committers list.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66971
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hans@chromium.org [Wed, 8 Sep 2010 11:25:01 +0000 (11:25 +0000)]
2010-09-08 Hans Wennborg <hans@chromium.org>
Unreviewed.
Adding myself as a committer in committers.py.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66970
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zoltan@webkit.org [Wed, 8 Sep 2010 11:18:46 +0000 (11:18 +0000)]
[Qt] Refactor MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=45173
Reviewed by Simon Hausmann.
Split BrowserWindow into two source files and headers. Remove unnecessary header includes.
* MiniBrowser/qt/BrowserView.cpp: Added.
(createNewPage):
(BrowserView::BrowserView):
(BrowserView::resizeEvent):
(BrowserView::load):
(BrowserView::view):
* MiniBrowser/qt/BrowserView.h: Added.
(BrowserView::~BrowserView):
* MiniBrowser/qt/BrowserWindow.cpp:
* MiniBrowser/qt/BrowserWindow.h:
* MiniBrowser/qt/MiniBrowser.pro:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66969
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Wed, 8 Sep 2010 11:08:08 +0000 (11:08 +0000)]
2010-08-30 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin Adler.
Handle MediaQueryExp memory management exclusively with smart pointers
https://bugs.webkit.org/show_bug.cgi?id=44874
Implemented a non-copying sort function to make it possible to sort a Vector
of OwnPtrs (which cannot be copied). This is required for the above.
* wtf/NonCopyingSort.h: Added.
(WTF::nonCopyingSort): It's secretly heapsort.
(WTF::heapSort): heapsort implementation.
(WTF::siftDown): Helper function for heapsort.
(WTF::heapify): ditto
Adjust build systems.
* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
2010-08-30 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin Adler.
Handle MediaQueryExp memory management exclusively with smart pointers
https://bugs.webkit.org/show_bug.cgi?id=44874
Gace MediaQueryExp a create function, made the constructor private, and followed
the implications. The one tricky bit was using a non-copying sort to sort
the Vector<OwnPtr<MediaQueryExp> > in the MediaQuery constructor.
* ForwardingHeaders/wtf/NonCopyingSort.h: Added.
* css/CSSGrammar.y:
* css/CSSParser.cpp:
(WebCore::CSSParser::~CSSParser):
(WebCore::CSSParser::createFloatingMediaQueryExp):
(WebCore::CSSParser::createFloatingMediaQueryExpList):
(WebCore::CSSParser::sinkFloatingMediaQueryExpList):
(WebCore::CSSParser::createFloatingMediaQuery):
* css/CSSParser.h:
* css/MediaList.cpp:
* css/MediaQuery.cpp:
(WebCore::expressionCompare):
(WebCore::MediaQuery::MediaQuery):
(WebCore::MediaQuery::~MediaQuery):
* css/MediaQuery.h:
(WebCore::MediaQuery::expressions):
* css/MediaQueryEvaluator.cpp:
(WebCore::MediaQueryEvaluator::eval):
* css/MediaQueryExp.h:
(WebCore::MediaQueryExp::create):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66968
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 8 Sep 2010 11:01:26 +0000 (11:01 +0000)]
2010-09-08 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
Remove unused member variable from DecodedDocumentParser
https://bugs.webkit.org/show_bug.cgi?id=45379
This member variable isn't used because of the recent split of
TextDocumentParser and TextViewSourceParser.
* dom/DecodedDataDocumentParser.cpp:
(WebCore::DecodedDataDocumentParser::DecodedDataDocumentParser):
* dom/DecodedDataDocumentParser.h:
* dom/ScriptableDocumentParser.cpp:
(WebCore::ScriptableDocumentParser::ScriptableDocumentParser):
* dom/ScriptableDocumentParser.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66967
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 8 Sep 2010 10:58:58 +0000 (10:58 +0000)]
2010-09-08 Adam Barth <abarth@webkit.org>
Attempted Window build fix.
* WebDataSource.cpp:
(WebDataSource::subresourceForURL):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66966
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 8 Sep 2010 10:48:38 +0000 (10:48 +0000)]
2010-09-08 Csaba Osztrogonác <ossy@webkit.org>
Reviewed by Andreas Kling.
Fix warning in rendering/RenderBlock.cpp.
https://bugs.webkit.org/show_bug.cgi?id=45373
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::hitTestColumns): Suggested parentheses added around && within ||
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66965
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 8 Sep 2010 10:29:00 +0000 (10:29 +0000)]
2010-09-08 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[Gtk] A list item's number/bullet should not be a child of that list item
https://bugs.webkit.org/show_bug.cgi?id=45190
Ignore list markers and prefix them to the text for the item
* accessibility/gtk/AccessibilityObjectAtk.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
Make list markers ignore accessibility for the GTK port.
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(webkit_accessible_text_get_text): Prefix the text of a marker
along with the accessible text for its list item's AtkObject
2010-09-08 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[Gtk] A list item's number/bullet should not be a child of that list item
https://bugs.webkit.org/show_bug.cgi?id=45190
New unit test added.
* tests/testatk.c:
(testWebkitAtkListsOfItems): New test to check ordered/unordered
list of items are properly exposed to AT technologies.
(main):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66964
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 8 Sep 2010 10:26:02 +0000 (10:26 +0000)]
2010-09-08 Adam Barth <abarth@webkit.org>
Rubber-stamped by Eric Seidel.
Rename DocLoader to CachedResourceLoader because that's what it does.
* WebDataSource.cpp:
2010-09-08 Adam Barth <abarth@webkit.org>
Rubber-stamped by Eric Seidel.
Rename DocLoader to CachedResourceLoader because that's what it does.
* WebView/WebFrame.mm:
2010-09-08 Adam Barth <abarth@webkit.org>
Rubber-stamped by Eric Seidel.
Rename DocLoader to CachedResourceLoader because that's what it does.
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSCursorImageValue.cpp:
(WebCore::CSSCursorImageValue::cachedImage):
* css/CSSCursorImageValue.h:
* css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData):
* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::cachedResourceLoader):
(WebCore::CSSFontSelector::addFontFaceRule):
* css/CSSFontSelector.h:
* css/CSSImageValue.cpp:
(WebCore::CSSImageValue::cachedImage):
* css/CSSImageValue.h:
* css/CSSImportRule.cpp:
(WebCore::CSSImportRule::insertedIntoParent):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::loadPendingImages):
* css/CSSStyleSheet.h:
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::implicitClose):
* dom/Document.h:
(WebCore::Document::cachedResourceLoader):
* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::checkStyleSheet):
* dom/ScriptElement.cpp:
(WebCore::ScriptElementData::requestScript):
* dom/XMLDocumentParser.cpp:
* dom/XMLDocumentParser.h:
* dom/XMLDocumentParserLibxml2.cpp:
(WebCore::matchFunc):
(WebCore::shouldAllowExternalLoad):
(WebCore::openFunc):
(WebCore::XMLDocumentParser::doWrite):
(WebCore::XMLDocumentParser::endElementNs):
(WebCore::XMLDocumentParser::initializeParserContext):
(WebCore::XMLDocumentParser::doEnd):
(WebCore::xmlDocPtrForString):
* dom/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::parseEndElement):
* dom/XMLDocumentParserScope.cpp:
(WebCore::XMLDocumentParserScope::XMLDocumentParserScope):
(WebCore::XMLDocumentParserScope::~XMLDocumentParserScope):
* dom/XMLDocumentParserScope.h:
* editing/Editor.cpp:
(WebCore::Editor::paste):
* editing/mac/EditorMac.mm:
(WebCore::Editor::paste):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::process):
* html/parser/CSSPreloadScanner.cpp:
(WebCore::CSSPreloadScanner::emitRule):
* html/parser/HTMLPreloadScanner.cpp:
(WebCore::HTMLNames::PreloadTask::preload):
* html/parser/HTMLScriptRunner.cpp:
(WebCore::HTMLScriptRunner::requestPendingScript):
* inspector/InspectorResource.cpp:
(WebCore::InspectorResource::cachedResource):
* loader/Cache.cpp:
(WebCore::Cache::requestResource):
(WebCore::Cache::requestUserCSSStyleSheet):
(WebCore::Cache::revalidateResource):
(WebCore::Cache::addCachedResourceLoader):
(WebCore::Cache::removeCachedResourceLoader):
* loader/Cache.h:
* loader/CachedCSSStyleSheet.h:
* loader/CachedFont.cpp:
(WebCore::CachedFont::load):
(WebCore::CachedFont::beginLoadIfNeeded):
* loader/CachedFont.h:
* loader/CachedImage.cpp:
(WebCore::CachedImage::load):
(WebCore::CachedImage::maximumDecodedImageSize):
* loader/CachedImage.h:
* loader/CachedResource.cpp:
(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::~CachedResource):
(WebCore::CachedResource::load):
* loader/CachedResource.h:
(WebCore::CachedResource::load):
(WebCore::CachedResource::setCachedResourceLoader):
* loader/CachedResourceLoader.cpp: Copied from WebCore/loader/DocLoader.cpp.
(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::~CachedResourceLoader):
(WebCore::CachedResourceLoader::frame):
(WebCore::CachedResourceLoader::checkForReload):
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::requestFont):
(WebCore::CachedResourceLoader::requestCSSStyleSheet):
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
(WebCore::CachedResourceLoader::requestScript):
(WebCore::CachedResourceLoader::requestXSLStyleSheet):
(WebCore::CachedResourceLoader::requestLinkPrefetch):
(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::printAccessDeniedMessage):
(WebCore::CachedResourceLoader::setAutoLoadImages):
(WebCore::CachedResourceLoader::cachePolicy):
(WebCore::CachedResourceLoader::removeCachedResource):
(WebCore::CachedResourceLoader::setLoadInProgress):
(WebCore::CachedResourceLoader::checkCacheObjectStatus):
(WebCore::CachedResourceLoader::incrementRequestCount):
(WebCore::CachedResourceLoader::decrementRequestCount):
(WebCore::CachedResourceLoader::requestCount):
(WebCore::CachedResourceLoader::preload):
(WebCore::CachedResourceLoader::checkForPendingPreloads):
(WebCore::CachedResourceLoader::requestPreload):
(WebCore::CachedResourceLoader::clearPreloads):
(WebCore::CachedResourceLoader::clearPendingPreloads):
(WebCore::CachedResourceLoader::printPreloadStats):
* loader/CachedResourceLoader.h: Copied from WebCore/loader/DocLoader.h.
* loader/CachedScript.h:
* loader/CachedXSLStyleSheet.h:
* loader/DocLoader.cpp: Removed.
* loader/DocLoader.h: Removed.
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::isLoadingInAPISense):
(WebCore::DocumentLoader::subresource):
(WebCore::DocumentLoader::getSubresources):
* loader/FrameLoader.cpp:
(WebCore::numRequests):
(WebCore::FrameLoader::stopLoading):
(WebCore::FrameLoader::didBeginDocument):
* loader/HistoryController.cpp:
(WebCore::HistoryController::createItem):
* loader/ImageLoader.cpp:
(WebCore::ImageLoader::updateFromElement):
* loader/Request.cpp:
(WebCore::Request::Request):
* loader/Request.h:
(WebCore::Request::cachedResourceLoader):
* loader/loader.cpp:
(WebCore::Loader::load):
(WebCore::Loader::cancelRequests):
(WebCore::Loader::Host::servePendingRequests):
(WebCore::Loader::Host::didFinishLoading):
(WebCore::Loader::Host::didFail):
(WebCore::Loader::Host::didReceiveResponse):
(WebCore::Loader::Host::cancelPendingRequests):
(WebCore::Loader::Host::cancelRequests):
* loader/loader.h:
* page/DragController.cpp:
(WebCore::DragController::concludeEditDrag):
* page/Frame.cpp:
* page/FrameView.cpp:
(WebCore::FrameView::checkStopDelayingDeferredRepaints):
(WebCore::FrameView::updateDeferredRepaintDelay):
* page/Settings.cpp:
(WebCore::setLoadsImagesAutomaticallyInAllFrames):
* platform/android/TemporaryLinkStubs.cpp:
(WebCore::CheckCacheObjectStatus):
* platform/network/android/ResourceHandleAndroid.cpp:
(WebCore::ResourceHandle::start):
* platform/network/cf/ResourceHandleCFNet.cpp:
* platform/network/curl/ResourceHandleCurl.cpp:
* platform/network/mac/ResourceHandleMac.mm:
* platform/network/qt/ResourceHandleQt.cpp:
* platform/network/soup/ResourceHandleSoup.cpp:
* platform/network/win/ResourceHandleWin.cpp:
* svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::requestImageResource):
* svg/SVGFontFaceUriElement.cpp:
(WebCore::SVGFontFaceUriElement::loadFont):
* workers/Worker.cpp:
* xml/XSLImportRule.cpp:
(WebCore::XSLImportRule::loadSheet):
* xml/XSLStyleSheet.h:
* xml/XSLStyleSheetLibxslt.cpp:
(WebCore::XSLStyleSheet::cachedResourceLoader):
(WebCore::XSLStyleSheet::parseString):
* xml/XSLStyleSheetQt.cpp:
(WebCore::XSLStyleSheet::cachedResourceLoader):
* xml/XSLTProcessor.cpp:
* xml/XSLTProcessorLibxslt.cpp:
(WebCore::docLoaderFunc):
(WebCore::setXSLTLoadCallBack):
(WebCore::xmlDocPtrFromNode):
(WebCore::XSLTProcessor::transformToString):
2010-09-08 Adam Barth <abarth@webkit.org>
Rubber-stamped by Eric Seidel.
Rename DocLoader to CachedResourceLoader because that's what it does.
* Scripts/do-webcore-rename:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66963
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zherczeg@webkit.org [Wed, 8 Sep 2010 09:59:24 +0000 (09:59 +0000)]
Refactoring multiline comments in the lexer
https://bugs.webkit.org/show_bug.cgi?id=45289
Reviewed by Darin Adler.
MultiLine comment parsing is moved to a separate function.
Slight performance increase on --parse-only tests (from 33.6ms to 32.8ms)
SunSpider reports no change (from 523.1ms to 521.2ms).
* parser/Lexer.cpp:
(JSC::Lexer::parseMultilineComment):
(JSC::Lexer::lex):
* parser/Lexer.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66962
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Wed, 8 Sep 2010 09:18:27 +0000 (09:18 +0000)]
Add mediaPlayerPlaybackStateChanged to MediaPlayerClient
Reviewed by Eric Carlson.
https://bugs.webkit.org/show_bug.cgi?id=45263
The platform backend may change state, for example as a result
of an external plugin controlling the backend, so we need to
react to this situation by syncing up the WebCore state with the
platform backend.
We call playInternal()/pauseInternal() depending on the backend
state, to trigger the corresponding DOM events to match the state.
updatePlayState() is then refactored to take into account the
situation where the backend is already in the correct state but
WebCore is not, so that we update the playback progress timer
and set m_playing correctly.
updatePlayState() changes Should be covered by existing tests.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerPlaybackStateChanged):
(WebCore::HTMLMediaElement::updatePlayState):
* html/HTMLMediaElement.h:
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::playbackStateChanged):
* platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerPlaybackStateChanged):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66961
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 8 Sep 2010 09:06:58 +0000 (09:06 +0000)]
2010-09-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
TextDocument doesn't belong in WebCore/loader
https://bugs.webkit.org/show_bug.cgi?id=45346
TextDocument has nothing to do with loading. It turns out that it
should be in WebCore/html because TextDocument is actually a subclass
of HTMLDocument (in quirks mode, no less).
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* html/TextDocument.cpp: Renamed from WebCore/loader/TextDocument.cpp.
(WebCore::TextDocument::TextDocument):
(WebCore::TextDocument::createParser):
* html/TextDocument.h: Renamed from WebCore/loader/TextDocument.h.
(WebCore::TextDocument::create):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66960
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 8 Sep 2010 09:04:17 +0000 (09:04 +0000)]
2010-09-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Create TextViewSourceParser
https://bugs.webkit.org/show_bug.cgi?id=45343
Rather than have the view source document set a flag on
HTMLViewSourceParser to indicate whether we're parsing a text document,
this patch creates a TextViewSourceParser for parsing text documents in
view-source mode. Like the TextDocumentParser, the
TextViewSourceParser implements this functionality by subclassing its
HTML counterpart.
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* html/HTMLViewSourceDocument.cpp:
(WebCore::HTMLViewSourceDocument::createParser):
* html/parser/HTMLViewSourceParser.cpp:
* html/parser/HTMLViewSourceParser.h:
(WebCore::HTMLViewSourceParser::tokenizer):
* html/parser/TextViewSourceParser.cpp: Added.
(WebCore::TextViewSourceParser::TextViewSourceParser):
(WebCore::TextViewSourceParser::~TextViewSourceParser):
* html/parser/TextViewSourceParser.h: Added.
(WebCore::TextViewSourceParser::create):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66959
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 8 Sep 2010 08:59:44 +0000 (08:59 +0000)]
2010-09-08 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Move HTMLInputStream to WebCore/html/parser
https://bugs.webkit.org/show_bug.cgi?id=45339
I forgot to move this file before.
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* html/parser/HTMLInputStream.h: Renamed from WebCore/html/HTMLInputStream.h.
(WebCore::HTMLInputStream::HTMLInputStream):
(WebCore::HTMLInputStream::appendToEnd):
(WebCore::HTMLInputStream::insertAtCurrentInsertionPoint):
(WebCore::HTMLInputStream::hasInsertionPoint):
(WebCore::HTMLInputStream::markEndOfFile):
(WebCore::HTMLInputStream::haveSeenEndOfFile):
(WebCore::HTMLInputStream::current):
(WebCore::HTMLInputStream::splitInto):
(WebCore::HTMLInputStream::mergeFrom):
(WebCore::InsertionPointRecord::InsertionPointRecord):
(WebCore::InsertionPointRecord::~InsertionPointRecord):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66958
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 8 Sep 2010 08:52:17 +0000 (08:52 +0000)]
2010-09-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
TextDocument should come in from the cold
https://bugs.webkit.org/show_bug.cgi?id=45334
Previously, TextDocument reinvented the wheel to parse text. This
patch replaces TextDocument's hand-rolled parser with a parser built on
the HTML parser infrustructure, which gives us that stuff for free. I
also disentangled TextDocument from HTMLViewSourceDocument.
In a future patch, I'll move TextDocument out of the "loader" directory.
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* html/HTMLViewSourceDocument.cpp:
(WebCore::HTMLViewSourceDocument::createParser):
* html/HTMLViewSourceDocument.h:
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::constructTreeFromToken):
(WebCore::HTMLTreeBuilder::constructTreeFromAtomicToken):
* html/parser/HTMLTreeBuilder.h:
* html/parser/HTMLViewSourceParser.cpp:
(WebCore::HTMLViewSourceParser::forcePlaintext):
* html/parser/HTMLViewSourceParser.h:
* html/parser/TextDocumentParser.cpp: Added.
(WebCore::TextDocumentParser::TextDocumentParser):
(WebCore::TextDocumentParser::~TextDocumentParser):
(WebCore::TextDocumentParser::insertFakePreElement):
* html/parser/TextDocumentParser.h: Added.
(WebCore::TextDocumentParser::create):
* loader/TextDocument.cpp:
* loader/TextDocument.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66957
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Wed, 8 Sep 2010 08:32:11 +0000 (08:32 +0000)]
Implement MediaPlayerPrivate::platformMedia() for the Qt port
Reviewed by Andreas Kling.
https://bugs.webkit.org/show_bug.cgi?id=45264
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66956
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zherczeg@webkit.org [Wed, 8 Sep 2010 07:23:17 +0000 (07:23 +0000)]
An individual renderer should be assigned to each SVGFE*Element class
https://bugs.webkit.org/show_bug.cgi?id=43954
Reviewed by Dirk Schulze.
WebCore:
RenderSVGResourceFilterPrimitive renderer is added to
the project, and assigned to each object, which class is
derived from SVGFilterPrimitiveStandardAttributes. The patch
mainly contains build system changes, and it fixes one layout
test in svg/dynamic-updates.
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* rendering/RenderObject.h:
(WebCore::RenderObject::isSVGResourceFilterPrimitive):
* rendering/RenderSVGResourceFilterPrimitive.cpp: Added.
(WebCore::RenderSVGResourceFilterPrimitive::RenderSVGResourceFilterPrimitive):
* rendering/RenderSVGResourceFilterPrimitive.h: Added.
(WebCore::RenderSVGResourceFilterPrimitive::isSVGResourceFilterPrimitive):
* rendering/SVGRenderTreeAsText.cpp:
(WebCore::writeSVGContainer):
* svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::svgAttributeChanged):
* svg/SVGFELightElement.cpp:
(WebCore::SVGFELightElement::svgAttributeChanged):
(WebCore::SVGFELightElement::childrenChanged):
* svg/SVGFEOffsetElement.cpp:
(WebCore::SVGFEOffsetElement::svgAttributeChanged):
* svg/SVGFilterElement.h:
* svg/SVGFilterPrimitiveStandardAttributes.cpp:
(WebCore::SVGFilterPrimitiveStandardAttributes::svgAttributeChanged):
(WebCore::SVGFilterPrimitiveStandardAttributes::childrenChanged):
(WebCore::SVGFilterPrimitiveStandardAttributes::createRenderer):
* svg/SVGFilterPrimitiveStandardAttributes.h:
(WebCore::SVGFilterPrimitiveStandardAttributes::invalidate):
LayoutTests:
The layout test below is fixed by this patch.
* platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.checksum:
* platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66955
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 8 Sep 2010 05:56:00 +0000 (05:56 +0000)]
DatasetDOMStringMap does not have the right memory model
https://bugs.webkit.org/show_bug.cgi?id=45358
Reviewed by Dan Bernstein.
WebCore:
Test: fast/dom/dataset-gc.html
* bindings/js/JSElementCustom.cpp:
(WebCore::JSElement::markChildren):
Mark the dataset if it exists.
* dom/Element.cpp:
(WebCore::Element::optionalDataset):
* dom/Element.h:
Expose a way to get the dataset or null (depending on if anyone thing
has forced its creation yet).
LayoutTests:
Test that the dataset persists gc.
* fast/dom/dataset-gc-expected.txt: Added.
* fast/dom/dataset-gc.html: Added.
* fast/dom/script-tests/dataset-gc.js: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66954
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kinuko@chromium.org [Wed, 8 Sep 2010 05:54:36 +0000 (05:54 +0000)]
2010-09-07 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Ojan Vafai.
Enable incremental results.json generation for non-layout tests.
https://bugs.webkit.org/show_bug.cgi?id=45315
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Enable generate_incremental_results=True by default. (This still keeps to generate results.json.) Also add a code to upload results json files to the app-engine server. Need a chromium change to actually start the uploading.
* TestResultServer/model/jsonresults.py: Make sure we save the file with test_type for incremental cases too.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66953
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Wed, 8 Sep 2010 05:30:56 +0000 (05:30 +0000)]
Versioning.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66952
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kinuko@chromium.org [Wed, 8 Sep 2010 04:58:34 +0000 (04:58 +0000)]
2010-09-07 Kinuko Yasuda <kinuko@chromium.org>
Unreviewed, another Qt release build fix attempt.
* UIProcess/API/cpp/qt/WKURLQt.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66950
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kinuko@chromium.org [Wed, 8 Sep 2010 04:52:16 +0000 (04:52 +0000)]
2010-09-07 Kinuko Yasuda <kinuko@chromium.org>
Unreviewed, attempt to fix Qt release build.
* UIProcess/API/cpp/qt/WKStringQt.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66949
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 8 Sep 2010 04:02:55 +0000 (04:02 +0000)]
2010-09-07 Jan E Hanssen <jhanssen@sencha.com>
Reviewed by Andreas Kling.
[Qt] Added test case for Path::length()
https://bugs.webkit.org/show_bug.cgi?id=45331
Also removed test case for Path::pointAtLength() that is now passing
* platform/qt/svg/dom/path-pointAtLength-expected.txt: Removed.
* svg/dom/path-totalLength-expected.txt: Added.
* svg/dom/path-totalLength.html: Added.
* svg/dom/script-tests/path-totalLength.js: Added.
(getTotalLength):
2010-09-07 Jan E Hanssen <jhanssen@sencha.com>
Reviewed by Andreas Kling.
[Qt] Add a separate Path::closeCanvasSubpath() function for canvas paths
https://bugs.webkit.org/show_bug.cgi?id=45331
This is needed due to an adverse effect of the fix in 44061 that causes
certain paths not to be closed. This is not important for canvas paths
but it is for SVG paths, so splitting up the code in a generic (SVG)
case and one specialized for canvas.
Test: svg/dom/path-totalLength.html
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::closePath):
* platform/graphics/Path.h:
(WebCore::Path::closeCanvasSubpath):
* platform/graphics/qt/PathQt.cpp:
(WebCore::Path::closeSubpath):
(WebCore::Path::closeCanvasSubpath):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66948
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Wed, 8 Sep 2010 03:01:14 +0000 (03:01 +0000)]
2010-09-07 Dirk Pranke <dpranke@chromium.org>
Unreviewed, build fix
Missed one test in mac_unittest.py in previous change; for some
reason the method is listed twice. I will fix both for now, but will
figure this out in a later, not-time-sensitive patch.
https://bugs.webkit.org/show_bug.cgi?id=45357
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66947
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Wed, 8 Sep 2010 02:56:45 +0000 (02:56 +0000)]
2010-09-07 Kent Tamura <tkent@chromium.org>
Reviewed by Tony Chang.
test-webkitpy: Fix load error of
webkitpy/layout_tests/port/factory_unittest.py on Win32 Python
https://bugs.webkit.org/show_bug.cgi?id=45356 Need a short
* Scripts/webkitpy/layout_tests/port/server_process.py:
Avoid to import fcntl on win32. Win32 Python doesn't have fcntl
and we don't use server_process.py on Win32 Python. However
unittest.py tries to load everything in a module.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66946
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Wed, 8 Sep 2010 02:23:16 +0000 (02:23 +0000)]
2010-09-07 Dirk Pranke <dpranke@chromium.org>
Reviewed by Kent Tamura.
Fix regression introduced in previous change to new-run-webkit-tests
(bug 45090) to not try to run unittests for the Mac implementation
of the Port interface if we aren't running on a Mac.
Also fix the overrides implementation mock in the chromium unittests
to fix the case where there are overrides checked in that cause
problems.
https://bugs.webkit.org/show_bug.cgi?id=45357
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66945
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Wed, 8 Sep 2010 01:26:37 +0000 (01:26 +0000)]
2010-09-07 Ojan Vafai <ojan@chromium.org>
Reviewed by Kent Tamura.
Markup.waitUntilDone does not call Markup.noAutoDump without LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=45123
* resources/dump-as-markup.js:
(Markup.waitUntilDone):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66944
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Wed, 8 Sep 2010 01:15:07 +0000 (01:15 +0000)]
2010-09-07 James Robinson <jamesr@chromium.org>
Compile fix attempt for windows.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66943
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Wed, 8 Sep 2010 01:10:02 +0000 (01:10 +0000)]
2010-09-07 Simon Fraser <simon.fraser@apple.com>
Reviewed by Chris Marrin.
Transform animations always run in software now
https://bugs.webkit.org/show_bug.cgi?id=45341
After r66339 we always fell into software animation, because we
failed to detect transform or opacity properties in the keyframes,
so would send an empty list of values to the GraphicsLayer.
Fixed by using CSSProperty values, rather than GraphicsLayer
values, when detecting the presence of properties in the keyframes.
Test: manual-tests/transition-accelerated.html
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::startAnimation):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66942
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
crogers@google.com [Wed, 8 Sep 2010 01:02:49 +0000 (01:02 +0000)]
2010-09-07 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
audio engine: add FFTFrame files
https://bugs.webkit.org/show_bug.cgi?id=34827
No new tests since audio API is not yet implemented.
* platform/audio/FFTFrame.cpp: Added.
(WebCore::FFTFrame::doPaddedFFT):
(WebCore::FFTFrame::createInterpolatedFrame):
(WebCore::FFTFrame::interpolateFrequencyComponents):
(WebCore::FFTFrame::extractAverageGroupDelay):
(WebCore::FFTFrame::addConstantGroupDelay):
(WebCore::FFTFrame::print):
* platform/audio/FFTFrame.h: Added.
(WebCore::FFTFrame::fftSize):
(WebCore::FFTFrame::log2FFTSize):
(WebCore::FFTFrame::dspSplitComplex):
* platform/audio/mac/FFTFrameMac.cpp: Added.
(WebCore::FFTFrame::FFTFrame):
(WebCore::FFTFrame::~FFTFrame):
(WebCore::FFTFrame::multiply):
(WebCore::FFTFrame::doFFT):
(WebCore::FFTFrame::doInverseFFT):
(WebCore::FFTFrame::fftSetupForSize):
(WebCore::FFTFrame::cleanup):
(WebCore::FFTFrame::realData):
(WebCore::FFTFrame::imagData):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66941
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Wed, 8 Sep 2010 00:54:04 +0000 (00:54 +0000)]
2010-09-07 Mihai Parparita <mihaip@chromium.org>
Reviewed by James Robinson.
Fix Windows build after r66936
https://bugs.webkit.org/show_bug.cgi?id=45348
Add symbol names that were missing from r66936.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66940
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Wed, 8 Sep 2010 00:50:05 +0000 (00:50 +0000)]
WebCore: Build fix, no review.
Provide stubs to allow WebKit.dll to build
for the WinCairo port.
* platform/network/curl/ResourceRequest.h:
(WebCore::ResourceRequest::ResourceRequest):
* platform/network/curl/ResourceResponse.h:
(WebCore::ResourceResponse::cfURLResponse):
WebKit2: Build correction, no review.
* win/WebKit2.vcproj: Disable two unused files for
the WinCairo target.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66939
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
crogers@google.com [Wed, 8 Sep 2010 00:48:23 +0000 (00:48 +0000)]
2010-09-07 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Add AudioArray.h
https://bugs.webkit.org/show_bug.cgi?id=45204
No new tests since audio API is not yet implemented.
* platform/audio/AudioArray.h: Added.
(WebCore::AudioArray::AudioArray):
(WebCore::AudioArray::zero):
(WebCore::AudioArray::zeroRange):
(WebCore::AudioArray::copyToRange):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66938
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Wed, 8 Sep 2010 00:46:34 +0000 (00:46 +0000)]
2010-09-01 Dirk Pranke <dpranke@chromium.org>
Reviewed by Ojan Vafai.
new-run-webkit-tests: still more unit tests
Clean up and remove unnecessary code. Biggest notable change is
moving the chromium-specific imagediff code from port/base to
port/chromium.
Add more unit tests for run_webkit_tests.py, port/base.py,
port/factory.py, port/dryrun.py, and
layout_package/dump_render_tree_thread.py
This covers almost all of the generic and test code paths except for
a few error paths involving invalid or port-specific command line
arguments, and the code path for uploading results files to the
buildbots.
https://bugs.webkit.org/show_bug.cgi?id=45090
* Scripts/webkitpy/layout_tests/data/failures/expected/hang.html: Added.
* Scripts/webkitpy/layout_tests/data/http/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
* Scripts/webkitpy/layout_tests/data/http/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
* Scripts/webkitpy/layout_tests/data/http/tests/ssl/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
* Scripts/webkitpy/layout_tests/data/http/tests/ssl/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
* Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
* Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
* Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
* Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
* Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Added.
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/port/dryrun.py:
* Scripts/webkitpy/layout_tests/port/factory_unittest.py:
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
* Scripts/webkitpy/layout_tests/port/port_testcase.py: Added.
* Scripts/webkitpy/layout_tests/port/server_process.py:
* Scripts/webkitpy/layout_tests/port/test.py:
* Scripts/webkitpy/layout_tests/port/webkit.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66937
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 8 Sep 2010 00:33:15 +0000 (00:33 +0000)]
2010-09-07 Mihai Parparita <mihaip@chromium.org>
Reviewed by Oliver Hunt.
pushState and replaceState do not clone RegExp objects correctly
https://bugs.webkit.org/show_bug.cgi?id=44718
Move internal representation of JSC::RegExp (which depends on wether
YARR and YARR_JIT is enabled) into RegExpRepresentation which can live
in the implementation only. This makes it feasible to use RegExp in
WebCore without bringing in all of YARR.
* JavaScriptCore.exp: Export RegExp and RegExpObject functions that are
needed inside WebCore's JSC bindings.
* runtime/RegExp.cpp:
(JSC::RegExpRepresentation::~RegExpRepresentation):
(JSC::RegExp::RegExp):
(JSC::RegExp::~RegExp):
(JSC::RegExp::compile):
(JSC::RegExp::match):
* runtime/RegExp.h:
2010-09-07 Mihai Parparita <mihaip@chromium.org>
Reviewed by Oliver Hunt.
pushState and replaceState do not clone RegExp objects correctly
https://bugs.webkit.org/show_bug.cgi?id=44718
Make RegExp test of pushstate-object-types.html actually test a RegExp
value with flags.
Also adds ImageData since it can be serialized as of r54646.
* fast/loader/stateobjects/pushstate-object-types-expected.txt:
* fast/loader/stateobjects/pushstate-object-types.html:
2010-09-07 Mihai Parparita <mihaip@chromium.org>
Reviewed by Oliver Hunt.
pushState and replaceState do not clone RegExp objects correctly
https://bugs.webkit.org/show_bug.cgi?id=44718
Add RegExp support to the JSC implementation of SerializedScriptValue
(it stores the pattern and flags read from a RegExpObject, and creates
a new one on deserialization).
Tests: fast/loader/stateobjects/pushstate-object-types.html
* ForwardingHeaders/runtime/RegExp.h: Added.
* ForwardingHeaders/runtime/RegExpObject.h: Added.
* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneDeserializer::readTerminal):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66936
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 8 Sep 2010 00:32:54 +0000 (00:32 +0000)]
Fix clang++ build.
Reviewed by Oliver Hunt.
* Misc/WebLocalizableStrings.h:
Fix a struct/tag mismatch.
* WebView/WebDeviceOrientationProviderMock.mm:
(-[WebDeviceOrientationProviderMock init]):
Remove stray semicolon.
* WebView/WebViewData.h:
Remove unused class forward declaration.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66935
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbr@google.com [Tue, 7 Sep 2010 23:56:28 +0000 (23:56 +0000)]
2010-09-07 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
Fix OpenGL error reporting in WebGL layout test utilities
https://bugs.webkit.org/show_bug.cgi?id=45336
* fast/canvas/webgl/resources/webgl-test.js:
(getGLErrorAsString):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66934
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 7 Sep 2010 23:51:45 +0000 (23:51 +0000)]
Fix clang++ build.
Reviewed by Sam Weinig.
* UIProcess/API/C/WKAPICast.h:
Move all functions into the WebKit namespace.
* UIProcess/API/C/cf/WKStringCF.cpp:
Add using namespace WebKit.
* WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
Move all functions into the WebKit namespace.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66933
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Tue, 7 Sep 2010 23:43:49 +0000 (23:43 +0000)]
2010-09-07 Tony Chang <tony@chromium.org>
Unreviewed, updating chromium linux test expectations.
* platform/chromium/drt_expectations.txt: Adding back a test removed in r66924 that is still failing.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66932
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Tue, 7 Sep 2010 23:37:29 +0000 (23:37 +0000)]
2010-09-07 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
Fix compile errors in DrawingBuffer if USE(ACCELERATED_COMPOSITING) is not set
https://bugs.webkit.org/show_bug.cgi?id=45324
Adds appropriate #if guards around code that has to deal directly with the compositor.
DrawingBuffer can still be used without the compositor as an off-screen rendering
region.
To test, compile without USE(ACCELERATED_COMPOSITING).
* platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBuffer::~DrawingBuffer):
(WebCore::DrawingBuffer::reset):
* platform/graphics/gpu/DrawingBuffer.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66931
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
joepeck@webkit.org [Tue, 7 Sep 2010 23:34:11 +0000 (23:34 +0000)]
2010-09-07 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Darin Adler.
Provide a way to trigger a <select multiple> onchange event on changes
https://bugs.webkit.org/show_bug.cgi?id=45192
Testing the DOMHTMLSelectElement interface for selecting an
index in a <select> and triggering a "change" event. This also
tests for allowing multiple selections.
* platform/mac/fast/objc/dom-html-select-activate-expected.txt: Added.
* platform/mac/fast/objc/dom-html-select-activate.html: Added.
2010-09-07 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Darin Adler.
Provide a way to trigger a <select multiple> onchange event on changes
https://bugs.webkit.org/show_bug.cgi?id=45192
Adds a selector on ObjCController for testing
-[DOMHTMLSelectElement _activateItemAtIndex:allowMultipleSelection:] and
its different uses.
* DumpRenderTree/mac/ObjCController.m:
(+[ObjCController isSelectorExcludedFromWebScript:]):
(+[ObjCController webScriptNameForSelector:]):
(-[ObjCController setSelectElement:selectedIndex:allowingMultiple:]):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66930
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
joepeck@webkit.org [Tue, 7 Sep 2010 23:33:59 +0000 (23:33 +0000)]
2010-09-03 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Darin Adler.
Provide a way to trigger a <select multiple> onchange event on changes
https://bugs.webkit.org/show_bug.cgi?id=45192
Test: LayoutTests/platform/mac/fast/objc/dom-html-select-activate.html
This provides a way for a WebKit client using the Obj-C DOM bindings to
trigger the "change" on a listbox select (<select multiple> or <select>
with size > 1). This is because when a select is rendered as a listbox
"change" events are triggered by mouse down events.
This adds -[DOMHTMLSelectElement _activateItemAtIndex:allowMultipleSelection:]
to allow for handling multiple selections if the select element is a
multi-select.
* bindings/objc/DOMHTML.mm:
(-[DOMHTMLSelectElement _activateItemAtIndex:allowMultipleSelection:]):
* bindings/objc/DOMPrivate.h: unified the Category name. Was "FormsAutocomplete" now all are "FormAutocomplete".
* dom/SelectElement.h:
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::setSelectedIndexByUser): listboxs need to be treated specially to fire their "change" event.
* html/HTMLSelectElement.h:
* wml/WMLSelectElement.cpp:
(WebCore::WMLSelectElement::setSelectedIndexByUser):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66929
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Tue, 7 Sep 2010 23:28:25 +0000 (23:28 +0000)]
2010-09-07 Simon Fraser <simon.fraser@apple.com>
Reviewed by Darin Adler.
Minor WKCACFLayerRenderer cleanup
https://bugs.webkit.org/show_bug.cgi?id=45201
Call initD3DGeometry() from createRenderer, rather than duplicating the code.
No behavior changes.
* platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::createRenderer):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66928
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Tue, 7 Sep 2010 23:27:22 +0000 (23:27 +0000)]
2010-09-07 James Robinson <jamesr@chromium.org>
Rubber-stamped by Dimitri Glazkov.
Move myself from the committer to the reviewer list.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66927
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Tue, 7 Sep 2010 23:26:36 +0000 (23:26 +0000)]
2010-09-07 Tony Chang <tony@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] removing tests that pass after switch the bot back to hardy
https://bugs.webkit.org/show_bug.cgi?id=45327
* platform/chromium/drt_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66926
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Tue, 7 Sep 2010 23:19:22 +0000 (23:19 +0000)]
2010-09-07 Dimitri Glazkov <dglazkov@chromium.org>
[Chromium/DRT] Remove now-passing tests.
* platform/chromium/drt_expectations.txt: A few more tests now pass, yay!
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66925
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Tue, 7 Sep 2010 23:10:45 +0000 (23:10 +0000)]
2010-09-07 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
turn off php output buffering in multipart tests
https://bugs.webkit.org/show_bug.cgi?id=45232
This was causing hanging multipart resources to not output anything.
On Lucid, the output buffer is enabled by default, but it's not enabled on Hardy.
http://www.php.net/manual/en/function.ob-end-flush.php
* http/tests/multipart/resources/multipart-wait-before-boundary.php:
* http/tests/multipart/resources/multipart.php:
* platform/chromium/drt_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66924
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vangelis@chromium.org [Tue, 7 Sep 2010 23:05:44 +0000 (23:05 +0000)]
2010-09-07 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Darin Fisher.
[chromium] Reset the owner of PlatformLayer's once the GraphicsLayer they are associated with
gets destroyed.
https://bugs.webkit.org/show_bug.cgi?id=45329
Test: Fixes UI test failures downstream for all the Media tests when run on the buildbots (machines without GPUs).
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::~GraphicsLayerChromium):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66923
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zmo@google.com [Tue, 7 Sep 2010 23:03:49 +0000 (23:03 +0000)]
2010-09-07 Zhenyao Mo <zmo@google.com>
Unreviewed.
Add fast/canvas/webgl/gl-teximage.html (failing on chromium mac bot) to chromium/test_expectations.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66922
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Tue, 7 Sep 2010 22:46:36 +0000 (22:46 +0000)]
2010-09-07 Dimitri Glazkov <dglazkov@chromium.org>
Unreviewed, trivial expectations update.
[Chromium/DRT] Remove expectation of crash for
fast/js/date-preserve-milliseconds.html. It's now passing.
* platform/chromium/drt_expectations.txt: Remove now-passing test.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66921
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 7 Sep 2010 22:42:42 +0000 (22:42 +0000)]
2010-09-07 Adam Barth <abarth@webkit.org>
Minor tweaks to the reviewtool UI.
Rename Cancel to Discard to make it more clear what the button does.
Also, move the style declaration for the focus ring later in the sheet
so it works.
* PrettyPatch/PrettyPatch.rb:
* code-review.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66918
268f45cc-cd09-0410-ab3c-
d52691b4dbfc