WebKit.git
9 years agoUpdate comment added in r92139 per Darin's suggestion.
rniwa@webkit.org [Mon, 1 Aug 2011 21:10:56 +0000 (21:10 +0000)]
Update comment added in r92139 per Darin's suggestion.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::styleForElement):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSearch field in designMode causes a crash
rniwa@webkit.org [Mon, 1 Aug 2011 21:08:17 +0000 (21:08 +0000)]
Search field in designMode causes a crash
https://bugs.webkit.org/show_bug.cgi?id=65362

Reviewed by Dimitri Glazkov.

Source/WebCore:

The crashed was caused by editing code inadvertently deleting search and cancel buttons in the design mode.
Fixed the bug by avoid inheriting user-modify property from the shadow host.

Test: editing/input/search-field-crash-in-designmode.html

* css/CSSStyleSelector.cpp:
(WebCore::isAtShadowBoundary): Moved.
(WebCore::CSSStyleSelector::styleForElement): Overrides -webkit-user-modify by the initial value after m_style
inherited the values from m_parentStyle but before applying matched rules.
* dom/Node.cpp:
(WebCore::Node::rendererIsEditable): Ignore page's editability inside a shadow DOM.

LayoutTests:

Add a test to ensure WebKit doesn't crash when a user tries to delete inside
an empty search field in the design mode.

* editing/input/search-field-crash-in-designmode-expected.txt: Added.
* editing/input/search-field-crash-in-designmode.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Soup] Set default max-conns to a more sane default value and fix comment
commit-queue@webkit.org [Mon, 1 Aug 2011 20:40:04 +0000 (20:40 +0000)]
[Soup] Set default max-conns to a more sane default value and fix comment
https://bugs.webkit.org/show_bug.cgi?id=65335

Patch by Marco Peereboom <marco@peereboom.us> on 2011-08-01
Reviewed by Martin Robinson.

Rigged the xxxterm web browser and validated that the default values were set properly.

* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandle::defaultSession):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove unused functionality from gardeningserver
abarth@webkit.org [Mon, 1 Aug 2011 20:39:31 +0000 (20:39 +0000)]
Remove unused functionality from gardeningserver
https://bugs.webkit.org/show_bug.cgi?id=65479

Reviewed by Dimitri Glazkov.

We now handle these operations directly from the front-end.  That means
they work even without the gardening server running!

Also, add some missing files to the list of static files.

* Scripts/webkitpy/tool/servers/gardeningserver.py:
* Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIntroduce SpecifierSorter, a thing that knows how specifiers should be ordered.
dglazkov@chromium.org [Mon, 1 Aug 2011 19:55:45 +0000 (19:55 +0000)]
Introduce SpecifierSorter, a thing that knows how specifiers should be ordered.
https://bugs.webkit.org/show_bug.cgi?id=65413

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/models/test_configuration.py: Added SpecifierSorter and converted
    existing code to use it.
* Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added unit tests and cleaned up a bit.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRefactor bugzilla.js for use by garden-o-matic
abarth@webkit.org [Mon, 1 Aug 2011 19:25:00 +0000 (19:25 +0000)]
Refactor bugzilla.js for use by garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=65450

Reviewed by Dimitri Glazkov.

This patch refactors bugzilla.js to use the AsynchronousCache and
updates the style to use a module instead of an object.  This patch
then fixes all the existing code that uses this class to use the new
API style.

This main benefit of this patch is we remove the tricky manual caching
and this code is now available to use in garden-o-matic (since the
dependency on Utilities.js is now gone).

I ran all the unit tests and poked around in TestFailures a bit to see
that everything seemed to be working properly.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js:
(FailingTestsBugForm):
(FailingTestsBugForm.prototype._createBugTitle):
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js:
(FlakyTestBugForm):
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js:
(NewBugForm):
(NewBugForm.prototype.domElement):
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js:
(TestRelatedBugForm):
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController.prototype._displayBuilder.start):
(ViewController.prototype._displayBuilder):
(ViewController.prototype._domForAuxiliaryUIElements):
(ViewController.prototype._domForNewAndExistingBugs.bugzilla.quickSearch):
(ViewController.prototype._domForPossiblyFlakyTests.flakyList.appendChildren):
(ViewController.prototype._domForPossiblyFlakyTests):
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agogarden-o-matic shouldn't require local server to determine if compile failed
abarth@webkit.org [Mon, 1 Aug 2011 19:23:21 +0000 (19:23 +0000)]
garden-o-matic shouldn't require local server to determine if compile failed
https://bugs.webkit.org/show_bug.cgi?id=65446

Reviewed by Dimitri Glazkov.

This patch adds some basic bindings for the buildbot JSON API.  I
wanted to use Buildbot.js an Builder.js from the original TestFailures,
but they make a number of WebKit-specific assumptions.  We'll
eventually need to reconcile these pieces of code.

I should really add tests for this code, but that will require me to
build a better mock network.  I'll be happy to do that in a follow-up
patch.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js: Added.
    - It's very unclear to me whether didFail is correct.  Supposedly
      the first entry here is the exit code of the step, which is 0 on
      success.  I suspect we'll need to improve this function over time.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agogarden-o-matic should show all failures, even ones that it can't find a regression...
abarth@webkit.org [Mon, 1 Aug 2011 18:45:02 +0000 (18:45 +0000)]
garden-o-matic should show all failures, even ones that it can't find a regression range for
https://bugs.webkit.org/show_bug.cgi?id=65447

Reviewed by Dimitri Glazkov.

Previously, we just wouldn't display test failures that we couldn't
identify a regression range for (or whose regression range had fallen
off the page).  This patch just displays them at the end of the list,
which is slightly (but not much) better.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRegression(82144): Crash in TrailingObjects::updateMidpointsForTrailingBoxes
inferno@chromium.org [Mon, 1 Aug 2011 18:03:03 +0000 (18:03 +0000)]
Regression(82144): Crash in TrailingObjects::updateMidpointsForTrailingBoxes
https://bugs.webkit.org/show_bug.cgi?id=65137

Source/WebCore:

Fix the looping condition to prevent trailingSpaceMidpoint from becoming negative.

Reviewed by Dave Hyatt.

Test: fast/block/update-midpoints-for-trailing-boxes-crash.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::TrailingObjects::updateMidpointsForTrailingBoxes):

LayoutTests:

ASSERTION FAILED: trailingSpaceMidpoint >= 0

Reviewed by Dave Hyatt.

* fast/block/update-midpoints-for-trailing-boxes-crash-expected.txt: Added.
* fast/block/update-midpoints-for-trailing-boxes-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening after r92127.
ossy@webkit.org [Mon, 1 Aug 2011 16:51:22 +0000 (16:51 +0000)]
[Qt] Unreviewed gardening after r92127.

* platform/qt-4.8/css2.1/t0602-c13-inh-underlin-00-e-expected.png: Added.
* platform/qt-4.8/css2.1/t0602-c13-inh-underlin-00-e-expected.txt: Added.
* platform/qt-4.8/editing/selection/4397952-expected.png: Added.
* platform/qt-4.8/editing/selection/4397952-expected.txt: Added.
* platform/qt-mac/Skipped: Skip failing tests.
* platform/qt-wk2/Skipped: Skip failing tests.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] OpenGLShims does not build on ARM
commit-queue@webkit.org [Mon, 1 Aug 2011 16:10:12 +0000 (16:10 +0000)]
[Qt] OpenGLShims does not build on ARM
https://bugs.webkit.org/show_bug.cgi?id=65465

Patch by Benjamin Poulain <benjamin@webkit.org> on 2011-08-01
Reviewed by Noam Rosenthal.

Fix the build with OpenGL ES 2:
-lookupOpenGLFunctionAddress() was defined but not used for OpenGL ES.
-glBlitFramebuffer() and glRenderbufferStorageMultisample() are not part of the specification.
When those are available as platform extension, the extension has been added.
-GLchar is not defined on some platform. The patch adds the same typedef as the official definition
to avoid conflicts.

* platform/graphics/cairo/OpenGLShims.cpp:
(lookupOpenGLFunctionAddress):
(WebCore::initializeOpenGLShims):
* platform/graphics/cairo/OpenGLShims.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd fast/forms/selection-direction.html to the Skipped list.
andersca@apple.com [Mon, 1 Aug 2011 16:09:37 +0000 (16:09 +0000)]
Add fast/forms/selection-direction.html to the Skipped list.

* platform/wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows build fix after r92096.
jeffm@apple.com [Mon, 1 Aug 2011 16:02:19 +0000 (16:02 +0000)]
Windows build fix after r92096.

* TestWebKitAPI/win/InjectedBundleControllerWin.cpp: Use #include, not #import, and don't include Foundation.h.
* TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Add InjectedBundleControllerWin.cpp.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Update expected results and unskip now passing tests.
ossy@webkit.org [Mon, 1 Aug 2011 16:01:39 +0000 (16:01 +0000)]
[Qt] Update expected results and unskip now passing tests.

Patch by Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu> on 2011-08-01
Reviewed by Csaba Osztrogonác.

* platform/qt/Skipped:
* platform/qt/css2.1/ [...]: Updated.
* platform/qt/editing/ [...]: Updated.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-08-01 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Mon, 1 Aug 2011 13:47:35 +0000 (13:47 +0000)]
2011-08-01  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: unflake inspector test that was just added.

        * inspector/debugger/scripts-sorting-expected.txt:
        * inspector/debugger/scripts-sorting.html:
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-08-01 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Mon, 1 Aug 2011 12:45:12 +0000 (12:45 +0000)]
2011-08-01  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Trivial fix for inspector/debugger/debugger-completions-on-call-frame.html after r92122.

        * inspector/front-end/ConsoleView.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd support for getting an element in shadow root by its id into a window.internals...
hayato@chromium.org [Mon, 1 Aug 2011 12:25:53 +0000 (12:25 +0000)]
Add support for getting an element in shadow root by its id into a window.internals object.
https://bugs.webkit.org/show_bug.cgi?id=64587

Reviewed by Hajime Morita.

.:

* Source/autotools/symbols.filter:

Source/WebCore:

Test: fast/dom/shadow/get-element-by-id-in-shadow-root.html

* WebCore.exp.in:
* testing/Internals.cpp:
(WebCore::Internals::getElementByIdInShadowRoot):
* testing/Internals.h:
* testing/Internals.idl:

Source/WebKit2:

* win/WebKit2.def:
* win/WebKit2CFLite.def:

LayoutTests:

* fast/dom/shadow/get-element-by-id-in-shadow-root-expected.txt: Added.
* fast/dom/shadow/get-element-by-id-in-shadow-root.html: Added.
* fast/dom/shadow/resources/create-dom.js: Added.
(createShadow):
(createDom):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agobuild: Fix finding the headers for GStreamer
commit-queue@webkit.org [Mon, 1 Aug 2011 11:53:51 +0000 (11:53 +0000)]
build: Fix finding the headers for GStreamer

The cmake files to find the various GStreamer packages were all
checking for the header gst/gst.h. However if gst-plugins-base is
installed into a separate prefix from gstreamer then all of these
tests would only pick up the gstreamer include path so the build
would fail. This patch changes it to try and find a file
appropriate to each package.

https://bugs.webkit.org/show_bug.cgi?id=64933

Patch by Neil Roberts <neil@linux.intel.com> on 2011-08-01
Reviewed by Martin Robinson.

* Source/cmake/FindGStreamer-App.cmake:
* Source/cmake/FindGStreamer-Base.cmake:
* Source/cmake/FindGStreamer-Interfaces.cmake:
* Source/cmake/FindGStreamer-Pbutils.cmake:
* Source/cmake/FindGStreamer-Plugins-Base.cmake:
* Source/cmake/FindGStreamer-Video.cmake:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: typing an expression in an iframe leads to multiple "Unsafe JavaScript...
yurys@chromium.org [Mon, 1 Aug 2011 11:42:43 +0000 (11:42 +0000)]
Web Inspector: typing an expression in an iframe leads to multiple "Unsafe JavaScript attempt to access frame..." errors
https://bugs.webkit.org/show_bug.cgi?id=65457

Source/WebCore:

Console completions are now done using evaluation which returns a JSON object with all property names rather than a remote
object. Also Runtime.evaluate and Runtime.callFunctionOn commands were extended with an optional parameter that allows to
get result as JSON value.

Reviewed by Pavel Feldman.

Test: http/tests/inspector/console-cd-completions.html

* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::evaluate):
(WebCore::InjectedScript::callFunctionOn):
* inspector/InjectedScript.h:
* inspector/InjectedScriptSource.js:
(.):
():
* inspector/Inspector.json:
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::asBool):
(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):
* inspector/InspectorRuntimeAgent.h:
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._completions.evaluated.getCompletions):
(WebInspector.ConsoleView.prototype._completions.evaluated):
(WebInspector.ConsoleView.prototype._completions.receivedPropertySet):
(WebInspector.ConsoleView.prototype._completions):
(WebInspector.ConsoleView.prototype.evalInInspectedWindow):
* inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject):
(WebInspector.RemoteObject.prototype.callFunction):
(WebInspector.RemoteObject.prototype.callFunctionJSON):
* inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionsSection.prototype.update):

LayoutTests:

Reviewed by Pavel Feldman.

* http/tests/inspector/console-cd-completions-expected.txt: Added.
* http/tests/inspector/console-cd-completions.html: Added.
* http/tests/inspector/resources/console-cd-completions-iframe.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] http/tests/inspector/resource-tree/resource-tree-document-url.html occasio...
tonyg@chromium.org [Mon, 1 Aug 2011 11:38:59 +0000 (11:38 +0000)]
[chromium] http/tests/inspector/resource-tree/resource-tree-document-url.html occasionally times out
https://bugs.webkit.org/show_bug.cgi?id=65463

Unreviewed expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] http/tests/cache/history-only-cached-subresource-loads-max-age-https.html...
tonyg@chromium.org [Mon, 1 Aug 2011 11:30:35 +0000 (11:30 +0000)]
[chromium] http/tests/cache/history-only-cached-subresource-loads-max-age-https.html frequently times out on Vista
https://bugs.webkit.org/show_bug.cgi?id=65462

Unreviewed expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Temporarily expect scripts-sorting.html to fail
tonyg@chromium.org [Mon, 1 Aug 2011 11:22:44 +0000 (11:22 +0000)]
[chromium] Temporarily expect scripts-sorting.html to fail
https://bugs.webkit.org/show_bug.cgi?id=65461

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBORDER attribute with the object tag, using percentage values not working.
commit-queue@webkit.org [Mon, 1 Aug 2011 11:18:15 +0000 (11:18 +0000)]
BORDER attribute with the object tag, using percentage values not working.
https://bugs.webkit.org/show_bug.cgi?id=65176

Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-08-01
Reviewed by Hajime Morita.

Source/WebCore:

When border presentational attribute for object element has % in it, it should be parsed using HTML parser rules.

Test: fast/borders/border-width-percent.html

* html/HTMLElement.cpp:
(WebCore::HTMLElement::parseBorderWidthAttribute):
* html/HTMLElement.h:
* html/HTMLImageElement.cpp:
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parseMappedAttribute):

LayoutTests:

Added the tests with border width with percentages in a new file. Moved them
from images border test file.

* fast/borders/border-width-percent-expected.txt: Added.
* fast/borders/border-width-percent.html: Added.
* fast/images/border-expected.txt:
* fast/images/script-tests/border.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Update expectations for fast/text/international/bidi-mirror-he-ar.html
tonyg@chromium.org [Mon, 1 Aug 2011 11:16:15 +0000 (11:16 +0000)]
[chromium] Update expectations for fast/text/international/bidi-mirror-he-ar.html
https://bugs.webkit.org/show_bug.cgi?id=65460

Unreviewed expectations update.

* platform/chromium-win/fast/text/international/bidi-mirror-he-ar-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebSocket: Receive URL and subprotocol in WebSocketChannel::connect()
yutak@chromium.org [Mon, 1 Aug 2011 11:16:13 +0000 (11:16 +0000)]
WebSocket: Receive URL and subprotocol in WebSocketChannel::connect()
https://bugs.webkit.org/show_bug.cgi?id=65367

Reviewed by Kent Tamura.

To implement multiple subprotocols support (bug 65247), WebSocket::connect() will need to validate
the value of subprotocols after constructing WebSocketChannel, because the result depends on which
WebSocket protocol is used, which is obtained from WebSocketChannel::useHixie76Protocol(). This
means the subprotocol value will not be available at the time of WebSocketChannel construction.

This change moves URL and subprotocol arguments in WebSocketChannel constructor to
WebSocketChannel::connect(), which allows WebSocket::connect() function to check the subprotocol
value before the actual connection is established.

Relocating URL argument is technically not necessary, but seemed legitimate in terms of functional
correspondence between WebSocket and WebSocketChannel (constructor versus connect()).

No change in behavior, thus no new tests.

* websockets/ThreadableWebSocketChannel.cpp:
Remove "url" and "protocol" arguments from constructor and add them in connect().
(WebCore::ThreadableWebSocketChannel::create):
* websockets/ThreadableWebSocketChannel.h:
* websockets/WebSocket.cpp:
(WebCore::WebSocket::connect):
* websockets/WebSocketChannel.cpp: Same as ThreadableWebSocketChannel.
(WebCore::WebSocketChannel::WebSocketChannel):
(WebCore::WebSocketChannel::connect):
InspectorInstrumentation::didCreateWebSocket() call was moved to connect() because it needs URL.
This does not change behavior, because connect() is guaranteed to be called immediately after
WebSocketChannel is constructed.
* websockets/WebSocketChannel.h:
(WebCore::WebSocketChannel::create):
* websockets/WorkerThreadableWebSocketChannel.cpp: Same as ThreadableWebSocketChannel.
(WebCore::WorkerThreadableWebSocketChannel::WorkerThreadableWebSocketChannel):
(WebCore::WorkerThreadableWebSocketChannel::connect):
(WebCore::WorkerThreadableWebSocketChannel::Peer::Peer):
(WebCore::WorkerThreadableWebSocketChannel::Peer::connect):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadCreateWebSocketChannel):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::Bridge):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadConnect):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::connect):
* websockets/WorkerThreadableWebSocketChannel.h:
(WebCore::WorkerThreadableWebSocketChannel::create):
(WebCore::WorkerThreadableWebSocketChannel::Peer::create):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::create):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Fix tst_QWebPage::loadHtml5Video() API test
ossy@webkit.org [Mon, 1 Aug 2011 10:19:44 +0000 (10:19 +0000)]
[Qt] Fix tst_QWebPage::loadHtml5Video() API test
https://bugs.webkit.org/show_bug.cgi?id=65452

Patch by Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu> on 2011-08-01
Reviewed by Csaba Osztrogonác.

* tests/qwebpage/tst_qwebpage.cpp: Mark failing test case as expected fail
(tst_QWebPage::loadHtml5Video):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Add network panel sidebar width test.
vsevik@chromium.org [Mon, 1 Aug 2011 10:18:19 +0000 (10:18 +0000)]
Web Inspector: Add network panel sidebar width test.
https://bugs.webkit.org/show_bug.cgi?id=65314

Reviewed by Yury Semikhatsky.

* http/tests/inspector/network/network-sidebar-width-expected.txt: Added.
* http/tests/inspector/network/network-sidebar-width.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r92108.
commit-queue@webkit.org [Mon, 1 Aug 2011 09:53:53 +0000 (09:53 +0000)]
Unreviewed, rolling out r92108.
http://trac.webkit.org/changeset/92108
https://bugs.webkit.org/show_bug.cgi?id=65459

breaks SL compile (Requested by tonyg-cr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-01

* Shared/WebCoreArgumentCoders.cpp:
(CoreIPC::::encode):
(CoreIPC::::decode):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttp/tests/inspector/resource-tree/resource-tree-reload.html is flaky on chromium win
tonyg@chromium.org [Mon, 1 Aug 2011 09:36:54 +0000 (09:36 +0000)]
http/tests/inspector/resource-tree/resource-tree-reload.html is flaky on chromium win
https://bugs.webkit.org/show_bug.cgi?id=60110

Marking it flaky on Linux as well.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix windows text rendering expectations for fast/text/justify-ideograph-leading-expan...
tonyg@chromium.org [Mon, 1 Aug 2011 09:05:46 +0000 (09:05 +0000)]
Fix windows text rendering expectations for fast/text/justify-ideograph-leading-expansion.html
https://bugs.webkit.org/show_bug.cgi?id=65455

Unreviewed expectations update.

* platform/chromium-win-xp/fast/text/justify-ideograph-leading-expansion-expected.png: Copied from LayoutTests/platform/chromium-win/fast/text/justify-ideograph-leading-expansion-expected.png.
* platform/chromium-win/fast/text/justify-ideograph-leading-expansion-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r92048): svg/custom/external-paintserver-reference.svg, svg/custom/linkin...
ossy@webkit.org [Mon, 1 Aug 2011 09:04:33 +0000 (09:04 +0000)]
REGRESSION (r92048): svg/custom/external-paintserver-reference.svg, svg/custom/linking-base-external-reference.xhtml failing on SnowLeopard Intel Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=65432

Revert accidentally committed changes, and update Qt specific expected results.

* platform/qt/svg/custom/external-paintserver-reference-expected.png: Copied from LayoutTests/svg/custom/external-paintserver-reference-expected.png.
* platform/qt/svg/custom/external-paintserver-reference-expected.txt: Copied from LayoutTests/svg/custom/external-paintserver-reference-expected.txt.
* platform/qt/svg/custom/linking-base-external-reference-expected.png: Copied from LayoutTests/svg/custom/linking-base-external-reference-expected.png.
* platform/qt/svg/custom/linking-base-external-reference-expected.txt: Copied from LayoutTests/svg/custom/linking-base-external-reference-expected.txt.
* svg/custom/external-paintserver-reference-expected.png: Revert r92048.
* svg/custom/external-paintserver-reference-expected.txt: Revert r92048.
* svg/custom/linking-base-external-reference-expected.png: Revert r92048.
* svg/custom/linking-base-external-reference-expected.txt: Revert r92048.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-08-01 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Mon, 1 Aug 2011 08:57:05 +0000 (08:57 +0000)]
2011-08-01  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: unflake inspector test that was just added.

        * inspector/debugger/scripts-sorting-expected.txt:
        * inspector/debugger/scripts-sorting.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCustom cursors cause the WebProcess to crash
commit-queue@webkit.org [Mon, 1 Aug 2011 08:49:06 +0000 (08:49 +0000)]
Custom cursors cause the WebProcess to crash
https://bugs.webkit.org/show_bug.cgi?id=64802

Patch by Amruth Raj <amruthraj@motorola.com> on 2011-08-01
Reviewed by Darin Adler.

* Shared/WebCoreArgumentCoders.cpp:
(CoreIPC::::encode): In case of a NULL cursor image, encode a bool indicating that.
(CoreIPC::::decode): Decode the image only if required.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] fast/css/outline-auto-empty-rects.html broken by r92059
tonyg@chromium.org [Mon, 1 Aug 2011 08:48:49 +0000 (08:48 +0000)]
[chromium] fast/css/outline-auto-empty-rects.html broken by r92059
https://bugs.webkit.org/show_bug.cgi?id=65453

This patch just expects the test to fail for now.

Unreviewed expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd iterator to CSSValueList
macpherson@chromium.org [Mon, 1 Aug 2011 08:31:43 +0000 (08:31 +0000)]
Add iterator to CSSValueList
https://bugs.webkit.org/show_bug.cgi?id=65297

Reviewed by Darin Adler.

No new tests / refactoring only.

* css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::isLength):
Add shorthand to determine if this primitive value is a length.
* css/CSSStyleSelector.cpp:
Use CSSValueListIterator throughout.
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::applyPageSizeProperty):
(WebCore::CSSStyleSelector::createTransformOperations):
* css/CSSValueList.cpp:
(WebCore::CSSValueList::copy):
Use itemWithoutBoundsCheck() instead of item().
* css/CSSValueList.h:
Add CSSValueListIterator and CSSValueListInspector class definitions.
(WebCore::CSSValueList::item)
Provide inline definition of item.
(WebCore::CSSValueListIterator::CSSValueListIterator):
(WebCore::CSSValueListIterator::hasMore):
Return true if there are more values to consume, including the current value.
(WebCore::CSSValueListIterator::value):
Return the value at the current position.
(WebCore::CSSValueListIterator::next):
Move the iterator forward to the next item.
(WebCore::CSSValueListIterator::index):
Return the current position in the list.
(WebCore::CSSValueListInspector::item):
Return the item at a given index.
(WebCore::CSSValueListInspector::first):
Return the first item in the list.
(WebCore::CSSValueListInspector::second):
Return the second item in the list.
(WebCore::CSSValueListInspector::length):
Return the size of the underlying list.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: group scripts by folder in the scripts selector.
pfeldman@chromium.org [Mon, 1 Aug 2011 08:17:05 +0000 (08:17 +0000)]
Web Inspector: group scripts by folder in the scripts selector.
https://bugs.webkit.org/show_bug.cgi?id=65321

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/debugger/scripts-sorting.html

* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._sourceFileAdded.get if):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.insertOrdered.optionCompare):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.insertOrdered):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
(WebInspector.ScriptsPanel.prototype._folderAndDisplayNameForScriptURL):
(WebInspector.ScriptsPanel.prototype.reset):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.suggestedFileName):

LayoutTests:

* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
* inspector/debugger/scripts-sorting-expected.txt: Added.
* inspector/debugger/scripts-sorting.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [protocol] methods where all parameters are optional should not requir...
pfeldman@chromium.org [Mon, 1 Aug 2011 08:13:55 +0000 (08:13 +0000)]
Web Inspector: [protocol] methods where all parameters are optional should not require empty params object.
https://bugs.webkit.org/show_bug.cgi?id=65331

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/CodeGeneratorInspector.pm:
(generateBackendFunction):
(generateArgumentGetters):

LayoutTests:

* inspector/report-protocol-errors-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoapplication/json MIME type shouldn't cause warnings in <script> tags
abarth@webkit.org [Mon, 1 Aug 2011 08:04:11 +0000 (08:04 +0000)]
application/json MIME type shouldn't cause warnings in <script> tags
https://bugs.webkit.org/show_bug.cgi?id=65448

Reviewed by Pavel Feldman.

This patch stops the web inspector from logging a ton of spam warnings
when a web page uses a JSONP service (which points script tags at
application/json resources).

* inspector/front-end/inspector.js:
(WebInspector.reset):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebSocket: Rename SocketStreamHandleClient member functions
yutak@chromium.org [Mon, 1 Aug 2011 07:26:41 +0000 (07:26 +0000)]
WebSocket: Rename SocketStreamHandleClient member functions
https://bugs.webkit.org/show_bug.cgi?id=65374

Reviewed by Kent Tamura.

Source/WebCore:

Rename SocketStreamHandleClient member functions to avoid conflict of the names of
FileReaderLoaderClient functions.

No change in behavior, thus no new tests are added.

* platform/network/SocketStreamHandleClient.h:
(WebCore::SocketStreamHandleClient::didOpenSocketStream):
(WebCore::SocketStreamHandleClient::didCloseSocketStream):
(WebCore::SocketStreamHandleClient::didReceiveSocketStreamData):
(WebCore::SocketStreamHandleClient::didFailSocketStream):
* platform/network/brew/SocketStreamHandleBrew.cpp:
(WebCore::SocketStreamHandlePrivate::socketConnected):
(WebCore::SocketStreamHandlePrivate::socketReadyRead):
(WebCore::SocketStreamHandlePrivate::socketClosed):
(WebCore::SocketStreamHandlePrivate::socketError):
* platform/network/cf/SocketStreamHandleCFNet.cpp:
(WebCore::SocketStreamHandle::addCONNECTCredentials):
(WebCore::SocketStreamHandle::readStreamCallback):
(WebCore::SocketStreamHandle::writeStreamCallback):
(WebCore::SocketStreamHandle::reportErrorToClient):
(WebCore::SocketStreamHandle::platformClose):
* platform/network/qt/SocketStreamHandleQt.cpp:
(WebCore::SocketStreamHandlePrivate::socketConnected):
(WebCore::SocketStreamHandlePrivate::socketReadyRead):
(WebCore::SocketStreamHandlePrivate::socketClosedCallback):
(WebCore::SocketStreamHandlePrivate::socketErrorCallback):
* platform/network/soup/SocketStreamHandleSoup.cpp:
(WebCore::SocketStreamHandle::connected):
(WebCore::SocketStreamHandle::readBytes):
(WebCore::SocketStreamHandle::platformSend):
(WebCore::SocketStreamHandle::platformClose):
* websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::didOpenSocketStream):
(WebCore::WebSocketChannel::didCloseSocketStream):
(WebCore::WebSocketChannel::didReceiveSocketStreamData):
(WebCore::WebSocketChannel::didFailSocketStream):
(WebCore::WebSocketChannel::resumeTimerFired):
* websockets/WebSocketChannel.h:

Source/WebKit/chromium:

* src/SocketStreamHandle.cpp:
(WebCore::SocketStreamHandleInternal::didOpenStream):
(WebCore::SocketStreamHandleInternal::didReceiveData):
(WebCore::SocketStreamHandleInternal::didClose):
(WebCore::SocketStreamHandleInternal::didFail):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoThese results appear to differ only in text rendering.
abarth@webkit.org [Mon, 1 Aug 2011 06:05:50 +0000 (06:05 +0000)]
These results appear to differ only in text rendering.

* platform/chromium-win-xp/fast/text/international/bidi-mirror-he-ar-expected.png:
* platform/chromium-win-xp/fast/text/justify-ideograph-leading-expansion-expected.png: Removed.
* platform/chromium-win/fast/text/international/bidi-mirror-he-ar-expected.png:
* platform/chromium-win/fast/text/justify-ideograph-leading-expansion-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdding expected results. These results appear to differ only in the scrollbar.
abarth@webkit.org [Mon, 1 Aug 2011 05:36:49 +0000 (05:36 +0000)]
Adding expected results.  These results appear to differ only in the scrollbar.

* platform/chromium-linux/svg/custom/external-paintserver-reference-expected.png: Added.
* platform/chromium-linux/svg/custom/linking-base-external-reference-expected.png: Added.
* platform/chromium-mac/svg/custom/external-paintserver-reference-expected.png: Added.
* platform/chromium-mac/svg/custom/external-paintserver-reference-expected.txt: Added.
* platform/chromium-mac/svg/custom/linking-base-external-reference-expected.png: Added.
* platform/chromium-mac/svg/custom/linking-base-external-reference-expected.txt: Added.
* platform/chromium-win/svg/custom/external-paintserver-reference-expected.png: Added.
* platform/chromium-win/svg/custom/external-paintserver-reference-expected.txt: Added.
* platform/chromium-win/svg/custom/linking-base-external-reference-expected.png: Added.
* platform/chromium-win/svg/custom/linking-base-external-reference-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate baseline. This patch might cause Linux to start failing, but in
abarth@webkit.org [Mon, 1 Aug 2011 05:33:37 +0000 (05:33 +0000)]
Update baseline.  This patch might cause Linux to start failing, but in
that case, we can add a more specific Linux result.  This approach is
somewhat of an exploration of this automated rebaselining algorithm.

* platform/chromium-win/svg/batik/text/textLength-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r92094.
commit-queue@webkit.org [Mon, 1 Aug 2011 04:25:01 +0000 (04:25 +0000)]
Unreviewed, rolling out r92094.
http://trac.webkit.org/changeset/92094
https://bugs.webkit.org/show_bug.cgi?id=65443

Triggered many asserts (Requested by abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-31

Source/WebCore:

* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent):

LayoutTests:

* fast/events/event-target-reset-expected.txt: Removed.
* fast/events/event-target-reset.html: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDownloadDecideDestinationCrash WebKit2 API tests crashes
andersca@apple.com [Mon, 1 Aug 2011 04:17:06 +0000 (04:17 +0000)]
DownloadDecideDestinationCrash WebKit2 API tests crashes
https://bugs.webkit.org/show_bug.cgi?id=65442

Reviewed by Sam Weinig.

Copy the 18-characters.html file to the destination directory so we won't
crash trying to make an URL for it.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd forgotten files.
andersca@apple.com [Mon, 1 Aug 2011 04:10:41 +0000 (04:10 +0000)]
Add forgotten files.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix SpacebarScrolling WebKit2 API test
andersca@apple.com [Mon, 1 Aug 2011 03:32:07 +0000 (03:32 +0000)]
Fix SpacebarScrolling WebKit2 API test
https://bugs.webkit.org/show_bug.cgi?id=65431

Reviewed by Sam Weinig.

Add a way to do platform-specific bundle initialization, and use it to disable smooth
scrolling. Also make it possible for a test to load the injected bundle without actually running
a test from it.

* TestWebKitAPI/InjectedBundleController.cpp:
(TestWebKitAPI::InjectedBundleController::initialize):
* TestWebKitAPI/InjectedBundleController.h:
* TestWebKitAPI/PlatformUtilities.cpp:
(TestWebKitAPI::Util::createContextWithInjectedBundle):
* TestWebKitAPI/PlatformUtilities.h:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
(TestWebKitAPI::TEST):
* TestWebKitAPI/mac/InjectedBundleControllerMac.mm: Added.
(TestWebKitAPI::InjectedBundleController::platformInitialize):
* TestWebKitAPI/win/InjectedBundleControllerWin.cpp: Added.
(TestWebKitAPI::InjectedBundleController::platformInitialize):
* TestWebKitAPI/win/TestWebKitAPI.vcproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEvent target set to null post event dispatch
dominicc@chromium.org [Mon, 1 Aug 2011 02:53:55 +0000 (02:53 +0000)]
Event target set to null post event dispatch
https://bugs.webkit.org/show_bug.cgi?id=63934

Reviewed by Dimitri Glazkov.

Source/WebCore:

Test: fast/events/event-target-reset.html

* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent): Reset target to outermost
shadow host.

LayoutTests:

* fast/events/event-target-reset-expected.txt: Added.
* fast/events/event-target-reset.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=64679
barraclough@apple.com [Mon, 1 Aug 2011 01:50:16 +0000 (01:50 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=64679
Fix bugs in Array.prototype this handling.

Unreviewed - rolling out r91290.

Source/JavaScriptCore:

Looks like the wild wild web isn't ready for this yet.

This change broke http://slides.html5rocks.com/#landing-slide.
Interestingly, this might only be due to our lack of bind support -
it looks like this site is calling  Array.prototype.slice as a part
of its bind implementation.

* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncJoin):
(JSC::arrayProtoFuncConcat):
(JSC::arrayProtoFuncPop):
(JSC::arrayProtoFuncPush):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncForEach):
(JSC::arrayProtoFuncSome):
(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):
(JSC::arrayProtoFuncIndexOf):
(JSC::arrayProtoFuncLastIndexOf):

LayoutTests:

Checking in failing results - we can't fix this bug just yet
for web compatibility reasons.

* fast/js/array-prototype-properties-expected.txt:
* ietestcenter/Javascript/15.4.4.14-5-28-expected.txt:
* ietestcenter/Javascript/15.4.4.15-5-28-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJSC GC lays out size classes under wrong assumptions about expected
fpizlo@apple.com [Sun, 31 Jul 2011 23:48:27 +0000 (23:48 +0000)]
JSC GC lays out size classes under wrong assumptions about expected
object size.
https://bugs.webkit.org/show_bug.cgi?id=65437

Reviewed by Oliver Hunt.

Changed the atom size - which is both the smallest allocation size and
the smallest possible stepping unit for size class spacing - from
8 bytes to 4 pointer-size words.  This is a 1% win on SunSpider.

* heap/MarkedBlock.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix fast/dom/Range/getBoundingClientRect.html after r92089.
rniwa@webkit.org [Sun, 31 Jul 2011 23:17:24 +0000 (23:17 +0000)]
Fix fast/dom/Range/getBoundingClientRect.html after r92089.

* fast/dom/Range/getBoundingClientRect.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] editing/execCommand/4786404-1.html,editing/execCommand/break-out-of-empty...
rniwa@webkit.org [Sun, 31 Jul 2011 21:14:06 +0000 (21:14 +0000)]
[Chromium] editing/execCommand/4786404-1.html,editing/execCommand/break-out-of-empty-list-item.html are slow/timeout
https://bugs.webkit.org/show_bug.cgi?id=65019

This bug was invalid; neither test is slow nor timing out.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION: getBoundingClientRect() method of Range incorrectly returns null for...
weinig@apple.com [Sun, 31 Jul 2011 21:05:26 +0000 (21:05 +0000)]
REGRESSION: getBoundingClientRect() method of Range incorrectly returns null for collapsed Range
https://bugs.webkit.org/show_bug.cgi?id=65324

Reviewed by Ryosuke Niwa.

Source/WebCore:

Update to more closely match the spec.

* dom/Range.cpp:
(WebCore::Range::getClientRects):
Return an empty ClientRectList instead of null when the range is empty.

(WebCore::Range::getBoundingClientRect):
Always return a ClientRect, even for an empty bounding rect.

LayoutTests:

* fast/dom/Range/getBoundingClientRect-expected.txt:
* fast/dom/Range/getBoundingClientRect.html:
* fast/dom/Range/getClientRects-expected.txt:
* fast/dom/Range/getClientRects.html:
Add test cases for empty and collapsed ranges.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[HTML5] Implement the selectionDirection property on input and textarea
rniwa@webkit.org [Sun, 31 Jul 2011 20:44:57 +0000 (20:44 +0000)]
[HTML5] Implement the selectionDirection property on input and textarea
https://bugs.webkit.org/show_bug.cgi?id=60403

Reviewed by Darin Adler.

Source/WebCore:

Implements selectionDirection property as specified in HTML5 section 4.10.20:
http://www.whatwg.org/specs/web-apps/current-work/#textFieldSelection

selectionDirection is a property on input and textarea elements, which, on getting returns either "none",
"forward", or "backward" corresponding to the current selection direction, and on setting, modifies
the direction of the current selection. When selection doesn't exist or direction is unknown, "none"
is returned on getting. Setting the property value to neither of above values will result in setting "none".

This patch also adds the optional third argument, direction, to setSelectionRange.

Test: fast/forms/selection-direction.html
      fast/forms/selection-wrongtype.html

* bindings/js/JSHTMLInputElementCustom.cpp:
(WebCore::JSHTMLInputElement::selectionDirection): Added.
(WebCore::JSHTMLInputElement::setSelectionDirection): Added.
(WebCore::JSHTMLInputElement::setSelectionRange): Processes the third argument.
* bindings/v8/custom/V8HTMLInputElementCustom.cpp:
(WebCore::V8HTMLInputElement::selectionDirectionAccessorGetter): Added.
(WebCore::V8HTMLInputElement::selectionDirectionAccessorSetter): Added.
(WebCore::V8HTMLInputElement::setSelectionRangeCallback): Processes the third argument.
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::updateFocusAppearance): Calls hasCachedSelection.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateFocusAppearance): Ditto.
(WebCore::HTMLInputElement::setValue): Calls cacheSelection with SelectionHasNoDirection.
* html/HTMLTextAreaElement.idl: Added selectionDirection and the third argument to setSelectionRange.
* html/HTMLInputElement.idl: Ditto.
* html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::HTMLTextFormControlElement): Initializes
m_cachedSelectionDirection.
(WebCore::HTMLTextFormControlElement::setSelectionStart): Calls setSelectionRange.
(WebCore::HTMLTextFormControlElement::setSelectionEnd): Ditto.
(WebCore::HTMLTextFormControlElement::setSelectionDirection): Added.
(WebCore::HTMLTextFormControlElement::select): Calls setSelectionRange with SelectionHasNoDirection.
(WebCore::HTMLTextFormControlElement::setSelectionRange): Added the version that takes direction
string as the third argument, which calls the version that takes two ints and TextFieldSelectionDirection.
(WebCore::HTMLTextFormControlElement::selectionStart): Calls hasCachedSelection.
(WebCore::HTMLTextFormControlElement::selectionEnd): Ditto.
(WebCore::directionString): Added.
(WebCore::HTMLTextFormControlElement::selectionDirection): Added.
(WebCore::HTMLTextFormControlElement::computeSelectionDirection): Added.
(WebCore::HTMLTextFormControlElement::selection): Calls hasCachedSelection.
(WebCore::HTMLTextFormControlElement::restoreCachedSelection): Calls setSelectionRange.
(WebCore::HTMLTextFormControlElement::selectionChanged): Calls cacheSelection.
* html/HTMLTextFormControlElement.h:
(WebCore::HTMLTextFormControlElement::cacheSelection): Takes TextFieldSelectionDirection.
(WebCore::HTMLTextFormControlElement::hasCachedSelection): Extracted from hasCachedSelectionStart;
cacheSelection is the only function that modifies m_cacheSelectionStart and m_cacheSelectionEnd
and none of its callers ever set one of them be -1 so they are always both -1 or both non-negative.
Thus, having two separate functions for m_cacheSelectionStart and m_cacheSelectionEnd was redundant.

LayoutTests:

Added a test to ensure WebKit sets and gets selectionDirection property.

Also added a test to ensure WebKit throws exceptions when retrieving or assigning values to selectionStart,
selectionEnd, and selectionDirection property of the input element when the element isn't a text field.

* fast/forms/selection-direction-expected.txt: Added.
* fast/forms/selection-direction.html: Added.
* fast/forms/selection-wrongtype-expected.txt: Added.
* fast/forms/selection-wrongtype.html: Added.
* platform/mac/editing/deleting/delete-all-text-in-text-field-assertion-expected.txt: Copied from
editing/deleting/delete-all-text-in-text-field-assertion-expected.txt; editing delegate change.
* platform/win/editing/deleting/delete-all-text-in-text-field-assertion-expected.txt: Copied from
editing/deleting/delete-all-text-in-text-field-assertion-expected.txt since Windows port fallbacks to Mac.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse set comparison to find duplicate or overlapping specifiers in test expectations.
dglazkov@chromium.org [Sun, 31 Jul 2011 20:40:55 +0000 (20:40 +0000)]
Use set comparison to find duplicate or overlapping specifiers in test expectations.
https://bugs.webkit.org/show_bug.cgi?id=65430

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed to use set comparisons, because length
    of a set is wrong.
* Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Added some unit tests to actually catch
    regressions.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd expected results for Snow Leopard and earlier for fast/css/font-family-pictograph...
mitz@apple.com [Sun, 31 Jul 2011 20:32:58 +0000 (20:32 +0000)]
Add expected results for Snow Leopard and earlier for fast/css/font-family-pictograph.html

Fixes REGRESSION (r91777): fast/css/font-family-pictograph.html failing on SnowLeopard Intel Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=65433

* platform/mac-snowleopard/fast/css: Added.
* platform/mac-snowleopard/fast/css/font-family-pictograph-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG non-speculative JIT does not optimize PutByVal
fpizlo@apple.com [Sun, 31 Jul 2011 20:13:37 +0000 (20:13 +0000)]
DFG non-speculative JIT does not optimize PutByVal
https://bugs.webkit.org/show_bug.cgi?id=65424

Reviewed by Gavin Barraclough.

Added code to emit PutByVal inline fast path.

* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoThe JSC garbage collector returns memory to the operating system too
fpizlo@apple.com [Sun, 31 Jul 2011 19:03:51 +0000 (19:03 +0000)]
The JSC garbage collector returns memory to the operating system too
eagerly.
https://bugs.webkit.org/show_bug.cgi?id=65382

Reviewed by Oliver Hunt.

This introduces a memory reuse model similar to the one in FastMalloc.
A periodic scavenger thread runs in the background and returns half the
free memory to the OS on each timer fire.  New block allocations first
attempt to get the memory from the collector's internal pool, reverting
to OS allocation only when this pool is empty.

* heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::~Heap):
(JSC::Heap::destroy):
(JSC::Heap::waitForRelativeTimeWhileHoldingLock):
(JSC::Heap::waitForRelativeTime):
(JSC::Heap::blockFreeingThreadStartFunc):
(JSC::Heap::blockFreeingThreadMain):
(JSC::Heap::allocateBlock):
(JSC::Heap::freeBlocks):
(JSC::Heap::releaseFreeBlocks):
* heap/Heap.h:
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::destroy):
(JSC::MarkedBlock::MarkedBlock):
(JSC::MarkedBlock::initForCellSize):
(JSC::MarkedBlock::reset):
* heap/MarkedBlock.h:
* wtf/Platform.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Remove the parameterless WebFrame::createAssociatedURLLoader
commit-queue@webkit.org [Sun, 31 Jul 2011 16:30:46 +0000 (16:30 +0000)]
[Chromium] Remove the parameterless WebFrame::createAssociatedURLLoader
overload, and change the overload that takes WebURLLoaderOptions to
use a default value. This is equivalent to the original parameterless
overload.
https://bugs.webkit.org/show_bug.cgi?id=65280

Patch by Bill Budge <bbudge@chromium.org> on 2011-07-31
Reviewed by Darin Fisher.

* public/WebFrame.h:
* src/AssociatedURLLoader.cpp:
* src/AssociatedURLLoader.h:
* src/WebFrameImpl.cpp:
* src/WebFrameImpl.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Remove unused variable coreChild in WebCore::getChildForTable()
dbates@webkit.org [Sun, 31 Jul 2011 08:48:56 +0000 (08:48 +0000)]
[GTK] Remove unused variable coreChild in WebCore::getChildForTable()
https://bugs.webkit.org/show_bug.cgi?id=65427

This variable was unused when it was initially added in <http://trac.webkit.org/changeset/89660> (bug #62718)
and it is unused today. We should remove it. This will also resolve a compiler warning.

Reviewed by Xan Lopez.

* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(getChildForTable):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-31 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Sun, 31 Jul 2011 08:34:21 +0000 (08:34 +0000)]
2011-07-31  Daniel Bates  <dbates@webkit.org>

        Add missing semicolons to build fix attempt in <http://trac.webkit.org/changeset/92080>.

        * Source/autotools/symbols.filter:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-31 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Sun, 31 Jul 2011 08:18:48 +0000 (08:18 +0000)]
2011-07-31  Daniel Bates  <dbates@webkit.org>

        Some more fixes to the GTK build after r92059 (https://bugs.webkit.org/show_bug.cgi?id=65419).

        * Source/autotools/symbols.filter: Export symbols needed by Internals.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-31 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Sun, 31 Jul 2011 08:06:17 +0000 (08:06 +0000)]
2011-07-31  Daniel Bates  <dbates@webkit.org>

        Try again to fix the WinCairo Debug build after r92059 ( https://bugs.webkit.org/show_bug.cgi?id=65419).

        * win/WebKit2CFLite.def: Export symbols needed by Internals.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-31 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Sun, 31 Jul 2011 07:37:21 +0000 (07:37 +0000)]
2011-07-31  Daniel Bates  <dbates@webkit.org>

        Attempt to fix the WinCairo Debug build after r92059 (https://bugs.webkit.org/show_bug.cgi?id=65419).

        * WebKit.vcproj/WebKit_Cairo.def: Export some symbols.
        * WebKit.vcproj/WebKit_Cairo_debug.def: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-31 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Sun, 31 Jul 2011 07:16:01 +0000 (07:16 +0000)]
2011-07-31  Xan Lopez  <xlopez@igalia.com>

        Group dependencies CFLAGS together.

        * GNUmakefile.am: ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-31 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Sun, 31 Jul 2011 07:04:53 +0000 (07:04 +0000)]
2011-07-31  Daniel Bates  <dbates@webkit.org>

        Attempt to fix the GTK build after <http://trac.webkit.org/changeset/92059>
        (https://bugs.webkit.org/show_bug.cgi?id=65419).

        * GNUmakefile.am: Add $(CAIRO_CFLAGS) to libWebCoreInternals_la_CPPFLAGS.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Rolled DEPS.
commit-queue@webkit.org [Sun, 31 Jul 2011 06:47:07 +0000 (06:47 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-30

* DEPS:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-30 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Sun, 31 Jul 2011 06:44:55 +0000 (06:44 +0000)]
2011-07-30  Daniel Bates  <dbates@webkit.org>

        Fix the WinCairo Debug build after <http://trac.webkit.org/changeset/91914>
        (https://bugs.webkit.org/show_bug.cgi?id=64744)

        * WebCore.vcproj/WebCore.vcproj: Remove ContextShadowCairo.cpp from the build since this
          file was deleted in <http://trac.webkit.org/changeset/91914>.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-30 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Sun, 31 Jul 2011 06:36:25 +0000 (06:36 +0000)]
2011-07-30  Daniel Bates  <dbates@webkit.org>

        Fix my email address in the changelog entry for <http://trac.webkit.org/changeset/92072>.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-30 Daniel Bates <dbates@webkit.com>
dbates@webkit.org [Sun, 31 Jul 2011 06:29:13 +0000 (06:29 +0000)]
2011-07-30  Daniel Bates  <dbates@webkit.com>

        Fix the Chromium Linux Release Flexbot build after <http://trac.webkit.org/changeset/92004>
        (https://bugs.webkit.org/show_bug.cgi?id=65342)

        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::layoutBlock): Update the definition of RenderFlexibleBox::layoutBlock()
        to be consistent with its declaration in RenderFlexibleBox.h; Add argument layoutPass of type BlockLayoutPass.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG JIT speculation failure pass sometimes forgets to emit code to
fpizlo@apple.com [Sun, 31 Jul 2011 06:14:10 +0000 (06:14 +0000)]
DFG JIT speculation failure pass sometimes forgets to emit code to
move certain registers.
https://bugs.webkit.org/show_bug.cgi?id=65421

Reviewed by Oliver Hunt.

Restructured the offending loops (for gprs and fprs).  It's once again
possible to use spreadsheets on docs.google.com.

* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry to fix the Windows build after r92059.
mitz@apple.com [Sun, 31 Jul 2011 05:56:25 +0000 (05:56 +0000)]
Try to fix the Windows build after r92059.

* win/WebKit2.def: Export symbols needed by Internals.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate run-bindings-tests results after
abarth@webkit.org [Sun, 31 Jul 2011 04:46:17 +0000 (04:46 +0000)]
Update run-bindings-tests results after
http://trac.webkit.org/changeset/92068

* bindings/scripts/test/JS/JSTestCallback.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove inclusion of MainThread.h from Threading.h
paroga@webkit.org [Sun, 31 Jul 2011 02:23:31 +0000 (02:23 +0000)]
Remove inclusion of MainThread.h from Threading.h
https://bugs.webkit.org/show_bug.cgi?id=65081

Reviewed by Darin Adler.

Source/JavaScriptCore:

Add missing and remove unneeded include statements for MainThread.

* wtf/CryptographicallyRandomNumber.cpp:
* wtf/Threading.h:
* wtf/ThreadingPthreads.cpp:
* wtf/text/StringStatics.cpp:

Source/WebCore:

Add missing include statements for MainThread.

* bindings/js/DOMWrapperWorld.cpp:
* bindings/js/JSDOMWindowBase.cpp:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateCallbackImplementation):
* bindings/v8/DOMDataStore.cpp:
* bindings/v8/DOMWrapperWorld.cpp:
* bindings/v8/V8Binding.cpp:
* bindings/v8/V8DOMMap.cpp:
* bindings/v8/V8DOMWrapper.h:
* dom/EventTarget.cpp:
* fileapi/LocalFileSystem.cpp:
* loader/CrossOriginPreflightResultCache.cpp:
* loader/ResourceLoadScheduler.cpp:
* loader/WorkerThreadableLoader.cpp:
* loader/appcache/ApplicationCacheGroup.cpp:
* page/DOMWindow.cpp:
* page/History.cpp:
* page/SecurityOrigin.cpp:
* page/mac/EventHandlerMac.mm:
* platform/MIMETypeRegistry.cpp:
* platform/ThreadGlobalData.cpp:
* platform/ThreadTimers.cpp:
* platform/TreeShared.h:
* platform/audio/HRTFDatabaseLoader.cpp:
* platform/graphics/Font.cpp:
* platform/graphics/FontFallbackList.h:
* platform/graphics/FontFastPath.cpp:
* platform/graphics/Image.cpp:
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
* platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp:
* platform/graphics/cg/ImageBufferCG.cpp:
* platform/graphics/chromium/LayerRendererChromium.cpp:
* platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp:
* platform/mac/LocalizedStringsMac.mm:
* platform/mac/SharedBufferMac.mm:
* platform/network/BlobResourceHandle.cpp:
* platform/network/cf/DNSCFNet.cpp:
* platform/network/cf/LoaderRunLoopCF.cpp:
* platform/text/LocalizedNumberICU.cpp:
* platform/text/TextEncodingRegistry.cpp:
* platform/text/mac/LocalizedNumberMac.mm:
* platform/win/LocalizedStringsWin.cpp:
* storage/LocalStorageThread.cpp:
* storage/StorageAreaImpl.cpp:
* storage/StorageAreaSync.cpp:
* storage/StorageNamespaceImpl.cpp:
* storage/StorageSyncManager.cpp:
* webaudio/AsyncAudioDecoder.cpp:
* webaudio/AudioBufferSourceNode.cpp:
* webaudio/AudioContext.h
* webaudio/AudioContext.cpp:
* webaudio/AudioNode.cpp:
* webaudio/ConvolverNode.cpp:
* webaudio/OfflineAudioDestinationNode.cpp:
* webaudio/RealtimeAnalyser.cpp:
* webaudio/WaveShaperNode.cpp:
* websockets/WorkerThreadableWebSocketChannel.cpp:
* workers/WorkerMessagingProxy.cpp:

Source/WebKit/chromium:

Add missing include statements for MainThread.

* src/WebKit.cpp:
* src/WebViewImpl.cpp:
* tests/CCThreadTest.cpp:

Source/WebKit/gtk:

Add missing include statements for MainThread.

* webkit/webkitglobals.cpp:

Source/WebKit/mac:

Add missing include statements for MainThread.

* Carbon/CarbonWindowAdapter.mm:
* History/WebBackForwardList.mm:
* History/WebHistoryItem.mm:
* Misc/WebElementDictionary.mm:
* Misc/WebIconDatabase.mm:
* Misc/WebLocalizableStrings.mm:
* Plugins/Hosted/WebHostedNetscapePluginView.mm:
* Plugins/WebBaseNetscapePluginView.mm:
* Plugins/WebBasePluginPackage.mm:
* Plugins/WebNetscapePluginView.mm:
* WebCoreSupport/WebEditorClient.mm:
* WebCoreSupport/WebFrameLoaderClient.mm:
* WebView/WebArchive.mm:
* WebView/WebDataSource.mm:
* WebView/WebHTMLView.mm:
* WebView/WebResource.mm:
* WebView/WebTextIterator.mm:
* WebView/WebView.mm:
* WebView/WebViewData.mm:

Source/WebKit/qt:

Add missing include statements for MainThread.

* Api/qwebpage.cpp:

Source/WebKit/win:

Add missing include statements for MainThread.

* WebKitClassFactory.cpp:
* WebView.cpp:

Source/WebKit/wx:

Add missing include statements for MainThread.

* WebView.cpp:

Source/WebKit2:

Add missing include statements for MainThread.

* PluginProcess/gtk/PluginProcessMainGtk.cpp:
* PluginProcess/mac/PluginProcessMainMac.mm:
* PluginProcess/qt/PluginProcessMainQt.cpp:
* UIProcess/API/mac/WKPrintingView.mm:
* UIProcess/Launcher/mac/ThreadLauncherMac.mm:
* UIProcess/Launcher/qt/ThreadLauncherQt.cpp:
* UIProcess/Launcher/win/ThreadLauncherWin.cpp:
* UIProcess/WebContext.cpp:
* WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:
* WebProcess/efl/WebProcessMainEfl.cpp:
* WebProcess/gtk/WebProcessMainGtk.cpp:
* WebProcess/mac/KeychainItemShimMethods.mm:
* WebProcess/mac/WebProcessMainMac.mm:
* WebProcess/qt/WebProcessMainQt.cpp:
* WebProcess/win/WebProcessMainWin.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix ports_unittest.py on native windows
paroga@webkit.org [Sun, 31 Jul 2011 01:19:56 +0000 (01:19 +0000)]
Fix ports_unittest.py on native windows
https://bugs.webkit.org/show_bug.cgi?id=64959

Reviewed by Adam Barth.

Replace WebKitPort.script_path with WebKitPort.script_shell_command.
The latter includes the interpreter executable required on native windows.

* Scripts/webkitpy/common/config/ports_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate baselines. This patch cleans up after http://trac.webkit.org/changeset/92042.
abarth@webkit.org [Sun, 31 Jul 2011 00:51:57 +0000 (00:51 +0000)]
Update baselines.  This patch cleans up after trac.webkit.org/changeset/92042.

* platform/chromium-mac/fast/repaint/absolute-position-change-containing-block-expected.png: Added.
* platform/chromium-mac/fast/repaint/absolute-position-changed-expected.png: Added.
* platform/chromium-mac/fast/repaint/absolute-position-moved-expected.png: Added.
* platform/chromium-mac/fast/repaint/fixed-and-absolute-position-scrolled-expected.png: Added.
* platform/chromium-mac/fast/repaint/fixed-position-transparency-with-overflow-expected.png: Added.
* platform/chromium-mac/fast/repaint/fixed-to-relative-position-with-absolute-child-expected.png: Added.
* platform/chromium-mac/fast/repaint/nested-iframe-scroll-inner-expected.png: Added.
* platform/chromium-mac/fast/repaint/nested-iframe-scroll-outer-expected.png: Added.
* platform/chromium-mac/fast/repaint/overflow-hide-expected.png: Added.
* platform/chromium-mac/fast/repaint/overflow-show-expected.png: Added.
* platform/chromium-win/fast/repaint/absolute-position-changed-expected.png: Added.
* platform/chromium-win/fast/repaint/fixed-and-absolute-position-scrolled-expected.png: Added.
* platform/chromium-win/fast/repaint/fixed-position-transparency-with-overflow-expected.png: Added.
* platform/chromium-win/fast/repaint/nested-iframe-scroll-inner-expected.png: Added.
* platform/chromium-win/fast/repaint/nested-iframe-scroll-outer-expected.png: Added.
* platform/chromium-win/fast/repaint/overflow-hide-expected.png: Added.
* platform/chromium-win/fast/repaint/overflow-show-expected.png: Added.
* platform/chromium/fast/repaint/absolute-position-changed-expected.png: Removed.
* platform/chromium/fast/repaint/fixed-and-absolute-position-scrolled-expected.png: Removed.
* platform/chromium/fast/repaint/fixed-position-transparency-with-overflow-expected.png: Removed.
* platform/chromium/fast/repaint/nested-iframe-scroll-inner-expected.png: Removed.
* platform/chromium/fast/repaint/nested-iframe-scroll-outer-expected.png: Removed.
* platform/chromium/fast/repaint/overflow-hide-expected.png: Removed.
* platform/chromium/fast/repaint/overflow-show-expected.png: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate more baselines. This completes the cleanup after
abarth@webkit.org [Sun, 31 Jul 2011 00:46:34 +0000 (00:46 +0000)]
Update more baselines.  This completes the cleanup after
http://trac.webkit.org/changeset/92047.

* platform/chromium-win-xp/svg/batik/paints/patternRegions-positioned-objects-expected.png: Removed.
* platform/chromium-win/svg/batik/filters/feTile-expected.png:
* platform/chromium-win/svg/batik/filters/feTile-expected.txt:
* platform/chromium-win/svg/batik/filters/filterRegions-expected.png:
* platform/chromium-win/svg/batik/filters/filterRegions-expected.txt:
* platform/chromium-win/svg/batik/paints/gradientLimit-expected.txt:
* platform/chromium-win/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
* platform/chromium-win/svg/batik/paints/patternRegionA-expected.txt:
* platform/chromium-win/svg/batik/paints/patternRegions-expected.txt:
* platform/chromium-win/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
* platform/chromium-win/svg/batik/text/textEffect2-expected.txt:
* platform/chromium-win/svg/batik/text/textFeatures-expected.png:
* platform/chromium-win/svg/batik/text/textFeatures-expected.txt:
* platform/chromium-win/svg/batik/text/textLayout-expected.png:
* platform/chromium-win/svg/batik/text/textLayout-expected.txt:
* platform/chromium-win/svg/batik/text/verticalTextOnPath-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMore baseline updates. (I'm going slowly because I'm using a new
abarth@webkit.org [Sun, 31 Jul 2011 00:39:54 +0000 (00:39 +0000)]
More baseline updates.  (I'm going slowly because I'm using a new
toolchain to do the rebaselining.)

* platform/chromium-linux/svg/batik/text/textOnPath-expected.png:
* platform/chromium-linux/svg/batik/text/textPosition2-expected.txt:
* platform/chromium-linux/svg/batik/text/verticalText-expected.txt: Removed.
* platform/chromium-win-xp/svg/batik/text/verticalText-expected.txt: Removed.
* platform/chromium-win/svg/batik/text/longTextOnPath-expected.png:
* platform/chromium-win/svg/batik/text/longTextOnPath-expected.txt:
* platform/chromium-win/svg/batik/text/textAnchor-expected.png:
* platform/chromium-win/svg/batik/text/textAnchor-expected.txt:
* platform/chromium-win/svg/batik/text/textDecoration-expected.txt:
* platform/chromium-win/svg/batik/text/textOnPath-expected.txt:
* platform/chromium-win/svg/batik/text/textPosition2-expected.txt:
* platform/chromium-win/svg/batik/text/textProperties-expected.png:
* platform/chromium-win/svg/batik/text/textProperties-expected.txt:
* platform/chromium-win/svg/batik/text/textProperties2-expected.png:
* platform/chromium-win/svg/batik/text/textProperties2-expected.txt:
* platform/chromium-win/svg/batik/text/textStyles-expected.png:
* platform/chromium-win/svg/batik/text/textStyles-expected.txt:
* platform/chromium-win/svg/batik/text/verticalText-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMore baseline updates. (I'm going slowly because I'm using a new
abarth@webkit.org [Sun, 31 Jul 2011 00:33:07 +0000 (00:33 +0000)]
More baseline updates.  (I'm going slowly because I'm using a new
toolchain to do the rebaselining.)

* platform/chromium-linux/svg/batik/text/textPosition-expected.txt:
* platform/chromium-win/svg/batik/text/textLayout2-expected.txt:
* platform/chromium-win/svg/batik/text/textOnPathSpaces-expected.txt:
* platform/chromium-win/svg/batik/text/textPosition-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate baseline.
abarth@webkit.org [Sun, 31 Jul 2011 00:25:04 +0000 (00:25 +0000)]
Update baseline.

* platform/chromium-win/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoProperly escape regular expressions. (Maybe these shouldn't be regular
abarth@webkit.org [Sun, 31 Jul 2011 00:05:27 +0000 (00:05 +0000)]
Properly escape regular expressions.  (Maybe these shouldn't be regular
expressions?)

* Scripts/webkitpy/tool/commands/rebaseline.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd support for Win7 to garden-o-matic.
abarth@webkit.org [Sat, 30 Jul 2011 23:57:55 +0000 (23:57 +0000)]
Add support for Win7 to garden-o-matic.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
* Scripts/webkitpy/tool/commands/rebaseline.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION: culledInlineAbsoluteRects needs to translate a 0,0 point to absolute
enrica@apple.com [Sat, 30 Jul 2011 23:51:31 +0000 (23:51 +0000)]
REGRESSION: culledInlineAbsoluteRects needs to translate a 0,0 point to absolute
coordinates so that the top left position is accurate.
https://bugs.webkit.org/show_bug.cgi?id=65419
<rdar://problem/9408862>

Source/WebCore:

This patch fixes a regression introduced in r83075.
Make sure that culledInlineAbsoluteRects still does
a translation of a 0,0 point to absolute coordinates so that the top left position is
accurate.
This code path could not be tested via JavaScript. The patch
extends the Internals object to be able to test this case.

Reviewed by Dan Bernstein.

Test: fast/inline/skipped-whitespace-boundingBox.html

* WebCore.exp.in: Added some exports.
* rendering/RenderInline.cpp:
(WebCore::RenderInline::culledInlineAbsoluteRects):
* testing/Internals.cpp:
(WebCore::Internals::boundingBox):
* testing/Internals.h:
* testing/Internals.idl:

LayoutTests:

Reviewed by Dan Bernstein.

* fast/inline/skipped-whitespace-boundingBox-expected.txt: Added.
* fast/inline/skipped-whitespace-boundingBox.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReduce the size of JSGlobalObject slightly
oliver@apple.com [Sat, 30 Jul 2011 23:10:19 +0000 (23:10 +0000)]
Reduce the size of JSGlobalObject slightly
https://bugs.webkit.org/show_bug.cgi?id=65417

Reviewed by Dan Bernstein.

Push a few members that either aren't commonly used,
or aren't frequently accessed into a separate struct.

* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::WeakMapsFinalizer::finalize):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::JSGlobalObjectRareData::JSGlobalObjectRareData):
(JSC::JSGlobalObject::createRareDataIfNeeded):
(JSC::JSGlobalObject::setProfileGroup):
(JSC::JSGlobalObject::profileGroup):
(JSC::JSGlobalObject::registerWeakMap):
(JSC::JSGlobalObject::deregisterWeakMap):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agogarden-o-matic regression ranges expand after fast bots start passing
abarth@webkit.org [Sat, 30 Jul 2011 18:27:23 +0000 (18:27 +0000)]
garden-o-matic regression ranges expand after fast bots start passing
https://bugs.webkit.org/show_bug.cgi?id=65406

Reviewed by Dimitri Glazkov.

Once the gardener has fixed a problem, the fast bots pick up the fix,
which means we end up using the slow bots to compute the regression
range.  Unfortunately, the slow bots give us large regression ranges,
leading to this strange effect where the regression range quality
degrades as fixes roll in.

This patch causes us to remember the previous regression ranges we've
seen and to use that information in the future, as long as it's
consistent with the new information we receive.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agogarden-o-matic should have a Refresh button to update its display
abarth@webkit.org [Sat, 30 Jul 2011 18:26:09 +0000 (18:26 +0000)]
garden-o-matic should have a Refresh button to update its display
https://bugs.webkit.org/show_bug.cgi?id=65403

Reviewed by Dimitri Glazkov.

The refresh button should be faster and less disruptive than the browser's reload button.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agogarden-o-matic should look for the "patch by" line in revisions ostensibly authored...
abarth@webkit.org [Sat, 30 Jul 2011 18:25:09 +0000 (18:25 +0000)]
garden-o-matic should look for the "patch by" line in revisions ostensibly authored by the commit-queue
https://bugs.webkit.org/show_bug.cgi?id=65231

Reviewed by Dimitri Glazkov.

The human readable name is easier to understand, especially when the patch is landed by the commit-queue.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agogarden-o-matic should strikeout revisions that have been rolled out
abarth@webkit.org [Sat, 30 Jul 2011 18:24:13 +0000 (18:24 +0000)]
garden-o-matic should strikeout revisions that have been rolled out
https://bugs.webkit.org/show_bug.cgi?id=65227

Reviewed by Dimitri Glazkov.

This helps gardeners keep track of which problems have been solved.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd missing files to the server.
abarth@webkit.org [Sat, 30 Jul 2011 18:12:47 +0000 (18:12 +0000)]
Add missing files to the server.

* Scripts/webkitpy/tool/servers/gardeningserver.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Fix the build afer r92014
kbalazs@webkit.org [Sat, 30 Jul 2011 17:39:44 +0000 (17:39 +0000)]
[Qt][WK2] Fix the build afer r92014
https://bugs.webkit.org/show_bug.cgi?id=65410

Reviewed by Noam Rosenthal.

* Shared/ShareableBitmap.h:
* UIProcess/qt/qdesktopwebpageproxy.cpp:
(QDesktopWebPageProxy::paintContent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: move location conversion functions to SourceFile.
podivilov@chromium.org [Sat, 30 Jul 2011 12:42:56 +0000 (12:42 +0000)]
Web Inspector: move location conversion functions to SourceFile.
https://bugs.webkit.org/show_bug.cgi?id=65185

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/source-file.html

* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._scriptLocationToUILocation.didCreateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._scriptLocationToUILocation):
(WebInspector.DebuggerPresentationModel.prototype._uiLocationToScriptLocation.didCreateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._uiLocationToScriptLocation):
* inspector/front-end/SourceFile.js:
(WebInspector.SourceFile.prototype.rawLocationToUILocation):
(WebInspector.SourceFile.prototype.uiLocationToRawLocation):
(WebInspector.SourceFile.prototype._scriptForRawLocation):
(WebInspector.SourceFile.prototype.createSourceMappingIfNeeded):
(WebInspector.FormattedSourceFile.prototype.createSourceMappingIfNeeded):
(WebInspector.FormattedSourceFile.prototype._didRequestContent):

LayoutTests:

* inspector/debugger/source-file-expected.txt: Added.
* inspector/debugger/source-file.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMessageQueue::waitForMessageFilteredWithTimeout can triggers an assertion
kbalazs@webkit.org [Sat, 30 Jul 2011 11:43:07 +0000 (11:43 +0000)]
MessageQueue::waitForMessageFilteredWithTimeout can triggers an assertion
https://bugs.webkit.org/show_bug.cgi?id=65263

Reviewed by Dmitry Titov.

* wtf/Deque.h:
(WTF::::operator): Don't check the validity of an iterator
that will be reassigned right now.
* wtf/MessageQueue.h:
(WTF::::removeIf): Revert r51198 as I beleave this is the better
solution for the problem that was solved by that.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Update platform specific expected files after r92047.
ossy@webkit.org [Sat, 30 Jul 2011 07:16:09 +0000 (07:16 +0000)]
[Qt] Update platform specific expected files after r92047.

* platform/qt-4.8/svg/batik/filters/filterRegions-expected.txt:
* platform/qt-4.8/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
* platform/qt-4.8/svg/batik/paints/patternRegionA-expected.txt:
* platform/qt-4.8/svg/batik/paints/patternRegions-expected.txt:
* platform/qt-4.8/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
* platform/qt-4.8/svg/batik/text/longTextOnPath-expected.txt:
* platform/qt-4.8/svg/batik/text/smallFonts-expected.txt:
* platform/qt-4.8/svg/batik/text/textAnchor-expected.txt:
* platform/qt-4.8/svg/batik/text/textDecoration-expected.txt:
* platform/qt-4.8/svg/batik/text/textEffect-expected.txt:
* platform/qt-4.8/svg/batik/text/textEffect2-expected.txt:
* platform/qt-4.8/svg/batik/text/textEffect3-expected.txt:
* platform/qt-4.8/svg/batik/text/textFeatures-expected.txt:
* platform/qt-4.8/svg/batik/text/textLayout2-expected.txt:
* platform/qt-4.8/svg/batik/text/textLength-expected.txt:
* platform/qt-4.8/svg/batik/text/textOnPath-expected.txt:
* platform/qt-4.8/svg/batik/text/textPosition-expected.txt:
* platform/qt-4.8/svg/batik/text/textPosition2-expected.txt:
* platform/qt-4.8/svg/batik/text/textProperties-expected.txt:
* platform/qt-4.8/svg/batik/text/textProperties2-expected.txt:
* platform/qt-4.8/svg/batik/text/verticalTextOnPath-expected.txt:
* platform/qt-mac/Skipped: Skip failing tests.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Update platform specific expected files after r92047.
ossy@webkit.org [Sat, 30 Jul 2011 06:48:34 +0000 (06:48 +0000)]
[Qt] Update platform specific expected files after r92047.

* platform/qt/svg/W3C-SVG-1.1/struct-use-05-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt:
* platform/qt/svg/batik/filters/filterRegions-expected.txt:
* platform/qt/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
* platform/qt/svg/batik/paints/patternRegionA-expected.txt:
* platform/qt/svg/batik/paints/patternRegions-expected.txt:
* platform/qt/svg/batik/paints/patternRegions-positioned-objects-expected.png:
* platform/qt/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
* platform/qt/svg/batik/text/longTextOnPath-expected.txt:
* platform/qt/svg/batik/text/smallFonts-expected.txt:
* platform/qt/svg/batik/text/textAnchor-expected.txt:
* platform/qt/svg/batik/text/textDecoration-expected.png:
* platform/qt/svg/batik/text/textDecoration-expected.txt:
* platform/qt/svg/batik/text/textEffect-expected.txt:
* platform/qt/svg/batik/text/textEffect2-expected.txt:
* platform/qt/svg/batik/text/textEffect3-expected.txt:
* platform/qt/svg/batik/text/textFeatures-expected.txt:
* platform/qt/svg/batik/text/textLayout2-expected.txt:
* platform/qt/svg/batik/text/textLength-expected.txt:
* platform/qt/svg/batik/text/textOnPath-expected.txt:
* platform/qt/svg/batik/text/textPosition-expected.txt:
* platform/qt/svg/batik/text/textPosition2-expected.txt:
* platform/qt/svg/batik/text/textProperties-expected.txt:
* platform/qt/svg/batik/text/textProperties2-expected.txt:
* platform/qt/svg/batik/text/verticalTextOnPath-expected.txt:
* platform/qt/svg/hixie/error/014-expected.txt:
* platform/qt/svg/hixie/use/002-expected.txt:
* svg/custom/external-paintserver-reference-expected.png:
* svg/custom/external-paintserver-reference-expected.txt:
* svg/custom/linking-base-external-reference-expected.png:
* svg/custom/linking-base-external-reference-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-29 Rob Buis <rbuis@rim.com>
rwlbuis@webkit.org [Sat, 30 Jul 2011 03:22:56 +0000 (03:22 +0000)]
2011-07-29  Rob Buis  <rbuis@rim.com>

        URL references are completely broken in SVG
        https://bugs.webkit.org/show_bug.cgi?id=63283

        Reviewed by Nikolas Zimmermann.

        Change SVGURIElement::getTarget to be more strict about iri resolving and make it serve as a central
        place to resolve a iri to a SVGElement. The iri can be same-document or external, for now we only handle
        the former, the latter will be handled in bug 65344.
        Accept as same-document if the iri combined with the base uri equals the document url (ignoring
        the fragment identifier). For convenience a method is added to lookup the element, if found.

        Tests: svg/custom/external-paintserver-reference.svg
               svg/custom/linking-base-external-reference.xhtml
               svg/custom/uri-reference-handling.svg

        * css/CSSCursorImageValue.cpp:
        (WebCore::resourceReferencedByCursorElement):
        (WebCore::CSSCursorImageValue::~CSSCursorImageValue):
        (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):
        * css/CSSFontFaceSource.cpp:
        (WebCore::CSSFontFaceSource::getFontData):
        * css/CSSFontSelector.h:
        (WebCore::CSSFontSelector::document):
        * css/SVGCSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applySVGProperty):
        * rendering/svg/RenderSVGTextPath.cpp:
        (WebCore::RenderSVGTextPath::layoutPath):
        * rendering/svg/SVGResources.cpp:
        (WebCore::targetReferenceFromResource):
        (WebCore::paintingResourceFromSVGPaint):
        * svg/SVGAltGlyphElement.cpp:
        (WebCore::SVGAltGlyphElement::hasValidGlyphElements):
        * svg/SVGFEImageElement.cpp:
        (WebCore::SVGFEImageElement::requestImageResource):
        (WebCore::SVGFEImageElement::build):
        * svg/SVGGlyphRefElement.cpp:
        (WebCore::SVGGlyphRefElement::hasValidGlyphElement):
        * svg/SVGLinearGradientElement.cpp:
        (WebCore::SVGLinearGradientElement::collectGradientAttributes):
        * svg/SVGMPathElement.cpp:
        (WebCore::SVGMPathElement::pathElement):
        * svg/SVGPaint.cpp:
        (WebCore::SVGPaint::matchesTargetURI):
        * svg/SVGPatternElement.cpp:
        (WebCore::SVGPatternElement::collectPatternAttributes):
        * svg/SVGRadialGradientElement.cpp:
        (WebCore::SVGRadialGradientElement::collectGradientAttributes):
        * svg/SVGTRefElement.cpp:
        (WebCore::SVGTRefElement::updateReferencedText):
        (WebCore::SVGTRefElement::svgAttributeChanged):
        (WebCore::SVGTRefElement::buildPendingResource):
        * svg/SVGTextPathElement.cpp:
        (WebCore::SVGTextPathElement::insertedIntoDocument):
        * svg/SVGURIReference.cpp:
        (WebCore::SVGURIReference::fragmentIdentifierFromIRIString):
        (WebCore::SVGURIReference::targetElementFromIRIString):
        * svg/SVGURIReference.h:
        * svg/SVGUseElement.cpp:
        (WebCore::SVGUseElement::buildPendingResource):
        (WebCore::SVGUseElement::hasCycleUseReferencing):
        (WebCore::SVGUseElement::expandUseElementsInShadowTree):
        * svg/animation/SVGSMILElement.cpp:
        (WebCore::SVGSMILElement::targetElement):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJSC GC zombie support no longer works, and is likely no longer needed.
fpizlo@apple.com [Sat, 30 Jul 2011 02:49:45 +0000 (02:49 +0000)]
JSC GC zombie support no longer works, and is likely no longer needed.
https://bugs.webkit.org/show_bug.cgi?id=65404

Reviewed by Darin Adler.

This removes zombies, because they no longer work, are not tested, are
probably not needed, and are getting in the way of GC optimization
work.

* JavaScriptCore.xcodeproj/project.pbxproj:
* heap/Handle.h:
(JSC::HandleConverter::operator->):
(JSC::HandleConverter::operator*):
* heap/HandleHeap.cpp:
(JSC::HandleHeap::isValidWeakNode):
* heap/Heap.cpp:
(JSC::Heap::destroy):
(JSC::Heap::collect):
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::sweep):
* heap/MarkedBlock.h:
(JSC::MarkedBlock::clearMarks):
* interpreter/Register.h:
(JSC::Register::Register):
(JSC::Register::operator=):
* runtime/ArgList.h:
(JSC::MarkedArgumentBuffer::append):
(JSC::ArgList::ArgList):
* runtime/JSCell.cpp:
(JSC::isZombie):
* runtime/JSCell.h:
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::clearBuiltinStructures):
* runtime/JSGlobalData.h:
* runtime/JSValue.h:
* runtime/JSValueInlineMethods.h:
(JSC::JSValue::JSValue):
* runtime/JSZombie.cpp: Removed.
* runtime/JSZombie.h: Removed.
* runtime/WriteBarrier.h:
(JSC::WriteBarrierBase::setEarlyValue):
(JSC::WriteBarrierBase::operator*):
(JSC::WriteBarrierBase::setWithoutWriteBarrier):
* wtf/Platform.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rebaseline, gardener stuff.
zmo@google.com [Sat, 30 Jul 2011 02:26:49 +0000 (02:26 +0000)]
Unreviewed, rebaseline, gardener stuff.

* platform/chromium-win-vista/fast/text/backslash-to-yen-sign-expected.png: Removed.
* platform/chromium-win-vista/fast/text/international/hindi-spacing-expected.png:
* platform/chromium-win-vista/fast/text/international/khmer-selection-expected.png: Added.
* platform/chromium-win-xp/fast/text/backslash-to-yen-sign-euc-expected.png:
* platform/chromium-win-xp/fast/text/backslash-to-yen-sign-expected.png:
* platform/chromium-win-xp/fast/text/international/hindi-spacing-expected.png:
* platform/chromium-win-xp/fast/text/international/khmer-selection-expected.png:
* platform/chromium-win-xp/svg/batik/text/verticalText-expected.png:
* platform/chromium-win/fast/text/backslash-to-yen-sign-euc-expected.png:
* platform/chromium-win/fast/text/backslash-to-yen-sign-expected.png:
* platform/chromium-win/fast/text/international/hindi-spacing-expected.png:
* platform/chromium-win/fast/text/international/khmer-selection-expected.png:
* platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
* platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
* platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
* platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
* platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
* platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
* platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
* platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
* platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
* platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
* platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
* platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
* platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
* platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
* platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
* platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.png:
* platform/chromium-win/svg/batik/text/verticalText-expected.png:
* platform/chromium-win/svg/css/text-shadow-multiple-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoActually import the logging module!
abarth@webkit.org [Sat, 30 Jul 2011 02:17:08 +0000 (02:17 +0000)]
Actually import the logging module!

* Scripts/webkitpy/common/checkout/scm/git.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMore debug logging. Maybe we're running the git version of this
abarth@webkit.org [Sat, 30 Jul 2011 02:14:00 +0000 (02:14 +0000)]
More debug logging.  Maybe we're running the git version of this
function somehow?  (That would explain why it doesn't work!)

* Scripts/webkitpy/common/checkout/scm/git.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd more testing to RenderLayer [ct'd]
jchaffraix@webkit.org [Sat, 30 Jul 2011 02:12:54 +0000 (02:12 +0000)]
Add more testing to RenderLayer [ct'd]
https://bugs.webkit.org/show_bug.cgi?id=65059

Reviewed by James Robinson.

This change adds testing with <iframe>, position: absolute elements and scrolling.

* fast/repaint/absolute-position-change-containing-block.html: Added.
* fast/repaint/absolute-position-changed.html: Added.
* fast/repaint/absolute-position-moved.html: Added.
* fast/repaint/fixed-and-absolute-position-scrolled.html: Added.
* fast/repaint/fixed-position-transparency-with-overflow.html: Added.
* fast/repaint/fixed-to-relative-position-with-absolute-child.html: Added.
* fast/repaint/nested-iframe-scroll-inner.html: Added.
* fast/repaint/nested-iframe-scroll-outer.html: Added.
* fast/repaint/overflow-hide.html: Added.
* fast/repaint/overflow-show.html: Added.
New test cases.

* fast/repaint/resources/iframe-inner.html: Added.
* fast/repaint/resources/iframe-outer.html: Added.

* fast/repaint/resources/default.css:
Added more shared code here.

* fast/repaint/absolute-position-change-containing-block-expected.png: Added.
* fast/repaint/absolute-position-change-containing-block-expected.txt: Added.
* fast/repaint/absolute-position-changed-expected.txt: Added.
* fast/repaint/absolute-position-moved-expected.png: Added.
* fast/repaint/absolute-position-moved-expected.txt: Added.
* fast/repaint/fixed-and-absolute-position-scrolled-expected.txt: Added.
* fast/repaint/fixed-position-transparency-with-overflow-expected.txt: Added.
* fast/repaint/fixed-to-relative-position-with-absolute-child-expected.png: Added.
* fast/repaint/fixed-to-relative-position-with-absolute-child-expected.txt: Added.
* fast/repaint/nested-iframe-scroll-inner-expected.txt: Added.
* fast/repaint/nested-iframe-scroll-outer-expected.txt: Added.
* fast/repaint/overflow-hide-expected.txt: Added.
* fast/repaint/overflow-show-expected.txt: Added.

* platform/chromium/fast/repaint/absolute-position-changed-expected.png: Added.
* platform/chromium/fast/repaint/fixed-and-absolute-position-scrolled-expected.png: Added.
* platform/chromium/fast/repaint/fixed-position-transparency-with-overflow-expected.png: Added.
* platform/chromium/fast/repaint/nested-iframe-scroll-inner-expected.png: Added.
* platform/chromium/fast/repaint/nested-iframe-scroll-outer-expected.png: Added.
* platform/chromium/fast/repaint/overflow-hide-expected.png: Added.
* platform/chromium/fast/repaint/overflow-show-expected.png: Added.
* platform/mac/fast/repaint/absolute-position-changed-expected.png: Added.
* platform/mac/fast/repaint/fixed-and-absolute-position-scrolled-expected.png: Added.
* platform/mac/fast/repaint/fixed-position-transparency-with-overflow-expected.png: Added.
* platform/mac/fast/repaint/nested-iframe-scroll-inner-expected.png: Added.
* platform/mac/fast/repaint/nested-iframe-scroll-outer-expected.png: Added.

* platform/mac/fast/repaint/overflow-hide-expected.png: Added.
* platform/mac/fast/repaint/overflow-show-expected.png: Added.
Those 2 results are strange and a bug will be opened about them.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove zipcar.com site specific hack added in r87361
simonjam@chromium.org [Sat, 30 Jul 2011 02:11:24 +0000 (02:11 +0000)]
Remove zipcar.com site specific hack added in r87361
https://bugs.webkit.org/show_bug.cgi?id=65405

Reviewed by Adam Barth.

* html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::insertedIntoDocument):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92041 268f45cc-cd09-0410-ab3c-d52691b4dbfc