WebKit.git
10 years agoSkip fast/canvas/set-colors.html on Windows
aroben@apple.com [Thu, 3 Feb 2011 18:07:38 +0000 (18:07 +0000)]
Skip fast/canvas/set-colors.html on Windows

It currently fails on some bots but not others.  <http://webkit.org/b/53677> tracks the
investigation.

* platform/win/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate Windows results after r77485
aroben@apple.com [Thu, 3 Feb 2011 18:02:25 +0000 (18:02 +0000)]
Update Windows results after r77485

Windows used to match Mac on these tests, but now it doesn't. Presumably this is because
r77485 increased the precision of ascent/descent calculations, making differences in
Windows/Mac font metrics matter more.

One test (svg/W3C-SVG-1.1-SE/types-dom-01-b.svg) is still failing, but it passes when run on
its own, so warrants more investigation.

* platform/win/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.checksum: Added.
* platform/win/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png: Added.
* platform/win/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt:
* platform/win/svg/W3C-SVG-1.1/text-align-06-b-expected.checksum: Added.
* platform/win/svg/W3C-SVG-1.1/text-align-06-b-expected.png: Added.
* platform/win/svg/W3C-SVG-1.1/text-align-06-b-expected.txt: Added.
* platform/win/svg/batik/text/textGlyphOrientationHorizontal-expected.checksum: Added.
* platform/win/svg/batik/text/textGlyphOrientationHorizontal-expected.png: Added.
* platform/win/svg/batik/text/textGlyphOrientationHorizontal-expected.txt: Added.
* platform/win/svg/carto.net/scrollbar-expected.checksum: Added.
* platform/win/svg/carto.net/scrollbar-expected.png: Added.
* platform/win/svg/carto.net/scrollbar-expected.txt: Added.
* platform/win/svg/text/font-size-below-point-five-expected.checksum: Added.
* platform/win/svg/text/font-size-below-point-five-expected.png: Added.
* platform/win/svg/text/font-size-below-point-five-expected.txt: Added.
* platform/win/svg/text/text-align-06-b-expected.checksum: Added.
* platform/win/svg/text/text-align-06-b-expected.png: Added.
* platform/win/svg/text/text-align-06-b-expected.txt: Added.
* platform/win/svg/zoom/page/zoom-mask-with-percentages-expected.checksum: Added.
* platform/win/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
* platform/win/svg/zoom/page/zoom-mask-with-percentages-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 3 Feb 2011 18:00:34 +0000 (18:00 +0000)]
2011-02-03  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed.

        small text which is scaled to be large renders pixelated
        https://bugs.webkit.org/show_bug.cgi?id=12448

        First chunk, updating mac SVG pixel test baseline after r77485.

        * platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
...

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Update Qt specific expected results after r77495.
ossy@webkit.org [Thu, 3 Feb 2011 17:54:11 +0000 (17:54 +0000)]
Unreviewed. Update Qt specific expected results after r77495.

* platform/qt/fast/dom/Window/window-properties-expected.txt:
* platform/qt/fast/dom/Window/window-properties-performance-expected.txt: Copied from LayoutTests/fast/dom/Window/window-properties-performance-expected.txt.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Evan Martin <evan@chromium.org>
evan@chromium.org [Thu, 3 Feb 2011 17:49:44 +0000 (17:49 +0000)]
2011-02-02  Evan Martin  <evan@chromium.org>

        Reviewed by Tony Chang.

        [chromium] complex joining characters positioned in wrong place
        https://bugs.webkit.org/show_bug.cgi?id=53637

        Add a test that includes some characters that exhibited the problem.
        Unfortunately it's purely a rendering issue, so it is a pixel test.

        * platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.checksum: Added.
        * platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.png: Added.
        * platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.txt: Added.
        * platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html: Added.
2011-02-02  Evan Martin  <evan@chromium.org>

        Reviewed by Tony Chang.

        [chromium] complex joining characters positioned in wrong place
        https://bugs.webkit.org/show_bug.cgi?id=53637

        Provide the correct font metrics to Harfbuzz related to the font design space.
        There are used in some fonts for GPOS positioning.

        Test: platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html

        * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
        (WebCore::ComplexTextController::setupFontForScriptRun):
        (WebCore::ComplexTextController::allocHarfbuzzFont):
        * platform/graphics/chromium/FontPlatformDataLinux.cpp:
        (WebCore::FontPlatformData::FontPlatformData):
        (WebCore::FontPlatformData::emSizeInFontUnits):
        (WebCore::FontPlatformData::operator=):
        * platform/graphics/chromium/FontPlatformDataLinux.h:
        (WebCore::FontPlatformData::FontPlatformData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 3 Feb 2011 17:42:56 +0000 (17:42 +0000)]
2011-02-03  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed; remove the line I intended to remove.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 3 Feb 2011 17:36:52 +0000 (17:36 +0000)]
2011-02-03  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Chromium test expectation update for
        http://src.chromium.org/viewvc/chrome?view=rev&revision=73469

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 3 Feb 2011 17:28:41 +0000 (17:28 +0000)]
2011-02-02  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Kent Tamura.

        REGRESSION(r76147): Slider thumb position is not updated when value attribute is changed.
        https://bugs.webkit.org/show_bug.cgi?id=53634

        * fast/dom/HTMLInputElement/input-slider-update.html: Added.
        * platform/mac/fast/dom/HTMLInputElement/input-slider-update-expected.checksum: Added.
        * platform/mac/fast/dom/HTMLInputElement/input-slider-update-expected.png: Added.
        * platform/mac/fast/dom/HTMLInputElement/input-slider-update-expected.txt: Added.
2011-02-02  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Kent Tamura.

        REGRESSION(r76147): Slider thumb position is not updated when value attribute is changed.
        https://bugs.webkit.org/show_bug.cgi?id=53634

        Test: fast/dom/HTMLInputElement/input-slider-update.html

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::setValue): Added a call to InputType::valueChanged.
        * html/InputType.cpp:
        (WebCore::InputType::valueChanged): Added empty implementation.
        * html/InputType.h: Added def.
        * html/RangeInputType.cpp:
        (WebCore::RangeInputType::valueChanged): Added implementation that dirties layout
            bit on the thumb.
        * html/RangeInputType.h: Added def.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 3 Feb 2011 17:22:49 +0000 (17:22 +0000)]
2011-02-03  Dimitri Glazkov  <dglazkov@chromium.org>

        [Chromium] Update SVG baselines after r77485 for Windows.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Thu, 3 Feb 2011 17:15:15 +0000 (17:15 +0000)]
2011-02-02  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: do not share source frames between resources panel and scripts panel.
        https://bugs.webkit.org/show_bug.cgi?id=53584

        Currently, we show error messages only for resources. This change will allow showing error
        messages in source frame even when resource is not available (eval scripts, inlined scripts).

        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype.addMessage):
        (WebInspector.ConsoleView.prototype.clearMessages):
        * inspector/front-end/ResourceView.js:
        (WebInspector.ResourceView.recreateResourceView):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.FrameResourceTreeElement.prototype._setBubbleText):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._scriptSourceChanged):
        (WebInspector.ScriptsPanel.prototype.addConsoleMessage):
        (WebInspector.ScriptsPanel.prototype.clearConsoleMessages):
        (WebInspector.ScriptsPanel.prototype.reset):
        (WebInspector.ScriptsPanel.prototype._sourceFrameForScriptOrResource):
        (WebInspector.ScriptsPanel.prototype._sourceFrameForResource):
        (WebInspector.ScriptsPanel.prototype._sourceFrameForScript):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rebaseline Qt svg tests after r77485.
ossy@webkit.org [Thu, 3 Feb 2011 17:13:11 +0000 (17:13 +0000)]
Unreviewed, rebaseline Qt svg tests after r77485.

* platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.checksum:
* platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
* platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
* platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.checksum:
* platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt:
* platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.checksum:
* platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt:
* platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.checksum:
* platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png:
* platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
* platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum:
* platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.checksum:
* platform/qt/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
* platform/qt/svg/custom/stroke-width-large-expected.checksum:
* platform/qt/svg/custom/stroke-width-large-expected.png:
* platform/qt/svg/custom/stroke-width-large-expected.txt:
* platform/qt/svg/custom/text-rotated-gradient-expected.checksum:
* platform/qt/svg/custom/text-rotated-gradient-expected.png:
* platform/qt/svg/custom/text-rotated-gradient-expected.txt:
* platform/qt/svg/foreignObject/text-tref-02-b-expected.checksum:
* platform/qt/svg/foreignObject/text-tref-02-b-expected.png:
* platform/qt/svg/foreignObject/text-tref-02-b-expected.txt:
* platform/qt/svg/text/lengthAdjust-text-metrics-expected.checksum: Added.
* platform/qt/svg/text/lengthAdjust-text-metrics-expected.png: Added.
* platform/qt/svg/text/lengthAdjust-text-metrics-expected.txt:
* platform/qt/svg/text/select-textLength-spacing-squeeze-1-expected.checksum:
* platform/qt/svg/text/select-textLength-spacing-squeeze-1-expected.png:
* platform/qt/svg/text/select-textLength-spacing-squeeze-1-expected.txt:
* platform/qt/svg/text/select-textLength-spacing-squeeze-2-expected.checksum:
* platform/qt/svg/text/select-textLength-spacing-squeeze-2-expected.png:
* platform/qt/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
* platform/qt/svg/text/select-textLength-spacing-squeeze-3-expected.checksum:
* platform/qt/svg/text/select-textLength-spacing-squeeze-3-expected.png:
* platform/qt/svg/text/select-textLength-spacing-squeeze-3-expected.txt:
* platform/qt/svg/text/select-textLength-spacing-squeeze-4-expected.checksum:
* platform/qt/svg/text/select-textLength-spacing-squeeze-4-expected.png:
* platform/qt/svg/text/select-textLength-spacing-squeeze-4-expected.txt:
* platform/qt/svg/text/select-textLength-spacing-stretch-1-expected.checksum:
* platform/qt/svg/text/select-textLength-spacing-stretch-1-expected.png:
* platform/qt/svg/text/select-textLength-spacing-stretch-1-expected.txt:
* platform/qt/svg/text/select-textLength-spacing-stretch-2-expected.checksum:
* platform/qt/svg/text/select-textLength-spacing-stretch-2-expected.png:
* platform/qt/svg/text/select-textLength-spacing-stretch-2-expected.txt:
* platform/qt/svg/text/select-textLength-spacing-stretch-3-expected.checksum:
* platform/qt/svg/text/select-textLength-spacing-stretch-3-expected.png:
* platform/qt/svg/text/select-textLength-spacing-stretch-3-expected.txt:
* platform/qt/svg/text/select-textLength-spacing-stretch-4-expected.checksum:
* platform/qt/svg/text/select-textLength-spacing-stretch-4-expected.png:
* platform/qt/svg/text/select-textLength-spacing-stretch-4-expected.txt:
* platform/qt/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.checksum:
* platform/qt/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.png:
* platform/qt/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt:
* platform/qt/svg/text/select-x-list-1-expected.checksum:
* platform/qt/svg/text/select-x-list-1-expected.png:
* platform/qt/svg/text/select-x-list-1-expected.txt:
* platform/qt/svg/text/select-x-list-2-expected.checksum:
* platform/qt/svg/text/select-x-list-2-expected.png:
* platform/qt/svg/text/select-x-list-2-expected.txt:
* platform/qt/svg/text/select-x-list-3-expected.checksum:
* platform/qt/svg/text/select-x-list-3-expected.png:
* platform/qt/svg/text/select-x-list-3-expected.txt:
* platform/qt/svg/text/select-x-list-4-expected.checksum:
* platform/qt/svg/text/select-x-list-4-expected.png:
* platform/qt/svg/text/select-x-list-4-expected.txt:
* platform/qt/svg/text/select-x-list-with-tspans-1-expected.checksum:
* platform/qt/svg/text/select-x-list-with-tspans-1-expected.png:
* platform/qt/svg/text/select-x-list-with-tspans-1-expected.txt:
* platform/qt/svg/text/select-x-list-with-tspans-2-expected.checksum:
* platform/qt/svg/text/select-x-list-with-tspans-2-expected.png:
* platform/qt/svg/text/select-x-list-with-tspans-2-expected.txt:
* platform/qt/svg/text/select-x-list-with-tspans-3-expected.checksum:
* platform/qt/svg/text/select-x-list-with-tspans-3-expected.png:
* platform/qt/svg/text/select-x-list-with-tspans-3-expected.txt:
* platform/qt/svg/text/select-x-list-with-tspans-4-expected.checksum:
* platform/qt/svg/text/select-x-list-with-tspans-4-expected.png:
* platform/qt/svg/text/select-x-list-with-tspans-4-expected.txt:
* platform/qt/svg/text/selection-doubleclick-expected.checksum:
* platform/qt/svg/text/selection-doubleclick-expected.png:
* platform/qt/svg/text/selection-doubleclick-expected.txt:
* platform/qt/svg/text/selection-tripleclick-expected.checksum:
* platform/qt/svg/text/selection-tripleclick-expected.png:
* platform/qt/svg/text/selection-tripleclick-expected.txt:
* platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.checksum:
* platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.png:
* platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
* platform/qt/svg/zoom/page/zoom-coords-viewattr-01-b-expected.checksum: Added.
* platform/qt/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
* platform/qt/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
* platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.checksum:
* platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.png:
* platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 3 Feb 2011 16:58:45 +0000 (16:58 +0000)]
2011-02-03  Simon Fraser  <simon.fraser@apple.com>

        Fix 32-bit builds.

        * platform/graphics/ShadowBlur.cpp:
        (WebCore::ShadowBlur::blurLayerImage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Thu, 3 Feb 2011 16:32:32 +0000 (16:32 +0000)]
2011-02-03  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Add reporting of JS heap size limit to 'console.memory'.
        https://bugs.webkit.org/show_bug.cgi?id=53592

        In JSC there is no limit, thus 'undefined' value is returned.
        For V8, the limit reported by the VM is returned.

        * Android.jscbindings.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSBindingsAllInOne.cpp:
        * bindings/js/JSMemoryInfoCustom.cpp: Added.
        * bindings/js/ScriptGCEvent.cpp:
        (WebCore::ScriptGCEvent::getHeapSize):
        * bindings/js/ScriptGCEvent.h:
        * bindings/v8/ScriptGCEvent.cpp:
        (WebCore::ScriptGCEvent::getHeapSize):
        * bindings/v8/ScriptGCEvent.h:
        * inspector/InspectorTimelineAgent.cpp:
        (WebCore::InspectorTimelineAgent::setHeapSizeStatistic):
        * page/MemoryInfo.cpp:
        (WebCore::MemoryInfo::MemoryInfo):
        * page/MemoryInfo.h:
        (WebCore::MemoryInfo::jsHeapSizeLimit):
        * page/MemoryInfo.idl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 3 Feb 2011 16:29:19 +0000 (16:29 +0000)]
2011-01-27  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] LayoutTests/media/audio-mpeg4-supported.html fails
        https://bugs.webkit.org/show_bug.cgi?id=53125

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::mimeTypeCache): Add audio/x-m4a mimetype in the cache.

LayoutTests:

2011-01-27  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] LayoutTests/media/audio-mpeg4-supported.html fails
        https://bugs.webkit.org/show_bug.cgi?id=53125

        * platform/gtk/Skipped: Unskip fixed test.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 3 Feb 2011 16:19:02 +0000 (16:19 +0000)]
2011-02-03  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skipping 2 more websocket tests on GTK, see bug 53683.

        * platform/gtk/Skipped: skip http/tests/websocket/tests/simple.html
        and http/tests/websocket/tests/cross-origin.html

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 3 Feb 2011 16:10:10 +0000 (16:10 +0000)]
2011-02-03  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Sam Weinig.

        ShadowBlur radius for CSS shadows is slightly too big
        https://bugs.webkit.org/show_bug.cgi?id=53660

        If we follow SVG gaussian blur for CSS shadows, we can end up rendering
        shadows that extend further than the CSS "blur radius", which results
        in the shadows being truncated.

        Fix with a small fudge factor to reduce the kernel diameter slightly
        for CSS shadows.

        Also more closely follow the algorithm described in the SVG spec
        for computing the kernel size for different diameters, and clean up
        some variable naming relating to the shadow bounds.

        * platform/graphics/ShadowBlur.cpp:
        (WebCore::ShadowBlur::blurLayerImage):
        (WebCore::ShadowBlur::drawRectShadowWithTiling):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Thu, 3 Feb 2011 16:02:48 +0000 (16:02 +0000)]
2011-02-03  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Darin Adler.

        Avoid strlen() in AtomicString::fromUTF8
        https://bugs.webkit.org/show_bug.cgi?id=50516

        Add an overload to calculateStringHashFromUTF8 to get
        strlen() of the input data with only one call.

        This change shows about 3% performance win on the xml-parser benchmark.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * wtf/text/AtomicString.cpp:
        (WTF::AtomicString::fromUTF8):
        * wtf/unicode/UTF8.cpp:
        (WTF::Unicode::calculateStringHashAndLengthFromUTF8Internal):
        (WTF::Unicode::calculateStringHashFromUTF8):
        (WTF::Unicode::calculateStringHashAndLengthFromUTF8):
        * wtf/unicode/UTF8.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 3 Feb 2011 15:51:32 +0000 (15:51 +0000)]
2011-02-03  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, rebaseline GTK svg tests after r77485.

        * platform/gtk/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
        * platform/gtk/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt:
        * platform/gtk/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt:
        * platform/gtk/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
        * platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
        * platform/gtk/svg/css/composite-shadow-text-expected.txt:
        * platform/gtk/svg/css/group-with-shadow-expected.txt:
        * platform/gtk/svg/css/shadow-changes-expected.txt:
        * platform/gtk/svg/css/text-gradient-shadow-expected.txt:
        * platform/gtk/svg/custom/stroke-width-large-expected.txt:
        * platform/gtk/svg/custom/text-rotated-gradient-expected.txt:
        * platform/gtk/svg/custom/text-rotation-expected.txt:
        * platform/gtk/svg/foreignObject/text-tref-02-b-expected.txt:
        * platform/gtk/svg/hixie/text/001-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacing-squeeze-1-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacing-squeeze-3-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacing-squeeze-4-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacing-stretch-1-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacing-stretch-2-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacing-stretch-3-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacing-stretch-4-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt:
        * platform/gtk/svg/text/select-x-list-1-expected.txt:
        * platform/gtk/svg/text/select-x-list-2-expected.txt:
        * platform/gtk/svg/text/select-x-list-3-expected.txt:
        * platform/gtk/svg/text/select-x-list-4-expected.txt:
        * platform/gtk/svg/text/select-x-list-with-tspans-1-expected.txt:
        * platform/gtk/svg/text/select-x-list-with-tspans-2-expected.txt:
        * platform/gtk/svg/text/select-x-list-with-tspans-3-expected.txt:
        * platform/gtk/svg/text/select-x-list-with-tspans-4-expected.txt:
        * platform/gtk/svg/text/selection-doubleclick-expected.txt:
        * platform/gtk/svg/text/selection-tripleclick-expected.txt:
        * platform/gtk/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
        * platform/gtk/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-01 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Thu, 3 Feb 2011 15:24:41 +0000 (15:24 +0000)]
2011-02-01  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: introduce new api for managing JavaScript breakpoints.
        https://bugs.webkit.org/show_bug.cgi?id=53235

        * inspector/report-protocol-errors.html:
2011-02-01  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: introduce new api for managing JavaScript breakpoints.
        https://bugs.webkit.org/show_bug.cgi?id=53235

        Single protocol breakpoint (e.g. set by url) is mapped on zero or more VM breakpoints (set by sourceID).
        removeJavaScriptBreakpoint(breakpointId) removes breakpoint and all linked VM breakpoints.
        Since UI uses VM breakpoint location rather then protocol breakpoint location, all resolved breakpoints locations are passed to frontend.

        SourceFrame is now aware of whether breakpoint is resolved or not and may display it accordingly.
        JavaScriptBreakpointsSidebarPane filters out breakpoints set on nonexistent scripts to avoid UI cluttering.

        * bindings/js/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::setBreakpoint):
        (WebCore::ScriptDebugServer::removeBreakpoint):
        * bindings/js/ScriptDebugServer.h:
        * bindings/v8/DebuggerScript.js:
        ():
        * bindings/v8/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::setBreakpoint):
        * bindings/v8/ScriptDebugServer.h:
        * inspector/Inspector.idl:
        * inspector/InspectorAgent.cpp: clear breakpoints from inspector state when new frontend is created
        (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
        (WebCore::InspectorAgent::populateScriptObjects):
        (WebCore::InspectorAgent::restoreDebugger):
        (WebCore::InspectorAgent::showAndEnableDebugger):
        (WebCore::InspectorAgent::enableDebugger):
        * inspector/InspectorAgent.h:
        * inspector/InspectorDebuggerAgent.cpp: manage relations between protocol breakpoints and VM breakpoints
        (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
        (WebCore::InspectorDebuggerAgent::inspectedURLChanged):
        (WebCore::InspectorDebuggerAgent::setJavaScriptBreakpoint):
        (WebCore::InspectorDebuggerAgent::setJavaScriptBreakpointBySourceId):
        (WebCore::InspectorDebuggerAgent::removeJavaScriptBreakpoint):
        (WebCore::InspectorDebuggerAgent::continueToLocation):
        (WebCore::InspectorDebuggerAgent::resolveBreakpoint):
        (WebCore::InspectorDebuggerAgent::getScriptSource):
        (WebCore::InspectorDebuggerAgent::didParseSource):
        (WebCore::InspectorDebuggerAgent::didPause):
        * inspector/InspectorDebuggerAgent.h:
        (WebCore::InspectorDebuggerAgent::Script::Script):
        * inspector/InspectorValues.cpp:
        (WebCore::InspectorValue::asNumber):
        (WebCore::InspectorBasicValue::asNumber):
        (WebCore::InspectorObject::remove):
        * inspector/InspectorValues.h:
        (WebCore::InspectorObject::getNumber):
        (WebCore::InspectorObject::find):
        * inspector/ScriptBreakpoint.h:
        (WebCore::ScriptBreakpoint::ScriptBreakpoint):
        * inspector/front-end/Breakpoint.js:
        (WebInspector.Breakpoint):
        (WebInspector.Breakpoint.prototype.addLocation):
        * inspector/front-end/BreakpointManager.js: remove all stuff related to JavaScript breakpoints from here
        (WebInspector.BreakpointManager):
        (WebInspector.BreakpointManager.prototype._projectChanged):
        (WebInspector.BreakpointManager.prototype._saveBreakpoints):
        (WebInspector.BreakpointManager.prototype._validateBreakpoints):
        * inspector/front-end/BreakpointsSidebarPane.js:
        (WebInspector.JavaScriptBreakpointsSidebarPane): filter breakpoints set on nonexistent scripts to avoid ui cluttering
        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerModel): pull all JavaScript from localStorage and push them to fronted when debugger is enabled, save resolved breakpoints data
        * inspector/front-end/Script.js:
        (WebInspector.Script.prototype.sourceLine):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._toggleDebugging):
        * inspector/front-end/Settings.js:
        (WebInspector.Settings):
        * inspector/front-end/SourceFrame.js: handle resolved and unresolved breakpoints differently
        * inspector/front-end/inspector.js:
2011-02-01  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: introduce new api for managing JavaScript breakpoints.
        https://bugs.webkit.org/show_bug.cgi?id=53235

        * src/WebDevToolsAgentImpl.cpp:
        (WebKit::WebDevToolsAgent::shouldInterruptForMessage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 3 Feb 2011 15:22:07 +0000 (15:22 +0000)]
2011-02-03  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip flaky websocket tests on GTK
        https://bugs.webkit.org/show_bug.cgi?id=53683

        * platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Thu, 3 Feb 2011 15:15:37 +0000 (15:15 +0000)]
2011-02-03  Alexander Pavlov  <apavlov@chromium.org>

        Unreviewed, fix build after r77478.

        * inspector/styles-source-lines-inline.html: Roll back inadvertent function rename.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 3 Feb 2011 14:57:35 +0000 (14:57 +0000)]
2011-02-03  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip flaky test
        fast/frames/sandboxed-iframe-scripting.html on GTK
        https://bugs.webkit.org/show_bug.cgi?id=53680

        * platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 3 Feb 2011 14:46:25 +0000 (14:46 +0000)]
2011-02-03  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        small text which is scaled to be large renders pixelated
        https://bugs.webkit.org/show_bug.cgi?id=12448

        SVG <text> with font-size smaller or equal to 1 does not paint correctly
        https://bugs.webkit.org/show_bug.cgi?id=14242

        misplaced text in SVG
        https://bugs.webkit.org/show_bug.cgi?id=17053

        Don't render very small (but zoomed) text inside SVG
        https://bugs.webkit.org/show_bug.cgi?id=19393

        Tiny fonts scaled up end up too large in Safari
        https://bugs.webkit.org/show_bug.cgi?id=20192

        Stretched SVG Text has awful glyph spacing
        https://bugs.webkit.org/show_bug.cgi?id=21774

        REGRESSION (r72141?): svg/batik/text/smallFonts.svg failing on Leopard
        https://bugs.webkit.org/show_bug.cgi?id=49846

        [Gtk] Text height in zoomed SVG is 1px too high
        https://bugs.webkit.org/show_bug.cgi?id=50313

        SVG text smaller than 0.5px not displayed properly
        https://bugs.webkit.org/show_bug.cgi?id=50528

        When rendering text, we're selecting a font with a size, as specified in the markup.
        This can lead to problems, if the context, where the text is rendered upon, is scaled. If a parent
        element of the <text> defines a transform=".." or the outermost <svg> containing a viewBox the
        problem becomes apparent.

        Consider following two snippets, which should render exactly the same:
        <svg viewBox="0 0 100 100"><text x="25" y="50" font-size="25">test</text></svg>
        <svg viewBox="0 0 1 1"><text x="0.25" y="0.5" font-size="0.25">test</text></svg>

        When selecting a font size below 0.5, FontCacheMac would request a font with size 0,
        which AppKit turns into 12. This lead to huge text rendering, instead of small text on Mac.
        Other platforms have different problems (Qt simply scales the font, leading to pixelation etc.)

        To fix this in a cross-platform fashion, we now always compute the final font size on screen,
        remove any scaling from the context, draw the text using the scaled font size, then reapply
        the context scale. This makes the example snippets above render exactly the same and fixes
        numerous of bugs, present since years. As we're now heavily using floating-point font sizes
        internally, depending on the scale of the document, it's very important to use the new
        floating-point text metrics information (floatAscent/floatDescent/floatHeight) everywhere in SVG.

        Fixes existing tests: css3/zoom-coords.xhtml (cross-platform inconsistencies should be gone, mac now reports floatHeight values for SVG text height)
                              svg/hixie/text/003.html (no more pixelation)
                              svg/batik/text/smallFonts.svg (small fonts aren't rendered huge anymore on mac)
                              svg/hixie/viewbox/preserveAspectRatio/001.xml (bug 21774, no more awful spacing)
                              svg/zoom/page/zoom-zoom-coords.xhtml (cross-platform inconsistencies should be gone, inspired by bug 50313)

        Tests: svg/text/font-size-below-point-five-2.svg (reduction from bug 50528)
               svg/text/font-size-below-point-five.svg (reduction from bug 50528)
               svg/text/scaled-font.svg (reduction from bug 12448)
               svg/text/small-fonts-2.svg (reduction from bug 14242)
               svg/text/small-fonts-3.svg (reduction from bug 17053)
               svg/text/small-fonts-in-html5.html (reduction from bug 19393)
               svg/text/small-fonts.svg (reduction from bug 20192))

        * rendering/svg/RenderSVGInlineText.cpp: Cache 'float scalingFactor' & 'Font scaledFont', whenever the on-screen representation changes.
        * rendering/svg/RenderSVGInlineText.h:
        * rendering/svg/RenderSVGText.cpp: Update scalingFactor/scaledFont, if necessary.
        * rendering/svg/SVGInlineTextBox.cpp: Switch to new font rendering strategy. Always use scaledFont, and remove any context scale before drawing.
        * rendering/svg/SVGInlineTextBox.h:
        * rendering/svg/SVGTextLayoutEngineBaseline.cpp: Use floating-point metrics everywhere.
        * rendering/svg/SVGTextMetrics.cpp: Ditto.
        * rendering/svg/SVGTextMetrics.h: Ditto.
        * rendering/svg/SVGTextQuery.cpp: Ditto.
        * svg/SVGFont.cpp: Adjust stroke thickness, when drawing SVGFonts into a normalized context (no more scale).
        * svg/SVGTextContentElement.cpp: Make <text> elements always dependant on window size changes in combination with viewBox set.
        * svg/SVGTextPositioningElement.cpp: Remove now unnecessary code to determine wheter relative lengths are used as text attributes.
        * svg/SVGTextPositioningElement.h:

2011-02-03  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        small text which is scaled to be large renders pixelated
        https://bugs.webkit.org/show_bug.cgi?id=12448

        Update SVG test results after fixing small font size support. Land new mac/mac-leopard baseline, as text looks slightly different
        in each testcase, as the font-size used for on-screen rendering has changed, this results in hinting differences, inter-glyph
        space changes, etc. This commit only includes the textual result changes, the pixel test baseline will land in chunks in follow-up commits.

        To those who have to rebaseline their platforms: Some of the svg/text pixel test results may look questionable on first sight,
        - svg/text/select-* tests:
          These tests render a certain string 'Foobar' and query the metrics using SVG Text DOM API (getExtentOfChar(firstChar) and getExtentOfChar(lastChar)).
          A red rectangle is drawn, to represent the size of the string, which gives precise results using floating-point accurancy.
          Using eventSender, a selection is simulated, by clicking the first char, holding down, and moving towards the last character.
          The blue selection rect which is drawn, should in theory be equal to the red rectangle.
          In practice it is not, as the selection rect is aligned to integer boundaries (see floor calls in Font::selectionRect...).
          Since we switched to use floating-point precision metrics, the actual drawn selection may exceed the red rectangle up to 1px.

        - svg/text/selection-(doubleclick|tripleclick).svg:
          These tests use DRTs dumpSelectionRect() which draws a red rectangle, highlighting the SelectionController::bounds() obtained through RenderView.
          In theory this red rectangle, should be equal to the drawn blue selection rect. Again it isn't, as the bounds() methods uses selectionRectForRepaint()
          of RenderText, which returns an enclosingIntRect of the actual selection. The drawn selection starts at y=0.93 in the first testcase, the selectionRectForRepaint()
          call returns an IntRect, which starts at y=0. That explains why the red rectangle starts slightly higher as it should be. Again this is no problem, the repaint
          rect may be 1px larger, if it would be smaller, we had a problem. The only way to fix this, would be to pass around FloatRect as repaint rects, but that's not worth it.

        - css3/zoom-coords.* / svg/zoom/page/zoom-zoom-coords*:
          These tests have different expectations now, as we're using the floatAscent/floatDesent/floatHeight FontMetrics methods instead of
          the integer variants ascent/descent/height - hopefully we'll see consistent results across platforms for these tests now, if not please comment in the bug report.

        * css3/zoom-coords-expected.txt:
        * css3/zoom-coords.xhtml:
        * platform/mac-leopard/Skipped:
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.checksum: Added.
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png: Added.
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt: Added.
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.checksum: Added.
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png: Added.
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt: Added.
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Added.
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt: Added.
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Added.
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum: Added.
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Added.
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Added.
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt: Added.
...

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Thu, 3 Feb 2011 14:38:58 +0000 (14:38 +0000)]
2011-02-03  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed.

        BUGCR71783 : scrollbars/custom-scrollbar-with-incomplete-style.html = IMAGE
        It is failing since r77459 by Sam Weinig.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSkip a new showModalDialog test on Windows
aroben@apple.com [Thu, 3 Feb 2011 14:22:41 +0000 (14:22 +0000)]
Skip a new showModalDialog test on Windows

showModalDialog support is now covered by <http://webkit.org/b/53675>.

I also sorted some sputnik tests that fail when showModalDialog is unsupported, and filed a
new bug (<http://webkit.org/b/53676>) about those failures, since it seems like those tests
should pass even when showModalDialog is unsupported.

* platform/win/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCheck in expected failure results for an RTL <select> test
aroben@apple.com [Thu, 3 Feb 2011 14:22:16 +0000 (14:22 +0000)]
Check in expected failure results for an RTL <select> test

The failure is covered by <http://webkit.org/b/53443>.

* platform/win/fast/text/international/bidi-menulist-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd Windows results for test added in r77153
aroben@apple.com [Thu, 3 Feb 2011 14:21:45 +0000 (14:21 +0000)]
Add Windows results for test added in r77153

* platform/win/fast/text/international/text-combine-image-test-expected.checksum: Added.
* platform/win/fast/text/international/text-combine-image-test-expected.png: Added.
* platform/win/fast/text/international/text-combine-image-test-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 3 Feb 2011 13:45:58 +0000 (13:45 +0000)]
2011-02-03  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: resources panel doesn't show frames after reload.
        https://bugs.webkit.org/show_bug.cgi?id=53430

        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype.show):
        (WebInspector.ResourcesPanel.prototype.loadEventFired):
        (WebInspector.ResourcesPanel.prototype._initDefaultSelection):
        (WebInspector.ResourcesPanel.prototype.reset):
        (WebInspector.ResourcesPanel.prototype.clear):
        * inspector/front-end/inspector.js:
        (WebInspector.loadEventFired):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
ossy@webkit.org [Thu, 3 Feb 2011 13:43:39 +0000 (13:43 +0000)]
Unreviewed.

[Qt]REGRESSION(r76951): media/controls-without-preload.html fails
https://bugs.webkit.org/show_bug.cgi?id=53674

* platform/qt/Skipped: media/controls-without-preload.html added until fix.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-01 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Thu, 3 Feb 2011 13:04:29 +0000 (13:04 +0000)]
2011-02-01  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Remove the *2 suffix from the CSS style-related protocol methods
        https://bugs.webkit.org/show_bug.cgi?id=53492

        WebCore:
        * inspector/Inspector.idl:
        * inspector/InspectorCSSAgent.cpp:
        (WebCore::InspectorCSSAgent::getStylesForNode):
        (WebCore::InspectorCSSAgent::getInlineStyleForNode):
        (WebCore::InspectorCSSAgent::getComputedStyleForNode):
        (WebCore::InspectorCSSAgent::getAllStyles):
        (WebCore::InspectorCSSAgent::getStyleSheet):
        (WebCore::InspectorCSSAgent::getStyleSheetText):
        (WebCore::InspectorCSSAgent::setStyleSheetText):
        (WebCore::InspectorCSSAgent::setPropertyText):
        (WebCore::InspectorCSSAgent::toggleProperty):
        (WebCore::InspectorCSSAgent::setRuleSelector):
        (WebCore::InspectorCSSAgent::addRule):
        * inspector/InspectorCSSAgent.h:
        * inspector/front-end/AuditRules.js:
        (WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
        * inspector/front-end/CSSStyleModel.js:
        (WebInspector.CSSStyleModel.prototype.getStylesAsync):
        (WebInspector.CSSStyleModel.prototype.getComputedStyleAsync):
        (WebInspector.CSSStyleModel.prototype.getInlineStyleAsync):
        (WebInspector.CSSStyleModel.prototype.setRuleSelector):
        (WebInspector.CSSStyleModel.prototype.addRule):
        (WebInspector.CSSStyleModel.prototype._styleSheetChanged):
        (WebInspector.CSSStyleModel.prototype._onRevert):
        (WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt):
        (WebInspector.CSSProperty.prototype.setText):
        (WebInspector.CSSProperty.prototype.setDisabled):
        (WebInspector.CSSStyleSheet.createForId):
        (WebInspector.CSSStyleSheet.prototype.setText):

        LayoutTests:
        * inspector/styles-iframe.html:
        * inspector/styles-new-API.html:
        * inspector/styles-source-lines-inline.html:
        * inspector/styles-source-lines.html:
        * inspector/styles-source-offsets.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 3 Feb 2011 12:52:16 +0000 (12:52 +0000)]
2011-02-03  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip flaky test
        fast/files/workers/worker-read-blob-async.html on GTK
        https://bugs.webkit.org/show_bug.cgi?id=53673

        * platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
rgabor@webkit.org [Thu, 3 Feb 2011 12:36:40 +0000 (12:36 +0000)]
Unreviewed.

Adding myself to committers.py.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
ossy@webkit.org [Thu, 3 Feb 2011 12:33:39 +0000 (12:33 +0000)]
Unreviewed.

[Qt] fast/dynamic/unicode-bidi.html fails
https://bugs.webkit.org/show_bug.cgi?id=53456

Add Qt specific expected files.

* platform/qt/fast/dynamic/unicode-bidi-expected.checksum: Added.
* platform/qt/fast/dynamic/unicode-bidi-expected.png: Added.
* platform/qt/fast/dynamic/unicode-bidi-expected.txt: Copied from LayoutTests/fast/dynamic/unicode-bidi-expected.txt.
* platform/qt/fast/text/bidi-embedding-pop-and-push-same-2-expected.checksum: Added.
* platform/qt/fast/text/bidi-embedding-pop-and-push-same-2-expected.png: Added.
* platform/qt/fast/text/bidi-embedding-pop-and-push-same-2-expected.txt: Copied from LayoutTests/fast/text/bidi-embedding-pop-and-push-same-2-expected.txt.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 3 Feb 2011 12:04:26 +0000 (12:04 +0000)]
2011-02-03  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, GTK baselines for 2 new tests added in r77267 and r77153.

        * platform/gtk/fast/dom/34176-expected.txt: Added.
        * platform/gtk/fast/text/international/text-combine-image-test-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Balazs Kelemen <kbalazs@webkit.org>
kbalazs@webkit.org [Thu, 3 Feb 2011 11:09:56 +0000 (11:09 +0000)]
2011-02-03  Balazs Kelemen  <kbalazs@webkit.org>

        Reviewed by Csaba Osztrogon√°c.

        [Qt][WK2] MiniBrowser's window size should be 800x600
        https://bugs.webkit.org/show_bug.cgi?id=53670

        Make layout test failure debugging easier.
        * MiniBrowser/qt/BrowserWindow.cpp:
        (BrowserWindow::BrowserWindow):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 3 Feb 2011 09:41:28 +0000 (09:41 +0000)]
2011-02-03  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip failing test
        fast/history/timed-refresh-in-cached-frame.html on GTK
        https://bugs.webkit.org/show_bug.cgi?id=53667

        * platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Thu, 3 Feb 2011 09:37:14 +0000 (09:37 +0000)]
2011-02-03  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Ryosuke Niwa.

        Skip some tests that fail in WebKit2 due to missing DRT functionality
        https://bugs.webkit.org/show_bug.cgi?id=53666

        * platform/mac-wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 3 Feb 2011 08:59:03 +0000 (08:59 +0000)]
2011-02-03  Adam Barth  <abarth@webkit.org>

        Reviewed by Daniel Bates.

        Teach XSSFilter about data URLs
        https://bugs.webkit.org/show_bug.cgi?id=53662

        Tests that the XSS filter doesn't block script in data URLs.

        * http/tests/security/xssAuditor/data-urls-work-expected.txt: Added.
        * http/tests/security/xssAuditor/data-urls-work.html: Added.
2011-02-03  Adam Barth  <abarth@webkit.org>

        Reviewed by Daniel Bates.

        Teach XSSFilter about data URLs
        https://bugs.webkit.org/show_bug.cgi?id=53662

        The XSS filter doesn't really make sense for data URLs because
        everything in a "response" from a data URL was part of the request.

        Test: http/tests/security/xssAuditor/data-urls-work.html

        * html/parser/XSSFilter.cpp:
        (WebCore::XSSFilter::init):
        (WebCore::XSSFilter::filterToken):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Thu, 3 Feb 2011 08:11:24 +0000 (08:11 +0000)]
2011-02-03  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r77449.
        http://trac.webkit.org/changeset/77449
        https://bugs.webkit.org/show_bug.cgi?id=53663

        causes many WebKit2 tests to crash (Requested by othermaciej
        on #webkit).

        * Shared/API/c/WKSharedAPICast.h:
        (WebKit::toAPI):
        (WebKit::toCopiedAPI):
        (WebKit::toURLRef):
        (WebKit::toCopiedURLAPI):
        * Shared/WebString.h:
        (WebKit::WebString::isNull):
        (WebKit::WebString::WebString):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Chris Evans <cevans@chromium.org>
commit-queue@webkit.org [Thu, 3 Feb 2011 06:21:07 +0000 (06:21 +0000)]
2011-02-02  Chris Evans  <cevans@chromium.org>

        Reviewed by Darin Fisher.

        window.find() can fail when switching case sensitivity
        https://bugs.webkit.org/show_bug.cgi?id=53654

        The test coverage for this area is very poor, so I took the liberty
        of adding a more general test than is needed.

        * fast/text/find-window.html: Added.
        * fast/text/find-window-expected.txt: Added.
2011-02-02  Chris Evans  <cevans@chromium.org>

        Reviewed by Darin Fisher.

        window.find() can fail when switching case sensitivity
        https://bugs.webkit.org/show_bug.cgi?id=53654

        Reset the pattern to a safe one when done, to avoid usearch_reset()
        indirectly touching the old, stale text pointer.

        Test: fast/text/find-window.html

        * editing/TextIterator.cpp:
        (WebCore::SearchBuffer::~SearchBuffer): leave a safe pattern buffer when done.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 3 Feb 2011 05:45:47 +0000 (05:45 +0000)]
2011-02-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Daniel Bates.

        Teach XSSFilter that <param> elements can contain URLs
        https://bugs.webkit.org/show_bug.cgi?id=53652

        When loading plugins for the <object> tag, we're "smart" enough to
        reach into the <param> elements and pull out the URL in some cases.
        This patch teaches the XSSFilter how to block injections into those
        sorts of param elements.

        Fixes:
            http/tests/security/xssAuditor/object-*

        * html/HTMLParamElement.cpp:
        (WebCore::HTMLParamElement::isURLParameter):
        (WebCore::HTMLParamElement::isURLAttribute):
        (WebCore::HTMLParamElement::addSubresourceAttributeURLs):
        * html/HTMLParamElement.h:
            - Add a helper function so that HTMLParamElement can share the
              ground truth for these names with the XSSFilter.
        * html/parser/XSSFilter.cpp:
        (WebCore::XSSFilter::filterTokenInitial):
        (WebCore::XSSFilter::filterParamToken):
        * html/parser/XSSFilter.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix license block issues pointed out by Daniel Bates.
weinig@apple.com [Thu, 3 Feb 2011 05:41:21 +0000 (05:41 +0000)]
Fix license block issues pointed out by Daniel Bates.

* Shared/API/c/WKGraphicsContext.cpp:
* Shared/API/c/WKGraphicsContext.h:
* Shared/API/c/cg/WKGraphicsContextCG.cpp:
* Shared/API/c/cg/WKGraphicsContextCG.h:
* Shared/WebGraphicsContext.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 3 Feb 2011 05:17:54 +0000 (05:17 +0000)]
2011-02-02  Martin Robinson  <mrobinson@igalia.com>

        Rebaseline two tests after import of editing test results for GTK+.
        Also remove a platform-specific baseline for a test which is now passing.

        * platform/gtk/editing/pasteboard/emacs-ctrl-a-k-y-expected.txt:
        * platform/gtk/editing/selection/find-yensign-and-backslash-expected.txt: Removed.
        * platform/gtk/fast/dom/52776-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 3 Feb 2011 04:40:58 +0000 (04:40 +0000)]
2011-02-02  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by David Levin.

        GCC compiler on ARM issues bogus warnings and fails to compile.
        https://bugs.webkit.org/show_bug.cgi?id=53620

        Despite warnings explicitly being disallowed (-Wno-uninitialized),
        gcc (Ubuntu 4.4.3-4ubuntu5) 4.4.3 throws up the warnings like:

        "error: 'colorTransparent.unstatic.4909' may be used uninitialized in this function"

        The fix is to add an extra condition, which somehow pacifies the compiler.

        * css/CSSPrimitiveValue.cpp:
        (WebCore::CSSPrimitiveValue::createColor): Added workaround conditions.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 3 Feb 2011 04:35:21 +0000 (04:35 +0000)]
2011-02-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Daniel Bates.

        Teach XSSFilter about X-XSS-Protection
        https://bugs.webkit.org/show_bug.cgi?id=53640

        This patch causes us to pass:
            http/tests/security/xssAuditor/full-block-*
            http/tests/security/xssAuditor/no-protection-script-tag.html

        * html/parser/XSSFilter.cpp:
        (WebCore::XSSFilter::XSSFilter):
        (WebCore::XSSFilter::init):
        (WebCore::XSSFilter::filterToken):
        * html/parser/XSSFilter.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 3 Feb 2011 04:23:06 +0000 (04:23 +0000)]
2011-02-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Daniel Bates.

        When XSSFilter blocks JavaScript URLs, use a safe JavaScript URL
        instead of the empty string
        https://bugs.webkit.org/show_bug.cgi?id=53643

        In a URL context, the empty string completes to the URL of the current
        page, which causes these tests to go into an infinite loop.  Instead,
        we should use a "safe" JavaScript URL that does nothing.

        Fixes:
            http/tests/security/xssAuditor/javascript-link*

        * html/parser/XSSFilter.cpp:
        (WebCore::XSSFilter::eraseDangerousAttributesIfInjected):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/8380506> REGRESSION (r61921): RTL text in <b> tag doesn't display...
mitz@apple.com [Thu, 3 Feb 2011 04:13:51 +0000 (04:13 +0000)]
<rdar://problem/8380506> REGRESSION (r61921): RTL text in <b> tag doesn't display in WebKit under certain conditions
https://bugs.webkit.org/show_bug.cgi?id=44942

Reviewed by Sam Weinig.

Source/WebCore:

Test: fast/text/bidi-embedding-pop-and-push-same-2.html

* platform/text/BidiResolver.h:
(WebCore::::commitExplicitEmbedding): Changed to return a boolean indicating whether there was
a change to embedding levels.
(WebCore::::createBidiRunsForLine): If embedding levels did not change as a result of committing
the explicit embedding sequence, then runs were not added, and we should continue normally.

LayoutTests:

* fast/text/bidi-embedding-pop-and-push-same-2-expected.checksum: Added.
* fast/text/bidi-embedding-pop-and-push-same-2-expected.png: Added.
* fast/text/bidi-embedding-pop-and-push-same-2-expected.txt: Added.
* fast/text/bidi-embedding-pop-and-push-same-2.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd WKBundleFrameGetVisibleContentBoundsExcludingScrollbars API for WebKit2.
weinig@apple.com [Thu, 3 Feb 2011 03:46:59 +0000 (03:46 +0000)]
Add WKBundleFrameGetVisibleContentBoundsExcludingScrollbars API for WebKit2.

Reviewed by Dan Bernstein.

* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameGetContentBounds):
(WKBundleFrameGetVisibleContentBounds):
(WKBundleFrameGetVisibleContentBoundsExcludingScrollbars):
(WKBundleFrameGetScrollOffset):
* WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::contentBounds):
(WebKit::WebFrame::visibleContentBounds):
(WebKit::WebFrame::visibleContentBoundsExcludingScrollbars):
(WebKit::WebFrame::scrollOffset):
* WebProcess/WebPage/WebFrame.h:
Move implementation of frame geometry to the implementation file
instead of keeping it in the API file.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix miscalculation of the overhang area used for painting. We were
weinig@apple.com [Thu, 3 Feb 2011 03:45:32 +0000 (03:45 +0000)]
Fix miscalculation of the overhang area used for painting. We were
not correctly accounting for scrollbars resulting in an non-negative
overhang even when we weren't over the edge.

Reviewed by Dan Bernstein.

* platform/ScrollView.cpp:
(WebCore::ScrollView::calculateOverhangAreasForPainting):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Kenneth Russell <kbr@google.com>
kbr@google.com [Thu, 3 Feb 2011 03:01:41 +0000 (03:01 +0000)]
2011-02-02  Kenneth Russell  <kbr@google.com>

        Reviewed by Mihai Parparita.

        gl-teximage.html failing on some WebKit bots
        https://bugs.webkit.org/show_bug.cgi?id=53633

        * fast/canvas/webgl/gl-teximage.html:
          - Synced with upstream test; detect when running in DRT and
            avoid printing the specific pixel value when the test will pass.
        * fast/canvas/webgl/resources/red-indexed.png:
          - Stripped gamma and other colorspace information.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago'update-webkit' should handle OpenSource and Internal using different
aestes@apple.com [Thu, 3 Feb 2011 02:39:42 +0000 (02:39 +0000)]
'update-webkit' should handle OpenSource and Internal using different
VCSs.

Reviewed by Mark Rowe.

* Scripts/update-webkit: Re-check the VCS type when updating Apple's
Internal directory.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Thu, 3 Feb 2011 02:24:03 +0000 (02:24 +0000)]
2011-02-02  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Nate Chapin.

        IDBTransaction and IDBRequest can be deleted while ScriptExecutionContext is iterating....which is bad
        https://bugs.webkit.org/show_bug.cgi?id=52722

        The solution is to change ScriptExecutionContext's destructor to iterate over
        the list in a way that handles the mutations. This new method is destructive,
        but that's OK since the object is going away. I've also added a several asserts.

        There should be no behavior change.

        * dom/ScriptExecutionContext.cpp:
        (WebCore::ScriptExecutionContext::ScriptExecutionContext):
        (WebCore::ScriptExecutionContext::~ScriptExecutionContext):
        (WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects):
        (WebCore::ScriptExecutionContext::suspendActiveDOMObjects):
        (WebCore::ScriptExecutionContext::resumeActiveDOMObjects):
        (WebCore::ScriptExecutionContext::stopActiveDOMObjects):
        (WebCore::ScriptExecutionContext::createdActiveDOMObject):
        (WebCore::ScriptExecutionContext::destroyedActiveDOMObject):
        * dom/ScriptExecutionContext.h:
        * storage/IDBTransaction.cpp:
        (WebCore::IDBTransaction::contextDestroyed):
        * storage/IDBTransaction.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix.
mrowe@apple.com [Thu, 3 Feb 2011 02:11:14 +0000 (02:11 +0000)]
Build fix.

* WebCore.exp.in: Remove some bogus symbols from the .exp.in file.
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::unregisterScrollbar): Look the object
up in the HashMap rather than relying on a local variable that doesn't
exist.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 3 Feb 2011 02:04:09 +0000 (02:04 +0000)]
2011-02-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Daniel Bates.

        Teach XSSFilter about JavaScript URLs
        https://bugs.webkit.org/show_bug.cgi?id=53635

        This patch teaches the XSSFilter to check for JavaScript URLs in
        attribute values.  If this approach has too many false positives, we
        can restrict which attribute names we examine.

        Fixes these tests:
            http/tests/security/xssAuditor/anchor-url-dom-write-location-javascript-URL.html
            http/tests/security/xssAuditor/dom-write-location-javascript-URL.html
            http/tests/security/xssAuditor/iframe-javascript-url*

        * html/parser/XSSFilter.cpp:
        (WebCore::HTMLNames::containsJavaScriptURL):
        (WebCore::XSSFilter::filterTokenInitial):
        (WebCore::XSSFilter::eraseDangerousAttributesIfInjected):
        * html/parser/XSSFilter.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 3 Feb 2011 02:00:28 +0000 (02:00 +0000)]
2011-02-02  Martin Robinson  <mrobinson@igalia.com>

        Unskip the last batch of editing tests needing GTK+ results.

        * platform/gtk/Skipped: Unskip last batch of tests.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=53361
slewis@apple.com [Thu, 3 Feb 2011 01:58:03 +0000 (01:58 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=53361
<rdar://problem/8921729> REGRESSION: Membuster accumulates 1GB+ memory due to autorelease
pools not being drained.
Call into AppKit to add observers that push and pop autorelease pools on entry
and exit from the CFRunLoop.  This will prevent memory from accumulating.

Reviewed by Geoff Garen.

* WebProcess/mac/WebProcessMainMac.mm:
(WebKit::WebProcessMain):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix.
mitz@apple.com [Thu, 3 Feb 2011 01:55:51 +0000 (01:55 +0000)]
Build fix.

* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 3 Feb 2011 01:54:48 +0000 (01:54 +0000)]
2011-02-02  Martin Robinson  <mrobinson@igalia.com>

        Add one more set of missing editing layout test results for GTK.

        * platform/gtk/Skipped: Unskip more editing tests.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake null WTF::String objects turn into 0 pointers for WKStringRef and WKURLRef.
darin@apple.com [Thu, 3 Feb 2011 01:51:57 +0000 (01:51 +0000)]
Make null WTF::String objects turn into 0 pointers for WKStringRef and WKURLRef.
rdar://problem/8948688

Reviewed by Sam Weinig.

* Shared/API/c/WKSharedAPICast.h:
(WebKit::toAPI): Return 0 if the passed in string is 0.
(WebKit::toCopiedAPI): Ditto.
(WebKit::toURLRef): Ditto. Old code was trying to do this but was missing a return.
(WebKit::toCopiedURLAPI): Ditto. Old code was trying to do this but had incorrect
nll check.

* Shared/WebString.h: Removed isNull function. It can never return true.
Removed constructor code that turns the null string into the empty string.
Instead assert that the passed in string is not null.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build fix.
barraclough@apple.com [Thu, 3 Feb 2011 01:48:54 +0000 (01:48 +0000)]
Windows build fix.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/8928367> Crash when loading canvas pages inside HTMLCanvasElement...
mrowe@apple.com [Thu, 3 Feb 2011 01:36:21 +0000 (01:36 +0000)]
<rdar://problem/8928367> Crash when loading canvas pages inside HTMLCanvasElement::createImageBuffer().

Reviewed by Beth Dakin.

Source/WebKit/mac:

* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Add some missing initializers.

Source/WebKit2:

* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Add some missing initializers.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/8952012> Crash on launch inside scrollbar code.
mrowe@apple.com [Thu, 3 Feb 2011 01:36:14 +0000 (01:36 +0000)]
<rdar://problem/8952012> Crash on launch inside scrollbar code.

Reviewed by Beth Dakin.

We need to ensure that we remove ourselves as the delegates of objects when we're going
away as failing to do this can lead to crashes if the lifetime of the other objects
is longer than ours.

* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::unregisterScrollbar):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agooops, build fix!
barraclough@apple.com [Thu, 3 Feb 2011 01:36:03 +0000 (01:36 +0000)]
oops, build fix!

* wtf/Assertions.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 3 Feb 2011 01:35:22 +0000 (01:35 +0000)]
2011-02-02  Martin Robinson  <mrobinson@igalia.com>

        Continue importing new editing layout test results for GTK.

        * platform/gtk/Skipped: Unskip more editing tests.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBug 53650 - Add a BACKTRACE macro to Assertions.h
barraclough@apple.com [Thu, 3 Feb 2011 01:31:17 +0000 (01:31 +0000)]
Bug 53650 - Add a BACKTRACE macro to Assertions.h

Reviewed by Sam Weinig.

Add a BACKTRACE macro to Assertions.h, which will print a backtrace on
debug Mac builds, make CRASH (and thus ASSERT) automatically call this.

* JavaScriptCore.exp:
* wtf/Assertions.cpp:
* wtf/Assertions.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix.
bdakin@apple.com [Thu, 3 Feb 2011 01:29:23 +0000 (01:29 +0000)]
Build fix.

* WebCore.exp.in:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 3 Feb 2011 01:20:32 +0000 (01:20 +0000)]
2011-02-02  Martin Robinson  <mrobinson@igalia.com>

        Begin importing missing editing directory test results.

        * platform/gtk/Skipped: Unskip tests with results and classify failures.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Thu, 3 Feb 2011 01:17:36 +0000 (01:17 +0000)]
2011-02-02  Michael Saboff  <msaboff@apple.com>

        Reviewed by Gavin Barraclough.

        Improper backtrack of nested non-capturing greedy paren to prior paren
        https://bugs.webkit.org/show_bug.cgi?id=53261

        A paren that follows a non-capturing greedy paren nested within a
        non-capturing fixed paren was back tracking to the last paren
        processed instead of the immediately prior paren.
        Refactored default backtracking of parens to prior paren to work for
        both nested (within) and immediately prior (after) parens.

        * yarr/YarrJIT.cpp:
        (JSC::Yarr::YarrGenerator::GenerationState::addParenthesesTail):
        (JSC::Yarr::YarrGenerator::TermGenerationState::TermGenerationState):
        (JSC::Yarr::YarrGenerator::TermGenerationState::setJumpListToPriorParen):
        (JSC::Yarr::YarrGenerator::TermGenerationState::getJumpListToPriorParen):
        (JSC::Yarr::YarrGenerator::ParenthesesTail::ParenthesesTail):
        (JSC::Yarr::YarrGenerator::ParenthesesTail::generateCode):
        (JSC::Yarr::YarrGenerator::generateParenthesesDisjunction):
        (JSC::Yarr::YarrGenerator::generateParenthesesSingle):
        (JSC::Yarr::YarrGenerator::generateDisjunction):
2011-02-02  Michael Saboff  <msaboff@apple.com>

        Reviewed by Gavin Barraclough.

        Improper backtrack of nested non-capturing greedy paren to prior paren
        https://bugs.webkit.org/show_bug.cgi?id=53261

        New tests to validate change.

        * fast/regex/parentheses-expected.txt:
        * fast/regex/script-tests/parentheses.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Thu, 3 Feb 2011 01:14:04 +0000 (01:14 +0000)]
2011-02-02  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed WinCE build fix for r77397.

        * page/wince/FrameWinCE.cpp:
        (WebCore::computePageRectsForFrame):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Thu, 3 Feb 2011 01:04:25 +0000 (01:04 +0000)]
2011-02-02  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed WinCE build fix for r77398.

        * platform/graphics/wince/PlatformPathWinCE.cpp:
        (WebCore::containsPoint):
        (WebCore::inflateRectToContainPoint):
        (WebCore::PlatformPath::addRect):
        * platform/graphics/wince/SharedBitmap.cpp:
        (WebCore::SharedBitmap::drawPattern):
        * rendering/RenderThemeWinCE.cpp:
        (WebCore::RenderThemeWinCE::paintMenuListButton):
        (WebCore::RenderThemeWinCE::paintSearchFieldCancelButton):
        (WebCore::RenderThemeWinCE::paintSliderTrack):
        (WebCore::RenderThemeWinCE::paintMediaMuteButton):
        (WebCore::RenderThemeWinCE::paintMediaPlayButton):
        (WebCore::RenderThemeWinCE::paintMediaSeekBackButton):
        (WebCore::RenderThemeWinCE::paintMediaSeekForwardButton):
2011-02-02  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed WinCE build fix for r77398.

        * WebView.cpp:
        (WebView::paint):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 3 Feb 2011 00:55:45 +0000 (00:55 +0000)]
2011-02-02  Eric Seidel  <eric@webkit.org>

        Unreviewed.  Just fixing an exception seen in Firefox.

        HTML5 TreeBuilder regressed a Peacekeeper DOM test by 40%
        https://bugs.webkit.org/show_bug.cgi?id=48719

        Make the benchmarks work in Firefox/Opera.

        * resources/runner.js:
        (log):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Evan Martin <evan@chromium.org>
evan@chromium.org [Thu, 3 Feb 2011 00:55:06 +0000 (00:55 +0000)]
2011-02-02  Evan Martin  <evan@chromium.org>

        Unreviewed, DEPS change.

        * DEPS: update to pick up newer Skia.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 3 Feb 2011 00:52:45 +0000 (00:52 +0000)]
2011-02-02  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Mihai Parparita.

        new-run-webkit-tests: hardcode the directories to scan for tests
        for GPU bots instead of SKIPping them. See bug 53562 for some
        context, but we will now hard-code the list of directories to
        use by default instead of skipping over directories in the
        expectations file. We do this so that we will be able to merge
        the expectations files without getting conflicting SKIP
        directives. Note that this change will reduce the # of tests
        being run on the Mac GPU bots, because we're accidentally
        including some today.

        https://bugs.webkit.org/show_bug.cgi?id=53631

        * platform/chromium-gpu/test_expectations.txt:
2011-02-02  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Mihai Parparita.

        new-run-webkit-tests: hardcode the directories to scan for tests
        for GPU bots instead of SKIPping them. See bug 53562 for some
        context, but we will now hard-code the list of directories to
        use by default instead of skipping over directories in the
        expectations file. We do this so that we will be able to merge
        the expectations files without getting conflicting SKIP
        directives. Note that this change will reduce the # of tests
        being run on the Mac GPU bots, because we're accidentally
        including some today.

        https://bugs.webkit.org/show_bug.cgi?id=53631

        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
        * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[V8] Accessing DataView with index of -1 returns 0, doesn't throw
jianli@chromium.org [Thu, 3 Feb 2011 00:52:12 +0000 (00:52 +0000)]
[V8] Accessing DataView with index of -1 returns 0, doesn't throw
https://bugs.webkit.org/show_bug.cgi?id=53559

Reviewed by Kenneth Russell.

Source/WebCore:

Added test cases to cover this in fast/canvas/webgl/data-view-test.html.

* html/canvas/DataView.h:
(WebCore::DataView::beyondRange):

LayoutTests:

* fast/canvas/webgl/data-view-test-expected.txt:
* fast/canvas/webgl/data-view-test.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd ChromeClient function to paint custom overhang areas.
weinig@apple.com [Thu, 3 Feb 2011 00:44:06 +0000 (00:44 +0000)]
Add ChromeClient function to paint custom overhang areas.
https://bugs.webkit.org/show_bug.cgi?id=53639

Reviewed by Beth Dakin.

Source/WebCore:

* page/Chrome.cpp:
(WebCore::ChromeClient::paintCustomOverhangArea):
* page/ChromeClient.h:
Add ChromeClient function.

* page/FrameView.cpp:
(WebCore::FrameView::paintOverhangAreas):
* page/FrameView.h:
Call out the the ChromeClient, call ScrollView base implementation
if the ChromeClient returns false.

* platform/ScrollView.cpp:
(WebCore::ScrollView::paintOverhangAreas):
* platform/ScrollView.h:
Add dirty rect for use when painting overhang areas.

Source/WebKit2:

* Shared/API/c/WKBase.h:
* Shared/API/c/WKGraphicsContext.cpp: Added.
(WKGraphicsContextGetTypeID):
* Shared/API/c/WKGraphicsContext.h: Added.
* Shared/API/c/WKSharedAPICast.h:
* Shared/API/c/cg/WKGraphicsContextCG.cpp: Added.
(WKGraphicsContextGetCGContext):
* Shared/API/c/cg/WKGraphicsContextCG.h: Added.
* Shared/APIObject.h:
* Shared/WebGraphicsContext.cpp: Added.
(WebKit::WebGraphicsContext::WebGraphicsContext):
* Shared/WebGraphicsContext.h: Added.
(WebKit::WebGraphicsContext::create):
(WebKit::WebGraphicsContext::platformContext):
(WebKit::WebGraphicsContext::type):
Add WebGraphicsContext API type.

* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
(WebKit::InjectedBundlePageUIClient::pageDidScroll):
(WebKit::InjectedBundlePageUIClient::shouldPaintCustomOverhangArea):
(WebKit::InjectedBundlePageUIClient::paintCustomOverhangArea):
* WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::paintCustomOverhangArea):
* WebProcess/WebCoreSupport/WebChromeClient.h:
Pipe paintCustomOverhangArea to the InjectedBundlePageUIClient.

* UIProcess/API/C/WebKit2.h:
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
* win/WebKit2Generated.make:
Add new files.

Tools:

* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
Stub out new callback.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 3 Feb 2011 00:33:29 +0000 (00:33 +0000)]
2011-02-02  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Tony Chang.

        new-run-webkit-tests: support chromium code paths in mock_drt

        https://bugs.webkit.org/show_bug.cgi?id=53471

        * Scripts/webkitpy/layout_tests/port/mock_drt.py:
        * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 3 Feb 2011 00:16:14 +0000 (00:16 +0000)]
2011-02-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Work towards making the layer tree host be in charge of all painting
        https://bugs.webkit.org/show_bug.cgi?id=53636

        Make sure that DrawingAreaImpl::display is never called when in accelerated compositing mode,
        since the layer tree host is supposed to handle all drawing in that case.

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::scroll):
        (WebKit::DrawingAreaImpl::setRootCompositingLayer):
        (WebKit::DrawingAreaImpl::setSize):
        (WebKit::DrawingAreaImpl::didUpdate):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNot reviewed, build fix.
pkasting@chromium.org [Wed, 2 Feb 2011 23:58:59 +0000 (23:58 +0000)]
Not reviewed, build fix.

Fix compile after r77427.
https://bugs.webkit.org/show_bug.cgi?id=53455

* platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::internalHandleCurrentImage):
* platform/image-decoders/ImageDecoder.cpp:
(WebCore::ImageFrame::operator=):
* platform/image-decoders/bmp/BMPImageReader.cpp:
(WebCore::BMPImageReader::decodeBMP):
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::JPEGImageDecoder::outputScanlines):
* platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::PNGImageDecoder::rowAvailable):
* platform/image-decoders/webp/WEBPImageDecoder.cpp:
(WebCore::WEBPImageDecoder::decode):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix the 32-bit build.
mrowe@apple.com [Wed, 2 Feb 2011 23:39:34 +0000 (23:39 +0000)]
Fix the 32-bit build.

* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::computeFakeWindowBoundsRect):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Peter Kasting <pkasting@google.com>
commit-queue@webkit.org [Wed, 2 Feb 2011 23:34:04 +0000 (23:34 +0000)]
2011-02-02  Peter Kasting  <pkasting@google.com>

        Reviewed by David Levin.

        Clean up ImageDecoder's comments (remove/trim/clarify).
        https://bugs.webkit.org/show_bug.cgi?id=53455

        This also renames or eliminates a couple of functions for clarity, and
        switches a couple erroneous strncmp() calls to memcmp().

        * platform/image-decoders/ImageDecoder.cpp:
        (WebCore::ImageDecoder::create):
        (WebCore::ImageFrame::clearPixelData):
        (WebCore::ImageFrame::zeroFillPixelData):
        (WebCore::ImageFrame::setSize):
        * platform/image-decoders/ImageDecoder.h:
        (WebCore::ImageFrame::originalFrameRect):
        (WebCore::ImageFrame::setOriginalFrameRect):
        (WebCore::ImageDecoder::ImageDecoder):
        (WebCore::ImageDecoder::~ImageDecoder):
        (WebCore::ImageDecoder::isSizeAvailable):
        (WebCore::ImageDecoder::size):
        (WebCore::ImageDecoder::setIgnoreGammaAndColorProfile):
        (WebCore::ImageDecoder::clearFrameBufferCache):
        (WebCore::ImageDecoder::isOverSize):
        * platform/image-decoders/bmp/BMPImageReader.cpp:
        (WebCore::BMPImageReader::processNonRLEData):
        * platform/image-decoders/cg/ImageDecoderCG.cpp:
        (WebCore::ImageFrame::setSize):
        * platform/image-decoders/gif/GIFImageDecoder.cpp:
        (WebCore::GIFImageDecoder::clearFrameBufferCache):
        (WebCore::GIFImageDecoder::frameComplete):
        (WebCore::GIFImageDecoder::initFrameBuffer):
        * platform/image-decoders/jpeg/JPEGImageDecoder.h:
        * platform/image-decoders/qt/ImageFrameQt.cpp:
        (WebCore::ImageFrame::operator=):
        (WebCore::ImageFrame::clearPixelData):
        (WebCore::ImageFrame::zeroFillPixelData):
        (WebCore::ImageFrame::setSize):
        * platform/image-decoders/skia/ImageDecoderSkia.cpp:
        (WebCore::ImageFrame::operator=):
        (WebCore::ImageFrame::clearPixelData):
        (WebCore::ImageFrame::zeroFillPixelData):
        (WebCore::ImageFrame::setSize):
        * platform/image-decoders/webp/WEBPImageDecoder.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 2 Feb 2011 23:32:39 +0000 (23:32 +0000)]
2011-01-27  Eric Seidel  <eric@webkit.org>

        Reviewed by Darin Adler.

        HTML5 TreeBuilder regressed a Peacekeeper DOM test by 40%
        https://bugs.webkit.org/show_bug.cgi?id=48719

        It's unclear exactly what the Peacekeeper benchmark is testing,
        because I haven't found a way to run it myself.

        However, I constructed a benchmark which shows at least one possible slow point.
        The HTML5 spec talks about creating a new document for every time we use
        the fragment parsing algorithm.  Document() it turns out, it a huge bloated
        mess, and the constructor and destructor do a huge amount of work.

        * benchmarks/parser/tiny-innerHTML.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Vangelis Kokkevis <vangelis@chromium.org>
vangelis@chromium.org [Wed, 2 Feb 2011 23:08:21 +0000 (23:08 +0000)]
2011-02-02  Vangelis Kokkevis  <vangelis@chromium.org>

        [chromium] Adding support for reflections to the accelerated
        compositing path.
        https://bugs.webkit.org/show_bug.cgi?id=53179

        All layout tests in compositing/reflections generate correct
        results with the exception of:
        1. nested-reflection-anchor-point.html : There appears to be
           some issue with the layer transform math that I haven't been
           able to track down yet.
        2. reflection-opacity.html : The current implementation applies
           opacity before doing the reflection which makes this test
           produce incorrect results.  This will affect reflected layers
           with opacity that overlap their original layer.  FIXME comment
           added in the code.

        Tests: Covered by existing layout tests in compositing/reflections.
               Please see above for exceptions.

        * platform/graphics/chromium/GraphicsLayerChromium.cpp:
        (WebCore::GraphicsLayerChromium::setReplicatedByLayer):
        (WebCore::GraphicsLayerChromium::updateAnchorPoint):
        * platform/graphics/chromium/GraphicsLayerChromium.h:
        * platform/graphics/chromium/LayerChromium.cpp:
        (WebCore::LayerChromium::LayerChromium):
        * platform/graphics/chromium/LayerChromium.h:
        (WebCore::LayerChromium::setReplicaLayer):
        (WebCore::LayerChromium::replicaLayer):
        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::updateLayersRecursive):
        (WebCore::LayerRendererChromium::drawLayer):
        * platform/graphics/chromium/RenderSurfaceChromium.cpp:
        (WebCore::RenderSurfaceChromium::drawableContentRect):
        (WebCore::RenderSurfaceChromium::drawSurface):
        (WebCore::RenderSurfaceChromium::draw):
        * platform/graphics/chromium/RenderSurfaceChromium.h:
        (WebCore::RenderSurfaceChromium::drawTransform):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Xiyuan Xia <xiyuan@chromium.org>
commit-queue@webkit.org [Wed, 2 Feb 2011 22:45:42 +0000 (22:45 +0000)]
2011-02-02  Xiyuan Xia  <xiyuan@chromium.org>

        Reviewed by Tony Chang.

        [Chromium] Select popup with padding has white strip on right
        https://bugs.webkit.org/show_bug.cgi?id=53602

        No new tests as this change restores old behavior.

        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupListBox::layout):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake sure that we don't try to call display() when in accelerated compositing mode
andersca@apple.com [Wed, 2 Feb 2011 22:45:09 +0000 (22:45 +0000)]
Make sure that we don't try to call display() when in accelerated compositing mode
https://bugs.webkit.org/show_bug.cgi?id=53629

Reviewed by Sam Weinig.

When in accelerated compositing mode, the layer tree host should handle all painting, so make sure that display() is never called.

* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::setNeedsDisplay):
(WebKit::DrawingAreaImpl::setRootCompositingLayer):
(WebKit::DrawingAreaImpl::display):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix for <rdar://problem/8950343> CrashTracer: [USER]
bdakin@apple.com [Wed, 2 Feb 2011 22:43:55 +0000 (22:43 +0000)]
Fix for <rdar://problem/8950343> CrashTracer: [USER]
1 crash in WebProcess at com.apple.WebCore:
WebCore::ScrollbarThemeMac::unregisterScrollbar + 22

Reviewed by Mark Rowe.

It is possible for a Scrollbar's ScrollableArea to be null,
so we must null check.
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::unregisterScrollbar):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Zhenyao Mo <zmo@google.com>
zmo@google.com [Wed, 2 Feb 2011 22:39:29 +0000 (22:39 +0000)]
2011-02-02  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        bufferData and bufferSubData should generate INVALID_VALUE with negative input
        https://bugs.webkit.org/show_bug.cgi?id=53626

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::bufferData):
        (WebCore::WebGLRenderingContext::bufferSubData):
2011-02-02  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        bufferData and bufferSubData should generate INVALID_VALUE with negative input
        https://bugs.webkit.org/show_bug.cgi?id=53626

        * fast/canvas/webgl/buffer-data-array-buffer-expected.txt:
        * fast/canvas/webgl/buffer-data-array-buffer.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd DerivedSources.make to some Visual Studio projects
aroben@apple.com [Wed, 2 Feb 2011 22:34:30 +0000 (22:34 +0000)]
Add DerivedSources.make to some Visual Studio projects

https://bugs.webkit.org/show_bug.cgi?id=53607

Patch by Jeff Miller <jeffm@apple.com> on 2011-02-02
Reviewed by Darin Adler and Steve Falkenburg.

Source/JavaScriptCore:

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj: Add DerivedSources.make.

Source/WebCore:

* WebCore.vcproj/WebCoreGenerated.vcproj: Add DerivedSources.make.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAssert WebBackForwardList's current index is valid to help catch errors
aroben@apple.com [Wed, 2 Feb 2011 22:33:55 +0000 (22:33 +0000)]
Assert WebBackForwardList's current index is valid to help catch errors

Hopefully this will help catch a crash I saw once but haven't yet been able to reproduce.

Fixes <http://webkit.org/b/53622>.

Reviewed by Brady Eidson.

* UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::WebBackForwardList):
(WebKit::WebBackForwardList::addItem):
(WebKit::WebBackForwardList::goToItem):
(WebKit::WebBackForwardList::currentItem):
(WebKit::WebBackForwardList::backItem):
(WebKit::WebBackForwardList::forwardItem):
(WebKit::WebBackForwardList::itemAtIndex):
(WebKit::WebBackForwardList::backListCount):
(WebKit::WebBackForwardList::forwardListCount):
(WebKit::WebBackForwardList::backListAsImmutableArrayWithLimit):
(WebKit::WebBackForwardList::forwardListAsImmutableArrayWithLimit):
(WebKit::WebBackForwardList::clear):
* UIProcess/cf/WebBackForwardListCF.cpp:
(WebKit::WebBackForwardList::createCFDictionaryRepresentation):
(WebKit::WebBackForwardList::restoreFromCFDictionaryRepresentation):
Assert that m_current is valid.

* UIProcess/WebBackForwardList.h: Moved the NoCurrentItemIndex to a static data member so
that it can be used from WebBackForwardListCF.cpp.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Cris Neckar <cdn@chromium.org>
inferno@chromium.org [Wed, 2 Feb 2011 22:25:49 +0000 (22:25 +0000)]
2011-02-02  Cris Neckar  <cdn@chromium.org>

        Reviewed by James Robinson.

        Tests for crash when a domwindow is removed within a device orientation event.
        https://bugs.webkit.org/show_bug.cgi?id=53623

        * fast/events/device-orientation-crash-expected.txt: Added.
        * fast/events/device-orientation-crash.html: Added.
2011-02-02  Cris Neckar  <cdn@chromium.org>

        Reviewed by James Robinson.

        Refcount domwindows when dispatching device orientation events.
        https://bugs.webkit.org/show_bug.cgi?id=53623

        Test: fast/events/device-orientation-crash.html

        * dom/DeviceMotionController.cpp:
        (WebCore::DeviceMotionController::timerFired):
        (WebCore::DeviceMotionController::didChangeDeviceMotion):
        * dom/DeviceMotionController.h:
        * dom/DeviceOrientationController.cpp:
        (WebCore::DeviceOrientationController::timerFired):
        (WebCore::DeviceOrientationController::didChangeDeviceOrientation):
        * dom/DeviceOrientationController.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Zhenyao Mo <zmo@google.com>
zmo@google.com [Wed, 2 Feb 2011 22:13:43 +0000 (22:13 +0000)]
2011-02-02  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        A deleted object should never been bound again
        https://bugs.webkit.org/show_bug.cgi?id=53604

        * fast/canvas/webgl/object-deletion-behaviour-expected.txt:
        * fast/canvas/webgl/object-deletion-behaviour.html: Add test cases for object binding and deletion.
2011-02-02  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        A deleted object should never been bound again
        https://bugs.webkit.org/show_bug.cgi?id=53604

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::checkObjectToBeBound): Helper function to bind* and useProgram.
        (WebCore::WebGLRenderingContext::bindBuffer): Use checkObjectToBeBound.
        (WebCore::WebGLRenderingContext::bindFramebuffer): Ditto.
        (WebCore::WebGLRenderingContext::bindRenderbuffer): Ditto.
        (WebCore::WebGLRenderingContext::bindTexture): Ditto, also check the target matching.
        (WebCore::WebGLRenderingContext::deleteObject): Helper funtion to delete*.
        (WebCore::WebGLRenderingContext::deleteBuffer): Use deleteObject.
        (WebCore::WebGLRenderingContext::deleteFramebuffer): Ditto.
        (WebCore::WebGLRenderingContext::deleteProgram): Ditto.
        (WebCore::WebGLRenderingContext::deleteRenderbuffer): Ditto.
        (WebCore::WebGLRenderingContext::deleteShader): Ditto.
        (WebCore::WebGLRenderingContext::deleteTexture): Ditto.
        (WebCore::WebGLRenderingContext::useProgram): Use checkObjectToBeBound.
        * html/canvas/WebGLRenderingContext.h:
        * html/canvas/WebGLTexture.h:
        (WebCore::WebGLTexture::getTarget): Accessor to cached target.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Wed, 2 Feb 2011 22:06:17 +0000 (22:06 +0000)]
2011-02-02  Alejandro G. Castro  <alex@igalia.com>

        Unreviewed Efl buildfix after r77399.

        * CMakeListsEfl.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Adam Klein <adamk@chromium.org>
commit-queue@webkit.org [Wed, 2 Feb 2011 21:59:46 +0000 (21:59 +0000)]
2011-02-02  Adam Klein  <adamk@chromium.org>

        Reviewed by Tony Chang.

        Update new-run-webkit-tests --chromium to put output under Source/...
        https://bugs.webkit.org/show_bug.cgi?id=53612

        * BuildSlaveSupport/test-result-archive:
        * Scripts/webkitpy/layout_tests/port/chromium.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Wed, 2 Feb 2011 21:49:53 +0000 (21:49 +0000)]
2011-02-02  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        Update the NEWS file in preparation for the 1.3.11 release.

        * NEWS: Update the NEWS.

2011-02-02  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        Bump the WebKitGTK+ versions in preparation for development release.

        * configure.ac: Bump the library, libtool and user agent version.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 2 Feb 2011 21:49:09 +0000 (21:49 +0000)]
2011-02-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        The drawing area proxy should keep track of the accelerated compositing state
        https://bugs.webkit.org/show_bug.cgi?id=53624

        * UIProcess/DrawingAreaProxyImpl.cpp:
        (WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl):
        Initialize m_isInAcceleratedCompositingMode to false.

        (WebKit::DrawingAreaProxyImpl::paint):
        Don't try to paint if we're in accelerated compositing mode.

        (WebKit::DrawingAreaProxyImpl::didSetSize):
        Bail if we're in accelerated compositing mode.

        (WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
        Set m_isInAcceleratedCompositingMode to true, null out the backing store.

        (WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode):
        Set m_isInAcceleratedCompositingMode back to false.

        (WebKit::DrawingAreaProxyImpl::incorporateUpdate):
        Assert that we're not in accelerated compositing mode.

        * UIProcess/DrawingAreaProxyImpl.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Kenneth Russell <kbr@google.com>
kbr@google.com [Wed, 2 Feb 2011 21:37:00 +0000 (21:37 +0000)]
2011-02-02  Kenneth Russell  <kbr@google.com>

        Reviewed by James Robinson.

        Rename Typed Array subset to subarray
        https://bugs.webkit.org/show_bug.cgi?id=53618

        * fast/canvas/webgl/array-setters.html:
        * fast/canvas/webgl/array-unit-tests-expected.txt:
        * fast/canvas/webgl/array-unit-tests.html:
        * fast/canvas/webgl/draw-elements-out-of-bounds-expected.txt:
        * fast/canvas/webgl/draw-elements-out-of-bounds.html:
        * fast/canvas/webgl/webgl-array-invalid-ranges-expected.txt:
        * fast/canvas/webgl/webgl-array-invalid-ranges.html:
2011-02-02  Kenneth Russell  <kbr@google.com>

        Reviewed by James Robinson.

        Rename Typed Array subset to subarray
        https://bugs.webkit.org/show_bug.cgi?id=53618

        * html/canvas/Float32Array.cpp:
        (WebCore::Float32Array::subarray):
        * html/canvas/Float32Array.h:
        * html/canvas/Float32Array.idl:
        * html/canvas/Int16Array.cpp:
        (WebCore::Int16Array::subarray):
        * html/canvas/Int16Array.h:
        * html/canvas/Int16Array.idl:
        * html/canvas/Int32Array.cpp:
        (WebCore::Int32Array::subarray):
        * html/canvas/Int32Array.h:
        * html/canvas/Int32Array.idl:
        * html/canvas/Int8Array.cpp:
        (WebCore::Int8Array::subarray):
        * html/canvas/Int8Array.h:
        * html/canvas/Int8Array.idl:
        * html/canvas/TypedArrayBase.h:
        (WebCore::TypedArrayBase::subarrayImpl):
        * html/canvas/Uint16Array.cpp:
        (WebCore::Uint16Array::subarray):
        * html/canvas/Uint16Array.h:
        * html/canvas/Uint16Array.idl:
        * html/canvas/Uint32Array.cpp:
        (WebCore::Uint32Array::subarray):
        * html/canvas/Uint32Array.h:
        * html/canvas/Uint32Array.idl:
        * html/canvas/Uint8Array.cpp:
        (WebCore::Uint8Array::subarray):
        * html/canvas/Uint8Array.h:
        * html/canvas/Uint8Array.idl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 2 Feb 2011 21:30:36 +0000 (21:30 +0000)]
2011-02-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add an empty file for Content Security Policy
        https://bugs.webkit.org/show_bug.cgi?id=53573

        Posting this as a separate patch because editing the build files is so
        painful.

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-28 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 2 Feb 2011 21:23:27 +0000 (21:23 +0000)]
2011-01-28  Tony Chang  <tony@chromium.org>

        Reviewed by Eric Seidel.

        [chromium] remove --use-test-shell from NRWT
        https://bugs.webkit.org/show_bug.cgi?id=53346

        I've already started removing some of the bindings like eventSender so
        this already doesn't work isn't useful.  Also updated some comments to
        refer to DRT instead of test_shell.

        * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
        * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
        * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium_win.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/test_types/text_diff.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoGive the Web Process access to the Safari RSS preferences.
timothy@apple.com [Wed, 2 Feb 2011 21:19:59 +0000 (21:19 +0000)]
Give the Web Process access to the Safari RSS preferences.

<rdar://problem/8916870> Sandbox violation related to RSS during initial
page load with WebKit2 (prevents RSS from working)

Reviewed by Darin Adler.

* WebProcess/com.apple.WebProcess.sb:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Dan Winship <danw@gnome.org>
mrobinson@webkit.org [Wed, 2 Feb 2011 21:19:41 +0000 (21:19 +0000)]
2011-02-02  Dan Winship  <danw@gnome.org>

        Reviewed by Martin Robinson.

        [GTK] remove old data: URI handler, fix the SoupRequest-based one
        to pass tests
        https://bugs.webkit.org/show_bug.cgi?id=50885

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::sendRequestCallback): Do content-type sniffing here for
        non-HTTP requests.
        (WebCore::startHTTPRequest): Rename to match WebKit style.
        (WebCore::ResourceHandle::start): Pass everything except HTTP to
        startNonHTTPRequest, letting the SoupRequester decide whether it's
        supported or not.
        (WebCore::startNonHTTPRequest): Remove some old pre-SoupRequester
        code that was a no-op for file: URIs, but would break some data:
        URIs.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 2 Feb 2011 21:18:44 +0000 (21:18 +0000)]
2011-02-02  Dimitri Glazkov  <dglazkov@chromium.org>

        Update even more references to right() and bottom() in Chromium. Sheesh.

        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::getFramebufferPixels): Replaced bottom/right with maxY/maxX.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77407 268f45cc-cd09-0410-ab3c-d52691b4dbfc