WebKit.git
10 years ago2009-09-29 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Tue, 29 Sep 2009 23:20:17 +0000 (23:20 +0000)]
2009-09-29  Daniel Bates  <dbates@webkit.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=29837

        More tests for the XSSAuditor.

        * http/tests/security/xssAuditor/embed-tag-javascript-url-expected.txt: Added.
        * http/tests/security/xssAuditor/embed-tag-javascript-url.html: Added.
        * http/tests/security/xssAuditor/meta-tag-http-refresh-javascript-url-expected.txt: Added.
        * http/tests/security/xssAuditor/meta-tag-http-refresh-javascript-url.html: Added.
        * http/tests/security/xssAuditor/object-tag-javascript-url-expected.txt: Added.
        * http/tests/security/xssAuditor/object-tag-javascript-url.html: Added.
        * http/tests/security/xssAuditor/property-escape-noquotes-expected.txt: Added.
        * http/tests/security/xssAuditor/property-escape-noquotes-tab-slash-chars-expected.txt: Added.
        * http/tests/security/xssAuditor/property-escape-noquotes-tab-slash-chars.html: Added.
        * http/tests/security/xssAuditor/property-escape-noquotes.html: Added.
        * http/tests/security/xssAuditor/property-inject-expected.txt: Added.
        * http/tests/security/xssAuditor/property-inject.html: Added.
        * http/tests/security/xssAuditor/resources/echo-head.pl: Added.
        * http/tests/security/xssAuditor/resources/echo-inner-tag.pl: Added.
        * http/tests/security/xssAuditor/resources/echo-property-noquotes.pl: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Enrica Casucci <enrica@apple.com>
eric@webkit.org [Tue, 29 Sep 2009 23:10:01 +0000 (23:10 +0000)]
2009-09-29  Enrica Casucci  <enrica@apple.com>

        Reviewed by Adele Peterson.

        Test case for <rdar://problem/7085453>.

        * editing/selection/blockquote-crash-expected.txt: Added.
        * editing/selection/blockquote-crash.html: Added.
2009-09-29  Enrica Casucci  <enrica@apple.com>

        Reviewed by Adele Peterson.

        Reproducible crash pressing return inside quoted content
        at WebCore::BreakBlockquoteCommand::doApply.
        <rdar://problem/7085453>
        In some case, like the one provided in the test case, m_downStreamEnd
        refers to a node that gets deleted when executing the DeleteSelectionCommand.
        We shouldn't use m_downStreamEnd to recalculate the new m_endPosition when
        pruning is needed, because it may be point to a node that has been deleted, but
        rather rely on removeNode in CompositeEditCommand to update m_endPosition correctly.

        Test: editing/selection/blockquote-crash.html

        * editing/BreakBlockquoteCommand.cpp:
        (WebCore::BreakBlockquoteCommand::doApply): Added check for invalid position
        to avoid dereferencing a null node pointer.
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::mergeParagraphs): Don't reset m_endPosition
        using the value in m_downStreamEnd when it is necessary to prune the start block.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Brady Eidson.
ap@apple.com [Tue, 29 Sep 2009 22:58:48 +0000 (22:58 +0000)]
    Reviewed by Brady Eidson.

        Basic authentication credentials are not sent automatically to top resources
        https://bugs.webkit.org/show_bug.cgi?id=29901

        No new tests - I don't want to pollute root directory of http tests to check for this rather
        minor issue.

        * platform/network/CredentialStorage.cpp:
        (WebCore::CredentialStorage::set): Changed to always preserve leading slash.
        (WebCore::CredentialStorage::getDefaultAuthenticationCredential): Made breaking out of the
        loop more explicit.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build fix.
bweinstein@apple.com [Tue, 29 Sep 2009 22:27:32 +0000 (22:27 +0000)]
Windows build fix.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 29 Sep 2009 22:10:06 +0000 (22:10 +0000)]
2009-09-29  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Oliver Hunt.

        Web Inspector REGRESSION(r47820-r47822): Profiles aren't
        added to the inspector unless the inspector is already open
        when the profile completes.

        https://bugs.webkit.org/show_bug.cgi?id=29897

        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype._populateProfiles):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubberstamped by David Hyatt.
kenneth@webkit.org [Tue, 29 Sep 2009 22:06:59 +0000 (22:06 +0000)]
Rubberstamped by David Hyatt.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-29
Fix to logic of earlier commit 48902.

When merging two if's before committing, I forgot to invert the
bool check.

* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::ignoreHttpError):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTidy up codeblock sampler
oliver@apple.com [Tue, 29 Sep 2009 21:48:52 +0000 (21:48 +0000)]
Tidy up codeblock sampler
https://bugs.webkit.org/show_bug.cgi?id=29836

Reviewed by Gavin Barraclough.

Some rather simple refactoring of codeblock sampler so that
it's easier for us to use it to find problems in non-jsc
environments

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, build fix.
senorblanco@chromium.org [Tue, 29 Sep 2009 21:43:57 +0000 (21:43 +0000)]
Unreviewed, build fix.

Fixing Chromium build, following r48884.

[https://bugs.webkit.org/show_bug.cgi?id=29894]

* bindings/v8/V8AbstractEventListener.cpp:
(WebCore::V8AbstractEventListener::handleEvent):
* bindings/v8/V8AbstractEventListener.h:
* bindings/v8/V8WorkerContextEventListener.cpp:
(WebCore::V8WorkerContextEventListener::handleEvent):
* bindings/v8/V8WorkerContextEventListener.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Kent Tamura <tkent@chromium.org>
eric@webkit.org [Tue, 29 Sep 2009 21:25:54 +0000 (21:25 +0000)]
2009-09-29  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Update for .maxLength behavior change.
        https://bugs.webkit.org/show_bug.cgi?id=29796

        * fast/forms/input-maxlength-expected.txt:
        * fast/forms/input-maxlength.html:
        * fast/forms/script-tests/textarea-maxlength.js:
        * fast/forms/textarea-maxlength-expected.txt:
2009-09-29  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Follows HTML5's maxLength change in September 2009.
        - Change HTMLTextAreaElement.maxLength type to signed.
        - HTMLTextAreaElement.maxLength returns -1 if maxlength= attribute is missing.
        - HTMLTextAreaElement.maxLength and HTMLInputElement.maxLength
          throw INDEX_SIZE_ERR for setting negative values.
        https://bugs.webkit.org/show_bug.cgi?id=29796

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::setMaxLength):
        * html/HTMLInputElement.h:
        * html/HTMLInputElement.idl:
        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::handleBeforeTextInsertedEvent):
        (WebCore::HTMLTextAreaElement::maxLength):
        (WebCore::HTMLTextAreaElement::setMaxLength):
        * html/HTMLTextAreaElement.h:
        * html/HTMLTextAreaElement.idl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDon't rely on QNetworkReply::NetworkError codes, but
kenneth@webkit.org [Tue, 29 Sep 2009 21:07:50 +0000 (21:07 +0000)]
Don't rely on QNetworkReply::NetworkError codes, but
on HTTP error codes instead.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-29
Reviewed by Simon Hausmann.

* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::ignoreHttpError):
(WebCore::QNetworkReplyHandler::finish):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUse const references when using Qt's foreach.
kenneth@webkit.org [Tue, 29 Sep 2009 21:07:26 +0000 (21:07 +0000)]
Use const references when using Qt's foreach.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-29
Reviewed by Simon Hausmann.

* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix handling of QNetworkReply errors.
kenneth@webkit.org [Tue, 29 Sep 2009 21:07:00 +0000 (21:07 +0000)]
Fix handling of QNetworkReply errors.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-29
Reviewed by Simon Hausmann.

In the QNetworkReplyHandler::finish() a response was sent even when
the reply contained an error. This resulted in a sendResponseIfNeeded()
calling didReceiveResponse on the client, leading to the destruction
of the m_resourceHandle, discontinuing further processing in finish(),
and thus not calling didFail on the client.

Instead it continued as everything went fine, and
FrameLoaderClientQt::dispatchDecidePolicyForMIMEType() changed the
policy to PolicyDownload due to not being able to show the non existing
MIMEType. As the download also obviously fails, it ended up with a
policy change error.

* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::finish):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Tue, 29 Sep 2009 21:01:39 +0000 (21:01 +0000)]
2009-09-29  Daniel Bates  <dbates@webkit.org>

        Reviewed by Adam Roben.

        https://bugs.webkit.org/show_bug.cgi?id=28902

        Fixes an issue where the drop effect returned by Window Dump Render Tree
        was always DROPEFFECT_NONE (since it was hard coded to do so).

        This patch corrects this issue by determining the actual drop effect
        performed by the corresponding drag-and-drop operation so that we can
        return it.

        * DumpRenderTree/win/DraggingInfo.h: Added field m_dropEffect to store performed drop effect.
        (DraggingInfo::DraggingInfo):
        (DraggingInfo::performedDropEffect): Added method.
        (DraggingInfo::setPerformedDropEffect): Added method.
        * DumpRenderTree/win/EventSender.cpp:
        (doMouseUp): Calls method DraggingInfo::setPerformedDropEffect with performed drop effect.
        Moved delete draggingInfo to UIDelegate::doDragDrop.
        * DumpRenderTree/win/UIDelegate.cpp:
        (UIDelegate::doDragDrop): Sets performedDropEffect to DraggingInfo::performedDropEffect().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Tue, 29 Sep 2009 20:48:16 +0000 (20:48 +0000)]
2009-09-29  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Dimitri Glazkov.

        Add GYP generated files to svn:ignore
        https://bugs.webkit.org/show_bug.cgi?id=29895

        The following files are generated by JavaScriptCore's GYP file and should be ignored:

        pcre.mk
        wtf.scons
        wtf.mk
        SConstruct
        wtf_config.scons
        wtf_config.mk
        pcre.scons

        * JavaScriptCore.gyp: Changed property svn:ignore.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Tue, 29 Sep 2009 20:42:27 +0000 (20:42 +0000)]
2009-09-29  Dimitri Glazkov  <dglazkov@chromium.org>

        No review, rolling out r48894, because review discussion was not complete.
        http://trac.webkit.org/changeset/48894

        * platform/sql/SQLiteTransaction.cpp:
        (WebCore::SQLiteTransaction::begin):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Tue, 29 Sep 2009 20:29:30 +0000 (20:29 +0000)]
2009-09-29  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG Filter feComposite implementation is missing
        [https://bugs.webkit.org/show_bug.cgi?id=28362]

        feComposite implementation for SVG.

        Test: svg/filters/feComposite.svg

        * platform/graphics/filters/FEComposite.cpp:
        (WebCore::arithmetic):
        (WebCore::FEComposite::apply):

        Tests the feComposite implementation for SVG.

        * platform/mac/svg/filters/feComposite-expected.checksum: Added.
        * platform/mac/svg/filters/feComposite-expected.png: Added.
        * platform/mac/svg/filters/feComposite-expected.txt: Added.
        * svg/filters/feComposite.svg: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoStandardized an optimization for adding non-numbers.
ggaren@apple.com [Tue, 29 Sep 2009 20:28:00 +0000 (20:28 +0000)]
Standardized an optimization for adding non-numbers.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-29
Reviewed by Sam Weinig.

SunSpider says maybe a tiny speedup.

* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_add):
(JSC::JIT::emitSlow_op_add):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Dumitru Daniliuc <dumi@chromium.org>
eric@webkit.org [Tue, 29 Sep 2009 20:05:11 +0000 (20:05 +0000)]
2009-09-29  Dumitru Daniliuc  <dumi@chromium.org>

        Reviewed by Dimitri Glazkov.

        Starting all read-only transactions with an explicit BEGIN
        DEFERRED command instead of BEGIN, since some ports (chromium)
        might compile their own SQLite library and set BEGIN to BEGIN
        IMMEDIATE by default; which would result in a deadlock in case of
        two concurrent read-only transactions on the same DB, and would
        unnecessarily delay other potential transactions to the same DB.

        https://bugs.webkit.org/show_bug.cgi?id=29729

        * platform/sql/SQLiteTransaction.cpp:
        (WebCore::SQLiteTransaction::begin):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore:
dglazkov@chromium.org [Tue, 29 Sep 2009 19:49:13 +0000 (19:49 +0000)]
WebCore:

2009-09-29  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        Add support for run-time flag for 3D canvas
        https://bugs.webkit.org/show_bug.cgi?id=29826

        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::getContext): Check page settings for
        experimental WebGL flag before returning 3D graphics context.
        * page/Settings.cpp:
        (WebCore::Settings::Settings): Initialize new flag to false.
        (WebCore::Settings::setExperimentalWebGLEnabled):
        * page/Settings.h: Set new flag.
        (WebCore::Settings::experimentalWebGLEnabled): Return new flag.

WebKit/mac:

2009-09-29  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        Add support for run-time flag for 3D canvas
        https://bugs.webkit.org/show_bug.cgi?id=29826

        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]): Enable experimental
        WebGL flag when 3D_CANVAS is enabled in the build.

WebKit/win:

2009-09-29  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        Add support for run-time flag for 3D canvas
        https://bugs.webkit.org/show_bug.cgi?id=29826

        * WebView.cpp:
        (WebView::notifyPreferencesChanged): Enable experimental WebGL
        flag when 3D_CANVAS is enabled in the build.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Tue, 29 Sep 2009 19:39:42 +0000 (19:39 +0000)]
2009-09-29  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Fisher.

        Chromium needs to be able to override the way storage events are delivered - part 1
        https://bugs.webkit.org/show_bug.cgi?id=29889

        Chromium needs to be able to override the way storage events are delivered.
        This replaced https://bugs.webkit.org/show_bug.cgi?id=29257 because it'll be
        faster (no vtables and extra allocation) and somewhat cleaner (no dependency
        injection).  This is necessary because Chromium needs to transport events across
        a process barrier and then dispatch them without use of a Frame*.

        This patch should be a no-op for all ports other than Chromium.

        * WebCore.gypi:
        * storage/StorageEventDispatcher.h: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Shinichiro Hamaji <hamaji@chromium.org>
eric@webkit.org [Tue, 29 Sep 2009 19:15:13 +0000 (19:15 +0000)]
2009-09-29  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by David Kilzer.

        Change remaining references in tests from bugzilla.opendarwin.org to bugs.webkit.org
        https://bugs.webkit.org/show_bug.cgi?id=12140

        Change the URLs in dumpAsText tests.

        * editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
        * editing/deleting/delete-all-text-in-text-field-assertion.html:
        * fast/dom/Document/doc-open-while-parsing.html:
        * fast/dom/Document/document-reopen.html:
        * fast/dom/Element/setAttribute-case-insensitivity.html:
        * fast/dom/HTMLHeadElement/head-check.html:
        * fast/dom/HTMLImageElement/image-without-renderer-width-expected.txt:
        * fast/dom/HTMLImageElement/image-without-renderer-width.html:
        * fast/dom/HTMLScriptElement/script-load-events-expected.txt:
        * fast/dom/HTMLScriptElement/script-load-events.html:
        * fast/dom/clone-node-form-elements-with-attr.html:
        * fast/dom/document-dir-property-expected.txt:
        * fast/dom/document-dir-property.html:
        * fast/dom/everything-to-string.html:
        * fast/dom/generic-form-element-assert-expected.txt:
        * fast/dom/generic-form-element-assert.html:
        * fast/dom/inner-text-rtl-expected.txt:
        * fast/dom/inner-text-rtl.html:
        * fast/dom/navigator-vendorSub.html:
        * fast/dom/option-properties-expected.txt:
        * fast/dom/option-properties.html:
        * fast/dom/replace-child-siblings-expected.txt:
        * fast/dom/replace-child-siblings.html:
        * fast/dom/replace-first-child.html:
        * fast/dom/setAttribute-using-initial-input-value.html:
        * fast/dom/space-to-text.html:
        * fast/dynamic/hovered-detach-expected.txt:
        * fast/dynamic/hovered-detach.html:
        * fast/encoding/charset-koi8-u.html:
        * fast/encoding/css-charset-dom.html:
        * fast/encoding/css-charset-evil.html:
        * fast/encoding/css-charset.html:
        * fast/encoding/latin1-winlatin.html:
        * fast/encoding/mispositioned-meta.html:
        * fast/encoding/percent-escaping.html:
        * fast/encoding/pseudo-xml-2.html:
        * fast/encoding/pseudo-xml-3.html:
        * fast/encoding/pseudo-xml-4.html:
        * fast/encoding/pseudo-xml.html:
        * fast/events/init-event-null-view.html:
        * fast/events/mouseover-mouseout.html:
        * fast/events/mouseover-mouseout2.html:
        * fast/events/onload-webkit-before-webcore.html:
        * fast/forms/button-in-forms-collection.html:
        * fast/forms/document-write.html:
        * fast/forms/domstring-replace-crash-expected.txt:
        * fast/forms/domstring-replace-crash.html:
        * fast/forms/element-by-name.html:
        * fast/forms/empty-get.html:
        * fast/forms/form-data-encoding-normalization-overrun.html:
        * fast/forms/radio-button-no-change-event.html:
        * fast/forms/selected-index-assert-expected.txt:
        * fast/forms/selected-index-assert.html:
        * fast/forms/textarea-hard-linewrap-empty-expected.txt:
        * fast/forms/textarea-hard-linewrap-empty.html:
        * fast/forms/textfield-focus-out-expected.txt:
        * fast/forms/textfield-focus-out.html:
        * fast/frames/empty-frame-document-expected.txt:
        * fast/frames/empty-frame-document.html:
        * fast/frames/frame-name-reset.html:
        * fast/frames/frame-set-same-location.html:
        * fast/frames/frame-set-same-src.html:
        * fast/frames/frameElement-widthheight.html:
        * fast/frames/iframe-name-and-id-expected.txt:
        * fast/frames/iframe-name-and-id.html:
        * fast/frames/iframe-set-same-location.html:
        * fast/frames/iframe-set-same-src.html:
        * fast/frames/repaint-display-none-crash-expected.txt:
        * fast/frames/repaint-display-none-crash.html:
        * fast/js/exception-linenums-in-html-2.html:
        * fast/js/missing-title-end-tag-js.html:
        * fast/loader/link-no-URL.html:
        * fast/loader/url-strip-cr-lf-tab.html:
        * fast/overflow/generated-content-crash-expected.txt:
        * fast/overflow/generated-content-crash.html:
        * fast/parser/number-sign-in-map-name.html:
        * fast/parser/remove-current-node-parent.html:
        * fast/parser/script-after-frameset-assert.html:
        * fast/tokenizer/image-empty-crash-expected.txt:
        * fast/tokenizer/image-empty-crash.html:
        * fast/tokenizer/nested-cached-scripts-expected.txt:
        * fast/tokenizer/nested-cached-scripts.html:
        * fast/tokenizer/write-unclosed-script-expected.txt:
        * fast/tokenizer/write-unclosed-script.html:
        * fast/xsl/transformToFragment-XML-declaration.html:
        * http/tests/misc/text-refresh.html:
        * http/tests/plugins/npapi-response-headers.html:
        * http/tests/uri/utf8-path.html:
        * http/tests/xmlhttprequest/cache-override.html:
        * http/tests/xmlhttprequest/event-listener-gc-expected.txt:
        * http/tests/xmlhttprequest/event-listener-gc.html:
        * http/tests/xmlhttprequest/event-target.html:
        * http/tests/xmlhttprequest/frame-load-cancelled-abort.html:
        * http/tests/xmlhttprequest/interactive-state.html:
        * http/tests/xmlhttprequest/methods-async.html:
        * http/tests/xmlhttprequest/methods-lower-case.html:
        * http/tests/xmlhttprequest/methods.html:
        * http/tests/xmlhttprequest/post-content-type.html:
        * http/tests/xmlhttprequest/readystatechange.html:
        * http/tests/xmlhttprequest/supported-xml-content-types.html:
        * http/tests/xmlhttprequest/xhr-onunload.html:
        * http/tests/xmlhttprequest/zero-length-response.html:
        * platform/mac/fast/events/objc-event-api.html:
        * platform/mac/fast/events/objc-keyboard-event-creation.html:
        * plugins/get-empty-url.html:
        * plugins/geturl-replace-query.html:
        * plugins/invoke.html:
        * plugins/mouse-events.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdding file missed in previous commit.
oliver@apple.com [Tue, 29 Sep 2009 19:01:58 +0000 (19:01 +0000)]
Adding file missed in previous commit.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Tue, 29 Sep 2009 18:51:22 +0000 (18:51 +0000)]
2009-09-29  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Fisher.

        [V8] Correct an issue with XMLHttpRequest attribute event listeners never being cleared.
        https://bugs.webkit.org/show_bug.cgi?id=29888

        Test: LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-abort-readyState-shouldDispatchEvent.html

        * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
        (WebCore::getEventListener): Added isAttribute parameter.
        (WebCore::ACCESSOR_SETTER): Made all event listener setters create attribute listeners.
        (WebCore::CALLBACK_FUNC_DECL): Made addEventListener create object listener.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] REGRESSION: BitmapImage::getGdkPixbuf fails for non-square images
oliver@apple.com [Tue, 29 Sep 2009 18:40:51 +0000 (18:40 +0000)]
[GTK] REGRESSION: BitmapImage::getGdkPixbuf fails for non-square images
https://bugs.webkit.org/show_bug.cgi?id=29654

Patch by Martin Robinson  <martin.james.robinson@gmail.com>
Reviewed by Eric Seidel

Added an additional manual-test for this issue to the existing Gtk
cursor image test.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Timothy Hatcher.
ap@apple.com [Tue, 29 Sep 2009 18:39:43 +0000 (18:39 +0000)]
    Reviewed by Timothy Hatcher.

        Build fix - pass a proper ScriptExecutipnContext to getEventListenerHandlerBody()

        * bindings/js/ScriptEventListener.cpp:
        (WebCore::getEventListenerHandlerBody):
        * bindings/js/ScriptEventListener.h:
        * bindings/v8/ScriptEventListener.cpp:
        (WebCore::getEventListenerHandlerBody):
        * bindings/v8/ScriptEventListener.h:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::buildObjectForEventListener):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Tue, 29 Sep 2009 18:37:36 +0000 (18:37 +0000)]
2009-09-29  Nate Chapin  <japhet@chromium.org>

        Reviewed by Eric Seidel.

        Ensure that we don't scroll lock to an anchor node after a
        user-initiated scroll, even if that scroll doesn't propagate
        all the way up to FrameView.

        Test: fast/events/node-event-anchor-lock.html

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build fix: export a new symbol.
ggaren@apple.com [Tue, 29 Sep 2009 18:12:33 +0000 (18:12 +0000)]
Windows build fix: export a new symbol.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-29
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Darin Adler and Sam Weinig.
ap@apple.com [Tue, 29 Sep 2009 18:05:08 +0000 (18:05 +0000)]
    Reviewed by Darin Adler and Sam Weinig.

        Onclick not fired for an element copied with cloneContents() or cloneNode()
        https://bugs.webkit.org/show_bug.cgi?id=25130

        The change here is that JS event listeners don't keep a reference to a global object from
        where they were created, and instead take it as a parameter when parsing source code. Also,
        the listener creation won't fail just because it happens for an element in a frameless
        document.
        Thus, moving nodes between documents no longer results in having incorrect registered
        lazy event listeners on them.

        Tests: fast/events/attribute-listener-cloned-from-frameless-doc-context-2.html
               fast/events/attribute-listener-cloned-from-frameless-doc-context.html
               fast/events/attribute-listener-cloned-from-frameless-doc.xhtml
               fast/events/attribute-listener-extracted-from-frameless-doc-context-2.html
               fast/events/attribute-listener-extracted-from-frameless-doc-context.html

        * bindings/js/JSEventListener.cpp:
        (WebCore::JSEventListener::JSEventListener): Don't take a reference to JSDOMGlobalObject.
        (WebCore::JSEventListener::jsFunction): Take ScriptExecutionContext as a parameter for
        getting to JSDOMGlobalObject. It's not used in base class, but is in JSLazyEventListner.
        (WebCore::JSEventListener::markJSFunction): Don't mark the global object.
        (WebCore::JSEventListener::handleEvent): Get global object from ScriptExecutionContext.
        (WebCore::JSEventListener::reportError): Ditto.

        * bindings/js/JSEventListener.h: (WebCore::JSEventListener::create): Don't keep a reference
        to JSDOMGlobalObject.

        * bindings/js/JSLazyEventListener.cpp: (WebCore::JSLazyEventListener::parseCode): Listener
        creation was split between this function and ScriptEventListener; moved it here, as JS
        global object can be different now.

        * bindings/js/JSLazyEventListener.h: (WebCore::JSLazyEventListener::create): Keep source URL,
        which can not be determined at parsing time.

        * bindings/js/ScriptEventListener.cpp: (WebCore::createAttributeEventListener): Moved code
        for listener creation to JSLazyEventListener. XSSAuditor code remains here, because tests
        expect that errors are logged at document parsing time, and because I don't know what other
        side effects moving it vould have.

        * dom/EventListener.h: handleEvent() and reportError() now take ScriptExecutionContext,
        because JSC needs a global context here.

        * bindings/js/JSAbstractWorkerCustom.cpp:
        (WebCore::JSAbstractWorker::addEventListener):
        (WebCore::JSAbstractWorker::removeEventListener):
        * bindings/js/JSDOMApplicationCacheCustom.cpp:
        (WebCore::JSDOMApplicationCache::addEventListener):
        (WebCore::JSDOMApplicationCache::removeEventListener):
        * bindings/js/JSDOMGlobalObject.cpp:
        (WebCore::JSDOMGlobalObject::createJSAttributeEventListener):
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::addEventListener):
        (WebCore::JSDOMWindow::removeEventListener):
        * bindings/js/JSEventSourceCustom.cpp:
        (WebCore::JSEventSource::addEventListener):
        (WebCore::JSEventSource::removeEventListener):
        * bindings/js/JSMessagePortCustom.cpp:
        (WebCore::JSMessagePort::addEventListener):
        (WebCore::JSMessagePort::removeEventListener):
        * bindings/js/JSNodeCustom.cpp:
        (WebCore::JSNode::addEventListener):
        (WebCore::JSNode::removeEventListener):
        * bindings/js/JSSVGElementInstanceCustom.cpp:
        (WebCore::JSSVGElementInstance::addEventListener):
        (WebCore::JSSVGElementInstance::removeEventListener):
        * bindings/js/JSWorkerContextCustom.cpp:
        (WebCore::JSWorkerContext::addEventListener):
        (WebCore::JSWorkerContext::removeEventListener):
        * bindings/js/JSXMLHttpRequestCustom.cpp:
        (WebCore::JSXMLHttpRequest::addEventListener):
        (WebCore::JSXMLHttpRequest::removeEventListener):
        * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
        (WebCore::JSXMLHttpRequestUpload::addEventListener):
        (WebCore::JSXMLHttpRequestUpload::removeEventListener):
        * bindings/objc/ObjCEventListener.h:
        * bindings/objc/ObjCEventListener.mm:
        (WebCore::ObjCEventListener::handleEvent):
        * bindings/scripts/CodeGeneratorJS.pm:
        * dom/EventTarget.cpp:
        (WebCore::EventTarget::fireEventListeners):
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::handleEvent):
        * inspector/InspectorDOMAgent.h:
        * inspector/InspectorDOMStorageResource.cpp:
        (WebCore::InspectorDOMStorageResource::handleEvent):
        * inspector/InspectorDOMStorageResource.h:
        * loader/ImageDocument.cpp:
        (WebCore::ImageEventListener::handleEvent):
        * svg/animation/SVGSMILElement.cpp:
        (WebCore::ConditionEventListener::handleEvent):
        * workers/WorkerContext.cpp:
        (WebCore::WorkerContext::reportException):
        Don't pass global object to JSEventListener::create(), which no longer needs it.
        Note that some of these functions still have an early return for null global object, which
        can probably be removed in a later patch.
        Pass ScriptExecutionContext to EventListener methods that now need it.

        * bindings/scripts/CodeGeneratorCOM.pm: Don't force EventTarget implementation on Node -
        it doesn't work yet (it didn't quite work before this patch, too, because it assumed that
        any object implementing EventTarget COM interface originated from WebCore).

        * dom/EventListener.idl: Just like in ObjC, EventListener should be a pure interface in
        COM bindings.

WebKit/win:
        * DOMCreateInstance.cpp: GEN_DOMEventListener is a pure interface now.

        * WebKit.vcproj/WebKit.vcproj: Removed GEN_DOMEventListener.cpp.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemoved virtual destructor from JSGlobalObjectData to eliminate pointer
ggaren@apple.com [Tue, 29 Sep 2009 17:54:39 +0000 (17:54 +0000)]
Removed virtual destructor from JSGlobalObjectData to eliminate pointer
fix-ups when accessing JSGlobalObject::d.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-28
Reviewed by Sam Weinig.

JavaScriptCore:

Replaced with an explicit destructor function pointer.

6% speedup on bench-alloc-nonretained.js.

* JavaScriptCore.exp:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::~JSGlobalObject):
(JSC::JSGlobalObject::destroyJSGlobalObjectData):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData):
(JSC::JSGlobalObject::JSGlobalObject):

JavaScriptGlue:

Replaced with an explicit destructor function pointer.

* JSRun.cpp:
(JSGlueGlobalObject::destroyData):
* JSRun.h:
(JSGlueGlobalObject::Data::Data):

WebCore:

Replaced with an explicit destructor function pointer.

* bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::destroyJSDOMGlobalObjectData):
* bindings/js/JSDOMGlobalObject.h:
(WebCore::JSDOMGlobalObject::JSDOMGlobalObjectData::JSDOMGlobalObjectData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoThe code for showing error pages when the response was
kenneth@webkit.org [Tue, 29 Sep 2009 17:44:37 +0000 (17:44 +0000)]
The code for showing error pages when the response was
a 401/403/404, was not actually doing so. This patch
fixes that.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-29
Reviewed by Simon Hausmann.

* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::finish):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove copying of unnecessary or nonexistent files from the ImageDiff
mitz@apple.com [Tue, 29 Sep 2009 16:43:55 +0000 (16:43 +0000)]
Remove copying of unnecessary or nonexistent files from the ImageDiff
post-build event.

Reviewed by Adam Roben.

* DumpRenderTree/win/ImageDiff.vcproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
eric@webkit.org [Tue, 29 Sep 2009 16:19:09 +0000 (16:19 +0000)]
2009-09-29  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>

        Reviewed by David Kilzer.

        [Qt] Make build-webkit script work on Windows
        https://bugs.webkit.org/show_bug.cgi?id=29802

        * Scripts/run-webkit-tests:
        * Scripts/webkitdirs.pm:
         - Removed unnecessary -p switch for mkdir on Windows.
         - Use canonical path, which uses slashes or backslashes depends on platform.
         - isWindows() only test for Windows and not for Cyqwin.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Brady Eidson.
ap@apple.com [Tue, 29 Sep 2009 16:19:03 +0000 (16:19 +0000)]
    Reviewed by Brady Eidson.

        <rdar://problem/7259965> REGRESSION: http/tests/xmlhttprequest/cross-origin-authorization.html
        is failing/crashing intermittently
        https://bugs.webkit.org/show_bug.cgi?id=29322

        This was caused by CStringBuffer::encodeBase64() returning a buffer that wasn't zero terminated.
        The code had other issues as well, so I removed it altogether:
        - it claimed to avoid some buffer copies, but it didn't;
        - and I don't think that base64 encoding should be part of CString interface.

WebCore:
        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::encodeBasicAuthorization): Encode username and password using Base64.h directly.
        (WebCore::ResourceHandle::start): Use encodeBasicAuthorization().
        (+[WebCoreSynchronousLoader loadRequest:allowStoredCredentials:returningResponse:error:]): Ditto.
        (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]): Extended logging
        to synchronous case.
        (-[WebCoreSynchronousLoader connectionShouldUseCredentialStorage:]): Ditto.
        (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): Ditto.
        (-[WebCoreSynchronousLoader connection:didReceiveResponse:]): Ditto.
        (-[WebCoreSynchronousLoader connection:didReceiveData:]): Ditto.
        (-[WebCoreSynchronousLoader connectionDidFinishLoading:]): Ditto.
        (-[WebCoreSynchronousLoader connection:didFailWithError:]): Ditto.

        * platform/network/cf/ResourceHandleCFNet.cpp: Matched Mac changes.

        * platform/text/CString.cpp:
        * platform/text/CString.h:
        (WebCore::CStringBuffer::create):
        (WebCore::CStringBuffer::CStringBuffer):
        Removed code that was added for Base64 in r48363.

LayoutTests:
        * http/tests/xmlhttprequest/cross-origin-authorization.html: While at it, made the test
        detect more error conditions

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Janne Koskinen <janne.p.koskinen@digia.com>
eric@webkit.org [Tue, 29 Sep 2009 16:10:02 +0000 (16:10 +0000)]
2009-09-29  Janne Koskinen  <janne.p.koskinen@digia.com>

        Reviewed by David Kilzer.

        [Qt] Assert messages prints visible in Symbian
        https://bugs.webkit.org/show_bug.cgi?id=29808

        Asserts use vprintf to print the messages to stderr.
        In Symbian Open C it is not possible to see stderr so
        I routed the messages to stdout instead.

        * wtf/Assertions.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 29 Sep 2009 15:18:56 +0000 (15:18 +0000)]
2009-09-29  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Do not set a non-default parent window for child widgets. We are
        just doing the same than the default path does, and on top of that
        if the widget's window changes (for example, during DnD widgets
        are usually unrealized/realized) the child widget will we left
        pointing to a dead window.

        For examples of crashers caused by this see
        https://bugzilla.gnome.org/show_bug.cgi?id=596397 and
        https://bugzilla.gnome.org/show_bug.cgi?id=596398

        * webkit/webkitwebview.cpp:
        (webkit_web_view_container_add):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
eric@webkit.org [Tue, 29 Sep 2009 15:00:48 +0000 (15:00 +0000)]
2009-09-29  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>

        Reviewed by Simon Hausmann.

        Fix typo in Localizations.cpp

        https://bugs.webkit.org/show_bug.cgi?id=29872

        * platform/qt/Localizations.cpp:
        (WebCore::localizedMediaControlElementHelpText):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake the XSLT conditional in DOMWindow.idl's xsltProcessor
hausmann@webkit.org [Tue, 29 Sep 2009 14:45:12 +0000 (14:45 +0000)]
Make the XSLT conditional in DOMWindow.idl's xsltProcessor
attribute conditional in the generated files, similar to
r44116.

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-09-29
Reviewed by Tor Arne Vestbø.

* page/DOMWindow.idl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Andras Becsi <becsi.andras@stud.u-szeged.hu>
zoltan@webkit.org [Tue, 29 Sep 2009 14:40:10 +0000 (14:40 +0000)]
2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>

        Reviewed by Simon Hausmann.

        Fix time measurement in build-webkit after refactoring done in r48853.

        * Scripts/build-webkit:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Default font size reconciliation to 16px/13px to match other platform's de-facto...
vestbo@webkit.org [Tue, 29 Sep 2009 14:25:21 +0000 (14:25 +0000)]
[Qt] Default font size reconciliation to 16px/13px to match other platform's de-facto standard.

This fixes https://bugs.webkit.org/show_bug.cgi?id=19674.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-09-29
Reviewed by Tor Arne Vestbø.

Done together with Renata Hodovan <renata.hodovan@stud.u-szeged.hu>

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=29844
hausmann@webkit.org [Tue, 29 Sep 2009 14:06:36 +0000 (14:06 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=29844

Patch by Jedrzej Nowacki <jedrzej.nowacki@nokia.com> on 2009-09-29
Reviewed by Simon Hausmann.

QWebPage dependency autotest fix.

Fix for database() autotest. All opened databases should be removed at
end of test.

* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::database):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSome QWebHistory and QWebPage autotest crash fixes.
hausmann@webkit.org [Tue, 29 Sep 2009 14:06:27 +0000 (14:06 +0000)]
Some QWebHistory and QWebPage autotest crash fixes.

Patch by Jedrzej Nowacki <jedrzej.nowacki@nokia.com> on 2009-09-29
Reviewed by Simon Hausmann.

Some checking for m_mainFrame were added. MainFrame should be created
at some point of QWebPage live cicle.

https://bugs.webkit.org/show_bug.cgi?id=29803

* Api/qwebpage.cpp:
(QWebPage::~QWebPage):
(QWebPage::currentFrame):
(QWebPage::history):
(QWebPage::selectedText):
(QWebPage::updatePositionDependentActions):
* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::crashTests_LazyInitializationOfMainFrame):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Use the ResourceError as it is supposed to and handle
kenneth@webkit.org [Tue, 29 Sep 2009 13:55:34 +0000 (13:55 +0000)]
WebCore: Use the ResourceError as it is supposed to and handle
not HTTP errors from QNetworkReply.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-29
Reviewed by Simon Hausmann.

Thanks to Adam Roben for his input.

* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::finish):

WebKit/qt: Implement QWebPage Extension for error pages, incl.
an example on how to use it in QtLauncher.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-29
Reviewed by Simon Hausmann.

Correct our use of ResourceError.

* Api/qwebpage.h:
(ExtensionOption::):
(ExtensionOption::ErrorPageExtensionReturn::ErrorPageExtensionReturn):
* QtLauncher/main.cpp:
(WebPage::supportsExtension):
(MainWindow::MainWindow):
(MainWindow::selectElements):
(WebPage::extension):
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::cancelledError):
(WebCore::FrameLoaderClientQt::blockedError):
(WebCore::FrameLoaderClientQt::cannotShowURLError):
(WebCore::FrameLoaderClientQt::interruptForPolicyChangeError):
(WebCore::FrameLoaderClientQt::cannotShowMIMETypeError):
(WebCore::FrameLoaderClientQt::fileDoesNotExistError):
(WebCore::FrameLoaderClientQt::callErrorPageExtension):
(WebCore::FrameLoaderClientQt::dispatchDidFailProvisionalLoad):
(WebCore::FrameLoaderClientQt::dispatchDidFailLoad):
* WebCoreSupport/FrameLoaderClientQt.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Janne Koskinen <janne.p.koskinen@digia.com>
eric@webkit.org [Tue, 29 Sep 2009 12:20:23 +0000 (12:20 +0000)]
2009-09-29  Janne Koskinen  <janne.p.koskinen@digia.com>

        Reviewed by Darin Adler.

        [Qt] Symbian CRASH macro implementation

        Added Symbian specific crash macro that
        stops to crash line if JIT debugging is used.
        Additional differentiation of access violation
        (KERN-EXEC 3) and CRASH panic.

        * wtf/Assertions.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Andras Becsi <becsi.andras@stud.u-szeged.hu>
zoltan@webkit.org [Tue, 29 Sep 2009 11:43:30 +0000 (11:43 +0000)]
2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>

        Reviewed by Simon Hausmann.

        [Qt] Update Skipped list after test refactoring done in r48806.

        * platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Jakub Wieczorek <faw217@gmail.com>
eric@webkit.org [Tue, 29 Sep 2009 09:56:14 +0000 (09:56 +0000)]
2009-09-29  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Simon Hausmann.

        [Qt] Unskip the passing tests that make use of eventSender.contextClick().
        https://bugs.webkit.org/show_bug.cgi?id=29821

        * platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 29 Sep 2009 09:53:24 +0000 (09:53 +0000)]
2009-09-29  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Encapsulate JS listeners specifics into ScriptEventListener.

        https://bugs.webkit.org/show_bug.cgi?id=29816

        * bindings/js/ScriptEventListener.cpp:
        (WebCore::getEventListenerHandlerBody):
        * bindings/js/ScriptEventListener.h:
        * bindings/v8/ScriptEventListener.cpp:
        (WebCore::getEventListenerHandlerBody):
        * bindings/v8/ScriptEventListener.h:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::buildObjectForEventListener):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 29 Sep 2009 09:48:56 +0000 (09:48 +0000)]
2009-09-29  Xan Lopez  <xlopez@igalia.com>

        Unreviewed attempt to fix the build.

        * page/Settings.cpp:
        (WebCore::Settings::Settings):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Jakub Wieczorek <faw217@gmail.com>
eric@webkit.org [Tue, 29 Sep 2009 09:48:55 +0000 (09:48 +0000)]
2009-09-29  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Simon Hausmann.

        [Qt] Implement eventSender.contextClick().
        https://bugs.webkit.org/show_bug.cgi?id=29821

        * DumpRenderTree/qt/jsobjects.cpp:
        (EventSender::contextClick):
        * DumpRenderTree/qt/jsobjects.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Tue, 29 Sep 2009 08:57:01 +0000 (08:57 +0000)]
2009-09-29  Fumitoshi Ukai  <ukai@chromium.org>

        Unreviewed.  Fix 4 layout test failures by webkit r48861.
        http://bugs.webkit.org/show_bug.cgi?id=29840

        r48861 introduced experimentalWebSocketsEnabled, and false by default.
        When experimentalWebSocketsEnabled is false, window.WebSocket is
        undefined, instead of a constructor.

        * fast/dom/Window/window-properties-expected.txt:
        * fast/dom/prototype-inheritance-2-expected.txt:
        * fast/dom/prototype-inheritance-expected.txt:
        * fast/js/global-constructors-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix the build by fixing a typo.
bweinstein@apple.com [Tue, 29 Sep 2009 07:22:11 +0000 (07:22 +0000)]
Fix the build by fixing a typo.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-28 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Tue, 29 Sep 2009 07:02:18 +0000 (07:02 +0000)]
2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Eric Seidel.

        Add experimentalWebSocketsEnabled in Settings.
        https://bugs.webkit.org/show_bug.cgi?id=28941

        * WebCore.base.exp:
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::webSocket):
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::getConstructor):
        * bindings/v8/custom/V8WebSocketCustom.cpp:
        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        (WebCore::Settings::setExperimentalWebSocketsEnabled):
        * page/Settings.h:
        (WebCore::Settings::experimentalWebSocketsEnabled):

2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Eric Seidel.

        Add experimentalWebSocketsEnabled in WebPreferences.
        https://bugs.webkit.org/show_bug.cgi?id=28941

        * WebView/WebPreferenceKeysPrivate.h:
        * WebView/WebPreferences.mm:
        (+[WebPreferences initialize]):
        (-[WebPreferences experimentalWebSocketsEnabled]):
        (-[WebPreferences setExperimentalWebSocketsEnabled:]):
        * WebView/WebPreferencesPrivate.h:
        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]):

2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Eric Seidel.

        Add experimentalWebSocketsEnabled in WebPreferences.
        https://bugs.webkit.org/show_bug.cgi?id=28941

        * Interfaces/IWebPreferencesPrivate.idl:
        * WebPreferenceKeysPrivate.h:
        * WebPreferences.cpp:
        (WebPreferences::initializeDefaultSettings):
        (WebPreferences::setExperimentalWebSocketsEnabled):
        (WebPreferences::experimentalWebSocketsEnabled):
        * WebPreferences.h:
        * WebView.cpp:
        (WebView::notifyPreferencesChanged):
        (core):

2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Eric Seidel.

        Add experimentalWebSocketsEnabled in WebPreferences.
        https://bugs.webkit.org/show_bug.cgi?id=28941

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (resetDefaultsToConsistentValues):
        * DumpRenderTree/win/DumpRenderTree.cpp:
        (resetDefaultsToConsistentValues):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix the PowerPC build.
mrowe@apple.com [Tue, 29 Sep 2009 05:51:58 +0000 (05:51 +0000)]
Fix the PowerPC build.

* JavaScriptCore.exp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-11 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Tue, 29 Sep 2009 05:42:58 +0000 (05:42 +0000)]
2009-09-11  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Adam Barth.

        Add platform code to support WebSocket for chromium.
        https://bugs.webkit.org/show_bug.cgi?id=29171

        To build within chromium tree, it requires a patch in bug 29174.
        Real implementation will be landed in chromium tree.

        * WebCore.gypi:
        * platform/network/chromium/SocketStreamError.h: Added.
        (WebCore::SocketStreamError::SocketStreamError):
        * platform/network/chromium/SocketStreamHandle.h: Added.
        (WebCore::SocketStreamHandle::create):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 29 Sep 2009 05:16:58 +0000 (05:16 +0000)]
2009-09-29  Xan Lopez  <xlopez@igalia.com>

        Rubber-stamped by Eric Seidel.

        [Gtk] Crash when saving a password
        https://bugs.webkit.org/show_bug.cgi?id=28070

        Disconnect the 'got-headers' callback when we are done with
        it. The signal can be emitted more than once if the message is
        retransmitted, but each time that happens authData is created
        again and a new callback connected, so we have to get rid of the
        old one (which will crash because we free authData).

        * webkit/webkitsoupauthdialog.c:
        (save_password_callback):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/7195704> JavaScriptCore fails to mark registers when built for x86_64...
mrowe@apple.com [Tue, 29 Sep 2009 04:51:11 +0000 (04:51 +0000)]
<rdar://problem/7195704> JavaScriptCore fails to mark registers when built for x86_64 using LLVM GCC.

Reviewed by Gavin Barraclough.

* runtime/Collector.cpp:
(JSC::Heap::markCurrentThreadConservatively): Force jmp_buf to use the appropriate alignment for a pointer
to ensure that we correctly interpret the contents of registers during marking.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-28 Yaar Schnitman <yaar@chromium.org>
ddkilzer@apple.com [Tue, 29 Sep 2009 04:01:09 +0000 (04:01 +0000)]
2009-09-28  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by David Kilzer.

        Integrated chromium port building into webkit tools update-webkit and
        build-webkit.

        https://bugs.webkit.org/show_bug.cgi?id=29749

        * Scripts/build-webkit: When --chromium is specified, will build
          the chromium port (currently only Mac is supported).
        * Scripts/update-webkit: When --chromium is specified, delegates to
          update-webkit-chromium.
        * Scripts/webkitdirs.pm: Added chromium specific defs.
        * Scripts/update-webkit-chromium: Uses gclient and gyp to fetch
          chromium port's dependencies and update its project files.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-28 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Tue, 29 Sep 2009 01:48:55 +0000 (01:48 +0000)]
2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>

        Unreviewed.

        Add myself to list of committers.

        * Scripts/modules/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-28 Zan Dobersek <zandobersek@gmail.com>
eric@webkit.org [Tue, 29 Sep 2009 01:10:11 +0000 (01:10 +0000)]
2009-09-28  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by David Kilzer.

        [Gtk][Layout tests] Generate results for css3 tests
        https://bugs.webkit.org/show_bug.cgi?id=29784

        Add results for css3 tests and enable these tests in the Skipped.

        * platform/gtk/Skipped:
        * platform/gtk/css3/css3-modsel-33-expected.txt: Added.
        * platform/gtk/css3/css3-modsel-35-expected.txt: Added.
        * platform/gtk/css3/css3-modsel-36-expected.txt: Added.
        * platform/gtk/css3/css3-modsel-37-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-28 Zan Dobersek <zandobersek@gmail.com>
eric@webkit.org [Tue, 29 Sep 2009 00:47:41 +0000 (00:47 +0000)]
2009-09-28  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by David Kilzer.

        [Gtk][Layout tests] Generate results for transitions tests
        https://bugs.webkit.org/show_bug.cgi?id=29786

        Add results for transitions tests and enable these tests in the Skipped.

        * platform/gtk/Skipped:
        * platform/gtk/transitions/transition-drt-api-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-28 Zan Dobersek <zandobersek@gmail.com>
eric@webkit.org [Tue, 29 Sep 2009 00:35:02 +0000 (00:35 +0000)]
2009-09-28  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by David Kilzer.

        [Gtk][Layout tests] Generate results for animations tests
        https://bugs.webkit.org/show_bug.cgi?id=29783

        Add results for animations tests and enable these tests in the Skipped.

        * platform/gtk/Skipped:
        * platform/gtk/animations/animation-drt-api-expected.txt: Added.
        * platform/gtk/animations/animation-drt-api-multiple-keyframes-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/7157288> Crash in RenderStyle::computedLineHeight()
mitz@apple.com [Tue, 29 Sep 2009 00:28:31 +0000 (00:28 +0000)]
<rdar://problem/7157288> Crash in RenderStyle::computedLineHeight()
when Times New Roman is not installed

Reviewed by Sam Weinig.

* platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::getLastResortFallbackFont): If Times New Roman is
not available, use the Windows default GUI font.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-28 Zan Dobersek <zandobersek@gmail.com>
eric@webkit.org [Tue, 29 Sep 2009 00:27:36 +0000 (00:27 +0000)]
2009-09-28  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by David Kilzer.

        [Gtk][Layout tests] Generate results for transforms tests
        https://bugs.webkit.org/show_bug.cgi?id=29785

        Add results for transforms tests and enable these tests in the Skipped.

        * platform/gtk/Skipped:
        * platform/gtk/transforms/2d/compound-transforms-vs-containers-expected.txt: Added.
        * platform/gtk/transforms/2d/transform-borderbox-expected.txt: Added.
        * platform/gtk/transforms/2d/transform-origin-borderbox-expected.txt: Added.
        * platform/gtk/transforms/no_transform_hit_testing-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDo not add platform-specific methods to cross-platform header
jianli@chromium.org [Mon, 28 Sep 2009 23:56:42 +0000 (23:56 +0000)]
Do not add platform-specific methods to cross-platform header
FileSystem.h per Darin's feedback for 29109.
https://bugs.webkit.org/show_bug.cgi?id=29830

Reviewed by David Levin.

* platform/FileSystem.h:
* platform/chromium/DragDataChromium.cpp:
(WebCore::DragData::asURL):
* platform/chromium/FileSystemChromium.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-28 Dumitru Daniliuc <dumi@chromium.org>
eric@webkit.org [Mon, 28 Sep 2009 23:33:25 +0000 (23:33 +0000)]
2009-09-28  Dumitru Daniliuc  <dumi@chromium.org>

        Reviewed by Dimitri Glazkov.

        Register Chromium's VFSs with a proper sqlite3_io_methods
        finder. This should only affect the POSIX implementation. The
        Windows change is included for consistency and in case sqlite
        starts using something similar in its Windows VFS in the future.

        https://bugs.webkit.org/show_bug.cgi?id=29743

        * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
        (WebCore::SQLiteFileSystem::registerSQLiteVFS):
        * platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
        (WebCore::SQLiteFileSystem::registerSQLiteVFS):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-28 Jakub Wieczorek <faw217@gmail.com>
eric@webkit.org [Mon, 28 Sep 2009 23:25:43 +0000 (23:25 +0000)]
2009-09-28  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Simon Hausmann.

        [Qt] Update the Skipped list after adding XSLT support.
        https://bugs.webkit.org/show_bug.cgi?id=29817

        Remove the tests that are passing now and skip these that are not,
        with a reason of failure for each of them.

        * platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-28 Alex Milowski <alex@milowski.com>
ddkilzer@apple.com [Mon, 28 Sep 2009 22:58:47 +0000 (22:58 +0000)]
2009-09-28  Alex Milowski  <alex@milowski.com>

        <http://webkit.org/b/29098> Update to MathML project webpage

        Reviewed by David Kilzer.

        Updated MathML project page and added link to Wiki page.

        * projects/mathml/index.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-28 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 28 Sep 2009 22:50:03 +0000 (22:50 +0000)]
2009-09-28  Eric Seidel  <eric@webkit.org>

        Reviewed by Simon Fraser.

        11 transforms/3d tests failing on the Leopard Debug bot after r48833
        https://bugs.webkit.org/show_bug.cgi?id=29828

        Leopard has HW compositing disabled until rdar://problem/7228836 can be fixed.
        So skip tests which depend on it being enabled per Simon's request.

        * platform/mac-leopard/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-28 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Mon, 28 Sep 2009 22:25:52 +0000 (22:25 +0000)]
2009-09-28  Nate Chapin  <japhet@chromium.org>

        Reviewed by Adam Barth.

        Change the V8 bindings' handling of window.toString(),
        so we return [object DOMWindow] (like JSC), not [object global].

        https://bugs.webkit.org/show_bug.cgi?id=29742

        This will fix a couple of Chromium port test failures and enable us to
        use the default expectations for a bunch more.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build fix: added new exports.
ggaren@apple.com [Mon, 28 Sep 2009 22:23:10 +0000 (22:23 +0000)]
Windows build fix: added new exports.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-28
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRoll out r48825. It causes build failures by calling an undefined function from...
mrowe@apple.com [Mon, 28 Sep 2009 22:16:09 +0000 (22:16 +0000)]
Roll out r48825.  It causes build failures by calling an undefined function from within RefPtr.h.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-28 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Mon, 28 Sep 2009 22:06:52 +0000 (22:06 +0000)]
2009-09-28  Nate Chapin  <japhet@chromium.org>

        Rubber stamped by David Levin.

        Chromium build fix, add back in #include of V8Proxy.h in V8WebKitPointConstructor.cpp.

        * bindings/v8/custom/V8WebKitPointConstructor.cpp: Re-include V8Proxy.h.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build fix: removed exports that no longer exist.
ggaren@apple.com [Mon, 28 Sep 2009 22:06:19 +0000 (22:06 +0000)]
Windows build fix: removed exports that no longer exist.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-28
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNotNullPassRefPtr: smart pointer optimized for passing references that are not null
ggaren@apple.com [Mon, 28 Sep 2009 21:45:58 +0000 (21:45 +0000)]
NotNullPassRefPtr: smart pointer optimized for passing references that are not null
https://bugs.webkit.org/show_bug.cgi?id=29822

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-28
Reviewed by Darin Adler.

JavaScriptCore:

Added NotNullPassRefPtr, and deployed it in all places that initialize
JavaScript objects.

2.2% speedup on bench-allocate-nonretained.js.

* API/JSCallbackConstructor.cpp:
(JSC::JSCallbackConstructor::JSCallbackConstructor):
* API/JSCallbackConstructor.h:
* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::JSCallbackObject::JSCallbackObject):
* JavaScriptCore.exp:
* bytecode/CodeBlock.h:
(JSC::CodeBlock::addFunctionDecl):
(JSC::CodeBlock::addFunctionExpr):
* runtime/ArrayConstructor.cpp:
(JSC::ArrayConstructor::ArrayConstructor):
* runtime/ArrayConstructor.h:
* runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::ArrayPrototype):
* runtime/ArrayPrototype.h:
* runtime/BooleanConstructor.cpp:
(JSC::BooleanConstructor::BooleanConstructor):
* runtime/BooleanConstructor.h:
* runtime/BooleanObject.cpp:
(JSC::BooleanObject::BooleanObject):
* runtime/BooleanObject.h:
* runtime/BooleanPrototype.cpp:
(JSC::BooleanPrototype::BooleanPrototype):
* runtime/BooleanPrototype.h:
* runtime/DateConstructor.cpp:
(JSC::DateConstructor::DateConstructor):
* runtime/DateConstructor.h:
* runtime/DateInstance.cpp:
(JSC::DateInstance::DateInstance):
* runtime/DateInstance.h:
* runtime/DatePrototype.cpp:
(JSC::DatePrototype::DatePrototype):
* runtime/DatePrototype.h:
* runtime/ErrorConstructor.cpp:
(JSC::ErrorConstructor::ErrorConstructor):
* runtime/ErrorConstructor.h:
* runtime/ErrorInstance.cpp:
(JSC::ErrorInstance::ErrorInstance):
* runtime/ErrorInstance.h:
* runtime/ErrorPrototype.cpp:
(JSC::ErrorPrototype::ErrorPrototype):
* runtime/ErrorPrototype.h:
* runtime/FunctionConstructor.cpp:
(JSC::FunctionConstructor::FunctionConstructor):
* runtime/FunctionConstructor.h:
* runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::FunctionPrototype):
* runtime/FunctionPrototype.h:
* runtime/GlobalEvalFunction.cpp:
(JSC::GlobalEvalFunction::GlobalEvalFunction):
* runtime/GlobalEvalFunction.h:
* runtime/InternalFunction.cpp:
(JSC::InternalFunction::InternalFunction):
* runtime/InternalFunction.h:
(JSC::InternalFunction::InternalFunction):
* runtime/JSActivation.cpp:
(JSC::JSActivation::JSActivation):
* runtime/JSActivation.h:
(JSC::JSActivation::JSActivationData::JSActivationData):
* runtime/JSArray.cpp:
(JSC::JSArray::JSArray):
* runtime/JSArray.h:
* runtime/JSByteArray.cpp:
(JSC::JSByteArray::JSByteArray):
* runtime/JSByteArray.h:
* runtime/JSFunction.cpp:
(JSC::JSFunction::JSFunction):
* runtime/JSFunction.h:
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::JSGlobalObject):
* runtime/JSONObject.h:
(JSC::JSONObject::JSONObject):
* runtime/JSObject.h:
(JSC::JSObject::JSObject):
(JSC::JSObject::setStructure):
* runtime/JSVariableObject.h:
(JSC::JSVariableObject::JSVariableObject):
* runtime/JSWrapperObject.h:
(JSC::JSWrapperObject::JSWrapperObject):
* runtime/MathObject.cpp:
(JSC::MathObject::MathObject):
* runtime/MathObject.h:
* runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::NativeErrorConstructor):
* runtime/NativeErrorConstructor.h:
* runtime/NativeErrorPrototype.cpp:
(JSC::NativeErrorPrototype::NativeErrorPrototype):
* runtime/NativeErrorPrototype.h:
* runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::NumberConstructor):
* runtime/NumberConstructor.h:
* runtime/NumberObject.cpp:
(JSC::NumberObject::NumberObject):
* runtime/NumberObject.h:
* runtime/NumberPrototype.cpp:
(JSC::NumberPrototype::NumberPrototype):
* runtime/NumberPrototype.h:
* runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::ObjectConstructor):
* runtime/ObjectConstructor.h:
* runtime/ObjectPrototype.cpp:
(JSC::ObjectPrototype::ObjectPrototype):
* runtime/ObjectPrototype.h:
* runtime/PropertyNameArray.h:
(JSC::PropertyNameArrayData::setCachedPrototypeChain):
* runtime/PrototypeFunction.cpp:
(JSC::PrototypeFunction::PrototypeFunction):
* runtime/PrototypeFunction.h:
* runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::RegExpConstructor):
* runtime/RegExpConstructor.h:
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::RegExpObject):
* runtime/RegExpObject.h:
(JSC::RegExpObject::RegExpObjectData::RegExpObjectData):
* runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::RegExpPrototype):
* runtime/RegExpPrototype.h:
* runtime/StringConstructor.cpp:
(JSC::StringConstructor::StringConstructor):
* runtime/StringConstructor.h:
* runtime/StringObject.cpp:
(JSC::StringObject::StringObject):
* runtime/StringObject.h:
* runtime/StringObjectThatMasqueradesAsUndefined.h:
(JSC::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined):
* runtime/StringPrototype.cpp:
(JSC::StringPrototype::StringPrototype):
* runtime/StringPrototype.h:
* wtf/PassRefPtr.h:
(WTF::NotNullPassRefPtr::NotNullPassRefPtr):
(WTF::NotNullPassRefPtr::~NotNullPassRefPtr):
(WTF::NotNullPassRefPtr::get):
(WTF::NotNullPassRefPtr::clear):
(WTF::NotNullPassRefPtr::releaseRef):
(WTF::NotNullPassRefPtr::operator*):
(WTF::NotNullPassRefPtr::operator->):
(WTF::NotNullPassRefPtr::operator!):
(WTF::NotNullPassRefPtr::operator UnspecifiedBoolType):
* wtf/RefPtr.h:
(WTF::RefPtr::RefPtr):
(WTF::operator==):

WebCore:

Added NotNullPassRefPtr, and deployed it in all places that initialize
JavaScript objects.

* bindings/js/DOMObjectWithSVGContext.h:
(WebCore::DOMObjectWithSVGContext::DOMObjectWithSVGContext):
* bindings/js/JSDOMBinding.cpp:
(WebCore::cacheDOMStructure):
* bindings/js/JSDOMBinding.h:
(WebCore::DOMObject::DOMObject):
(WebCore::DOMObjectWithGlobalPointer::DOMObjectWithGlobalPointer):
(WebCore::DOMConstructorObject::DOMConstructorObject):
(WebCore::DOMConstructorWithDocument::DOMConstructorWithDocument):
* bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::JSDOMGlobalObject):
* bindings/js/JSDOMGlobalObject.h:
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::JSDOMWindowBase):
* bindings/js/JSDOMWindowBase.h:
* bindings/js/JSHTMLAllCollection.h:
(WebCore::JSHTMLAllCollection::JSHTMLAllCollection):
* bindings/js/JSInspectedObjectWrapper.cpp:
(WebCore::JSInspectedObjectWrapper::JSInspectedObjectWrapper):
* bindings/js/JSInspectedObjectWrapper.h:
* bindings/js/JSInspectorCallbackWrapper.cpp:
(WebCore::JSInspectorCallbackWrapper::JSInspectorCallbackWrapper):
* bindings/js/JSInspectorCallbackWrapper.h:
* bindings/js/JSQuarantinedObjectWrapper.cpp:
(WebCore::JSQuarantinedObjectWrapper::JSQuarantinedObjectWrapper):
* bindings/js/JSQuarantinedObjectWrapper.h:
* bindings/js/JSWorkerContextBase.cpp:
(WebCore::JSWorkerContextBase::JSWorkerContextBase):
* bindings/js/JSWorkerContextBase.h:
* bindings/scripts/CodeGeneratorJS.pm:
* bridge/runtime_object.cpp:
(JSC::RuntimeObjectImp::RuntimeObjectImp):
* bridge/runtime_object.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-28 Jakub Wieczorek <faw217@gmail.com>
eric@webkit.org [Mon, 28 Sep 2009 21:38:08 +0000 (21:38 +0000)]
2009-09-28  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Simon Hausmann.

        [Qt] Add the expected result for the fast/xsl/document-function test.
        https://bugs.webkit.org/show_bug.cgi?id=29817

        * platform/qt/fast/xsl/document-function-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-28 Nate Chapin <japhet@chromium.org>
eric@webkit.org [Mon, 28 Sep 2009 21:30:53 +0000 (21:30 +0000)]
2009-09-28  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        Allow V8 to handle x/y parameters in a WebKitPoint constructor.
        https://bugs.webkit.org/show_bug.cgi?id=29823

        Fixes V8's handling of LayoutTests/fast/dom/Window/webkitConvertPoint.html

        * bindings/v8/custom/V8WebKitPointConstructor.cpp: Allow for x/y parameters in constructor.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-25 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 28 Sep 2009 21:22:50 +0000 (21:22 +0000)]
2009-09-25  Eric Seidel  <eric@webkit.org>

        Reviewed by Simon Fraser.

        REGRESSION: media/video-pause-empty-events.html is occasionally timing out on bots
        https://bugs.webkit.org/show_bug.cgi?id=28624

        No longer skip media tests now that we're disabling hardware compositing instead.
        Add leopard-specific results for 2 tests expected to fail with HW compositing disabled.

        * platform/mac-leopard/Skipped:
        * platform/mac-leopard/fast/media/mq-transform-02-expected.checksum: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-02-expected.checksum.
        * platform/mac-leopard/fast/media/mq-transform-02-expected.png: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-02-expected.png.
        * platform/mac-leopard/fast/media/mq-transform-02-expected.txt: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-02-expected.txt.
        * platform/mac-leopard/fast/media/mq-transform-03-expected.checksum: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-03-expected.checksum.
        * platform/mac-leopard/fast/media/mq-transform-03-expected.png: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-03-expected.png.
        * platform/mac-leopard/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-03-expected.txt.
2009-09-27  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Darin Adler.

        run-webkit-tests: Do not strip the metrics when there is no expected result for a test.
        https://bugs.webkit.org/show_bug.cgi?id=29771

        * Scripts/run-webkit-tests:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix the build by doing something approximating reasonableness in the Xcode project.
mrowe@apple.com [Mon, 28 Sep 2009 20:57:52 +0000 (20:57 +0000)]
Fix the build by doing something approximating reasonableness in the Xcode project.

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/7240911> REGRESSION (r48586): Crash occurs when loading
mitz@apple.com [Mon, 28 Sep 2009 20:55:38 +0000 (20:55 +0000)]
<rdar://problem/7240911> REGRESSION (r48586): Crash occurs when loading
a PDF

Reviewed by Anders Carlsson.

CGPDFObjectRef is not a CFTypeRef, and cannot be retained or released.
Its lifetime is managed by its container. Just use a Vector to store
CGPDFObjectRefs, relying on the CGPDFDocument to keep them alive.

* WebView/WebPDFDocumentExtras.mm:
(appendValuesInPDFNameSubtreeToVector):
(getAllValuesInPDFNameTree):
(web_PDFDocumentAllScripts):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoHard dependency on SSE2 instruction set with JIT
oliver@apple.com [Mon, 28 Sep 2009 20:42:15 +0000 (20:42 +0000)]
Hard dependency on SSE2 instruction set with JIT
https://bugs.webkit.org/show_bug.cgi?id=29779

Reviewed by Geoff Garen

Add floating point support checks to op_jfalse and op_jtrue, and
fix the logic for the slow case of op_add

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoProspective Tiger build fix.
hausmann@webkit.org [Mon, 28 Sep 2009 20:41:56 +0000 (20:41 +0000)]
Prospective Tiger build fix.

Patch by Simon Hausmann <hausmann@webkit.org> on 2009-09-28
* WebCore.xcodeproj/project.pbxproj: Try to use unique IDs for the new files.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-28 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 28 Sep 2009 20:33:41 +0000 (20:33 +0000)]
2009-09-28  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Add explicit frontend event for commit load.

        https://bugs.webkit.org/show_bug.cgi?id=29814

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::didCommitLoad):
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::didCommitLoad):
        * inspector/InspectorFrontend.h:
        * inspector/front-end/DOMAgent.js:
        (WebInspector.DOMAgent.prototype._setDocument):
        * inspector/front-end/inspector.js:
        (WebInspector.addResource):
        (WebInspector.didCommitLoad):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-28 Yaar Schnitman <yaar@chromium.org>
eric@webkit.org [Mon, 28 Sep 2009 20:30:52 +0000 (20:30 +0000)]
2009-09-28  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Dimitri Glazkov.

        Chromium port - recognize we are being built independently
        of chromium and look for dependencies under webkit/chromium rather
        than chromium/src.

        https://bugs.webkit.org/show_bug.cgi?id=29722

        * JavaScriptCore.gyp/JavaScriptCore.gyp:
2009-09-28  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Dimitri Glazkov.

        Chromium port - recognize we are being built independently
        of chromium and look for dependencies under webkit/chromium rather
        than chromium/src.

        https://bugs.webkit.org/show_bug.cgi?id=29722

        * WebCore.gyp/WebCore.gyp: See above. Also removed a few files from
          the sources list, since they are not supposed to be built here.
2009-09-28  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=29722

        * chromium/DEPS: Describes the chromium port's dependencies and
          is used by gclient to fetch them.
        * chromium/webkit.gyp: Currently only builds webcore but in
          the future will also build the webkit api.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Implement XSLT support with QtXmlPatterns.
hausmann@webkit.org [Mon, 28 Sep 2009 20:11:36 +0000 (20:11 +0000)]
[Qt] Implement XSLT support with QtXmlPatterns.
https://bugs.webkit.org/show_bug.cgi?id=28303

Patch by Jakub Wieczorek <faw217@gmail.com> on 2009-09-28
Reviewed by Simon Hausmann.

JavaScriptCore:

* wtf/Platform.h: Add a WTF_USE_QXMLQUERY #define.

WebCore:

* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCoreSources.bkl:
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::setTransformSource):
* dom/Document.h:
(WebCore::Document::transformSource):
* dom/TransformSource.h: Added.
(WebCore::TransformSource::platformSource):
* dom/TransformSourceLibxslt.cpp: Added.
(WebCore::TransformSource::TransformSource): Wraps a libxml2 document.
(WebCore::TransformSource::~TransformSource):
* dom/TransformSourceQt.cpp: Added.
(WebCore::TransformSource::TransformSource): Wraps a plain string.
(WebCore::TransformSource::~TransformSource):
* dom/XMLTokenizerLibxml2.cpp:
(WebCore::XMLTokenizer::doEnd):
* dom/XMLTokenizerQt.cpp:
(WebCore::XMLTokenizer::doEnd):
(WebCore::XMLTokenizer::parseProcessingInstruction):
* xml/XSLStyleSheet.h:
(WebCore::XSLStyleSheet::sheetString):
* xml/XSLStyleSheetLibxslt.cpp:
(WebCore::XSLStyleSheet::document):
* xml/XSLStyleSheetQt.cpp: Added.
* xml/XSLTProcessor.h:
* xml/XSLTProcessorLibxslt.cpp:
(WebCore::xmlDocPtrFromNode):
* xml/XSLTProcessorQt.cpp: Added.
(WebCore::XSLTMessageHandler::XSLTMessageHandler): A subclass of QAbstractMessageHandler.
(WebCore::XSLTMessageHandler::handleMessage): Forwards all processor messages to the Console.
(WebCore::XSLTProcessor::transformToString): Uses QXmlQuery.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-28 Yongjun Zhang <yongjun.zhang@nokia.com>
eric@webkit.org [Mon, 28 Sep 2009 20:09:40 +0000 (20:09 +0000)]
2009-09-28  Yongjun Zhang  <yongjun.zhang@nokia.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=28054

        Use derefInNotNull() to work around winscw compiler forward declaration bug
        regarding templated classes.

        The compiler bug is reported at
        https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=9812.

        The change should be reverted when the above bug is fixed in winscw compiler.

        Add parenthesis around (RefPtr::*UnspecifiedBoolType) to make winscw compiler
        work with the default UnSpecifiedBoolType() operator, which removes the winscw hack.

        * wtf/RefPtr.h:
        (WTF::RefPtr::~RefPtr):
        (WTF::RefPtr::clear):
        (WTF::RefPtr::operator UnspecifiedBoolType):
2009-09-28  Yongjun Zhang  <yongjun.zhang@nokia.com>

        Reviewed by Eric Seidel.

        Make JObjectWrapper::ref() and deref() public accessible to derefIfNull().

        Will be reverted when the following winscw compiler bug is fixed.
        https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=9812

        * bridge/jni/jni_instance.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove __clear_cache which is an internal function of GCC
hausmann@webkit.org [Mon, 28 Sep 2009 18:57:31 +0000 (18:57 +0000)]
Remove __clear_cache which is an internal function of GCC
https://bugs.webkit.org/show_bug.cgi?id=28886

Patch by Gabor Loki <loki@inf.u-szeged.hu> on 2009-09-28
Reviewed by Simon Hausmann.

Although __clear_cache is exported from GCC, this is an internal
function. GCC makes no promises about it.

* jit/ExecutableAllocator.h:
(JSC::ExecutableAllocator::cacheFlush):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-28 Shinichiro Hamaji <hamaji@chromium.org>
eric@webkit.org [Mon, 28 Sep 2009 18:51:10 +0000 (18:51 +0000)]
2009-09-28  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler.

        Move message-port-multi.js from resources to script-tests
        https://bugs.webkit.org/show_bug.cgi?id=29798

        * fast/events/message-port-multi-expected.txt:
        * fast/events/message-port-multi.html:
        * fast/events/resources/message-port-multi.js: Removed.
        * fast/events/script-tests/message-port-multi.js: Added.
        (channel.port2.onmessage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-28 Andrew Scherkus <scherkus@chromium.org>
eric@webkit.org [Mon, 28 Sep 2009 18:43:54 +0000 (18:43 +0000)]
2009-09-28  Andrew Scherkus  <scherkus@chromium.org>

        Reviewed by Eric Carlson.

        Delegate implementation of rendererIsNeeded() for media control elements to RenderTheme.

        https://bugs.webkit.org/show_bug.cgi?id=28689

        Covered by LayoutTests/media/video-no-audio.html

        * rendering/MediaControlElements.cpp: Removed subclass implementations of rendererIsNeeded().
        (WebCore::MediaControlElement::rendererIsNeeded): Include calling shouldRenderMediaControlPart().
        (WebCore::MediaControlInputElement::rendererIsNeeded): Include calling shouldRenderMediaControlPart().
        * rendering/MediaControlElements.h:
        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::shouldRenderMediaControlPart): New method.  Contains logic moved from subclass implementations of rendererIsNeeded().
        * rendering/RenderTheme.h:
        * rendering/RenderThemeChromiumSkia.cpp:
        (WebCore::RenderThemeChromiumSkia::shouldRenderMediaControlPart): Override to always render mute button.
        * rendering/RenderThemeChromiumSkia.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] DragData::asURL should return file URL.
jianli@chromium.org [Mon, 28 Sep 2009 18:13:00 +0000 (18:13 +0000)]
[chromium] DragData::asURL should return file URL.
https://bugs.webkit.org/show_bug.cgi?id=29109

Reviewed by David Levin.

Tested by LayoutTests/fast/events/drag-to-navigate.html.

* platform/FileSystem.h:
* platform/chromium/ChromiumBridge.h:
* platform/chromium/DragDataChromium.cpp:
(WebCore::DragData::asURL):
* platform/chromium/FileSystemChromium.cpp:
(WebCore::getAbsolutePath):
(WebCore::isDirectory):
(WebCore::filePathToURL):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-28 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Mon, 28 Sep 2009 17:57:17 +0000 (17:57 +0000)]
2009-09-28  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by David Levin.

        [V8] Add a special case to handle index arguments, because we need to be
        able to see if they're < 0.
        https://bugs.webkit.org/show_bug.cgi?id=29810

        Test: LayoutTests/dom/html/level1/core/hc_characterdataindexsizeerrdeletedatacountnegative.html

        * bindings/scripts/CodeGeneratorV8.pm: Added special case (matching CodeGeneratorJS.pm)
          for index arguments.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix an absolute path to somewhere in Oliver's machine to a relative path
weinig@apple.com [Mon, 28 Sep 2009 17:55:40 +0000 (17:55 +0000)]
Fix an absolute path to somewhere in Oliver's machine to a relative path
for derived JSONObject.lut.h.

Reviewed by Oliver Hunt.

* JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoExtend the MediaWiki/KHTMLFixes.css workaround to cover older MediaWiki versions
mitz@apple.com [Mon, 28 Sep 2009 16:34:53 +0000 (16:34 +0000)]
Extend the MediaWiki/KHTMLFixes.css workaround to cover older MediaWiki versions
https://bugs.webkit.org/show_bug.cgi?id=29792

Reviewed by Darin Adler.

* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::setCSSStyleSheet): If site specific hacks are
enabled, check if the linked style sheet is one of two versions of the
MediaWiki KHTMLFixes.css. If so, remove the offending rule.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-28 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Mon, 28 Sep 2009 16:29:14 +0000 (16:29 +0000)]
2009-09-28  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Adam Barth.

        [V8] Fix an error in type logic in CodeGeneratorV8.pm, where
        unsigned ints are accidentally used as signed.
        https://bugs.webkit.org/show_bug.cgi?id=29810

        Test: LayoutTests/fast/forms/textarea-maxlength.html

        * bindings/scripts/CodeGeneratorV8.pm: Made sure "unsigned long" in IDL is
          properly generates on "unsigned" return value.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-25 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 28 Sep 2009 16:14:18 +0000 (16:14 +0000)]
2009-09-25  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        ASSERTION FAILED: !repaintContainer || repaintContainer == this
        https://bugs.webkit.org/show_bug.cgi?id=29755

        It's possible for RenderObject::container() to return an object that is higher
        in the hierarchy than the repaintContainer that is being used to repaint an
        object. For example, this can happen when running an accelerated opacity
        transition on an element with a position:absolute parent, and a position:absolute child.

        In this case we need to detect when RenderObject::container() will skip over
        repaintContainer, and in that case adjust the coords to shift into repaintContainer's space.

        Test: compositing/repaint/opacity-between-absolute.html

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::mapLocalToContainer):
        (WebCore::RenderBox::computeRectForRepaint):
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::computeRectForRepaint):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::container):
        * rendering/RenderObject.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRename XSLStyleSheet.cpp to XSLStyleSheetLibxslt.cpp.
hausmann@webkit.org [Mon, 28 Sep 2009 15:06:24 +0000 (15:06 +0000)]
Rename XSLStyleSheet.cpp to XSLStyleSheetLibxslt.cpp.
https://bugs.webkit.org/show_bug.cgi?id=28303

Patch by Jakub Wieczorek <faw217@gmail.com> on 2009-09-28
Reviewed by Simon Hausmann.

In preparation for adding XSLT support with QtXmlPatterns to the Qt
port, rename XSLStyleSheet.cpp to XSLStyleSheetLibxslt.cpp as we will
have our own implementation which most likely will not share any code
with the current one.

Additionally, fix some coding style issues.

* GNUmakefile.am:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
* xml/XSLStyleSheet.cpp: Renamed to XSLStyleSheetLibxslt.cpp.
* xml/XSLStyleSheetLibxslt.cpp: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoProspective build fix for r48812.
hausmann@webkit.org [Mon, 28 Sep 2009 14:45:12 +0000 (14:45 +0000)]
Prospective build fix for r48812.

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-09-28
Forgot to remove the inline reset() implementation when reverting the indentation
changes in the file.

* xml/XSLTProcessor.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-28 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 28 Sep 2009 14:40:17 +0000 (14:40 +0000)]
2009-09-28  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by nobody (trivial follow up fix), Joseph Pecoraro LGTM-ed.

        Web Inspector: Follow up to r48809.
        InspectorController.wrapObject should only be called on the inspectable page side.

        https://bugs.webkit.org/show_bug.cgi?id=17429

        * inspector/front-end/EventListenersSidebarPane.js:
        (WebInspector.EventListenersSidebarPane.prototype.update.callback):
        (WebInspector.EventListenersSidebarPane.prototype.update):
        (WebInspector.EventListenersSection):
        (WebInspector.EventListenersSection.prototype.update):
        (WebInspector.EventListenerBar):
        (WebInspector.EventListenerBar.prototype.update):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMove the libxslt specific part of XSLTProcessor to a separate file.
hausmann@webkit.org [Mon, 28 Sep 2009 14:36:24 +0000 (14:36 +0000)]
Move the libxslt specific part of XSLTProcessor to a separate file.
https://bugs.webkit.org/show_bug.cgi?id=28303

Patch by Jakub Wieczorek <faw217@gmail.com> on 2009-09-28
Reviewed by Simon Hausmann.

In preparation for adding XSLT support with QtXmlPatterns to the Qt
port, move the libxslt part of the XSLTProcessor implementation into
another file and leave the part that can be reused and shared.

Additionally, fix some coding style issues.

* GNUmakefile.am:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
* xml/XSLTProcessor.cpp:
(WebCore::XSLTProcessor::createDocumentFromSource): Remove trailing whitespaces.
(WebCore::createFragmentFromSource): Remove trailing whitespaces.
(WebCore::XSLTProcessor::transformToFragment): Remove trailing whitespaces.
(WebCore::XSLTProcessor::reset): Moved out of the class definition.
* xml/XSLTProcessorLibxslt.cpp: Added.
(WebCore::XSLTProcessor::genericErrorFunc): Moved.
(WebCore::XSLTProcessor::parseErrorFunc): Moved.
(WebCore::docLoaderFunc): Moved.
(WebCore::setXSLTLoadCallBack): Moved.
(WebCore::writeToVector): Moved.
(WebCore::saveResultToString): Moved.
(WebCore::xsltParamArrayFromParameterMap): Moved.
(WebCore::freeXsltParamArray): Moved.
(WebCore::xsltStylesheetPointer): Moved.
(WebCore::xmlDocPtrFromNode): Moved.
(WebCore::resultMIMEType): Moved.
(WebCore::XSLTProcessor::transformToString): Moved.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMinor correction to Copyright notice. Not reviewed.
staikos@webkit.org [Mon, 28 Sep 2009 14:28:23 +0000 (14:28 +0000)]
Minor correction to Copyright notice.  Not reviewed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-28 Charles Wei <charles.wei@torchmobile.com.cn>
eric@webkit.org [Mon, 28 Sep 2009 13:35:39 +0000 (13:35 +0000)]
2009-09-28  Charles Wei  <charles.wei@torchmobile.com.cn>

        Reviewed by Nikolas Zimmermann.

        Fix the crash of SVG that crashes when use a non-exist symbol
        https://bugs.webkit.org/show_bug.cgi?id=27693

        * svg/custom/use-non-existing-symbol-crash-expected.txt: Added.
        * svg/custom/use-non-existing-symbol-crash.svg: Added.
2009-09-28  Charles Wei  <charles.wei@torchmobile.com.cn>

        Reviewed by Nikolas Zimmermann.

        Fix the crash of SVG that crashes when use a non-exist symbol
        https://bugs.webkit.org/show_bug.cgi?id=27693

        Test: svg/custom/use-non-existing-symbol-crash.svg

        * svg/SVGUseElement.cpp:
        (WebCore::shadowTreeContainsChangedNodes):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-28 Joseph Pecoraro <joepeck@webkit.org>
pfeldman@chromium.org [Mon, 28 Sep 2009 12:36:44 +0000 (12:36 +0000)]
2009-09-28  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Timothy Hatcher.

        Inspector Should Show Event Listeners/Handlers Registered on each Node
        https://bugs.webkit.org/show_bug.cgi?id=17429

          Extracted a method from dispatchEvent to get the event ancestor chain

        * dom/Node.cpp:
        (WebCore::Node::eventAncestors): the extracted method
        (WebCore::Node::dispatchGenericEvent): use eventAncestors
        * dom/Node.h:

          Asynchronous Flow For the Inspector, Backend -> DOM Agent -> Frontend
          The DOMAgent's getEventListenersForNode handles the logic of finding
          all the relevant listeners in the event flow.

        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::getEventListenersForNode):
        * inspector/InspectorBackend.h:
        * inspector/InspectorBackend.idl:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::getEventListenersForNode):
        (WebCore::InspectorDOMAgent::buildObjectForEventListener):
        (WebCore::InspectorDOMAgent::buildObjectForNode): added localName
        * inspector/InspectorDOMAgent.h:
        (WebCore::EventListenerInfo::EventListenerInfo):
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::didGetEventListenersForNode):
        * inspector/InspectorFrontend.h:
        (WebCore::InspectorFrontend::scriptState):
        * inspector/front-end/DOMAgent.js: added localName to WebInspector.DOMNode from payload
        (WebInspector.EventListeners.getEventListenersForNodeAsync.mycallback):
        (WebInspector.EventListeners.getEventListenersForNodeAsync):

          New Sidebar Pane in the Element's Panel
          Includes Gear Menu for filtering the Event Listeners on the
          "Selected Node Only" or "All Nodes"

        * inspector/front-end/ElementsPanel.js: Handles refreshing the Pane when necessary
        (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
        (WebInspector.ElementsPanel):
        (WebInspector.ElementsPanel.prototype.updateEventListeners):
        * inspector/front-end/EventListenersSidebarPane.js: Added.
        (WebInspector.EventListenersSidebarPane): The 1st level in the Pane
        (WebInspector.EventListenersSidebarPane.prototype.update.callback):
        (WebInspector.EventListenersSidebarPane.prototype.update):
        (WebInspector.EventListenersSection): The 2nd level in the Pane
        (WebInspector.EventListenersSection.prototype.update): filters on Preference
        (WebInspector.EventListenersSection.prototype.addListener):
        (WebInspector.EventListenerBar): The 3rd level in the Pane
        (WebInspector.EventListenerBar.prototype._getNodeDisplayName):
        (WebInspector.EventListenerBar.prototype._getFunctionDisplayName):
        (WebInspector.EventListenersSidebarPane.prototype._changeSetting): For the Gear Menu

          Consolidated "appropriateSelectorForNode"

        * inspector/front-end/StylesSidebarPane.js:
        * inspector/front-end/utilities.js:

          Miscellaneous Updates

        * English.lproj/localizedStrings.js: "Event Listeners", "No Event Listeners", "Selected Node Only", "All Nodes"
        * WebCore.gypi: included the new inspector files
        * WebCore.vcproj/WebCore.vcproj: included source files that were missing
        * inspector/front-end/Images/grayConnectorPoint.png: Added. Thanks to Timothy Hatcher.
        * inspector/front-end/Images/whiteConnectorPoint.png: Added. Thanks to Timothy Hatcher.
        * inspector/front-end/inspector.js: Preferences for the Gear Menu Event Listeners filter
        * inspector/front-end/inspector.css: reused as much as possible
        * inspector/front-end/inspector.html: include the new script
        * inspector/front-end/WebKit.qrc: included the new inspector files

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48809 268f45cc-cd09-0410-ab3c-d52691b4dbfc