WebKit.git
10 years agoIgnore compiled Java test cases in .gitignore.
dimich@chromium.org [Tue, 2 Mar 2010 19:12:42 +0000 (19:12 +0000)]
Ignore compiled Java test cases in .gitignore.
https://bugs.webkit.org/show_bug.cgi?id=35559

Reviewed by Alexey Proskuryakov.

* .gitignore:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-02 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Tue, 2 Mar 2010 19:10:31 +0000 (19:10 +0000)]
2010-03-02  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        [V8] Fail gracefully if NPN_GetProperty tries to retrieve a property that doesn't exist.

        https://bugs.webkit.org/show_bug.cgi?id=35588

        Required for passing LayoutTests/plugins/netscape-plugin-property-access-exception.html on Chromium.

        * bindings/v8/NPV8Object.cpp:
        (_NPN_GetProperty): If the result is empty, don't try to convert it to an NPVariant and return false.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[V8] DOMCoreException should be visible as DOMException
jianli@chromium.org [Tue, 2 Mar 2010 18:59:52 +0000 (18:59 +0000)]
[V8] DOMCoreException should be visible as DOMException
https://bugs.webkit.org/show_bug.cgi?id=35552

Reviewed by Nate Chapin.

Fix V8 code generator to use the correct visible name.

* bindings/scripts/CodeGeneratorV8.pm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-02 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Tue, 2 Mar 2010 18:34:28 +0000 (18:34 +0000)]
2010-03-02  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Alexey Proskuryakov.

        Test plugin still has issues with releasing objects, and variants
        https://bugs.webkit.org/show_bug.cgi?id=35587

        Fix the conditions for releasing the variants after calling
        invoke, and avoid having a number of objects leak.

        * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
        (testDocumentOpen):
        (testWindowOpen):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION(r51097) - Unable to log in to statefarm.com
beidson@apple.com [Tue, 2 Mar 2010 18:33:56 +0000 (18:33 +0000)]
REGRESSION(r51097) - Unable to log in to statefarm.com
<rdar://problem/7672667> and https://bugs.webkit.org/show_bug.cgi?id=35556

Reviewed by Sam Weinig.

WebCore:

Test: fast/loader/for-window-event-onload-scripts.html

Match Gecko's rules for executing "for/event" scripts:
  -If there's only a 'for' attribute, execute it.
  -If there's only an 'event' attribute, execute it.
  -If there's a 'for=window' and 'event=onload', execute it.
  -If there's a 'for=window' and 'event=onload()', execute it.
  -If there's any other combination of both 'for' and 'event', don't execute it.

* dom/ScriptElement.cpp:
(WebCore::ScriptElementData::shouldExecuteAsJavaScript):
* dom/ScriptElement.h:

* html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::eventAttributeValue):
* html/HTMLScriptElement.h:

* svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::eventAttributeValue):
* svg/SVGScriptElement.h:

Add the event attribute name:
* html/HTMLAttributeNames.in:

LayoutTests:

* fast/loader/for-window-event-onload-scripts-expected.txt: Added.
* fast/loader/for-window-event-onload-scripts.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-02 James Hawkins <jhawkins@chromium.org>
eric@webkit.org [Tue, 2 Mar 2010 18:19:41 +0000 (18:19 +0000)]
2010-03-02  James Hawkins  <jhawkins@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Implement WebNode::equals and add inline operators for ==
        and !=.

        https://bugs.webkit.org/show_bug.cgi?id=35543

        * public/WebNode.h:
        (WebKit::operator==):
        (WebKit::operator!=):
        * src/WebNode.cpp:
        (WebKit::WebNode::equals):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-02 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 2 Mar 2010 17:52:58 +0000 (17:52 +0000)]
2010-03-02  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=35555
        QuickTime plugin content can spill outside the <object> tag

        Set -masksToBounds on the layer that is handed to us by plug-ins, to ensure that sublayers
        of that layer don't spill outside the <object> contents rect.

        Manual test because it relies on QuickTime, and pixel results depend on movie loading timing.

        * manual-tests/plugins/object-clipping.html: Added.
        * platform/graphics/mac/GraphicsLayerCA.mm:
        (WebCore::GraphicsLayerCA::setupContentsLayer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRefactored the StyleChecker class's file-processing method
cjerdonek@webkit.org [Tue, 2 Mar 2010 17:25:52 +0000 (17:25 +0000)]
Refactored the StyleChecker class's file-processing method
_process_file().  This will make it easier to add new
file-processing capabilities to check-webkit-style.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=35490

* Scripts/webkitpy/style/checker.py:
  - Added a _read_lines() method to the StyleChecker class
    that extracts the lines from a file.
  - Replaced part of _process_file() with a call to the new
    _read_lines() method.
  - Replaced another part of _process_file() with a call
    to the new CarriageReturnProcessor.process() method.

* Scripts/webkitpy/style/processors/common.py:
  - Replaced the check_no_carriage_return() function with a
    new CarriageReturnProcessor class.

* Scripts/webkitpy/style/processors/common_unittest.py:
  - Renamed the CarriageReturnTest class to
    CarriageReturnProcessorTest and updated it as necessary.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixing layout test problems. No review.
cfleizach@apple.com [Tue, 2 Mar 2010 17:25:46 +0000 (17:25 +0000)]
Fixing layout test problems. No review.

AX: changes to WAI-ARIA grid aren't perceived correctly by VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=35514

AXTable tests crash on Leopard/Tiger because tables don't exist. This test needs to be skipped
on those playtforms.

* platform/mac-leopard/Skipped:
* platform/mac-tiger/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-02 Chris Jerdonek <cjerdonek@webkit.org>
cjerdonek@webkit.org [Tue, 2 Mar 2010 16:48:05 +0000 (16:48 +0000)]
2010-03-02  Chris Jerdonek  <cjerdonek@webkit.org>

        Reviewed by Shinichiro Hamaji.

        Started using the logging module in check-webkit-style.
        This provides more options for debugging and a more flexible,
        uniform way to report messages to the end-user.

        https://bugs.webkit.org/show_bug.cgi?id=35484

        Also included classes in a central location to facilitate
        the unit testing of logging code (setUp and tearDown of unit
        test logging configurations, etc).

        * Scripts/check-webkit-style:
          - Added a call to configure_logging() in the beginning of main().
          - Replaced two calls to sys.stderr.write() with appropriate
            logging calls.

        * Scripts/webkitpy/init/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py.

        * Scripts/webkitpy/init/logtesting.py: Added.
          - Added a UnitTestLogStream class to capture log output
            during unit tests.
          - Added a UnitTestLog class that provides convenience methods
            for unit-testing logging code.

        * Scripts/webkitpy/style/checker.py:
          - Added a configure_logging() method.
          - Added a _LevelLoggingFilter class to filter out log messages
            above a certain logging level.
          - Removed the _stderr_write() method from the StyleChecker class
            and replaced its use with appropriate logging calls.

        * Scripts/webkitpy/style/checker_unittest.py:
          - Added a ConfigureLoggingTest class to unit test the
            configure_logging() method.
          - Updated the StyleCheckerCheckFileTest class as necessary.

        * Scripts/webkitpy/style_references.py:
          - Added references to logtesting.UnitTestLog and
            logtesting.UnitTestLogStream.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoExpose SecurityOrigin::registerURLSchemeAsSecure as WebKit SPI
aroben@apple.com [Tue, 2 Mar 2010 16:22:44 +0000 (16:22 +0000)]
Expose SecurityOrigin::registerURLSchemeAsSecure as WebKit SPI

Fixes <http://webkit.org/b/35580> <rdar://problem/7706407>

Reviewed by Tim Hatcher.

WebCore:

Export SecurityOrigin::registerURLSchemeAsSecure

* WebCore.base.exp: Added symbol, sorted file.

WebKit/mac:

Add -[WebView _registerURLSchemeAsSecure:]

* WebView/WebView.mm:
(+[WebView _registerURLSchemeAsSecure:]):
* WebView/WebViewPrivate.h:
Added. Calls through to SecurityOrigin::registerURLSchemeAsSecure.

WebKit/win:

Add IWebViewPrivate::registerURLSchemeAsSecure

* Interfaces/WebKit.idl: Touched to force a build.

* Interfaces/IWebViewPrivate.idl:
* WebView.cpp:
(WebView::registerURLSchemeAsSecure):
* WebView.h:
Added. Calls through to SecurityOrigin::registerURLSchemeAsSecure.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-02 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 2 Mar 2010 14:37:33 +0000 (14:37 +0000)]
2010-03-02  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: render breakpoints as border images instead of canvas.

        https://bugs.webkit.org/show_bug.cgi?id=35535

        * inspector/front-end/Images/breakpointBorder.png: Added.
        * inspector/front-end/Images/breakpointConditionalBorder.png: Added.
        * inspector/front-end/Images/breakpointConditionalCounterBorder.png: Added.
        * inspector/front-end/Images/breakpointCounterBorder.png: Added.
        * inspector/front-end/Images/programCounterBorder.png: Added.
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._updateExecutionLine):
        (WebInspector.SourceFrame.prototype._addBreakpointToSource):
        (WebInspector.SourceFrame.prototype.resize):
        * inspector/front-end/TextViewer.js:
        (WebInspector.TextChunk):
        * inspector/front-end/textViewer.css:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Special case Font::floatWidthForComplexText for single space
zecke@webkit.org [Tue, 2 Mar 2010 10:16:24 +0000 (10:16 +0000)]
[Qt] Special case Font::floatWidthForComplexText for single space

https://bugs.webkit.org/show_bug.cgi?id=33876

For a single space we can go through the QFontMetric::width routine
instead of converting the WebCore::String to a QString and then
going through the QTextLine.

* platform/graphics/qt/FontQt.cpp:
(WebCore::Font::floatWidthForComplexText):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Gtk] Support private browsing mode in plugins.
zecke@webkit.org [Tue, 2 Mar 2010 09:59:28 +0000 (09:59 +0000)]
[Gtk] Support private browsing mode in plugins.

https://bugs.webkit.org/show_bug.cgi?id=35500

Integrate the PluginViewQt.cpp changes from
r55358 into Gtk+ and unskip the test.

* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::getValue):
* platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-02 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Tue, 2 Mar 2010 09:12:54 +0000 (09:12 +0000)]
2010-03-02  Oliver Hunt  <oliver@apple.com>

        Reviewed by NOBODY (Build fix).

        Update Qt bridge to new named getter signature

        * bridge/qt/qt_runtime.cpp:
        (JSC::Bindings::QtRuntimeMetaMethod::lengthGetter):
        (JSC::Bindings::QtRuntimeMetaMethod::connectGetter):
        (JSC::Bindings::QtRuntimeMetaMethod::disconnectGetter):
        (JSC::Bindings::QtRuntimeConnectionMethod::lengthGetter):
        * bridge/qt/qt_runtime.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-02 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Tue, 2 Mar 2010 08:32:30 +0000 (08:32 +0000)]
2010-03-02  Oliver Hunt  <oliver@apple.com>

        Reviewed by NOBODY (Build fix).

        Export function on windows.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-01 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 2 Mar 2010 08:30:03 +0000 (08:30 +0000)]
2010-03-01  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] Move gstreamer-related source files to platform/graphics/gstreamer
        https://bugs.webkit.org/show_bug.cgi?id=35518

        Moved GStreamer-related files to platform/graphics/gstreamer so
        other ports could benefit from this media player implementation.

        * GNUmakefile.am:
        * platform/graphics/gstreamer/DataSourceGStreamer.cpp: Renamed from WebCore/platform/graphics/gtk/DataSourceGStreamer.cpp.
        (_do_init):
        (webkit_data_src_base_init):
        (webkit_data_src_class_init):
        (webkit_data_src_reset):
        (webkit_data_src_init):
        (webkit_data_src_finalize):
        (webkit_data_src_change_state):
        (webkit_data_src_uri_get_type):
        (webkit_data_src_uri_get_protocols):
        (webkit_data_src_uri_get_uri):
        (webkit_data_src_uri_set_uri):
        (webkit_data_src_uri_handler_init):
        * platform/graphics/gstreamer/DataSourceGStreamer.h: Renamed from WebCore/platform/graphics/gtk/DataSourceGStreamer.h.
        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: Renamed from WebCore/platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp.
        (WebCore::greatestCommonDivisor):
        (WebCore::mediaPlayerPrivateMessageCallback):
        (WebCore::mediaPlayerPrivateSourceChangedCallback):
        (WebCore::mediaPlayerPrivateVolumeChangedCallback):
        (WebCore::notifyVolumeIdleCallback):
        (WebCore::mediaPlayerPrivateMuteChangedCallback):
        (WebCore::notifyMuteIdleCallback):
        (WebCore::bufferingTimeoutCallback):
        (WebCore::playbackPosition):
        (WebCore::mediaPlayerPrivateRepaintCallback):
        (WebCore::MediaPlayerPrivate::create):
        (WebCore::MediaPlayerPrivate::registerMediaEngine):
        (WebCore::doGstInit):
        (WebCore::MediaPlayerPrivate::isAvailable):
        (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
        (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
        (WebCore::MediaPlayerPrivate::load):
        (WebCore::MediaPlayerPrivate::changePipelineState):
        (WebCore::MediaPlayerPrivate::play):
        (WebCore::MediaPlayerPrivate::pause):
        (WebCore::MediaPlayerPrivate::duration):
        (WebCore::MediaPlayerPrivate::currentTime):
        (WebCore::MediaPlayerPrivate::seek):
        (WebCore::MediaPlayerPrivate::startEndPointTimerIfNeeded):
        (WebCore::MediaPlayerPrivate::cancelSeek):
        (WebCore::MediaPlayerPrivate::endPointTimerFired):
        (WebCore::MediaPlayerPrivate::paused):
        (WebCore::MediaPlayerPrivate::seeking):
        (WebCore::MediaPlayerPrivate::naturalSize):
        (WebCore::MediaPlayerPrivate::hasVideo):
        (WebCore::MediaPlayerPrivate::hasAudio):
        (WebCore::MediaPlayerPrivate::setVolume):
        (WebCore::MediaPlayerPrivate::volumeChangedCallback):
        (WebCore::MediaPlayerPrivate::volumeChanged):
        (WebCore::MediaPlayerPrivate::setRate):
        (WebCore::MediaPlayerPrivate::networkState):
        (WebCore::MediaPlayerPrivate::readyState):
        (WebCore::MediaPlayerPrivate::buffered):
        (WebCore::MediaPlayerPrivate::processBufferingStats):
        (WebCore::MediaPlayerPrivate::queryBufferingStats):
        (WebCore::MediaPlayerPrivate::maxTimeSeekable):
        (WebCore::MediaPlayerPrivate::maxTimeLoaded):
        (WebCore::MediaPlayerPrivate::bytesLoaded):
        (WebCore::MediaPlayerPrivate::totalBytes):
        (WebCore::MediaPlayerPrivate::cancelLoad):
        (WebCore::MediaPlayerPrivate::updateStates):
        (WebCore::MediaPlayerPrivate::mediaLocationChanged):
        (WebCore::MediaPlayerPrivate::loadNextLocation):
        (WebCore::MediaPlayerPrivate::loadStateChanged):
        (WebCore::MediaPlayerPrivate::sizeChanged):
        (WebCore::MediaPlayerPrivate::timeChanged):
        (WebCore::MediaPlayerPrivate::didEnd):
        (WebCore::MediaPlayerPrivate::durationChanged):
        (WebCore::MediaPlayerPrivate::supportsMuting):
        (WebCore::MediaPlayerPrivate::setMuted):
        (WebCore::MediaPlayerPrivate::muteChangedCallback):
        (WebCore::MediaPlayerPrivate::muteChanged):
        (WebCore::MediaPlayerPrivate::loadingFailed):
        (WebCore::MediaPlayerPrivate::setSize):
        (WebCore::MediaPlayerPrivate::setVisible):
        (WebCore::MediaPlayerPrivate::repaint):
        (WebCore::MediaPlayerPrivate::paint):
        (WebCore::mimeTypeCache):
        (WebCore::MediaPlayerPrivate::getSupportedTypes):
        (WebCore::MediaPlayerPrivate::supportsType):
        (WebCore::MediaPlayerPrivate::hasSingleSecurityOrigin):
        (WebCore::MediaPlayerPrivate::supportsFullscreen):
        (WebCore::MediaPlayerPrivate::setAutobuffer):
        (WebCore::MediaPlayerPrivate::createGSTPlayBin):
        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: Renamed from WebCore/platform/graphics/gtk/MediaPlayerPrivateGStreamer.h.
        (WebCore::MediaPlayerPrivate::pipelineReset):
        * platform/graphics/gstreamer/VideoSinkGStreamer.cpp: Renamed from WebCore/platform/graphics/gtk/VideoSinkGStreamer.cpp.
        (webkit_video_sink_base_init):
        (webkit_video_sink_init):
        (webkit_video_sink_timeout_func):
        (webkit_video_sink_render):
        (webkit_video_sink_dispose):
        (unlock_buffer_mutex):
        (webkit_video_sink_unlock):
        (webkit_video_sink_unlock_stop):
        (webkit_video_sink_stop):
        (webkit_video_sink_start):
        (marshal_VOID__MINIOBJECT):
        (webkit_video_sink_class_init):
        (webkit_video_sink_new):
        * platform/graphics/gstreamer/VideoSinkGStreamer.h: Renamed from WebCore/platform/graphics/gtk/VideoSinkGStreamer.h.
        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: Renamed from WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp.
        (doInit):
        (webkit_web_src_base_init):
        (webkit_web_src_class_init):
        (webkit_web_src_init):
        (webKitWebSrcFinalize):
        (webKitWebSrcSetProperty):
        (webKitWebSrcGetProperty):
        (webKitWebSrcStop):
        (webKitWebSrcStart):
        (webKitWebSrcChangeState):
        (webKitWebSrcUriGetType):
        (webKitWebSrcGetProtocols):
        (webKitWebSrcGetUri):
        (webKitWebSrcSetUri):
        (webKitWebSrcUriHandlerInit):
        (webKitWebSrcNeedDataMainCb):
        (webKitWebSrcNeedDataCb):
        (webKitWebSrcEnoughDataMainCb):
        (webKitWebSrcEnoughDataCb):
        (webKitWebSrcSeekMainCb):
        (webKitWebSrcSeekDataCb):
        (webKitWebSrcSetFrame):
        (StreamingClient::StreamingClient):
        (StreamingClient::~StreamingClient):
        (StreamingClient::willSendRequest):
        (StreamingClient::didReceiveResponse):
        (StreamingClient::didReceiveData):
        (StreamingClient::didFinishLoading):
        (StreamingClient::didFail):
        (StreamingClient::wasBlocked):
        (StreamingClient::cannotShowURL):
        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.h: Renamed from WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.h.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-01 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Tue, 2 Mar 2010 08:20:48 +0000 (08:20 +0000)]
2010-03-01  Oliver Hunt  <oliver@apple.com>

        Reviewed by Maciej Stachowiak.

        Refactor named getter function signature to be in line with indexing getter signature
        https://bugs.webkit.org/show_bug.cgi?id=35563

        This removes the PropertySlot argument from getter functions, and makes them directly
        pass the slot base.  This makes the semantics for the functions match that of the
        indexing getters.

        On the down side, this means that we can no longer simply use a proxy function for
        JS getters, so we now add another marker value to indicate that a getter is present
        and branch accordingly.

        Against all rationality sunspider reports this as a perf win, but i suspect it's just noise.

        * API/JSCallbackObject.h:
        * API/JSCallbackObjectFunctions.h:
        (JSC::::staticValueGetter):
        (JSC::::staticFunctionGetter):
        (JSC::::callbackGetter):
        * JavaScriptCore.exp:
        * runtime/JSActivation.cpp:
        (JSC::JSActivation::argumentsGetter):
        * runtime/JSActivation.h:
        * runtime/JSFunction.cpp:
        (JSC::JSFunction::argumentsGetter):
        (JSC::JSFunction::callerGetter):
        (JSC::JSFunction::lengthGetter):
        * runtime/JSFunction.h:
        * runtime/NumberConstructor.cpp:
        (JSC::numberConstructorNaNValue):
        (JSC::numberConstructorNegInfinity):
        (JSC::numberConstructorPosInfinity):
        (JSC::numberConstructorMaxValue):
        (JSC::numberConstructorMinValue):
        * runtime/PropertySlot.cpp:
        (JSC::PropertySlot::functionGetter):
        * runtime/PropertySlot.h:
        (JSC::PropertySlot::getValue):
        (JSC::PropertySlot::setGetterSlot):
        (JSC::PropertySlot::setCacheableGetterSlot):
        * runtime/RegExpConstructor.cpp:
        (JSC::regExpConstructorDollar1):
        (JSC::regExpConstructorDollar2):
        (JSC::regExpConstructorDollar3):
        (JSC::regExpConstructorDollar4):
        (JSC::regExpConstructorDollar5):
        (JSC::regExpConstructorDollar6):
        (JSC::regExpConstructorDollar7):
        (JSC::regExpConstructorDollar8):
        (JSC::regExpConstructorDollar9):
        (JSC::regExpConstructorInput):
        (JSC::regExpConstructorMultiline):
        (JSC::regExpConstructorLastMatch):
        (JSC::regExpConstructorLastParen):
        (JSC::regExpConstructorLeftContext):
        (JSC::regExpConstructorRightContext):
        * runtime/RegExpObject.cpp:
        (JSC::regExpObjectGlobal):
        (JSC::regExpObjectIgnoreCase):
        (JSC::regExpObjectMultiline):
        (JSC::regExpObjectSource):
        (JSC::regExpObjectLastIndex):
2010-03-01  Oliver Hunt  <oliver@apple.com>

        Reviewed by Maciej Stachowiak.

        Refactor named getter function signature to be in line with indexing getter signature
        https://bugs.webkit.org/show_bug.cgi?id=35563

        Fix method signature and update code as appropriate

        * UserObjectImp.cpp:
        (UserObjectImp::userObjectGetter):
        * UserObjectImp.h:
2010-03-01  Oliver Hunt  <oliver@apple.com>

        Reviewed by Maciej Stachowiak.

        Refactor named getter function signature to be in line with indexing getter signature
        https://bugs.webkit.org/show_bug.cgi?id=35563

        Fix up WebCore to use the new named getter function signature, update the
        codegenerator to the new calling convention, and fix the custom bindings.

        * bindings/js/JSCSSStyleDeclarationCustom.cpp:
        (WebCore::JSCSSStyleDeclaration::nameGetter):
        * bindings/js/JSDOMBinding.cpp:
        (WebCore::objectToStringFunctionGetter):
        * bindings/js/JSDOMBinding.h:
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::nonCachingStaticFunctionGetter):
        (WebCore::childFrameGetter):
        (WebCore::namedItemGetter):
        * bindings/js/JSDataGridColumnListCustom.cpp:
        (WebCore::JSDataGridColumnList::nameGetter):
        * bindings/js/JSHTMLAllCollectionCustom.cpp:
        (WebCore::JSHTMLAllCollection::nameGetter):
        * bindings/js/JSHTMLCollectionCustom.cpp:
        (WebCore::JSHTMLCollection::nameGetter):
        * bindings/js/JSHTMLDocumentCustom.cpp:
        (WebCore::JSHTMLDocument::nameGetter):
        * bindings/js/JSHTMLFormElementCustom.cpp:
        (WebCore::JSHTMLFormElement::nameGetter):
        * bindings/js/JSHTMLFrameSetElementCustom.cpp:
        (WebCore::JSHTMLFrameSetElement::nameGetter):
        * bindings/js/JSHistoryCustom.cpp:
        (WebCore::nonCachingStaticBackFunctionGetter):
        (WebCore::nonCachingStaticForwardFunctionGetter):
        (WebCore::nonCachingStaticGoFunctionGetter):
        * bindings/js/JSLocationCustom.cpp:
        (WebCore::nonCachingStaticReplaceFunctionGetter):
        (WebCore::nonCachingStaticReloadFunctionGetter):
        (WebCore::nonCachingStaticAssignFunctionGetter):
        * bindings/js/JSMimeTypeArrayCustom.cpp:
        (WebCore::JSMimeTypeArray::nameGetter):
        * bindings/js/JSNamedNodeMapCustom.cpp:
        (WebCore::JSNamedNodeMap::nameGetter):
        * bindings/js/JSNodeListCustom.cpp:
        (WebCore::JSNodeList::nameGetter):
        * bindings/js/JSPluginArrayCustom.cpp:
        (WebCore::JSPluginArray::nameGetter):
        * bindings/js/JSPluginCustom.cpp:
        (WebCore::JSPlugin::nameGetter):
        * bindings/js/JSPluginElementFunctions.cpp:
        (WebCore::runtimeObjectPropertyGetter):
        * bindings/js/JSPluginElementFunctions.h:
        * bindings/js/JSStorageCustom.cpp:
        (WebCore::JSStorage::nameGetter):
        * bindings/js/JSStyleSheetListCustom.cpp:
        (WebCore::JSStyleSheetList::nameGetter):
        * bindings/scripts/CodeGeneratorJS.pm:
        * bridge/runtime_array.cpp:
        (JSC::RuntimeArray::lengthGetter):
        * bridge/runtime_array.h:
        * bridge/runtime_method.cpp:
        (JSC::RuntimeMethod::lengthGetter):
        * bridge/runtime_method.h:
        * bridge/runtime_object.cpp:
        (JSC::Bindings::RuntimeObject::fallbackObjectGetter):
        (JSC::Bindings::RuntimeObject::fieldGetter):
        (JSC::Bindings::RuntimeObject::methodGetter):
        * bridge/runtime_object.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSymbian build fix.
hausmann@webkit.org [Tue, 2 Mar 2010 08:10:26 +0000 (08:10 +0000)]
Symbian build fix.

[Qt] Updated the def file with one new export, to fix
QtLauncher linkage.

* symbian/eabi/QtWebKitu.def:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove Windows line endings from some files.
jhoneycutt@apple.com [Tue, 2 Mar 2010 04:14:53 +0000 (04:14 +0000)]
Remove Windows line endings from some files.

Rubber-stamped by Alice Liu.

* Interfaces/IWebEmbeddedView.idl:

* WebCoreSupport/EmbeddedWidget.cpp:
(EmbeddedWidget::create):
(EmbeddedWidget::~EmbeddedWidget):
(EmbeddedWidget::createWindow):
(EmbeddedWidget::invalidateRect):
(EmbeddedWidget::setFrameRect):
(EmbeddedWidget::frameRectsChanged):
(EmbeddedWidget::setFocus):
(EmbeddedWidget::show):
(EmbeddedWidget::hide):
(EmbeddedWidget::windowClipRect):
(EmbeddedWidget::setParent):
(EmbeddedWidget::attachToWindow):
(EmbeddedWidget::detachFromWindow):
(EmbeddedWidget::didReceiveResponse):
(EmbeddedWidget::didReceiveData):
(EmbeddedWidget::didFinishLoading):
(EmbeddedWidget::didFail):

* WebCoreSupport/EmbeddedWidget.h:
(EmbeddedWidget::EmbeddedWidget):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSome WebKit DOMNode API is unimplemented.
jhoneycutt@apple.com [Tue, 2 Mar 2010 04:14:39 +0000 (04:14 +0000)]
Some WebKit DOMNode API is unimplemented.
https://bugs.webkit.org/show_bug.cgi?id=35554

Reviewed by Alice Liu.

* DOMCoreClasses.cpp:
(DOMNode::nextSibling):
Create a DOMNode to wrap m_node's next sibling, and assign it to the
out param 'result'.
(DOMNode::insertBefore):
Query for the DOMNode for newChild, and return early if we fail. Query
refChild for DOMNode. Call insertBefore(), passing the newChild's
WebCore node and refChild's WebCore node (if refChild is non-null). If
we successfully insert the child, fill the result out param with
newChild, ref it, and return S_OK. Otherwise, return E_FAIL.
(DOMNode::removeChild):
Query oldChild for DOMNode. If we fail, return E_FAIL. Call
removeChild(), passing the node's WebCore node. If this fails, return
E_FAIL. Otherwise, fill the result out param with oldChild, ref it, and
return S_OK.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-01 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Tue, 2 Mar 2010 04:08:22 +0000 (04:08 +0000)]
2010-03-01  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        PropertySlot::getValue(ExecState, unsigned) unnecessarily converts index to an Identifier
        https://bugs.webkit.org/show_bug.cgi?id=35561

        Fix this by defining a separate property getter function for index getters.  This allows
        us to pass an unsigned number without the conversion to an Identifier.  We then update
        setCustomIndex to take this new getter type.

        * runtime/PropertySlot.h:
        (JSC::PropertySlot::getValue):
        (JSC::PropertySlot::setCustom):
        (JSC::PropertySlot::setCustomIndex):
2010-03-01  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        PropertySlot::getValue(ExecState, unsigned) unnecessarily converts index to an Identifier
        https://bugs.webkit.org/show_bug.cgi?id=35561

        Update bindings generation and the few manual indexing getters we have to use
        the new PropertySlot API.

        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::indexGetter):
        * bindings/scripts/CodeGeneratorJS.pm:
        * bridge/runtime_array.cpp:
        (JSC::RuntimeArray::indexGetter):
        * bridge/runtime_array.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Darin Adler.
ap@apple.com [Tue, 2 Mar 2010 02:24:24 +0000 (02:24 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=26520
        Accessing a DOM node from a parent window in a child iframe moves the prototype to the child
        iframe and resets it in the parent window

        Adding a test for a bug that no longer occurs in ToT.

        * fast/dom/cross-frame-node-prototype-expected.txt: Added.
        * fast/dom/cross-frame-node-prototype.html: Added.
        * fast/dom/resources/cross-frame-node-prototype-iframe.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixing broken DRT on Leopard/Tiger. Second try.
cfleizach@apple.com [Tue, 2 Mar 2010 01:58:58 +0000 (01:58 +0000)]
Fixing broken DRT on Leopard/Tiger. Second try.

AX: changes to WAI-ARIA grid aren't perceived correctly by VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=35514

* DumpRenderTree/mac/AccessibilityUIElementMac.mm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixing broken DRT on Leopard/Tiger.
cfleizach@apple.com [Tue, 2 Mar 2010 01:50:33 +0000 (01:50 +0000)]
Fixing broken DRT on Leopard/Tiger.

AX: changes to WAI-ARIA grid aren't perceived correctly by VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=35514

* DumpRenderTree/mac/AccessibilityUIElementMac.mm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-01 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Tue, 2 Mar 2010 01:40:31 +0000 (01:40 +0000)]
2010-03-01  Gustavo Noronha Silva  <gns@gnome.org>

        Rebaseline the two editing tests we stopped skipping - we failed
        to take the new caret position result into account while
        unskipping these.

        * platform/gtk/editing/selection/5109817-expected.txt:
        * platform/gtk/editing/selection/5354455-2-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKitTools
kov@webkit.org [Tue, 2 Mar 2010 01:35:58 +0000 (01:35 +0000)]
WebKitTools

2010-03-01  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Eric Seidel.

        [GTK] plugins/setProperty.html fails on 64bit Release
        https://bugs.webkit.org/show_bug.cgi?id=35425

        Check invoke's return code before releasing the variant, since
        there's a chance it won't be properly initialized, leading to
        memory corruption, in some cases.

        * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
        (testCallback):
        (testEnumerate):
        (testDocumentOpen):
        (testWindowOpen):
        (handleCallback):

LayoutTests

2010-03-01  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Eric Seidel.

        [GTK] plugins/setProperty.html fails on 64bit Release
        https://bugs.webkit.org/show_bug.cgi?id=35425

        Unskip the tests that failed as a consequence of the memory
        corruption.

        * platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-01 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 2 Mar 2010 01:29:45 +0000 (01:29 +0000)]
2010-03-01  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by nobody. Build bustage :(

        Fix stupid typo that I committed even after David Levin pointed
        it out to me :(

        https://bugs.webkit.org/show_bug.cgi?id=35553

        * Scripts/webkitpy/layout_tests/port/mac.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAX: changes to WAI-ARIA grid aren't perceived correctly by VoiceOver
cfleizach@apple.com [Tue, 2 Mar 2010 01:19:25 +0000 (01:19 +0000)]
AX: changes to WAI-ARIA grid aren't perceived correctly by VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=35514

Reviewed by Darin Adler.

WebCore:

When a table's DOM is changed and an AX Table is not asked first for its children,
it would return wrong information. A table needs to make sure children are up to date in
all methods that can be called from the outside.

Test: platform/mac/accessibility/stale-table-rows.html

* accessibility/AccessibilityARIAGrid.cpp:
(WebCore::AccessibilityARIAGrid::cellForColumnAndRow):
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::clearChildren):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::clearChildren):
(WebCore::AccessibilityRenderObject::updateChildrenIfNecessary):
(WebCore::AccessibilityRenderObject::children):
* accessibility/AccessibilityRenderObject.h:
(WebCore::AccessibilityRenderObject::needsToUpdateChildren):
(WebCore::AccessibilityRenderObject::setNeedsToUpdateChildren):
* accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::clearChildren):
(WebCore::AccessibilityTable::columns):
(WebCore::AccessibilityTable::rows):
(WebCore::AccessibilityTable::rowHeaders):
(WebCore::AccessibilityTable::columnHeaders):
(WebCore::AccessibilityTable::cells):
(WebCore::AccessibilityTable::columnCount):
(WebCore::AccessibilityTable::rowCount):
(WebCore::AccessibilityTable::cellForColumnAndRow):

WebKitTools:

Add rowCount, columnCount for tables.

* DumpRenderTree/AccessibilityUIElement.cpp:
(rowCountCallback):
(columnCountCallback):
(AccessibilityUIElement::getJSClass):
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::rowCount):
(AccessibilityUIElement::columnCount):
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::rowCount):
(AccessibilityUIElement::columnCount):
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::rowCount):
(AccessibilityUIElement::columnCount):

LayoutTests:

* platform/mac/accessibility/stale-table-rows-expected.txt: Added.
* platform/mac/accessibility/stale-table-rows.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-01 José Millán Soto <jmillan@igalia.com>
eric@webkit.org [Tue, 2 Mar 2010 01:12:16 +0000 (01:12 +0000)]
2010-03-01  José Millán Soto  <jmillan@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Right click does not activate text entry
        https://bugs.webkit.org/show_bug.cgi?id=29177

        Stop skipping some tests which where failing because of right click
        not being correct handled.

        * platform/gtk/Skipped:
2010-03-01  José Millán Soto  <jmillan@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Right click does not activate text entry
        https://bugs.webkit.org/show_bug.cgi?id=29177

        Makes the frame handle the mouse click event before sending the
        context menu event.

        * webkit/webkitwebview.cpp:
        (PopupMenuPositionFunc):
        Function created to make the popup menu appear in the correct position, especially
        when invoked from the keyboard.
        (webkit_web_view_forward_context_menu_event):
        Mouse click event is sent to frame before creating context menu,
        PopupMenuPositionFunc used to determine the position where the menu should appear.
        (webkit_web_view_popup_menu_handler):
        Improved focused node position detection. Event button set to right button.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-01 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 2 Mar 2010 01:07:09 +0000 (01:07 +0000)]
2010-03-01  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Eric Seidel.

        Work around a bug in Python's subprocess.Popen() that keeps us from
        cleaning up DumpRenderTree / test_shell properly when we finish the
        tests in new-run-webkit-tests.

        https://bugs.webkit.org/show_bug.cgi?id=35553

        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/mac.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-01 Jakob Petsovits <jpetsovits@rim.com>
eric@webkit.org [Tue, 2 Mar 2010 00:56:04 +0000 (00:56 +0000)]
2010-03-01  Jakob Petsovits  <jpetsovits@rim.com>

        Reviewed by Adam Barth.

        Convert the zoom mode (page vs. text-only) into a proper enum.
        https://bugs.webkit.org/show_bug.cgi?id=35347

        * GNUmakefile.am:
        * WebCore.base.exp: Substituted symbols __ZN7WebCore5Frame13setZoomFactorEfNS_8ZoomModeE
        and __ZN7WebCore8Settings11setZoomModeENS_8ZoomModeE for __ZN7WebCore5Frame13setZoomFactorEfb
        and __ZN7WebCore8Settings16setZoomsTextOnlyEb, respectively.
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * page/Frame.cpp:
        (WebCore::Frame::zoomMode):
        (WebCore::Frame::shouldApplyTextZoom):
        (WebCore::Frame::shouldApplyPageZoom):
        (WebCore::Frame::setZoomFactor):
        * page/Frame.h:
        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        (WebCore::Settings::setZoomMode):
        * page/Settings.h:
        (WebCore::Settings::zoomMode):
        * page/ZoomMode.h: Added.
        (WebCore::):
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::setCurrentScale):
2010-03-01  Jakob Petsovits  <jpetsovits@rim.com>

        Reviewed by Adam Barth.

        Adapt to the new ZoomMode enum.
        https://bugs.webkit.org/show_bug.cgi?id=35347

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::setZoomLevel):
2010-03-01  Jakob Petsovits  <jpetsovits@rim.com>

        Reviewed by Adam Barth.

        Adapt to the new ZoomMode enum.
        https://bugs.webkit.org/show_bug.cgi?id=35347

        * webkit/webkitwebview.cpp:
        (DNDContentsRequest::webkit_web_view_apply_zoom_level):
2010-03-01  Jakob Petsovits  <jpetsovits@rim.com>

        Reviewed by Adam Barth.

        Adapt to the new ZoomMode enum.
        https://bugs.webkit.org/show_bug.cgi?id=35347

        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]):
        (-[WebView _setZoomMultiplier:isTextOnly:]):
        (-[WebView _realZoomMultiplierIsTextOnly]):
2010-03-01  Jakob Petsovits  <jpetsovits@rim.com>

        Reviewed by Adam Barth.

        Adapt to the new ZoomMode enum.
        https://bugs.webkit.org/show_bug.cgi?id=35347

        * Api/qwebframe.cpp:
        (QWebFrame::setTextSizeMultiplier):
        (QWebFrame::setZoomFactor):
        * Api/qwebsettings.cpp:
        (QWebSettingsPrivate::apply):
2010-03-01  Jakob Petsovits  <jpetsovits@rim.com>

        Reviewed by Adam Barth.

        Adapt to the new ZoomMode enum.
        https://bugs.webkit.org/show_bug.cgi?id=35347

        * WebFrame.cpp:
        (WebFrame::setTextSizeMultiplier):
        * WebView.cpp:
        (WebView::setZoomMultiplier):
        (WebView::zoomMultiplier):
        (WebView::canMakeTextLarger):
        (WebView::makeTextLarger):
        (WebView::canMakeTextSmaller):
        (WebView::makeTextSmaller):
        (WebView::notifyPreferencesChanged):
2010-03-01  Jakob Petsovits  <jpetsovits@rim.com>

        Reviewed by Adam Barth.

        Adapt to the new ZoomMode enum.
        https://bugs.webkit.org/show_bug.cgi?id=35347

        * WebFrame.cpp:
        (wxWebFrame::IncreaseTextSize):
        (wxWebFrame::DecreaseTextSize):
        (wxWebFrame::ResetTextSize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-01 Alex Milowski <alex@milowski.com>
eric@webkit.org [Tue, 2 Mar 2010 00:22:13 +0000 (00:22 +0000)]
2010-03-01  Alex Milowski  <alex@milowski.com>

        Reviewed by Kenneth Rohde Christiansen.

        Added test for basic msubsup support.

        * mathml/presentation/subsup.xhtml: Added.
        * platform/mac/mathml/presentation/subsup-expected.checksum: Added.
        * platform/mac/mathml/presentation/subsup-expected.png: Added.
        * platform/mac/mathml/presentation/subsup-expected.txt: Added.
2010-03-01  Alex Milowski  <alex@milowski.com>

        Reviewed by Kenneth Rohde Christiansen.

        Added support for the msubsup element that also handles the msup and msub elements.

        Test: mathml/presentation/subsup.xhtml

        * WebCore.xcodeproj/project.pbxproj:
        * mathml/MathMLInlineContainerElement.cpp:
        (WebCore::MathMLInlineContainerElement::createRenderer):
        * mathml/RenderMathMLSubSup.cpp: Added.
        (WebCore::RenderMathMLSubSup::RenderMathMLSubSup):
        (WebCore::RenderMathMLSubSup::addChild):
        (WebCore::RenderMathMLSubSup::stretchToHeight):
        (WebCore::RenderMathMLSubSup::nonOperatorHeight):
        (WebCore::RenderMathMLSubSup::layout):
        (WebCore::RenderMathMLSubSup::baselinePosition):
        * mathml/RenderMathMLSubSup.h: Added.
        (WebCore::RenderMathMLSubSup::hasBase):
        (WebCore::RenderMathMLSubSup::):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/7703368> IWebUIDelegatePrivate::embeddedViewWithArguments
jhoneycutt@apple.com [Tue, 2 Mar 2010 00:18:10 +0000 (00:18 +0000)]
<rdar://problem/7703368> IWebUIDelegatePrivate::embeddedViewWithArguments
is passed wrong arguments

Reviewed by Adam Roben.

* Interfaces/IWebUIDelegatePrivate.idl:
Update copyright strings. Added a new key for the plug-in source URL.

* Interfaces/WebKit.idl:
Update copyright strings.

* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::createPlugin):
Pass the URL of the plug-in as the source URL. Pass the document's
base URI for the base URL.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-01 Arno Renevier <arno@renevier.net>
eric@webkit.org [Tue, 2 Mar 2010 00:05:35 +0000 (00:05 +0000)]
2010-03-01  Arno Renevier  <arno@renevier.net>

        Reviewed by Xan Lopez.

        webkit-build could pass unknown arguments to autogen.sh
        https://bugs.webkit.org/show_bug.cgi?id=35454

        * Scripts/build-webkit:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-01 Pavel Feldman <pfeldman@chromium.org>
eric@webkit.org [Mon, 1 Mar 2010 23:49:08 +0000 (23:49 +0000)]
2010-03-01  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: use dejavu sans mono 11px on linux.

        https://bugs.webkit.org/show_bug.cgi?id=35527

        * inspector/front-end/inspector.css:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-01 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Mon, 1 Mar 2010 23:17:08 +0000 (23:17 +0000)]
2010-03-01  Dirk Pranke  <dpranke@chromium.org>

        Rubber-stamped by Dimitri Glazkov.

        Fix breakage from r55372.

        https://bugs.webkit.org/show_bug.cgi?id=35549

        * Scripts/webkitpy/layout_tests/port/chromium.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-01 Thatcher Ulrich <tulrich@google.com>
eric@webkit.org [Mon, 1 Mar 2010 22:51:25 +0000 (22:51 +0000)]
2010-03-01  Thatcher Ulrich  <tulrich@google.com>

        Reviewed by Darin Fisher.

        Fix chromium iframe shims.  Add another test case to the
        iframes-shims test.  After r53637, the plugin widget doesn't get
        moved every paint.  This used to hide the bug that if an iframe
        gets added, the plugin's cutout rectangles don't get updated until
        a layout happens.
        https://bugs.webkit.org/show_bug.cgi?id=35184

        * plugins/iframe-shims.html: test case that adds an iframe shim dynamically
2010-03-01  Thatcher Ulrich  <tulrich@google.com>

        Reviewed by Darin Fisher.

        Fix chromium iframe shims.  Add another test case to the
        iframes-shims test.  After r53637, the plugin widget doesn't get
        moved every paint.  This used to hide the bug that if an iframe
        gets added, the plugin's cutout rectangles don't get updated until
        a layout happens.
        https://bugs.webkit.org/show_bug.cgi?id=35184

        * platform/Widget.h:
        (WebCore::Widget::widgetPositionsUpdated): new virtual method
            widgetPositionsUpdated() to notify widgets when other widgets on
            the page have been repositioned.
        * rendering/RenderView.cpp:
        (WebCore::RenderView::updateWidgetPositions): call widgetPositionsUpdated() on the widgets
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::widgetPositionsUpdated): call widgetPositionsUpdated() on the widget
        * rendering/RenderWidget.h:
2010-03-01  Thatcher Ulrich  <tulrich@google.com>

        Reviewed by Darin Fisher.

        Fix chromium iframe shims.  Add another test case to the
        iframes-shims test.  After r53637, the plugin widget doesn't get
        moved every paint.  This used to hide the bug that if an iframe
        gets added, the plugin's cutout rectangles don't get updated until
        a layout happens.
        https://bugs.webkit.org/show_bug.cgi?id=35184

        * src/WebPluginContainerImpl.cpp:
        (WebKit::WebPluginContainerImpl::widgetPositionsUpdated): do reportGeometry() to ensure that
            the plugin is aware of the positions of cutouts on the page (for iframe shim behavior).
        * src/WebPluginContainerImpl.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 1 Mar 2010 22:27:22 +0000 (22:27 +0000)]
2010-03-01  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        EWS can hang for five hours when compile output is too big
        https://bugs.webkit.org/show_bug.cgi?id=35545

        * Scripts/webkitpy/commands/queues.py: Limit uploads to 1MB instead of
        5MB.  AppEngine seems to not like 5MB uploads.  I'm not sure what the
        limit is.  Let's try 1MB for a while and see how it goes.
        * Scripts/webkitpy/networktransaction.py: Tune the default parameters
        to our exponential backoff.  I'm not sure why I picked five hours as
        the retry limit.  That seems way too large.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBug 35537 - put_by_id does will incorrectly cache writes where a specific value exists,
barraclough@apple.com [Mon, 1 Mar 2010 22:14:22 +0000 (22:14 +0000)]
Bug 35537 - put_by_id does will incorrectly cache writes where a specific value exists,
            where at the point of caching the same value is being written.

Reviewed by Oliver Hunt.

JavaScriptCore:

When performing a put_by_id that is replacing a property already present on the object,
there are three interesting cases regarding the state of the specific value:

(1) No specific value set - nothing to do, leave the structure in it's current state,
    can cache.
(2) A specific value was set, the new put is not of a specified value (i.e. function),
    or is of a different specific value - in these cases we need to perform a despecifying
    transition to clear the specific value in the structure, but having done so this is a
    normal property so as such we can again cache normally.
(3) A specific value was set, and we are overwriting with the same value - in these cases
    leave the structure unchanged, but since a specific value is set we cannot cache this
    put (we would need the JIT to dynamically check the value being written matched).

Unfortunately, the current behaviour does not match this.  the checks for a specific value
being present & the value matching are combined in such a way that in case (2), above we
will unnecessarily prevent the transition being cached, but in case (3) we will incorrectly
fail to prevent caching.

The bug exposes itself if multiple puts of the same specific value are performed to a
property, and erroneously the put is allowed to be cached by the JIT.  Method checks may be
generated caching calls of this structure.  Subsequent puts performed from JIT code may
write different values without triggering a despecify transition, and as such cached method
checks will continue to pass, despite the value having changed.

* runtime/JSObject.h:
(JSC::JSObject::putDirectInternal):

LayoutTests:

Add test case.

* fast/js/method-check-expected.txt:
* fast/js/script-tests/method-check.js:
(addOne):
(addOneHundred):
(totalizer.makeCall):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-01 Kalle Vahlman <zuh@iki.fi>
eric@webkit.org [Mon, 1 Mar 2010 22:07:45 +0000 (22:07 +0000)]
2010-03-01  Kalle Vahlman  <zuh@iki.fi>

        Reviewed by Gustavo Noronha Silva.

        Queue a resize when either of the content dimensions change
        https://bugs.webkit.org/show_bug.cgi?id=35489

        The check for size changes only queued a resize if both of the content
        dimensions change, leaving the widget size out-of-sync if eg. only the
        width changes.

        * WebCoreSupport/ChromeClientGtk.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-01 Fridrich Strba <fridrich.strba@bluewin.ch>
eric@webkit.org [Mon, 1 Mar 2010 21:51:22 +0000 (21:51 +0000)]
2010-03-01  Fridrich Strba  <fridrich.strba@bluewin.ch>

        Reviewed by Holger Freyther.

        Dist some mathml related files

        * GNUmakefile.am:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-01 Kenneth Russell <kbr@google.com>
kbr@google.com [Mon, 1 Mar 2010 21:20:31 +0000 (21:20 +0000)]
2010-03-01  Kenneth Russell  <kbr@google.com>

        Reviewed by Oliver Hunt.

        Integer overflow in WebGL arrays
        https://bugs.webkit.org/show_bug.cgi?id=35241

        Test: fast/canvas/webgl/webgl-array-invalid-ranges.html

        * bindings/js/JSWebGLArrayBufferConstructor.cpp:
        (WebCore::constructCanvasArrayBuffer):
        * bindings/js/JSWebGLArrayBufferConstructor.h:
        (WebCore::construct):
        * bindings/js/JSWebGLArrayHelper.h:
        (WebCore::setWebGLArrayFromArray):
        * bindings/js/JSWebGLByteArrayConstructor.cpp:
        (WebCore::constructCanvasByteArray):
        * bindings/js/JSWebGLFloatArrayConstructor.cpp:
        (WebCore::constructCanvasFloatArray):
        * bindings/js/JSWebGLIntArrayConstructor.cpp:
        (WebCore::constructCanvasIntArray):
        * bindings/js/JSWebGLShortArrayConstructor.cpp:
        (WebCore::constructCanvasShortArray):
        * bindings/js/JSWebGLUnsignedByteArrayConstructor.cpp:
        (WebCore::constructCanvasUnsignedByteArray):
        * bindings/js/JSWebGLUnsignedIntArrayConstructor.cpp:
        (WebCore::constructCanvasUnsignedIntArray):
        * bindings/js/JSWebGLUnsignedShortArrayConstructor.cpp:
        (WebCore::constructCanvasUnsignedShortArray):
        * bindings/v8/V8Binding.cpp:
        (WebCore::toUInt32):
        * bindings/v8/V8Binding.h:
        (WebCore::toUInt32):
        * bindings/v8/custom/V8WebGLArrayBufferCustom.cpp:
        (WebCore::V8WebGLArrayBuffer::constructorCallback):
        * bindings/v8/custom/V8WebGLArrayCustom.h:
        (WebCore::constructWebGLArray):
        (WebCore::getWebGLArrayElement):
        (WebCore::setWebGLArrayFromArray):
        (WebCore::setWebGLArray):
        * bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
        (WebCore::V8WebGLByteArray::constructorCallback):
        * bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
        (WebCore::V8WebGLFloatArray::constructorCallback):
        * bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
        (WebCore::V8WebGLIntArray::constructorCallback):
        * bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
        (WebCore::V8WebGLShortArray::constructorCallback):
        * bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
        (WebCore::V8WebGLUnsignedByteArray::constructorCallback):
        * bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
        (WebCore::V8WebGLUnsignedIntArray::constructorCallback):
        * bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
        (WebCore::V8WebGLUnsignedShortArray::constructorCallback):
        * html/canvas/WebGLArray.cpp:
        (WebCore::WebGLArray::setImpl):
        * html/canvas/WebGLArray.h:
        (WebCore::WebGLArray::verifySubRange):
        (WebCore::WebGLArray::clampOffsetAndNumElements):
        * html/canvas/WebGLArrayBuffer.cpp:
        (WebCore::WebGLArrayBuffer::create):
        (WebCore::WebGLArrayBuffer::WebGLArrayBuffer):
        (WebCore::WebGLArrayBuffer::tryAllocate):
        * html/canvas/WebGLArrayBuffer.h:
        * html/canvas/WebGLByteArray.cpp:
        (WebCore::WebGLByteArray::create):
        (WebCore::WebGLByteArray::WebGLByteArray):
        (WebCore::WebGLByteArray::slice):
        * html/canvas/WebGLByteArray.h:
        * html/canvas/WebGLFloatArray.cpp:
        (WebCore::WebGLFloatArray::create):
        (WebCore::WebGLFloatArray::WebGLFloatArray):
        (WebCore::WebGLFloatArray::slice):
        * html/canvas/WebGLFloatArray.h:
        * html/canvas/WebGLIntArray.cpp:
        (WebCore::WebGLIntArray::create):
        (WebCore::WebGLIntArray::WebGLIntArray):
        (WebCore::WebGLIntArray::slice):
        * html/canvas/WebGLIntArray.h:
        * html/canvas/WebGLShortArray.cpp:
        (WebCore::WebGLShortArray::create):
        (WebCore::WebGLShortArray::WebGLShortArray):
        (WebCore::WebGLShortArray::slice):
        * html/canvas/WebGLShortArray.h:
        * html/canvas/WebGLUnsignedByteArray.cpp:
        (WebCore::WebGLUnsignedByteArray::create):
        (WebCore::WebGLUnsignedByteArray::WebGLUnsignedByteArray):
        (WebCore::WebGLUnsignedByteArray::slice):
        * html/canvas/WebGLUnsignedByteArray.h:
        * html/canvas/WebGLUnsignedIntArray.cpp:
        (WebCore::WebGLUnsignedIntArray::create):
        (WebCore::WebGLUnsignedIntArray::WebGLUnsignedIntArray):
        (WebCore::WebGLUnsignedIntArray::slice):
        * html/canvas/WebGLUnsignedIntArray.h:
        * html/canvas/WebGLUnsignedShortArray.cpp:
        (WebCore::WebGLUnsignedShortArray::create):
        (WebCore::WebGLUnsignedShortArray::WebGLUnsignedShortArray):
        (WebCore::WebGLUnsignedShortArray::slice):
        * html/canvas/WebGLUnsignedShortArray.h:

2010-03-01  Kenneth Russell  <kbr@google.com>

        Reviewed by Oliver Hunt.

        Integer overflow in WebGL arrays
        https://bugs.webkit.org/show_bug.cgi?id=35241

        * fast/canvas/webgl/array-unit-tests-expected.txt:
        * fast/canvas/webgl/array-unit-tests.html:
        * fast/canvas/webgl/webgl-array-invalid-ranges-expected.txt: Added.
        * fast/canvas/webgl/webgl-array-invalid-ranges.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION: Telling a WebView to go to its current WebHistoryItem is broken.
beidson@apple.com [Mon, 1 Mar 2010 21:10:10 +0000 (21:10 +0000)]
REGRESSION: Telling a WebView to go to its current WebHistoryItem is broken.
<rdar://problem/7699371> and https://bugs.webkit.org/show_bug.cgi?id=35532

Reviewed by Sam Weinig.

WebCore:

Test: fast/loader/api-test-go-to-current-back-forward-item.html

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadItem): If the current item is the same as the target item, don't
  consider this to be a same document navigation.

* page/Page.cpp:
(WebCore::Page::goToItem): Hard code the "going to the same item as the current item" relationship
  as a precondition for stopping all loaders, as that will be a new document load.

WebKitTools:

* DumpRenderTree/LayoutTestController.cpp:
(apiTestGoToCurrentBackForwardItemCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::apiTestGoToCurrentBackForwardItem):

Stubs for now:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::apiTestGoToCurrentBackForwardItem):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::apiTestGoToCurrentBackForwardItem):
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::apiTestGoToCurrentBackForwardItem):

LayoutTests:

* fast/loader/api-test-go-to-current-back-forward-item-expected.txt: Added.
* fast/loader/api-test-go-to-current-back-forward-item.html: Added.
* platform/gtk/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-01 Robert Hogan <robert@webkit.org>
robert@webkit.org [Mon, 1 Mar 2010 21:04:30 +0000 (21:04 +0000)]
2010-03-01  Robert Hogan  <robert@webkit.org>

        Reviewed by nobody, build fix.

        Fix --minimal build. Add ENABLE(DATABASE) as compile time condition
        for building file GeolocationPositionCache.cpp.

        * page/GeolocationPositionCache.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-01 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Mon, 1 Mar 2010 20:41:29 +0000 (20:41 +0000)]
2010-03-01  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by David Levin.

        General cleanup of error handling in new-run-webkit-tests.

        Add Port.check_build() call that is separate from Port.check_sys_deps()
        (and add a --nocheck-build flag to skip). This breaks a circular
        dependency where you would start the layout test helper before
        checking sys deps, but checking sys deps was the thing that told
        you if your binaries where there.

        Also, made Port.check_sys_deps(), start_helper() and stop_helper()
        optional by providing default implementations in the base class
        rather than requiring ports to implement the routines regardless
        of whether or not they were needed.

        Lastly, tweak a bunch of log messages to be cleaner, including
        changing messages in thirdparty/autoinstall.py to be silent at
        the default log level.

        http://bugs.webkit.org/show_bug.cgi?id=35416

        * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
        * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
        * Scripts/webkitpy/layout_tests/port/chromium_win.py:
        * Scripts/webkitpy/layout_tests/port/mac.py:
        * Scripts/webkitpy/layout_tests/port/passing.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/thirdparty/autoinstall.py

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-01 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Mon, 1 Mar 2010 19:36:23 +0000 (19:36 +0000)]
2010-03-01  Dirk Pranke <dpranke@chromium.org>

         Reviewed by David Levin.

         new-chromium-webkit-tests --platform=mac-leopard diffs are backwards
         https://bugs.webkit.org/show_bug.cgi?id=35265

         Some parts of the code passed arguments as
         "actual, expected" and some passed as "expected, actual".
         As you might imagine, this lead to great confusion and wrongness.
         Standardize on "expected, actual" as that's the order which is
         passed to the underlying diff tool.

         Based on a patch by Eric Siedel <eric@webkit.org>.

         * Scripts/webkitpy/layout_tests/port/base.py:
         * Scripts/webkitpy/layout_tests/port/chromium.py:
         * Scripts/webkitpy/layout_tests/port/test.py:
         * Scripts/webkitpy/layout_tests/test_types/image_diff.py

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-01 Jakob Petsovits <jpetsovits@rim.com>
jpetsovits@rim.com [Mon, 1 Mar 2010 17:41:44 +0000 (17:41 +0000)]
2010-03-01  Jakob Petsovits  <jpetsovits@rim.com>

        Reviewed by Dirk Schulze.

        [OpenVG] Implement support for paths
        https://bugs.webkit.org/show_bug.cgi?id=34366

        Adds an implementation of the Path class -
        *almost* complete, but not quite because OpenVG
        does not provide access to the points in a VGPath
        unless one keeps track of all the points by
        themselves, which we decided not to do.

        Also hooked up to PainterOpenVG and GraphicsContext.

        Further introduced is SharedResourceOpenVG, which is
        intended as base class for paths and other OpenVG
        resources (images, fonts) that WebKit creates as
        long-lived objects. We are at a slight disadvantage
        here as WebKit doesn't have the concept of resources
        belonging to a specific (hardware graphics) context,
        which is the reason why EGLDisplayOpenVG had to
        provide a current display singleton; this class is
        what actually requires that functionality.

        Path::addArcTo() uses code by Yong Li <yoli@rim.com>.

        * platform/graphics/Path.cpp:
        * platform/graphics/Path.h:
        * platform/graphics/openvg/GraphicsContextOpenVG.cpp:
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::strokePath):
        (WebCore::GraphicsContext::drawPath):
        (WebCore::GraphicsContext::beginPath):
        (WebCore::GraphicsContext::addPath):
        * platform/graphics/openvg/PainterOpenVG.cpp:
        (WebCore::PainterOpenVG::PainterOpenVG):
        (WebCore::PainterOpenVG::~PainterOpenVG):
        (WebCore::PainterOpenVG::transformPath):
        (WebCore::PainterOpenVG::beginPath):
        (WebCore::PainterOpenVG::addPath):
        (WebCore::PainterOpenVG::currentPath):
        (WebCore::PainterOpenVG::drawPath):
        * platform/graphics/openvg/PainterOpenVG.h:
        * platform/graphics/openvg/PathOpenVG.cpp: Added.
        (WebCore::PlatformPathOpenVG::PlatformPathOpenVG):
        (WebCore::PlatformPathOpenVG::operator=):
        (WebCore::PlatformPathOpenVG::~PlatformPathOpenVG):
        (WebCore::PlatformPathOpenVG::clear):
        (WebCore::PlatformPathOpenVG::createPath):
        (WebCore::Path::Path):
        (WebCore::Path::~Path):
        (WebCore::Path::operator=):
        (WebCore::Path::contains):
        (WebCore::Path::strokeContains):
        (WebCore::Path::translate):
        (WebCore::Path::boundingRect):
        (WebCore::Path::strokeBoundingRect):
        (WebCore::Path::moveTo):
        (WebCore::Path::addLineTo):
        (WebCore::Path::addQuadCurveTo):
        (WebCore::Path::addBezierCurveTo):
        (WebCore::Path::addArcTo):
        (WebCore::Path::closeSubpath):
        (WebCore::Path::addArc):
        (WebCore::Path::addRect):
        (WebCore::Path::addEllipse):
        (WebCore::Path::clear):
        (WebCore::Path::isEmpty):
        (WebCore::Path::hasCurrentPoint):
        (WebCore::Path::debugString):
        (WebCore::Path::apply):
        (WebCore::Path::transform):
        (WebCore::Path::length):
        (WebCore::Path::pointAtLength):
        (WebCore::Path::normalAngleAtLength):
        * platform/graphics/openvg/PlatformPathOpenVG.h: Added.
        (WebCore::PlatformPathOpenVG::vgPath):
        * platform/graphics/openvg/SharedResourceOpenVG.cpp: Added.
        (WebCore::SharedResourceOpenVG::makeSharedContextCurrent):
        (WebCore::SharedResourceOpenVG::makeCompatibleContextCurrent):
        * platform/graphics/openvg/SharedResourceOpenVG.h: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-01 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 1 Mar 2010 16:18:50 +0000 (16:18 +0000)]
2010-03-01  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed, bring English.lproj/locallizedStrings.js back to binary (UTF) mode.

        * English.lproj/localizedStrings.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-01 Jakob Petsovits <jpetsovits@rim.com>
jpetsovits@rim.com [Mon, 1 Mar 2010 15:51:59 +0000 (15:51 +0000)]
2010-03-01  Jakob Petsovits  <jpetsovits@rim.com>

        Reviewed by Nikolas Zimmermann.

        [OpenVG] Convert from TransformationMatrix to AffineTransform.
        https://bugs.webkit.org/show_bug.cgi?id=35445

        Dirk Schulze previously introduced AffineTransform as
        replacement for most TransformationMatrix occurrences
        in GraphicsContext & Co., but did not update the OpenVG
        graphics backend as there's no publicly available way
        to build it. This commit now takes care of that.

        * platform/graphics/openvg/GraphicsContextOpenVG.cpp:
        (WebCore::GraphicsContext::getCTM):
        (WebCore::GraphicsContext::roundToDevicePixels):
        (WebCore::GraphicsContext::origin):
        (WebCore::GraphicsContext::concatCTM):
        * platform/graphics/openvg/PainterOpenVG.cpp:
        (WebCore::isNonRotatedAffineTransformation):
        (WebCore::PlatformPainterState::PlatformPainterState):
        (WebCore::PlatformPainterState::applyState):
        (WebCore::PlatformPainterState::applyTransformation):
        (WebCore::PainterOpenVG::transformation):
        (WebCore::PainterOpenVG::concatTransformation):
        (WebCore::PainterOpenVG::setTransformation):
        (WebCore::PainterOpenVG::scale):
        (WebCore::PainterOpenVG::rotate):
        (WebCore::PainterOpenVG::translate):
        (WebCore::PainterOpenVG::intersectClipRect):
        * platform/graphics/openvg/PainterOpenVG.h:
        * platform/graphics/openvg/VGUtils.cpp:
        (WebCore::VGMatrix::VGMatrix):
        (WebCore::VGMatrix::operator AffineTransform):
        (WebCore::VGMatrix::operator TransformationMatrix):
        (WebCore::AffineTransform::operator VGMatrix):
        * platform/graphics/openvg/VGUtils.h:
        * platform/graphics/transforms/AffineTransform.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Fix segfault when drawing NPAPI plugins on Mac
vestbo@webkit.org [Mon, 1 Mar 2010 15:34:25 +0000 (15:34 +0000)]
[Qt] Fix segfault when drawing NPAPI plugins on Mac

Reviewed by Simon Hausmann.

Don't try to get a contexctRef for a null-pixmap. If the pixmap
size is 0,0 the private pixmap data has not yet been initialized.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix the Qt build on Mac OS X/Cocoa 64-bit
vestbo@webkit.org [Mon, 1 Mar 2010 15:34:14 +0000 (15:34 +0000)]
Fix the Qt build on Mac OS X/Cocoa 64-bit

Add missing implementation file to resolve JSC symbols.

Use the proper event/drawing-model guards instead of global 64-bit
guard for the NPAPI plugin implementation (view and package).

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix ChangeLog entries not showing the reviewer due to the ChangeLogs
kenneth@webkit.org [Mon, 1 Mar 2010 12:54:56 +0000 (12:54 +0000)]
Fix ChangeLog entries not showing the reviewer due to the ChangeLogs
having been made manually without the (OOPS!!!) part.

Rubberstamped by Gustavo Noronha

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-27 Ilya Tikhonovsky <loislo@chromium.org>
pfeldman@chromium.org [Mon, 1 Mar 2010 10:17:03 +0000 (10:17 +0000)]
2010-02-27  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: callerScriptName and callerScriptLine should be obfuscated for timeline tests.
        https://bugs.webkit.org/show_bug.cgi?id=35478

        * ../../LayoutTests/inspector/timeline-test.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-27 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 1 Mar 2010 10:12:10 +0000 (10:12 +0000)]
2010-02-27  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: disable breakpoint upon Shift-click.

        https://bugs.webkit.org/show_bug.cgi?id=35477

        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype._format):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._mouseDown):
        (WebInspector.SourceFrame.prototype._mouseMove):
        * inspector/front-end/textViewer.css:
        Chromium: remove DevTools part that has been upstreamed.
        * src/js/DevTools.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
cjerdonek@webkit.org [Mon, 1 Mar 2010 10:07:59 +0000 (10:07 +0000)]
Unreviewed.

Rolling out: http://trac.webkit.org/changeset/55348

https://bugs.webkit.org/show_bug.cgi?id=35163

Rolling out since the changes to autoinstall do not work
with Python 2.4. In particular, ZipFile.extractall() was
added in Python 2.6.

* Scripts/webkitpy/__init__.py:
* Scripts/webkitpy/bugzilla.py:
* Scripts/webkitpy/init/__init__.py: Removed.
* Scripts/webkitpy/init/autoinstall.py: Removed.
* Scripts/webkitpy/networktransaction.py:
* Scripts/webkitpy/networktransaction_unittest.py:
* Scripts/webkitpy/statusserver.py:
* Scripts/webkitpy/thirdparty/autoinstall.py: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
cjerdonek@webkit.org [Mon, 1 Mar 2010 09:44:50 +0000 (09:44 +0000)]
Unreviewed.

Fixing up ChangeLog after: http://trac.webkit.org/changeset/55361

Restoring deleted ChangeLog entry, and added new ChangeLog entry
for r55361.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Rolling out r55350: http://trac.webkit.org/changeset/55350
cjerdonek@webkit.org [Mon, 1 Mar 2010 09:19:11 +0000 (09:19 +0000)]
Unreviewed. Rolling out r55350: trac.webkit.org/changeset/55350

https://bugs.webkit.org/show_bug.cgi?id=33639

Need to roll out because this patch (pep8) depends on the newly rewritten
autoinstall.py (r55348), which is breaking for people with Python 2.4:

https://bugs.webkit.org/show_bug.cgi?id=35163#c21

That also needs to be rolled out and will be rolled out next.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoExempted WebKitTools/Scripts/webkitpy/thirdparty from all
cjerdonek@webkit.org [Mon, 1 Mar 2010 05:14:03 +0000 (05:14 +0000)]
Exempted WebKitTools/Scripts/webkitpy/thirdparty from all
style checks except for the whitespace/carriage_return check
and the pep8 tab and trailing white space checks.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=35497

* Scripts/webkitpy/style/checker.py:
  - Adjusted the _PATH_RULES_SPECIFIER configuration as necessary.
  - Added enough pep8 categories to _all_categories() for the
    unit tests to pass.

* Scripts/webkitpy/style/checker_unittest.py:
  - Updated the test_path_rules_specifier() unit test.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Dan Bernstein.
ap@apple.com [Sun, 28 Feb 2010 20:04:48 +0000 (20:04 +0000)]
    Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=35496
        <rdar://problem/7663444> Opening newsweek.com and youtube.com has become very slow in debug builds

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSRuleSet::getIDRules):
        (WebCore::CSSRuleSet::getClassRules):
        (WebCore::CSSRuleSet::getTagRules):
        Removed consistency checks, as they affect performance too much in this case.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Support private browsing mode in plugins
robert@webkit.org [Sun, 28 Feb 2010 12:57:09 +0000 (12:57 +0000)]
[Qt] Support private browsing mode in plugins

Add support for NPNVprivateModeBool property in plugins.

See also: https://developer.mozilla.org/En/Supporting_private_browsing_in_plugins

The NPNVprivateModeBool property is supported as scriptable property privateBrowsingEnabled
in the test WebKit plugin. The Mac platform also supports a cachedPrivateBrowsingEnabled
property implemented in the test plugin. This allows the Layout test plugins/private-browsing-mode.html
to retrieve the previous value of NPNVprivateModeBool in the test plugin. Due to the platform-specific
overhead required to support this bespoke property it is not implemented as part of this patch, instead
a new test, plugins/private-browsing-mode-2.html, is added to ensure that setting and resetting privateBrowsingEnabled works as expected.

http://bugs.webkit.org/show_bug.cgi?id=33180

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-27 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Sun, 28 Feb 2010 07:09:12 +0000 (07:09 +0000)]
2010-02-27  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Timothy Hatcher.

        Web Inspector shouldn't show a white color box for "-webkit-line-break: after-white-space"
        https://bugs.webkit.org/show_bug.cgi?id=33478

        * inspector/front-end/StylesSidebarPane.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-27 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Sat, 27 Feb 2010 22:45:28 +0000 (22:45 +0000)]
2010-02-27  Xan Lopez  <xlopez@igalia.com>

        Rubber-stamped by Gustavo Noronha.

        Unskip test that we seem to pass now.

        * platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-27 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Sat, 27 Feb 2010 22:26:03 +0000 (22:26 +0000)]
2010-02-27  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Add platform results for plugin test and unskip it. The filename
        of our test plugin is not the same than the one expected in the
        default result file.

        * platform/gtk/Skipped:
        * platform/gtk/plugins/plugin-javascript-access-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Skip new test introduced in r55353 because of missing drag&drop support.
ossy@webkit.org [Sat, 27 Feb 2010 17:47:54 +0000 (17:47 +0000)]
[Qt] Skip new test introduced in r55353 because of missing drag&drop support.

* platform/qt/Skipped: fast/css/user-drag-none.html skipped.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/7696607> Links do not respect -webkit-user-drag: none
mitz@apple.com [Sat, 27 Feb 2010 12:39:27 +0000 (12:39 +0000)]
<rdar://problem/7696607> Links do not respect -webkit-user-drag: none
https://bugs.webkit.org/show_bug.cgi?id=35475

Reviewed by Maciej Stachowiak.

WebCore:

Test: fast/css/user-drag-none.html

* page/DragController.cpp:
(WebCore::DragController::mayStartDragAtEventLocation): Added a node
parameter. The image drag check is done against the node, rather than
than against the hit test result. This prevents a non-draggable image
with an auto-draggable ancestor from being dragged alone. The link drag
check now ignores links that are -webkit-user-drag: none.
* page/DragController.h:
* page/EventHandler.cpp:
(WebCore::EventHandler::shouldDragAutoNode): Pass the current node
to mayStartDragAtEventLocation().

LayoutTests:

* fast/css/user-drag-none-expected.txt: Added.
* fast/css/user-drag-none.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-27 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Sat, 27 Feb 2010 10:48:18 +0000 (10:48 +0000)]
2010-02-27  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: REGRESSION: hangs when scrolling in Resource pane.

        https://bugs.webkit.org/show_bug.cgi?id=35216

        * inspector/front-end/TextEditorHighlighter.js:
        (WebInspector.TextEditorHighlighter):
        (WebInspector.TextEditorHighlighter.prototype.highlight):
        (WebInspector.TextEditorHighlighter.prototype._highlightInChunks):
        (WebInspector.TextEditorHighlighter.prototype._highlightLines):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore:
xan@webkit.org [Sat, 27 Feb 2010 08:57:37 +0000 (08:57 +0000)]
WebCore:

2010-02-27  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Abort XEmbed plugin initialization if our parent is not anchored
        in a widget hierarchy. This can happen when the browser window is
        destroyed while the plugin is being loaded, and will lead to a
        crash.

        * plugins/gtk/PluginViewGtk.cpp:
        (WebCore::PluginView::platformStart):

LayoutTests:

2010-02-27  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        We now pass this test, unskip.

        * platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdded Python style checking to check-webkit-style using
cjerdonek@webkit.org [Sat, 27 Feb 2010 08:24:13 +0000 (08:24 +0000)]
Added Python style checking to check-webkit-style using
the third-party pep8 module (via autoinstall).

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=33639

* Scripts/webkitpy/style/checker.py:
  - Added PYTHON to FileType.
  - Updated ProcessorDispatcher to return a PythonProcessor
    for *.py files.

* Scripts/webkitpy/style/checker_unittest.py:
  - Updated the ProcessorDispatcher unit tests for *.py files.

* Scripts/webkitpy/style/processors/python.py: Added.
  - Added PythonProcessor class.

* Scripts/webkitpy/style/processors/python_unittest.py: Added.
  - Added PythonProcessor unit tests.

* Scripts/webkitpy/style/processors/python_unittest_input.py: Added.
  - Added a sample Python file to test the PythonProcessor.process()
    code path (since pep8 accepts a file path).

* Scripts/webkitpy/style/unittests.py:
  - Updated the style unit test file to import python_unittest.py.

* Scripts/webkitpy/style_references.py:
  - Adjusted style references to import pep8.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-27 Jing Jin <jjin@apple.com>
eric@webkit.org [Sat, 27 Feb 2010 08:10:47 +0000 (08:10 +0000)]
2010-02-27  Jing Jin  <jjin@apple.com>

        Reviewed by Timothy Hatcher.

        Move implementation of Bug 35449 into WebFramePrivate.

        * WebView/WebFrame.h:
        * WebView/WebFrame.mm:
        (-[WebFrame setAllowScrollersToOverlapContent:]):
        (-[WebFrame setAlwaysHideHorizontalScroller:]):
        (-[WebFrame setAlwaysHideVerticalScroller:]):
        * WebView/WebFramePrivate.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRewrote autoinstall.py to support unzipping *.zip files after
cjerdonek@webkit.org [Sat, 27 Feb 2010 08:04:48 +0000 (08:04 +0000)]
Rewrote autoinstall.py to support unzipping *.zip files after
download, unzipping and extracting *.tar.gz files after download,
and copying installed files to a destination directory.

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=35163

These changes will allow us to autoinstall pep8.py from the web
and to put our third-party autoinstalled code in an explicit
directory like webkitpy/thirdparty/autoinstalled. They should
also speed up imports from autoinstalled *.zip packages slightly
since *.pyc files cannot be generated when importing from
zipped packages.

* Scripts/webkitpy/__init__.py:
  - Updated the autoinstall lines to use the new autoinstall methods.
  - Added pep8.py to the list of auto-installed packages.

* Scripts/webkitpy/bugzilla.py:
  - Updated mechanize import path.

* Scripts/webkitpy/init/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py.

* Scripts/webkitpy/init/autoinstall.py: Added.
  - Added AutoInstaller class.
  - Added sample testing usage to __main__.

* Scripts/webkitpy/networktransaction.py:
  - Updated mechanize import path.

* Scripts/webkitpy/networktransaction_unittest.py:
  - Updated mechanize import path.

* Scripts/webkitpy/statusserver.py:
  - Updated mechanize import path.

* Scripts/webkitpy/thirdparty/autoinstall.py: Removed.
  - Replaced with rewritten autoinstall in init/autoinstall.py.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-26 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Sat, 27 Feb 2010 07:01:02 +0000 (07:01 +0000)]
2010-02-26  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: reload inspected page on Cmd+R / Ctrl+R / F5 key event in inspector.
        Drive-by fix for couple of minor front-end problems.

        https://bugs.webkit.org/show_bug.cgi?id=35434

        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::reloadPage):
        * inspector/InspectorBackend.h:
        * inspector/InspectorBackend.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::didFinishLoading):
        (WebCore::InspectorController::didFailLoading):
        * inspector/front-end/InspectorBackendStub.js:
        (.WebInspector.InspectorBackendStub.prototype.reloadPage):
        * inspector/front-end/InspectorFrontendHostStub.js:
        (.WebInspector.InspectorFrontendHostStub.prototype.copyText):
        (.WebInspector.InspectorFrontendHostStub.prototype.canAttachWindow):
        * inspector/front-end/TextViewer.js:
        (WebInspector.TextViewer.prototype._paintLine):
        * inspector/front-end/inspector.js:
        (WebInspector.documentKeyDown):
        (WebInspector.toggleAttach):

        WebKit/chromium
        * src/WebDevToolsFrontendImpl.cpp:
        (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl):
        (WebKit::WebDevToolsFrontendImpl::jsCanAttachWindow):
        * src/WebDevToolsFrontendImpl.h:
        * src/js/InspectorControllerImpl.js:
        (devtools.InspectorBackendImpl):
        (devtools.InspectorBackendImpl.prototype.toggleNodeSearch):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-26 James Hawkins <jhawkins@chromium.org>
eric@webkit.org [Sat, 27 Feb 2010 06:22:33 +0000 (06:22 +0000)]
2010-02-26  James Hawkins  <jhawkins@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Verify that the Nodes being enumerated are HTML elements.

        https://bugs.webkit.org/show_bug.cgi?id=35463

        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::forms):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-26 Leandro Pereira <leandro@profusion.mobi>
eric@webkit.org [Sat, 27 Feb 2010 06:06:02 +0000 (06:06 +0000)]
2010-02-26  Leandro Pereira  <leandro@profusion.mobi>

        Reviewed by NOBODY.

        Add EFL port files to platform/efl.
        http://webkit.org/b/35087

        * platform/efl/ScrollbarEfl.cpp: Added.
        * platform/efl/EventLoopEfl.cpp: Added.
        * platform/efl/PlatformKeyboardEventEfl.cpp: Added.
        * platform/efl/DragImageEfl.cpp: Added.
        * platform/efl/PlatformMouseEventEfl.cpp: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-26 Leandro Pereira <leandro@profusion.mobi>
eric@webkit.org [Sat, 27 Feb 2010 05:49:23 +0000 (05:49 +0000)]
2010-02-26  Leandro Pereira  <leandro@profusion.mobi>

        Reviewed by NOBODY.

        Add EFL port files to platform/efl.
        http://webkit.org/b/35087

        * platform/efl/CursorEfl.cpp: Added.
        * platform/efl/LocalizedStringsEfl.cpp: Added.
        * platform/efl/SearchPopupMenuEfl.cpp: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-26 Leandro Pereira <leandro@profusion.mobi>
eric@webkit.org [Sat, 27 Feb 2010 05:32:43 +0000 (05:32 +0000)]
2010-02-26  Leandro Pereira  <leandro@profusion.mobi>

        Reviewed by NOBODY.

        Add EFL port files to page/efl.
        http://webkit.org/b/35087

        * WebCore/page/efl/DragControllerEfl.cpp: Added.
        * WebCore/page/efl/FrameEfl.cpp: Added.
        * WebCore/page/efl/AccessibilityObjectEfl.cpp: Added.
        * WebCore/page/efl/EventHandlerEfl.cpp: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-26 Leandro Pereira <leandro@profusion.mobi>
eric@webkit.org [Sat, 27 Feb 2010 05:16:04 +0000 (05:16 +0000)]
2010-02-26  Leandro Pereira  <leandro@profusion.mobi>

        Reviewed by NOBODY.

        Add EFL port files to platform/efl.
        http://webkit.org/b/35087

        * WebCore/platform/efl/LoggingEfl.cpp: Added.
        * WebCore/platform/efl/ScrollbarThemeEfl.cpp: Added.
        * WebCore/platform/efl/TemporaryLinkStubs.cpp: Added.
        * WebCore/platform/efl/ScrollViewEfl.cpp: Added.
        * WebCore/platform/efl/SharedBufferEfl.cpp: Added.
        * WebCore/platform/efl/DragDataEfl.cpp: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-26 Dirk Pranke <dpranke@chromium.org>
eric@webkit.org [Sat, 27 Feb 2010 04:59:31 +0000 (04:59 +0000)]
2010-02-26  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Adam Barth.

        Change the default port for new-run-webkit-tests when running on
        a Mac from 'chromium-mac' to 'mac'. Add a '--chromium' switch to
        pick up the default platform-specific version of chromium instead.

        https://bugs.webkit.org/show_bug.cgi?id=35462

        * Scripts/webkitpy/layout_tests/port/factory.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-26 Leandro Pereira <leandro@profusion.mobi>
eric@webkit.org [Sat, 27 Feb 2010 04:42:57 +0000 (04:42 +0000)]
2010-02-26  Leandro Pereira  <leandro@profusion.mobi>

        Reviewed by NOBODY.

        Add EFL port files to platform/efl.
        http://webkit.org/b/35087

        * WebCore/platform/efl/RenderThemeEfl.cpp: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago010-02-26 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Sat, 27 Feb 2010 03:53:50 +0000 (03:53 +0000)]
010-02-26  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, build fix

        third time's the charm getting this path right?

        * pywebsocket/mod_pywebsocket/standalone.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-26 Leandro Pereira <leandro@profusion.mobi>
eric@webkit.org [Sat, 27 Feb 2010 03:53:24 +0000 (03:53 +0000)]
2010-02-26  Leandro Pereira  <leandro@profusion.mobi>

        Reviewed by NOBODY.

        Add EFL port files to platform/efl.
        http://webkit.org/b/35087

        * WebCore/platform/efl/PlatformWheelEventEfl.cpp: Added.
        * WebCore/platform/efl/FileChooserEfl.cpp: Added.
        * WebCore/platform/efl/ContextMenuEfl.cpp: Added.
        * WebCore/platform/efl/PlatformScreenEfl.cpp: Added.
        * WebCore/platform/efl/WidgetEfl.cpp: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, build fix.
dumi@chromium.org [Sat, 27 Feb 2010 03:42:08 +0000 (03:42 +0000)]
Unreviewed, build fix.

* pywebsocket/mod_pywebsocket/standalone.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMoving the script to the right location.
dumi@chromium.org [Sat, 27 Feb 2010 03:27:33 +0000 (03:27 +0000)]
Moving the script to the right location.

Reviewed by NOBODY (OOPS!).

* pywebsocket/mod_pywebsocket: Added.
* pywebsocket/mod_pywebsocket/standalone.py: Copied from WebKitTools/pywebsocket/standalone.py.
* pywebsocket/standalone.py: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-26 Adam Barth <abarth@webkit.org>
eric@webkit.org [Sat, 27 Feb 2010 03:20:22 +0000 (03:20 +0000)]
2010-02-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Fisher.

        Expose an API for ports to add schemes to the mixed content whitelist
        https://bugs.webkit.org/show_bug.cgi?id=35438

        Add a notion of a "secure" scheme that doesn't trigger mixed content
        warnings.  Let folks register new secure schemes in the same way they
        can register "local" schemes.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::isMixedContent):
        * page/SecurityOrigin.cpp:
        (WebCore::secureSchemes):
        (WebCore::SecurityOrigin::registerURLSchemeAsSecure):
        (WebCore::SecurityOrigin::shouldTreatURLSchemeAsSecure):
        * page/SecurityOrigin.h:
2010-02-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Fisher.

        Expose an API for ports to add schemes to the mixed content whitelist
        https://bugs.webkit.org/show_bug.cgi?id=35438

        Expose registerURLSchemeAsSecure via the WebKit API.

        * public/WebSecurityPolicy.h:
        * src/WebSecurityPolicy.cpp:
        (WebKit::WebSecurityPolicy::registerURLSchemeAsSecure):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-26 Noam Rosenthal <noam.rosenthal@nokia.com>
eric@webkit.org [Sat, 27 Feb 2010 02:59:56 +0000 (02:59 +0000)]
2010-02-26  Noam Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] GraphicsLayerQt: artifacts and wrong transformOrigin
        This was due to wrong way of applying cache-mode and transformation
        on a graphics-item with HTML. Cache-mode should be updated
        when the content type updates, even if it was the same cache-mode

        https://bugs.webkit.org/show_bug.cgi?id=35382

        Test URL attached to the bug now works correctly.

        * platform/graphics/qt/GraphicsLayerQt.cpp:
        (WebCore::GraphicsLayerQtImpl::computeTransform):
        (WebCore::GraphicsLayerQtImpl::flushChanges):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, fixing the license.
dumi@chromium.org [Sat, 27 Feb 2010 02:51:43 +0000 (02:51 +0000)]
Unreviewed, fixing the license.

* pywebsocket/standalone.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-26 Luiz Agostini <luiz.agostini@openbossa.org>
eric@webkit.org [Sat, 27 Feb 2010 02:43:10 +0000 (02:43 +0000)]
2010-02-26  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        Qt/Mac: Revert null timer removal (r51105)
        https://bugs.webkit.org/show_bug.cgi?id=35396

        r51105 removed the null timer event of the carbon event model. This however
        breaks the flash of many sites.

        Applying patch suggested by Girish Ramakrishnan in bug comment #1.

        * plugins/PluginView.h:
        * plugins/mac/PluginViewMac.cpp:
        (WebCore::PluginView::platformStart):
        (WebCore::PluginView::handleMouseEvent):
        (WebCore::PluginView::nullEventTimerFired):
        (WebCore::PluginView::mousePosForPlugin):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-26 Noam Rosenthal <noam.rosenthal@nokia.com>
eric@webkit.org [Sat, 27 Feb 2010 02:25:50 +0000 (02:25 +0000)]
2010-02-26  Noam Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Compile error with 3d-canvas
        Replaced a direct gl call with a getProcAddress call
        https://bugs.webkit.org/show_bug.cgi?id=35448

        No new tests.

        * platform/graphics/qt/GraphicsContext3DQt.cpp:
        (WebCore::GraphicsContext3D::blendColor):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-26 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Sat, 27 Feb 2010 02:08:36 +0000 (02:08 +0000)]
2010-02-26  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Kenneth Rohde Christiansen.

        [BREWMP] Port EventHandler
        https://bugs.webkit.org/show_bug.cgi?id=34796

        Add platform-specific code required to implement EventHandler.

        * page/brew/EventHandlerBrew.cpp: Added.
        (WebCore::EventHandler::tabsToAllControls):
        (WebCore::EventHandler::focusDocumentView):
        (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
        (WebCore::EventHandler::passMouseDownEventToWidget):
        (WebCore::EventHandler::eventActivatedView):
        (WebCore::EventHandler::passSubframeEventToSubframe):
        (WebCore::EventHandler::passWheelEventToWidget):
        (WebCore::EventHandler::passMousePressEventToSubframe):
        (WebCore::EventHandler::passMouseMoveEventToSubframe):
        (WebCore::EventHandler::passMouseReleaseEventToSubframe):
        (WebCore::EventHandler::accessKeyModifiers):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdding pywebsocket/standalone.py back to fix the Chromium webkit
dumi@chromium.org [Sat, 27 Feb 2010 01:51:57 +0000 (01:51 +0000)]
Adding pywebsocket/standalone.py back to fix the Chromium webkit
canaries. Once all layout tests pass, we can get in the patch that
moves this directorty to WebKitTools/Scripts, update all Chromium
scripts, and revert this patch.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=35464

* pywebsocket: Added.
* pywebsocket/standalone.py: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-26 Leandro Pereira <leandro@profusion.mobi>
eric@webkit.org [Sat, 27 Feb 2010 01:51:42 +0000 (01:51 +0000)]
2010-02-26  Leandro Pereira  <leandro@profusion.mobi>

        Reviewed by NOBODY.

        Add EFL port files to platform/efl.
        http://webkit.org/b/35087

        * WebCore/platform/efl/ClipboardEfl.cpp: Added.
        * WebCore/platform/efl/PopupMenuEfl.cpp: Added.
        * WebCore/platform/efl/SharedTimerEfl.cpp: Added.
        * WebCore/platform/efl/RenderThemeEfl.h: Added.
        * WebCore/platform/efl/Language.cpp: Added.
        * WebCore/platform/efl/CookieJarEfl.cpp: Added.
        * WebCore/platform/efl/MIMETypeRegistryEfl.cpp: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-26 Arno Renevier <arno@renevier.net>
eric@webkit.org [Sat, 27 Feb 2010 01:34:46 +0000 (01:34 +0000)]
2010-02-26  Arno Renevier  <arno@renevier.net>

        Reviewed by Gustavo Noronha Silva.

        [Gtk] ignore WebKit/gtk/docs/GNUmakefile.in in .gitignore
        https://bugs.webkit.org/show_bug.cgi?id=35424

        * .gitignore:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-26 Robert Kroeger <rjkroege@chromium.org>
eric@webkit.org [Sat, 27 Feb 2010 01:17:55 +0000 (01:17 +0000)]
2010-02-26  Robert Kroeger  <rjkroege@chromium.org>

        Reviewed by Nate Chapin

        To fire each event handler registered on an SVG node once per
        event, Chromium needs an implementation of wasCreatedFromMarkup
        added to V8LazyEventListener.h that matches the one in
        WebKit/WebCore/bindings/js/JSLazyEventListener.h.

        This patch adds such a matching implementation of wasCreatedFromMarkup
        to V8LazyEventListener.h.

        https://bugs.webkit.org/show_bug.cgi?id=35325

        * bindings/v8/V8LazyEventListener.h:
        (WebCore::V8LazyEventListener::wasCreatedFromMarkup):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-26 Arno Renevier <arno@renevier.net>
eric@webkit.org [Sat, 27 Feb 2010 01:00:00 +0000 (01:00 +0000)]
2010-02-26  Arno Renevier  <arno@renevier.net>

        Reviewed by Gustavo Noronha Silva.

        [Gtk] use geoclue_position_get_position_async to get geolocation position.
        https://bugs.webkit.org/show_bug.cgi?id=35355

        No new tests, behaviour depends on system.

        * platform/gtk/GeolocationServiceGtk.cpp:
        (WebCore::GeolocationServiceGtk::startUpdating):
        (WebCore::GeolocationServiceGtk::get_position):
        * platform/gtk/GeolocationServiceGtk.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=35449
mthole@apple.com [Sat, 27 Feb 2010 00:44:52 +0000 (00:44 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=35449
Add ability to hide WebFrame scrollbars and to allow scrollbars to overlap with content.

Patch by Jing Jin <jjin@apple.com> on 2010-02-26
Reviewed by Timothy Hatcher.

* WebView/WebDynamicScrollBarsView.h:
* WebView/WebDynamicScrollBarsView.mm:
(-[WebDynamicScrollBarsView setAllowScrollersToOverlapContent:]): Allows scrollbars to
overlap with the document and re-layouts the document.
(-[WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]): Hides the horizontal scrollbar.
(-[WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]): Hides the vertical scrollbar.
(-[WebDynamicScrollBarsView contentViewFrame]): Calculates the appropriate frame based
on allowScrollersToOverlapContent.
(-[WebDynamicScrollBarsView tile]): If allowScrollersToOverlapContent is YES, set the
contentView's frame so it overlaps with the scrollbar.
(-[WebDynamicScrollBarsView updateScrollers]): Take into account hideHorizontalScroller
and hideVerticalScroller.
(-[WebDynamicScrollBarsView reflectScrolledClipView:]): set drawsBackground to NO when
scrollbars are overlapping with content, so we don't get trails during scrollbar draw updates.
* WebView/WebDynamicScrollBarsViewInternal.h:
* WebView/WebFrame.h:
* WebView/WebFrame.mm:
(-[WebFrame setAllowScrollersToOverlapContent:]): Hook for [WebDynamicScrollBarsView setAllowScrollersToOverlapContent:]
(-[WebFrame setAlwaysHideHorizontalScroller:]): Hook for [WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]
(-[WebFrame setAlwaysHideVerticalScroller:]): Hook for [WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-26 Yaar Schnitman <yaar@chromium.org>
yaar@chromium.org [Sat, 27 Feb 2010 00:32:01 +0000 (00:32 +0000)]
2010-02-26  Yaar Schnitman  <yaar@chromium.org>

        Chromium Win build fix.

        * WebCore.gyp/WebCore.gyp: Added missing file to action input.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber Stamped by Geoff Garen.
barraclough@apple.com [Sat, 27 Feb 2010 00:19:13 +0000 (00:19 +0000)]
Rubber Stamped by Geoff Garen.

Remove wrec.  All builds should have switched to yarr by now.

* Android.mk:
* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.pri:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
* JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/RegExp.cpp:
(JSC::RegExp::match):
* runtime/RegExp.h:
* wrec: Removed.
* wrec/CharacterClass.cpp: Removed.
* wrec/CharacterClass.h: Removed.
* wrec/CharacterClassConstructor.cpp: Removed.
* wrec/CharacterClassConstructor.h: Removed.
* wrec/Escapes.h: Removed.
* wrec/Quantifier.h: Removed.
* wrec/WREC.cpp: Removed.
* wrec/WREC.h: Removed.
* wrec/WRECFunctors.cpp: Removed.
* wrec/WRECFunctors.h: Removed.
* wrec/WRECGenerator.cpp: Removed.
* wrec/WRECGenerator.h: Removed.
* wrec/WRECParser.cpp: Removed.
* wrec/WRECParser.h: Removed.
* wscript:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-26 Brett Wilson <brettw@chromium.org>
brettw@chromium.org [Fri, 26 Feb 2010 23:47:21 +0000 (23:47 +0000)]
2010-02-26  Brett Wilson  <brettw@chromium.org>

        Fix chromium build. This test's expectation became obsolete with
        recent changes to KURL which my previous change brings Chromium's
        port in compliance with.

        * tests/KURLTest.cpp:
        (ComponentCase::TEST):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-26 Yaar Schnitman <yaar@chromium.org>
yaar@chromium.org [Fri, 26 Feb 2010 23:26:04 +0000 (23:26 +0000)]
2010-02-26  Yaar Schnitman  <yaar@chromium.org>

        Chromium build fix.

        * features.gypi: Added missing new variable enable_svg.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-12 Brett Wilson <brettw@chromium.org>
brettw@chromium.org [Fri, 26 Feb 2010 23:18:11 +0000 (23:18 +0000)]
2010-02-12  Brett Wilson  <brettw@chromium.org>

        Reviewed by Adam Barth.

        Update the Google-URL version of KURL and the V8 bindings to the new
        behavior of KURL.IsStandard.

        https://bugs.webkit.org/show_bug.cgi?id=34859

        This is covered by fast/dom/Window/invalid-protocol.html

        * bindings/v8/custom/V8LocationCustom.cpp:
        (WebCore::V8Location::protocolAccessorSetter):
        * platform/KURLGoogle.cpp:
        (WebCore::KURL::setProtocol):
        (WebCore::KURL::isHierarchical):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55319 268f45cc-cd09-0410-ab3c-d52691b4dbfc