WebKit.git
10 years ago2011-02-07 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 8 Feb 2011 00:29:23 +0000 (00:29 +0000)]
2011-02-07  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        Find bouncy is missing content on pages with framesets
        https://bugs.webkit.org/show_bug.cgi?id=53958
        <rdar://problem/8904447>

        Fix paint rect computation; FrameView::paint expects the paint rect to be in the
        parent widget's coordinate system.

        * WebProcess/WebPage/FindController.cpp:
        (WebKit::FindController::updateFindIndicator):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/8960434> and https://bugs.webkit.org/show_bug.cgi?id=53957
beidson@apple.com [Tue, 8 Feb 2011 00:22:47 +0000 (00:22 +0000)]
<rdar://problem/8960434> and https://bugs.webkit.org/show_bug.cgi?id=53957
Crash after incorrectly restoring bogus session state.

Reviewed by Anders Carlsson.

In some cases we're writing an invalid session state for a back/forward list where the current entry is 0
but the number of entries is also 0.
In such cases the current entry should be "NoCurrentEntryIndex."

When we later read this state in, we set ourselves up to crash later.

Amusingly an ASSERT caught this, but we should've rejected it before the ASSERT fired.

* UIProcess/cf/WebBackForwardListCF.cpp:
(WebKit::WebBackForwardList::restoreFromCFDictionaryRepresentation): Fail the restore if the "current index past the end
  of the list" case occurs, and speculatively bail out of the case where we have no current index but do have a list.
  Also remove the unhelpful ASSERT.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-07 Zhenyao Mo <zmo@google.com>
zmo@google.com [Tue, 8 Feb 2011 00:22:13 +0000 (00:22 +0000)]
2011-02-07  Zhenyao Mo  <zmo@google.com>

        Unreviewed, test expectations update.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-07 Zhenyao Mo <zmo@google.com>
zmo@google.com [Tue, 8 Feb 2011 00:11:15 +0000 (00:11 +0000)]
2011-02-07  Zhenyao Mo  <zmo@google.com>

        Unreviewed, test expectations update.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/8946023> REGRESSION (r76674): SVG + BiDi text broken (text-intro...
mitz@apple.com [Tue, 8 Feb 2011 00:07:31 +0000 (00:07 +0000)]
<rdar://problem/8946023> REGRESSION (r76674): SVG + BiDi text broken (text-intro-05-t.svg)
https://bugs.webkit.org/show_bug.cgi?id=53480

Reviewed by Oliver Hunt.

* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): m_indexEnd should be an
offset into m_characters, not into the run’s characters.
* platform/graphics/mac/ComplexTextControllerATSUI.cpp:
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-07 Zhenyao Mo <zmo@google.com>
zmo@google.com [Tue, 8 Feb 2011 00:01:28 +0000 (00:01 +0000)]
2011-02-07  Zhenyao Mo  <zmo@google.com>

        Unreviewed, test expectations update.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd bundle API to get the background color of a frame
weinig@apple.com [Mon, 7 Feb 2011 23:46:18 +0000 (23:46 +0000)]
Add bundle API to get the background color of a frame
<rdar://problem/8962670>
https://bugs.webkit.org/show_bug.cgi?id=53952

Reviewed by Anders Carlsson.

../WebCore:

* WebCore.exp.in: Add export.

../WebKit2:

* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameGetBodyBackgroundColor):
* WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
Add API function.

* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::getDocumentBackgroundColor):
* WebProcess/WebPage/WebFrame.h:
Call down into the document to get either the body's, or if there is no body,
the root element's, background color.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
ossy@webkit.org [Mon, 7 Feb 2011 23:45:58 +0000 (23:45 +0000)]
Unreviewed.

[Qt] Fix crashes in QMetaObject::metacall
https://bugs.webkit.org/show_bug.cgi?id=53912

* platform/qt/Skipped: http/tests/websocket/tests/websocket-pending-activity.html added until fix.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-07 Zhenyao Mo <zmo@google.com>
zmo@google.com [Mon, 7 Feb 2011 23:41:37 +0000 (23:41 +0000)]
2011-02-07  Zhenyao Mo  <zmo@google.com>

        Unreviewed, rebaseline.

        * platform/chromium-mac/fast/url/path-expected.txt:
* platform/chromium-win/fast/url/path-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-07 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Mon, 7 Feb 2011 23:37:23 +0000 (23:37 +0000)]
2011-02-07  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Darin Adler.

        Assertion failure in ~JSGlobalObject when loading apple.com HTML5
        transitions demo page
        https://bugs.webkit.org/show_bug.cgi?id=53853

        This was a long-standing bookkeeping bug uncovered by some heap refactoring.

        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::createImageBuffer):
        * html/HTMLImageLoader.cpp:
        (WebCore::HTMLImageLoader::notifyFinished):
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::dropProtection): Take the JSLock before
        reporting extra cost to the JavaScriptCore heap, since all use of
        JavaScriptCore is supposed to be guarded by JSLock.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoIntermittent crash in fast/files/read-blob-async.html on the GTK+ debug
jianli@chromium.org [Mon, 7 Feb 2011 23:28:35 +0000 (23:28 +0000)]
Intermittent crash in fast/files/read-blob-async.html on the GTK+ debug
bots
https://bugs.webkit.org/show_bug.cgi?id=53104

Reviewed by David Levin.

Source/WebCore:

Covered by the existing tests.

* fileapi/FileStreamProxy.cpp:
(WebCore::FileStreamProxy::startOnFileThread):
* platform/network/BlobRegistryImpl.cpp:
(WebCore::BlobRegistryImpl::createResourceHandle):
* platform/network/BlobResourceHandle.cpp:
(WebCore::BlobResourceHandle::BlobResourceHandle):
(WebCore::BlobResourceHandle::cancel):
(WebCore::delayedStartBlobResourceHandle):
(WebCore::BlobResourceHandle::start): Keep BlobResourceHandle alive
till the delay function is called.
(WebCore::BlobResourceHandle::doStart):
(WebCore::doNotifyFinish):
(WebCore::BlobResourceHandle::notifyFinish): Notify the client via the
standalone function to prevent the handle from being disposed immediately
by the client which will make the calls in the stack that're still bound
to the handle suffer.
* platform/network/BlobResourceHandle.h:
* platform/network/ResourceHandle.h: Change cancel() to virtual so that
BlobResourceHandle::cancel will be called when we abort a FileReader.

LayoutTests:

* platform/gtk/Skipped: Enable the flakey test that has been fixed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-07 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 7 Feb 2011 23:27:27 +0000 (23:27 +0000)]
2011-02-07  Adam Barth  <abarth@webkit.org>

        Remove wrong platform-specific expectation.

        * platform/win/plugins/plugin-document-back-forward-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-07 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Mon, 7 Feb 2011 23:09:22 +0000 (23:09 +0000)]
2011-02-07  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r77845.
        http://trac.webkit.org/changeset/77845
        https://bugs.webkit.org/show_bug.cgi?id=53946

        build failure (Requested by lforschler_ on #webkit).

        * WebCore.xcodeproj/project.pbxproj:
        * accessibility/AccessibilityAllInOne.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=53939
darin@apple.com [Mon, 7 Feb 2011 23:05:53 +0000 (23:05 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=53939
fast/css/text-overflow-ellipsis.html failure after r77818/77819

* platform/text/TextCodecICU.cpp:
(WebCore::TextCodecICU::registerExtendedEncodingNames):
Add back the "utf8" synonym for "UTF-8".

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove an unnecessary extra computeLogicalWidth() from line layout.
hyatt@apple.com [Mon, 7 Feb 2011 22:58:53 +0000 (22:58 +0000)]
Remove an unnecessary extra computeLogicalWidth() from line layout.

Reviewed by Dan Bernstein.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix typo. vectical -> vertical.
weinig@apple.com [Mon, 7 Feb 2011 22:34:38 +0000 (22:34 +0000)]
Fix typo. vectical -> vertical.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didChangeScrollbarsForMainFrame):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoInform the UIProcess when main frame scrollbars change
weinig@apple.com [Mon, 7 Feb 2011 22:32:14 +0000 (22:32 +0000)]
Inform the UIProcess when main frame scrollbars change
<rdar://problem/8967496>
https://bugs.webkit.org/show_bug.cgi?id=53941

Reviewed by Anders Carlsson.

* UIProcess/API/C/WKPage.cpp:
(WKPageHasHorizontalScrollbar):
(WKPageHasVerticalScrollbar):
* UIProcess/API/C/WKPage.h:
Add API to query whether the main frame has scrollbars.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::processDidCrash):
(WebKit::WebPageProxy::didChangeScrollbarsForMainFrame):
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::hasHorizontalScrollbar):
(WebKit::WebPageProxy::hasVerticalScrollbar):
Store/update main frame scrollbar state.

* UIProcess/WebPageProxy.messages.in:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::contentsSizeChanged):
* WebProcess/WebCoreSupport/WebChromeClient.h:
(WebKit::WebChromeClient::WebChromeClient):
Post message when main frame scrollbar state changes.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-07 Lucas Forschler <lforschler@apple.com>
lforschler@apple.com [Mon, 7 Feb 2011 22:28:45 +0000 (22:28 +0000)]
2011-02-07  Lucas Forschler  <lforschler@apple.com>

        Reviewed by Geoffrey Garen.

        Fix Leopard Intel Debug Build.
        <rdar://problem/8953606> REGRESSION: Can't link WebCore on 32-bit Leopard (53681)
        This could potentially break windows, since I had to change #include <filename> to #include "filename"

        * WebCore.xcodeproj/project.pbxproj:
        * accessibility/AccessibilityAllInOne.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-07 Zhenyao Mo <zmo@google.com>
zmo@google.com [Mon, 7 Feb 2011 21:54:50 +0000 (21:54 +0000)]
2011-02-07  Zhenyao Mo  <zmo@google.com>

        Unreviewed, test expectations update.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix build.
weinig@apple.com [Mon, 7 Feb 2011 21:48:28 +0000 (21:48 +0000)]
Fix build.

* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-07 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 7 Feb 2011 21:42:08 +0000 (21:42 +0000)]
2011-02-07  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Some content is not covered by Find-on-page overlay
        https://bugs.webkit.org/show_bug.cgi?id=53937
        <rdar://problem/8711353>

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::didInstallPageOverlay):
        Call LayerTreeHost::didInstallPageOverlay.

        (WebKit::DrawingAreaImpl::didUninstallPageOverlay):
        Call LayerTreeHost::didUninstallPageOverlay.

        (WebKit::DrawingAreaImpl::setPageOverlayNeedsDisplay):
        Call LayerTreeHost::setPageOverlayNeedsDisplay.

        * WebProcess/WebPage/FindController.cpp:
        (WebKit::FindController::drawRect):
        Remove a bogus assertion.

        * WebProcess/WebPage/LayerTreeHost.h:
        Add new pure virtual member functions.

        * WebProcess/WebPage/PageOverlay.cpp:
        (WebKit::PageOverlay::setNeedsDisplay):
        Call DrawingArea::setPageOverlayNeedsDisplay.

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::installPageOverlay):
        Make sure to call PageOverlay::setNeedsDisplay after the page overlay has been installed.

        * WebProcess/WebPage/mac/LayerTreeHostMac.mm:
        (WebKit::LayerTreeHostMac::LayerTreeHostMac):
        Create the page overlay layer if needed.

        (WebKit::LayerTreeHostMac::setNonCompositedContentsNeedDisplay):
        Invalidate the page overlay layer as well.

        (WebKit::LayerTreeHostMac::sizeDidChange):
        Resize the page overlay layer.

        (WebKit::LayerTreeHostMac::didInstallPageOverlay):
        Create the page overlay layer.

        (WebKit::LayerTreeHostMac::didUninstallPageOverlay):
        Destroy the page overlay layer.

        (WebKit::LayerTreeHostMac::setPageOverlayNeedsDisplay):
        Call setNeedsDisplay on the page overlay layer.

        (WebKit::LayerTreeHostMac::paintContents):
        Handle painting the page overlay layer.

        (WebKit::LayerTreeHostMac::flushPendingLayerChanges):
        Flush the page overlay layer changes as well.

        (WebKit::LayerTreeHostMac::createPageOverlayLayer):
        Create a layer and add it as a sublayer of the root layer.

        (WebKit::LayerTreeHostMac::destroyPageOverlayLayer):
        Destroy the page overlay layer.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd mechanism to inform the ScrollAnimator when Scrollbars are added
weinig@apple.com [Mon, 7 Feb 2011 21:29:12 +0000 (21:29 +0000)]
Add mechanism to inform the ScrollAnimator when Scrollbars are added
and removed.

Reviewed by Beth Dakin.

* platform/ScrollAnimator.h:
(WebCore::ScrollAnimator::didAddVerticalScrollbar):
(WebCore::ScrollAnimator::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimator::didAddHorizontalScrollbar):
(WebCore::ScrollAnimator::willRemoveHorizontalScrollbar):
Make virtual to allow platform specific overrides.

* platform/ScrollView.cpp:
(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):
Call new ScrollableArea functions.

* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::didAddVerticalScrollbar):
(WebCore::ScrollableArea::willRemoveVerticalScrollbar):
(WebCore::ScrollableArea::didAddHorizontalScrollbar):
(WebCore::ScrollableArea::willRemoveHorizontalScrollbar):
* platform/ScrollableArea.h:
Pipe to ScrollAnimator.

* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
* platform/mac/ScrollbarThemeMac.h:
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::unregisterScrollbar):
(WebCore::ScrollbarThemeMac::painterForScrollbar):
Move painter delegate registration to the new didAdd/willRemove functions.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-07 Zhenyao Mo <zmo@google.com>
zmo@google.com [Mon, 7 Feb 2011 21:25:56 +0000 (21:25 +0000)]
2011-02-07  Zhenyao Mo  <zmo@google.com>

        Unreviewed, test expectations update.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake it possible to use DrawingAreaProxyImpl on Windows
aroben@apple.com [Mon, 7 Feb 2011 21:19:54 +0000 (21:19 +0000)]
Make it possible to use DrawingAreaProxyImpl on Windows

It can be optionally turned on by setting the WEBKIT2_USE_NEW_DRAWING_AREA environment
variable. Turning it on by default is covered by <http://webkit.org/b/53805>.

Fixes <http://webkit.org/b/53879>.

Reviewed by Anders Carlsson.

* UIProcess/BackingStore.h: Add an m_bitmap member on Windows.

* UIProcess/win/BackingStoreWin.cpp:
(WebKit::BitmapDC::operator HDC):
(WebKit::BitmapDC::BitmapDC):
(WebKit::BitmapDC::~BitmapDC):
Added this helper class, which uses RAII to select a bitmap into a new memory DC.
(WebKit::BackingStore::paint): Wrap our bitmap in a BitmapDC and use ::BitBlt to copy the
specified rect into the destination DC.
(WebKit::createBitmap): New helper function, just creates a DIB section with the specified
size.
(WebKit::BackingStore::incorporateUpdate): Ported from BackingStoreMac.mm. It seems like
this code could be shared at some point.
(WebKit::BackingStore::scroll): Wrap our bitmap in a BitmapDC and use ::ScrollDC to scroll
the specified rect.

* UIProcess/win/WebView.cpp:
(WebKit::useNewDrawingArea): Added. Returns true if the WEBKIT2_USE_NEW_DRAWING_AREA
environment variable is set.
(WebKit::drawPageBackground): New helper function. Code came from onPaintEvent.
(WebKit::WebView::onPaintEvent): Ported from -[WKView drawRect:].
(WebKit::WebView::createDrawingAreaProxy): Create a DrawingAreaProxyImpl if we're using the
new drawing area.

(WebKit::WebView::enterAcceleratedCompositingMode):
(WebKit::WebView::exitAcceleratedCompositingMode):
(WebKit::WebView::pageDidEnterAcceleratedCompositing):
(WebKit::WebView::pageDidLeaveAcceleratedCompositing):
Added some assertions to make sure these are only called when expected. We don't expect
enter/exitAcceleratedCompositingMode to be called at all right now, because accelerated
compositing is turned off in WebKit2 on Windows.

(WebKit::WebView::switchToDrawingAreaTypeIfNecessary): Ditto, and added a case for the
DrawingAreaInfo::Impl constant.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoStart compiling DrawingArea[Proxy]Impl and dependencies on Windows
aroben@apple.com [Mon, 7 Feb 2011 21:19:20 +0000 (21:19 +0000)]
Start compiling DrawingArea[Proxy]Impl and dependencies on Windows

Fixes <http://webkit.org/b/53875> WebKit2 on Windows should build DrawingArea[Proxy]Impl

Reviewed by Sam Weinig and Darin Adler.

* Platform/Region.cpp:
(WebKit::Region::Shape::shapeOperation): Initialize variable to avoid a bogus "potentially
uninitialized variable" warning.

* UIProcess/BackingStore.cpp: Removed #error for non-Mac platforms.

* UIProcess/BackingStore.h: Added a PlatformGraphicsContext typedef for Windows.

* UIProcess/DrawingAreaProxy.h:
* UIProcess/DrawingAreaProxyImpl.cpp:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage):
Allow Windows to compile the new drawing area code.

* WebProcess/WebPage/DrawingArea.cpp:
(WebKit::DrawingArea::create): Allow creating a DrawingAreaImpl on Windows, too.

* WebProcess/WebPage/DrawingArea.h:
* WebProcess/WebPage/DrawingAreaImpl.cpp:
* WebProcess/WebPage/LayerTreeHost.cpp:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didReceiveMessage):
Allow Windows to compile the new drawing area code.

* Shared/win/LayerTreeContextWin.cpp: Added.
* UIProcess/win/BackingStoreWin.cpp: Added.
Stubbed out these files.

* win/WebKit2.vcproj: Added new files.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-07 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 7 Feb 2011 20:57:42 +0000 (20:57 +0000)]
2011-02-07  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Rename some drawing area related member functions
        https://bugs.webkit.org/show_bug.cgi?id=53935

        * WebProcess/WebPage/DrawingArea.h:
        (WebKit::DrawingArea::setPageOverlayNeedsDisplay):
        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::setNeedsDisplay):
        (WebKit::DrawingAreaImpl::setPageOverlayNeedsDisplay):
        * WebProcess/WebPage/DrawingAreaImpl.h:
        * WebProcess/WebPage/LayerTreeHost.h:
        * WebProcess/WebPage/mac/LayerTreeHostMac.h:
        * WebProcess/WebPage/mac/LayerTreeHostMac.mm:
        (WebKit::LayerTreeHostMac::setNonCompositedContentsNeedDisplay):
        (WebKit::LayerTreeHostMac::scrollNonCompositedContents):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-07 Chang Shu <chang.shu@nokia.com>
chang.shu@nokia.com [Mon, 7 Feb 2011 20:49:31 +0000 (20:49 +0000)]
2011-02-07  Chang Shu  <chang.shu@nokia.com>

        Reviewed by Darin Adler.

        We should disable spatial navigation explicitly during the initialization
        of DumpRenderTree.
        https://bugs.webkit.org/show_bug.cgi?id=53928

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (resetDefaultsToConsistentValues):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-07 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 7 Feb 2011 20:43:05 +0000 (20:43 +0000)]
2011-02-07  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Missing text match markers with accelerated content
        https://bugs.webkit.org/show_bug.cgi?id=53934

        When doing the fake paint that recomputes the text match rects, we need to
        flatten compositing layers, otherwise the rects won't be updated until the next paint call.

        (This worked by accident in WebKit1 because Safari calls -[NSWindow displayIfNeeded] on the containing
        window before asking for the text match rects).

        * editing/Editor.cpp:
        (WebCore::Editor::countMatchesForText):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION(r77740): CSSStyleSelector accessing deleted memory for svg/dom/use-transfo...
antti@apple.com [Mon, 7 Feb 2011 20:08:47 +0000 (20:08 +0000)]
REGRESSION(r77740): CSSStyleSelector accessing deleted memory for svg/dom/use-transform.svg
https://bugs.webkit.org/show_bug.cgi?id=53900

Reviewed by Andreas Kling.

Ignore link elements in shadow trees.

* dom/Element.cpp:
(WebCore::StyleSelectorParentPusher::StyleSelectorParentPusher):
(WebCore::StyleSelectorParentPusher::~StyleSelectorParentPusher):

    Some asserts to catch cases like this.

(WebCore::Element::attach):
(WebCore::Element::recalcStyle):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::HTMLLinkElement):
(WebCore::HTMLLinkElement::process):
(WebCore::HTMLLinkElement::insertedIntoDocument):
(WebCore::HTMLLinkElement::removedFromDocument):
* html/HTMLLinkElement.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-07 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Mon, 7 Feb 2011 19:18:00 +0000 (19:18 +0000)]
2011-02-07  Dimitri Glazkov  <dglazkov@chromium.org>

        Mark test as flaky per dashboard.
        https://bugs.webkit.org/show_bug.cgi?id=53824

        * platform/chromium/test_expectations.txt: Marked.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTurn UTF-8 decoder off for now so we can look into failing tests
darin@apple.com [Mon, 7 Feb 2011 18:46:01 +0000 (18:46 +0000)]
Turn UTF-8 decoder off for now so we can look into failing tests
without leaving the tree red.

* platform/text/TextCodecICU.cpp:
(WebCore::TextCodecICU::registerBaseEncodingNames): Reverting
earlier change so this can handle UTF-8.
(WebCore::TextCodecICU::registerBaseCodecs): Ditto.
(WebCore::TextCodecICU::registerExtendedEncodingNames): Ditto.
(WebCore::TextCodecICU::registerExtendedCodecs): Ditto.
* platform/text/TextCodecICU.h: Ditto.
* platform/text/TextEncodingRegistry.cpp:
(WebCore::buildBaseTextCodecMaps): Ditto.
(WebCore::extendTextCodecMaps): Ditto.
* platform/text/brew/TextCodecBrew.cpp:
(WebCore::TextCodecBrew::registerBaseEncodingNames): Ditto.
(WebCore::TextCodecBrew::registerBaseCodecs): Ditto.
(WebCore::TextCodecBrew::registerExtendedEncodingNames): Ditto.
(WebCore::TextCodecBrew::registerExtendedCodecs): Ditto.
* platform/text/brew/TextCodecBrew.h: Ditto.
* platform/text/gtk/TextCodecGtk.cpp:
(WebCore::TextCodecGtk::registerBaseEncodingNames): Ditto.
(WebCore::TextCodecGtk::registerBaseCodecs): Ditto.
* platform/text/wince/TextCodecWinCE.cpp:
(WebCore::TextCodecWinCE::registerBaseEncodingNames): Ditto.
(WebCore::TextCodecWinCE::registerBaseCodecs): Ditto.
(WebCore::TextCodecWinCE::registerExtendedEncodingNames): Ditto.
(WebCore::TextCodecWinCE::registerExtendedCodecs): Ditto.
* platform/text/wince/TextCodecWinCE.h: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUse the right calling convention when calling WebKitMain
aroben@apple.com [Mon, 7 Feb 2011 18:45:32 +0000 (18:45 +0000)]
Use the right calling convention when calling WebKitMain

Fixes <http://webkit.org/b/53923> REGRESSION (r77678): Crash on quit in web process in
wWinMain

Reviewed by Steve Falkenburg.

* win/MainWin.cpp:
(wWinMain): Use __cdecl instead of WINAPI (__stdcall) when calling WebKitMain, since that is
how that function is declared.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-07 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 7 Feb 2011 18:39:24 +0000 (18:39 +0000)]
2011-02-07  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        The drawing area should be in charge of drawing the page overlay
        https://bugs.webkit.org/show_bug.cgi?id=53927

        * WebProcess/WebPage/DrawingArea.h:
        (WebKit::DrawingArea::didInstallPageOverlay):
        (WebKit::DrawingArea::didUninstallPageOverlay):
        (WebKit::DrawingArea::setOverlayNeedsDisplay):
        Add empty stubs.

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::didInstallPageOverlay):
        Add empty function. This will eventually ask the layer tree host to
        create a GraphicsLayer for the page overlay.

        (WebKit::DrawingAreaImpl::didUninstallPageOverlay):
        Tell the page that it needs to be repainted.

        (WebKit::DrawingAreaImpl::setOverlayNeedsDisplay):
        Just call setNeedsDisplay for now.

        (WebKit::DrawingAreaImpl::display):
        Paint the page overlay too.

        * WebProcess/WebPage/DrawingAreaImpl.h:
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::drawRect):
        Only call drawPageOverlay if we have an old drawing area.

        (WebKit::WebPage::drawPageOverlay):
        Draw the page overlay. Code moved here from WebPage::drawRect.

        (WebKit::WebPage::installPageOverlay):
        Call DrawingArea::installPageOverlay.

        (WebKit::WebPage::uninstallPageOverlay):
        Call DrawingArea::uninstallPageOverlay.

        * WebProcess/WebPage/WebPage.h:
        (WebKit::WebPage::hasPageOverlay):
        Add getter.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDon't exclude overlay scrollers from the page overlay bounds
andersca@apple.com [Mon, 7 Feb 2011 18:31:33 +0000 (18:31 +0000)]
Don't exclude overlay scrollers from the page overlay bounds
https://bugs.webkit.org/show_bug.cgi?id=53924

Reviewed by Maciej Stachowiak.

Export ScrollbarTheme::nativeTheme.

* WebCore.exp.in:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-07 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 7 Feb 2011 18:26:54 +0000 (18:26 +0000)]
2011-02-07  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Add WebPage::bounds and use it
        https://bugs.webkit.org/show_bug.cgi?id=53926

        * WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
        (WebKit::ChunkedUpdateDrawingArea::resumePainting):
        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::resumePainting):
        (WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
        * WebProcess/WebPage/WebPage.h:
        (WebKit::WebPage::bounds):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-07 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 7 Feb 2011 18:21:37 +0000 (18:21 +0000)]
2011-02-07  Anders Carlsson  <andersca@apple.com>

        Reviewed by Maciej Stachowiak.

        Don't exclude overlay scrollers from the page overlay bounds
        https://bugs.webkit.org/show_bug.cgi?id=53924

        Don't subtract the scrollbars from the page overlay bounds if
        overlay scrollers are enabled.

        * WebProcess/WebPage/PageOverlay.cpp:
        (WebKit::PageOverlay::bounds):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-07 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Mon, 7 Feb 2011 18:18:04 +0000 (18:18 +0000)]
2011-02-07  Martin Robinson  <mrobinson@igalia.com>

        Unskip a passing accessibility test and organize the rest of the tests missing
        results as failing.

        * platform/gtk/Skipped: Unskip passing test and organize remaining failures.
        * platform/gtk/accessibility/aria-describedby-on-input-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd built-in decoder for UTF-8 for improved performance
darin@apple.com [Mon, 7 Feb 2011 18:02:55 +0000 (18:02 +0000)]
Add built-in decoder for UTF-8 for improved performance
https://bugs.webkit.org/show_bug.cgi?id=53898

Reviewed by Antti Koivisto.

* wtf/unicode/UnicodeMacrosFromICU.h: Added U8_MAX_LENGTH and
U8_APPEND_UNSAFE. Also fixed header.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNot reviewed.
mjs@apple.com [Mon, 7 Feb 2011 17:57:36 +0000 (17:57 +0000)]
Not reviewed.

Fix WebKitTestRunner build on the SL bot.

* WebKitTestRunner/Configurations/Base.xcconfig: Look for the JSC copy
of ICU headers.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Zhenyao Mo <zmo@google.com>
zmo@google.com [Mon, 7 Feb 2011 17:29:36 +0000 (17:29 +0000)]
2011-02-03  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Crash in glDrawArrays with NaCl crystal model
        https://bugs.webkit.org/show_bug.cgi?id=52831

        * html/canvas/WebGLRenderingContext.cpp: Allocate large enough buffer for atttrib0 if it's enabled and not used.
        (WebCore::WebGLRenderingContext::initVertexAttrib0):
        (WebCore::WebGLRenderingContext::simulateVertexAttrib0):
        * html/canvas/WebGLRenderingContext.h:
2011-02-03  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Crash in glDrawArrays with NaCl crystal model
        https://bugs.webkit.org/show_bug.cgi?id=52831

        * fast/canvas/webgl/gl-vertex-attrib-zero-issues-expected.txt: Added.
        * fast/canvas/webgl/gl-vertex-attrib-zero-issues.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: WAI-ARIA @aria-sort not exposed on rowheader and columnheader roles.
cfleizach@apple.com [Mon, 7 Feb 2011 17:24:01 +0000 (17:24 +0000)]
Source/WebCore: WAI-ARIA @aria-sort not exposed on rowheader and columnheader roles.
https://bugs.webkit.org/show_bug.cgi?id=53842

Reviewed by Darin Adler.

Test: platform/mac/accessibility/aria-sort.html

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::sortDirection):
* accessibility/AccessibilityObject.h:
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
* html/HTMLAttributeNames.in:

LayoutTests: WAI-ARIA @aria-sort not exposed on rowheader and columnheader roles
https://bugs.webkit.org/show_bug.cgi?id=53842

Reviewed by Darin Adler.

* platform/mac/accessibility/aria-sort-expected.txt: Added.
* platform/mac/accessibility/aria-sort.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-06 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 7 Feb 2011 16:35:38 +0000 (16:35 +0000)]
2011-02-06  Darin Adler  <darin@apple.com>

        Reviewed by Antti Koivisto.

        Add built-in decoder for UTF-8 for improved performance
        https://bugs.webkit.org/show_bug.cgi?id=53898

        Correct behavior is covered by existing tests.

        * Android.mk: Added TextCodecUTF8.
        * CMakeLists.txt: Ditto.
        * GNUmakefile.am: Ditto.
        * WebCore.gypi: Ditto.
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.

        * platform/text/TextCodecICU.cpp: Removed registration of UTF-8
        since that's now handled by the built-in UTF-8 codec.
        (WebCore::TextCodecICU::registerEncodingNames): Renamed to remove
        the word "extended" since all codecs from ICU are now extended.
        (WebCore::TextCodecICU::registerCodecs): Ditto.
        * platform/text/TextCodecICU.h: Ditto.

        * platform/text/TextCodecUTF16.cpp:
        (WebCore::TextCodecUTF16::decode): Added a FIXME about missing
        error handling.

        * platform/text/TextCodecUTF8.cpp: Added.
        * platform/text/TextCodecUTF8.h: Added.

        * platform/text/TextEncodingRegistry.cpp:
        (WebCore::buildBaseTextCodecMaps): Added TextCodecUTF8, and
        removed TextCodecICU, TextCodecBrew, and TextCodecWinCE.
        (WebCore::extendTextCodecMaps): Updated names for
        TextCodecICU and TextCodecWinCE.

        * platform/text/brew/TextCodecBrew.cpp:
        (WebCore::TextCodecBrew::registerEncodingNames): Renamed to remove
        the word "extended" since all codecs from Brew are now extended.
        (WebCore::TextCodecBrew::registerCodecs): Ditto.
        * platform/text/brew/TextCodecBrew.h: Ditto.

        * platform/text/gtk/TextCodecGtk.cpp:
        (WebCore::TextCodecGtk::registerBaseEncodingNames): Removed
        registration of UTF-8. It's questionable whether the other codecs
        here are really basic. If we think they qualify, then we should
        register them on other platforms, not just GTK.
        (WebCore::TextCodecGtk::registerBaseCodecs): Ditto.

        * platform/text/wince/TextCodecWinCE.cpp:
        (WebCore::getCodePage): Removed special case for UTF-8 since we
        no longer use this codec for UTF-8.
        (WebCore::TextCodecWinCE::registerEncodingNames): Renamed to remove
        the word "extended" since all codecs from WinCE are now extended.
        (WebCore::TextCodecWinCE::registerCodecs): Ditto.
        * platform/text/wince/TextCodecWinCE.h: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-07 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Mon, 7 Feb 2011 16:35:36 +0000 (16:35 +0000)]
2011-02-07  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Daniel Bates.

        [GTK] fast/history/history-subframe-with-name.html fails with GTK DRT
        https://bugs.webkit.org/show_bug.cgi?id=44784

        * platform/gtk/Skipped: Unskip tests which are now passing.
2011-02-07  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Daniel Bates.

        [GTK] fast/history/history-subframe-with-name.html fails with GTK DRT
        https://bugs.webkit.org/show_bug.cgi?id=44784

        Call FrameLoader::loadURLIntoChildFrame on the parent frame's loader, not the child's.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::createFrame): Fix the call to FrameLoader::loadURLIntoChildFrame.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-07 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Mon, 7 Feb 2011 16:23:10 +0000 (16:23 +0000)]
2011-02-07  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Xan Lopez.

        [Gtk] atk_text_get_caret_offset fails for list items
        https://bugs.webkit.org/show_bug.cgi?id=53436

        Consider list item markers when calculating the offset.

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (webkit_accessible_text_get_caret_offset): Adjust the offset
        with the item marker's length for list items.
        (webkit_accessible_text_set_caret_offset): Replace usage of
        g_utf8_strlen() by calling to markerText.length().
2011-02-07  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Xan Lopez.

        [Gtk] atk_text_get_caret_offset fails for list items
        https://bugs.webkit.org/show_bug.cgi?id=53436

        Update unit test to check the fix for this bug.

        * tests/testatk.c:
        (testWebkitAtkCaretOffsets): Check that the caret offset returned
        match the value previously set.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build fix after r77794
aroben@apple.com [Mon, 7 Feb 2011 16:03:06 +0000 (16:03 +0000)]
Windows build fix after r77794

* win/WebKit2.def: Export WebCore symbols used by WebKitTestRunner.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDelete precompiled headers whenever any .vsprops file changes
aroben@apple.com [Mon, 7 Feb 2011 16:02:02 +0000 (16:02 +0000)]
Delete precompiled headers whenever any .vsprops file changes

Precompiled headers need to be rebuilt if, e.g., an ENABLE_* macro is changed in one of our
.vsprops files. Unfortunately, Visual Studio isn't smart enough to figure this out, so we
give it some assistance by deleting the precompiled headers whenever any .vsprops file
changes.

I also made some drive-by fixes while I was in the area.

Fixes <http://webkit.org/b/53826> react-to-vsprops-changes.py doesn't force precompiled
headers to be rebuilt, but should

Reviewed by David Kilzer.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Stop ignoring the
return code from react-to-vsprops-changes.py so we will notice when errors are introduced.
But skip the script entirely in production builds, where it is both unnecessary and can't
function correctly (due to not having the entire source tree available to it).

* JavaScriptCore.vcproj/JavaScriptCore/react-to-vsprops-changes.py:
(main): Removed an extra '*' in the glob for finding manifest files. The extra '*' was
leftover from before we rearranged WebKitBuild in r75138. Moved code to delete an old file
to the new delete_if_older_than function. Added code to delete any precompiled headers older
than the newest .vsprops file.
(delete_if_older_than): Added. Code came from main.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-07 Yi Shen <yi.4.shen@nokia.com>
yi.4.shen@nokia.com [Mon, 7 Feb 2011 15:57:57 +0000 (15:57 +0000)]
2011-02-07  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Tor Arne Vestbø.

        [Qt] Fix LayoutTests/media/restore-from-page-cache.html
        https://bugs.webkit.org/show_bug.cgi?id=53621

        Unskip media/restore-from-page-cache.html for Qt.

        * platform/qt/Skipped:
2011-02-07  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Tor Arne Vestbø.

        [Qt] Fix LayoutTests/media/restore-from-page-cache.html
        https://bugs.webkit.org/show_bug.cgi?id=53621

        Changed the networkState to MediaPlayer::Loaded when
        MediaPlayerPrivateQt has enough data.

        Test: media/restore-from-page-cache.html

        * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
        (WebCore::MediaPlayerPrivateQt::updateStates):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-07 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Mon, 7 Feb 2011 15:56:34 +0000 (15:56 +0000)]
2011-02-07  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Andreas Kling.

        [Haiku] FrameLoaderClient calls loadURLInChildFrame on the child's frame loader
        https://bugs.webkit.org/show_bug.cgi?id=53893

        * WebCoreSupport/FrameLoaderClientHaiku.cpp:
        (WebCore::FrameLoaderClientHaiku::createFrame): Use m_frame instead of childFrame.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-07 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Mon, 7 Feb 2011 15:31:55 +0000 (15:31 +0000)]
2011-02-07  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed.

        Chromium: three tests temporary disabled for rebaseline after r77781

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-07 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Mon, 7 Feb 2011 15:18:26 +0000 (15:18 +0000)]
2011-02-07  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Andreas Kling.

        [EFL] FrameLoaderClient calls loadURLInChildFrame on the child's frame loader
        https://bugs.webkit.org/show_bug.cgi?id=53892

        * ewk/ewk_frame.cpp:
        (ewk_frame_child_add): Use the loader of the core frame instead.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-04 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Mon, 7 Feb 2011 15:15:37 +0000 (15:15 +0000)]
2011-02-04  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: implement beautification of scripts inlined in html documents.
        https://bugs.webkit.org/show_bug.cgi?id=52706

        * http/tests/inspector/debugger-test2.js:
        (initialize_DebuggerTest.InspectorTest.setBreakpointInVisibleView):
        * inspector/debugger-breakpoints-not-activated-on-reload.html:
        * inspector/debugger-pause-on-breakpoint.html:
2011-01-31  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: implement beautification of scripts inlined in html documents.
        https://bugs.webkit.org/show_bug.cgi?id=52706

        To beautify scripts inlined in html, we need to cut individual scripts, beautify them using UglifyJS library, and
        finally paste them back to html.

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/ScriptFormatter.js:
        (WebInspector.ScriptFormatter): Implement formatting of scripts inlined in html.
        (WebInspector.ScriptFormatter.prototype.formatContent.didFormatChunks):
        (WebInspector.ScriptFormatter.prototype.formatContent):
        (WebInspector.ScriptFormatter.prototype._splitContentIntoChunks):
        (WebInspector.ScriptFormatter.prototype._formatChunks.didFormat):
        (WebInspector.ScriptFormatter.prototype._formatChunks):
        (WebInspector.ScriptFormatter.prototype._buildContentFromChunks):
        (WebInspector.ScriptFormatter.prototype._formatScript.messageHandler):
        (WebInspector.ScriptFormatter.prototype._formatScript):
        * inspector/front-end/ScriptFormatterWorker.js:
        (onmessage):
        (buildMapping):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrameContent): Use SourceFrameContent and FormattedSourceFrameContent to perform operations with line numbers.
        * inspector/front-end/SourceFrameContent.js: Added.
        (WebInspector.SourceFrameContent): Helper class, holds resource text and scripts layout
        (WebInspector.SourceFrameContent.prototype.get scriptRanges):
        (WebInspector.SourceFrameContent.prototype.locationToPosition):
        (WebInspector.SourceFrameContent.prototype.positionToLocation):
        (WebInspector.SourceFrameContent.prototype.scriptLocationForLineNumber):
        (WebInspector.SourceFrameContent.prototype.scriptLocationForRange):
        (WebInspector.SourceFrameContent.prototype.lineNumberToRange):
        (WebInspector.SourceFrameContent.prototype._intersectingScriptRange):
        (WebInspector):
        (WebInspector.FormattedSourceFrameContent): Helper class, holds original and formatted versions of resource and mapping between them.
        (WebInspector.FormattedSourceFrameContent.prototype.get text):
        (WebInspector.FormattedSourceFrameContent.prototype.originalLocationToFormattedLocation):
        (WebInspector.FormattedSourceFrameContent.prototype.scriptLocationForFormattedLineNumber):
        (WebInspector.FormattedSourceFrameContent.prototype._convertPosition):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-07 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Mon, 7 Feb 2011 14:55:50 +0000 (14:55 +0000)]
2011-02-07  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Andreas Kling.

        [wx] FrameLoaderClient calls loadURLInChildFrame on the child's frame loader
        https://bugs.webkit.org/show_bug.cgi?id=53895

        * WebKitSupport/FrameLoaderClientWx.cpp:
        (WebCore::FrameLoaderClientWx::createFrame): Use m_frame instead of childFrame.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-07 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Mon, 7 Feb 2011 14:49:28 +0000 (14:49 +0000)]
2011-02-07  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed.

        Chromium: add explicit "Passed" expectations for the tests which have "failed" expectations in platfrom/mac
        The problem was introduced at r77719.
        I have to do that because platform/mac is in the list of baseline folders.
        See 'Tools/Scripts/webkitpy/layout_tests/port/chromium_linux.py'.

        * platform/chromium/canvas/philip/tests/2d.drawImage.broken-expected.txt: Added.
        * platform/chromium/canvas/philip/tests/2d.drawImage.image.incomplete.omitted-expected.txt: Added.
        * platform/chromium/canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-6-expected.txt: Added.
        * platform/chromium/canvas/philip/tests/2d.fillStyle.parse.rgb-eof-expected.txt: Added.
        * platform/chromium/canvas/philip/tests/2d.fillStyle.parse.rgba-eof-expected.txt: Added.
        * platform/chromium/canvas/philip/tests/2d.fillStyle.parse.system-expected.txt: Added.
        * platform/chromium/canvas/philip/tests/2d.gradient.radial.cone.front-expected.txt: Added.
        * platform/chromium/canvas/philip/tests/2d.gradient.radial.inside2-expected.txt: Added.
        * platform/chromium/canvas/philip/tests/2d.gradient.radial.inside3-expected.txt: Added.
        * platform/chromium/canvas/philip/tests/2d.gradient.radial.outside1-expected.txt: Added.
        * platform/chromium/canvas/philip/tests/2d.imageData.put.wrongtype-expected.txt: Added.
        * platform/chromium/canvas/philip/tests/2d.line.cap.closed-expected.txt: Added.
        * platform/chromium/canvas/philip/tests/2d.line.join.parallel-expected.txt: Added.
        * platform/chromium/canvas/philip/tests/2d.line.miter.lineedge-expected.txt: Added.
        * platform/chromium/canvas/philip/tests/2d.path.rect.winding-expected.txt: Added.
        * platform/chromium/canvas/philip/tests/2d.pattern.image.broken-expected.txt: Added.
        * platform/chromium/canvas/philip/tests/2d.pattern.image.incomplete.empty-expected.txt: Added.
        * platform/chromium/canvas/philip/tests/2d.pattern.image.incomplete.omitted-expected.txt: Added.
        * platform/chromium/canvas/philip/tests/2d.shadow.enable.x-expected.txt: Added.
        * platform/chromium/canvas/philip/tests/2d.shadow.enable.y-expected.txt: Added.
        * platform/chromium/canvas/philip/tests/2d.strokeRect.zero.4-expected.txt: Added.
        * platform/chromium/canvas/philip/tests/2d.text.draw.baseline.bottom-expected.txt: Added.
        * platform/chromium/canvas/philip/tests/2d.text.draw.baseline.hanging-expected.txt: Added.
        * platform/chromium/canvas/philip/tests/2d.text.draw.baseline.middle-expected.txt: Added.
        * platform/chromium/canvas/philip/tests/2d.text.draw.baseline.top-expected.txt: Added.
        * platform/chromium/canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface-expected.txt: Added.
        * platform/chromium/canvas/philip/tests/2d.text.draw.space.collapse.end-expected.txt: Added.
        * platform/chromium/canvas/philip/tests/2d.text.draw.space.collapse.nonspace-expected.txt: Added.
        * platform/chromium/canvas/philip/tests/2d.text.draw.space.collapse.other-expected.txt: Added.
        * platform/chromium/canvas/philip/tests/2d.text.draw.space.collapse.space-expected.txt: Added.
        * platform/chromium/canvas/philip/tests/2d.text.draw.space.collapse.start-expected.txt: Added.
        * platform/chromium/canvas/philip/tests/2d.text.font.parse.basic-expected.txt: Added.
        * platform/chromium/canvas/philip/tests/2d.text.font.parse.complex-expected.txt: Added.
        * platform/chromium/canvas/philip/tests/2d.text.font.parse.invalid-expected.txt: Added.
        * platform/chromium/canvas/philip/tests/2d.text.font.parse.size.percentage-expected.txt: Added.
        * platform/chromium/canvas/philip/tests/2d.text.font.parse.size.percentage.default-expected.txt: Added.
        * platform/chromium/canvas/philip/tests/2d.text.font.parse.system-expected.txt: Added.
        * platform/chromium/canvas/philip/tests/2d.text.measure.width.space-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-07 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Mon, 7 Feb 2011 13:21:22 +0000 (13:21 +0000)]
2011-02-07  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed.

        small text which is scaled to be large renders pixelated
        https://bugs.webkit.org/show_bug.cgi?id=12448

        Update Snow Leopard SVG pixel test baseline after r77485.

        * platform/mac/svg/dom/SVGRectElement/rect-modify-rx-expected.png:
        * platform/mac/svg/dynamic-updates/SVGAElement-dom-href-attr-expected.png:
...

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-07 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Mon, 7 Feb 2011 13:10:08 +0000 (13:10 +0000)]
2011-02-07  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed.

        small text which is scaled to be large renders pixelated
        https://bugs.webkit.org/show_bug.cgi?id=12448

        Update Snow Leopard SVG pixel test baseline after r77485.

        * platform/mac/svg/custom/js-update-polygon-removal-expected.png:
        * platform/mac/svg/custom/js-update-style-expected.png:
...

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-07 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Mon, 7 Feb 2011 13:05:36 +0000 (13:05 +0000)]
2011-02-07  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed.

        small text which is scaled to be large renders pixelated
        https://bugs.webkit.org/show_bug.cgi?id=12448

        Update Snow Leopard SVG pixel test baseline after r77485.

        * platform/mac/svg/custom/class-baseValue-expected.png:
        * platform/mac/svg/custom/class-selector-expected.png:
...

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-07 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Mon, 7 Feb 2011 12:59:18 +0000 (12:59 +0000)]
2011-02-07  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed.

        small text which is scaled to be large renders pixelated
        https://bugs.webkit.org/show_bug.cgi?id=12448

        Update Snow Leopard SVG pixel test baseline after r77485.

        * platform/mac/svg/batik/paints/gradientLimit-expected.png:
        * platform/mac/svg/batik/paints/patternRegionA-expected.png:
...

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-07 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Mon, 7 Feb 2011 11:56:51 +0000 (11:56 +0000)]
2011-02-07  Alejandro G. Castro  <alex@igalia.com>

        Unreviewed, added new results for the slider-thumb-drag-release
        test and removed use-infinite-recursion.svg from skipped, required
        after r77778.

        * platform/gtk/Skipped:
        * platform/gtk/fast/repaint/slider-thumb-drag-release-expected.checksum: Added.
        * platform/gtk/fast/repaint/slider-thumb-drag-release-expected.png: Added.
        * platform/gtk/fast/repaint/slider-thumb-drag-release-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-07 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Mon, 7 Feb 2011 11:46:29 +0000 (11:46 +0000)]
2011-02-07  Alexander Pavlov  <apavlov@chromium.org>

        Unreviewed. Add Web Inspector warning 10x10 PNG, move files from r77801 into the inspector/ directory.

        * blog-files/inspector/css_as_authored.png: Renamed from Websites/webkit.org/blog-files/inspector-css-as-authored.png.
        * blog-files/inspector/css_autocomplete.png: Renamed from Websites/webkit.org/blog-files/inspector-css-autocomplete.png.
        * blog-files/inspector/css_unknown_properties.png: Renamed from Websites/webkit.org/blog-files/inspector-unknown-css-properties.png.
        * blog-files/inspector/warning_10x10.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-07 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Mon, 7 Feb 2011 11:27:13 +0000 (11:27 +0000)]
2011-02-07  Alexander Pavlov  <apavlov@chromium.org>

        Unreviewed. Add Web Inspector style editing screenshots.

        * blog-files/inspector-css-as-authored.png: Added.
        * blog-files/inspector-css-autocomplete.png: Added.
        * blog-files/inspector-unknown-css-properties.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-07 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 7 Feb 2011 11:26:25 +0000 (11:26 +0000)]
2011-02-07  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: "Reveal in elements panel" does not always work.
        https://bugs.webkit.org/show_bug.cgi?id=53775

        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView):
        * inspector/front-end/ContextMenu.js:
        (WebInspector.ContextMenu.prototype.show):
        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.prototype.switchToAndFocus):
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired.focusElement):
        (WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired):
        * inspector/front-end/ObjectPropertiesSection.js:
        (WebInspector.ObjectPropertyTreeElement.prototype.update):
        (WebInspector.ObjectPropertyTreeElement.prototype._contextMenuEventFired):
        * inspector/front-end/inspector.js:
        (WebInspector.cancelSearch):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-07 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 7 Feb 2011 11:24:31 +0000 (11:24 +0000)]
2011-02-07  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Relative .. in URL paths shouldn't skip adjacent / characters
        https://bugs.webkit.org/show_bug.cgi?id=53907

        Add some more test cases.

        * fast/url/path-expected.txt:
        * fast/url/script-tests/path.js:
2011-02-07  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Relative .. in URL paths shouldn't skip adjacent / characters
        https://bugs.webkit.org/show_bug.cgi?id=53907

        Our new behavior matches Firefox, Chrome, and IE.

        * platform/KURL.cpp:
        (WebCore::copyPathRemovingDots):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
ossy@webkit.org [Mon, 7 Feb 2011 11:16:32 +0000 (11:16 +0000)]
Unreviewed.

[Qt][WK2] Buildfix after r77794.

       WebKitTestRunner does not block remote resources or complain about them
       https://bugs.webkit.org/show_bug.cgi?id=42139
       <rdar://problem/8183942>

* WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Add missing includepaths.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNot reviewed.
mjs@apple.com [Mon, 7 Feb 2011 11:01:11 +0000 (11:01 +0000)]
Not reviewed.

More bot appeasement.

* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNot reviewed.
mjs@apple.com [Mon, 7 Feb 2011 10:47:21 +0000 (10:47 +0000)]
Not reviewed.

Remove accidental references to directories on my laptop.

* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-07 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Mon, 7 Feb 2011 09:47:00 +0000 (09:47 +0000)]
2011-02-07  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Antti Koivisto.

        WebKitTestRunner does not block remote resources or complain about them
        https://bugs.webkit.org/show_bug.cgi?id=42139
        <rdar://problem/8183942>

        * Configurations/WebCore.xcconfig: Allow WebKitTestRunner to link
        WebCore.
        * WebCore.exp.in: Export a handful of KURL symbols.
2011-02-07  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Antti Koivisto.

        WebKitTestRunner does not block remote resources or complain about them
        https://bugs.webkit.org/show_bug.cgi?id=42139
        <rdar://problem/8183942>

        * platform/mac-wk2/Skipped: Unskip formerly skipped tests.
2011-02-07  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Antti Koivisto.

        WebKitTestRunner does not block remote resources or complain about them
        https://bugs.webkit.org/show_bug.cgi?id=42139
        <rdar://problem/8183942>

        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
        (WTR::InjectedBundlePage::willSendRequestForFrame): Implement the required
        checks (using KURL, to avoid need to invent a whole URL API).
        * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Link WebCore
        directly to get at KURL symbols.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-07 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Mon, 7 Feb 2011 09:31:36 +0000 (09:31 +0000)]
2011-02-07  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Antti Koivisto.

        Add WKURLRequestCopyURL API (needed for tests and also generally useful)
        https://bugs.webkit.org/show_bug.cgi?id=53909

        * Shared/API/c/WKURLRequest.cpp:
        (WKURLRequestCopyURL):
        * Shared/API/c/WKURLRequest.h:
        * Shared/WebURLRequest.h:
        (WebKit::WebURLRequest::url):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNot reviewed.
antti@apple.com [Mon, 7 Feb 2011 08:54:44 +0000 (08:54 +0000)]
Not reviewed.

ASSERTS_DISABLED -> ASSERT_DISABLED

* wtf/BloomFilter.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-06 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Mon, 7 Feb 2011 07:20:52 +0000 (07:20 +0000)]
2011-02-06  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Daniel Bates.

        Add WebKit2 bot to list of expected builders in Python regression test results.
        https://bugs.webkit.org/show_bug.cgi?id=53905

        * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-06 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Mon, 7 Feb 2011 06:49:12 +0000 (06:49 +0000)]
2011-02-06  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Ryosuke Niwa.

        Update test expectations for new core builder
        https://bugs.webkit.org/show_bug.cgi?id=53904

        * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-06 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Mon, 7 Feb 2011 06:20:10 +0000 (06:20 +0000)]
2011-02-06  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by David Levin.

        Add WebKit2 test bot to core builders
        https://bugs.webkit.org/show_bug.cgi?id=53901

        * Scripts/webkitpy/common/net/buildbot/buildbot.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-06 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Mon, 7 Feb 2011 05:47:24 +0000 (05:47 +0000)]
2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>

        Another unreviewed Chromium build fix.

        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::pathToLocalResource):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-06 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Mon, 7 Feb 2011 05:29:37 +0000 (05:29 +0000)]
2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Chromium build fix.

        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::pathToLocalResource):
2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed; speculative Qt build fix.

        * WebKit2.pro:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-06 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Mon, 7 Feb 2011 05:19:01 +0000 (05:19 +0000)]
2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed; speculative Qt build fix.

        * JavaScriptCore.pro:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-06 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Mon, 7 Feb 2011 05:01:30 +0000 (05:01 +0000)]
2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
        https://bugs.webkit.org/show_bug.cgi?id=52867

        * DumpRenderTree/chromium/ImageDiff.cpp:
        (Image::craeteFromStdin): Call adoptArrayPtr.
2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
        https://bugs.webkit.org/show_bug.cgi?id=52867

        Removed LOOSE_OWN_ARRAY_PTR and OwnArrayPtr<T>::set. Replaced all calls to OwnArrayPtr::set
        and loose instantiation of OwnArrayPtr by calls to operator= and adoptArrayPtr. Also removed
        OwnArrayPtrCommon.h since PassOwnArrayPtr.h needs to include OwnArrayPtr.h and there is
        no point in putting deleteOwnedArrayPtr into a separate header.

        Note: if this patch breaks build, the code is either instiantiating OwnArrayPtr
        without calling adoptArrayPtr or calling set on ArrayOwnPtr instead of operator=.

        No tests are added since this is a refactoring.

        * API/JSStringRefCF.cpp:
        (JSStringCreateWithCFString): Calls adoptArrayPtr.
        * GNUmakefile.am: Removed OwnArrayPtrCommon.h
        * JavaScriptCore.vcproj/WTF/WTF.vcproj: Ditto.
        * JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
        * runtime/Arguments.cpp:
        (JSC::Arguments::deleteProperty): Calls adoptArrayPtr.
        * runtime/Arguments.h:
        (JSC::Arguments::copyRegisters): Ditto.
        * runtime/JSPropertyNameIterator.cpp:
        (JSC::JSPropertyNameIterator::JSPropertyNameIterator): Ditto.
        * runtime/JSVariableObject.h:
        (JSC::JSVariableObject::setRegisters): Calls operator= instead of set.
        * runtime/StructureChain.cpp:
        (JSC::StructureChain::StructureChain): Ditto.
        * wtf/CMakeLists.txt:
        * wtf/DateMath.h:
        (JSC::GregorianDateTime::GregorianDateTime): No longer instnatiates OwnArrayPtr
        with a null pointer.
        * wtf/OwnArrayPtr.h:
        * wtf/OwnArrayPtrCommon.h: Removed.
        * wtf/PassOwnArrayPtr.h: No longer includes OwnArrayCommon.h
        (WTF::deleteOwnedArrayPtr): Moved from OwnArrayPtrCommon.h
2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
        https://bugs.webkit.org/show_bug.cgi?id=52867

        * ForwardingHeaders/wtf/OwnArrayPtrCommon.h: Removed.
2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
        https://bugs.webkit.org/show_bug.cgi?id=52867

        * WebHistory.cpp:
        (WebHistory::orderedLastVisitedDays): Calls adoptArrayPtr.
        * WebPreferences.cpp:
        (WebPreferences::copyWebKitPreferencesToCFPreferences): Ditto.
2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
        https://bugs.webkit.org/show_bug.cgi?id=52867

        * ForwardingHeaders/wtf/OwnArrayPtrCommon.h: Removed.
        * bindings/v8/NPV8Object.cpp:
        (WebCore::createValueListFromVariantArgs): Returns PassOwnArrayPtr<v8::Handle<v8::Value>> instead of
        v8::Handle<v8::Value>*.
        (_NPN_Invoke): Calls createValueListFromVariantArgs.
        (_NPN_InvokeDefault): createValueListFromVariantArgs.
        (_NPN_Construct): createValueListFromVariantArgs.
        * bindings/v8/ScriptFunctionCall.cpp:
        (WebCore::ScriptFunctionCall::call): Calls adoptArrayPtr.
        (WebCore::ScriptFunctionCall::construct): Ditto.
        (WebCore::ScriptCallback::call):
        * bindings/v8/V8DOMWindowShell.cpp:
        (WebCore::V8DOMWindowShell::createNewContext): Ditto.
        * bindings/v8/V8NPObject.cpp:
        (WebCore::npObjectInvokeImpl): Ditto
        * bindings/v8/V8NodeFilterCondition.cpp:
        (WebCore::V8NodeFilterCondition::acceptNode): Ditto,
        * html/HTMLAreaElement.cpp:
        (WebCore::HTMLAreaElement::parseMappedAttribute): Calls newCoordsArray.
        * html/HTMLFrameSetElement.cpp:
        (WebCore::HTMLFrameSetElement::parseMappedAttribute): Calls newLengthArray.
        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::getAttachedShaders): Calls adoptArraYptr.
        (WebCore::WebGLRenderingContext::simulateVertexAttrib0): Ditto.
        (WebCore::WebGLRenderingContext::LRUImageBufferCache::LRUImageBufferCache): Dito.
        * platform/Length.cpp:
        (WebCore::newCoordsArray): Returns PassOwnArrayPtr<Length> instead of Length*.
        (WebCore::newLengthArray): Returns PassOwnArrayPtr<Length> instead of Length*.
        * platform/Length.h: Prototype changes.
        * platform/graphics/ANGLEWebKitBridge.cpp:
        (WebCore::ANGLEWebKitBridge::validateShaderSource): Calls adoptArrayPtr.
        * platform/graphics/ca/win/CACFLayerTreeHost.cpp:
        (WebCore::getDirtyRects): Ditto.
        * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
        (WebCore::ComplexTextController::getNormalizedTextRun): Ditto.
        * platform/graphics/chromium/HarfbuzzSkia.cpp:
        (WebCore::glyphsToAdvances): Ditto.
        (WebCore::canRender): Ditto.
        * platform/graphics/gpu/Texture.cpp:
        (WebCore::Texture::updateSubRect): Ditto.
        * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
        (WebCore::GraphicsContext3D::paintRenderingResultsToCanvas): Ditto.
        * platform/graphics/skia/PlatformContextSkia.cpp:
        (WebCore::PlatformContextSkia::readbackHardwareToSoftware): Ditto.
        * platform/graphics/wince/SharedBitmap.cpp:
        (WebCore::SharedBitmap::to16bit): Ditto.
        * platform/win/ContextMenuWin.cpp:
        (WebCore::ContextMenu::getContextMenuItems): Ditto.
        * platform/win/LoggingWin.cpp:
        (WebCore::initializeWithUserDefault): Ditto.
        * plugins/win/PluginPackageWin.cpp:
        (WebCore::PluginPackage::fetchInfo): Ditto.
2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
        https://bugs.webkit.org/show_bug.cgi?id=52867

        * Shared/Plugins/Netscape/win/NetscapePluginModuleWin.cpp:
        (WebKit::NetscapePluginModule::getPluginInfo): Calls adoptArrayPtr.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-06 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Mon, 7 Feb 2011 04:54:42 +0000 (04:54 +0000)]
2011-02-06  Kent Tamura  <tkent@chromium.org>

        Unreviewed.

        * WebCore.xcodeproj/project.pbxproj: Run sort-xcode-project-file.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-06 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Mon, 7 Feb 2011 04:08:54 +0000 (04:08 +0000)]
2011-02-06  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Martin Robinson.

        [WINCE] FrameLoaderClient calls loadURLInChildFrame on the child's frame loader
        https://bugs.webkit.org/show_bug.cgi?id=53896

        * WebView.cpp:
        (WebView::createFrame): Use coreFrame instead of childFrame.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-06 MORITA Hajime <morrita@google.com>
morrita@google.com [Mon, 7 Feb 2011 02:20:27 +0000 (02:20 +0000)]
2011-02-06  MORITA Hajime  <morrita@google.com>

        Unreviewed, unskip the html5lib test again which fails for another reason. (See Bug 53030)

        * platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-06 Dominic Cooney <dominicc@google.com>
morrita@google.com [Mon, 7 Feb 2011 01:40:17 +0000 (01:40 +0000)]
2011-02-06  Dominic Cooney  <dominicc@google.com>

        Reviewed by Dimitri Glazkov.

        Convert <keygen> option elements to a shadow DOM
        https://bugs.webkit.org/show_bug.cgi?id=51379

        * html5lib/runner-expected.txt: Two more tests pass.
        * platform/mac/fast/html/keygen-expected.txt: Shadow render tree.
        * platform/mac/fast/invalid/residual-style-expected.txt:
2011-02-03  Dominic Cooney  <dominicc@google.com>

        Reviewed by Dimitri Glazkov.

        Convert <keygen> option elements to a shadow DOM
        https://bugs.webkit.org/show_bug.cgi?id=51379

        Covered by existing tests e.g. fast/html/keygen.html,
        html5lib/runner.html, etc.

        * css/html.css:
        (form): Cleanup.
        (keygen, select): Border radii should match so focus ring looks good.
        (keygen::-webkit-keygen-select): No margin on the shadow element.
        (select): Hoisting border radius to keygen, select rule.
        * dom/SelectElement.cpp:
        (WebCore::toSelectElement): keygen is no longer a select element.
        * html/HTMLKeygenElement.cpp: Implements keygen shadow.
        (WebCore::KeygenSelectElement::create):
        (WebCore::KeygenSelectElement::shadowPseudoId):
        (WebCore::KeygenSelectElement::KeygenSelectElement):
        (WebCore::HTMLKeygenElement::HTMLKeygenElement):
        (WebCore::HTMLKeygenElement::parseMappedAttribute):
        (WebCore::HTMLKeygenElement::appendFormData):
        (WebCore::HTMLKeygenElement::formControlType):
        (WebCore::HTMLKeygenElement::reset):
        (WebCore::HTMLKeygenElement::selectShadow):
        * html/HTMLKeygenElement.h: keygen is no longer a select on C++ side.
        (WebCore::HTMLKeygenElement::canStartSelection):
        (WebCore::HTMLKeygenElement::isEnumeratable):
        (WebCore::HTMLKeygenElement::isResettable):
        * html/HTMLOptionElement.cpp:
        (WebCore::HTMLOptionElement::ownerSelectElement): Only owned by selects.
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::HTMLSelectElement): Only 'select' tag name.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-06 James Kozianski <koz@chromium.org>
commit-queue@webkit.org [Mon, 7 Feb 2011 01:00:53 +0000 (01:00 +0000)]
2011-02-06  James Kozianski  <koz@chromium.org>

        Reviewed by Ojan Vafai.

        Add classes for representing test outputs.
        https://bugs.webkit.org/show_bug.cgi?id=52136

        These classes will make it easier to write scripts that deal with test
        outputs such as rebaselining and deduping scripts. The intent is that
        eventually we will be have buildbot return TestOutputs for a
        particular build which can be compared with TestOutputs derived from a
        local LayoutTests directory.

        * Scripts/webkitpy/common/net/testoutput.py: Added.
        * Scripts/webkitpy/common/net/testoutput_unittest.py: Added.
        * Scripts/webkitpy/common/net/testoutputset.py: Added.
        * Scripts/webkitpy/common/net/testoutputset_unittest.py: Added.
        * Scripts/webkitpy/common/system/zip_mock.py: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-06 Benjamin Poulain <ikipou@gmail.com>
commit-queue@webkit.org [Sun, 6 Feb 2011 23:48:37 +0000 (23:48 +0000)]
2011-02-06  Benjamin Poulain  <ikipou@gmail.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Fix coding style errors in ClipboardQt.h
        https://bugs.webkit.org/show_bug.cgi?id=43520

        Fix coding style: order of header and indentation.

        * platform/qt/ClipboardQt.h:
        (WebCore::ClipboardQt::create):
        (WebCore::ClipboardQt::clipboardData):
        (WebCore::ClipboardQt::invalidateWritableData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-06 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sun, 6 Feb 2011 22:16:54 +0000 (22:16 +0000)]
2011-02-06  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Oliver Hunt.

        Remove empty svg test
        https://bugs.webkit.org/show_bug.cgi?id=53887

        This files are empty.  Empty tests are pretty useless.

        * platform/chromium-win/svg/custom/use-infinite-recursion-expected.png: Removed.
        * platform/mac/svg/custom/use-infinite-recursion-expected.checksum: Removed.
        * platform/mac/svg/custom/use-infinite-recursion-expected.png: Removed.
        * platform/mac/svg/custom/use-infinite-recursion-expected.txt: Removed.
        * platform/qt/svg/custom/use-infinite-recursion-expected.txt: Removed.
        * svg/custom/use-infinite-recursion.svg: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUse bloom filter for descendant selector filtering
antti@apple.com [Sun, 6 Feb 2011 20:43:41 +0000 (20:43 +0000)]
Use bloom filter for descendant selector filtering
https://bugs.webkit.org/show_bug.cgi?id=53880

Reviewed by Maciej Stachowiak.

Source/JavaScriptCore:

Implement a bloom filter with k=2 and 8 bit counting.

* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/BloomFilter.h: Added.
(WTF::BloomFilter::maximumCount):
(WTF::BloomFilter::BloomFilter):
(WTF::BloomFilter::mayContain):
(WTF::BloomFilter::add):
(WTF::BloomFilter::remove):
(WTF::BloomFilter::firstSlot):
(WTF::BloomFilter::secondSlot):
(WTF::::add):
(WTF::::remove):
(WTF::::clear):
(WTF::::likelyEmpty):
(WTF::::isClear):

Source/WebCore:

Bloom filter is faster than a hash set in this kind of use.

Shark thinks this speeds up style matching by ~30% on sites
with lots of descendant selectors.

* ForwardingHeaders/wtf/BloomFilter.h: Added.
* css/CSSStyleSelector.cpp:
(WebCore::collectElementIdentifierHashes):
(WebCore::CSSStyleSelector::pushParent):
(WebCore::CSSStyleSelector::popParent):
(WebCore::CSSStyleSelector::fastRejectSelector):
(WebCore::RuleData::collectDescendantSelectorIdentifierHashes):
* css/CSSStyleSelector.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-06 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Sun, 6 Feb 2011 20:05:38 +0000 (20:05 +0000)]
2011-02-06  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Antti Koivisto.

        media/video-document-types.html sometimes crashes the WebProcess
        https://bugs.webkit.org/show_bug.cgi?id=53884

        No new tests. Already covered by media/video-document-types.html

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::userCancelledLoad): Stop the load timer
        when cancelling the load.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-06 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sun, 6 Feb 2011 18:52:58 +0000 (18:52 +0000)]
2011-02-06  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Roben.

        [WIN] Use WCHAR instead of TCHAR
        https://bugs.webkit.org/show_bug.cgi?id=53863

        We always use the UNICODE versions of windows functions, so
        the usage of TCHAR makes no sense and mixing them is bad style.

        * platform/graphics/win/IconWin.cpp:
        (WebCore::Icon::createIconForFiles):
        * platform/graphics/win/QTMovie.cpp:
        * platform/graphics/win/QTMovieGWorld.cpp:
        (QTMovieGWorld::fullscreenWndProc):
        (QTMovieGWorld::enterFullscreen):
        * platform/graphics/win/SimpleFontDataCGWin.cpp:
        (WebCore::SimpleFontData::platformInit):
        * platform/graphics/win/SimpleFontDataCairoWin.cpp:
        * platform/graphics/win/SimpleFontDataWin.cpp:
        * platform/graphics/wince/SimpleFontDataWinCE.cpp:
        * platform/win/BString.cpp:
        * platform/win/ClipboardWin.cpp:
        (WebCore::filesystemPathFromUrlOrTitle):
        (WebCore::createGlobalHDropContent):
        (WebCore::createGlobalImageFileDescriptor):
        * platform/win/ContextMenuWin.cpp:
        * platform/win/CursorWin.cpp:
        (WebCore::loadSharedCursor):
        * platform/win/FileChooserWin.cpp:
        (WebCore::FileChooser::basenameForWidth):
        * platform/win/PopupMenuWin.cpp:
        (WebCore::PopupMenuWin::popupClassName):
        (WebCore::PopupMenuWin::show):
        * platform/win/PopupMenuWin.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-06 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sun, 6 Feb 2011 18:44:24 +0000 (18:44 +0000)]
2011-02-06  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Andreas Kling.

        Replace FLT_MAX with std::numeric_limits
        https://bugs.webkit.org/show_bug.cgi?id=53861

        Also move EFL's userIdleTime from TemporaryLinkStubs into SystemTimeEfl.

        * html/NumberInputType.cpp:
        * html/parser/HTMLParserIdioms.cpp:
        (WebCore::parseToDoubleForNumberType):
        * platform/brew/SystemTimeBrew.cpp:
        (WebCore::userIdleTime):
        * platform/efl/SystemTimeEfl.cpp:
        (WebCore::userIdleTime):
        * platform/efl/TemporaryLinkStubs.cpp:
        * platform/graphics/ca/GraphicsLayerCA.cpp:
        (WebCore::GraphicsLayerCA::setupAnimation):
        * platform/win/SystemTimeWin.cpp:
        (WebCore::userIdleTime):
        * platform/wx/SystemTimeWx.cpp:
        (WebCore::userIdleTime):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-06 Robert Hogan <robert@webkit.org>
robert@webkit.org [Sun, 6 Feb 2011 18:31:38 +0000 (18:31 +0000)]
2011-02-06  Robert Hogan  <robert@webkit.org>

        Reviewed by Andreas Kling.

        [Qt] Remove unnecessary QRect assignment
        https://bugs.webkit.org/show_bug.cgi?id=53873

        * Api/qwebframe.cpp:
        (QWebFramePrivate::renderRelativeCoords):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-06 Robert Hogan <robert@webkit.org>
robert@webkit.org [Sun, 6 Feb 2011 18:18:35 +0000 (18:18 +0000)]
2011-02-06  Robert Hogan  <robert@webkit.org>

        Reviewed by Andreas Kling.

        [Qt] Clear page's groupName even when not in DRT
        https://bugs.webkit.org/show_bug.cgi?id=53874

        Matches behaviour of other ports.

        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::closeWindowSoon):
2011-02-06  Robert Hogan  <robert@webkit.org>

        Reviewed by Andreas Kling.

        [Qt] Clear page's groupName even when not in DRT
        https://bugs.webkit.org/show_bug.cgi?id=53874

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::DumpRenderTree::windowCloseRequested):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-06 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sun, 6 Feb 2011 17:47:14 +0000 (17:47 +0000)]
2011-02-06  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Andreas Kling.

        [CMake] Add dependencies for Visual Studio projects
        https://bugs.webkit.org/show_bug.cgi?id=53773

        Add a JavaScriptCore dependecy to WebCore, so CMake can
        generate the correct build order for the solution.

        * CMakeLists.txt:
2011-02-06  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Andreas Kling.

        [CMake] Add dependencies for Visual Studio projects
        https://bugs.webkit.org/show_bug.cgi?id=53773

        Add a WebCore dependecy to WebKit, so CMake can
        generate the correct build order for the solution.

        Remove JavaScriptCore dependecy, since WebCore already depends on it.

        * CMakeLists.txt:
2011-02-06  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Andreas Kling.

        [CMake] Add dependencies for Visual Studio projects
        https://bugs.webkit.org/show_bug.cgi?id=53773

        Add a WebKit dependecy to WinCELauncher, so CMake can
        generate the correct build order for the solution.

        * CMakeListsWinCE.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-06 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sun, 6 Feb 2011 17:14:22 +0000 (17:14 +0000)]
2011-02-06  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Andreas Kling.

        [CMake] Unify ENABLE_SVG sections
        https://bugs.webkit.org/show_bug.cgi?id=53778

        * CMakeLists.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-06 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Sun, 6 Feb 2011 17:08:32 +0000 (17:08 +0000)]
2011-02-06  Martin Robinson  <mrobinson@igalia.com>

        Reclassify a failing test and unskip another which should be passing now.

        * platform/gtk/Skipped: Update the skipped list.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-06 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Sun, 6 Feb 2011 16:22:23 +0000 (16:22 +0000)]
2011-02-06  Andreas Kling  <kling@webkit.org>

        Reviewed by Dirk Schulze.

        Refactor Font::normalizeSpaces() to avoid an extra String copy.
        https://bugs.webkit.org/show_bug.cgi?id=53871

        Have normalizeSpaces() take UChar*,length arguments instead of a
        String, since all call sites were creating temporaries from these
        components anyway.

        Font::normalizeSpaces() now always makes 1 String copy,
        instead of 1 in the best case and 2 in the worst case.

        * platform/graphics/Font.cpp:
        (WebCore::Font::normalizeSpaces):
        * platform/graphics/Font.h:
        * platform/graphics/qt/FontQt.cpp:
        (WebCore::drawTextCommon):
        (WebCore::Font::floatWidthForSimpleText):
        (WebCore::Font::floatWidthForComplexText):
        (WebCore::Font::offsetForPositionForSimpleText):
        (WebCore::Font::offsetForPositionForComplexText):
        (WebCore::Font::selectionRectForSimpleText):
        (WebCore::Font::selectionRectForComplexText):
        * svg/SVGFont.cpp:
        (WebCore::SVGTextRunWalker::walk):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-06 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Sun, 6 Feb 2011 15:19:26 +0000 (15:19 +0000)]
2011-02-06  Andreas Kling  <kling@webkit.org>

        Reviewed by Antonio Gomes.

        [Qt] MiniBrowser: Clean up handling of titleChanged() signal
        https://bugs.webkit.org/show_bug.cgi?id=53869

        * MiniBrowser/qt/BrowserView.cpp:
        (BrowserView::BrowserView): Remove unnecessary titleChanged() handling.
        * MiniBrowser/qt/BrowserWindow.cpp:
        (BrowserWindow::BrowserWindow): Connect titleChanged() directly to setWindowTitle().
        * MiniBrowser/qt/BrowserWindow.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-06 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Sun, 6 Feb 2011 14:35:42 +0000 (14:35 +0000)]
2011-02-06  Andreas Kling  <kling@webkit.org>

        Reviewed by Dirk Schulze.

        Fix potential buffer overrun in SVGTextRunWalker::walk()
        https://bugs.webkit.org/show_bug.cgi?id=53870

        A new String was created from a UChar* with a 'length' argument
        that could be greater than the number of UChars available.

        * svg/SVGFont.cpp:
        (WebCore::SVGTextRunWalker::walk):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-06 Benjamin Poulain <ikipou@gmail.com>
commit-queue@webkit.org [Sun, 6 Feb 2011 13:23:53 +0000 (13:23 +0000)]
2011-02-06  Benjamin Poulain  <ikipou@gmail.com>

        Reviewed by Andreas Kling.

        [Qt] WebKit does not build on Mac with WebKit 2
        https://bugs.webkit.org/show_bug.cgi?id=53380

        * Platform/CoreIPC/qt/ConnectionQt.cpp: Use fcntl() to set close on exec so
        we do not rely on recent kernel.
        (CoreIPC::Connection::readyReadHandler):
        * Platform/qt/SharedMemoryQt.cpp: ditto
        (WebKit::SharedMemory::create):
        (WebKit::SharedMemory::createHandle):
        * UIProcess/Launcher/qt/ProcessLauncherQt.cpp: Guard prctl() since it is
        a Linux specific function.
        (WebKit::QtWebProcess::setupChildProcess):
        * UIProcess/DrawingAreaProxy.h: Differentiate between building on Mac
        and the Mac port.
        * UIProcess/DrawingAreaProxyImpl.cpp: ditto
        * UIProcess/WebPageProxy.cpp: ditto
        (WebKit::WebPageProxy::didReceiveMessage):
        * WebProcess/WebPage/DrawingArea.cpp: ditto
        (WebKit::DrawingArea::create):
        * WebProcess/WebPage/DrawingArea.h:
        * WebProcess/WebPage/DrawingAreaImpl.cpp: ditto
        * WebProcess/WebPage/WebPage.cpp: ditto
        (WebKit::WebPage::didReceiveMessage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-06 Robert Hogan <robert@webkit.org>
robert@webkit.org [Sun, 6 Feb 2011 10:46:45 +0000 (10:46 +0000)]
2011-02-06  Robert Hogan  <robert@webkit.org>

        Unreviewed, skip failing test on Qt bot.

        [Qt]  fast/notifications/notifications-document-close-crash.html fails after r77738
        https://bugs.webkit.org/show_bug.cgi?id=53868

        * platform/qt/Skipped: Skip fast/notifications/notifications-document-close-crash.html

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-06 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Sun, 6 Feb 2011 10:35:28 +0000 (10:35 +0000)]
2011-02-06  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Dan Bernstein.

        WebKitTestRunner needs layoutTestController.setWillSendRequestReturnsNull
        https://bugs.webkit.org/show_bug.cgi?id=42690
        <rdar://problem/8213851>

        * platform/mac-wk2/Skipped: Unskip tests that now pass, except for the ones that
        mysteriously fail.
2011-02-06  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Dan Bernstein.

        WebKitTestRunner needs layoutTestController.setWillSendRequestReturnsNull
        https://bugs.webkit.org/show_bug.cgi?id=42690
        <rdar://problem/8213851>

        * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
        (WTR::InjectedBundlePage::willSendRequestForFrame):
        * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
        (WTR::LayoutTestController::LayoutTestController):
        * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
        (WTR::LayoutTestController::willSendRequestReturnsNull):
        (WTR::LayoutTestController::setWillSendRequestReturnsNull):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-05 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Sun, 6 Feb 2011 05:24:27 +0000 (05:24 +0000)]
2011-02-05  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Dan Bernstein.

        REGRESSION: New drawing area is causing some WebProcess crashes in layout tests
        https://bugs.webkit.org/show_bug.cgi?id=53865
        <rdar://problem/8963148>

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode): Handle the case
        where this is called repeatedly without exiting accelerated composting mode
        first.
        (WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode): Handle the case
        of being called more than once.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-05 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Sun, 6 Feb 2011 05:05:45 +0000 (05:05 +0000)]
2011-02-05  Dimitri Glazkov  <dglazkov@chromium.org>

        [Chromium] Add baselines for the test added in r77690.

        * platform/chromium-mac/media/video-frame-accurate-seek-expected.checksum: Added.
        * platform/chromium-mac/media/video-frame-accurate-seek-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-05 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Sun, 6 Feb 2011 02:58:46 +0000 (02:58 +0000)]
2011-02-05  Dimitri Glazkov  <dglazkov@chromium.org>

        Remove passing canvas tests from expectations.

        * platform/chromium/test_expectations.txt: Removed passing tests.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77757 268f45cc-cd09-0410-ab3c-d52691b4dbfc