WebKit.git
7 years agoChange JSEventListener::m_jsFunction to be a weak ref.
mark.lam@apple.com [Thu, 15 Nov 2012 01:01:41 +0000 (01:01 +0000)]
Change JSEventListener::m_jsFunction to be a weak ref.
https://bugs.webkit.org/show_bug.cgi?id=101989.

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Added infrastructure for scanning weak ref slots.

* heap/SlotVisitor.cpp: Added #include "SlotVisitorInlines.h".
* heap/SlotVisitor.h:
(SlotVisitor): Added SlotVisitor::appendUnbarrieredWeak().
* heap/SlotVisitorInlines.h: Added #include "Weak.h".
(JSC::SlotVisitor::appendUnbarrieredWeak): Added.
* heap/Weak.h:
(JSC::operator==): Added operator==() for Weak.
* runtime/JSCell.h: Removed #include "SlotVisitorInlines.h".
* runtime/JSObject.h: Added #include "SlotVisitorInlines.h".

Source/WebCore:

No new tests.

* ForwardingHeaders/heap/SlotVisitor.h: Added.
* bindings/js/JSDOMBinding.h: Added #include <heap/SlotVisitor.h>
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::JSEventListener):
(WebCore::JSEventListener::visitJSFunction):
(WebCore::JSEventListener::operator==):
 - Removed the m_wrapper checks in operator==() because they are not
   needed. There is no longer any threat of m_jsFunction pointing to
   recycled memory. The use of weak refs will ensure that m_jsFunction
   is either still holding on to its old memory exclusively, or is 0'ed
   out when the GC collects it.
* bindings/js/JSEventListener.h:
(JSEventListener):
(WebCore::JSEventListener::jsFunction):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Rename dispatchWrap
commit-queue@webkit.org [Thu, 15 Nov 2012 00:58:13 +0000 (00:58 +0000)]
[V8] Rename dispatchWrap
https://bugs.webkit.org/show_bug.cgi?id=102240

Patch by Dan Carney <dcarney@google.com> on 2012-11-14
Reviewed by Adam Barth.

Mostly a rename:
dispatchWrap->wrap
wrapSlow->createWrapper
dispatchWrapCustom->wrap

No new tests. No change in functionality.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateNormalAttrGetter):
(GenerateImplementation):
(GenerateToV8Converters):
* bindings/scripts/IDLAttributes.txt:
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::wrap):
(WebCore::V8Float64Array::createWrapper):
* bindings/scripts/test/V8/V8Float64Array.h:
(V8Float64Array):
(WebCore):
(WebCore::toV8Object):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::createWrapper):
* bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(V8TestActiveDOMObject):
(WebCore::wrap):
(WebCore::toV8Object):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::createWrapper):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(V8TestCustomNamedGetter):
(WebCore::wrap):
(WebCore::toV8Object):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::createWrapper):
* bindings/scripts/test/V8/V8TestEventConstructor.h:
(V8TestEventConstructor):
(WebCore::wrap):
(WebCore::toV8Object):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::createWrapper):
* bindings/scripts/test/V8/V8TestEventTarget.h:
(V8TestEventTarget):
(WebCore::wrap):
(WebCore::toV8Object):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::V8TestException::createWrapper):
* bindings/scripts/test/V8/V8TestException.h:
(V8TestException):
(WebCore::wrap):
(WebCore::toV8Object):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::createWrapper):
* bindings/scripts/test/V8/V8TestInterface.h:
(V8TestInterface):
(WebCore::wrap):
(WebCore::toV8Object):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::createWrapper):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(V8TestMediaQueryListListener):
(WebCore::wrap):
(WebCore::toV8Object):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::createWrapper):
* bindings/scripts/test/V8/V8TestNamedConstructor.h:
(V8TestNamedConstructor):
(WebCore::wrap):
(WebCore::toV8Object):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::createWrapper):
* bindings/scripts/test/V8/V8TestNode.h:
(V8TestNode):
(WebCore::wrap):
(WebCore::toV8Object):
(WebCore::toV8):
(WebCore::toV8Fast):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::createWrapper):
* bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
(WebCore::wrap):
(WebCore::toV8Object):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::V8TestOverloadedConstructors::createWrapper):
* bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
(V8TestOverloadedConstructors):
(WebCore::wrap):
(WebCore::toV8Object):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::createWrapper):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(V8TestSerializedScriptValueInterface):
(WebCore::wrap):
(WebCore::toV8Object):
(WebCore::toV8):
* bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::wrap):
* bindings/v8/custom/V8CSSRuleCustom.cpp:
(WebCore::wrap):
* bindings/v8/custom/V8CSSValueCustom.cpp:
(WebCore::wrap):
* bindings/v8/custom/V8CanvasRenderingContextCustom.cpp:
(WebCore::wrap):
* bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore::wrap):
* bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::wrap):
* bindings/v8/custom/V8ElementCustom.cpp:
(WebCore):
(WebCore::wrap):
* bindings/v8/custom/V8EntryCustom.cpp:
(WebCore::wrap):
* bindings/v8/custom/V8EntrySyncCustom.cpp:
(WebCore::wrap):
* bindings/v8/custom/V8EventCustom.cpp:
(WebCore):
(WebCore::wrap):
* bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::wrap):
* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::wrap):
* bindings/v8/custom/V8HTMLElementCustom.cpp:
(WebCore::wrap):
* bindings/v8/custom/V8ImageDataCustom.cpp:
(WebCore::wrap):
* bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::wrap):
* bindings/v8/custom/V8PerformanceEntryCustom.cpp:
(WebCore::wrap):
* bindings/v8/custom/V8SVGDocumentCustom.cpp:
(WebCore::wrap):
* bindings/v8/custom/V8SVGElementCustom.cpp:
(WebCore::wrap):
* bindings/v8/custom/V8SVGPathSegCustom.cpp:
(WebCore::wrap):
* bindings/v8/custom/V8StyleSheetCustom.cpp:
(WebCore::wrap):
* dom/make_names.pl:
(printWrapperFunctions):
(printWrapperFactoryCppFile):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRead-only properties created with putDirect() should tell the structure that there...
fpizlo@apple.com [Thu, 15 Nov 2012 00:50:41 +0000 (00:50 +0000)]
Read-only properties created with putDirect() should tell the structure that there are read-only properties
https://bugs.webkit.org/show_bug.cgi?id=102292

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

This mostly affects things like function.length.

* runtime/JSObject.h:
(JSC::JSObject::putDirectInternal):

LayoutTests:

* fast/js/function-dot-length-read-only-expected.txt: Added.
* fast/js/function-dot-length-read-only.html: Added.
* fast/js/jsc-test-list:
* fast/js/script-tests/function-dot-length-read-only.js: Added.
(foo):
(Bar):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Refactor theme to choose whether to support foreground color of selection
commit-queue@webkit.org [Thu, 15 Nov 2012 00:49:59 +0000 (00:49 +0000)]
[EFL] Refactor theme to choose whether to support foreground color of selection
https://bugs.webkit.org/show_bug.cgi?id=102037

Patch by Ryuan Choi <ryuan.choi@gmail.com> on 2012-11-14
Reviewed by Gyuyoung Kim.

Source/WebCore:

RenderThemeEfl can change foreground color of selection using theme file.
But it can not disable supports of foreground color to keep the text color
which is selected.

This patch refactors color classes of theme file from active/inactive classes
to foreground/background classes so that RenderThemeEfl checks whether
theme file supports foreground color class.

* platform/efl/RenderThemeEfl.cpp:
(WebCore::fillColorsFromEdjeClass):
(WebCore::RenderThemeEfl::setColorFromThemeClass):
(WebCore::RenderThemeEfl::loadTheme):
(WebCore::RenderThemeEfl::RenderThemeEfl):
(WebCore::RenderThemeEfl::supportsSelectionForegroundColors):
(WebCore):
* platform/efl/RenderThemeEfl.h:
(RenderThemeEfl):

Source/WebKit/efl:

* DefaultTheme/default.edc:
Refactored color classes from active/inactive to foreground/background.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoConvert m_selectorVector back to a stack allocated m_reusableSelectorVector
tony@chromium.org [Thu, 15 Nov 2012 00:48:05 +0000 (00:48 +0000)]
Convert m_selectorVector back to a stack allocated m_reusableSelectorVector
https://bugs.webkit.org/show_bug.cgi?id=102295

Reviewed by Andreas Kling.

Revert r125252 because we're not going to go forward with implementing CSS hierarchies at this time.

No new tests because there should be no change in behavior.

* css/CSSGrammar.y.in:
* css/CSSParser.cpp:
(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseColor):
(WebCore::CSSParser::parseDeclaration):
(WebCore):
(WebCore::filterProperties):
(WebCore::CSSParser::createStylePropertySet):
(WebCore::CSSParser::addProperty):
(WebCore::CSSParser::rollbackLastProperties):
(WebCore::CSSParser::clearProperties):
(WebCore::CSSParser::parse4Values):
(WebCore::CSSParser::parseFlowThread):
(WebCore::CSSParser::addTextDecorationProperty):
(WebCore::CSSParser::createFloatingSelectorVector):
(WebCore::CSSParser::sinkFloatingSelectorVector):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::setReusableRegionSelectorVector):
(WebCore::CSSParser::startDeclarationsForMarginBox):
(WebCore::CSSParser::endDeclarationsForMarginBox):
(WebCore::CSSParser::deleteFontFaceOnlyValues):
* css/CSSParser.h:
(WebCore::CSSParser::hasProperties):
(WebCore::CSSParser::reusableSelectorVector):
(CSSParser):
(WebCore::CSSParser::reusableRegionSelectorVector):
* css/CSSParserValues.cpp:
(WebCore::CSSParserSelector::adoptSelectorVector):
* css/CSSParserValues.h:
(CSSParserSelector):
* css/CSSSelectorList.cpp:
(WebCore::CSSSelectorList::adoptSelectorVector):
* css/CSSSelectorList.h:
(CSSSelectorList):
* css/SVGCSSParser.cpp:
(WebCore::CSSParser::parseSVGValue):
* css/StyleRule.cpp:
(WebCore::StyleRuleRegion::StyleRuleRegion):
* css/StyleRule.h:
(WebCore::StyleRule::parserAdoptSelectorVector):
(WebCore::StyleRulePage::parserAdoptSelectorVector):
(WebCore::StyleRuleRegion::create):
(StyleRuleRegion):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] WebPreferences reset() should set perTilePainting and acceleratedAnimation...
danakj@chromium.org [Thu, 15 Nov 2012 00:43:27 +0000 (00:43 +0000)]
[chromium] WebPreferences reset() should set perTilePainting and acceleratedAnimation settings to false.
https://bugs.webkit.org/show_bug.cgi?id=102296

Reviewed by James Robinson.

These settings are always set by TestShell anyhow, but we should be
setting them to false here along with everything else.

* DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::reset):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd tests for explicit serialization values
alecflett@chromium.org [Thu, 15 Nov 2012 00:34:38 +0000 (00:34 +0000)]
Add tests for explicit serialization values
https://bugs.webkit.org/show_bug.cgi?id=96818

Reviewed by Adam Barth.

Source/WebCore:

Expose direct access to the serialization/deserialization mechanisms
of SerializedScriptValue to DumpRenderTree.

* testing/Internals.cpp:
(WebCore::Internals::serializeObject):
(WebCore):
(WebCore::Internals::deserializeBuffer):
* testing/Internals.h:
(WebCore):
* testing/Internals.idl:

LayoutTests:

Make sure SerializedScriptValues are backward compatible with future changes.

* platform/chromium/fast/storage/serialized-script-value.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCoordinated Graphics: Remove unused members and methods in CoordinatedGraphicsLayer.
commit-queue@webkit.org [Thu, 15 Nov 2012 00:29:20 +0000 (00:29 +0000)]
Coordinated Graphics: Remove unused members and methods in CoordinatedGraphicsLayer.
https://bugs.webkit.org/show_bug.cgi?id=102172

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-14
Reviewed by Noam Rosenthal.

* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Add clear() method to JSC ScriptValue
commit-queue@webkit.org [Thu, 15 Nov 2012 00:23:55 +0000 (00:23 +0000)]
IndexedDB: Add clear() method to JSC ScriptValue
https://bugs.webkit.org/show_bug.cgi?id=102288

Patch by Michael Pruett <michael@68k.org> on 2012-11-14
Reviewed by Kentaro Hara.

IndexedDB uses the ScriptValue::clear() method, which existed
previously only in the V8 implementation of ScriptValue. This
change is necessary to implement IndexedDB for JSC.

Tests: storage/indexeddb/*

* bindings/js/ScriptValue.h:
(WebCore::ScriptValue::clear):
(ScriptValue):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Marked more virtual/deferred/fast/images as failing.
dglazkov@chromium.org [Thu, 15 Nov 2012 00:19:01 +0000 (00:19 +0000)]
[Chromium] Marked more virtual/deferred/fast/images as failing.
https://bugs.webkit.org/show_bug.cgi?id=102294

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove loading responsibility out of WebResourceLoadScheduler into a new WebResourceLoader
beidson@apple.com [Wed, 14 Nov 2012 23:59:01 +0000 (23:59 +0000)]
Move loading responsibility out of WebResourceLoadScheduler into a new WebResourceLoader
https://bugs.webkit.org/show_bug.cgi?id=102259

Reviewed by Alexey Proskuryakov.

Add a new WebResourceLoader message class which allows NetworkResourceLoader to message
WebResourceLoaders directly.

Consolidate the NetworkProcessConnection and WebResourceLoadScheduler messaging responsibilities
directly into WebResourceLoader.

Build-system infrastructure stuff:
* DerivedSources.make:
* Platform/CoreIPC/MessageID.h:
* WebKit2.xcodeproj/project.pbxproj:

Message directly to WebResourceLoader instead of NetworkProcessConnection:
* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::connection):
(WebKit::NetworkResourceLoader::didReceiveResponse):
(WebKit::NetworkResourceLoader::didReceiveData):
(WebKit::NetworkResourceLoader::didFinishLoading):
(WebKit::NetworkResourceLoader::didFail):
(WebKit::NetworkResourceLoader::willSendRequest):
* NetworkProcess/NetworkResourceLoader.h:
(WebKit::NetworkResourceLoader::destinationID):

For now handle the only relevant message class which is the WebResourceLoader class:
* WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::didReceiveMessage):
* WebProcess/Network/NetworkProcessConnection.h:
* WebProcess/Network/NetworkProcessConnection.messages.in:

Allow access to WebResourceLoaders by identifier:
* WebProcess/Network/WebResourceLoadScheduler.cpp:
* WebProcess/Network/WebResourceLoadScheduler.h:
(WebKit::WebResourceLoadScheduler::webResourceLoaderForIdentifier):

Directly handle resource loading messages instead of having WebResourceLoadScheduler do it:
* WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::willSendRequest):
(WebKit::WebResourceLoader::didReceiveResponse):
(WebKit::WebResourceLoader::didReceiveData):
(WebKit::WebResourceLoader::didFinishResourceLoad):
(WebKit::WebResourceLoader::didFailResourceLoad):
(WebKit::WebResourceLoader::didReceiveResource):
* WebProcess/Network/WebResourceLoader.h:
* WebProcess/Network/WebResourceLoader.messages.in:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix the Lion build after r134681.
aestes@apple.com [Wed, 14 Nov 2012 23:56:13 +0000 (23:56 +0000)]
Fix the Lion build after r134681.

* WebProcess/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Indexing tests are flaky-crashing
jsbell@chromium.org [Wed, 14 Nov 2012 23:52:06 +0000 (23:52 +0000)]
IndexedDB: Indexing tests are flaky-crashing
https://bugs.webkit.org/show_bug.cgi?id=102283

Reviewed by Tony Chang.

Don't commit the transaction if there are outstanding pre-emptive events
from indexing operations.

Speculative fix for the flakiness.

* Modules/indexeddb/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::taskEventTimerFired):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Marked platform/chromium/virtual/deferred/fast/images/exif-orientation...
dglazkov@chromium.org [Wed, 14 Nov 2012 23:43:25 +0000 (23:43 +0000)]
[Chromium] Marked platform/chromium/virtual/deferred/fast/images/exif-orientation.html as failing.
https://bugs.webkit.org/show_bug.cgi?id=102294

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in flexbox when removing absolutely positioned children
tony@chromium.org [Wed, 14 Nov 2012 23:36:04 +0000 (23:36 +0000)]
Crash in flexbox when removing absolutely positioned children
https://bugs.webkit.org/show_bug.cgi?id=100465

Reviewed by Ojan Vafai.

Source/WebCore:

We use m_numberOfChildrenOnFirstLine when computing baseline alignment.
This value gets set during flexbox layout. When we remove an absolutely
positioned child, we don't relayout and this value would get stale.

Change m_numberOfChildrenOnFirstLine to m_numberOfInFlowChildrenOnFirstLine
so the value doesn't get stale when we remove absolutely positioned children.
Also change the loop in firstLineBoxBaseline to bail if we run off the end of
the iterator.

Test: css3/flexbox/crash-removing-out-of-flow-child.html

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::RenderFlexibleBox):
(WebCore::RenderFlexibleBox::firstLineBoxBaseline):
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::repositionLogicalHeightDependentFlexItems):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
* rendering/RenderFlexibleBox.h:

LayoutTests:

Test case for the crash.

* css3/flexbox/crash-removing-out-of-flow-child-expected.txt: Added.
* css3/flexbox/crash-removing-out-of-flow-child.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDon't access Node& after adding nodes to the graph.
fpizlo@apple.com [Wed, 14 Nov 2012 23:34:19 +0000 (23:34 +0000)]
Don't access Node& after adding nodes to the graph.
https://bugs.webkit.org/show_bug.cgi?id=102005

Reviewed by Oliver Hunt.

* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WebKit2] Need API in UIProcess to enable loading of custom protocols
aestes@apple.com [Wed, 14 Nov 2012 23:29:37 +0000 (23:29 +0000)]
[WebKit2] Need API in UIProcess to enable loading of custom protocols
https://bugs.webkit.org/show_bug.cgi?id=101674

Reviewed by Brady Eidson.

Source/WebKit2:

Enable clients of WebKit2 to implement NSURLProtocol subclasses to
control the loading of resources with schemes that WebKit2 cannot
handle natively. Since loading happens in a different process, we
accomplish this by registering a global NSURLProtocol in the web
process and proxying NSURLProtocol and NSURLProtocolClient calls to
the client's NSURLProtocol in the UI process.

* DerivedSources.make: Addded new .messages.in files.
* Platform/CoreIPC/MessageID.h:
* Shared/WebProcessCreationParameters.cpp: Added the list of supported schemes.
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
* UIProcess/API/mac/WKBrowsingContextController.h:
* UIProcess/API/mac/WKBrowsingContextController.mm:
(+[WKBrowsingContextController registerSchemeForCustomProtocol:]):
Added a class method where a client can register a scheme that it supports.
(+[WKBrowsingContextController unregisterSchemeForCustomProtocol:]):
Added a class method where a client can unregister a scheme that it no longer supports.
(+[WKBrowsingContextController customSchemes]):
* UIProcess/API/mac/WKBrowsingContextControllerInternal.h:
* UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.h: Added.
* UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.messages.in: Added.
* UIProcess/Network/CustomProtocols/mac/CustomProtocolManagerProxyMac.mm: Added.

Implemented an NSURLConnectionDelegate that proxies messages to the
equivalent NSURLProtocolClient in the web process:
(-[WKCustomProtocolLoader initWithCustomProtocolManagerProxy:customProtocolID:request:connection:]):
(-[WKCustomProtocolLoader dealloc]):
(-[WKCustomProtocolLoader connection:didFailWithError:]):
(-[WKCustomProtocolLoader connection:willCacheResponse:]):
(-[WKCustomProtocolLoader connection:didReceiveResponse:]):
(-[WKCustomProtocolLoader connection:didReceiveData:]):
(-[WKCustomProtocolLoader connection:willSendRequest:redirectResponse:]):
(-[WKCustomProtocolLoader connectionDidFinishLoading:]):

Implemented a proxy that recieves -startLoading and -stopLoading
messages from the NSURLProtocol in the web process and starts an
NSURLConnection in the UI process, which will instantiate the client's NSURLProtocol:
(WebKit::CustomProtocolManagerProxy::CustomProtocolManagerProxy):
(WebKit::CustomProtocolManagerProxy::didReceiveMessage):
(WebKit::CustomProtocolManagerProxy::startLoading):
(WebKit::CustomProtocolManagerProxy::stopLoading):

* UIProcess/WebContext.h: Declared strings that store names of
NSNotifications used for scheme registration in the UI process.
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::WebProcessProxy):
(WebKit::WebProcessProxy::didReceiveMessage): Forwarded messages to the
CustomProtocolManagerProxy.
* UIProcess/WebProcessProxy.h:
* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformInitializeWebProcess): Added the currently
registered schemes to the WebProcessCreationParameters and register
NSNotification observers for new scheme registration that forwards to
the context's web processes.
* WebKit2.xcodeproj/project.pbxproj:
* WebKit2Prefix.h: Enabled the CUSTOM_PROTOCOLS macro for the Mac.
* WebProcess/Network/CustomProtocols/CustomProtocolManager.h: Added.
* WebProcess/Network/CustomProtocols/CustomProtocolManager.messages.in: Added.
* WebProcess/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm: Added.
(generateCustomProtocolID): Generate a per-WebProcess unique ID.

Implemented a global NSURLProtocol that claims to support all schemes
registered in the UI process. When NSURLConnection calls -startLoading
and -stopLoading, we forward these messages to the client's NSURLProtocol
in the UI process:
(+[WKCustomProtocol canInitWithRequest:]):
(+[WKCustomProtocol canonicalRequestForRequest:]):
(+[WKCustomProtocol requestIsCacheEquivalent:toRequest:]):
(-[WKCustomProtocol initWithRequest:cachedResponse:client:]):
(-[WKCustomProtocol startLoading]):
(-[WKCustomProtocol stopLoading]):

Implemented a manager that receives NSURLConnectionDelegate messages
forwarded from the UI process and passes them to the global NSURLProtocol's NSURLProtocolClient:
(WebKit::CustomProtocolManager::shared):
(WebKit::CustomProtocolManager::registerCustomProtocolClass):
(WebKit::CustomProtocolManager::addCustomProtocol):
(WebKit::CustomProtocolManager::removeCustomProtocol):
(WebKit::CustomProtocolManager::registerScheme):
(WebKit::CustomProtocolManager::unregisterScheme):
(WebKit::CustomProtocolManager::supportsScheme):
(WebKit::CustomProtocolManager::didReceiveMessage):
(WebKit::CustomProtocolManager::didFailWithError):
(WebKit::CustomProtocolManager::didLoadData):
(WebKit::CustomProtocolManager::didReceiveResponse):
(WebKit::CustomProtocolManager::didFinishLoading):
(WebKit::CustomProtocolManager::protocolForID):

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didReceiveMessage): Forwarded messages to the
shared CustomProtocolManager.
(WebKit::WebProcess::registerSchemeForCustomProtocol): Register a
scheme received from the UI process.
(WebKit::WebProcess::unregisterSchemeForCustomProtocol): Unregister a
scheme received from the UI process.
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in: Declared messages for passing
supported schemes from the UI process the web process.
* WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::platformInitializeWebProcess): Register the
schemes contained in the WebProcessCreationParameters.

Tools:

Add an API test that implements a custom protocol and attempts to load
a resource requiring that protocol in a WKView. The test passes only if
didFinishLoadForFrame: fires.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: Added.
(+[TestProtocol canInitWithRequest:]):
(+[TestProtocol canonicalRequestForRequest:]):
(+[TestProtocol requestIsCacheEquivalent:toRequest:]):
(-[TestProtocol startLoading]):
(-[TestProtocol stopLoading]):
* TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
* TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextControllerInternal.h.
* TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextControllerInternal.h.
(-[TestBrowsingContextLoadDelegate initWithBlockToRunOnLoad:]):
(-[TestBrowsingContextLoadDelegate browsingContextControllerDidFinishLoad:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Remove magic numbers in record comparator, handle missing case
jsbell@chromium.org [Wed, 14 Nov 2012 23:28:54 +0000 (23:28 +0000)]
IndexedDB: Remove magic numbers in record comparator, handle missing case
https://bugs.webkit.org/show_bug.cgi?id=102255

Reviewed by Tony Chang.

Source/WebCore:

For some ranges of metadata entries, a simple type byte comparison is sufficient
for the backing store comparator. In two places those ranges used magic numbers,
one of which was incorrect - which could lead to failed reads/writes.

Test: webkit_unit_tests --gtest_filter='IDBLevelDBCodingTest.ComparisonTest'

* Modules/indexeddb/IDBLevelDBCoding.cpp:
(IDBLevelDBCoding):
(WebCore::IDBLevelDBCoding::compare):
* Modules/indexeddb/IDBLevelDBCoding.h:

Source/WebKit/chromium:

Add test keys for various metadata types.

* tests/IDBLevelDBCodingTest.cpp:
(IDBLevelDBCoding::TEST):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCleanup BasicShape blending check
krit@webkit.org [Wed, 14 Nov 2012 23:27:11 +0000 (23:27 +0000)]
Cleanup BasicShape blending check
https://bugs.webkit.org/show_bug.cgi?id=102289

Reviewed by Daniel Bates.

CSSPropertyAnimation had the same code for varifying that two BasicShape objects can be blended
twice. Refactor the code and add a canBlend method in BasicShape that combines both checks. This
is a preparation for follow-up patches.

Pure refactoring without behavior change, no new tests.

* page/animation/CSSPropertyAnimation.cpp:
(WebCore::blendFunc): Call new canBlend method for blending verification.
* rendering/style/BasicShapes.cpp:
(WebCore::BasicShape::canBlend): Check if two BasicShape objects can be blended.
(WebCore):
* rendering/style/BasicShapes.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Exclusions] Basic shapes on 'shape-inside' should be animatable
krit@webkit.org [Wed, 14 Nov 2012 23:09:28 +0000 (23:09 +0000)]
[CSS Exclusions] Basic shapes on 'shape-inside' should be animatable
https://bugs.webkit.org/show_bug.cgi?id=102123

Reviewed by Antti Koivisto.

Source/WebCore:

The '-webkit-shape-inside' propery takes a BasicShape as input like
'-webkit-clip-path'. Follow up on http://trac.webkit.org/changeset/134352 and
make '-webkit-shape-inside' animatable as well.

Test: fast/exclusions/shape-inside/shape-inside-animation.html

* page/animation/CSSPropertyAnimation.cpp:
(WebCore::blendFunc): Blend fuction for exclusion shapes. The property takes another
    input then '-webkit-clip-path'.
(WebCore):
(PropertyWrapperBasicShape): Add wrapper for BasicShape object. Can be reused by
    '-webkit-shape-ourside' as well.
(WebCore::PropertyWrapperBasicShape::PropertyWrapperBasicShape):
(WebCore::CSSPropertyAnimation::ensurePropertyMap):

LayoutTests:

Add new animation test for 'shape-inside', similar to 'clip-path' test.

* animations/resources/animation-test-helpers.js:
(getPropertyValue):
(comparePropertyValue):
* fast/exclusions/shape-inside/shape-inside-animation-expected.txt: Added.
* fast/exclusions/shape-inside/shape-inside-animation.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoString::append() should handle two 8 bit strings without converting both to 16 bits
msaboff@apple.com [Wed, 14 Nov 2012 23:04:43 +0000 (23:04 +0000)]
String::append() should handle two 8 bit strings without converting both to 16 bits
https://bugs.webkit.org/show_bug.cgi?id=102286

Reviewed by Oliver Hunt.

If both strings are 8 bit, then allocate and copy to a new 8 bit string.  Since most strings are
8 bit, this will save up to 3x the resulting string length in bytes.  2x is due to the possible
surviving 16 bit source string upconversion and 1x for the 16 bit result now being 8 bit.

* wtf/text/WTFString.cpp:
(WTF::String::append):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[TexMap][Cairo] Accelerated compositing debug visuals
commit-queue@webkit.org [Wed, 14 Nov 2012 23:02:37 +0000 (23:02 +0000)]
[TexMap][Cairo] Accelerated compositing debug visuals
https://bugs.webkit.org/show_bug.cgi?id=101883

Patch by Helder Correia <helder.correia@nokia.com> on 2012-11-14
Reviewed by Kenneth Rohde Christiansen.

No new tests, just introducing a debug feature.

Add a Cairo implementation to complement the patch from bug 90116
(http://trac.webkit.org/changeset/122275).

For this feature to be enabled, the environment variable
WEBKIT_SHOW_COMPOSITING_DEBUG_VISUALS must be set to 1. Once enabled,
both repaint counters and tile borders will be painted.

A Cairo-specific drawRepaintCounter() implementation was added to
TextureMapperGL. A cairo_surface_t is used as scratch buffer to paint
the counters. It is then uploaded to a BitmapTexture acquired
from the pool and finally draw by TextureMapper. The actual compositing
happens inside LayerBackingStore::paintToTextureMapper(). Each
LayerBackingStoreTile has a repaint counter which gets incremented in
LayerBackingStore::updateTile().

Source/WebCore:

* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawRepaintCounter):

Source/WebKit2:

* UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp:
(WebKit::shouldShowTileDebugVisuals):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix some defuct flakiness dashboard unittests.
ojan@chromium.org [Wed, 14 Nov 2012 23:01:14 +0000 (23:01 +0000)]
Fix some defuct flakiness dashboard unittests.
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Add JSNoStaticTables to IndexedDB interfaces
commit-queue@webkit.org [Wed, 14 Nov 2012 22:47:40 +0000 (22:47 +0000)]
IndexedDB: Add JSNoStaticTables to IndexedDB interfaces
https://bugs.webkit.org/show_bug.cgi?id=102268

Patch by Michael Pruett <michael@68k.org> on 2012-11-14
Reviewed by Geoffrey Garen.

Add JSNoStaticTables attribute to IndexedDB interface
definitions. This attribute must be specified in interfaces
which can be accessed from workers.

Tests: storage/indexeddb/*

* Modules/indexeddb/IDBAny.idl:
* Modules/indexeddb/IDBCursor.idl:
* Modules/indexeddb/IDBCursorWithValue.idl:
* Modules/indexeddb/IDBDatabase.idl:
* Modules/indexeddb/IDBDatabaseException.idl:
* Modules/indexeddb/IDBFactory.idl:
* Modules/indexeddb/IDBIndex.idl:
* Modules/indexeddb/IDBKey.idl:
* Modules/indexeddb/IDBKeyRange.idl:
* Modules/indexeddb/IDBObjectStore.idl:
* Modules/indexeddb/IDBOpenDBRequest.idl:
* Modules/indexeddb/IDBRequest.idl:
* Modules/indexeddb/IDBTransaction.idl:
* Modules/indexeddb/IDBUpgradeNeededEvent.idl:
* Modules/indexeddb/IDBVersionChangeEvent.idl:
* Modules/indexeddb/IDBVersionChangeRequest.idl:
* dom/DOMStringList.idl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Replace int64 with int64_t
commit-queue@webkit.org [Wed, 14 Nov 2012 22:42:15 +0000 (22:42 +0000)]
IndexedDB: Replace int64 with int64_t
https://bugs.webkit.org/show_bug.cgi?id=102270

Patch by Michael Pruett <michael@68k.org> on 2012-11-14
Reviewed by Tony Chang.

Cleaning up coding inconsistencies, no change in behavior.

Tests: storage/indexeddb/*

* Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::deleteObjectStore):
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::putInternal):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Do not clear the ProcessingChangeGuard state on DeleteBackward
commit-queue@webkit.org [Wed, 14 Nov 2012 22:39:57 +0000 (22:39 +0000)]
[BlackBerry] Do not clear the ProcessingChangeGuard state on DeleteBackward
https://bugs.webkit.org/show_bug.cgi?id=102284

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-11-14
Reviewed by Rob Buis.

PR237497
When holding backspace, clearing the state forces a keyboard
update which resets the state of the keyboard. Handling this
specific corner case separate from all other editor commands.

Internally reviewed by Mike Fenton.

* WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::handleKeyboardEvent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] White flicker when scrolling big pages with dark background on slower...
commit-queue@webkit.org [Wed, 14 Nov 2012 22:29:34 +0000 (22:29 +0000)]
[EFL][WK2] White flicker when scrolling big pages with dark background on slower hardware.
https://bugs.webkit.org/show_bug.cgi?id=102000

Patch by Viatcheslav Ostapenko <v.ostapenko@samsung.com> on 2012-11-14
Reviewed by Noam Rosenthal.

Add helper functions to clear viewport before painting. Those functions
used by EFL Webkit2 port to set view background to match page background
in order to reduce visibility of flicker during scrolling/scaling/repainting
where page tiles are not ready.

* platform/graphics/texmap/TextureMapper.h:
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawSolidColor):
(WebCore):
* platform/graphics/texmap/TextureMapperGL.h:
* platform/graphics/texmap/TextureMapperImageBuffer.cpp:
(WebCore::TextureMapperImageBuffer::drawSolidColor):
(WebCore):
* platform/graphics/texmap/TextureMapperImageBuffer.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowebkitpy: print-expectations - add --paths option to print only paths of test expecta...
commit-queue@webkit.org [Wed, 14 Nov 2012 22:25:49 +0000 (22:25 +0000)]
webkitpy: print-expectations - add --paths option to print only paths of test expectation files
https://bugs.webkit.org/show_bug.cgi?id=102269

Patch by Glenn Adams <glenn@skynav.com> on 2012-11-14
Reviewed by Dirk Pranke.

Add --paths option to print-expectations command in order to obtain list of applicable
test expectation file paths.

* Scripts/webkitpy/tool/commands/queries.py:
(PrintExpectations.__init__):
(PrintExpectations.execute):
* Scripts/webkitpy/tool/commands/queries_unittest.py:
(PrintExpectationsTest.run_test):
(PrintExpectationsTest.test_paths):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Match the LayerTreeSetting default for acceleratedAnimationEnabled in...
danakj@chromium.org [Wed, 14 Nov 2012 22:24:08 +0000 (22:24 +0000)]
[chromium] Match the LayerTreeSetting default for acceleratedAnimationEnabled in the WebLayerTreeSetting
https://bugs.webkit.org/show_bug.cgi?id=102285

Reviewed by James Robinson.

Accelerated animations default to on.

* chromium/public/WebLayerTreeView.h:
(WebKit::WebLayerTreeView::Settings::Settings):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdating baselines after r134631
junov@google.com [Wed, 14 Nov 2012 22:16:58 +0000 (22:16 +0000)]
Updating baselines after r134631
https://bugs.webkit.org/show_bug.cgi?id=101974

Unreviewed

* platform/chromium-linux/fast/borders/border-radius-wide-border-01-expected.png: Removed.
* platform/chromium-linux/fast/borders/borderRadiusInset01-expected.png:
* platform/chromium-linux/fast/forms/validation-message-appearance-expected.png:
* platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png:
* platform/chromium-mac-lion/fast/forms/validation-message-appearance-expected.png:
* platform/chromium-mac-lion/svg/custom/svg-fonts-in-html-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/svg-fonts-in-html-expected.png:
* platform/chromium-mac/fast/borders/border-radius-wide-border-01-expected.png:
* platform/chromium-mac/fast/borders/borderRadiusInset01-expected.png:
* platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
* platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.png:
* platform/chromium-win/fast/borders/border-radius-wide-border-01-expected.png:
* platform/chromium-win/fast/borders/borderRadiusInset01-expected.png:
* platform/chromium-win/fast/forms/validation-message-appearance-expected.png:
* platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
* platform/efl-wk1/fast/borders: Added.
* platform/efl-wk1/fast/borders/border-radius-wide-border-01-expected.png: Added.
* platform/efl-wk1/fast/borders/borderRadiusInset01-expected.png: Added.
* platform/efl-wk1/fast/forms/validation-message-appearance-expected.png: Added.
* platform/efl/fast/borders/border-radius-wide-border-01-expected.png: Removed.
* platform/efl/fast/borders/borderRadiusInset01-expected.png: Removed.
* platform/efl/fast/forms/validation-message-appearance-expected.png: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowebgl-background-color.html started failing
commit-queue@webkit.org [Wed, 14 Nov 2012 22:09:12 +0000 (22:09 +0000)]
webgl-background-color.html started failing
https://bugs.webkit.org/show_bug.cgi?id=102247

Patch by James Robinson <jamesr@chromium.org> on 2012-11-14
Reviewed by Adrienne Walker.

The compositor thread should outlive the WebView.

* DumpRenderTree/chromium/TestShell.h:
(TestShell):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFixed regressions due to adding JSEventListener::m_wrapper null checks.
mark.lam@apple.com [Wed, 14 Nov 2012 22:07:13 +0000 (22:07 +0000)]
Fixed regressions due to adding JSEventListener::m_wrapper null checks.
https://bugs.webkit.org/show_bug.cgi?id=102183.

Reviewed by Geoffrey Garen.

Fixed JSEventListener::operator==() to work within the contract that
when m_wrapper is 0, m_jsFunction is also expected to be 0. Also fixed
some typos in comments.

No new tests.

* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::visitJSFunction):
(WebCore::JSEventListener::operator==):
* bindings/js/JSEventListener.h:
(WebCore::JSEventListener::jsFunction):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-11-14 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 14 Nov 2012 22:02:05 +0000 (22:02 +0000)]
2012-11-14  Nate Chapin  <japhet@chromium.org>

        Fix chromium asserts from r134649.

        Rubber-stamped by Adam Barth.

        MainResourceLoader was calling releaseResources() twice when cancelled
        within MainResourceLoader::load(), so check reachedTerminalState() before
        calling releaseResources() there.

        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::load):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoOnly resolve presentation attribute style once per shared ElementAttributeData.
kling@webkit.org [Wed, 14 Nov 2012 21:58:13 +0000 (21:58 +0000)]
Only resolve presentation attribute style once per shared ElementAttributeData.
<http://webkit.org/b/100990>

Reviewed by Antti Koivisto.

Track the "presentation attribute style dirty" state on ElementAttributeData instead of in a Node flag.
This allows us to avoid duplicate work for ElementAttributeData that are shared between multiple elements,
since the state is no longer per-Element.

I've left the presentation attribute cache in there for now, since it still covers the case where
two elements have the same presentation attributes but different non-presentation attributes.
It's likely that we're not gaining much from it anymore, but that's a topic for another patch.

(WebCore::StyledElement::rebuildPresentationAttributeStyle):
* dom/StyledElement.h:
(WebCore::StyledElement::presentationAttributeStyle):
(WebCore::ElementAttributeData::ElementAttributeData):
* dom/ElementAttributeData.h:
(WebCore::ElementAttributeData::ElementAttributeData):
(ElementAttributeData):
* dom/Node.h:

    Move presentation attribute style dirty flag from Node to ElementAttributeData.

* dom/ElementAttributeData.cpp:
(SameSizeAsElementAttributeData):

    Add a compile-time object size assertion for ElementAttributeData.

* dom/StyledElement.cpp:
(WebCore::StyledElement::attributeChanged):

    Don't mark the presentation attribute style dirty if the element is using an immutable (implies
    shared) ElementAttributeData and another element has already generated the StylePropertySet.
    The element itself is still marked for style recalc like before, this just avoids the process
    of converting the attributes to CSS properties.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCoordinated Graphics: Rename m_CoordinatedGraphicsLayerClient to m_coordinator
noam.rosenthal@nokia.com [Wed, 14 Nov 2012 21:56:19 +0000 (21:56 +0000)]
Coordinated Graphics: Rename m_CoordinatedGraphicsLayerClient to m_coordinator
https://bugs.webkit.org/show_bug.cgi?id=102133

Renamed m_CoordinatedGraphicsLayerClient to m_coordinator.
Also, there is no need for calling setCoordinator every time the tree changes,
since we can call it once when the layer is created, now that LayerTreeCoordinator
is the GraphicsLayerFactory.

Reviewed by Kenneth Rohde Christiansen

No change in functionality.

* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::~CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::setChildren):
(WebCore::CoordinatedGraphicsLayer::addChild):
(WebCore::CoordinatedGraphicsLayer::addChildAtIndex):
(WebCore::CoordinatedGraphicsLayer::addChildAbove):
(WebCore::CoordinatedGraphicsLayer::addChildBelow):
(WebCore::CoordinatedGraphicsLayer::replaceChild):
(WebCore::CoordinatedGraphicsLayer::setContentsToImage):
(WebCore::CoordinatedGraphicsLayer::setMaskLayer):
(WebCore::CoordinatedGraphicsLayer::setReplicatedByLayer):
(WebCore::CoordinatedGraphicsLayer::flushCompositingState):
(WebCore::CoordinatedGraphicsLayer::syncChildren):
(WebCore::CoordinatedGraphicsLayer::syncFilters):
(WebCore::CoordinatedGraphicsLayer::syncLayerState):
(WebCore::CoordinatedGraphicsLayer::syncAnimations):
(WebCore::CoordinatedGraphicsLayer::syncCanvas):
(WebCore::CoordinatedGraphicsLayer::ensureImageBackingStore):
(WebCore::CoordinatedGraphicsLayer::tiledBackingStoreUpdatesAllowed):
(WebCore::CoordinatedGraphicsLayer::tiledBackingStoreVisibleRect):
(WebCore::CoordinatedGraphicsLayer::beginContentUpdate):
(WebCore::CoordinatedGraphicsLayer::createTile):
(WebCore::CoordinatedGraphicsLayer::updateTile):
(WebCore::CoordinatedGraphicsLayer::removeTile):
(WebCore::CoordinatedGraphicsLayer::purgeBackingStores):
(WebCore::CoordinatedGraphicsLayer::setCoordinator):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayer):
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::~LayerTreeCoordinator):
(WebKit::LayerTreeCoordinator::LayerTreeCoordinator):
(WebKit::LayerTreeCoordinator::paintContents):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Refactor theme font lookup into a factory
commit-queue@webkit.org [Wed, 14 Nov 2012 21:56:02 +0000 (21:56 +0000)]
[Chromium] Refactor theme font lookup into a factory
https://bugs.webkit.org/show_bug.cgi?id=101949

Patch by Scott Violet <sky@chromium.org> on 2012-11-14
Reviewed by Tony Chang.

This will ultimately allow us to use what is currently in RenderThemeChromiumLinux on windows.

No new tests. Refactoring only.

* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* rendering/RenderThemeChromiumFontProvider.cpp: Added.
(WebCore):
(WebCore::RenderThemeChromiumFontProvider::defaultGUIFont): Moved into RenderThemeFontProvider.
* rendering/RenderThemeChromiumFontProvider.h: Added.
(WTF):
(WebCore):
(RenderThemeChromiumFontProvider): This is the font related methods.
* rendering/RenderThemeChromiumFontProviderLinux.cpp: Added.
(WebCore):
(WebCore::RenderThemeChromiumFontProvider::setDefaultFontSize): What was in RenderThemeChromiumSkia::setDefaultFontSize.
(WebCore::RenderThemeChromiumFontProvider::systemFont): What was in RenderThemeChromiumSkia::systemFont.
* rendering/RenderThemeChromiumFontProviderWin.cpp: Added.
(WebCore):
(WebCore::pointsToPixels): Moved from RenderThemeChromiumWin.
(WebCore::getNonClientMetrics): Moved from RenderThemeChromiumWin.
(WebCore::systemFontSize): Moved from RenderThemeChromiumWin.
(WebCore::RenderThemeChromiumFontProvider::systemFont): Moved from RenderThemeChromiumWin.
(WebCore::RenderThemeChromiumFontProvider::setDefaultFontSize): Moved from RenderThemeChromiumWin.
* rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::RenderThemeChromiumSkia): Moved into RenderThemeFontProvider.
(WebCore::RenderThemeChromiumSkia::systemFont): Calls to RenderThemeChromiumFontProvider.
(WebCore::RenderThemeChromiumSkia::setDefaultFontSize): Calls to RenderThemeChromiumFontProvider.
* rendering/RenderThemeChromiumSkia.h:
(RenderThemeChromiumSkia): Moves defaultFontSize into RenderThemeChromiumFontProvider.
* rendering/RenderThemeChromiumWin.cpp: Moves font code into RenderThemeFontProviderWin.
(WebCore):
* rendering/RenderThemeChromiumWin.h: Removed overriden methods now handled by RenderThemeChromiumSkia.
(RenderThemeChromiumWin):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: test conversion batch 3
dgrogan@chromium.org [Wed, 14 Nov 2012 21:52:49 +0000 (21:52 +0000)]
IndexedDB: test conversion batch 3
https://bugs.webkit.org/show_bug.cgi?id=102168

Reviewed by Tony Chang.

These were all pretty straightforward. metadata.html could include
some additional tests that check the metadata after a versionchange
transaction aborts, but I think that's tested in one of the intversion
tests.

* storage/indexeddb/exceptions-expected.txt:
* storage/indexeddb/factory-deletedatabase-expected.txt:
* storage/indexeddb/index-duplicate-keypaths-expected.txt:
* storage/indexeddb/index-multientry-expected.txt:
* storage/indexeddb/index-population-expected.txt:
* storage/indexeddb/metadata-expected.txt:
* storage/indexeddb/resources/database-basics.js:
  Fix failure when run as a chromium browser test.

* storage/indexeddb/resources/exceptions.js:
  Moved some asserts from running before the database is opened to
  afterward but they appear to be testing the same thing.
(transactionComplete):
  close can't proceed until the transactions are complete, something
  setVersion didn't have to deal with.

* storage/indexeddb/resources/factory-deletedatabase.js:
  The conditions under which deleteDatabase is called in this test is
  _slightly_ different. Previously, deleteDatabase was called from
  inside a versionchange transaction, causing the original connection
  to receive a versionchange event. With upgradeneeded we have to close
  the original connection before entering a versionchange transaction,
  so the second connection is now what closes in response to the
  deleteDatabase's versionchange event.

* storage/indexeddb/resources/index-duplicate-keypaths.js:
(testCollideAutoIncrementSetup):
(testCollideAutoIncrement):
* storage/indexeddb/resources/index-multientry.js:
(prepareDatabase):
(createIndexOnStoreWithData):
* storage/indexeddb/resources/index-population.js:
(prepareDatabase.request.onsuccess):
(prepareDatabase):
(doSetVersion2):
(setVersion2):
(setVersion2Abort):
* storage/indexeddb/resources/metadata.js:
(prepareDatabase):
(snapshotConnection1):
(secondOpen.request.onupgradeneeded):
(secondOpen.request.onsuccess):
(secondOpen):
(thirdOpen.request.onupgradeneeded):
(thirdOpen.request.onerror):
(thirdOpen):
(fourthOpen.request.onupgradeneeded):
(fourthOpen.request.onsuccess):
(fourthOpen):
(checkState):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Updating baselines after r134631.
dglazkov@chromium.org [Wed, 14 Nov 2012 21:47:39 +0000 (21:47 +0000)]
[Chromium] Updating baselines after r134631.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate DOMException name: InUseAttributeError
arv@chromium.org [Wed, 14 Nov 2012 21:27:51 +0000 (21:27 +0000)]
Update DOMException name: InUseAttributeError
https://bugs.webkit.org/show_bug.cgi?id=102141

Reviewed by Ojan Vafai.

Patch 10 of 25 to update DOMException name to match the spec and Firefox.

The name for this is not in the spec but the case was selected to match
Firefox. http://mxr.mozilla.org/mozilla-central/source/dom/base/domerr.msg#18

INUSE_ATTRIBUTE_ERR is historical and not used in any spec or any of our tests.

* dom/DOMCoreException.cpp:
* dom/ExceptionCode.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMarked fake-mouse-move tests as failing.
dglazkov@chromium.org [Wed, 14 Nov 2012 21:27:22 +0000 (21:27 +0000)]
Marked fake-mouse-move tests as failing.
https://bugs.webkit.org/show_bug.cgi?id=102277

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WinCairo] Incorrect line-height for styled menulist (select tag)
bfulgham@webkit.org [Wed, 14 Nov 2012 21:26:05 +0000 (21:26 +0000)]
[WinCairo] Incorrect line-height for styled menulist (select tag)
in windows theme.
https://bugs.webkit.org/show_bug.cgi?id=79435

Patch by Lynn Neir <lynn.neir@skype.net> on 2012-11-14
Reviewed by Brent Fulgham

Applied same fix as in RenderThemeSafari::adjustMenuListButtonStyle
to Windows theme to fix issue.

Tests: fast/forms/menulist-restrict-line-height.html
       fast/forms/control-restrict-line-height.html
       fast/forms/basic-selects.html

* rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::adjustMenuListButtonStyle): Set line
height to the correct initial height.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMore steps towards actually hosting layers in the UI process
andersca@apple.com [Wed, 14 Nov 2012 21:16:41 +0000 (21:16 +0000)]
More steps towards actually hosting layers in the UI process
https://bugs.webkit.org/show_bug.cgi?id=102275

Reviewed by Andreas Kling.

* Shared/mac/RemoteLayerTreeTransaction.h:
(WebKit::RemoteLayerTreeTransaction::rootLayerID):
Add a getter for the root layer ID.

* UIProcess/mac/RemoteLayerTreeHost.h:
(RemoteLayerTreeHost):
Add root layer member variable. Make the RemoteLayerTreeHost class a GraphicsLayerClient.

* UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::RemoteLayerTreeHost):
Initialize the root layer to null.

(WebKit::RemoteLayerTreeHost::notifyAnimationStarted):
(WebKit::RemoteLayerTreeHost::notifyFlushRequired):
(WebKit::RemoteLayerTreeHost::paintContents):
Add empty stubs.

(WebKit::RemoteLayerTreeHost::commit):
Try to get the root layer.

(WebKit::RemoteLayerTreeHost::getOrCreateLayer):
Look up the layer with the given ID in the m_layers hash table and create it if it doesn't exist.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate DOMException name: WrongDocumentError
arv@chromium.org [Wed, 14 Nov 2012 21:05:40 +0000 (21:05 +0000)]
Update DOMException name: WrongDocumentError
https://bugs.webkit.org/show_bug.cgi?id=102096

Reviewed by Ojan Vafai.

Source/WebCore:

Patch 4 of 25 to update DOMException name to match the spec and Firefox.

Updated existing tests.

* dom/DOMCoreException.cpp:

LayoutTests:

Updated tests and expectations.

* fast/dom/Range/compareBoundaryPoints-1-expected.txt:
* fast/dom/Range/compareBoundaryPoints-1.html:
* fast/dom/move-nodes-across-documents.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Don't let shift-click turn popup into tab.
ericu@chromium.org [Wed, 14 Nov 2012 20:52:56 +0000 (20:52 +0000)]
[chromium] Don't let shift-click turn popup into tab.
https://bugs.webkit.org/show_bug.cgi?id=102254

Reviewed by Adam Barth.

Change http://trac.webkit.org/changeset/132399 broke shift-click on
compose in GMail.  We didn't want to change behavior that people were
depending on, and this quick fix seems a good compromise between user
intent and developer intent.

* src/ChromeClientImpl.cpp:
(WebKit::updatePolicyForEvent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Improve debug functionality in FatFingers
rwlbuis@webkit.org [Wed, 14 Nov 2012 20:51:45 +0000 (20:51 +0000)]
[BlackBerry] Improve debug functionality in FatFingers
https://bugs.webkit.org/show_bug.cgi?id=102263

Reviewed by Antonio Gomes.

- use logAlways to log even in release.
- dump shadow tree info if available.

* WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::isElementClickable):
(BlackBerry::WebKit::FatFingers::checkFingerIntersection):
(BlackBerry::WebKit::FatFingers::findIntersectingRegions):
(BlackBerry::WebKit::FatFingers::checkForText):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix the Production build after r134640 broke it.
beidson@apple.com [Wed, 14 Nov 2012 20:42:39 +0000 (20:42 +0000)]
Fix the Production build after r134640 broke it.

* WebProcess/Network/WebResourceLoader.h:
(WebKit::WebResourceLoader::resourceLoadIdentifier): Use the un-used.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPDFPlugin should make use of PDFKit's fluid zooming
timothy_horton@apple.com [Wed, 14 Nov 2012 20:38:46 +0000 (20:38 +0000)]
PDFPlugin should make use of PDFKit's fluid zooming
https://bugs.webkit.org/show_bug.cgi?id=101962
<rdar://problem/12555229>

Reviewed by Anders Carlsson.

Expose the notion of a frame that handles page scale gestures via WebFrame and to the bundle via WKBundleFrame.
The only frames that will purport to handle page scale gestures are those which contain PluginDocuments
backed by PDFPlugin, for now. Also, allow PDFKit to do its own fluid zooming animation.

* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameHandlesPageScaleGesture): Provide WKBundleFrameHandlesPageScaleGesture to
inform the injected bundle whether or not the frame handles scaling itself.
* WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h: Add WKBundleFrameHandlesPageScaleGesture.
* WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::geometryDidChange): Allow PDFKit to use its fluid zooming instead of changing
the scale factor immediately.
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::handlesPageScaleGesture): For now, the only frames that handle page scale
gestures themselves are plugins that purport to handle page scale changes themselves (i.e. only PDFPlugin).
* WebProcess/WebPage/WebFrame.h:
(WebFrame):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove empty loading to DocumentLoader, simplify FrameLoader::init()
japhet@chromium.org [Wed, 14 Nov 2012 20:35:21 +0000 (20:35 +0000)]
Move empty loading to DocumentLoader, simplify FrameLoader::init()
https://bugs.webkit.org/show_bug.cgi?id=101512

Reviewed by Adam Barth.

Source/WebCore:

No new tests, though several outputs changed because we no longer send resource
    load callbacks for empty loads.

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::startLoadingMainResource): Handle empty main resource
    loads directly here.
* loader/DocumentLoader.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::FrameLoader): Initialize some variables whose values
    were previously being reset in init(). Given that the FrameLoader is in
    an inconsistent state before init() is called anyway, there doesn't seem
    to be a disadvantage to just initializing them to their post-init() values.
(WebCore::FrameLoader::init): Just call startLoadingMainResource(), instead of
    doing a bunch of direct calls to functions FrameLoader shouldn't know about.
* loader/FrameLoaderStateMachine.cpp:
* loader/FrameLoaderStateMachine.h:
* loader/MainResourceLoader.cpp: Throughout, remove the concept of an empty load.
(WebCore::MainResourceLoader::loadNow): This only returned true when an empty
    load got deferred, which won't happen now. Return void and always treat
    as returning false.
* loader/MainResourceLoader.h:

Tools:

Chromium DRT has some code that doesn't play nicely with empty urls and incorrectly
interprets them as a non-empty load. This ensures
http/tests/navigation/new-window-redirect-history.html continues to pass
in chromium.

* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::updateForCommittedLoad):

LayoutTests:

Don't expect resource load callbacks for empty loads.

* http/tests/inspector/network/network-iframe-load-and-delete.html:
* http/tests/loading/redirect-methods-expected.txt:
* http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
* http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
* http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate DOMException name: InvalidStateError
arv@chromium.org [Wed, 14 Nov 2012 20:28:32 +0000 (20:28 +0000)]
Update DOMException name: InvalidStateError
https://bugs.webkit.org/show_bug.cgi?id=102241

Reviewed by Ojan Vafai.

Source/WebCore:

Patch 11 of 25 to update DOMException name to match the spec and Firefox.

Updated existing tests.

* dom/DOMCoreException.cpp:

LayoutTests:

Updated tests and expectations.

* fast/dom/HTMLDialogElement/dialog-open-expected.txt:
* fast/dom/HTMLDialogElement/dialog-open.html:
* fast/dom/HTMLDialogElement/dialog-show-modal-expected.txt:
* fast/dom/HTMLDialogElement/dialog-show-modal.html:
* fast/dom/Range/range-intersectsNode-exception-expected.txt:
* fast/dom/Range/range-intersectsNode-exception.html:
* fast/dom/Range/range-intersectsNode-expected.txt:
* fast/dom/Range/resources/intersectsNode.js:
* fast/dom/Selection/collapseToX-empty-selection-expected.txt:
* fast/dom/Selection/script-tests/collapseToX-empty-selection.js:
* fast/events/message-port-clone-expected.txt:
* fast/events/message-port-multi-expected.txt:
* fast/files/read-file-async-expected.txt:
* fast/files/workers/worker-read-file-async-expected.txt:
* fast/forms/color/color-setrangetext-expected.txt:
* fast/forms/date/date-setrangetext-expected.txt:
* fast/forms/date/date-stepup-stepdown-expected.txt:
* fast/forms/date/date-stepup-stepdown.html:
* fast/forms/datetime/datetime-setrangetext-expected.txt:
* fast/forms/datetime/datetime-stepup-stepdown-expected.txt:
* fast/forms/datetime/datetime-stepup-stepdown.html:
* fast/forms/datetimelocal/datetimelocal-setrangetext-expected.txt:
* fast/forms/datetimelocal/datetimelocal-stepup-stepdown-expected.txt:
* fast/forms/datetimelocal/datetimelocal-stepup-stepdown.html:
* fast/forms/file/file-setrangetext-expected.txt:
* fast/forms/file/input-file-value-expected.txt:
* fast/forms/hidden/hidden-setrangetext-expected.txt:
* fast/forms/image/image-setrangetext-expected.txt:
* fast/forms/input-stepup-stepdown-expected.txt:
* fast/forms/input-stepup-stepdown.html:
* fast/forms/input-valueasnumber-unsupported-expected.txt:
* fast/forms/input-valueasnumber-unsupported.html:
* fast/forms/month/input-valueasdate-expected.txt:
* fast/forms/month/input-valueasdate.html:
* fast/forms/month/month-setrangetext-expected.txt:
* fast/forms/month/month-stepup-stepdown-expected.txt:
* fast/forms/month/month-stepup-stepdown.html:
* fast/forms/number/number-setrangetext-expected.txt:
* fast/forms/number/number-stepup-stepdown-expected.txt:
* fast/forms/number/number-stepup-stepdown-from-renderer.html:
* fast/forms/number/number-stepup-stepdown.html:
* fast/forms/number/number-valueasnumber-expected.txt:
* fast/forms/number/number-valueasnumber.html:
* fast/forms/range/range-setrangetext-expected.txt:
* fast/forms/range/range-stepup-stepdown-expected.txt:
* fast/forms/range/range-stepup-stepdown-from-renderer.html:
* fast/forms/range/range-stepup-stepdown.html:
* fast/forms/setrangetext-expected.txt:
* fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html:
* fast/forms/time/time-setrangetext-expected.txt:
* fast/forms/time/time-stepup-stepdown-expected.txt:
* fast/forms/time/time-stepup-stepdown.html:
* fast/forms/week/week-setrangetext-expected.txt:
* fast/forms/week/week-stepup-stepdown-expected.txt:
* fast/forms/week/week-stepup-stepdown.html:
* fast/js/dfg-custom-getter-throw-expected.txt:
* fast/js/dfg-custom-getter-throw-inlined-expected.txt:
* fast/js/script-tests/dfg-custom-getter-throw-inlined.js:
* fast/js/script-tests/dfg-custom-getter-throw.js:
* fast/mediastream/MediaStreamTrackList-expected.txt:
* fast/notifications/notifications-document-close-crash-expected.txt:
* fast/speech/scripted/start-exception-expected.txt:
* fast/speech/scripted/start-exception.html:
* fast/workers/worker-context-multi-port-expected.txt:
* fast/workers/worker-multi-port-expected.txt:
* fast/xmlhttprequest/xmlhttprequest-responseXML-xml-text-responsetype-expected.txt:
* fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer-expected.txt:
* fast/xmlhttprequest/xmlhttprequest-responsetype-document-expected.txt:
* fast/xmlhttprequest/xmlhttprequest-responsetype-set-at-headers-received-expected.txt:
* fast/xmlhttprequest/xmlhttprequest-responsetype-text-expected.txt:
* fast/xpath/detached-subtree-invalidate-iterator-expected.txt:
* http/tests/media/media-source/video-media-source-add-and-remove-buffers-expected.txt:
* http/tests/media/media-source/video-media-source-duration-changed-expected.txt:
* http/tests/media/media-source/video-media-source-objects-expected.txt:
* http/tests/xmlhttprequest/exceptions-expected.txt:
* http/tests/xmlhttprequest/zero-length-response-expected.txt:
* platform/chromium-mac/fast/notifications/notifications-document-close-crash-expected.txt:
* platform/qt/editing/pasteboard/data-transfer-items-expected.txt:
* platform/qt/fast/notifications/notifications-document-close-crash-expected.txt:
* storage/websql/open-database-set-empty-version-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPDFPlugin should support downloading PDFs
timothy_horton@apple.com [Wed, 14 Nov 2012 20:27:08 +0000 (20:27 +0000)]
PDFPlugin should support downloading PDFs
https://bugs.webkit.org/show_bug.cgi?id=102152
<rdar://problem/12555313>

Reviewed by Alexey Proskuryakov.

Clicking on the "Download PDF" HUD button should download the current
PDF to the Downloads folder.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::savePDFToFileInDownloadsFolder): Added. Save the
PDF data to disk, in the Downloads folder. This will only save files with
the .pdf extension, and of MIME type "application/pdf".
* UIProcess/WebPageProxy.h:
(WebPageProxy): Add savePDFToFileInDownloadsFolder.
* UIProcess/WebPageProxy.messages.in: Add savePDFToFileInDownloadsFolder.
* WebProcess/Plugins/PDF/PDFPlugin.h:
(PDFPlugin): Add saveToPDF().
* WebProcess/Plugins/PDF/PDFPlugin.mm:
(-[WKPDFLayerControllerDelegate saveToPDF]): Forward saveToPDF delegate callback to PDFPlugin.
(WebKit::PDFPlugin::saveToPDF): Hand WebPageProxy the raw data for the
current PDF, which it will save to the Downloads folder. We receive
the suggested filename during loading.
* WebProcess/Plugins/PDF/SimplePDFPlugin.h:
(WebKit::SimplePDFPlugin::suggestedFilename): Expose a getter for suggestedFilename.
* WebProcess/Plugins/PDF/SimplePDFPlugin.mm:
(WebKit::SimplePDFPlugin::pluginInfo): Add a missing space after an operator.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename NATIVE_TYPE_ERR to TypeError
jsbell@chromium.org [Wed, 14 Nov 2012 20:22:41 +0000 (20:22 +0000)]
Rename NATIVE_TYPE_ERR to TypeError
https://bugs.webkit.org/show_bug.cgi?id=102114

Reviewed by Kentaro Hara.

Defines names (mostly) matching WebIDL exception types for use by dom (etc) code.
V8 binding code had colliding enum members, which required prefixing.

No new tests - just internal renames.

* Modules/indexeddb/IDBCursor.cpp: s/NATIVE_TYPE_ERR/TypeError/g
(WebCore::IDBCursor::advance):
(WebCore::IDBCursor::stringToDirection):
(WebCore::IDBCursor::directionToString):
* Modules/indexeddb/IDBDatabase.cpp: Ditto.
(WebCore::IDBDatabase::setVersion):
* Modules/indexeddb/IDBFactory.cpp: Ditto.
(WebCore::IDBFactory::open):
(WebCore::IDBFactory::openInternal):
(WebCore::IDBFactory::deleteDatabase):
* Modules/indexeddb/IDBObjectStore.cpp: Ditto.
(WebCore::IDBObjectStore::createIndex):
* Modules/indexeddb/IDBTransaction.cpp: Ditto.
(WebCore::IDBTransaction::stringToMode):
(WebCore::IDBTransaction::modeToString):
* bindings/js/JSDOMBinding.cpp: Ditto.
(WebCore::setDOMException):
* bindings/v8/DateExtension.cpp: Prefix ErrorType enum/members w/ V8/v8.
(WebCore::DateExtension::OnSleepDetected):
* bindings/v8/NPV8Object.cpp: Ditto.
(_NPN_SetException):
* bindings/v8/V8Binding.cpp: Ditto.
(WebCore::throwError):
(WebCore::handleMaxRecursionDepthExceeded):
* bindings/v8/V8Binding.h: Ditto.
(WebCore):
* bindings/v8/V8NPObject.cpp: Ditto.
(WebCore::npObjectInvokeImpl):
(WebCore::npObjectGetProperty):
(WebCore::npObjectSetProperty):
(WebCore::npObjectPropertyEnumerator):
* bindings/v8/V8ThrowException.cpp: Rename ALL the errors!
(WebCore::V8ThrowException::setDOMException):
(WebCore::V8ThrowException::throwError):
(WebCore::V8ThrowException::throwTypeError):
(WebCore::V8ThrowException::throwNotEnoughArgumentsError):
* bindings/v8/V8ThrowException.h:
(V8ThrowException):
* bindings/v8/WorkerContextExecutionProxy.cpp: Prefixing (continued)
(WebCore::WorkerContextExecutionProxy::evaluate):
* bindings/v8/custom/V8ArrayBufferCustom.cpp: Ditto.
(WebCore::V8ArrayBuffer::constructorCallback):
* bindings/v8/custom/V8ArrayBufferViewCustom.h: Ditto.
(WebCore::constructWebGLArrayWithArrayBufferArgument):
(WebCore::constructWebGLArray):
(WebCore::setWebGLArrayHelper):
* bindings/v8/custom/V8AudioContextCustom.cpp: Ditto.
(WebCore::V8AudioContext::constructorCallback):
* bindings/v8/custom/V8BlobCustom.cpp: Ditto.
(WebCore::V8Blob::constructorCallback):
* bindings/v8/custom/V8ClipboardCustom.cpp: Ditto.
(WebCore::V8Clipboard::clearDataCallback):
(WebCore::V8Clipboard::setDragImageCallback):
* bindings/v8/custom/V8DOMFormDataCustom.cpp: Ditto.
(WebCore::V8DOMFormData::appendCallback):
* bindings/v8/custom/V8SQLResultSetRowListCustom.cpp: Ditto.
(WebCore::V8SQLResultSetRowList::itemCallback):
* dom/ExceptionCode.h: Add WebIDL exception types.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Style BB10 time input field font.
commit-queue@webkit.org [Wed, 14 Nov 2012 20:19:15 +0000 (20:19 +0000)]
[BlackBerry] Style BB10 time input field font.
https://bugs.webkit.org/show_bug.cgi?id=102260.

Patch by Tiancheng Jiang <tijiang@rim.com> on 2012-11-14
Reviewed by Rob Buis.

RIM PR 243355
Adjust time input field font using BB10 system default font.

* css/themeBlackBerry.css:
(input[type="date"], input[type="datetime"], input[type="datetime-local"], input[type="time"], input[type="month"]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agocreateDelay should raise exception when the maxDelayTime parameter is incorrect.
commit-queue@webkit.org [Wed, 14 Nov 2012 20:14:08 +0000 (20:14 +0000)]
createDelay should raise exception when the maxDelayTime parameter is incorrect.
https://bugs.webkit.org/show_bug.cgi?id=102173

Patch by Li Yin <li.yin@intel.com> on 2012-11-14
Reviewed by Chris Rogers.

Spec: https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html
The specified value must be greater than zero and less than three minutes or a
NOT_SUPPORTED_ERR exception will be thrown.

Source/WebCore:

Tests: webaudio/delaynode-maxdelaylimit.html

* Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::createDelay):
* Modules/webaudio/AudioContext.h:
(AudioContext):
* Modules/webaudio/AudioContext.idl: Add raising exception for createDelay.
* Modules/webaudio/DelayNode.cpp:
(WebCore):
(WebCore::DelayNode::DelayNode):
* Modules/webaudio/DelayNode.h:
(WebCore::DelayNode::create):
(DelayNode):

LayoutTests:

* webaudio/delaynode-maxdelaylimit-expected.txt:
* webaudio/delaynode-maxdelaylimit.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] css3/filters/custom/custom-filter-property-computed-style.html is a flaky...
dglazkov@chromium.org [Wed, 14 Nov 2012 19:57:24 +0000 (19:57 +0000)]
[Chromium] css3/filters/custom/custom-filter-property-computed-style.html is a flaky timeout in debug.
https://bugs.webkit.org/show_bug.cgi?id=90207

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDon't pass a paintingRoot when painting from RenderLayerBacking
simon.fraser@apple.com [Wed, 14 Nov 2012 19:48:25 +0000 (19:48 +0000)]
Don't pass a paintingRoot when painting from RenderLayerBacking
https://bugs.webkit.org/show_bug.cgi?id=102256

Reviewed by David Hyatt.

The 'paintingRoot' parameter to the RenderLayer paint functions
is used when painting just a subtree (e.g. when painting dragged
selections). There is no need to pass it when a RenderLayerBacking
paints its contents or overlay scrollbars.

Passing it requires an expensive isDescendant() check, so passing
null is more efficient.

* rendering/RenderLayer.h:
(WebCore::RenderLayer::LayerPaintingInfo::LayerPaintingInfo):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintIntoLayer):
(WebCore::RenderLayerBacking::paintContents):
* rendering/RenderLayerBacking.h:
(RenderLayerBacking):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Updated the type of flakiness for fast/forms/select/select-state-restore...
dglazkov@chromium.org [Wed, 14 Nov 2012 19:44:47 +0000 (19:44 +0000)]
[Chromium] Updated the type of flakiness for fast/forms/select/select-state-restore.html.
https://bugs.webkit.org/show_bug.cgi?id=90207

* platform/chromium/TestExpectations: Updated.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPart of "Move loading responsibility out of WebResourceLoadScheduler into a new WebRe...
beidson@apple.com [Wed, 14 Nov 2012 19:43:42 +0000 (19:43 +0000)]
Part of "Move loading responsibility out of WebResourceLoadScheduler into a new WebResourceLoader"
https://bugs.webkit.org/show_bug.cgi?id=102259

Reviewed by Alexey Proskuryakov.

WebResourceLoadScheduler has taken on too many responsibilities that shouldn't belong to it.

We should create a WebResourceLoader that will eventually act as an intermediary between
WebCore::ResourceLoader and NetworkResourceLoader.

This patch is prep-work: It adds a new skeleton class to the WebProcess.

* WebKit2.xcodeproj/project.pbxproj:

Add the new WebResourceLoader class which is a very thin skeleton for now:
* WebProcess/Network/WebResourceLoader.cpp: Added.
(WebKit::WebResourceLoader::create):
(WebKit::WebResourceLoader::WebResourceLoader):
(WebKit::WebResourceLoader::~WebResourceLoader):
* WebProcess/Network/WebResourceLoader.h: Added.
(WebKit::WebResourceLoader::coreLoader):

Adapt WebResourceLoadScheduler to use this new class where appropriate:
* WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::WebResourceLoadScheduler::scheduleLoad):
(WebKit::WebResourceLoadScheduler::addMainResourceLoad):
(WebKit::WebResourceLoadScheduler::remove):
(WebKit::WebResourceLoadScheduler::willSendRequest):
(WebKit::WebResourceLoadScheduler::didReceiveResponse):
(WebKit::WebResourceLoadScheduler::didReceiveData):
(WebKit::WebResourceLoadScheduler::didFinishResourceLoad):
(WebKit::WebResourceLoadScheduler::didReceiveResource):
(WebKit::WebResourceLoadScheduler::didFailResourceLoad):
* WebProcess/Network/WebResourceLoadScheduler.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rebaselined test results.
arv@chromium.org [Wed, 14 Nov 2012 19:43:05 +0000 (19:43 +0000)]
Unreviewed. Rebaselined test results.

* fast/media/mq-js-media-except-01-expected.txt: Renamed from LayoutTests/platform/mac/fast/media/mq-js-media-except-01-expected.txt.
* platform/chromium-linux-x86/svg/dom/SVGTransformList-basics-expected.png: Removed.
* platform/chromium-mac-lion/svg/dom/SVGLengthList-appendItem-expected.png:
* platform/chromium-mac-lion/svg/dom/SVGLengthList-basics-expected.png:
* platform/chromium-mac-lion/svg/dom/SVGLengthList-getItem-expected.png:
* platform/chromium-mac-lion/svg/dom/SVGLengthList-initialize-expected.png:
* platform/chromium-mac-lion/svg/dom/SVGLengthList-insertItemBefore-expected.png:
* platform/chromium-mac-lion/svg/dom/SVGLengthList-removeItem-expected.png:
* platform/chromium-mac-lion/svg/dom/SVGLengthList-replaceItem-expected.png:
* platform/chromium-mac-lion/svg/dom/SVGNumberList-basics-expected.png:
* platform/chromium-mac-lion/svg/dom/SVGTransformList-basics-expected.png:
* platform/chromium-win/fast/media/mq-js-media-except-01-expected.png:
* platform/chromium-win/svg/dom/SVGLengthList-appendItem-expected.png:
* platform/chromium-win/svg/dom/SVGLengthList-basics-expected.png:
* platform/chromium-win/svg/dom/SVGLengthList-getItem-expected.png:
* platform/chromium-win/svg/dom/SVGLengthList-initialize-expected.png:
* platform/chromium-win/svg/dom/SVGLengthList-insertItemBefore-expected.png:
* platform/chromium-win/svg/dom/SVGLengthList-removeItem-expected.png:
* platform/chromium-win/svg/dom/SVGLengthList-replaceItem-expected.png:
* platform/chromium-win/svg/dom/SVGNumberList-basics-expected.png:
* platform/chromium-win/svg/dom/SVGTransformList-basics-expected.png:
* platform/chromium/fast/media/mq-js-media-except-01-expected.txt: Removed.
* platform/efl-wk1/fast/media/mq-js-media-except-01-expected.txt: Renamed from LayoutTests/platform/efl/fast/media/mq-js-media-except-01-expected.txt.
* platform/efl-wk1/svg/dom/SVGLengthList-appendItem-expected.png: Renamed from LayoutTests/platform/efl/svg/dom/SVGLengthList-appendItem-expected.png.
* platform/efl-wk1/svg/dom/SVGLengthList-basics-expected.png: Renamed from LayoutTests/platform/efl/svg/dom/SVGLengthList-basics-expected.png.
* platform/efl-wk1/svg/dom/SVGLengthList-initialize-expected.png: Renamed from LayoutTests/platform/efl/svg/dom/SVGLengthList-initialize-expected.png.
* platform/efl-wk1/svg/dom/SVGLengthList-insertItemBefore-expected.png: Renamed from LayoutTests/platform/efl/svg/dom/SVGLengthList-insertItemBefore-expected.png.
* platform/efl-wk1/svg/dom/SVGLengthList-replaceItem-expected.png: Renamed from LayoutTests/platform/efl/svg/dom/SVGLengthList-replaceItem-expected.png.
* platform/efl-wk1/svg/dom/SVGNumberList-basics-expected.png: Renamed from LayoutTests/platform/efl/svg/dom/SVGNumberList-basics-expected.png.
* platform/qt/fast/files/workers/worker-read-blob-sync-expected.txt: Added.
* platform/qt/fast/media/mq-js-media-except-01-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Wed, 14 Nov 2012 19:37:59 +0000 (19:37 +0000)]
Unreviewed GTK gardening.

Adding back and updating baselines that were removed by accident in r133908.

* platform/gtk/fast/forms/basic-textareas-quirks-expected.png:
* platform/gtk/fast/forms/basic-textareas-quirks-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agorunCount in runner.js should be renamed to iterationCount
rniwa@webkit.org [Wed, 14 Nov 2012 19:34:49 +0000 (19:34 +0000)]
runCount in runner.js should be renamed to iterationCount
https://bugs.webkit.org/show_bug.cgi?id=102208

Reviewed by Tony Chang.

Prior to this patch, there were terminology confusions between "runs" and "iterations".
The term "run" should refer to running a performance test once, and "iteration" should
refer to one measurement in the test. i.e. Executing run-perf-should once will result in
a single "run" of performance tests and each test may execute multiple "iterations"
to complete the run.

Unfortunately, we still overload the meaning of "runs" in "runs/s" (is "function calls/s")
but that could be addressed in a separate patch.

* Animation/balls.html:
* DOM/DOMTable.html:
* DOM/resources/dom-perf.js:
* Layout/floats_100_100.html:
* Layout/floats_100_100_nested.html:
* Layout/floats_20_100.html:
* Layout/floats_20_100_nested.html:
* Layout/floats_2_100.html:
* Layout/floats_2_100_nested.html:
* Layout/floats_50_100.html:
* Layout/floats_50_100_nested.html:
* Layout/subtree-detaching.html:
* Parser/html5-full-render.html:
* SVG/SvgHitTesting.html:
* resources/runner.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove uses of deprecated unittest.TestCase aliases
zandobersek@gmail.com [Wed, 14 Nov 2012 19:29:25 +0000 (19:29 +0000)]
Remove uses of deprecated unittest.TestCase aliases
https://bugs.webkit.org/show_bug.cgi?id=102253

Reviewed by Dirk Pranke.

Replace the deprecated unittest.TestCase methods with the corresponding methods
everywhere inside the Tools directory. The following replacements are done:
- assertEquals -> assertEqual
- assert_ -> assertTrue
- failUnlessRaises -> assertRaises

* BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
(SVNMirrorTest.test_CheckOutSource):
* QueueStatusServer/model/queuepropertymixin_unittest.py:
(QueuePropertyMixinTest.test_queue_property):
* QueueStatusServer/model/queues_unittest.py:
(QueueTest._assert_short_name):
(QueueTest._assert_display_name):
(QueueTest._assert_name_with_underscores):
* QueueStatusServer/model/workitems_unittest.py:
(WorkItemsTest.test_display_position_for_attachment):
* Scripts/webkitpy/common/checkout/changelog_unittest.py:
(test_parse_log_entries_from_changelog):
(test_parse_log_entries_from_annotated_file):
(_assert_parse_reviewer_text_and_list):
(_assert_parse_reviewer_text_list):
(_assert_fuzzy_reviewer_match):
(_assert_parse_authors):
(test_latest_entry_parse):
(test_latest_entry_parse_single_entry):
(test_set_reviewer):
(test_set_short_description_and_bug_url):
* Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
(DiffParserTest.test_diff_parser):
* Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
(GitSVNTest.test_revisions_changing_files_with_local_commit):
(GitSVNTest.test_upstream_branch):
(GitSVNTest.test_create_patch_with_rm_and_changed_files):
(GitTestWithMock.test_push_local_commits_to_server_with_username_and_password):
* Scripts/webkitpy/common/config/ports_unittest.py:
(DeprecatedPortTest.test_mac_port):
(DeprecatedPortTest.test_gtk_port):
(DeprecatedPortTest.test_efl_port):
(DeprecatedPortTest.test_qt_port):
(DeprecatedPortTest.test_chromium_port):
(DeprecatedPortTest.test_chromium_android_port):
(DeprecatedPortTest.test_chromium_xvfb_port):
* Scripts/webkitpy/common/config/urls_unittest.py:
(URLsTest.test_parse_bug_id):
(URLsTest.test_parse_attachment_id):
* Scripts/webkitpy/common/find_files_unittest.py:
(TestWinNormalize.assert_filesystem_normalizes):
* Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
(test_url_creation):
(test_parse_bug_id):
(_assert_dictionaries_equal):
(test_parse_bugs_from_xml):
(test_attachment_detail_bug_parsing):
(_assert_result_count):
(test_request_page_parsing):
(test_quip_page_parsing):
(EditUsersParserTest._assert_login_userid_pairs):
* Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
(test_status_parsing):
(test_latest_cached_build):
(test_results_zip_url):
* Scripts/webkitpy/common/net/credentials_unittest.py:
(test_credentials_from_environment):
* Scripts/webkitpy/common/net/failuremap_unittest.py:
(FailureMapTest.test_failing_revisions):
(FailureMapTest.test_new_failures):
(FailureMapTest.test_new_failures_with_old_revisions):
(FailureMapTest.test_new_failures_with_more_old_revisions):
(FailureMapTest.test_tests_failing_for):
(FailureMapTest.test_failing_tests):
* Scripts/webkitpy/common/net/layouttestresults_unittest.py:
(LayoutTestResultsTest.test_set_failure_limit_count):
* Scripts/webkitpy/common/net/unittestresults_unittest.py:
(UnitTestResultsTest.test_nostring):
(UnitTestResultsTest.test_emptystring):
* Scripts/webkitpy/common/read_checksum_from_png_unittest.py:
(ReadChecksumFromPngTest.test_read_checksum):
* Scripts/webkitpy/common/system/deprecated_logging_unittest.py:
(LoggingTest.assert_log_equals):
* Scripts/webkitpy/common/system/executive_unittest.py:
(ScriptErrorTest.test_string_from_args):
(ScriptErrorTest.test_message_with_output):
(ExecutiveTest.test_run_command_with_bad_command):
(ExecutiveTest.test_run_command_with_unicode):
(ExecutiveTest.serial_test_run_in_parallel):
* Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
(MockFileSystemTest.quick_check):
* Scripts/webkitpy/common/system/filesystem_unittest.py:
(GenericFileSystemTests.test_glob__trailing_asterisk):
(GenericFileSystemTests.test_glob__leading_asterisk):
(GenericFileSystemTests.test_glob__middle_asterisk):
(GenericFileSystemTests.test_glob__period_is_escaped):
(RealFileSystemTest.test_chdir):
(RealFileSystemTest.test_remove_file_with_retry):
(RealFileSystemTest.test_sep):
* Scripts/webkitpy/common/system/logtesting.py:
(TestLogStream.assertMessages):
* Scripts/webkitpy/common/system/logutils_unittest.py:
(GetLoggerTest.test_get_logger_in_webkitpy):
(GetLoggerTest.test_get_logger_not_in_webkitpy):
* Scripts/webkitpy/common/system/outputcapture.py:
(OutputCaptureTestCaseBase.assertStdout):
(OutputCaptureTestCaseBase.assertStderr):
* Scripts/webkitpy/common/system/path_unittest.py:
(AbspathTest.test_abspath_to_uri_cygwin):
(AbspathTest.test_abspath_to_uri_unixy):
(AbspathTest.test_abspath_to_uri_win):
(AbspathTest.test_abspath_to_uri_escaping_unixy):
(AbspathTest.test_abspath_to_uri_escaping_cygwin):
* Scripts/webkitpy/common/system/platforminfo_unittest.py:
(TestPlatformInfo.test_real_code):
(TestPlatformInfo.test_os_name_and_wrappers):
(TestPlatformInfo.test_os_version):
(TestPlatformInfo.test_total_bytes_memory):
* Scripts/webkitpy/common/system/user_unittest.py:
(UserTest.test_confirm.mock_raw_input):
(UserTest.test_confirm):
* Scripts/webkitpy/common/system/zipfileset_unittest.py:
(ZipFileSetTest.test_open):
(ZipFileSetTest.test_read):
* Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
(WatchListTest.test_filename_definition_no_matches):
(WatchListTest.test_filename_definition):
(WatchListTest.test_cc_rules_simple):
(WatchListTest.test_cc_rules_complex):
(WatchListTest.test_cc_and_message_rules_complex):
(WatchListTest.test_cc_and_message_rules_no_matches):
(WatchListTest.test_added_match):
(WatchListTest.test_deleted_match):
(WatchListTest.test_more_and_less_match):
(WatchListTest.test_complex_match):
* Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
(LockCheckingRunner.handle_finished_list):
(LayoutTestRunnerTests.test_interrupt_if_at_failure_limits):
(LayoutTestRunnerTests.test_update_summary_with_result):
(LayoutTestRunnerTests.test_servers_started):
(SharderTests.assert_shards):
(SharderTests.test_shard_in_two_has_no_locked_shards):
(SharderTests.test_shard_in_two_has_no_unlocked_shards):
(NaturalCompareTest.assert_cmp):
(KeyCompareTest.assert_cmp):
* Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
(TestConfigurationTest.test_items):
(TestConfigurationTest.test_keys):
(TestConfigurationTest.test_str):
(TestConfigurationTest.test_repr):
(TestConfigurationTest.test_hash):
(TestConfigurationTest.test_eq):
(TestConfigurationTest.test_values):
(SpecifierSorterTest.test_init):
(SpecifierSorterTest.test_add_specifier):
(SpecifierSorterTest.test_add_macros):
(SpecifierSorterTest.test_category_priority):
(SpecifierSorterTest.test_specifier_priority):
(SpecifierSorterTest.test_sort_specifiers):
(TestConfigurationConverterTest.test_symmetric_difference):
(TestConfigurationConverterTest.test_to_config_set):
(TestConfigurationConverterTest.test_macro_expansion):
(TestConfigurationConverterTest.test_to_specifier_lists):
(TestConfigurationConverterTest.test_macro_collapsing):
(TestConfigurationConverterTest.test_converter_macro_collapsing):
(TestConfigurationConverterTest.test_specifier_converter_access):
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(assert_exp):
(MiscTests.test_result_was_expected):
(MiscTests.test_remove_pixel_failures):
(MiscTests.test_suffixes_for_expectations):
(MiscTests.test_get_expectations_string):
(SkippedTests.check):
(ExpectationSyntaxTests.assert_tokenize_exp):
(SemanticTests.test_bad_bugid):
(SemanticTests.test_missing_bugid):
(TestExpectationSerializationTests.test_reconstitute_only_these):
* Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
(TestFailuresTest.test_crashes):
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_nonexistant_expectations):
(PortTest.test_additional_expectations):
* Scripts/webkitpy/layout_tests/port/builders_unittest.py:
(BuildersTest.test_path_from_name):
* Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
(ChromiumAndroidPortTest.test_attributes):
(ChromiumAndroidPortTest.test_default_timeout_ms):
(ChromiumAndroidPortTest.test_get_devices_one_device):
(ChromiumAndroidPortTest.test_get_devices_two_devices):
(ChromiumAndroidPortTest.test_get_device_serial_one_device):
(ChromiumAndroidPortTest.test_get_device_serial_two_devices):
(ChromiumAndroidPortTest.test_must_require_http_server):
(ChromiumAndroidDriverTest.test_get_last_stacktrace):
(ChromiumAndroidDriverTest.test_get_crash_log):
(ChromiumAndroidDriverTest.test_cmd_line):
(ChromiumAndroidDriverTest.test_read_prompt):
(ChromiumAndroidDriverTest.test_command_from_driver_input):
(ChromiumAndroidDriverTwoDriversTest.test_two_drivers):
(ChromiumAndroidTwoPortsTest.test_options_with_two_ports):
* Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
(ChromiumLinuxPortTest.assert_architecture):
(ChromiumLinuxPortTest.test_determine_architecture_fails):
(ChromiumLinuxPortTest.test_path_to_image_diff):
* Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
(ChromiumMacPortTest.assert_name):
(ChromiumMacPortTest.test_baseline_path):
(ChromiumMacPortTest.test_path_to_image_diff):
* Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
(ChromiumPortTestCase.test_default_max_locked_shards):
(ChromiumPortTestCase.test_default_timeout_ms):
(ChromiumPortTestCase.test_default_pixel_tests):
(ChromiumPortTestCase.test_all_test_configurations):
(ChromiumPortTestCase.test_default_configuration):
(ChromiumPortTestCase.test_diff_image):
(ChromiumPortTestCase.test_diff_image_crashed):
(ChromiumPortTestCase.test_expectations_files):
* Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
(ChromiumWinTest.test_setup_environ_for_server_cygpath):
(ChromiumWinTest.assert_name):
(ChromiumWinTest.test_baseline_path):
(ChromiumWinTest.test_path_to_image_diff):
* Scripts/webkitpy/layout_tests/port/driver_unittest.py:
(DriverTest.test_read_block):
(DriverTest.test_read_binary_block):
(DriverTest.test_read_base64_block):
(DriverTest.test_no_timeout):
(DriverTest.test_check_for_driver_crash.assert_crash):
(DriverTest.test_creating_a_port_does_not_write_to_the_filesystem):
* Scripts/webkitpy/layout_tests/port/factory_unittest.py:
(FactoryTest.test_get_from_builder_name):
* Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
(GtkPortTest.test_default_timeout_ms):
* Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
(HttpLockTest.test_current_lock_pid):
* Scripts/webkitpy/layout_tests/port/image_diff_unittest.py:
(TestImageDiffer.test_diff_image_failed):
(TestImageDiffer.test_diff_image_passed):
* Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
(LeakDetectorTest.test_leaks_args):
(test_parse_leaks_output):
(test_leaks_files_in_directory):
(test_count_total_leaks):
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
(MacTest.test_default_timeout_ms):
(assert_name):
(test_setup_environ_for_server):
(_assert_search_path):
(test_32bit):
(test_64bit):
* Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
(MockTestShellTest.test_pixeltest__fails):
(MockTestShellTest.test_test_shell_parse_options):
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
(PortTestCase.test_default_max_locked_shards):
(PortTestCase.test_default_timeout_ms):
(PortTestCase.test_default_pixel_tests):
(PortTestCase.test_diff_image):
(PortTestCase.test_diff_image_crashed):
(PortTestCase.test_get_crash_log):
(PortTestCase.assert_build_path):
(PortTestCase.test_expectations_ordering):
(_assert_config_file_for_platform):
(test_path_to_apache_config_file):
(test_additional_platform_directory):
* Scripts/webkitpy/layout_tests/port/qt_unittest.py:
(QtPortTest._assert_search_path):
(QtPortTest._assert_expectations_files):
(QtPortTest.test_setup_environ_for_server):
* Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
(TestServerProcess.test_basic):
(TestServerProcess.test_broken_pipe):
* Scripts/webkitpy/layout_tests/port/win_unittest.py:
(WinPortTest._assert_search_path):
(WinPortTest._assert_version):
(WinPortTest.test_runtime_feature_list):
(WinPortTest.test_expectations_files):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(LintTest.test_all_configurations):
(MainTest.test_all):
(MainTest.test_repeat_each):
(MainTest.test_skipped_flag):
(MainTest.test_iterations):
(MainTest.test_run_chunk):
(MainTest.test_run_part):
(MainTest.test_run_singly):
(MainTest.test_run_singly_actually_runs_tests):
(MainTest.test_single_file):
(MainTest.test_single_file_with_prefix):
(MainTest.test_single_skipped_file):
(MainTest.test_stderr_is_saved):
(MainTest.test_test_list):
(MainTest.test_test_list_with_prefix):
(MainTest.test_missing_and_unexpected_results):
(MainTest.test_pixel_test_directories):
(MainTest.test_missing_and_unexpected_results_with_custom_exit_code):
(MainTest.test_crash_log):
(MainTest.test_web_process_crash_log):
(MainTest.test_exit_after_n_failures_upload):
(MainTest.test_exit_after_n_failures):
(MainTest.test_exit_after_n_crashes):
(MainTest.test_retrying_and_flaky_tests):
(MainTest.test_run_order__inline):
(MainTest.test_reftest_run):
(MainTest.test_reftest_run_reftests_if_pixel_tests_are_disabled):
(MainTest.test_reftest_skip_reftests_if_no_ref_tests):
(MainTest.test_reftest_expected_html_should_be_ignored):
(MainTest.test_reftest_driver_should_run_expected_html):
(MainTest.test_reftest_driver_should_run_expected_mismatch_html):
(MainTest.test_output_diffs):
(MainTest.test_unsupported_platform):
(EndToEndTest.test_end_to_end):
(RebaselineTest.test_reset_results):
(RebaselineTest.test_missing_results):
(RebaselineTest.test_new_baseline):
* Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
(BaseTest.integration_test_server__normal):
(BaseTest.integration_test_server__fails):
(BaseTest.integration_test_port_and_root):
* Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
(TestHttpServer.test_start_cmd):
* Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
(RegularTest.test_logging_not_included):
(RegularTest._basic):
(RegularTest.test_basic):
(RegularTest.test_log_after_update):
(RegularTest.test_log_args):
(TtyTest.test_basic):
(TtyTest.test_log_after_update):
(VerboseTest.test_basic):
(VerboseTest.test_log_after_update):
(VerboseTest.test_log_args):
* Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(Testprinter.assertWritten):
(test_test_status_line):
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(MainTest.assertWritten):
* Scripts/webkitpy/style/checker_unittest.py:
(GlobalVariablesTest.test_webkit_base_filter_rules):
(CheckerDispatcherSkipTest._assert_should_skip_without_warning):
(CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
(CheckerDispatcherDispatchTest.assert_checker):
(CheckerDispatcherDispatchTest.test_changelog_paths):
(CheckerDispatcherDispatchTest.test_cpp_paths):
(CheckerDispatcherDispatchTest.test_json_paths):
(CheckerDispatcherDispatchTest.test_python_paths):
(CheckerDispatcherDispatchTest.test_text_paths):
(CheckerDispatcherDispatchTest.test_xml_paths):
(StyleProcessorConfigurationTest.test_init):
(StyleProcessorConfigurationTest.test_write_style_error_emacs):
(StyleProcessorConfigurationTest.test_write_style_error_vs7):
(StyleProcessor_EndToEndTest.test_init):
(StyleProcessor_EndToEndTest.test_process):
(StyleProcessor_CodeCoverageTest.test_process__checker_dispatched):
* Scripts/webkitpy/style/checkers/changelog_unittest.py:
(ChangeLogCheckerTest.assert_error.handle_style_error):
(ChangeLogCheckerTest.test_init):
* Scripts/webkitpy/style/checkers/common_unittest.py:
(CarriageReturnCheckerTest.assert_carriage_return):
(TabCheckerTest.assert_tab):
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppFunctionsTest.test_convert_to_lower_with_underscores):
(CppFunctionsTest.test_create_acronym):
(CppFunctionsTest.test_parameter):
(CppFunctionsTest.test_single_line_view):
(CppFunctionsTest.test_create_skeleton_parameters):
(CppFunctionsTest.test_find_parameter_name_index):
(CppFunctionsTest.test_parameter_list):
(CppFunctionsTest.test_check_parameter_against_text):
(CppStyleTestBase.perform_lint):
(CppStyleTestBase.assert_lint):
(CppStyleTestBase.assert_lint_one_of_many_errors_re):
(CppStyleTestBase.assert_multi_line_lint):
(CppStyleTestBase.assert_language_rules_check):
(CppStyleTestBase.assert_include_what_you_use):
(CppStyleTestBase.assert_blank_lines_check):
(CppStyleTestBase.assert_positions_equal):
(FunctionDetectionTest.perform_function_detection):
(CppStyleTest.test_get_line_width):
(CppStyleTest.test_find_next_multi_line_comment_start):
(CppStyleTest.test_find_next_multi_line_comment_end):
(CppStyleTest.test_remove_multi_line_comments_from_range):
(CppStyleTest.test_position):
(CppStyleTest.test_rfind_in_lines):
(CppStyleTest.test_close_expression):
(CppStyleTest.test_include_what_you_use_no_implementation_files):
(CppStyleTest.test_include_what_you_use):
(CppStyleTest.test_files_belong_to_same_module):
(CppStyleTest.test_cleanse_line):
(CppStyleTest.test_multiline_strings):
(CppStyleTest.test_newline_at_eof.do_test):
(CppStyleTest.test_invalid_utf8.do_test):
(CppStyleTest.test_is_blank_line):
(CppStyleTest.test_allow_blank_line_before_closing_namespace):
(CppStyleTest.test_allow_blank_line_before_if_else_chain):
(CppStyleTest.test_else_on_same_line_as_closing_braces):
(CppStyleTest.test_build_header_guard):
(CppStyleTest.test_legal_copyright):
(CleansedLinesTest.test_init):
(CleansedLinesTest.test_init_empty):
(CleansedLinesTest.test_collapse_strings):
(CheckForFunctionLengthsTest.assert_function_lengths_check):
(PassPtrTest.assert_pass_ptr_check):
(LeakyPatternTest.assert_leaky_pattern_check):
(WebKitStyleTest.test_parameter_names):
(WebKitStyleTest.test_webkit_export_check):
(CppCheckerTest.test_init):
* Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
(JSONCheckerTest.assert_error.handle_style_error):
(JSONCheckerTest.test_init):
* Scripts/webkitpy/style/checkers/png_unittest.py:
(PNGCheckerTest.test_init):
(PNGCheckerTest.test_check):
* Scripts/webkitpy/style/checkers/python_unittest.py:
(PythonCheckerTest.test_init):
(PythonCheckerTest.test_check):
* Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
(TestExpectationsTestCase._expect_port_for_expectations_path):
(TestExpectationsTestCase.assert_lines_lint):
* Scripts/webkitpy/style/checkers/text_unittest.py:
(TextStyleTestCase.assertNoError):
(TextStyleTestCase.assertError.error_for_test):
(TextStyleTestCase.assertError):
(TextCheckerTest.test_init):
* Scripts/webkitpy/style/checkers/watchlist_unittest.py:
(WatchListTest.test_basic_error_message.handle_style_error):
(WatchListTest):
* Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
(XcodeProjectFileCheckerTest.assert_error):
* Scripts/webkitpy/style/checkers/xml_unittest.py:
(XMLCheckerTest.assert_error.handle_style_error):
(XMLCheckerTest.test_init):
* Scripts/webkitpy/style/error_handlers_unittest.py:
(DefaultStyleErrorHandlerTest._check_initialized):
(DefaultStyleErrorHandlerTest.test_non_reportable_error):
(DefaultStyleErrorHandlerTest.test_max_reports_per_category):
(DefaultStyleErrorHandlerTest.test_line_numbers):
* Scripts/webkitpy/style/filereader_unittest.py:
(TextFileReaderTest._assert_file_reader):
(TextFileReaderTest.test_process_file__does_not_exist):
(TextFileReaderTest.test_count_delete_only_file):
* Scripts/webkitpy/style/filter_unittest.py:
(CategoryFilterTest.test_init):
(CategoryFilterTest.test_init_default_arguments):
(CategoryFilterTest.test_str):
(FilterConfigurationTest.test_init):
(FilterConfigurationTest.test_default_arguments):
* Scripts/webkitpy/style/main_unittest.py:
(ChangeDirectoryTest._assert_result):
* Scripts/webkitpy/style/optparser_unittest.py:
(ArgumentPrinterTest.test_to_flag_string):
(ArgumentParserTest.test_parse_default_arguments):
(ArgumentParserTest.test_parse_explicit_arguments):
(ArgumentParserTest.test_parse_files):
(CommandOptionValuesTest.test_init):
* Scripts/webkitpy/style/patchreader_unittest.py:
(PatchReaderTest._assert_checked):
* Scripts/webkitpy/test/finder_unittest.py:
(FinderTest.test_additional_system_paths):
(FinderTest.test_to_module):
(FinderTest.check_names):
* Scripts/webkitpy/test/main_unittest.py:
(TesterTest.test_individual_names_are_not_run_twice):
(TesterTest.test_integration_tests_are_not_found_by_default):
(TesterTest.test_integration_tests_are_found):
(TesterTest.integration_test_coverage_works):
* Scripts/webkitpy/test/runner_unittest.py:
(RunnerTest.test_run):
* Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
(_expect_validate):
* Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
(ExpectedFailuresTest._assert_can_trust):
(ExpectedFailuresTest.test_unexpected_failures_observed):
(ExpectedFailuresTest.test_unexpected_failures_observed_when_tree_is_hosed):
* Scripts/webkitpy/tool/bot/feeders_unittest.py:
(test_patches_with_acceptable_review_flag):
* Scripts/webkitpy/tool/bot/irc_command_unittest.py:
(IRCCommandTest.test_whois):
(IRCCommandTest.test_create_bug):
(IRCCommandTest.test_roll_chromium_deps):
(IRCCommandTest.test_rollout):
* Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
(LayoutTestResultsReaderTest.test_missing_layout_test_results):
(test_missing_unit_test_results_path):
(test_layout_test_results):
* Scripts/webkitpy/tool/bot/queueengine_unittest.py:
(LoggingDelegate.process_work_item):
(LoggingDelegate.handle_unexpected_error):
(QueueEngineTest.test_trivial):
(QueueEngineTest.test_unexpected_error):
(QueueEngineTest.test_handled_error):
(QueueEngineTest._test_terminating_queue):
* Scripts/webkitpy/tool/commands/openbugs_unittest.py:
(OpenBugsTest.test_find_bugs_in_string):
* Scripts/webkitpy/tool/commands/queries_unittest.py:
(FailureReasonTest.test_blame_line_for_revision):
(PrintExpectationsTest.run_test):
(PrintBaselinesTest.test_basic):
(PrintBaselinesTest.test_multiple):
(PrintBaselinesTest.test_csv):
* Scripts/webkitpy/tool/commands/queues_unittest.py:
(AbstractQueueTest.test_log_directory):
(AbstractPatchQueueTest.test_next_patch):
(test_auto_retry):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(test_rebaseline_updates_expectations_file):
(test_rebaseline_does_not_include_overrides):
(test_rebaseline_test):
(test_rebaseline_test_with_results_directory):
(test_rebaseline_test_and_print_scm_changes):
(test_rebaseline_and_copy_test):
(test_rebaseline_and_copy_test_no_existing_result):
(test_rebaseline_and_copy_test_with_lion_result):
(test_rebaseline_and_copy_no_overwrite_test):
(test_rebaseline_test_internal_with_move_overwritten_baselines_to):
(TestRebaselineJson.test_rebaseline_all):
(TestRebaselineJson.test_rebaseline_debug):
(TestRebaselineJson.test_move_overwritten):
(TestRebaselineJson.test_no_optimize):
(TestRebaselineJson.test_results_directory):
(TestRebaseline.test_rebaseline):
(TestRebaselineExpectations.test_rebaseline_expectations_noop):
(TestRebaselineExpectations.disabled_test_overrides_are_included_correctly):
(TestAnalyzeBaselines.test_default):
(TestAnalyzeBaselines.test_missing_baselines):
* Scripts/webkitpy/tool/commands/roll_unittest.py:
(PostRollCommandsTest.test_prepare_state):
* Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
(BuildCoverageExtrapolatorTest.test_extrapolate):
* Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py:
(AddSvnMimetypeForPngTest.test_run):
* Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
(PrepareChangeLogTest.test_ensure_bug_url):
* Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
(_assert_message_for_revert_output):
* TestResultServer/model/jsonresults_unittest.py:
(JsonResultsTest._test_merge):
(JsonResultsTest._test_get_test_list):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Wed, 14 Nov 2012 19:28:14 +0000 (19:28 +0000)]
Unreviewed GTK gardening.

Adding or updating baselines for changes in r134618.
Adding timeout expectations for
- fast/dom/Window/open-window-min-size.html, added in r134586 and
- inspector-protocol/nmi-webaudio.html, added in r134593.

* platform/gtk/TestExpectations:
* platform/gtk/fast/files/workers/worker-read-blob-sync-expected.txt: Added.
* platform/gtk/fast/media/mq-js-media-except-01-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReplace (typeof(x) != <"object", "undefined", ...>) with
bfulgham@webkit.org [Wed, 14 Nov 2012 19:26:04 +0000 (19:26 +0000)]
Replace (typeof(x) != <"object", "undefined", ...>) with
!(typeof(x) == <"object",..>). Later is_object, is_<...>  bytecode operation
will be used.

https://bugs.webkit.org/show_bug.cgi?id=98893

Patch by Valery Ignatyev <valery.ignatyev@ispras.ru> on 2012-11-14
Reviewed by Filip Pizlo.

This eliminates expensive  typeof implementation and
allows to use DFG optimizations, which doesn't support 'typeof'.

* bytecompiler/NodesCodegen.cpp:
(JSC::BinaryOpNode::emitBytecode):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Rebaselined video LayoutTests for software compositor
enne@google.com [Wed, 14 Nov 2012 19:24:57 +0000 (19:24 +0000)]
[Chromium] Rebaselined video LayoutTests for software compositor
https://bugs.webkit.org/show_bug.cgi?id=101973

Patch by Slavomir Kaslev <skaslev@google.com> on 2012-11-12
Reviewed by Adrienne Walker.

Rebaselined failing video LayouTests caused by different filtering
result between Skia and Mesa for the software compositor.

* platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/video-fixed-scrolling-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/video-opacity-overlay-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/softwarecompositing/layers-inside-overflow-scroll-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/softwarecompositing/overflow/overflow-compositing-descendant-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/softwarecompositing/overflow/scroll-ancestor-update-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/softwarecompositing/reflections/load-video-in-reflection-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/softwarecompositing/self-painting-layers-expected.png: Added.
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/video-fixed-scrolling-expected.png: Added.
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/video-opacity-overlay-expected.png: Added.
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/layers-inside-overflow-scroll-expected.png: Added.
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/overflow/overflow-compositing-descendant-expected.png: Added.
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/overflow/scroll-ancestor-update-expected.png: Added.
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/reflections/load-video-in-reflection-expected.png: Added.
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/self-painting-layers-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/video-fixed-scrolling-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/video-opacity-overlay-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/layers-inside-overflow-scroll-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/overflow/overflow-compositing-descendant-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/overflow/scroll-ancestor-update-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/reflections/load-video-in-reflection-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/self-painting-layers-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/video-fixed-scrolling-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/video-opacity-overlay-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/layers-inside-overflow-scroll-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/overflow/overflow-compositing-descendant-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/overflow/scroll-ancestor-update-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/reflections/load-video-in-reflection-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/self-painting-layers-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/visibility/visibility-simple-video-layer-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/video-fixed-scrolling-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/video-opacity-overlay-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/softwarecompositing/layers-inside-overflow-scroll-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/softwarecompositing/overflow/overflow-compositing-descendant-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/softwarecompositing/overflow/scroll-ancestor-update-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/softwarecompositing/reflections/load-video-in-reflection-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/softwarecompositing/self-painting-layers-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/softwarecompositing/visibility/visibility-simple-video-layer-expected.png: Added.
* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd DOMRequestState to maintain world/ScriptExecutionContext state
alecflett@chromium.org [Wed, 14 Nov 2012 19:16:36 +0000 (19:16 +0000)]
Add DOMRequestState to maintain world/ScriptExecutionContext state
https://bugs.webkit.org/show_bug.cgi?id=102102

Reviewed by Adam Barth.

Introduce DOMRequestState, and convert IndexedDB over.

No new tests, this is an abstraction layer for existing code.

* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::dispatchEvent):
* Modules/indexeddb/IDBRequest.h:
(IDBRequest):
* WebCore.gypi:
* bindings/v8/DOMRequestState.h: Added.
(WebCore):
(DOMRequestState):
(WebCore::DOMRequestState::DOMRequestState):
(Scope):
(WebCore::DOMRequestState::Scope::Scope):
(WebCore::DOMRequestState::scope):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBoxes with rounded corners and thin borders are too slow to draw
junov@google.com [Wed, 14 Nov 2012 19:12:02 +0000 (19:12 +0000)]
Boxes with rounded corners and thin borders are too slow to draw
https://bugs.webkit.org/show_bug.cgi?id=101974

Reviewed by Simon Fraser.

Source/WebCore:

With the current implementation RenderBox::
determineBackgroundBleedAvoidance() uses the slow path
BackgroundBleedUseTransparencyLayer for some very common use cases,
notably for drawing rectangles with rounded corners that have thin
borders. This is because the BackgroundBleedShrinkBackground
strategy requires a border at least two pixels wide on all sides. This
patch introduce drawing strategy BackgroundBleedBackgroundOverBorder.
This approach consists in drawing the border first, with an inset inner
edge (for anti-aliased compositing to work well).  This approach only
works with opaque solid edges and opaque single-layer backgrounds.
By using this approach rather than BackgroundBleedUseTransparencyLayer,
we save two clipPath, one save and one saveLayer on the
GraphicsContext. This patch gets good coverage from existing layout
tests. One additional test was added to exercise mitring, thick edges
and anti-aliasing edge cases under the new painting algorithm.

Test: fast/borders/border-radius-wide-border-05.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::determineBackgroundBleedAvoidance):
Added selection criteria for BackgroundOverBorder
(WebCore::RenderBox::paintBoxDecorations):
Added a preliminary paintBorder pass for BackgroundOverBorder
(WebCore::RenderBox::paintBackground):
Insetting the background to to innerBorder when bleedAvoidance is
BackgroundOverBorder.  This why BackgroundOverBorder only works for
Opaque solid edges.
(WebCore):
(WebCore::RenderBox::backgroundIsSingleOpaqueLayer):
Utility method use by determineBackgroundBleedAvoidance to test the
background's eligibility for BackgroundOverBorder bleed avoidance
strategy.  The reason the background must be a single layer is to avoid
color bleeding from layer compositing along anti-aliased edges
* rendering/RenderBox.h:
(RenderBox):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::getBackgroundRoundedRect):
(WebCore::RenderBoxModelObject::borderInnerRectAdjustedForBleedAvoidance):
Added support for BackgroundOverBorder by applying a one pixel inset.
(WebCore::RenderBoxModelObject::backgroundRoundedRectAdjustedForBleedAvoidance):
Set the background rect to the inner border for BackgroundOverBorder
(WebCore):
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
Added support for BackgroundOverBorder by using
backgroundRoundedRectAdjustedForBleedAvoidance
(WebCore::RenderBoxModelObject::paintBorderSides):
Added support for BackgroundOverBorder by applying per-side inset
adjustments.
(WebCore::RenderBoxModelObject::paintTranslucentBorderSides):
(WebCore::RenderBoxModelObject::paintBorder):
Added support for BackgroundOverBorder by using an adjusted inner
border, but not if sides are painted individually.
* rendering/RenderBoxModelObject.h:
(RenderBoxModelObject):

LayoutTests:

New test that purposely triggers the BackgroundOverBorder painting path
in WebCore::RenderBox, to test it with thick borders, off-diagonal
mitring, an anti-aliased rounded border wedge, and a border of width 0.

* fast/borders/border-radius-wide-border-05.html: Added.
* fast/borders/border-radius-wide-border-05-expected.txt: Added.
* LayoutTests/platform/chromium-win/fast/borders/border-radius-wide-border-05-expected.png: Added.
* LayoutTests/platform/chromium/TestExpectations: Added Expectations.
Added expectations for tests pixels results that require rebaselining

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Break suspend/resume of the backingstore and screen into separate methods
commit-queue@webkit.org [Wed, 14 Nov 2012 19:03:10 +0000 (19:03 +0000)]
[BlackBerry] Break suspend/resume of the backingstore and screen into separate methods
https://bugs.webkit.org/show_bug.cgi?id=102126

Patch by Adam Treat <atreat@rim.com> on 2012-11-14
Reviewed by George Staikos.
PR 219976

Modify the suspend/resume methods so that they can be called from the UI thread
itself and split up the suspend/resume methods so that we can suspend/resume
the screen or backingstore separately.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::suspendBackingStoreUpdates):
(WebKit):
(BlackBerry::WebKit::BackingStorePrivate::suspendScreenUpdates):
(BlackBerry::WebKit::BackingStorePrivate::resumeBackingStoreUpdates):
(BlackBerry::WebKit::BackingStorePrivate::resumeScreenUpdates):
(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
(BlackBerry::WebKit::BackingStorePrivate::createSurfaces):
(BlackBerry::WebKit::BackingStore::suspendBackingStoreUpdates):
(BlackBerry::WebKit::BackingStore::resumeBackingStoreUpdates):
(BlackBerry::WebKit::BackingStore::suspendScreenUpdates):
(BlackBerry::WebKit::BackingStore::resumeScreenUpdates):
(BlackBerry::WebKit::BackingStore::createBackingStoreMemory):
(BlackBerry::WebKit::BackingStore::releaseBackingStoreMemory):
* Api/BackingStore.h:
* Api/BackingStore_p.h:
(BackingStorePrivate):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
(BlackBerry::WebKit::WebPagePrivate::zoomBlock):
(BlackBerry::WebKit::WebPage::destroy):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
(BlackBerry::WebKit::WebPagePrivate::setCompositor):
(BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):
(BlackBerry::WebKit::WebPagePrivate::restoreHistoryViewState):
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::transitionToCommittedForNewPage):
(WebCore::FrameLoaderClientBlackBerry::restoreViewState):
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::setBatchEditingActive):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WinCairo] Fix cairo_t* memory leak in GraphicsContext::platformInit
bfulgham@webkit.org [Wed, 14 Nov 2012 18:53:36 +0000 (18:53 +0000)]
[WinCairo] Fix cairo_t* memory leak in GraphicsContext::platformInit
https://bugs.webkit.org/show_bug.cgi?id=76219

Patch by Hideki Yoshida <yoshida-hxa@necst.nec.co.jp> on 2012-11-14
Reviewed by Brent Fulgham.

This patch is to fix a memory leak problem which occurs
in every rendering process on Wincairo port.
By applying this patch, the memory allocated in cairo
library will be released by calling cairo_destroy.

* platform/graphics/win/GraphicsContextCairoWin.cpp:
(WebCore::GraphicsContext::platformInit):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoOptimize painting of composited scrolling layers
commit-queue@webkit.org [Wed, 14 Nov 2012 18:51:51 +0000 (18:51 +0000)]
Optimize painting of composited scrolling layers
https://bugs.webkit.org/show_bug.cgi?id=96087

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-11-14
Reviewed by Simon Fraser.

Source/WebCore:

Don't completely repaint accelerated scrolling layers when the scroll offset
changes.

Test: compositing/overflow/scrolling-without-painting.html

* platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::setOffsetFromRenderer):
* platform/graphics/GraphicsLayer.h:
(GraphicsLayer):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

LayoutTests:

Test that accelerated scrolling layers can be scrolled without repainting
their contents. Note that this test will not pass unless
ENABLE_ACCELERATED_OVERFLOW_SCROLLING is enabled.

* compositing/overflow/scrolling-without-painting-expected.txt: Added.
* compositing/overflow/scrolling-without-painting.html: Added.
* platform/chromium/TestExpectations: Mark test as expected to fail
  by default.
* platform/mac/TestExpectations: Skip the test.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: keep track of mutation observers and disconnect them upon upload
pfeldman@chromium.org [Wed, 14 Nov 2012 18:48:59 +0000 (18:48 +0000)]
Web Inspector: keep track of mutation observers and disconnect them upon upload
https://bugs.webkit.org/show_bug.cgi?id=102239

Reviewed by Vsevolod Vlasov.

Otherwise we hit memory leaks.

* inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype.wasShown):
(WebInspector.DefaultTextEditor.prototype.willHide):
(WebInspector.TextEditorMainPanel.prototype._wasShown):
(WebInspector.TextEditorMainPanel.prototype._willHide):
(WebInspector.TextEditorMainPanel.prototype._attachMutationObserver):
(WebInspector.TextEditorMainPanel.prototype._detachMutationObserver):
* inspector/front-end/utilities.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDynamically create canvas in Setup() to avoid calling DEPRECATED function setDevice().
reed@google.com [Wed, 14 Nov 2012 18:43:21 +0000 (18:43 +0000)]
Dynamically create canvas in Setup() to avoid calling DEPRECATED function setDevice().
https://bugs.webkit.org/show_bug.cgi?id=102242

Reviewed by Stephen White.

This change should not change any test results, it is an equivalent implementation that avoids
using a (now) DEPRECATED function.

* tests/DeferredImageDecoderTest.cpp:
(WebCore::createRasterCanvas):
(WebCore):
(WebCore::DeferredImageDecoderTest::SetUp):
(DeferredImageDecoderTest):
(WebCore::TEST_F):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline fast/media/mq-js-media-except-01.html after r134618.
dglazkov@chromium.org [Wed, 14 Nov 2012 18:39:37 +0000 (18:39 +0000)]
Rebaseline fast/media/mq-js-media-except-01.html after r134618.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Add FocusBased context node detection strategy
commit-queue@webkit.org [Wed, 14 Nov 2012 18:37:56 +0000 (18:37 +0000)]
[BlackBerry] Add FocusBased context node detection strategy
https://bugs.webkit.org/show_bug.cgi?id=102238

Patch by Andy Chen <andchen@rim.com> on 2012-11-14
Reviewed by Rob Buis.

If last fat finger result is invalid, we need to return current
focus element as context node, because when user tap on selection
overlay, there is not touch event sent to webkit.
PR 241382

Internally reviewed by Genevieve Mak and Mike Fenton.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::contextNode):
* Api/WebPage.h:
* WebKitSupport/InputHandler.h:
(BlackBerry::WebKit::InputHandler::currentFocusElement):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDeliver data from NetworkProcess to resources progressively.
beidson@apple.com [Wed, 14 Nov 2012 18:20:52 +0000 (18:20 +0000)]
Deliver data from NetworkProcess to resources progressively.
https://bugs.webkit.org/show_bug.cgi?id=102171

Reviewed by Alexey Proskuryakov.

Instead of buffering up the data for an entire resource and delivering it in one chunk, we need
to deliver data progressively.

This allows progressive parsing of textual resources and progressive rendering of images,
as well as allows endless multipart resources (e.g., multipart jpegs) to work at all.

* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didReceiveData): Don't buffer data locally (for now) but rather
  pass it straight through to the WebProcess.
(WebKit::NetworkResourceLoader::didFinishLoading): Only notify didFinishLoading instead of
  delivering a chunk of buffered data.
(WebKit::NetworkResourceLoader::didFail):
* NetworkProcess/NetworkResourceLoader.h:

* WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::didReceiveData): Pass through towards ResourceLoader.
(WebKit::NetworkProcessConnection::didFinishResourceLoad):
(WebKit::NetworkProcessConnection::didFailResourceLoad):
* WebProcess/Network/NetworkProcessConnection.h:
* WebProcess/Network/NetworkProcessConnection.messages.in:

* WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::WebResourceLoadScheduler::didReceiveData): Hand this chunk of data to the ResourceLoader directly.
(WebKit::WebResourceLoadScheduler::didFinishResourceLoad):
* WebProcess/Network/WebResourceLoadScheduler.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Mark webgl-background-color.html as failing.
dglazkov@chromium.org [Wed, 14 Nov 2012 18:07:01 +0000 (18:07 +0000)]
[Chromium] Mark webgl-background-color.html as failing.
http://webkit.org/b/102247

* platform/chromium/TestExpectations: Marked as failing.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening.
arv@chromium.org [Wed, 14 Nov 2012 17:57:27 +0000 (17:57 +0000)]
Unreviewed gardening.

Updating pixel tests expectations after r134613

* LayoutTests/platform/chromium/TestExpectations:
* platform/chromium-mac-snowleopard/svg/dom/SVGLengthList-appendItem-expected.png:
* platform/chromium-mac-snowleopard/svg/dom/SVGLengthList-basics-expected.png:
* platform/chromium-mac-snowleopard/svg/dom/SVGLengthList-getItem-expected.png:
* platform/chromium-mac-snowleopard/svg/dom/SVGLengthList-initialize-expected.png:
* platform/chromium-mac-snowleopard/svg/dom/SVGLengthList-insertItemBefore-expected.png:
* platform/chromium-mac-snowleopard/svg/dom/SVGLengthList-removeItem-expected.png:
* platform/chromium-mac-snowleopard/svg/dom/SVGLengthList-replaceItem-expected.png:
* platform/chromium-mac-snowleopard/svg/dom/SVGNumberList-basics-expected.png:
* platform/chromium-mac-snowleopard/svg/dom/SVGTransformList-basics-expected.png:
* platform/chromium-mac/svg/dom/SVGLengthList-appendItem-expected.png:
* platform/chromium-mac/svg/dom/SVGLengthList-basics-expected.png:
* platform/chromium-mac/svg/dom/SVGLengthList-getItem-expected.png:
* platform/chromium-mac/svg/dom/SVGLengthList-initialize-expected.png:
* platform/chromium-mac/svg/dom/SVGLengthList-insertItemBefore-expected.png:
* platform/chromium-mac/svg/dom/SVGLengthList-removeItem-expected.png:
* platform/chromium-mac/svg/dom/SVGLengthList-replaceItem-expected.png:
* platform/chromium-mac/svg/dom/SVGNumberList-basics-expected.png:
* platform/chromium-mac/svg/dom/SVGTransformList-basics-expected.png:
* platform/efl-wk1/svg/dom/SVGLengthList-getItem-expected.png: Renamed from LayoutTests/platform/efl/svg/dom/SVGLengthList-getItem-expected.png.
* platform/efl-wk1/svg/dom/SVGLengthList-removeItem-expected.png: Renamed from LayoutTests/platform/efl/svg/dom/SVGLengthList-removeItem-expected.png.
* platform/efl-wk1/svg/dom/SVGTransformList-basics-expected.png: Renamed from LayoutTests/platform/efl/svg/dom/SVGTransformList-basics-expected.png.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Use a node image if there is no drag image set for Drag&Drop
sergio@webkit.org [Wed, 14 Nov 2012 17:46:26 +0000 (17:46 +0000)]
[Qt] Use a node image if there is no drag image set for Drag&Drop
https://bugs.webkit.org/show_bug.cgi?id=102124

Reviewed by Simon Hausmann.

Use the nodeImage provided by the frame if there is no dragImage in
the clipboard for the current drag&drop operation.

* platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::createDragImage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCall to enclosingFilterLayer() in RenderObject::containerForRepaint() is expensive
commit-queue@webkit.org [Wed, 14 Nov 2012 17:37:48 +0000 (17:37 +0000)]
Call to enclosingFilterLayer() in RenderObject::containerForRepaint() is expensive
https://bugs.webkit.org/show_bug.cgi?id=101846

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-11-14
Reviewed by Simon Fraser.

If software-rendered CSS Filters have not been used in the document, avoid doing the second
tree walk in RenderObject::containerForRepaint, which determines the RenderObject's
enclosing filter layer.

No new tests. We now avoid a filters related code path for a performance improvement when
we're not using filters.

* page/FrameView.cpp:
(WebCore::FrameView::FrameView):
* page/FrameView.h:
(FrameView):
(WebCore::FrameView::setHasSoftwareFilters):
(WebCore::FrameView::hasSoftwareFilters):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateOrRemoveFilterEffectRenderer):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::containerForRepaint):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate DOMException name: NotFoundError
arv@chromium.org [Wed, 14 Nov 2012 17:33:01 +0000 (17:33 +0000)]
Update DOMException name: NotFoundError
https://bugs.webkit.org/show_bug.cgi?id=102137

Reviewed by Ojan Vafai.

Source/WebCore:

Patch 8 of 25 to update DOMException name to match the spec and Firefox.

Updated existing tests.

* dom/DOMCoreException.cpp:

LayoutTests:

Updated tests and expectations.

* fast/dom/Document/replaceChild-null-oldChild-expected.txt:
* fast/dom/Document/script-tests/replaceChild-null-oldChild.js:
* fast/dom/NamedNodeMap-setNamedItem-crash-expected.txt:
* fast/dom/Range/range-intersectsNode-expected.txt:
* fast/dom/incompatible-operations-expected.txt:
* fast/dom/incompatible-operations.html:
* fast/dom/setter-type-enforcement-expected.txt:
* fast/dom/timer-clear-interval-in-handler-and-generate-error-expected.txt:
* fast/events/remove-target-with-shadow-in-drag-expected.txt:
* fast/files/workers/worker-read-blob-sync-expected.txt:
* fast/files/workers/worker-read-file-sync-expected.txt:
* fast/inspector-support/uncaught-dom8-exception-expected.txt:
* fast/js/dot-node-base-exception-expected.txt:
* fast/js/script-tests/dot-node-base-exception.js:
* fast/mutation/observe-exceptions-expected.txt:
* platform/chromium-linux/fast/media/mq-js-media-except-01-expected.png:
* platform/chromium-win/fast/media/mq-js-media-except-01-expected.txt:
* platform/chromium/fast/dom/NamedNodeMap-setNamedItem-crash-expected.txt:
* platform/chromium/fast/dom/timer-clear-interval-in-handler-and-generate-error-expected.txt:
* platform/chromium/fast/events/remove-target-with-shadow-in-drag-expected.txt:
* platform/chromium/fast/files/workers/worker-read-blob-sync-expected.txt:
* platform/chromium/fast/inspector-support/uncaught-dom8-exception-expected.txt:
* platform/chromium/fast/media/mq-js-media-except-01-expected.txt:
* platform/efl/fast/media/mq-js-media-except-01-expected.txt:
* platform/gtk/fast/events/remove-target-with-shadow-in-drag-expected.txt:
* platform/gtk/fast/media/mq-js-media-except-01-expected.txt:
* platform/mac/fast/media/mq-js-media-except-01-expected.txt:
* platform/qt/fast/media/mq-js-media-except-01-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMark files that need rebaselines as failing.
dglazkov@chromium.org [Wed, 14 Nov 2012 17:07:11 +0000 (17:07 +0000)]
Mark files that need rebaselines as failing.
https://bugs.webkit.org/show_bug.cgi?id=102087

* platform/chromium/TestExpectations: Added expectations.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Use mispelled-marker offsets relative to the element
commit-queue@webkit.org [Wed, 14 Nov 2012 17:04:30 +0000 (17:04 +0000)]
[BlackBerry] Use mispelled-marker offsets relative to the element
https://bugs.webkit.org/show_bug.cgi?id=102236

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-11-14
Reviewed by Rob Buis.

DocumentMarker offsets are calculated relative to a node. This is causing
problems for contenteditable which can have numerous nodes. Creating a Range around a word
and calculating its location and length gives us the correct override in this case for starting
and ending points to pass to IMF.

Internally reviewed by Mike Fenton.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Updating BB Cookie database to use WAL
commit-queue@webkit.org [Wed, 14 Nov 2012 16:53:06 +0000 (16:53 +0000)]
[BlackBerry] Updating BB Cookie database to use WAL
https://bugs.webkit.org/show_bug.cgi?id=102237

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-11-14
Reviewed by Rob Buis.

The cookie database is accessed by one process only and should be updated to
use the WAL journal mode for better I/O performance.

PR 236553

cookieCollection.db-wal is created after the conversion to WAL.
Tested cookie persistence by logging on to random sites and restarting the browser and
check if it automatically logs in.
Also tested using Opera's cookie persistence test.

* platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp:
(WebCore::CookieDatabaseBackingStore::invokeOpen):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][ARM] Fix 'nullptr' is a keyword in C++11 [-Wc++0x-compat] warning
commit-queue@webkit.org [Wed, 14 Nov 2012 16:31:03 +0000 (16:31 +0000)]
[Qt][ARM] Fix 'nullptr' is a keyword in C++11 [-Wc++0x-compat] warning
https://bugs.webkit.org/show_bug.cgi?id=102083

Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-11-14
Reviewed by Csaba Osztrogonác.

Modified compiler name regex in condition that tests if -std=c++0x, c++11,
gnu++0x or gnu++11 are enabled in order to match linux-arm-gnueabi-g++ too,
thus enabling -Wno-c++0x-compat also on ARM compiler.

* qmake/mkspecs/features/unix/default_post.prf:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate DOMException name: IndexSizeError
arv@chromium.org [Wed, 14 Nov 2012 16:26:18 +0000 (16:26 +0000)]
Update DOMException name: IndexSizeError
https://bugs.webkit.org/show_bug.cgi?id=102087

Reviewed by Ojan Vafai.

Source/WebCore:

This is the first in a series of updates to DOMException name to match
the spec and Firefox.

Patch 1 of 25

Updated existing tests.

* dom/DOMCoreException.cpp:
(WebCore):

LayoutTests:

Updated tests and expectations.

* editing/selection/extend-expected.txt:
* fast/canvas/canvas-getImageData-invalid-expected.txt:
* fast/canvas/canvas-overloads-drawImage-expected.txt:
* fast/canvas/script-tests/canvas-getImageData-invalid.js:
* fast/canvas/script-tests/canvas-overloads-drawImage.js:
* fast/canvas/webgl/data-view-test-expected.txt:
* fast/dom/HTMLInputElement/input-size-attribute-expected.txt:
* fast/dom/HTMLInputElement/input-size-attribute.html:
* fast/dom/HTMLSelectElement/select-selectedIndex-expected.txt:
* fast/dom/HTMLSelectElement/select-selectedIndex-multiple-expected.txt:
* fast/dom/css-mediarule-functions-expected.txt:
* fast/dom/css-mediarule-functions.html:
* fast/forms/input-maxlength-expected.txt:
* fast/forms/input-maxlength.html:
* fast/forms/number/number-size-expected.txt:
* fast/forms/number/number-size.html:
* fast/forms/search/search-setrangetext-expected.txt:
* fast/forms/setrangetext-expected.txt:
* fast/forms/textarea-maxlength-expected.txt:
* fast/forms/textarea-maxlength.html:
* fast/forms/textarea/textarea-setrangetext-expected.txt:
* fast/html/marquee-element-expected.txt:
* fast/inspector-support/uncaught-dom1-exception-expected.txt:
* fast/js/select-options-add-expected.txt:
* fast/speech/scripted/speechgrammar-basics-expected.txt:
* inspector/styles/set-property-boundaries-expected.txt:
* platform/chromium-mac/fast/dynamic/015-expected.txt:
* platform/chromium-win/fast/dynamic/015-expected.txt:
* platform/chromium/canvas/philip/tests/2d.missingargs-expected.txt:
* platform/chromium/fast/inspector-support/uncaught-dom1-exception-expected.txt:
* platform/efl/fast/dynamic/015-expected.txt:
* platform/gtk/fast/dynamic/015-expected.txt:
* platform/mac/canvas/philip/tests/2d.missingargs-expected.txt:
* platform/mac/fast/dynamic/015-expected.txt:
* platform/qt/fast/dynamic/015-expected.txt:
* svg/custom/acid3-test-77-expected.txt:
* svg/custom/getSubStringLength-expected.txt:
* svg/custom/selectSubString-expected.txt:
* svg/dom/SVGLengthList-appendItem-expected.txt:
* svg/dom/SVGLengthList-basics-expected.txt:
* svg/dom/SVGLengthList-getItem-expected.txt:
* svg/dom/SVGLengthList-initialize-expected.txt:
* svg/dom/SVGLengthList-insertItemBefore-expected.txt:
* svg/dom/SVGLengthList-removeItem-expected.txt:
* svg/dom/SVGLengthList-replaceItem-expected.txt:
* svg/dom/SVGNumberList-basics-expected.txt:
* svg/dom/SVGPathSegList-clear-and-initialize-expected.txt:
* svg/dom/SVGPointList-basics-expected.txt:
* svg/dom/SVGStringList-basics-expected.txt:
* svg/dom/SVGTransformList-basics-expected.txt:
* svg/dom/svglist-exception-on-out-bounds-error-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][ARM]REGRESSION(r133985): It broke the build
ossy@webkit.org [Wed, 14 Nov 2012 16:18:10 +0000 (16:18 +0000)]
[Qt][ARM]REGRESSION(r133985): It broke the build
https://bugs.webkit.org/show_bug.cgi?id=101740

Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2012-11-14
Reviewed by Csaba Osztrogonác.

Changed the emitGenericContiguousPutByVal to accept the additional IndexingType argument.
This information was passed as a template parameter.

* jit/JIT.h:
(JSC::JIT::emitInt32PutByVal):
(JSC::JIT::emitDoublePutByVal):
(JSC::JIT::emitContiguousPutByVal):
(JIT):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emitGenericContiguousPutByVal):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emitGenericContiguousPutByVal):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix [-Wmissing-braces] warnings in graphics/cpu/arm/GraphicsContext3DNEON.h
rgabor@webkit.org [Wed, 14 Nov 2012 16:02:43 +0000 (16:02 +0000)]
Fix [-Wmissing-braces] warnings in graphics/cpu/arm/GraphicsContext3DNEON.h
https://bugs.webkit.org/show_bug.cgi?id=102205

Reviewed by Csaba Osztrogonác.

Fixing some warnings in GraphicsContext3DNEON.h which have been caused by missing braces.

* platform/graphics/cpu/arm/GraphicsContext3DNEON.h:
(WebCore::ARM::unpackOneRowOfRGBA4444ToRGBA8NEON):
(WebCore::ARM::unpackOneRowOfRGBA5551ToRGBA8NEON):
(WebCore::ARM::unpackOneRowOfRGB565ToRGBA8NEON):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate DOMException name: NoDataAllowedError
arv@chromium.org [Wed, 14 Nov 2012 15:55:48 +0000 (15:55 +0000)]
Update DOMException name: NoDataAllowedError
https://bugs.webkit.org/show_bug.cgi?id=102132

Reviewed by Darin Adler.

Patch 6 of 25 to update DOMException name to match the spec and Firefox.

NO_DATA_ALLOWED_ERR is historical and not used in any spec or in our code.

* dom/DOMCoreException.cpp:
(WebCore):
* dom/ExceptionCode.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][ARM] Enable the DFG JIT on ARMv7(Thumb2)
ossy@webkit.org [Wed, 14 Nov 2012 15:35:38 +0000 (15:35 +0000)]
[Qt][ARM] Enable the DFG JIT on ARMv7(Thumb2)
https://bugs.webkit.org/show_bug.cgi?id=101747

Reviewed by Simon Hausmann.

* wtf/Platform.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix the MIPS build after r134332
commit-queue@webkit.org [Wed, 14 Nov 2012 15:25:25 +0000 (15:25 +0000)]
Fix the MIPS build after r134332
https://bugs.webkit.org/show_bug.cgi?id=102227

Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2012-11-14
Reviewed by Csaba Osztrogonác.

Added missing methods for the MacroAssemblerMIPS, based on the MacroAssemblerARMv7.

* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::canJumpReplacePatchableBranchPtrWithPatch):
(MacroAssemblerMIPS):
(JSC::MacroAssemblerMIPS::startOfPatchableBranchPtrWithPatch):
(JSC::MacroAssemblerMIPS::revertJumpReplacementToPatchableBranchPtrWithPatch):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Add some missing pixel expectations.
rakuco@webkit.org [Wed, 14 Nov 2012 15:20:02 +0000 (15:20 +0000)]
[EFL] Add some missing pixel expectations.

* platform/efl/fast/multicol/span/anonymous-split-block-crash-expected.png: Added.
* platform/efl/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png: Added.
* platform/efl/fast/replaced/width100percent-textarea-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] WK1 gardening.
rakuco@webkit.org [Wed, 14 Nov 2012 15:14:41 +0000 (15:14 +0000)]
[EFL] WK1 gardening.

Skip fast/dom/Window/open-window-min-size.html and add some
WK1-specific pixel results which do not look wrong per se.

* platform/efl-wk1/TestExpectations:
* platform/efl-wk1/fast/repaint/japanese-rl-selection-clear-expected.png: Added.
* platform/efl-wk1/fast/repaint/selection-after-delete-expected.png: Added.
* platform/efl-wk1/fast/repaint/selection-after-remove-expected.png: Added.
* platform/efl-wk1/fast/repaint/selection-gap-overflow-scroll-2-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: "Reveal in Element Panel" doesn't work if Elements panel hasn't been...
pfeldman@chromium.org [Wed, 14 Nov 2012 15:12:08 +0000 (15:12 +0000)]
Web Inspector: "Reveal in Element Panel" doesn't work if Elements panel hasn't been opened
https://bugs.webkit.org/show_bug.cgi?id=102219

Reviewed by Alexander Pavlov.

Force elements module load upon context menu invocation.

* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired.focusElement):
(WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening. Skip failing tests.
kadam@inf.u-szeged.hu [Wed, 14 Nov 2012 14:52:25 +0000 (14:52 +0000)]
[Qt] Unreviewed gardening. Skip failing tests.

* platform/qt/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix the [-Wreturn-type] warning in JavaScriptCore/assembler/MacroAssemblerARM.h
ossy@webkit.org [Wed, 14 Nov 2012 14:51:59 +0000 (14:51 +0000)]
Fix the [-Wreturn-type] warning in JavaScriptCore/assembler/MacroAssemblerARM.h
https://bugs.webkit.org/show_bug.cgi?id=102206

Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2012-11-14
Reviewed by Csaba Osztrogonác.

Add a return value for the function to suppress the warning.

* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::startOfPatchableBranchPtrWithPatch):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r134599.
ossy@webkit.org [Wed, 14 Nov 2012 14:41:46 +0000 (14:41 +0000)]
Unreviewed, rolling out r134599.
http://trac.webkit.org/changeset/134599
https://bugs.webkit.org/show_bug.cgi?id=102225

It broke the 32 bit EFL build (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-14

* jit/JITPropertyAccess.cpp:
* jit/JITPropertyAccess32_64.cpp:
(JSC):
(JSC::JIT::emitGenericContiguousPutByVal):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r134523.
commit-queue@webkit.org [Wed, 14 Nov 2012 14:40:23 +0000 (14:40 +0000)]
Unreviewed, rolling out r134523.
http://trac.webkit.org/changeset/134523
https://bugs.webkit.org/show_bug.cgi?id=102218

brake chrome windows build, as it references a non existing
header js/DOMRequestState.h (Requested by jochen__ on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-14

Source/WebCore:

* Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::setValueReady):
* Modules/indexeddb/IDBCursor.h:
(IDBCursor):
* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::stop):
(WebCore::IDBRequest::dispatchEvent):
* Modules/indexeddb/IDBRequest.h:
(IDBRequest):
* WebCore.gypi:
* bindings/v8/DOMRequestState.h: Removed.
* bindings/v8/IDBBindingUtilities.cpp:
(WebCore::deserializeIDBValue):
(WebCore::idbKeyToScriptValue):
* bindings/v8/IDBBindingUtilities.h:
(WebCore):

Source/WebKit/chromium:

* src/WebIDBKey.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd platform implementation of remote web inspector server for GTK port.
commit-queue@webkit.org [Wed, 14 Nov 2012 14:26:14 +0000 (14:26 +0000)]
Add platform implementation of remote web inspector server for GTK port.
https://bugs.webkit.org/show_bug.cgi?id=88094

Patch by Anton Obzhirov <a.obzhirov@samsung.com> on 2012-11-14
Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Extra SocketStreamHandle constructor is added to accept existing GSocketConnection.
Needed to pass remote inspector server socket connection. The change is tested with
inspector server API tests.

* platform/network/soup/SocketStreamHandle.h:
(WebCore::SocketStreamHandle::create):
(SocketStreamHandle):
* platform/network/soup/SocketStreamHandleSoup.cpp:
(WebCore::SocketStreamHandle::SocketStreamHandle):
(WebCore):
(WebCore::SocketStreamHandle::connected):
(WebCore::SocketStreamHandle::platformSend):
(WebCore::SocketStreamHandle::platformClose):

Source/WebKit2:

The platform implementation is based on GSocket API (WebInspectorServerGtk.cpp and WebSocketServerGtk.cpp).
The server listens on port 2999 by default. IP address of the server can be set
in WEBKIT_INSPECTOR_SERVER (for example export WEBKIT_INSPECTOR_SERVER="192.168.124.130:2999").
The server is started during WebKit context initialization.
Once a page is loaded insector server can be accessed via other WebKit based browser.
New WebKit API gtk tests have beed added.
inspectorPageIndex.html has been moved to new location to share the file between GTK and Qt ports.

Test: test-page-list, test-remote-debugging-message, test-open-debugging-session

* GNUmakefile.am:
* GNUmakefile.list.am:
* Platform/Logging.cpp:
(WebKit):
(WebKit::getChannelFromName):
(WebKit::initializeLogChannelsIfNecessary):
* Platform/Logging.h:
(WebKit):
* UIProcess/API/gtk/tests/GNUmakefile.am:
* UIProcess/API/gtk/tests/InspectorTestServer.cpp: Added.
(loadChangedCallback):
(main):
* UIProcess/API/gtk/tests/TestInspectorServer.cpp: Added.
(stopTestServer):
(sigAbortHandler):
(testServerMonitorThreadFunc):
(startTestServerMonitor):
(startTestServer):
(testInspectorServerPageList):
(testRemoteDebuggingMessage):
(openRemoteDebuggingSession):
(beforeAll):
(afterAll):
* UIProcess/InspectorServer/WebInspectorServer.h:
(WebInspectorServer):
* UIProcess/InspectorServer/WebSocketServer.h:
(WebSocketServer):
* UIProcess/InspectorServer/WebSocketServerConnection.cpp:
(WebKit::WebSocketServerConnection::WebSocketServerConnection):
(WebKit::WebSocketServerConnection::shutdownNow):
(WebKit::WebSocketServerConnection::shutdownAfterSendOrNow):
(WebKit::WebSocketServerConnection::didCloseSocketStream):
(WebKit::WebSocketServerConnection::didReceiveSocketStreamData):
(WebKit):
(WebKit::WebSocketServerConnection::didUpdateBufferedAmount):
* UIProcess/InspectorServer/WebSocketServerConnection.h:
(WebSocketServerConnection):
* UIProcess/InspectorServer/front-end: Added.
* UIProcess/InspectorServer/front-end/inspectorPageIndex.html: Added.
* UIProcess/InspectorServer/gtk: Added.
* UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp: Added.
(WebKit):
(WebKit::WebInspectorServer::platformResourceForPath):
(WebKit::WebInspectorServer::buildPageList):
* UIProcess/InspectorServer/gtk/WebSocketServerGtk.cpp: Added.
(WebKit):
(WebKit::connectionCallback):
(WebKit::WebSocketServer::platformInitialize):
(WebKit::WebSocketServer::platformListen):
(WebKit::WebSocketServer::platformClose):
* UIProcess/gtk/WebContextGtk.cpp:
(WebKit::initInspectorServer):
(WebKit):
(WebKit::WebContext::platformInitializeWebProcess):
* WebKit2.qrc:
* config.h:
* qt/Resources/inspectorPageIndex.html: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][ARM]REGRESSION(r133985): It broke the build
ossy@webkit.org [Wed, 14 Nov 2012 14:23:35 +0000 (14:23 +0000)]
[Qt][ARM]REGRESSION(r133985): It broke the build
https://bugs.webkit.org/show_bug.cgi?id=101740

Patch by Balazs Kilvady <kilvadyb@homejinni.com> on 2012-11-14
Reviewed by Csaba Osztrogonác.

Template function body moved to fix VALUE_PROFILER disabled case.

* jit/JITPropertyAccess.cpp:
(JSC):
(JSC::JIT::emitGenericContiguousPutByVal):
* jit/JITPropertyAccess32_64.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed test fix for r134593.
loislo@chromium.org [Wed, 14 Nov 2012 14:03:20 +0000 (14:03 +0000)]
Unreviewed test fix for r134593.

* inspector-protocol/nmi-webaudio.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Unreviewed gardening.
dominik.rottsches@intel.com [Wed, 14 Nov 2012 13:35:16 +0000 (13:35 +0000)]
[EFL] Unreviewed gardening.

anchor-*download.html wander between crashing and failing.
Marking winsize test as failure and added to bug.

* platform/efl-wk2/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134597 268f45cc-cd09-0410-ab3c-d52691b4dbfc