WebKit.git
2 years agoCrash in many WebKit apps marking a connection invalid under Messages::NetworkProcess...
beidson@apple.com [Sat, 22 Jul 2017 00:15:00 +0000 (00:15 +0000)]
Crash in many WebKit apps marking a connection invalid under Messages::NetworkProcessProxy::canAuthenticateAgainstProtectionSpace.
<rdar://problem/28822272> and https://bugs.webkit.org/show_bug.cgi?id=174729

Reviewed by Tim Horton.

Previously, when a NetworkLoad generated a "CanAuthenticateAgainstProtectionSpace" event, the message went from
Network process -> Web process -> UI process.

In that case, MESSAGE_CHECKing the validity of the frame in WebPageProxy made sense.

In r202511 we cut the WebProcess out of this and had Networking go straight to UI process.

As a result, the message check became invalid. The Networking process cannot possible know the validity of
particular WebPage or WebFrame identifiers.

We simply need to validate the input in NetworkProcessProxy.

* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::canAuthenticateAgainstProtectionSpace): Validate both the page and frame ids before
  passing the call along to the WebPageProxy. Also, if either of those validations fail, respond to the network process.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRemove an inaccurate comment from RenderTextLineBoxes
timothy_horton@apple.com [Sat, 22 Jul 2017 00:13:11 +0000 (00:13 +0000)]
Remove an inaccurate comment from RenderTextLineBoxes

* rendering/RenderTextLineBoxes.cpp:
(WebCore::RenderTextLineBoxes::absoluteRectsForRange):
This comment has been wrong for at least 4 years.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoTextIndicator::estimatedTextColorsForRange asserts inside HashSet code (inserting...
timothy_horton@apple.com [Fri, 21 Jul 2017 23:34:18 +0000 (23:34 +0000)]
TextIndicator::estimatedTextColorsForRange asserts inside HashSet code (inserting reserved value)
https://bugs.webkit.org/show_bug.cgi?id=174733

Reviewed by Wenson Hsieh.

* page/TextIndicator.cpp:
(WebCore::estimatedTextColorsForRange):
(WebCore::adjustTextIndicatorDataOptionsForEstimatedColorsIfNecessary):
RGBA32 isn't a valid hash key, because we have no traits that define the
empty or deleted values, nor do we have any bits we could feasibly
use -- the full range of RGBA32 is easy to reach with various colors.

Instead, hash Color directly.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAX: Expose form validation on iOS as hint
n_wang@apple.com [Fri, 21 Jul 2017 23:25:21 +0000 (23:25 +0000)]
AX: Expose form validation on iOS as hint
https://bugs.webkit.org/show_bug.cgi?id=174722
<rdar://problem/33459761>

Reviewed by Chris Fleizach.

Source/WebCore:

Adding the validation message to the hint of the form control element.

Test: accessibility/ios-simulator/form-control-validation-message.html

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::isShowingValidationMessage):
(WebCore::AccessibilityObject::validationMessage):
* accessibility/AccessibilityObject.h:
* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityHint]):
(-[WebAccessibilityObjectWrapper accessibilityIsShowingValidationMessage]):
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::isShowingValidationMessage):
* html/HTMLFormControlElement.h:

LayoutTests:

* accessibility/ios-simulator/form-control-validation-message-expected.txt: Added.
* accessibility/ios-simulator/form-control-validation-message.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[iOS] Adopt UIImagePickerControllerImageURL for photo uploads
aestes@apple.com [Fri, 21 Jul 2017 22:44:32 +0000 (22:44 +0000)]
[iOS] Adopt UIImagePickerControllerImageURL for photo uploads
https://bugs.webkit.org/show_bug.cgi?id=174723
<rdar://problem/33223962>

Reviewed by Joseph Pecoraro.

In iOS 11, use the URL provided by UIImagePickerControllerImageURL, if available, as the
file URL for photo uploads. Since we use the UIImagePickerController imageExportPreset of
UIImagePickerControllerImageURLExportPresetCompatible, UIKit will take care of converting
HEIF images to JPEG for us. For other types (GIF, JPEG, and PNG), it will preserve the
original format.

Since UIImagePickerController now provides GIF and PNG representations, we no longer need to
use PHImageManager to access the original assets. This patch removes the
PHAsset/PHImageManager code added in r185241.

* Platform/spi/ios/PhotosSPI.h: Removed.
* UIProcess/ios/forms/WKFileUploadPanel.mm:
(-[WKFileUploadPanel _uploadItemFromMediaInfo:successBlock:failureBlock:]):
(-[WKFileUploadPanel _uploadItemForImage:withAssetURL:successBlock:failureBlock:]): Deleted.
* WebKit.xcodeproj/project.pbxproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWeb Inspector: inspect(aFunction) should jump to function definition
commit-queue@webkit.org [Fri, 21 Jul 2017 22:41:26 +0000 (22:41 +0000)]
Web Inspector: inspect(aFunction) should jump to function definition
https://bugs.webkit.org/show_bug.cgi?id=149344
<rdar://problem/11563607>

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2017-07-21
Reviewed by Matt Baker.

Source/WebInspectorUI:

* UserInterface/Protocol/InspectorObserver.js:
(WebInspector.InspectorObserver.prototype.inspect):
If we receive a function remote object jump to its location if available.

LayoutTests:

* inspector/runtime/CommandLineAPI-inspect-expected.txt: Added.
* inspector/runtime/CommandLineAPI-inspect.html: Added.
Add tests for the CommandLineAPI's inspect() and how it triggers the
`Inspector.inspect` event with a RemoteObject and hints.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAdjusted test expectations.
jlewis3@apple.com [Fri, 21 Jul 2017 22:22:26 +0000 (22:22 +0000)]
Adjusted test expectations.
https://bugs.webkit.org/show_bug.cgi?id=173861

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoFail gracefully when xcrun fails in IOSSimulatorPort constructor
jbedard@apple.com [Fri, 21 Jul 2017 22:20:37 +0000 (22:20 +0000)]
Fail gracefully when xcrun fails in IOSSimulatorPort constructor
https://bugs.webkit.org/show_bug.cgi?id=174724

Reviewed by Aakash Jain.

* Scripts/webkitpy/port/ios_simulator.py:
(IOSSimulatorPort.__init__): Ignore any errors when attempting to find a running
simulator. Errors here should be treated the same as no simulators found.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, fix Mac cmake build after r219733
annulen@yandex.ru [Fri, 21 Jul 2017 22:04:01 +0000 (22:04 +0000)]
Unreviewed, fix Mac cmake build after r219733

* PlatformMac.cmake:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[cmake][Mac] Unreviewed, fix linking WebKitSystemInterface
annulen@yandex.ru [Fri, 21 Jul 2017 21:26:15 +0000 (21:26 +0000)]
[cmake][Mac] Unreviewed, fix linking WebKitSystemInterface

After r219560 link_directories() in PlatformXXX.cmake files does not
affect corresponding targets.

* PlatformMac.cmake:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[WebIDL] Remove the need for the side map of DeprecatedCSSOMValue roots
commit-queue@webkit.org [Fri, 21 Jul 2017 21:20:25 +0000 (21:20 +0000)]
[WebIDL] Remove the need for the side map of DeprecatedCSSOMValue roots
https://bugs.webkit.org/show_bug.cgi?id=174713

Patch by Sam Weinig <sam@webkit.org> on 2017-07-21
Reviewed by Andreas Kling.

We used to not want to bloat the size of CSSValues with a pointer to the
owner CSSStyleDeclaration, so, for GC purposes we need kept a mapping of
them on DOMWrapperWorld that only got set if a wrapper was made. Now that
we have DeprecatedCSSOMValue, a wrapper for CSSValue that only gets created
for the bindings, we no longer need the side table, and simply have the
DeprecatedCSSOMValue maintain a reference to the CSSStyleDeclaration.

* bindings/js/DOMWrapperWorld.h:
(WebCore::DOMWrapperWorld::wrappers):
Remove m_deprecatedCSSOMValueRoots and make m_wrappers private with a getter.

* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclaration::getPropertyCSSValue): Deleted.
Remove custom implementation of getPropertyCSSValue, now that it no longer
needs to update m_deprecatedCSSOMValueRoots.

* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::fireFrameClearedWatchpointsForWindow):
* bindings/js/JSDOMWrapperCache.h:
(WebCore::getCachedWrapper):
(WebCore::cacheWrapper):
(WebCore::uncacheWrapper):
* bindings/js/JSNodeCustom.cpp:
(WebCore::getOutOfLineCachedWrapper):
Use wrappers getter rather than direct member variable.

* bindings/js/JSDeprecatedCSSOMValueCustom.cpp:
(WebCore::JSDeprecatedCSSOMValueOwner::isReachableFromOpaqueRoots):
Rather than checking the side table for roots, now get the root
via the reference CSSStyleDeclaration.

(WebCore::JSDeprecatedCSSOMValueOwner::finalize): Deleted.
Remove custom finalize now that we don't have to remove ourself
from m_deprecatedCSSOMValueRoots.

* css/CSSStyleDeclaration.idl:
Remove [Custom] from getPropertyCSSValue.

* css/DeprecatedCSSOMValue.idl:
Remove [JSCustomFinalize].

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSImageValue.cpp:
(WebCore::CSSImageValue::createDeprecatedCSSOMWrapper):
* css/CSSImageValue.h:
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::createDeprecatedCSSOMPrimitiveWrapper):
* css/CSSPrimitiveValue.h:
* css/CSSStyleDeclaration.h:
* css/CSSValue.cpp:
(WebCore::CSSValue::createDeprecatedCSSOMWrapper):
* css/CSSValue.h:
* css/DeprecatedCSSOMCounter.h:
* css/DeprecatedCSSOMPrimitiveValue.cpp:
(WebCore::DeprecatedCSSOMPrimitiveValue::getCounterValue):
(WebCore::DeprecatedCSSOMPrimitiveValue::getRectValue):
(WebCore::DeprecatedCSSOMPrimitiveValue::getRGBColorValue):
* css/DeprecatedCSSOMPrimitiveValue.h:
(WebCore::DeprecatedCSSOMPrimitiveValue::create):
(WebCore::DeprecatedCSSOMPrimitiveValue::DeprecatedCSSOMPrimitiveValue):
* css/DeprecatedCSSOMRGBColor.h:
* css/DeprecatedCSSOMRect.h:
* css/DeprecatedCSSOMValue.h:
(WebCore::DeprecatedCSSOMValue::owner):
(WebCore::DeprecatedCSSOMValue::DeprecatedCSSOMValue):
(WebCore::DeprecatedCSSOMComplexValue::create):
(WebCore::DeprecatedCSSOMComplexValue::DeprecatedCSSOMComplexValue):
* css/DeprecatedCSSOMValueList.h:
(WebCore::DeprecatedCSSOMValueList::create):
(WebCore::DeprecatedCSSOMValueList::DeprecatedCSSOMValueList):
* css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::wrapForDeprecatedCSSOM):
* css/PropertySetCSSStyleDeclaration.h:
* svg/SVGElement.cpp:
(WebCore::SVGElement::getPresentationAttribute):
Pass owning CSSStyleDeclaration to DeprecatedCSSOMValue and derived classes.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUse more references in event dispatch code
akling@apple.com [Fri, 21 Jul 2017 21:16:29 +0000 (21:16 +0000)]
Use more references in event dispatch code
https://bugs.webkit.org/show_bug.cgi?id=174681

Reviewed by Geoffrey Garen.

Source/WebCore:

Make EventListener::handleEvent() take a ScriptExecutionContext&, Event&.
Then make everything build again. Various null checks and assertions
disappear in the process.

* bindings/js/JSErrorHandler.cpp:
(WebCore::JSErrorHandler::handleEvent):
* bindings/js/JSErrorHandler.h:
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::initializeJSFunction):
(WebCore::JSEventListener::handleEvent):
(WebCore::eventHandlerAttribute):
* bindings/js/JSEventListener.h:
(WebCore::JSEventListener::jsFunction):
* bindings/js/JSLazyEventListener.cpp:
(WebCore::JSLazyEventListener::initializeJSFunction):
* bindings/js/JSLazyEventListener.h:
* dom/EventListener.h:
* dom/EventTarget.cpp:
(WebCore::EventTarget::fireEventListeners):
* html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::defaultEventHandler):
* html/ImageDocument.cpp:
(WebCore::ImageEventListener::handleEvent):
* inspector/CommandLineAPIHost.cpp:
(WebCore::listenerEntriesFromListenerInfo):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForEventListener):
* inspector/InspectorIndexedDBAgent.cpp:
* platform/Widget.h:
(WebCore::Widget::handleEvent):
* platform/cocoa/WebPlaybackSessionModelMediaElement.h:
* platform/cocoa/WebPlaybackSessionModelMediaElement.mm:
(WebCore::WebPlaybackSessionModelMediaElement::handleEvent):
* platform/cocoa/WebVideoFullscreenModelVideoElement.h:
* platform/cocoa/WebVideoFullscreenModelVideoElement.mm:
(WebVideoFullscreenModelVideoElement::handleEvent):
* svg/SVGTRefElement.cpp:
(WebCore::SVGTRefTargetEventListener::handleEvent):
* svg/animation/SVGSMILElement.cpp:
(WebCore::ConditionEventListener::handleEvent):
(WebCore::SVGSMILElement::handleConditionEvent):
* svg/animation/SVGSMILElement.h:

Source/WebKit:

* WebProcess/Plugins/PDF/PDFPluginAnnotation.h:
* WebProcess/Plugins/PDF/PDFPluginAnnotation.mm:
(WebKit::PDFPluginAnnotation::handleEvent):
(WebKit::PDFPluginAnnotation::PDFPluginAnnotationEventListener::handleEvent):
* WebProcess/Plugins/PDF/PDFPluginPasswordField.h:
* WebProcess/Plugins/PDF/PDFPluginPasswordField.mm:
(WebKit::PDFPluginPasswordField::handleEvent):
* WebProcess/Plugins/PDF/PDFPluginTextAnnotation.h:
* WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:
(WebKit::PDFPluginTextAnnotation::handleEvent):
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::createWebEvent):
(WebKit::PluginView::handleEvent):
* WebProcess/Plugins/PluginView.h:

Source/WebKitLegacy/mac:

* DOM/ObjCEventListener.h:
* DOM/ObjCEventListener.mm:
(WebCore::ObjCEventListener::handleEvent):
* WebCoreSupport/WebFrameLoaderClient.mm:
(NetscapePluginWidget::handleEvent):

Source/WebKitLegacy/win:

* DOMEventsClasses.cpp:
(WebEventListener::handleEvent):
* DOMEventsClasses.h:
* Plugins/PluginView.cpp:
(WebCore::PluginView::handleEvent):
* Plugins/PluginView.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoiBooks: Overlapping/missing content at beginning/end of paragraph.
zalan@apple.com [Fri, 21 Jul 2017 21:04:43 +0000 (21:04 +0000)]
iBooks: Overlapping/missing content at beginning/end of paragraph.
https://bugs.webkit.org/show_bug.cgi?id=174717
<rdar://problem/33117912>

Reviewed by Simon Fraser.

By definiton simple and normal line layout should always produce the exact same lineboxes. It enables us not
to force repaint while swapping between these 2 line layouts.
However in certain cases (font size pixel rounding as an example) they don't agree on how much content fits the line and
that could result in missing/overlapping content due to the lack of repaint.

Unable to test.

* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::ensureLineBoxes):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoDrop make_dom_exceptions.pl script that we only have DOMException
cdumez@apple.com [Fri, 21 Jul 2017 20:53:01 +0000 (20:53 +0000)]
Drop make_dom_exceptions.pl script that we only have DOMException
https://bugs.webkit.org/show_bug.cgi?id=174699

Reviewed by Darin Adler.

Drop make_dom_exceptions.pl script that we only have DOMException.

* CMakeLists.txt:
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreMacros.cmake:
* bindings/js/JSDOMExceptionHandling.cpp:
* css/FontFaceSet.cpp:
* dom/DOMAllInOne.cpp:
* dom/DOMExceptions.in: Removed.
* dom/ExceptionCodeDescription.cpp: Added.
(WebCore::ExceptionCodeDescription::ExceptionCodeDescription):
* dom/ExceptionCodeDescription.h: Added.
* dom/make_dom_exceptions.pl: Removed.
* inspector/WebInjectedScriptHost.cpp:
(WebCore::WebInjectedScriptHost::subtype):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRefactor MASM probe CPUState to use arrays for register storage.
mark.lam@apple.com [Fri, 21 Jul 2017 20:44:33 +0000 (20:44 +0000)]
Refactor MASM probe CPUState to use arrays for register storage.
https://bugs.webkit.org/show_bug.cgi?id=174694

Reviewed by Keith Miller.

Using arrays for register storage in CPUState allows us to do away with the
huge switch statements to decode each register id.  We can now simply index into
the arrays.

With this patch, we now:

1. Remove the need for macros for defining the list of CPU registers.
   We can go back to simple enums.  This makes the code easier to read.

2. Make the assembler the authority on register names.
   Most of this code is moved into the assembler from GPRInfo and FPRInfo.
   GPRInfo and FPRInfo now forwards to the assembler.

3. Make the assembler the authority on the number of registers of each type.

4. Fix a "bug" in ARMv7's lastRegister().  It was previously omitting lr and pc.
   This is inconsistent with how every other CPU architecture implements
   lastRegister().  This patch fixes it to return the true last GPR i.e. pc, but
   updates RegisterSet::reservedHardwareRegisters() to exclude those registers.

* assembler/ARM64Assembler.h:
(JSC::ARM64Assembler::numberOfRegisters):
(JSC::ARM64Assembler::firstSPRegister):
(JSC::ARM64Assembler::lastSPRegister):
(JSC::ARM64Assembler::numberOfSPRegisters):
(JSC::ARM64Assembler::numberOfFPRegisters):
(JSC::ARM64Assembler::gprName):
(JSC::ARM64Assembler::sprName):
(JSC::ARM64Assembler::fprName):
* assembler/ARMAssembler.h:
(JSC::ARMAssembler::numberOfRegisters):
(JSC::ARMAssembler::firstSPRegister):
(JSC::ARMAssembler::lastSPRegister):
(JSC::ARMAssembler::numberOfSPRegisters):
(JSC::ARMAssembler::numberOfFPRegisters):
(JSC::ARMAssembler::gprName):
(JSC::ARMAssembler::sprName):
(JSC::ARMAssembler::fprName):
* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::lastRegister):
(JSC::ARMv7Assembler::numberOfRegisters):
(JSC::ARMv7Assembler::firstSPRegister):
(JSC::ARMv7Assembler::lastSPRegister):
(JSC::ARMv7Assembler::numberOfSPRegisters):
(JSC::ARMv7Assembler::numberOfFPRegisters):
(JSC::ARMv7Assembler::gprName):
(JSC::ARMv7Assembler::sprName):
(JSC::ARMv7Assembler::fprName):
* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::numberOfRegisters):
(JSC::AbstractMacroAssembler::gprName):
(JSC::AbstractMacroAssembler::firstSPRegister):
(JSC::AbstractMacroAssembler::lastSPRegister):
(JSC::AbstractMacroAssembler::numberOfSPRegisters):
(JSC::AbstractMacroAssembler::sprName):
(JSC::AbstractMacroAssembler::numberOfFPRegisters):
(JSC::AbstractMacroAssembler::fprName):
* assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::numberOfRegisters):
(JSC::MIPSAssembler::firstSPRegister):
(JSC::MIPSAssembler::lastSPRegister):
(JSC::MIPSAssembler::numberOfSPRegisters):
(JSC::MIPSAssembler::numberOfFPRegisters):
(JSC::MIPSAssembler::gprName):
(JSC::MIPSAssembler::sprName):
(JSC::MIPSAssembler::fprName):
* assembler/MacroAssembler.h:
(JSC::MacroAssembler::CPUState::gprName):
(JSC::MacroAssembler::CPUState::sprName):
(JSC::MacroAssembler::CPUState::fprName):
(JSC::MacroAssembler::CPUState::gpr):
(JSC::MacroAssembler::CPUState::spr):
(JSC::MacroAssembler::CPUState::fpr):
(JSC::MacroAssembler::CPUState::pc):
(JSC::MacroAssembler::CPUState::fp):
(JSC::MacroAssembler::CPUState::sp):
(JSC::ProbeContext::gpr):
(JSC::ProbeContext::spr):
(JSC::ProbeContext::fpr):
(JSC::ProbeContext::gprName):
(JSC::ProbeContext::sprName):
(JSC::ProbeContext::fprName):
(JSC::MacroAssembler::numberOfRegisters): Deleted.
(JSC::MacroAssembler::numberOfFPRegisters): Deleted.
* assembler/MacroAssemblerARM.cpp:
* assembler/MacroAssemblerARM64.cpp:
(JSC::arm64ProbeTrampoline):
* assembler/MacroAssemblerARMv7.cpp:
* assembler/MacroAssemblerPrinter.cpp:
(JSC::Printer::nextID):
(JSC::Printer::printAllRegisters):
(JSC::Printer::printPCRegister):
(JSC::Printer::printRegisterID):
(JSC::Printer::printAddress):
* assembler/MacroAssemblerX86Common.cpp:
* assembler/X86Assembler.h:
(JSC::X86Assembler::numberOfRegisters):
(JSC::X86Assembler::firstSPRegister):
(JSC::X86Assembler::lastSPRegister):
(JSC::X86Assembler::numberOfSPRegisters):
(JSC::X86Assembler::numberOfFPRegisters):
(JSC::X86Assembler::gprName):
(JSC::X86Assembler::sprName):
(JSC::X86Assembler::fprName):
* jit/FPRInfo.h:
(JSC::FPRInfo::debugName):
* jit/GPRInfo.h:
(JSC::GPRInfo::debugName):
* jit/RegisterSet.cpp:
(JSC::RegisterSet::reservedHardwareRegisters):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWebResourceLoadStatisticsStore::m_operatingDates is unsafely modified from several...
cdumez@apple.com [Fri, 21 Jul 2017 20:40:13 +0000 (20:40 +0000)]
WebResourceLoadStatisticsStore::m_operatingDates is unsafely modified from several threads
https://bugs.webkit.org/show_bug.cgi?id=174721
<rdar://problem/33400343>

Reviewed by Brent Fulgham.

WebResourceLoadStatisticsStore::m_operatingDates is supposed to only be modified on
the background thread. However, WebResourceLoadStatisticsStore::performDailyTasks()
was mistakenly calling includeTodayAsOperatingDateIfNecessary() on the main thread,
which would modify m_operatingDates. This could lead to crashes such as the
one in <rdar://problem/33400343>, as the main thread may modify m_operatingDates
while we are interating over it on the background thread to save it to disk.

* UIProcess/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::performDailyTasks):
(WebKit::WebResourceLoadStatisticsStore::includeTodayAsOperatingDateIfNecessary):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[CG] An image should not invoke many system calls before confirming its format is...
commit-queue@webkit.org [Fri, 21 Jul 2017 20:38:21 +0000 (20:38 +0000)]
[CG] An image should not invoke many system calls before confirming its format is supported
https://bugs.webkit.org/show_bug.cgi?id=174692

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-07-21
Reviewed by Tim Horton.

We should be careful when invoking system calls before confirming that the
image type is available and it is one of the whitelist formats. Otherwise
we will be calling the parsers of the unsupported formats.

* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::setImageDataBuffer): The check isAllowedImageUTI()
is now done in ImageDecoder::encodedDataStatus() which will return Error
if there is an error in the data or "isAllowedImageUTI() returns false."

* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::dataChanged): Avoid calling canUseAsyncDecodingForLargeImages()
before confirming the image type is available and it's supported by WebKit.
canUseAsyncDecodingForLargeImages() tries to cache the first frame of the
image to know its size. Asking the ImageFrameCache to destroy its decoded
frames is not needed unless ImageFrameCache::decodedSize() is not zero.

* platform/graphics/cg/ImageDecoderCG.cpp:
(WebCore::ImageDecoder::encodedDataStatus): Avoid calling CGImageSourceGetStatus()
before knowing the UTI of the image. When knowing it, we call CGImageSourceGetStatus()
and if it returns kCGImageStatusIncomplete or kCGImageStatusComplete, we
check whether isAllowedImageUTI() or not. If isAllowedImageUTI() returns
false, return Error which will make the CachedImage cancel loading the
rest of the image.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAudioTrackPrivateMediaStreamCocoa shouldn't set AudioSession::setPreferredBufferSize
commit-queue@webkit.org [Fri, 21 Jul 2017 19:55:00 +0000 (19:55 +0000)]
AudioTrackPrivateMediaStreamCocoa shouldn't set AudioSession::setPreferredBufferSize
https://bugs.webkit.org/show_bug.cgi?id=174707
rdar://problem/33446809

Patch by Jeremy Jones <jeremyj@apple.com> on 2017-07-21
Reviewed by Eric Carlson.

Manually tested for audio side effects.

AudioChannel::copyFrom fails when AudioChannel lengths don't match.

This happens because PlatformMediaSessionManager::updateSessionState() owns and sets
AudioSession::setPreferredBufferSize().

However, AudioTrackPrivateMediaStreamCocoa::createAudioUnit, when it creates an input
audio unit is setting AudioSession::setPreferredBufferSize() directly to its own arbitrary value.

AudioSession::setPreferredBufferSize() should be managed by the higher level
PlatformMediaSessionManager, and not modified by audio unit creation, in order to keep harmony
within the audio pipeline.

* platform/mediastream/mac/AudioTrackPrivateMediaStreamCocoa.cpp:
(WebCore::AudioTrackPrivateMediaStreamCocoa::createAudioUnit):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoNoise when AudioChannel lengths don't match.
commit-queue@webkit.org [Fri, 21 Jul 2017 19:48:48 +0000 (19:48 +0000)]
Noise when AudioChannel lengths don't match.
https://bugs.webkit.org/show_bug.cgi?id=174706
rdar://problem/33389856

Patch by Jeremy Jones <jeremyj@apple.com> on 2017-07-21
Reviewed by Eric Carlson.

When AudioChannel lengths don't match, copyFrom() returns early leaving uninitialized data in the audio buffer.
This change zeros out the data, so there isn't objectionable noise sent to the speaker.

* platform/audio/AudioChannel.cpp:
(WebCore::AudioChannel::copyFrom):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[WebIDL] Make a few parameters non-nullable in inspector IDL files
commit-queue@webkit.org [Fri, 21 Jul 2017 19:39:57 +0000 (19:39 +0000)]
[WebIDL] Make a few parameters non-nullable in inspector IDL files
https://bugs.webkit.org/show_bug.cgi?id=174719

Patch by Sam Weinig <sam@webkit.org> on 2017-07-21
Reviewed by Joseph Pecoraro.

* inspector/CommandLineAPIHost.cpp:
(WebCore::CommandLineAPIHost::databaseId):
(WebCore::CommandLineAPIHost::storageId):
* inspector/CommandLineAPIHost.h:
* inspector/CommandLineAPIHost.idl:
* inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::storageId):
* inspector/InspectorDOMStorageAgent.h:
* inspector/InspectorDatabaseAgent.cpp:
(WebCore::InspectorDatabaseAgent::databaseId):
* inspector/InspectorDatabaseAgent.h:
* inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::showContextMenu):
(WebCore::InspectorFrontendHost::dispatchEventAsContextMenuEvent):
* inspector/InspectorFrontendHost.h:
* inspector/InspectorFrontendHost.idl:
Remove nullability from arguments that should never be null.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWeb Inspector: Avoid subclassing WebInspector.Object if we do not need to
commit-queue@webkit.org [Fri, 21 Jul 2017 19:36:40 +0000 (19:36 +0000)]
Web Inspector: Avoid subclassing WebInspector.Object if we do not need to
https://bugs.webkit.org/show_bug.cgi?id=174703

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2017-07-21
Reviewed by Brian Burg.

* UserInterface/Models/LogObject.js:
(WebInspector.LogObject):
(WebInspector.LogObject.prototype.get startDate): Deleted.
Remove unused startDate property as well.

* UserInterface/Base/YieldableTask.js:
* UserInterface/Debug/ProtocolTrace.js:
* UserInterface/Models/AnalyzerMessage.js:
* UserInterface/Models/ApplicationCacheFrame.js:
* UserInterface/Models/ApplicationCacheManifest.js:
* UserInterface/Models/BackForwardEntry.js:
* UserInterface/Models/Branch.js:
* UserInterface/Models/BreakpointAction.js:
* UserInterface/Models/CSSMedia.js:
* UserInterface/Models/CSSSelector.js:
* UserInterface/Models/CallFrame.js:
* UserInterface/Models/CallingContextTree.js:
* UserInterface/Models/CallingContextTreeNode.js:
* UserInterface/Models/CollectionEntry.js:
* UserInterface/Models/CollectionEntryPreview.js:
* UserInterface/Models/ConsoleMessage.js:
* UserInterface/Models/DOMSearchMatchObject.js:
* UserInterface/Models/DatabaseObject.js:
* UserInterface/Models/DatabaseTableObject.js:
* UserInterface/Models/DebuggerDashboard.js:
* UserInterface/Models/DebuggerData.js:
* UserInterface/Models/ExecutionContext.js:
* UserInterface/Models/ExecutionContextList.js:
* UserInterface/Models/GarbageCollection.js:
* UserInterface/Models/HeapSnapshotRootPath.js:
* UserInterface/Models/IndexedDatabase.js:
* UserInterface/Models/IndexedDatabaseObjectStore.js:
* UserInterface/Models/IndexedDatabaseObjectStoreIndex.js:
* UserInterface/Models/Instrument.js:
* UserInterface/Models/KeyboardShortcut.js:
* UserInterface/Models/LineWidget.js:
* UserInterface/Models/MemoryCategory.js:
* UserInterface/Models/MemoryPressureEvent.js:
* UserInterface/Models/ObjectPreview.js:
* UserInterface/Models/Probe.js:
* UserInterface/Models/ProbeSetDataFrame.js:
* UserInterface/Models/Profile.js:
* UserInterface/Models/ProfileNode.js:
* UserInterface/Models/ProfileNodeCall.js:
* UserInterface/Models/PropertyDescriptor.js:
* UserInterface/Models/PropertyPath.js:
* UserInterface/Models/PropertyPreview.js:
* UserInterface/Models/ResourceQueryMatch.js:
* UserInterface/Models/ResourceQueryResult.js:
* UserInterface/Models/ResourceTimingData.js:
* UserInterface/Models/Revision.js:
* UserInterface/Models/ScopeChainNode.js:
* UserInterface/Models/ScriptSyntaxTree.js:
* UserInterface/Models/SourceCodePosition.js:
* UserInterface/Models/SourceCodeSearchMatchObject.js:
* UserInterface/Models/SourceMap.js:
* UserInterface/Models/StackTrace.js:
* UserInterface/Models/StructureDescription.js:
* UserInterface/Models/TextMarker.js:
* UserInterface/Models/TextRange.js:
* UserInterface/Models/TimelineRange.js:
* UserInterface/Models/TypeDescription.js:
* UserInterface/Models/TypeSet.js:
* UserInterface/Protocol/ProtocolTracer.js:
* UserInterface/Proxies/FormatterWorkerProxy.js:
* UserInterface/Proxies/HeapSnapshotDiffProxy.js:
* UserInterface/Proxies/HeapSnapshotWorkerProxy.js:
* UserInterface/Test/TestSuite.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoGet rid of WebCore IconDatabase code.
beidson@apple.com [Fri, 21 Jul 2017 18:48:17 +0000 (18:48 +0000)]
Get rid of WebCore IconDatabase code.
https://bugs.webkit.org/show_bug.cgi?id=174700

Reviewed by Tim Horton.

Source/WebCore:

No new tests (No behavior change).

Tons of red.
Very little green.
No further explanation.

* CMakeLists.txt:
* WebCore.xcodeproj/project.pbxproj:
* dom/Document.cpp:
(WebCore::Document::implicitClose):
* history/HistoryItem.cpp:
(WebCore::HistoryItem::HistoryItem):
(WebCore::HistoryItem::~HistoryItem):
(WebCore::HistoryItem::reset):
(WebCore::HistoryItem::setURLString):
* inspector/InspectorNetworkAgent.cpp:
(WebCore::InspectorNetworkAgent::willSendRequest):
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::~DocumentLoader):
(WebCore::DocumentLoader::startIconLoading):
(WebCore::DocumentLoader::iconLoadDecisionAvailable): Deleted.
(WebCore::iconLoadDecisionCallback): Deleted.
(WebCore::DocumentLoader::getIconLoadDecisionForIconURL): Deleted.
(WebCore::DocumentLoader::continueIconLoadWithDecision): Deleted.
(WebCore::iconDataCallback): Deleted.
(WebCore::DocumentLoader::getIconDataForIconURL): Deleted.
* loader/DocumentLoader.h:
(WebCore::DocumentLoader::linkIcons):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::stop):
* loader/FrameLoader.h:
(WebCore::FrameLoader::subframeLoader):
(WebCore::FrameLoader::icon): Deleted.
* loader/FrameLoaderClient.h:
* loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::create):
* loader/icon/IconController.cpp: Removed.
* loader/icon/IconController.h: Removed.
* loader/icon/IconDatabase.cpp: Removed.
* loader/icon/IconDatabase.h: Removed.
* loader/icon/IconDatabaseBase.cpp: Removed.
* loader/icon/IconDatabaseBase.h: Removed.
* loader/icon/IconDatabaseClient.h: Removed.
* loader/icon/IconLoader.cpp:
(WebCore::IconLoader::IconLoader):
(WebCore::IconLoader::startLoading):
(WebCore::IconLoader::notifyFinished):
* loader/icon/IconLoader.h:
* loader/icon/IconRecord.cpp: Removed.
* loader/icon/IconRecord.h: Removed.
* loader/icon/PageURLRecord.cpp: Removed.
* loader/icon/PageURLRecord.h: Removed.
* testing/Internals.cpp:
(WebCore::Internals::shortcutIconURLs):

Source/WebKit:

* UIProcess/API/glib/WebKitWebContext.cpp:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::useIconLoadingClient): Deleted.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKitLegacy:

* WebKitLegacy.xcodeproj/project.pbxproj:

Source/WebKitLegacy/mac:

* Misc/WebCoreStatistics.mm:
(+[WebCoreStatistics iconPageURLMappingCount]):
(+[WebCoreStatistics iconRetainedPageURLCount]):
(+[WebCoreStatistics iconRecordCount]):
(+[WebCoreStatistics iconsWithDataCount]):
* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
* WebCoreSupport/WebIconDatabaseClient.h: Removed.
* WebCoreSupport/WebIconDatabaseClient.mm: Removed.
* WebView/WebView.mm:
(-[WebView mainFrameIconURL]):

LayoutTests:

* fast/dom/icon-url-list-expected.txt:
* fast/dom/icon-url-list.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[WTF] Drop initializeDate
utatane.tea@gmail.com [Fri, 21 Jul 2017 16:59:46 +0000 (16:59 +0000)]
[WTF] Drop initializeDate
https://bugs.webkit.org/show_bug.cgi?id=174714

Reviewed by Darin Adler.

minYear static variable will be initialized in an exclusive manner, which is ensured by C++ "static" semantics.
Thus, we do not need to call initializeDate() explicitly.

* wtf/DateMath.cpp:
(WTF::equivalentYearForDST):
(WTF::initializeDates): Deleted.
* wtf/Threading.cpp:
(WTF::initializeThreading):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[JSC] Introduce static symbols
utatane.tea@gmail.com [Fri, 21 Jul 2017 16:41:34 +0000 (16:41 +0000)]
[JSC] Introduce static symbols
https://bugs.webkit.org/show_bug.cgi?id=158863

Reviewed by Darin Adler.

Source/JavaScriptCore:

We use StaticSymbolImpl to initialize PrivateNames and builtin Symbols.
As a result, we can share the same Symbol values between VMs and threads.
And we do not need to allocate Ref<SymbolImpl> for these symbols at runtime.

* CMakeLists.txt:
* JavaScriptCore.xcodeproj/project.pbxproj:
* builtins/BuiltinNames.cpp: Added.
Suppress warning C4307, integral constant overflow. It is intentional in constexpr hash value calculation.

* builtins/BuiltinNames.h:
(JSC::BuiltinNames::BuiltinNames):
* builtins/BuiltinUtils.h:

Source/WTF:

We add a new class StaticSymbolImpl. StaticSymbolImpl can offer
the way to create static SymbolImpl. It can be shared between
multiple VMs and multiple threads.

* wtf/text/SymbolImpl.h:
(WTF::SymbolImpl::StaticSymbolImpl::StaticSymbolImpl):
(WTF::SymbolImpl::StaticSymbolImpl::operator SymbolImpl&):
For StaticSymbolImpl's hashForSymbol, we use usual string hash value.
Since all the SymbolImpls are unique, basically, any value is OK here.
Non-confilicting to the other SymbolImpls is ideal.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRename DOMCoreException class to DOMException
cdumez@apple.com [Fri, 21 Jul 2017 16:35:32 +0000 (16:35 +0000)]
Rename DOMCoreException class to DOMException
https://bugs.webkit.org/show_bug.cgi?id=174698

Reviewed by Darin Adler.

Rename DOMCoreException class to DOMException to match its Web-exposed name.

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* Modules/quota/StorageErrorCallback.cpp:
(WebCore::StorageErrorCallback::CallbackTask::CallbackTask):
* Modules/quota/StorageErrorCallback.h:
* Modules/quota/StorageErrorCallback.idl:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMExceptionHandling.cpp:
(WebCore::retrieveErrorMessage):
(WebCore::createDOMException):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateOverloadDispatcher):
* css/FontFaceSet.cpp:
* css/FontFaceSet.h:
* dom/DOMAllInOne.cpp:
* dom/DOMException.cpp: Renamed from Source/WebCore/dom/DOMCoreException.cpp.
(WebCore::DOMException::create):
(WebCore::DOMException::DOMException):
(WebCore::DOMException::initializeDescription):
* dom/DOMException.h: Renamed from Source/WebCore/dom/DOMCoreException.h.
(WebCore::DOMException::create):
(WebCore::DOMException::DOMException):
* dom/DOMException.idl: Renamed from Source/WebCore/dom/DOMCoreException.idl.
* dom/DOMExceptions.in:
* dom/make_dom_exceptions.pl:
(generateImplementation):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, rebaseline test after r219708.
cdumez@apple.com [Fri, 21 Jul 2017 16:34:49 +0000 (16:34 +0000)]
Unreviewed, rebaseline test after r219708.

* js/dom/global-constructors-attributes-expected.txt:
* platform/gtk/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-highsierra-wk1/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-highsierra/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
* platform/mac/js/dom/global-constructors-attributes-expected.txt:
* platform/win/js/dom/global-constructors-attributes-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[CMake] Add an option to stop build after generating project files
commit-queue@webkit.org [Fri, 21 Jul 2017 16:02:22 +0000 (16:02 +0000)]
[CMake] Add an option to stop build after generating project files
https://bugs.webkit.org/show_bug.cgi?id=174664

Patch by Yousuke Kimoto <Yousuke.Kimoto@sony.com> on 2017-07-21
Reviewed by Konstantin Tokarev.

Add "--generate-project-only" to stop build after generating project files.

* Scripts/build-webkit: Add '--generate-project-only' option and a checker to stop build.
* Scripts/webkitdirs.pm: Add a function to check '--generate-project-only' option and the same checker as the above
(buildCMakeProjectOrExit): Add a cheker to stop build stop build after generating project files.
(determineIsGenerateProjectOnly): Check if '--generate-project-only' option is specified
(isGenerateProjectOnly): ditto

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[FTL] Arguments elimination is suppressed by unreachable blocks
utatane.tea@gmail.com [Fri, 21 Jul 2017 16:01:01 +0000 (16:01 +0000)]
[FTL] Arguments elimination is suppressed by unreachable blocks
https://bugs.webkit.org/show_bug.cgi?id=174352

Reviewed by Filip Pizlo.

JSTests:

* stress/arguments-elimination-force-exit.js: Added.
(shouldBe):
(strict):
(sloppy):
* stress/arguments-elimination-throw.js: Added.
(shouldBe):
(shouldThrow):
(sloppy):
(isArguments):

Source/JavaScriptCore:

If we do not execute `op_get_by_id`, our value profiling tells us unpredictable and DFG emits ForceOSRExit.
The problem is that arguments elimination phase checks escaping even when ForceOSRExit preceeds.
Since GetById without information can escape arguments if it is specified, non-executed code including
op_get_by_id with arguments can escape arguments.

For example,

    function test(flag)
    {
        if (flag) {
            // This is not executed, but emits GetById with arguments.
            // It prevents us from eliminating materialization.
            return arguments.length;
        }
        return arguments.length;
    }
    noInline(test);
    while (true)
        test(false);

We do not perform CFA and dead-node clipping yet when performing arguments elimination phase.
So this GetById exists and escapes arguments.

To solve this problem, our arguments elimination phase checks preceding pseudo-terminal nodes.
If it is shown, following GetById does not escape arguments. Compared to performing AI, it is
lightweight. But it catches much of typical cases we failed to perform arguments elimination.

* dfg/DFGArgumentsEliminationPhase.cpp:
* dfg/DFGNode.h:
(JSC::DFG::Node::isPseudoTerminal):
* dfg/DFGValidate.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoFollow up to https://bugs.webkit.org/show_bug.cgi?id=174659.
weinig@apple.com [Fri, 21 Jul 2017 15:50:55 +0000 (15:50 +0000)]
Follow up to https://bugs.webkit.org/show_bug.cgi?id=174659.

* inspector/InspectorFrontendHost.idl:
Remove unnecessary JSGenerateToJSObject noticed in review.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringI...
utatane.tea@gmail.com [Fri, 21 Jul 2017 15:37:52 +0000 (15:37 +0000)]
[WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
https://bugs.webkit.org/show_bug.cgi?id=174501

Reviewed by Darin Adler.

Source/WTF:

When creating AtomicStringImpl from static StringImpl, we can just use createWithoutCopying
to create a BufferInternal AtomicStringImpl which m_data{8,16} is static string's one.

* wtf/text/AtomicStringImpl.cpp:
(WTF::CStringTranslator::hash):
(WTF::CStringTranslator::equal):
(WTF::CStringTranslator::translate):
(WTF::AtomicStringImpl::add):
(WTF::HashTranslatorCharBuffer::HashTranslatorCharBuffer):
(WTF::UCharBufferTranslator::hash):
(WTF::UCharBufferTranslator::equal):
(WTF::UCharBufferTranslator::translate):
(WTF::LCharBufferTranslator::hash):
(WTF::LCharBufferTranslator::equal):
(WTF::LCharBufferTranslator::translate):
(WTF::BufferFromStaticDataTranslator::hash):
(WTF::BufferFromStaticDataTranslator::equal):
(WTF::BufferFromStaticDataTranslator::translate):
(WTF::AtomicStringImpl::addLiteral):
(WTF::addSymbol):
(WTF::addStatic):
(WTF::AtomicStringImpl::addSlowCase):
(WTF::AtomicStringImpl::lookUp):
(WTF::CharBufferFromLiteralDataTranslator::hash): Deleted.
(WTF::CharBufferFromLiteralDataTranslator::equal): Deleted.
(WTF::CharBufferFromLiteralDataTranslator::translate): Deleted.
(WTF::addSubstring): Deleted.
* wtf/text/StringImpl.h:

Tools:

* TestWebKitAPI/Tests/WTF/StringImpl.cpp:
(TestWebKitAPI::TEST):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago [cmake] Unreviewed, add definitions necessary to use ICU shipped with macOS
annulen@yandex.ru [Fri, 21 Jul 2017 13:46:13 +0000 (13:46 +0000)]
   [cmake] Unreviewed, add definitions necessary to use ICU shipped with macOS

       macOS system ICU libraries are built with U_DISABLE_RENAMING=1 and
       U_SHOW_CPLUSPLUS_API=0. After r219155 we have to pass this definitons
       explicitly, because ICU headers in the tree are not modified anymore.

.:

* Source/cmake/OptionsJSCOnly.cmake:
* Source/cmake/OptionsMac.cmake:

Source/WTF:

* wtf/PlatformMac.cmake: Rely on ICU_LIBRARIES instead of passing ICU
library name explicitly in WTF_LIBRARIES.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWeb Automation: implicit navigations don't cause browsing context switch
carlosgc@webkit.org [Fri, 21 Jul 2017 10:22:25 +0000 (10:22 +0000)]
Web Automation: implicit navigations don't cause browsing context switch
https://bugs.webkit.org/show_bug.cgi?id=174633
<rdar://problem/33387797>

Reviewed by Brian Burg.

When a new page load replaces the current frameset, for example when a link in the current browser context has a
_top target, there's no explicit context switch, so the web driver doesn't know that the current browsing
context is no longer valid. Following commands will still be using the previous frame as the current browsing
context, but they don't fail with no such frame because the frame is still alive in the page cache and
referenced in the internal maps used in both UI and web processes. This causes test
testShouldFocusOnTheReplacementWhenAFrameFollowsALinkToA_TopTargetedPage to fail, since it expects a no such
frame exception. When a new page navigation happens we can simply remove references to frames from
m_handleWebFrameMap in WebAutomationSession, because any existing frame reference in the map should be for a
previous page. With this, before the next command is executed, waitForNavigationToComplete will be called and it
will fail with no such frame, condition that is handled to switch to the top level browser context. The test
still fails, because the find element command is called with the top level browsing context, returning no such
element, instead of no such frame. This is consistent with Chrome.

* UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::navigationOccurredForFrame): Clear the m_handleWebFrameMap when a new page load
finished.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWebDriver: wait until navigation is complete before running new commands and after...
carlosgc@webkit.org [Fri, 21 Jul 2017 09:50:49 +0000 (09:50 +0000)]
WebDriver: wait until navigation is complete before running new commands and after a click
https://bugs.webkit.org/show_bug.cgi?id=174670

Reviewed by Brian Burg.

Source/WebDriver:

We are already waiting for navigation to complete after navigation commands (go, back, forward, refresh), but
the spec says we should always wait before executing a new command and also after a click. This is causing test
testShouldBeAbleToNavigateBackInTheBrowserHistoryInPresenceOfIframes to sometimes fail, because it does .click()
+ .title and expects the title to tbe the one of the page loaded by the click. Since the load happens very fast,
the test usually passes, but in a real case with a slower load, the title of the previous page will be returned
most of the times.

6.3 Processing Model. Step 7. Wait for navigation to complete. If this returns an error return its value and
jump to step 1 in this overall algorithm, otherwise continue.
https://www.w3.org/TR/webdriver/#processing-model

14.1 Element Click. Step 10. If the click causes navigation: 1. Run the post-navigation checks and return its
value if it is an error. 2. Try to wait for navigation to complete.
https://www.w3.org/TR/webdriver/#element-click

* Session.cpp:
(WebDriver::Session::waitForNavigationToComplete): Send waitForNavigationToComplete message to the browser to
wait for any pending navigation of current browsing context to complete.
(WebDriver::Session::elementClick): Call waitForNavigationToComplete() after the click.
* Session.h:
* WebDriverService.cpp:
(WebDriver::WebDriverService::go): Wait for navigations to complete before running the command.
(WebDriver::WebDriverService::getCurrentURL): Ditto.
(WebDriver::WebDriverService::back): Ditto.
(WebDriver::WebDriverService::forward): Ditto.
(WebDriver::WebDriverService::refresh): Ditto.
(WebDriver::WebDriverService::getTitle): Ditto.
(WebDriver::WebDriverService::switchToFrame): Ditto.
(WebDriver::WebDriverService::switchToParentFrame): Ditto.
(WebDriver::WebDriverService::findElement): Ditto.
(WebDriver::WebDriverService::findElements): Ditto.
(WebDriver::WebDriverService::executeScript): Ditto.
(WebDriver::WebDriverService::executeAsyncScript): Ditto.

Source/WebKit:

Add waitForNavigationToComplete method to Automation to allow WebDriver to wait for pending navigations to
complete. The new method already receives page load strategy and timeout, but they are not implemented yet.

* UIProcess/Automation/Automation.json: Add waitForNavigationToComplete method and PageLoadStrategy new type.
* UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::waitForNavigationToComplete): Call waitForNavigationToCompleteOnPage or
waitForNavigationToCompleteOnFrame depending on whether the current borwsing context is the main frame or not.
(WebKit::WebAutomationSession::waitForNavigationToCompleteOnPage): Check if there's an ongoing load for the page,
and wait for it to complete if needed.
(WebKit::WebAutomationSession::waitForNavigationToCompleteOnFrame): Check if there's an ongoing load for the frame,
and wait for it to complete if needed.
(WebKit::WebAutomationSession::navigateBrowsingContext): Use waitForNavigationToCompleteOnPage() now.
(WebKit::WebAutomationSession::goBackInBrowsingContext): Ditto.
(WebKit::WebAutomationSession::goForwardInBrowsingContext): Ditto.
(WebKit::WebAutomationSession::reloadBrowsingContext): Ditto.
(WebKit::WebAutomationSession::navigationOccurredForFrame): Renamed since it now receives the notification for
all the frames. Complete page operations if it's a main frame, or frame operations otherwise.
* UIProcess/Automation/WebAutomationSession.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didFinishLoadForFrame): Notify about all frames, not only the main one.
(WebKit::WebPageProxy::didFailLoadForFrame): Ditto.
(WebKit::WebPageProxy::didSameDocumentNavigationForFrame): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWebDriver: correctly handle main frame handles
carlosgc@webkit.org [Fri, 21 Jul 2017 09:43:13 +0000 (09:43 +0000)]
WebDriver: correctly handle main frame handles
https://bugs.webkit.org/show_bug.cgi?id=174668

Reviewed by Brian Burg.

When I switched to use std::optional instead of empty strings for the browsing contexts in WebDriver, I forgot
that automation uses empty string for frames to refer to the main frame. We should handle that case, because we
are currently considering empty strings as valid browsing context. It's not a big deal because Automation
converts back the empty string received to the main frame, though. We should also ensure we close the current
browsing context when switching to a new top level browsing context. This patch adds to helper private methods
to switch browsing contexts that deal with the special cases.

* Session.cpp:
(WebDriver::Session::close):
(WebDriver::Session::switchToTopLevelBrowsingContext):
(WebDriver::Session::switchToBrowsingContext):
(WebDriver::Session::createTopLevelBrowsingContext):
(WebDriver::Session::go):
(WebDriver::Session::back):
(WebDriver::Session::forward):
(WebDriver::Session::refresh):
(WebDriver::Session::switchToWindow):
(WebDriver::Session::switchToFrame):
(WebDriver::Session::switchToParentFrame):
* Session.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[GTK] Update test expectations after r219663
csaavedra@igalia.com [Fri, 21 Jul 2017 08:22:20 +0000 (08:22 +0000)]
[GTK] Update test expectations after r219663

Unreviewed gardening

DOMException got its toString() removed so the output changes.

* platform/gtk/crypto/subtle/aes-cbc-cfb-decrypt-malformed-parameters-expected.txt:
* platform/gtk/crypto/subtle/aes-cbc-cfb-encrypt-malformed-parameters-expected.txt:
* platform/gtk/crypto/subtle/aes-export-key-malformed-parameters-expected.txt:
* platform/gtk/crypto/subtle/aes-generate-key-malformed-parameters-expected.txt:
* platform/gtk/crypto/subtle/aes-import-key-malformed-parameters-expected.txt:
* platform/gtk/crypto/subtle/rsa-generate-key-malformed-parameters-expected.txt:
* platform/gtk/crypto/subtle/rsa-import-key-malformed-parameters-expected.txt:
* platform/gtk/fast/mediastream/RTCPeerConnection-closed-state-expected.txt:
* platform/gtk/fast/text/font-selection-font-loading-api-parse-expected.txt:
* platform/gtk/http/tests/dom/document-attributes-null-handling-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[WPE] Update expectation file
csaavedra@igalia.com [Fri, 21 Jul 2017 07:40:21 +0000 (07:40 +0000)]
[WPE] Update expectation file

Unreviewed gardening.

Drop XPathException after r219708.

* platform/wpe/js/dom/global-constructors-attributes-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed. Remove WKIconDatabaseCairo.
carlosgc@webkit.org [Fri, 21 Jul 2017 06:38:09 +0000 (06:38 +0000)]
Unreviewed. Remove WKIconDatabaseCairo.

* PlatformGTK.cmake:
* PlatformWPE.cmake:
* UIProcess/API/C/cairo/WKIconDatabaseCairo.cpp: Removed.
* UIProcess/API/C/cairo/WKIconDatabaseCairo.h: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoTurn tests at media/modern-media-controls/seek-forward-support back on
graouts@webkit.org [Fri, 21 Jul 2017 06:34:29 +0000 (06:34 +0000)]
Turn tests at media/modern-media-controls/seek-forward-support back on
https://bugs.webkit.org/show_bug.cgi?id=174690

Reviewed by Dean Jackson.

* platform/mac/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoTurn tests at media/modern-media-controls/seek-backward-support back on
graouts@webkit.org [Fri, 21 Jul 2017 06:32:18 +0000 (06:32 +0000)]
Turn tests at media/modern-media-controls/seek-backward-support back on
https://bugs.webkit.org/show_bug.cgi?id=174689

Reviewed by Dean Jackson.

* platform/mac/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoTurn tests at media/modern-media-controls/time-labels-support back on
graouts@webkit.org [Fri, 21 Jul 2017 06:29:25 +0000 (06:29 +0000)]
Turn tests at media/modern-media-controls/time-labels-support back on
https://bugs.webkit.org/show_bug.cgi?id=174688

Reviewed by Dean Jackson.

* media/modern-media-controls/time-labels-support/elapsed-time-expected.txt:
* media/modern-media-controls/time-labels-support/elapsed-time.html:
* media/modern-media-controls/time-labels-support/remaining-time-expected.txt:
* media/modern-media-controls/time-labels-support/remaining-time.html:
* platform/ios-simulator/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoTurn tests at media/modern-media-controls/status-support back on
graouts@webkit.org [Fri, 21 Jul 2017 06:28:34 +0000 (06:28 +0000)]
Turn tests at media/modern-media-controls/status-support back on
https://bugs.webkit.org/show_bug.cgi?id=174687

Reviewed by Dean Jackson.

* platform/ios-simulator/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoGet rid of IconDatabase related code in WebKit.
beidson@apple.com [Fri, 21 Jul 2017 04:10:54 +0000 (04:10 +0000)]
Get rid of IconDatabase related code in WebKit.
https://bugs.webkit.org/show_bug.cgi?id=174693

Reviewed by Tim Horton.

This leaves the C-API class but guts it.

No explanations of the other changes are needed.

* CMakeLists.txt:
* DerivedSources.make:
* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
* UIProcess/API/C/WKContext.cpp:
(WKContextGetIconDatabase):
(WKContextSetIconDatabasePath):
* UIProcess/API/C/WKIconDatabase.cpp:
(WKIconDatabaseSetIconDatabaseClient):
(WKIconDatabaseRetainIconForURL):
(WKIconDatabaseReleaseIconForURL):
(WKIconDatabaseSetIconDataForIconURL):
(WKIconDatabaseSetIconURLForPageURL):
(WKIconDatabaseCopyIconURLForPageURL):
(WKIconDatabaseCopyIconDataForPageURL):
(WKIconDatabaseEnableDatabaseCleanup):
(WKIconDatabaseRemoveAllIcons):
(WKIconDatabaseCheckIntegrityBeforeOpening):
(WKIconDatabaseClose):
* UIProcess/API/C/cg/WKIconDatabaseCG.cpp:
(WKIconDatabaseTryGetCGImageForURL):
(WKIconDatabaseTryCopyCGImageArrayForURL):
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformDefaultIconDatabasePath): Deleted.
* UIProcess/WebIconDatabase.cpp: Removed.
* UIProcess/WebIconDatabase.h:
(WebKit::WebIconDatabase::clearProcessPool): Deleted.
* UIProcess/WebIconDatabase.messages.in: Removed.
* UIProcess/WebIconDatabaseClient.cpp: Removed.
* UIProcess/WebIconDatabaseClient.h: Removed.
* UIProcess/WebProcessPool.cpp:
(WebKit::m_hiddenPageThrottlingTimer):
(WebKit::WebProcessPool::~WebProcessPool):
(WebKit::WebProcessPool::setAnyPageGroupMightHavePrivateBrowsingEnabled):
(WebKit::WebProcessPool::createNewWebProcess):
(WebKit::WebProcessPool::setIconDatabasePath): Deleted.
(WebKit::WebProcessPool::iconDatabasePath): Deleted.
* UIProcess/WebProcessPool.h:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::processWillShutDown):
(WebKit::WebProcessProxy::retainIconForPageURL): Deleted.
(WebKit::WebProcessProxy::releaseIconForPageURL): Deleted.
(WebKit::WebProcessProxy::releaseRemainingIconsForPageURLs): Deleted.
* UIProcess/WebProcessProxy.h:
* UIProcess/WebProcessProxy.messages.in:
* UIProcess/gtk/WebProcessPoolGtk.cpp:
(WebKit::WebProcessPool::platformDefaultIconDatabasePath): Deleted.
* UIProcess/wpe/WebProcessPoolWPE.cpp:
(WebKit::WebProcessPool::platformDefaultIconDatabasePath): Deleted.
* WebKit.xcodeproj/project.pbxproj:
* WebProcess/IconDatabase/WebIconDatabaseProxy.cpp: Removed.
* WebProcess/IconDatabase/WebIconDatabaseProxy.h: Removed.
* WebProcess/IconDatabase/WebIconDatabaseProxy.messages.in: Removed.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::getWebCoreStatistics):
* WebProcess/WebProcess.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoDrop legacy SVGException type
cdumez@apple.com [Fri, 21 Jul 2017 02:36:52 +0000 (02:36 +0000)]
Drop legacy SVGException type
https://bugs.webkit.org/show_bug.cgi?id=174695

Reviewed by Darin Adler.

Source/WebCore:

Drop legacy SVGException type and use DOMException instead, as per the latest
SVG specification. Both Chrome and Firefox no longer expose the SVGException
type.

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMExceptionHandling.cpp:
(WebCore::createDOMException):
* bindings/js/JSExceptionBase.cpp:
(WebCore::toExceptionBase):
* dom/DOMExceptions.in:
* svg/SVGAllInOne.cpp:
* svg/SVGCircleElement.cpp:
* svg/SVGException.cpp: Removed.
* svg/SVGException.h: Removed.
* svg/SVGException.idl: Removed.
* svg/SVGGraphicsElement.idl:
* svg/SVGLocatable.cpp:
(WebCore::SVGLocatable::getTransformToElement):
* svg/SVGMatrixValue.h:
* svg/SVGPathSegList.cpp:
(WebCore::SVGPathSegList::getItem):
(WebCore::SVGPathSegList::replaceItem):
(WebCore::SVGPathSegList::removeItem):
* svg/SVGPathSegList.h:
* svg/SVGPathSegList.idl:
* svg/properties/SVGAnimatedEnumerationPropertyTearOff.h:
* svg/properties/SVGListProperty.h:

LayoutTests:

Update existing tests to reflect behavior change.

* fast/dom/Window/resources/window-properties.js:
* js/dom/global-constructors-attributes-expected.txt:
* platform/gtk/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-highsierra-wk1/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-highsierra/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
* platform/mac/js/dom/global-constructors-attributes-expected.txt:
* platform/win/js/dom/global-constructors-attributes-expected.txt:
* platform/wpe/js/dom/global-constructors-attributes-expected.txt:
* svg/animations/animate-marker-orient-from-angle-to-autostartreverse-expected.txt:
* svg/custom/SVGException-expected.txt: Removed.
* svg/custom/SVGException.html: Removed.
* svg/custom/global-constructors-expected.txt:
* svg/custom/global-constructors.html:
* svg/custom/js-svg-constructors-expected.txt:
* svg/custom/js-svg-constructors.svg:
* svg/dom/SVGAnimatedEnumeration-SVGClipPathElement-expected.txt:
* svg/dom/SVGAnimatedEnumeration-SVGComponentTransferFunctionElement-expected.txt:
* svg/dom/SVGAnimatedEnumeration-SVGFEBlendElement-expected.txt:
* svg/dom/SVGAnimatedEnumeration-SVGFEColorMatrixElement-expected.txt:
* svg/dom/SVGAnimatedEnumeration-SVGFEConvolveMatrixElement-expected.txt:
* svg/dom/SVGAnimatedEnumeration-SVGFEDisplacementMapElement-expected.txt:
* svg/dom/SVGAnimatedEnumeration-SVGFEMorphologyElement-expected.txt:
* svg/dom/SVGAnimatedEnumeration-SVGFETurbulenceElement-expected.txt:
* svg/dom/SVGAnimatedEnumeration-SVGFilterElement-expected.txt:
* svg/dom/SVGAnimatedEnumeration-SVGGradientElement-expected.txt:
* svg/dom/SVGAnimatedEnumeration-SVGMarkerElement-expected.txt:
* svg/dom/SVGAnimatedEnumeration-SVGMaskElement-expected.txt:
* svg/dom/SVGAnimatedEnumeration-SVGPatternElement-expected.txt:
* svg/dom/SVGAnimatedEnumeration-SVGTextContentElement-expected.txt:
* svg/dom/SVGAnimatedEnumeration-SVGTextPathElement-expected.txt:
* svg/dom/SVGAnimatedEnumeration-expected.txt:
* svg/dom/SVGException-obsolete-expected.txt: Added.
* svg/dom/SVGException-obsolete.html: Added.
* svg/dom/SVGMatrix-interface-expected.txt:
* svg/dom/svglist-exception-on-out-bounds-error-expected.txt:
* svg/filters/feBlend-invalid-mode-expected.txt:
* svg/filters/feComponentTransfer-style-crash-expected.txt:
* svg/filters/feDisplacementMap-crash-test-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoHook up ITP quirks to the needsSiteSpecificQuirks setting
cdumez@apple.com [Fri, 21 Jul 2017 01:38:58 +0000 (01:38 +0000)]
Hook up ITP quirks to the needsSiteSpecificQuirks setting
https://bugs.webkit.org/show_bug.cgi?id=174691

Reviewed by Darin Adler.

Hook up ITP quirks to the needsSiteSpecificQuirks setting to make it easier for
Web-developers to test their fixes.

* loader/ResourceLoadObserver.cpp:
(WebCore::shouldEnableSiteSpecificQuirks):
(WebCore::areDomainsAssociated):
(WebCore::ResourceLoadObserver::logFrameNavigation):
(WebCore::resourceNeedsSSOQuirk):
(WebCore::ResourceLoadObserver::logSubresourceLoading):
(WebCore::ResourceLoadObserver::logWebSocketLoading):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, rolling out r219700.
jlewis3@apple.com [Fri, 21 Jul 2017 01:23:19 +0000 (01:23 +0000)]
Unreviewed, rolling out r219700.

This revision caused consistent timouts on iOS.

Reverted changeset:

"Turn tests at media/modern-media-controls/start-support back
on"
https://bugs.webkit.org/show_bug.cgi?id=174683
http://trac.webkit.org/changeset/219700

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAdd SPI to notify WKNavigationDelegate about client redirects
commit-queue@webkit.org [Fri, 21 Jul 2017 00:39:09 +0000 (00:39 +0000)]
Add SPI to notify WKNavigationDelegate about client redirects
https://bugs.webkit.org/show_bug.cgi?id=174680
rdar://problem/33184886

Patch by David Quesada <david_quesada@apple.com> on 2017-07-20
Reviewed by Brady Eidson.

Source/WebCore:

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::performClientRedirect):
* loader/FrameLoader.h:
Add a convenience method for NavigationScheduler that handles a FrameLoadRequest
as a client redirect. Currently this means loading the request and informing the
client about it.

* loader/FrameLoaderClient.h:
Add FrameLoaderClient::dispatchDidPerformClientRedirect() to inform the client when
a client redirect occurs.

* loader/NavigationScheduler.cpp:
Removed ScheduledURLNavigation::fire(). This class was never instantiated directly,
and all subclasses override fire(), so this was unused code.
For ScheduledRedirects and ScheduledLocationChange, use FrameLoader's new method to
load the request as a client redirect.

Source/WebKit:

* UIProcess/API/APINavigationClient.h:
(API::NavigationClient::didPerformClientRedirectForNavigation):
Add a new virtual method for navigation clients to implement if they want to be informed
when the page is initiating a navigation that is a client redirect.

* UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:
Declare the new WKNavigationDelegate method -_webView:didPerformClientRedirectForNavigation:

* UIProcess/Cocoa/NavigationState.h:
* UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::setNavigationDelegate):
(WebKit::NavigationState::NavigationClient::didPerformClientRedirectForNavigation):
Add a new method to NavigationState method to tell the WKNavigationDelegate when a
client redirect happens.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didPerformClientRedirectForLoadForFrame):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
Allow the WebPageProxy to receive a message from the web process when a client redirect happens.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidPerformClientRedirect):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
Send this new message to the UI process on client redirects.

Tools:

* TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
(-[DidPerformClientRedirectNavigationDelegate _webView:didPerformClientRedirectForNavigation:]):
(TEST):
Add API test for -[id<WKNavigationDelegatePrivate> _webView:didPerformClientRedirectForNavigation:].

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoDrop legacy XPathException type
cdumez@apple.com [Thu, 20 Jul 2017 23:02:15 +0000 (23:02 +0000)]
Drop legacy XPathException type
https://bugs.webkit.org/show_bug.cgi?id=174679

Reviewed by Sam Weinig.

Source/WebCore:

Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
no longer expose XPathException.

Test: fast/dom/DOMException/XPathException-obsolete.html

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMExceptionHandling.cpp:
(WebCore::createDOMException):
* bindings/js/JSExceptionBase.cpp:
(WebCore::toExceptionBase):
* dom/DOMExceptions.in:
* xml/XPathException.cpp: Removed.
* xml/XPathException.h: Removed.
* xml/XPathException.idl: Removed.
* xml/XPathExpression.cpp:
(WebCore::XPathExpression::evaluate):
* xml/XPathParser.cpp:
(WebCore::XPath::Parser::parseStatement):
* xml/XPathResult.cpp:
(WebCore::XPathResult::convertTo):
(WebCore::XPathResult::numberValue):
(WebCore::XPathResult::stringValue):
(WebCore::XPathResult::booleanValue):
(WebCore::XPathResult::singleNodeValue):
(WebCore::XPathResult::snapshotLength):
(WebCore::XPathResult::iterateNext):
(WebCore::XPathResult::snapshotItem):

Source/WebKit:

Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
no longer expose XPathException.

* UIProcess/Automation/atoms/FindNodes.js:
(tryToFindNode):

Source/WebKitLegacy/mac:

Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
no longer expose XPathException.

* DOM/ExceptionHandlers.mm:
(raiseDOMErrorException):

LayoutTests:

Update existing tests to reflect behavior change.

* dom/svg/level3/xpath/XPathEvaluator_createExpression_INVALID_EXPRESSION_ERR.js:
(XPathEvaluator_createExpression_INVALID_EXPRESSION_ERR):
* dom/svg/level3/xpath/XPathEvaluator_evaluate_INVALID_EXPRESSION_ERR.js:
(XPathEvaluator_evaluate_INVALID_EXPRESSION_ERR):
* dom/svg/level3/xpath/XPathEvaluator_evaluate_TYPE_ERR.js:
(XPathEvaluator_evaluate_TYPE_ERR):
* dom/svg/level3/xpath/XPathResult_TYPE_ERR.js:
(XPathResult_TYPE_ERR):
* fast/dom/DOMException/XPathException-expected.txt: Removed.
* fast/dom/DOMException/XPathException.html: Removed.
* fast/dom/DOMException/resources/XPathException.js: Removed.
* fast/dom/Window/resources/window-properties.js:
* fast/dom/Window/window-lookup-precedence-expected.txt:
* fast/xpath/4XPath/Core/test_parser-expected.txt:
* fast/xpath/invalid-functions-expected.txt:
* fast/xpath/py-dom-xpath/expressions-expected.txt:
* platform/gtk/fast/dom/Window/window-lookup-precedence-expected.txt:
* platform/mac/fast/dom/Window/window-lookup-precedence-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, rolling out r219706.
cdumez@apple.com [Thu, 20 Jul 2017 22:45:23 +0000 (22:45 +0000)]
Unreviewed, rolling out r219706.

Broke iOS build

Reverted changeset:

"Drop legacy XPathException type"
https://bugs.webkit.org/show_bug.cgi?id=174679
http://trac.webkit.org/changeset/219706

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoDrop legacy XPathException type
cdumez@apple.com [Thu, 20 Jul 2017 22:03:45 +0000 (22:03 +0000)]
Drop legacy XPathException type
https://bugs.webkit.org/show_bug.cgi?id=174679

Reviewed by Sam Weinig.

Source/WebCore:

Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
no longer expose XPathException.

Test: fast/dom/DOMException/XPathException-obsolete.html

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMExceptionHandling.cpp:
(WebCore::createDOMException):
* bindings/js/JSExceptionBase.cpp:
(WebCore::toExceptionBase):
* dom/DOMExceptions.in:
* xml/XPathException.cpp: Removed.
* xml/XPathException.h: Removed.
* xml/XPathException.idl: Removed.
* xml/XPathExpression.cpp:
(WebCore::XPathExpression::evaluate):
* xml/XPathParser.cpp:
(WebCore::XPath::Parser::parseStatement):
* xml/XPathResult.cpp:
(WebCore::XPathResult::convertTo):
(WebCore::XPathResult::numberValue):
(WebCore::XPathResult::stringValue):
(WebCore::XPathResult::booleanValue):
(WebCore::XPathResult::singleNodeValue):
(WebCore::XPathResult::snapshotLength):
(WebCore::XPathResult::iterateNext):
(WebCore::XPathResult::snapshotItem):

Source/WebKit:

Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
no longer expose XPathException.

* UIProcess/Automation/atoms/FindNodes.js:
(tryToFindNode):

Source/WebKitLegacy/mac:

Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
no longer expose XPathException.

* DOM/ExceptionHandlers.mm:
(raiseDOMErrorException):
* WebKit.exp:

LayoutTests:

Update existing tests to reflect behavior change.

* dom/svg/level3/xpath/XPathEvaluator_createExpression_INVALID_EXPRESSION_ERR.js:
(XPathEvaluator_createExpression_INVALID_EXPRESSION_ERR):
* dom/svg/level3/xpath/XPathEvaluator_evaluate_INVALID_EXPRESSION_ERR.js:
(XPathEvaluator_evaluate_INVALID_EXPRESSION_ERR):
* dom/svg/level3/xpath/XPathEvaluator_evaluate_TYPE_ERR.js:
(XPathEvaluator_evaluate_TYPE_ERR):
* dom/svg/level3/xpath/XPathResult_TYPE_ERR.js:
(XPathResult_TYPE_ERR):
* fast/dom/DOMException/XPathException-expected.txt: Removed.
* fast/dom/DOMException/XPathException.html: Removed.
* fast/dom/DOMException/resources/XPathException.js: Removed.
* fast/dom/Window/resources/window-properties.js:
* fast/dom/Window/window-lookup-precedence-expected.txt:
* fast/xpath/4XPath/Core/test_parser-expected.txt:
* fast/xpath/invalid-functions-expected.txt:
* fast/xpath/py-dom-xpath/expressions-expected.txt:
* platform/gtk/fast/dom/Window/window-lookup-precedence-expected.txt:
* platform/mac/fast/dom/Window/window-lookup-precedence-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAvoid unnecessary WorkQueue dispatch in WebResourceLoadStatisticsStore::processStatis...
cdumez@apple.com [Thu, 20 Jul 2017 21:09:26 +0000 (21:09 +0000)]
Avoid unnecessary WorkQueue dispatch in WebResourceLoadStatisticsStore::processStatisticsAndDataRecords()
https://bugs.webkit.org/show_bug.cgi?id=174686

Reviewed by Geoffrey Garen.

Avoid unnecessary WorkQueue dispatch in WebResourceLoadStatisticsStore::processStatisticsAndDataRecords(). The most common
call site is already on the right thread.

* UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(-[WKWebsiteDataStore _resourceLoadStatisticsProcessStatisticsAndDataRecords]):
* UIProcess/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::scheduleStatisticsAndDataRecordsProcessing):
(WebKit::WebResourceLoadStatisticsStore::processStatisticsAndDataRecords):
* UIProcess/WebResourceLoadStatisticsStore.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRebaselined svg/css/getComputedStyle-basic.xhtml.
jlewis3@apple.com [Thu, 20 Jul 2017 21:09:12 +0000 (21:09 +0000)]
Rebaselined svg/css/getComputedStyle-basic.xhtml.

Unreviewed test gardening.

* platform/mac-highsierra/svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRegression(ITP): May get frequently logged out of wsj.com
cdumez@apple.com [Thu, 20 Jul 2017 21:08:16 +0000 (21:08 +0000)]
Regression(ITP): May get frequently logged out of wsj.com
https://bugs.webkit.org/show_bug.cgi?id=174661
<rdar://problem/32343256>

Reviewed by Geoffrey Garen.

Source/WebCore:

Add the concept of associated domains in the ResourceLoadObserver. We
previously ignore loads to and from the same domains. We now do the same
if the to and from domains are associated (i.e. owned by the same entity).

For now, only add domains owned by Dow Jones & Company, Inc. to the list,
to address login issues on wsj.com.

No new tests, verified manually on wsj.com.

* loader/ResourceLoadObserver.cpp:
(WebCore::areDomainsAssociated):
(WebCore::ResourceLoadObserver::logFrameNavigation):
(WebCore::ResourceLoadObserver::logSubresourceLoading):
(WebCore::ResourceLoadObserver::logWebSocketLoading):

Source/WebKit:

Bump statistics file version to blow away old statistics on disk since those do not
take into account associated domains.

* UIProcess/WebResourceLoadStatisticsStore.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoReplace calls to Vector::resize() with calls to more efficient shrink() / grow()...
cdumez@apple.com [Thu, 20 Jul 2017 21:06:12 +0000 (21:06 +0000)]
Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable
https://bugs.webkit.org/show_bug.cgi?id=174660

Reviewed by Geoffrey Garen.

Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable.
This essentially replaces a branch to figure out if the new size is less or greater than the
current size by an assertion.

Source/bmalloc:

* bmalloc/Map.h:
(bmalloc::Hash>::rehash):

Source/JavaScriptCore:

* b3/B3BasicBlockUtils.h:
(JSC::B3::clearPredecessors):
* b3/B3InferSwitches.cpp:
* b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::finishAppendingInstructions):
* b3/B3ReduceStrength.cpp:
* b3/B3SparseCollection.h:
(JSC::B3::SparseCollection::packIndices):
* b3/B3UseCounts.cpp:
(JSC::B3::UseCounts::UseCounts):
* b3/air/AirAllocateRegistersAndStackByLinearScan.cpp:
* b3/air/AirEmitShuffle.cpp:
(JSC::B3::Air::emitShuffle):
* b3/air/AirLowerAfterRegAlloc.cpp:
(JSC::B3::Air::lowerAfterRegAlloc):
* b3/air/AirOptimizeBlockOrder.cpp:
(JSC::B3::Air::optimizeBlockOrder):
* bytecode/Operands.h:
(JSC::Operands::ensureLocals):
* bytecode/PreciseJumpTargets.cpp:
(JSC::computePreciseJumpTargetsInternal):
* dfg/DFGBlockInsertionSet.cpp:
(JSC::DFG::BlockInsertionSet::execute):
* dfg/DFGBlockMapInlines.h:
(JSC::DFG::BlockMap<T>::BlockMap):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::processSetLocalQueue):
(JSC::DFG::ByteCodeParser::clearCaches):
* dfg/DFGDisassembler.cpp:
(JSC::DFG::Disassembler::Disassembler):
* dfg/DFGFlowIndexing.cpp:
(JSC::DFG::FlowIndexing::recompute):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::registerFrozenValues):
* dfg/DFGInPlaceAbstractState.cpp:
(JSC::DFG::setLiveValues):
* dfg/DFGLICMPhase.cpp:
(JSC::DFG::LICMPhase::run):
* dfg/DFGLivenessAnalysisPhase.cpp:
* dfg/DFGNaturalLoops.cpp:
(JSC::DFG::NaturalLoops::NaturalLoops):
* dfg/DFGStoreBarrierClusteringPhase.cpp:
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileNode):
* heap/CodeBlockSet.cpp:
(JSC::CodeBlockSet::deleteUnmarkedAndUnreferenced):
* heap/MarkedSpace.cpp:
(JSC::MarkedSpace::sweepLargeAllocations):
* inspector/ContentSearchUtilities.cpp:
(Inspector::ContentSearchUtilities::findMagicComment):
* interpreter/ShadowChicken.cpp:
(JSC::ShadowChicken::update):
* parser/ASTBuilder.h:
(JSC::ASTBuilder::shrinkOperandStackBy):
* parser/Lexer.h:
(JSC::Lexer::setOffset):
* runtime/RegExpInlines.h:
(JSC::RegExp::matchInline):
* runtime/RegExpPrototype.cpp:
(JSC::genericSplit):
* yarr/RegularExpression.cpp:
(JSC::Yarr::RegularExpression::match):

Source/WebCore:

* Modules/gamepad/Gamepad.cpp:
(WebCore::Gamepad::Gamepad):
* Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::addReaction):
* Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::skipBuffer):
* Modules/websockets/WebSocketDeflater.cpp:
(WebCore::WebSocketDeflater::finish):
* contentextensions/ContentExtensionCompiler.cpp:
(WebCore::ContentExtensions::serializeSelector):
* contentextensions/DFABytecodeCompiler.cpp:
(WebCore::ContentExtensions::append):
* crypto/gcrypt/CryptoAlgorithmAES_CBCGCrypt.cpp:
(WebCore::gcryptEncrypt):
(WebCore::gcryptDecrypt):
* crypto/gcrypt/CryptoAlgorithmECDHGCrypt.cpp:
(WebCore::gcryptDerive):
* platform/gamepad/cocoa/GameControllerGamepadProvider.mm:
(WebCore::GameControllerGamepadProvider::controllerDidConnect):
* platform/gamepad/mac/HIDGamepadProvider.cpp:
(WebCore::HIDGamepadProvider::deviceAdded):
* platform/graphics/ImageBackingStore.h:
(WebCore::ImageBackingStore::setSize):
* platform/graphics/WOFFFileFormat.cpp:
* platform/graphics/avfoundation/InbandMetadataTextTrackPrivateAVF.cpp:
(WebCore::InbandMetadataTextTrackPrivateAVF::updatePendingCueEndTimes):
(WebCore::InbandMetadataTextTrackPrivateAVF::flushPartialCues):
* platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
(WebCore::InbandTextTrackPrivateAVF::resetCueValues):
(WebCore::InbandTextTrackPrivateAVF::readNativeSampleBuffer):
* platform/graphics/avfoundation/cf/InbandTextTrackPrivateAVCF.cpp:
(WebCore::InbandTextTrackPrivateAVCF::readNativeSampleBuffer):
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::cfData):
* platform/image-decoders/bmp/BMPImageDecoder.cpp:
(WebCore::BMPImageDecoder::frameBufferAtIndex):
* platform/image-decoders/ico/ICOImageDecoder.cpp:
(WebCore::ICOImageDecoder::decode):
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::JPEGImageDecoder::frameBufferAtIndex):
* platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::PNGImageDecoder::frameBufferAtIndex):
(WebCore::PNGImageDecoder::readChunks):
* platform/image-decoders/webp/WEBPImageDecoder.cpp:
(WebCore::WEBPImageDecoder::frameBufferAtIndex):
* platform/image-encoders/JPEGImageEncoder.cpp:
(WebCore::compressRGBABigEndianToJPEG):
* platform/text/DecodeEscapeSequences.h:
(WebCore::URLEscapeSequence::decodeRun):
* platform/text/SuffixTree.h:
(WebCore::SuffixTree::Node::Node):
* rendering/Grid.cpp:
(WebCore::Grid::setNeedsItemsPlacement):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::invalidateCachedColumns):

Source/WebKit:

* Platform/IPC/ArgumentCoders.h:
* UIProcess/Gamepad/UIGamepadProvider.cpp:
(WebKit::UIGamepadProvider::platformGamepadConnected):
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::setInitialConnectedGamepads):
* WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::loadResourceSynchronously):
* WebProcess/WebCoreSupport/WebPasteboardOverrides.cpp:
(WebKit::WebPasteboardOverrides::getDataForOverride):
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::requestAutocorrectionData):

Source/WebKitLegacy/mac:

* Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):

Source/WTF:

* wtf/IndexSparseSet.h:
(WTF::OverflowHandler>::IndexSparseSet):
(WTF::OverflowHandler>::clear):
* wtf/Insertion.h:
(WTF::executeInsertions):
* wtf/RangeSet.h:
(WTF::RangeSet::compact):
* wtf/Vector.h:
(WTF::removeRepeatedElements):
* wtf/persistence/Coders.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRegression(ITP): Can no longer log in on abc.go.com
cdumez@apple.com [Thu, 20 Jul 2017 20:52:22 +0000 (20:52 +0000)]
Regression(ITP): Can no longer log in on abc.go.com
https://bugs.webkit.org/show_bug.cgi?id=174533
<rdar://problem/33325881>

Reviewed by Geoffrey Garen.

Source/WebCore:

Add quirk for sp.auth.adobe.com which is used for SSO by web sites such as
abc.go.com. This would otherwise cause adobe.com to be identified as a
tracker and log in on abc.go.com would break.

No new tests, tested manually on abc.go.com.

* loader/ResourceLoadObserver.cpp:
(WebCore::resourceNeedsSSOQuirk):
(WebCore::ResourceLoadObserver::logSubresourceLoading):

Source/WebKit:

Bump statistics database version to blow away any existing statistics. Without this, SSO providers
for which we added a quirk may already be in the database and identified as trackers. The quirk
merely prevents the specified SSO providers from being identified as trackers.

* UIProcess/WebResourceLoadStatisticsStore.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoTurn tests at media/modern-media-controls/start-support back on
commit-queue@webkit.org [Thu, 20 Jul 2017 20:47:53 +0000 (20:47 +0000)]
Turn tests at media/modern-media-controls/start-support back on
https://bugs.webkit.org/show_bug.cgi?id=174683

Patch by Antoine Quint <graouts@apple.com> on 2017-07-20
Reviewed by Dean Jackson.

Source/WebCore:

Turning those tests back on revealed a small bug that is unlikely to really affect content
on the Web. In the case where the size of the video is known right away, without the need
for loading its metadata, as is the case in the start-support-click-to-start.html test with
a local media resource, all queued layouts are flushed at once and we may call the layout()
method of the left ButtonsContainer which originally is set to contain the play/pause button,
which would remove the play/pause button from the center of the media. So before we potentially
set the play/pause button as the central button, we first assign the default button set for
the two ButtonsContainer instances and only add the play/pause button when we're not showing
the prominent play/pause button.

* Modules/modern-media-controls/controls/inline-media-controls.js:
(InlineMediaControls.prototype.layout):
(InlineMediaControls.prototype._leftContainerButtons):

LayoutTests:

* media/modern-media-controls/start-support/start-support-click-to-start-expected.txt:
* media/modern-media-controls/start-support/start-support-click-to-start.html:
* media/modern-media-controls/start-support/start-support-fullscreen.html:
* media/modern-media-controls/start-support/start-support-lowPowerMode-expected.txt:
* media/modern-media-controls/start-support/start-support-lowPowerMode.html:
* platform/ios-simulator/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoDrop legacy FileException type
cdumez@apple.com [Thu, 20 Jul 2017 20:35:12 +0000 (20:35 +0000)]
Drop legacy FileException type
https://bugs.webkit.org/show_bug.cgi?id=174676

Reviewed by Alex Christensen.

Drop legacy FileException type and use DOMException instead, as per the latest
File API specification:
- https://w3c.github.io/FileAPI/#ErrorAndException

Both Firefox and Chrome no longer expose FileException.

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMExceptionHandling.cpp:
(WebCore::createDOMException):
* dom/DOMExceptions.in:
* fileapi/FileException.cpp: Removed.
* fileapi/FileException.h: Removed.
* fileapi/FileException.idl: Removed.
* fileapi/FileReaderLoader.cpp:
(WebCore::FileReaderLoader::FileReaderLoader):
(WebCore::FileReaderLoader::failed):
* fileapi/FileReaderLoader.h:
(WebCore::FileReaderLoader::errorCode):
* fileapi/FileReaderSync.cpp:
(WebCore::errorCodeToExceptionCode):
(WebCore::FileReaderSync::startLoading):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoTest WebKit2CustomProtocolsTest.ProcessPoolDestroyedDuringLoading added in r219664...
beidson@apple.com [Thu, 20 Jul 2017 20:34:29 +0000 (20:34 +0000)]
Test WebKit2CustomProtocolsTest.ProcessPoolDestroyedDuringLoading added in r219664 fails on El Capitan.
https://bugs.webkit.org/show_bug.cgi?id=174685

Reviewed by Andy Estes.

* TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
(TestWebKitAPI::TEST): Use a scoped AutodrainedPool instead of a RetainPtr<NSAutoreleasePool>.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMarked media/modern-media-controls/scrubber-support/scrubber-support-drag.html as...
jlewis3@apple.com [Thu, 20 Jul 2017 19:06:21 +0000 (19:06 +0000)]
Marked media/modern-media-controls/scrubber-support/scrubber-support-drag.html as flaky
https://bugs.webkit.org/show_bug.cgi?id=174682

Unreviewed test gardening.

* platform/mac/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[WTF] Use ThreadGroup to bookkeep active threads for Mach exception
utatane.tea@gmail.com [Thu, 20 Jul 2017 18:32:13 +0000 (18:32 +0000)]
[WTF] Use ThreadGroup to bookkeep active threads for Mach exception
https://bugs.webkit.org/show_bug.cgi?id=174678

Reviewed by Mark Lam.

Source/JavaScriptCore:

Use Thread& instead.

* runtime/JSLock.cpp:
(JSC::JSLock::didAcquireLock):

Source/WTF:

We can use ThreadGroup to bookkeep active threads for Mach exceptions.
When the thread dies, it is automatically removed from the thread groups.
So we do not need to call unregisterThreadForMachExceptionHandling.

* wtf/ThreadGroup.cpp:
(WTF::ThreadGroup::~ThreadGroup):
(WTF::ThreadGroup::add):
* wtf/ThreadGroup.h:
* wtf/ThreadHolder.cpp:
(WTF::ThreadHolder::~ThreadHolder):
* wtf/Threading.cpp:
(WTF::Thread::addToThreadGroup):
(WTF::Thread::removeFromThreadGroup):
* wtf/Threading.h:
* wtf/threads/Signals.cpp:
(WTF::setExceptionPorts):
(WTF::activeThreads):
(WTF::registerThreadForMachExceptionHandling):
(WTF::installSignalHandler):
(WTF::unregisterThreadForMachExceptionHandling): Deleted.
* wtf/threads/Signals.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoDeprecate WebIconDatabase in WebKitLegacy/mac.
beidson@apple.com [Thu, 20 Jul 2017 18:07:30 +0000 (18:07 +0000)]
Deprecate WebIconDatabase in WebKitLegacy/mac.
https://bugs.webkit.org/show_bug.cgi?id=174607

Reviewed by Alex Christensen.

Source/WebKitLegacy/mac:

This patch:
1 - Formally deprecates WebIconDatabase (which was never API anyways)
2 - Guts the class to where it can only return the default icon at the small size
3 - Reworks other parts of WebKitLegacy that used it for anything to either
    use something else or to not do anything.

This patch *could* go much farther. A future patch is what will remove WebCore/IconDatabase
and that patch will remove all of the last remnants of WebIconDatabase.

* History/WebHistoryItem.mm:
(-[WebHistoryItem icon]):

* Misc/WebIconDatabase.h:
* Misc/WebIconDatabase.mm:
(-[WebIconDatabase init]):
(-[WebIconDatabase iconForURL:withSize:cache:]):
(-[WebIconDatabase iconForURL:withSize:]):
(-[WebIconDatabase defaultIconWithSize:]):
(-[WebIconDatabase defaultIconForURL:withSize:]):
(-[WebIconDatabase iconURLForURL:]):
(-[WebIconDatabase retainIconForURL:]):
(-[WebIconDatabase releaseIconForURL:]):
(+[WebIconDatabase delayDatabaseCleanup]):
(+[WebIconDatabase allowDatabaseCleanup]):
(-[WebIconDatabase setDelegate:]):
(-[WebIconDatabase delegate]):
(+[WebIconDatabase initialize]): Deleted.
(-[WebIconDatabase isEnabled]): Deleted.
(-[WebIconDatabase setEnabled:]): Deleted.
(-[WebIconDatabase removeAllIcons]): Deleted.
(+[WebIconDatabase _checkIntegrityBeforeOpening]): Deleted.
(-[WebIconDatabase _sendNotificationForURL:]): Deleted.
(-[WebIconDatabase _sendDidRemoveAllIconsNotification]): Deleted.
(-[WebIconDatabase _startUpIconDatabase]): Deleted.
(-[WebIconDatabase _shutDownIconDatabase]): Deleted.
(-[WebIconDatabase _applicationWillTerminate:]): Deleted.
(-[WebIconDatabase _iconForFileURL:withSize:]): Deleted.
(-[WebIconDatabase _resetCachedWebPreferences:]): Deleted.
(-[WebIconDatabase _largestIconFromDictionary:]): Deleted.
(-[WebIconDatabase _iconsBySplittingRepresentationsOfIcon:]): Deleted.
(-[WebIconDatabase _iconFromDictionary:forSize:cache:]): Deleted.
(-[WebIconDatabase _scaleIcon:toSize:]): Deleted.
(-[WebIconDatabase _databaseDirectory]): Deleted.
(webGetNSImage): Deleted.

* Misc/WebIconDatabaseDelegate.h: Removed.
* Misc/WebIconDatabaseInternal.h: Removed.
* Misc/WebIconDatabasePrivate.h: Removed.

* WebCoreSupport/WebFrameLoaderClient.mm:
(webGetNSImage):

* WebCoreSupport/WebIconDatabaseClient.mm:
(WebIconDatabaseClient::didRemoveAllIcons):
(WebIconDatabaseClient::didImportIconURLForPageURL):

* WebView/WebView.mm:
(-[WebView setFrameLoadDelegate:]):
(-[WebView mainFrameIcon]):

Tools:

* DumpRenderTree/mac/TestRunnerMac.mm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, rebaseline test on all platforms after r219673.
cdumez@apple.com [Thu, 20 Jul 2017 17:45:46 +0000 (17:45 +0000)]
Unreviewed, rebaseline test on all platforms after r219673.

* js/dom/global-constructors-attributes-expected.txt:
* platform/gtk/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-highsierra-wk1/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-highsierra/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
* platform/mac/js/dom/global-constructors-attributes-expected.txt:
* platform/win/js/dom/global-constructors-attributes-expected.txt:
* platform/wpe/js/dom/global-constructors-attributes-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, add the final demo page for a WebCrypto API blog post
jiewen_tan@apple.com [Thu, 20 Jul 2017 17:18:56 +0000 (17:18 +0000)]
Unreviewed, add the final demo page for a WebCrypto API blog post

* demos/webcrypto/pbkdf2.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, rebaseline test after r219663.
cdumez@apple.com [Thu, 20 Jul 2017 17:00:56 +0000 (17:00 +0000)]
Unreviewed, rebaseline test after r219663.

* web-platform-tests/WebCryptoAPI/import_export/test_rsa_importKey.https-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[WebIDL] Remove custom bindings for InspectorFrontendHost
commit-queue@webkit.org [Thu, 20 Jul 2017 16:58:06 +0000 (16:58 +0000)]
[WebIDL] Remove custom bindings for InspectorFrontendHost
https://bugs.webkit.org/show_bug.cgi?id=174659

Patch by Sam Weinig <sam@webkit.org> on 2017-07-20
Reviewed by Chris Dumez.

* CMakeLists.txt:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSInspectorFrontendHostCustom.cpp: Removed.
Remove JSInspectorFrontendHostCustom.cpp.

* inspector/InspectorFrontendHost.cpp:
(WebCore::populateContextMenu):
(WebCore::InspectorFrontendHost::showContextMenu):
* inspector/InspectorFrontendHost.h:
* inspector/InspectorFrontendHost.idl:
Re-implement showContextMenu by using an IDL defined ContextMenuItem dictionary
and converting from that to a WebCore::ContextMenu in the implementation.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, add yet another demo page for a WebCrypto API blog post
jiewen_tan@apple.com [Thu, 20 Jul 2017 16:42:39 +0000 (16:42 +0000)]
Unreviewed, add yet another demo page for a WebCrypto API blog post

* demos/webcrypto/aes-gcm.html:
* demos/webcrypto/alice.png: Added.
* demos/webcrypto/bob.png: Added.
* demos/webcrypto/ecdh.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agolint-test-expectations should be run during style checking
jbedard@apple.com [Thu, 20 Jul 2017 16:33:33 +0000 (16:33 +0000)]
lint-test-expectations should be run during style checking
https://bugs.webkit.org/show_bug.cgi?id=173559
<rdar://problem/32854941>

Reviewed by Aakash Jain.

* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationsModel._already_seen_better_match): Append returns 'None' when successful,
prevents identifying errors on specific lines in a file.
* Scripts/webkitpy/style/main_unittest.py:
(ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Test for the
case where a linter error is in the file modified, but the line modified is not related to
the linter error.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[GTK] Layout Test http/tests/media/hls/hls-progress.html is failing
commit-queue@webkit.org [Thu, 20 Jul 2017 15:59:39 +0000 (15:59 +0000)]
[GTK] Layout Test http/tests/media/hls/hls-progress.html is failing
https://bugs.webkit.org/show_bug.cgi?id=141469

Patch by Charlie Turner <cturner@igalia.com> on 2017-07-20
Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

A work-around for getting progress information in a timely manner from
live pipelines. We cannot rely on getting BUFFERING messages within
the stalled time window (3s), so we have to poll for progress
information somehow.

Makes the following pass reliably
 http/tests/media/hls/hls-audio-tracks-has-audio.html passed unexpectedly
 http/tests/media/hls/hls-audio-tracks.html passed unexpectedly
 http/tests/media/hls/hls-progress.html passed unexpectedly

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::findHLSQueue):
(WebCore::isHLSProgressing):
(WebCore::MediaPlayerPrivateGStreamer::fillTimerFired):

LayoutTests:

Fixes the removed tests.

* platform/gtk/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed GTK test gardening
mcatanzaro@igalia.com [Thu, 20 Jul 2017 15:48:44 +0000 (15:48 +0000)]
Unreviewed GTK test gardening

* platform/gtk/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, add another demo page for a WebCrypto API blog post
jiewen_tan@apple.com [Thu, 20 Jul 2017 15:46:51 +0000 (15:46 +0000)]
Unreviewed, add another demo page for a WebCrypto API blog post

* demos/webcrypto/aes-gcm.html: Added.
* demos/webcrypto/asynchronous-execution.html:
* demos/webcrypto/common.js: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMinor Node->Element type tightening fixes
akling@apple.com [Thu, 20 Jul 2017 14:37:14 +0000 (14:37 +0000)]
Minor Node->Element type tightening fixes
https://bugs.webkit.org/show_bug.cgi?id=174651

Reviewed by Sam Weinig.

Tighten up some Node* into Element* or even better, Element&.

* dom/Document.cpp:
(WebCore::acceptsEditingFocus): Take a const Element&.
(WebCore::Document::setFocusedElement):
* editing/Editor.cpp:
(WebCore::Editor::findEventTargetFrom): Return an Element*.
(WebCore::Editor::findEventTargetFromSelection): Ditto.
(WebCore::Editor::pasteAsPlainText):
(WebCore::Editor::pasteAsFragment):
(WebCore::Editor::dispatchCPPEvent):
* editing/Editor.h:
* page/DragController.cpp:
(WebCore::DragController::dispatchTextInputEventFor):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRemove WebIconDatabase from WebKitLegacy/win.
beidson@apple.com [Thu, 20 Jul 2017 14:30:10 +0000 (14:30 +0000)]
Remove WebIconDatabase from WebKitLegacy/win.
https://bugs.webkit.org/show_bug.cgi?id=174608

Reviewed by Alex Christensen.

Source/WebKitLegacy/win:

It is unused.

* ForEachCoClass.h:

* Interfaces/IWebIconDatabase.idl: Removed.

* Interfaces/WebKit.idl:

* WebCoreStatistics.cpp:
(WebCoreStatistics::iconPageURLMappingCount):
(WebCoreStatistics::iconRetainedPageURLCount):
(WebCoreStatistics::iconRecordCount):
(WebCoreStatistics::iconsWithDataCount):

* WebIconDatabase.cpp: Removed.
* WebIconDatabase.h: Removed.
* WebKitClassFactory.cpp:

* WebKitDLL.cpp:
(shutDownWebKit):

* WebKitLogging.h:

* WebView.cpp:
(WebView::close):
(WebView::notifyDidAddIcon):
(WebView::registerForIconNotification):
(WebView::dispatchDidReceiveIconFromWebFrame):
(WebView::onNotify):

Tools:

* DumpRenderTree/win/DumpRenderTree.cpp:
(main):
* DumpRenderTree/win/TestRunnerWin.cpp:
(TestRunner::setIconDatabaseEnabled):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWKHTTPCookieStore API tests fail on High Sierra.
beidson@apple.com [Thu, 20 Jul 2017 14:28:18 +0000 (14:28 +0000)]
WKHTTPCookieStore API tests fail on High Sierra.
<rdar://problem/33410271> and https://bugs.webkit.org/show_bug.cgi?id=174666

Reviewed by Andy Estes.

Covered by existing API tests.

In r219567 I'd moved cookie storage observation off of NSHTTPCookieStorage and NSNotificationCenter
to CFHTTPCookieStorage observation callbacks.

This is because notifications were only sent for the default [NSHTTPCookieStorage sharedHTTPCookieStorage]
and not any of the other ones we keep in flight.

Unfortunately that SPI has been disabled in High Sierra.
Fortunately we found a way we can get non-shared NSHTTPCookieStorages to send notifications that works everywhere.

* platform/network/cocoa/CookieStorageObserver.h:
* platform/network/cocoa/CookieStorageObserver.mm:
(-[WebCookieObserverAdapter initWithObserver:]):
(-[WebCookieObserverAdapter cookiesChangedNotificationHandler:]):
(WebCore::CookieStorageObserver::create):
(WebCore::CookieStorageObserver::CookieStorageObserver):
(WebCore::CookieStorageObserver::~CookieStorageObserver):
(WebCore::CookieStorageObserver::startObserving): Use a trick to call some SPI on non-shared NSHTTPCookieStorages
  to get them to send notifications.
(WebCore::CookieStorageObserver::stopObserving):
(WebCore::cookiesChanged): Deleted.

* platform/network/cocoa/NetworkStorageSessionCocoa.mm:
(WebCore::NetworkStorageSession::cookieStorageObserver):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, add a demo page for a WebCrypto API blog post
jiewen_tan@apple.com [Thu, 20 Jul 2017 14:25:34 +0000 (14:25 +0000)]
Unreviewed, add a demo page for a WebCrypto API blog post

* demos/webcrypto/asynchronous-execution-worker.js: Added.
* demos/webcrypto/asynchronous-execution.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[GStreamer] Some layout tests issue "g_mutex_clear() called on uninitialised or locke...
magomez@igalia.com [Thu, 20 Jul 2017 13:07:01 +0000 (13:07 +0000)]
[GStreamer] Some layout tests issue "g_mutex_clear() called on uninitialised or locked mutex" and flaky crash in ~MediaPlayerPrivateGStreamerBase
https://bugs.webkit.org/show_bug.cgi?id=173952

Reviewed by Carlos Garcia Campos.

Adjust MediaPlayerPrivateGStreamerBase to avoid concurrence problems with the GStreamer thread when
destroying the object.

Covered by existent tests.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::~MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::repaint):
(WebCore::MediaPlayerPrivateGStreamerBase::cancelRepaint):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[WPE] Adjust priority of GSource used in WKTR's HeadlessViewBackend
zandobersek@gmail.com [Thu, 20 Jul 2017 12:11:59 +0000 (12:11 +0000)]
[WPE] Adjust priority of GSource used in WKTR's HeadlessViewBackend
https://bugs.webkit.org/show_bug.cgi?id=174671

Reviewed by Carlos Garcia Campos.

* WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
(HeadlessViewBackend::HeadlessViewBackend): Use the RunLoopDispatcher
priority for this source in order to have it dispatched on the same
priority as the other WebKit-controlled GSource objects.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed WPE gardening. Updating test baselines after r219663.
zandobersek@gmail.com [Thu, 20 Jul 2017 07:46:15 +0000 (07:46 +0000)]
Unreviewed WPE gardening. Updating test baselines after r219663.

* platform/wpe/crypto/subtle/aes-cbc-cfb-decrypt-malformed-parameters-expected.txt:
* platform/wpe/crypto/subtle/aes-cbc-cfb-encrypt-malformed-parameters-expected.txt:
* platform/wpe/crypto/subtle/aes-export-key-malformed-parameters-expected.txt:
* platform/wpe/crypto/subtle/aes-generate-key-malformed-parameters-expected.txt:
* platform/wpe/crypto/subtle/aes-import-key-malformed-parameters-expected.txt:
* platform/wpe/crypto/subtle/rsa-generate-key-malformed-parameters-expected.txt:
* platform/wpe/crypto/subtle/rsa-import-key-malformed-parameters-expected.txt:
* platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-destroy-persistent-license-expected.txt:
* platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-persistent-license-events-expected.txt:
* platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-persistent-license-expected.txt:
* platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-persistent-usage-record-events-expected.txt:
* platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-persistent-usage-record-expected.txt:
* platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-retrieve-destroy-persistent-license-expected.txt:
* platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-retrieve-persistent-license-expected.txt:
* platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-retrieve-persistent-usage-record-expected.txt:
* platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-clear-encrypted-expected.txt:
* platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-encrypted-clear-expected.txt:
* platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-encrypted-clear-sources-expected.txt:
* platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-events-expected.txt:
* platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-expected.txt:
* platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multikey-expected.txt:
* platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multikey-sequential-expected.txt:
* platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multikey-sequential-readyState-expected.txt:
* platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multisession-expected.txt:
* platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-after-src-expected.txt:
* platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-after-update-expected.txt:
* platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-immediately-expected.txt:
* platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-onencrypted-expected.txt:
* platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-two-videos-expected.txt:
* platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-waitingforkey-expected.txt:
* platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-requestmediakeysystemaccess-expected.txt:
* platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-reset-src-after-setmediakeys-expected.txt:
* platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-again-after-resetting-src-expected.txt:
* platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-multiple-times-with-the-same-mediakeys-expected.txt:
* platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-unique-origin-expected.txt:
* platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-not-callable-after-createsession-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[EME] Push CDMInstance, CDMPrivate and associated types into the Platform layer
zandobersek@gmail.com [Thu, 20 Jul 2017 06:09:56 +0000 (06:09 +0000)]
[EME] Push CDMInstance, CDMPrivate and associated types into the Platform layer
https://bugs.webkit.org/show_bug.cgi?id=174496

Reviewed by Xabier Rodriguez-Calvar.

Move the CDMInstance and CDMPrivate interfaces into the platform layer, enabling
implementations of specific key systems at that level, as well as integration with
the MediaPlayerPrivate stack without any layering violations.

While the platform layer still uses the WebCore namespace, the two interface files
have now been moved under the platform/encryptedmedia/ directory and out of the
Modules/encryptedmedia/ directory where the Web-facing API implementation resides.

The two interfaces integrated closely with the Web-facing enumerations and
dictionaries: MediaKeyMessageType, MediaKeySessionType, MediaKeyStatus,
MediaKeySystemConfiguration, MediaKeySystemCapability, MediaKeysRequirement
and MediaKeysRestrictions. Definitions of these types are also moved to the
platform layer without any changes (apart from renaming), and the previous
types now alias against the types now located in the platform layer.

No new tests -- no change in behavior.

* CMakeLists.txt:
* Modules/encryptedmedia/CDM.cpp:
* Modules/encryptedmedia/CDM.h:
* Modules/encryptedmedia/MediaKeyMessageType.h:
* Modules/encryptedmedia/MediaKeySessionType.h:
* Modules/encryptedmedia/MediaKeyStatus.h:
* Modules/encryptedmedia/MediaKeySystemAccess.cpp:
* Modules/encryptedmedia/MediaKeySystemAccess.h:
* Modules/encryptedmedia/MediaKeySystemConfiguration.h:
* Modules/encryptedmedia/MediaKeySystemMediaCapability.h:
* Modules/encryptedmedia/MediaKeysRequirement.h:
* Modules/encryptedmedia/MediaKeysRestrictions.h:
* platform/encryptedmedia/CDMInstance.h: Renamed from Source/WebCore/Modules/encryptedmedia/CDMInstance.h.
* platform/encryptedmedia/CDMKeyStatus.h: Copied from Source/WebCore/Modules/encryptedmedia/MediaKeyStatus.h.
* platform/encryptedmedia/CDMKeySystemConfiguration.h: Copied from Source/WebCore/Modules/encryptedmedia/MediaKeySystemConfiguration.h.
* platform/encryptedmedia/CDMMediaCapability.h: Copied from Source/WebCore/Modules/encryptedmedia/MediaKeySystemMediaCapability.h.
* platform/encryptedmedia/CDMMessageType.h: Copied from Source/WebCore/Modules/encryptedmedia/MediaKeyMessageType.h.
* platform/encryptedmedia/CDMPrivate.h: Renamed from Source/WebCore/Modules/encryptedmedia/CDMPrivate.h.
* platform/encryptedmedia/CDMRequirement.h: Copied from Source/WebCore/Modules/encryptedmedia/MediaKeysRequirement.h.
* platform/encryptedmedia/CDMRestrictions.h: Copied from Source/WebCore/Modules/encryptedmedia/MediaKeysRestrictions.h.
* platform/encryptedmedia/CDMSessionType.h: Copied from Source/WebCore/Modules/encryptedmedia/MediaKeySessionType.h.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed follow-up to r219674.
zandobersek@gmail.com [Thu, 20 Jul 2017 06:08:28 +0000 (06:08 +0000)]
Unreviewed follow-up to r219674.

* page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp:
Remove the AsyncScrollingCoordinator.h header include that was added by accident.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[CMake] Clean up Web Crypto build targets
zandobersek@gmail.com [Thu, 20 Jul 2017 05:57:35 +0000 (05:57 +0000)]
[CMake] Clean up Web Crypto build targets
https://bugs.webkit.org/show_bug.cgi?id=174253

Reviewed by Alex Christensen.

Gather the common WebCrypto source files in CMakeLists.txt, including them
in the build unconditionally and instead relying on ENABLE_SUBTLE_CRYPTO
build guards to exclude the code from compilation if the feature is disabled.

PlatformGTK.cmake, PlatformMac.cmake and PlatformWPE.cmake can then remove
duplicated build targets. PlatformMac.cmake still lists all the Mac-specific
Web Crypto build targets.

PlatformGTK.cmake and PlatformWPE.cmake now include GCrypt.cmake if the
USE_GCRYPT variable is enabled. Both ports at the moment enable that variable
though as they by default leverage a libgcrypt-based CrpytoDigest implementation
in the PAL library.

The new GCrypt.cmake file adds the libgcrypt-specific Web Crypto build targets to
the build and also sets up libgcrypt include directiories and libraries.

No new tests -- no change in behavior.

* CMakeLists.txt:
* PlatformGTK.cmake:
* PlatformMac.cmake:
* PlatformWPE.cmake:
* platform/GCrypt.cmake: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[WebIDL] Remove custom bindings for CommandLineAPIHost
commit-queue@webkit.org [Thu, 20 Jul 2017 05:46:30 +0000 (05:46 +0000)]
[WebIDL] Remove custom bindings for CommandLineAPIHost
https://bugs.webkit.org/show_bug.cgi?id=174642

Patch by Sam Weinig <sam@webkit.org> on 2017-07-19
Reviewed by Joseph Pecoraro.

* CMakeLists.txt:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSCommandLineAPIHostCustom.cpp: Removed.
Remove JSCommandLineAPIHostCustom.cpp.

* bindings/js/JSDOMConvertObject.h:
(WebCore::JSConverter<IDLObject>::convert):
Add missing JSConverter specialization for IDLObject.

* inspector/CommandLineAPIHost.cpp:
(WebCore::CommandLineAPIHost::inspect):
(WebCore::listenerEntriesFromListenerInfo):
(WebCore::CommandLineAPIHost::inspectedObject):
(WebCore::CommandLineAPIHost::databaseId):
(WebCore::CommandLineAPIHost::storageId):
(WebCore::CommandLineAPIHost::inspectImpl): Deleted.
(WebCore::CommandLineAPIHost::getEventListenersImpl): Deleted.
(WebCore::CommandLineAPIHost::databaseIdImpl): Deleted.
(WebCore::CommandLineAPIHost::storageIdImpl): Deleted.
* inspector/CommandLineAPIHost.h:
* inspector/CommandLineAPIHost.idl:
Replace custom bindings with modern bindings affordances: dictionaries, records and sequences.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed CoordGraphics build fix.
zandobersek@gmail.com [Thu, 20 Jul 2017 05:43:11 +0000 (05:43 +0000)]
Unreviewed CoordGraphics build fix.

* page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp:
(WebCore::ScrollingCoordinatorCoordinatedGraphics::updateNodeViewportConstraints):
This should be defined for the ScrollingCoordinatorCoordinatedGraphics class.
Also fix the setFixedToViewport() call, fishing out the GraphicsLayer object from
the ScrollingStateNode's LayerRepresentation.
(WebCore::AsyncScrollingCoordinator::updateNodeViewportConstraints): Deleted.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoDrop SQLException type
cdumez@apple.com [Thu, 20 Jul 2017 05:23:48 +0000 (05:23 +0000)]
Drop SQLException type
https://bugs.webkit.org/show_bug.cgi?id=174665

Reviewed by Sam Weinig.

Source/WebCore:

Drop SQLException type. We never throw such exception. Also, Firefox
and Chrome no longer expose this type.

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* Modules/webdatabase/SQLException.cpp: Removed.
* Modules/webdatabase/SQLException.h: Removed.
* Modules/webdatabase/SQLException.idl: Removed.
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMExceptionHandling.cpp:
(WebCore::createDOMException):
* bindings/js/JSExceptionBase.cpp:
(WebCore::toExceptionBase):
* dom/DOMExceptions.in:

Source/WebInspectorUI:

Use SQLError instead of SQLException, this is what the script should really
use here since it is checking the code of an SQLError.

* .eslintrc:
* UserInterface/Models/DatabaseObject.js:
(WebInspector.DatabaseObject.prototype.executeSQL.queryCallback):
(WebInspector.DatabaseObject.prototype.executeSQL):
(WebInspector.DatabaseObject):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, tweak a comment above TemporarySelectionOptionIgnoreSelectionChanges...
wenson_hsieh@apple.com [Thu, 20 Jul 2017 02:14:29 +0000 (02:14 +0000)]
Unreviewed, tweak a comment above TemporarySelectionOptionIgnoreSelectionChanges in Editor.cpp.

The comment references the UI process, but it describes an entity in WebCore. This should have been generalized
to instead refer to the client layer in general (i.e. WebKit1 or WebKit2).

* editing/Editor.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agolint-test-expectations should be run during style checking
jbedard@apple.com [Thu, 20 Jul 2017 00:17:40 +0000 (00:17 +0000)]
lint-test-expectations should be run during style checking
https://bugs.webkit.org/show_bug.cgi?id=173559
<rdar://problem/32854941>

Reviewed by Daniel Bates.

Follow up fix addressing style and a few minor bugs.

* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser.__init__): Use lambda x: x instead of str
(TestExpectationsModel.__init__): Make lambda x: x the default argument.
(TestExpectationsModel._already_seen_better_match): Use a temporary variable to
reduce the calls of _shorten_filename, fix minor bug in appending the current
expectation's line number instead of the previous ones, clarify treatment of None
in file-to-line-number mapping.
(TestExpectations._report_warnings): Collapse call.
* Scripts/webkitpy/style/checkers/test_expectations.py:
(TestExpectationsChecker.lint_test_expectations):
* Scripts/webkitpy/style/filereader.py: Re-write comment.
(TextFileReader.process_file): Add comment explaining treatment of None in
file-to-line-number mapping.
(TextFileReader.delete_file): Collapse call.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agogetBoundingClientRects not updated for programmatic scrolls
simon.fraser@apple.com [Thu, 20 Jul 2017 00:15:08 +0000 (00:15 +0000)]
getBoundingClientRects not updated for programmatic scrolls
https://bugs.webkit.org/show_bug.cgi?id=174538
rdar://problem/33049012

Reviewed by Tim Horton.
Source/WebCore:

Baidu.com has two event handlers on its <input>, and both query the input location with getBoundingClientRect()
and the current pageYOffset (via jQuery), then try to scroll the input to the top of the screen. The bug is that
programmatic scrolls did not immediately update the layout viewport rect, so the second call to
getBoundingClientRect() would return stale coordinates, triggering an extra scroll.

To fix this, undo the fix for r219320 which tried to keep getBoundingClientRect() current during unstable scroll
updates by adding a shadow layout viewport rect. Instead, almost always update the layout viewport rect on
FrameView, even during unstable visible rect updates, but not if content insets are being changed interactively,
since changing viewport heights cause problems with bottom-fixed elements. Also, we need to compute a new layout
viewport rect in FrameView::updateLayoutViewport() for programmatic scrolls.

However, always updating the layout viewport triggered issues with the scrolling tree. The scrolling state tree
fossilizes layer positions relative to a specific viewport rect, and that relationship has to be maintained.
There are code paths that recompute fixed/sticky viewport constraints when the layout viewport has changed but
we haven't done layout or recomputed layer positions (e.g. updating viewport-constrained layers via
updateScrollCoordinatedLayersAfterFlush()) and in these cases using a new layout viewport for those computations
results in an inconsistent scrolling tree.

Fix this by not updating scrolling constraints every time we have to re-register scrolling nodes.
updateScrollCoordinatedLayersAfterFlush() only needs to update the layer on the scrolling node (to handle
tiled/non-tiled switches), so make updateScrollCoordinatedLayer() a little more fine-grained, and only update
constraints when we've just computed layer geometry. This allows for different scrolling nodes to have
constraints computed at different times, with different layout viewports, which happens.

Two additional fixes were required to make bottom-fixed bars behave correctly.

First, FrameView::computeLayoutViewportOrigin() had a bug where rounding of half-pixel values would cause it to
fall into the if (visualViewport.height() > layoutViewport.height()) clause, but then fail to clamp for
rubber-banding.

Second, the FrameView::unscaledMaximumScrollPosition() was wrong after zooming on iOS, since it uses visibleSize()
which is affected by page scale on iOS only (and the function wants scale-independent values). Fix with a hack that
should be cleaned up via webkit.org/b/174648.

Tested by existing tests.

* page/FrameView.cpp:
(WebCore::FrameView::computeUpdatedLayoutViewportRect):
(WebCore::FrameView::computeLayoutViewportOrigin):
(WebCore::FrameView::setLayoutViewportOverrideRect):
(WebCore::FrameView::updateLayoutViewport):
(WebCore::FrameView::unscaledMaximumScrollPosition):
(WebCore::FrameView::documentToClientOffset):
(WebCore::FrameView::setUnstableLayoutViewportRect): Deleted.
* page/FrameView.h:
* page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::updateScrollPositionAfterAsyncScroll):
(WebCore::AsyncScrollingCoordinator::reconcileScrollingState):
(WebCore::AsyncScrollingCoordinator::reconcileViewportConstrainedLayerPositions):
(WebCore::AsyncScrollingCoordinator::updateNodeLayer):
(WebCore::AsyncScrollingCoordinator::updateNodeViewportConstraints):
(WebCore::AsyncScrollingCoordinator::updateViewportConstrainedNode): Deleted.
* page/scrolling/AsyncScrollingCoordinator.h:
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::operator<<):
* page/scrolling/ScrollingCoordinator.h:
(WebCore::ScrollingCoordinator::reconcileScrollingState):
(WebCore::ScrollingCoordinator::updateNodeLayer):
(WebCore::ScrollingCoordinator::updateNodeViewportConstraints):
(WebCore::ScrollingCoordinator::updateViewportConstrainedNode): Deleted.
* page/scrolling/ScrollingStateFixedNode.cpp:
(WebCore::ScrollingStateFixedNode::updateConstraints):
* page/scrolling/ScrollingStateStickyNode.cpp:
(WebCore::ScrollingStateStickyNode::updateConstraints):
(WebCore::ScrollingStateStickyNode::reconcileLayerPositionForViewportRect):
* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::commitTreeState):
* page/scrolling/mac/ScrollingTreeFixedNode.mm:
(WebCore::ScrollingTreeFixedNode::updateLayersAfterAncestorChange):
* page/scrolling/mac/ScrollingTreeStickyNode.mm:
(WebCore::ScrollingTreeStickyNode::updateLayersAfterAncestorChange):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGeometry):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateScrollCoordinatedLayersAfterFlush):
(WebCore::RenderLayerCompositor::updateBacking):
(WebCore::RenderLayerCompositor::fixedRootBackgroundLayerChanged):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
(WebCore::RenderLayerCompositor::updateScrollCoordinatedStatus):
(WebCore::RenderLayerCompositor::computeFixedViewportConstraints):
(WebCore::RenderLayerCompositor::computeStickyViewportConstraints):
(WebCore::RenderLayerCompositor::updateScrollCoordinatedLayer):
(WebCore::RenderLayerCompositor::didAddScrollingLayer):
* rendering/RenderLayerCompositor.h:

Source/WebKit:

Feed ViewportRectStability and ScrollingLayerPositionAction into reconcileScrollingState().

* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::updateVisibleContentRects):

LayoutTests:

New results for these tests, reflecting the fact that programmatic scrolls now update
the layout viewport.

Clean up fast/dom/elementFromPoint-relative-to-viewport.html, and land an iOS expectation. The test
uses eventSender.zoomPageOut() which is not expected to work correctly on iOS. It works when tested
manually.

* fast/dom/elementFromPoint-relative-to-viewport-expected.txt:
* fast/dom/elementFromPoint-relative-to-viewport.html:
* platform/ios-wk2/fast/dom/elementFromPoint-relative-to-viewport-expected.txt: Copied from LayoutTests/fast/dom/elementFromPoint-relative-to-viewport-expected.txt.
* platform/ios-wk2/fast/visual-viewport/client-rects-relative-to-layout-viewport-expected.txt:
* platform/ios-wk2/fast/visual-viewport/rtl-zoomed-rects-expected.txt:
* platform/ios-wk2/fast/visual-viewport/zoomed-fixed-scroll-down-then-up-expected.txt:
* platform/ios-wk2/fast/visual-viewport/zoomed-rects-expected.txt:
* platform/ios/fast/visual-viewport/zoomed-fixed-expected.txt:
* platform/ios/fast/visual-viewport/zoomed-fixed-header-and-footer-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed attempt to fix API test failure after r219663.
cdumez@apple.com [Wed, 19 Jul 2017 23:59:22 +0000 (23:59 +0000)]
Unreviewed attempt to fix API test failure after r219663.

The test was hard-coding an exception string and the string has changed slightly
in r219663.

* TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
(TEST):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoDon't write file URLs to iOS Pasteboard
megan_gardner@apple.com [Wed, 19 Jul 2017 23:57:38 +0000 (23:57 +0000)]
Don't write file URLs to iOS Pasteboard
https://bugs.webkit.org/show_bug.cgi?id=174647
<rdar://problem/33199730>

Reviewed by Wenson Hsieh.

Source/WebCore:

Tests updated to reflect the changes. We are no longer vending file URLs in Drag & Drop and Copy/Paste.

* editing/ios/EditorIOS.mm:
(WebCore::Editor::writeImageToPasteboard):
* platform/ios/PlatformPasteboardIOS.mm:
(WebCore::PlatformPasteboard::write):

Tools:

Updating tests to reflect the lack of file URLs for images.

* TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
(checkTypeIdentifierAndIsNotOtherTypeIdentifier):
(checkEstimatedSize):
(TestWebKitAPI::TEST):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoSetting the minimum font size preference doesn’t affect absolute line-height values...
mmaxfield@apple.com [Wed, 19 Jul 2017 23:38:06 +0000 (23:38 +0000)]
Setting the minimum font size preference doesn’t affect absolute line-height values, so lines overlap
https://bugs.webkit.org/show_bug.cgi?id=174406
Source/WebCore:

Reviewed by Simon Fraser.
<rdar://problem/10139227>

Reviewed by NOBODY.

When the minimumFontSize API preference is set, we will increase the font size without increasing
the line height. If the content specifies line-height as an absolute value, there can be two
unfortunate results:

- Adjacent lines in a paragraph can overlap
- If the paragraph (or containin block or whatever) uses overflow: hidden, the first and last lines
can be cut off and potentially indecipherable.

Instead, we should use the minimum font size preference as a signal that we should increase the
line-height as well as the font-size. Eventually, we will want to increase it by an amount
proportional to the increase in font-size (which can be due to minimumFontSize, minimumLogicalFontSize,
text autosizing, etc.). However, because minimumLogicalFontSize is on by default, this would cause
a behavior change on many webpages which use small text, so such a change would be too risky right now.
Instead, we can pretend that minimumFontSize is the only cause that text increases, and use this as the
only signal to boost the corresponding line-height.

Tests: fast/text/line-height-minimumFontSize-text-zoom.html
       fast/text/line-height-minimumFontSize-visual.html
       fast/text/line-height-minimumFontSize-zoom.html
       fast/text/line-height-minimumFontSize.html
       fast/text/line-height-minimumFontSize-autosize.html

* css/StyleBuilderCustom.h:
(WebCore::computeBaseSpecifiedFontSize):
(WebCore::computeLineHeightMultiplierDueToFontSize):
(WebCore::StyleBuilderCustom::applyValueLineHeight):
(WebCore::StyleBuilderCustom::applyValueFill):
(WebCore::StyleBuilderCustom::applyValueStroke):
(WebCore::StyleBuilderCustom::applyValueContent):
* rendering/TextAutoSizing.cpp:

LayoutTests:

<rdar://problem/10139227>

Reviewed by Simon Fraser.

* fast/text/line-height-minimumFontSize-autosize-expected.text: Added.
* fast/text/line-height-minimumFontSize-autosize.html: Added.
* fast/text/line-height-minimumFontSize-expected.txt: Added.
* fast/text/line-height-minimumFontSize-text-zoom-expected.html: Added.
* fast/text/line-height-minimumFontSize-text-zoom.html: Added.
* fast/text/line-height-minimumFontSize-visual-expected.html: Added.
* fast/text/line-height-minimumFontSize-visual.html: Added.
* fast/text/line-height-minimumFontSize-zoom-expected.html: Added.
* fast/text/line-height-minimumFontSize-zoom.html: Added.
* fast/text/line-height-minimumFontSize.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoiBooks sometimes crashes when closing a book.
beidson@apple.com [Wed, 19 Jul 2017 20:42:21 +0000 (20:42 +0000)]
iBooks sometimes crashes when closing a book.
<rdar://problem/31180331> and https://bugs.webkit.org/show_bug.cgi?id=174658

Reviewed by Oliver Hunt.

Source/WebKit:

- LegacyCustomProtocolManagerProxy should not reference a WebProcessPool directly.
- LegacyCustomProtocolManagerProxy should invalidate in its destructor.

* UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.cpp:
(WebKit::LegacyCustomProtocolManagerProxy::LegacyCustomProtocolManagerProxy):
(WebKit::LegacyCustomProtocolManagerProxy::~LegacyCustomProtocolManagerProxy):
(WebKit::LegacyCustomProtocolManagerProxy::startLoading):
(WebKit::LegacyCustomProtocolManagerProxy::stopLoading):
(WebKit::LegacyCustomProtocolManagerProxy::invalidate):
(WebKit::LegacyCustomProtocolManagerProxy::wasRedirectedToRequest):
(WebKit::LegacyCustomProtocolManagerProxy::didReceiveResponse):
(WebKit::LegacyCustomProtocolManagerProxy::didLoadData):
(WebKit::LegacyCustomProtocolManagerProxy::didFailWithError):
(WebKit::LegacyCustomProtocolManagerProxy::didFinishLoading):
(WebKit::LegacyCustomProtocolManagerProxy::processDidClose): Deleted.
* UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.h:

* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::NetworkProcessProxy):
(WebKit::NetworkProcessProxy::didClose):
* UIProcess/Network/NetworkProcessProxy.h:
(WebKit::NetworkProcessProxy::processPool):

Tools:

* TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
(-[ProcessPoolDestroyedDuringLoadingProtocol startLoading]):
(-[ProcessPoolDestroyedDuringLoadingProtocol finishTheLoad]):
(-[ProcessPoolDestroyedDuringLoadingProtocol stopLoading]):
(TestWebKitAPI::TEST):

Add a "spin the runloop X number of times" utility:
* TestWebKitAPI/Utilities.h:
* TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
(TestWebKitAPI::Util::spinRunLoop):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoDOMException should not have its own toString()
cdumez@apple.com [Wed, 19 Jul 2017 20:24:15 +0000 (20:24 +0000)]
DOMException should not have its own toString()
https://bugs.webkit.org/show_bug.cgi?id=174630

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Rebaseline existing tests now that more checks are passing.

* web-platform-tests/WebIDL/ecmascript-binding/es-exceptions/DOMException-custom-bindings.any-expected.txt:
* web-platform-tests/WebIDL/ecmascript-binding/es-exceptions/DOMException-custom-bindings.any.worker-expected.txt:

Source/WebCore:

DOMException should not have its own toString() and should use the one from Error.prototype.toString()
instead:
- https://heycam.github.io/webidl/#idl-DOMException

No new tests, rebaselined existing tests.

* dom/DOMCoreException.idl:

LayoutTests:

Rebaseline existing tests as the exception string is now slightly different.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[iOS] REGRESSION: Scrubbing media using built-in controls does not pause media
commit-queue@webkit.org [Wed, 19 Jul 2017 20:13:15 +0000 (20:13 +0000)]
[iOS] REGRESSION: Scrubbing media using built-in controls does not pause media
https://bugs.webkit.org/show_bug.cgi?id=174650
<rdar://problem/33401877>

Patch by Antoine Quint <graouts@apple.com> on 2017-07-19
Reviewed by Dean Jackson.

Source/WebCore:

We would only pause when scrubbing on macOS because we only listened to "mousedown" events on the
scrubber's backing <input> element to identify that the user had started interacting with the
scrubber.

Implementing the same technique on iOS required a little more work than just listening to "touchstart"
events on the same element. On top of that, we needed to make sure that we would only respond to
"touchstart" events on the slider's thumb, and not on the track, since only on macOS should the user
be able to click anywhere on the track to scrub. So we turn off pointer-events for the <input> on iOS
only, and turn them back on specifically for the thumb.

There is also some finessing when dealing with touch events where we need to track the identifier of
the touch that started the user interaction. So we keep track of it in an ivar and wait until we get
a "touchend" event where the changedTouches list contains a touch with that same identifier to ensure
the same touch that initiates and ends the scrubbing interaction.

Finally, we fix another issue that was uncovered while turning back on the ScrubbingSupport tests
where we would not trash the cached _value ivar when we initiated scrubbing, which was important since
we would mistakenly use the pre-srubbing value during a scrub.

* Modules/modern-media-controls/controls/slider.css:
(.ios .slider > input):
(.slider > input::-webkit-slider-thumb):
* Modules/modern-media-controls/controls/slider.js:
(Slider.prototype.handleEvent):
(Slider.prototype._handleMousedownEvent):
(Slider.prototype._interactionEndTarget):
(Slider.prototype._handleTouchstartEvent):
(Slider.prototype._valueWillStartChanging):
(Slider.prototype._valueDidStopChanging):
(Slider.prototype._handleMouseupEvent):
(Slider.prototype._handleTouchendEvent):

LayoutTests:

Rebaseline and turn back on all the ScrubberSupport tests on macOS and iOS.

* media/modern-media-controls/scrubber-support/ipad/scrubber-support-drag-expected.txt:
* media/modern-media-controls/scrubber-support/ipad/scrubber-support-drag.html:
* media/modern-media-controls/scrubber-support/scrubber-support-media-api-expected.txt:
* media/modern-media-controls/scrubber-support/scrubber-support-media-api.html:
* platform/ios-simulator/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAX: Web page reloaded when a node is labelling multiple childnodes
n_wang@apple.com [Wed, 19 Jul 2017 19:18:40 +0000 (19:18 +0000)]
AX: Web page reloaded when a node is labelling multiple childnodes
https://bugs.webkit.org/show_bug.cgi?id=174655

Reviewed by Chris Fleizach.

Source/WebCore:

When we are asking for the aria-labelledby attribute of a node and its
sibling is also labelled by the same node, we get into an infinite loop
in textUnderElement since we only ignore one child. Added checks for
siblings to avoid such loop.

Test: accessibility/mac/aria-labelledby-multiple-child-crash.html

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::textUnderElement):

LayoutTests:

* accessibility/mac/aria-labelledby-multiple-child-crash-expected.txt: Added.
* accessibility/mac/aria-labelledby-multiple-child-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUse a cast to work around clang's false -Wobjc-literal-conversion warnings
aestes@apple.com [Wed, 19 Jul 2017 18:16:35 +0000 (18:16 +0000)]
Use a cast to work around clang's false -Wobjc-literal-conversion warnings
https://bugs.webkit.org/show_bug.cgi?id=174631

Reviewed by Dan Bernstein.

Instead of ignoring -Wobjc-literal-conversion, use a cast to work around rdar://problem/33383354.

* platform/ios/PlatformPasteboardIOS.mm:
(WebCore::PlatformPasteboard::write):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMake cross-origin properties enumerable
cdumez@apple.com [Wed, 19 Jul 2017 18:16:21 +0000 (18:16 +0000)]
Make cross-origin properties enumerable
https://bugs.webkit.org/show_bug.cgi?id=174576

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Re-sync tests from upstream and rebaseline to improve test coverage.

* web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-expected.txt:
* web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects.html:
* web-platform-tests/html/browsers/the-window-object/window-indexed-properties-expected.txt:
* web-platform-tests/html/browsers/the-window-object/window-indexed-properties.html:

Source/WebCore:

Makes cross-origin properties enumerable on Window and Location objects
as per:
- https://github.com/whatwg/html/pull/2777

This simplifies our code quite a bit.

No new tests, updated existing tests.

* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::jsDOMWindowGetOwnPropertySlotRestrictedAccess):
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):
(WebCore::JSDOMWindow::getOwnPropertyNames):
* bindings/js/JSLocationCustom.cpp:
(WebCore::getOwnPropertySlotCommon):
(WebCore::JSLocation::getOwnPropertyNames):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):

LayoutTests:

Update / rebaseline some tests to reflect behavior change.

* http/tests/security/cross-origin-descriptors-expected.txt:
* http/tests/security/cross-origin-descriptors.html:
* js/dom/getOwnPropertyDescriptor-expected.txt:
* js/resources/getOwnPropertyDescriptor.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[EME] Build failure with Clang-3.8 on InitDataRegistry.cpp
clopez@igalia.com [Wed, 19 Jul 2017 17:27:10 +0000 (17:27 +0000)]
[EME] Build failure with Clang-3.8 on InitDataRegistry.cpp
https://bugs.webkit.org/show_bug.cgi?id=174628

Reviewed by Žan Doberšek.

* Modules/encryptedmedia/InitDataRegistry.cpp:
(WebCore::extractKeyIDsKeyids): Add an explicit cast to unsigned.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agolint-test-expectations should be run during style checking
jbedard@apple.com [Wed, 19 Jul 2017 17:09:32 +0000 (17:09 +0000)]
lint-test-expectations should be run during style checking
https://bugs.webkit.org/show_bug.cgi?id=173559
<rdar://problem/32854941>

Reviewed by David Kilzer.

Running the test expectation linter requires reading both files and lines not in the
patch because, for example, deletion of a test can cause a lint failure even though
no test expectations where modified. This means that the linter will occasionally warn
about lines which were not changed in a given patch but whose error is related to a
change made in that patch.

* Scripts/webkitpy/common/system/filesystem_mock.py:
(MockFileSystem.open_text_file_for_reading): Add 'errors' argument to mimic filesystem.
* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationWarning): Added class to pass warnings as an object instead of a string.
(TestExpectationWarning.__init__): Construct warning with file name, line number, line
content, description of the error and the name of the associated test.
(TestExpectationWarning.__str__): Convert to string so that existing printing code works.
(TestExpectationParser.__init__): Pass shorten_filename function to
TestExpectationsParser to add a deleted file to the related_files dictionary.
(TestExpectationParser._check_test_exists): If the test does not exist, add the
missing path to the related_files dictionary.
(TestExpectationLine.__init__): Add related_files dictionary, which tracks
files and line numbers related to this test expectation line. This will allow
tracking linter errors in the style checker occurring across multiple files.
(TestExpectationsModel._already_seen_better_match): Add redundant expectation
lines to related_files dictionary.
(TestExpectations.__init__): Pass self._shorten_filename to TestExpectationParser.
(TestExpectations._report_warnings): Construct warning object instead of string
when adding to warnings list.
* Scripts/webkitpy/port/win.py: Changed logging level form warning to debug to
clean-up log.
* Scripts/webkitpy/style/checker.py:
(ProcessorBase.do_association_check): Add required function for processor classes.
(StyleProcessor):
(StyleProcessor.do_association_check): Run the TestExpectations linter when
checking for errors between associated files.
* Scripts/webkitpy/style/checkers/test_expectations.py:
(TestExpectationsChecker.check_test_expectations): Reflect changed import statements.
(TestExpectationsChecker):
(TestExpectationsChecker._should_log_linter_warning): Given a warning, a dictionary
of modified files, the current working directory and the host, determine if the linter
warning is associated with the changes.
(TestExpectationsChecker.lint_test_expectations): Lint test expectations for the
style checker.
* Scripts/webkitpy/style/filereader.py:
(TextFileReader):
(TextFileReader.__init__): Track modified files in dictionary instead of a counter.
(TextFileReader.file_count): Use dictionary to determine the number of modified files.
(TextFileReader.process_file): Track both the number of files changed and which lines
in those files were changed.
(TextFileReader.do_association_check): Run the processor's association check on all
modified or deleted files processed by TextFileReader.
(TextFileReader.delete_file): Track deleted files in _files dictionary.
(TextFileReader.count_delete_only_file): Deleted.
* Scripts/webkitpy/style/filereader_unittest.py:
(TextFileReaderTest.test_delete_file): Renamed function to reflect new function name.
(TextFileReaderTest.test_count_delete_only_file): Moved to test_delete_file.
* Scripts/webkitpy/style/main.py:
(CheckWebKitStyle.main): When running the style checker on a specific list of files,
explicitly run the association check on the file reader.
* Scripts/webkitpy/style/main_unittest.py:
(ExpectationLinterInStyleCheckerTest): Added to test the TestExpectationLinter now
embedded in the style checker.
(ExpectationLinterInStyleCheckerTest.setUp): Set up the style checker configuration.
(ExpectationLinterInStyleCheckerTest._generate_file_reader): Given a filesystem object,
construct the TextFileReader object with a StyleProcessor used to run style checks on
specific files.
(ExpectationLinterInStyleCheckerTest._generate_testing_host): Generate a host used for
testing the test expectation linter inside the style checker. This host must contain a
mock file system with the basic structure of test expectations.
(ExpectationLinterInStyleCheckerTest.test_no_linter_errors):
(ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line):
(ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit):
(ExpectationLinterInStyleCheckerTest.test_linter_deleted_file):
(ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit):
* Scripts/webkitpy/style/patchreader.py:
(PatchReader.check): Specify which file was deleted, run the association check.
* Scripts/webkitpy/style/patchreader_unittest.py:
(PatchReaderTest.MockTextFileReader.delete_file): Renamed count_delete_only_file.
(PatchReaderTest.MockTextFileReader.do_association_check): Added.
(PatchReaderTest.MockTextFileReader.count_delete_only_file): Renamed delete_file.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, rolling out r219646.
jlewis3@apple.com [Wed, 19 Jul 2017 16:42:53 +0000 (16:42 +0000)]
Unreviewed, rolling out r219646.

The test added are failing on all platforms

Reverted changeset:

"Setting the minimum font size preference doesn’t affect
absolute line-height values, so lines overlap"
https://bugs.webkit.org/show_bug.cgi?id=174406
http://trac.webkit.org/changeset/219646

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed WPE gardening.
zandobersek@gmail.com [Wed, 19 Jul 2017 14:10:02 +0000 (14:10 +0000)]
Unreviewed WPE gardening.

* platform/wpe/TestExpectations:
Unskip a bunch of Web Crypto tests that are passing now that
the underlying implementation has progressed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[WTF] Remove unnecessary indirection of WTF::Thread entry point
utatane.tea@gmail.com [Wed, 19 Jul 2017 10:44:57 +0000 (10:44 +0000)]
[WTF] Remove unnecessary indirection of WTF::Thread entry point
https://bugs.webkit.org/show_bug.cgi?id=174291

Reviewed by Mark Lam.

Now wtfThreadEntryPoint is almost the same. Only the difference is function signature due to platform APIs.
We remove ThreadFunctionInvocation indirection in ThreadingPthread.cpp and ThreadingWin.cpp.

Also, ThreadFunctionInvocation keeps a RefPtr to the Thread object. This was previously needed to keep the
Thread object alive until the thread itself could install the ThreadHolder into its thread local storage.
The ThreadHolder has a Ref that keeps the Thread object alive for the lifetime of the thread. Since
Thread::create() now waits for the thread to be initialized before returning and Thread::create() hold a Ref
to the Thread object, we are guaranteed that the Thread object will be alive long enough for it to be installed
in the thread's ThreadHolder, and we no longer need ThreadFunctionInvocation.

And we also simplify ThreadHolder::initialize a bit. Now Thread::create waits for the completion of Thread
initialization. So, after establishing thread handle, we can call ThreadHolder::initialize before completing
Thread initialization.

Also we drop errno.h ifdefs in ThreadingWin.cpp. This is introduced to support WinCE. But now WinCE port is removed.

* WTF.xcodeproj/project.pbxproj:
* wtf/ThreadFunctionInvocation.h: Removed.
* wtf/ThreadHolder.h:
* wtf/ThreadHolderWin.cpp:
(WTF::ThreadHolder::initialize):
* wtf/Threading.cpp:
(WTF::Thread::entryPoint):
(WTF::Thread::create):
(WTF::threadEntryPoint): Deleted.
* wtf/Threading.h:
* wtf/ThreadingPthreads.cpp:
(WTF::Thread::initializeCurrentThreadEvenIfNonWTFCreated):
(WTF::wtfThreadEntryPoint):
(WTF::Thread::establishHandle):
(WTF::Thread::initializeCurrentThreadInternal):
(WTF::Thread::current):
(WTF::Thread::establishPlatformSpecificHandle):
(WTF::Thread::createInternal): Deleted.
(WTF::Thread::establish): Deleted.
* wtf/ThreadingWin.cpp:
(WTF::Thread::initializeCurrentThreadEvenIfNonWTFCreated):
(WTF::Thread::initializeCurrentThreadInternal):
(WTF::wtfThreadEntryPoint):
(WTF::Thread::establishHandle):
(WTF::Thread::current):
(WTF::Thread::establishPlatformSpecificHandle):
(WTF::Thread::createInternal): Deleted.
(WTF::Thread::establish): Deleted.
* wtf/win/MainThreadWin.cpp:
(WTF::initializeMainThreadPlatform):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[WTF] Implement WTF::ThreadGroup
utatane.tea@gmail.com [Wed, 19 Jul 2017 08:43:57 +0000 (08:43 +0000)]
[WTF] Implement WTF::ThreadGroup
https://bugs.webkit.org/show_bug.cgi?id=174081

Reviewed by Mark Lam.

Source/JavaScriptCore:

Large part of MachineThreads are now removed and replaced with WTF::ThreadGroup.
And SamplingProfiler and others interact with WTF::Thread directly.

* API/tests/ExecutionTimeLimitTest.cpp:
* heap/MachineStackMarker.cpp:
(JSC::MachineThreads::MachineThreads):
(JSC::captureStack):
(JSC::MachineThreads::tryCopyOtherThreadStack):
(JSC::MachineThreads::tryCopyOtherThreadStacks):
(JSC::MachineThreads::gatherConservativeRoots):
(JSC::ActiveMachineThreadsManager::Locker::Locker): Deleted.
(JSC::ActiveMachineThreadsManager::add): Deleted.
(JSC::ActiveMachineThreadsManager::remove): Deleted.
(JSC::ActiveMachineThreadsManager::contains): Deleted.
(JSC::ActiveMachineThreadsManager::ActiveMachineThreadsManager): Deleted.
(JSC::activeMachineThreadsManager): Deleted.
(JSC::MachineThreads::~MachineThreads): Deleted.
(JSC::MachineThreads::addCurrentThread): Deleted.
(): Deleted.
(JSC::MachineThreads::removeThread): Deleted.
(JSC::MachineThreads::removeThreadIfFound): Deleted.
(JSC::MachineThreads::MachineThread::MachineThread): Deleted.
(JSC::MachineThreads::MachineThread::getRegisters): Deleted.
(JSC::MachineThreads::MachineThread::Registers::stackPointer): Deleted.
(JSC::MachineThreads::MachineThread::Registers::framePointer): Deleted.
(JSC::MachineThreads::MachineThread::Registers::instructionPointer): Deleted.
(JSC::MachineThreads::MachineThread::Registers::llintPC): Deleted.
(JSC::MachineThreads::MachineThread::captureStack): Deleted.
* heap/MachineStackMarker.h:
(JSC::MachineThreads::addCurrentThread):
(JSC::MachineThreads::getLock):
(JSC::MachineThreads::threads):
(JSC::MachineThreads::MachineThread::suspend): Deleted.
(JSC::MachineThreads::MachineThread::resume): Deleted.
(JSC::MachineThreads::MachineThread::threadID): Deleted.
(JSC::MachineThreads::MachineThread::stackBase): Deleted.
(JSC::MachineThreads::MachineThread::stackEnd): Deleted.
(JSC::MachineThreads::threadsListHead): Deleted.
* runtime/SamplingProfiler.cpp:
(JSC::FrameWalker::isValidFramePointer):
(JSC::SamplingProfiler::SamplingProfiler):
(JSC::SamplingProfiler::takeSample):
(JSC::SamplingProfiler::noticeCurrentThreadAsJSCExecutionThread):
* runtime/SamplingProfiler.h:
* wasm/WasmMachineThreads.cpp:
(JSC::Wasm::resetInstructionCacheOnAllThreads):

Source/WebCore:

* page/ResourceUsageThread.h:

Source/WebKit:

* Shared/AsyncRequest.h:

Source/WTF:

This patch implements WTF::ThreadGroup. It implements core of JSC::MachineThreads with more reliable way.
JSC::MachineThreads was complicated because of managing dead threads. Each JSC::MachineThreads has its
own TLS with a registered destructor. And everytime a thread dies, the registered TLS destructor is called.
And this destructor will remove the current dying thread from JSC::MachineThreads.

However the above implementation is tricky. And each JSC::MachineThreads requires own TLS space, which is
not considered in WTF's Windows ThreadSpecific implementation. Current design works well since we only
have small number of MachineThreads right now.

Instead, we use more reliable way. After introducing WTF::Thread, WTF::Thread has WTF::Thread::didExit,
which is called when associated TLS (with WTF::Thread) is destroyed. We leverage this mechanism to remove
WTF::Thread from MachineThreads.

This patch introduces WTF::ThreadGroup. It is tightly integrated with WTF::Thread: WTF::Thread knows
ThreadGroups which includes this thread. And WTF::ThreadGroup of course knows WTF::Threads added to it.
WTF::Thread::didExit carefully remove itself from WTF::ThreadGroups.

The most important part of this patch is locking. WTF::Thread can die. And WTF::ThreadGroup can die.
If we take a design using two fine grain locks in WTF::Thread and WTF::ThreadGroup, we easily encounter
dead lock. Consider the following case.

1. When adding WTF::Thread (TH) to WTF::ThreadGroup (THG), we first hold a lock of THG, and hold a lock of TH (locking order is THG -> TH).
2. When TH dies, TH need to hold a lock of TH to iterate THGs. And we hold a lock of THG to unregister TH from it (locking order is TH -> THG).
3. When suspending and resuming THs in THG, we first hold a lock of THG. And then, we hold a lock of TH to suspend and resume it (locking order is THG -> TH).
4. When destroying THG, we need to hold a lock of TH to unregister THG from TH. We can hold a lock of THG before that (locking order is THG -> TH).

Then, it easily causes dead lock. We cannot swap the locking order of (2) since iterating THG requires a lock of TH.
To solve this problem, we use std::shared_ptr and std::weak_ptr.

1. When adding WTF::Thread (TH) to WTF::ThreadGroup (THG), we first hold THG, and hold a lock of TH. (THG -> TH)
2. When TH dies, TH first hold lock of TH. And we use std::weak_ptr<>::lock() to retain non-destructed ThreadGroups.
If some of ThreadGroups are dying, we just ignore them. It is ok because such a ThreadGroup will be destructed. So we do not need to unregister this thread from
such a ThreadGroup. Then, we have Vector<std::shared_ptr<ThreadGroup>>. So we unlock a lock of TH. To unregister a thread from thread group, we first hold a
lock of THG and then hold a lock of TH. Both lifetime is ensured: THG is retained by std::shared_ptr. And TH is itself. (TH), (THG -> TH).
3. When suspending and resuming THs in THG, we first hold a lock of THG. And then, we hold a lock of TH to suspend and resume it (THG -> TH).
4. When destroying THG, we hold a lock of THG. And hold a lock of TH. During holding THG's lock, registered thread never dies because (2) holds THG lock. (THG -> TH).

We also fix suspend and resume locking mechanism to avoid dead lock. We should hold the global lock when suspending and resuming.
If we use per-thread lock, the suspended thread can hold the lock of the other threads. It causes dead lock.

* WTF.xcodeproj/project.pbxproj:
* wtf/AutomaticThread.cpp:
* wtf/CMakeLists.txt:
* wtf/CrossThreadCopier.h:
* wtf/ParkingLot.h:
* wtf/ThreadGroup.cpp: Copied from Source/JavaScriptCore/wasm/WasmMachineThreads.cpp.
(WTF::ThreadGroup::~ThreadGroup):
(WTF::ThreadGroup::add):
(WTF::ThreadGroup::addCurrentThread):
* wtf/ThreadGroup.h: Copied from Source/JavaScriptCore/wasm/WasmMachineThreads.cpp.
(WTF::ThreadGroup::create):
(WTF::ThreadGroup::threads):
(WTF::ThreadGroup::getLock):
(WTF::ThreadGroup::weakFromThis):
* wtf/Threading.cpp:
(WTF::shouldRemoveThreadFromThreadGroup):
(WTF::Thread::didExit):
(WTF::Thread::addToThreadGroup):
(WTF::Thread::removeFromThreadGroup):
* wtf/Threading.h:
* wtf/ThreadingPthreads.cpp:
(WTF::Thread::resume):
(WTF::Thread::getRegisters):
* wtf/ThreadingWin.cpp:
(WTF::Thread::resume):
(WTF::Thread::getRegisters):

Tools:

Add WTF::ThreadGroup tests.

* TestWebKitAPI/CMakeLists.txt:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
(TestWebKitAPI::testThreadGroup):
(TestWebKitAPI::TEST):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219653 268f45cc-cd09-0410-ab3c-d52691b4dbfc