WebKit.git
10 years ago2011-02-03 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Thu, 3 Feb 2011 09:37:14 +0000 (09:37 +0000)]
2011-02-03  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Ryosuke Niwa.

        Skip some tests that fail in WebKit2 due to missing DRT functionality
        https://bugs.webkit.org/show_bug.cgi?id=53666

        * platform/mac-wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 3 Feb 2011 08:59:03 +0000 (08:59 +0000)]
2011-02-03  Adam Barth  <abarth@webkit.org>

        Reviewed by Daniel Bates.

        Teach XSSFilter about data URLs
        https://bugs.webkit.org/show_bug.cgi?id=53662

        Tests that the XSS filter doesn't block script in data URLs.

        * http/tests/security/xssAuditor/data-urls-work-expected.txt: Added.
        * http/tests/security/xssAuditor/data-urls-work.html: Added.
2011-02-03  Adam Barth  <abarth@webkit.org>

        Reviewed by Daniel Bates.

        Teach XSSFilter about data URLs
        https://bugs.webkit.org/show_bug.cgi?id=53662

        The XSS filter doesn't really make sense for data URLs because
        everything in a "response" from a data URL was part of the request.

        Test: http/tests/security/xssAuditor/data-urls-work.html

        * html/parser/XSSFilter.cpp:
        (WebCore::XSSFilter::init):
        (WebCore::XSSFilter::filterToken):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Thu, 3 Feb 2011 08:11:24 +0000 (08:11 +0000)]
2011-02-03  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r77449.
        http://trac.webkit.org/changeset/77449
        https://bugs.webkit.org/show_bug.cgi?id=53663

        causes many WebKit2 tests to crash (Requested by othermaciej
        on #webkit).

        * Shared/API/c/WKSharedAPICast.h:
        (WebKit::toAPI):
        (WebKit::toCopiedAPI):
        (WebKit::toURLRef):
        (WebKit::toCopiedURLAPI):
        * Shared/WebString.h:
        (WebKit::WebString::isNull):
        (WebKit::WebString::WebString):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Chris Evans <cevans@chromium.org>
commit-queue@webkit.org [Thu, 3 Feb 2011 06:21:07 +0000 (06:21 +0000)]
2011-02-02  Chris Evans  <cevans@chromium.org>

        Reviewed by Darin Fisher.

        window.find() can fail when switching case sensitivity
        https://bugs.webkit.org/show_bug.cgi?id=53654

        The test coverage for this area is very poor, so I took the liberty
        of adding a more general test than is needed.

        * fast/text/find-window.html: Added.
        * fast/text/find-window-expected.txt: Added.
2011-02-02  Chris Evans  <cevans@chromium.org>

        Reviewed by Darin Fisher.

        window.find() can fail when switching case sensitivity
        https://bugs.webkit.org/show_bug.cgi?id=53654

        Reset the pattern to a safe one when done, to avoid usearch_reset()
        indirectly touching the old, stale text pointer.

        Test: fast/text/find-window.html

        * editing/TextIterator.cpp:
        (WebCore::SearchBuffer::~SearchBuffer): leave a safe pattern buffer when done.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 3 Feb 2011 05:45:47 +0000 (05:45 +0000)]
2011-02-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Daniel Bates.

        Teach XSSFilter that <param> elements can contain URLs
        https://bugs.webkit.org/show_bug.cgi?id=53652

        When loading plugins for the <object> tag, we're "smart" enough to
        reach into the <param> elements and pull out the URL in some cases.
        This patch teaches the XSSFilter how to block injections into those
        sorts of param elements.

        Fixes:
            http/tests/security/xssAuditor/object-*

        * html/HTMLParamElement.cpp:
        (WebCore::HTMLParamElement::isURLParameter):
        (WebCore::HTMLParamElement::isURLAttribute):
        (WebCore::HTMLParamElement::addSubresourceAttributeURLs):
        * html/HTMLParamElement.h:
            - Add a helper function so that HTMLParamElement can share the
              ground truth for these names with the XSSFilter.
        * html/parser/XSSFilter.cpp:
        (WebCore::XSSFilter::filterTokenInitial):
        (WebCore::XSSFilter::filterParamToken):
        * html/parser/XSSFilter.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix license block issues pointed out by Daniel Bates.
weinig@apple.com [Thu, 3 Feb 2011 05:41:21 +0000 (05:41 +0000)]
Fix license block issues pointed out by Daniel Bates.

* Shared/API/c/WKGraphicsContext.cpp:
* Shared/API/c/WKGraphicsContext.h:
* Shared/API/c/cg/WKGraphicsContextCG.cpp:
* Shared/API/c/cg/WKGraphicsContextCG.h:
* Shared/WebGraphicsContext.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 3 Feb 2011 05:17:54 +0000 (05:17 +0000)]
2011-02-02  Martin Robinson  <mrobinson@igalia.com>

        Rebaseline two tests after import of editing test results for GTK+.
        Also remove a platform-specific baseline for a test which is now passing.

        * platform/gtk/editing/pasteboard/emacs-ctrl-a-k-y-expected.txt:
        * platform/gtk/editing/selection/find-yensign-and-backslash-expected.txt: Removed.
        * platform/gtk/fast/dom/52776-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 3 Feb 2011 04:40:58 +0000 (04:40 +0000)]
2011-02-02  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by David Levin.

        GCC compiler on ARM issues bogus warnings and fails to compile.
        https://bugs.webkit.org/show_bug.cgi?id=53620

        Despite warnings explicitly being disallowed (-Wno-uninitialized),
        gcc (Ubuntu 4.4.3-4ubuntu5) 4.4.3 throws up the warnings like:

        "error: 'colorTransparent.unstatic.4909' may be used uninitialized in this function"

        The fix is to add an extra condition, which somehow pacifies the compiler.

        * css/CSSPrimitiveValue.cpp:
        (WebCore::CSSPrimitiveValue::createColor): Added workaround conditions.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 3 Feb 2011 04:35:21 +0000 (04:35 +0000)]
2011-02-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Daniel Bates.

        Teach XSSFilter about X-XSS-Protection
        https://bugs.webkit.org/show_bug.cgi?id=53640

        This patch causes us to pass:
            http/tests/security/xssAuditor/full-block-*
            http/tests/security/xssAuditor/no-protection-script-tag.html

        * html/parser/XSSFilter.cpp:
        (WebCore::XSSFilter::XSSFilter):
        (WebCore::XSSFilter::init):
        (WebCore::XSSFilter::filterToken):
        * html/parser/XSSFilter.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 3 Feb 2011 04:23:06 +0000 (04:23 +0000)]
2011-02-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Daniel Bates.

        When XSSFilter blocks JavaScript URLs, use a safe JavaScript URL
        instead of the empty string
        https://bugs.webkit.org/show_bug.cgi?id=53643

        In a URL context, the empty string completes to the URL of the current
        page, which causes these tests to go into an infinite loop.  Instead,
        we should use a "safe" JavaScript URL that does nothing.

        Fixes:
            http/tests/security/xssAuditor/javascript-link*

        * html/parser/XSSFilter.cpp:
        (WebCore::XSSFilter::eraseDangerousAttributesIfInjected):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/8380506> REGRESSION (r61921): RTL text in <b> tag doesn't display...
mitz@apple.com [Thu, 3 Feb 2011 04:13:51 +0000 (04:13 +0000)]
<rdar://problem/8380506> REGRESSION (r61921): RTL text in <b> tag doesn't display in WebKit under certain conditions
https://bugs.webkit.org/show_bug.cgi?id=44942

Reviewed by Sam Weinig.

Source/WebCore:

Test: fast/text/bidi-embedding-pop-and-push-same-2.html

* platform/text/BidiResolver.h:
(WebCore::::commitExplicitEmbedding): Changed to return a boolean indicating whether there was
a change to embedding levels.
(WebCore::::createBidiRunsForLine): If embedding levels did not change as a result of committing
the explicit embedding sequence, then runs were not added, and we should continue normally.

LayoutTests:

* fast/text/bidi-embedding-pop-and-push-same-2-expected.checksum: Added.
* fast/text/bidi-embedding-pop-and-push-same-2-expected.png: Added.
* fast/text/bidi-embedding-pop-and-push-same-2-expected.txt: Added.
* fast/text/bidi-embedding-pop-and-push-same-2.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd WKBundleFrameGetVisibleContentBoundsExcludingScrollbars API for WebKit2.
weinig@apple.com [Thu, 3 Feb 2011 03:46:59 +0000 (03:46 +0000)]
Add WKBundleFrameGetVisibleContentBoundsExcludingScrollbars API for WebKit2.

Reviewed by Dan Bernstein.

* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameGetContentBounds):
(WKBundleFrameGetVisibleContentBounds):
(WKBundleFrameGetVisibleContentBoundsExcludingScrollbars):
(WKBundleFrameGetScrollOffset):
* WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::contentBounds):
(WebKit::WebFrame::visibleContentBounds):
(WebKit::WebFrame::visibleContentBoundsExcludingScrollbars):
(WebKit::WebFrame::scrollOffset):
* WebProcess/WebPage/WebFrame.h:
Move implementation of frame geometry to the implementation file
instead of keeping it in the API file.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix miscalculation of the overhang area used for painting. We were
weinig@apple.com [Thu, 3 Feb 2011 03:45:32 +0000 (03:45 +0000)]
Fix miscalculation of the overhang area used for painting. We were
not correctly accounting for scrollbars resulting in an non-negative
overhang even when we weren't over the edge.

Reviewed by Dan Bernstein.

* platform/ScrollView.cpp:
(WebCore::ScrollView::calculateOverhangAreasForPainting):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Kenneth Russell <kbr@google.com>
kbr@google.com [Thu, 3 Feb 2011 03:01:41 +0000 (03:01 +0000)]
2011-02-02  Kenneth Russell  <kbr@google.com>

        Reviewed by Mihai Parparita.

        gl-teximage.html failing on some WebKit bots
        https://bugs.webkit.org/show_bug.cgi?id=53633

        * fast/canvas/webgl/gl-teximage.html:
          - Synced with upstream test; detect when running in DRT and
            avoid printing the specific pixel value when the test will pass.
        * fast/canvas/webgl/resources/red-indexed.png:
          - Stripped gamma and other colorspace information.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago'update-webkit' should handle OpenSource and Internal using different
aestes@apple.com [Thu, 3 Feb 2011 02:39:42 +0000 (02:39 +0000)]
'update-webkit' should handle OpenSource and Internal using different
VCSs.

Reviewed by Mark Rowe.

* Scripts/update-webkit: Re-check the VCS type when updating Apple's
Internal directory.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Thu, 3 Feb 2011 02:24:03 +0000 (02:24 +0000)]
2011-02-02  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Nate Chapin.

        IDBTransaction and IDBRequest can be deleted while ScriptExecutionContext is iterating....which is bad
        https://bugs.webkit.org/show_bug.cgi?id=52722

        The solution is to change ScriptExecutionContext's destructor to iterate over
        the list in a way that handles the mutations. This new method is destructive,
        but that's OK since the object is going away. I've also added a several asserts.

        There should be no behavior change.

        * dom/ScriptExecutionContext.cpp:
        (WebCore::ScriptExecutionContext::ScriptExecutionContext):
        (WebCore::ScriptExecutionContext::~ScriptExecutionContext):
        (WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects):
        (WebCore::ScriptExecutionContext::suspendActiveDOMObjects):
        (WebCore::ScriptExecutionContext::resumeActiveDOMObjects):
        (WebCore::ScriptExecutionContext::stopActiveDOMObjects):
        (WebCore::ScriptExecutionContext::createdActiveDOMObject):
        (WebCore::ScriptExecutionContext::destroyedActiveDOMObject):
        * dom/ScriptExecutionContext.h:
        * storage/IDBTransaction.cpp:
        (WebCore::IDBTransaction::contextDestroyed):
        * storage/IDBTransaction.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix.
mrowe@apple.com [Thu, 3 Feb 2011 02:11:14 +0000 (02:11 +0000)]
Build fix.

* WebCore.exp.in: Remove some bogus symbols from the .exp.in file.
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::unregisterScrollbar): Look the object
up in the HashMap rather than relying on a local variable that doesn't
exist.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 3 Feb 2011 02:04:09 +0000 (02:04 +0000)]
2011-02-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Daniel Bates.

        Teach XSSFilter about JavaScript URLs
        https://bugs.webkit.org/show_bug.cgi?id=53635

        This patch teaches the XSSFilter to check for JavaScript URLs in
        attribute values.  If this approach has too many false positives, we
        can restrict which attribute names we examine.

        Fixes these tests:
            http/tests/security/xssAuditor/anchor-url-dom-write-location-javascript-URL.html
            http/tests/security/xssAuditor/dom-write-location-javascript-URL.html
            http/tests/security/xssAuditor/iframe-javascript-url*

        * html/parser/XSSFilter.cpp:
        (WebCore::HTMLNames::containsJavaScriptURL):
        (WebCore::XSSFilter::filterTokenInitial):
        (WebCore::XSSFilter::eraseDangerousAttributesIfInjected):
        * html/parser/XSSFilter.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 3 Feb 2011 02:00:28 +0000 (02:00 +0000)]
2011-02-02  Martin Robinson  <mrobinson@igalia.com>

        Unskip the last batch of editing tests needing GTK+ results.

        * platform/gtk/Skipped: Unskip last batch of tests.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=53361
slewis@apple.com [Thu, 3 Feb 2011 01:58:03 +0000 (01:58 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=53361
<rdar://problem/8921729> REGRESSION: Membuster accumulates 1GB+ memory due to autorelease
pools not being drained.
Call into AppKit to add observers that push and pop autorelease pools on entry
and exit from the CFRunLoop.  This will prevent memory from accumulating.

Reviewed by Geoff Garen.

* WebProcess/mac/WebProcessMainMac.mm:
(WebKit::WebProcessMain):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix.
mitz@apple.com [Thu, 3 Feb 2011 01:55:51 +0000 (01:55 +0000)]
Build fix.

* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 3 Feb 2011 01:54:48 +0000 (01:54 +0000)]
2011-02-02  Martin Robinson  <mrobinson@igalia.com>

        Add one more set of missing editing layout test results for GTK.

        * platform/gtk/Skipped: Unskip more editing tests.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake null WTF::String objects turn into 0 pointers for WKStringRef and WKURLRef.
darin@apple.com [Thu, 3 Feb 2011 01:51:57 +0000 (01:51 +0000)]
Make null WTF::String objects turn into 0 pointers for WKStringRef and WKURLRef.
rdar://problem/8948688

Reviewed by Sam Weinig.

* Shared/API/c/WKSharedAPICast.h:
(WebKit::toAPI): Return 0 if the passed in string is 0.
(WebKit::toCopiedAPI): Ditto.
(WebKit::toURLRef): Ditto. Old code was trying to do this but was missing a return.
(WebKit::toCopiedURLAPI): Ditto. Old code was trying to do this but had incorrect
nll check.

* Shared/WebString.h: Removed isNull function. It can never return true.
Removed constructor code that turns the null string into the empty string.
Instead assert that the passed in string is not null.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build fix.
barraclough@apple.com [Thu, 3 Feb 2011 01:48:54 +0000 (01:48 +0000)]
Windows build fix.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/8928367> Crash when loading canvas pages inside HTMLCanvasElement...
mrowe@apple.com [Thu, 3 Feb 2011 01:36:21 +0000 (01:36 +0000)]
<rdar://problem/8928367> Crash when loading canvas pages inside HTMLCanvasElement::createImageBuffer().

Reviewed by Beth Dakin.

Source/WebKit/mac:

* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Add some missing initializers.

Source/WebKit2:

* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Add some missing initializers.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/8952012> Crash on launch inside scrollbar code.
mrowe@apple.com [Thu, 3 Feb 2011 01:36:14 +0000 (01:36 +0000)]
<rdar://problem/8952012> Crash on launch inside scrollbar code.

Reviewed by Beth Dakin.

We need to ensure that we remove ourselves as the delegates of objects when we're going
away as failing to do this can lead to crashes if the lifetime of the other objects
is longer than ours.

* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::unregisterScrollbar):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agooops, build fix!
barraclough@apple.com [Thu, 3 Feb 2011 01:36:03 +0000 (01:36 +0000)]
oops, build fix!

* wtf/Assertions.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 3 Feb 2011 01:35:22 +0000 (01:35 +0000)]
2011-02-02  Martin Robinson  <mrobinson@igalia.com>

        Continue importing new editing layout test results for GTK.

        * platform/gtk/Skipped: Unskip more editing tests.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBug 53650 - Add a BACKTRACE macro to Assertions.h
barraclough@apple.com [Thu, 3 Feb 2011 01:31:17 +0000 (01:31 +0000)]
Bug 53650 - Add a BACKTRACE macro to Assertions.h

Reviewed by Sam Weinig.

Add a BACKTRACE macro to Assertions.h, which will print a backtrace on
debug Mac builds, make CRASH (and thus ASSERT) automatically call this.

* JavaScriptCore.exp:
* wtf/Assertions.cpp:
* wtf/Assertions.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix.
bdakin@apple.com [Thu, 3 Feb 2011 01:29:23 +0000 (01:29 +0000)]
Build fix.

* WebCore.exp.in:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 3 Feb 2011 01:20:32 +0000 (01:20 +0000)]
2011-02-02  Martin Robinson  <mrobinson@igalia.com>

        Begin importing missing editing directory test results.

        * platform/gtk/Skipped: Unskip tests with results and classify failures.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Thu, 3 Feb 2011 01:17:36 +0000 (01:17 +0000)]
2011-02-02  Michael Saboff  <msaboff@apple.com>

        Reviewed by Gavin Barraclough.

        Improper backtrack of nested non-capturing greedy paren to prior paren
        https://bugs.webkit.org/show_bug.cgi?id=53261

        A paren that follows a non-capturing greedy paren nested within a
        non-capturing fixed paren was back tracking to the last paren
        processed instead of the immediately prior paren.
        Refactored default backtracking of parens to prior paren to work for
        both nested (within) and immediately prior (after) parens.

        * yarr/YarrJIT.cpp:
        (JSC::Yarr::YarrGenerator::GenerationState::addParenthesesTail):
        (JSC::Yarr::YarrGenerator::TermGenerationState::TermGenerationState):
        (JSC::Yarr::YarrGenerator::TermGenerationState::setJumpListToPriorParen):
        (JSC::Yarr::YarrGenerator::TermGenerationState::getJumpListToPriorParen):
        (JSC::Yarr::YarrGenerator::ParenthesesTail::ParenthesesTail):
        (JSC::Yarr::YarrGenerator::ParenthesesTail::generateCode):
        (JSC::Yarr::YarrGenerator::generateParenthesesDisjunction):
        (JSC::Yarr::YarrGenerator::generateParenthesesSingle):
        (JSC::Yarr::YarrGenerator::generateDisjunction):
2011-02-02  Michael Saboff  <msaboff@apple.com>

        Reviewed by Gavin Barraclough.

        Improper backtrack of nested non-capturing greedy paren to prior paren
        https://bugs.webkit.org/show_bug.cgi?id=53261

        New tests to validate change.

        * fast/regex/parentheses-expected.txt:
        * fast/regex/script-tests/parentheses.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Thu, 3 Feb 2011 01:14:04 +0000 (01:14 +0000)]
2011-02-02  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed WinCE build fix for r77397.

        * page/wince/FrameWinCE.cpp:
        (WebCore::computePageRectsForFrame):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Thu, 3 Feb 2011 01:04:25 +0000 (01:04 +0000)]
2011-02-02  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed WinCE build fix for r77398.

        * platform/graphics/wince/PlatformPathWinCE.cpp:
        (WebCore::containsPoint):
        (WebCore::inflateRectToContainPoint):
        (WebCore::PlatformPath::addRect):
        * platform/graphics/wince/SharedBitmap.cpp:
        (WebCore::SharedBitmap::drawPattern):
        * rendering/RenderThemeWinCE.cpp:
        (WebCore::RenderThemeWinCE::paintMenuListButton):
        (WebCore::RenderThemeWinCE::paintSearchFieldCancelButton):
        (WebCore::RenderThemeWinCE::paintSliderTrack):
        (WebCore::RenderThemeWinCE::paintMediaMuteButton):
        (WebCore::RenderThemeWinCE::paintMediaPlayButton):
        (WebCore::RenderThemeWinCE::paintMediaSeekBackButton):
        (WebCore::RenderThemeWinCE::paintMediaSeekForwardButton):
2011-02-02  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed WinCE build fix for r77398.

        * WebView.cpp:
        (WebView::paint):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 3 Feb 2011 00:55:45 +0000 (00:55 +0000)]
2011-02-02  Eric Seidel  <eric@webkit.org>

        Unreviewed.  Just fixing an exception seen in Firefox.

        HTML5 TreeBuilder regressed a Peacekeeper DOM test by 40%
        https://bugs.webkit.org/show_bug.cgi?id=48719

        Make the benchmarks work in Firefox/Opera.

        * resources/runner.js:
        (log):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Evan Martin <evan@chromium.org>
evan@chromium.org [Thu, 3 Feb 2011 00:55:06 +0000 (00:55 +0000)]
2011-02-02  Evan Martin  <evan@chromium.org>

        Unreviewed, DEPS change.

        * DEPS: update to pick up newer Skia.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 3 Feb 2011 00:52:45 +0000 (00:52 +0000)]
2011-02-02  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Mihai Parparita.

        new-run-webkit-tests: hardcode the directories to scan for tests
        for GPU bots instead of SKIPping them. See bug 53562 for some
        context, but we will now hard-code the list of directories to
        use by default instead of skipping over directories in the
        expectations file. We do this so that we will be able to merge
        the expectations files without getting conflicting SKIP
        directives. Note that this change will reduce the # of tests
        being run on the Mac GPU bots, because we're accidentally
        including some today.

        https://bugs.webkit.org/show_bug.cgi?id=53631

        * platform/chromium-gpu/test_expectations.txt:
2011-02-02  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Mihai Parparita.

        new-run-webkit-tests: hardcode the directories to scan for tests
        for GPU bots instead of SKIPping them. See bug 53562 for some
        context, but we will now hard-code the list of directories to
        use by default instead of skipping over directories in the
        expectations file. We do this so that we will be able to merge
        the expectations files without getting conflicting SKIP
        directives. Note that this change will reduce the # of tests
        being run on the Mac GPU bots, because we're accidentally
        including some today.

        https://bugs.webkit.org/show_bug.cgi?id=53631

        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
        * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[V8] Accessing DataView with index of -1 returns 0, doesn't throw
jianli@chromium.org [Thu, 3 Feb 2011 00:52:12 +0000 (00:52 +0000)]
[V8] Accessing DataView with index of -1 returns 0, doesn't throw
https://bugs.webkit.org/show_bug.cgi?id=53559

Reviewed by Kenneth Russell.

Source/WebCore:

Added test cases to cover this in fast/canvas/webgl/data-view-test.html.

* html/canvas/DataView.h:
(WebCore::DataView::beyondRange):

LayoutTests:

* fast/canvas/webgl/data-view-test-expected.txt:
* fast/canvas/webgl/data-view-test.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd ChromeClient function to paint custom overhang areas.
weinig@apple.com [Thu, 3 Feb 2011 00:44:06 +0000 (00:44 +0000)]
Add ChromeClient function to paint custom overhang areas.
https://bugs.webkit.org/show_bug.cgi?id=53639

Reviewed by Beth Dakin.

Source/WebCore:

* page/Chrome.cpp:
(WebCore::ChromeClient::paintCustomOverhangArea):
* page/ChromeClient.h:
Add ChromeClient function.

* page/FrameView.cpp:
(WebCore::FrameView::paintOverhangAreas):
* page/FrameView.h:
Call out the the ChromeClient, call ScrollView base implementation
if the ChromeClient returns false.

* platform/ScrollView.cpp:
(WebCore::ScrollView::paintOverhangAreas):
* platform/ScrollView.h:
Add dirty rect for use when painting overhang areas.

Source/WebKit2:

* Shared/API/c/WKBase.h:
* Shared/API/c/WKGraphicsContext.cpp: Added.
(WKGraphicsContextGetTypeID):
* Shared/API/c/WKGraphicsContext.h: Added.
* Shared/API/c/WKSharedAPICast.h:
* Shared/API/c/cg/WKGraphicsContextCG.cpp: Added.
(WKGraphicsContextGetCGContext):
* Shared/API/c/cg/WKGraphicsContextCG.h: Added.
* Shared/APIObject.h:
* Shared/WebGraphicsContext.cpp: Added.
(WebKit::WebGraphicsContext::WebGraphicsContext):
* Shared/WebGraphicsContext.h: Added.
(WebKit::WebGraphicsContext::create):
(WebKit::WebGraphicsContext::platformContext):
(WebKit::WebGraphicsContext::type):
Add WebGraphicsContext API type.

* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
(WebKit::InjectedBundlePageUIClient::pageDidScroll):
(WebKit::InjectedBundlePageUIClient::shouldPaintCustomOverhangArea):
(WebKit::InjectedBundlePageUIClient::paintCustomOverhangArea):
* WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::paintCustomOverhangArea):
* WebProcess/WebCoreSupport/WebChromeClient.h:
Pipe paintCustomOverhangArea to the InjectedBundlePageUIClient.

* UIProcess/API/C/WebKit2.h:
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
* win/WebKit2Generated.make:
Add new files.

Tools:

* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
Stub out new callback.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 3 Feb 2011 00:33:29 +0000 (00:33 +0000)]
2011-02-02  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Tony Chang.

        new-run-webkit-tests: support chromium code paths in mock_drt

        https://bugs.webkit.org/show_bug.cgi?id=53471

        * Scripts/webkitpy/layout_tests/port/mock_drt.py:
        * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 3 Feb 2011 00:16:14 +0000 (00:16 +0000)]
2011-02-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Work towards making the layer tree host be in charge of all painting
        https://bugs.webkit.org/show_bug.cgi?id=53636

        Make sure that DrawingAreaImpl::display is never called when in accelerated compositing mode,
        since the layer tree host is supposed to handle all drawing in that case.

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::scroll):
        (WebKit::DrawingAreaImpl::setRootCompositingLayer):
        (WebKit::DrawingAreaImpl::setSize):
        (WebKit::DrawingAreaImpl::didUpdate):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNot reviewed, build fix.
pkasting@chromium.org [Wed, 2 Feb 2011 23:58:59 +0000 (23:58 +0000)]
Not reviewed, build fix.

Fix compile after r77427.
https://bugs.webkit.org/show_bug.cgi?id=53455

* platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::internalHandleCurrentImage):
* platform/image-decoders/ImageDecoder.cpp:
(WebCore::ImageFrame::operator=):
* platform/image-decoders/bmp/BMPImageReader.cpp:
(WebCore::BMPImageReader::decodeBMP):
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::JPEGImageDecoder::outputScanlines):
* platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::PNGImageDecoder::rowAvailable):
* platform/image-decoders/webp/WEBPImageDecoder.cpp:
(WebCore::WEBPImageDecoder::decode):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix the 32-bit build.
mrowe@apple.com [Wed, 2 Feb 2011 23:39:34 +0000 (23:39 +0000)]
Fix the 32-bit build.

* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::computeFakeWindowBoundsRect):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Peter Kasting <pkasting@google.com>
commit-queue@webkit.org [Wed, 2 Feb 2011 23:34:04 +0000 (23:34 +0000)]
2011-02-02  Peter Kasting  <pkasting@google.com>

        Reviewed by David Levin.

        Clean up ImageDecoder's comments (remove/trim/clarify).
        https://bugs.webkit.org/show_bug.cgi?id=53455

        This also renames or eliminates a couple of functions for clarity, and
        switches a couple erroneous strncmp() calls to memcmp().

        * platform/image-decoders/ImageDecoder.cpp:
        (WebCore::ImageDecoder::create):
        (WebCore::ImageFrame::clearPixelData):
        (WebCore::ImageFrame::zeroFillPixelData):
        (WebCore::ImageFrame::setSize):
        * platform/image-decoders/ImageDecoder.h:
        (WebCore::ImageFrame::originalFrameRect):
        (WebCore::ImageFrame::setOriginalFrameRect):
        (WebCore::ImageDecoder::ImageDecoder):
        (WebCore::ImageDecoder::~ImageDecoder):
        (WebCore::ImageDecoder::isSizeAvailable):
        (WebCore::ImageDecoder::size):
        (WebCore::ImageDecoder::setIgnoreGammaAndColorProfile):
        (WebCore::ImageDecoder::clearFrameBufferCache):
        (WebCore::ImageDecoder::isOverSize):
        * platform/image-decoders/bmp/BMPImageReader.cpp:
        (WebCore::BMPImageReader::processNonRLEData):
        * platform/image-decoders/cg/ImageDecoderCG.cpp:
        (WebCore::ImageFrame::setSize):
        * platform/image-decoders/gif/GIFImageDecoder.cpp:
        (WebCore::GIFImageDecoder::clearFrameBufferCache):
        (WebCore::GIFImageDecoder::frameComplete):
        (WebCore::GIFImageDecoder::initFrameBuffer):
        * platform/image-decoders/jpeg/JPEGImageDecoder.h:
        * platform/image-decoders/qt/ImageFrameQt.cpp:
        (WebCore::ImageFrame::operator=):
        (WebCore::ImageFrame::clearPixelData):
        (WebCore::ImageFrame::zeroFillPixelData):
        (WebCore::ImageFrame::setSize):
        * platform/image-decoders/skia/ImageDecoderSkia.cpp:
        (WebCore::ImageFrame::operator=):
        (WebCore::ImageFrame::clearPixelData):
        (WebCore::ImageFrame::zeroFillPixelData):
        (WebCore::ImageFrame::setSize):
        * platform/image-decoders/webp/WEBPImageDecoder.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-27 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 2 Feb 2011 23:32:39 +0000 (23:32 +0000)]
2011-01-27  Eric Seidel  <eric@webkit.org>

        Reviewed by Darin Adler.

        HTML5 TreeBuilder regressed a Peacekeeper DOM test by 40%
        https://bugs.webkit.org/show_bug.cgi?id=48719

        It's unclear exactly what the Peacekeeper benchmark is testing,
        because I haven't found a way to run it myself.

        However, I constructed a benchmark which shows at least one possible slow point.
        The HTML5 spec talks about creating a new document for every time we use
        the fragment parsing algorithm.  Document() it turns out, it a huge bloated
        mess, and the constructor and destructor do a huge amount of work.

        * benchmarks/parser/tiny-innerHTML.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Vangelis Kokkevis <vangelis@chromium.org>
vangelis@chromium.org [Wed, 2 Feb 2011 23:08:21 +0000 (23:08 +0000)]
2011-02-02  Vangelis Kokkevis  <vangelis@chromium.org>

        [chromium] Adding support for reflections to the accelerated
        compositing path.
        https://bugs.webkit.org/show_bug.cgi?id=53179

        All layout tests in compositing/reflections generate correct
        results with the exception of:
        1. nested-reflection-anchor-point.html : There appears to be
           some issue with the layer transform math that I haven't been
           able to track down yet.
        2. reflection-opacity.html : The current implementation applies
           opacity before doing the reflection which makes this test
           produce incorrect results.  This will affect reflected layers
           with opacity that overlap their original layer.  FIXME comment
           added in the code.

        Tests: Covered by existing layout tests in compositing/reflections.
               Please see above for exceptions.

        * platform/graphics/chromium/GraphicsLayerChromium.cpp:
        (WebCore::GraphicsLayerChromium::setReplicatedByLayer):
        (WebCore::GraphicsLayerChromium::updateAnchorPoint):
        * platform/graphics/chromium/GraphicsLayerChromium.h:
        * platform/graphics/chromium/LayerChromium.cpp:
        (WebCore::LayerChromium::LayerChromium):
        * platform/graphics/chromium/LayerChromium.h:
        (WebCore::LayerChromium::setReplicaLayer):
        (WebCore::LayerChromium::replicaLayer):
        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::updateLayersRecursive):
        (WebCore::LayerRendererChromium::drawLayer):
        * platform/graphics/chromium/RenderSurfaceChromium.cpp:
        (WebCore::RenderSurfaceChromium::drawableContentRect):
        (WebCore::RenderSurfaceChromium::drawSurface):
        (WebCore::RenderSurfaceChromium::draw):
        * platform/graphics/chromium/RenderSurfaceChromium.h:
        (WebCore::RenderSurfaceChromium::drawTransform):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Xiyuan Xia <xiyuan@chromium.org>
commit-queue@webkit.org [Wed, 2 Feb 2011 22:45:42 +0000 (22:45 +0000)]
2011-02-02  Xiyuan Xia  <xiyuan@chromium.org>

        Reviewed by Tony Chang.

        [Chromium] Select popup with padding has white strip on right
        https://bugs.webkit.org/show_bug.cgi?id=53602

        No new tests as this change restores old behavior.

        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupListBox::layout):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake sure that we don't try to call display() when in accelerated compositing mode
andersca@apple.com [Wed, 2 Feb 2011 22:45:09 +0000 (22:45 +0000)]
Make sure that we don't try to call display() when in accelerated compositing mode
https://bugs.webkit.org/show_bug.cgi?id=53629

Reviewed by Sam Weinig.

When in accelerated compositing mode, the layer tree host should handle all painting, so make sure that display() is never called.

* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::setNeedsDisplay):
(WebKit::DrawingAreaImpl::setRootCompositingLayer):
(WebKit::DrawingAreaImpl::display):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix for <rdar://problem/8950343> CrashTracer: [USER]
bdakin@apple.com [Wed, 2 Feb 2011 22:43:55 +0000 (22:43 +0000)]
Fix for <rdar://problem/8950343> CrashTracer: [USER]
1 crash in WebProcess at com.apple.WebCore:
WebCore::ScrollbarThemeMac::unregisterScrollbar + 22

Reviewed by Mark Rowe.

It is possible for a Scrollbar's ScrollableArea to be null,
so we must null check.
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::unregisterScrollbar):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Zhenyao Mo <zmo@google.com>
zmo@google.com [Wed, 2 Feb 2011 22:39:29 +0000 (22:39 +0000)]
2011-02-02  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        bufferData and bufferSubData should generate INVALID_VALUE with negative input
        https://bugs.webkit.org/show_bug.cgi?id=53626

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::bufferData):
        (WebCore::WebGLRenderingContext::bufferSubData):
2011-02-02  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        bufferData and bufferSubData should generate INVALID_VALUE with negative input
        https://bugs.webkit.org/show_bug.cgi?id=53626

        * fast/canvas/webgl/buffer-data-array-buffer-expected.txt:
        * fast/canvas/webgl/buffer-data-array-buffer.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd DerivedSources.make to some Visual Studio projects
aroben@apple.com [Wed, 2 Feb 2011 22:34:30 +0000 (22:34 +0000)]
Add DerivedSources.make to some Visual Studio projects

https://bugs.webkit.org/show_bug.cgi?id=53607

Patch by Jeff Miller <jeffm@apple.com> on 2011-02-02
Reviewed by Darin Adler and Steve Falkenburg.

Source/JavaScriptCore:

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj: Add DerivedSources.make.

Source/WebCore:

* WebCore.vcproj/WebCoreGenerated.vcproj: Add DerivedSources.make.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAssert WebBackForwardList's current index is valid to help catch errors
aroben@apple.com [Wed, 2 Feb 2011 22:33:55 +0000 (22:33 +0000)]
Assert WebBackForwardList's current index is valid to help catch errors

Hopefully this will help catch a crash I saw once but haven't yet been able to reproduce.

Fixes <http://webkit.org/b/53622>.

Reviewed by Brady Eidson.

* UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::WebBackForwardList):
(WebKit::WebBackForwardList::addItem):
(WebKit::WebBackForwardList::goToItem):
(WebKit::WebBackForwardList::currentItem):
(WebKit::WebBackForwardList::backItem):
(WebKit::WebBackForwardList::forwardItem):
(WebKit::WebBackForwardList::itemAtIndex):
(WebKit::WebBackForwardList::backListCount):
(WebKit::WebBackForwardList::forwardListCount):
(WebKit::WebBackForwardList::backListAsImmutableArrayWithLimit):
(WebKit::WebBackForwardList::forwardListAsImmutableArrayWithLimit):
(WebKit::WebBackForwardList::clear):
* UIProcess/cf/WebBackForwardListCF.cpp:
(WebKit::WebBackForwardList::createCFDictionaryRepresentation):
(WebKit::WebBackForwardList::restoreFromCFDictionaryRepresentation):
Assert that m_current is valid.

* UIProcess/WebBackForwardList.h: Moved the NoCurrentItemIndex to a static data member so
that it can be used from WebBackForwardListCF.cpp.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Cris Neckar <cdn@chromium.org>
inferno@chromium.org [Wed, 2 Feb 2011 22:25:49 +0000 (22:25 +0000)]
2011-02-02  Cris Neckar  <cdn@chromium.org>

        Reviewed by James Robinson.

        Tests for crash when a domwindow is removed within a device orientation event.
        https://bugs.webkit.org/show_bug.cgi?id=53623

        * fast/events/device-orientation-crash-expected.txt: Added.
        * fast/events/device-orientation-crash.html: Added.
2011-02-02  Cris Neckar  <cdn@chromium.org>

        Reviewed by James Robinson.

        Refcount domwindows when dispatching device orientation events.
        https://bugs.webkit.org/show_bug.cgi?id=53623

        Test: fast/events/device-orientation-crash.html

        * dom/DeviceMotionController.cpp:
        (WebCore::DeviceMotionController::timerFired):
        (WebCore::DeviceMotionController::didChangeDeviceMotion):
        * dom/DeviceMotionController.h:
        * dom/DeviceOrientationController.cpp:
        (WebCore::DeviceOrientationController::timerFired):
        (WebCore::DeviceOrientationController::didChangeDeviceOrientation):
        * dom/DeviceOrientationController.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Zhenyao Mo <zmo@google.com>
zmo@google.com [Wed, 2 Feb 2011 22:13:43 +0000 (22:13 +0000)]
2011-02-02  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        A deleted object should never been bound again
        https://bugs.webkit.org/show_bug.cgi?id=53604

        * fast/canvas/webgl/object-deletion-behaviour-expected.txt:
        * fast/canvas/webgl/object-deletion-behaviour.html: Add test cases for object binding and deletion.
2011-02-02  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        A deleted object should never been bound again
        https://bugs.webkit.org/show_bug.cgi?id=53604

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::checkObjectToBeBound): Helper function to bind* and useProgram.
        (WebCore::WebGLRenderingContext::bindBuffer): Use checkObjectToBeBound.
        (WebCore::WebGLRenderingContext::bindFramebuffer): Ditto.
        (WebCore::WebGLRenderingContext::bindRenderbuffer): Ditto.
        (WebCore::WebGLRenderingContext::bindTexture): Ditto, also check the target matching.
        (WebCore::WebGLRenderingContext::deleteObject): Helper funtion to delete*.
        (WebCore::WebGLRenderingContext::deleteBuffer): Use deleteObject.
        (WebCore::WebGLRenderingContext::deleteFramebuffer): Ditto.
        (WebCore::WebGLRenderingContext::deleteProgram): Ditto.
        (WebCore::WebGLRenderingContext::deleteRenderbuffer): Ditto.
        (WebCore::WebGLRenderingContext::deleteShader): Ditto.
        (WebCore::WebGLRenderingContext::deleteTexture): Ditto.
        (WebCore::WebGLRenderingContext::useProgram): Use checkObjectToBeBound.
        * html/canvas/WebGLRenderingContext.h:
        * html/canvas/WebGLTexture.h:
        (WebCore::WebGLTexture::getTarget): Accessor to cached target.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Wed, 2 Feb 2011 22:06:17 +0000 (22:06 +0000)]
2011-02-02  Alejandro G. Castro  <alex@igalia.com>

        Unreviewed Efl buildfix after r77399.

        * CMakeListsEfl.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Adam Klein <adamk@chromium.org>
commit-queue@webkit.org [Wed, 2 Feb 2011 21:59:46 +0000 (21:59 +0000)]
2011-02-02  Adam Klein  <adamk@chromium.org>

        Reviewed by Tony Chang.

        Update new-run-webkit-tests --chromium to put output under Source/...
        https://bugs.webkit.org/show_bug.cgi?id=53612

        * BuildSlaveSupport/test-result-archive:
        * Scripts/webkitpy/layout_tests/port/chromium.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Wed, 2 Feb 2011 21:49:53 +0000 (21:49 +0000)]
2011-02-02  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        Update the NEWS file in preparation for the 1.3.11 release.

        * NEWS: Update the NEWS.

2011-02-02  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        Bump the WebKitGTK+ versions in preparation for development release.

        * configure.ac: Bump the library, libtool and user agent version.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 2 Feb 2011 21:49:09 +0000 (21:49 +0000)]
2011-02-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        The drawing area proxy should keep track of the accelerated compositing state
        https://bugs.webkit.org/show_bug.cgi?id=53624

        * UIProcess/DrawingAreaProxyImpl.cpp:
        (WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl):
        Initialize m_isInAcceleratedCompositingMode to false.

        (WebKit::DrawingAreaProxyImpl::paint):
        Don't try to paint if we're in accelerated compositing mode.

        (WebKit::DrawingAreaProxyImpl::didSetSize):
        Bail if we're in accelerated compositing mode.

        (WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
        Set m_isInAcceleratedCompositingMode to true, null out the backing store.

        (WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode):
        Set m_isInAcceleratedCompositingMode back to false.

        (WebKit::DrawingAreaProxyImpl::incorporateUpdate):
        Assert that we're not in accelerated compositing mode.

        * UIProcess/DrawingAreaProxyImpl.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Kenneth Russell <kbr@google.com>
kbr@google.com [Wed, 2 Feb 2011 21:37:00 +0000 (21:37 +0000)]
2011-02-02  Kenneth Russell  <kbr@google.com>

        Reviewed by James Robinson.

        Rename Typed Array subset to subarray
        https://bugs.webkit.org/show_bug.cgi?id=53618

        * fast/canvas/webgl/array-setters.html:
        * fast/canvas/webgl/array-unit-tests-expected.txt:
        * fast/canvas/webgl/array-unit-tests.html:
        * fast/canvas/webgl/draw-elements-out-of-bounds-expected.txt:
        * fast/canvas/webgl/draw-elements-out-of-bounds.html:
        * fast/canvas/webgl/webgl-array-invalid-ranges-expected.txt:
        * fast/canvas/webgl/webgl-array-invalid-ranges.html:
2011-02-02  Kenneth Russell  <kbr@google.com>

        Reviewed by James Robinson.

        Rename Typed Array subset to subarray
        https://bugs.webkit.org/show_bug.cgi?id=53618

        * html/canvas/Float32Array.cpp:
        (WebCore::Float32Array::subarray):
        * html/canvas/Float32Array.h:
        * html/canvas/Float32Array.idl:
        * html/canvas/Int16Array.cpp:
        (WebCore::Int16Array::subarray):
        * html/canvas/Int16Array.h:
        * html/canvas/Int16Array.idl:
        * html/canvas/Int32Array.cpp:
        (WebCore::Int32Array::subarray):
        * html/canvas/Int32Array.h:
        * html/canvas/Int32Array.idl:
        * html/canvas/Int8Array.cpp:
        (WebCore::Int8Array::subarray):
        * html/canvas/Int8Array.h:
        * html/canvas/Int8Array.idl:
        * html/canvas/TypedArrayBase.h:
        (WebCore::TypedArrayBase::subarrayImpl):
        * html/canvas/Uint16Array.cpp:
        (WebCore::Uint16Array::subarray):
        * html/canvas/Uint16Array.h:
        * html/canvas/Uint16Array.idl:
        * html/canvas/Uint32Array.cpp:
        (WebCore::Uint32Array::subarray):
        * html/canvas/Uint32Array.h:
        * html/canvas/Uint32Array.idl:
        * html/canvas/Uint8Array.cpp:
        (WebCore::Uint8Array::subarray):
        * html/canvas/Uint8Array.h:
        * html/canvas/Uint8Array.idl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 2 Feb 2011 21:30:36 +0000 (21:30 +0000)]
2011-02-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add an empty file for Content Security Policy
        https://bugs.webkit.org/show_bug.cgi?id=53573

        Posting this as a separate patch because editing the build files is so
        painful.

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-28 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 2 Feb 2011 21:23:27 +0000 (21:23 +0000)]
2011-01-28  Tony Chang  <tony@chromium.org>

        Reviewed by Eric Seidel.

        [chromium] remove --use-test-shell from NRWT
        https://bugs.webkit.org/show_bug.cgi?id=53346

        I've already started removing some of the bindings like eventSender so
        this already doesn't work isn't useful.  Also updated some comments to
        refer to DRT instead of test_shell.

        * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
        * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
        * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium_win.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/test_types/text_diff.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoGive the Web Process access to the Safari RSS preferences.
timothy@apple.com [Wed, 2 Feb 2011 21:19:59 +0000 (21:19 +0000)]
Give the Web Process access to the Safari RSS preferences.

<rdar://problem/8916870> Sandbox violation related to RSS during initial
page load with WebKit2 (prevents RSS from working)

Reviewed by Darin Adler.

* WebProcess/com.apple.WebProcess.sb:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Dan Winship <danw@gnome.org>
mrobinson@webkit.org [Wed, 2 Feb 2011 21:19:41 +0000 (21:19 +0000)]
2011-02-02  Dan Winship  <danw@gnome.org>

        Reviewed by Martin Robinson.

        [GTK] remove old data: URI handler, fix the SoupRequest-based one
        to pass tests
        https://bugs.webkit.org/show_bug.cgi?id=50885

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::sendRequestCallback): Do content-type sniffing here for
        non-HTTP requests.
        (WebCore::startHTTPRequest): Rename to match WebKit style.
        (WebCore::ResourceHandle::start): Pass everything except HTTP to
        startNonHTTPRequest, letting the SoupRequester decide whether it's
        supported or not.
        (WebCore::startNonHTTPRequest): Remove some old pre-SoupRequester
        code that was a no-op for file: URIs, but would break some data:
        URIs.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 2 Feb 2011 21:18:44 +0000 (21:18 +0000)]
2011-02-02  Dimitri Glazkov  <dglazkov@chromium.org>

        Update even more references to right() and bottom() in Chromium. Sheesh.

        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::getFramebufferPixels): Replaced bottom/right with maxY/maxX.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 2 Feb 2011 21:12:07 +0000 (21:12 +0000)]
2011-02-02  Dimitri Glazkov  <dglazkov@chromium.org>

        Update more references to right() and bottom() in Chromium.

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::doPixelReadbackToCanvas): Replaced bottom/right with maxY/maxX.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Wed, 2 Feb 2011 21:03:39 +0000 (21:03 +0000)]
2011-02-02  Alejandro G. Castro  <alex@igalia.com>

        Unreviewed Gtk3 buildfix after r77286.

        https://bugs.webkit.org/show_bug.cgi?id=53520
        Remove the physical terminology from IntRect and FloatRect.

        * platform/gtk/RenderThemeGtk3.cpp:
        (WebCore::RenderThemeGtk::paintMenuList):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix build.
andersca@apple.com [Wed, 2 Feb 2011 21:01:34 +0000 (21:01 +0000)]
Fix build.

* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::pinnedInDirection):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=53619
hyatt@apple.com [Wed, 2 Feb 2011 20:59:20 +0000 (20:59 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=53619

Reviewed by Dan Bernstein.

Floats should not use physical terminology for their rects. Replace left/top with x/y and right/bottom
with maxX/maxY.  This matches IntRect.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addOverflowFromFloats):
(WebCore::RenderBlock::flipFloatForWritingMode):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::adjustForBorderFit):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::FloatingObject::x):
(WebCore::RenderBlock::FloatingObject::maxX):
(WebCore::RenderBlock::FloatingObject::y):
(WebCore::RenderBlock::FloatingObject::maxY):
(WebCore::RenderBlock::FloatingObject::setX):
(WebCore::RenderBlock::FloatingObject::setY):
(WebCore::RenderBlock::logicalTopForFloat):
(WebCore::RenderBlock::logicalBottomForFloat):
(WebCore::RenderBlock::logicalLeftForFloat):
(WebCore::RenderBlock::logicalRightForFloat):
(WebCore::RenderBlock::setLogicalTopForFloat):
(WebCore::RenderBlock::setLogicalLeftForFloat):
(WebCore::RenderBlock::xPositionForFloatIncludingMargin):
(WebCore::RenderBlock::yPositionForFloatIncludingMargin):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 2 Feb 2011 20:54:03 +0000 (20:54 +0000)]
2011-02-02  Dimitri Glazkov  <dglazkov@chromium.org>

        Update more references to right() and bottom() in Chromium Win.

        * platform/graphics/chromium/TransparencyWin.cpp:
        (WebCore::TransparencyWin::compositeOpaqueComposite): Replaced bottom/right with maxY/maxX.
        (WebCore::TransparencyWin::compositeTextComposite): Ditto.
        * rendering/RenderThemeChromiumWin.cpp:
        (WebCore::RenderThemeChromiumWin::paintMenuList): Ditto.
2011-02-02  Dimitri Glazkov  <dglazkov@chromium.org>

        Update more references to right() and bottom() in Chromium Win.

        * tests/TransparencyWinTest.cpp:
        (WebCore::TEST): Replaced bottom/right with maxY/maxX.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoEncode/decode FormData and FormDataElement objects consistently
aroben@apple.com [Wed, 2 Feb 2011 20:33:51 +0000 (20:33 +0000)]
Encode/decode FormData and FormDataElement objects consistently

Fixes <http://webkit.org/b/53615> <rdar://problem/8943346> WebKit2: Restoring session state
that contains form data fails (asserts in Debug build)

To prevent this from interfering with WebKit2 testing, it's useful to get this into a build
now, even though we don't have an automated test for it yet. Writing a test is covered by
<http://webkit.org/b/53616>.

Reviewed by Darin Adler.

* history/HistoryItem.cpp: Bump the encoding version, since this patch changes how we encode
FormData objects.

* platform/network/FormData.cpp:
(WebCore::decode): Decode the type from the Decoder, rather than getting it from the
default-constructed FormDataElement. Failing to do this meant that all future uses of the
Decoder would be reading from an unexpected part of the buffer (i.e., the next decode would
start by reading the uint32_t that we forgot to decode here, and so on). We already had code
to correctly set the FormDataElement's type based on this decoded type later in the
function.
(WebCore::FormData::encodeForBackForward): Encode m_identifier as an int64_t, since that
matches its type and how we decode it.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Matthew Vosburgh <maf@chromium.org>
kbr@google.com [Wed, 2 Feb 2011 20:25:58 +0000 (20:25 +0000)]
2011-02-02  Matthew Vosburgh  <maf@chromium.org>

        Reviewed by Kenneth Russell.

        Some favicons not correctly decoded by Chromium/Mac
        https://bugs.webkit.org/show_bug.cgi?id=53448

        * src/WebImageCG.cpp:
        (WebKit::WebImage::fromData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Dan Winship <danw@gnome.org>
mrobinson@webkit.org [Wed, 2 Feb 2011 20:24:39 +0000 (20:24 +0000)]
2011-02-02  Dan Winship  <danw@gnome.org>

        Reviewed by Martin Robinson.

        [GTK] drop soup cache stuff, which has been moved to libsoup
        https://bugs.webkit.org/show_bug.cgi?id=50747

        Use libsoup-based cache/requester API and remove the WebCore version
        of this functionality. This has been pushed upstream fully.

        No new tests because this should not change functionality.

        * GNUmakefile.am: Update for removed files.
        * platform/network/ResourceHandleInternal.h:
        (WebCore::ResourceHandleInternal::ResourceHandleInternal): Update
        type names, drop m_requester.
        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::ensureSessionIsInitialized): Add a SoupRequester to the
        session.
        (WebCore::parseDataUrl):
        (WebCore::startHttp): Get the requester from the session rather
        than using m_requester.
        (WebCore::sendRequestCallback):
        (WebCore::ResourceHandle::platformSetDefersLoading):
        (WebCore::readCallback):
        (WebCore::startGio): Update type names.
        * platform/network/soup/cache/soup-directory-input-stream.c: Removed.
        * platform/network/soup/cache/soup-directory-input-stream.h: Removed.
        * platform/network/soup/cache/soup-http-input-stream.c: Removed.
        * platform/network/soup/cache/soup-http-input-stream.h: Removed.
        * platform/network/soup/cache/soup-request-data.c: Removed.
        * platform/network/soup/cache/soup-request-data.h: Removed.
        * platform/network/soup/cache/soup-request-file.c: Removed.
        * platform/network/soup/cache/soup-request-file.h: Removed.
        * platform/network/soup/cache/soup-request-http.c: Removed.
        * platform/network/soup/cache/soup-request-http.h: Removed.
        * platform/network/soup/cache/soup-request.c: Removed.
        * platform/network/soup/cache/soup-request.h: Removed.
        * platform/network/soup/cache/soup-requester.c: Removed.
        * platform/network/soup/cache/soup-requester.h: Removed.
        * platform/network/soup/cache/webkit/soup-cache-private.h: Removed.
        * platform/network/soup/cache/webkit/soup-cache.c: Removed.
        * platform/network/soup/cache/webkit/soup-cache.h: Removed.
2011-02-02  Dan Winship  <danw@gnome.org>

        Reviewed by Martin Robinson.

        [GTK] drop soup cache stuff, which has been moved to libsoup
        https://bugs.webkit.org/show_bug.cgi?id=50747

        * GNUmakefile.am: Remove old cache files.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=53520
hyatt@apple.com [Wed, 2 Feb 2011 20:20:36 +0000 (20:20 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=53520

Reviewed by Darin Adler.

Remove physical accessors from IntRect and FloatRect.

* page/FrameView.cpp:
(WebCore::FrameView::adjustPageHeightDeprecated):
* platform/graphics/FloatRect.h:
* platform/graphics/IntRect.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=53614
hyatt@apple.com [Wed, 2 Feb 2011 20:19:22 +0000 (20:19 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=53614

Reviewed by Dan Bernstein.

Remove physical terminology from overflow.  Replace with minX/maxX/minY/maxY.

* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::addBoxShadowVisualOverflow):
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):
* rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::minYLayoutOverflow):
(WebCore::InlineFlowBox::maxYLayoutOverflow):
(WebCore::InlineFlowBox::minXLayoutOverflow):
(WebCore::InlineFlowBox::maxXLayoutOverflow):
(WebCore::InlineFlowBox::logicalLeftLayoutOverflow):
(WebCore::InlineFlowBox::logicalRightLayoutOverflow):
(WebCore::InlineFlowBox::logicalTopLayoutOverflow):
(WebCore::InlineFlowBox::logicalBottomLayoutOverflow):
(WebCore::InlineFlowBox::minYVisualOverflow):
(WebCore::InlineFlowBox::maxYVisualOverflow):
(WebCore::InlineFlowBox::minXVisualOverflow):
(WebCore::InlineFlowBox::maxXVisualOverflow):
(WebCore::InlineFlowBox::logicalLeftVisualOverflow):
(WebCore::InlineFlowBox::logicalRightVisualOverflow):
(WebCore::InlineFlowBox::logicalminYVisualOverflow):
(WebCore::InlineFlowBox::logicalmaxYVisualOverflow):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustLinePositionForPagination):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::beforeSideVisualOverflowForLine):
(WebCore::RenderBlock::afterSideVisualOverflowForLine):
(WebCore::RenderBlock::beforeSideLayoutOverflowForLine):
(WebCore::RenderBlock::afterSideLayoutOverflowForLine):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::scrollWidth):
(WebCore::RenderBox::scrollHeight):
* rendering/RenderBox.h:
(WebCore::RenderBox::minYLayoutOverflow):
(WebCore::RenderBox::maxYLayoutOverflow):
(WebCore::RenderBox::minXLayoutOverflow):
(WebCore::RenderBox::maxXLayoutOverflow):
(WebCore::RenderBox::logicalLeftLayoutOverflow):
(WebCore::RenderBox::logicalRightLayoutOverflow):
(WebCore::RenderBox::minYVisualOverflow):
(WebCore::RenderBox::maxYVisualOverflow):
(WebCore::RenderBox::minXVisualOverflow):
(WebCore::RenderBox::maxXVisualOverflow):
(WebCore::RenderBox::logicalLeftVisualOverflow):
(WebCore::RenderBox::logicalRightVisualOverflow):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::linesVisualOverflowBoundingBox):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
* rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::anyLineIntersectsRect):
(WebCore::RenderLineBoxList::lineIntersectsDirtyRect):
(WebCore::RenderLineBoxList::paint):
(WebCore::RenderLineBoxList::hitTest):
* rendering/RenderMarquee.cpp:
(WebCore::RenderMarquee::computePosition):
* rendering/RenderOverflow.h:
(WebCore::RenderOverflow::RenderOverflow):
(WebCore::RenderOverflow::minYLayoutOverflow):
(WebCore::RenderOverflow::maxYLayoutOverflow):
(WebCore::RenderOverflow::minXLayoutOverflow):
(WebCore::RenderOverflow::maxXLayoutOverflow):
(WebCore::RenderOverflow::minYVisualOverflow):
(WebCore::RenderOverflow::maxYVisualOverflow):
(WebCore::RenderOverflow::minXVisualOverflow):
(WebCore::RenderOverflow::maxXVisualOverflow):
(WebCore::RenderOverflow::setminYVisualOverflow):
(WebCore::RenderOverflow::visualOverflowRect):
(WebCore::RenderOverflow::move):
(WebCore::RenderOverflow::addVisualOverflow):
(WebCore::RenderOverflow::setVisualOverflow):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::shouldPaint):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::layout):
(WebCore::RenderTable::paint):
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
* rendering/RenderTreeAsText.cpp:
(WebCore::writeLayers):
* rendering/RenderView.cpp:
(WebCore::RenderView::docTop):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 2 Feb 2011 20:07:34 +0000 (20:07 +0000)]
2011-02-02  Dimitri Glazkov  <dglazkov@chromium.org>

        Added GPU fails from bots.

        * platform/chromium-gpu/test_expectations.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 2 Feb 2011 19:58:07 +0000 (19:58 +0000)]
2011-02-02  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Dave Hyatt.

        Remove remaining references to right() and bottom() from Chromium build.
        https://bugs.webkit.org/show_bug.cgi?id=53613

        * src/DragScrollTimer.cpp:
        (WebKit::distanceToRect): Replaced right/bottom with maxX/maxY.
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::doPixelReadbackToCanvas): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Steve Lacey <sjl@chromium.org>
dbates@webkit.org [Wed, 2 Feb 2011 19:56:36 +0000 (19:56 +0000)]
2011-02-02  Steve Lacey  <sjl@chromium.org>

        Reviewed by Eric Carlson.

        Implement basic media statistics on media elements.
        https://bugs.webkit.org/show_bug.cgi?id=53322

        * win/tools/vsprops/FeatureDefines.vsprops:
        * win/tools/vsprops/FeatureDefinesCairo.vsprops:
2011-02-02  Steve Lacey  <sjl@chromium.org>

        Reviewed by Eric Carlson.

        Implement basic media statistics on media elements.
        https://bugs.webkit.org/show_bug.cgi?id=53322

        * configure.ac:
2011-02-02  Steve Lacey  <sjl@chromium.org>

        Reviewed by Eric Carlson.

        Implement basic media statistics on media elements.
        https://bugs.webkit.org/show_bug.cgi?id=53322

        * Scripts/build-webkit:
2011-02-02  Steve Lacey  <sjl@chromium.org>

        Reviewed by Eric Carlson.

        Implement basic media statistics on media elements.
        https://bugs.webkit.org/show_bug.cgi?id=53322

        * Configurations/FeatureDefines.xcconfig:
2011-02-02  Steve Lacey  <sjl@chromium.org>

        Reviewed by Eric Carlson.

        Implement basic media statistics on media elements.
        https://bugs.webkit.org/show_bug.cgi?id=53322

        * Configurations/FeatureDefines.xcconfig:
2011-02-02  Steve Lacey  <sjl@chromium.org>

        Reviewed by Eric Carlson.

        Implement basic media statistics on media elements.
        https://bugs.webkit.org/show_bug.cgi?id=53322

        * Configurations/FeatureDefines.xcconfig:
        * GNUmakefile.am:
        * features.pri:
        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::webkitAudioBytesDecoded):
        (WebCore::HTMLMediaElement::webkitVideoBytesDecoded):
        * html/HTMLMediaElement.h:
        * html/HTMLMediaElement.idl:
        * html/HTMLVideoElement.cpp:
        (WebCore::HTMLVideoElement::webkitDecodedFrames):
        (WebCore::HTMLVideoElement::webkitDroppedFrames):
        * html/HTMLVideoElement.h:
        * html/HTMLVideoElement.idl:
        * platform/graphics/MediaPlayer.cpp:
        (WebCore::MediaPlayer::decodedFrames):
        (WebCore::MediaPlayer::droppedFrames):
        (WebCore::MediaPlayer::audioBytesDecoded):
        (WebCore::MediaPlayer::videoBytesDecoded):
        * platform/graphics/MediaPlayer.h:
        * platform/graphics/MediaPlayerPrivate.h:
        (WebCore::MediaPlayerPrivateInterface::decodedFrames):
        (WebCore::MediaPlayerPrivateInterface::droppedFrames):
        (WebCore::MediaPlayerPrivateInterface::audioBytesDecoded):
        (WebCore::MediaPlayerPrivateInterface::videoBytesDecoded):
2011-02-02  Steve Lacey  <sjl@chromium.org>

        Reviewed by Eric Carlson.

        Implement basic media statistics on media elements.
        https://bugs.webkit.org/show_bug.cgi?id=53322

        * Configurations/FeatureDefines.xcconfig:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Luiz Agostini <luiz.agostini@openbossa.org>
luiz@webkit.org [Wed, 2 Feb 2011 19:40:44 +0000 (19:40 +0000)]
2011-02-02  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by David Hyatt.

        More conversion from right()/bottom() to maxX()/maxY().

        * page/qt/FrameQt.cpp:
        (WebCore::Frame::dragImageForSelection):
        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::roundToDevicePixels):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[wx] Build fixes for wxWebKit.
kevino@webkit.org [Wed, 2 Feb 2011 19:34:38 +0000 (19:34 +0000)]
[wx] Build fixes for wxWebKit.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-01 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Wed, 2 Feb 2011 19:21:17 +0000 (19:21 +0000)]
2011-02-01  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        A little more Heap refactoring
        https://bugs.webkit.org/show_bug.cgi?id=53577

        SunSpider reports no change.

        Split out MarkedBlock into its own file / class.

        Did the following renames:
            isCellMarked => isMarked
            checkMarkCell => testAndSetMarked
            markCell => setMarked
            cellOffset => cellNumber
            collectorBlock => blockFor

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * JavaScriptCore.gypi:
        * JavaScriptCore.pro:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * runtime/Heap.cpp:
        (JSC::WeakGCHandlePool::update):
        * runtime/Heap.h:
        (JSC::Heap::isMarked):
        (JSC::Heap::testAndSetMarked):
        (JSC::Heap::setMarked):
        * runtime/JSArray.h:
        (JSC::MarkStack::markChildren):
        (JSC::MarkStack::drain):
        * runtime/JSCell.h:
        (JSC::JSCell::MarkStack::internalAppend):
        * runtime/MarkedBlock.cpp: Added.
        * runtime/MarkedBlock.h: Added.
        (JSC::MarkedBlock::blockFor):
        (JSC::MarkedBlock::cellNumber):
        (JSC::MarkedBlock::isMarked):
        (JSC::MarkedBlock::testAndSetMarked):
        (JSC::MarkedBlock::setMarked):
        (JSC::MarkedBlock::isCellAligned):
        (JSC::MarkedBlock::isPossibleCell):
        * runtime/MarkedSpace.h:
        (JSC::MarkedSpace::isMarked):
        (JSC::MarkedSpace::testAndSetMarked):
        (JSC::MarkedSpace::setMarked):
        * runtime/SmallStrings.cpp:
        (JSC::isMarked):
        * runtime/WeakGCMap.h:
        (JSC::WeakGCMap::isValid):
        (JSC::::get):
        (JSC::::take):
        (JSC::::set):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMore right()/bottom() to maxX()/maxY() conversion.
hyatt@apple.com [Wed, 2 Feb 2011 19:13:09 +0000 (19:13 +0000)]
More right()/bottom() to maxX()/maxY() conversion.

Reviewed by Darin Adler.

* page/chromium/FrameChromium.cpp:
(WebCore::Frame::nodeImage):
(WebCore::Frame::dragImageForSelection):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix windows clean build.
weinig@apple.com [Wed, 2 Feb 2011 19:00:32 +0000 (19:00 +0000)]
Fix windows clean build.

../JavaScriptCore:

* DerivedSources.make:

../WebCore:

* DerivedSources.make:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 2 Feb 2011 18:56:05 +0000 (18:56 +0000)]
2011-02-02  Martin Robinson  <mrobinson@igalia.com>

        Unskip a test that just needs platform-specific results. Re-classify
        two other failures with more pertinent information.

        * platform/gtk/Skipped: Organize the skipped list a bit. Unskip a test.
        Remove obsolete comments.
        * platform/gtk/editing/inserting/5994480-2-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Wed, 2 Feb 2011 18:55:35 +0000 (18:55 +0000)]
2011-02-02  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Landing detailed heap snapshots, part 2.

        https://bugs.webkit.org/show_bug.cgi?id=53606

        Display progress while taking a snapshot, and hints while loading
        and parsing. This is needed because taking detailed heap snapshots
        takes time.

        * English.lproj/localizedStrings.js:
        * inspector/front-end/DetailedHeapshotView.js:
        (WebInspector.DetailedHeapshotProfileType.prototype.buttonClicked):
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype._reset):
        (WebInspector.ProfilesPanel.prototype._addProfileHeader):
        (WebInspector.ProfilesPanel.prototype.getProfiles):
        (WebInspector.ProfilesPanel.prototype.loadHeapSnapshot):
        (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.doParse):
        (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
        (WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):
        (WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):
        * inspector/front-end/SidebarTreeElement.js:
        (WebInspector.SidebarTreeElement.prototype.refreshTitles):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Sam Weinig.
ap@apple.com [Wed, 2 Feb 2011 18:51:57 +0000 (18:51 +0000)]
    Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=53561
        <rdar://problem/8900228> Stepping through print previews in WebKit2 mode steps in and out of
        printing mode a lot

        Disable NSView autodisplay, so that -[WKView drawRect:] isn't called (other than when
        resizing the window), so that we don't have to switch modes all the time.

        * UIProcess/API/mac/PageClientImpl.h:
        * UIProcess/API/mac/PageClientImpl.mm:
        (WebKit::PageClientImpl::setAutodisplay):
        * UIProcess/PageClient.h:
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::setAutodisplay):
        * UIProcess/WebPageProxy.h:
        Pipe the call from WKPrintingView down to WKView.

        * UIProcess/API/mac/WKPrintingView.mm:
        (-[WKPrintingView beginDocument]): Added. We don't want to autodisplay WKView while printing,
        because layout is changed to print at the time, and drawing to screen requires relayout.

        (-[WKPrintingView endDocument]): When not printing, turn autodisplay back on. Also, call
        -[super endDocument] for unknown but definitive good (oops!).

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMore conversion from right()/bottom() to maxX()/maxY().
hyatt@apple.com [Wed, 2 Feb 2011 18:35:41 +0000 (18:35 +0000)]
More conversion from right()/bottom() to maxX()/maxY().

Reviewed by Darin Adler.

* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::calculatePositionAndSize):
(WebCore::PopupMenuWin::paint):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemoval of right()/bottom(). Replace with maxX() and maxY(). Still converting....
hyatt@apple.com [Wed, 2 Feb 2011 18:32:56 +0000 (18:32 +0000)]
Removal of right()/bottom().  Replace with maxX() and maxY().  Still converting.  Haven't removed yet.

Reviewed by Darin Adler.

* platform/chromium/PopupMenuChromium.cpp:
(WebCore::PopupContainer::layoutAndCalculateWidgetRect):
(WebCore::PopupListBox::scrollToRevealRow):
(WebCore::PopupListBox::layout):
* platform/graphics/FloatRect.h:
* platform/graphics/IntRect.h:
* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::getImageData):
(WebCore::putImageData):
* platform/graphics/chromium/GLES2Canvas.cpp:
(WebCore::GLES2Canvas::drawTexturedRect):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::verticalScrollbarRect):
(WebCore::LayerRendererChromium::horizontalScrollbarRect):
(WebCore::LayerRendererChromium::setScissorToRect):
(WebCore::LayerRendererChromium::setDrawViewportRect):
* platform/graphics/chromium/LayerTilerChromium.cpp:
(WebCore::LayerTilerChromium::contentRectToTileIndices):
(WebCore::LayerTilerChromium::growLayerToContain):
* platform/graphics/gpu/TilingData.cpp:
(WebCore::TilingData::tileBoundsWithBorder):
(WebCore::TilingData::overlappedTileIndices):
* platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::getImageData):
(WebCore::putImageData):
* platform/graphics/skia/FloatRectSkia.cpp:
(WebCore::FloatRect::operator SkRect):
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::getImageData):
(WebCore::putImageData):
* platform/graphics/skia/IntRectSkia.cpp:
(WebCore::IntRect::operator SkIRect):
(WebCore::IntRect::operator SkRect):
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::beginLayerClippedToImage):
* platform/graphics/win/GraphicsContextWin.cpp:
(WebCore::GraphicsContextPlatformPrivate::clip):
* platform/graphics/win/IntRectWin.cpp:
(WebCore::IntRect::operator RECT):
* platform/graphics/win/UniscribeController.cpp:
(WebCore::UniscribeController::shapeAndPlaceItem):
* platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::roundRect):
(WebCore::mapRect):
(WebCore::TransparentLayerDC::TransparentLayerDC):
(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::drawEllipse):
(WebCore::GraphicsContext::strokeArc):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::strokeRect):
* platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::initFrameBuffer):
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::calculatePositionAndSize):
(WebCore::PopupMenuWin::paint):
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::invalidateRect):
* rendering/RenderThemeSafari.cpp:
(WebCore::RenderThemeSafari::paintMenuListButtonGradients):
(WebCore::RenderThemeSafari::paintMenuListButton):
(WebCore::RenderThemeSafari::paintSliderTrack):
* rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::paintInnerSpinButton):
(WebCore::RenderThemeWin::paintMenuListButton):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-01 Darin Fisher <darin@chromium.org>
darin@chromium.org [Wed, 2 Feb 2011 18:30:59 +0000 (18:30 +0000)]
2011-02-01  Darin Fisher  <darin@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Avoid #ifdefs in code that constructs a GraphicsContext by
        adding a helper class.
        https://bugs.webkit.org/show_bug.cgi?id=53575

        * WebKit.gyp:
        * src/WebFontImpl.cpp:
        (WebKit::WebFontImpl::drawText):
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::printPage):
        (WebKit::WebFrameImpl::paint):
        * src/WebPopupMenuImpl.cpp:
        (WebKit::WebPopupMenuImpl::paint):
        * src/WebScrollbarImpl.cpp:
        (WebKit::WebScrollbarImpl::paint):
        * src/painting: Added.
        * src/painting/GraphicsContextBuilder.h: Added.
        (WebKit::GraphicsContextBuilder::GraphicsContextBuilder):
        (WebKit::GraphicsContextBuilder::context):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemoval of right()/bottom(), converting to maxX()/maxY().
hyatt@apple.com [Wed, 2 Feb 2011 18:30:27 +0000 (18:30 +0000)]
Removal of right()/bottom(), converting to maxX()/maxY().

Reviewed by Darin Adler.

../WebKit/gtk:

* webkit/webkitwebview.cpp:
(webkit_web_view_popup_menu_handler):

../WebKit/win:

* DOMHTMLClasses.cpp:
(DOMHTMLInputElement::rectOnScreen):
* WebCoreSupport/EmbeddedWidget.cpp:
(EmbeddedWidget::frameRectsChanged):
* WebFrame.cpp:
(WebFrame::computePageRects):
* WebScrollBar.cpp:
(WebScrollBar::frameRect):
* WebView.cpp:
(WebView::addToDirtyRegion):
(WebView::visibleContentRect):
(WebView::prepareCandidateWindow):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoConversion of right()/bottom() to maxX()/maxY() as part of the removal of those acces...
hyatt@apple.com [Wed, 2 Feb 2011 18:29:28 +0000 (18:29 +0000)]
Conversion of right()/bottom() to maxX()/maxY() as part of the removal of those accessors.

Reviewed by Darin Adler.

* UIProcess/win/WebPopupMenuProxyWin.cpp:
(WebKit::WebPopupMenuProxyWin::calculatePositionAndSize):
* UIProcess/win/WebView.cpp:
(WebKit::WebView::prepareCandidateWindow):
* WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::NetscapePlugin::platformGeometryDidChange):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Wed, 2 Feb 2011 18:06:27 +0000 (18:06 +0000)]
2011-02-02  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] po files path update after the code moved to Source
        https://bugs.webkit.org/show_bug.cgi?id=53599

        * POTFILES: Add Source to the path of the files.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-01 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Wed, 2 Feb 2011 18:05:28 +0000 (18:05 +0000)]
2011-02-01  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: add test for OPTIONS requests caused by CORS preflight checking to appear in Network panel
        https://bugs.webkit.org/show_bug.cgi?id=53501

        * http/tests/inspector/network-preflight-options-expected.txt: Added.
        * http/tests/inspector/network-preflight-options.html: Added.
        * http/tests/inspector/resources/cors-target.php: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-01 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 2 Feb 2011 17:59:24 +0000 (17:59 +0000)]
2011-02-01  Darin Adler  <darin@apple.com>

        Reviewed by Anders Carlsson.

        Overflow in WebKit2 argument decoder buffer checking
        https://bugs.webkit.org/show_bug.cgi?id=53536

        * Platform/CoreIPC/ArgumentDecoder.cpp:
        (CoreIPC::roundUpToAlignment): Tweak code a bit for clarity and to replace
        C casts with C++ casts.
        (CoreIPC::ArgumentDecoder::alignBufferPosition): Rearrange buffer calculation
        so we don't do any math with the passed-in size, because that could overflow.
        (CoreIPC::ArgumentDecoder::bufferIsLargeEnoughToContain): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 2 Feb 2011 17:00:06 +0000 (17:00 +0000)]
2011-02-02  Martin Robinson  <mrobinson@igalia.com>

        Skip another test that uses modal dialogs.

        * platform/gtk/Skipped: Skip modal dialog test and update bug in the skipped list.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUse Vector instead of a linked list for rules in CSSStyleSelector
antti@apple.com [Wed, 2 Feb 2011 15:00:55 +0000 (15:00 +0000)]
Use Vector instead of a linked list for rules in CSSStyleSelector
https://bugs.webkit.org/show_bug.cgi?id=53581

Reviewed by Maciej Stachowiak.

- eliminate CSSRuleDataList, replace with Vector<RuleData>
- rename CSSRuleData -> RuleData and CSSRuleSet -> RuleSet
  (these are selector internal classes, CSS prefix is better reserved for public ones).
- constify a bit
- shrink the vectors to fit after collecting the rules

* css/CSSStyleSelector.cpp:
(WebCore::RuleData::RuleData):
(WebCore::RuleData::position):
(WebCore::RuleData::rule):
(WebCore::RuleData::selector):
(WebCore::RuleSet::disableAutoShrinkToFit):
(WebCore::RuleSet::getIDRules):
(WebCore::RuleSet::getClassRules):
(WebCore::RuleSet::getTagRules):
(WebCore::RuleSet::getPseudoRules):
(WebCore::RuleSet::getUniversalRules):
(WebCore::RuleSet::getPageRules):
(WebCore::collectSiblingRulesInDefaultStyle):
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::loadFullDefaultStyle):
(WebCore::loadSimpleDefaultStyle):
(WebCore::loadViewSourceStyle):
(WebCore::CSSStyleSelector::matchRules):
(WebCore::CSSStyleSelector::matchRulesForList):
(WebCore::operator >):
(WebCore::operator <=):
(WebCore::CSSStyleSelector::sortMatchedRules):
(WebCore::CSSStyleSelector::matchUARules):
(WebCore::RuleSet::RuleSet):
(WebCore::RuleSet::~RuleSet):
(WebCore::RuleSet::addToRuleSet):
(WebCore::RuleSet::addRule):
(WebCore::RuleSet::addPageRule):
(WebCore::RuleSet::addRulesFromSheet):
(WebCore::RuleSet::addStyleRule):
(WebCore::collectIdsAndSiblingRulesFromList):
(WebCore::RuleSet::collectIdsAndSiblingRules):
(WebCore::shrinkMapVectorsToFit):
(WebCore::RuleSet::shrinkToFit):
(WebCore::CSSStyleSelector::matchPageRules):
(WebCore::CSSStyleSelector::matchPageRulesForList):
* css/CSSStyleSelector.h:
(WebCore::CSSStyleSelector::addMatchedRule):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Andrey Adaikin <aandrey@google.com>
podivilov@chromium.org [Wed, 2 Feb 2011 14:08:21 +0000 (14:08 +0000)]
2011-02-02  Andrey Adaikin  <aandrey@google.com>

        Reviewed by Pavel Feldman.

        Web Inspector: Use DIVs instead of TABLE in TextViewer
        https://bugs.webkit.org/show_bug.cgi?id=53299

        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._createTextViewer):
        (WebInspector.SourceFrame.prototype._mouseDown):
        * inspector/front-end/TextViewer.js:
        (WebInspector.TextViewer):
        (WebInspector.TextViewer.prototype.set mimeType):
        (WebInspector.TextViewer.prototype.revealLine):
        (WebInspector.TextViewer.prototype.addDecoration):
        (WebInspector.TextViewer.prototype.removeDecoration):
        (WebInspector.TextViewer.prototype.markAndRevealRange):
        (WebInspector.TextViewer.prototype.highlightLine):
        (WebInspector.TextViewer.prototype.clearLineHighlight):
        (WebInspector.TextViewer.prototype.freeCachedElements):
        (WebInspector.TextViewer.prototype._handleKeyDown):
        (WebInspector.TextViewer.prototype.editLine.finishEditing):
        (WebInspector.TextViewer.prototype.editLine):
        (WebInspector.TextViewer.prototype.beginUpdates):
        (WebInspector.TextViewer.prototype.endUpdates):
        (WebInspector.TextViewer.prototype.resize):
        (WebInspector.TextViewer.prototype._textChanged):
        (WebInspector.TextViewer.prototype._updatePanelOffsets):
        (WebInspector.TextViewer.prototype._syncScroll):
        (WebInspector.TextViewer.prototype._syncDecorationsForLine):
        (WebInspector.TextEditorChunkedPanel):
        (WebInspector.TextEditorChunkedPanel.prototype.set syncScrollListener):
        (WebInspector.TextEditorChunkedPanel.prototype.get textModel):
        (WebInspector.TextEditorChunkedPanel.prototype.addDecoration):
        (WebInspector.TextEditorChunkedPanel.prototype.removeDecoration):
        (WebInspector.TextEditorChunkedPanel.prototype.revealLine):
        (WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk):
        (WebInspector.TextEditorChunkedPanel.prototype.textChanged):
        (WebInspector.TextEditorChunkedPanel.prototype.beginUpdates):
        (WebInspector.TextEditorChunkedPanel.prototype.endUpdates):
        (WebInspector.TextEditorChunkedPanel.prototype.resize):
        (WebInspector.TextEditorChunkedPanel.prototype._scroll):
        (WebInspector.TextEditorChunkedPanel.prototype._scheduleRepaintAll):
        (WebInspector.TextEditorChunkedPanel.prototype._buildChunks):
        (WebInspector.TextEditorChunkedPanel.prototype._repaintAll):
        (WebInspector.TextEditorChunkedPanel.prototype._chunkNumberForLine):
        (WebInspector.TextEditorChunkedPanel.prototype._chunkForLine):
        (WebInspector.TextEditorGutterPanel):
        (WebInspector.TextEditorGutterPanel.prototype.freeCachedElements):
        (WebInspector.TextEditorGutterPanel.prototype._createNewChunk):
        (WebInspector.TextEditorGutterPanel.prototype._expandChunks):
        (WebInspector.TextEditorGutterChunk):
        (WebInspector.TextEditorGutterChunk.prototype.get expanded):
        (WebInspector.TextEditorGutterChunk.prototype.set expanded):
        (WebInspector.TextEditorGutterChunk.prototype.get height):
        (WebInspector.TextEditorGutterChunk.prototype._createRow):
        (WebInspector.TextEditorMainPanel):
        (WebInspector.TextEditorMainPanel.prototype.set syncDecorationsForLine):
        (WebInspector.TextEditorMainPanel.prototype.set mimeType):
        (WebInspector.TextEditorMainPanel.prototype.markAndRevealRange):
        (WebInspector.TextEditorMainPanel.prototype.highlightLine):
        (WebInspector.TextEditorMainPanel.prototype.clearLineHighlight):
        (WebInspector.TextEditorMainPanel.prototype.freeCachedElements):
        (WebInspector.TextEditorMainPanel.prototype._buildChunks):
        (WebInspector.TextEditorMainPanel.prototype._createNewChunk):
        (WebInspector.TextEditorMainPanel.prototype._expandChunks):
        (WebInspector.TextEditorMainPanel.prototype._highlightDataReady):
        (WebInspector.TextEditorMainPanel.prototype._paintLines):
        (WebInspector.TextEditorMainPanel.prototype._paintLine):
        (WebInspector.TextEditorMainPanel.prototype._releaseLinesHighlight):
        (WebInspector.TextEditorMainPanel.prototype._getSelection):
        (WebInspector.TextEditorMainPanel.prototype._restoreSelection):
        (WebInspector.TextEditorMainPanel.prototype._selectionToPosition):
        (WebInspector.TextEditorMainPanel.prototype._positionToSelection):
        (WebInspector.TextEditorMainPanel.prototype._appendTextNode):
        (WebInspector.TextEditorMainPanel.prototype._handleDomUpdates):
        (WebInspector.TextEditorMainChunk):
        (WebInspector.TextEditorMainChunk.prototype.addDecoration):
        (WebInspector.TextEditorMainChunk.prototype.set expanded):
        (WebInspector.TextEditorMainChunk.prototype.get height):
        (WebInspector.TextEditorMainChunk.prototype.getExpandedLineRow):
        (WebInspector.TextEditorMainChunk.prototype._createRow):
        (WebInspector):
        * inspector/front-end/textViewer.css:
        (.text-editor-lines):
        (.text-editor-contents):
        (.text-editor-editable):
        (.webkit-line-decorations):
        (.webkit-line-number):
        (.webkit-execution-line.webkit-line-content):
        (.diff-container .webkit-added-line.webkit-line-content):
        (.diff-container .webkit-removed-line.webkit-line-content):
        (.diff-container .webkit-changed-line.webkit-line-content):
        (.webkit-highlighted-line.webkit-line-content):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Wed, 2 Feb 2011 13:55:01 +0000 (13:55 +0000)]
2011-02-02  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Removed some custom Chromium test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Hans Wennborg <hans@chromium.org>
hans@chromium.org [Wed, 2 Feb 2011 10:10:54 +0000 (10:10 +0000)]
2011-02-02  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        IndexedDB: Implement support for cursor updates
        https://bugs.webkit.org/show_bug.cgi?id=53421

        Layout test for cursor updates.

        * storage/indexeddb/cursor-update-expected.txt: Added.
        * storage/indexeddb/cursor-update.html: Added.
2011-02-02  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        IndexedDB: Implement support for cursor updates
        https://bugs.webkit.org/show_bug.cgi?id=53421

        Implement support for cursor updates using the same pattern as cursor
        deletes: forward the calls to the IDBObjectStoreBackend::put().
        The put() function's signature needs to be changed to allow for a
        "cursor update mode". This makes the signature more clear anyway,
        since it replaces the boolean parameter.

        Test: storage/indexeddb/cursor-update.html

        * storage/IDBCursor.idl:
        * storage/IDBCursorBackendImpl.cpp:
        (WebCore::IDBCursorBackendImpl::key):
        (WebCore::IDBCursorBackendImpl::update):
        * storage/IDBCursorBackendImpl.h:
        * storage/IDBObjectStore.cpp:
        (WebCore::IDBObjectStore::add):
        (WebCore::IDBObjectStore::put):
        * storage/IDBObjectStoreBackendImpl.cpp:
        (WebCore::IDBObjectStoreBackendImpl::put):
        (WebCore::IDBObjectStoreBackendImpl::putInternal):
        * storage/IDBObjectStoreBackendImpl.h:
        * storage/IDBObjectStoreBackendInterface.h:
2011-02-02  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        IndexedDB: Implement support for cursor updates
        https://bugs.webkit.org/show_bug.cgi?id=53421

        Mirror the update to the IDBObjectStoreInterface::put() signature in
        the WebKit layer wrappers.

        * public/WebIDBObjectStore.h:
        (WebKit::WebIDBObjectStore::put):
        * src/IDBObjectStoreProxy.cpp:
        (WebCore::IDBObjectStoreProxy::put):
        * src/IDBObjectStoreProxy.h:
        * src/WebIDBObjectStoreImpl.cpp:
        (WebKit::WebIDBObjectStoreImpl::put):
        * src/WebIDBObjectStoreImpl.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Naoki Takano <takano.naoki@gmail.com>
commit-queue@webkit.org [Wed, 2 Feb 2011 08:50:41 +0000 (08:50 +0000)]
2011-02-02  Naoki Takano  <takano.naoki@gmail.com>

        Reviewed by Kent Tamura.

        Fix popup menu RTL bug introduced by Changeset 75982.
        https://bugs.webkit.org/show_bug.cgi?id=53567

        PopupMenuChromium::layout() calculates X position according to RTL or not. So Change the X position calculation in layoutAndCalculateWidgetRect().

        No new tests. However we can check manually with select_dropdown_box_alignment.html, autofill_alignment.html, select_alignment.html, select_dropdown_box_alignment.html, autofill-popup-width-and-item-direction.html

        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupContainer::layoutAndCalculateWidgetRect): Fix calculation of x position, because layout() considers RTL. And change the parameter from both X and Y positions to only Y position.
        (WebCore::PopupContainer::showPopup): Change the passing parameter.
        (WebCore::PopupContainer::refresh): Change the passing parameter.
        * platform/chromium/PopupMenuChromium.h: Change the parameter declaration.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Wed, 2 Feb 2011 08:49:32 +0000 (08:49 +0000)]
2011-02-02  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Fix dist compilation
        https://bugs.webkit.org/show_bug.cgi?id=53579

        * GNUmakefile.am: Added WriteBarrier.h to the sources, it was
        added in r77151

2011-02-02  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Fix dist compilation
        https://bugs.webkit.org/show_bug.cgi?id=53579

        * GNUmakefile.am: Added FontWidthVariant.h to the sources, it was
        added in r77153.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77369 268f45cc-cd09-0410-ab3c-d52691b4dbfc