mjs@apple.com [Sun, 10 Apr 2011 21:26:48 +0000 (21:26 +0000)]
Not reviewed.
Fix build (at least on Lion) by adding some newish header files to
PrivateHeaders.
* JavaScriptCore.xcodeproj/project.pbxproj:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83404
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Sun, 10 Apr 2011 21:00:17 +0000 (21:00 +0000)]
2011-04-10 Patrick Gansterer <paroga@webkit.org>
Unreviewed build fix for !ENABLE(XSLT) after r82562.
* xml/XMLTreeViewer.cpp: Readded #if ENABLE(XSLT).
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83403
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Sun, 10 Apr 2011 18:06:57 +0000 (18:06 +0000)]
WebKitTestRunner needs a more-complete implementation of eventSender
https://bugs.webkit.org/show_bug.cgi?id=42194
Add another test that depends on eventSender.keyDown (fast/dom/hidden-iframe-no-focus.html
added in r83356) to the mac-wk2 skipped list to get the bots green.
* platform/mac-wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83402
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Sun, 10 Apr 2011 17:37:48 +0000 (17:37 +0000)]
[wx] Unreviewed build fix. Add Source/JavaScriptCore/heap to the list of directories.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83401
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Sun, 10 Apr 2011 17:35:54 +0000 (17:35 +0000)]
2011-04-10 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Anders Carlsson.
REGRESSION(r83256): Text-decoration bleeds into shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=58205
* platform/chromium/test_expectations.txt: Removed the test that starts
passing after this change.
2011-04-10 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Anders Carlsson.
REGRESSION(r83256): Text-decoration bleeds into shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=58205
Now that the shadow root is a never-styled element, we need to walk to
parent to find out if we're inside of a shadow DOM subtree.
Test: media/controls-styling.html
* css/CSSStyleSelector.cpp:
(WebCore::isAtShadowBoundary): Added helper function.
(WebCore::CSSStyleSelector::adjustRenderStyle): Changed to use the helper.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83400
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Sun, 10 Apr 2011 16:45:17 +0000 (16:45 +0000)]
2011-04-10 Dimitri Glazkov <dglazkov@chromium.org>
Temporarily add a failing test, while I am fixing it.
* platform/chromium/test_expectations.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83399
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Sun, 10 Apr 2011 16:00:51 +0000 (16:00 +0000)]
REGRESSION(r83384): Change to chromium.py is resulting in failures of the test framework on linux.
https://bugs.webkit.org/show_bug.cgi?id=58201
Reviewed by Dimitri Glazkov.
* Scripts/webkitpy/layout_tests/port/chromium.py: Commented out the assert for now,
and filed bug 58202.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83398
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Sun, 10 Apr 2011 14:57:13 +0000 (14:57 +0000)]
2011-04-07 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Eric Carlson.
[Meta] Convert HTMLMediaElement to use the new shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=53020
This conversion is non-trivial, for several reasons:
1) Since HTMLMediaElement now hosts the shadow DOM for controls, hiding
and showing controls does not result in destroying and re-creating the
shadow DOM tree. Instead, the tree is created as needed and shown/hidden
using inline styles.
2) Instead of detaching/attaching on each style change, the control parts
are now using a set of higher fidelity callbacks that notify MediaControls
about changes to which it should react. Each reaction results in hiding,
showing, or changing the state of the control parts using inline styles
and DOM APIs.
3) Hiding and showing controls is accomplished using inline styles, rather
than wiring rendererIsNeeded, because renderers are now re-created less
frequently.
4) Instead of constantly querying RenderTheme about visibility of a particular
control part, we let the theme determine which parts are supported and
which parts are visible in certain conditions.
5) Custom hit-testing, event forwarding, and style updates are completely
removed, since they are now unnecessary.
6) Fading controls in/out is now done as CSS animation, since shadow DOM
supports it.
Test: manual-tests/media-controls.html
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83397
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sun, 10 Apr 2011 06:29:26 +0000 (06:29 +0000)]
<rdar://problem/
9215280> Detached canvas draws with incorrect font
Reviewed by Beth Dakin.
Source/WebCore:
Test: fast/canvas/font-update.html
The existing mechanism for updating the font in a canvas 2D context was lacking in at least
two ways: it neglected to update fonts in all but the topmost state in the stack, and since it
was based on HTMLCanvasElemen's attach() and recalcStyle(), it did not work when the element
was not attached.
This change takes the responsibility for font updates away from the canvas element and gives it
to the canvas context and its graphics state.
* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::registerForInvalidationCallbacks): Added. Adds to the set of registered
font selector clients.
(WebCore::CSSFontSelector::unregisterForInvalidationCallbacks): Added. Removes from the set of
registered font selector clients.
(WebCore::CSSFontSelector::dispatchInvalidationCallbacks): Calls fontsNeedUpdate() on all registered
clients and forces a style recalc on the document.
(WebCore::CSSFontSelector::fontLoaded): Changed to call dispatchInvalidationCallbacks().
(WebCore::CSSFontSelector::fontCacheInvalidated): Ditto.
* css/CSSFontSelector.h:
* html/HTMLCanvasElement.cpp: Removed overrides of attach() and recalcStyle().
* html/HTMLCanvasElement.h:
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::State::~State): Added. Unregisters with the font selector.
(WebCore::CanvasRenderingContext2D::State::fontsNeedUpdate): Added. Called by the font selector
when its fonts need to be updated. Updates the font.
(WebCore::CanvasRenderingContext2D::setFont): Registers the state with the font selector.
* html/canvas/CanvasRenderingContext2D.h:
* platform/graphics/FontSelector.h:
(WebCore::FontSelectorClient::~FontSelectorClient):
LayoutTests:
* fast/canvas/font-update-expected.checksum: Added.
* fast/canvas/font-update-expected.png: Added.
* fast/canvas/font-update-expected.txt: Added.
* fast/canvas/font-update.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83396
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Sun, 10 Apr 2011 06:17:24 +0000 (06:17 +0000)]
2011-04-09 David Levin <levin@chromium.org>
Unreviewed, rolling out r83394.
http://trac.webkit.org/changeset/83394
https://bugs.webkit.org/show_bug.cgi?id=53625
Patch was incorrect as noted in the bug.
* Scripts/svn-apply:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83395
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Sun, 10 Apr 2011 05:57:58 +0000 (05:57 +0000)]
svn-apply and/or patch(1) has trouble applying patches that makes changes to files with Windows line endings
https://bugs.webkit.org/show_bug.cgi?id=53625
Reviewed by Adam Barth.
* Scripts/svn-apply: Ensure that the portions of patches
which are for vcproj/vsprops files has DOS line endings.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83394
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Sun, 10 Apr 2011 04:18:15 +0000 (04:18 +0000)]
2011-04-09 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change.
https://bugs.webkit.org/show_bug.cgi?id=58193
Suppress a whole bunch of Win Vista failures until they can be
triaged and/or rebaselined.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83393
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Sun, 10 Apr 2011 03:55:42 +0000 (03:55 +0000)]
Not reviewed.
Try recommitting some things svn left out of my last commit.
* bridge/qt/qt_runtime.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83392
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Sun, 10 Apr 2011 03:53:45 +0000 (03:53 +0000)]
Not reviewed.
Try recommitting some things svn left out of my last commit.
* WebProcess/Plugins/Netscape/NPJSObject.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83391
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Sun, 10 Apr 2011 03:50:32 +0000 (03:50 +0000)]
Not reviewed.
Try recommitting some things svn left out of my last commit.
* WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::evaluate):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83390
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Sun, 10 Apr 2011 03:47:56 +0000 (03:47 +0000)]
Not reviewed.
Try recommitting some things svn left out of my last commit.
* ForwardingHeaders/collector: Removed.
* ForwardingHeaders/collector/handles: Removed.
* ForwardingHeaders/collector/handles/Global.h: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83389
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Sun, 10 Apr 2011 03:41:08 +0000 (03:41 +0000)]
Not reviewed.
Try recommitting some things svn left out of its last commit.
* heap/Handle.h:
(JSC::HandleBase::operator!):
(JSC::HandleBase::HandleBase):
(JSC::HandleBase::slot):
(JSC::HandleBase::setSlot):
(JSC::Handle::Handle):
* heap/HandleHeap.cpp:
(JSC::HandleHeap::markWeakHandles):
(JSC::HandleHeap::finalizeWeakHandles):
(JSC::HandleHeap::isValidWeakNode):
* heap/HandleHeap.h:
(JSC::HandleHeap::globalData):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83388
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Sun, 10 Apr 2011 03:01:30 +0000 (03:01 +0000)]
2011-04-09 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change.
https://bugs.webkit.org/show_bug.cgi?id=58193
Suppress a whole bunch of Win 7 failures until they can be
triaged and/or rebaselined.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83387
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Sun, 10 Apr 2011 02:33:19 +0000 (02:33 +0000)]
2011-04-02 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Ojan Vafai.
Implement proper handling of mouseover/mouseout events in regard to shadow DOM boundaries.
https://bugs.webkit.org/show_bug.cgi?id=55515
* fast/events/shadow-boundary-crossing-expected.txt: Updated expectations.
* fast/events/shadow-boundary-crossing.html: Added new test for mouseover/mouseout handling.
2011-04-08 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Ojan Vafai.
Implement proper handling of mouseover/mouseout events in regard to shadow DOM boundaries.
https://bugs.webkit.org/show_bug.cgi?id=55515
This implements XBL 2.0's specified handling of mouseover/mouseout events:
http://dev.w3.org/2006/xbl2/Overview.html#the-mouseover-and-mouseout-events
To do this, we:
1) calculate lowest common ancestor between relatedTarget and target, and
the nearest boundaries around them: the outer (common) boundary, and the
inner (specific to relatedTarget) boundary. Then, we
2) ensure that events only propagate up to the common boundary (or
all the way if boundary is not found), while
3) updating relatedTarget be the inner boundary.
We also detect the most common case when no common boundary could exist
and provide a fast path to short-circuit most of the boundary detection
logic.
Test: fast/events/shadow-boundary-crossing.html
* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::adjustToShadowBoundaries): Added a helper to determine lowest
common ancestor, the boundaries around it, and compute adjustments
to relatedTarget and event target ancestor chain.
(WebCore::ancestorsCrossShadowBoundaries): Added.
(WebCore::EventDispatcher::adjustRelatedTarget): Changed to calculate
inner/outer shadow DOM boundaries and adjust ancestors chain accordingly.
(WebCore::EventDispatcher::EventDispatcher): Added flag initializer
(WebCore::EventDispatcher::ensureEventAncestors): Renamed from getEventAncestors,
converted to use initialization flag, rather than testing for empty.
* dom/EventDispatcher.h: Adjusted decls.
* dom/MouseEvent.cpp:
(WebCore::MouseEventDispatchMediator::dispatchEvent): Changed to send event
to adjustRelatedTarget.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83386
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Sun, 10 Apr 2011 02:32:07 +0000 (02:32 +0000)]
2011-04-08 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
A few heap-related renames and file moves.
WeakGCPtr<T> => Weak<T>
Global<T> => Strong<T>
collector/ => heap/
collector/* => heap/*
runtime/WeakGCPtr.h => heap/Weak.h
(Eventually, even more files should move into the heap directory. Like
Heap.h and Heap.cpp, for example.)
* API/JSClassRef.h:
* CMakeLists.txt:
* GNUmakefile.am:
* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.pri:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
* JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd:
* JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/SamplingTool.h:
* bytecompiler/BytecodeGenerator.h:
* collector: Removed.
* collector/handles: Removed.
* collector/handles/Global.h: Removed.
* collector/handles/Handle.h: Removed.
* collector/handles/HandleHeap.cpp: Removed.
* collector/handles/HandleHeap.h: Removed.
* collector/handles/HandleStack.cpp: Removed.
* collector/handles/HandleStack.h: Removed.
* collector/handles/Local.h: Removed.
* collector/handles/LocalScope.h: Removed.
* heap: Copied from collector.
* heap/Handle.h: Copied from collector/handles/Handle.h.
* heap/HandleHeap.cpp: Copied from collector/handles/HandleHeap.cpp.
* heap/HandleHeap.h: Copied from collector/handles/HandleHeap.h.
* heap/HandleStack.cpp: Copied from collector/handles/HandleStack.cpp.
* heap/HandleStack.h: Copied from collector/handles/HandleStack.h.
* heap/Local.h: Copied from collector/handles/Local.h.
* heap/LocalScope.h: Copied from collector/handles/LocalScope.h.
* heap/Strong.h: Copied from collector/handles/Global.h.
(JSC::Strong::Strong):
(JSC::Strong::~Strong):
(JSC::Strong::operator=):
* heap/Weak.h: Copied from runtime/WeakGCPtr.h.
(JSC::Weak::Weak):
(JSC::Weak::~Weak):
* heap/handles: Removed.
* interpreter/RegisterFile.h:
* jit/JITStubs.cpp:
(JSC::JITThunks::hostFunctionStub):
* jit/JITStubs.h:
* runtime/Structure.h:
* runtime/WeakGCPtr.h: Removed.
2011-04-08 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
A few heap-related renames and file moves.
WeakGCPtr<T> => Weak<T>
Global<T> => Strong<T>
collector/ => heap/
collector/* => heap/*
runtime/WeakGCPtr.h => heap/Weak.h
(Eventually, even more files should move into the heap directory. Like
Heap.h and Heap.cpp, for example.)
* JSRun.h:
* JSValueWrapper.h:
2011-04-08 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
A few heap-related renames and file moves.
WeakGCPtr<T> => Weak<T>
Global<T> => Strong<T>
collector/ => heap/
collector/* => heap/*
runtime/WeakGCPtr.h => heap/Weak.h
(Eventually, even more files should move into the heap directory. Like
Heap.h and Heap.cpp, for example.)
* CMakeLists.txt:
2011-04-08 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
A few heap-related renames and file moves.
WeakGCPtr<T> => Weak<T>
Global<T> => Strong<T>
collector/ => heap/
collector/* => heap/*
runtime/WeakGCPtr.h => heap/Weak.h
(Eventually, even more files should move into the heap directory. Like
Heap.h and Heap.cpp, for example.)
* Plugins/Hosted/NetscapePluginInstanceProxy.h:
* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget):
(WebKit::NetscapePluginInstanceProxy::evaluate):
* WebView/WebScriptDebugger.h:
2011-04-08 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
A few heap-related renames and file moves.
WeakGCPtr<T> => Weak<T>
Global<T> => Strong<T>
collector/ => heap/
collector/* => heap/*
runtime/WeakGCPtr.h => heap/Weak.h
(Eventually, even more files should move into the heap directory. Like
Heap.h and Heap.cpp, for example.)
* CMakeLists.txt:
* ForwardingHeaders/collector: Removed.
* ForwardingHeaders/heap: Copied from ForwardingHeaders/collector.
* ForwardingHeaders/heap/Strong.h: Copied from ForwardingHeaders/collector/handles/Global.h.
* ForwardingHeaders/heap/Weak.h: Copied from ForwardingHeaders/runtime/WeakGCPtr.h.
* ForwardingHeaders/runtime/WeakGCPtr.h: Removed.
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcproj/copyForwardingHeaders.cmd:
* bindings/js/JSCallbackData.h:
* bindings/js/JSCustomVoidCallback.h:
* bindings/js/JSDOMWindowBase.h:
* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::setWindow):
* bindings/js/JSDataGridDataSource.h:
* bindings/js/JSEventListener.h:
* bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::ScheduledAction):
* bindings/js/ScheduledAction.h:
* bindings/js/ScriptCachedFrameData.cpp:
(WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
* bindings/js/ScriptCachedFrameData.h:
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::createWindowShell):
* bindings/js/ScriptController.h:
* bindings/js/ScriptObject.h:
* bindings/js/ScriptState.h:
* bindings/js/ScriptValue.cpp:
* bindings/js/ScriptValue.h:
* bindings/js/ScriptWrappable.h:
* bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::initScript):
* bindings/js/WorkerScriptController.h:
* bridge/jsc/BridgeJSC.h:
* bridge/qt/qt_runtime.h:
* bridge/runtime_root.h:
* xml/XMLHttpRequest.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83385
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Sun, 10 Apr 2011 00:30:54 +0000 (00:30 +0000)]
2011-04-09 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
It looks like NRWT has not been stopping DRT/TestShell
instances properly on windows, probably for a long time.
This would go a long way to explaining why we often have
processes lying around :)
https://bugs.webkit.org/show_bug.cgi?id=57807
* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83384
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Sat, 9 Apr 2011 23:07:05 +0000 (23:07 +0000)]
2011-04-09 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change.
new-run-webkit-tests: Mac SL tests failing on the bot
https://bugs.webkit.org/show_bug.cgi?id=58192
Mark tests as needing triage/investigation for failing
on NRWT bot.
* platform/mac/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83383
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Sat, 9 Apr 2011 22:24:02 +0000 (22:24 +0000)]
2011-04-09 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by James Robinson.
Add a diagram, explaning how an event's relatedTarget interact with shadow DOM boundaries.
https://bugs.webkit.org/show_bug.cgi?id=58190
* misc/related-target-and-shadow-dom.svg: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83382
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Sat, 9 Apr 2011 18:30:35 +0000 (18:30 +0000)]
[Qt][WK2] One more attempt to make Qt-WK2 bot happy.
* platform/qt-wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83381
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Sat, 9 Apr 2011 17:58:53 +0000 (17:58 +0000)]
2011-04-09 Keith Kyzivat <keith.kyzivat@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Don't link against fontconfig or X11 if embedded
https://bugs.webkit.org/show_bug.cgi?id=58104
* Source/WebKit.pri: Add qpa=>embedded as it should be across all builds.
2011-04-09 Keith Kyzivat <keith.kyzivat@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Don't link against fontconfig or X11 if embedded
https://bugs.webkit.org/show_bug.cgi?id=58104
No functional change so no new tests.
* WebCore.pri: qpa=>embedded should be done very early so all cases of embedded are uniform.
2011-04-09 Keith Kyzivat <keith.kyzivat@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Don't link against fontconfig or X11 if embedded
https://bugs.webkit.org/show_bug.cgi?id=58104
* DumpRenderTree/qt/DumpRenderTree.pro: fontconfig !included in embedded
* QtTestBrowser/QtTestBrowser.pro: ditto
* WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: ditto
* WebKitTestRunner/qt/WebKitTestRunner.pro: ditto
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83380
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Sat, 9 Apr 2011 17:24:32 +0000 (17:24 +0000)]
[Qt] Make Qt bots happier. :)
* platform/qt-wk2/Skipped: Remove non-existent tests.
* platform/qt/Skipped: Add new tests without Qt specific expected files.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83379
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Sat, 9 Apr 2011 17:14:10 +0000 (17:14 +0000)]
[Qt] Unreviewed trivial fix after r83344.
* WebCore.pro: Update HEADERS list.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83378
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Sat, 9 Apr 2011 17:04:38 +0000 (17:04 +0000)]
[Qt][WK2] Make Qt-WK2 buildbot green on webkit.sed.hu
* platform/qt-wk2/Skipped: Add failing tests.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83377
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 9 Apr 2011 08:31:00 +0000 (08:31 +0000)]
2011-04-09 Jon Lee <jonlee@apple.com>
Reviewed by Beth Dakin.
Overlay scrollbar flashes in scrollable <textarea> with each keystroke (58180)
https://bugs.webkit.org/show_bug.cgi?id=58180
<rdar://problem/
9047984>
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::immediateScrollToPoint): Check that there is a change before submitting
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaX):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaY):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83376
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 9 Apr 2011 08:01:20 +0000 (08:01 +0000)]
2011-04-09 Sreeram Ramachandran <sreeram@google.com>
Reviewed by Ryosuke Niwa.
Gather data on modal dialogs shown during unload events
https://bugs.webkit.org/show_bug.cgi?id=58115
Add a new method to the ChromeClient API to allow clients to receive
notifications of modal dialogs dispatched during page dismissal events.
The new method has a default empty definition; only chromium overrides
it to keep track of histograms.
No tests because this is a no-op for all ports except chromium (and it's
not clear how to test chromium histograms from webkit).
* page/Chrome.cpp:
(WebCore::isDuringPageDismissal):
(WebCore::willRunModalDialog):
(WebCore::Chrome::runJavaScriptAlert):
(WebCore::Chrome::runJavaScriptConfirm):
(WebCore::Chrome::runJavaScriptPrompt):
(WebCore::Chrome::willRunModalHTMLDialog):
* page/Chrome.h:
* page/ChromeClient.h:
(WebCore::ChromeClient::willRunModalDialogDuringPageDismissal):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::showModalDialog):
2011-04-09 Sreeram Ramachandran <sreeram@google.com>
Reviewed by Ryosuke Niwa.
Gather data on modal dialogs shown during unload events
https://bugs.webkit.org/show_bug.cgi?id=58115
Implementation of the new API to receive notifications of modal dialogs
dispatched during unload events. Count the notifications through a histogram.
No tests because it's not clear how to test chromium histograms from webkit.
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::willRunModalDialogDuringPageDismissal):
* src/ChromeClientImpl.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83375
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sat, 9 Apr 2011 04:41:09 +0000 (04:41 +0000)]
No need to compile .js files, that is what the JIT is for.
* WebKit.xcodeproj/project.pbxproj:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83374
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 9 Apr 2011 03:05:18 +0000 (03:05 +0000)]
2011-04-08 David Humphrey <david.humphrey@senecac.on.ca>
Reviewed by Eric Carlson.
Fix call order of media element muted and play(), such that setting muted before play() works.
https://bugs.webkit.org/show_bug.cgi?id=57673
https://code.google.com/p/chromium/issues/detail?id=70777
Manual test added: manual-tests/media-muted.html
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::updatePlayState):
* manual-tests/media-muted.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83373
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Sat, 9 Apr 2011 01:59:20 +0000 (01:59 +0000)]
2011-04-08 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
WebKit2: Safari doesn't respect cmd-arrows (and variations) as custom keyboard shortcuts
https://bugs.webkit.org/show_bug.cgi?id=58175
<rdar://problem/
9060555>
* WebView/WebFrameView.mm: (-[WebFrameView keyDown:]): Added a comment explaining how this
should be changed to match WebKit2.
2011-04-08 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
WebKit2: Safari doesn't respect cmd-arrows (and variations) as custom keyboard shortcuts
https://bugs.webkit.org/show_bug.cgi?id=58175
<rdar://problem/
9060555>
The problem is that command handling should be different for events that come as keyDown:
and those that come as performKeyEquivalent:. WebKit1 only tries custom "key bindings"
when handling a keyDown:, letting a performKeyEquivalent: run through the whole responder
chain first.
This would be very difficult to implement in WebKit2 because of how it re-sends the same
event after web process handling. Luckily, we can both fix the bug and make the behavior
more robust by not hardcoding key combinations.
* WebProcess/WebPage/WebPage.h: Edit performNonEditingBehaviorForSelector.
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::executeKeypressCommandsInternal): When executing commands, also try
executing editor commands in their non-editing meaning, which is usually scrolling.
(WebKit::WebPage::performNonEditingBehaviorForSelector): Naive implementation with a chain
of ifs, which is hopefully ok performance-wise for a dozen check.
(WebKit::WebPage::performDefaultBehaviorForKeyEvent): Only kept two commands here that I
couldn't easily move.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83372
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jhoneycutt@apple.com [Sat, 9 Apr 2011 01:39:27 +0000 (01:39 +0000)]
http/tests/loading/preload-append-scan.php is failing on Windows
https://bugs.webkit.org/show_bug.cgi?id=58178
Reviewed by Brian Weinstein.
* DumpRenderTree/win/DumpRenderTree.cpp:
(lastPathComponent):
Use CFURL API to find the last path component, rather than
PathFindFileName(), because the latter will include the query string.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83371
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 9 Apr 2011 01:36:34 +0000 (01:36 +0000)]
2011-04-08 Nat Duca <nduca@chromium.org>
Reviewed by David Levin.
[chromium] Fix windows assertion on ~CCThread
https://bugs.webkit.org/show_bug.cgi?id=58153
Because ~CCThread uses waitForThreadCompletion,
calling detachThread is not necessary.
* platform/graphics/chromium/cc/CCThread.cpp:
(WebCore::CCThread::runLoop):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83370
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Sat, 9 Apr 2011 01:31:30 +0000 (01:31 +0000)]
WebKit2: Show the substitutions panel on Mac and make sure the menu items titles are
updated correctly.
https://bugs.webkit.org/show_bug.cgi?id=58179
Reviewed by Anders Carlsson.
* UIProcess/API/mac/WKView.mm:
(-[WKView validateUserInterfaceItem:]):
The title of the context menu item should be opposite of whether or not the spelling panel
is visible.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::contextMenuItemSelected):
If the "Show/Hide" Substitutions item is selected, call toggleSubstitutionsPanelIsShowing.
(WebKit::WebPageProxy::substitutionsPanelIsShowing):
Ask the TextChecker.
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/TextChecker.h:
* UIProcess/mac/TextCheckerMac.mm:
(WebKit::TextChecker::substitutionsPanelIsShowing):
As the shared NSSpellChecker if the substitutionsPanel is visible.
(WebKit::TextChecker::toggleSubstitutionsPanelIsShowing):
Order the substitutionsPanel out or front (copied from WKView.mm).
* WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
(WebKit::WebEditorClient::substitutionsPanelIsShowing):
Send a sync message to the UI process to find out.
It needs to be sync because the editor code relies on the value returned.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83369
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sat, 9 Apr 2011 00:57:35 +0000 (00:57 +0000)]
Fixed a bug where right-to-left frames incorrectly reported that they were pinned to the left
when they were actually not.
Reviewed by Adele Peterson.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didChangeScrollOffsetForMainFrame): Do not assume that the minimum scroll offset
is zero, because it is not.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83368
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jianli@chromium.org [Sat, 9 Apr 2011 00:55:54 +0000 (00:55 +0000)]
Fix broken sentence in WebCore/Change of my rollout r83365.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83367
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aa@chromium.org [Sat, 9 Apr 2011 00:54:36 +0000 (00:54 +0000)]
Reviewed by Dmitry Titov.
Re-land http://trac.webkit.org/changeset/83007. This works
without changes after https://bugs.webkit.org/show_bug.cgi?id=58110.
https://bugs.webkit.org/show_bug.cgi?id=58096
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83366
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jianli@chromium.org [Sat, 9 Apr 2011 00:52:34 +0000 (00:52 +0000)]
2011-04-08 Jian Li <jianli@chromium.org>
Unreviewed, rolling out r83348.
http://trac.webkit.org/changeset/83348
https://bugs.webkit.org/show_bug.cgi?id=49508
Breaks layout tests in QT, Win7 and Chromium.
* fast/forms/cursor-at-editable-content-boundary-expected.txt: Removed.
* fast/forms/cursor-at-editable-content-boundary.html: Removed.
2011-04-08 Jian Li <jianli@chromium.org>
Unreviewed, rolling out r83348.
http://trac.webkit.org/changeset/83348
https://bugs.webkit.org/show_bug.cgi?id=49508
Breaks
* rendering/RenderText.cpp:
(WebCore::RenderText::localCaretRect):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83365
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sat, 9 Apr 2011 00:28:00 +0000 (00:28 +0000)]
Fix the Windows build.
* UIProcess/win/WebView.cpp:
(WebKit::WebView::Drop):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83364
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Sat, 9 Apr 2011 00:18:01 +0000 (00:18 +0000)]
WebKit2: Implement TextChecker on Windows
https://bugs.webkit.org/show_bug.cgi?id=57862
Reviewed by Anders Carlsson.
Part 5: Implement the code show and hide the Spelling UI via the context menu item (both
Windows and Mac).
* UIProcess/API/C/win/WKTextChecker.h:
Add the new WKTextCheckerClient funtions.
* UIProcess/API/mac/WKView.mm:
(-[WKView validateUserInterfaceItem:]):
The title of the context menu item should be opposite of whether or not the spelling panel
is visible.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::contextMenuItemSelected):
If the "Show/Hide Spelling and Grammar" item is selected, call toggleSpellingUIIsShowing.
(WebKit::WebPageProxy::spellingUIIsShowing):
Call through to TextChecker.
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/TextChecker.h:
* UIProcess/win/TextCheckerWin.cpp:
(WebKit::TextChecker::spellingUIIsShowing):
Call the TextCheckerClient.
(WebKit::TextChecker::toggleSpellingUIIsShowing):
Ditto.
* UIProcess/mac/TextCheckerMac.mm:
(WebKit::TextChecker::spellingUIIsShowing):
Ask the shared NSSpellChecker if the spellingPanel is visible.
(WebKit::TextChecker::toggleSpellingUIIsShowing):
Order the spellingPanel out or front (copied from WKView.mm).
* UIProcess/qt/TextCheckerQt.cpp:
(WebKit::TextChecker::spellingUIIsShowing):
Call notImplemented.
(WebKit::TextChecker::toggleSpellingUIIsShowing):
Ditto.
* UIProcess/gtk/TextCheckerGtk.cpp:
(WebKit::TextChecker::spellingUIIsShowing):
Ditto.
(WebKit::TextChecker::toggleSpellingUIIsShowing):
Ditto.
* UIProcess/win/WebTextCheckerClient.cpp:
(WebKit::WebTextCheckerClient::spellingUIIsShowing):
Call the client.
(WebKit::WebTextCheckerClient::toggleSpellingUIIsShowing):
Ditto.
* UIProcess/win/WebTextCheckerClient.h:
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::spellingUIIsShowing):
Send a sync message to the UI process to find out.
It needs to be sync because the Editor code relies on the value returned.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83363
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sat, 9 Apr 2011 00:04:50 +0000 (00:04 +0000)]
2011-04-08 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Sandboxing doesn't work if a local file is dropped on the content area
https://bugs.webkit.org/show_bug.cgi?id=58177
<rdar://problem/
9019253>
When performing a drag and the dragging pasteboard contains a local file, create a
sandbox extension and pass it along. If we end up loading the file, the sandbox extension
tracker will consume the extension.
* UIProcess/API/mac/WKView.mm:
(maybeCreateSandboxExtensionFromPasteboard):
Add helper function.
(-[WKView performDragOperation:]):
Create a sandbox extension handle and pass it to performDrag.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::dragEntered):
(WebKit::WebPageProxy::dragUpdated):
(WebKit::WebPageProxy::dragExited):
Pass an empty sandbox extension handle to performDragControllerAction.
(WebKit::WebPageProxy::performDrag):
Pass the sandbox extension handle along to performDragControllerAction.
(WebKit::WebPageProxy::performDragControllerAction):
Send along the sandbox extension handle.
* WebProcess/WebCoreSupport/WebDragClient.cpp:
(WebKit::WebDragClient::willPerformDragDestinationAction):
If the destination action is a load action, call WebPage::willPerformLoadDragDestinationAction.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::performDragControllerAction):
Create a sandbox extension.
(WebKit::WebPage::willPerformLoadDragDestinationAction):
If we have a sandbox extension, pass it along to the sandbox extension tracker.
(WebKit::WebPage::SandboxExtensionTracker::willPerformLoadDragDestinationAction):
Call setPendingProvisionalSandboxExtension.
(WebKit::WebPage::SandboxExtensionTracker::beginLoad):
Call setPendingProvisionalSandboxExtension.
(WebKit::WebPage::SandboxExtensionTracker::setPendingProvisionalSandboxExtension):
Factor code from beginLoad out into a separate function.
* WebProcess/WebPage/WebPage.messages.in:
PerformDragControllerAction now takes a sandbox extension handle.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83362
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jianli@chromium.org [Sat, 9 Apr 2011 00:02:34 +0000 (00:02 +0000)]
Revert "2011-04-08 Dirk Pranke <dpranke@chromium.org>"
This reverts commit
78a47b96232b89bedf2e2c98794bbac8e19b905a.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83361
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Sat, 9 Apr 2011 00:00:51 +0000 (00:00 +0000)]
2011-04-08 MORITA Hajime <morrita@google.com>
Reviewed by Simon Fraser.
Negative spread should not make a sharp corner rounded
https://bugs.webkit.org/show_bug.cgi?id=58162
Updated the result. This new result matches other browsers behavior.
* platform/mac/fast/box-shadow/inset-expected.checksum:
* platform/mac/fast/box-shadow/inset-expected.png:
2011-04-08 MORITA Hajime <morrita@google.com>
Reviewed by Simon Fraser.
Negative spread should not make a sharp corner rounded
https://bugs.webkit.org/show_bug.cgi?id=58162
Handled inset shadow path for rounded and non-rounded rect
differently as normal shadow path is doing.
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBoxShadow):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83360
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 8 Apr 2011 23:54:45 +0000 (23:54 +0000)]
2011-04-07 Simon Fraser <simon.fraser@apple.com>
Reviewed by Martin Robinson.
REGRESSION (r77034-r77220): CSS box-shadow no longer renders on PowerPC
https://bugs.webkit.org/show_bug.cgi?id=55180
The endianness #ifdef in ShadowBlur was unnecessary and harmful. The
data we get back from ImageBuffer::getImageData() do not vary in
endianness.
* platform/graphics/ShadowBlur.cpp:
(WebCore::ShadowBlur::blurLayerImage):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83358
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alice.liu@apple.com [Fri, 8 Apr 2011 23:51:03 +0000 (23:51 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=58151
Crash after closing a Webview, in WebKit!WebCore::WindowMessageBroadcaster::SubclassedWndProc
Reviewed by Adam Roben.
* UIProcess/win/WebView.cpp:
(WebKit::WebView::close):
Resolve a difference between old WebKit WebView and WebKit2 WebView by destroying and clearing
out WebKit2 WebView's HWND when closing. Not doing so was causing the WebView to remain in the
list of WindowMessageBroadcaster listeners, and after closing the WebView, WindowMessageBroadcaster
would message a dead WebView and crash.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83357
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
arv@chromium.org [Fri, 8 Apr 2011 23:37:33 +0000 (23:37 +0000)]
2011-04-08 Erik Arvidsson <arv@chromium.org>
Reviewed by Dimitri Glazkov.
IFrame is getting the focus even though it is hidden
https://bugs.webkit.org/show_bug.cgi?id=55861
* fast/dom/hidden-iframe-no-focus-expected.txt: Added.
* fast/dom/hidden-iframe-no-focus.html: Added.
2011-04-08 Erik Arvidsson <arv@chromium.org>
Reviewed by Dimitri Glazkov.
IFrame is getting the focus even though it is hidden
https://bugs.webkit.org/show_bug.cgi?id=55861
Test: fast/dom/hidden-iframe-no-focus.html
* html/HTMLFrameOwnerElement.cpp:
(WebCore::HTMLFrameOwnerElement::isKeyboardFocusable):
* html/HTMLFrameOwnerElement.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83356
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 8 Apr 2011 23:01:29 +0000 (23:01 +0000)]
2011-04-08 Jeff Timanus <twiz@chromium.org>
Reviewed by Kenneth Russell.
Fall back to software rendering for Canvas2D when requesting a DrawingBuffer larger than supported by the GL environment.
https://bugs.webkit.org/show_bug.cgi?id=57768
* platform/chromium/test_expectations.txt:
2011-04-08 Jeff Timanus <twiz@chromium.org>
Reviewed by Kenneth Russell.
Fall back to software rendering for Canvas2D when requesting a DrawingBuffer larger than supported by the GL environment.
https://bugs.webkit.org/show_bug.cgi?id=57768
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
(WebCore::CanvasRenderingContext2D::reset):
* platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore::DrawingBuffer::reset):
* platform/graphics/gpu/DrawingBuffer.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83355
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 8 Apr 2011 23:00:32 +0000 (23:00 +0000)]
2011-04-08 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Make the drag operations be different functions
https://bugs.webkit.org/show_bug.cgi?id=58169
Since we want performDrag to take a sandbox extension, separate the four
drag operations out into different functions. No functionality change.
* UIProcess/API/mac/WKView.mm:
(-[WKView draggingEntered:]):
(-[WKView draggingUpdated:]):
(-[WKView draggingExited:]):
(-[WKView performDragOperation:]):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::dragEntered):
(WebKit::WebPageProxy::dragUpdated):
(WebKit::WebPageProxy::dragExited):
(WebKit::WebPageProxy::performDrag):
* UIProcess/WebPageProxy.h:
* UIProcess/win/WebView.cpp:
(WebKit::WebView::DragEnter):
(WebKit::WebView::DragOver):
(WebKit::WebView::DragLeave):
(WebKit::WebView::Drop):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83354
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dcheng@chromium.org [Fri, 8 Apr 2011 22:59:33 +0000 (22:59 +0000)]
2011-04-08 Daniel Cheng <dcheng@chromium.org>
Reviewed by Dmitry Titov.
[chromium] Implement image/png support in DataTransferItems
https://bugs.webkit.org/show_bug.cgi?id=58106
Add a reftest to verify that the various bits in the pipeline work as expected.
* editing/pasteboard/data-transfer-items-image-png-expected.html: Added.
* editing/pasteboard/data-transfer-items-image-png.html: Added.
2011-04-08 Daniel Cheng <dcheng@chromium.org>
Reviewed by Dmitry Titov.
[chromium] Implement image/png support in DataTransferItems
https://bugs.webkit.org/show_bug.cgi?id=58106
This patch implements DataTransferItem::getAsFile() using Blobs. In
addition, plumbing for image/png has been added so image paste will be
supported as long as the renderer makes that data available.
Tests: editing/pasteboard/data-transfer-items-image-png.html
* dom/DataTransferItem.h:
* dom/DataTransferItem.idl:
* platform/chromium/ClipboardMimeTypes.cpp:
* platform/chromium/ClipboardMimeTypes.h:
* platform/chromium/DataTransferItemChromium.cpp:
(WebCore::DataTransferItemChromium::getAsString):
(WebCore::DataTransferItemChromium::getAsFile):
* platform/chromium/DataTransferItemChromium.h:
* platform/chromium/PlatformBridge.h:
2011-04-08 Daniel Cheng <dcheng@chromium.org>
Reviewed by Dmitry Titov.
[chromium] Implement image/png support in DataTransferItems
https://bugs.webkit.org/show_bug.cgi?id=58106
Add glue for reading image data from clipboard.
* DEPS:
* src/PlatformBridge.cpp:
(WebCore::PlatformBridge::clipboardReadImage):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83353
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Fri, 8 Apr 2011 22:42:20 +0000 (22:42 +0000)]
2011-04-08 MORITA Hajime <morrita@google.com>
Unreviewed windows build fix.
* editing/SpellingCorrectionController.h:
(WebCore::SpellingCorrectionController::UNLESS_ENABLED):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83352
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enrica@apple.com [Fri, 8 Apr 2011 22:39:42 +0000 (22:39 +0000)]
Improve lifetime management of nodes in ReplaceNodeWithSpanCommand.
https://bugs.webkit.org/show_bug.cgi?id=57595
<rdar://problem/
9222122>
Reviewed by Maciej Stachowiak.
Source/WebCore:
Test: editing/style/bold-with-dom-changes.html
* editing/ReplaceNodeWithSpanCommand.cpp:
(WebCore::swapInNodePreservingAttributesAndChildren):
LayoutTests:
* editing/style/bold-with-dom-changes-expected.txt: Added.
* editing/style/bold-with-dom-changes.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83351
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 8 Apr 2011 22:39:00 +0000 (22:39 +0000)]
2011-04-08 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Parse 'DispatchOnConnectionQueue' in messages.in files
https://bugs.webkit.org/show_bug.cgi?id=58168
Handle parsing multiple, space-separated attributes in .messages.in files. Keep track of
'DispatchOnConnectionQueue' and rename 'delayed' to 'Delayed'.
* Scripts/webkit2/messages.py:
* Scripts/webkit2/messages_unittest.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83350
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rolandsteiner@chromium.org [Fri, 8 Apr 2011 22:37:39 +0000 (22:37 +0000)]
2011-04-07 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Dimitri Glazkov.
Bug 58060 - Prepare access to TreeScope from Node, using NodeRareData
https://bugs.webkit.org/show_bug.cgi?id=58060
Add a TreeScope pointer to NodeRareData to allow direct access to the containing tree scope.
However, in case the containing scope is the document, this is not set, and the
document pointer within Node is used instead.
In an object derived from TreeScope (currently Document), the tree scope pointer
points to itself. Such objects also contain a parent tree scope pointer that
points to the containing scope. For Document, this is 0.
Add new functions setTreeScope[Recursively] that replace setDocument[Recursively]
in public usage. setDocument[Recursively] are now only used internally and are
thererfore protected.
No new tests. (no new functionality)
* dom/ContainerNode.cpp: change DOM manipulation methods to update scope of inserted nodes
(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::appendChild):
* dom/Document.cpp:
(WebCore::Document::~Document):
(WebCore::Document::setDocType): Ditto
(WebCore::Document::adoptNode): Ditto
* dom/Document.h:
* dom/Node.cpp:
(WebCore::Node::treeScope): use NodeRareData to check if a non-Document scope is set
(WebCore::Node::setTreeScope): update NodeRareData depending on whether scope is a document
(WebCore::Node::setTreeScopeRecursively):
(WebCore::Node::setDocumentRecursively):
* dom/Node.h:
* dom/NodeRareData.h: add scope pointer
(WebCore::NodeRareData::NodeRareData):
(WebCore::NodeRareData::treeScope):
(WebCore::NodeRareData::setTreeScope):
* dom/TreeScope.cpp: add parentTreeScope pointer
(WebCore::TreeScope::TreeScope):
(WebCore::TreeScope::setParentTreeScope):
* dom/TreeScope.h:
(WebCore::TreeScope::parentTreeScope):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83349
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xji@chromium.org [Fri, 8 Apr 2011 22:34:56 +0000 (22:34 +0000)]
2011-04-08 Xiaomei Ji <xji@chromium.org>
Reviewed by David Hyatt.
Local caret rectangle calculation should be relative to its containing block.
https://bugs.webkit.org/show_bug.cgi?id=49508.
* fast/forms/cursor-at-editable-content-boundary-expected.txt: Added.
* fast/forms/cursor-at-editable-content-boundary.html: Added.
2011-04-08 Xiaomei Ji <xji@chromium.org>
Reviewed by David Hyatt.
Local caret rectangle calculation should be relative to its containing block.
https://bugs.webkit.org/show_bug.cgi?id=49508.
InlineBox and caret rectangle are positioned relative to its containing block.
So its left and right edge value should be relative to its containing block as well.
Test: fast/forms/cursor-at-editable-content-boundary.html
* rendering/RenderText.cpp:
(WebCore::RenderText::localCaretRect):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83348
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Fri, 8 Apr 2011 22:23:30 +0000 (22:23 +0000)]
2011-04-08 MORITA Hajime <morrita@google.com>
Unreviewed build fix.
* editing/Editor.cpp:
(WebCore::Editor::markMisspellingsAfterTypingToWord):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83347
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
scheib@chromium.org [Fri, 8 Apr 2011 22:15:48 +0000 (22:15 +0000)]
2011-04-08 Vincent Scheib <scheib@chromium.org>
Reviewed by Eric Seidel.
add chromium-gpu-linux-x86_64 to the recognized list of ports
https://bugs.webkit.org/show_bug.cgi?id=58099
Add chromium-gpu-linux-x86_64 to fix assert.
* Scripts/webkitpy/layout_tests/port/chromium_linux.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83346
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Fri, 8 Apr 2011 21:57:54 +0000 (21:57 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=57971
Reviewed by Simon Fraser.
Rework visited/unvisited links for before/after content. Propagate the bits earlier so that we don't lose
them when we throw away the visited style. Don't throw away the visited link style for pseudo elements
either, so that the styles are consistent.
Source/WebCore:
Added fast/history/visited-generated-content-test.html
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
LayoutTests:
* fast/history/visited-generated-content-test-expected.txt: Added.
* fast/history/visited-generated-content-test.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83345
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Fri, 8 Apr 2011 21:21:44 +0000 (21:21 +0000)]
2011-04-06 MORITA Hajime <morrita@google.com>
Reviewed by Darin Adler.
[Refactoring] Auto correction panel should be handled by its own class.
https://bugs.webkit.org/show_bug.cgi?id=55571
Extracted code inside SUPPORT_AUTOCORRECTION_PANEL into
SpellingCorrectionController class.
This change also remove some SUPPORT_AUTOCORRECTION_PANEL guard if
code paths inside the never reached without autocorrection support.
Removing guards reduces unintentional build breakage.
No new tests, no behavior chagne.
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* editing/CorrectionPanelInfo.h: Removed.
* editing/EditingAllInOne.cpp:
* editing/Editor.cpp:
(WebCore::Editor::respondToChangedSelection):
(WebCore::Editor::respondToChangedContents):
(WebCore::Editor::appliedEditing):
(WebCore::Editor::Editor):
(WebCore::Editor::~Editor):
(WebCore::Editor::insertTextWithoutSendingTextEvent):
(WebCore::Editor::insertLineBreak):
(WebCore::Editor::insertParagraphSeparator):
(WebCore::Editor::cut):
(WebCore::Editor::paste):
(WebCore::Editor::pasteAsPlainText):
(WebCore::Editor::isAutomaticSpellingCorrectionEnabled):
(WebCore::Editor::markMisspellingsAfterTypingToWord):
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
(WebCore::Editor::changeBackToReplacedString):
(WebCore::Editor::unappliedSpellCorrection):
(WebCore::Editor::updateMarkersForWordsAffectedByEditing):
(WebCore::Editor::startCorrectionPanelTimer):
(WebCore::Editor::handleCorrectionPanelResult):
(WebCore::Editor::dismissCorrectionPanelAsIgnored):
* editing/Editor.h:
* editing/SpellingCorrectionCommand.cpp:
* editing/SpellingCorrectionController.cpp: Added.
(WebCore::markerTypesForAutocorrection):
(WebCore::markerTypesForReplacement):
(WebCore::markersHaveIdenticalDescription):
(WebCore::SpellingCorrectionController::SpellingCorrectionController):
(WebCore::SpellingCorrectionController::~SpellingCorrectionController):
(WebCore::SpellingCorrectionController::startCorrectionPanelTimer):
(WebCore::SpellingCorrectionController::stopCorrectionPanelTimer):
(WebCore::SpellingCorrectionController::stopPendingCorrection):
(WebCore::SpellingCorrectionController::applyPendingCorrection):
(WebCore::SpellingCorrectionController::hasPendingCorrection):
(WebCore::SpellingCorrectionController::isSpellingMarkerAllowed):
(WebCore::SpellingCorrectionController::show):
(WebCore::SpellingCorrectionController::handleCancelOperation):
(WebCore::SpellingCorrectionController::dismiss):
(WebCore::SpellingCorrectionController::dismissSoon):
(WebCore::SpellingCorrectionController::applyCorrectionPanelInfo):
(WebCore::SpellingCorrectionController::applyAutocorrectionBeforeTypingIfAppropriate):
(WebCore::SpellingCorrectionController::respondToUnappliedSpellCorrection):
(WebCore::SpellingCorrectionController::correctionPanelTimerFired):
(WebCore::SpellingCorrectionController::handleCorrectionPanelResult):
(WebCore::SpellingCorrectionController::isAutomaticSpellingCorrectionEnabled):
(WebCore::SpellingCorrectionController::windowRectForRange):
(WebCore::SpellingCorrectionController::respondToChangedSelection):
(WebCore::SpellingCorrectionController::respondToAppliedEditing):
(WebCore::SpellingCorrectionController::client):
(WebCore::SpellingCorrectionController::textChecker):
(WebCore::SpellingCorrectionController::recordAutocorrectionResponseReversed):
(WebCore::SpellingCorrectionController::markReversed):
(WebCore::SpellingCorrectionController::markCorrection):
(WebCore::SpellingCorrectionController::recordSpellcheckerResponseForModifiedCorrection):
* editing/SpellingCorrectionController.h: Added.
(WebCore::SpellingCorrectionController::UNLESS_ENABLED):
(WebCore::SpellingCorrectionController::shouldStartTimeFor):
(WebCore::SpellingCorrectionController::shouldRemoveMarkersUponEditing):
* editing/TypingCommand.cpp:
(WebCore::TypingCommand::insertText):
(WebCore::TypingCommand::markMisspellingsAfterTyping):
(WebCore::TypingCommand::deleteKeyPressed):
(WebCore::TypingCommand::forwardDeleteKeyPressed):
* editing/htmlediting.h:
(WebCore::isAmbiguousBoundaryCharacter):
* page/EditorClient.h:
* page/Frame.cpp:
(WebCore::Frame::setPageAndTextZoomFactors):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83344
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 8 Apr 2011 21:06:26 +0000 (21:06 +0000)]
2011-04-08 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
dump-as-markup conversion: editing/pasteboard/paste-text-at-tabspan-001.html and paste-text-at-tabspan-002.html
https://bugs.webkit.org/show_bug.cgi?id=58081
Converted paste-text-at-tabspan-001.html and paste-text-at-tabspan-002.html to dump-as-markup tests.
Also explained what to expect in each test.
* editing/pasteboard/paste-text-at-tabspan-001-expected.txt: Added.
* editing/pasteboard/paste-text-at-tabspan-001.html:
* editing/pasteboard/paste-text-at-tabspan-002-expected.txt: Added.
* editing/pasteboard/paste-text-at-tabspan-002.html:
* platform/chromium-linux/editing/pasteboard/paste-text-at-tabspan-001-expected.checksum: Removed.
* platform/chromium-linux/editing/pasteboard/paste-text-at-tabspan-001-expected.png: Removed.
* platform/chromium-linux/editing/pasteboard/paste-text-at-tabspan-002-expected.checksum: Removed.
* platform/chromium-linux/editing/pasteboard/paste-text-at-tabspan-002-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-text-at-tabspan-001-expected.checksum: Removed.
* platform/chromium-win/editing/pasteboard/paste-text-at-tabspan-001-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-text-at-tabspan-001-expected.txt: Removed.
* platform/chromium-win/editing/pasteboard/paste-text-at-tabspan-002-expected.checksum: Removed.
* platform/chromium-win/editing/pasteboard/paste-text-at-tabspan-002-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-text-at-tabspan-002-expected.txt: Removed.
* platform/gtk/editing/pasteboard/paste-text-at-tabspan-001-expected.checksum: Removed.
* platform/gtk/editing/pasteboard/paste-text-at-tabspan-001-expected.png: Removed.
* platform/gtk/editing/pasteboard/paste-text-at-tabspan-001-expected.txt: Removed.
* platform/gtk/editing/pasteboard/paste-text-at-tabspan-002-expected.checksum: Removed.
* platform/gtk/editing/pasteboard/paste-text-at-tabspan-002-expected.png: Removed.
* platform/gtk/editing/pasteboard/paste-text-at-tabspan-002-expected.txt: Removed.
* platform/mac/editing/pasteboard/paste-text-at-tabspan-001-expected.checksum: Removed.
* platform/mac/editing/pasteboard/paste-text-at-tabspan-001-expected.png: Removed.
* platform/mac/editing/pasteboard/paste-text-at-tabspan-001-expected.txt: Removed.
* platform/mac/editing/pasteboard/paste-text-at-tabspan-002-expected.checksum: Removed.
* platform/mac/editing/pasteboard/paste-text-at-tabspan-002-expected.png: Removed.
* platform/mac/editing/pasteboard/paste-text-at-tabspan-002-expected.txt: Removed.
* platform/qt/editing/pasteboard/paste-text-at-tabspan-001-expected.txt: Removed.
* platform/qt/editing/pasteboard/paste-text-at-tabspan-002-expected.checksum: Removed.
* platform/qt/editing/pasteboard/paste-text-at-tabspan-002-expected.png: Removed.
* platform/qt/editing/pasteboard/paste-text-at-tabspan-002-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83343
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hclam@chromium.org [Fri, 8 Apr 2011 20:58:17 +0000 (20:58 +0000)]
2011-04-08 Alpha Lam <hclam@chromium.org>
Unreviewed, rolling out r83335.
http://trac.webkit.org/changeset/83335
https://bugs.webkit.org/show_bug.cgi?id=53556
GTK and QT bots are broken.
* configure.ac:
2011-04-08 Alpha Lam <hclam@chromium.org>
Unreviewed, rolling out r83335.
http://trac.webkit.org/changeset/83335
https://bugs.webkit.org/show_bug.cgi?id=53556
GTK and QT bots are broken
* Configurations/FeatureDefines.xcconfig:
2011-04-08 Alpha Lam <hclam@chromium.org>
Unreviewed, rolling out r83335.
http://trac.webkit.org/changeset/83335
https://bugs.webkit.org/show_bug.cgi?id=53556
GTK and QT bots are broken
* CMakeLists.txt:
* Configurations/FeatureDefines.xcconfig:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* features.pri:
* html/HTMLAttributeNames.in:
* html/HTMLTagNames.in:
* html/HTMLTrackElement.cpp: Removed.
* html/HTMLTrackElement.h: Removed.
* html/HTMLTrackElement.idl: Removed.
2011-04-08 Alpha Lam <hclam@chromium.org>
Unreviewed, rolling out r83335.
http://trac.webkit.org/changeset/83335
https://bugs.webkit.org/show_bug.cgi?id=53556
GTK and QT bots are broken
* WebKit.xcodeproj/project.pbxproj:
2011-04-08 Alpha Lam <hclam@chromium.org>
Unreviewed, rolling out r83335.
http://trac.webkit.org/changeset/83335
https://bugs.webkit.org/show_bug.cgi?id=53556
GTK and QT bots are broken
* features.gypi:
2011-04-08 Alpha Lam <hclam@chromium.org>
Unreviewed, rolling out r83335.
http://trac.webkit.org/changeset/83335
https://bugs.webkit.org/show_bug.cgi?id=53556
GTK and QT bots are broken
* Configurations/FeatureDefines.xcconfig:
2011-04-08 Alpha Lam <hclam@chromium.org>
Unreviewed, rolling out r83335.
http://trac.webkit.org/changeset/83335
https://bugs.webkit.org/show_bug.cgi?id=53556
GTK and QT bots are broken
* Configurations/FeatureDefines.xcconfig:
2011-04-08 Alpha Lam <hclam@chromium.org>
Unreviewed, rolling out r83335.
http://trac.webkit.org/changeset/83335
https://bugs.webkit.org/show_bug.cgi?id=53556
GTK and QT bots are broken
* Scripts/build-webkit:
2011-04-08 Alpha Lam <hclam@chromium.org>
Unreviewed, rolling out r83335.
http://trac.webkit.org/changeset/83335
https://bugs.webkit.org/show_bug.cgi?id=53556
GTK and QT bots are broken
* win/tools/vsprops/FeatureDefines.vsprops:
* win/tools/vsprops/FeatureDefinesCairo.vsprops:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83342
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Fri, 8 Apr 2011 20:46:58 +0000 (20:46 +0000)]
Ooops, typo, build fix.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parse):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83341
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 8 Apr 2011 20:40:46 +0000 (20:40 +0000)]
2011-04-08 Kristian Amlie <kristian.amlie@nokia.com>
Reviewed by Andreas Kling.
[Qt] Remove modular references after support for the flag was removed.
https://bugs.webkit.org/show_bug.cgi?id=57018
Removed modular references after support for the flag was removed.
Support was removed because the Qt Modularization project decided we
don't need it. It's better to base decisions on the available
information, as demonstrated in the patch by checking
QT.phonon.includes.
* Source/WebKit.pri:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83340
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 8 Apr 2011 20:38:03 +0000 (20:38 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=58155 and part of <rdar://problem/
9251767>
BitmapImage::getFirstCGImageRefOfSize fails if the frameCount hasn't been initialized from the image source.
Reviewed by Adam Roben.
* platform/graphics/cg/ImageCG.cpp:
(WebCore::BitmapImage::getFirstCGImageRefOfSize): Call frameCount() instead of accessing m_frames.size() to
make sure the frames are properly tallied first.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83339
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin.poulain@nokia.com [Fri, 8 Apr 2011 20:36:18 +0000 (20:36 +0000)]
2011-04-08 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Andreas Kling.
[Qt] Dragging and dropping an image in edit mode does not work
https://bugs.webkit.org/show_bug.cgi?id=19385
When adding an image to the clipboard, we should also include the HTML code of that image so
it can be used for internal drag and drop.
This HTML is expected by all clients of drop events so a fragment can be moved from one browser to
another, or inside the same browser.
* platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::declareAndWriteDragImage):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83338
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Fri, 8 Apr 2011 20:33:24 +0000 (20:33 +0000)]
Bug 58154 - Add support for comparison operators to the DFG JIT.
Reviewed by Oliver Hunt.
Add support for <, <=, ==, ===, and also !. Add support for all corresponding
bytecode ops, including the not- and -null forms. Initially add functionally
correct support, we'll revisit the performance.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::constantNull):
(JSC::DFG::ByteCodeParser::parse):
- Add support for parsing of bytecode opcodes,
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::callOperation):
- Add new operation call types, return bool values.
* dfg/DFGNode.h:
- Add new node types.
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
- Add code generation for new nodes.
* dfg/DFGOperations.cpp:
(JSC::DFG::operationCompareLess):
(JSC::DFG::operationCompareLessEq):
(JSC::DFG::operationCompareEq):
(JSC::DFG::operationCompareStrictEq):
(JSC::DFG::dfgConvertJSValueToBoolean):
* dfg/DFGOperations.h:
- Add operation callbacks to implement new ops.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- Add code generation for new nodes.
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
- Switched to a simpler <0 check, rather than relying on an internal value in JSImmediate.
* jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompilePatchGetArrayLength):
- Switched to a simpler <0 check, rather than relying on an internal value in JSImmediate.
* runtime/JSImmediate.h:
- Make tag values public, rather than relying on a friend - this matches JSVALUE32_64.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83337
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 8 Apr 2011 20:28:48 +0000 (20:28 +0000)]
2011-04-08 Ryosuke Niwa <rniwa@webkit.org>
Rebaselines and text expectation updates after r83322.
The bug is tracked by https://bugs.webkit.org/show_bug.cgi?id=58158
* platform/chromium/test_expectations.txt:
* platform/gtk/editing/pasteboard/paste-xml-expected.txt:
* platform/win/editing/pasteboard/paste-xml-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83336
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hclam@chromium.org [Fri, 8 Apr 2011 20:28:22 +0000 (20:28 +0000)]
2011-04-07 Anna Cavender <annacc@chromium.org>
Reviewed by Eric Carlson.
Setup ENABLE(TRACK) feature define
https://bugs.webkit.org/show_bug.cgi?id=53556
* configure.ac:
2011-04-07 Anna Cavender <annacc@chromium.org>
Reviewed by Eric Carlson.
Setup ENABLE(TRACK) feature define
https://bugs.webkit.org/show_bug.cgi?id=53556
* Configurations/FeatureDefines.xcconfig:
2011-04-07 Anna Cavender <annacc@chromium.org>
Reviewed by Eric Carlson.
Setup ENABLE(TRACK) feature define + initial HTMLTrackElement
https://bugs.webkit.org/show_bug.cgi?id=53556
No new tests. No real functionality added just yet.
* CMakeLists.txt:
* Configurations/FeatureDefines.xcconfig:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* features.pri:
* html/HTMLAttributeNames.in:
* html/HTMLTagNames.in:
* html/HTMLTrackElement.cpp: Added.
(WebCore::HTMLTrackElement::HTMLTrackElement):
(WebCore::HTMLTrackElement::create):
(WebCore::HTMLTrackElement::insertedIntoTree):
(WebCore::HTMLTrackElement::willRemove):
(WebCore::HTMLTrackElement::src):
(WebCore::HTMLTrackElement::setSrc):
(WebCore::HTMLTrackElement::kind):
(WebCore::HTMLTrackElement::setKind):
(WebCore::HTMLTrackElement::srclang):
(WebCore::HTMLTrackElement::setSrclang):
(WebCore::HTMLTrackElement::label):
(WebCore::HTMLTrackElement::setLabel):
(WebCore::HTMLTrackElement::isDefault):
(WebCore::HTMLTrackElement::setIsDefault):
(WebCore::HTMLTrackElement::isURLAttribute):
* html/HTMLTrackElement.h: Added.
* html/HTMLTrackElement.idl: Added.
2011-04-07 Anna Cavender <annacc@chromium.org>
Reviewed by Eric Carlson.
Setup ENABLE(TRACK) feature define + initial HTMLTrackElement
https://bugs.webkit.org/show_bug.cgi?id=53556
* WebKit.xcodeproj/project.pbxproj:
2011-04-07 Anna Cavender <annacc@chromium.org>
Reviewed by Eric Carlson.
Setup ENABLE(TRACK) feature define
https://bugs.webkit.org/show_bug.cgi?id=53556
* features.gypi:
2011-04-07 Anna Cavender <annacc@chromium.org>
Reviewed by Eric Carlson.
Setup ENABLE(TRACK) feature define
https://bugs.webkit.org/show_bug.cgi?id=53556
* Configurations/FeatureDefines.xcconfig:
2011-04-07 Anna Cavender <annacc@chromium.org>
Reviewed by Eric Carlson.
Setup ENABLE(TRACK) feature define
https://bugs.webkit.org/show_bug.cgi?id=53556
* Configurations/FeatureDefines.xcconfig:
2011-04-07 Anna Cavender <annacc@chromium.org>
Reviewed by Eric Carlson.
Setup ENABLE(TRACK) feature define
https://bugs.webkit.org/show_bug.cgi?id=53556
* Scripts/build-webkit:
2011-04-07 Anna Cavender <annacc@chromium.org>
Reviewed by Eric Carlson.
Setup ENABLE(TRACK) feature define
https://bugs.webkit.org/show_bug.cgi?id=53556
* win/tools/vsprops/FeatureDefines.vsprops:
* win/tools/vsprops/FeatureDefinesCairo.vsprops:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83335
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Fri, 8 Apr 2011 20:21:32 +0000 (20:21 +0000)]
2011-04-08 Dirk Pranke <dpranke@chromium.org>
Reviewed by Adam Roben.
new-run-webkit-tests: configure a NRWT test bot for Mac SL
https://bugs.webkit.org/show_bug.cgi?id=58114
This change removes the old new-run-webkit-tests entry and
updates it for a new test-only bot.
* BuildSlaveSupport/build.webkit.org-config/config.json:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83334
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 8 Apr 2011 20:14:54 +0000 (20:14 +0000)]
2011-04-08 Dominic Cooney <dominicc@google.com>
Reviewed by Adam Roben.
layoutTestController.shadowRoot returns null, not undefined, when
its argument is invalid.
https://bugs.webkit.org/show_bug.cgi?id=58121
Update the test to expect null and not undefined.
* fast/dom/HTMLKeygenElement/keygen-expected.txt:
* fast/dom/HTMLKeygenElement/keygen.html:
* platform/chromium/test_expectations.txt: unskip keygen.html
2011-04-08 Dominic Cooney <dominicc@google.com>
Reviewed by Adam Roben.
Make layoutTestController.shadowRoot return null, not undefined,
when its argument is invalid.
https://bugs.webkit.org/show_bug.cgi?id=58121
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::shadowRoot):
2011-04-08 Dominic Cooney <dominicc@google.com>
Reviewed by Adam Roben.
Make layoutTestController.shadowRoot return null, not undefined,
when its argument is invalid.
https://bugs.webkit.org/show_bug.cgi?id=58121
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::shadowRoot):
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::shadowRoot):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83333
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Fri, 8 Apr 2011 20:11:32 +0000 (20:11 +0000)]
2011-04-07 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
Logic error in HTMLMediaElement::exitFullscreen()
https://bugs.webkit.org/show_bug.cgi?id=58085
The new full screen API case could fall through to the legacy API case
unintentionally if a script calls exitFullscreen on an element which is
not the current full screen element.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::enterFullscreen):
(WebCore::HTMLMediaElement::exitFullscreen):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83332
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dimich@chromium.org [Fri, 8 Apr 2011 20:10:47 +0000 (20:10 +0000)]
[Chromium] Remove unneeded usage of V8::Lockers in IDB tests.
https://bugs.webkit.org/show_bug.cgi?id=58110
Since they are simple one-thread tests.
This code parallels the code in Chromium's idb bindings that uses v8 Lockers in utility process,
which is equally not needed since there is only one thread running v8 in that process.
Reviewed by Adam Barth.
* tests/IDBBindingUtilitiesTest.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83331
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Fri, 8 Apr 2011 20:08:01 +0000 (20:08 +0000)]
2011-04-08 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
new-run-webkit-tests: implement support for audio tests.
https://bugs.webkit.org/show_bug.cgi?id=57987
* Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
* Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
* Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
* Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
* Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/test.py:
* Scripts/webkitpy/layout_tests/port/mock_drt.py:
* Scripts/webkitpy/layout_tests/port/webkit.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83330
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 8 Apr 2011 20:08:01 +0000 (20:08 +0000)]
2011-04-08 Mike Reed <reed@google.com>
Reviewed by Eric Seidel.
Replace SKIA_TEXT with isNativeFontRenderingAllowed() for print-preview to work
https://bugs.webkit.org/show_bug.cgi?id=57782
No new tests. This change only affects print-preview and build option SKIA_GPU
* platform/graphics/skia/SkiaFontWin.cpp:
(WebCore::paintSkiaText):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83329
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 8 Apr 2011 19:58:49 +0000 (19:58 +0000)]
2011-04-08 Ryosuke Niwa <rniwa@webkit.org>
Chromium rebaselines after r83291.
* platform/chromium/fast/dom/error-to-string-stack-overflow-expected.txt:
* platform/chromium/fast/js/recursion-limit-equal-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83328
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Fri, 8 Apr 2011 19:48:47 +0000 (19:48 +0000)]
2011-04-08 Dirk Pranke <dpranke@chromium.org>
Reviewed by Ojan Vafai.
new-run-webkit-tests: clean up the way we handle missing files,
to be consistent. With this change, the Port.expected_X() and
Driver.run_test() routines should return None if there is no
output, not ''.
https://bugs.webkit.org/show_bug.cgi?id=58101
* Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/port/webkit.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83327
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Fri, 8 Apr 2011 19:39:21 +0000 (19:39 +0000)]
Reviewed by Darin Alder.
REGRESSION (WebKit2): AppKit thinks that web views don't support DocumentAccess
https://bugs.webkit.org/show_bug.cgi?id=58102
<rdar://problem/
9223246>
* UIProcess/API/mac/WKView.h:
* UIProcess/API/mac/WKView.mm:
(-[WKView doCommandBySelector:]):
(-[WKView insertText:replacementRange:]):
(-[WKView validAttributesForMarkedText]):
(-[WKView setMarkedText:selectedRange:replacementRange:]):
(-[WKView attributedSubstringForProposedRange:actualRange:]):
(-[WKView firstRectForCharacterRange:actualRange:]):
Switch to NSTextInputClient, opting out of optimizations and optional features for now.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83326
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Fri, 8 Apr 2011 19:37:17 +0000 (19:37 +0000)]
Not reviewed.
Skip for DRT differences.
* platform/mac-wk2/Skipped:
* platform/qt/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83325
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Fri, 8 Apr 2011 19:33:04 +0000 (19:33 +0000)]
2011-04-08 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin Adler.
-[WebView setPreferences:] can take a lot of time if loading lots of webviews at once
https://bugs.webkit.org/show_bug.cgi?id=58128
<rdar://problem/
9244553>
The root of the problem here was an O(N^2) issue - each WebView,
upon having its preferences initialized, would broadcast a
notification that was listened to by all other WebViews sharing
its preferences.
To maintain the API contract, I split the notification into two,
one that is for public API consumption, and the other which is for
internal use only. Changes that don't need to be picked up by
other WebViews broadcast the public notification only. And we
avoid WebView broadcasting a notification just to get itself to
update.
* Misc/WebIconDatabase.mm:
(-[WebIconDatabase _startUpIconDatabase]):
(-[WebIconDatabase _shutDownIconDatabase]):
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView viewWillMoveToWindow:]):
(-[WebBaseNetscapePluginView viewWillMoveToSuperview:]):
(-[WebBaseNetscapePluginView viewDidMoveToWindow]):
(-[WebBaseNetscapePluginView viewWillMoveToHostWindow:]):
* WebView/WebPreferences.mm:
(-[WebPreferences initWithIdentifier:]):
(-[WebPreferences _setStringValue:forKey:]):
(-[WebPreferences _setIntegerValue:forKey:]):
(-[WebPreferences _setFloatValue:forKey:]):
(-[WebPreferences _setBoolValue:forKey:]):
(-[WebPreferences _setLongLongValue:forKey:]):
(-[WebPreferences _setUnsignedLongLongValue:forKey:]):
(-[WebPreferences _postPreferencesChangedNotification]):
(-[WebPreferences _postPreferencesChangedAPINotification]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
(-[WebView _preferencesChangedNotification:]):
(-[WebView _preferencesChanged:]):
(-[WebView setUsesPageCache:]):
(+[WebView initialize]):
(-[WebView setPreferences:]):
(-[WebView _keyboardUIMode]):
* WebView/WebViewInternal.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83324
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 8 Apr 2011 19:30:03 +0000 (19:30 +0000)]
2011-04-08 Siddharth Mathur <siddharth.mathur@nokia.com>
Reviewed by Martin Robinson.
[Qt][WK2][Symbian] Remove use of stack arrays with variable size
https://bugs.webkit.org/show_bug.cgi?id=57877
For better compiler portability, use new/delete for arrays when size
isn't known at compile time. Also fix one compiler warning about bitshift
operations on signed integer
* Platform/CoreIPC/unix/ConnectionUnix.cpp:
(CoreIPC::Connection::readyReadHandler):
(CoreIPC::Connection::sendOutgoingMessage):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83323
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 8 Apr 2011 19:29:13 +0000 (19:29 +0000)]
2011-04-08 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang, Darin Adler, and Enrica Casucci.
REGRESSION(r81887): Crash in SplitElement
https://bugs.webkit.org/show_bug.cgi?id=57743
The crash was caused by ReplaceSelectionCommand::doApply's calling splitElement with computeNodeAfterPosition
even when the position was after the last node in it container. Since all we are doing here is to splitting tree
up until the highest ancestor with isInlineNodeWithStyle, replaced the while loop by calls to splitTreeToNode
and highestEnclosingNodeOfType.
Also fixed a bug in splitTreeToNode not to check the difference in visible position when splitting the ancestor,
which would have introduced unnecessary nodes when splitting tree and a bug in highestEnclosingNodeOfType that
it incorrectly called deprecatedNode instead of containerNode.
Test: editing/inserting/insert-images-in-pre-x-crash.html
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::splitTreeToNode):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::doApply):
* editing/htmlediting.cpp:
(WebCore::highestEnclosingNodeOfType):
2011-04-08 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang, Darin Adler, and Enrica Casucci.
REGRESSION(r81887): Crash in SplitElement
https://bugs.webkit.org/show_bug.cgi?id=57743
Added a regression test for a crash in ReplaceSelectionCommand.
* editing/inserting/insert-images-in-pre-x-crash-expected.txt: Added.
* editing/inserting/insert-images-in-pre-x-crash.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83322
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Fri, 8 Apr 2011 18:55:37 +0000 (18:55 +0000)]
Incoming source should be preload scanned when the parser is blocked
https://bugs.webkit.org/show_bug.cgi?id=58117
Reviewed by Tony Gentilcore.
Source/WebCore:
Scan the appended source if parser is blocked.
Test: http/tests/loading/preload-append-scan.php
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::append):
LayoutTests:
* http/tests/loading/preload-append-scan-expected.txt: Added.
* http/tests/loading/preload-append-scan.php: Added.
* http/tests/resources/slow-script.pl: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83321
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 8 Apr 2011 18:53:21 +0000 (18:53 +0000)]
2011-04-08 Varun Jain <varunjain@chromium.org>
Reviewed by Darin Fisher.
Need to extend WebKit chromium API to access text selection
https://bugs.webkit.org/show_bug.cgi?id=57888
* Source/WebKit/chromium/public/WebFrame.h:
* Source/WebKit/chromium/public/WebWidget.h:
* Source/WebKit/chromium/src/WebFrameImpl.cpp:
* Source/WebKit/chromium/src/WebFrameImpl.h:
* Source/WebKit/chromium/src/WebPopupMenuImpl.h:
* Source/WebKit/chromium/src/WebViewImpl.cpp:
* Source/WebKit/chromium/src/WebViewImpl.h:
* Source/WebKit/chromium/tests/PopupMenuTest.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83320
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Fri, 8 Apr 2011 18:47:55 +0000 (18:47 +0000)]
2011-04-08 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Fix the WebKit2 build for older versions of GTK+
https://bugs.webkit.org/show_bug.cgi?id=58095
No new tests. This is just a build fix.
* platform/gtk/GtkVersioning.c:
(gdk_window_create_similar_surface): Reimplement this method for older versions of GDK.
* platform/gtk/GtkVersioning.h: Add the new method to the header.
2011-04-08 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Fix the WebKit2 build for older versions of GTK+
https://bugs.webkit.org/show_bug.cgi?id=58095
* UIProcess/gtk/ChunkedUpdateDrawingAreaProxyGtk.cpp: Include the GtkVersioning.h header.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83319
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jianli@chromium.org [Fri, 8 Apr 2011 18:40:45 +0000 (18:40 +0000)]
Unreviewed, fixed a typo in chromium test expectation list.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83318
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jianli@chromium.org [Fri, 8 Apr 2011 18:19:49 +0000 (18:19 +0000)]
Unreviewed, added one more failed test to test expectation list in chromium.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83317
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 8 Apr 2011 17:58:45 +0000 (17:58 +0000)]
2011-04-08 Misha Tyutyunik <michael.tyutyunik@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Plugin is not scrolled together with page content or jumping
when content is rendered using cache (backing store).
https://bugs.webkit.org/show_bug.cgi?id=56130
This is a Symbian portion of the fix. For Linux it looks like
it's enough to call set geometry which should be addressed in
https://bugs.webkit.org/show_bug.cgi?id=57179
No new tests required. This can be tested with manual tests from
WebCore/manual-tests/qt and WebCore/manual-tests/plugins
* plugins/symbian/PluginViewSymbian.cpp:
(WebCore::PluginView::updatePluginWidget):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83316
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jianli@chromium.org [Fri, 8 Apr 2011 17:50:01 +0000 (17:50 +0000)]
Unreviewed, added failed tests to test expectation list in chromium.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83314
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Fri, 8 Apr 2011 17:44:31 +0000 (17:44 +0000)]
2011-04-08 Abhishek Arya <inferno@chromium.org>
Unreviewed. Remove accidental printf added in r83306.
* page/EventHandler.cpp:
(WebCore::EventHandler::sendContextMenuEvent):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83312
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 8 Apr 2011 17:43:13 +0000 (17:43 +0000)]
2011-04-08 Pere Martir <pere.martir4@gmail.com>
Reviewed by Adam Roben.
Locate NSTD.EXE in 64-bit Windows
https://bugs.webkit.org/show_bug.cgi?id=57847
* Scripts/old-run-webkit-tests:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83310
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enrica@apple.com [Fri, 8 Apr 2011 17:36:43 +0000 (17:36 +0000)]
Dragging text in a WebKit2 window results in a copy instead of a move.
https://bugs.webkit.org/show_bug.cgi?id=56772
<rdar://problem/
9165140>
Reviewed by Darin Adler.
cleanupAfterSystemDrag cannot call dragEnd in WebKit2, since
the call to startDrag is asynchronous.
* page/mac/DragControllerMac.mm:
(WebCore::DragController::cleanupAfterSystemDrag):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83308
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Fri, 8 Apr 2011 17:05:11 +0000 (17:05 +0000)]
2011-04-07 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[WK2][Qt][GTK] Introduce common use flag for the shared UNIX domain socket IPC implementation
https://bugs.webkit.org/show_bug.cgi?id=58030
* wtf/Platform.h: Introduce USE(UNIX_DOMAIN_SOCKETS) for WebKit2.
2011-04-07 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[WK2][Qt][GTK] Introduce common use flag for the shared UNIX domain socket IPC implementation
https://bugs.webkit.org/show_bug.cgi?id=58030
Replace "PLATFORM(QT) || PLATFORM(GTK)" conditions in IPC code with
USE(UNIX_DOMAIN_SOCKETS).
* Platform/CoreIPC/Attachment.h:
* Platform/CoreIPC/Connection.h:
* Platform/SharedMemory.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83307
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 8 Apr 2011 16:59:54 +0000 (16:59 +0000)]
2011-04-07 Anders Carlsson <andersca@apple.com>
Reviewed by Simon Fraser.
Clicks not recognized on http://www.nibblestutorials.net/ which uses Silverlight
https://bugs.webkit.org/show_bug.cgi?id=58108
<rdar://problem/
9167611>
Change platformHandleMouseEvent to return true, which means that the plug-in has handled the
event. Some plug-ins (like Silverlight) will return false from NPP_HandleEvent even though the
event has been handled. In this case it lead to a very subtle bug where the plug-in element would
lose focus right after a mouse down even had been sent.
* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::platformHandleMouseEvent):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83306
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 8 Apr 2011 16:49:50 +0000 (16:49 +0000)]
2011-04-08 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r83295.
http://trac.webkit.org/changeset/83295
https://bugs.webkit.org/show_bug.cgi?id=58144
Broke 4 tests in QtWebKit (Requested by tonikitoo on #webkit).
* platform/qt/Skipped:
2011-04-08 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r83295.
http://trac.webkit.org/changeset/83295
https://bugs.webkit.org/show_bug.cgi?id=58144
Broke 4 tests in QtWebKit (Requested by tonikitoo on #webkit).
* WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::handleInputMethodKeydown):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83305
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sergio@webkit.org [Fri, 8 Apr 2011 16:10:25 +0000 (16:10 +0000)]
2011-04-08 Sergio Villar Senin <svillar@igalia.com>
Unreviewed, looks like the test is working fine now.
[GTK] websocket/tests/bad-sub-protocol-control-chars.html fails on 32-bit Debug bot
https://bugs.webkit.org/show_bug.cgi?id=46942
* platform/gtk/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83303
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 8 Apr 2011 16:06:23 +0000 (16:06 +0000)]
Qt build fix
* DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Pull in stdarg.h for va_list.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83302
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 8 Apr 2011 16:03:35 +0000 (16:03 +0000)]
2011-04-08 Jon Lee <jonlee@apple.com>
Reviewed by David Levin.
adding *.vcproj.*.user to .gitignore for Visual Studio development
https://bugs.webkit.org/show_bug.cgi?id=58097
* .gitignore:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83301
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 8 Apr 2011 16:00:38 +0000 (16:00 +0000)]
Pass NPP_SetWindow a null window handle during plugin destruction on non-Mac platforms
This matches WebKit1.
Fixes <http://webkit.org/b/47009> WebKit2 needs to call NPP_SetWindow when destroying a
plugin
Reviewed by Anders Carlsson.
Source/WebKit2:
* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::destroy): Null out our NPWindow's window handle and pass it to
NPP_SetWindow (unless we're on Mac).
Tools:
Test that NPP_SetWindow is passed a null window handle during plugin destruction on non-Mac platforms
* DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
(pluginLogWithArguments): Moved code to format and log the message here...
(pluginLog): ...from here.
* DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Added pluginLogWithArguments.
* DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
(PluginTest::log): Added. Calls through to pluginLogWithArguments.
* DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added log.
* DumpRenderTree/TestNetscapePlugIn/Tests/NPPSetWindowCalledDuringDestruction.cpp: Added.
(NPPSetWindowCalledDuringDestruction::setWillBeDestroyed): Records that destruction is about
to begin.
(NPPSetWindowCalledDuringDestruction::NPPSetWindowCalledDuringDestruction): Simple
constructor.
(NPPSetWindowCalledDuringDestruction::NPP_GetValue): Creates and returns a ScriptObject that
can be used to invoke our setWillBeDestroyed function.
(NPPSetWindowCalledDuringDestruction::NPP_SetWindow): Records what has happened (and logs if
anything unexpected happens).
(NPPSetWindowCalledDuringDestruction::NPP_Destroy): On Mac, logs a failure message if
NPP_SetWindow was called during destruction. On other platforms, logs a failure message if
NPP_SetWindow was *not* called during destruction.
(NPPSetWindowCalledDuringDestruction::ScriptObject::hasMethod): Return true for our only
method, setWillBeDestroyed.
(NPPSetWindowCalledDuringDestruction::ScriptObject::invoke): Call through to the PluginTest
object.
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
* DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
* GNUmakefile.am:
Added new test.
* Scripts/old-run-webkit-tests: Skip the new test when using out-of-process plugins with
WebKit1 on Mac, since it can't work properly due to <http://webkit.org/b/58077>.
LayoutTests:
Test that NPP_SetWindow is passed a null window handle during plugin destruction on non-Mac platforms
* platform/win-wk2/Skipped: Removed a test that no longer crashes thanks to this fix.
* plugins/npp-set-window-called-during-destruction-expected.txt: Added.
* plugins/npp-set-window-called-during-destruction.html: Added.
* platform/mac/plugins/npp-set-window-called-during-destruction-expected.txt: Added. This is
different from the cross-platform results because we don't expect NPP_SetWindow to be called
during destruction.
* platform/win/plugins/npp-set-window-called-during-destruction-expected.txt: Added. This is
a copy of the cross-platform results, needed to override the Mac-specific results.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83300
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 8 Apr 2011 15:56:14 +0000 (15:56 +0000)]
Clean build fix
* JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd: Don't try to delete directories that
don't exist. Also switched from del /s to rmdir /s, which has the benefit of deleting the
directory itself in addition to the files it contains.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83299
268f45cc-cd09-0410-ab3c-
d52691b4dbfc