WebKit.git
3 years agoUnreviewed, fix the internal iOS 11 build
wenson_hsieh@apple.com [Thu, 6 Jul 2017 23:59:08 +0000 (23:59 +0000)]
Unreviewed, fix the internal iOS 11 build

It turns out, our internal bots are still on an older version of the iOS 11 SDK that's missing _UIDataOwner in
<UIKit/NSItemProvider+UIKitAdditions_Private.h>. To ensure that we can build on both current and slightly older
versions of the iOS 11 SDK, fall back to using NSInteger instead of _UIDataOwner.

* Platform/spi/ios/UIKitSPI.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _dragInteraction:dataOwnerForSession:]):
(-[WKContentView _dropInteraction:dataOwnerForSession:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[iOS DnD] [WK2] Add delegate hooks for specifying the data owner for a drag or drop...
wenson_hsieh@apple.com [Thu, 6 Jul 2017 23:30:10 +0000 (23:30 +0000)]
[iOS DnD] [WK2] Add delegate hooks for specifying the data owner for a drag or drop session
https://bugs.webkit.org/show_bug.cgi?id=174139
<rdar://problem/33126212>

Reviewed by Beth Dakin.

Add hooks to query the UI delegate for a _UIDataOwner on both drag and drop sides.

* Platform/spi/ios/UIKitSPI.h:
* UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _dragInteraction:dataOwnerForSession:]):
(-[WKContentView _dropInteraction:dataOwnerForSession:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[Cocoa] Improve performance of font lookups
mmaxfield@apple.com [Thu, 6 Jul 2017 23:04:18 +0000 (23:04 +0000)]
[Cocoa] Improve performance of font lookups
https://bugs.webkit.org/show_bug.cgi?id=173960
<rdar://problem/31996891>

Reviewed by Darin Adler.

PerformanceTests:

* Layout/font-fallback-font-family.html: Added.
* Layout/resources/font-fallback-font-family.html: Added.

Source/WebCore:

Looking up kCTFontPostScriptNameAttribute is faster than kCTFontNameAttribute.

No new tests because there is no behavior change.

* platform/spi/cocoa/CoreTextSPI.h:
* platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::FontDatabase::fontForPostScriptName):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUpdate help text.
lforschler@apple.com [Thu, 6 Jul 2017 22:50:30 +0000 (22:50 +0000)]
Update help text.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoREGRESSION(r216944): Font loads can cause Chinese characters to draw as .notdef
mmaxfield@apple.com [Thu, 6 Jul 2017 22:09:11 +0000 (22:09 +0000)]
REGRESSION(r216944): Font loads can cause Chinese characters to draw as .notdef
https://bugs.webkit.org/show_bug.cgi?id=173962
<rdar://problem/32925318>

Reviewed by Simon Fraser.

Source/WebCore:

Previously, there was no signalling between our font loading code
which determined whether or not a font should be invisible (because
its in the middle of loading) and our system fallback code which
created fonts when we fall off the end of the fallback list. Because
of this, we were doing two things wrong:

1. When we started downloading a font, we would try to use a fallback
font. However, if the fallback font didn't suppor the character we're
trying to render, we would just bail and draw .notdef
2. Even if we continued down the fallback list, and fell of the end,
we wouldn't realize that the system fallback font should also be drawn
as invisible.

This patch solves these two problems by:
1. Performing a search to find the best (local) fallback font with
which to fall systemFallbackFontForCharacter(). This way, if you say
"font-family: 'RemoteFont', 'Helvetica'" we will use Helvetica as
the lookup to ask the system to search for.
2. Give the Font class an accessor which can create a duplicate, but
invisible font. Give FontCascadeFonts::glyphDataForVariant() the
correct tracking to know when to use this invisible duplicate.

Tests: fast/text/font-loading-system-fallback.html
       http/tests/webfont/font-loading-system-fallback-visibility.html

* platform/graphics/Font.cpp:
(WebCore::Font::invisibleFont):
* platform/graphics/Font.h:
* platform/graphics/FontCascadeFonts.cpp:
(WebCore::findBestFallbackFont):
(WebCore::FontCascadeFonts::glyphDataForSystemFallback):
(WebCore::FontCascadeFonts::glyphDataForVariant):
* platform/graphics/FontCascadeFonts.h:

LayoutTests:

* fast/text/font-loading-system-fallback-expected.html: Added.
* fast/text/font-loading-system-fallback.html: Added.
* http/tests/webfont/font-loading-system-fallback-visibility-expected.html: Added.
* http/tests/webfont/font-loading-system-fallback-visibility.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[WK2] ResourceLoadStatistics should batch its writes
bfulgham@apple.com [Thu, 6 Jul 2017 21:59:33 +0000 (21:59 +0000)]
[WK2] ResourceLoadStatistics should batch its writes
https://bugs.webkit.org/show_bug.cgi?id=174111
<rdar://problem/33115894>

Reviewed by Chris Dumez.

Revise the data writing operation to only write on a specific interval (currently
set to 5 minutes).

Also make 'writeStoreToDisk' simpler to use by moving the deleting (before write) and
creating (after write) of the FileMonitor into the method, rather than requiring this
knowledge in multiple places.

Make sure that we write our statistics file out before exiting so that we do not
lose any data if we exit before the five-minute window has elapsed.

* UIProcess/Storage/ResourceLoadStatisticsStore.cpp:
(WebKit::ResourceLoadStatisticsStore::setWritePersistentStoreCallback): Deleted.
* UIProcess/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::processStatisticsAndDataRecords): Remove the stop
and start monitoring into 'writeStoreToDisk'. Also check if enough time has elapsed since
the last write to commit to disk.
(WebKit::WebResourceLoadStatisticsStore::registerSharedResourceLoadObserver): Remove the
stop and start monitoring into 'writeStoreToDisk'.
(WebKit::WebResourceLoadStatisticsStore::writeStoreToDisk): Add the stop and start monitoring
commands here, so callers don't have to know to do so.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoFileMonitor should not be ref counted
cdumez@apple.com [Thu, 6 Jul 2017 21:45:04 +0000 (21:45 +0000)]
FileMonitor should not be ref counted
https://bugs.webkit.org/show_bug.cgi?id=174166

Reviewed by Brent Fulgham.

Source/WebCore:

Update FileMonitor to no longer be refcounted. It was previously easy to leak it
because the object would ref itself in various lambdas. The client would have to
explicitely call FileMonitor::stopMonitoring() which was fragile.

This patch also simplifies the code and API a bit since no longer actually
requires startMonitoring() / stopMonitoring() API.

No new tests, covered by API tests.

* platform/FileMonitor.cpp:
(WebCore::FileMonitor::FileMonitor):
(WebCore::FileMonitor::~FileMonitor):
(WebCore::FileMonitor::create): Deleted.
(WebCore::FileMonitor::startMonitoring): Deleted.
(WebCore::FileMonitor::stopMonitoring): Deleted.
* platform/FileMonitor.h:
* platform/cocoa/FileMonitorCocoa.mm:
(WebCore::FileMonitor::FileMonitor):
(WebCore::FileMonitor::~FileMonitor):
(WebCore::FileMonitor::startMonitoring): Deleted.
(WebCore::FileMonitor::stopMonitoring): Deleted.

Source/WebKit2:

Update code using FileMonitor to reflect API change.

* UIProcess/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::startMonitoringStatisticsStorage):
(WebKit::WebResourceLoadStatisticsStore::stopMonitoringStatisticsStorage):
* UIProcess/WebResourceLoadStatisticsStore.h:

Tools:

Update the API tests to reflect the API change.

* TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
(TestWebKitAPI::TEST_F):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoFix build with VIDEO support disabled.
mrajca@apple.com [Thu, 6 Jul 2017 21:22:48 +0000 (21:22 +0000)]
Fix build with VIDEO support disabled.
https://bugs.webkit.org/show_bug.cgi?id=174217

Unreviewed build fix.

Source/WebCore:

* page/Page.cpp:

Source/WebKit2:

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updateWebsitePolicies):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed, rolling out r219193.
jlewis3@apple.com [Thu, 6 Jul 2017 21:20:18 +0000 (21:20 +0000)]
Unreviewed, rolling out r219193.

The tests added with this revision were extreamly flaky on all
platforms.

Reverted changeset:

"[SVG] Leak in SVGAnimatedListPropertyTearOff"
https://bugs.webkit.org/show_bug.cgi?id=172545
http://trac.webkit.org/changeset/219193

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUse WTFLogAlways for debug logging so that it shows up in device system logs
zalan@apple.com [Thu, 6 Jul 2017 21:13:24 +0000 (21:13 +0000)]
Use WTFLogAlways for debug logging so that it shows up in device system logs
https://bugs.webkit.org/show_bug.cgi?id=173450

Reviewed by Simon Fraser.

If you want to showRenderTree() on-device, the result doesn't show in system log so you can't see it.
Switch to WTFLogAlways to fix this, for showRenderTree and its dependencies.

* platform/text/TextStream.cpp:
(WebCore::writeIndent):
* rendering/InlineBox.cpp:
(WebCore::InlineBox::showLineTreeAndMark):
(WebCore::InlineBox::showLineBox):
* rendering/InlineBox.h:
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::showLineTreeAndMark):
* rendering/InlineFlowBox.h:
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::showLineBox):
* rendering/InlineTextBox.h:
* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::showLineTreeAndMark):
* rendering/RenderBlockFlow.h:
* rendering/RenderObject.cpp:
(WebCore::showRenderTreeLegend):
(WebCore::RenderObject::showRenderTreeForThis):
(WebCore::RenderObject::showLineTreeForThis):
(WebCore::RenderObject::showRegionsInformation):
(WebCore::RenderObject::showRenderObject):
(WebCore::RenderObject::showRenderSubTreeAndMark):
* rendering/RenderObject.h:
* rendering/SimpleLineLayoutFunctions.cpp:
(WebCore::SimpleLineLayout::printPrefix):
(WebCore::SimpleLineLayout::showLineLayoutForFlow):
* rendering/SimpleLineLayoutFunctions.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnify FontCascadeFonts::glyphDataForVariant() and FontCascadeFonts::glyphDataForNorma...
mmaxfield@apple.com [Thu, 6 Jul 2017 21:07:19 +0000 (21:07 +0000)]
Unify FontCascadeFonts::glyphDataForVariant() and FontCascadeFonts::glyphDataForNormalVariant()
https://bugs.webkit.org/show_bug.cgi?id=174213

Reviewed by Zalan Bujtas.

They have almost identical code. This is in preparation for https://bugs.webkit.org/show_bug.cgi?id=173962

No new tests because there is no behavior change.

* platform/graphics/FontCascadeFonts.cpp:
(WebCore::FontCascadeFonts::glyphDataForVariant):
(WebCore::FontCascadeFonts::glyphDataForCharacter):
(WebCore::FontCascadeFonts::glyphDataForNormalVariant): Deleted.
* platform/graphics/FontCascadeFonts.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoWeb Inspector: Highlight matching canvas element when hovering contexts in the Resour...
drousso@apple.com [Thu, 6 Jul 2017 20:51:20 +0000 (20:51 +0000)]
Web Inspector: Highlight matching canvas element when hovering contexts in the Resources tab
https://bugs.webkit.org/show_bug.cgi?id=174209

Reviewed by Joseph Pecoraro.

* UserInterface/Views/CanvasTreeElement.js:
(WebInspector.CanvasTreeElement.prototype.onattach):
(WebInspector.CanvasTreeElement.prototype._handleMouseOver):
(WebInspector.CanvasTreeElement.prototype._handleMouseOut):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[PAL] Move KillRing into PAL
don.olmstead@sony.com [Thu, 6 Jul 2017 20:23:27 +0000 (20:23 +0000)]
[PAL] Move KillRing into PAL
https://bugs.webkit.org/show_bug.cgi?id=173900

Reviewed by Myles C. Maxfield.

No new tests. No change in functionality.

Source/WebCore:

* Configurations/WebCore.xcconfig:
* PlatformGTK.cmake:
* PlatformMac.cmake:
* PlatformWPE.cmake:
* PlatformWin.cmake:
* WebCore.xcodeproj/project.pbxproj:
* editing/Editor.cpp:
(WebCore::Editor::Editor):
* editing/Editor.h:
(WebCore::Editor::killRing):
* editing/EditorCommand.cpp:

Source/WebCore/PAL:

* Configurations/PAL.xcconfig:
* PAL.xcodeproj/project.pbxproj:
* pal/CMakeLists.txt:
* pal/PlatformGTK.cmake:
* pal/PlatformMac.cmake:
* pal/PlatformWPE.cmake:
* pal/PlatformWin.cmake:
* pal/text/KillRing.h: Renamed from Source/WebCore/platform/KillRing.h.
* pal/text/KillRingNone.cpp: Renamed from Source/WebCore/platform/KillRingNone.cpp.
* pal/text/mac/KillRingMac.mm: Renamed from Source/WebCore/platform/mac/KillRingMac.mm.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoMarked js/slow-stress/Int32Array-alloc-huge.html as flaky.
jlewis3@apple.com [Thu, 6 Jul 2017 20:03:14 +0000 (20:03 +0000)]
Marked js/slow-stress/Int32Array-alloc-huge.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=173010

Unreviewed test gardening.

* platform/ios-simulator-wk2/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoCrash under WebResourceLoadStatisticsStore::persistentStoragePath(WTF::String const&)
cdumez@apple.com [Thu, 6 Jul 2017 19:22:36 +0000 (19:22 +0000)]
Crash under WebResourceLoadStatisticsStore::persistentStoragePath(WTF::String const&)
https://bugs.webkit.org/show_bug.cgi?id=174205
<rdar://problem/33093552>

Reviewed by Brent Fulgham.

Make sure we isolateCopy() m_statisticsStoragePath before using it from the background
thread.

* UIProcess/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::readDataFromDiskIfNeeded):
(WebKit::WebResourceLoadStatisticsStore::refreshFromDisk):
(WebKit::WebResourceLoadStatisticsStore::resourceLogFilePath):
(WebKit::WebResourceLoadStatisticsStore::statisticsFilePath):
(WebKit::WebResourceLoadStatisticsStore::writeStoreToDisk):
(WebKit::WebResourceLoadStatisticsStore::writeEncoderToDisk):
(WebKit::WebResourceLoadStatisticsStore::deleteStoreFromDisk):
(WebKit::WebResourceLoadStatisticsStore::startMonitoringStatisticsStorage):
(WebKit::WebResourceLoadStatisticsStore::syncWithExistingStatisticsStorageIfNeeded):
(WebKit::WebResourceLoadStatisticsStore::persistentStoragePath): Deleted.
* UIProcess/WebResourceLoadStatisticsStore.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoFix CFURLRequestRef serialization after r207330
achristensen@apple.com [Thu, 6 Jul 2017 18:50:47 +0000 (18:50 +0000)]
Fix CFURLRequestRef serialization after r207330
https://bugs.webkit.org/show_bug.cgi?id=163332

* Shared/mac/WebCoreArgumentCodersMac.mm:
(IPC::ArgumentCoder<ResourceRequest>::encodePlatformData):
The CFURLConnection code was not updated.
We did not catch this because nobody uses the WebKit2 CFURLConnection code, but I need to use it to debug something.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoWe are missing places where we invalidate the for-in context
sbarati@apple.com [Thu, 6 Jul 2017 18:43:41 +0000 (18:43 +0000)]
We are missing places where we invalidate the for-in context
https://bugs.webkit.org/show_bug.cgi?id=174184

Reviewed by Geoffrey Garen.

JSTests:

* stress/for-in-invalidate-context-weird-assignments.js: Added.
(assert):
(test):

Source/JavaScriptCore:

* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::invalidateForInContextForLocal):
* bytecompiler/NodesCodegen.cpp:
(JSC::EmptyLetExpression::emitBytecode):
(JSC::ForInNode::emitLoopHeader):
(JSC::ForOfNode::emitBytecode):
(JSC::BindingNode::bindValue):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoWeb Inspector: Support getting the content of WebGL/WebGL2 contexts
drousso@apple.com [Thu, 6 Jul 2017 18:35:58 +0000 (18:35 +0000)]
Web Inspector: Support getting the content of WebGL/WebGL2 contexts
https://bugs.webkit.org/show_bug.cgi?id=173569
<rdar://problem/33112420>

Reviewed by Joseph Pecoraro.

Source/WebCore:

Tests: inspector/canvas/requestContent-2d.html
       inspector/canvas/requestContent-webgl.html
       inspector/canvas/requestContent-webgl2.html

* html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::clearIfComposited):
* html/canvas/WebGLRenderingContextBase.h:
(WebCore::WebGLRenderingContextBase::preventBufferClearForInspector):
(WebCore::WebGLRenderingContextBase::setPreventBufferClearForInspector):
Add a flag that will prevent the context buffer from being cleared, allowing it to be copied
within a toDataURL call. This is currently only used by InspectorCanvasAgent::requestContent.

* inspector/InspectorCanvasAgent.cpp:
(WebCore::InspectorCanvasAgent::requestContent):
Since toDataURL attempts to force the canvas to redraw, we can preserve the buffer after it
finishes drawing so that it can be copied, instead of it normally being swapped out.

LayoutTests:

* inspector/canvas/requestContent-2d-expected.txt: Added.
* inspector/canvas/requestContent-2d.html: Added.
* inspector/canvas/requestContent-webgl-expected.txt: Added.
* inspector/canvas/requestContent-webgl.html: Added.
* inspector/canvas/requestContent-webgl2-expected.txt: Added.
* inspector/canvas/requestContent-webgl2.html: Added.
* inspector/canvas/requestContent-expected.txt: Removed.
* inspector/canvas/requestContent.html: Removed.
* platform/gtk/TestExpectations:
* platform/win/TestExpectations:
Split the existing canvas content tests into one for each context type. This allows
platforms that don't support certain context types to ignore just those tests (e.g. WebGL2).

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoMove ResourceLoadObserver notification throttling logic from WebProcess class to...
cdumez@apple.com [Thu, 6 Jul 2017 18:28:40 +0000 (18:28 +0000)]
Move ResourceLoadObserver notification throttling logic from WebProcess class to ResourceLoadObserver
https://bugs.webkit.org/show_bug.cgi?id=174194

Reviewed by Brent Fulgham.

Move ResourceLoadObserver notification throttling logic from WebProcess class to
ResourceLoadObserver. This makes more sense and decreases the complexity of the
WebProcess class.

Source/WebCore:

* loader/ResourceLoadObserver.cpp:
(WebCore::ResourceLoadObserver::setNotificationCallback):
(WebCore::ResourceLoadObserver::ResourceLoadObserver):
(WebCore::ResourceLoadObserver::logFrameNavigation):
(WebCore::ResourceLoadObserver::logSubresourceLoading):
(WebCore::ResourceLoadObserver::logWebSocketLoading):
(WebCore::ResourceLoadObserver::logUserInteractionWithReducedTimeResolution):
(WebCore::ResourceLoadObserver::scheduleNotificationIfNeeded):
(WebCore::ResourceLoadObserver::notificationTimerFired):
* loader/ResourceLoadObserver.h:

Source/WebKit2:

* WebProcess/WebProcess.cpp:
(WebKit::m_webSQLiteDatabaseTracker):
(WebKit::WebProcess::statisticsChangedTimerFired): Deleted.
* WebProcess/WebProcess.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[GTK] Layout test gardening.
clopez@igalia.com [Thu, 6 Jul 2017 18:24:12 +0000 (18:24 +0000)]
[GTK] Layout test gardening.

Unreviewed.

* platform/gtk/TestExpectations: Update WebRTC related expectations and mark a new emoji related test failing after r218371.
* platform/gtk/fast/css/css2-system-fonts-expected.txt: Rebaseline after r218446.
* platform/gtk/fast/css/getComputedStyle/computed-style-font-family-expected.txt: Removed. Rebaseline after r218446 (use the general expectation).
* platform/gtk/fast/text/font-stretch-parse-expected.txt: Removed. Rebaseline after r218446 (use the general expectation).
* platform/gtk/fast/text/font-style-parse-expected.txt: Removed. Rebaseline after r218446 (use the general expectation).
* platform/gtk/fast/text/font-weight-parse-expected.txt: Removed Rebaseline after r218446 (use the general expectation).

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoREGRESSION(r208511): RenderImageResourceStyleImage should not assume image() won...
commit-queue@webkit.org [Thu, 6 Jul 2017 18:22:44 +0000 (18:22 +0000)]
REGRESSION(r208511): RenderImageResourceStyleImage should not assume image() won't return null if its m_cachedImage is valid
https://bugs.webkit.org/show_bug.cgi?id=174168

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-07-06
Reviewed by Simon Fraser.

RenderImageResourceStyleImage::image() may return a null pointer even if
its m_cachedImage is not null. The revision r208511, changed the function
RenderImageResourceStyleImage::shutdown() so it calls Image::stopAnimation().
But this change assumes that if m_cachedImage is not null then image() will
return a valid pointer. This is not true because StyleCachedImage::isPending()
can return true and hence, RenderImageResourceStyleImage::image() will return
a null pointer.

* rendering/RenderImageResourceStyleImage.cpp:
(WebCore::RenderImageResourceStyleImage::image): Like what RenderImageResource
does, return Image::nullImage() if m_styleImage->isPending().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed, rolling out r219201.
commit-queue@webkit.org [Thu, 6 Jul 2017 18:10:21 +0000 (18:10 +0000)]
Unreviewed, rolling out r219201.
https://bugs.webkit.org/show_bug.cgi?id=174211

"Causes crashes on Release builds and API tests" (Requested by
ddkilzer on #webkit).

Reverted changeset:

"Add release assert to explore crash for
<rdar://problem/32908525>"
http://trac.webkit.org/changeset/219201

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoWebResourceLoadStatisticsStore should only be constructed when the feature is enabled
cdumez@apple.com [Thu, 6 Jul 2017 17:23:07 +0000 (17:23 +0000)]
WebResourceLoadStatisticsStore should only be constructed when the feature is enabled
https://bugs.webkit.org/show_bug.cgi?id=174189

Reviewed by Brent Fulgham.

Delay the construction of the WebResourceLoadStatisticsStore until the feature gets
enabled via WebsiteDataStore::setResourceLoadStatisticsEnabled(). Previously, we would
always construct a store and then have a boolean on the store to indicate if it is
enabled or not.

Also simplify the initialization process of the WebResourceLoadStatisticsStore, we
used to have:
1. WebResourceLoadStatisticsStore constructor
2. WebResourceLoadStatisticsStore::registerSharedResourceLoadObserver()
3. WebResourceLoadStatisticsStore::setResourceLoadStatisticsEnabled(true)

All 3 steps are now taken care of by the WebResourceLoadStatisticsStore constructor.

* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitialize):
* UIProcess/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::WebResourceLoadStatisticsStore):
(WebKit::WebResourceLoadStatisticsStore::readDataFromDiskIfNeeded):
* UIProcess/WebResourceLoadStatisticsStore.h:
* UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::WebsiteDataStore::platformInitialize):
* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::WebsiteDataStore):
(WebKit::WebsiteDataStore::resourceLoadStatisticsEnabled):
(WebKit::WebsiteDataStore::setResourceLoadStatisticsEnabled):
* UIProcess/WebsiteData/WebsiteDataStore.h:
(WebKit::WebsiteDataStore::resourceLoadStatistics):
* UIProcess/wpe/WebProcessPoolWPE.cpp:
(WebKit::WebProcessPool::platformInitialize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed, rolling out r219194.
commit-queue@webkit.org [Thu, 6 Jul 2017 17:12:54 +0000 (17:12 +0000)]
Unreviewed, rolling out r219194.
https://bugs.webkit.org/show_bug.cgi?id=174207

it broke some layout tests (Requested by clopez on #webkit).

Reverted changeset:

"[GStreamer] vid.me videos do not play"
https://bugs.webkit.org/show_bug.cgi?id=172240
http://trac.webkit.org/changeset/219194

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoAdd release assert to explore crash for <rdar://problem/32908525>
ddkilzer@apple.com [Thu, 6 Jul 2017 16:49:16 +0000 (16:49 +0000)]
Add release assert to explore crash for <rdar://problem/32908525>

Reviewed by Brady Eidson.

* Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::~UniqueIDBDatabase): Add
release assert to catch cases when the IDBBackingStore is not
deleted before the UniqueIDBDatabase is destroyed.  The
IDBBackingStore should always be released on the database
thread.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoAdd logging to first attempt to use the WebIconDatabase class.
beidson@apple.com [Thu, 6 Jul 2017 16:31:34 +0000 (16:31 +0000)]
Add logging to first attempt to use the WebIconDatabase class.
https://bugs.webkit.org/show_bug.cgi?id=174190

Reviewed by Andy Estes.

* Misc/WebIconDatabase.mm:
(+[WebIconDatabase sharedIconDatabase]): On first call, log a warning of the bleak future of this non-API.
* Misc/WebKitVersionChecks.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed, rolling out r219178.
jlewis3@apple.com [Thu, 6 Jul 2017 16:22:41 +0000 (16:22 +0000)]
Unreviewed, rolling out r219178.

This caused a consistent failure with the API test
StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.

Reverted changeset:

"[WTF] Clean up StringStatics.cpp by using
LazyNeverDestroyed<> for Atoms"
https://bugs.webkit.org/show_bug.cgi?id=174150
http://trac.webkit.org/changeset/219178

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoWeb Inspector: Add another Protocol Version
commit-queue@webkit.org [Thu, 6 Jul 2017 16:00:47 +0000 (16:00 +0000)]
Web Inspector: Add another Protocol Version
https://bugs.webkit.org/show_bug.cgi?id=174193
<rdar://problem/33150053>

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2017-07-06
Reviewed by Brian Burg.

* UserInterface/Protocol/Legacy/11.0/InspectorBackendCommands.js: Added.
* Versions/Inspector-iOS-11.0.json: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoAdd CWD to Perl library path (no longer the default since 5.26.0)
commit-queue@webkit.org [Thu, 6 Jul 2017 15:37:43 +0000 (15:37 +0000)]
Add CWD to Perl library path (no longer the default since 5.26.0)
https://bugs.webkit.org/show_bug.cgi?id=174200

Patch by Alicia Boya García <aboya@igalia.com> on 2017-07-06
Reviewed by Michael Catanzaro.

* Scripts/webkitpy/tool/commands/setupgitclone.py:
(SetupGitClone._get_username_and_email):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed, update my email address.
gyuyoung.kim@webkit.org [Thu, 6 Jul 2017 14:45:17 +0000 (14:45 +0000)]
Unreviewed, update my email address.

Patch by Gyuyoung Kim <gyuyoung.kim@webkit.org> on 2017-07-06

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[GTK] It should process MouseMoved events when the parent window is not active
csaavedra@igalia.com [Thu, 6 Jul 2017 13:35:02 +0000 (13:35 +0000)]
[GTK] It should process MouseMoved events when the parent window is not active
https://bugs.webkit.org/show_bug.cgi?id=116691

Reviewed by Michael Catanzaro.

From reading the comments in the related code, only in Safari it
is desired that MouseMoved events are not processed when the
parent window is not active. In other ports, in particular those
targeting Linux, these events should be processed for consistency
with other browsers.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setCursor):
* UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::setCursor):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::handleMouseEvent):
(WebKit::WebPage::mouseEvent):  No need to always pass a boolean
parameter that is only checked for one type of event. Do the check
internally in handleMouseEvent() only when needed and only in Cocoa.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[GStreamer] vid.me videos do not play
commit-queue@webkit.org [Thu, 6 Jul 2017 10:12:49 +0000 (10:12 +0000)]
[GStreamer] vid.me videos do not play
https://bugs.webkit.org/show_bug.cgi?id=172240

Patch by Charlie Turner <cturner@igalia.com> on 2017-07-06
Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

In r142251, code to hide the WK HTTP source elements from elsewhere in
the pipeline was removed. This has the nasty side-effect of
auto-plugging the WK HTTP source into things it really should not be
used in, especially the adaptive streaming demuxers. The reasons this
is bad are documented in several places on Bugzilla, see the parent
bug report for more details. The high-level issue is that the WK HTTP
source and its use of WebCore is not thread-safe. Although work has
been recently done to improve this situation, it's still not perfect.

Another issue is the interface hlsdemux expects its HTTP source to
implement, specifically seeking in READY.

This does rely on HTTP context sharing being available in GStreamer,
upstream bug is here:
https://bugzilla.gnome.org/show_bug.cgi?id=761099. The failing case
can be demonstrated with
https://github.com/thiagoss/adaptive-test-server but manual testing on
popular video hosting sites, including vid.me, shows that this doesn't
bite us at the moment, just something else to fix in the future.

There are some QoS issues with the adaptive streaming code in
GStreamer, but it seems much better to offer a below par QoS in lieu
of crashing/livelocking when playing certain streams, and issues can be
raised upstream when they arise.

This patch does take us further away from the future goal of having all
networking operations go through the network process, but in return it
solves some nasty crashes and livelocks that have been irritating
users for some time. With the pressure off on this issue, work can be
planned to consider how to make the WK HTTP source a better citizen
inside the GStreamer pipeline when we migrate the netcode to go
through the network process.

A new test is added to check that the single file HLS playlists
(new in version 4) can be played, which was the primary cause of
this bug report.

Test: http/tests/media/hls/range-request.html

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::setPlaybinURL): Perform
some trickery to make sure that we only ever fetch URLs handed to
us by WebCore. Any further URLs discovered inside the pipeline
will not get WKWS auto-plugged, since they'll be plain https?
schemas.
(WebCore::MediaPlayerPrivateGStreamer::load): Refactor to use the
setPlaybinURL helper method.
(WebCore::MediaPlayerPrivateGStreamer::loadNextLocation): Ditto.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: Add
the setPlaybinURL helper method.
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcGetProtocols): Only advertise webkit+https?, this
ensures we won't get auto-plugged by pipeline elements asking for
an element to fetch https? resources (like adaptive demuxers).
(convertPlaybinURI): Undo the trick when another element asks us
for our URI.

Tools:

Build httpsoupsrc again for use in adaptive streaming pipelines, and
have the existing libsoup build against GNOME to avoid header drift
against GStreamer's linked Soup library.

* gtk/jhbuild.modules:

LayoutTests:

Add a test for single output file HLS playlists that require HTTP
range requests to playback. This failed using the WK http source
for reasons documented in the linked bug.

Generated with mp4hls --segment-duration 3 --output-single-file

* Http/tests/media/hls/range-request-expected.txt: Added.
* http/tests/media/hls/range-request.html: Added.
* http/tests/media/resources/hls/range-request-playlist.m3u8: Added.
* http/tests/media/resources/hls/range-request-playlists/iframes.m3u8: Added.
* http/tests/media/resources/hls/range-request-playlists/media.ts: Added.
* http/tests/media/resources/hls/range-request-playlists/stream.m3u8: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[SVG] Leak in SVGAnimatedListPropertyTearOff
svillar@igalia.com [Thu, 6 Jul 2017 09:57:45 +0000 (09:57 +0000)]
[SVG] Leak in SVGAnimatedListPropertyTearOff
https://bugs.webkit.org/show_bug.cgi?id=172545

Reviewed by Said Abou-Hallawa.

SVGAnimatedListPropertyTearOff maintains a vector m_wrappers with references to
SVGPropertyTraits<PropertyType>::ListItemTearOff. Apart from that SVGPropertyTearOff has a
reference to SVGAnimatedProperty.

When SVGListProperty::getItemValuesAndWrappers() is called, it creates a
SVGPropertyTraits<PropertyType>::ListItemTearOff pointing to the same SVGAnimatedProperty (a
SVGAnimatedListPropertyTearOff) which stores the m_wrappers vector where the ListItemTearOff
is going to be added to. This effectively creates a reference cycle between the
SVGAnimatedListPropertyTearOff and all the ListItemTearOff it stores in m_wrappers.

We should detach those wrappers in propertyWillBeDeleted() in order to break the cycle.

* svg/properties/SVGAnimatedListPropertyTearOff.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed, suppress warnings in GCC environment
utatane.tea@gmail.com [Thu, 6 Jul 2017 09:07:01 +0000 (09:07 +0000)]
Unreviewed, suppress warnings in GCC environment

* dfg/DFGObjectAllocationSinkingPhase.cpp:
* runtime/IntlCollator.cpp:
* runtime/IntlDateTimeFormat.cpp:
* runtime/JSGlobalObject.cpp:
* runtime/StringPrototype.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[WTF] Move SoftLinking.h into WTF
don.olmstead@sony.com [Thu, 6 Jul 2017 05:51:32 +0000 (05:51 +0000)]
[WTF] Move SoftLinking.h into WTF
https://bugs.webkit.org/show_bug.cgi?id=174000

Reviewed by Alex Christensen.

Source/WebCore:

No new tests. No change in functionality

* Modules/applepay/PaymentRequest.cpp:
* Modules/applepay/cocoa/PaymentContactCocoa.mm:
* Modules/applepay/cocoa/PaymentMerchantSessionCocoa.mm:
* Modules/encryptedmedia/legacy/LegacyCDMPrivateMediaPlayer.cpp:
* WebCore.xcodeproj/project.pbxproj:
* editing/cocoa/EditorCocoa.mm:
* editing/cocoa/HTMLConverter.mm:
* editing/ios/EditorIOS.mm:
* page/CaptionUserPreferencesMediaAF.cpp:
* page/cocoa/SettingsCocoa.mm:
* page/ios/UserAgentIOS.mm:
* page/mac/ServicesOverlayController.mm:
* platform/audio/ios/AudioDestinationIOS.cpp:
* platform/audio/ios/AudioFileReaderIOS.cpp:
* platform/audio/ios/AudioSessionIOS.mm:
* platform/audio/ios/MediaSessionManagerIOS.mm:
* platform/cf/CoreMediaSoftLink.cpp:
* platform/cf/CoreMediaSoftLink.h:
* platform/cf/MediaAccessibilitySoftLink.cpp:
* platform/cf/MediaAccessibilitySoftLink.h:
* platform/cocoa/ContentFilterUnblockHandlerCocoa.mm:
* platform/cocoa/CoreVideoSoftLink.cpp:
* platform/cocoa/CoreVideoSoftLink.h:
* platform/cocoa/DataDetectorsCoreSoftLink.h:
* platform/cocoa/NetworkExtensionContentFilter.mm:
* platform/cocoa/ParentalControlsContentFilter.mm:
* platform/cocoa/TelephoneNumberDetectorCocoa.cpp:
* platform/cocoa/VideoToolboxSoftLink.cpp:
* platform/cocoa/VideoToolboxSoftLink.h:
* platform/cocoa/WebPlaybackSessionModelMediaElement.mm:
* platform/cocoa/WebVideoFullscreenModelVideoElement.mm:
* platform/gamepad/cocoa/GameControllerGamepadProvider.mm:
* platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm:
* platform/graphics/avfoundation/MediaPlaybackTargetMac.mm:
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
* platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.mm:
* platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h:
* platform/graphics/avfoundation/cf/CDMSessionAVFoundationCF.cpp:
* platform/graphics/avfoundation/cf/InbandTextTrackPrivateAVCF.cpp:
* platform/graphics/avfoundation/cf/InbandTextTrackPrivateLegacyAVCF.cpp:
* platform/graphics/avfoundation/cf/WebCoreAVCFResourceLoader.cpp:
* platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm:
* platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.mm:
* platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:
* platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:
* platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm:
* platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:
* platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm:
* platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
* platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:
* platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
* platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp:
* platform/graphics/cocoa/FontCascadeCocoa.mm:
* platform/graphics/cocoa/FontFamilySpecificationCoreText.cpp:
* platform/graphics/cv/PixelBufferConformerCV.cpp:
* platform/graphics/ios/FontCacheIOS.mm:
* platform/graphics/mac/ComplexTextControllerCoreText.mm:
* platform/graphics/mac/FontCacheMac.mm:
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
* platform/graphics/mac/MediaTimeQTKit.mm:
* platform/graphics/mac/PDFDocumentImageMac.mm:
* platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:
* platform/ios/DragImageIOS.mm:
* platform/ios/PlatformPasteboardIOS.mm:
* platform/ios/PlatformScreenIOS.mm:
* platform/ios/PlatformSpeechSynthesizerIOS.mm:
* platform/ios/QuickLookSoftLink.h:
* platform/ios/QuickLookSoftLink.mm:
* platform/ios/RemoteCommandListenerIOS.mm:
* platform/ios/ThemeIOS.mm:
* platform/ios/ValidationBubbleIOS.mm:
* platform/ios/WebCoreMotionManager.mm:
* platform/ios/WebItemProviderPasteboard.mm:
* platform/ios/WebVideoFullscreenControllerAVKit.mm:
* platform/mac/DragImageMac.mm:
* platform/mac/MediaRemoteSoftLink.cpp:
* platform/mac/MediaRemoteSoftLink.h:
* platform/mac/SerializedPlatformRepresentationMac.mm:
* platform/mac/WebPlaybackControlsManager.mm:
* platform/mac/WebVideoFullscreenController.mm:
* platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm:
* platform/mediastream/ios/CoreAudioCaptureSourceIOS.mm:
* platform/mediastream/libwebrtc/H264VideoToolBoxEncoder.mm:
* platform/mediastream/mac/AVCaptureDeviceManager.mm:
* platform/network/cf/CookieJarCFNet.cpp:
* platform/network/ios/NetworkStateNotifierIOS.mm:
* platform/network/ios/PreviewConverter.mm:
* platform/network/mac/BlobDataFileReferenceMac.mm:
* platform/spi/cocoa/AVKitSPI.h:
(-[AVTouchBarPlaybackControlsControlling NS_ENUM]): Deleted.
* platform/spi/cocoa/NSAttributedStringSPI.h:
* platform/spi/ios/DataDetectorsUISPI.h:
* platform/spi/mac/AVFoundationSPI.h:
* platform/spi/mac/DataDetectorsSPI.h:
* platform/spi/mac/LookupSPI.h:
* platform/spi/mac/TUCallSPI.h:
* platform/win/ScrollbarThemeWin.cpp:
* rendering/RenderThemeCocoa.mm:
* rendering/RenderThemeIOS.mm:
* rendering/RenderThemeWin.cpp:
* testing/Internals.mm:
* xml/XSLStyleSheetLibxslt.cpp:
* xml/XSLTExtensions.cpp:
* xml/XSLTProcessorLibxslt.cpp:
* xml/XSLTUnicodeSort.cpp:

Source/WebKit/ios:

* Misc/WebGeolocationCoreLocationProvider.mm:
* WebView/WebPDFViewPlaceholder.mm:

Source/WebKit/mac:

* Plugins/WebNetscapePluginView.mm:
* Plugins/WebPluginController.mm:
* WebCoreSupport/WebInspectorClient.mm:
* WebView/WebFullScreenController.mm:
* WebView/WebImmediateActionController.mm:
* WebView/WebView.mm:

Source/WebKit/win:

* WebKitClassFactory.cpp:
* WebView.cpp:

Source/WebKit2:

* Platform/mac/StringUtilities.mm:
* Platform/spi/ios/ManagedConfigurationSPI.h:
* Shared/Cocoa/DataDetectionResult.mm:
* Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:
* Shared/ios/InteractionInformationAtPosition.mm:
* Shared/ios/WebIconUtilities.mm:
* Shared/mac/CookieStorageShim.mm:
* Shared/mac/WebCoreArgumentCodersMac.mm:
* UIProcess/API/Cocoa/_WKElementAction.mm:
* UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:
* UIProcess/ApplePay/ios/WebPaymentCoordinatorProxyIOS.mm:
* UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm:
* UIProcess/Cocoa/UIDelegate.mm:
* UIProcess/Cocoa/WebViewImpl.mm:
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
* UIProcess/ios/WKActionSheetAssistant.mm:
* UIProcess/ios/WKContentViewInteraction.mm:
* UIProcess/ios/forms/WKAirPlayRoutePicker.mm:
* UIProcess/ios/forms/WKFileUploadPanel.mm:
* UIProcess/mac/WKImmediateActionController.mm:
* UIProcess/mac/WebInspectorProxyMac.mm:
* WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm:
* WebProcess/WebPage/mac/WebInspectorUIMac.mm:
* WebProcess/cocoa/WebProcessCocoa.mm:

Source/WTF:

* WTF.xcodeproj/project.pbxproj:
* wtf/SoftLinking.h: Copied from Source/WebCore/platform/ios/QuickLookSoftLink.mm.
* wtf/cocoa/SoftLinking.h: Renamed from Source/WebCore/platform/cocoa/SoftLinking.h.
* wtf/win/SoftLinking.h: Renamed from Source/WebCore/platform/win/SoftLinking.h.

Tools:

* DumpRenderTree/mac/TestRunnerMac.mm:
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(test_primary_header):
(ErrorCollector.__init__): Deleted.
(ErrorCollector.__call__): Deleted.
(ErrorCollector.results): Deleted.
(ErrorCollector.result_list): Deleted.
(ErrorCollector.verify_all_categories_are_seen): Deleted.
(MockIo.open): Deleted.
(CppFunctionsTest.test_convert_to_lower_with_underscores): Deleted.
(CppFunctionsTest.test_create_acronym): Deleted.
(CppFunctionsTest.test_is_c_or_objective_c): Deleted.
(CppFunctionsTest.test_parameter): Deleted.
(CppFunctionsTest.test_single_line_view): Deleted.
(CppFunctionsTest.test_create_skeleton_parameters): Deleted.
(CppFunctionsTest.test_find_parameter_name_index): Deleted.
(CppFunctionsTest.test_parameter_list): Deleted.
(CppFunctionsTest.test_check_parameter_against_text): Deleted.
(CppStyleTestBase.process_file_data): Deleted.
(CppStyleTestBase.perform_lint): Deleted.
(CppStyleTestBase.perform_single_line_lint): Deleted.
(CppStyleTestBase.perform_multi_line_lint): Deleted.
(CppStyleTestBase.perform_language_rules_check): Deleted.
(CppStyleTestBase.perform_function_lengths_check): Deleted.
(CppStyleTestBase.perform_pass_ptr_check): Deleted.
(CppStyleTestBase.perform_leaky_pattern_check): Deleted.
(CppStyleTestBase.perform_include_what_you_use): Deleted.
(CppStyleTestBase.perform_header_guard_check): Deleted.
(CppStyleTestBase.assert_lint): Deleted.
(CppStyleTestBase.assert_lint_one_of_many_errors_re): Deleted.
(CppStyleTestBase.assert_multi_line_lint): Deleted.
(CppStyleTestBase.assert_multi_line_lint_re): Deleted.
(CppStyleTestBase.assert_language_rules_check): Deleted.
(CppStyleTestBase.assert_include_what_you_use): Deleted.
(CppStyleTestBase.assert_header_guard): Deleted.
(CppStyleTestBase.assert_blank_lines_check): Deleted.
(CppStyleTestBase.assert_positions_equal): Deleted.
(FunctionDetectionTest.test_basic_function_detection): Deleted.
(FunctionDetectionTest.test_function_declaration_detection): Deleted.
(FunctionDetectionTest.test_pure_function_detection): Deleted.
(FunctionDetectionTest.test_override_and_final_function_detection): Deleted.
(FunctionDetectionTest.test_ignore_macros): Deleted.
(FunctionDetectionTest.test_non_functions): Deleted.
(FunctionDetectionTest.test_non_functions.Stuff): Deleted.
(FunctionDetectionTest.test_parameter_list): Deleted.
(Cpp11StyleTest.test_rvaule_reference_in_parameter_pack): Deleted.
(CppStyleTest.test_asm_lines_ignored): Deleted.
(CppStyleTest.test_get_line_width): Deleted.
(CppStyleTest.test_find_next_multi_line_comment_start): Deleted.
(CppStyleTest.test_find_next_multi_line_comment_end): Deleted.
(CppStyleTest.test_remove_multi_line_comments_from_range): Deleted.
(CppStyleTest.test_position): Deleted.
(CppStyleTest.test_rfind_in_lines): Deleted.
(CppStyleTest.test_close_expression): Deleted.
(CppStyleTest.test_spaces_at_end_of_line): Deleted.
(CppStyleTest.test_cstyle_cast): Deleted.
(CppStyleTest.test_runtime_casting): Deleted.
(CppStyleTest.test_runtime_selfinit): Deleted.
(CppStyleTest.test_runtime_rtti): Deleted.
(CppStyleTest.test_static_cast_readability): Deleted.
(CppStyleTest.test_check_for_unnamed_params): Deleted.
(CppStyleTest.void): Deleted.
(CppStyleTest.test_deprecated_cast): Deleted.
(CppStyleTest.test_mock_method): Deleted.
(CppStyleTest.test_sizeof_type): Deleted.
(CppStyleTest.cases): Deleted.
(CppStyleTest.for): Deleted.
(CppStyleTest.test_typedef_for_pointer_to_function): Deleted.
(CppStyleTest.test_typedef_for_pointer_to_function.void): Deleted.
(CppStyleTest.test_include_what_you_use_no_implementation_files): Deleted.
(CppStyleTest.test_include_what_you_use): Deleted.
(CppStyleTest.test_files_belong_to_same_module): Deleted.
(CppStyleTest.test_cleanse_line): Deleted.
(CppStyleTest.test_multi_line_comments): Deleted.
(CppStyleTest.test_multi_line_comments.Foo): Deleted.
(CppStyleTest.test_multiline_strings): Deleted.
(CppStyleTest.test_platformh_comments): Deleted.
(CppStyleTest.test_explicit_single_argument_constructors): Deleted.
(CppStyleTest.test_explicit_single_argument_constructors.Foo): Deleted.
(CppStyleTest.test_explicit_single_argument_constructors.Qualifier): Deleted.
(CppStyleTest.test_explicit_single_argument_constructors.definition): Deleted.
(CppStyleTest.test_slash_star_comment_on_single_line): Deleted.
(CppStyleTest.test_suspicious_usage_of_if): Deleted.
(CppStyleTest.test_suspicious_usage_of_memset): Deleted.
(CppStyleTest.test_check_posix_threading): Deleted.
(CppStyleTest.test_insecure_string_operations): Deleted.
(CppStyleTest.test_format_strings): Deleted.
(CppStyleTest.test_insecure_temp_file): Deleted.
(CppStyleTest.test_variable_length_array_detection): Deleted.
(CppStyleTest.test_braces): Deleted.
(CppStyleTest.test_check_check): Deleted.
(CppStyleTest.test_brace_at_begin_of_line): Deleted.
(CppStyleTest.test_mismatching_spaces_in_parens): Deleted.
(CppStyleTest.test_spacing_for_fncall): Deleted.
(CppStyleTest.test_spacing_for_fncall.foo): Deleted.
(CppStyleTest.test_spacing_before_braces): Deleted.
(CppStyleTest.test_spacing_between_braces): Deleted.
(CppStyleTest.test_spacing_before_brackets): Deleted.
(CppStyleTest.test_cpp_lambda_functions): Deleted.
(CppStyleTest.test_objective_c_block): Deleted.
(CppStyleTest.test_objective_c_block_as_argument): Deleted.
(CppStyleTest.test_spacing_around_else): Deleted.
(CppStyleTest.test_spacing_for_binary_ops): Deleted.
(CppStyleTest.test_spacing_for_binary_ops.hash_map): Deleted.
(CppStyleTest.test_operator_methods): Deleted.
(CppStyleTest.test_spacing_in_objective_c_properties): Deleted.
(CppStyleTest.test_spacing_before_last_semicolon): Deleted.
(CppStyleTest.test_static_or_global_stlstrings): Deleted.
(CppStyleTest.test_no_spaces_in_function_calls): Deleted.
(CppStyleTest.test_one_spaces_between_code_and_comments): Deleted.
(CppStyleTest.test_one_spaces_after_punctuation_in_comments): Deleted.
(CppStyleTest.test_space_after_comment_marker): Deleted.
(CppStyleTest.test_newline_at_eof): Deleted.
(CppStyleTest.test_newline_at_eof.do_test): Deleted.
(CppStyleTest.test_extra_newlines_at_eof): Deleted.
(CppStyleTest.test_extra_newlines_at_eof.do_test): Deleted.
(CppStyleTest.test_invalid_utf8): Deleted.
(CppStyleTest.test_invalid_utf8.do_test): Deleted.
(CppStyleTest.test_is_blank_line): Deleted.
(CppStyleTest.test_blank_lines_check): Deleted.
(CppStyleTest.test_allow_blank_line_before_closing_namespace): Deleted.
(CppStyleTest.test_allow_blank_line_before_if_else_chain): Deleted.
(CppStyleTest.test_else_on_same_line_as_closing_braces): Deleted.
(CppStyleTest.test_else_clause_not_on_same_line_as_else): Deleted.
(CppStyleTest.test_comma): Deleted.
(CppStyleTest.test_declaration): Deleted.
(CppStyleTest.test_pointer_reference_marker_location): Deleted.
(CppStyleTest.test_indent): Deleted.
(CppStyleTest.test_indent.Foo): Deleted.
(CppStyleTest.test_not_alabel): Deleted.
(CppStyleTest.test_tab): Deleted.
(CppStyleTest.test_unnamed_namespaces_in_headers): Deleted.
(CppStyleTest.test_build_class): Deleted.
(CppStyleTest.test_build_class.definitions): Deleted.
(CppStyleTest.test_build_class.Foo): Deleted.
(CppStyleTest.test_build_class.DERIVE_FROM_GOO): Deleted.
(CppStyleTest.test_build_end_comment): Deleted.
(CppStyleTest.test_build_forward_decl): Deleted.
(CppStyleTest.test_build_forward_decl.Foo): Deleted.
(CppStyleTest.test_build_header_guard): Deleted.
(CppStyleTest.test_build_header_guard.Foo_h): Deleted.
(CppStyleTest.test_build_header_guard.Foo_h.for): Deleted.
(CppStyleTest.test_build_printf_format): Deleted.
(CppStyleTest.test_runtime_printf_format): Deleted.
(CppStyleTest.assert_lintLogCodeOnError): Deleted.
(CppStyleTest.test_build_storage_class): Deleted.
(CppStyleTest.test_build_storage_class.unsignedLongLong): Deleted.
(CppStyleTest.test_build_storage_class.declaration): Deleted.
(CppStyleTest.test_build_storage_class.after): Deleted.
(CppStyleTest.test_build_storage_class.is): Deleted.
(CppStyleTest.test_legal_copyright): Deleted.
(CppStyleTest.test_invalid_increment): Deleted.
(CppStyleTest.test_enum_bitfields): Deleted.
(CppStyleTest.test_plain_integral_bitfields): Deleted.
(CleansedLinesTest.test_init_empty): Deleted.
(CleansedLinesTest.test_collapse_strings): Deleted.
(OrderOfIncludesTest.tearDown): Deleted.
(OrderOfIncludesTest.test_check_next_include_order__no_config): Deleted.
(OrderOfIncludesTest.test_check_next_include_order__no_self): Deleted.
(OrderOfIncludesTest.test_check_next_include_order__likely_then_config): Deleted.
(OrderOfIncludesTest.test_check_next_include_order__other_then_config): Deleted.
(OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely): Deleted.
(OrderOfIncludesTest.test_check_alphabetical_include_order): Deleted.
(OrderOfIncludesTest.test_check_alphabetical_include_order_errors_reported_for_both_lines): Deleted.
(OrderOfIncludesTest.test_check_line_break_after_own_header): Deleted.
(OrderOfIncludesTest.test_check_line_break_before_own_header): Deleted.
(OrderOfIncludesTest.test_check_preprocessor_in_include_section): Deleted.
(OrderOfIncludesTest.test_check_preprocessor_in_include_section.BAZ): Deleted.
(OrderOfIncludesTest.test_check_preprocessor_in_include_section.FOOBAR): Deleted.
(OrderOfIncludesTest.test_primary_header): Deleted.
(OrderOfIncludesTest.test_public_primary_header): Deleted.
(OrderOfIncludesTest.test_check_wtf_includes): Deleted.
(OrderOfIncludesTest.test_classify_include): Deleted.
(OrderOfIncludesTest.test_try_drop_common_suffixes): Deleted.
(CheckForFunctionLengthsTest.tearDown): Deleted.
(CheckForFunctionLengthsTest.set_min_confidence): Deleted.
(CheckForFunctionLengthsTest.assert_function_lengths_check): Deleted.
(CheckForFunctionLengthsTest.trigger_lines): Deleted.
(CheckForFunctionLengthsTest.trigger_test_lines): Deleted.
(CheckForFunctionLengthsTest.assert_function_length_check_definition): Deleted.
(CheckForFunctionLengthsTest.assert_function_length_check_definition_ok): Deleted.
(CheckForFunctionLengthsTest.assert_function_length_check_at_error_level): Deleted.
(CheckForFunctionLengthsTest.assert_function_length_check_below_error_level): Deleted.
(CheckForFunctionLengthsTest.assert_function_length_check_above_error_level): Deleted.
(CheckForFunctionLengthsTest.function_body): Deleted.
(CheckForFunctionLengthsTest.function_body_with_blank_lines): Deleted.
(CheckForFunctionLengthsTest.function_body_with_no_lints): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_declaration): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_declaration_with_block_following): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_class_definition): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_class_definition.Test): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_trivial): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_empty): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity0): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity0): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity0): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1v0): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1v0): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity1): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_indented): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_blanks): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_complex_definition_severity1): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_test): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_split_line_test): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_embedded_no_lints): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_no_lint): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity2): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_severity2): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity2): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity3): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_severity3): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity3): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity4): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_severity4): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity4): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity5): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity5): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity5): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines): Deleted.
(CheckForFunctionLengthsTest.test_function_length_not_determinable): Deleted.
(NoNonVirtualDestructorsTest.test_no_error): Deleted.
(NoNonVirtualDestructorsTest.test_no_error.Foo): Deleted.
(NoNonVirtualDestructorsTest.test_no_error.MyClass): Deleted.
(NoNonVirtualDestructorsTest.test_no_error.Qualified): Deleted.
(NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed): Deleted.
(NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed.Foo): Deleted.
(NoNonVirtualDestructorsTest.test_enum_casing): Deleted.
(NoNonVirtualDestructorsTest.test_enum_casing.Foo): Deleted.
(NoNonVirtualDestructorsTest.test_enum_casing.Enum123): Deleted.
(NoNonVirtualDestructorsTest.test_enum_trailing_semicolon): Deleted.
(NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.CPP11EnumClass): Deleted.
(NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.MyEnum): Deleted.
(NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed): Deleted.
(NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed.Foo): Deleted.
(NoNonVirtualDestructorsTest.test_no_warn_when_derived): Deleted.
(NoNonVirtualDestructorsTest.test_no_warn_when_derived.Foo): Deleted.
(NoNonVirtualDestructorsTest.test_internal_braces): Deleted.
(NoNonVirtualDestructorsTest.test_internal_braces.Foo): Deleted.
(NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor): Deleted.
(NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo): Deleted.
(NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo.Goo): Deleted.
(NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Goo): Deleted.
(NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor): Deleted.
(NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo): Deleted.
(NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo.Goo): Deleted.
(NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor): Deleted.
(NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor.Qualified): Deleted.
(NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error): Deleted.
(NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error.Foo): Deleted.
(NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error): Deleted.
(NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error.Foo): Deleted.
(LeakyPatternTest.assert_leaky_pattern_check): Deleted.
(LeakyPatternTest.test_get_dc): Deleted.
(LeakyPatternTest.test_get_dc.HWndDC): Deleted.
(LeakyPatternTest.test_own_get_dc): Deleted.
(LeakyPatternTest.test_create_dc): Deleted.
(LeakyPatternTest.test_create_compatible_dc): Deleted.
(WebKitStyleTest.test_indentation): Deleted.
(WebKitStyleTest.test_indentation.Foo): Deleted.
(WebKitStyleTest.test_indentation.Document): Deleted.
(WebKitStyleTest.test_spacing): Deleted.
(WebKitStyleTest.test_line_breaking): Deleted.
(WebKitStyleTest.test_braces): Deleted.
(WebKitStyleTest.test_braces.MyClass): Deleted.
(WebKitStyleTest.test_braces.NS_ENUM): Deleted.
(WebKitStyleTest.test_braces.CPP11EnumClass): Deleted.
(WebKitStyleTest.test_braces.SOMETHING): Deleted.
(WebKitStyleTest.test_null_false_zero): Deleted.
(WebKitStyleTest.test_directive_indentation): Deleted.
(WebKitStyleTest.test_using_std): Deleted.
(WebKitStyleTest.test_using_namespace): Deleted.
(WebKitStyleTest.test_max_macro): Deleted.
(WebKitStyleTest.test_min_macro): Deleted.
(WebKitStyleTest.test_wtf_move): Deleted.
(WebKitStyleTest.test_ctype_fucntion): Deleted.
(WebKitStyleTest.test_names): Deleted.
(WebKitStyleTest.test_names.HTMLDocument): Deleted.
(WebKitStyleTest.test_names.WebWindowFadeAnimation): Deleted.
(WebKitStyleTest.test_names.declarations): Deleted.
(WebKitStyleTest.test_names.struct): Deleted.
(WebKitStyleTest.test_names.VectorType): Deleted.
(WebKitStyleTest.test_parameter_names): Deleted.
(WebKitStyleTest.test_comments): Deleted.
(WebKitStyleTest.test_webkit_export_check): Deleted.
(WebKitStyleTest.test_member_initialization_list): Deleted.
(WebKitStyleTest.test_member_initialization_list.MyClass): Deleted.
(WebKitStyleTest.test_other): Deleted.
(CppCheckerTest.mock_handle_style_error): Deleted.
(CppCheckerTest._checker): Deleted.
(CppCheckerTest.test_init): Deleted.
(CppCheckerTest.test_eq): Deleted.
(CppCheckerTest.test_eq.mock_handle_style_error2): Deleted.
(CppCheckerTest.test_ne): Deleted.
* TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
* TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
* TestWebKitAPI/cocoa/TestWKWebView.mm:
* TestWebKitAPI/ios/DataInteractionSimulator.mm:
* WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
* WebKitTestRunner/ios/HIDEventGenerator.mm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoREGRESSION: Stack overflow in RenderBlockFlow::layoutBlock after increasing the font...
zalan@apple.com [Thu, 6 Jul 2017 05:49:50 +0000 (05:49 +0000)]
REGRESSION: Stack overflow in RenderBlockFlow::layoutBlock after increasing the font size to max in some RTL vertical books.
https://bugs.webkit.org/show_bug.cgi?id=174144
<rdar://problem/32781038>

Reviewed by Simon Fraser.

Source/WebCore:

We set the start/end margin on the ruby renderer to support overhanging content. The margins ensure that
adjacent boxes on the line are placed properly respecting the overhanging content.
The line breaking algorithm also takes this value into account as it affects the line's available width.
We need to reset this value before laying out the lines, otherwise we might end up using this value on the line twice;
first as the renderer's margins (as the result of the previous layout) and second as the renderer's overhanging value.
Since this is not strictly part of the renderer's layout context (i.e. we set them during the line layout and not at
RenderRubyRun::layout) we can't rely on the ruby's layout logic to reset them.

Test: fast/ruby/ruby-overhang-margin-crash.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::layoutLineBoxes):

LayoutTests:

* fast/ruby/ruby-overhang-margin-crash-expected.txt: Added.
* fast/ruby/ruby-overhang-margin-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoNewArray in FTLLowerDFGToB3 does not handle speculating on doubles when having a...
sbarati@apple.com [Thu, 6 Jul 2017 05:01:33 +0000 (05:01 +0000)]
NewArray in FTLLowerDFGToB3 does not handle speculating on doubles when having a bad time
https://bugs.webkit.org/show_bug.cgi?id=174188
<rdar://problem/30581423>

Reviewed by Mark Lam.

JSTests:

* stress/new-array-having-a-bad-time-double.js: Added.
(assert):
(foo):

Source/JavaScriptCore:

We were calling lowJSValue(edge) when we were speculating the
edge as double. This isn't allowed. We should have been using
lowDouble.

This patch also adds a new option, called useArrayAllocationProfiling,
which defaults to true. When false, it will make the array allocation
profile not actually sample seen arrays. It'll force the allocation
profile's predicted indexing type to be ArrayWithUndecided. Adding
this option made it trivial to write a test for this bug.

* bytecode/ArrayAllocationProfile.cpp:
(JSC::ArrayAllocationProfile::updateIndexingType):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileNewArray):
* runtime/Options.h:

Tools:

* Scripts/run-jsc-stress-tests:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUpgrade GCC baseline
utatane.tea@gmail.com [Thu, 6 Jul 2017 04:51:10 +0000 (04:51 +0000)]
Upgrade GCC baseline
https://bugs.webkit.org/show_bug.cgi?id=174155

Reviewed by Michael Catanzaro.

.:

This patch bumps the version of GCC from 4.9.0 to 5.0.0,
which is shipped with Ubuntu 16.04 LTS. And the latest
Debian stable (stretch) already ships newer GCC (6.3.0).
Remove workaround for old GCC. And move GCC version check
to the top-level CMakeLists.txt.

* CMakeLists.txt:
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/WebKitHelpers.cmake:

Source/WebCore:

Remove workaround for old GCC.

* CMakeLists.txt:

Source/WTF:

* wtf/Compiler.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoWeb Inspector: Group Inspector Style Sheets as part of the Stylesheets folder
drousso@apple.com [Thu, 6 Jul 2017 03:42:29 +0000 (03:42 +0000)]
Web Inspector: Group Inspector Style Sheets as part of the Stylesheets folder
https://bugs.webkit.org/show_bug.cgi?id=173435

Reviewed by Joseph Pecoraro.

* UserInterface/Views/ResourceSidebarPanel.js:
(WebInspector.ResourceSidebarPanel.prototype.matchTreeElementAgainstCustomFilters.match):
Add special case for CSSStyleSheetTreeElement.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed attempt to fix iOS build after r219177.
cdumez@apple.com [Thu, 6 Jul 2017 02:59:36 +0000 (02:59 +0000)]
Unreviewed attempt to fix iOS build after r219177.

* page/ios/UserAgentIOS.mm:
* platform/spi/ios/UIKitSPI.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed attempt to fix iOS build after r219177.
cdumez@apple.com [Thu, 6 Jul 2017 02:49:38 +0000 (02:49 +0000)]
Unreviewed attempt to fix iOS build after r219177.

* page/ios/UserAgentIOS.mm:
* platform/spi/ios/UIKitSPI.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoWTF::StringImpl::copyChars segfaults when built with GCC 7
utatane.tea@gmail.com [Thu, 6 Jul 2017 02:31:35 +0000 (02:31 +0000)]
WTF::StringImpl::copyChars segfaults when built with GCC 7
https://bugs.webkit.org/show_bug.cgi?id=173407

Reviewed by Andreas Kling.

JSTests:

* stress/string-repeat-copy-chars-crash.js: Added.
(shouldBe):

Source/WTF:

With GCC 7, StringImpl::copyChars() behaves as unexpected.
This function violates strict aliasing rule.

This optimization is originally introduced to improve performance
in SunSpider's string tests in 2008. When running it in my Linux
box, it no longer causes any observable difference. So, we just
remove this optimization.

                                baseline                  patched

string-base64                7.7544+-0.1761            7.6138+-0.2071          might be 1.0185x faster
string-fasta                10.5429+-0.2746     ?     10.7500+-0.2669        ? might be 1.0196x slower
string-tagcloud             14.8588+-0.2828           14.8039+-0.3039
string-unpack-code          36.1769+-0.4251           35.3397+-0.5398          might be 1.0237x faster
string-validate-input        8.5182+-0.2206            8.3514+-0.2179          might be 1.0200x faster

* wtf/text/StringImpl.h:
(WTF::StringImpl::copyChars):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoreinterpret_cast does not evaluate to constexpr
commit-queue@webkit.org [Thu, 6 Jul 2017 02:30:40 +0000 (02:30 +0000)]
reinterpret_cast does not evaluate to constexpr
https://bugs.webkit.org/show_bug.cgi?id=173622

Patch by Daewoong Jang <daewoong.jang@navercorp.com> on 2017-07-05
Reviewed by Yusuke Suzuki.

* bmalloc/Algorithm.h:
(bmalloc::mask):
(bmalloc::roundUpToMultipleOf):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoWeb Inspector: Split Canvas.svg into icons for 2D and 3D
drousso@apple.com [Thu, 6 Jul 2017 02:29:05 +0000 (02:29 +0000)]
Web Inspector: Split Canvas.svg into icons for 2D and 3D
https://bugs.webkit.org/show_bug.cgi?id=174057

Reviewed by Matt Baker.

* UserInterface/Images/Canvas2D.svg: Added.
* UserInterface/Images/Canvas3D.svg: Renamed from Source/WebInspectorUI/UserInterface/Images/Canvas.svg.
* UserInterface/Views/ResourceIcons.css:
(.canvas.canvas-2d .icon):
(.canvas:matches(.webgl, .webgl2, .webgpu) .icon):
(.canvas .icon): Deleted.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUse std::lock_guard instead of std::unique_lock if move semantics and try_lock is...
utatane.tea@gmail.com [Thu, 6 Jul 2017 02:27:06 +0000 (02:27 +0000)]
Use std::lock_guard instead of std::unique_lock if move semantics and try_lock is not necessary
https://bugs.webkit.org/show_bug.cgi?id=174148

Reviewed by Mark Lam.

Source/WebCore:

* platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:
(WebCore::AudioSourceProviderAVFObjC::~AudioSourceProviderAVFObjC):

Source/WTF:

It is not necessary to use std::unique_lock if we do not use additional features compared to std::lock_guard.

(WTF::ThreadHolder::get):
(WTF::ThreadHolder::initialize):
(WTF::ThreadHolder::destruct):
* wtf/Threading.cpp:
(WTF::Thread::didExit):
* wtf/ThreadingPthreads.cpp:
(WTF::Thread::changePriority):
(WTF::Thread::waitForCompletion):
(WTF::Thread::detach):
(WTF::Thread::signal):
(WTF::Thread::resume):
(WTF::Thread::getRegisters):
(WTF::Thread::establish):
* wtf/ThreadingWin.cpp:
(WTF::Thread::changePriority):
(WTF::Thread::waitForCompletion):
(WTF::Thread::detach):
(WTF::Thread::resume):
(WTF::Thread::getRegisters):
(WTF::Thread::establish):
* wtf/WordLock.cpp:
(WTF::WordLockBase::unlockSlow):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
utatane.tea@gmail.com [Thu, 6 Jul 2017 02:02:51 +0000 (02:02 +0000)]
[WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
https://bugs.webkit.org/show_bug.cgi?id=174150

Reviewed by Mark Lam.

Source/WebCore:

* Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::captionDisplayMode):
* Modules/mediastream/RTCDataChannel.cpp:
(WebCore::RTCDataChannel::binaryType):
* accessibility/AXObjectCache.cpp:
(WebCore::createFromRenderer):
* accessibility/AccessibilityMediaControls.cpp:
(WebCore::AccessibilityMediaControl::controlTypeName):
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::language):
(WebCore::AccessibilityObject::defaultLiveRegionStatusForRole):
(WebCore::AccessibilityObject::actionVerb):
(WebCore::AccessibilityObject::getAttribute):
(WebCore::AccessibilityObject::placeholderValue):
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::accessKey):
(WebCore::AccessibilityObject::ariaLiveRegionRelevant):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessKey):
(WebCore::AccessibilityRenderObject::actionVerb):
* bindings/js/JSCustomElementInterface.cpp:
(WebCore::JSCustomElementInterface::constructElementWithFallback):
* bindings/js/JSCustomElementRegistryCustom.cpp:
(WebCore::JSCustomElementRegistry::define):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateDefaultValue):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalAtomicStringBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalAtomicStringIsNullBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalAtomicStringIsEmptyStringBody):
* css/CSSPageRule.cpp:
(WebCore::CSSPageRule::selectorText):
* css/CSSPrimitiveValue.cpp:
(WebCore::valueName):
* css/CSSSelector.cpp:
(WebCore::simpleSelectorSpecificityInternal):
(WebCore::CSSSelector::specificityForPage):
(WebCore::CSSSelector::RareData::RareData):
* css/CSSSelector.h:
(WebCore::CSSSelector::argument):
* css/CSSSelectorList.cpp:
(WebCore::SelectorNeedsNamespaceResolutionFunctor::operator()):
* css/PageRuleCollector.cpp:
(WebCore::checkPageSelectorComponents):
* css/RuleSet.cpp:
(WebCore::computeMatchBasedOnRuleHash):
(WebCore::RuleSet::addRule):
* css/SelectorChecker.cpp:
(WebCore::tagMatches):
* css/SelectorFilter.cpp:
(WebCore::collectDescendantSelectorIdentifierHashes):
* css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertStringOrAuto):
(WebCore::StyleBuilderConverter::convertStringOrNone):
* css/StyleBuilderCustom.h:
(WebCore::StyleBuilderCustom::applyValueWebkitLocale):
(WebCore::StyleBuilderCustom::applyValueWebkitTextEmphasisStyle):
(WebCore::StyleBuilderCustom::applyValueContent):
(WebCore::StyleBuilderCustom::applyValueAlt):
* css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::StyleSheetContents):
(WebCore::StyleSheetContents::namespaceURIFromPrefix):
* css/makeprop.pl:
* css/parser/CSSParserImpl.cpp:
(WebCore::CSSParserImpl::parsePageSelector):
* css/parser/CSSSelectorParser.cpp:
(WebCore::CSSSelectorParser::consumeCompoundSelector):
(WebCore::CSSSelectorParser::consumeName):
(WebCore::CSSSelectorParser::consumeAttribute):
(WebCore::CSSSelectorParser::defaultNamespace):
(WebCore::CSSSelectorParser::determineNamespace):
(WebCore::CSSSelectorParser::prependTypeSelectorIfNeeded):
* cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::attributeNameTestingRequiresNamespaceRegister):
(WebCore::SelectorCompiler::equalTagNames):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementAttributeMatching):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementHasTagName):
* dom/Attr.cpp:
(WebCore::Attr::setPrefix):
(WebCore::Attr::attachToElement):
* dom/Attribute.h:
(WebCore::Attribute::nameMatchesFilter):
* dom/ConstantPropertyMap.cpp:
(WebCore::ConstantPropertyMap::nameForProperty):
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::getElementsByTagName):
(WebCore::ContainerNode::getElementsByTagNameNS):
* dom/CustomElementReactionQueue.cpp:
(WebCore::CustomElementReactionQueue::enqueuePostUpgradeReactions):
* dom/DatasetDOMStringMap.cpp:
(WebCore::convertPropertyNameToAttributeName):
* dom/Document.cpp:
(WebCore::createUpgradeCandidateElement):
(WebCore::Document::createElementForBindings):
(WebCore::Document::importNode):
(WebCore::Document::hasValidNamespaceForElements):
(WebCore::Document::processBaseElement):
(WebCore::Document::dir):
(WebCore::Document::bgColor):
(WebCore::Document::fgColor):
(WebCore::Document::alinkColor):
(WebCore::Document::linkColorForBindings):
(WebCore::Document::vlinkColor):
* dom/Document.h:
* dom/Element.cpp:
(WebCore::Element::setBooleanAttribute):
(WebCore::Element::synchronizeAttribute):
(WebCore::Element::getAttribute):
(WebCore::Element::getAttributeNS):
(WebCore::Element::setAttribute):
(WebCore::Element::parserSetAttributes):
(WebCore::Element::didMoveToNewDocument):
(WebCore::Element::setPrefix):
(WebCore::Element::insertedInto):
(WebCore::Element::removedFrom):
(WebCore::Element::removeAttributeInternal):
(WebCore::Element::addAttributeInternal):
(WebCore::Element::removeAttributeNS):
(WebCore::Element::getAttributeNodeNS):
(WebCore::Element::hasAttributeNS):
(WebCore::Element::computeInheritedLanguage):
(WebCore::Element::updateNameForDocument):
(WebCore::Element::updateIdForDocument):
(WebCore::Element::didAddAttribute):
(WebCore::Element::didRemoveAttribute):
(WebCore::Element::cloneAttributesFromElement):
* dom/Element.h:
(WebCore::Element::attributeWithoutSynchronization):
(WebCore::Element::idForStyleResolution):
(WebCore::Element::getIdAttribute):
(WebCore::Element::getNameAttribute):
* dom/EventTarget.cpp:
(WebCore::legacyType):
* dom/MutationRecord.h:
(WebCore::MutationRecord::attributeName):
(WebCore::MutationRecord::attributeNamespace):
* dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::removeNamedItemNS):
* dom/Node.cpp:
(WebCore::Node::prefix):
(WebCore::Node::localName):
(WebCore::Node::namespaceURI):
(WebCore::Node::checkSetPrefix):
(WebCore::locateDefaultNamespace):
(WebCore::Node::isDefaultNamespace):
(WebCore::Node::lookupNamespaceURI):
(WebCore::locateNamespacePrefix):
(WebCore::Node::lookupPrefix):
* dom/NodeRareData.h:
(WebCore::NodeListsNodeData::addCachedTagCollectionNS):
(WebCore::NodeListsNodeData::addCachedCollection):
(WebCore::NodeListsNodeData::cachedCollection):
(WebCore::NodeListsNodeData::removeCacheWithAtomicName):
(WebCore::NodeListsNodeData::removeCachedTagCollectionNS):
(WebCore::NodeListsNodeData::removeCachedCollection):
* dom/PseudoElement.cpp:
(WebCore::pseudoElementTagName):
* dom/QualifiedName.cpp:
(WebCore::QualifiedName::init):
(WebCore::nullQName):
(WebCore::createQualifiedName):
* dom/QualifiedName.h:
(WebCore::QualifiedName::hasPrefix):
* dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::executeSingleTagNameSelectorData):
* dom/SlotAssignment.cpp:
(WebCore::slotNameFromAttributeValue):
* dom/SlotAssignment.h:
(WebCore::SlotAssignment::defaultSlotName):
(WebCore::ShadowRoot::didRemoveAllChildrenOfShadowHost):
(WebCore::ShadowRoot::didChangeDefaultSlot):
* dom/TagCollection.cpp:
(WebCore::TagCollection::TagCollection):
(WebCore::HTMLTagCollection::HTMLTagCollection):
* dom/TagCollection.h:
(WebCore::TagCollectionNS::elementMatches):
* dom/make_names.pl:
(printNamesCppFile):
(printDefinitions):
(printFactoryCppFile):
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::removeNodeAttribute):
* editing/Editing.cpp:
(WebCore::createHTMLElement):
* editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::serializeNodesWithNamespaces):
(WebCore::MarkupAccumulator::shouldAddNamespaceElement):
(WebCore::MarkupAccumulator::shouldAddNamespaceAttribute):
(WebCore::MarkupAccumulator::appendNamespace):
(WebCore::MarkupAccumulator::appendOpenTag):
(WebCore::MarkupAccumulator::appendAttribute):
* editing/gtk/EditorGtk.cpp:
(WebCore::elementURL):
* editing/markup.cpp:
(WebCore::AttributeChange::AttributeChange):
* html/Autocapitalize.cpp:
(WebCore::stringForAutocapitalizeType):
* html/Autofill.cpp:
(WebCore::AutofillData::createFromHTMLFormControlElement):
* html/DOMTokenList.h:
(WebCore::DOMTokenList::item):
* html/FormAssociatedElement.cpp:
(WebCore::FormAssociatedElement::name):
* html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::formControlType):
* html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::toggleOpen):
* html/HTMLDocument.cpp:
(WebCore::HTMLDocument::isCaseSensitiveAttribute):
* html/HTMLElement.cpp:
(WebCore::HTMLElement::eventNameForEventHandlerAttribute):
(WebCore::toValidDirValue):
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::name):
(WebCore::HTMLInputElement::updateType):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::doesHaveAttribute):
* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::createForJSConstructor):
* html/HTMLParamElement.cpp:
(WebCore::HTMLParamElement::name):
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::setMultiple):
* html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::scope):
* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::mediaElementCrossOriginAttribute):
* html/LabelableElement.cpp:
(WebCore::LabelableElement::labels):
* html/LabelsNodeList.cpp:
(WebCore::LabelsNodeList::~LabelsNodeList):
* html/MediaController.cpp:
(MediaController::playbackState):
(eventNameForReadyState):
* html/MediaDocument.cpp:
(WebCore::MediaDocumentParser::createDocumentStructure):
* html/parser/AtomicHTMLToken.h:
(WebCore::AtomicHTMLToken::initializeAttributes):
* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::createElement):
(WebCore::HTMLConstructionSite::createHTMLElementOrFindCustomElementInterface):
* html/parser/HTMLParserIdioms.cpp:
(WebCore::stripLeadingAndTrailingHTMLSpaces):
(WebCore::parseHTMLHashNameReference):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::createForeignAttributesMap):
* html/track/InbandTextTrack.cpp:
(WebCore::InbandTextTrack::InbandTextTrack):
* html/track/LoadableTextTrack.cpp:
(WebCore::LoadableTextTrack::id):
* html/track/TextTrack.cpp:
(WebCore::TextTrack::captionMenuOffItem):
(WebCore::TextTrack::captionMenuAutomaticItem):
* html/track/TrackBase.cpp:
(WebCore::MediaTrackBase::setKindInternal):
* html/track/VTTRegion.cpp:
(WebCore::VTTRegion::scroll):
* html/track/WebVTTElement.cpp:
(WebCore::nodeTypeToTagName):
* html/track/WebVTTElement.h:
* html/track/WebVTTToken.h:
(WebCore::WebVTTToken::StartTag):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::clear):
* loader/FrameLoader.h:
* loader/ImageLoader.cpp:
(WebCore::ImageLoader::clearFailedLoadURL):
* loader/NavigationAction.h:
* loader/PolicyChecker.cpp:
(WebCore::PolicyChecker::checkNavigationPolicy):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::showModalDialog):
* page/EventHandler.cpp:
(WebCore::eventNameForTouchPointState):
* page/FrameTree.cpp:
(WebCore::FrameTree::setName):
(WebCore::FrameTree::clearName):
* page/Page.cpp:
(WebCore::Page::groupName):
* platform/graphics/ComplexTextController.cpp:
(WebCore::ComplexTextController::offsetForPosition):
* platform/graphics/FontCache.cpp:
(WebCore::FontCache::alternateFamilyName):
* platform/graphics/FontDescription.h:
(WebCore::FontCascadeDescription::initialLocale):
* platform/graphics/FontGenericFamilies.cpp:
(WebCore::genericFontFamilyForScript):
* platform/graphics/InbandTextTrackPrivate.h:
(WebCore::InbandTextTrackPrivate::inBandMetadataTrackDispatchType):
* platform/graphics/TrackPrivateBase.h:
(WebCore::TrackPrivateBase::id):
(WebCore::TrackPrivateBase::label):
(WebCore::TrackPrivateBase::language):
* platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm:
(WebCore::AVTrackPrivateAVFObjCImpl::id):
(WebCore::AVTrackPrivateAVFObjCImpl::label):
(WebCore::AVTrackPrivateAVFObjCImpl::language):
* platform/graphics/avfoundation/InbandMetadataTextTrackPrivateAVF.h:
* platform/graphics/avfoundation/cf/InbandTextTrackPrivateAVCF.cpp:
(WebCore::InbandTextTrackPrivateAVCF::label):
(WebCore::InbandTextTrackPrivateAVCF::language):
* platform/graphics/avfoundation/cf/InbandTextTrackPrivateLegacyAVCF.cpp:
(WebCore::InbandTextTrackPrivateLegacyAVCF::label):
(WebCore::InbandTextTrackPrivateLegacyAVCF::language):
* platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:
(WebCore::InbandTextTrackPrivateAVFObjC::label):
(WebCore::InbandTextTrackPrivateAVFObjC::language):
* platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm:
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::label):
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::language):
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::metadataType):
(WebCore::MediaPlayerPrivateAVFoundationObjC::metadataDidArrive):
* platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::FontCache::platformAlternateFamilyName):
* platform/graphics/cocoa/FontDescriptionCocoa.cpp:
(WebCore::FontCascadeDescription::effectiveFamilyAt):
* platform/graphics/freetype/FontCacheFreeType.cpp:
(WebCore::FontCache::platformAlternateFamilyName):
* platform/graphics/gstreamer/InbandMetadataTextTrackPrivateGStreamer.h:
(WebCore::InbandMetadataTextTrackPrivateGStreamer::create):
* platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::platformAlternateFamilyName):
* platform/mediastream/AudioTrackPrivateMediaStream.h:
* platform/mediastream/RealtimeMediaSourceSettings.cpp:
(WebCore::RealtimeMediaSourceSettings::facingMode):
* platform/mediastream/VideoTrackPrivateMediaStream.h:
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::linkSuggestedFilename):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
* rendering/RenderListItem.cpp:
(WebCore::RenderListItem::markerText):
* rendering/RenderText.cpp:
(WebCore::RenderText::previousOffset):
(WebCore::RenderText::nextOffset):
* rendering/RenderTreeAsText.cpp:
(WebCore::RenderTreeAsText::writeRenderObject):
* rendering/TextPainter.cpp:
(WebCore::TextPainter::paintTextAndEmphasisMarksIfNeeded):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::textEmphasisMarkString):
* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::initialHyphenationString):
(WebCore::RenderStyle::initialTextEmphasisCustomMark):
(WebCore::RenderStyle::initialContentAltText):
(WebCore::RenderStyle::initialLineGrid):
(WebCore::RenderStyle::initialFlowThread):
(WebCore::RenderStyle::initialRegionThread):
* style/StyleScope.cpp:
(WebCore::Style::Scope::collectActiveStyleSheets):
* svg/SVGElement.cpp:
(WebCore::SVGElement::getPresentationAttribute):
* svg/SVGElement.h:
(WebCore::SVGAttributeHashTranslator::hash):
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::transferSizeAttributesToTargetClone):
* svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::constructAttributeName):
* testing/MockCDMFactory.cpp:
(WebCore::MockCDMInstance::requestLicense):
* xml/XMLErrors.cpp:
(WebCore::createXHTMLParserErrorHeader):
* xml/XPathStep.cpp:
(WebCore::XPath::nodeMatchesBasicTest):
(WebCore::XPath::Step::nodesInAxis):
* xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::handleNamespaceAttributes):
(WebCore::handleElementAttributes):

Source/WebKit/mac:

* DOM/DOM.mm:
(lookupElementClass):

Source/WTF:

This patch cleans up StringStatics.cpp and remove it from the tree.

1. Move StringImpl methods to appropriate place, "StringImpl.cpp".

StringImpl::hashSlowCase() and StringImpl::concurrentHash() are defined in
StringStatics.cpp. But they should be defined in StringImpl.cpp.
This patch just moves them to StringImpl.cpp.

2. Use LazyNeverDestroyed to initialize AtomicString atoms like emptyAtom.

Previously, we initialized AtomicString atoms like emptyAtom in a hacky way.
We first define them as extern global variables. However, AtomicString has
a non-trivial constructor. Thus, we cannot do this because it requires global
constructor calls. This is why we have StringStatics.cpp. In this file, we
include "StaticConstructors.h". After including this file, all the global
constructor call disabled in Windows. And in GCC environment, we allocate
void* storage for that variable. And we use placement new in AtomicString::init()
to initialize these storage.
However, we already have better way for that: LazyNeverDestroyed. It just allocates
storage like the above. And it does not have any global constructors. Thus
we can just declare it as a global variable. And we initialize them lazily in
AtomicString::init(). This way effectively avoids "StaticConstructors.h" hacky way.
And it makes "StringStatics.cpp" unnecessary.
Then, we just move these variables and AtomicString::init() to AtomicString.cpp.

And we also change emptyAtom to emptyAtom() to get the value from LazyNeverDestroyed<>.

* WTF.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
* wtf/text/AtomicString.cpp:
(WTF::AtomicString::convertASCIICase):
(WTF::AtomicString::fromUTF8Internal):
(WTF::AtomicString::init):
* wtf/text/AtomicString.h:
(WTF::nullAtom):
(WTF::emptyAtom):
(WTF::starAtom):
(WTF::xmlAtom):
(WTF::xmlnsAtom):
(WTF::AtomicString::fromUTF8):
* wtf/text/StringBuilder.h:
(WTF::StringBuilder::toAtomicString):
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::hashSlowCase):
(WTF::StringImpl::concurrentHash):
* wtf/text/StringStatics.cpp: Removed.

Tools:

* TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
(TestWebKitAPI::TEST):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[iOS] User agent string incorrectly says "iPhone" instead of "iPad" on newer iPads
cdumez@apple.com [Thu, 6 Jul 2017 02:01:30 +0000 (02:01 +0000)]
[iOS] User agent string incorrectly says "iPhone" instead of "iPad" on newer iPads
https://bugs.webkit.org/show_bug.cgi?id=174182
<rdar://problem/32868369>

Reviewed by Tim Horton.

In deviceNameForUserAgent() on iOS, we were forcefully returning "iPhone" if
[UIApplication _isClassic] returns true. Update check to return "iPad" if
[UIApplication _isClassic] returns true but [UIApplication _classMode] returns
UIApplicationSceneClassicModeOriginalPad.

* page/ios/UserAgentIOS.mm:
(WebCore::isClassicPad):
(WebCore::isClassicPhone):
(WebCore::osNameForUserAgent):
(WebCore::deviceNameForUserAgent):
* platform/spi/ios/UIKitSPI.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoWTF::Thread should have the threads stack bounds.
utatane.tea@gmail.com [Thu, 6 Jul 2017 01:57:43 +0000 (01:57 +0000)]
WTF::Thread should have the threads stack bounds.
https://bugs.webkit.org/show_bug.cgi?id=173975

Reviewed by Keith Miller.

Source/JavaScriptCore:

There is a site in JSC that try to walk another thread's stack.
Currently, stack bounds are stored in WTFThreadData which is located
in TLS. Thus, only the thread itself can access its own WTFThreadData.
We workaround this situation by holding StackBounds in MachineThread in JSC,
but StackBounds should be put in WTF::Thread instead.

This patch moves StackBounds from WTFThreadData to WTF::Thread. StackBounds
information is tightly coupled with Thread. Thus putting it in WTF::Thread
is natural choice.

* heap/MachineStackMarker.cpp:
(JSC::MachineThreads::MachineThread::MachineThread):
(JSC::MachineThreads::MachineThread::captureStack):
* heap/MachineStackMarker.h:
(JSC::MachineThreads::MachineThread::stackBase):
(JSC::MachineThreads::MachineThread::stackEnd):
* runtime/InitializeThreading.cpp:
(JSC::initializeThreading):
* runtime/VM.cpp:
(JSC::VM::VM):
(JSC::VM::updateStackLimits):
(JSC::VM::committedStackByteCount):
* runtime/VM.h:
(JSC::VM::isSafeToRecurse):
* runtime/VMEntryScope.cpp:
(JSC::VMEntryScope::VMEntryScope):
* runtime/VMInlines.h:
(JSC::VM::ensureStackCapacityFor):
* runtime/VMTraps.cpp:
* yarr/YarrPattern.cpp:
(JSC::Yarr::YarrPatternConstructor::isSafeToRecurse):

Source/WebCore:

When creating WebThread, we first allocate WebCore::ThreadGlobalData in UI thread
and share it with WebThread.
The problem is that WebCore::ThreadGlobalData has CachedResourceRequestInitiators.
It allocates AtomicString, which requires WTFThreadData.

Before this patch, it was OK because WTFThreadData does not touch threading related
things except for ThreadSpecific<>. However, after this patch, it touches
WTF::Thread::current() which requires WTF::initializeThreading().

In this patch, we call WTF::initializeThreading() before allocating WebCore::ThreadGlobalData.
And we also call AtomicString::init() before calling WebCore::ThreadGlobalData since
WebCore::ThreadGlobalData allocates AtomicString.

This fixes crashes in the iOS web threading environment (UIWebView).

* platform/ios/wak/WebCoreThread.mm:
(StartWebThread):

Source/WTF:

We move StackBounds from WTFThreadData to WTF::Thread.
One important thing is that we should make valid StackBounds
visible to Thread::create() caller. When the caller get
WTF::Thread from Thread::create(), this WTF::Thread should
have a valid StackBounds. But StackBounds information can be
retrived only in the WTF::Thread's thread itself.

We also clean up WTF::initializeThreading. StringImpl::empty()
is now statically initialized by using constexpr constructor.
Thus we do not need to call StringImpl::empty() explicitly here.
And WTF::initializeThreading() does not have any main thread
affinity right now in all the platforms. So we fix the comment
in Threading.h. Then, now, WTF::initializeThreading() is called
in UI thread when using Web thread in iOS.

* wtf/StackBounds.h:
(WTF::StackBounds::emptyBounds):
(WTF::StackBounds::StackBounds):
* wtf/StackStats.cpp:
(WTF::StackStats::PerThreadStats::PerThreadStats):
* wtf/Threading.cpp:
(WTF::threadEntryPoint):
(WTF::Thread::create):
(WTF::Thread::currentMayBeNull):
(WTF::Thread::initialize):
(WTF::initializeThreading):
* wtf/Threading.h:
(WTF::Thread::stack):
* wtf/ThreadingPthreads.cpp:
(WTF::Thread::initializeCurrentThreadEvenIfNonWTFCreated):
(WTF::Thread::current):
(WTF::initializeCurrentThreadEvenIfNonWTFCreated): Deleted.
(WTF::Thread::currentMayBeNull): Deleted.
* wtf/ThreadingWin.cpp:
(WTF::Thread::initializeCurrentThreadEvenIfNonWTFCreated):
(WTF::Thread::initializeCurrentThreadInternal):
(WTF::Thread::current):
* wtf/WTFThreadData.cpp:
(WTF::WTFThreadData::WTFThreadData):
* wtf/WTFThreadData.h:
(WTF::WTFThreadData::stack): Deleted.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoMove internal iOS 11 TestExpectations to OpenSource
jbedard@apple.com [Thu, 6 Jul 2017 00:29:21 +0000 (00:29 +0000)]
Move internal iOS 11 TestExpectations to OpenSource
<rdar://problem/32717028>

Unreviewed test gardening.

* platform/ios-11/platform/ios/ios/fast/text/opticalFont-expected.txt: Added.
* platform/ios-11/platform/ios/ios/fast/text/opticalFontWithTextStyle-expected.txt: Added.
* platform/ios-11/platform/ios/ios/fast/text/opticalFontWithWeight-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoCSSFontStyleValue::isItalic seems a bit bogus.
mmaxfield@apple.com [Thu, 6 Jul 2017 00:26:31 +0000 (00:26 +0000)]
CSSFontStyleValue::isItalic seems a bit bogus.
https://bugs.webkit.org/show_bug.cgi?id=174149

Reviewed by Tim Horton.

Source/WebCore:

Simple typo.

Test: editing/execCommand/italicizeByCharacter-normal.html

* css/CSSFontStyleValue.h:

LayoutTests:

* editing/execCommand/italicizeByCharacter-normal-expected.txt: Added.
* editing/execCommand/italicizeByCharacter-normal.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoCrashing with information should have an abort reason
keith_miller@apple.com [Thu, 6 Jul 2017 00:05:36 +0000 (00:05 +0000)]
Crashing with information should have an abort reason
https://bugs.webkit.org/show_bug.cgi?id=174185

Reviewed by Saam Barati.

Source/JavaScriptCore:

Add crash information for the abstract interpreter and add an enum
value for object allocation sinking.

* assembler/AbortReason.h:
* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::verifyEdge):
* dfg/DFGGraph.cpp:
(JSC::DFG::logDFGAssertionFailure):
* dfg/DFGObjectAllocationSinkingPhase.cpp:

Source/WTF:

Fix an ifdef to actually work with X86_64. It turns out X64_64 is
not an architecture... Whoops.

* wtf/Assertions.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoSkipped webgl/1.0.2/conformance/glsl/misc/shader-with-non-reserved-words.html.
jlewis3@apple.com [Thu, 6 Jul 2017 00:05:11 +0000 (00:05 +0000)]
Skipped webgl/1.0.2/conformance/glsl/misc/shader-with-non-reserved-words.html.
https://bugs.webkit.org/show_bug.cgi?id=174100

Unreviewed test gardening.

* platform/ios-simulator-wk2/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoAllow navigations in subframes to get a ShouldOpenExternalURLsPolicy of "ShouldAllow".
beidson@apple.com [Thu, 6 Jul 2017 00:01:53 +0000 (00:01 +0000)]
Allow navigations in subframes to get a ShouldOpenExternalURLsPolicy of "ShouldAllow".
<rdar://problem/22485589> and https://bugs.webkit.org/show_bug.cgi?id=174178

Reviewed by Alex Christensen.

Source/WebCore:

Test: loader/navigation-policy/should-open-external-urls/subframe-navigated-programatically-by-main-frame.html

This patch introduces a new flag to FrameLoadRequest to track when it is known with certainty that a
FrameLoadRequest originates from the main frame.

Later, when calculating the final ShouldOpenExternalURLsPolicy, main frames navigating iframes get to propagate
their permissions to the iframe.

* bindings/js/CommonVM.cpp:
(WebCore::lexicalFrameFromCommonVM): Helper to grab the current frame associated with the current JS callstack.
* bindings/js/CommonVM.h:

* inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::openInNewTab):

* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::navigate):

Add the new flag to FrameLoadRequest (and force almost everybody to explicitly include the flag):
* loader/FrameLoadRequest.cpp:
(WebCore::FrameLoadRequest::FrameLoadRequest):
* loader/FrameLoadRequest.h:
(WebCore::FrameLoadRequest::FrameLoadRequest):
(WebCore::FrameLoadRequest::navigationInitiatedByMainFrame):

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::urlSelected):
(WebCore::FrameLoader::loadURLIntoChildFrame):
(WebCore::shouldOpenExternalURLsPolicyToApply): Helper that takes the new flag into account when deciding
  what the final ShouldOpenExternalURLsPolicy will be.
(WebCore::applyShouldOpenExternalURLsPolicyToNewDocumentLoader):
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::load):
(WebCore::FrameLoader::loadWithNavigationAction):
(WebCore::FrameLoader::reloadWithOverrideEncoding):
(WebCore::FrameLoader::reload):
(WebCore::FrameLoader::loadPostRequest):
(WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
(WebCore::FrameLoader::loadDifferentDocumentItem):
(WebCore::createWindow):
(WebCore::FrameLoader::applyShouldOpenExternalURLsPolicyToNewDocumentLoader): Deleted.
* loader/FrameLoader.h:

* loader/FrameLoaderTypes.h:

* loader/NavigationAction.h:
(WebCore::NavigationAction::navigationInitiatedByMainFrame):
* loader/NavigationScheduler.cpp:
(WebCore::ScheduledNavigation::ScheduledNavigation): Grab the "initiating frame" at the time the
  ScheduledNavigation is created, as it dictates the policy we decide later.
(WebCore::ScheduledNavigation::navigationInitiatedByMainFrame):
(WebCore::NavigationScheduler::scheduleLocationChange):

* page/ContextMenuController.cpp:
(WebCore::openNewWindow):
(WebCore::ContextMenuController::contextMenuItemSelected):

* page/DOMWindow.cpp:
(WebCore::DOMWindow::createWindow):

Source/WebKit/ios:

Adopt to the new constructor for FrameLoadRequest.

* WebView/WebPDFViewPlaceholder.mm:
(-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]):

Source/WebKit/mac:

Adopt to the new constructor for FrameLoadRequest.

* WebView/WebPDFView.mm:
(-[WebPDFView PDFViewWillClickOnLink:withURL:]):

Source/WebKit/win:

Adopt to the new constructor for FrameLoadRequest.

* Plugins/PluginView.cpp:
(WebCore::PluginView::start):
(WebCore::PluginView::getURLNotify):
(WebCore::PluginView::getURL):
(WebCore::PluginView::handlePost):

Source/WebKit2:

Adopt to the new constructor for FrameLoadRequest.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::loadURL):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchCreatePage):
* WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::openInNewTab):

LayoutTests:

Added a new explicit test and updated expectations for an old one.

* loader/navigation-policy/should-open-external-urls/resources/main-frame-with-subframe-main-programatically-navigates-subframe.html: Added.
* loader/navigation-policy/should-open-external-urls/subframe-click-target-self-expected.txt:
* loader/navigation-policy/should-open-external-urls/subframe-navigated-programatically-by-main-frame-expected.txt: Added.
* loader/navigation-policy/should-open-external-urls/subframe-navigated-programatically-by-main-frame.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoRemove unnecessary forward declartions now that we include Foundation.h
rniwa@webkit.org [Wed, 5 Jul 2017 23:44:55 +0000 (23:44 +0000)]
Remove unnecessary forward declartions now that we include Foundation.h

* UIProcess/API/Cocoa/WKContentRuleListStore.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoMarked animations/needs-layout.html as flaky.
jlewis3@apple.com [Wed, 5 Jul 2017 23:44:37 +0000 (23:44 +0000)]
Marked animations/needs-layout.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=172397

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoMake WebKit's public headers on Mac and iOS C++ module safe
rniwa@webkit.org [Wed, 5 Jul 2017 23:40:26 +0000 (23:40 +0000)]
Make WebKit's public headers on Mac and iOS C++ module safe
https://bugs.webkit.org/show_bug.cgi?id=174175

Reviewed by Alex Christensen.

Fixed the header files.

Source/WebKit/mac:

* Misc/WebDownload.h:
* Misc/WebKitErrors.h:
* Plugins/WebPluginContainer.h:
* WebView/WebResourceLoadDelegate.h:

Source/WebKit2:

* UIProcess/API/Cocoa/WKContentRuleList.h:
* UIProcess/API/Cocoa/WKContentRuleListStore.h:
* UIProcess/API/Cocoa/WKUIDelegate.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoAnother build fix, for Mac.
simon.fraser@apple.com [Wed, 5 Jul 2017 22:29:03 +0000 (22:29 +0000)]
Another build fix, for Mac.

* platform/graphics/cocoa/IOSurface.mm:
(WebCore::IOSurface::surfaceID):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[WK2] WebsiteDataStore::setResourceLoadStatisticsEnabled() updates processPools the...
cdumez@apple.com [Wed, 5 Jul 2017 22:27:47 +0000 (22:27 +0000)]
[WK2] WebsiteDataStore::setResourceLoadStatisticsEnabled() updates processPools the store is not associated with
https://bugs.webkit.org/show_bug.cgi?id=174174

Reviewed by Brent Fulgham.

WebsiteDataStore::setResourceLoadStatisticsEnabled() updates processPools the store is not associated with.
Fix this by iterating over WebsiteDataStore::processPools() instead of WebProcessPool::allProcessPools().

Also rename shouldPartitionCookiesForTopPrivatelyOwnedDomains methods / IPC messages to
updateCookiePartitioningForTopPrivatelyOwnedDomains since this is a setter, not a getter.

Finally, drop ShouldPartitionCookiesForTopPrivatelyOwnedDomains IPC message to the NetworkProcessProxy
as well as corresponding methods as those appear to be unused.

* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::updateCookiePartitioningForTopPrivatelyOwnedDomains):
(WebKit::NetworkProcess::shouldPartitionCookiesForTopPrivatelyOwnedDomains): Deleted.
* NetworkProcess/NetworkProcess.h:
* NetworkProcess/NetworkProcess.messages.in:
* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::shouldPartitionCookiesForTopPrivatelyOwnedDomains): Deleted.
* UIProcess/Network/NetworkProcessProxy.h:
* UIProcess/Network/NetworkProcessProxy.messages.in:
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::setResourceLoadStatisticsEnabled):
* UIProcess/WebProcessPool.h:
* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::updateCookiePartitioningForTopPrivatelyOwnedDomains):
(WebKit::WebsiteDataStore::setResourceLoadStatisticsEnabled):
(WebKit::WebsiteDataStore::registerSharedResourceLoadObserver):
(WebKit::WebsiteDataStore::shouldPartitionCookiesForTopPrivatelyOwnedDomains): Deleted.
* UIProcess/WebsiteData/WebsiteDataStore.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoFurther attempts to fix the iOS public SDK build.
simon.fraser@apple.com [Wed, 5 Jul 2017 22:25:06 +0000 (22:25 +0000)]
Further attempts to fix the iOS public SDK build.

* platform/graphics/cocoa/IOSurface.mm:
(WebCore::IOSurface::surfaceID):
* platform/spi/cocoa/IOSurfaceSPI.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoAsync Image Decoding: Image flashes away briefly when tapping on tab in iPad tab...
timothy_horton@apple.com [Wed, 5 Jul 2017 21:52:19 +0000 (21:52 +0000)]
Async Image Decoding: Image flashes away briefly when tapping on tab in iPad tab picker
https://bugs.webkit.org/show_bug.cgi?id=174173
<rdar://problem/32431952>

Reviewed by Geoffrey Garen.

* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::addTransactionCallbackID):
When a client uses e.g. doAfterNextPresentationUpdate (or internally,
dispatchAfterEnsuringDrawing), they're doing so in the hopes that the
callback is called after the page is well-painted -- for example, to
remove a snapshot (in the tab picker case, as well as for navigation
gestures), or to *take* a snapshot. In all of these cases, it is
preferable to do a synchronous decode, to ensure that the image does
not flash away temporarily.

Use the existing mechanism that was implemented for the synchronous
activity state change flush to also force synchronous image decoding
any time there is a post-commit transaction callback.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[iOS DnD] [WK2] 3D touch fails to recognize when UIDragInteraction is enabled on...
wenson_hsieh@apple.com [Wed, 5 Jul 2017 21:40:31 +0000 (21:40 +0000)]
[iOS DnD] [WK2] 3D touch fails to recognize when UIDragInteraction is enabled on phone
https://bugs.webkit.org/show_bug.cgi?id=174171
<rdar://problem/32956929>

Reviewed by Tim Horton.

By default, UIKit defers all competing long press gesture recognizers if dragging is enabled. However, this
would cause 3D touch to be prevented, due to UIKit asking us whether or not we can proceed with the 3D touch
gesture in -_interactionShouldBeginFromPreviewItemController:forPosition:, while the highlight long press
gesture recognizer is being deferred. To address this, we use SPI on UIDragInteraction to allow the highlight
long press gesture recognizer to recognize alongside the drag lift gesture. We then (already) manually cancel
the highlight long press gesture in _dragInteraction:prepareForSession:completion:.

* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _dragInteraction:shouldDelayCompetingGestureRecognizer:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[WinCairo] Consolidate CMake code related to CURL
don.olmstead@sony.com [Wed, 5 Jul 2017 21:26:23 +0000 (21:26 +0000)]
[WinCairo] Consolidate CMake code related to CURL
https://bugs.webkit.org/show_bug.cgi?id=170860

Reviewed by Alex Christensen.

.:

* Source/cmake/OptionsWinCairo.cmake:

Source/WebCore:

No new tests. No change in functionality.

* PlatformWinCairo.cmake:
* platform/Curl.cmake: Added.

Source/WebKit:

* PlatformWin.cmake:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoRemove copy of ICU headers from WebKit
mmaxfield@apple.com [Wed, 5 Jul 2017 21:13:19 +0000 (21:13 +0000)]
Remove copy of ICU headers from WebKit
https://bugs.webkit.org/show_bug.cgi?id=116407

Reviewed by Alex Christensen.

Source/JavaScriptCore:

Use WTF's copy of ICU headers.

* Configurations/Base.xcconfig:
* icu/unicode/localpointer.h: Removed.
* icu/unicode/parseerr.h: Removed.
* icu/unicode/platform.h: Removed.
* icu/unicode/ptypes.h: Removed.
* icu/unicode/putil.h: Removed.
* icu/unicode/uchar.h: Removed.
* icu/unicode/ucnv.h: Removed.
* icu/unicode/ucnv_err.h: Removed.
* icu/unicode/ucol.h: Removed.
* icu/unicode/uconfig.h: Removed.
* icu/unicode/ucurr.h: Removed.
* icu/unicode/uenum.h: Removed.
* icu/unicode/uiter.h: Removed.
* icu/unicode/uloc.h: Removed.
* icu/unicode/umachine.h: Removed.
* icu/unicode/unorm.h: Removed.
* icu/unicode/unorm2.h: Removed.
* icu/unicode/urename.h: Removed.
* icu/unicode/uscript.h: Removed.
* icu/unicode/uset.h: Removed.
* icu/unicode/ustring.h: Removed.
* icu/unicode/utf.h: Removed.
* icu/unicode/utf16.h: Removed.
* icu/unicode/utf8.h: Removed.
* icu/unicode/utf_old.h: Removed.
* icu/unicode/utypes.h: Removed.
* icu/unicode/uvernum.h: Removed.
* icu/unicode/uversion.h: Removed.
* runtime/IntlCollator.cpp:
* runtime/IntlDateTimeFormat.cpp:
(JSC::IntlDateTimeFormat::partTypeString):
* runtime/JSGlobalObject.cpp:
* runtime/StringPrototype.cpp:
(JSC::normalize):
(JSC::stringProtoFuncNormalize):

Source/WebCore:

Use WTF's copy of ICU headers.

No new tests because there is no behavior change.

* Configurations/WebCore.xcconfig:
* icu/unicode/bytestream.h: Removed.
* icu/unicode/localpointer.h: Removed.
* icu/unicode/parseerr.h: Removed.
* icu/unicode/platform.h: Removed.
* icu/unicode/ptypes.h: Removed.
* icu/unicode/putil.h: Removed.
* icu/unicode/rep.h: Removed.
* icu/unicode/std_string.h: Removed.
* icu/unicode/strenum.h: Removed.
* icu/unicode/stringpiece.h: Removed.
* icu/unicode/ubrk.h: Removed.
* icu/unicode/uchar.h: Removed.
* icu/unicode/ucnv.h: Removed.
* icu/unicode/ucnv_err.h: Removed.
* icu/unicode/ucol.h: Removed.
* icu/unicode/uconfig.h: Removed.
* icu/unicode/ucurr.h: Removed.
* icu/unicode/uenum.h: Removed.
* icu/unicode/uiter.h: Removed.
* icu/unicode/uloc.h: Removed.
* icu/unicode/umachine.h: Removed.
* icu/unicode/unistr.h: Removed.
* icu/unicode/unorm.h: Removed.
* icu/unicode/unorm2.h: Removed.
* icu/unicode/uobject.h: Removed.
* icu/unicode/urename.h: Removed.
* icu/unicode/uscript.h: Removed.
* icu/unicode/uset.h: Removed.
* icu/unicode/ustring.h: Removed.
* icu/unicode/utext.h: Removed.
* icu/unicode/utf.h: Removed.
* icu/unicode/utf16.h: Removed.
* icu/unicode/utf8.h: Removed.
* icu/unicode/utf_old.h: Removed.
* icu/unicode/utypes.h: Removed.
* icu/unicode/uvernum.h: Removed.
* icu/unicode/uversion.h: Removed.
* platform/graphics/FontCache.h:
(WebCore::FontDescriptionKey::makeFlagsKey):

Source/WebKit/mac:

Use WTF's copy of ICU headers.

* Configurations/WebKitLegacy.xcconfig:
* icu/unicode/localpointer.h: Removed.
* icu/unicode/parseerr.h: Removed.
* icu/unicode/platform.h: Removed.
* icu/unicode/ptypes.h: Removed.
* icu/unicode/putil.h: Removed.
* icu/unicode/uchar.h: Removed.
* icu/unicode/uconfig.h: Removed.
* icu/unicode/ucurr.h: Removed.
* icu/unicode/uidna.h: Removed.
* icu/unicode/uiter.h: Removed.
* icu/unicode/umachine.h: Removed.
* icu/unicode/unorm.h: Removed.
* icu/unicode/unorm2.h: Removed.
* icu/unicode/urename.h: Removed.
* icu/unicode/uscript.h: Removed.
* icu/unicode/ustring.h: Removed.
* icu/unicode/utf.h: Removed.
* icu/unicode/utf16.h: Removed.
* icu/unicode/utf8.h: Removed.
* icu/unicode/utf_old.h: Removed.
* icu/unicode/utypes.h: Removed.
* icu/unicode/uvernum.h: Removed.
* icu/unicode/uversion.h: Removed.

Source/WebKit2:

* Configurations/BaseTarget.xcconfig:

Source/WTF:

Add an extra rsync command to CopyWTFHeaders which copies the ICU headers
to DSTROOT/usr/local/include/. These headers already live inside a
"unicode" folder, so an example path of a header is
DSTROOT/usr/local/include/unicode/uchar.h. This is already in the search
path of the other WebKit projects, so those other projects can remove
their explicit listing of the old place these headers lived.

Also add the remaining ICU 55.1 headers which the other projects (like
WebCore) need. Revert any local changes to these headers in favor of
using the GCC_PREPROCESSOR_DEFINITIONS build setting. This is so we can
compile the same way against unmodified headers.

* Configurations/Base.xcconfig:
* Configurations/CopyWTFHeaders.xcconfig:
* WTF.xcodeproj/project.pbxproj:
* icu/unicode/alphaindex.h: Added.
* icu/unicode/appendable.h: Added.
* icu/unicode/basictz.h: Added.
* icu/unicode/brkiter.h: Added.
(BreakIterator::isBufferClone):
* icu/unicode/bytestrie.h: Added.
* icu/unicode/bytestriebuilder.h: Added.
* icu/unicode/calendar.h: Added.
(Calendar::createInstance):
(Calendar::roll):
(Calendar::internalSet):
(Calendar::weekNumber):
* icu/unicode/caniter.h: Added.
* icu/unicode/chariter.h: Renamed from Source/WebCore/icu/unicode/chariter.h.
* icu/unicode/choicfmt.h: Added.
* icu/unicode/coleitr.h: Added.
(CollationElementIterator::primaryOrder):
(CollationElementIterator::secondaryOrder):
(CollationElementIterator::tertiaryOrder):
(CollationElementIterator::isIgnorable):
* icu/unicode/coll.h: Added.
* icu/unicode/compactdecimalformat.h: Added.
* icu/unicode/curramt.h: Added.
(CurrencyAmount::getCurrency):
(CurrencyAmount::getISOCurrency):
* icu/unicode/currpinf.h: Added.
(CurrencyPluralInfo::operator!=):
* icu/unicode/currunit.h: Added.
(CurrencyUnit::getISOCurrency):
* icu/unicode/datefmt.h: Added.
* icu/unicode/dbbi.h: Added.
* icu/unicode/dcfmtsym.h: Added.
(DecimalFormatSymbols::getSymbol):
(DecimalFormatSymbols::getConstSymbol):
(DecimalFormatSymbols::setSymbol):
(DecimalFormatSymbols::getLocale):
(DecimalFormatSymbols::getCurrencyPattern):
* icu/unicode/decimfmt.h: Added.
(DecimalFormat::getConstSymbol):
* icu/unicode/docmain.h: Added.
* icu/unicode/dtfmtsym.h: Added.
* icu/unicode/dtintrv.h: Added.
(DateInterval::getFromDate):
(DateInterval::getToDate):
(DateInterval::operator!=):
* icu/unicode/dtitvfmt.h: Added.
(DateIntervalFormat::operator!=):
* icu/unicode/dtitvinf.h: Added.
(DateIntervalInfo::operator!=):
* icu/unicode/dtptngen.h: Added.
* icu/unicode/dtrule.h: Added.
* icu/unicode/enumset.h: Added.
(EnumSet::EnumSet):
(EnumSet::~EnumSet):
(EnumSet::clear):
(EnumSet::add):
(EnumSet::remove):
(EnumSet::contains):
(EnumSet::set):
(EnumSet::get):
(EnumSet::isValidEnum):
(EnumSet::isValidValue):
(EnumSet::operator=):
(EnumSet::getAll):
(EnumSet::flag):
* icu/unicode/errorcode.h: Added.
* icu/unicode/fieldpos.h: Added.
(FieldPosition::operator=):
(FieldPosition::operator==):
(FieldPosition::operator!=):
* icu/unicode/filteredbrk.h: Added.
* icu/unicode/fmtable.h: Added.
(Formattable::getDate):
(Formattable::getString):
(Formattable::getLong):
(Formattable::toUFormattable):
(Formattable::fromUFormattable):
* icu/unicode/format.h: Added.
* icu/unicode/fpositer.h: Added.
* icu/unicode/gender.h: Added.
* icu/unicode/gregocal.h: Added.
* icu/unicode/icudataver.h: Added.
* icu/unicode/icuplug.h: Added.
* icu/unicode/idna.h: Added.
* icu/unicode/listformatter.h: Added.
(ListFormatData::ListFormatData):
* icu/unicode/locdspnm.h: Added.
(LocaleDisplayNames::createInstance):
* icu/unicode/locid.h: Added.
(Locale::operator!=):
(Locale::getCountry):
(Locale::getLanguage):
(Locale::getScript):
(Locale::getVariant):
(Locale::getName):
(Locale::isBogus):
* icu/unicode/measfmt.h: Added.
* icu/unicode/measunit.h: Added.
* icu/unicode/measure.h: Added.
(Measure::getNumber):
(Measure::getUnit):
* icu/unicode/messagepattern.h: Added.
* icu/unicode/msgfmt.h: Added.
* icu/unicode/normalizer2.h: Added.
* icu/unicode/normlzr.h: Added.
(Normalizer::operator!= ):
(Normalizer::quickCheck):
(Normalizer::isNormalized):
(Normalizer::compare):
* icu/unicode/numfmt.h: Added.
(NumberFormat::isParseIntegerOnly):
(NumberFormat::isLenient):
* icu/unicode/numsys.h: Added.
* icu/unicode/parsepos.h: Added.
(ParsePosition::operator=):
(ParsePosition::operator==):
(ParsePosition::operator!=):
(ParsePosition::getIndex):
(ParsePosition::setIndex):
(ParsePosition::getErrorIndex):
(ParsePosition::setErrorIndex):
* icu/unicode/plurfmt.h: Added.
* icu/unicode/plurrule.h: Added.
* icu/unicode/rbbi.h: Added.
(RuleBasedBreakIterator::operator!=):
* icu/unicode/rbnf.h: Added.
(RuleBasedNumberFormat::isLenient):
(RuleBasedNumberFormat::getDefaultRuleSet):
* icu/unicode/rbtz.h: Added.
* icu/unicode/regex.h: Added.
* icu/unicode/region.h: Added.
* icu/unicode/reldatefmt.h: Added.
* icu/unicode/resbund.h: Added.
* icu/unicode/schriter.h: Added.
* icu/unicode/scientificnumberformatter.h: Added.
* icu/unicode/search.h: Added.
(SearchIterator::operator!=):
* icu/unicode/selfmt.h: Added.
* icu/unicode/simpletz.h: Added.
(SimpleTimeZone::setStartRule):
(SimpleTimeZone::setEndRule):
(SimpleTimeZone::getOffset):
* icu/unicode/smpdtfmt.h: Added.
(SimpleDateFormat::get2DigitYearStart):
* icu/unicode/sortkey.h: Added.
(CollationKey::operator!=):
(CollationKey::isBogus):
(CollationKey::getByteArray):
* icu/unicode/stringtriebuilder.h: Added.
* icu/unicode/stsearch.h: Added.
* icu/unicode/symtable.h: Added.
* icu/unicode/tblcoll.h: Added.
* icu/unicode/timezone.h: Added.
(TimeZone::getID):
(TimeZone::setID):
* icu/unicode/tmunit.h: Added.
* icu/unicode/tmutamt.h: Added.
(TimeUnitAmount::operator!=):
* icu/unicode/tmutfmt.h: Added.
(TimeUnitFormat::operator!=):
* icu/unicode/translit.h: Added.
(Transliterator::getMaximumContextLength):
(Transliterator::setID):
(Transliterator::integerToken):
(Transliterator::pointerToken):
* icu/unicode/tzfmt.h: Added.
* icu/unicode/tznames.h: Added.
* icu/unicode/tzrule.h: Added.
* icu/unicode/tztrans.h: Added.
* icu/unicode/ubidi.h: Added.
* icu/unicode/ucal.h: Renamed from Source/JavaScriptCore/icu/unicode/ucal.h.
* icu/unicode/ucasemap.h: Added.
* icu/unicode/ucat.h: Added.
* icu/unicode/ucharstrie.h: Added.
* icu/unicode/ucharstriebuilder.h: Added.
* icu/unicode/uchriter.h: Added.
* icu/unicode/uclean.h: Added.
* icu/unicode/ucnv_cb.h: Renamed from Source/WebCore/icu/unicode/ucnv_cb.h.
* icu/unicode/ucnvsel.h: Added.
* icu/unicode/ucoleitr.h: Renamed from Source/WebCore/icu/unicode/ucoleitr.h.
* icu/unicode/uconfig.h:
* icu/unicode/ucsdet.h: Renamed from Source/WebCore/icu/unicode/ucsdet.h.
* icu/unicode/udat.h: Renamed from Source/JavaScriptCore/icu/unicode/udat.h.
* icu/unicode/udata.h: Added.
* icu/unicode/udateintervalformat.h: Added.
* icu/unicode/udatpg.h: Renamed from Source/JavaScriptCore/icu/unicode/udatpg.h.
* icu/unicode/udisplaycontext.h: Renamed from Source/JavaScriptCore/icu/unicode/udisplaycontext.h.
* icu/unicode/ufieldpositer.h: Renamed from Source/JavaScriptCore/icu/unicode/ufieldpositer.h.
* icu/unicode/uformattable.h: Renamed from Source/JavaScriptCore/icu/unicode/uformattable.h.
* icu/unicode/ugender.h: Added.
* icu/unicode/uidna.h: Renamed from Source/WebCore/icu/unicode/uidna.h.
* icu/unicode/uldnames.h: Added.
* icu/unicode/ulistformatter.h: Added.
* icu/unicode/ulocdata.h: Added.
* icu/unicode/umisc.h: Renamed from Source/JavaScriptCore/icu/unicode/umisc.h.
* icu/unicode/umsg.h: Added.
* icu/unicode/unifilt.h: Added.
* icu/unicode/unifunct.h: Added.
* icu/unicode/unimatch.h: Added.
* icu/unicode/unirepl.h: Added.
* icu/unicode/uniset.h: Added.
(UnicodeSet::operator!=):
(UnicodeSet::isFrozen):
(UnicodeSet::containsSome):
(UnicodeSet::isBogus):
(UnicodeSet::fromUSet):
(UnicodeSet::toUSet):
(UnicodeSet::span):
(UnicodeSet::spanBack):
* icu/unicode/unum.h: Renamed from Source/JavaScriptCore/icu/unicode/unum.h.
* icu/unicode/unumsys.h: Renamed from Source/JavaScriptCore/icu/unicode/unumsys.h.
* icu/unicode/upluralrules.h: Added.
* icu/unicode/uregex.h: Added.
* icu/unicode/uregion.h: Added.
* icu/unicode/urep.h: Added.
* icu/unicode/ures.h: Added.
(ures_getUnicodeString):
(ures_getNextUnicodeString):
(ures_getUnicodeStringByIndex):
(ures_getUnicodeStringByKey):
* icu/unicode/usearch.h: Renamed from Source/WebCore/icu/unicode/usearch.h.
* icu/unicode/usetiter.h: Added.
(UnicodeSetIterator::isString):
(UnicodeSetIterator::getCodepoint):
(UnicodeSetIterator::getCodepointEnd):
* icu/unicode/ushape.h: Renamed from Source/WebCore/icu/unicode/ushape.h.
* icu/unicode/uspoof.h: Added.
* icu/unicode/usprep.h: Added.
* icu/unicode/ustdio.h: Added.
* icu/unicode/ustream.h: Added.
* icu/unicode/ustringtrie.h: Added.
* icu/unicode/utf32.h: Added.
* icu/unicode/utmscale.h: Added.
* icu/unicode/utrace.h: Added.
* icu/unicode/utrans.h: Added.
* icu/unicode/utypes.h:
* icu/unicode/vtzone.h: Added.

Tools:

* DumpRenderTree/mac/Configurations/Base.xcconfig:
* TestWebKitAPI/Configurations/Base.xcconfig:
* WebKitTestRunner/Configurations/Base.xcconfig:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoRegression(r218821): Bad cast to WebKit::DiagnosticLoggingClient in WKWebView's _setD...
cdumez@apple.com [Wed, 5 Jul 2017 20:41:04 +0000 (20:41 +0000)]
Regression(r218821): Bad cast to WebKit::DiagnosticLoggingClient in WKWebView's _setDiagnosticLoggingDelegate
https://bugs.webkit.org/show_bug.cgi?id=174163
<rdar://problem/33067518>

Reviewed by Alex Christensen.

Source/WebKit2:

After r218821, WebPageProxy::setDiagnosticLoggingClient() would no longer set the client in
private session. This is an issue because there is code in WKWebView which expects the
DiagnosticLoggingClient to be set and of a specific type. This would lead to bad casts in
WKWebView's _diagnosticLoggingDelegate / _setDiagnosticLoggingDelegate.

To avoid the issue, we now unconditionally update the client in
WebPageProxy::setDiagnosticLoggingClient(). Instead, we implement the logic for disabling
logging in private session in the logging methods themselves, via the
WebPageProxy::effectiveDiagnosticLoggingClient() helper instead.

I also added null checks in WKWebView's _diagnosticLoggingDelegate /
_setDiagnosticLoggingDelegate. Even though the WKWebView sets itself as the diagnostic
logging client, WebPageProxy::diagnosticLoggingClient() can still return null after
calling WebPageProxy::close(). Previously, we would have done a bad cast if the WKWebView's
client would have used this API after calling 'close' as well.

* UIProcess/API/APIDiagnosticLoggingClient.h:
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _diagnosticLoggingDelegate]):
(-[WKWebView _setDiagnosticLoggingDelegate:]):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::setDiagnosticLoggingClient):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::effectiveDiagnosticLoggingClient):
(WebKit::WebPageProxy::logDiagnosticMessage):
(WebKit::WebPageProxy::logDiagnosticMessageWithResult):
(WebKit::WebPageProxy::logDiagnosticMessageWithValue):
(WebKit::WebPageProxy::logDiagnosticMessageWithEnhancedPrivacy):
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::diagnosticLoggingClient):

Tools:

Add API test coverage.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDiagnosticLogging.mm: Added.
(TEST):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoWhen dragging a selection, clearing the selection in dragstart should not crash the...
wenson_hsieh@apple.com [Wed, 5 Jul 2017 20:32:41 +0000 (20:32 +0000)]
When dragging a selection, clearing the selection in dragstart should not crash the web process
https://bugs.webkit.org/show_bug.cgi?id=174142
<rdar://problem/33067501>

Reviewed by Tim Horton.

Source/WebCore:

Currenly, if the page clears the current selection after dragging starts on selected content, the web process
will crash while attempting to write pasteboard data for a nonexistent selection. This patch adds a trivial
check for this case, bailing if no DHTML dragging data was specified by the page during a selection drag and the
selection has been cleared.

Also removes some unused code for estimating the bounds of the current selection. On iOS, dragging was actually
crashing earlier, in this codepath. However, this information isn't even used anymore, since the drag anchor
point is no longer necessary on iOS.

Test: DataInteractionTests.DoNotCrashWhenSelectionIsClearedInDragStart

* page/DragController.cpp:
(WebCore::DragController::startDrag):

Tools:

Adds a unit test checking that the web process does not crash when the selection is cleared while a selection
drag is starting up.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-clear-selection.html: Added.
* TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
(TestWebKitAPI::TEST):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoTry to fix iOS 10.3 public SDK builds.
simon.fraser@apple.com [Wed, 5 Jul 2017 20:27:24 +0000 (20:27 +0000)]
Try to fix iOS 10.3 public SDK builds.

* platform/spi/cocoa/IOSurfaceSPI.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoREGRESSION (r217522): "Show My Relationship" link in familysearch.org does not work.
zalan@apple.com [Wed, 5 Jul 2017 20:21:34 +0000 (20:21 +0000)]
REGRESSION (r217522): "Show My Relationship" link in familysearch.org does not work.
https://bugs.webkit.org/show_bug.cgi?id=174070
LayoutTests/imported/w3c:

Reviewed by Simon Fraser.

* web-platform-tests/css-timing-1/frames-timing-functions-output-expected.txt:
* web-platform-tests/html/semantics/interactive-elements/the-dialog-element/centering-expected.txt:

Source/WebCore:

<rdar://problem/32940653>

Reviewed by Simon Fraser.

Decouple in- and out-of-flow computed position values. Now we match blink's implementation on
in-flow values.
This also fixes the flickering content while scrolling on hbr.org.

Covered by existing test cases.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::positionOffsetValue):

LayoutTests:

Reviewed by Simon Fraser.

* fast/css/getComputedStyle/computed-style-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoWeb Inspector: Allow users to log any tracked canvas context
drousso@apple.com [Wed, 5 Jul 2017 20:13:56 +0000 (20:13 +0000)]
Web Inspector: Allow users to log any tracked canvas context
https://bugs.webkit.org/show_bug.cgi?id=173397
<rdar://problem/33111581>

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

* inspector/protocol/Canvas.json:
Add `resolveCanvasContext` command that returns a RemoteObject for the given canvas context.

Source/WebCore:

Tests: inspector/canvas/resolveCanvasContext-2d.html
       inspector/canvas/resolveCanvasContext-webgl.html
       inspector/canvas/resolveCanvasContext-webgl2.html
       inspector/canvas/resolveCanvasContext-webgpu.html

* inspector/InspectorCanvasAgent.h:
* inspector/InspectorCanvasAgent.cpp:
(WebCore::InspectorCanvasAgent::InspectorCanvasAgent):
(WebCore::contextAsScriptValue):
(WebCore::InspectorCanvasAgent::resolveCanvasContext):

Source/WebInspectorUI:

* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Protocol/RemoteObject.js:
(WebInspector.RemoteObject.resolveCanvasContext):
* UserInterface/Views/CanvasTreeElement.js:
(WebInspector.CanvasTreeElement.prototype.populateContextMenu):

LayoutTests:

* inspector/canvas/resolveCanvasContext-2d-expected.txt: Added.
* inspector/canvas/resolveCanvasContext-2d.html: Added.
* inspector/canvas/resolveCanvasContext-webgl-expected.txt: Added.
* inspector/canvas/resolveCanvasContext-webgl.html: Added.
* inspector/canvas/resolveCanvasContext-webgl2-expected.txt: Added.
* inspector/canvas/resolveCanvasContext-webgl2.html: Added.
* inspector/canvas/resolveCanvasContext-webgpu-expected.txt: Added.
* inspector/canvas/resolveCanvasContext-webgpu.html: Added.
* platform/gtk/TestExpectations:
* platform/ios/TestExpectations:
* platform/win/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoDo not pass API::FrameInfo for source frame or clear out page of target frame on
dbates@webkit.org [Wed, 5 Jul 2017 20:10:19 +0000 (20:10 +0000)]
Do not pass API::FrameInfo for source frame or clear out page of target frame on
API navigation
https://bugs.webkit.org/show_bug.cgi?id=174170
<rdar://problem/33140328>

Reviewed by Brady Eidson.

Source/WebKit2:

As a step towards making it straightforward for an embedding client to determine whether
a WebPageProxy::decidePolicyForNavigationAction() callback was initiated from API we
should not pass frame info for the source frame and should not nullify the page pointer
in the target frame info.

Currently we always pass frame info for the source frame and nullify the page pointer
in both the source frame info and target frame info if the navigation was initiated from
API. This seems subtle and error prone. Instead we should not pass frame info for
the source frame and not nullify the page pointer in the target frame info as a step
towards making using this API less error-prone.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForNavigationAction):

Tools:

Update tests as needed for the behavior change.

* TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
(TEST):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoAdd a few more WebKit2 owners
cdumez@apple.com [Wed, 5 Jul 2017 20:07:10 +0000 (20:07 +0000)]
Add a few more WebKit2 owners
https://bugs.webkit.org/show_bug.cgi?id=174169

Reviewed by Brady Eidson.

* Owners:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoStyle sharing check for fullscreen element seems bogus.
commit-queue@webkit.org [Wed, 5 Jul 2017 19:58:47 +0000 (19:58 +0000)]
Style sharing check for fullscreen element seems bogus.
https://bugs.webkit.org/show_bug.cgi?id=160196

Patch by Emilio Cobos Álvarez <ecobos@igalia.com> on 2017-07-05
Reviewed by Antti Koivisto.

No new tests (no easy way to test this reliably).

* style/StyleSharingResolver.cpp:
(WebCore::Style::SharingResolver::canShareStyleWithElement):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoAdd a logging channel for IOSurface allocations
simon.fraser@apple.com [Wed, 5 Jul 2017 19:56:23 +0000 (19:56 +0000)]
Add a logging channel for IOSurface allocations
https://bugs.webkit.org/show_bug.cgi?id=174167

Reviewed by Tim Horton.

Add an "IOSurface" log channel, make IOSurface TextStream-loggable, and log cached
and new IOSurface allocations. Do some namespace-related cleanup.

* platform/Logging.h:
* platform/graphics/cocoa/IOSurface.h:
* platform/graphics/cocoa/IOSurface.mm:
(WebCore::WebCore::IOSurface::create):
(WebCore::WebCore::IOSurface::surfaceID):
(WebCore::operator<<):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoLow memory notification shouldn't cause style recalc
antti@apple.com [Wed, 5 Jul 2017 19:53:55 +0000 (19:53 +0000)]
Low memory notification shouldn't cause style recalc
https://bugs.webkit.org/show_bug.cgi?id=173574
<rdar://problem/32616997>

Reviewed by Andreas Kling.

Source/WebCore:

Patch mostly by Myles.

When we receive a low memory warning, we clear the style resolver. Previously, we were using
this as an opportunity to also purge the CSSFontSelector. However, purging the font selector
is wasteful, since the exact same set of CSSFontFace objects will be recreated as soon as the
CSSFontSelector is recreated. It's also harmful because this purge operation causes fonts to
be removed from the document's working set, and therefore triggers a relayout. Instead, this
call should be softened to only delete any transitory caches the CSSFontSelector owns.

We can simply delay the rebuild of the CSSFontSelector to
StyleResolver::appendAuthorStyleSheets(), when it's really needed. This way, we can sidestep
this whole problem.

There's also an added benefit: Now, buildStarted() doesn't have to be idempotent, so we can
enforce a stricter calling sequence with ASSERT()s.

* css/CSSFontFaceSet.cpp:
(WebCore::CSSFontFaceSet::emptyCaches):
* css/CSSFontFaceSet.h:
* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::emptyCaches):

    Add a separate function to clear font selector caches.

(WebCore::CSSFontSelector::buildStarted):
(WebCore::CSSFontSelector::buildCompleted):
(WebCore::CSSFontSelector::addFontFaceRule):
(WebCore::CSSFontSelector::fontModified):

    No need to invalidate while building.

(WebCore::CSSFontSelector::fontRangesForFamily):
* css/CSSFontSelector.h:
* css/StyleResolver.cpp:
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::addCurrentSVGFontFaceRules):

    Factor into a function from the constructor.

(WebCore::StyleResolver::appendAuthorStyleSheets):

    Font selector build is now started and finished by StyleScope.

* css/StyleResolver.h:
* dom/Document.cpp:
(WebCore::Document::resolveStyle):

    Call FrameView::styleDidChange() to update any custom scrollbars.
    This bug was hidden by spurious style recalcs, tested by fast/css/scrollbar-dynamic-style-change.html

(WebCore::Document::userAgentShadowTreeStyleResolver):
(WebCore::Document::didClearStyleResolver):

    Don't start the font selector rebuild after clearing the resolver. It would cause style recalc trashing.
    Instead the build starts when the new resolver is constructed.

* page/MemoryRelease.cpp:
(WebCore::releaseCriticalMemory):

    Release font selector caches.

* style/StyleScope.cpp:
(WebCore::Style::Scope::resolver):

LayoutTests:

* platform/mac/printing/width-overflow-expected.txt:

    1px width change that doesn't affect what is being tested.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[WK2] Prevent ResourceLoadStatistics from triggering a cascade of read/write events
bfulgham@apple.com [Wed, 5 Jul 2017 19:05:24 +0000 (19:05 +0000)]
[WK2] Prevent ResourceLoadStatistics from triggering a cascade of read/write events
https://bugs.webkit.org/show_bug.cgi?id=174062\
<rdar://problem/33086744>

Reviewed by Chris Dumez.

Source/WebCore:

Treat DISPATCH_VNODE_DELETE, DISPATCH_VNODE_RENAME, and DISPATCH_VNODE_REVOKE as equivalent
"file is unavailable" events, and act as though the file was deleted. Don't listen for
DISPATCH_VNODE_EXTEND, since we always get a DISPATCH_VNODE_WRITE as well, and we only
want to read once.

Finally, add some logging to support future investigations.

* platform/FileMonitor.h:
(WebCore::FileMonitor::platformMonitor): Expose dispatch_source_t for logging purposes.
* platform/cocoa/FileMonitorCocoa.mm:
(WebCore::FileMonitor::startMonitoring): Add logging.
(WebCore::FileMonitor::stopMonitoring): Ditto.

Source/WebKit2:

ResourceLoadStatistics was triggering periods of high CPU use due to a cascade of read/write
operations:
(1) The 'makeRefPtr' call in FileMonitor::startMonitoring was capturing a reference to itself, preventing
    the FileMonitor from being destroyed. This caused the file modification handler to fire in response
    to our own write events, creating a ridiculous read/write cycle. This problem was addressed in
    the short term by stopping the file monitor in WebResourceLoadStatisticsStore::stopMonitoringStatisticsStorage,
    rather than relying on the destructor to shut things down. This will be improved in a
    subsequent patch.
(2) 'syncWithExistingStatisticsStorageIfNeeded' was creating a FileMonitor during the write operation,
    which exacerbated the chain of read/writes already present due to the self-reference described above.
(3) Because VNODE dispatch sources are low level, they do not offer a means of filtering out operations
    triggered by the current process. To avoid this, I added code to track the file modification time, so
    that we don't bother reading a file that holds data that is older than the in-memory data, even though
    we receive a file modification dispatch. Writes seem to trigger a chain of notification events in rapid
    succession. Once we've responded to the first of these events, we don't need to to further reads until
    the data on disk changes again.

We also shouldn't allow the ResourceLoadStatistics worker thread to consume high CPU resources. Run it
as utility QoS, avoiding using the CPU when other work is going on.

Drive-by fix: The closure in setWritePersistentStoreCallback() should stop monitoring before writing
data, and should start monitoring after the write completes.

* UIProcess/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::WebResourceLoadStatisticsStore): Run our worker queue
as a utility-level process.
(WebKit::WebResourceLoadStatisticsStore::registerSharedResourceLoadObserver): Stop checking for
updates before writing, and begin checking again once the write is complete.
(WebKit::WebResourceLoadStatisticsStore::statisticsFileModificationTime): Added.
(WebKit::WebResourceLoadStatisticsStore::readDataFromDiskIfNeeded): Avoid reading the file if it
was last modified on (or before) the time we last read the file.
(WebKit::WebResourceLoadStatisticsStore::refreshFromDisk): Ditto.
(WebKit::WebResourceLoadStatisticsStore::stopMonitoringStatisticsStorage): Explicitly stop file
monitoring so that the active file modification handler will terminate.
(WebKit::WebResourceLoadStatisticsStore::syncWithExistingStatisticsStorageIfNeeded): Do not begin
monitoring the file after syncing, since this is only used as part of an ongoing write operation.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoVersioning.
jmarcell@apple.com [Wed, 5 Jul 2017 18:40:18 +0000 (18:40 +0000)]
Versioning.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoMove internal iOS 11 TestExpectations to OpenSource
jbedard@apple.com [Wed, 5 Jul 2017 18:36:36 +0000 (18:36 +0000)]
Move internal iOS 11 TestExpectations to OpenSource
<rdar://problem/32717028>

Unreviewed test gardening.

* platform/ios-11: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoAdd WebKitPrivateFrameworkStubs for iOS 11
jbedard@apple.com [Wed, 5 Jul 2017 18:14:41 +0000 (18:14 +0000)]
Add WebKitPrivateFrameworkStubs for iOS 11
https://bugs.webkit.org/show_bug.cgi?id=173988

Reviewed by David Kilzer.

Source/JavaScriptCore:

* Configurations/Base.xcconfig: iphoneos and iphonesimulator should use the
same directory for private framework stubs.

Source/WebCore:

* Configurations/WebCore.xcconfig: iphoneos and iphonesimulator should use the
same directory for private framework stubs.

Source/WebCore/PAL:

* Configurations/PAL.xcconfig: iphoneos and iphonesimulator should use the
same directory for private framework stubs.

Source/WebKit/mac:

* Configurations/WebKitLegacy.xcconfig: iphoneos and iphonesimulator should
use the same directory for private framework stubs.

Source/WebKit2:

* Configurations/BaseTarget.xcconfig: iphoneos and iphonesimulator should use the
same directory for private framework stubs.

Tools:

* DumpRenderTree/mac/Configurations/Base.xcconfig: iphoneos and iphonesimulator
should use the same directory for private framework stubs.
* WebKitTestRunner/Configurations/Base.xcconfig: Ditto.

WebKitLibraries:

* WebKitPrivateFrameworkStubs/iOS/9: Add Mac architecture for Simulator.
* WebKitPrivateFrameworkStubs/iOS/10: Ditto..
* WebKitPrivateFrameworkStubs/iOS/11: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[iOS] WKActionSheetAssistants can outlive their host views
aestes@apple.com [Wed, 5 Jul 2017 18:08:32 +0000 (18:08 +0000)]
[iOS] WKActionSheetAssistants can outlive their host views
https://bugs.webkit.org/show_bug.cgi?id=174160
<rdar://problem/20638607>

Reviewed by Tim Horton.

WKActionSheetAssistant keeps a raw pointer to its host UIView, and nothing clears it when
the host view is deallocated. If the assistant outlives the view, we can end up accessing a
pointer to a deallocated UIView and crashing.

I don't know how to reproduce such a crash, but this patch guards against it by doing the
following:

1. Make _view a WeakObjCPtr in WKActionSheetAssistant to ensure it gets set to nil when the
   UIView is deallocated.
2. Call -[WKActionSheetAssistant cleanupSheet] when a WKContentView or WKPDFView is
   deallocated, or when the Web process crashes. This will ensure the action sheet is
   dismissed and prevent the user from tapping on an action that's no longer valid.

* UIProcess/ios/WKActionSheetAssistant.mm:
(-[WKActionSheetAssistant superviewForSheet]):
(-[WKActionSheetAssistant _presentationRectForSheetGivenPoint:inHostView:]):
(-[WKActionSheetAssistant presentationRectForElementUsingClosestIndicatedRect]):
(-[WKActionSheetAssistant presentationRectForIndicatedElement]):
(-[WKActionSheetAssistant _shouldPresentAtTouchLocationForElementRect:]):
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView cleanupInteraction]):
* UIProcess/ios/WKPDFView.mm:
(-[WKPDFView dealloc]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoDon't resolve an extra computed style for getComputedStyle in a display: none subtree.
commit-queue@webkit.org [Wed, 5 Jul 2017 18:01:45 +0000 (18:01 +0000)]
Don't resolve an extra computed style for getComputedStyle in a display: none subtree.
https://bugs.webkit.org/show_bug.cgi?id=174145

Before this, we were also resolving the first ancestor's style as
inheriting from itself, which felt pretty wrong (though I think it's
not observable).

Patch by Emilio Cobos Álvarez <ecobos@igalia.com> on 2017-07-05
Reviewed by Antti Koivisto.

No new tests (non-observable behavior).

* dom/Element.cpp:
(WebCore::Element::resolveComputedStyle):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoMove ScrolledContentsLayer property to ScrollingStateScrollingNode
fred.wang@free.fr [Wed, 5 Jul 2017 17:56:11 +0000 (17:56 +0000)]
Move ScrolledContentsLayer property to ScrollingStateScrollingNode
https://bugs.webkit.org/show_bug.cgi?id=174134

Patch by Frederic Wang <fwang@igalia.com> on 2017-07-05
Reviewed by Simon Fraser.

Source/WebCore:

ScrollingStateFrameScrollingNode and ScrollingStateOverflowScrollingNode both use a
ScrolledContentsLayer property for the same purpose. This commit moves that property into
their parent class ScrollingStateScrollingNode, so that more code is shared between the two
classes. This will also help the refactoring in bug 174130.

No new tests, only dumped tree may change a bit.

* page/scrolling/ScrollingStateFrameScrollingNode.cpp: Remove scrolled contents layer.
(WebCore::ScrollingStateFrameScrollingNode::ScrollingStateFrameScrollingNode):
(WebCore::ScrollingStateFrameScrollingNode::dumpProperties):
(WebCore::ScrollingStateFrameScrollingNode::setScrolledContentsLayer): Deleted.
* page/scrolling/ScrollingStateFrameScrollingNode.h: Ditto.
* page/scrolling/ScrollingStateOverflowScrollingNode.cpp: Ditto.
(WebCore::ScrollingStateOverflowScrollingNode::ScrollingStateOverflowScrollingNode):
(WebCore::ScrollingStateOverflowScrollingNode::dumpProperties):
(WebCore::ScrollingStateOverflowScrollingNode::setScrolledContentsLayer): Deleted.
* page/scrolling/ScrollingStateOverflowScrollingNode.h: Ditto.
(): Deleted.
(WebCore::ScrollingStateOverflowScrollingNode::scrolledContentsLayer): Deleted.
* page/scrolling/ScrollingStateScrollingNode.cpp: Add scrolled contents layer.
(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):
(WebCore::ScrollingStateScrollingNode::setScrolledContentsLayer):
(WebCore::ScrollingStateScrollingNode::dumpProperties): Use the label from the overflow class
which is different from the frame class. The dumping order may change a bit too.
* page/scrolling/ScrollingStateScrollingNode.h: Add ScrolledContentsLayer to the enum and
scrolled contents layer.
(WebCore::ScrollingStateScrollingNode::scrolledContentsLayer):
* page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:
(WebCore::ScrollingTreeFrameScrollingNodeMac::commitStateBeforeChildren): Adjust enum value
to use ScrollingStateScrollingNode::ScrolledContentsLayer.

Source/WebKit2:

* Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:
(ArgumentCoder<ScrollingStateScrollingNode>::encode): Add encoding for scrolled contents
layer.
(ArgumentCoder<ScrollingStateFrameScrollingNode>::encode): Remove encoding for scrolled
contents layer.
(ArgumentCoder<ScrollingStateOverflowScrollingNode>::encode): Ditto.
(ArgumentCoder<ScrollingStateScrollingNode>::decode): Add decoding for scrolled contents
layer.
(ArgumentCoder<ScrollingStateFrameScrollingNode>::decode): Remove decoding for scrolled
contents layer.
(ArgumentCoder<ScrollingStateOverflowScrollingNode>::decode): Ditto.
(WebKit::dump): Move dumping of scrolled contents layer from overflow/frame nodes to
scrolling node.
* UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp:
(WebKit::RemoteScrollingCoordinatorProxy::connectStateNodeLayers): Adjust enum value to use
ScrollingStateScrollingNode::ScrolledContentsLayer.
* UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::commitStateBeforeChildren): Ditto.
* UIProcess/ios/RemoteScrollingCoordinatorProxyIOS.mm:
(WebKit::RemoteScrollingCoordinatorProxy::connectStateNodeLayers): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoFix crash in UIKit: +[UIViewController _viewControllerForFullScreenPresentationFromView:]
adachan@apple.com [Wed, 5 Jul 2017 17:43:59 +0000 (17:43 +0000)]
Fix crash in UIKit: +[UIViewController _viewControllerForFullScreenPresentationFromView:]
https://bugs.webkit.org/show_bug.cgi?id=174143
<rdar://problem/28384582>

Reviewed by Wenson Hsieh.

In -[WKActionSheet willRotate], we can't guarantee that the action sheet belongs
in a window, and passing nil to +[UIViewController _viewControllerForFullScreenPresentationFromView:]
throws an exception. To fix this, bail early if the result from -hostViewForSheet is nil.

* UIProcess/ios/WKActionSheet.mm:
(-[WKActionSheet willRotate]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[MediaStream] Protect request and web view during gUM client callback
eric.carlson@apple.com [Wed, 5 Jul 2017 17:41:47 +0000 (17:41 +0000)]
[MediaStream] Protect request and web view during gUM client callback
https://bugs.webkit.org/show_bug.cgi?id=174096
<rdar://problem/32833102>

Reviewed by Youenn Fablet.

Source/WebKit2:

Retain the message and WebView during asynchronous calls so they won't be
released if a navigation happens during a call to the UA for getUserMedia
or enumerateMediaDevices.

* UIProcess/Cocoa/UIDelegate.mm:
(WebKit::requestUserMediaAuthorizationForDevices):
(WebKit::UIDelegate::UIClient::decidePolicyForUserMediaPermissionRequest):
(WebKit::UIDelegate::UIClient::checkUserMediaPermissionForOrigin):

Tools:

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoWebAssembly: implement name section's module name, skip unknown sections
jfbastien@apple.com [Wed, 5 Jul 2017 16:51:59 +0000 (16:51 +0000)]
WebAssembly: implement name section's module name, skip unknown sections
https://bugs.webkit.org/show_bug.cgi?id=172008

Reviewed by Keith Miller.

Parse the WebAssembly module name properly, and skip unknown
sections. This is useful because as toolchains support new types
of names we want to keep displaying the information we know about
and simply ignore new information. That capability was designed
into WebAssembly's name section.

Failure to commit this patch would mean that WebKit won't display
stack trace information, which would make developers sad.

Module names were added here: https://github.com/WebAssembly/design/pull/1055

Note that this patch doesn't do anything with the parsed name! Two
reasons for this: module names aren't supported in binaryen yet,
so I can't write a simple binary test; and using the name is a
slightly riskier change because it requires changing StackVisitor
+ StackFrame (where they print "[wasm code]") which requires
figuring out the frame's Module. The latter bit isn't trivial
because we only know wasm frames from their tag bits, and
CodeBlocks are always nullptr.

Binaryen bug: https://github.com/WebAssembly/binaryen/issues/1010

I filed #174098 to use the module name.

* wasm/WasmFormat.h:
(JSC::Wasm::isValidNameType):
* wasm/WasmNameSectionParser.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoAdjusted test expectations for tiled-drawing/scrolling/fast-scroll-iframe-latched...
jlewis3@apple.com [Wed, 5 Jul 2017 16:40:55 +0000 (16:40 +0000)]
Adjusted test expectations for tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe.html.
https://bugs.webkit.org/show_bug.cgi?id=168937

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoIncorrect IfModule on Fedora with with PHP 7
commit-queue@webkit.org [Wed, 5 Jul 2017 16:35:41 +0000 (16:35 +0000)]
Incorrect IfModule on Fedora with with PHP 7
https://bugs.webkit.org/show_bug.cgi?id=174159

Patch by Charlie Turner <cturner@igalia.com> on 2017-07-05
Reviewed by Michael Catanzaro.

* http/conf/fedora-httpd-2.4-php7.conf:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed, guard iOS 11-dependent UIPasteboardTests to be iOS 11+ only
wenson_hsieh@apple.com [Wed, 5 Jul 2017 16:17:34 +0000 (16:17 +0000)]
Unreviewed, guard iOS 11-dependent UIPasteboardTests to be iOS 11+ only

* TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoProcessingInstruction::clearExistingCachedSheet doesn't really exist.
commit-queue@webkit.org [Wed, 5 Jul 2017 16:11:58 +0000 (16:11 +0000)]
ProcessingInstruction::clearExistingCachedSheet doesn't really exist.
https://bugs.webkit.org/show_bug.cgi?id=174146

Patch by Emilio Cobos Álvarez <ecobos@igalia.com> on 2017-07-05
Reviewed by Chris Dumez.

No new tests (no functionality change).

* dom/ProcessingInstruction.h: Remove dead declaration.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed, rolling out r219128.
jlewis3@apple.com [Wed, 5 Jul 2017 16:07:27 +0000 (16:07 +0000)]
Unreviewed, rolling out r219128.

Spoke with engineer who originally submitted, Patch for APi
test to follow.

Reverted changeset:

"Unreviewed, rolling out r219070."
https://bugs.webkit.org/show_bug.cgi?id=174082
http://trac.webkit.org/changeset/219128

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed, rolling out r219070.
jlewis3@apple.com [Wed, 5 Jul 2017 15:59:45 +0000 (15:59 +0000)]
Unreviewed, rolling out r219070.

This revision caused consistent failures of the API test
UIPasteboardTests.DoNotPastePlainTextAsURL on iOS.

Reverted changeset:

"Pasting single words copied to UIPasteboard inserts URLs in
editable areas"
https://bugs.webkit.org/show_bug.cgi?id=174082
http://trac.webkit.org/changeset/219070

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoReceiving tracks should be ended when peer connection is being closed
commit-queue@webkit.org [Wed, 5 Jul 2017 15:53:17 +0000 (15:53 +0000)]
Receiving tracks should be ended when peer connection is being closed
https://bugs.webkit.org/show_bug.cgi?id=174109

Patch by Youenn Fablet <youenn@apple.com> on 2017-07-05
Reviewed by Eric Carlson.

Source/WebCore:

Test: webrtc/peer-connection-track-end.html

As per https://www.w3.org/TR/webrtc/#dom-rtcpeerconnection-close, tracks should be ended when peer connection is closed.
Also updating transceiver stopped state.

* Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::doClose):
* Modules/mediastream/RTCRtpReceiver.cpp:
(WebCore::RTCRtpReceiver::stop):
* Modules/mediastream/RTCRtpReceiver.h:

LayoutTests:

* webrtc/peer-connection-track-end-expected.txt: Added.
* webrtc/peer-connection-track-end.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[GLib] Incorrect <glib/gi18n.h> include in WebKitWebsiteData
zandobersek@gmail.com [Wed, 5 Jul 2017 14:05:47 +0000 (14:05 +0000)]
[GLib] Incorrect <glib/gi18n.h> include in WebKitWebsiteData
https://bugs.webkit.org/show_bug.cgi?id=174093

Reviewed by Michael Catanzaro.

* UIProcess/API/glib/WebKitWebsiteData.cpp: Include <glib/gi18n-lib.h>
rather than <glib/gi18n.h>, since the former has to be included in a
library while the latter should only be included in a standalone application.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed, review follow-up after r218961
said@apple.com [Wed, 5 Jul 2017 04:44:26 +0000 (04:44 +0000)]
Unreviewed, review follow-up after r218961

* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::updateFromSettings):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[WTF] Make double-conversion's cache data constant and drop double_conversion::initia...
utatane.tea@gmail.com [Wed, 5 Jul 2017 00:59:11 +0000 (00:59 +0000)]
[WTF] Make double-conversion's cache data constant and drop double_conversion::initialize()
https://bugs.webkit.org/show_bug.cgi?id=174124

Reviewed by Saam Barati.

We annotate double-conversion's cache data as const and constexpr. And move it out of function.
Since they are not involving global constructors, they are compiled as rodata and initialized
without calling double_conversion::initialize().

And we drop double_conversion::initialize() function since it is no longer necessary.

* wtf/Threading.cpp:
(WTF::initializeThreading):
* wtf/dtoa/cached-powers.cc:
* wtf/dtoa/cached-powers.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoRenderThemeCocoa::mediaControlsFormattedStringForDuration is leaking NSDateComponents...
antti@apple.com [Tue, 4 Jul 2017 22:07:53 +0000 (22:07 +0000)]
RenderThemeCocoa::mediaControlsFormattedStringForDuration is leaking NSDateComponentsFormatters
https://bugs.webkit.org/show_bug.cgi?id=174138

Reviewed by Ryosuke Niwa.

Saw a random spin here during media playback. Looks like we are leaking.

* rendering/RenderThemeCocoa.h:
* rendering/RenderThemeCocoa.mm:
(WebCore::RenderThemeCocoa::mediaControlsFormattedStringForDuration):

    Reuse NSDateComponentsFormatter.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoRemove unused EFL logo from bot watcher dashboard
mcatanzaro@igalia.com [Tue, 4 Jul 2017 20:14:28 +0000 (20:14 +0000)]
Remove unused EFL logo from bot watcher dashboard
https://bugs.webkit.org/show_bug.cgi?id=174136

Reviewed by Alexey Proskuryakov.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL@2x.png: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoFrameView should not set RenderView::logicalWidth directly for printing
antti@apple.com [Tue, 4 Jul 2017 17:58:36 +0000 (17:58 +0000)]
FrameView should not set RenderView::logicalWidth directly for printing
https://bugs.webkit.org/show_bug.cgi?id=174135

Reviewed by Zalan Bujtas.

Source/WebCore:

Renderer logicalWidth should be set by layout. Direct override by RenderView when printing means
that we don't layout children in all cases when the width changes. This is currently mostly hidden
by spurious layouts but causes problems when trying to fix other things that reduces those.

* page/FrameView.cpp:
(WebCore::FrameView::forceLayoutForPagination):

    Instead of calling setLogicalWidth directly call the new setPageLogicalSize that sets both the width
    and the height uniformly.

* rendering/RenderView.cpp:
(WebCore::RenderView::updateLogicalWidth):

    Use pageLogicalSize->width() in printing state instead of skipping the logical width update entirely.
    This ensures that the layout will progress to children when the page logical width changes.

(WebCore::RenderView::initializeLayoutState):
(WebCore::RenderView::layout):
(WebCore::RenderView::pageOrViewLogicalHeight):
(WebCore::RenderView::setPageLogicalSize):
* rendering/RenderView.h:

    Replace the existing m_pageLogicalHeight with std::optional m_pageLogicalSize.

LayoutTests:

* platform/mac/printing/width-overflow-expected.txt:

    This is a progression, view and root element sizes now match.
    Printing output is not affected.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[GTK] Add more GTK bots to dashboard
mcatanzaro@igalia.com [Tue, 4 Jul 2017 17:51:30 +0000 (17:51 +0000)]
[GTK] Add more GTK bots to dashboard
https://bugs.webkit.org/show_bug.cgi?id=174129

Reviewed by Carlos Alberto Lopez Perez.

We have a bunch of GTK bots that I never look at because they're not on the dashboard. Add
them.

This also changes the sort order to put WPE above GTK so that it's not buried under all the
less-essential GTK bots.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[WTF] Initialize srandom and srand with cryptographically random number
utatane.tea@gmail.com [Tue, 4 Jul 2017 17:43:18 +0000 (17:43 +0000)]
[WTF] Initialize srandom and srand with cryptographically random number
https://bugs.webkit.org/show_bug.cgi?id=174123

Reviewed by Mark Lam.

Use cryptographically random number instead of current time as a seed.

* wtf/RandomNumberSeed.h:
(WTF::initializeRandomNumberGenerator):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[WPE] Add WPE to bot watcher dashboard
mcatanzaro@igalia.com [Tue, 4 Jul 2017 14:02:42 +0000 (14:02 +0000)]
[WPE] Add WPE to bot watcher dashboard
https://bugs.webkit.org/show_bug.cgi?id=174119

Reviewed by Alexey Proskuryakov.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/CREDIT: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE@2x.png: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot):
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
(table.queue-grid tr.platform.linux-wpe img.logo):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoXcode duplicate UUID for DisallowCType.h and DispatchPtr.h
commit-queue@webkit.org [Tue, 4 Jul 2017 11:43:14 +0000 (11:43 +0000)]
Xcode duplicate UUID for DisallowCType.h and DispatchPtr.h
https://bugs.webkit.org/show_bug.cgi?id=174117

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2017-07-04
Reviewed by Alexey Proskuryakov.

* WTF.xcodeproj/project.pbxproj:
Give DisallowCType.h and DispatchPtr.h different UUIDs.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219117 268f45cc-cd09-0410-ab3c-d52691b4dbfc