WebKit.git
9 years agoUpdate xcodeproj svn:ignore to include xcuserdata.
mitz@apple.com [Mon, 17 Jan 2011 19:50:32 +0000 (19:50 +0000)]
Update xcodeproj svn:ignore to include xcuserdata.

Rubber-stamped by Mark Rowe.

Examples:

* NetscapeCocoaPlugin/NetscapeCocoaPlugin.xcodeproj: Modified property svn:ignore.
* NetscapeCoreAnimationMoviePlugin/NetscapeCoreAnimationMoviePlugin.xcodeproj: Modified property svn:ignore.
* NetscapeCoreAnimationPlugin/NetscapeCoreAnimationPlugin.xcodeproj: Modified property svn:ignore.
* NetscapeInputMethodPlugin/NetscapeInputMethodPlugin.xcodeproj: Modified property svn:ignore.

Source/JavaScriptCore:

* JavaScriptCore.xcodeproj: Modified property svn:ignore.

Source/JavaScriptGlue:

* JavaScriptGlue.xcodeproj: Modified property svn:ignore.

Source/ThirdParty/ANGLE:

* ANGLE.xcodeproj: Modified property svn:ignore.
* src/build_angle.xcodeproj: Modified property svn:ignore.

Source/WebCore:

* WebCore.xcodeproj: Modified property svn:ignore.
* manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj: Modified property svn:ignore.

Source/WebKit:

* WebKit.xcodeproj: Modified property svn:ignore.

Source/WebKit2:

* WebKit2.xcodeproj: Modified property svn:ignore.

Tools:

* DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
* MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
* TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
* WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
* WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Fixing a typo from a bad merge.
ap@apple.com [Mon, 17 Jan 2011 19:48:53 +0000 (19:48 +0000)]
    Fixing a typo from a bad merge.

        * UIProcess/API/mac/WKView.mm: (-[WKView canChangeFrameLayout:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Reviewed by John Sullivan.
ap@apple.com [Mon, 17 Jan 2011 19:43:51 +0000 (19:43 +0000)]
    Reviewed by John Sullivan.

        https://bugs.webkit.org/show_bug.cgi?id=52590
        Should pass a frame into -[WKView canPrintHeadersAndFooters]

        * UIProcess/API/mac/WKView.h:
        * UIProcess/API/mac/WKView.mm: (-[WKView canChangeFrameLayout:]): Also, renamed the method
        to canChangeFrameLayout.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Leopard build fix.
ap@apple.com [Mon, 17 Jan 2011 19:36:19 +0000 (19:36 +0000)]
    Leopard build fix.

        * page/PrintContext.cpp: GCC complained about shortening a double value to float.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove a few more empty directories that I missed.
mrowe@apple.com [Mon, 17 Jan 2011 18:47:04 +0000 (18:47 +0000)]
Remove a few more empty directories that I missed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove a large number of empty directories.
mrowe@apple.com [Mon, 17 Jan 2011 18:41:09 +0000 (18:41 +0000)]
Remove a large number of empty directories.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Reviewed by Dan Bernstein.
ap@apple.com [Mon, 17 Jan 2011 18:31:12 +0000 (18:31 +0000)]
    Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=52495

        No change in behavior, so no tests.

        * WebCore.exp.in: Export additional methods, as I'm going to use more code from PrintContext.

        * page/PrintContext.cpp:
        (WebCore::PrintContext::~PrintContext): No need to clear m_pageRects, the object is being
        destroyed already.
        (WebCore::PrintContext::pageCount): Changed page count from int to size_t.
        (WebCore::PrintContext::pageRect): Ditto.
        (WebCore::PrintContext::computePageRects): Pass allowHorizontalTiling as an argument.
        PrintContext already has code to calculate scale factor, so it makes sense to make methods
        that contain it universal (allowHorizontalTiling is always true for Safari).
        Round page height to an integer, because Mac code does that, and because page height is
        treated as integer almost everywhere else in code.
        (WebCore::PrintContext::begin): Allow calling this function multiple times. There is no need
        to return to screen mode if e.g. "print backgounds" option changes.
        (WebCore::PrintContext::computeAutomaticScaleFactor): Expose scale factor computation, so
        that clients don't have to copy it.
        (WebCore::PrintContext::spoolRect): Add a way to spool a precomputed rect - handy if a request
        comes from code that doesn't have page number.
        (WebCore::PrintContext::pageNumberForElement): Page number int -> size_t.

        * page/PrintContext.h: Added comments and FIXMEs. PrintContext needs cleanup, but that
        depends on deciding how it really needs to work (e.g. whether computePageRects() should
        cause relayout).

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-17 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 17 Jan 2011 18:25:37 +0000 (18:25 +0000)]
2011-01-17  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: skip flaky inspector test (will look at it tomorrow).

        * platform/mac-leopard/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-17 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 17 Jan 2011 18:21:06 +0000 (18:21 +0000)]
2011-01-17  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Implement scrolling support
        https://bugs.webkit.org/show_bug.cgi?id=52502

        * Shared/UpdateInfo.cpp:
        (WebKit::UpdateInfo::encode):
        (WebKit::UpdateInfo::decode):
        * Shared/UpdateInfo.h:
        Add scrollRect and scrollDelta member variables.

        * UIProcess/BackingStore.h:
        Add scroll member function.

        * UIProcess/DrawingAreaProxyImpl.cpp:
        (WebKit::DrawingAreaProxyImpl::incorporateUpdate):
        Repaint the scroll rect. Force a display of the view when the update info contains a scroll rect.

        * UIProcess/mac/BackingStoreMac.mm:
        (WebKit::BackingStore::incorporateUpdate):
        Call scroll.

        (WebKit::BackingStore::scroll):
        Paint the backing store into itself.

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::display):
        Pass the scroll information in the update info.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-17 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 17 Jan 2011 17:51:21 +0000 (17:51 +0000)]
2011-01-17  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: unify image data source assignment, add image url
        to the image view properties list.
        https://bugs.webkit.org/show_bug.cgi?id=52584

        * English.lproj/localizedStrings.js:
        * inspector/front-end/ImageView.js:
        (WebInspector.ImageView.prototype._createContentIfNeeded.onImageLoad):
        (WebInspector.ImageView.prototype._createContentIfNeeded):
        * inspector/front-end/NetworkPanel.js:
        (WebInspector.NetworkDataGridNode.prototype._refreshNameCell):
        * inspector/front-end/Resource.js:
        (WebInspector.Resource.prototype.populateImageSource):
        (WebInspector.Resource.prototype._contentURL):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.FrameResourceTreeElement.prototype.onattach):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix up the `make` build on Macs
beidson@apple.com [Mon, 17 Jan 2011 17:28:59 +0000 (17:28 +0000)]
Fix up the `make` build on Macs

Rubberstamped by Adam Roben.

* Makefile: Point to the correct Makefile.shared

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-17 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Mon, 17 Jan 2011 17:10:32 +0000 (17:10 +0000)]
2011-01-17  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Extensions API] webInspector.resources.onFinished is not fired for redirected resources
        Make resource start/finish hanlding more consistent.
        https://bugs.webkit.org/show_bug.cgi?id=52452

        * inspector/front-end/AuditLauncherView.js: Ignore WebSocket resources when displaying progress indicator
        (WebInspector.AuditLauncherView.prototype._resetResourceCount):
        (WebInspector.AuditLauncherView.prototype.resourceStarted):
        (WebInspector.AuditLauncherView.prototype.resourceFinished):
        * inspector/front-end/NetworkManager.js:
        (WebInspector.NetworkManager): Factor out resource start/finish logic to _startResource()/_finishResource()
        (WebInspector.NetworkManager.prototype.identifierForInitialRequest):
        (WebInspector.NetworkManager.prototype.willSendRequest):
        (WebInspector.NetworkManager.prototype.markResourceAsCached):
        (WebInspector.NetworkManager.prototype.didReceiveResponse):
        (WebInspector.NetworkManager.prototype.didReceiveContentLength):
        (WebInspector.NetworkManager.prototype.didFinishLoading):
        (WebInspector.NetworkManager.prototype.didFailLoading):
        (WebInspector.NetworkManager.prototype.didLoadResourceFromMemoryCache):
        (WebInspector.NetworkManager.prototype.didCreateWebSocket):
        (WebInspector.NetworkManager.prototype.willSendWebSocketHandshakeRequest):
        (WebInspector.NetworkManager.prototype.didReceiveWebSocketHandshakeResponse):
        (WebInspector.NetworkManager.prototype.didCloseWebSocket):
        (WebInspector.NetworkManager.prototype._appendRedirect):
        (WebInspector.NetworkManager.prototype._startResource):
        (WebInspector.NetworkManager.prototype._finishResource):

2011-01-17  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Extensions API] webInspector.resources.onFinished is not fired for redirected resources
        Added test for finished event being sent for redirected resources.
        https://bugs.webkit.org/show_bug.cgi?id=52452

        * http/tests/inspector/extensions-resources-redirect-expected.txt:
        * http/tests/inspector/extensions-resources-redirect.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-17 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 17 Jan 2011 16:42:38 +0000 (16:42 +0000)]
2011-01-17  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: restore dom and network state upon frontend reuse.
        https://bugs.webkit.org/show_bug.cgi?id=52574

        * inspector/Inspector.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::restoreInspectorStateFromCookie):
        (WebCore::InspectorController::populateScriptObjects):
        (WebCore::InspectorController::pushDataCollectedOffline):
        (WebCore::InspectorController::didCommitLoad):
        * inspector/InspectorController.h:
        * inspector/front-end/NetworkManager.js:
        (WebInspector.NetworkManager.prototype.reset):
        * inspector/front-end/NetworkPanel.js:
        (WebInspector.NetworkPanel.prototype.clear):
        (WebInspector.NetworkPanel.prototype.mainResourceChanged):
        * inspector/front-end/ResourceTreeModel.js:
        (WebInspector.ResourceTreeModel):
        (WebInspector.ResourceTreeModel.prototype.reloadCachedResources):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype.clear):
        * inspector/front-end/inspector.js:
        (WebInspector.frontendReused):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed fix after r75908.
ossy@webkit.org [Mon, 17 Jan 2011 16:38:40 +0000 (16:38 +0000)]
Unreviewed fix after r75908.

Move WebKit into Source
https://bugs.webkit.org/show_bug.cgi?id=52530

* BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-17 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 17 Jan 2011 16:33:51 +0000 (16:33 +0000)]
2011-01-17  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: first timeline-network-resource flakiness.

        * inspector/timeline-network-resource.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-17 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Mon, 17 Jan 2011 16:19:25 +0000 (16:19 +0000)]
2011-01-17  Andrey Kosyakov  <caseq@chromium.org>

        Unreviewed. Fixed malformed reference to WebKitVSPropsRedirectionDir that broke win build.

        * win/WebKit2.vcproj:
        * win/WebKit2GeneratedCommon.vsprops:
        * win/WebKit2WebProcess.vcproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed buildfix after r75944.
ossy@webkit.org [Mon, 17 Jan 2011 16:18:06 +0000 (16:18 +0000)]
Unreviewed buildfix after r75944.

* WebCore.pro:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-17 Yi Shen <yi.4.shen@nokia.com>
commit-queue@webkit.org [Mon, 17 Jan 2011 16:00:31 +0000 (16:00 +0000)]
2011-01-17  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Extend the Platform Plugin to support full screen video handler
        https://bugs.webkit.org/show_bug.cgi?id=51249

        Make MediaPlayerPrivateQt support a fullscreen player.

        No new tests because LayoutTests/media/media-fullscreen-inline.html already exists.
        However, this test failed for Qt (QtMediaPlayer) due to durationchange event getting fired twice.
        So, still skip it for Qt.

        * WebCore.pro:
        * features.pri:
        * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
        (WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
        (WebCore::MediaPlayerPrivateQt::removeVideoItem):
        (WebCore::MediaPlayerPrivateQt::restoreVideoItem):
        * platform/graphics/qt/MediaPlayerPrivateQt.h:
        (WebCore::MediaPlayerPrivateQt::supportsFullscreen):
        (WebCore::MediaPlayerPrivateQt::mediaPlayer):
2011-01-17  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Extend the Platform Plugin to support full screen video handler
        https://bugs.webkit.org/show_bug.cgi?id=51249

        Add a new webkit platform plugin interface to support full screen video handler.

        * Api/qwebkitplatformplugin.h:
        (QWebFullScreenVideoHandler::QWebFullScreenVideoHandler):
        (QWebFullScreenVideoHandler::~QWebFullScreenVideoHandler):
        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::ChromeClientQt):
        (WebCore::ChromeClientQt::~ChromeClientQt):
        (WebCore::ChromeClientQt::fullScreenVideo):
        (WebCore::ChromeClientQt::supportsFullscreenForNode):
        (WebCore::ChromeClientQt::requiresFullscreenForVideoPlayback):
        (WebCore::ChromeClientQt::enterFullscreenForNode):
        (WebCore::ChromeClientQt::exitFullscreenForNode):
        * WebCoreSupport/ChromeClientQt.h:
        * WebCoreSupport/FullScreenVideoQt.cpp: Added.
        (WebCore::FullScreenVideoQt::FullScreenVideoQt):
        (WebCore::FullScreenVideoQt::~FullScreenVideoQt):
        (WebCore::FullScreenVideoQt::enterFullScreenForNode):
        (WebCore::FullScreenVideoQt::exitFullScreenForNode):
        (WebCore::FullScreenVideoQt::aboutToClose):
        (WebCore::FullScreenVideoQt::mediaPlayer):
        (WebCore::FullScreenVideoQt::mediaPlayerForNode):
        (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
        * WebCoreSupport/FullScreenVideoQt.h: Added.
        (WebCore::FullScreenVideoQt::isValid):
        * WebCoreSupport/QtPlatformPlugin.cpp:
        (WebCore::QtPlatformPlugin::createFullScreenVideoHandler):
        * WebCoreSupport/QtPlatformPlugin.h:
        * examples/platformplugin/WebPlugin.cpp:
        (FullScreenVideoWidget::FullScreenVideoWidget):
        (FullScreenVideoWidget::event):
        (FullScreenVideoWidget::keyPressEvent):
        (FullScreenVideoHandler::FullScreenVideoHandler):
        (FullScreenVideoHandler::~FullScreenVideoHandler):
        (FullScreenVideoHandler::requiresFullScreenForVideoPlayback):
        (FullScreenVideoHandler::enterFullScreen):
        (FullScreenVideoHandler::exitFullScreen):
        (WebPlugin::supportsExtension):
        (WebPlugin::createExtension):
        * examples/platformplugin/WebPlugin.h:
        (FullScreenVideoWidget::~FullScreenVideoWidget):
        * examples/platformplugin/platformplugin.pro:
        * examples/platformplugin/qwebkitplatformplugin.h:
        (QWebFullScreenVideoHandler::QWebFullScreenVideoHandler):
        (QWebFullScreenVideoHandler::~QWebFullScreenVideoHandler):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-17 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Mon, 17 Jan 2011 15:50:16 +0000 (15:50 +0000)]
2011-01-17  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: fix flaky debugger tests.
        https://bugs.webkit.org/show_bug.cgi?id=51320

        * http/tests/inspector/debugger-test2.js:
        (initialize_DebuggerTest.InspectorTest.setBreakpoint):
        * inspector/debugger-breakpoints-not-activated-on-reload.html:
        * inspector/debugger-pause-on-breakpoint-expected.txt:
        * inspector/debugger-pause-on-breakpoint.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
ossy@webkit.org [Mon, 17 Jan 2011 15:42:04 +0000 (15:42 +0000)]
Unreviewed.

Remove accidentally committed debug printing after r75908.

* Scripts/webkitdirs.pm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
ossy@webkit.org [Mon, 17 Jan 2011 15:38:53 +0000 (15:38 +0000)]
Unreviewed.

Add Qt specific expected results for passing CSS tests.
Compared to Mac png files and Mac expected files.

* platform/qt/Skipped: Unskip passing tests.
* platform/qt/css1/[...]: Added.
* platform/qt/css2.1/[...]: Added.
* platform/qt/css3/[...]: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-17 Anthony Ricaud <rik@webkit.org>
rik@webkit.org [Mon, 17 Jan 2011 14:59:40 +0000 (14:59 +0000)]
2011-01-17  Anthony Ricaud  <rik@webkit.org>

        Reviewed by Kent Tamura.

        [HTML5] Revert display:none on datalist
        https://bugs.webkit.org/show_bug.cgi?id=52214

        * fast/forms/datalist-expected.txt:
        * fast/forms/datalist-nonoption-child-expected.txt:
        * fast/forms/datalist.html:
2011-01-17  Anthony Ricaud  <rik@webkit.org>

        Reviewed by Kent Tamura.

        [HTML5] Revert display:none on datalist
        https://bugs.webkit.org/show_bug.cgi?id=52214

        * css/html.css:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-17 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 17 Jan 2011 14:31:13 +0000 (14:31 +0000)]
2011-01-17  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: simplify debugger enabling routine.
        https://bugs.webkit.org/show_bug.cgi?id=52472

        * inspector/Inspector.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::restoreDebugger):
        (WebCore::InspectorController::showAndEnableDebugger):
        (WebCore::InspectorController::enableDebugger):
        * inspector/InspectorController.h:
        * inspector/front-end/DebuggerModel.js:
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.show):
        (WebInspector.ScriptsPanel.prototype._toggleDebugging):
2011-01-17  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: simplify debugger enabling routine.
        https://bugs.webkit.org/show_bug.cgi?id=52472

        * WebInspector/WebInspector.mm:
        (-[WebInspector startDebuggingJavaScript:]):
2011-01-17  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: simplify debugger enabling routine.
        https://bugs.webkit.org/show_bug.cgi?id=52472

        * WebInspector.cpp:
        (WebInspector::toggleDebuggingJavaScript):
2011-01-17  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: simplify debugger enabling routine.
        https://bugs.webkit.org/show_bug.cgi?id=52472

        * WebProcess/WebPage/WebInspector.cpp:
        (WebKit::WebInspector::startJavaScriptDebugging):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-17 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 17 Jan 2011 14:25:50 +0000 (14:25 +0000)]
2011-01-17  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Chromium: updated DevTools tests.

        * src/js/Tests.js:
        (.TestSuite.prototype._waitForScriptPause):
        (.TestSuite.prototype._waitUntilScriptsAreParsed.waitForAllScripts):
        (.TestSuite.prototype._waitUntilScriptsAreParsed):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-17 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Mon, 17 Jan 2011 14:13:43 +0000 (14:13 +0000)]
2011-01-17  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: refactoring: encapsulate lazy initialization of SourceFrame.
        https://bugs.webkit.org/show_bug.cgi?id=51738

        * http/tests/inspector/debugger-test2.js:
        (initialize_DebuggerTest.InspectorTest.showScriptSource):
        (initialize_DebuggerTest.InspectorTest._showScriptSource):
        * inspector/debugger-pause-in-eval-script-expected.txt:
        * inspector/debugger-pause-in-eval-script.html:
2011-01-17  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: refactoring: encapsulate lazy initialization of SourceFrame.
        https://bugs.webkit.org/show_bug.cgi?id=51738

        Extract content loading logic from SourceView and ScriptView to ContentProvider implementations.
        Pass ContentProvider in SourceFrame constructor to allow SourceFrame manage it's lazy initialization.

        * inspector/front-end/ScriptView.js:
        (WebInspector.ScriptView):
        (WebInspector.SourceFrameContentProviderForScript):
        (WebInspector.SourceFrameContentProviderForScript.prototype.requestContent.didRequestSource):
        (WebInspector.SourceFrameContentProviderForScript.prototype.requestContent):
        (WebInspector.SourceFrameContentProviderForScript.prototype.scripts):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._addScript):
        (WebInspector.ScriptsPanel.prototype.sourceFrameForScript):
        (WebInspector.ScriptsPanel.prototype._sourceFrameForResource):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame):
        (WebInspector.SourceFrame.prototype.set visible):
        (WebInspector.SourceFrame.prototype._createTextViewer):
        (WebInspector.SourceFrame.prototype._breakpointAdded):
        (WebInspector.SourceFrame.prototype._breakpoints):
        (WebInspector.SourceFrame.prototype._sourceIDForLine):
        (WebInspector.SourceFrame.prototype._sourceIDSet):
        (WebInspector.SourceFrameContentProvider):
        (WebInspector.SourceFrameContentProvider.prototype.requestContent):
        (WebInspector.SourceFrameContentProvider.prototype.scripts):
        * inspector/front-end/SourceView.js:
        (WebInspector.SourceView):
        (WebInspector.SourceView.prototype.show):
        (WebInspector.SourceView.prototype.resize):
        (WebInspector.SourceView.prototype.performSearch.didFindSearchMatches):
        (WebInspector.SourceView.prototype.performSearch):
        (WebInspector.SourceView.prototype.revealLine):
        (WebInspector.SourceView.prototype.highlightLine):
        (WebInspector.SourceView.prototype._jumpToSearchResult):
        (WebInspector.SourceFrameContentProviderForResource):
        (WebInspector.SourceFrameContentProviderForResource.prototype.requestContent):
        (WebInspector.SourceFrameContentProviderForResource.prototype.scripts):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-17 John Knottenbelt <jknotten@chromium.org>
jknotten@chromium.org [Mon, 17 Jan 2011 14:09:10 +0000 (14:09 +0000)]
2011-01-17  John Knottenbelt  <jknotten@chromium.org>

        Unreviewed.

        Add myself to committers list
        https://bugs.webkit.org/show_bug.cgi?id=52566

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-17 Balazs Kelemen <kbalazs@webkit.org>
kbalazs@webkit.org [Mon, 17 Jan 2011 13:28:53 +0000 (13:28 +0000)]
2011-01-17  Balazs Kelemen  <kbalazs@webkit.org>

        Reviewed by Andreas Kling.

        [Qt][WK2] Crash due to double destruction of QSharedMemory
        https://bugs.webkit.org/show_bug.cgi?id=52569

        Avoid deleting the QSharedMemory twice.
        * Platform/qt/SharedMemoryQt.cpp:
        (WebKit::SharedMemory::~SharedMemory):
        * Shared/qt/CleanupHandler.cpp:
        Renamed m_inDeleteObjects to m_hasStartedDeleting and
        added a getter for it.
        (WebKit::CleanupHandler::CleanupHandler):
        (WebKit::CleanupHandler::deleteObjects):
        * Shared/qt/CleanupHandler.h:
        (WebKit::CleanupHandler::unmark):
        (WebKit::CleanupHandler::hasStartedDeleting):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-17 John Knottenbelt <jknotten@chromium.org>
jknotten@chromium.org [Mon, 17 Jan 2011 12:21:55 +0000 (12:21 +0000)]
2011-01-17  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by Jeremy Orlow.

        GeolocationController should call stopUpdating on destruction
        https://bugs.webkit.org/show_bug.cgi?id=52216

        fast/dom/window-close-crash.html tests that we do not fail the
        assertion in the mock GeolocationClient that the GeolocationClient
        is not updating when the GeolocationController is destroyed.

        * fast/dom/Geolocation/resources/window-close-popup.html: Added.
        * fast/dom/Geolocation/script-tests/window-close-crash.js: Added.
        (gotPosition):
        (waitForWindowToClose):
        (failedToCreateWatch):
        * fast/dom/Geolocation/window-close-crash-expected.txt: Added.
        * fast/dom/Geolocation/window-close-crash.html: Added.
        * platform/gtk/Skipped:
        * platform/mac-wk2/Skipped:
        * platform/qt-wk2/Skipped:
2011-01-17  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by Jeremy Orlow.

        GeolocationController should call stopUpdating on destruction
        https://bugs.webkit.org/show_bug.cgi?id=52216

        Test: fast/dom/Geolocation/window-close-crash.html

        * page/GeolocationController.cpp:
        (WebCore::GeolocationController::~GeolocationController):
2011-01-17  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by Jeremy Orlow.

        GeolocationController should call stopUpdating on destruction
        https://bugs.webkit.org/show_bug.cgi?id=52216

        fast/dom/Geolocation/window-close-crash.html requires that a
        Geolocation watch be started in a secondary window. Consequently,
        we need to allow geolocation permission and provide a mock
        geolocation position for the secondary window's
        GeolocationClientMock.

        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::setGeolocationPermission):
        (LayoutTestController::setMockGeolocationPosition):
        (LayoutTestController::setMockGeolocationError):
        * DumpRenderTree/chromium/TestShell.h:
        (TestShell::windowList):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-17 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 17 Jan 2011 11:02:02 +0000 (11:02 +0000)]
2011-01-17  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: Qt build fix.

        * inspector/InspectorInstrumentation.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-16 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 17 Jan 2011 10:44:50 +0000 (10:44 +0000)]
2011-01-16  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: make WebCore use InspectorInstrumentation
        for instrumentation calls.
        https://bugs.webkit.org/show_bug.cgi?id=52532

        This change makes WebCore classes issue instrumentation signals
        by means of InspectorInstrumentation interface. It covered migration
        for Document, FrameLoader, Database, DOMStorage, etc. It fixed
        instrumentation handling for Console as well. This all is a part
        of story described in the bug 52510.

        * dom/Document.cpp:
        (WebCore::Document::finishedParsing):
        * dom/Document.h:
        * dom/ScriptExecutionContext.h:
        * inspector/InspectorBrowserDebuggerAgent.cpp:
        (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent):
        (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode):
        (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode):
        (WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr):
        (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
        (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded):
        (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
        * inspector/InspectorBrowserDebuggerAgent.h:
        (WebCore::InspectorBrowserDebuggerAgent::create):
        * inspector/InspectorConsoleAgent.cpp:
        (WebCore::InspectorConsoleAgent::stopTiming):
        (WebCore::InspectorConsoleAgent::count):
        * inspector/InspectorConsoleAgent.h:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::~InspectorController):
        (WebCore::InspectorController::handleMousePress):
        (WebCore::InspectorController::didClearWindowObjectInWorld):
        (WebCore::PostWorkerNotificationToFrontendTask::performTask):
        * inspector/InspectorController.h:
        * inspector/InspectorDOMAgent.h:
        * inspector/InspectorDOMStorageAgent.h:
        * inspector/InspectorDatabaseAgent.cpp:
        * inspector/InspectorDatabaseAgent.h:
        * inspector/InspectorFrontendHost.cpp:
        * inspector/InspectorFrontendHost.h:
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl):
        (WebCore::InspectorInstrumentation::inspectedPageDestroyedImpl):
        (WebCore::InspectorInstrumentation::mouseDidMoveOverElementImpl):
        (WebCore::InspectorInstrumentation::handleMousePressImpl):
        (WebCore::InspectorInstrumentation::mainResourceFiredLoadEventImpl):
        (WebCore::InspectorInstrumentation::mainResourceFiredDOMContentEventImpl):
        (WebCore::InspectorInstrumentation::frameDetachedFromParentImpl):
        (WebCore::InspectorInstrumentation::didCommitLoadImpl):
        (WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
        (WebCore::InspectorInstrumentation::consoleCountImpl):
        (WebCore::InspectorInstrumentation::startConsoleTimingImpl):
        (WebCore::InspectorInstrumentation::stopConsoleTimingImpl):
        (WebCore::InspectorInstrumentation::consoleMarkTimelineImpl):
        (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsoleImpl):
        (WebCore::InspectorInstrumentation::didOpenDatabaseImpl):
        (WebCore::InspectorInstrumentation::didUseDOMStorageImpl):
        (WebCore::InspectorInstrumentation::didCreateWorkerImpl):
        (WebCore::InspectorInstrumentation::didDestroyWorkerImpl):
        (WebCore::InspectorInstrumentation::didCreateWebSocketImpl):
        (WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequestImpl):
        (WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponseImpl):
        (WebCore::InspectorInstrumentation::didCloseWebSocketImpl):
        (WebCore::InspectorInstrumentation::networkStateChangedImpl):
        (WebCore::InspectorInstrumentation::updateApplicationCacheStatusImpl):
        * inspector/InspectorInstrumentation.h:
        (WebCore::InspectorInstrumentation::inspectorControllerCreated):
        (WebCore::InspectorInstrumentation::inspectorControllerDeleted):
        (WebCore::InspectorInstrumentation::didClearWindowObjectInWorld):
        (WebCore::InspectorInstrumentation::inspectedPageDestroyed):
        (WebCore::InspectorInstrumentation::willInsertDOMNode):
        (WebCore::InspectorInstrumentation::didInsertDOMNode):
        (WebCore::InspectorInstrumentation::willRemoveDOMNode):
        (WebCore::InspectorInstrumentation::willModifyDOMAttr):
        (WebCore::InspectorInstrumentation::didModifyDOMAttr):
        (WebCore::InspectorInstrumentation::mouseDidMoveOverElement):
        (WebCore::InspectorInstrumentation::handleMousePress):
        (WebCore::InspectorInstrumentation::characterDataModified):
        (WebCore::InspectorInstrumentation::willSendXMLHttpRequest):
        (WebCore::InspectorInstrumentation::didScheduleResourceRequest):
        (WebCore::InspectorInstrumentation::didInstallTimer):
        (WebCore::InspectorInstrumentation::didRemoveTimer):
        (WebCore::InspectorInstrumentation::willCallFunction):
        (WebCore::InspectorInstrumentation::willChangeXHRReadyState):
        (WebCore::InspectorInstrumentation::willDispatchEvent):
        (WebCore::InspectorInstrumentation::willDispatchEventOnWindow):
        (WebCore::InspectorInstrumentation::willEvaluateScript):
        (WebCore::InspectorInstrumentation::willFireTimer):
        (WebCore::InspectorInstrumentation::willLayout):
        (WebCore::InspectorInstrumentation::willLoadXHR):
        (WebCore::InspectorInstrumentation::willPaint):
        (WebCore::InspectorInstrumentation::willRecalculateStyle):
        (WebCore::InspectorInstrumentation::identifierForInitialRequest):
        (WebCore::InspectorInstrumentation::willSendRequest):
        (WebCore::InspectorInstrumentation::markResourceAsCached):
        (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCache):
        (WebCore::InspectorInstrumentation::willReceiveResourceData):
        (WebCore::InspectorInstrumentation::willReceiveResourceResponse):
        (WebCore::InspectorInstrumentation::didReceiveContentLength):
        (WebCore::InspectorInstrumentation::didFinishLoading):
        (WebCore::InspectorInstrumentation::didFailLoading):
        (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequest):
        (WebCore::InspectorInstrumentation::scriptImported):
        (WebCore::InspectorInstrumentation::mainResourceFiredLoadEvent):
        (WebCore::InspectorInstrumentation::mainResourceFiredDOMContentEvent):
        (WebCore::InspectorInstrumentation::frameDetachedFromParent):
        (WebCore::InspectorInstrumentation::didCommitLoad):
        (WebCore::InspectorInstrumentation::willWriteHTML):
        (WebCore::InspectorInstrumentation::didOpenDatabase):
        (WebCore::InspectorInstrumentation::didUseDOMStorage):
        (WebCore::InspectorInstrumentation::didCreateWorker):
        (WebCore::InspectorInstrumentation::didDestroyWorker):
        (WebCore::InspectorInstrumentation::didCreateWebSocket):
        (WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequest):
        (WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponse):
        (WebCore::InspectorInstrumentation::didCloseWebSocket):
        (WebCore::InspectorInstrumentation::networkStateChanged):
        (WebCore::InspectorInstrumentation::updateApplicationCacheStatus):
        (WebCore::InspectorInstrumentation::addMessageToConsole):
        (WebCore::InspectorInstrumentation::consoleCount):
        (WebCore::InspectorInstrumentation::startConsoleTiming):
        (WebCore::InspectorInstrumentation::stopConsoleTiming):
        (WebCore::InspectorInstrumentation::consoleMarkTimeline):
        (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole):
        (WebCore::InspectorInstrumentation::inspectorControllerForContext):
        (WebCore::InspectorInstrumentation::inspectorControllerForFrame):
        (WebCore::InspectorInstrumentation::inspectorControllerForPage):
        (WebCore::InspectorInstrumentation::inspectorControllerWithFrontendForContext):
        (WebCore::InspectorInstrumentation::inspectorControllerWithFrontendForDocument):
        (WebCore::InspectorInstrumentation::inspectorControllerWithFrontendForFrame):
        (WebCore::InspectorInstrumentation::inspectorControllerWithFrontendForPage):
        * inspector/InspectorState.cpp:
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::detachFromParent):
        (WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld):
        (WebCore::FrameLoader::dispatchDidCommitLoad):
        * page/Chrome.cpp:
        (WebCore::Chrome::mouseDidMoveOverElement):
        * page/Console.cpp:
        (WebCore::Console::addMessage):
        (WebCore::Console::count):
        (WebCore::Console::markTimeline):
        (WebCore::Console::profile):
        (WebCore::Console::time):
        (WebCore::Console::timeEnd):
        (WebCore::Console::group):
        (WebCore::Console::groupCollapsed):
        (WebCore::Console::groupEnd):
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::sessionStorage):
        (WebCore::DOMWindow::localStorage):
        (WebCore::DOMWindow::dispatchLoadEvent):
        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMousePressEvent):
        * page/Page.cpp:
        (WebCore::Page::~Page):
        * storage/Database.cpp:
        (WebCore::Database::openDatabase):
        * workers/AbstractWorker.cpp:
        (WebCore::AbstractWorker::onDestroyWorker):
        * workers/SharedWorker.cpp:
        (WebCore::SharedWorker::create):
        * workers/Worker.cpp:
        (WebCore::Worker::create):
        * workers/WorkerMessagingProxy.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-17 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 17 Jan 2011 10:15:39 +0000 (10:15 +0000)]
2011-01-17  Adam Barth  <abarth@webkit.org>

        Update path to reflect new WebKit directory location.

        * tests/WebFrameTest.cpp:
        (WebKit::WebFrameTest::registerMockedURLLoad):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Mon, 17 Jan 2011 10:08:18 +0000 (10:08 +0000)]
2011-01-14  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Enable inspector's tests for chromium Linux.
        https://bugs.webkit.org/show_bug.cgi?id=52445

        * platform/chromium/inspector/timeline-network-resource-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-17 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Mon, 17 Jan 2011 09:40:32 +0000 (09:40 +0000)]
2011-01-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Unreviewed, rolling out r75923.

        GTK guy rolls out the r75914.

        * platform/efl/ScrollViewEfl.cpp:
        (WebCore::ScrollView::platformInit):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-17 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Mon, 17 Jan 2011 09:26:52 +0000 (09:26 +0000)]
2011-01-17  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, build fix for 2 GTK tests html file paths.

        * tests/testmimehandling.c:
        (main):
        * tests/testwebview.c:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-17 Helder Correia <helder@sencha.com>
commit-queue@webkit.org [Mon, 17 Jan 2011 09:25:46 +0000 (09:25 +0000)]
2011-01-17  Helder Correia  <helder@sencha.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] fast/canvas/canvas-fillPath-gradient-shadow.html does not pass
        https://bugs.webkit.org/show_bug.cgi?id=52556

        The shadow color opacity needs to be set on the shadow painter.
        Additionally, the gradient brush should be transformed.

        * platform/qt/Skipped: Remove test from skipped list.
2011-01-17  Helder Correia  <helder@sencha.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] fast/canvas/canvas-fillPath-gradient-shadow.html does not pass
        https://bugs.webkit.org/show_bug.cgi?id=52556

        The shadow color opacity needs to be set on the shadow painter.
        Additionally, the gradient brush should be transformed.

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::fillPath):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-17 No'am Rosenthal <noam.rosenthal@nokia.com>
noam.rosenthal@nokia.com [Mon, 17 Jan 2011 08:50:11 +0000 (08:50 +0000)]
2011-01-17  No'am Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Background image rendering is slow
        https://bugs.webkit.org/show_bug.cgi?id=50527

        When tiling a scaled pixmap in Image::drawPattern, scale the tile
        first and only then draw it to the target. Do so only when drawing
        more than one tile.

        Tests in fast/backgrounds/size cover this.

        * platform/graphics/qt/ImageQt.cpp:
        (WebCore::Image::drawPattern):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-17 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Mon, 17 Jan 2011 08:28:19 +0000 (08:28 +0000)]
2011-01-17  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] [Symbian] Fix building NPAPI support
        https://bugs.webkit.org/show_bug.cgi?id=51981

        Make sure that npapi.h is always included outside of the extern "C"
        linkage declaration block.

        No new tests as there is no new functionality.

        * bridge/npruntime.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-17 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Mon, 17 Jan 2011 08:26:24 +0000 (08:26 +0000)]
2011-01-17  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, rolling out r75914.
        http://trac.webkit.org/changeset/75914
        https://bugs.webkit.org/show_bug.cgi?id=49177

        multiple crashes on GTK

        * platform/gtk/Skipped:
2011-01-17  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, rolling out r75914.
        http://trac.webkit.org/changeset/75914
        https://bugs.webkit.org/show_bug.cgi?id=49177

        multiple crashes on GTK

        * platform/ScrollView.cpp:
        (WebCore::ScrollView::removeChild):
        (WebCore::ScrollView::wheelEvent):
        * platform/gtk/MainFrameScrollbarGtk.cpp:
        (MainFrameScrollbarGtk::attachAdjustment):
        (MainFrameScrollbarGtk::gtkValueChanged):
        * platform/gtk/ScrollViewGtk.cpp:
        (WebCore::ScrollView::platformInit):
        (WebCore::ScrollView::platformAddChild):
        (WebCore::ScrollView::platformRemoveChild):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-17 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Mon, 17 Jan 2011 08:05:33 +0000 (08:05 +0000)]
2011-01-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Unreviewed build fix.

        Bug 49177's patch enabled platformInit() in super class(ScrollView).
        But, it didn't removed the function in ScrollViewEfl.cpp.

        * platform/efl/ScrollViewEfl.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-16 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Mon, 17 Jan 2011 07:54:55 +0000 (07:54 +0000)]
2011-01-16  Kent Tamura  <tkent@chromium.org>

        Unreviewed, Chromium-linux build fix.

        * gyp_webkit: Fix a relative path to the top directory.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 17 Jan 2011 07:37:01 +0000 (07:37 +0000)]
2011-01-16  Adam Barth  <abarth@webkit.org>

        Update more include paths to reflect WebKit move.

        * DumpRenderTree/chromium/EventSender.cpp:
        (EventSender::keyDown):
        (EventSender::needsShiftModifier):
        * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
        * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-16 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Mon, 17 Jan 2011 07:29:06 +0000 (07:29 +0000)]
2011-01-16  Kent Tamura  <tkent@chromium.org>

        Unreviewed, Chromium build fix.

        * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/8871903> REGRESSION (r75897): Crash with 0-by-0 iframe in scaled...
mitz@apple.com [Mon, 17 Jan 2011 07:11:11 +0000 (07:11 +0000)]
<rdar://problem/8871903> REGRESSION (r75897): Crash with 0-by-0 iframe in scaled WebView

Reviewed by Sam Weinig.

Avoid use of FloatRect::enclosingBoundingBox(), which can stretch an empty
quad to a non-empty rect.

* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidget):
(WebCore::RenderWidget::updateWidgetPosition):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 17 Jan 2011 06:52:32 +0000 (06:52 +0000)]
2011-01-16  Adam Barth  <abarth@webkit.org>

        Roll Chromium DEPS to pick up the changes reflecting the new location
        of WebKit.

        * DEPS:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-16 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Mon, 17 Jan 2011 06:24:42 +0000 (06:24 +0000)]
2011-01-16  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] fast/events/scroll-after-click-on-tab-index has been failing on the bots
        https://bugs.webkit.org/show_bug.cgi?id=49177

        * platform/gtk/Skipped: Unskip this test, as it's now passing.
2011-01-16  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] fast/events/scroll-after-click-on-tab-index has been failing on the bots
        https://bugs.webkit.org/show_bug.cgi?id=49177

        * platform/ScrollView.cpp: Move the platform guards around a little. GTK+
        now shares the implementation of platformAddChild and platformRemoveChild,
        but has its own implementation of removeChild, which knows how to inform
        main frame scrollbars that they no longer control the WebCore scrollbar.
        * platform/gtk/MainFrameScrollbarGtk.cpp:
        (MainFrameScrollbarGtk::attachAdjustment): If we are attaching the same adjustment
        that we already have, bail out early. Apply the value changed signal handler
        after configuring the adjustment. We don't want our reset of the adjustment to
        stomp on WebCore values.
        (MainFrameScrollbarGtk::gtkValueChanged): Do not adjust the value if the WebCore
        state already matches ours. This prevents some unnecessary recursion
        * platform/gtk/ScrollViewGtk.cpp:
        (WebCore::ScrollView::removeChild): Added, special cases main frame scrollbars
        which need their adjustments detached.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-13 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Mon, 17 Jan 2011 06:20:57 +0000 (06:20 +0000)]
2011-01-13  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Antti Koivisto.

        Fix for Bug 52427 - Inconsistent use of m_cache in CachedResourceLoader
        https://bugs.webkit.org/show_bug.cgi?id=52427

        In constructor/destructor of CachedResourceLoader, m_cache has been
        used to call MemoryCache::addCachedResourceLoader/removeCachedResourceLoader
        while cache() is used everywhere else.

        Actually addCachedResourceLoader/removeCachedResourceLoader need not be called at all.
        Remove the call sites and make MemoryCache non-friend of CachedResourceLoader.

        No new tests because the behavior remains the same.

        * loader/cache/CachedResourceLoader.cpp:
        (WebCore::CachedResourceLoader::CachedResourceLoader):
        (WebCore::CachedResourceLoader::~CachedResourceLoader):
        * loader/cache/CachedResourceLoader.h:
        * loader/cache/MemoryCache.cpp:
        * loader/cache/MemoryCache.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-16 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Mon, 17 Jan 2011 05:59:09 +0000 (05:59 +0000)]
2011-01-16  Martin Robinson  <mrobinson@igalia.com>

        Build fix for GTK+ after source directory movement.

        * GNUmakefile.am: Correct include paths.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 17 Jan 2011 05:09:19 +0000 (05:09 +0000)]
2011-01-16  Adam Barth  <abarth@webkit.org>

        Teach svn-apply about WebKit move.

        * Scripts/VCSUtils.pm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove WebKit into Source
abarth@webkit.org [Mon, 17 Jan 2011 05:04:17 +0000 (05:04 +0000)]
Move WebKit into Source

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 17 Jan 2011 05:02:09 +0000 (05:02 +0000)]
2011-01-16  Adam Barth  <abarth@webkit.org>

        Rubber-stamped by Eric Seidel.

        Move WebKit into Source
        https://bugs.webkit.org/show_bug.cgi?id=52530

        * WebKit.grd:
        * WebKit.gyp:
2011-01-16  Adam Barth  <abarth@webkit.org>

        Rubber-stamped by Eric Seidel.

        Move WebKit into Source
        https://bugs.webkit.org/show_bug.cgi?id=52530

        * Api/DerivedSources.pro:
        * declarative/declarative.pro:
        * docs/docs.pri:
        * tests/tests.pri:
2011-01-16  Adam Barth  <abarth@webkit.org>

        Rubber-stamped by Eric Seidel.

        Move WebKit into Source
        https://bugs.webkit.org/show_bug.cgi?id=52530

        * GNUmakefile.am:
2011-01-16  Adam Barth  <abarth@webkit.org>

        Rubber-stamped by Eric Seidel.

        Move WebKit into Source
        https://bugs.webkit.org/show_bug.cgi?id=52530

        * GNUmakefile.am:
2011-01-16  Adam Barth  <abarth@webkit.org>

        Rubber-stamped by Eric Seidel.

        Move WebKit into Source
        https://bugs.webkit.org/show_bug.cgi?id=52530

        * Makefile:
        * scripts/generate-webkitversion.pl:
2011-01-16  Adam Barth  <abarth@webkit.org>

        Rubber-stamped by Eric Seidel.

        Move WebKit into Source
        https://bugs.webkit.org/show_bug.cgi?id=52530

        * WebKit.vcproj/Interfaces.vcproj:
        * WebKit.vcproj/WebKit.sln:
        * WebKit.vcproj/WebKit.vcproj:
        * WebKit.vcproj/WebKitGUID.vcproj:
2011-01-16  Adam Barth  <abarth@webkit.org>

        Rubber-stamped by Eric Seidel.

        Move WebKit into Source
        https://bugs.webkit.org/show_bug.cgi?id=52530

        * Android.mk:
        * CMakeLists.txt:
        * DerivedSources.pro:
        * GNUmakefile.am:
        * Makefile:
        * WebKit.pri:
        * WebKit.pro:
        * configure.ac:
        * wscript:
2011-01-16  Adam Barth  <abarth@webkit.org>

        Rubber-stamped by Eric Seidel.

        Move WebKit into Source
        https://bugs.webkit.org/show_bug.cgi?id=52530

        * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        * DumpRenderTree/qt/DumpRenderTreeQt.h:
        * DumpRenderTree/qt/GCControllerQt.cpp:
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        * DumpRenderTree/qt/PlainTextControllerQt.cpp:
        * DumpRenderTree/qt/TextInputControllerQt.cpp:
        * DumpRenderTree/wscript:
        * QtTestBrowser/launcherwindow.h:
        * Scripts/build-webkit:
        * Scripts/webkitdirs.pm:
2011-01-16  Adam Barth  <abarth@webkit.org>

        Rubber-stamped by Eric Seidel.

        Move WebKit into Source
        https://bugs.webkit.org/show_bug.cgi?id=52530

        * JavaScriptCore.gyp/JavaScriptCore.gyp:
2011-01-16  Adam Barth  <abarth@webkit.org>

        Rubber-stamped by Eric Seidel.

        Move WebKit into Source
        https://bugs.webkit.org/show_bug.cgi?id=52530

        * WebCore.gyp/WebCore.gyp:
        * WebCore.pri:
        * WebCore.pro:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAssertion failure (!inSetWindow) with in-process plug-in in plugins/destroy-on-setwin...
mitz@apple.com [Mon, 17 Jan 2011 04:21:50 +0000 (04:21 +0000)]
Assertion failure (!inSetWindow) with in-process plug-in in plugins/destroy-on-setwindow.html
https://bugs.webkit.org/show_bug.cgi?id=52550

Reviewed by Simon Fraser.

* Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView setWindowIfNecessary]): Removed the assertion, making sure
that inSetWindow remains YES until we exit the top-level setWindowIfNecessary.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-16 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 17 Jan 2011 03:49:59 +0000 (03:49 +0000)]
2011-01-16  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        frame-removed-during-resize.html test crashes (shows up as image-map-2.html crash)
        https://bugs.webkit.org/show_bug.cgi?id=52549

        Fix regression from r75900; m_widget->setFrameRect() can run script that
        clears m_widget, so null-check it before calling setBoundsSize().

        Tested by fast/replaced/frame-removed-during-resize.html

        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::setWidgetGeometry):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-16 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 17 Jan 2011 02:01:04 +0000 (02:01 +0000)]
2011-01-16  Simon Fraser  <simon.fraser@apple.com>

        Keep Leopard build happy.

        * platform/mac/WidgetMac.mm:
        (WebCore::Widget::setBoundsSize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-16 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Mon, 17 Jan 2011 01:52:16 +0000 (01:52 +0000)]
2011-01-16  Oliver Hunt  <oliver@apple.com>

        Reviewed by Sam Weinig.

        [jsfunfuzz] Parser doesn't correctly validate for-loop syntax
        https://bugs.webkit.org/show_bug.cgi?id=52516

        Add test for the case where a syntax error immediately follows
        multiple declarations in a for-loop initialiser.

        * fast/js/parser-syntax-check-expected.txt:
        * fast/js/script-tests/parser-syntax-check.js:
2011-01-16  Oliver Hunt  <oliver@apple.com>

        Reviewed by Sam Weinig.

        [jsfunfuzz] Parser doesn't correctly validate for-loop syntax
        https://bugs.webkit.org/show_bug.cgi?id=52516

        Ensure that we always check for a semicolon after encountering
        multiple declarations in the initialiser portion of a for-loop.

        * parser/JSParser.cpp:
        (JSC::JSParser::parseForStatement):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-16 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 17 Jan 2011 01:07:24 +0000 (01:07 +0000)]
2011-01-16  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Issues with iframes and plugins when the WebView is scaled.
        <rdar://problem/6213380>

        When _scaleWebView has been called on a WebView, iframes
        in WebKit1 render and hit-test incorrectly, and plug-ins don't scale up.
        This is caused by AppKit NSViews not playing nicely with the scale
        applied through style.

        Work around most of these issues by adjusting the bounds size
        of widgets to allow iframe contents to paint with the correct scale,
        and fix various places in the code where we relied on coordinate
        transforms via NSViews (which ignore CSS transforms).

        * WebCore.exp.in:
        * platform/Widget.cpp:
        (WebCore::Widget::setBoundsSize):
        * platform/Widget.h:
        * platform/mac/WidgetMac.mm:
        (WebCore::Widget::setBoundsSize):
        (WebCore::Widget::paint):
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingIFrame):
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::setWidgetGeometry):
        (WebCore::RenderWidget::setWidget):
        (WebCore::RenderWidget::updateWidgetPosition):
        * rendering/RenderWidget.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-16 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Sun, 16 Jan 2011 23:54:40 +0000 (23:54 +0000)]
2011-01-16  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Strict mode restrictions on arguments and eval usage aren't complete
        https://bugs.webkit.org/show_bug.cgi?id=52528

        Add a helper function to aid parse failure tests by testing both direct
        eval/global code, and nested code (so that we test the syntax checker
        mode as well)

        * fast/js/basic-strict-mode-expected.txt:
        * fast/js/script-tests/basic-strict-mode.js:
        (shouldBeSyntaxError):
2011-01-16  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Strict mode restrictions on arguments and eval usage aren't complete
        https://bugs.webkit.org/show_bug.cgi?id=52528

        Fix a few bugs in strict mode where we incorrect allow mutation of
        arguments and eval in the parser.

        Alas the "optimisation" used by the syntax checker for validating
        binary and unary expressions was too aggressive: we do actually need
        a stack for operations and operands although it needn't be as complete
        as that used for the full AST builder.

        Also disallow assignment to arguments in all cases as allowing arguments
        to be assignable is always an error in strict mode, regardless of context.

        * parser/ASTBuilder.h:
        (JSC::ASTBuilder::BinaryExprContext::BinaryExprContext):
        (JSC::ASTBuilder::UnaryExprContext::UnaryExprContext):
        * parser/JSParser.cpp:
        (JSC::JSParser::parseAssignmentExpression):
        (JSC::JSParser::parseBinaryExpression):
        (JSC::JSParser::parseUnaryExpression):
        * parser/SyntaxChecker.h:
        (JSC::SyntaxChecker::BinaryExprContext::BinaryExprContext):
        (JSC::SyntaxChecker::BinaryExprContext::~BinaryExprContext):
        (JSC::SyntaxChecker::UnaryExprContext::UnaryExprContext):
        (JSC::SyntaxChecker::UnaryExprContext::~UnaryExprContext):
        (JSC::SyntaxChecker::appendBinaryExpressionInfo):
        (JSC::SyntaxChecker::operatorStackPop):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-16 Robert Hogan <robert@webkit.org>
robert@webkit.org [Sun, 16 Jan 2011 22:08:41 +0000 (22:08 +0000)]
2011-01-16  Robert Hogan  <robert@webkit.org>

        Unreviewed, re-skip test after r75894.

        [Qt] plugins/keyboard-events.html fails after r72717

        Re-skip plugins/keyboard-events.html.
        Using XKeysymToKeycode(QX11Info::display(), ..) doesn't work on
        a headless build, such as the buildbot. So need to solve this a
        different way.

        https://bugs.webkit.org/show_bug.cgi?id=50050

        * platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-16 Robert Hogan <robert@webkit.org>
robert@webkit.org [Sun, 16 Jan 2011 21:08:28 +0000 (21:08 +0000)]
2011-01-16  Robert Hogan  <robert@webkit.org>

        Reviewed by Andreas Kling.

        [Qt] plugins/keyboard-events.html fails after r72717
        https://bugs.webkit.org/show_bug.cgi?id=50050

        * platform/qt/Skipped: Unskip plugins/keyboard-events.html
2011-01-16  Robert Hogan  <robert@webkit.org>

        Reviewed by Andreas Kling.

        [Qt] plugins/keyboard-events.html fails after r72717
        https://bugs.webkit.org/show_bug.cgi?id=50050

        * plugins/qt/PluginViewQt.cpp:
        (WebCore::setXKeyEventSpecificFields): map event text to keycode

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix for <rdar://problem/8871204>
bdakin@apple.com [Sun, 16 Jan 2011 20:59:28 +0000 (20:59 +0000)]
Fix for <rdar://problem/8871204>

Reviewed by Kevin Decker.

Don't try to save elasticity state. Just rely on
NSScrollElasticityAutomatic to restore the correct state.
* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::WebFrameLoaderClient):
(WebFrameLoaderClient::dispatchDidFirstLayout):
(WebFrameLoaderClient::provisionalLoadStarted):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-16 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sun, 16 Jan 2011 18:04:01 +0000 (18:04 +0000)]
2011-01-16  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        RenderView needs to take transforms on its layer into account
        https://bugs.webkit.org/show_bug.cgi?id=52536

        The RenderView's coordinate mapping methods failed to
        take into account a transform on the RenderView's layer.

        No tests because it's not possible to get a transform
        on the RenderView's layer through content.

        * rendering/RenderView.cpp:
        (WebCore::RenderView::mapLocalToContainer):
        (WebCore::RenderView::mapAbsoluteToLocalPoint):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-15 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Sun, 16 Jan 2011 05:11:14 +0000 (05:11 +0000)]
2011-01-15  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Rolled back in r75886.
        https://bugs.webkit.org/show_bug.cgi?id=52527

        r75886 broke the GTK Linux bot because Linux was -- quite surprisingly --
        set up to use the constants for embedded devices.

        * jit/ExecutableAllocatorFixedVMPool.cpp:
        (JSC::maybeModifyVMPoolSize): Separated Linux constants from embedded
        constants.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-15 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Sun, 16 Jan 2011 04:22:30 +0000 (04:22 +0000)]
2011-01-15  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r75886.
        http://trac.webkit.org/changeset/75886
        https://bugs.webkit.org/show_bug.cgi?id=52526

        "Broke GTK+ 64bit" (Requested by xan_ on #webkit).

        * jit/ExecutableAllocatorFixedVMPool.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip fast/dom/Range/range-clone-contents.html on Windows
ddkilzer@apple.com [Sun, 16 Jan 2011 02:14:39 +0000 (02:14 +0000)]
Skip fast/dom/Range/range-clone-contents.html on Windows

Not reviewed.

Filed: <https://bugs.webkit.org/show_bug.cgi?id=52524>

* platform/win/Skipped: Skip test on Windows. The test passes
on all other bots.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/8870429> Shrink the executable pool on embedded devices
ggaren@apple.com [Sat, 15 Jan 2011 23:48:46 +0000 (23:48 +0000)]
<rdar://problem/8870429> Shrink the executable pool on embedded devices

Reviewed by Sam Weinig.

* jit/ExecutableAllocatorFixedVMPool.cpp: Dropped the pool size from 32MB
to 16MB.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-15 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Sat, 15 Jan 2011 23:41:48 +0000 (23:41 +0000)]
2011-01-15  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r75708.
        http://trac.webkit.org/changeset/75708
        https://bugs.webkit.org/show_bug.cgi?id=52521

        Breaks Qt build if mobility is not installed. (Requested by
        benjaminp on #webkit).

        * WebCore.pro:
        * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
        (WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
        * platform/graphics/qt/MediaPlayerPrivateQt.h:
        (WebCore::MediaPlayerPrivateQt::supportsFullscreen):
2011-01-15  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r75708.
        http://trac.webkit.org/changeset/75708
        https://bugs.webkit.org/show_bug.cgi?id=52521

        Breaks Qt build if mobility is not installed. (Requested by
        benjaminp on #webkit).

        * Api/qwebkitplatformplugin.h:
        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::ChromeClientQt):
        (WebCore::ChromeClientQt::~ChromeClientQt):
        * WebCoreSupport/ChromeClientQt.h:
        * WebCoreSupport/FullScreenVideoQt.cpp: Removed.
        * WebCoreSupport/FullScreenVideoQt.h: Removed.
        * WebCoreSupport/QtPlatformPlugin.cpp:
        * WebCoreSupport/QtPlatformPlugin.h:
        * examples/platformplugin/WebPlugin.cpp:
        (WebPlugin::supportsExtension):
        (WebPlugin::createExtension):
        * examples/platformplugin/WebPlugin.h:
        * examples/platformplugin/platformplugin.pro:
        * examples/platformplugin/qwebkitplatformplugin.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-15 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Sat, 15 Jan 2011 23:39:36 +0000 (23:39 +0000)]
2011-01-15  Oliver Hunt  <oliver@apple.com>

        Reviewed by Maciej Stachowiak.

        Incorrect behavior changing attributes of an accessor
        https://bugs.webkit.org/show_bug.cgi?id=52515

        defineProperty doesn't correctly handle changing attributes of an accessor
        property.  This is because we don't pass the full descriptor to the
        putDescriptor helper function, which means we have insufficient information
        to do the right thing. Once that's passed the correct behavior is relatively
        simple to implement.

        * runtime/JSObject.cpp:
        (JSC::putDescriptor):
        (JSC::JSObject::defineOwnProperty):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<http://webkit.org/b/52512> REGRESSION(r73818): range.cloneContents() ignores end...
ddkilzer@apple.com [Sat, 15 Jan 2011 20:44:35 +0000 (20:44 +0000)]
<webkit.org/b/52512> REGRESSION(r73818): range.cloneContents() ignores end offset

Reviewed by Adele Peterson.

WebCore:

The fix for Bug 50710 in r73799 introduced an off-by-one error
when copying nodes to a local NodeVector for processing.  A fix
was attempted for Bug 50854 in r73818, but instead of stopping
at the end offset, it iterates through all the sibling nodes
because the loop variable (i) is never incremented.  To clean
this up, revert back to the code in r73799 and fix the
off-by-one error.

Test: fast/dom/Range/range-clone-contents.html

* dom/Range.cpp:
(WebCore::Range::processContents): Fix the loop that copies
nodes to a local NodeVector by restoring the code from r73799
and fixing the off-by-one error.

LayoutTests:

* fast/dom/Range/range-clone-contents-expected.txt: Added.
* fast/dom/Range/range-clone-contents.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-15 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 15 Jan 2011 20:04:11 +0000 (20:04 +0000)]
2011-01-15  Adam Barth  <abarth@webkit.org>

        Teach svn-apply about WebKit2 move.

        * Scripts/VCSUtils.pm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove WebKit2 into Source
abarth@webkit.org [Sat, 15 Jan 2011 20:02:03 +0000 (20:02 +0000)]
Move WebKit2 into Source
https://bugs.webkit.org/show_bug.cgi?id=52438

Rubber-stamped by Eric Seidel.

.:

Update reference to WebKit2.

* DerivedSources.pro:
* GNUmakefile.am:
* Makefile:
* Source/cmake/WebKitPackaging.cmake:
* WebKit.pro:
* configure.ac:

Source/WebCore:

* WebCore.pro:

Source/WebKit2:

* DerivedSources.pro:
* GNUmakefile.am:
* WebKit2.pro:
* WebProcess.pro:
* win/WebKit2.vcproj:
* win/WebKit2WebProcess.vcproj:

Tools:

* MiniBrowser/qt/MiniBrowser.pro:
* Scripts/build-webkit:
* Scripts/do-file-rename:
* Scripts/do-webcore-rename:
* Scripts/test-webkitpy:
* Scripts/webkitdirs.pm:
* Scripts/webkitpy/style/checker.py:
* WebKitTestRunner/DerivedSources.pro:
* WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
* WebKitTestRunner/qt/WebKitTestRunner.pro:

WebKit/win:

Update reference to WebKit2.

* WebKit.vcproj/WebKit.sln:

Websites/bugs.webkit.org:

Remove WebKit2 from the list of top-level source directories.

* PrettyPatch/PrettyPatch.rb:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-15 Joone Hur <joone.hur@collabora.co.uk>
commit-queue@webkit.org [Sat, 15 Jan 2011 19:26:32 +0000 (19:26 +0000)]
2011-01-15  Joone Hur  <joone.hur@collabora.co.uk>

        Reviewed by Martin Robinson.

        [GTK] Linux build with FileSystem API enabled fails
        https://bugs.webkit.org/show_bug.cgi?id=43878

        This patch allows WebKitGtk+ to build with FileSystem API option.

        No new tests because no new functionality.

        * GNUmakefile.am: Included AsyncFileSystem.h,cpp and Excluded duplicated JSFileException.h,cpp.
        * bindings/js/JSDirectoryEntryCustom.cpp: Included ExceptionCode.h.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-15 Robert Hogan <robert@webkit.org>
robert@webkit.org [Sat, 15 Jan 2011 14:51:56 +0000 (14:51 +0000)]
2011-01-15  Robert Hogan  <robert@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] plugins/no-mime-with-valid-extension.html fails

        Check extension of resource against installed
        plugins when determining mime-type.

        https://bugs.webkit.org/show_bug.cgi?id=52288
        https://bugs.webkit.org/show_bug.cgi?id=50657
        * platform/qt/Skipped:
2011-01-15  Robert Hogan  <robert@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] plugins/no-mime-with-valid-extension.html fails
        Check extension of resource against installed
        plugins when determining mime-type.

        https://bugs.webkit.org/show_bug.cgi?id=52288
        https://bugs.webkit.org/show_bug.cgi?id=50657

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::objectContentType):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-15 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Sat, 15 Jan 2011 14:17:00 +0000 (14:17 +0000)]
2011-01-15  Stephen White  <senorblanco@chromium.org>

        Unreviewed; updated chromium test expectations.

        * platform/chromium-gpu/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-15 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Sat, 15 Jan 2011 14:11:12 +0000 (14:11 +0000)]
2011-01-15  Stephen White  <senorblanco@chromium.org>

        Unreviewed; updated chromium test expectations.

        * platform/chromium-gpu/test_expectations.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-15 Jochen Eisinger <jochen@chromium.org>
jochen@chromium.org [Sat, 15 Jan 2011 09:33:09 +0000 (09:33 +0000)]
2011-01-15  Jochen Eisinger  <jochen@chromium.org>

        Reviewed by David Levin.

        [chromium] remove obsolete createView method
        https://bugs.webkit.org/show_bug.cgi?id=52437

        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::createView):
        * DumpRenderTree/chromium/WebViewHost.h:
2011-01-15  Jochen Eisinger  <jochen@chromium.org>

        Reviewed by David Levin.

        [chromium] remove obsolete createView method
        https://bugs.webkit.org/show_bug.cgi?id=52437

        * public/WebViewClient.h:
        (WebKit::WebViewClient::createView):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-15 Tony Chang <tony@chromium.org>
tony@chromium.org [Sat, 15 Jan 2011 08:58:24 +0000 (08:58 +0000)]
2011-01-15  Tony Chang  <tony@chromium.org>

        Unreviewed, add new test to GTK+ Skipped list.
        https://bugs.webkit.org/show_bug.cgi?id=52508

        * platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sat, 15 Jan 2011 06:48:32 +0000 (06:48 +0000)]
2011-01-14  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Plugins render incorrectly with transformed ancestors
        https://bugs.webkit.org/show_bug.cgi?id=52507

        -[NSView visibleRect] gives the wrong answer if there are CSS transforms
        in the ancestor chain of a plugin.

        So use of this method with calls to -actualVisibleRectInWindow, which
        maps rects through the render tree to compute the correct rect,
        clipping via windowClipRect() if necessary.

        Not testable, because doing so relies on the behavior of some
        plugins, which stop rendering if setWindow passes an empty rect.

        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView updateAndSetWindow]):
        * Plugins/WebBaseNetscapePluginView.h:
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView actualVisibleRectInWindow]):
        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Sat, 15 Jan 2011 06:35:13 +0000 (06:35 +0000)]
2011-01-14  Oliver Hunt  <oliver@apple.com>

        Reviewed by Maciej Stachowiak.

        [jsfunfuzz] Incorrect handling of consecutive duplicate labels
        https://bugs.webkit.org/show_bug.cgi?id=52505

        Add a few tests of consecutive labels containing duplicates to the parser check.

        * fast/js/parser-syntax-check-expected.txt:
        * fast/js/script-tests/parser-syntax-check.js:
2011-01-14  Oliver Hunt  <oliver@apple.com>

        Reviewed by Maciej Stachowiak.

        [jsfunfuzz] Incorrect handling of consecutive duplicate labels
        https://bugs.webkit.org/show_bug.cgi?id=52505

        Compare StringImpl*'s instead of Identifier*'s when looking for duplicate
        labels.

        * parser/JSParser.cpp:
        (JSC::JSParser::parseExpressionOrLabelStatement):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Xiyuan Xia <xiyuan@chromium.org>
commit-queue@webkit.org [Sat, 15 Jan 2011 06:01:15 +0000 (06:01 +0000)]
2011-01-14  Xiyuan Xia  <xiyuan@chromium.org>

        Reviewed by Darin Fisher.

        Prepare Linux WebThemeEngine interface to support new theme parts.
        https://bugs.webkit.org/show_bug.cgi?id=52413

        * public/linux/WebThemeEngine.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Sam Magnuson <smagnuso@gmail.com>
commit-queue@webkit.org [Sat, 15 Jan 2011 05:38:48 +0000 (05:38 +0000)]
2011-01-14  Sam Magnuson  <smagnuso@gmail.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Compile with QT_NO_GRAPHICSVIEW
        https://bugs.webkit.org/show_bug.cgi?id=49750

        * platform/graphics/qt/GraphicsLayerQt.cpp:
        * platform/graphics/qt/GraphicsLayerQt.h:
        * platform/qt/PlatformMouseEventQt.cpp:
2011-01-14  Sam Magnuson  <smagnuso@gmail.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Compile with QT_NO_GRAPHICSVIEW
        https://bugs.webkit.org/show_bug.cgi?id=49750

        * Api/qgraphicswebview.cpp:
        * Api/qgraphicswebview.h:
        * Api/qwebpage.cpp:
        (QWebPage::event):
        * Api/qwebpage_p.h:
        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::createPlugin):
        * WebCoreSupport/PageClientQt.cpp:
        * WebCoreSupport/PageClientQt.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed, update of Chromium test expectations.
dimich@chromium.org [Sat, 15 Jan 2011 04:20:20 +0000 (04:20 +0000)]
Not reviewed, update of Chromium test expectations.
Update of files affected by mass rebaseline in r75828 and r75838

* platform/chromium-mac/animations/3d/state-at-end-event-transform-expected.checksum:
* platform/chromium-mac/animations/3d/state-at-end-event-transform-expected.png:
* platform/chromium-mac/plugins/embed-attributes-style-expected.txt: Removed.
* platform/chromium-mac/svg/custom/svg-curve-with-relative-cordinates-expected.checksum:
* platform/chromium-mac/svg/custom/svg-curve-with-relative-cordinates-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sat, 15 Jan 2011 03:53:29 +0000 (03:53 +0000)]
2011-01-14  Simon Fraser  <simon.fraser@apple.com>

        No review.

        Initialize m_operationInProgress after r75855.

        * runtime/Heap.cpp:
        (JSC::Heap::Heap):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReverted accidentally committed code from my last checkin.
ggaren@apple.com [Sat, 15 Jan 2011 03:32:19 +0000 (03:32 +0000)]
Reverted accidentally committed code from my last checkin.

* runtime/Heap.cpp:
(JSC::Heap::markRoots):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry to fix the GTK bot.
ggaren@apple.com [Sat, 15 Jan 2011 03:28:16 +0000 (03:28 +0000)]
Try to fix the GTK bot.

Reviewed by Sam Weinig.

* runtime/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::markRoots): Kids, remember to initialize your data members.
Knowing is half the battle.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed, update of test expectations.
dimich@chromium.org [Sat, 15 Jan 2011 02:33:53 +0000 (02:33 +0000)]
Not reviewed, update of test expectations.
Ignore new test fast/js/js-continue-break-restrictions.html, it fails for V8.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Eric Uhrhane <ericu@chromium.org>
ericu@chromium.org [Sat, 15 Jan 2011 02:26:35 +0000 (02:26 +0000)]
2011-01-14  Eric Uhrhane  <ericu@chromium.org>

        Reviewed by David Levin.

        Add tests for FileWriterSync
        https://bugs.webkit.org/show_bug.cgi?id=50720

        * fast/filesystem/resources/file-writer-sync-truncate-extend.js: Added.
        * fast/filesystem/workers/file-writer-sync-truncate-extend.html: Added.
        * fast/filesystem/workers/file-writer-sync-truncate-extend-expected.txt: Added.
        * fast/filesystem/resources/file-writer-sync-write-overlapped.js: Added.
        * fast/filesystem/workers/file-writer-sync-write-overlapped.html: Added.
        * fast/filesystem/workers/file-writer-sync-write-overlapped-expected.txt: Added.
        * fast/filesystem/resources/file-writer-utils.js:
        (assert): Make assert throw, rather than continue.
        (cleanUp): Always call finishJSTest, even without fileEntryForCleanup.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sat, 15 Jan 2011 02:22:03 +0000 (02:22 +0000)]
2011-01-14  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed. Try to fix EFL build.

        * ewk/ewk_frame.cpp:
        (ewk_frame_scroll_add): Added WebCore namespace to IntSize.
        * ewk/ewk_view.cpp:
        (_ewk_view_viewport_attributes_compute): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Sat, 15 Jan 2011 02:14:45 +0000 (02:14 +0000)]
2011-01-14  Oliver Hunt  <oliver@apple.com>

        Reviewed by Stephanie Lewis.

        [jsfunfuzz] We should be clearing the lexers temporary character buffers when switching to strict mode
        https://bugs.webkit.org/show_bug.cgi?id=52501

        Add checks for correct behaviour when the strict mode token is immediately followed
        by a value that needs a temporary buffer in the lexer.

        * fast/js/basic-strict-mode-expected.txt:
        * fast/js/script-tests/basic-strict-mode.js:
2011-01-14  Oliver Hunt  <oliver@apple.com>

        Reviewed by Stephanie Lewis.

        [jsfunfuzz] We should be clearing the lexers temporary character buffers when switching to strict mode
        https://bugs.webkit.org/show_bug.cgi?id=52501

        Clear the temporary character buffers used for reading escaped characters and
        numbers.

        * parser/Lexer.h:
        (JSC::Lexer::setOffset):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Tony Chang <tony@chromium.org>
tony@chromium.org [Sat, 15 Jan 2011 02:06:08 +0000 (02:06 +0000)]
2011-01-14  Tony Chang  <tony@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Strip NUL character when copying text on Windows
        https://bugs.webkit.org/show_bug.cgi?id=52236

        * editing/pasteboard/copy-null-characters-expected.txt: Added.
        * editing/pasteboard/copy-null-characters.html: Added.
2011-01-14  Tony Chang  <tony@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Strip NUL character when copying text on Windows
        https://bugs.webkit.org/show_bug.cgi?id=52236

        Test: editing/pasteboard/copy-null-characters.html

        * editing/Editor.cpp:
        (WebCore::Editor::selectedText):
        * platform/mac/PasteboardMac.mm:
        (WebCore::Pasteboard::writeSelection): Use editor()->selectedText() which matches the other platforms.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Sat, 15 Jan 2011 01:59:05 +0000 (01:59 +0000)]
2011-01-14  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Antti Koivisto.

        Rename cache() to memoryCache()
        https://bugs.webkit.org/show_bug.cgi?id=52433

        No new tests because the behavior remains the same.

        * WebCore.exp.in:
        * WebCore.order:
        * history/PageCache.cpp:
        (WebCore::PageCache::releaseAutoreleasedPagesNow):
        * inspector/InspectorResourceAgent.cpp:
        (WebCore::InspectorResourceAgent::cachedResource):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::tellClientAboutPastMemoryCacheLoads):
        * loader/archive/cf/LegacyWebArchive.cpp:
        (WebCore::LegacyWebArchive::create):
        * loader/cache/CachedImage.cpp:
        (WebCore::CachedImage::allClientsRemoved):
        (WebCore::CachedImage::data):
        * loader/cache/CachedResource.cpp:
        (WebCore::CachedResource::~CachedResource):
        (WebCore::CachedResource::addClientToSet):
        (WebCore::CachedResource::removeClient):
        (WebCore::CachedResource::setDecodedSize):
        (WebCore::CachedResource::setEncodedSize):
        (WebCore::CachedResource::didAccessDecodedData):
        * loader/cache/CachedResourceLoader.cpp:
        (WebCore::CachedResourceLoader::CachedResourceLoader):
        (WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
        (WebCore::CachedResourceLoader::requestResource):
        (WebCore::CachedResourceLoader::revalidateResource):
        (WebCore::CachedResourceLoader::loadResource):
        (WebCore::CachedResourceLoader::clearPreloads):
        (WebCore::CachedResourceLoader::printPreloadStats):
        * loader/cache/CachedResourceRequest.cpp:
        (WebCore::CachedResourceRequest::load):
        (WebCore::CachedResourceRequest::didFail):
        (WebCore::CachedResourceRequest::didReceiveResponse):
        * loader/cache/MemoryCache.cpp:
        (WebCore::memoryCache):
        * loader/cache/MemoryCache.h:
2011-01-14  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Antti Koivisto.

        Rename cache() to memoryCache()
        https://bugs.webkit.org/show_bug.cgi?id=52433

        * src/WebCache.cpp:
        (WebKit::WebCache::setCapacities):
        (WebKit::WebCache::clear):
        (WebKit::WebCache::getUsageStats):
        (WebKit::WebCache::getResourceTypeStats):
2011-01-14  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Antti Koivisto.

        Rename cache() to memoryCache()
        https://bugs.webkit.org/show_bug.cgi?id=52433

        * webkit/webkitglobals.cpp:
        (webkit_set_cache_model):
2011-01-14  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Antti Koivisto.

        Rename cache() to memoryCache()
        https://bugs.webkit.org/show_bug.cgi?id=52433

        * Misc/WebCache.mm:
        (+[WebCache statistics]):
        (+[WebCache setDisabled:]):
        (+[WebCache isDisabled]):
        * WebView/WebView.mm:
        (+[WebView _setCacheModel:]):
2011-01-14  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Antti Koivisto.

        Rename cache() to memoryCache()
        https://bugs.webkit.org/show_bug.cgi?id=52433

        * Api/qwebpage.cpp:
        (QWebPagePrivate::_q_cleanupLeakMessages):
        * Api/qwebsettings.cpp:
        (QWebSettings::clearMemoryCaches):
        (QWebSettings::setObjectCacheCapacities):
2011-01-14  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Antti Koivisto.

        Rename cache() to memoryCache()
        https://bugs.webkit.org/show_bug.cgi?id=52433

        * WebCache.cpp:
        (WebCache::statistics):
        (WebCache::empty):
        (WebCache::setDisabled):
        (WebCache::disabled):
        * WebView.cpp:
        (WebView::setCacheModel):
2011-01-14  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Antti Koivisto.

        Rename cache() to memoryCache()
        https://bugs.webkit.org/show_bug.cgi?id=52433

        * WebView.cpp:
        (wxWebView::SetCachePolicy):
2011-01-14  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Antti Koivisto.

        Rename cache() to memoryCache()
        https://bugs.webkit.org/show_bug.cgi?id=52433

        * WebProcess/WebProcess.cpp:
        (WebKit::WebProcess::shutdownIfPossible):
        (WebKit::WebProcess::didClose):
        * WebProcess/mac/WebProcessMac.mm:
        (WebKit::WebProcess::platformSetCacheModel):
        * WebProcess/win/WebProcessWin.cpp:
        (WebKit::WebProcess::platformSetCacheModel):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry to fix non-Dtrace builds: #include Tracing.h instead of TracingDtrace.h.
ggaren@apple.com [Sat, 15 Jan 2011 01:52:28 +0000 (01:52 +0000)]
Try to fix non-Dtrace builds: #include Tracing.h instead of TracingDtrace.h.

* runtime/Heap.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-13 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Sat, 15 Jan 2011 01:43:29 +0000 (01:43 +0000)]
2011-01-13  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Split out a MarkedSpace strategy object from Heap.
        https://bugs.webkit.org/show_bug.cgi?id=52421

        * Misc/WebCoreStatistics.mm:
        (+[WebCoreStatistics memoryStatistics]): Updated for class move.
2011-01-13  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Split out a MarkedSpace strategy object from Heap.
        https://bugs.webkit.org/show_bug.cgi?id=52421

        SunSpider reports no change.

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * JavaScriptCore.gypi:
        * JavaScriptCore.pro:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj: Updated our 7 build systems. Which is cool.

        * runtime/Heap.cpp:
        (JSC::Heap::Heap):
        (JSC::Heap::destroy):
        (JSC::Heap::recordExtraCost):
        (JSC::Heap::allocate):
        (JSC::Heap::markConservatively):
        (JSC::Heap::markRoots):
        (JSC::Heap::objectCount):
        (JSC::Heap::statistics):
        (JSC::Heap::size):
        (JSC::Heap::isBusy):
        (JSC::Heap::collectAllGarbage):
        (JSC::Heap::primaryHeapBegin):
        (JSC::Heap::primaryHeapEnd):
        * runtime/Heap.h:
        (JSC::Heap::globalData):
        (JSC::Heap::markedSpace):
        (JSC::Heap::isCellMarked):
        (JSC::Heap::checkMarkCell):
        (JSC::Heap::markCell): Moved all code pertaining to managing chunks of
        collector memory out of this class. Heap now just delegates to MarkedSpace.

        * runtime/JSCell.h:
        (JSC::JSCell::Heap::heap): Updated for MarkedSpace delegation.

        * runtime/JSValue.h: Moved the ValueStringPair typedef to help with #includes.

        * runtime/MarkedSpace.cpp: Copied from runtime/Heap.cpp.
        (JSC::MarkedSpace::MarkedSpace):
        (JSC::MarkedSpace::destroy):
        (JSC::MarkedSpace::allocateBlock):
        (JSC::MarkedSpace::freeBlock):
        (JSC::MarkedSpace::allocate):
        (JSC::MarkedSpace::resizeBlocks):
        (JSC::MarkedSpace::growBlocks):
        (JSC::MarkedSpace::shrinkBlocks):
        (JSC::MarkedSpace::markConservatively):
        (JSC::MarkedSpace::clearMarkBits):
        (JSC::MarkedSpace::markedCells):
        (JSC::MarkedSpace::sweep):
        (JSC::MarkedSpace::objectCount):
        (JSC::MarkedSpace::addToStatistics):
        (JSC::MarkedSpace::statistics):
        (JSC::MarkedSpace::size):
        (JSC::MarkedSpace::reset):
        (JSC::MarkedSpace::primaryHeapBegin):
        (JSC::MarkedSpace::primaryHeapEnd):
        * runtime/MarkedSpace.h: Copied from runtime/Heap.h.
        (JSC::MarkedSpace::globalData):
        (JSC::MarkedSpace::didShrink):
        (JSC::MarkedSpace::cellBlock):
        (JSC::MarkedSpace::cellOffset):
        (JSC::MarkedSpace::isCellMarked):
        (JSC::MarkedSpace::checkMarkCell):
        (JSC::MarkedSpace::markCell): Moved all code pertaining to managing chunks of
        collector memory into this class.

        * runtime/MemoryStatistics.cpp:
        (JSC::heapStatistics):
        * runtime/MemoryStatistics.h: Updated for MarkedSpace delegation.
2011-01-13  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Split out a MarkedSpace strategy object from Heap.
        https://bugs.webkit.org/show_bug.cgi?id=52421

        * Shared/mac/WebMemorySampler.mac.mm:
        (WebKit::WebMemorySampler::sampleWebKit): Updated for class move.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Nico Weber <thakis@chromium.org>
thakis@chromium.org [Sat, 15 Jan 2011 01:40:28 +0000 (01:40 +0000)]
2011-01-14  Nico Weber  <thakis@chromium.org>

        Unreviewed, test expectations.

        Rebaseline gradient test due to updated skia. reed checked the test and
        says the new look is right and is an intentional change.
        https://bugs.webkit.org/show_bug.cgi?id=52105

        * platform/chromium-linux/svg/batik/paints/gradientLimit-expected.checksum:
        * platform/chromium-linux/svg/batik/paints/gradientLimit-expected.png:
        * platform/chromium-win/svg/batik/paints/gradientLimit-expected.checksum:
        * platform/chromium-win/svg/batik/paints/gradientLimit-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Sat, 15 Jan 2011 01:31:09 +0000 (01:31 +0000)]
2011-01-14  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Add a new PageClient::displayView function and expose it on WebPageProxy
        https://bugs.webkit.org/show_bug.cgi?id=52500

        * UIProcess/API/mac/PageClientImpl.h:
        * UIProcess/API/mac/PageClientImpl.mm:
        (WebKit::PageClientImpl::displayView):
        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPagePrivate::displayView):
        * UIProcess/API/qt/qwkpage_p.h:
        * UIProcess/PageClient.h:
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::displayView):
        * UIProcess/WebPageProxy.h:
        * UIProcess/win/WebView.cpp:
        (WebKit::WebView::displayView):
        * UIProcess/win/WebView.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Sat, 15 Jan 2011 01:22:58 +0000 (01:22 +0000)]
2011-01-14  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        [jsfunfuzz] parser doesn't enforce continue restrictions correctly.
        https://bugs.webkit.org/show_bug.cgi?id=52493

        Add a few tests for continue to cover the cases where continue
        isn't syntactically valid.

        * fast/js/js-continue-break-restrictions-expected.txt: Added.
        * fast/js/js-continue-break-restrictions.html: Added.
        * fast/js/script-tests/js-continue-break-restrictions.js: Added.
2011-01-14  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        [jsfunfuzz] parser doesn't enforce continue restrictions correctly.
        https://bugs.webkit.org/show_bug.cgi?id=52493

        This patch reworks handling of break, continue and label statements
        to correctly handle all the valid and invalid cases.  Previously certain
        errors would be missed by the parser in strict mode, but the bytecode
        generator needed to handle those cases for non-strict code so nothing
        failed, it simply became non-standard behaviour.

        Now that we treat break and continue errors as early faults in non-strict
        mode as well that safety net has been removed so the parser bugs result in
        crashes at codegen time.

        * parser/JSParser.cpp:
        (JSC::JSParser::ScopeLabelInfo::ScopeLabelInfo):
        (JSC::JSParser::next):
        (JSC::JSParser::nextTokenIsColon):
        (JSC::JSParser::continueIsValid):
            Continue is only valid in loops so we can't use breakIsValid()
        (JSC::JSParser::pushLabel):
            We now track whether the label is for a loop (and is therefore a
            valid target for continue.
        (JSC::JSParser::popLabel):
        (JSC::JSParser::getLabel):
            Replace hasLabel with getLabel so that we can validate the target
            when parsing continue statements.
        (JSC::JSParser::Scope::continueIsValid):
        (JSC::JSParser::Scope::pushLabel):
        (JSC::JSParser::Scope::getLabel):
        (JSC::JSParser::JSParser):
        (JSC::JSParser::parseBreakStatement):
        (JSC::JSParser::parseContinueStatement):
        (JSC::LabelInfo::LabelInfo):
        (JSC::JSParser::parseExpressionOrLabelStatement):
            Consecutive labels now get handled iteratively so that we can determine
            whether they're valid targets for continue.
        * parser/Lexer.cpp:
        (JSC::Lexer::nextTokenIsColon):
        * parser/Lexer.h:
        (JSC::Lexer::setOffset):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: WebCore part of <rdar://problem/8441312> Crash in -[NSView _invalidat...
mitz@apple.com [Sat, 15 Jan 2011 01:20:45 +0000 (01:20 +0000)]
Source/WebCore: WebCore part of <rdar://problem/8441312> Crash in -[NSView _invalidateGStatesForTree]

Reviewed by Simon Fraser.

* WebCore.exp.in: Export RenderWidget::suspendWidgetHierarchyUpdates() and
RenderWidget::resumeWidgetHierarchyUpdates().
* manual-tests/plug-in-mutates-NSView-hierarchy-during-resize.html: Added.
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidgetGeometry): Removed the assertion that widget hierarchy updates
are disabled. When this assertion was added, this condition was a subset of the “calling out to
plug-in code is forbidden” condition, hence the assertion was valid. The WebKit part of this
change now suspends widget hierarchy updates even at times where plug-in code is expected to be
called, which invalidates the assertion.

WebKit/mac: WebKit/mac part of <rdar://problem/8441312> Crash in -[NSView _invalidateGStatesForTree]

Reviewed by Simon Fraser.

* WebView/WebHTMLView.mm:
(-[WebHTMLView _invalidateGStatesForTree]): Override this NSView method, and bracket the call
to the superclass implementation with suspending WebCore Widget hierarchy updates. This ensures
that the NSView tree doesn’t change from under AppKit as it traverses it.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Ahmad Sharif <asharif.tools@gmail.com>
commit-queue@webkit.org [Sat, 15 Jan 2011 01:19:57 +0000 (01:19 +0000)]
2011-01-14  Ahmad Sharif  <asharif.tools@gmail.com>

        Reviewed by Darin Fisher.

        When inlining is performed, the progress variable is
        declared as uninitialized.
        https://bugs.webkit.org/show_bug.cgi?id=51084

        * WebCore: Copied from WebCore.
        * WebCore/page/animation/KeyframeAnimation.cpp:
        (WebCore::KeyframeAnimation::animate):
        (WebCore::KeyframeAnimation::getAnimatedStyle):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Sat, 15 Jan 2011 01:18:58 +0000 (01:18 +0000)]
2011-01-14  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Implement the "should paint bounds instead of indiviual rects" algorithm from WebKit1
        https://bugs.webkit.org/show_bug.cgi?id=52499

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::shouldPaintBoundsRect):
        Port code from -[WebView _mustDrawUnionedRect:singleRects:count:].

        (WebKit::DrawingAreaImpl::display):
        If shouldPaintBoundsRect returns true, clear the rects vector and append the bounds rect.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Sat, 15 Jan 2011 01:17:16 +0000 (01:17 +0000)]
2011-01-14  Tony Gentilcore  <tonyg@chromium.org>

        Unreviewed build fix.

        Fix Qt build after r75837
        https://bugs.webkit.org/show_bug.cgi?id=52494

        * rendering/style/StyleRareInheritedData.cpp:
        * rendering/style/StyleRareNonInheritedData.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Sat, 15 Jan 2011 01:15:05 +0000 (01:15 +0000)]
2011-01-14  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        fix expanded lines in the code review tool
        https://bugs.webkit.org/show_bug.cgi?id=52498

        Fixes them to work now that we have wrapper divs.
        Also fixes the long-standing bug that the line numbers
        were incorrect sometimes.

        * code-review.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Sat, 15 Jan 2011 01:08:11 +0000 (01:08 +0000)]
2011-01-14  Tony Gentilcore  <tonyg@chromium.org>

        Unreviewed build fix.

        Fix Qt build after r75837
        https://bugs.webkit.org/show_bug.cgi?id=52494

        * rendering/style/RenderStyle.cpp:
2011-01-14  Tony Gentilcore  <tonyg@chromium.org>

        Unreviewed build fix.

        Fix Qt build after r75837
        https://bugs.webkit.org/show_bug.cgi?id=52494

        * ewk/ewk_view.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75846 268f45cc-cd09-0410-ab3c-d52691b4dbfc