mihaip@chromium.org [Mon, 6 Dec 2010 18:20:12 +0000 (18:20 +0000)]
2010-12-06 Mihai Parparita <mihaip@chromium.org>
Unreviewed move of Chromium baselines.
In preparation for making pixel tests pass for Chromium on Snow Leopard,
move baselines for 273 tests from chromium-mac to chromium-mac-leopard.
These tests will then use the mac baselines, which will enable them
to pass on Snow Leopard, but keep passing for Leopard too.
List of files omitted due to length but composed entirely of moves from
platform/chromium-mac to platform/chromium-mac-leopard.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73376
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Mon, 6 Dec 2010 18:06:40 +0000 (18:06 +0000)]
2010-12-03 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Chang.
Allow the Chromium port to have Leopard-specific baselines
https://bugs.webkit.org/show_bug.cgi?id=50506
* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73375
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Mon, 6 Dec 2010 17:36:01 +0000 (17:36 +0000)]
AX does not support HTML5 "required"
https://bugs.webkit.org/show_bug.cgi?id=50507
Reviewed by Oliver Hunt.
WebCore:
Test: platform/mac/accessibility/html5-required-attribute.html
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isRequired):
LayoutTests:
* platform/mac/accessibility/html5-required-attribute-expected.txt: Added.
* platform/mac/accessibility/html5-required-attribute.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73374
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Mon, 6 Dec 2010 17:35:05 +0000 (17:35 +0000)]
2010-12-03 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] fix 2 bugs with inspector tests in DRT
https://bugs.webkit.org/show_bug.cgi?id=50492
Tasks can outlive the tasklist (even when canceled) so this was
causing a crash when ~WebTask() ran. Avoid this by unregistering
when a task is canceled.
Also fix an assert when closing devtool windows by copying some
logic from test_shell.
* DumpRenderTree/chromium/Task.cpp:
(WebTask::~WebTask):
(TaskList::revokeAll):
* DumpRenderTree/chromium/Task.h: Canceling a task now removes it from
the tasklist (since the task can outlive the tasklist).
* DumpRenderTree/chromium/TestShell.h:
(TestShell::devToolsWebView):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::~WebViewHost): Don't load about:blank when closing
a window if the window has devtools loaded. This avoids an
ASSERT and matches test_shell.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73373
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
victorw@chromium.org [Mon, 6 Dec 2010 17:13:04 +0000 (17:13 +0000)]
2010-12-06 Victor Wang <victorw@chromium.org>
Unreviewed.
[Chromium] update chromium test expectations.
* platform/chromium-linux/fast/css/focus-ring-outline-color-expected.checksum: Added.
* platform/chromium-linux/fast/css/focus-ring-outline-color-expected.png: Added.
* platform/chromium-linux/fast/css/focus-ring-outline-offset-expected.checksum: Added.
* platform/chromium-linux/fast/css/focus-ring-outline-offset-expected.png: Added.
* platform/chromium-linux/fast/css/focus-ring-outline-width-expected.checksum: Added.
* platform/chromium-linux/fast/css/focus-ring-outline-width-expected.png: Added.
* platform/chromium-mac/fast/css/focus-ring-outline-color-expected.checksum: Added.
* platform/chromium-mac/fast/css/focus-ring-outline-color-expected.png: Added.
* platform/chromium-mac/fast/css/focus-ring-outline-offset-expected.checksum: Added.
* platform/chromium-mac/fast/css/focus-ring-outline-offset-expected.png: Added.
* platform/chromium-mac/fast/css/focus-ring-outline-width-expected.checksum: Added.
* platform/chromium-mac/fast/css/focus-ring-outline-width-expected.png: Added.
* platform/chromium-win/fast/css/focus-ring-outline-color-expected.checksum: Added.
* platform/chromium-win/fast/css/focus-ring-outline-color-expected.png: Added.
* platform/chromium-win/fast/css/focus-ring-outline-color-expected.txt: Added.
* platform/chromium-win/fast/css/focus-ring-outline-offset-expected.checksum: Added.
* platform/chromium-win/fast/css/focus-ring-outline-offset-expected.png: Added.
* platform/chromium-win/fast/css/focus-ring-outline-offset-expected.txt: Added.
* platform/chromium-win/fast/css/focus-ring-outline-width-expected.checksum: Added.
* platform/chromium-win/fast/css/focus-ring-outline-width-expected.png: Added.
* platform/chromium-win/fast/css/focus-ring-outline-width-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73372
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan@apple.com [Mon, 6 Dec 2010 16:45:46 +0000 (16:45 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=50504
Expose some more WebCore settings in WebKit2 preferences
Reviewed by Adam Roben.
* Shared/WebPreferencesStore.h:
Changed name of existing FOR_EACH_WEBKIT_STRING_PREFERENCE macro to
FOR_EACH_WEBKIT_FONT_FAMILY_PREFERENCE since it was all about platform-specific
font families, and I'm now introducing a non-platform-spacific string, and
I didn't want to put the new preference in two platform-specific lists. Then
added a new FOR_EACH_WEBKIT_STRING_PREFERENCE to hold the new preference. Note
that the other preferences exposed in this patch were already declared here.
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetDefaultFontSize):
New wrapper.
(WKPreferencesGetDefaultFontSize):
Ditto.
(WKPreferencesSetDefaultFixedFontSize):
Ditto.
(WKPreferencesGetDefaultFixedFontSize):
Ditto.
(WKPreferencesSetDefaultTextEncodingName):
Ditto.
(WKPreferencesCopyDefaultTextEncodingName):
Ditto.
* UIProcess/API/C/WKPreferences.h:
Declare new wrappers.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73370
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Mon, 6 Dec 2010 16:00:32 +0000 (16:00 +0000)]
2010-12-06 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] using shadows leaks memory
https://bugs.webkit.org/show_bug.cgi?id=50541
Fixed leaks in the shadow code.
* platform/graphics/cairo/CairoUtilities.cpp:
(WebCore::drawPatternToCairoContext): adoptRef instead of just
getting a new reference.
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::drawPathShadow): handle cairo_path_t with smart
pointers.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73369
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Mon, 6 Dec 2010 15:59:30 +0000 (15:59 +0000)]
2010-12-06 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Build is broken after r73353
https://bugs.webkit.org/show_bug.cgi?id=50568
Fix the gtk-doc build by making all members of the cache model
enum public. gtk-doc does not support making only some enum
members private. We should also expose it so that users querying
the cache model do not get mysterious, undocumented results.
* webkit/webkitwebview.h: Fix gtk-doc for the cache model enum.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73368
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Mon, 6 Dec 2010 15:41:08 +0000 (15:41 +0000)]
2010-12-06 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Fix GtkLauncher.c style, use webkit style
https://bugs.webkit.org/show_bug.cgi?id=50542
* GtkLauncher/main.c:
(activateUriEntryCb):
(updateTitle):
(linkHoverCb):
(notifyTitleCb):
(notifyLoadStatusCb):
(notifyProgressCb):
(destroyCb):
(goBackCb):
(goForwardCb):
(create_webViewCb):
(webViewReadyCb):
(closeWebViewCb):
(createBrowser):
(createStatusbar):
(createToolbar):
(createWindow):
(main):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73367
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Mon, 6 Dec 2010 15:40:17 +0000 (15:40 +0000)]
2010-12-06 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
[v8] Web Inspector: remove duplicate code for capturing stack trace
https://bugs.webkit.org/show_bug.cgi?id=50461
No new tests. Covered with existing inspector tests.
* bindings/js/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStack):
* bindings/js/ScriptCallStackFactory.h:
* bindings/v8/ScriptCallStackFactory.cpp:
(WebCore::toScriptCallFrame):
(WebCore::toScriptCallFramesVector):
(WebCore::createScriptCallStack):
* bindings/v8/ScriptCallStackFactory.h:
* bindings/v8/V8ConsoleMessage.cpp:
(WebCore::V8ConsoleMessage::handler):
* inspector/ScriptCallFrame.cpp:
(WebCore::ScriptCallFrame::ScriptCallFrame):
(WebCore::ScriptCallFrame::isEqual):
(WebCore::ScriptCallFrame::buildInspectorObject):
* inspector/ScriptCallFrame.h:
(WebCore::ScriptCallFrame::sourceURL):
* inspector/ScriptCallStack.h:
* inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createGenericRecord):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73366
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 6 Dec 2010 15:06:22 +0000 (15:06 +0000)]
Unreviewed.
Add Qt specific expected result for test introduced in r73257.
* platform/qt/media/controls-without-preload-expected.checksum: Added.
* platform/qt/media/controls-without-preload-expected.png: Added.
* platform/qt/media/controls-without-preload-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73365
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 6 Dec 2010 14:52:55 +0000 (14:52 +0000)]
Unreviewed.
WebCore: == Rolled over to ChangeLog-2010-12-06 ==
LayoutTests: == Rolled over to ChangeLog-2010-12-06 ==
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73363
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yael.aharon@nokia.com [Mon, 6 Dec 2010 14:47:41 +0000 (14:47 +0000)]
[Qt] Support focus ring outline color for links.
https://bugs.webkit.org/show_bug.cgi?id=50428
Reviewed by Andreas Kling.
WebCore:
Take width and offset into account when drawing focus ring.
Tests: fast/css/focus-ring-outline-color.html
fast/css/focus-ring-outline-offset.html
fast/css/focus-ring-outline-width.html
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::drawFocusRing):
LayoutTests:
* fast/css/focus-ring-outline-color.html: Added.
* fast/css/focus-ring-outline-offset.html: Added.
* fast/css/focus-ring-outline-width.html: Added.
* platform/mac/fast/css/focus-ring-outline-color-expected.checksum: Added.
* platform/mac/fast/css/focus-ring-outline-color-expected.png: Added.
* platform/mac/fast/css/focus-ring-outline-color-expected.txt: Added.
* platform/mac/fast/css/focus-ring-outline-offset-expected.checksum: Added.
* platform/mac/fast/css/focus-ring-outline-offset-expected.png: Added.
* platform/mac/fast/css/focus-ring-outline-offset-expected.txt: Added.
* platform/mac/fast/css/focus-ring-outline-width-expected.checksum: Added.
* platform/mac/fast/css/focus-ring-outline-width-expected.png: Added.
* platform/mac/fast/css/focus-ring-outline-width-expected.txt: Added.
* platform/qt/fast/css/focus-ring-outline-color-expected.checksum: Added.
* platform/qt/fast/css/focus-ring-outline-color-expected.png: Added.
* platform/qt/fast/css/focus-ring-outline-color-expected.txt: Added.
* platform/qt/fast/css/focus-ring-outline-offset-expected.checksum: Added.
* platform/qt/fast/css/focus-ring-outline-offset-expected.png: Added.
* platform/qt/fast/css/focus-ring-outline-offset-expected.txt: Added.
* platform/qt/fast/css/focus-ring-outline-width-expected.checksum: Added.
* platform/qt/fast/css/focus-ring-outline-width-expected.png: Added.
* platform/qt/fast/css/focus-ring-outline-width-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73362
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yael.aharon@nokia.com [Mon, 6 Dec 2010 14:33:39 +0000 (14:33 +0000)]
[Qt] Fix focus ring outline color support
https://bugs.webkit.org/show_bug.cgi?id=50325
Reviewed by Andreas Kling.
WebCore:
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::drawFocusRing):
Take the outline width into account when drawing the focus ring of image map.
Change the outline-style from dotted to solid. The default outline-width is
5 pixels, and dotted lines just don't make sense anymore.
Give the focus ring alpha of 50%, following what other ports do.
Save and restore the pen when drawing a focus ring.
LayoutTests:
* platform/qt/Skipped:
* platform/qt/fast/images/imagemap-focus-ring-expected.checksum:
* platform/qt/fast/images/imagemap-focus-ring-expected.png:
* platform/qt/fast/images/imagemap-focus-ring-outline-color-expected.checksum: Added.
* platform/qt/fast/images/imagemap-focus-ring-outline-color-expected.png: Added.
* platform/qt/fast/images/imagemap-focus-ring-outline-color-expected.txt: Added.
* platform/qt/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.checksum: Added.
* platform/qt/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png: Added.
* platform/qt/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.txt: Added.
* platform/qt/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.checksum: Added.
* platform/qt/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png: Added.
* platform/qt/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.txt: Added.
* platform/qt/fast/images/imagemap-focus-ring-zoom-expected.checksum:
* platform/qt/fast/images/imagemap-focus-ring-zoom-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73361
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yael.aharon@nokia.com [Mon, 6 Dec 2010 13:45:15 +0000 (13:45 +0000)]
Unreviewed.
Added a proper mime-type to images.
* platform/qt/fast/images/imagemap-focus-ring-expected.png: Added property svn:mime-type.
* platform/qt/fast/images/imagemap-focus-ring-zoom-expected.png: Added property svn:mime-type.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73360
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 6 Dec 2010 13:21:47 +0000 (13:21 +0000)]
Unreviewed.
Add Qt specific expected results for tests introduced in r73296.
Compared to Mac png files and Mac expected files.
* platform/qt/fast/multicol/span/anonymous-before-child-parent-crash-expected.checksum: Added.
* platform/qt/fast/multicol/span/anonymous-before-child-parent-crash-expected.png: Added.
* platform/qt/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt: Added.
* platform/qt/fast/multicol/span/anonymous-split-block-crash-expected.checksum: Added.
* platform/qt/fast/multicol/span/anonymous-split-block-crash-expected.png: Added.
* platform/qt/fast/multicol/span/anonymous-split-block-crash-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73359
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Mon, 6 Dec 2010 13:19:19 +0000 (13:19 +0000)]
2010-12-06 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt][V8] Build fix after r73283.
No new tests needed.
* WebCore.pri: Add missing webaudio directory
to IDL generator includes.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73358
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Mon, 6 Dec 2010 12:31:00 +0000 (12:31 +0000)]
2010-12-06 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[soup] implement ResourceHandle::platformSetDefersLoading
https://bugs.webkit.org/show_bug.cgi?id=44158
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandle::platformSetDefersLoading): Implemented
using the soup_session_{,un}pause_message APIs.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73357
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sergio@webkit.org [Mon, 6 Dec 2010 12:24:32 +0000 (12:24 +0000)]
2010-12-06 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Martin Robinson.
[GTK] Leak in webkit_soup_cache_load if file contents load fails
https://bugs.webkit.org/show_bug.cgi?id=50558
g_file_get_contents() could return an error after allocating a
buffer for file contents. We must free that memory before
returning.
* platform/network/soup/cache/webkit/soup-cache.c:
(webkit_soup_cache_load): Added a missing g_free().
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73356
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Mon, 6 Dec 2010 11:59:32 +0000 (11:59 +0000)]
2010-12-06 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r73351.
http://trac.webkit.org/changeset/73351
https://bugs.webkit.org/show_bug.cgi?id=50560
"The change broke plugin tests in Chromium" (Requested by
yurys on #webkit).
* bindings/js/ScriptCallStackFactory.cpp:
(WebCore::ScriptCallStack::stackTrace):
* bindings/js/ScriptCallStackFactory.h:
* bindings/v8/ScriptCallStackFactory.cpp:
(WebCore::toScriptCallFrame):
(WebCore::toScriptCallFramesVector):
(WebCore::createScriptCallStack):
(WebCore::ScriptCallStack::stackTrace):
* bindings/v8/ScriptCallStackFactory.h:
* bindings/v8/V8ConsoleMessage.cpp:
(WebCore::V8ConsoleMessage::handler):
* inspector/ScriptCallFrame.cpp:
(WebCore::ScriptCallFrame::ScriptCallFrame):
(WebCore::ScriptCallFrame::isEqual):
(WebCore::ScriptCallFrame::buildInspectorObject):
* inspector/ScriptCallFrame.h:
(WebCore::ScriptCallFrame::sourceURL):
* inspector/ScriptCallStack.h:
* inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createGenericRecord):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73355
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Mon, 6 Dec 2010 11:23:02 +0000 (11:23 +0000)]
2010-12-06 Derek Weitzel <djw8605@gmail.com>
Reviewed by Martin Robinson.
[GTK] API Documentation referencing depreciated GTK_WIDGET_TOPLEVEL
https://bugs.webkit.org/show_bug.cgi?id=50512
Fixed reference to depreciated GTK_WIDGET_TOPLEVEL.
* webkit/webkitwebview.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73354
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Mon, 6 Dec 2010 11:18:20 +0000 (11:18 +0000)]
2010-12-06 Joone Hur <joone@kldp.org>
Reviewed by Xan Lopez.
[GTK] The webkit cache model needs to be set when WebFrameLoaderClient::didPerformFirstNavigation() is called
https://bugs.webkit.org/show_bug.cgi?id=50430
* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::didPerformFirstNavigation): Set the webview cache model.
* webkit/webkitprivate.cpp:
(webkit_init): Removed the code of setting the webview cache model.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73353
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 6 Dec 2010 10:24:08 +0000 (10:24 +0000)]
[Qt] Report zero width for zero size fonts
Patch by Robert Hogan <robert@webkit.org> on 2010-12-06
Reviewed by Kenneth Rohde Christiansen.
Report zero width when font size is zero.
Fixes fast/text/font-size-zero.html
https://bugs.webkit.org/show_bug.cgi?id=50539
* platform/graphics/qt/FontQt.cpp:
(WebCore::Font::floatWidthForSimpleText):
(WebCore::Font::floatWidthForComplexText):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73352
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Mon, 6 Dec 2010 10:13:38 +0000 (10:13 +0000)]
2010-12-03 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
[v8] Web Inspector: remove duplicate code for capturing stack trace
https://bugs.webkit.org/show_bug.cgi?id=50461
No new tests. Covered with existing inspector tests.
* bindings/js/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStack):
* bindings/js/ScriptCallStackFactory.h:
* bindings/v8/ScriptCallStackFactory.cpp:
(WebCore::toScriptCallFrame):
(WebCore::toScriptCallFramesVector):
(WebCore::createScriptCallStack):
* bindings/v8/ScriptCallStackFactory.h:
* bindings/v8/V8ConsoleMessage.cpp:
(WebCore::V8ConsoleMessage::handler):
* inspector/ScriptCallFrame.cpp:
(WebCore::ScriptCallFrame::ScriptCallFrame):
(WebCore::ScriptCallFrame::isEqual):
(WebCore::ScriptCallFrame::buildInspectorObject):
* inspector/ScriptCallFrame.h:
(WebCore::ScriptCallFrame::sourceURL):
* inspector/ScriptCallStack.h:
* inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createGenericRecord):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73351
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sergio@webkit.org [Mon, 6 Dec 2010 09:42:37 +0000 (09:42 +0000)]
2010-12-06 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Martin Robinson.
[GTK] webkit_soup_cache_clear() does not delete all entries in the cache
https://bugs.webkit.org/show_bug.cgi?id=50462
Do not use g_hash_table_foreach to remove entries from the cache
entries hashtable. Iterate over a list of entries to remove them
from the hash table.
* platform/network/soup/ResourceHandleSoup.cpp:
* platform/network/soup/cache/webkit/soup-cache.c:
(remove_cache_item):
(webkit_soup_cache_finalize):
(clear_cache_item):
(webkit_soup_cache_clear):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73350
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Mon, 6 Dec 2010 05:15:22 +0000 (05:15 +0000)]
2010-12-05 Kent Tamura <tkent@chromium.org>
Unreviewed. Run sort-Xcode-project-file.
* WebCore.xcodeproj/project.pbxproj:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73349
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonikitoo@webkit.org [Mon, 6 Dec 2010 01:21:40 +0000 (01:21 +0000)]
2010-12-04 Antonio Gomes <agomes@rim.com>
Reviewed by Martin Robinson.
[Gtk] Populate DumpRenderTreeSupportGtk (Part II)
https://bugs.webkit.org/show_bug.cgi?id=48429
Moved more private method declared with WEBKIT_API to
DumpRenderTreeSupportGtk, since they were only being used by DRT.
WebKit:
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::executeCoreCommandByName):
(DumpRenderTreeSupportGtk::isCommandEnabled):
(DumpRenderTreeSupportGtk::whiteListAccessFromOrigin):
(DumpRenderTreeSupportGtk::resetOriginAccessWhiteLists):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
* webkit/webkitprivate.cpp:
* webkit/webkitprivate.h:
* webkit/webkitwebview.cpp:
WebKitTools:
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::addOriginAccessWhitelistEntry):
(LayoutTestController::execCommand):
(LayoutTestController::isCommandEnabled):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73348
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonikitoo@webkit.org [Mon, 6 Dec 2010 01:21:22 +0000 (01:21 +0000)]
2010-12-04 Antonio Gomes <agomes@rim.com>
Reviewed by Andreas Kling.
Removed extern webkit_web_view_set_group_name from gtk/DumpRenderTree.cpp
Method was removed by http://trac.webkit.org/changeset/71604
* DumpRenderTree/gtk/DumpRenderTree.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73347
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
luiz@webkit.org [Mon, 6 Dec 2010 01:14:39 +0000 (01:14 +0000)]
2010-11-30 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Adler.
HTML5 <details> and <summary> initial implementation
https://bugs.webkit.org/show_bug.cgi?id=50309
HTML5 <details> and <summary> elements initial implementation. The main objective is
to add the files for html element and renderers, and to get rid of build system issues
in future patches.
See: http://www.w3.org/TR/html5/interactive-elements.html#the-details-element
http://www.w3.org/TR/html5/interactive-elements.html#the-summary-element
build systems
* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pri:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/gobject/GNUmakefile.am:
Some css properties to the new html elements.
* css/html.css:
(details):
(summary):
New html element associated with the corresponding tag.
* html/HTMLAttributeNames.in:
* html/HTMLTagNames.in:
1 html element and 3 renderers were added.
* html/HTMLDetailsElement.cpp: Added.
* html/HTMLDetailsElement.h: Added.
* html/HTMLDetailsElement.idl: Added.
* html/HTMLElementsAllInOne.cpp:
* rendering/RenderDetails.cpp: Added.
* rendering/RenderDetails.h: Added.
* rendering/RenderDetailsMarker.cpp: Added.
* rendering/RenderDetailsMarker.h: Added.
* rendering/RenderSummary.cpp: Added.
* rendering/RenderSummary.h: Added.
* rendering/RenderingAllInOne.cpp:
New renderer type checkers.
* rendering/RenderObject.h:
(WebCore::RenderObject::isDetails):
(WebCore::RenderObject::isDetailsMarker):
(WebCore::RenderObject::isSummary):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73346
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis@webkit.org [Sun, 5 Dec 2010 20:13:17 +0000 (20:13 +0000)]
2010-12-05 Rob Buis <rwlbuis@gmail.com>
Reviewed by Nikolas Zimmermann.
createSVGTransformFromMatrix(undefined) => NULL ptr
https://bugs.webkit.org/show_bug.cgi?id=49564
Throw TYPE_MISMATCH_ERR when using undefined or null as value for matrix parameter.
* svg/SVGTransformList.idl:
* svg/properties/SVGTransformListPropertyTearOff.h:
(WebCore::SVGTransformListPropertyTearOff::createSVGTransformFromMatrix):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73345
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Sun, 5 Dec 2010 19:21:56 +0000 (19:21 +0000)]
2010-12-05 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
[GTK] Fix compilation warnings reported by clang
https://bugs.webkit.org/show_bug.cgi?id=50252
* platform/graphics/Path.h: CairoPath is now a class, not a
struct.
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::sendRequestCallback): Cast the status_code to int.
2010-12-05 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
[GTK] Fix compilation warnings reported by clang
https://bugs.webkit.org/show_bug.cgi?id=50252
* GtkLauncher/main.c:
(create_window): The create_statusbar function does not have
parameters.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73344
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Sun, 5 Dec 2010 18:43:49 +0000 (18:43 +0000)]
2010-12-05 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Remove setColor functions it was replicated in
CairoUtilities: setSourceRGBAFromColor.
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::setPlatformFill):
(WebCore::setPlatformStroke):
(WebCore::fillRectSourceOver):
(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::drawEllipse):
(WebCore::GraphicsContext::strokeArc):
(WebCore::GraphicsContext::drawConvexPolygon):
(WebCore::GraphicsContext::drawFocusRing):
(WebCore::GraphicsContext::fillRoundedRect):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73343
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Sun, 5 Dec 2010 18:28:58 +0000 (18:28 +0000)]
Windows production build fix
Put spaces after trailing backslashes when setting
%WebKitVSPropsRedirectionDir%. According to MSDN
<http://msdn.microsoft.com/en-us/library/2kzfk8c7(v=VS.80).aspx>:
A backslash ( \ ) followed by a newline character is interpreted as
a space in the command; use a backslash at the end of a line to
continue a command onto the next line. NMAKE interprets the
backslash literally if any other character, including a space or
tab, follows the backslash.
JavaScriptCore:
* JavaScriptCore.vcproj/JavaScriptCore.make:
WebCore:
* WebCore.vcproj/WebCore.make:
WebKit/win:
* WebKit.vcproj/WebKit.make:
WebKit2:
* win/WebKit2.make:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73342
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Sun, 5 Dec 2010 15:10:18 +0000 (15:10 +0000)]
2010-12-05 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] Zero-sized font does not yet work
Fix fast/text/font-size-zero.html
https://bugs.webkit.org/show_bug.cgi?id=49759
* platform/qt/Skipped:
2010-12-05 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] Zero-sized font does not yet work
Fix fast/text/font-size-zero.html
Copy other ports by setting minimumFontSize to 0 for DRT runs,
copy a fix to SimpleFontData from chromium/safari, and set font
size in FontPlatformData to zero if size zero is requested
and QFont::pixelSize otherwise. (Note that QFont doesn't accept
a pixel size of zero).
Also fix QFont::setPixelSize in FontPlatformData to use
description.computedPixelSize rather than computedSize and
pixelSize() rather than pointSizeF - since the latter gets
set to -1 if pixelSize is set at all.
https://bugs.webkit.org/show_bug.cgi?id=49759
* platform/graphics/qt/FontPlatformData.h:
(WebCore::FontPlatformDataPrivate::FontPlatformDataPrivate):
(WebCore::FontPlatformData::pixelSize):
* platform/graphics/qt/FontPlatformDataQt.cpp:
(WebCore::FontPlatformData::FontPlatformData):
* platform/graphics/qt/FontQt.cpp:
(WebCore::drawTextCommon):
* platform/graphics/qt/SimpleFontDataQt.cpp:
(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::platformGlyphInit):
(WebCore::SimpleFontData::platformCharWidthInit):
2010-12-05 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] Zero-sized font does not yet work
Fix fast/text/font-size-zero.html
Copy other ports by setting minimumFontSize to 0 for DRT runs.
https://bugs.webkit.org/show_bug.cgi?id=49759
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::WebPage):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73341
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Sun, 5 Dec 2010 06:22:08 +0000 (06:22 +0000)]
2010-12-04 Daniel Bates <dbates@rim.com>
https://bugs.webkit.org/show_bug.cgi?id=49641
Inadvertently committed the wrong results for test case fast/lists/w3-css3-list-styles-fallback-style.html
in <http://trac.webkit.org/changeset/73339>.
* fast/lists/w3-css3-list-styles-fallback-style-expected.txt: Rebased results.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73340
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Sun, 5 Dec 2010 05:57:31 +0000 (05:57 +0000)]
2010-12-04 Daniel Bates <dbates@rim.com>
https://bugs.webkit.org/show_bug.cgi?id=49641
Update test case and result for fast/lists/w3-css3-list-styles-fallback-style.html
since we now support list style types lower-armenian and upper-armenian.
* fast/lists/w3-css3-list-styles-fallback-style-expected.txt:
* fast/lists/w3-css3-list-styles-fallback-style.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73339
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Sun, 5 Dec 2010 05:12:21 +0000 (05:12 +0000)]
2010-12-04 Daniel Bates <dbates@rim.com>
Reviewed by Darin Adler.
Add support for lower-armenian and upper-armenian
https://bugs.webkit.org/show_bug.cgi?id=49641
Implement support for list-style-types lower-armenian and upper-armenian
for lowercase Armenian and uppercase Armenian numerals, respectively.
Tests: fast/lists/w3-css3-lower-armenian.html
fast/lists/w3-css3-upper-armenian.html
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added enum values LowerArmenian
and UpperArmenian.
* css/CSSValueKeywords.in: Added "upper-armenian" and "lower-armenian".
* inspector/front-end/SourceCSSTokenizer.re2js: Ditto.
* rendering/RenderListMarker.cpp:
(WebCore::effectiveListMarkerType): Added enum values LowerArmenian
and UpperArmenian.
(WebCore::listMarkerSuffix): Ditto.
(WebCore::listMarkerText): Ditto.
(WebCore::RenderListMarker::paint): Ditto.
(WebCore::RenderListMarker::computePreferredLogicalWidths): Ditto.
(WebCore::RenderListMarker::getRelativeMarkerRect): Ditto.
* rendering/style/RenderStyleConstants.h: Ditto.
2010-12-04 Daniel Bates <dbates@rim.com>
Reviewed by Darin Adler.
Add support for lower-armenian and upper-armenian
https://bugs.webkit.org/show_bug.cgi?id=49641
Tests cases for lower-armenian and upper-armenian list-style-types
derived from the HTML+CSS Internationalization Tests "lower-armenian, up to 9,999",
and "armenian, up to 9,999", respectively.
See <http://www.w3.org/International/tests/tests-html-css/list-lists>.
* fast/lists/w3-css3-lower-armenian-expected.txt: Added.
* fast/lists/w3-css3-lower-armenian.html: Added.
* fast/lists/w3-css3-upper-armenian-expected.txt: Added.
* fast/lists/w3-css3-upper-armenian.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73338
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sun, 5 Dec 2010 03:21:16 +0000 (03:21 +0000)]
2010-12-04 Dan Bernstein <mitz@apple.com>
Reviewed by Sam Weinig.
WebKit part of <rdar://problem/
8145955> Add text search API for counting/marking/highlighting matches in a range
https://bugs.webkit.org/show_bug.cgi?id=50530
* WebView/WebDocumentInternal.h: Added a DOMRange parameter to -countMatchesForText:options:limit:markMatches:
* WebView/WebHTMLView.mm:
(-[WebHTMLView countMatchesForText:inDOMRange:options:limit:markMatches:]): Added DOMRange parameter,
which is passed through to WebCore.
* WebView/WebPDFView.mm:
(isFrameInRange): Added this helper function.
(-[WebPDFView countMatchesForText:inDOMRange:options:limit:markMatches:]): Added DOMRange parameter and
a check if the frame is in the range.
* WebView/WebView.mm:
(-[WebView countMatchesForText:options:highlight:limit:markMatches:]): Now calls the inDOMRange: version.
(-[WebView countMatchesForText:inDOMRange:options:highlight:limit:markMatches:]): Added DOMRange
parameter, which is passed to document views' -countMatchesForText:inDOMRange:options:limit:markMatches:.
* WebView/WebViewPrivate.h:
2010-12-04 Dan Bernstein <mitz@apple.com>
Reviewed by Sam Weinig.
WebCore part of <rdar://problem/
8145955> Add text search API for counting/marking/highlighting matches in a range
https://bugs.webkit.org/show_bug.cgi?id=50530
* WebCore.exp.in: Export Range version of countMatchesForText().
* editing/Editor.cpp:
(WebCore::isFrameInRange): Added this helper method.
(WebCore::Editor::countMatchesForText): Added a Range parameter and restricted the result to
matches that occur in the range.
* editing/Editor.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73337
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sat, 4 Dec 2010 21:51:57 +0000 (21:51 +0000)]
WebKit2: Need client functions to notify app when the url changes due to a fragment navigation
https://bugs.webkit.org/show_bug.cgi?id=50511
Reviewed by Jon Honeycutt.
WebKit2:
Pipe didChangeLocationWithinPageForFrame up through the UIProcess to the WKPageLoadClient,
updating the WebFrameProxy's URL on the way.
Test: PageLoadDidChangeLocationWithinPageForFrame
* UIProcess/API/C/WKPage.h:
* UIProcess/API/qt/qwkpage.cpp:
(QWKPage::QWKPage):
* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::didChangeURLWithoutNavigation):
* UIProcess/WebFrameProxy.h:
* UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::didChangeLocationWithinPageForFrame):
* UIProcess/WebLoaderClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didChangeLocationWithinPageForFrame):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::didChangeLocationWithinPageForFrame):
(WebKit::InjectedBundlePageLoaderClient::didDisplayInsecureContentForFrame):
(WebKit::InjectedBundlePageLoaderClient::didRunInsecureContentForFrame):
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidCancelClientRedirect): Fix typo.
(WebKit::WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
WebKitTools:
Update tools for new didChangeLocationWithinPageForFrame client function (and changed bundle
signature) and added a test for the functionality (PageLoadDidChangeLocationWithinPageForFrame.cpp)
* MiniBrowser/mac/BrowserWindowController.m:
(didChangeLocationWithinPageForFrame):
(-[BrowserWindowController awakeFromNib]):
(-[BrowserWindowController didChangeLocationWithinPageForFrame:]):
* TestWebKitAPI/PlatformUtilities.cpp:
(TestWebKitAPI::Util::toWK):
* TestWebKitAPI/PlatformUtilities.h:
(TestWebKitAPI::Util::adoptWK):
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: Added.
(TestWebKitAPI::nullJavaScriptCallback):
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::didChangeLocationWithinPageForFrame):
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2/file-with-anchor.html: Added.
* TestWebKitAPI/win/TestWebKitAPI.vcproj:
* TestWebKitAPI/win/copy-resources.cmd:
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73336
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 4 Dec 2010 20:40:10 +0000 (20:40 +0000)]
2010-12-04 Gavin Peters <gavinp@chromium.org>
Reviewed by Adam Barth.
Implement onload events for <link rel=prefetch>
https://bugs.webkit.org/show_bug.cgi?id=50187
* fast/dom/HTMLLinkElement/link-and-subresource-test-expected.txt: Added.
* fast/dom/HTMLLinkElement/link-and-subresource-test.html: Added.
* fast/dom/HTMLLinkElement/prefetch-expected.txt:
* fast/dom/HTMLLinkElement/prefetch-onload-expected.txt: Added.
* fast/dom/HTMLLinkElement/prefetch-onload.html: Added.
* fast/dom/HTMLLinkElement/prefetch.html:
* http/tests/misc/prefetch-purpose.html:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
2010-12-04 Gavin Peters <gavinp@chromium.org>
Reviewed by Adam Barth.
Implement onload events for <link rel=prefetch>
https://bugs.webkit.org/show_bug.cgi?id=50187
Tests: fast/dom/HTMLLinkElement/link-and-subresource-test.html
fast/dom/HTMLLinkElement/prefetch-onload.html
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::HTMLLinkElement):
(WebCore::HTMLLinkElement::~HTMLLinkElement):
(WebCore::HTMLLinkElement::parseMappedAttribute):
(WebCore::HTMLLinkElement::process):
(WebCore::HTMLLinkElement::onloadTimerFired):
(WebCore::HTMLLinkElement::notifyFinished):
* html/HTMLLinkElement.h:
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::data):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73335
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Sat, 4 Dec 2010 19:53:46 +0000 (19:53 +0000)]
2010-12-04 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Barth.
Increase size of status bubbles
https://bugs.webkit.org/show_bug.cgi?id=50496
The current available space isn't enough to display all
pending results including position in the queue.
* PrettyPatch/PrettyPatch.rb:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73334
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Sat, 4 Dec 2010 18:57:12 +0000 (18:57 +0000)]
2010-12-04 Patrick Gansterer <paroga@webkit.org>
Unreviewed, build fix after r69132.
* shell/CMakeLists.txt: Fix directory name (jsc -> shell).
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73333
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Sat, 4 Dec 2010 15:19:54 +0000 (15:19 +0000)]
2010-12-04 Patrick Gansterer <paroga@webkit.org>
Reviewed by Andreas Kling.
[CMake] Better detection of ARM platform
https://bugs.webkit.org/show_bug.cgi?id=50452
* CMakeLists.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73332
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Sat, 4 Dec 2010 15:19:07 +0000 (15:19 +0000)]
2010-12-04 Martin Robinson <mrobinson@igalia.com>
Fix a baseline which differs between my machine and the bots.
* platform/gtk/fast/dom/vertical-scrollbar-in-rtl-expected.txt: Fix differing baseline.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73331
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Sat, 4 Dec 2010 14:37:45 +0000 (14:37 +0000)]
WebCore:
2010-12-04 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Drop GdkDrawable usage, it's deprecated in GTK+3.x and we can use GdkWindow
https://bugs.webkit.org/show_bug.cgi?id=50451
GdkDrawable has been removed in GTK+3.x. To cope with this we can
actually stop using it altogether, since GdkWindow is just a
typedef for it and that seems to be good enough for us.
* platform/graphics/GraphicsContext.h: s/GdkDrawable/GdkWindow/.
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::gdkWindow): ditto.
* platform/gtk/GtkVersioning.h: declare GDK_WINDOW_XWINDOW for GTK 3.x builds.
* platform/gtk/PlatformScreenGtk.cpp:
(WebCore::screenAvailableRect): s/GdkDrawable/GdkWindow/.
* platform/gtk/WidgetGtk.cpp:
(WebCore::gdkWindow): ditto.
(WebCore::Widget::setCursor): ditto.
* platform/gtk/WidgetRenderingContextGtk2.cpp: ditto.
JavaScriptCore:
2010-12-04 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Drop GdkDrawable usage, it's deprecated in GTK+3.x and we can use GdkWindow
https://bugs.webkit.org/show_bug.cgi?id=50451
* wtf/gobject/GTypedefs.h: add GdkWindow defines.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73330
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Sat, 4 Dec 2010 14:34:05 +0000 (14:34 +0000)]
2010-12-04 Philippe Normand <pnormand@igalia.com>
Unreviewed, skipping failing media test.
* platform/gtk/Skipped: Skip media/controls-without-preload.html
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73329
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Sat, 4 Dec 2010 14:23:04 +0000 (14:23 +0000)]
2010-12-04 Martin Robinson <mrobinson@igalia.com>
Check in platform-specific results for failing RTL tests on GTK+. Comments
at https://bugs.webkit.org/show_bug.cgi?id=50352 suggest that these failing
results are fine for now.
* platform/gtk/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Added.
* platform/gtk/fast/dom/vertical-scrollbar-in-rtl-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73328
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jnd@chromium.org [Sat, 4 Dec 2010 12:15:36 +0000 (12:15 +0000)]
2010-12-04 Johnny Ding <jnd@chromium.org>
Reviewed by Alexey Proskuryakov.
The JavaScript created (untrusted) event inside a user-initiated
(trusted) event should not cache the UserGesture status.
https://bugs.webkit.org/show_bug.cgi?id=50508
* fast/events/popup-blocked-from-untrusted-mouse-click-expected.txt: Added.
* fast/events/popup-blocked-from-untrusted-mouse-click.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73327
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Sat, 4 Dec 2010 10:04:01 +0000 (10:04 +0000)]
2010-12-04 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Barth.
Increase size of status bubbles
https://bugs.webkit.org/show_bug.cgi?id=50496
The current available space isn't enough to display all
pending results including position in the queue.
* template/en/custom/attachment/edit.html.tmpl:
* template/en/custom/attachment/list.html.tmpl:
* template/en/custom/attachment/reviewform.html.tmpl:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73326
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonikitoo@webkit.org [Sat, 4 Dec 2010 05:27:44 +0000 (05:27 +0000)]
[GTK+] Populate DumpRenderTreeSupportGtk
https://bugs.webkit.org/show_bug.cgi?id=48429
Reviewed by Martin Robinson.
Patch by Antonio Gomes <agomes@rim.com>
WebKit/gtk:
Moved most of the webkit_web_frame* methods defined as private APIs in webkitprivate.h
to DumpRenderTreeSupportGtk, as static class methods. These methods had
not gone throught the formal API review process and were only being used by DRT for now.
The essence of each original method name were kept. For example
webkit_web_frame_get_children(...) was renamed to DumpRenderTreeSupportGtk::getFrameChildren(...),
and so on.
Also some of the method bodies were changed to return non-glib types (gchar* -> CString).
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::getFrameChildren):
(DumpRenderTreeSupportGtk::getInnerText):
(DumpRenderTreeSupportGtk::dumpRenderTree):
(DumpRenderTreeSupportGtk::counterValueForElementById):
(DumpRenderTreeSupportGtk::pageNumberForElementById):
(DumpRenderTreeSupportGtk::numberOfPagesForFrame):
(DumpRenderTreeSupportGtk::getPendingUnloadEventCount):
(DumpRenderTreeSupportGtk::pauseAnimation):
(DumpRenderTreeSupportGtk::pauseTransition):
(DumpRenderTreeSupportGtk::pauseSvgAnimation):
(DumpRenderTreeSupportGtk::markerTextForListItem):
(DumpRenderTreeSupportGtk::numberOfActiveAnimations):
(DumpRenderTreeSupportGtk::suspendAnimations):
(DumpRenderTreeSupportGtk::resumeAnimations):
(DumpRenderTreeSupportGtk::clearMainFrameName):
(DumpRenderTreeSupportGtk::getFocusedAccessibleElement):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
* webkit/webkitprivate.h:
* webkit/webkitwebframe.cpp:
WebKitTools:
Made the previous calls to webkit_web_frame* functions defined as private
APIs in webkitprivate.h go through DRTSupportGtk.
* DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
(AccessibilityController::focusedElement):
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(dumpFramesAsText):
(resetDefaultsToConsistentValues):
(dump):
(webViewDocumentLoadFinished):
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::counterValueForElementById):
(LayoutTestController::pageNumberForElementById):
(LayoutTestController::numberOfPages):
(LayoutTestController::pauseAnimationAtTimeOnElementWithId):
(LayoutTestController::pauseTransitionAtTimeOnElementWithId):
(LayoutTestController::sampleSVGAnimationForElementAtTime):
(LayoutTestController::numberOfActiveAnimations):
(LayoutTestController::suspendAnimations):
(LayoutTestController::resumeAnimations):
(LayoutTestController::markerTextForListItem):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73325
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Sat, 4 Dec 2010 03:19:24 +0000 (03:19 +0000)]
Make the Web Inspector window show and be usable on Mac.
https://webkit.org/b/50490
Reviewed by Sam Weinig.
* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::invalidate): Call platformClose.
(WebKit::WebInspectorProxy::didLoadInspectorPage): Call platformOpen.
(WebKit::WebInspectorProxy::didClose): Call platformClose.
* UIProcess/WebInspectorProxy.h:
* UIProcess/WebInspectorProxy.messages.in: Added DidClose.
* UIProcess/mac/WebInspectorProxyMac.mm:
(-[WebInspectorProxyObjCAdapter initWithWebInspectorProxy:]): Added.
(-[WebInspectorProxyObjCAdapter windowWillClose:]): Added. Call WebInspectorProxy::close.
(WebKit::WebInspectorProxy::platformOpen): Added.
(WebKit::WebInspectorProxy::platformClose): Added.
* UIProcess/qt/WebInspectorProxyQt.cpp:
(WebKit::WebInspectorProxy::platformOpen): Added stub.
(WebKit::WebInspectorProxy::platformClose): Added stub.
* UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::platformOpen): Added stub.
(WebKit::WebInspectorProxy::platformClose): Added stub.
* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::sendMessageToFrontend): Added more null checks to avoid a crash.
* WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
(WebKit::WebInspectorFrontendClient::closeWindow): Call WebInspector::didClose.
(WebKit::WebInspectorFrontendClient::disconnectFromBackend): Ditto.
(WebKit::WebInspectorFrontendClient::sendMessageToBackend): Removed. This does not need to be
implemented by our subclass since we are in a single process.
* WebProcess/WebCoreSupport/WebInspectorFrontendClient.h: Removed sendMessageToBackend.
* WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::didClose): Added. Send a DidClose message to the UI process.
* WebProcess/WebPage/WebInspector.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73324
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Sat, 4 Dec 2010 02:46:49 +0000 (02:46 +0000)]
Bug 50509 - set* methods on MacroAssembler are awfully named.
Rubber stamped by Oliver Hunt.
Methods set32 and setTest32 compare 32-bit operands, and set a 32-bit results based on the comparison.
set8 compares 32-bit operands, and sets an 8-bit result based on the comparison.
setTest8 compares 8-bit operands, and sets a 32-bit result based on the comparison.
Rename to clarify.
set32 -> set32Compare32
setTest32 -> set32Test32
set8 -> set8Compare32
setTest8 -> set32Test8
* assembler/MacroAssembler.h:
(JSC::MacroAssembler::setPtr):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::set32Compare32):
(JSC::MacroAssemblerARM::set8Compare32):
(JSC::MacroAssemblerARM::set32Test32):
(JSC::MacroAssemblerARM::set32Test8):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::set32Compare32):
(JSC::MacroAssemblerARMv7::set8Compare32):
(JSC::MacroAssemblerARMv7::set32Test32):
(JSC::MacroAssemblerARMv7::set32Test8):
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::set8Compare32):
(JSC::MacroAssemblerMIPS::set32Compare32):
(JSC::MacroAssemblerMIPS::set32Test8):
(JSC::MacroAssemblerMIPS::set32Test32):
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::set8Compare32):
(JSC::MacroAssemblerX86Common::set32Compare32):
(JSC::MacroAssemblerX86Common::set32Test8):
(JSC::MacroAssemblerX86Common::set32Test32):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_eq):
(JSC::JIT::emit_op_neq):
(JSC::JIT::compileOpStrictEq):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_eq):
(JSC::JIT::emit_op_neq):
(JSC::JIT::compileOpStrictEq):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73323
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Sat, 4 Dec 2010 02:45:59 +0000 (02:45 +0000)]
2010-12-03 Martin Robinson <mrobinson@igalia.com>
Add a platform-specific baseline for GTK+ after r73128. This test
just click at a predetermined location in the middle of the text field.
Since GTK+ font sizes differ from other ports, the text selected differs.
* platform/gtk/fast/forms/onselect-textarea-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73322
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Sat, 4 Dec 2010 02:05:56 +0000 (02:05 +0000)]
2010-12-03 Oliver Hunt <oliver@apple.com>
Reviewed by Geoff Garen.
Incorrect logic for returning memory at the end of linking.
Reviewed by Geoff Garen.
At the end of linking we return any space at the end of the
allocated executable region that was saved due to branch
compaction. This is currently by done by subtracting the
different from the m_freePtr in the allocation pool. This
can be incorrect if your allocation was made from a new
page that was not selected for subsequent allocations.
This patch corrects this behaviour by verifying that the
memory being returned actually comes from the current
allocation pool.
* assembler/LinkBuffer.h:
(JSC::LinkBuffer::linkCode):
* jit/ExecutableAllocator.h:
(JSC::ExecutablePool::tryShrink):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73321
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Sat, 4 Dec 2010 01:46:22 +0000 (01:46 +0000)]
2010-12-03 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Chang.
Rebaseline server: use pretty text diff output
https://bugs.webkit.org/show_bug.cgi?id=50484
Serve *-pretty-diff.html for text diff output.
* Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
* Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
* Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
* Scripts/webkitpy/tool/commands/rebaselineserver.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73320
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Sat, 4 Dec 2010 00:11:49 +0000 (00:11 +0000)]
2010-12-03 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
REGRESSION(r71934): input event fires twice when editing text inside a text input.
https://bugs.webkit.org/show_bug.cgi?id=50477
* fast/forms/text-input-event-expected.txt: Added.
* fast/forms/text-input-event.html: Added.
2010-12-03 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
REGRESSION(r71934): input event fires twice when editing text inside a text input.
https://bugs.webkit.org/show_bug.cgi?id=50477
Now that events escape the shadow DOM boundary, the input event is fired twice
for each input, once triggered by editing, once triggered by value change.
Test: fast/forms/text-input-event.html
* dom/InputElement.cpp:
(WebCore::InputElement::setValueFromRenderer): Added a check to ensure editable fields
don't fire an extra input event.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73319
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sat, 4 Dec 2010 00:04:49 +0000 (00:04 +0000)]
Clean up the BackingStore implementation
https://bugs.webkit.org/show_bug.cgi?id=50498
Reviewed by Sam Weinig and Dan Bernstein.
* Shared/BackingStore.cpp:
(WebKit::BackingStore::create):
(WebKit::BackingStore::createSharable):
(WebKit::BackingStore::resize):
Use new numBytesForSize helper function.
(WebKit::BackingStore::createFlippedGraphicsContext):
Make this function platform independent.
* Shared/BackingStore.h:
(WebKit::BackingStore::numBytesForSize):
Given a size, return the number of bytes needed for it.
(WebKit::BackingStore::sizeInBytes):
Implement.
* Shared/cg/BackingStoreCG.cpp:
(WebKit::BackingStore::paint):
Don't use CGBitmapContextCreateImage; it creates an extra copy of the image data.
* Shared/qt/BackingStoreQt.cpp:
Remove createFlippedGraphicsContext.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73318
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 4 Dec 2010 00:01:09 +0000 (00:01 +0000)]
2010-12-03 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r73302.
http://trac.webkit.org/changeset/73302
https://bugs.webkit.org/show_bug.cgi?id=50499
Causes crashes in debug LayoutTests (Requested by xan_ on
#webkit).
* platform/win/Skipped:
2010-12-03 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r73302.
http://trac.webkit.org/changeset/73302
https://bugs.webkit.org/show_bug.cgi?id=50499
Causes crashes in debug LayoutTests (Requested by xan_ on
#webkit).
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::renderParentObject):
(WebCore::AccessibilityRenderObject::addChildren):
* accessibility/AccessibilityRenderObject.h:
* accessibility/chromium/AccessibilityObjectChromium.cpp:
(WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
2010-12-03 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r73302.
http://trac.webkit.org/changeset/73302
https://bugs.webkit.org/show_bug.cgi?id=50499
Causes crashes in debug LayoutTests (Requested by xan_ on
#webkit).
* public/WebAccessibilityObject.h:
* src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::parentObject):
2010-12-03 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r73302.
http://trac.webkit.org/changeset/73302
https://bugs.webkit.org/show_bug.cgi?id=50499
Causes crashes in debug LayoutTests (Requested by xan_ on
#webkit).
* DumpRenderTree/chromium/AccessibilityUIElement.cpp:
(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::parentElementCallback):
* DumpRenderTree/chromium/AccessibilityUIElement.h:
* DumpRenderTree/chromium/CppBoundClass.cpp:
* DumpRenderTree/chromium/CppBoundClass.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73317
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 3 Dec 2010 23:52:46 +0000 (23:52 +0000)]
2010-12-03 Alex Bredariol Grilo <abgrilo@profusion.mobi>
Reviewed by Andreas Kling.
Update usage of Eina_Iterator due to EFL changes.
https://bugs.webkit.org/show_bug.cgi?id=50457
* ewk/ewk_tiled_model.c:
(ewk_tile_updates_process):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73316
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Fri, 3 Dec 2010 23:40:42 +0000 (23:40 +0000)]
2010-12-01 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Inspector protocol cleanup task.
The patch has just small renames and adjustments for the protocol things.
'handler' keyword in idl file was replaced with 'domain'.
'domain' property was assigned for the each backend to frontend messages.
At the next step WebInspector wrapper functions will be removed and 'agents' will be called directly.
https://bugs.webkit.org/show_bug.cgi?id=50337
* inspector/CodeGeneratorInspector.pm:
* inspector/Inspector.idl:
* inspector/front-end/inspector.js:
(WebInspector_syncDispatch):
2010-12-01 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Inspector protocol cleanup task.
The patch has just small renames and adjustments for the protocol things.
'handler' keyword in idl file was replaced with 'domain'.
'domain' property was assigned for the each backend to frontend messages.
At the next step WebInspector wrapper functions will be removed and 'agents' will be called directly.
https://bugs.webkit.org/show_bug.cgi?id=50337
* src/WebDevToolsFrontendImpl.cpp:
(WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend):
2010-12-01 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Inspector protocol cleanup task.
The patch has just small renames and adjustments for the protocol things.
'handler' keyword in idl file was replaced with 'domain'.
'domain' property was assigned for the each backend to frontend messages.
At the next step WebInspector wrapper functions will be removed and 'agents' will be called directly.
https://bugs.webkit.org/show_bug.cgi?id=50337
* inspector/report-API-errors-expected.txt:
* inspector/report-API-errors.html:
* inspector/report-protocol-errors-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73315
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Fri, 3 Dec 2010 23:38:11 +0000 (23:38 +0000)]
Update WebKit2 skipped list.
* platform/mac-wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73314
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 3 Dec 2010 23:34:59 +0000 (23:34 +0000)]
2010-12-03 Siddharth Mathur <siddharth.mathur@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] [WK2] Build system improvements for non-Unix targets
https://bugs.webkit.org/show_bug.cgi?id=50257
* DerivedSources.pro:
Fix dir seperator errors on Windows build host. Thanks to Laszlo Gombos.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73313
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Fri, 3 Dec 2010 23:25:55 +0000 (23:25 +0000)]
Enable <a ping> for Mac/Windows/WebKit2 builds
<rdar://problem/
8504473>
https://bugs.webkit.org/show_bug.cgi?id=50488
Reviewed by Maciej Stachowiak.
WebKit/mac:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]): Enable "HyperlinkAuditing" by default.
WebKit/win:
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings): Enable "HyperlinkAuditing" by default.
WebKit2:
* Shared/WebPreferencesStore.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetHyperlinkAuditingEnabled):
(WKPreferencesGetHyperlinkAuditingEnabled):
* UIProcess/API/C/WKPreferences.h:
Add "HyperlinkAuditing" preference and enabled it by default.
WebKitTools:
* TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
(TestWebKitAPI::TEST): Test that the default value of
WKPreferencesGetHyperlinkAuditingEnabled is true.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73312
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Fri, 3 Dec 2010 23:18:01 +0000 (23:18 +0000)]
2010-12-03 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Duplicate "!important" for !important properties displayed in the Styles pane
https://bugs.webkit.org/show_bug.cgi?id=50460
* inspector/front-end/StylesSidebarPane.js:
* inspector/front-end/inspector.css:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73311
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 3 Dec 2010 23:16:20 +0000 (23:16 +0000)]
Flip the destination context when painting a backing store into the destination
https://bugs.webkit.org/show_bug.cgi?id=50491
Reviewed by Dan Bernstein.
* Shared/cg/BackingStoreCG.cpp:
(WebKit::BackingStore::paint):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73310
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Fri, 3 Dec 2010 23:09:55 +0000 (23:09 +0000)]
2010-12-03 Xan Lopez <xlopez@igalia.com>
Unreviewed build fix for GTK+.
Add configure.ac-fu for WebAudio.
* configure.ac:
WebCore:
2010-12-03 Xan Lopez <xlopez@igalia.com>
Unreviewed build fix.
The JS code generator includes headers unconditionally, so we need
to generate them unconditionally and disable the feature. The
WebAudio files hadn't been added to our sources list.
* GNUmakefile.am:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73309
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
victorw@chromium.org [Fri, 3 Dec 2010 23:08:56 +0000 (23:08 +0000)]
2010-12-03 Victor Wang <victorw@chromium.org>
Unreviewed.
[Chromium] update chromium baselines for tests added by http://trac.webkit.org/changeset/73296
* platform/chromium-linux/fast/multicol/span/anonymous-before-child-parent-crash-expected.checksum: Added.
* platform/chromium-linux/fast/multicol/span/anonymous-before-child-parent-crash-expected.png: Added.
* platform/chromium-linux/fast/multicol/span/anonymous-split-block-crash-expected.checksum: Added.
* platform/chromium-linux/fast/multicol/span/anonymous-split-block-crash-expected.png: Added.
* platform/chromium-mac/fast/multicol/span/anonymous-before-child-parent-crash-expected.checksum: Added.
* platform/chromium-mac/fast/multicol/span/anonymous-before-child-parent-crash-expected.png: Added.
* platform/chromium-mac/fast/multicol/span/anonymous-split-block-crash-expected.checksum: Added.
* platform/chromium-mac/fast/multicol/span/anonymous-split-block-crash-expected.png: Added.
* platform/chromium-win/fast/multicol/span/anonymous-before-child-parent-crash-expected.checksum: Added.
* platform/chromium-win/fast/multicol/span/anonymous-before-child-parent-crash-expected.png: Added.
* platform/chromium-win/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt: Added.
* platform/chromium-win/fast/multicol/span/anonymous-split-block-crash-expected.checksum: Added.
* platform/chromium-win/fast/multicol/span/anonymous-split-block-crash-expected.png: Added.
* platform/chromium-win/fast/multicol/span/anonymous-split-block-crash-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73308
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
msaboff@apple.com [Fri, 3 Dec 2010 22:48:19 +0000 (22:48 +0000)]
2010-12-03 Michael Saboff <msaboff@apple.com>
Reviewed by Gavin Barraclough
Changes to significantly reduce branches to branches in JIT'ed
parentheses backtrack processing. The changes include the following:
- Taking the backtracking processing out of line and adding it as
code at the end of the JIT'ed routine.
- Allow backtracks to be direct via an indirect branch for an address
pushed onto the stack. If the use of an indirect branch is from a
conditional jump, then we emit a trampoline at the end of the
routine.
- Propogate backtracks instead of adding trampolines. Backtracks are
propogated to where they are used. This change also eliminated
trampoline branch code that aren't used.
- Added global expression state to keep track of parentheses tail
code and indirect branches.
Other changes made to support these changes.
- Split invertOrCapture flag on Patterns to two separate flags. Added
getters for these flags. Rippled these changes to both the JIT
and interpreter code.
- Split BacktrackDestination out off TermGenerationState struct.
This is done to hold references to a backtrack for later code
generation.
https://bugs.webkit.org/show_bug.cgi?id=50295
* assembler/ARMAssembler.h:
(JSC::ARMAssembler::JmpDst::isSet):
* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::JmpDst::isSet):
* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::Label::isSet):
(JSC::AbstractMacroAssembler::DataLabelPtr::isUsed):
(JSC::AbstractMacroAssembler::DataLabelPtr::used):
(JSC::AbstractMacroAssembler::JumpList::clear):
* assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::JmpDst::isSet):
* assembler/X86Assembler.h:
(JSC::X86Assembler::JmpDst::isSet):
* yarr/RegexCompiler.cpp:
(JSC::Yarr::RegexPatternConstructor::atomParenthesesSubpatternBegin):
(JSC::Yarr::RegexPatternConstructor::atomParentheticalAssertionBegin):
(JSC::Yarr::RegexPatternConstructor::atomBackReference):
(JSC::Yarr::RegexPatternConstructor::setupAlternativeBeginTerms):
* yarr/RegexInterpreter.cpp:
(JSC::Yarr::ByteCompiler::atomParenthesesOnceBegin):
(JSC::Yarr::ByteCompiler::atomParenthesesTerminalBegin):
(JSC::Yarr::ByteCompiler::atomParenthesesSubpatternBegin):
(JSC::Yarr::ByteCompiler::atomParentheticalAssertionBegin):
(JSC::Yarr::ByteCompiler::atomParentheticalAssertionEnd):
(JSC::Yarr::ByteCompiler::atomParenthesesSubpatternEnd):
(JSC::Yarr::ByteCompiler::atomParenthesesOnceEnd):
(JSC::Yarr::ByteCompiler::atomParenthesesTerminalEnd):
(JSC::Yarr::ByteCompiler::emitDisjunction):
* yarr/RegexInterpreter.h:
(JSC::Yarr::ByteTerm::ByteTerm):
(JSC::Yarr::ByteTerm::BackReference):
(JSC::Yarr::ByteTerm::invert):
(JSC::Yarr::ByteTerm::capture):
* yarr/RegexJIT.cpp:
(JSC::Yarr::RegexGenerator::IndirectJumpEntry::IndirectJumpEntry):
(JSC::Yarr::RegexGenerator::IndirectJumpEntry::addJump):
(JSC::Yarr::RegexGenerator::GenerationState::GenerationState):
(JSC::Yarr::RegexGenerator::GenerationState::addIndirectJumpEntry):
(JSC::Yarr::RegexGenerator::GenerationState::emitIndirectJumpTable):
(JSC::Yarr::RegexGenerator::GenerationState::addParenthesesTail):
(JSC::Yarr::RegexGenerator::GenerationState::emitParenthesesTail):
(JSC::Yarr::RegexGenerator::GenerationState::addJumpToNextInteration):
(JSC::Yarr::RegexGenerator::GenerationState::addJumpsToNextInteration):
(JSC::Yarr::RegexGenerator::GenerationState::addDataLabelToNextIteration):
(JSC::Yarr::RegexGenerator::GenerationState::linkToNextIteration):
(JSC::Yarr::RegexGenerator::BacktrackDestination::BacktrackDestination):
(JSC::Yarr::RegexGenerator::BacktrackDestination::clear):
(JSC::Yarr::RegexGenerator::BacktrackDestination::clearDataLabel):
(JSC::Yarr::RegexGenerator::BacktrackDestination::haveDestination):
(JSC::Yarr::RegexGenerator::BacktrackDestination::isStackOffset):
(JSC::Yarr::RegexGenerator::BacktrackDestination::isLabel):
(JSC::Yarr::RegexGenerator::BacktrackDestination::isJumpList):
(JSC::Yarr::RegexGenerator::BacktrackDestination::haveDataLabel):
(JSC::Yarr::RegexGenerator::BacktrackDestination::copyTarget):
(JSC::Yarr::RegexGenerator::BacktrackDestination::copyTo):
(JSC::Yarr::RegexGenerator::BacktrackDestination::addBacktrackJump):
(JSC::Yarr::RegexGenerator::BacktrackDestination::setStackOffset):
(JSC::Yarr::RegexGenerator::BacktrackDestination::setLabel):
(JSC::Yarr::RegexGenerator::BacktrackDestination::setNextBacktrackLabel):
(JSC::Yarr::RegexGenerator::BacktrackDestination::setBacktrackToLabel):
(JSC::Yarr::RegexGenerator::BacktrackDestination::setBacktrackJumpList):
(JSC::Yarr::RegexGenerator::BacktrackDestination::setBacktrackSourceLabel):
(JSC::Yarr::RegexGenerator::BacktrackDestination::setDataLabel):
(JSC::Yarr::RegexGenerator::BacktrackDestination::setSubDataLabelPtr):
(JSC::Yarr::RegexGenerator::BacktrackDestination::linkToNextBacktrack):
(JSC::Yarr::RegexGenerator::BacktrackDestination::getStackOffset):
(JSC::Yarr::RegexGenerator::BacktrackDestination::getLabel):
(JSC::Yarr::RegexGenerator::BacktrackDestination::getBacktrackJumps):
(JSC::Yarr::RegexGenerator::BacktrackDestination::getDataLabel):
(JSC::Yarr::RegexGenerator::BacktrackDestination::jumpToBacktrack):
(JSC::Yarr::RegexGenerator::BacktrackDestination::linkDataLabelToHereIfExists):
(JSC::Yarr::RegexGenerator::BacktrackDestination::plantJumpToBacktrackIfExists):
(JSC::Yarr::RegexGenerator::BacktrackDestination::linkAlternativeBacktracks):
(JSC::Yarr::RegexGenerator::BacktrackDestination::linkAlternativeBacktracksTo):
(JSC::Yarr::RegexGenerator::TermGenerationState::TermGenerationState):
(JSC::Yarr::RegexGenerator::TermGenerationState::resetAlternative):
(JSC::Yarr::RegexGenerator::TermGenerationState::isLastAlternative):
(JSC::Yarr::RegexGenerator::TermGenerationState::clearBacktrack):
(JSC::Yarr::RegexGenerator::TermGenerationState::jumpToBacktrack):
(JSC::Yarr::RegexGenerator::TermGenerationState::plantJumpToBacktrackIfExists):
(JSC::Yarr::RegexGenerator::TermGenerationState::linkDataLabelToBacktrackIfExists):
(JSC::Yarr::RegexGenerator::TermGenerationState::addBacktrackJump):
(JSC::Yarr::RegexGenerator::TermGenerationState::setDataLabelPtr):
(JSC::Yarr::RegexGenerator::TermGenerationState::setBackTrackStackOffset):
(JSC::Yarr::RegexGenerator::TermGenerationState::setBacktrackLabel):
(JSC::Yarr::RegexGenerator::TermGenerationState::linkAlternativeBacktracks):
(JSC::Yarr::RegexGenerator::TermGenerationState::linkAlternativeBacktracksTo):
(JSC::Yarr::RegexGenerator::TermGenerationState::setBacktrackLink):
(JSC::Yarr::RegexGenerator::TermGenerationState::chainBacktracks):
(JSC::Yarr::RegexGenerator::TermGenerationState::chainBacktrackJumps):
(JSC::Yarr::RegexGenerator::TermGenerationState::getBacktrackDestination):
(JSC::Yarr::RegexGenerator::TermGenerationState::propagateBacktrackingFrom):
(JSC::Yarr::RegexGenerator::ParenthesesTail::ParenthesesTail):
(JSC::Yarr::RegexGenerator::ParenthesesTail::processBacktracks):
(JSC::Yarr::RegexGenerator::ParenthesesTail::setNextIteration):
(JSC::Yarr::RegexGenerator::ParenthesesTail::generateCode):
(JSC::Yarr::RegexGenerator::generateAssertionBOL):
(JSC::Yarr::RegexGenerator::generateAssertionEOL):
(JSC::Yarr::RegexGenerator::generateAssertionWordBoundary):
(JSC::Yarr::RegexGenerator::generatePatternCharacterSingle):
(JSC::Yarr::RegexGenerator::generatePatternCharacterPair):
(JSC::Yarr::RegexGenerator::generatePatternCharacterFixed):
(JSC::Yarr::RegexGenerator::generatePatternCharacterGreedy):
(JSC::Yarr::RegexGenerator::generatePatternCharacterNonGreedy):
(JSC::Yarr::RegexGenerator::generateCharacterClassSingle):
(JSC::Yarr::RegexGenerator::generateCharacterClassFixed):
(JSC::Yarr::RegexGenerator::generateCharacterClassGreedy):
(JSC::Yarr::RegexGenerator::generateCharacterClassNonGreedy):
(JSC::Yarr::RegexGenerator::generateParenthesesDisjunction):
(JSC::Yarr::RegexGenerator::generateParenthesesSingle):
(JSC::Yarr::RegexGenerator::generateParenthesesGreedyNoBacktrack):
(JSC::Yarr::RegexGenerator::generateParentheticalAssertion):
(JSC::Yarr::RegexGenerator::generateDisjunction):
(JSC::Yarr::RegexGenerator::compile):
* yarr/RegexPattern.h:
(JSC::Yarr::PatternTerm::PatternTerm):
(JSC::Yarr::PatternTerm::invert):
(JSC::Yarr::PatternTerm::capture):
2010-12-03 Michael Saboff <msaboff@apple.com>
Reviewed by Gavin Barraclough
Added new tests to support changes to Regexp JIT code handling
of parentheses. Tests focused on backtracking and nested
subexpressions.
https://bugs.webkit.org/show_bug.cgi?id=50295
* fast/regex/parentheses-expected.txt: Added.
* fast/regex/parentheses.html: Added.
* fast/regex/script-tests/parentheses.js: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73307
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Fri, 3 Dec 2010 22:36:04 +0000 (22:36 +0000)]
WebContextMenuClient::fixMenuReceivedFromOldSafari is no longer needed on Windows
https://bugs.webkit.org/show_bug.cgi?id=50486
Reviewed by Brady Eidson.
Remove the static fixMenuReceivedFromOldSafari and isPreInspectElementTagSafari methods
from WebContextMenuClient. There were there for when WebKit had the Inspect Element context menu
item, but Safari didn't support it. We don't support that old Safari, so that code can go.
* WebCoreSupport/WebContextMenuClient.cpp:
(WebContextMenuClient::getCustomMenuFromDefaultItems):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73305
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Fri, 3 Dec 2010 22:32:07 +0000 (22:32 +0000)]
2010-12-03 Patrick Gansterer <paroga@webkit.org>
Unreviewed build fix.
Try to fix EFL build after r73273.
* CMakeLists.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73303
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 3 Dec 2010 22:27:53 +0000 (22:27 +0000)]
2010-12-03 Chris Guillory <chris.guillory@google.com>
Reviewed by Chris Fleizach.
Include the FrameView widget of a RenderWidget in the accessibility tree.
https://bugs.webkit.org/show_bug.cgi?id=49106
* platform/win/Skipped:
2010-12-03 Chris Guillory <chris.guillory@google.com>
Reviewed by Chris Fleizach.
Include the FrameView widget of a RenderWidget in the accessibility tree.
https://bugs.webkit.org/show_bug.cgi?id=49106
Include render widget children in the accessibility tree for not mac webkit ports.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::renderParentObject):
(WebCore::AccessibilityRenderObject::addChildren):
(WebCore::AccessibilityRenderObject::addRenderWidgetChildren):
* accessibility/AccessibilityRenderObject.h:
* accessibility/chromium/AccessibilityObjectChromium.cpp:
(WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
2010-12-03 Chris Guillory <chris.guillory@google.com>
Reviewed by Chris Fleizach.
Include the FrameView widget of a RenderWidget in the accessibility tree.
https://bugs.webkit.org/show_bug.cgi?id=49106
* public/WebAccessibilityObject.h:
* src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::equals):
(WebKit::WebAccessibilityObject::parentObject):
2010-12-03 Chris Guillory <chris.guillory@google.com>
Reviewed by Chris Fleizach.
Include the FrameView widget of a RenderWidget in the accessibility tree.
https://bugs.webkit.org/show_bug.cgi?id=49106
* DumpRenderTree/chromium/AccessibilityUIElement.cpp:
(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::parentElementCallback):
(AccessibilityUIElement::isEqualCallback):
* DumpRenderTree/chromium/AccessibilityUIElement.h:
* DumpRenderTree/chromium/CppBoundClass.cpp:
(CppBoundClass::getFromCppVariant):
* DumpRenderTree/chromium/CppBoundClass.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73302
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 3 Dec 2010 22:10:51 +0000 (22:10 +0000)]
Export the 4 new API headers I added today.
Reviewed by good sense in fixing builds.
* WebKit2.xcodeproj/project.pbxproj:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73301
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
victorw@chromium.org [Fri, 3 Dec 2010 22:08:30 +0000 (22:08 +0000)]
2010-12-03 Victor Wang <victorw@chromium.org>
Unreviewed.
[Chromium] clean up chromium test expectations.
* platform/chromium-mac/platform/mac/editing: Removed.
* platform/chromium-mac/platform/mac/editing/spelling: Removed.
* platform/chromium-mac/platform/mac/editing/spelling/delete-autocorrected-word-1-expected.checksum: Removed.
* platform/chromium-mac/platform/mac/editing/spelling/delete-autocorrected-word-1-expected.png: Removed.
* platform/chromium-win/platform/mac/editing/spelling: Removed.
* platform/chromium-win/platform/mac/editing/spelling/delete-autocorrected-word-1-expected.checksum: Removed.
* platform/chromium-win/platform/mac/editing/spelling/delete-autocorrected-word-1-expected.png: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73300
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 3 Dec 2010 22:06:14 +0000 (22:06 +0000)]
<rdar://problem/
8725679> and https://bugs.webkit.org/show_bug.cgi?id=50482
Crash trying to empty caches with no WebProcess.
Reviewed by Sam Weinig.
* Shared/WebProcessCreationParameters.h: Add the "clear this cache" flags.
* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
(WebKit::WebContext::ensureWebProcess): If either of the clear cache flags are set when a new WebProcess is
created, include those flags in the parameters.
(WebKit::WebContext::clearResourceCaches): If the current process isn't valid, flag this action to be done later.
(WebKit::WebContext::clearApplicationCache): Ditto.
* UIProcess/WebContext.h:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess): Clear the caches if told to.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73299
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Fri, 3 Dec 2010 22:02:42 +0000 (22:02 +0000)]
2010-12-03 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Chang.
Rebaseline server: organize tests by state, add dry run mode
https://bugs.webkit.org/show_bug.cgi?id=50473
Group tests in the menu by state, so that it's easier to see after
processing the queue which failed.
Add support for the --dry-run flag so that it's easier to test changes
such as this (stubs out filesystem and SCM operations).
* Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
* Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
* Scripts/webkitpy/tool/commands/rebaselineserver.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73298
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Fri, 3 Dec 2010 21:51:30 +0000 (21:51 +0000)]
Fix failing API test. The default san serif font on the mac
should be Helvetica, not Courier.
Reviewed by Gavin Barraclough.
* Shared/WebPreferencesStore.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73297
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Fri, 3 Dec 2010 21:44:21 +0000 (21:44 +0000)]
2010-11-30 Abhishek Arya <inferno@chromium.org>
Reviewed by Dave Hyatt.
Don't clone an anonymous block, instead create a new one in splitBlocks. Also,
when beforeChild is not in one of our children, then do the processing first
to get its anonymous container before calling splitBlocks.
https://bugs.webkit.org/show_bug.cgi?id=49928
Tests: fast/multicol/span/anonymous-before-child-parent-crash.html
fast/multicol/span/anonymous-split-block-crash.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::splitBlocks):
(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):
2010-12-03 Abhishek Arya <inferno@chromium.org>
Reviewed by Dave Hyatt.
Test passes if we do not crash in splitBlocks while working with anonymous
blocks.
https://bugs.webkit.org/show_bug.cgi?id=49928
* fast/multicol/span/anonymous-before-child-parent-crash.html: Added.
* fast/multicol/span/anonymous-split-block-crash.html: Added.
* platform/mac/fast/multicol/span/anonymous-before-child-parent-crash-expected.checksum: Added.
* platform/mac/fast/multicol/span/anonymous-before-child-parent-crash-expected.png: Added.
* platform/mac/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt: Added.
* platform/mac/fast/multicol/span/anonymous-split-block-crash-expected.checksum: Added.
* platform/mac/fast/multicol/span/anonymous-split-block-crash-expected.png: Added.
* platform/mac/fast/multicol/span/anonymous-split-block-crash-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73296
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 3 Dec 2010 21:41:00 +0000 (21:41 +0000)]
2010-12-03 Mark Rowe <mrowe@apple.com>
Reviewed by Eric Seidel.
Animated GIF animates much more slowly in Safari than Firefox
<rdar://problem/
7689300> / <http://webkit.org/b/26455>
Adopt Firefox's behavior for frame duration clamping. Images that specify a frame duration
of <= 10ms are treated as having a frame duration of 100ms, while all other images use the
frame duration that they specify.
ImageIO currently implements its own clamping of frame durations (<rdar://problem/
7689297>)
which will result in this change having no observable effect on platforms where it is used
until an updated version of ImageIO becomes available.
* platform/graphics/ImageSource.cpp:
(WebCore::ImageSource::frameDurationAtIndex): Update the formatting of the comment and style
of the code to match that in ImageSourceCG.
* platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::frameDurationAtIndex):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73295
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
crogers@google.com [Fri, 3 Dec 2010 21:38:16 +0000 (21:38 +0000)]
2010-12-03 Chris Rogers <crogers@google.com>
Unreviewed build fix.
Fix M_E compile error on Chromium Win
https://bugs.webkit.org/show_bug.cgi?id=50479
* platform/audio/AudioUtilities.cpp:
(WebCore::AudioUtilities::discreteTimeConstantForSampleRate):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73294
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
crogers@google.com [Fri, 3 Dec 2010 21:17:29 +0000 (21:17 +0000)]
2010-12-03 Chris Rogers <crogers@google.com>
Unreviewed build fix.
Try to fix GTK build due to recent web audio makefile changes (disable ENABLE_WEB_AUDIO explicitly)
https://bugs.webkit.org/show_bug.cgi?id=50478
* GNUmakefile.am:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73293
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 3 Dec 2010 21:12:00 +0000 (21:12 +0000)]
2010-12-03 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dirk Schulze.
Clean up some text-related code on GraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=50464
Save 8 bytes in GraphicsContextState by rearranging the
data members to reduce padding.
* platform/graphics/GraphicsContextPrivate.h:
(WebCore::GraphicsContextState::GraphicsContextState):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73292
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 3 Dec 2010 21:09:17 +0000 (21:09 +0000)]
2010-12-03 Simon Fraser <simon.fraser@apple.com>
Another Chromium build fix.
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::setPlatformTextDrawingMode):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73291
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 3 Dec 2010 20:53:42 +0000 (20:53 +0000)]
2010-12-03 Simon Fraser <simon.fraser@apple.com>
Fix Chromium build.
* platform/graphics/skia/PlatformContextSkia.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73290
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Fri, 3 Dec 2010 20:53:07 +0000 (20:53 +0000)]
2010-12-03 Patrick Gansterer <paroga@webkit.org>
Reviewed by Andreas Kling.
[CMake] Remove WebCore_IDL_PURE_FILES
https://bugs.webkit.org/show_bug.cgi?id=50445
* CMakeLists.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73289
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Fri, 3 Dec 2010 20:52:23 +0000 (20:52 +0000)]
Update the Windows results for controls-without-preload.html to make the bots green. Unreviewed.
media/controls-without-preload.html failing on Windows
https://bugs.webkit.org/show_bug.cgi?id=50471
* platform/win/media/controls-without-preload-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73288
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 3 Dec 2010 20:45:34 +0000 (20:45 +0000)]
2010-12-03 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
Need to move all code that applies correction into correction panel callback.
https://bugs.webkit.org/show_bug.cgi?id=50426
<rdar://problem/
8720832>
Added expected png file.
* platform/mac/editing/spelling/delete-autocorrected-word-1-expected.checksum: Added.
* platform/mac/editing/spelling/delete-autocorrected-word-1-expected.png: Added.
2010-12-03 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
Need to move all code that applies correction into correction panel callback.
https://bugs.webkit.org/show_bug.cgi?id=50426
<rdar://problem/
8720832>
No new test, since there's no behavioral change.
This patch is to prepare WebKit to work with upcoming AppKit changes. The main changes are:
1. Moved all calls to applyCorrectionPanelInfo() into handleCorrectionPanelResult().
2. Added more user dictionary learning code.
3. Removed m_ prefix in all member variables of CorrectionPanelInfo.
* editing/CorrectionPanelInfo.h: Remove m_ prefix on member variables. Added ReasonForDismissingCorrectionPanel enum type.
* editing/Editor.cpp: Moved all calls to applyCorrectionPanelInfo() into handleCorrectionPanelResult().
Adopted new member variable naming in class CorrectionPanelInfo.
(WebCore::Editor::respondToChangedSelection):
(WebCore::Editor::~Editor):
(WebCore::Editor::markMisspellingsAfterTypingToWord):
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
(WebCore::Editor::correctionPanelTimerFired):
(WebCore::Editor::handleCorrectionPanelResult):
(WebCore::Editor::startCorrectionPanelTimer):
(WebCore::Editor::stopCorrectionPanelTimer):
(WebCore::Editor::handleCancelOperation):
(WebCore::Editor::dismissCorrectionPanel):
(WebCore::Editor::applyCorrectionPanelInfo):
* editing/Editor.h: Changed signature of dismissCorrectionPanel to use ReasonForDismissingCorrectionPanel.
* loader/EmptyClients.h: Ditto.
(WebCore::EmptyEditorClient::dismissCorrectionPanel):
* page/EditorClient.h: Ditto.
2010-12-03 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
Need to move all code that applies correction into correction panel callback.
https://bugs.webkit.org/show_bug.cgi?id=50426
<rdar://problem/
8720832>
* WebCoreSupport/WebEditorClient.h: Adopted new signature of dismissCorrectionPanel.
* WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::~WebEditorClient): Adopted new signature of dismissCorrectionPanel.
(WebEditorClient::showCorrectionPanel): Added more user dictionary learning code.
(WebEditorClient::dismissCorrectionPanel): Adopted new signature of dismissCorrectionPanel.
2010-12-03 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
Need to move all code that applies correction into correction panel callback.
https://bugs.webkit.org/show_bug.cgi?id=50426
<rdar://problem/
8720832>
Adopted new signature of dismissCorrectionPanel.
* WebProcess/WebCoreSupport/WebEditorClient.h:
* WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
(WebKit::WebEditorClient::dismissCorrectionPanel):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73287
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Fri, 3 Dec 2010 20:35:15 +0000 (20:35 +0000)]
Windows build fix. Unreviewed.
* win/WebKit2Generated.make:
Add the new API files from http://trac.webkit.org/changeset/73281.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73286
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 3 Dec 2010 20:11:23 +0000 (20:11 +0000)]
2010-12-03 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: reveal in elements panel does not switch the panel itself.
https://bugs.webkit.org/show_bug.cgi?id=50408
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired.focusElement):
(WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired):
* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype._contextMenuEventFired):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73285
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 3 Dec 2010 20:08:04 +0000 (20:08 +0000)]
2010-12-03 Simon Fraser <simon.fraser@apple.com>
Reviewed by Nikolas Zimmermann.
Clean up some text-related code on GraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=50464
Use defined types for textDrawingMode and it's associated flags.
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawTextInternal):
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::textDrawingMode):
(WebCore::GraphicsContext::setTextDrawingMode):
(WebCore::GraphicsContext::setPlatformTextDrawingMode):
* platform/graphics/GraphicsContext.h:
* platform/graphics/GraphicsContextPrivate.h:
(WebCore::GraphicsContextState::GraphicsContextState):
* platform/graphics/cairo/FontCairo.cpp:
(WebCore::drawGlyphsShadow):
(WebCore::Font::drawGlyphs):
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::setPlatformTextDrawingMode):
* platform/graphics/chromium/FontLinux.cpp:
(WebCore::Font::drawGlyphs):
(WebCore::Font::drawComplexText):
* platform/graphics/gtk/FontGtk.cpp:
(WebCore::drawGlyphsShadow):
(WebCore::Font::drawComplexText):
* platform/graphics/mac/FontMac.mm:
(WebCore::Font::drawGlyphs):
* platform/graphics/openvg/PainterOpenVG.cpp:
(WebCore::PlatformPainterState::PlatformPainterState):
(WebCore::PainterOpenVG::textDrawingMode):
(WebCore::PainterOpenVG::setTextDrawingMode):
(WebCore::PainterOpenVG::drawText):
* platform/graphics/qt/FontQt.cpp:
(WebCore::drawTextCommon):
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::State::State):
(WebCore::PlatformContextSkia::getTextDrawingMode):
(WebCore::PlatformContextSkia::setTextDrawingMode):
* platform/graphics/skia/SkiaFontWin.cpp:
(WebCore::windowsCanHandleTextDrawing):
(WebCore::paintSkiaText):
* platform/graphics/texmap/TextureMapper.h:
(WebCore::TextureMapper::setTextDrawingMode):
(WebCore::TextureMapper::textDrawingMode):
(WebCore::TextureMapper::TextureMapper):
* platform/graphics/win/FontCGWin.cpp:
(WebCore::drawGDIGlyphs):
(WebCore::Font::drawGlyphs):
* platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::GraphicsContext::drawText):
* rendering/InlineTextBox.cpp:
(WebCore::updateGraphicsContext):
* rendering/RenderSVGResourceGradient.cpp:
(WebCore::RenderSVGResourceGradient::applyResource):
* rendering/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::applyResource):
* rendering/RenderSVGResourceSolidColor.cpp:
(WebCore::RenderSVGResourceSolidColor::applyResource):
* svg/SVGFont.cpp:
(WebCore::Font::drawTextUsingSVGFont):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73284
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
crogers@google.com [Fri, 3 Dec 2010 20:05:14 +0000 (20:05 +0000)]
2010-12-03 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
First steps to adding web audio files to build systems
https://bugs.webkit.org/show_bug.cgi?id=49952
* wtf/Complex.h:
2010-12-03 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
First steps to adding web audio files to build systems
https://bugs.webkit.org/show_bug.cgi?id=49952
No new tests since audio API is not yet implemented.
* CMakeLists.txt:
* DerivedSources.make:
* ForwardingHeaders/wtf/Complex.h: Added.
* GNUmakefile.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.pri:
* WebCore.pro:
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::audioContext):
* features.pri:
* page/DOMWindow.idl:
* platform/audio/HRTFElevation.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73283
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Fri, 3 Dec 2010 19:47:38 +0000 (19:47 +0000)]
2010-12-03 Patrick Gansterer <paroga@webkit.org>
Reviewed by David Levin.
Use String::adopt in TextCodecWinCE::decode
https://bugs.webkit.org/show_bug.cgi?id=50319
* platform/text/wince/TextCodecWinCE.cpp:
(WebCore::TextCodecWinCE::decode):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73282
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 3 Dec 2010 19:41:49 +0000 (19:41 +0000)]
Groundwork for <rdar://problem/
7660733> and https://bugs.webkit.org/show_bug.cgi?id=50191
WebKit2 Authentication Support
Reviewed by Anders Carlsson.
WebCore:
* WebCore.exp.in:
Expose the AuthenticationClient for WK2 platforms (Windows already does this):
* platform/network/mac/AuthenticationChallenge.h:
* platform/network/mac/AuthenticationMac.mm:
(-[WebCoreAuthenticationClientAsChallengeSender client]):
(WebCore::AuthenticationChallenge::authenticationClient):
* platform/network/qt/AuthenticationChallenge.h:
(WebCore::AuthenticationChallenge::authenticationClient):
WebKit2:
With this patch in place, authentication challenges are sent up from WebCore and shipped over the IPC layer.
Client apps can implement the related client methods to attempt to continue without credentials or cancel a
challenge.
There's not yet API to inspect a challenge or create a credential to use in reply - that will come later.
Build-system changes:
* DerivedSources.make:
* DerivedSources.pro:
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
* win/WebKit2Common.vsprops:
Messages and casts for IPC and APIs:
* Platform/CoreIPC/MessageID.h:
* Shared/API/c/WKBase.h:
* Shared/APIObject.h:
* Shared/WebCoreArgumentCoders.h:
* UIProcess/API/C/WKAPICast.h:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didReceiveMessage):
Stub out the AuthenticationChallenge class family:
* UIProcess/API/C/WKAuthenticationChallenge.cpp: Added.
(WKAuthenticationChallengeGetTypeID):
* UIProcess/API/C/WKAuthenticationChallenge.h: Added.
* UIProcess/API/C/WKCredential.cpp: Added.
(WKCredentialGetTypeID):
* UIProcess/API/C/WKCredential.h: Added.
* UIProcess/API/C/WKProtectionSpace.cpp: Added.
(WKProtectionSpaceGetTypeID):
* UIProcess/API/C/WKProtectionSpace.h: Added.
Add an Authentication listener for the client app to respond to:
* UIProcess/API/C/WKAuthenticationDecisionListener.cpp: Added.
(WKAuthenticationDecisionListenerGetTypeID):
(WKAuthenticationDecisionListenerUseCredential):
(WKAuthenticationDecisionListenerCancel):
* UIProcess/API/C/WKAuthenticationDecisionListener.h: Added.
Add Authentication related methods to the page loader client:
* UIProcess/API/C/WKPage.h:
Add empty implementations of the new API objects:
* UIProcess/Authentication: Added.
* UIProcess/Authentication/AuthenticationChallengeProxy.cpp: Added.
(WebKit::AuthenticationChallengeProxy::AuthenticationChallengeProxy):
(WebKit::AuthenticationChallengeProxy::~AuthenticationChallengeProxy):
(WebKit::AuthenticationChallengeProxy::useCredential):
(WebKit::AuthenticationChallengeProxy::cancel):
* UIProcess/Authentication/AuthenticationChallengeProxy.h: Added.
(WebKit::AuthenticationChallengeProxy::create):
(WebKit::AuthenticationChallengeProxy::listener):
(WebKit::AuthenticationChallengeProxy::type):
* UIProcess/Authentication/WebCredential.cpp: Added.
(WebKit::WebCredential::core):
* UIProcess/Authentication/WebCredential.h: Added.
(WebKit::WebCredential::create):
(WebKit::WebCredential::type):
* UIProcess/Authentication/WebProtectionSpace.cpp: Added.
(WebKit::WebProtectionSpace::WebProtectionSpace):
* UIProcess/Authentication/WebProtectionSpace.h: Added.
(WebKit::WebProtectionSpace::create):
(WebKit::WebProtectionSpace::type):
Add implementation of the Authentication decision listener:
* UIProcess/Authentication/AuthenticationDecisionListener.cpp: Added.
(WebKit::AuthenticationDecisionListener::AuthenticationDecisionListener):
(WebKit::AuthenticationDecisionListener::useCredential):
(WebKit::AuthenticationDecisionListener::cancel):
(WebKit::AuthenticationDecisionListener::detachChallenge):
* UIProcess/Authentication/AuthenticationDecisionListener.h: Added.
(WebKit::AuthenticationDecisionListener::create):
(WebKit::AuthenticationDecisionListener::type):
WebPage and PageLoaderClient glue:
* UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::canAuthenticateAgainstProtectionSpaceInFrame):
(WebKit::WebLoaderClient::didReceiveAuthenticationChallengeInFrame):
* UIProcess/WebLoaderClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::canAuthenticateAgainstProtectionSpaceInFrame):
(WebKit::WebPageProxy::didReceiveAuthenticationChallenge):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
Add a manager to map the actual platform authentication challenges to a challenge ID,
as at least some platforms require the object identity to persist:
* WebProcess/Authentication: Added.
* WebProcess/Authentication/AuthenticationManager.cpp: Added.
(WebKit::generateAuthenticationChallengeID):
(WebKit::AuthenticationManager::shared):
(WebKit::AuthenticationManager::AuthenticationManager):
(WebKit::AuthenticationManager::didReceiveMessage):
(WebKit::AuthenticationManager::didReceiveAuthenticationChallenge):
(WebKit::AuthenticationManager::useCredentialForChallenge):
(WebKit::AuthenticationManager::continueWithoutCredentialForChallenge):
(WebKit::AuthenticationManager::cancelChallenge):
* WebProcess/Authentication/AuthenticationManager.h: Added.
* WebProcess/Authentication/AuthenticationManager.messages.in: Added.
Hand off Authentication challenges to the manager to be sent over IPC:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
(WebKit::WebFrameLoaderClient::canAuthenticateAgainstProtectionSpace):
* UIProcess/API/qt/qwkpage.cpp:
WebKitTools:
Keep these builds working:
* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController awakeFromNib]):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73281
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Fri, 3 Dec 2010 19:33:28 +0000 (19:33 +0000)]
Added fast/text/font-size-zero.html and svg/batik/text/smallFonts.svg to
the leopard skipped list.
Reviewed by Gavin Barraclough.
* platform/mac-leopard/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73280
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 3 Dec 2010 19:26:22 +0000 (19:26 +0000)]
2010-12-03 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
REGRESSION: Crash when deleting text after textarea's value is modified on input event
https://bugs.webkit.org/show_bug.cgi?id=49962
The crash was caused by TypingCommand::deleteKeyPressed's reusing a typing command for
textarea's shadow DOM after its input event handler rewrote the value set by the typing command.
Because the reused typing command's ending selection was pointing at a shadow node
that has been detached from the document when the event handler set the new value,
rootEditableElement of the ending selection was null and caused the crash.
Fixed the bug by updating the ending selection of the last typing command when it differsfrom
that of the current selection held by the SelectionController in TypingCommand::deleteKeyPressed.
Also fixed similar bugs in forwardDeleteKeyPressed and insertText, and insertTextRunWithoutNewlines.
Tests: editing/input/set-value-on-input-and-delete.html
editing/input/set-value-on-input-and-forward-delete.html
editing/input/set-value-on-input-and-type-input.html
editing/input/set-value-on-input-and-type-textarea.html
* editing/InsertTextCommand.h: Added TypingCommand as a friend because it needs to update selection.
* editing/TypingCommand.cpp:
(WebCore::TypingCommand::deleteKeyPressed): Updates the last typing command's selection as needed.
(WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
(WebCore::TypingCommand::insertText): Ditto.
(WebCore::TypingCommand::updateSelectionIfDifferentFromCurrentSelection): Added.
(WebCore::TypingCommand::insertTextRunWithoutNewlines): Updates InsertTextCommand's selection as needed.
* editing/TypingCommand.h:
2010-12-03 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
REGRESSION: Crash when deleting text after textarea's value is modified on input event
https://bugs.webkit.org/show_bug.cgi?id=49962
Added tests to ensure inserting and deleting a character inside input or textarea
succeeds even if the value of those elements have been rewritten by its input event handler.
* editing/input/set-value-on-input-and-delete-expected.txt: Added.
* editing/input/set-value-on-input-and-delete.html: Added.
* editing/input/set-value-on-input-and-forward-delete-expected.txt: Added.
* editing/input/set-value-on-input-and-forward-delete.html: Added.
* editing/input/set-value-on-input-and-type-input-expected.txt: Added.
* editing/input/set-value-on-input-and-type-input.html: Added.
* editing/input/set-value-on-input-and-type-textarea-expected.txt: Added.
* editing/input/set-value-on-input-and-type-textarea.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73279
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Fri, 3 Dec 2010 19:20:56 +0000 (19:20 +0000)]
Add missing expected results.
* media/controls-without-preload-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73278
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Fri, 3 Dec 2010 19:18:55 +0000 (19:18 +0000)]
Updating the Windows 7 results for clip-path-referencing-use.svg to make the bots green. Unreviewed.
svg/custom/clip-path-referencing-use.svg fails when run with Aero enabled.
https://bugs.webkit.org/show_bug.cgi?id=49945
Make sure that the XP results still match the Mac results.
* platform/win-xp/svg: Added.
* platform/win-xp/svg/custom: Added.
* platform/win-xp/svg/custom/clip-path-referencing-use-expected.checksum: Added.
* platform/win-xp/svg/custom/clip-path-referencing-use-expected.png: Added.
* platform/win-xp/svg/custom/clip-path-referencing-use-expected.txt: Added.
* platform/win/svg/custom/clip-path-referencing-use-expected.checksum: Added.
* platform/win/svg/custom/clip-path-referencing-use-expected.png: Added.
* platform/win/svg/custom/clip-path-referencing-use-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73277
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Fri, 3 Dec 2010 19:18:09 +0000 (19:18 +0000)]
2010-12-03 Daniel Cheng <dcheng@chromium.org>
Reviewed by Tony Chang.
Dragging and dropping into an empty document crashes WebKit.
https://bugs.webkit.org/show_bug.cgi?id=48793
Remove the assert and update callers to check for a null return value.
Test: manual-tests/drop-in-empty-doc.html
* manual-tests/drop-in-empty-doc.html: Added.
* manual-tests/resources/drop-in-empty-doc.xhtml: Added.
* page/DragController.cpp:
(WebCore::elementUnderMouse):
(WebCore::DragController::tryDocumentDrag):
(WebCore::DragController::concludeEditDrag):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73276
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 3 Dec 2010 19:11:49 +0000 (19:11 +0000)]
The chunked update drawing area is flipped twice when drawing
https://bugs.webkit.org/show_bug.cgi?id=50465
<rdar://problem/
8726836>
Reviewed by Dan Bernstein.
* UIProcess/mac/ChunkedUpdateDrawingAreaProxyMac.mm:
(WebKit::ChunkedUpdateDrawingAreaProxy::platformPaint):
(WebKit::ChunkedUpdateDrawingAreaProxy::drawUpdateChunkIntoBackingStore):
Flip the destination contexts, thus unflipping them. (Turns out two wrongs make a right here).
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73275
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Fri, 3 Dec 2010 18:35:37 +0000 (18:35 +0000)]
2010-12-02 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Chang.
Rebaseline server: move existing baselines
https://bugs.webkit.org/show_bug.cgi?id=50421
Implement moving of existing baselines: move all files that are about
to be overwriten by update baselines.
Also fix a typo in the UI JS.
* Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
* Scripts/webkitpy/tool/commands/rebaselineserver.py:
* Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73274
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Fri, 3 Dec 2010 18:15:39 +0000 (18:15 +0000)]
2010-12-03 Patrick Gansterer <paroga@webkit.org>
Reviewed by Andreas Kling.
Move Inspector generator logic into main CMakeLists.txt file
https://bugs.webkit.org/show_bug.cgi?id=50445
* CMakeLists.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73273
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit.git / log