dpranke@chromium.org [Wed, 12 Jan 2011 02:38:57 +0000 (02:38 +0000)]
2011-01-11 Dirk Pranke <dpranke@chromium.org>
Unreviewed, fix typo in expectations file.
* platform/chromium-gpu/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75582
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thakis@chromium.org [Wed, 12 Jan 2011 02:16:56 +0000 (02:16 +0000)]
2011-01-11 Nico Weber <thakis@chromium.org>
Unreviewed, test expectations.
Remove now-unnecessary xp-specific baseline.
https://bugs.webkit.org/show_bug.cgi?id=52105
* platform/chromium-win-xp/fast/gradients/radial-centered-expected.checksum: Removed.
* platform/chromium-win-xp/fast/gradients/radial-centered-expected.png: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75581
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Wed, 12 Jan 2011 01:57:36 +0000 (01:57 +0000)]
2011-01-11 Andy Estes <aestes@apple.com>
Reviewed by Darin Adler.
REGRESSION (r71562): servePendingRequests() no longer called when
resources are done loading.
https://bugs.webkit.org/show_bug.cgi?id=52264
<rdar://problem/
8767429>
In r71562, servePendingRequests() is no longer called in Loader's
didFinishLoading(), didFail() and didReceiveResponse() methods. Since
r71562 was intended only as a refactoring, these calls should be
restored. At least one WebKit-based Mac OS X application relies on this
for correct behavior.
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::loadDone): Call
resourceLoadScheduler()->servePendingRequests().
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75580
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Wed, 12 Jan 2011 01:36:29 +0000 (01:36 +0000)]
2011-01-11 Adrienne Walker <enne@google.com>
Unreviewed, test expectations update.
Revert expect change for Snow Leopard in r75570.
* platform/mac-snowleopard/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75579
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Wed, 12 Jan 2011 01:28:20 +0000 (01:28 +0000)]
2011-01-11 Mihai Parparita <mihaip@chromium.org>
Unreviewed; chromium test expectations update.
Remove failing expectations for tests that pass after r75569.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75578
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Wed, 12 Jan 2011 01:26:04 +0000 (01:26 +0000)]
2011-01-11 Patrick Gansterer <paroga@webkit.org>
Reviewed by Eric Seidel.
Add Document::setContent()
https://bugs.webkit.org/show_bug.cgi?id=52085
Add a method to Document to set the whole content at once.
This removes the hack of the insert method in the xml parser
and is a predecessor to feed the xml parser with raw data.
* dom/Document.cpp:
(WebCore::Document::setContent):
* dom/Document.h:
* dom/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::insert): Added ASSERT_NOT_REACHED().
* loader/cache/CachedFont.cpp:
(WebCore::CachedFont::ensureSVGFontData): Use setContent.
* xml/DOMParser.cpp:
(WebCore::DOMParser::parseFromString): Ditto.
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::responseXML): Ditto.
* xml/XSLTProcessor.cpp:
(WebCore::XSLTProcessor::createDocumentFromSource): Ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75577
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Wed, 12 Jan 2011 01:15:46 +0000 (01:15 +0000)]
2011-01-11 Dirk Pranke <dpranke@chromium.org>
Reviewed by Ojan Vafai.
The current modifier parsing code in test_expectations is
fragile and hard-coded, so it's not easy to understand the logic
or easily add new types of modifiers (like GPU vs. CPU testing
for graphics tests, or 32-bit vs. 64-bit differences).
This is the first of two patches that will add in more generic
support and then eliminate the GPU-specific test expectations
files for Chromium.
This patch adds two standalone objects for handling modifiers. The
rules for interpreting modifiers, precedence, and conflicts are
given in the docstring to the ModifierMatcher class, which
returns ModifierMatchResult objects.
This patch also adds routines to the Port interface and a
default set of values in the base object, in order to obtain the
values needed on a given test run. These values are then passed
to the expectation parser. This also allows us to clean up the
logic used to lint all of the different configurations in a
single test_expectations.txt file.
The next patch will merge in the separate GPU expectations file.
https://bugs.webkit.org/show_bug.cgi?id=51222
* Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
* Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
* Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
* Scripts/webkitpy/layout_tests/port/test.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75576
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Wed, 12 Jan 2011 00:56:54 +0000 (00:56 +0000)]
2011-01-11 Maciej Stachowiak <mjs@apple.com>
Reviewed by Adam Barth.
Make webkit-patch support subdirectories for SVN checkouts
https://bugs.webkit.org/show_bug.cgi?id=52261
* Scripts/webkitpy/common/checkout/scm.py:
* Scripts/webkitpy/style_references.py:
* Scripts/webkitpy/tool/main.py:
* Scripts/webkitpy/tool/steps/preparechangelog.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75575
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Wed, 12 Jan 2011 00:56:38 +0000 (00:56 +0000)]
2011-01-11 James Robinson <jamesr@chromium.org>
Update test to use layoutTestController.waitUntilDone()/notifyDone() since it relies on the scroll event which is now async.
* fast/repaint/resources/fixed-move-after-keyboard-scroll-iframe.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75574
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Wed, 12 Jan 2011 00:53:21 +0000 (00:53 +0000)]
Unreviewed build fix.
* platform/graphics/cairo/PathCairo.cpp:
(WebCore::Path::addArc): Switch to MathExtra's piFloat define,
rather than M_PI which is not always available.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75573
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Wed, 12 Jan 2011 00:52:40 +0000 (00:52 +0000)]
2011-01-11 Mihai Parparita <mihaip@chromium.org>
Unreviewed; chromium test expectations update.
Remove failing expectations for tests that pass after r75552.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75572
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Wed, 12 Jan 2011 00:43:09 +0000 (00:43 +0000)]
2011-01-11 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
fix difflink centering to be vertical, not horizontal
https://bugs.webkit.org/show_bug.cgi?id=52263
* PrettyPatch/PrettyPatch.rb:
* code-review.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75571
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Wed, 12 Jan 2011 00:39:20 +0000 (00:39 +0000)]
2011-01-11 Adrienne Walker <enne@google.com>
Reviewed by Kenneth Russell.
Sync WebGL texImage2D video test from Khronos and re-enable it.
https://bugs.webkit.org/show_bug.cgi?id=44459
* fast/canvas/webgl/resources/quadrants.mp4: Removed.
* fast/canvas/webgl/resources/quadrants.ogv: Removed.
* fast/canvas/webgl/resources/red-green.mp4: Added.
* fast/canvas/webgl/resources/red-green.theora.ogv: Added.
* fast/canvas/webgl/resources/red-green.webmvp8.webm: Added.
* fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-expected.txt:
* fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html:
* platform/chromium-gpu/test_expectations.txt:
* platform/chromium/test_expectations.txt:
* platform/mac-snowleopard/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75570
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Wed, 12 Jan 2011 00:36:46 +0000 (00:36 +0000)]
2011-01-11 Mihai Parparita <mihaip@chromium.org>
Unreviewed, new chromium-mac baselines.
Rebaseline after the scrollbar change (these tests still need
chromium-mac baselines since they have controls or images that render
slightly differently from the Mac port).
* platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.checksum:
* platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
* platform/chromium-mac/fast/block/margin-collapse/103-expected.checksum: Added.
* platform/chromium-mac/fast/block/margin-collapse/103-expected.png: Added.
* platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.checksum:
* platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.png:
* platform/chromium-mac/fast/events/pointer-events-2-expected.checksum:
* platform/chromium-mac/fast/events/pointer-events-2-expected.png:
* platform/chromium-mac/fast/images/gif-large-checkerboard-expected.checksum: Removed.
* platform/chromium-mac/fast/images/gif-large-checkerboard-expected.png: Removed.
* platform/chromium-mac/fast/replaced/width100percent-image-expected.checksum: Added.
* platform/chromium-mac/fast/replaced/width100percent-image-expected.png: Added.
* platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.checksum: Added.
* platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png: Added.
* platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.checksum: Added.
* platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png: Added.
* platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.checksum: Added.
* platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png: Added.
* platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.checksum: Added.
* platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png: Added.
* platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.checksum: Added.
* platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png: Added.
* platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.checksum: Added.
* platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png: Added.
* platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.checksum: Added.
* platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug101674-expected.checksum: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug101674-expected.png: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug29314-expected.checksum: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug29314-expected.png: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug5797-expected.checksum: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug5797-expected.png: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug625-expected.checksum: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug625-expected.png: Added.
* platform/chromium-mac/tables/mozilla/core/bloomberg-expected.checksum: Added.
* platform/chromium-mac/tables/mozilla/core/bloomberg-expected.png: Added.
* platform/chromium-mac/tables/mozilla/core/row_span-expected.checksum: Added.
* platform/chromium-mac/tables/mozilla/core/row_span-expected.png: Added.
* platform/chromium-mac/tables/mozilla/other/cell_widths-expected.checksum: Added.
* platform/chromium-mac/tables/mozilla/other/cell_widths-expected.png: Added.
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.checksum: Added.
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png: Added.
* platform/chromium-mac/tables/mozilla_expected_failures/other/test4-expected.checksum: Added.
* platform/chromium-mac/tables/mozilla_expected_failures/other/test4-expected.png: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75569
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 12 Jan 2011 00:33:37 +0000 (00:33 +0000)]
2011-01-11 Jeff Miller <jeffm@apple.com>
Reviewed by John Sullivan.
WebKit2: "Webpages not responding" dialog appears when <select> popup menu is showing
https://bugs.webkit.org/show_bug.cgi?id=52242
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showPopupMenu):
On Windows, stop the responsiveness timer before calling showPopupMenu().
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75568
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 12 Jan 2011 00:33:21 +0000 (00:33 +0000)]
2011-01-11 Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>
Reviewed by Adam Barth.
Use plug-in DB for extensions to MIME type convertion
Plugins extension to MIME type conversion was not used in the
frameLoader. This was causing some fallback to be use which as the side
effect of loosing all the <OBJECT> parameters or <EMBED> attributes.
This patch ensure that we try to convert the extension to MIME type
using the plugin database beofre using this fallback.
Attribute lost with Flash plugin without mime type set
https://bugs.webkit.org/show_bug.cgi?id=50657
* plugins/no-mime-with-valid-extension.html: Added.
* plugins/no-mime-with-valid-extension-expected.txt: Added.
2011-01-11 Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>
Reviewed by Adam Barth.
Use plug-in DB for extensions to MIME type convertion
Plugins extension to MIME type conversion was not used in the
frameLoader. This was causing some fallback to be use which as the side
effect of loosing all the <OBJECT> parameters or <EMBED> attributes.
This patch ensure that we try to convert the extension to MIME type
using the plugin database beofre using this fallback.
Attribute lost with Flash plugin without mime type set
https://bugs.webkit.org/show_bug.cgi?id=50657
Test: plugins/no-mime-with-valid-extension.html
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::defaultObjectContentType): Use PluginDatabase for MIME
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75567
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Wed, 12 Jan 2011 00:17:10 +0000 (00:17 +0000)]
2011-01-11 Maciej Stachowiak <mjs@apple.com>
Reviewed by Anders Carlsson.
UIProcess kills the WebProcess sometimes when detached frames exist
https://bugs.webkit.org/show_bug.cgi?id=52227
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didSaveFrameToPageCache): Don't consider the message invalid
if it came in for a detached frame.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75566
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Tue, 11 Jan 2011 23:56:50 +0000 (23:56 +0000)]
2011-01-11 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
remember diffstate for review tool
https://bugs.webkit.org/show_bug.cgi?id=52253
If you use the global sidebyside/unified links, store the diff type
in localstorage. Then, onload, use that diff type. That way, people
who prefer one diff type or the other can always get that by default.
* code-review.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75565
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jschuh@chromium.org [Tue, 11 Jan 2011 23:44:55 +0000 (23:44 +0000)]
2011-01-11 Justin Schuh <jschuh@chromium.org>
Unreviewed, test expectations update.
Flaky expectations for textOnPath.svg.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75564
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 11 Jan 2011 23:41:14 +0000 (23:41 +0000)]
Build fix.
* WebKit2.xcodeproj/project.pbxproj:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75563
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 11 Jan 2011 23:40:26 +0000 (23:40 +0000)]
2011-01-11 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add a Region class which represents a graphical region
https://bugs.webkit.org/show_bug.cgi?id=52255
* Platform/Region.cpp: Added.
(WebKit::Region::Region):
(WebKit::Region::rects):
(WebKit::Region::Shape::Shape):
(WebKit::Region::Shape::appendSpan):
(WebKit::Region::Shape::canCoalesce):
(WebKit::Region::Shape::appendSpans):
(WebKit::Region::Shape::appendSegment):
(WebKit::Region::Shape::spans_begin):
(WebKit::Region::Shape::spans_end):
(WebKit::Region::Shape::segments_begin):
(WebKit::Region::Shape::segments_end):
(WebKit::Region::Shape::dump):
(WebKit::Region::Shape::bounds):
(WebKit::Region::Shape::move):
(WebKit::Region::Shape::swap):
(WebKit::Region::Shape::shapeOperation):
(WebKit::Region::Shape::UnionOperation::trySimpleOperation):
(WebKit::Region::Shape::unionShapes):
(WebKit::Region::Shape::IntersectOperation::trySimpleOperation):
(WebKit::Region::Shape::intersectShapes):
(WebKit::Region::Shape::SubtractOperation::trySimpleOperation):
(WebKit::Region::Shape::subtractShapes):
(WebKit::Region::dump):
(WebKit::Region::intersect):
(WebKit::Region::unite):
(WebKit::Region::subtract):
(WebKit::Region::move):
* Platform/Region.h: Added.
(WebKit::Region::bounds):
(WebKit::Region::isEmpty):
(WebKit::Region::Span::Span):
(WebKit::Region::Shape::isEmpty):
* WebKit2.xcodeproj/project.pbxproj:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75562
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Tue, 11 Jan 2011 23:35:54 +0000 (23:35 +0000)]
2011-01-11 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
[chromium] copy test netscape plugin into TestNetscapePlugin
https://bugs.webkit.org/show_bug.cgi?id=52232
* WebKit.gyp: Make a copy of the TestNetscapePlugIn in
TestNetscapePlugIn and WebKitTestNetscapePlugIn
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75561
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simonjam@chromium.org [Tue, 11 Jan 2011 23:19:29 +0000 (23:19 +0000)]
2011-01-11 James Simonsen <simonjam@chromium.org>
Reviewed by Eric Seidel.
[Web Timing] Rename sslHandshakeStart to secureConnectionStart
https://bugs.webkit.org/show_bug.cgi?id=52239
* fast/dom/Window/window-properties-performance-expected.txt:
* fast/dom/script-tests/webtiming.js:
(checkTimingBeforeLoad):
(checkTimingWhileDeferred):
(checkWebTimingOnDOMContentLoaded):
(checkWebTimingWhileAsync):
(checkWebTimingOnLoad):
(checkWebTimingAfterLoad):
* fast/dom/webtiming-document-open-expected.txt:
* fast/dom/webtiming-expected.txt:
* fast/dom/webtiming-navigate-within-document-expected.txt:
* http/tests/misc/resources/webtiming-cross-origin-and-back2.html:
* http/tests/misc/resources/webtiming-cross-origin-redirect.html:
* http/tests/misc/resources/webtiming-no-origin.html:
* http/tests/misc/resources/webtiming-ssl.html:
* http/tests/misc/webtiming-origins-expected.txt:
* http/tests/misc/webtiming-ssl-expected.txt:
2011-01-11 James Simonsen <simonjam@chromium.org>
Reviewed by Eric Seidel.
[Web Timing] Rename sslHandshakeStart to secureConnectionStart
https://bugs.webkit.org/show_bug.cgi?id=52239
* page/PerformanceTiming.cpp:
(WebCore::PerformanceTiming::secureConnectionStart):
* page/PerformanceTiming.h:
* page/PerformanceTiming.idl:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75560
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Tue, 11 Jan 2011 23:16:23 +0000 (23:16 +0000)]
2011-01-11 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
allow sidebysideifying individual files in the code review tool
https://bugs.webkit.org/show_bug.cgi?id=52226
* code-review.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75559
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 11 Jan 2011 22:58:10 +0000 (22:58 +0000)]
2011-01-11 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Add DidSetSize message
https://bugs.webkit.org/show_bug.cgi?id=52254
* DerivedSources.make:
Add DrawingAReaProxy.messages.in.
* Platform/CoreIPC/MessageID.h:
Add DrawingAreaProxy message class.
* UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::didSetSize):
Add CoreIPC message handler function.
* UIProcess/DrawingAreaProxy.messages.in: Added.
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::didSetSize):
Add stub.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage):
Handle DrawingAreaProxy messages.
* WebKit2.xcodeproj/project.pbxproj:
Add new files.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::setSize):
Send a DidSetSize message for now.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75558
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 11 Jan 2011 22:53:39 +0000 (22:53 +0000)]
2011-01-11 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Introduce the notion of a "display-isolated" URL scheme for use by
Chrome-internal URLs
https://bugs.webkit.org/show_bug.cgi?id=50182
This patch actually makes the display-isolated schemes display
isolated. The behavior should be the same as the previous iteration of
this patch, but re-organized a bit because reading the access white
list is expensive.
* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::isAccessToURLWhiteListed):
(WebCore::SecurityOrigin::canDisplay):
* page/SecurityOrigin.h:
* platform/SchemeRegistry.cpp:
* platform/SchemeRegistry.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75557
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Tue, 11 Jan 2011 22:47:10 +0000 (22:47 +0000)]
2011-01-11 Mihai Parparita <mihaip@chromium.org>
Reviewed by Darin Fisher.
Scroll event should be fired asynchronously
https://bugs.webkit.org/show_bug.cgi?id=45631
Update existing tests that assumed that scroll events fired
synchronously.
* editing/input/page-up-down-scrolls-expected.txt:
* editing/input/page-up-down-scrolls.html:
* fast/events/fire-scroll-event-element-expected.txt: Copied from LayoutTests/fast/events/fire-scroll-event-expected.txt.
* fast/events/fire-scroll-event-element.html: Added. Does the same
tests as fire-scroll-event.html, but on an individual element instead
of the whole document.
* fast/events/fire-scroll-event-expected.txt:
* fast/events/fire-scroll-event.html: Now explicitly tests for
synchronous behavior when scrolling the document, and that we don't
fire the event more than once.
* fast/events/remove-child-onscroll.html:
* fast/events/scroll-during-zoom-change.html:
* fast/events/scroll-event-does-not-bubble.html:
* fast/events/scroll-event-phase-expected.txt: Added.
* fast/events/scroll-event-phase.html: Added. Checks that we can listen
for scroll events in both the capture and bubble phase.
* fast/layers/removed-by-scroll-handler.html:
* fast/overflow/onscroll-layer-self-destruct.html:
* fast/repaint/repaint-during-scroll.html:
2011-01-11 Mihai Parparita <mihaip@chromium.org>
Reviewed by Darin Fisher.
Scroll event should be fired asynchronously
https://bugs.webkit.org/show_bug.cgi?id=45631
Tests: fast/events/fire-scroll-event.html
fast/events/fire-scroll-event-element.html
fast/events/scroll-event-phase.html
Makes scroll events fire asynchronously to be in compliance with the
CSSOM View Module and consistent with Gecko, Opera and (to some degree)
IE.
Implemented via the EventQueue class added by r74062 (EventQueue now
has a convenience enqueueScrollEvent method).
* dom/EventQueue.cpp:
(WebCore::EventQueue::enqueueScrollEvent):
(WebCore::EventQueue::pendingEventTimerFired):
* dom/EventQueue.h:
* page/EventHandler.cpp:
(WebCore::EventHandler::sendScrollEvent):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollToOffset):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::valueChanged):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75555
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbr@google.com [Tue, 11 Jan 2011 22:16:25 +0000 (22:16 +0000)]
2011-01-11 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
[chromium] Move WebGraphicsContext3DDefaultImpl to Chromium repository
https://bugs.webkit.org/show_bug.cgi?id=52235
Deleted WebGraphicsContext3DDefaultImpl, which has been moved to
the Chromium repository under WebGraphicsContext3DInProcessImpl.
Removed WebGraphicsContext3D::createDefault(). Rolled forward
Chromium version to pick up needed changes.
Tested with build-webkit --chromium --debug and a run of the WebGL
layout tests in DRT.
* DEPS:
* WebKit.gyp:
* public/WebGraphicsContext3D.h:
* src/GraphicsContext3DChromium.cpp:
* src/WebGraphicsContext3D.cpp: Removed.
* src/WebGraphicsContext3DDefaultImpl.cpp: Removed.
* src/WebGraphicsContext3DDefaultImpl.h: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75553
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Tue, 11 Jan 2011 22:03:50 +0000 (22:03 +0000)]
2011-01-11 Mihai Parparita <mihaip@chromium.org>
Unreviewed; new and updated mac-leopard baselines.
Update stale or missing Leopard baselines (tests currently pass on Snow
Leopard).
* platform/chromium/test_expectations.txt:
* platform/mac-leopard/editing/deleting/delete-line-end-ws-001-expected.checksum:
* platform/mac-leopard/editing/deleting/delete-line-end-ws-001-expected.png:
* platform/mac-leopard/editing/deleting/delete-line-end-ws-002-expected.checksum:
* platform/mac-leopard/editing/deleting/delete-line-end-ws-002-expected.png:
* platform/mac-leopard/fast/block/basic/016-expected.checksum: Added.
* platform/mac-leopard/fast/block/basic/016-expected.png: Added.
* platform/mac-leopard/fast/block/basic/truncation-rtl-expected.checksum: Added.
* platform/mac-leopard/fast/block/basic/truncation-rtl-expected.png: Added.
* platform/mac-leopard/fast/blockflow/fieldsets-expected.checksum: Added.
* platform/mac-leopard/fast/blockflow/fieldsets-expected.png: Added.
* platform/mac-leopard/fast/borders/border-image-scale-transform-expected.checksum:
* platform/mac-leopard/fast/borders/border-image-scale-transform-expected.png:
* platform/mac-leopard/tables/mozilla_expected_failures/bugs/bug2479-5-expected.checksum:
* platform/mac-leopard/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75552
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Tue, 11 Jan 2011 22:03:13 +0000 (22:03 +0000)]
Fix spelling mistake. Sharable -> Shareable.
Reviewed by Anders Carlsson.
* Shared/API/c/WKImage.h:
* Shared/API/c/WKSharedAPICast.h:
(WebKit::toImageOptions):
* Shared/ImageOptions.h:
* Shared/WebImage.cpp:
(WebKit::WebImage::create):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75551
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 11 Jan 2011 21:53:29 +0000 (21:53 +0000)]
2011-01-11 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add SetSize message
https://bugs.webkit.org/show_bug.cgi?id=52247
* DerivedSources.make:
Add DrawingArea.messages.in
* Platform/CoreIPC/MessageID.h:
Add DrawingArea message class.
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::sizeDidChange):
Call sendSetSize.
(WebKit::DrawingAreaProxyImpl::sendSetSize):
Send a SetSize message.
* UIProcess/DrawingAreaProxyImpl.h:
Add setSize override.
* WebKit2.xcodeproj/project.pbxproj:
Add new files.
* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::setSize):
Add setSize member function.
* WebProcess/WebPage/DrawingArea.messages.in: Added.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
* WebProcess/WebPage/DrawingAreaImpl.h:
Add setSize.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didReceiveMessage):
Handle drawing area messages.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75550
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Tue, 11 Jan 2011 21:33:48 +0000 (21:33 +0000)]
2011-01-11 Patrick Gansterer <paroga@webkit.org>
Unreviewed WinCE build fix for r75523.
* platform/wince/DragDataWinCE.cpp: Added missing include.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75549
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Tue, 11 Jan 2011 21:28:13 +0000 (21:28 +0000)]
2011-01-11 Abhishek Arya <inferno@chromium.org>
Reviewed by Dimitri Glazkov.
RefPtr the FrameView to prevent scrollbar from getting deleted inside
its scroll event.
https://bugs.webkit.org/show_bug.cgi?id=52238
Test: scrollbars/scrollable-iframe-remove-crash.html
* page/DOMWindow.cpp:
(WebCore::DOMWindow::scrollTo):
2011-01-11 Abhishek Arya <inferno@chromium.org>
Reviewed by Dimitri Glazkov.
Tests that we do not crash when we remove scrollable iframe when executing
inside its scroll event.
https://bugs.webkit.org/show_bug.cgi?id=52238
* scrollbars/scrollable-iframe-remove-crash-expected.txt: Added.
* scrollbars/scrollable-iframe-remove-crash.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75548
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 11 Jan 2011 21:24:06 +0000 (21:24 +0000)]
Replace ASSERTs with FIXMEs.
Reviewed by Sam Weinig.
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::sizeDidChange):
(WebKit::DrawingAreaProxyImpl::setPageIsVisible):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75547
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 11 Jan 2011 21:20:35 +0000 (21:20 +0000)]
2011-01-11 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add DrawingAreaImpl skeleton class
https://bugs.webkit.org/show_bug.cgi?id=52246
* UIProcess/API/mac/WKView.mm:
(useNewDrawingArea):
New function which controls which drawing area to use, through an environment variable.
(-[WKView drawRect:]):
Bail if we're using the new drawing area (for now).
(-[WKView WebKit::]):
Create a DrawingAreaProxyImpl when asked to.
* WebKit2.xcodeproj/project.pbxproj:
Add new files.
* WebProcess/WebPage/DrawingArea.cpp:
(WebKit::DrawingArea::create):
Create a DrawingAreaImpl when asked to.
* WebProcess/WebPage/DrawingAreaImpl.cpp: Added.
* WebProcess/WebPage/DrawingAreaImpl.h: Added.
Add DrawingAreaImpl class.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75546
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Tue, 11 Jan 2011 21:17:41 +0000 (21:17 +0000)]
2011-01-11 Martin Robinson <mrobinson@igalia.com>
Remove some GTK+-specific baselines. GTK+ now enough feature parity with the Mac
port to make these platform-specific results unnecessary.
* platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
* platform/gtk/fast/dom/prototype-inheritance-expected.txt: Removed.
* platform/gtk/fast/js/global-constructors-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75545
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thakis@chromium.org [Tue, 11 Jan 2011 21:08:23 +0000 (21:08 +0000)]
2011-01-11 Nico Weber <thakis@chromium.org>
Unreviewed, test expectations.
Another new baselines due to updated skia
https://bugs.webkit.org/show_bug.cgi?id=52105
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.checksum:
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75544
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Tue, 11 Jan 2011 21:05:33 +0000 (21:05 +0000)]
2011-01-08 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by David Hyatt.
Make pseudo-style resolution less hard-coded when used to select a shadow node
https://bugs.webkit.org/show_bug.cgi?id=46595
New test that comprehensively travels the code paths affected by the change.
* fast/css/unknown-pseudo-element-matching-expected.txt: Added.
* fast/css/unknown-pseudo-element-matching.html: Added.
2011-01-08 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by David Hyatt.
Make pseudo-style resolution less hard-coded when used to select a shadow node
https://bugs.webkit.org/show_bug.cgi?id=46595
Essentially implements the plumbing for the XBL2 pseudo attribute:
http://dev.w3.org/2006/xbl2/#the-pseudo-attribute
Test: fast/css/unknown-pseudo-element-matching.html
* css/CSSGrammar.y: Changed to handle specifier_list structure with the
CSSParser::updateSpecifierWithElementName helper, added logic to
keep unknown pseudo-element selectors at the top of the selector chain,
so that we can easily check for them and grab them, and also because
they would either not match anything or act as a descendant selector
(descendant into a shadow DOM subtree that is), not a specifier.
* css/CSSParser.cpp:
(WebCore::CSSParser::updateSpecifiersWithElementName): Generalized/combined
the logic adding element name to selectors and added the special case
to handle unknown pseudo-element selectors.
* css/CSSParser.h: Added def.
* css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId): Removed any mention of PseudoSliderThumb/SLIDER_THUMB.
(WebCore::nameToPseudoTypeMap): Ditto.
(WebCore::CSSSelector::extractPseudoType): Ditto.
* css/CSSSelector.h: Added a new ShadowDescendant relation type,
removed PseudoSliderThumb def.
(WebCore::CSSSelector::isUnknownPseudoElement): Added a helper method.
* css/CSSSelectorList.cpp:
(WebCore::SelectorHasUnknownPseudoElementFunctor::operator()): Added a functor
to check for an unknown pseudo-element in the list.
(WebCore::CSSSelectorList::hasUnknownPseudoElements): Added.
* css/CSSSelectorList.h: Added a def.
* css/CSSStyleSelector.cpp:
(WebCore::CSSRuleSet::getPseudoRules): Added accessor to pseudo-element hash.
(WebCore::CSSStyleSelector::matchRules): Added matching pseudo elements.
(WebCore::CSSStyleSelector::SelectorChecker::checkSelector): Added handling
of ShadowDescendant relation.
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Enabled handling
of unknown pseudo-element selectors.
(WebCore::CSSRuleSet::addRule): Added populating unknown pseudo-element hash.
* css/html.css:
(input[type="range"]::-webkit-slider-thumb): Added previously-hard-coded
display:block.
* dom/Element.h:
(WebCore::Element::shadowPseudoId): Added new virtual method to allow
elements to provide the value of pseudo-element selector they would match.
* dom/Node.cpp:
(WebCore::Node::querySelector): Added checking for unknown pseudo-element selectors,
so that we can throw a SYNTAX_ERR if found.
(WebCore::Node::querySelectorAll): Ditto.
* html/shadow/SliderThumbElement.h:
(WebCore::SliderThumbElement::shadowPseudoId): Added to return "-webkit-slider-thumb";
* rendering/RenderSlider.cpp:
(WebCore::RenderSlider::createThumbStyle): Changed to use the new styleForElement logic.
* rendering/style/RenderStyleConstants.h: Removed SLIDER_THUMB.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75543
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dino@apple.com [Tue, 11 Jan 2011 21:03:44 +0000 (21:03 +0000)]
2011-01-11 Dean Jackson <dino@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=52233
WebKitCSSMatrix constructor should accept 'none'
as a valid string parameter.
* css/WebKitCSSMatrix.cpp:
(WebCore::WebKitCSSMatrix::setMatrixValue):
2011-01-11 Dean Jackson <dino@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=52233
Update WebKitCSSMatrix test to cover a constructor
that accepts 'none' as input.
* transforms/cssmatrix-2d-interface-expected.txt:
* transforms/cssmatrix-2d-interface.xhtml:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75542
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 11 Jan 2011 20:56:58 +0000 (20:56 +0000)]
2011-01-11 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add Mac-only DrawingAreaProxyImpl class skeleton
https://bugs.webkit.org/show_bug.cgi?id=52243
This is the proxy side of a new drawing area implementation. This is Mac only for now
while the design is being fleshed out.
* Shared/DrawingAreaInfo.h:
* UIProcess/API/mac/WKView.mm:
(-[WKView _switchToDrawingAreaTypeIfNecessary:DrawingAreaInfo::]):
* UIProcess/DrawingAreaProxyImpl.cpp: Added.
(WebKit::DrawingAreaProxyImpl::create):
(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl):
(WebKit::DrawingAreaProxyImpl::~DrawingAreaProxyImpl):
(WebKit::DrawingAreaProxyImpl::didReceiveMessage):
(WebKit::DrawingAreaProxyImpl::didReceiveSyncMessage):
(WebKit::DrawingAreaProxyImpl::paint):
(WebKit::DrawingAreaProxyImpl::sizeDidChange):
(WebKit::DrawingAreaProxyImpl::setPageIsVisible):
(WebKit::DrawingAreaProxyImpl::attachCompositingContext):
(WebKit::DrawingAreaProxyImpl::detachCompositingContext):
* UIProcess/DrawingAreaProxyImpl.h: Added.
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebPage/DrawingArea.cpp:
(WebKit::DrawingArea::create):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75540
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Tue, 11 Jan 2011 20:56:13 +0000 (20:56 +0000)]
2011-01-11 Ojan Vafai <ojan@chromium.org>
Reviewed by Mihai Parparita.
fix exception when adding a comment to a side-by-side diff
https://bugs.webkit.org/show_bug.cgi?id=52240
prev() and next() won't get the previous and next lines in
side-by-side mode. Instead do a query to find them.
* code-review.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75539
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Tue, 11 Jan 2011 20:54:19 +0000 (20:54 +0000)]
2011-01-11 Ojan Vafai <ojan@chromium.org>
Reviewed by Mihai Parparita.
maintain word diffs when converting to side-by-side and back
https://bugs.webkit.org/show_bug.cgi?id=52244
Using textContent would lose the spans use to make the word-diff highlighting.
Just move the span element itself.
* code-review.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75538
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Tue, 11 Jan 2011 20:47:51 +0000 (20:47 +0000)]
2011-01-11 James Robinson <jamesr@chromium.org>
Reviewed by Dimitri Glazkov.
Set all RenderBlocks as replaced when an inline display type is specified
https://bugs.webkit.org/show_bug.cgi?id=50858
When a RenderBlock is created for an element with a specified display:inline style,
it should always be treated as inline-block. This situations often comes up for form
controls. Previously, RenderBlock::styleWillChange set the replaced flag for display
values of inline-block, inline-table, and inline-table and a number of subclasses of
RenderBlock set the replaced flag in styleDidChange for a display:inline. However
sometimes new subclasses would miss this step leading to bugs (such as with RenderDetails).
This patch sets the replaced flag for all inline display types in RenderBlock::styleWillChange.
Code cleanup only, no change in behavior so no new tests.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::styleWillChange):
* rendering/RenderButton.cpp:
(WebCore::RenderButton::styleDidChange):
* rendering/RenderFieldset.cpp:
* rendering/RenderFieldset.h:
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::styleDidChange):
* rendering/RenderListBox.cpp:
* rendering/RenderListBox.h:
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::styleDidChange):
* rendering/RenderSlider.cpp:
(WebCore::RenderSlider::styleDidChange):
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::styleDidChange):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75537
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Tue, 11 Jan 2011 20:44:52 +0000 (20:44 +0000)]
2011-01-11 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Eric Seidel.
REGRESSION(r71934) Can't type in search edit field on skin-one.com
https://bugs.webkit.org/show_bug.cgi?id=52195
Restored original (pre-71934) check in the test to ensure that
selectstart does not propagate outside of the shadow DOM.
Consolidated shadow-boundary-crossing-2.html into shadow-boundary-crossing.html.
* fast/events/shadow-boundary-crossing-2-expected.txt: Renamed to
shadow-boundary-crossing-expected.txt.
* fast/events/shadow-boundary-crossing-2.html: Renamed to
shadow-boundary-crossing.html.
* fast/events/shadow-boundary-crossing-expected.txt: Removed.
* fast/events/shadow-boundary-crossing.html: Removed after folding the
test into the new shadow-boundary-crossing.html.
2011-01-11 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Eric Seidel.
REGRESSION(r71934) Can't type in search edit field on skin-one.com
https://bugs.webkit.org/show_bug.cgi?id=52195
Restored the original behavior, where the selectstart event is not
dispatched when selection changes inside of the shadow DOM.
* dom/Node.cpp:
(WebCore::determineDispatchBehavior): Moved EventDispatchBehavior-determining
logic into a helper function, also added a check to keep selectstart
events inside of the shadow DOM.
(WebCore::Node::dispatchGenericEvent): Changed to use the helper function.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75536
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 11 Jan 2011 20:39:33 +0000 (20:39 +0000)]
2011-01-11 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
Reviewed by Eric Seidel.
[Qt] Provide plugin coordinates to windowless plugins on Symbian.
https://bugs.webkit.org/show_bug.cgi?id=52213
* plugins/symbian/PluginViewSymbian.cpp:
(WebCore::PluginView::setNPWindowIfNeeded):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75535
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zmo@google.com [Tue, 11 Jan 2011 20:34:09 +0000 (20:34 +0000)]
2011-01-11 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectation update.
* platform/mac-snowleopard/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75534
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
laszlo.1.gombos@nokia.com [Tue, 11 Jan 2011 20:33:02 +0000 (20:33 +0000)]
2011-01-11 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Csaba Osztrogonác.
[Qt] Add QT_NO_CONCURRENT to the qt_minimal configuration
https://bugs.webkit.org/show_bug.cgi?id=52223
Add QT_NO_CONCURRENT to the qt_minimal configuration to make sure
that QtWebKit builds with QT_NO_CONCURRENT defined.
* WebKit.pri:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75533
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 11 Jan 2011 20:28:33 +0000 (20:28 +0000)]
Fix Windows build.
* WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp:
(WebKit::WebPopupMenu::setUpPlatformData):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75532
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
msaboff@apple.com [Tue, 11 Jan 2011 20:24:55 +0000 (20:24 +0000)]
2011-01-11 Michael Saboff <msaboff@apple.com>
Reviewed by Geoffrey Garen.
Missing call to popTempSortVector() for exception case in JSArray::sort.
https://bugs.webkit.org/show_bug.cgi?id=50718
Fix to patch of 50718 that added pushTempSortVector() and
popTempSortVector() to JSArray::sort() to mark elements during sort.
Need to add popTempSortVector() for the return case if toString()
had an exception.
* runtime/JSArray.cpp:
(JSC::JSArray::sort): Added popTempSortVector()
2011-01-11 Michael Saboff <msaboff@apple.com>
Reviewed by Geoffrey Garen.
Missing call to popTempSortVector() for exception case in JSArray::sort.
https://bugs.webkit.org/show_bug.cgi?id=50718
New test to validate balanced calls to pushTempSortVector() and
popTempSortVector().
* fast/js/array-sort-exception-expected.txt: Added.
* fast/js/array-sort-exception.html: Added.
* fast/js/script-tests/array-sort-exception.js: Added.
(do_gc):
(Item):
(toString_throw):
(test):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75531
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zmo@google.com [Tue, 11 Jan 2011 20:22:14 +0000 (20:22 +0000)]
2011-01-11 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
* platform/chromium-gpu/test_expectations.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75530
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Tue, 11 Jan 2011 20:21:23 +0000 (20:21 +0000)]
2011-01-11 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
fix layout error with comments in code review tool
https://bugs.webkit.org/show_bug.cgi?id=52230
* PrettyPatch/PrettyPatch.rb:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75529
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 11 Jan 2011 20:20:22 +0000 (20:20 +0000)]
2011-01-11 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Rename ShareableBitmap::createSharable to createShareable
https://bugs.webkit.org/show_bug.cgi?id=52234
* Shared/ShareableBitmap.cpp:
(WebKit::ShareableBitmap::createShareable):
* Shared/ShareableBitmap.h:
* Shared/WebImage.cpp:
(WebKit::WebImage::create):
* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::geometryDidChange):
* WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp:
(WebKit::WebPopupMenu::setUpPlatformData):
* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::updateFindIndicator):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75528
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 11 Jan 2011 20:13:20 +0000 (20:13 +0000)]
2011-01-11 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Rename BackingStore to ShareableBitmap
https://bugs.webkit.org/show_bug.cgi?id=52228
* GNUmakefile.am:
* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::geometryDidChange):
* PluginProcess/PluginControllerProxy.h:
* Shared/API/c/cg/WKImageCG.cpp:
(WKImageCreateCGImage):
* Shared/BackingStore.cpp: Removed.
* Shared/BackingStore.h: Removed.
* Shared/PlatformPopupMenuData.cpp:
(WebKit::PlatformPopupMenuData::decode):
* Shared/PlatformPopupMenuData.h:
* Shared/ShareableBitmap.cpp: Copied from WebKit2/Shared/BackingStore.cpp.
(WebKit::ShareableBitmap::create):
(WebKit::ShareableBitmap::createSharable):
(WebKit::ShareableBitmap::createHandle):
(WebKit::ShareableBitmap::ShareableBitmap):
(WebKit::ShareableBitmap::~ShareableBitmap):
(WebKit::ShareableBitmap::resize):
(WebKit::ShareableBitmap::data):
* Shared/ShareableBitmap.h: Copied from WebKit2/Shared/BackingStore.h.
* Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
* Shared/WebImage.cpp:
(WebKit::WebImage::create):
(WebKit::WebImage::WebImage):
(WebKit::WebImage::~WebImage):
(WebKit::WebImage::size):
* Shared/WebImage.h:
(WebKit::WebImage::bitmap):
* Shared/cairo/BackingStoreCairo.cpp:
(WebKit::ShareableBitmap::createGraphicsContext):
(WebKit::ShareableBitmap::paint):
* Shared/cg/BackingStoreCG.cpp: Removed.
* Shared/cg/ShareableBitmapCG.cpp: Copied from WebKit2/Shared/cg/BackingStoreCG.cpp.
(WebKit::ShareableBitmap::createGraphicsContext):
(WebKit::ShareableBitmap::paint):
* Shared/gtk/BackingStoreGtk.cpp: Removed.
* Shared/gtk/ShareableBitmapGtk.cpp: Copied from WebKit2/Shared/gtk/BackingStoreGtk.cpp.
(WebKit::ShareableBitmap::createGraphicsContext):
(WebKit::ShareableBitmap::paint):
* Shared/qt/BackingStoreQt.cpp: Removed.
* Shared/qt/ShareableBitmapQt.cpp: Copied from WebKit2/Shared/qt/BackingStoreQt.cpp.
(WebKit::ShareableBitmap::createGraphicsContext):
(WebKit::ShareableBitmap::paint):
* UIProcess/FindIndicator.cpp:
(WebKit::FindIndicator::create):
(WebKit::FindIndicator::FindIndicator):
* UIProcess/FindIndicator.h:
(WebKit::FindIndicator::contentImage):
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::geometryDidChange):
* WebProcess/Plugins/PluginProxy.h:
* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::updateFindIndicator):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::snapshotInViewCoordinates):
(WebKit::WebPage::snapshotInDocumentCoordinates):
* win/WebKit2.vcproj:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75527
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thakis@chromium.org [Tue, 11 Jan 2011 20:12:24 +0000 (20:12 +0000)]
2011-01-11 Nico Weber <thakis@chromium.org>
Unreviewed, test expectations.
Another baseline for the recent skia roll.
https://bugs.webkit.org/show_bug.cgi?id=52105
* platform/chromium-linux/svg/custom/focus-ring-expected.checksum:
* platform/chromium-linux/svg/custom/focus-ring-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75526
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan@apple.com [Tue, 11 Jan 2011 20:05:32 +0000 (20:05 +0000)]
[WKView setFrameSize:] derefs _page->drawingArea() without null check
<https://bugs.webkit.org/show_bug.cgi?id=52231>
Reviewed by Anders Carlsson.
* UIProcess/API/mac/WKView.mm:
(-[WKView setFrameSize:]):
Null check drawingArea(). This is OK because if it doesn't exist then it will be
created later with the correct initial size.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75525
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zmo@google.com [Tue, 11 Jan 2011 19:49:28 +0000 (19:49 +0000)]
2011-01-10 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Need to consider UNPACK_ALIGNMENT in GraphicsContext3D::texImage2DResourceSafe
https://bugs.webkit.org/show_bug.cgi?id=52068
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::copyTexImage2D): Use computeImageSizeInBytes.
(WebCore::WebGLRenderingContext::copyTexSubImage2D): Ditto.
(WebCore::WebGLRenderingContext::readPixels): Ditto, and fix a bug on generating the wrong error.
(WebCore::WebGLRenderingContext::texImage2DBase): Ditto.
(WebCore::WebGLRenderingContext::validateTexFuncData): Use computeImageSizeInBytes.
* platform/graphics/GraphicsContext3D.cpp:
(WebCore::GraphicsContext3D::texImage2DResourceSafe): Add a new parameter alignment.
(WebCore::GraphicsContext3D::computeFormatAndTypeParameters): Add more supported format/type.
(WebCore::GraphicsContext3D::computeImageSizeInBytes): Added.
* platform/graphics/GraphicsContext3D.h:
2011-01-10 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Need to consider UNPACK_ALIGNMENT in GraphicsContext3D::texImage2DResourceSafe
https://bugs.webkit.org/show_bug.cgi?id=52068
* fast/canvas/webgl/read-pixels-test-expected.txt:
* fast/canvas/webgl/read-pixels-test.html: Sync with khronos.
* fast/canvas/webgl/resources/webgl-test.js: Add finishTest().
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75524
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enrica@apple.com [Tue, 11 Jan 2011 19:47:02 +0000 (19:47 +0000)]
Source/WebCore: Paste and drag and drop use different code paths to interact with the pasteboard.
https://bugs.webkit.org/show_bug.cgi?id=52093
The change consists in a refactoring of the code to have only one class that
deals with the pasteboard on Mac.
Reviewed by Alexey Proskuryakov.
No new tests. A test is already available for this
(editing/pasteboard/drag-image-to-contenteditable-in-iframe.html) but had incorrect results.
* WebCore.exp.in:
* loader/EmptyClients.h: Added two Mac only methods to call into WebKit to use functionality
that is in NSURLExtras.
(WebCore::EmptyEditorClient::canonicalizeURL):
(WebCore::EmptyEditorClient::canonicalizeURLString):
* page/DragController.cpp:
The following methods have been changed to pass a pointer to the Frame object
to the DragData class.
(WebCore::documentFragmentFromDragData):
(WebCore::DragController::performDrag):
(WebCore::DragController::dispatchTextInputEventFor):
(WebCore::DragController::concludeEditDrag):
* page/EditorClient.h: Added two Mac only methods to call into WebKit to use functionality
that is in NSURLExtras.
The following files have been modified to pass the Frame object to the DragData method calls.
* page/chromium/DragControllerChromium.cpp:
(WebCore::DragController::dragOperation):
* page/gtk/DragControllerGtk.cpp:
(WebCore::DragController::dragOperation):
* page/mac/DragControllerMac.mm:
(WebCore::DragController::dragOperation):
* page/qt/DragControllerQt.cpp:
(WebCore::DragController::dragOperation):
* page/win/DragControllerWin.cpp:
(WebCore::DragController::dragOperation):
* platform/DragData.h: Removed Mac specific constructor and reference to PasteboardHelper class.
* platform/Pasteboard.h: Added public constructor to create a Pasteboard object from an NSPasteboard.
The following files were all modified to match the new parameters of the methods listed.
* platform/android/DragDataAndroid.cpp:
(WebCore::DragData::asPlainText):
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):
* platform/chromium/DragDataChromium.cpp:
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::asPlainText):
(WebCore::DragData::containsCompatibleContent):
(WebCore::DragData::asFragment):
* platform/gtk/DragDataGtk.cpp:
(WebCore::DragData::asPlainText):
(WebCore::DragData::containsCompatibleContent):
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):
* platform/haiku/DragDataHaiku.cpp:
(WebCore::DragData::asPlainText):
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):
* platform/mac/DragDataMac.mm:
(WebCore::DragData::DragData):
(WebCore::DragData::asPlainText):
(WebCore::insertablePasteboardTypes):
(WebCore::DragData::containsCompatibleContent):
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::getBestURL):
(WebCore::Pasteboard::asURL):
* platform/qt/DragDataQt.cpp:
(WebCore::DragData::asPlainText):
(WebCore::DragData::containsCompatibleContent):
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):
* platform/win/DragDataWin.cpp:
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::asPlainText):
(WebCore::DragData::containsCompatibleContent):
(WebCore::DragData::asFragment):
* platform/wince/DragDataWinCE.cpp:
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::asPlainText):
(WebCore::DragData::asFragment):
* platform/wx/DragDataWx.cpp:
(WebCore::DragData::asPlainText):
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):
WebKit: Paste and drag and drop use different code paths to interact with the pasteboard.
https://bugs.webkit.org/show_bug.cgi?id=52093
The change consists in a refactoring of the code to have only one class that
deals with the pasteboard on Mac.
Reviewed by Alexey Proskuryakov.
* WebKit.xcodeproj/project.pbxproj: Removed WebPasteboardHelper.mm and WebPasteboardHelper.h.
WebKit/mac: Paste and drag and drop use different code paths to interact with the pasteboard.
https://bugs.webkit.org/show_bug.cgi?id=52093
The change consists in a refactoring of the code to have only one class that
deals with the pasteboard on Mac.
Reviewed by Alexey Proskuryakov.
* WebCoreSupport/WebEditorClient.h:
* WebCoreSupport/WebEditorClient.mm: Added two methods to provide to WebCore functionality
exposed by NSURLExtras.
(WebEditorClient::canonicalizeURL):
(WebEditorClient::canonicalizeURLString):
* WebCoreSupport/WebPasteboardHelper.h: Removed.
* WebCoreSupport/WebPasteboardHelper.mm: Removed.
* WebView/WebHTMLView.mm: Removed comment.
* WebView/WebView.mm: The following methods have been changed to use the new DragData
constructor that doesn't use the WebPasteboardHelper reference.
(-[WebView draggingEntered:]):
(-[WebView draggingUpdated:]):
(-[WebView draggingExited:]):
(-[WebView performDragOperation:]):
WebKit2: Paste and drag and drop use different code paths to interact with the pasteboard.
https://bugs.webkit.org/show_bug.cgi?id=52093
The change consists in a refactoring of the code to have only one class that
deals with the pasteboard on Mac.
Reviewed by Alexey Proskuryakov.
* WebProcess/WebCoreSupport/WebEditorClient.h:
* WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm: Added two methods to provide to WebCore functionality
exposed by NSURLExtras.
(WebKit::WebEditorClient::canonicalizeURL):
(WebKit::WebEditorClient::canonicalizeURLString):
LayoutTests: Paste and drag and drop use different code paths to interact with the pasteboard.
https://bugs.webkit.org/show_bug.cgi?id=52093
Reviewed by Alexey Proskuryakov.
New test results added to match the correct behavior.
* platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.checksum:
* platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png:
* platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75523
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Tue, 11 Jan 2011 19:40:16 +0000 (19:40 +0000)]
2011-01-11 Mihai Parparita <mihaip@chromium.org>
Unreviewed; chromium test expectations update.
Remove failing expectations for tests that pass after r75515.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75522
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Tue, 11 Jan 2011 19:40:00 +0000 (19:40 +0000)]
Fix crash on launch on Windows.
Reviewed by Anders Carlsson and Sam Weinig.
* UIProcess/win/WebView.cpp:
(WebKit::WebView::onSizeEvent):
The drawing area is no longer initialized before the WebView is created and the first
onSize is receieved.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75521
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 11 Jan 2011 19:28:35 +0000 (19:28 +0000)]
2011-01-11 Eric Seidel <eric@webkit.org>
Unreviewed.
commit-queue should know how to upload archived results (for test flakes or general failures)
https://bugs.webkit.org/show_bug.cgi?id=52048
I changed the API for archive_last_layout_test_results w/o updating the implementation. Oops.
This fixes an exception seen on the commit-queue when attempting to report flaky tests.
* Scripts/webkitpy/common/system/workspace.py:
* Scripts/webkitpy/common/system/workspace_unittest.py:
* Scripts/webkitpy/tool/commands/queues.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75520
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Tue, 11 Jan 2011 19:24:36 +0000 (19:24 +0000)]
2011-01-11 Abhishek Arya <inferno@chromium.org>
Reviewed by Dimitri Glazkov.
RefPtr text node in setOuterText since calling appendData
on a text node can fire away dom event listener which might
remove the text node from underneath.
https://bugs.webkit.org/show_bug.cgi?id=52163
Test: fast/dom/text-node-append-data-remove-crash.html
* html/HTMLElement.cpp:
(WebCore::HTMLElement::setOuterText):
2011-01-11 Abhishek Arya <inferno@chromium.org>
Reviewed by Dimitri Glazkov.
Tests that calling append data on a text node which removes its
sibling text node does not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=52163
* fast/dom/text-node-append-data-remove-crash-expected.txt: Added.
* fast/dom/text-node-append-data-remove-crash.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75519
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
senorblanco@chromium.org [Tue, 11 Jan 2011 18:50:38 +0000 (18:50 +0000)]
2011-01-11 Stephen White <senorblanco@chromium.org>
Unreviewed; chromium-gpu test expectations update.
Remove now-passing tests from text_expectations.txt.
* platform/chromium-gpu/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75518
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Tue, 11 Jan 2011 18:49:56 +0000 (18:49 +0000)]
2011-01-11 Xan Lopez <xlopez@igalia.com>
Reviewed by Darin Adler.
Microoptimization in ~JSString
https://bugs.webkit.org/show_bug.cgi?id=52222
The case where m_fibers is 0 seems to be the most common one
(almost 1/2 of the time, followed at some distance by m_fibers = 1
in 1/4 of the cases in a typical SunSpider execution). We can save
one comparison in this common case by doing a bit of refactoring
in the JSString destructor; overall a 0.3% progression, but only
the string tests show improvement.
* runtime/JSString.h:
(JSC::RopeBuilder::~JSString):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75517
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 11 Jan 2011 18:49:13 +0000 (18:49 +0000)]
2011-01-11 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Automatically reinitialize the web page on relaunch
https://bugs.webkit.org/show_bug.cgi?id=52224
<rdar://problem/
8765695>
* UIProcess/API/mac/WKView.mm:
(-[WKView _didRelaunchProcess]):
Remove call to reinitializeWebPage.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::relaunch):
Call initializeWebPage().
(WebKit::WebPageProxy::initializeWebPage):
Assert that the web page is valid here.
* UIProcess/WebPageProxy.h:
Remove reinitializeWebPage.
* UIProcess/win/WebView.cpp:
(WebKit::WebView::didRelaunchProcess):
Remove call to reinitializeWebPage.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75516
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Tue, 11 Jan 2011 18:46:52 +0000 (18:46 +0000)]
2011-01-11 Mihai Parparita <mihaip@chromium.org>
Unreviewed; new and updated mac-leopard baselines.
Update stale or missing Leopard baselines (tests currently pass on Snow
Leopard).
* platform/chromium/test_expectations.txt:
* platform/mac-leopard/fast/block/basic/fieldset-stretch-to-legend-expected.checksum:
* platform/mac-leopard/fast/block/basic/fieldset-stretch-to-legend-expected.png:
* platform/mac-leopard/fast/dom/focus-contenteditable-expected.checksum: Added.
* platform/mac-leopard/fast/dom/focus-contenteditable-expected.png: Added.
* platform/mac-leopard/fast/forms/fieldset-align-expected.checksum: Added.
* platform/mac-leopard/fast/forms/fieldset-align-expected.png: Added.
* platform/mac-leopard/fast/multicol/columns-shorthand-parsing-expected.checksum: Added.
* platform/mac-leopard/fast/multicol/columns-shorthand-parsing-expected.png: Added.
* platform/mac-leopard/fast/text/capitalize-boundaries-expected.checksum: Added.
* platform/mac-leopard/fast/text/capitalize-boundaries-expected.png: Added.
* platform/mac-leopard/fast/text/softHyphen-expected.checksum: Added.
* platform/mac-leopard/fast/text/softHyphen-expected.png: Added.
* platform/mac-leopard/tables/mozilla/other/wa_table_tr_align-expected.checksum:
* platform/mac-leopard/tables/mozilla/other/wa_table_tr_align-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75515
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Tue, 11 Jan 2011 18:39:23 +0000 (18:39 +0000)]
2011-01-10 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
convert back to unified from sidebyside diff
https://bugs.webkit.org/show_bug.cgi?id=52180
Remove url fragment stuff. Having it be per-filediff is too complicated.
* PrettyPatch/PrettyPatch.rb:
* code-review.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75514
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Tue, 11 Jan 2011 18:37:02 +0000 (18:37 +0000)]
2011-01-11 Martin Robinson <mrobinson@igalia.com>
Unskipping fast/multicol/span/double-merge-anonymous-block-crash.html. We
have been unsuccessful reproducing the crash locally or on the bots.
* platform/gtk/Skipped: Unskipping test.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75513
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 11 Jan 2011 18:36:22 +0000 (18:36 +0000)]
2011-01-10 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Pass the view size to the DrawingAreaProxy constructor
https://bugs.webkit.org/show_bug.cgi?id=52189
* UIProcess/DrawingAreaProxy.cpp:
(WebKit::DrawingAreaProxy::DrawingAreaProxy):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::viewSize):
* UIProcess/WebPageProxy.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75512
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Tue, 11 Jan 2011 18:29:42 +0000 (18:29 +0000)]
2011-01-11 Mihai Parparita <mihaip@chromium.org>
Unreviewed. Update .gitignore with new Chromium dependency.
ui/ was added with http://crrev.com/70743, we picked that up with a
Chromium roll in r75311.
Also alphabetizes the dependency list.
* .gitignore:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75511
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
msaboff@apple.com [Tue, 11 Jan 2011 18:27:15 +0000 (18:27 +0000)]
2011-01-10 Michael Saboff <msaboff@apple.com>
Reviewed by Geoffrey Garen.
ASSERTION Failure in JSC::binaryChop
https://bugs.webkit.org/show_bug.cgi?id=25614
Changed JITStubs::cti_register_file_check() to use the current stack's
return PC to find the bytecode for handling the exception in the prior
frame. Also added the appropriate arrity check routine call to the
JIT to bytecode vector (m_callReturnIndexVector) in the CodeBlock.
* jit/JIT.cpp:
(JSC::JIT::privateCompile): Changed the arrity check call location
so that it gets added to the m_calls list so that it's included in
CodeBlock::m_callReturnIndexVector.
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION): Use the current call frame's return PC.
2011-01-11 Michael Saboff <msaboff@apple.com>
Reviewed by Geoffrey Garen.
ASSERTION Failure in JSC::binaryChop
https://bugs.webkit.org/show_bug.cgi?id=25614
Added new test to check for proper handling of stack overflow
exceptions and arrity exceptions while close to the top of the stack.
* fast/js/script-tests/stack-overflow-arrity-catch.js: Added.
(fWithTwoArgs):
(test):
* fast/js/script-tests/stack-overflow-catch.js: Added.
(test):
* fast/js/stack-overflow-arrity-catch-expected.txt: Added.
* fast/js/stack-overflow-arrity-catch.html: Added.
* fast/js/stack-overflow-catch-expected.txt: Added.
* fast/js/stack-overflow-catch.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75510
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
senorblanco@chromium.org [Tue, 11 Jan 2011 18:05:06 +0000 (18:05 +0000)]
2011-01-11 Stephen White <senorblanco@chromium.org>
Unreviewed; new chromium GPU test baselines.
These tests required rebaselining after the skia roll in
http://src.chromium.org/viewvc/chrome?view=rev&revision=70835.
* platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.checksum:
* platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png:
* platform/chromium-gpu-linux/fast/canvas/fillrect_gradient-expected.checksum:
* platform/chromium-gpu-linux/fast/canvas/fillrect_gradient-expected.png:
* platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.checksum:
* platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.png:
* platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.txt:
* platform/chromium-gpu-win/fast/canvas/fillrect_gradient-expected.checksum:
* platform/chromium-gpu-win/fast/canvas/fillrect_gradient-expected.png:
* platform/chromium-gpu-win/fast/canvas/fillrect_gradient-expected.txt:
* platform/chromium-gpu-win/fast/canvas/gradient-add-second-start-end-stop-expected.checksum:
* platform/chromium-gpu-win/fast/canvas/gradient-add-second-start-end-stop-expected.png:
* platform/chromium-gpu-win/fast/canvas/gradient-add-second-start-end-stop-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75509
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Tue, 11 Jan 2011 17:56:06 +0000 (17:56 +0000)]
Tools: Roll r75474 back in.
WebKit2: Roll r75460 back in with build fix.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75508
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Tue, 11 Jan 2011 17:32:15 +0000 (17:32 +0000)]
2011-01-11 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add support for <meter> element
https://bugs.webkit.org/show_bug.cgi?id=48713
* platform/gtk/Skipped:
* platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum: Added.
* platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: Added.
* platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt: Added.
* platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.checksum: Added.
* platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Added.
* platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt: Added.
* platform/gtk/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum: Added.
* platform/gtk/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Added.
* platform/gtk/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt: Added.
* platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.checksum: Added.
* platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.png: Added.
* platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.txt: Added.
* platform/gtk/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum: Added.
* platform/gtk/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Added.
* platform/gtk/fast/dom/HTMLMeterElement/meter-optimums-expected.txt: Added.
* platform/gtk/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum: Added.
* platform/gtk/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png: Added.
* platform/gtk/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: Added.
* platform/gtk/fast/dom/HTMLMeterElement/meter-styles-expected.checksum: Added.
* platform/gtk/fast/dom/HTMLMeterElement/meter-styles-expected.png: Added.
* platform/gtk/fast/dom/HTMLMeterElement/meter-styles-expected.txt: Added.
2011-01-11 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add support for <meter> element
https://bugs.webkit.org/show_bug.cgi?id=48713
* GNUmakefile.am: Enable meter element.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75507
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Tue, 11 Jan 2011 17:22:23 +0000 (17:22 +0000)]
2011-01-11 Anders Carlsson <andersca@apple.com>
Reviewed by Andreas Kling.
Work towards having the WebPageProxy decide when to create the DrawingAreaProxy
https://bugs.webkit.org/show_bug.cgi?id=52184
Qt part made my Balazs Kelemen.
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::createDrawingAreaProxy):
Call -[WKView _createDrawingAreaProxy].
(WebKit::PageClientImpl::setViewNeedsDisplay):
Call setNeedsDisplayInRect on the WKView.
* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:contextRef:pageGroupRef:]):
No need to set the drawing area proxy anymore.
(-[WKView _createDrawingAreaProxy]):
Create a chunked update drawing area proxy for now.
* UIProcess/API/qt/qgraphicswkview.cpp:
Added a QGraphicsItem* member that is initialized in init to the accociated view.
Implement the new functions. This is a temporary solution, in the long term the view
and the page should be decoupled.
(QGraphicsWKView::QGraphicsWKView):
* UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::QWKPagePrivate):
(QWKPagePrivate::init):
(QWKPagePrivate::createDrawingAreaProxy):
(QWKPagePrivate::setViewNeedsDisplay):
* UIProcess/API/qt/qwkpage.h:
* UIProcess/API/qt/qwkpage_p.h:
* UIProcess/PageClient.h:
Add new pure virtual member functions.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::reinitializeWebPage):
Set the new drawing area proxy.
* UIProcess/win/WebView.cpp:
(WebKit::WebView::WebView):
No need to set the drawing area proxy anymore.
(WebKit::WebView::createDrawingAreaProxy):
Create a chunked update drawing area proxy for now.
(WebKit::WebView::setViewNeedsDisplay):
Invalidate the window.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75506
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 11 Jan 2011 16:49:38 +0000 (16:49 +0000)]
Unreviewed buildfix.
[Qt][V8] Add missing include for debug build.
* loader/cache/CachedResourceLoader.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75505
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
senorblanco@chromium.org [Tue, 11 Jan 2011 16:37:25 +0000 (16:37 +0000)]
2011-01-11 Stephen White <senorblanco@chromium.org>
Unreviewed; yet another gpu test_expectations update.
All glory to the hypnotoad.
* platform/chromium-gpu/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75504
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Tue, 11 Jan 2011 16:33:23 +0000 (16:33 +0000)]
2011-01-11 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: redirects are lost from the network panel upon navigation.
https://bugs.webkit.org/show_bug.cgi?id=52210
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager.prototype.didCommitLoadForFrame):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75503
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jocelyn.turcotte@nokia.com [Tue, 11 Jan 2011 16:19:05 +0000 (16:19 +0000)]
2011-01-11 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove uses of QFuture since it isn't supported on all platforms.
https://bugs.webkit.org/show_bug.cgi?id=51204
* platform/network/qt/QtNAMThreadSafeProxy.cpp:
(WebCore::QtNAMThreadSafeProxy::QtNAMThreadSafeProxy):
(WebCore::QtNAMThreadSafeProxy::localCookiesForUrl):
(WebCore::QtNAMThreadSafeProxy::localWillLoadFromCache):
* platform/network/qt/QtNAMThreadSafeProxy.h:
(WebCore::QtNAMThreadSafeProxy::cookiesForUrl):
(WebCore::QtNAMThreadSafeProxy::willLoadFromCache):
2011-01-11 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove uses of QFuture since it isn't supported on all platforms.
https://bugs.webkit.org/show_bug.cgi?id=51204
* QtTestBrowser/webpage.h:
(QtNAMThread::QtNAMThread):
(QtNAMThread::networkAccessManager):
(QtNAMThread::run):
2011-01-11 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove uses of QFuture since it isn't supported on all platforms.
https://bugs.webkit.org/show_bug.cgi?id=51204
* tests/qwebpage/tst_qwebpage.cpp:
(QtNAMThread::QtNAMThread):
(QtNAMThread::networkAccessManager):
(QtNAMThread::run):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75502
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pvarga@webkit.org [Tue, 11 Jan 2011 15:09:54 +0000 (15:09 +0000)]
2011-01-11 Peter Varga <pvarga@webkit.org>
Unreviewed.
Add myself to committers' list.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75501
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Tue, 11 Jan 2011 14:37:24 +0000 (14:37 +0000)]
2011-01-11 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: recreate script view after live edit.
https://bugs.webkit.org/show_bug.cgi?id=51751
* inspector/front-end/Script.js:
(WebInspector.Script.prototype.set source):
* inspector/front-end/ScriptView.js:
(WebInspector.ScriptView):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.editScriptSource.mycallback):
(WebInspector.ScriptsPanel.prototype.editScriptSource):
(WebInspector.ScriptsPanel.prototype.viewRecreated):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._doEditLine):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75500
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Tue, 11 Jan 2011 14:33:24 +0000 (14:33 +0000)]
2011-01-11 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: frameDetachedFromParent notification handler is missing in NetworkManager.
https://bugs.webkit.org/show_bug.cgi?id=52205
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager.prototype.frameDetachedFromParent):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75499
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Tue, 11 Jan 2011 14:11:46 +0000 (14:11 +0000)]
2011-01-11 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: "Audit present state" always disabled
https://bugs.webkit.org/show_bug.cgi?id=52199
Removed all traces of resource tracking checks, as we have it no more.
* English.lproj/localizedStrings.js:
* inspector/front-end/AuditLauncherView.js:
(WebInspector.AuditLauncherView.prototype._createLauncherUI):
* inspector/front-end/AuditsPanel.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75498
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Tue, 11 Jan 2011 14:09:07 +0000 (14:09 +0000)]
2011-01-11 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: move delayed search implementation to SourceFrame.
https://bugs.webkit.org/show_bug.cgi?id=51753
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._createViewerIfNeeded):
(WebInspector.SourceFrame.prototype.findSearchMatches):
(WebInspector.SourceFrame.prototype.cancelFindSearchMatches):
* inspector/front-end/SourceView.js:
(WebInspector.SourceView.prototype.hide):
(WebInspector.SourceView.prototype.searchCanceled):
(WebInspector.SourceView.prototype.performSearch.didFindSearchMatches):
(WebInspector.SourceView.prototype.performSearch):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75497
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jorlow@chromium.org [Tue, 11 Jan 2011 14:07:39 +0000 (14:07 +0000)]
2011-01-11 Jeremy Orlow <jorlow@chromium.org>
[Chromium] Fix bad baselines
https://bugs.webkit.org/show_bug.cgi?id=52207
It looks like https://bugs.webkit.org/show_bug.cgi?id=51865 didn't quite
get the baselines right. Ran the rebaseline tool to get these.
* platform/chromium-linux/svg/custom/fill-SVGPaint-interface-expected.txt: Removed.
* platform/chromium-linux/svg/custom/getPresentationAttribute-expected.txt: Removed.
* platform/chromium-win/svg/custom/fill-SVGPaint-interface-expected.txt:
* platform/chromium-win/svg/custom/getPresentationAttribute-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75496
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Tue, 11 Jan 2011 14:07:34 +0000 (14:07 +0000)]
2011-01-11 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: innerFirstChild has a side effect which should be called explicitly.
If a node is a frame's owner then innerFirstChild method
subscribes DOMAgent instance to the frame's doc's events.
I think this should be done explicitly when we meet with
the node for the first time. As I understand it happens
in buildArrayForContainerChildren method.
https://bugs.webkit.org/show_bug.cgi?id=52204
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::startListeningFrameDoc):
(WebCore::InspectorDOMAgent::buildArrayForContainerChildren):
(WebCore::InspectorDOMAgent::innerFirstChild):
* inspector/InspectorDOMAgent.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75495
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Tue, 11 Jan 2011 13:48:40 +0000 (13:48 +0000)]
Delete WKCACFLayer.{cpp,h}
These have been unused since r75262
* platform/graphics/win/WKCACFLayer.cpp: Removed.
* platform/graphics/win/WKCACFLayer.h: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75494
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Tue, 11 Jan 2011 13:40:14 +0000 (13:40 +0000)]
Update test results after r75408
* platform/mac-leopard/fast/js/large-expressions-expected.txt:
* platform/win/fast/js/large-expressions-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75493
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 11 Jan 2011 13:26:40 +0000 (13:26 +0000)]
Unreviewed.
[Qt] DRT sideeffect revealed by r63657 and r75305
https://bugs.webkit.org/show_bug.cgi?id=42578
After r75305 24 tests fail. Add them to the Skipped list temporarily to make buildbot happy.
* platform/qt/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75492
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Tue, 11 Jan 2011 13:19:16 +0000 (13:19 +0000)]
Fix a typo in a comment
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75491
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Tue, 11 Jan 2011 13:18:22 +0000 (13:18 +0000)]
Roll out r75487 since it broke the 32-bit build.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75490
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Tue, 11 Jan 2011 13:17:46 +0000 (13:17 +0000)]
2011-01-11 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [regression] Cookies view does not allow columns resize.
https://bugs.webkit.org/show_bug.cgi?id=51877
* inspector/front-end/CookieItemsView.js:
(WebInspector.CookieItemsView.prototype._updateWithCookies):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75489
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 11 Jan 2011 12:46:06 +0000 (12:46 +0000)]
2011-01-11 Noel Gordon <noel.gordon@gmail.com>
Reviewed by James Robinson.
[chromium] canvas.toDataURL("image/jpeg") should composite onto black.
https://bugs.webkit.org/show_bug.cgi?id=51237
canvas/philip/tests/toDataURL.jpeg.alpha.html only fails on chromium-mac
now, tracked by bug http://webkit.org/b/40147.
* platform/chromium/test_expectations.txt: win & linux pass.
2011-01-11 Noel Gordon <noel.gordon@gmail.com>
Reviewed by James Robinson.
[chromium] canvas.toDataURL("image/jpeg") should composite onto black.
https://bugs.webkit.org/show_bug.cgi?id=51237
The Canvas specification requires that the canvas image is composited using
the Porter-Duff operator source-over onto a black background; the resultant
image should be JPEG encoded and returned as a dataURL. To composite image
A and background B, for any Porter-Duff operator, produce pixels I with
I = c(A)F(A) + c(B)F(B)
where, F(X) is the fraction [0.0-1.0] contributed to the composite by image
X, and c(X) are the premultiplied RGB color components of image X. Note by
definition, c(B) = 0 since the background is black, so I = c(A)F(A). Since
F(A) = 1 in Porter-Duff operator source-over, the composited pixels satisfy
I = c(A). Hence, to conform to the Canvas spec, pass the premultiplied RGB
color components of the canvas image to the JPEG encoder.
Covered by canvas/philip/tests/toDataURL.jpeg.alpha.html
* platform/image-encoders/skia/JPEGImageEncoder.cpp:
(WebCore::preMultipliedBGRAtoRGB): Use Porter-Duff source-over black.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75488
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 11 Jan 2011 12:44:11 +0000 (12:44 +0000)]
2011-01-11 François Sausset <sausset@gmail.com>
Reviewed by Eric Seidel.
Code cleaning in rendering/mathml/RenderMathMLFraction.cpp
https://bugs.webkit.org/show_bug.cgi?id=52201
Replace unneeded doubles by floats and remove unneeded casts.
* rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::paint):
* rendering/mathml/RenderMathMLFraction.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75487
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Tue, 11 Jan 2011 12:31:48 +0000 (12:31 +0000)]
2011-01-11 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Chromium DevTools: get rid of APU-related code in WebKit/chromium.
https://bugs.webkit.org/show_bug.cgi?id=52152
* inspector/InspectorController.cpp:
(WebCore::InspectorController::restoreInspectorStateFromCookie):
(WebCore::InspectorController::setInjectedScriptSource):
* inspector/InspectorState.cpp:
(WebCore::InspectorState::InspectorState):
* inspector/InspectorState.h:
* inspector/front-end/inspector.js:
2011-01-11 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Chromium DevTools: get rid of APU-related code in WebKit/chromium.
https://bugs.webkit.org/show_bug.cgi?id=52152
* src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::WebDevToolsAgentImpl):
(WebKit::WebDevToolsAgentImpl::detach):
(WebKit::WebDevToolsAgentImpl::frontendLoaded):
(WebKit::WebDevToolsAgentImpl::setRuntimeProperty):
(WebKit::WebDevToolsAgentImpl::sendMessageToFrontend):
* src/WebDevToolsAgentImpl.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75486
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Tue, 11 Jan 2011 11:44:10 +0000 (11:44 +0000)]
2011-01-11 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [REGRESSION] Load timing is requested
for all resources (not only for the main one).
https://bugs.webkit.org/show_bug.cgi?id=51749
* inspector/InspectorController.cpp:
(WebCore::InspectorController::willSendRequest):
* loader/ResourceLoadNotifier.cpp:
(WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75485
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Tue, 11 Jan 2011 11:38:08 +0000 (11:38 +0000)]
Unreviewed Chromium test expectations update.
Remove now unnecessary Chromium overrides.
* platform/chromium-mac/fast/regex/malformed-escapes-expected.txt: Removed.
* platform/chromium-win/fast/regex/malformed-escapes-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75484
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 11 Jan 2011 11:26:03 +0000 (11:26 +0000)]
2011-01-11 Shane Stephens <shanestephens@google.com>
Reviewed by Eric Seidel.
[Chromium] Tests marked as WONTFIX SKIP but bug causing test failure fixed.
https://bugs.webkit.org/show_bug.cgi?id=51865
* platform/chromium-linux/svg/custom/fill-SVGPaint-interface-expected.checksum: Added.
* platform/chromium-linux/svg/custom/fill-SVGPaint-interface-expected.png: Added.
* platform/chromium-linux/svg/custom/fill-SVGPaint-interface-expected.txt: Added.
* platform/chromium-linux/svg/custom/getPresentationAttribute-expected.checksum: Added.
* platform/chromium-linux/svg/custom/getPresentationAttribute-expected.png: Added.
* platform/chromium-linux/svg/custom/getPresentationAttribute-expected.txt: Added.
* platform/chromium-win/svg/custom/fill-SVGPaint-interface-expected.checksum:
* platform/chromium-win/svg/custom/fill-SVGPaint-interface-expected.png:
* platform/chromium-win/svg/custom/fill-SVGPaint-interface-expected.txt: Added.
* platform/chromium-win/svg/custom/getPresentationAttribute-expected.checksum:
* platform/chromium-win/svg/custom/getPresentationAttribute-expected.png:
* platform/chromium-win/svg/custom/getPresentationAttribute-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75482
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Tue, 11 Jan 2011 11:18:54 +0000 (11:18 +0000)]
2011-01-11 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] GRefPtr should not be used with Gtk widgets
https://bugs.webkit.org/show_bug.cgi?id=51241
GRefPtr breaks the widget life-cycle, the main problem is
that GRefPtr calls g_object_unref() when it's destroyed,
which is undesirable for widgets. In gtk+ widgets are created with
a floating reference and when added to a container, the container
takes the ownership of the widget consuming the floating
reference. So you don't usually need to call g_object_ref/unref on
widgets (only for some operations like reparent a widget) and
toplevel widgets are destroyed with gtk_widget_destroy().
* platform/ContextMenuItem.h:
* platform/gtk/ContextMenuGtk.cpp:
(WebCore::ContextMenu::ContextMenu):
(WebCore::ContextMenu::~ContextMenu):
(WebCore::ContextMenu::setPlatformDescription):
* platform/gtk/ContextMenuItemGtk.cpp:
(WebCore::ContextMenuItem::ContextMenuItem):
(WebCore::ContextMenuItem::releasePlatformDescription):
(WebCore::ContextMenuItem::type):
(WebCore::ContextMenuItem::action):
(WebCore::ContextMenuItem::setAction):
(WebCore::ContextMenuItem::title):
(WebCore::ContextMenuItem::setTitle):
(WebCore::ContextMenuItem::platformSubMenu):
(WebCore::ContextMenuItem::setSubMenu):
(WebCore::ContextMenuItem::setChecked):
(WebCore::ContextMenuItem::setEnabled):
2011-01-11 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] GRefPtr should not be used with Gtk widgets
https://bugs.webkit.org/show_bug.cgi?id=51241
GRefPtr breaks the widget life-cycle, the main problem is
that GRefPtr calls g_object_unref() when it's destroyed,
which is undesirable for widgets. In gtk+ widgets are created with
a floating reference and when added to a container, the container
takes the ownership of the widget consuming the floating
reference. So you don't usually need to call g_object_ref/unref on
widgets (only for some operations like reparent a widget) and
toplevel widgets are destroyed with gtk_widget_destroy().
* WebCoreSupport/DragClientGtk.cpp:
(WebKit::DragClient::DragClient):
(WebKit::DragClient::~DragClient):
(WebKit::DragClient::startDrag):
* WebCoreSupport/DragClientGtk.h:
* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::postCommitFrameViewSetup):
* webkit/webkitwebview.cpp:
(webkit_web_view_dispose):
* webkit/webkitwebviewprivate.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75481
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 11 Jan 2011 10:36:36 +0000 (10:36 +0000)]
2011-01-11 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
commit-queue should know how to upload archived results (for test flakes or general failures)
https://bugs.webkit.org/show_bug.cgi?id=52048
Now the queue will always upload results. Either the entire zip, or just
the diffs.txt in the case of text failures.
This should make understanding flakes much easier, and paves the way
for having the EWS run layout tests (and upload failures).
In order to upload .zip files I had to teach bugzilla.py to autodetect
mime types from the filename. Since mimetypes.py doesn't include a mapping
for .patch files, I have it add one before calling guess_type.
We may find that always uploading the whole zip instead of just the -diffs.txt
file is preferable, but for now I'm keeping the old behavior because it makes
quickly understanding text failures easy.
* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
* Scripts/webkitpy/common/system/workspace.py: Added.
* Scripts/webkitpy/common/system/workspace_unittest.py: Added.
* Scripts/webkitpy/tool/bot/commitqueuetask.py:
* Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
* Scripts/webkitpy/tool/bot/flakytestreporter.py:
* Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
* Scripts/webkitpy/tool/commands/queues.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75480
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin.poulain@nokia.com [Tue, 11 Jan 2011 10:08:06 +0000 (10:08 +0000)]
2011-01-11 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix tst_QWebPage::geolocationRequestJS()
https://bugs.webkit.org/show_bug.cgi?id=46814
Skip the test when WebKit is compiled without geolocation.
* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::geolocationRequestJS):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75479
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit.git / log