WebKit.git
11 years agoNot reviewed, build fix.
mjs@apple.com [Tue, 18 May 2010 09:04:24 +0000 (09:04 +0000)]
Not reviewed, build fix.

Attempt to fix build for v8 bindings (untested).

* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::clearWindowShell):
* bindings/v8/ScriptController.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-18 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Tue, 18 May 2010 08:52:19 +0000 (08:52 +0000)]
2010-05-18  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Eric Seidel.

        Chromium: new-run-webkit-httpd fails to setup_mount
        https://bugs.webkit.org/show_bug.cgi?id=39257

        * Scripts/webkitpy/common/system/executive.py:
         Assert type of args in run_command.
        * Scripts/webkitpy/common/system/executive_unittest.py:
         Add test_run_command_args_type
        * Scripts/webkitpy/layout_tests/port/chromium_win.py:
         Executive.run_command takes array for command line.
        * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
         Test if setup_environ_for_server() run setup_mount.bat.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix QWebHistory serialization.
hausmann@webkit.org [Tue, 18 May 2010 08:42:28 +0000 (08:42 +0000)]
Fix QWebHistory serialization.

Patch by Jedrzej Nowacki <jedrzej.nowacki@nokia.com> on 2010-05-18
Reviewed by Simon Hausmann.

Regression was caused by bug 33224. The streaming function
should generate a documentSequenceNumber for all loaded values.

[Qt] tst_QWebHistory::serialize_2() fails
https://bugs.webkit.org/show_bug.cgi?id=37322

* Api/qwebhistory.cpp:
(operator>>):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-17 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Tue, 18 May 2010 08:09:57 +0000 (08:09 +0000)]
2010-05-17  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Oliver Hunt.

        GC more promptly when navigating to a new inner window, but not at all when it went in the page cache
        https://bugs.webkit.org/show_bug.cgi?id=39254
        <rdar://problem/7996370>

        ~1% PLT speedup
        ~4% iBench HTML speedup

        * bindings/js/GCController.cpp:
        (WebCore::GCController::garbageCollectSoon): Change back to a 0 delay timer instead of
        0.5 second.
        * bindings/js/ScriptController.cpp:
        (WebCore::ScriptController::clearWindowShell): Add a new boolean parameter. Don't
        garbageColectSoon if the page is going into the page cache.
        * bindings/js/ScriptController.h: Prototype change for above.
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::clear): Indicate when the page is going into the page cache.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-18 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 18 May 2010 07:24:09 +0000 (07:24 +0000)]
2010-05-18  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Implement ScriptData states for HTML5Lexer
        https://bugs.webkit.org/show_bug.cgi?id=39273

        This patch implements more of the lexer states according to the HTML5
        specification.  Currently, this code is compiled by not tested.  We're
        working on bringing up a test harness in parallel with transliterating
        the spec into code.

        * html/HTML5Lexer.cpp:
        (WebCore::HTML5Lexer::tokenize):
        (WebCore::HTML5Lexer::temporaryBufferIs):
        * html/HTML5Lexer.h:
        (WebCore::HTML5Lexer::):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-17 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 18 May 2010 07:00:02 +0000 (07:00 +0000)]
2010-05-17  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Rename HTML5Tokenzier to HTML5Lexer so that we can add a new HTML5Tokenizer which implements Tokenizer
        https://bugs.webkit.org/show_bug.cgi?id=39272

        Strictly a rename, no functionality change.

        * WebCore.xcodeproj/project.pbxproj:
        * html/HTML5Lexer.cpp: Added.
        * html/HTML5Lexer.h: Added.
        * html/HTML5Tokenizer.cpp: Removed.
        * html/HTML5Tokenizer.h: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed test expectations update for chromium.
atwilson@chromium.org [Tue, 18 May 2010 06:01:13 +0000 (06:01 +0000)]
Unreviewed test expectations update for chromium.

* platform/chromium-mac/html5lib/runner-expected.txt: Added.
* platform/chromium-win/html5lib/runner-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-17 Sheriff Bot <webkit.review.bot@gmail.com>
tkent@chromium.org [Tue, 18 May 2010 05:56:38 +0000 (05:56 +0000)]
2010-05-17  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r59652.
        http://trac.webkit.org/changeset/59652
        https://bugs.webkit.org/show_bug.cgi?id=39268

        file-input-files-access test is broken on Mac (Requested by
        dcheng on #webkit).

        * editing/pasteboard/file-input-files-access-expected.txt:
        * editing/pasteboard/script-tests/file-input-files-access.js:
        (runTest):
        * http/tests/security/clipboard/script-tests/clipboard-file-access.js:
2010-05-17  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r59652.
        http://trac.webkit.org/changeset/59652
        https://bugs.webkit.org/show_bug.cgi?id=39268

        file-input-files-access test is broken on Mac (Requested by
        dcheng on #webkit).

        * platform/chromium/DragDataChromium.cpp:
        (WebCore::DragData::asURL):
2010-05-17  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r59652.
        http://trac.webkit.org/changeset/59652
        https://bugs.webkit.org/show_bug.cgi?id=39268

        file-input-files-access test is broken on Mac (Requested by
        dcheng on #webkit).

        * Misc/WebNSPasteboardExtras.mm:
        (-[NSPasteboard _web_bestURL]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-17 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 18 May 2010 05:51:01 +0000 (05:51 +0000)]
2010-05-17  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Implement RAWTEXT tokenizer states
        https://bugs.webkit.org/show_bug.cgi?id=39267

        More tokenizer states.  There's a bunch of functionality notImplemented
        that we'll come back to.

        * html/HTML5Tokenizer.cpp:
        (WebCore::HTML5Tokenizer::tokenize):
        * html/HTML5Tokenizer.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-17 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 18 May 2010 05:17:34 +0000 (05:17 +0000)]
2010-05-17  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Implement more parser states in HTML5Tokenizer
        https://bugs.webkit.org/show_bug.cgi?id=39265

        This patch implements some easy states.  I'll come back and do the
        harder states later.

        * html/HTML5Tokenizer.cpp:
        (WebCore::HTML5Tokenizer::tokenize):
        (WebCore::HTML5Tokenizer::emitParseError):
        * html/HTML5Tokenizer.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-17 Daniel Cheng <dcheng@chromium.org>
tkent@chromium.org [Tue, 18 May 2010 05:11:49 +0000 (05:11 +0000)]
2010-05-17  Daniel Cheng  <dcheng@chromium.org>

        DragData::asURL() shouldn't do file validity checks
        https://bugs.webkit.org/show_bug.cgi?id=38711

        Several layout tests depended on the fact that dropping a file would
        never trigger navigation. This never happened to occur in the past,
        since it just so happened that the filenames used in the tests never
        resolved to files that exist. Since DragData::asURL() no longer tries
        to verify file existence, the layout tests were updated to either
        suppress navigation or log any navigation that should occur as part of
        the test.

        * editing/pasteboard/file-input-files-access-expected.txt:
        * editing/pasteboard/script-tests/file-input-files-access.js:
        (runTest.window.onbeforeunload):
        (runTest):
        * http/tests/security/clipboard/script-tests/clipboard-file-access.js:
2010-05-17  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by Darin Adler.

        DragData::asURL() shouldn't do file validity checks
        https://bugs.webkit.org/show_bug.cgi?id=38711

        There's no point to trying to make sure the file is valid in
        DragData::asURL(). It's better to ask for forgiveness than to ask for
        permission, since asking for permission is prone to race conditions
        and results in unnecessary I/O.  Consumers of this function either:
        - need to verify the file exists themselves (e.g. the loader)
        - don't care about file validity (rich text drag-and-drop)

        * platform/chromium/DragDataChromium.cpp:
        (WebCore::DragData::asURL):
2010-05-17  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by Darin Adler.

        DragData::asURL() shouldn't do file validity checks
        https://bugs.webkit.org/show_bug.cgi?id=38711

        Change [NSPasteboard _web_bestURL] to still return a file URL for paths
        that don't exist. Callers who care about the existence of the file or
        whether or not it is a directory should check themselves when they
        want to use the file. The directory check has been left in for now,
        since the Mac implementation of ResourceHandle, which uses this function
        indirectly via DragController::performDrag) handles directories somewhat
        non-intuitively: it opens the parent directory in the Finder, rather
        than opening the directory itself.

        * Misc/WebNSPasteboardExtras.mm:
        (-[NSPasteboard _web_bestURL]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed. Roll out r59650.
tkent@chromium.org [Tue, 18 May 2010 05:05:31 +0000 (05:05 +0000)]
Unreviewed. Roll out r59650.
A workaround of a buildbot issue triggered by r59650 wasn't resolved by r59646.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[DRT/Chromium] Fix repaint, WebGL, textarea tests
tkent@chromium.org [Tue, 18 May 2010 04:56:18 +0000 (04:56 +0000)]
[DRT/Chromium] Fix repaint, WebGL, textarea tests
https://bugs.webkit.org/show_bug.cgi?id=39054

Reviewed by Dimitri Glazkov.

WebKit/chromium:

* DEPS: Update to Chromium r47248 to use a fix for CommandLine assertion
  and textAreaResizeCorner.png
* WebKit.gyp: Add textAreaResizeCorner.png as a Mac resource
* features.gypi: Enable ENABLE_3D_CANVAS.

WebKitTools:

* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::canvas): Remove m_paintRect initialization in canvas().
 This line updated m_paintRect unexpectedly during paintRect().
 We don't need to initialize m_paintRect because show() does it.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-16 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Tue, 18 May 2010 04:46:22 +0000 (04:46 +0000)]
2010-05-16  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Darin Adler.

        Add tests for Bug 31267 - :nth-child(-2n) should match no element.
        http://trac.webkit.org/changeset/58300 has fixed this already.
        https://bugs.webkit.org/show_bug.cgi?id=31267

        * fast/css/nth-child-negative-a-param-expected.txt: Added.
        * fast/css/nth-child-negative-a-param.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-17 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 18 May 2010 04:27:33 +0000 (04:27 +0000)]
2010-05-17  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Update states in HTML5Tokenizer to match HTML5 spec
        https://bugs.webkit.org/show_bug.cgi?id=39264

        I've also implemented the DataState.  More states to follow.

        * html/HTML5Tokenizer.cpp:
        (WebCore::HTML5Tokenizer::reset):
        (WebCore::HTML5Tokenizer::tokenize):
        * html/HTML5Tokenizer.h:
        (WebCore::HTML5Tokenizer::):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed.
tkent@chromium.org [Tue, 18 May 2010 04:24:57 +0000 (04:24 +0000)]
Unreviewed.

Update a test for the behavior change of r59645.
https://bugs.webkit.org/show_bug.cgi?id=39162

* fast/forms/script-tests/willvalidate.js:
* fast/forms/willvalidate-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoChromium Windows build system does not rebuild correctly when
tkent@chromium.org [Tue, 18 May 2010 04:04:50 +0000 (04:04 +0000)]
Chromium Windows build system does not rebuild correctly when
enabling/disabling a feature
https://bugs.webkit.org/show_bug.cgi?id=38926

Reviewed by David Levin.

Add a workaround of this issue.

* Scripts/update-webkit:
  Chromium-Windows only: If WebKit/chromium/features.gyp has been
  updated, remove WebKit/chromium/Debug and WebKit/chromium/Release.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago':valid' CSS selector should not be applied to some form controls
tkent@chromium.org [Tue, 18 May 2010 03:57:06 +0000 (03:57 +0000)]
':valid' CSS selector should not be applied to some form controls
https://bugs.webkit.org/show_bug.cgi?id=39162

Reviewed by Darin Adler.

WebCore:

* html/HTMLElement.cpp:
(WebCore::inlineTagList): Always includes progressTag. This change is
needed in a case of no ENABLE_PROGRESS_TAG. Without this change and
ENABLE_PROGRESS_TAG, <progress> tags disappear.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::recalcWillValidate):
  Return false for SUBMIT and IMAGE.
* html/HTMLProgressElement.h:
(WebCore::HTMLProgressElement::recalcWillValidate):
  Return false. This change is needed in a case of ENABLE_PROGRESS_TAG.

LayoutTests:

Add test cases for
 - <input type=submit>
 - <input type=image>
 - <progress>
 - <meter>

* fast/css/pseudo-valid-unapplied-expected.txt:
* fast/css/pseudo-valid-unapplied.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-17 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 18 May 2010 03:41:34 +0000 (03:41 +0000)]
2010-05-17  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove load-related code from HTML5Tokenizer
        https://bugs.webkit.org/show_bug.cgi?id=39263

        This code is related to reloading resources and not to tokenizing.  In
        the PreloadScanner, these concerns are coupled, but we want to decouple
        them.

        * html/HTML5Tokenizer.cpp:
        (WebCore::HTML5Tokenizer::HTML5Tokenizer):
        (WebCore::HTML5Tokenizer::~HTML5Tokenizer):
        (WebCore::HTML5Tokenizer::begin):
        (WebCore::HTML5Tokenizer::end):
        (WebCore::HTML5Tokenizer::reset):
        (WebCore::HTML5Tokenizer::write):
        (WebCore::HTML5Tokenizer::consumeEntity):
        (WebCore::HTML5Tokenizer::tokenize):
        (WebCore::HTML5Tokenizer::processAttribute):
        (WebCore::HTML5Tokenizer::emitCharacter):
        (WebCore::HTML5Tokenizer::emitTag):
        * html/HTML5Tokenizer.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-17 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 18 May 2010 03:25:26 +0000 (03:25 +0000)]
2010-05-17  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add HTML5Tokenizer to the build system on Mac
        https://bugs.webkit.org/show_bug.cgi?id=39262

        This file will be easier to work with if we're actually compiling it.
        Hopefully we'll get this wired into the PreloadScanner soon.  Once we
        start actually calling the code, we'll add it to the build system on
        other platforms.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoOops, meant ebx not eax there. Fix Qt (and probably Win too).
barraclough@apple.com [Tue, 18 May 2010 03:24:05 +0000 (03:24 +0000)]
Oops, meant ebx not eax there.  Fix Qt (and probably Win too).

Reviewed by Geoff Garen.

* jit/JITOpcodes32_64.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-17 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 18 May 2010 03:21:00 +0000 (03:21 +0000)]
2010-05-17  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Copy PreloadScanner.* to HTML5Tokenizer.* to start work on the new HTML5 Tokenizer
        https://bugs.webkit.org/show_bug.cgi?id=39261

        * html/HTML5Tokenizer.cpp: Rename PreloadScanner to HTML5Tokenizer.
        * html/HTML5Tokenizer.h: ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-17 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 18 May 2010 03:15:53 +0000 (03:15 +0000)]
2010-05-17  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Copy PreloadScanner.* to HTML5Tokenizer.* to start work on the new HTML5 Tokenizer
        https://bugs.webkit.org/show_bug.cgi?id=39261

        This time copy the cpp from the right file.

        * html/HTML5Tokenizer.cpp: Copied from WebCore/html/PreloadScanner.cpp.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-17 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 18 May 2010 03:08:26 +0000 (03:08 +0000)]
2010-05-17  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Copy PreloadScanner.* to HTML5Tokenizer.* to start work on the new HTML5 Tokenizer
        https://bugs.webkit.org/show_bug.cgi?id=39261

        * html/HTML5Tokenizer.cpp: Copied from WebCore/html/PreloadScanner.h.
        * html/HTML5Tokenizer.h: Copied from WebCore/html/PreloadScanner.h.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-17 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 18 May 2010 03:06:32 +0000 (03:06 +0000)]
2010-05-17  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add the html5lib HTML parser tests
        https://bugs.webkit.org/show_bug.cgi?id=39260

        We currently fail a bunch of these.  Hopefully we'll get better as we
        implement the HTML5 parser.

        Source: http://gsnedders.html5.org/html5lib-tests/runner.html

        * html5lib/resources/dom2string.js: Added.
        (String.prototype.toAsciiLowerCase):
        (indent):
        (dom2string):
        * html5lib/resources/tests1.dat: Added.
        * html5lib/resources/tests10.dat: Added.
        * html5lib/resources/tests11.dat: Added.
        * html5lib/resources/tests12.dat: Added.
        * html5lib/resources/tests13.dat: Added.
        * html5lib/resources/tests14.dat: Added.
        * html5lib/resources/tests15.dat: Added.
        * html5lib/resources/tests16.dat: Added.
        * html5lib/resources/tests2.dat: Added.
        * html5lib/resources/tests3.dat: Added.
        * html5lib/resources/tests4.dat: Added.
        * html5lib/resources/tests5.dat: Added.
        * html5lib/resources/tests6.dat: Added.
        * html5lib/resources/tests7.dat: Added.
        * html5lib/resources/tests8.dat: Added.
        * html5lib/resources/tests9.dat: Added.
        * html5lib/runner-expected.txt: Added.
        * html5lib/runner.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 39252 - Move host/native JSFunction's NativeFunction onto NativeExecutable.
barraclough@apple.com [Tue, 18 May 2010 02:39:20 +0000 (02:39 +0000)]
Bug 39252 - Move host/native JSFunction's NativeFunction onto NativeExecutable.

Reviewed by Geoff Garen.

Currently host functions reuse JSFunction's ScopeChain as storage for their
NativeFunction (the C function pointer to the host function implementation).
Instead, move this onto NativeExecutable.  This will allow host functions to
have a scopechain (which will be implemented as a separate patch).

* JavaScriptCore.xcodeproj/project.pbxproj:
* jit/JIT.h:
* jit/JITCall.cpp:
(JSC::JIT::compileOpCallInitializeCallFrame):
(JSC::JIT::compileOpCall):
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
* jit/JITOpcodes32_64.cpp:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::emitSlow_op_get_by_val):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::emitSlow_op_get_by_val):
* jit/JITStubs.cpp:
(JSC::JITThunks::specializedThunk):
* jit/JITStubs.h:
(JSC::JITThunks::ctiNativeCall):
* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::finalize):
* jit/ThunkGenerators.cpp:
(JSC::charCodeAtThunkGenerator):
(JSC::charAtThunkGenerator):
(JSC::fromCharCodeThunkGenerator):
(JSC::sqrtThunkGenerator):
(JSC::powThunkGenerator):
* jit/ThunkGenerators.h:
* runtime/Executable.h:
(JSC::NativeExecutable::create):
(JSC::NativeExecutable::function):
(JSC::NativeExecutable::NativeExecutable):
(JSC::JSFunction::nativeFunction):
* runtime/JSFunction.cpp:
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::~JSFunction):
(JSC::JSFunction::markChildren):
(JSC::JSFunction::getCallData):
(JSC::JSFunction::call):
(JSC::JSFunction::getOwnPropertySlot):
(JSC::JSFunction::getConstructData):
(JSC::JSFunction::construct):
* runtime/JSFunction.h:
(JSC::JSFunction::scope):
* runtime/JSGlobalData.h:
(JSC::JSGlobalData::getThunk):
* runtime/Lookup.cpp:
(JSC::setUpStaticFunctionSlot):
* runtime/StringConstructor.cpp:
(JSC::StringConstructor::StringConstructor):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-17 Sheriff Bot <webkit.review.bot@gmail.com>
atwilson@chromium.org [Tue, 18 May 2010 01:38:26 +0000 (01:38 +0000)]
2010-05-17  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r59631.
        http://trac.webkit.org/changeset/59631
        https://bugs.webkit.org/show_bug.cgi?id=39255

        chromium canaries can no longer run webkit_tests, suspect this
        change. (Requested by atwilson on #webkit).

        * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-17 MORITA Hajime <morrita@google.com>
morrita@google.com [Tue, 18 May 2010 01:28:20 +0000 (01:28 +0000)]
2010-05-17  MORITA Hajime  <morrita@google.com>

        Reviewed by Kent Tamura.

        [Chromium] Windows: Speed of indeterminate progress bar should be constant
        https://bugs.webkit.org/show_bug.cgi?id=39211

        No new tests, animation effect can be confirmed only manually.

        * rendering/RenderThemeChromiumWin.cpp:
        (WebCore::RenderThemeChromiumWin::animationDurationForProgressBar):
        (WebCore::RenderThemeChromiumWin::paintProgressBar):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed build fix for Qt and Chromium. Added missing #include in Frame.h.
atwilson@chromium.org [Tue, 18 May 2010 00:58:46 +0000 (00:58 +0000)]
Unreviewed build fix for Qt and Chromium. Added missing #include in Frame.h.

https://bugs.webkit.org/show_bug.cgi?id=39147

* page/Frame.h: Now includes CSSMutableStyleDeclaration.h.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-17 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 18 May 2010 00:19:05 +0000 (00:19 +0000)]
2010-05-17  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        Remove unused member member from Document
        https://bugs.webkit.org/show_bug.cgi?id=39251

        Remove m_associatedHistoryItems from Document; it is never used.

        * dom/Document.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix Qt build.
darin@apple.com [Tue, 18 May 2010 00:15:37 +0000 (00:15 +0000)]
Fix Qt build.

* page/Frame.cpp:
(WebCore::Frame::setTypingStyle): Move back to make non-inline.
* page/Frame.h: Removed inline version of setTypingStyle.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-17 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 18 May 2010 00:15:16 +0000 (00:15 +0000)]
2010-05-17  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Attempt to make new-run-webkit-tests --help more sane
        https://bugs.webkit.org/show_bug.cgi?id=37836

        * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
         - Add a FIXME about options.singly and options.batch_size being different.
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
         - Add support for hidden options.
         - Add option groupings to attempt to simplify --help.
         - Fix a bunch of option helps to start with a capitalized verb.
         - Hide a bunch of options which make no sense to users.
         - Sort options in --help.
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
         - Add tests for option sorting.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-14 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 17 May 2010 23:48:48 +0000 (23:48 +0000)]
2010-05-14  Darin Adler  <darin@apple.com>

        Reviewed by Brady Eidson.

        Frame has many trivial member functions that should be inlined
        https://bugs.webkit.org/show_bug.cgi?id=39147

        * WebCore.base.exp: Export the functions that are now inlined.

        * page/Frame.cpp:
        (WebCore::Frame::removeEditingStyleFromBodyElement):
        Removed the body of this function.

        * page/Frame.h:
        (WebCore::Frame::init): Moved here from .cpp.
        (WebCore::Frame::loader): Ditto.
        (WebCore::Frame::redirectScheduler): Ditto.
        (WebCore::Frame::view): Ditto.
        (WebCore::Frame::script): Ditto.
        (WebCore::Frame::document): Ditto.
        (WebCore::Frame::selection): Ditto.
        (WebCore::Frame::editor): Ditto.
        (WebCore::Frame::animation): Ditto.
        (WebCore::Frame::mark): Ditto.
        (WebCore::Frame::setMark): Ditto.
        (WebCore::Frame::zoomFactor): Ditto.
        (WebCore::Frame::jsStatusBarText): Ditto.
        (WebCore::Frame::jsDefaultStatusBarText): Ditto.
        (WebCore::Frame::needsReapplyStyles): Ditto.
        (WebCore::Frame::typingStyle): Ditto.
        (WebCore::Frame::setTypingStyle): Ditto.
        (WebCore::Frame::clearTypingStyle): Ditto.
        (WebCore::Frame::ownerElement): Ditto.
        (WebCore::Frame::isDisconnected): Ditto.
        (WebCore::Frame::setIsDisconnected): Ditto.
        (WebCore::Frame::excludeFromTextSearch): Ditto.
        (WebCore::Frame::setExcludeFromTextSearch): Ditto.
        (WebCore::Frame::inViewSourceMode): Ditto.
        (WebCore::Frame::setInViewSourceMode): Ditto.
        (WebCore::Frame::markedTextMatchesAreHighlighted): Ditto.
        (WebCore::Frame::tree): Ditto.
        (WebCore::Frame::page): Ditto.
        (WebCore::Frame::detachFromPage): Ditto.
        (WebCore::Frame::eventHandler): Ditto.
        (WebCore::Frame::shouldClose): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-17 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 17 May 2010 23:03:57 +0000 (23:03 +0000)]
2010-05-17  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=39247
        <rdar://problem/7994707>
        Move rarely used data members to the rare structures, thus saving memory.

        Move rarely used member variables from StyleInheritedData and StyleVisualData to
        StyleRareInheritedData and StyleRareNonInheritedData, namely:

        indent, cursorData, m_effectiveZoom, widows and orphans move from StyleInheritedData to StyleRareInheritedData.
        m_counterIncrement and m_counterReset move from StyleVisualData to StyleRareNonInheritedData.

        * rendering/style/RenderStyle.cpp:
        (WebCore::RenderStyle::diff):
        (WebCore::RenderStyle::addCursor):
        (WebCore::RenderStyle::setCursorList):
        (WebCore::RenderStyle::clearCursorList):
        * rendering/style/RenderStyle.h:
        (WebCore::InheritedFlags::textIndent):
        (WebCore::InheritedFlags::effectiveZoom):
        (WebCore::InheritedFlags::counterIncrement):
        (WebCore::InheritedFlags::counterReset):
        (WebCore::InheritedFlags::cursors):
        (WebCore::InheritedFlags::widows):
        (WebCore::InheritedFlags::orphans):
        (WebCore::InheritedFlags::setTextIndent):
        (WebCore::InheritedFlags::setEffectiveZoom):
        (WebCore::InheritedFlags::setCounterIncrement):
        (WebCore::InheritedFlags::setCounterReset):
        (WebCore::InheritedFlags::setWidows):
        (WebCore::InheritedFlags::setOrphans):
        * rendering/style/StyleInheritedData.cpp:
        (WebCore::StyleInheritedData::StyleInheritedData):
        (WebCore::StyleInheritedData::operator==):
        * rendering/style/StyleInheritedData.h:
        * rendering/style/StyleRareInheritedData.cpp:
        (WebCore::StyleRareInheritedData::StyleRareInheritedData):
        (WebCore::cursorDataEquivalent):
        (WebCore::StyleRareInheritedData::operator==):
        * rendering/style/StyleRareInheritedData.h:
        * rendering/style/StyleRareNonInheritedData.cpp:
        (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
        (WebCore::StyleRareNonInheritedData::operator==):
        * rendering/style/StyleRareNonInheritedData.h:
        * rendering/style/StyleVisualData.cpp:
        (WebCore::StyleVisualData::StyleVisualData):
        * rendering/style/StyleVisualData.h:
        (WebCore::StyleVisualData::operator==):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-17 James Robinson <jamesr@chromium.org>
jamesr@google.com [Mon, 17 May 2010 22:25:29 +0000 (22:25 +0000)]
2010-05-17  James Robinson  <jamesr@chromium.org>

        Reviewed by Darin Adler.

        Rebaseline fast/multicol pixel results on mac
        https://bugs.webkit.org/show_bug.cgi?id=39241

        * fast/multicol/client-rects-expected.checksum:
        * fast/multicol/client-rects-expected.png:
        * platform/mac/fast/multicol/float-multicol-expected.png:
        * platform/mac/fast/multicol/layers-in-multicol-expected.checksum: Added.
        * platform/mac/fast/multicol/layers-in-multicol-expected.png: Added.
        * platform/mac/fast/multicol/nested-columns-expected.checksum: Added.
        * platform/mac/fast/multicol/nested-columns-expected.png: Added.
        * platform/mac/fast/multicol/positioned-with-constrained-height-expected.checksum:
        * platform/mac/fast/multicol/positioned-with-constrained-height-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed. Update Chromium test expectations.
atwilson@chromium.org [Mon, 17 May 2010 22:21:39 +0000 (22:21 +0000)]
Unreviewed. Update Chromium test expectations.

* platform/chromium-linux/fast/multicol/layers-in-multicol-expected.checksum:
* platform/chromium-linux/fast/multicol/layers-in-multicol-expected.png:
* platform/chromium-linux/fast/multicol/nested-columns-expected.checksum: Added.
* platform/chromium-linux/fast/multicol/nested-columns-expected.png: Added.
* platform/chromium-mac/fast/multicol/layers-in-multicol-expected.checksum:
* platform/chromium-mac/fast/multicol/layers-in-multicol-expected.png:
* platform/chromium-mac/fast/multicol/nested-columns-expected.checksum: Added.
* platform/chromium-mac/fast/multicol/nested-columns-expected.png: Added.
* platform/chromium-win/fast/multicol/layers-in-multicol-expected.checksum:
* platform/chromium-win/fast/multicol/layers-in-multicol-expected.png:
* platform/chromium-win/fast/multicol/layers-in-multicol-expected.txt:
* platform/chromium-win/fast/multicol/nested-columns-expected.checksum: Added.
* platform/chromium-win/fast/multicol/nested-columns-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-17 Robert Hogan <robert@webkit.org>
robert@webkit.org [Mon, 17 May 2010 20:45:11 +0000 (20:45 +0000)]
2010-05-17  Robert Hogan  <robert@webkit.org>

        Rubber-stamped by Eric Seidel.

        Fix --no-svg build.

        I have no idea where the SVG-dependent include of this file is hidden, but
        it is probably better to include it explicitly anyway like V8WorkerContextCustom.cpp.

        * bindings/js/JSWorkerContextCustom.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewd: Update Chromium test expectations.
atwilson@chromium.org [Mon, 17 May 2010 20:39:43 +0000 (20:39 +0000)]
Unreviewd: Update Chromium test expectations.

* platform/chromium-win/fast/multicol/nested-columns-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agohttps://bugs.webkit.org/show_bug.cgi?id=39231
hyatt@apple.com [Mon, 17 May 2010 20:29:00 +0000 (20:29 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=39231

Reviewed by Dan Bernstein.

Fix failures in the RTL portion of fast/multicol/layers-in-multicol.html.  Make sure block children of RTL blocks are positioned using
the reduced column width instead of the total content width.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::determineHorizontalPosition):
(WebCore::RenderBlock::nodeAtPoint):
(WebCore::RenderBlock::hitTestContents):
(WebCore::RenderBlock::adjustForColumns):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-17 Robert Hogan <robert@webkit.org>
robert@webkit.org [Mon, 17 May 2010 19:36:36 +0000 (19:36 +0000)]
2010-05-17  Robert Hogan  <robert@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Disable Icon Database by default in Qt DRT

        Unskip:
         http/tests/misc/favicon-loads-with-images-disabled.html
         http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html
         http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html
         http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html

        Qt returns 5 (QNetworkReply::OperationCanceledError) instead of -999 for the XFrameOptions tests,
        so update accordingly.

        https://bugs.webkit.org/show_bug.cgi?id=37382

        * platform/qt/Skipped:
        * platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Added. Qt returns 5 instead of -999.
        * platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Added. Qt returns 5 instead of -999.
        * platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Added. Qt returns 5 instead of -999.
2010-05-17  Robert Hogan  <robert@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Disable Icon Database by default in Qt DRT

        Unskip:
         http/tests/misc/favicon-loads-with-images-disabled.html
         http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html
         http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html
         http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html

        https://bugs.webkit.org/show_bug.cgi?id=37382

        Add support for layoutTestController.setIconDatabaseEnabled and layoutTestController.disableImageLoading().
        The XFrameOptions tests were failing because of an extra resource load callback for favicon.ico requests.
        These extra callbacks are removed by supporting both of the above layoutTestContoller commands.

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::WebPage::resetSettings):
        (WebCore::DumpRenderTree::DumpRenderTree):
        * DumpRenderTree/qt/DumpRenderTreeQt.h:
        (WebCore::DumpRenderTree::drtStoragePath):
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::reset):
        (LayoutTestController::disableImageLoading):
        (LayoutTestController::setIconDatabaseEnabled):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-17 Jakob Petsovits <jpetsovits@rim.com>
jpetsovits@rim.com [Mon, 17 May 2010 19:09:24 +0000 (19:09 +0000)]
2010-05-17  Jakob Petsovits  <jpetsovits@rim.com>

        Reviewed by George Staikos.

        [OpenVG] Add support for decoding and drawing images
        https://bugs.webkit.org/show_bug.cgi?id=36072

        OpenVG has a maximum image size (how large is
        specific to the OpenVG implementation), so this
        requires us to store them as separate image tiles.

        Image decoding and initial drawing code by
        Adam Treat <atreat@rim.com>. Image decoder
        downsampling support by Yong Li <yoli@rim.com>.

        * platform/graphics/ImageSource.h:
        * platform/graphics/openvg/ImageOpenVG.cpp: Added.
        (WebCore::FrameData::clear):
        (WebCore::BitmapImage::BitmapImage):
        (WebCore::BitmapImage::checkForSolidColor):
        (WebCore::BitmapImage::initPlatformData):
        (WebCore::BitmapImage::invalidatePlatformData):
        (WebCore::adjustSourceRectForDownSampling):
        (WebCore::BitmapImage::draw):
        (WebCore::Image::drawPattern):
        (WebCore::Image::loadPlatformResource):
        * platform/graphics/openvg/PainterOpenVG.cpp:
        (WebCore::PainterOpenVG::drawImage):
        (WebCore::PainterOpenVG::asNewNativeImage):
        * platform/graphics/openvg/PainterOpenVG.h:
        * platform/graphics/openvg/TiledImageOpenVG.cpp: Added.
        (WebCore::TiledImageOpenVG::TiledImageOpenVG):
        (WebCore::TiledImageOpenVG::operator=):
        (WebCore::TiledImageOpenVG::~TiledImageOpenVG):
        (WebCore::TiledImageOpenVG::numTiles):
        (WebCore::TiledImageOpenVG::numColumns):
        (WebCore::TiledImageOpenVG::numRows):
        (WebCore::TiledImageOpenVG::setTile):
        (WebCore::TiledImageOpenVG::tilesInRect):
        (WebCore::TiledImageOpenVG::tile):
        (WebCore::TiledImageOpenVG::tileRect):
        (WebCore::TiledImageOpenVG::detachTiles):
        (WebCore::TiledImageOpenVG::destroyTiles):
        * platform/graphics/openvg/TiledImageOpenVG.h: Added.
        (WebCore::TiledImageOpenVG::size):
        (WebCore::TiledImageOpenVG::maxTileSize):
        * platform/graphics/openvg/VGUtils.cpp:
        (WebCore::VGUtils::bytesForImage):
        (WebCore::VGUtils::bytesForImageScanline):
        (WebCore::VGUtils::imageFormatBitsPerPixel):
        (WebCore::VGUtils::endianAwareImageFormat):
        * platform/graphics/openvg/VGUtils.h:
        * platform/image-decoders/openvg/ImageDecoderOpenVG.cpp: Added.
        (WebCore::RGBA32Buffer::asNewNativeImage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-17 Yaar Schnitman <yaar@chromium.org>
yaar@chromium.org [Mon, 17 May 2010 18:42:25 +0000 (18:42 +0000)]
2010-05-17  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Darin Adler.

        Fix JSC's generation of 'Optional' arguments. When a single 'Optional' extended attribute precedes multiple method arguments, all of these arguments are optional as a group (either all or non must be specified). This fix, which makes JSC compliant with V8 and with the Web IDL specs, is pretty harmless, since Optional is currently not being used anywhere in JSC, but it blocks further work on overloads.
        https://bugs.webkit.org/show_bug.cgi?id=39227

        * bindings/scripts/CodeGeneratorJS.pm:
        * bindings/scripts/test/JS/JSTestObj.cpp:
        (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agohttps://bugs.webkit.org/show_bug.cgi?id=39192
weinig@apple.com [Mon, 17 May 2010 18:05:10 +0000 (18:05 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=39192
Remove unused PERFECT_HASH code CodeGeneratorJS.

Reviewed by Adam Barth.

* bindings/scripts/CodeGeneratorJS.pm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd a test of columns inside columns. The test also puts a RenderLayer in the 2nd...
hyatt@apple.com [Mon, 17 May 2010 17:57:48 +0000 (17:57 +0000)]
Add a test of columns inside columns.  The test also puts a RenderLayer in the 2nd column of the 2nd column
to make sure layer positioning works across nested columns.

Reviewed by Dan Bernstein.

* fast/multicol/nested-columns.html: Added.
* platform/mac/fast/multicol/nested-columns-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-17 Jeremy Moskovich <jeremy@chromium.org>
eric@webkit.org [Mon, 17 May 2010 17:54:44 +0000 (17:54 +0000)]
2010-05-17  Jeremy Moskovich  <jeremy@chromium.org>

        Reviewed by Jeremy Orlow.

        Remove debug code that was introduced to help narrow down the
        source of a crash.
        https://bugs.webkit.org/show_bug.cgi?id=36426

        No change in behavior, so no new tests.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::finishedLoadingDocument):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-17 Tasuku Suzuki <tasuku.suzuki@nokia.com>
eric@webkit.org [Mon, 17 May 2010 17:43:28 +0000 (17:43 +0000)]
2010-05-17  Tasuku Suzuki  <tasuku.suzuki@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Fix compilation with QT_NO_COMBOBOX
        https://bugs.webkit.org/show_bug.cgi?id=38324

        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::createSelectPopup):
        * WebCoreSupport/QtFallbackWebPopup.cpp:
        * WebCoreSupport/QtFallbackWebPopup.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-17 Andreas Kling <andreas.kling@nokia.com>
eric@webkit.org [Mon, 17 May 2010 17:32:46 +0000 (17:32 +0000)]
2010-05-17  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Add a test to verify proper behavior of createImageData(ImageData)
        and createImageData(width, height) with negative arguments.
        https://bugs.webkit.org/show_bug.cgi?id=39189

        Spec link:
        http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-createimagedata

        * fast/canvas/canvas-createImageData-expected.txt: Added.
        * fast/canvas/canvas-createImageData.html: Added.
        * fast/canvas/script-tests/canvas-createImageData.js: Added.
2010-05-17  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Bring CanvasRenderingContext2D's createImageData() in line with HTML5 spec
        Added createImageData(ImageData) which returns a new ImageData with the same size as the one passed.
        Changed createImageData(width, height) to use the absolute values of width and height.

        https://bugs.webkit.org/show_bug.cgi?id=39189

        Spec link:
        http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-createimagedata

        Test: fast/canvas/canvas-createImageData.html

        * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
        (WebCore::JSCanvasRenderingContext2D::createImageData):
        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::createImageData):
        * html/canvas/CanvasRenderingContext2D.h:
        * html/canvas/CanvasRenderingContext2D.idl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoThis was missing from previous commit.
antti.j.koivisto@nokia.com [Mon, 17 May 2010 15:37:17 +0000 (15:37 +0000)]
This was missing from previous commit.

* platform/qt/QWebPageClient.h:
(QWebPageClient::graphicsItemVisibleRect):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agohttps://bugs.webkit.org/show_bug.cgi?id=39218
antti.j.koivisto@nokia.com [Mon, 17 May 2010 15:34:14 +0000 (15:34 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=39218
[Qt] Tiled backing store tiles sometimes flicker when exiting a zoom animation

Reviewed by Kenneth Rohde Christiansen.

WebCore:

Tiles sometimes flicker when exiting a zoom animation. This happens as a result
of the visible rectangle being momentarily out of sync.

Instead of updating the visible rect by explicitly setting it, pull it through
the client and recompute in the WebKit level.

* page/ChromeClient.h:
(WebCore::ChromeClient::visibleRectForTiledBackingStore):
* page/Frame.cpp:
(WebCore::Frame::tiledBackingStoreVisibleRect):
* page/Frame.h:
* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::checkVisibleRectChanged):
(WebCore::TiledBackingStore::createTiles):
* platform/graphics/TiledBackingStore.h:
* platform/graphics/TiledBackingStoreClient.h:

WebKit/qt:

Tiles sometimes flicker when exiting a zoom animation. This happens as a result
of the visible rectangle being momentarily out of sync.

Instead of updating the visible rect by explicitly setting it, pull it through
the client and recompute in WebKit the level.

* Api/qgraphicswebview.cpp:
(QGraphicsWebView::paint):
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::visibleRectForTiledBackingStore):
* WebCoreSupport/ChromeClientQt.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoPeriodically try to reset a lost IDirect3DDevice9 until we succeed
aroben@apple.com [Mon, 17 May 2010 15:04:36 +0000 (15:04 +0000)]
Periodically try to reset a lost IDirect3DDevice9 until we succeed

This is how MSDN says we must respond to a lost device (see
<http://msdn.microsoft.com/en-us/library/bb174714(v=VS.85).aspx>).

Only testable by a manual test, unfortunately.

Fixes <rdar://problem/7986906> <http://webkit.org/b/39139> Pages that
use hardware acceleration don't repaint after waking computer from
sleep

Reviewed by John Sullivan.

* manual-tests/no-repaint-after-wake-from-sleep.html: Added. This is
the Poster Circle demo from webkit.org/blog, but with instructions for
putting the computer to sleep and waking it up again.

* platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): Initialize new
member that tells us whether we need to try to reset the device before
rendering.
(WebCore::WKCACFLayerRenderer::resize): Changed to tell resetDevice
the reason why the device needs to be reset (which is because the
window's size has changed).
(WebCore::WKCACFLayerRenderer::render): Before we do anything else,
check if we need to reset the device before rendering. If we do, try
to reset it. If that fails, bail out and set a timer to try again
later. If we discover that the device is lost when calling
IDirect3DDevice9::Present and resetting the device fails, bail out and
set a timer to try again later.
(WebCore::WKCACFLayerRenderer::resetDevice): Changed to return a
boolean indicating whether resetting succeeded or not. Added a
ResetReason parameter so callers can specify whey the device needs to
be reset. Before trying to do anything, we call
IDirect3DDevice9::TestCooperativeLevel to find out whether the device
can be reset currently. If it can't, we set a flag to tell ourselves
that the device must be reset before we next render, and indicate to
the caller that the reset failed. If we thought the device was lost
but it turns out not to be, we don't have to do anything and can tell
the caller that the reset succeeded. Otherwise we go ahead and reset
the device as before, and indicate to the caller that the reset
succeeded.

* platform/graphics/win/WKCACFLayerRenderer.h: Changed resetDevice to
return a boolean and take a ResetReason parameter. Added a comment
about when and why this function should be called. And added
m_mustResetLostDeviceBeforeRendering.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoCall CARenderOGLPurge whenever we call IDirect3DDevice9::Reset
aroben@apple.com [Mon, 17 May 2010 15:04:14 +0000 (15:04 +0000)]
Call CARenderOGLPurge whenever we call IDirect3DDevice9::Reset

MSDN says that all resoures allocated with D3DPOOL_DEFAULT must be
destroyed before calling IDirect3DDevice9::Reset. The only way to
guarantee this with Core Animation is to call CARenderOGLPurge.

Unfortunately this isn't testable at the moment, as we don't use any
features of Core Animation (e.g., mask layers) that actually make this
required. But it seems like a good idea to fix the code now so that
if/when we do start using those features we won't run into problems.

Fixes <http://webkit.org/b/39159> WKCACFLayerRenderer::resetDevice
might fail due to failing to destroy all D3DPOOL_DEFAULT resources

Reviewed by John Sullivan.

* platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::render): Moved the call to
CARenderOGLPurge from here...
(WebCore::WKCACFLayerRenderer::resetDevice): ...to here, so that it
will be called whenever we reset the device (e.g., when resizing the
window).

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Mon, 17 May 2010 14:42:26 +0000 (14:42 +0000)]
2010-05-17  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Rubber-stamped by Xan Lopez.

        Build fix. Remove bashism from build system.

        * GNUmakefile.am:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-17 Sheriff Bot <webkit.review.bot@gmail.com>
yurys@chromium.org [Mon, 17 May 2010 14:25:02 +0000 (14:25 +0000)]
2010-05-17  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r59483.
        http://trac.webkit.org/changeset/59483
        https://bugs.webkit.org/show_bug.cgi?id=39215

        "page_cycler_intl1 regression on Linux" (Requested by yurys on
        #webkit).

        * platform/chromium/ChromiumBridge.h:
        * platform/graphics/chromium/FontCacheLinux.cpp:
        (WebCore::FontCache::getFontDataForCharacters):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoREGRESSION(59563): [Qt] JSValue QtClass::fallbackObject can be optimized
kenneth@webkit.org [Mon, 17 May 2010 13:49:55 +0000 (13:49 +0000)]
REGRESSION(59563): [Qt] JSValue QtClass::fallbackObject can be optimized

Reviewed by Laszlo Gombos.

Patch declared a variable index, which shadowed an earlier declared
variable.

* bridge/qt/qt_class.cpp:
(JSC::Bindings::QtClass::fallbackObject):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-14 Andrei Popescu <andreip@google.com>
jorlow@chromium.org [Mon, 17 May 2010 13:33:00 +0000 (13:33 +0000)]
2010-05-14  Andrei Popescu  <andreip@google.com>

        Reviewed by Jeremy Orlow.

        IDBRequest is not a proper ActiveDomObject
        https://bugs.webkit.org/show_bug.cgi?id=39001

        Add IDBRequest interface to the IsActiveDomType
        routine of the CodeGeneratorV8.pm.

        Rename IDBRequest::m_stopped to m_suspended and reset
        the flag when resume() is called.

        No new tests, Indexed Database isn't yet testable.

        * bindings/scripts/CodeGeneratorV8.pm:
        * storage/IDBRequest.cpp:
        (WebCore::IDBRequest::suspend):
        (WebCore::IDBRequest::resume):
        (WebCore::IDBRequest::timerFired):
        (WebCore::IDBRequest::onEventCommon):
        * storage/IDBRequest.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-17 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Mon, 17 May 2010 13:22:01 +0000 (13:22 +0000)]
2010-05-17  Xan Lopez  <xlopez@igalia.com>

        Do not include the indexed database headers if the feature is not
        enabled. Should fix the build in GTK+.

        * bindings/js/JSEventCustom.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-17 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Mon, 17 May 2010 12:55:46 +0000 (12:55 +0000)]
2010-05-17  Xan Lopez  <xlopez@igalia.com>

        Try to fix GTK+ build.

        * GNUmakefile.am:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-14 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Mon, 17 May 2010 11:20:45 +0000 (11:20 +0000)]
2010-05-14  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Nate Chapin.

        Finish up IndexedDB events
        https://bugs.webkit.org/show_bug.cgi?id=39117

        Add the beginnings of a test for IndexedDB.  It currently fails, but we'll
        update this (and/or add other tests) as things start passing.

        Disable it on all !Chromium platforms since none of them compile it
        in.  (Note that Chromium keeps it behind a runtime flag at the moment,
        despite compiling it in...so don't worry.)

        This also makes evalAndLog return the result of the evaluation.  I think
        this was just an oversight when I originally added it, and it's going to
        come in useful for these tests.

        * fast/js/resources/js-test-pre.js:
        (evalAndLog):
        * platform/gtk/Skipped:
        * platform/mac-leopard/Skipped:
        * platform/mac-snowleopard/Skipped:
        * platform/mac-tiger/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
        * storage/indexeddb/basics-expected.txt: Added.
        * storage/indexeddb/basics.html: Added.
        * storage/indexeddb/script-tests/TEMPLATE.html: Copied from LayoutTests/storage/domstorage/script-tests/TEMPLATE.html.
        * storage/indexeddb/script-tests/basics.js: Added.
        (eventShared):
        (successFunction):
        (errorFunction):
        (test):
2010-05-14  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Nate Chapin.

        Finish up IndexedDB events
        https://bugs.webkit.org/show_bug.cgi?id=39117

        Implement the indexed database event interfaces as proposed by Mozilla.
        Refactor the run time type detection code that was in IDBRequest into its own
        class named IDBAny.  Use this new class within the new event classes and
        IDBResults.

        Test: storage/indexeddb/basics.html

        * DerivedSources.cpp:
        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:
        * WebCore.pri:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSEventCustom.cpp:
        (WebCore::toJS):
        * bindings/js/JSEventTarget.cpp:
        (WebCore::toJS):
        * bindings/js/JSIDBAnyCustom.cpp: Added.
        (WebCore::toJS):
        * bindings/js/JSIDBRequestCustom.cpp: Removed.
        * bindings/v8/custom/V8EventCustom.cpp:
        (WebCore::toV8):
        * bindings/v8/custom/V8IDBAnyCustom.cpp: Added.
        (WebCore::toV8):
        * bindings/v8/custom/V8IDBRequestCustom.cpp: Removed.
        * dom/Event.cpp:
        (WebCore::Event::isIDBErrorEvent):
        (WebCore::Event::isIDBSuccessEvent):
        * dom/Event.h:
        * storage/IDBAny.cpp: Added.
        (WebCore::IDBAny::create):
        (WebCore::IDBAny::IDBAny):
        (WebCore::IDBAny::~IDBAny):
        (WebCore::IDBAny::idbDatabaseRequest):
        (WebCore::IDBAny::indexedDatabaseRequest):
        (WebCore::IDBAny::serializedScriptValue):
        (WebCore::IDBAny::set):
        * storage/IDBAny.h: Added.
        (WebCore::IDBAny::):
        (WebCore::IDBAny::type):
        * storage/IDBAny.idl: Added.
        * storage/IDBErrorEvent.cpp: Added.
        (WebCore::IDBErrorEvent::create):
        (WebCore::IDBErrorEvent::IDBErrorEvent):
        (WebCore::IDBErrorEvent::~IDBErrorEvent):
        * storage/IDBErrorEvent.h: Added.
        (WebCore::IDBErrorEvent::code):
        (WebCore::IDBErrorEvent::message):
        (WebCore::IDBErrorEvent::isIDBErrorEvent):
        * storage/IDBErrorEvent.idl: Added.
        * storage/IDBEvent.cpp: Added.
        (WebCore::IDBEvent::IDBEvent):
        (WebCore::IDBEvent::~IDBEvent):
        (WebCore::IDBEvent::source):
        * storage/IDBEvent.h: Added.
        * storage/IDBEvent.idl: Added.
        * storage/IDBRequest.cpp:
        (WebCore::IDBRequest::IDBRequest):
        (WebCore::IDBRequest::onSuccess):
        (WebCore::IDBRequest::timerFired):
        (WebCore::IDBRequest::onEventCommon):
        * storage/IDBRequest.h:
        (WebCore::IDBRequest::create):
        (WebCore::IDBRequest::result):
        * storage/IDBRequest.idl:
        * storage/IDBSuccessEvent.cpp: Added.
        (WebCore::IDBSuccessEvent::create):
        (WebCore::IDBSuccessEvent::IDBSuccessEvent):
        (WebCore::IDBSuccessEvent::~IDBSuccessEvent):
        (WebCore::IDBSuccessEvent::result):
        * storage/IDBSuccessEvent.h: Added.
        (WebCore::IDBSuccessEvent::isIDBSuccessEvent):
        * storage/IDBSuccessEvent.idl: Added.
        * storage/IndexedDatabaseImpl.cpp:
        (WebCore::IndexedDatabaseImpl::open):
        * storage/IndexedDatabaseRequest.cpp:
        (WebCore::IndexedDatabaseRequest::IndexedDatabaseRequest):
        (WebCore::IndexedDatabaseRequest::open):
        * storage/IndexedDatabaseRequest.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-17 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Mon, 17 May 2010 08:44:00 +0000 (08:44 +0000)]
2010-05-17  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Update Chromium test expectations.

        * platform/chromium-win-xp/fast/multicol/client-rects-expected.txt: Removed.
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-17 Patrick Gansterer <paroga@paroga.com>
eric@webkit.org [Mon, 17 May 2010 08:11:07 +0000 (08:11 +0000)]
2010-05-17  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Laszlo Gombos.

        [Qt] Remove WinCE endian dedection.
        https://bugs.webkit.org/show_bug.cgi?id=38511

        Windows CE supports little-endian format only.
        Correct dedection was added in r57804.

        * wtf/Platform.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBrowser-hosted version of SunSpider runs tests twice as many times as advertised
mjs@apple.com [Mon, 17 May 2010 08:10:52 +0000 (08:10 +0000)]
Browser-hosted version of SunSpider runs tests twice as many times as advertised
https://bugs.webkit.org/show_bug.cgi?id=39201

Reviewed by Mark Rowe.

* make-hosted: Make sure to reset test list after every test suite.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed.
cjerdonek@webkit.org [Mon, 17 May 2010 08:03:19 +0000 (08:03 +0000)]
Unreviewed.

Removed the stray equals sign from the reviewer's name in the
"Reviewed by" line of the ChangeLog entry for r59596:

http://trac.webkit.org/changeset/59596

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-17 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Mon, 17 May 2010 07:42:03 +0000 (07:42 +0000)]
2010-05-17  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Update Chromium test expectations.

        * platform/chromium-linux/fast/loader/recursive-before-unload-crash-expected.txt:
        * platform/chromium-linux/fast/multicol/client-rects-expected.txt: Removed.
        * platform/chromium-linux/fast/multicol/column-count-with-rules-expected.checksum: Added.
        * platform/chromium-linux/fast/multicol/column-count-with-rules-expected.png: Added.
        * platform/chromium-linux/fast/multicol/layers-in-multicol-expected.checksum: Added.
        * platform/chromium-linux/fast/multicol/layers-in-multicol-expected.png: Added.
        * platform/chromium-mac/fast/multicol/column-count-with-rules-expected.checksum: Added.
        * platform/chromium-mac/fast/multicol/column-count-with-rules-expected.png: Added.
        * platform/chromium-mac/fast/multicol/layers-in-multicol-expected.checksum: Added.
        * platform/chromium-mac/fast/multicol/layers-in-multicol-expected.png: Added.
        * platform/chromium-win/fast/canvas/canvas-toDataURL-case-insensitive-mimetype-expected.txt: Added.
        * platform/chromium-win/fast/multicol/client-rects-expected.txt:
        * platform/chromium-win/fast/multicol/column-count-with-rules-expected.checksum: Added.
        * platform/chromium-win/fast/multicol/column-count-with-rules-expected.png: Added.
        * platform/chromium-win/fast/multicol/column-count-with-rules-expected.txt: Added.
        * platform/chromium-win/fast/multicol/column-rules-expected.txt:
        * platform/chromium-win/fast/multicol/columns-shorthand-parsing-expected.txt:
        * platform/chromium-win/fast/multicol/float-avoidance-expected.txt:
        * platform/chromium-win/fast/multicol/float-multicol-expected.txt:
        * platform/chromium-win/fast/multicol/layers-in-multicol-expected.checksum: Added.
        * platform/chromium-win/fast/multicol/layers-in-multicol-expected.png: Added.
        * platform/chromium-win/fast/multicol/layers-in-multicol-expected.txt: Added.
        * platform/chromium-win/fast/multicol/single-line-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-16 Chris Jerdonek <cjerdonek@webkit.org>
cjerdonek@webkit.org [Mon, 17 May 2010 07:34:12 +0000 (07:34 +0000)]
2010-05-16  Chris Jerdonek  <cjerdonek@webkit.org>

        Reviewed by =Adam Barth.

        Refactored FrameLoader::changeLocation() and urlSelected() to share more code.

        https://bugs.webkit.org/show_bug.cgi?id=38827

        No change in behavior, so no new tests.

        * bindings/ScriptControllerBase.cpp:
        (WebCore::ScriptController::executeIfJavaScriptURL):
          - Changed a parameter from boolean to the ShouldReplaceDocumentIfJavaScriptURL enum.
        * bindings/js/ScriptController.h:
          - Changed a parameter from boolean to the ShouldReplaceDocumentIfJavaScriptURL enum.
        * bindings/v8/ScriptController.h:
          - Changed a parameter from boolean to the ShouldReplaceDocumentIfJavaScriptURL enum.
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::changeLocation):
          - Changed to call the new private overload of urlSelected().
        (WebCore::FrameLoader::urlSelected):
          - Added a private overload of urlSelected().
          - Changed the public urlSelected() to call the private overload.
        (WebCore::FrameLoader::submitForm):
        * loader/FrameLoader.h:
          - Added a private overload of urlSelected().
        * loader/FrameLoaderTypes.h:
          - Added a ShouldReplaceDocumentIfJavaScriptURL enum.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-17 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Mon, 17 May 2010 07:06:50 +0000 (07:06 +0000)]
2010-05-17  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Eric Seidel.

        Chromium: Add --chromium option to new-run-webkit-websocketserver
        https://bugs.webkit.org/show_bug.cgi?id=37664

        os.environ setup and setup_mount for cygwin are moved in ChromiumWinPort.setup_environ_for_server.

        * Scripts/new-run-webkit-httpd:
          Remove passing register_cygwin.
        * Scripts/new-run-webkit-websocketserver:
          Add --chromium flag.
          Remove passing register_cygwin.
          Create port object using options.
        * Scripts/webkitpy/layout_tests/port/base.py:
          Add setup_environ_for_server().
        * Scripts/webkitpy/layout_tests/port/chromium_win.py:
          Ditto.
        * Scripts/webkitpy/layout_tests/port/factory_unittest.py: Added.
        * Scripts/webkitpy/layout_tests/port/http_server.py:
          Remove register_cygwin_parameter.
          Call setup_environ_for_server().
        * Scripts/webkitpy/layout_tests/port/websocket_server.py:
          Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed
ukai@chromium.org [Mon, 17 May 2010 06:10:22 +0000 (06:10 +0000)]
Unreviewed

Patch by Takeshi Yoshino <tyoshino@google.com> on 2010-05-16
Update test_expectations.txt for Chromium
fast/loader/recursive-before-unload-crash.html is flaky on Linux and Win
See http://code.google.com/p/chromium/issues/detail?id=44229 for detail.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-16 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Mon, 17 May 2010 06:10:06 +0000 (06:10 +0000)]
2010-05-16  Daniel Bates  <dbates@rim.com>

        Reviewed by Chris Jerdonek.

        https://bugs.webkit.org/show_bug.cgi?id=39184

        Adds function VCSUtils::parseSvnProperty to parse an SVN property with
        either a single-line or multi-line value change.

        * Scripts/VCSUtils.pm:
          - Added function parseSvnProperty. We will use this function
            towards resolving Bug #38885 <https://bugs.webkit.org/show_bug.cgi?id=38885>.
          - Removed FIXME comment above function parseSvnPropertyValue, since
            it is being used by parseSvnProperty.
          - Modified function parseSvnPropertyValue to break out of "while (<$fileHandle>)"
            loop when it encounters the start of the next property so that it can be
            processed by its caller, parseSvnPropertyValue. We reference this bullet below
            by (*).
        * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: Added.
          - Added unit tests.
        * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
          - Changed the name of the unit test "simple multi-line '-' change" to
            "single-line '-' change followed by empty line" since the former was an
            incorrect description of this test.
          - Added unit test "single-line '-' change followed by the next property", and
            "multi-line '-' change followed by the next property" to test (*) above.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-16 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Mon, 17 May 2010 04:58:25 +0000 (04:58 +0000)]
2010-05-16  Daniel Bates  <dbates@rim.com>

        Reviewed by David Hyatt.

        https://bugs.webkit.org/show_bug.cgi?id=39196

        Rollout changeset 59274 <http://trac.webkit.org/changeset/59274>.

        Prepared on behalf of David Hyatt.

        "Not worth the memory use." Just roll this out.

        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * editing/visible_units.cpp:
        (WebCore::previousLinePosition):
        (WebCore::nextLinePosition):
        * rendering/EllipsisBox.cpp:
        (WebCore::EllipsisBox::paint):
        (WebCore::EllipsisBox::selectionRect):
        (WebCore::EllipsisBox::paintSelection):
        (WebCore::EllipsisBox::nodeAtPoint):
        * rendering/EllipsisBox.h:
        (WebCore::EllipsisBox::EllipsisBox):
        (WebCore::EllipsisBox::height):
        * rendering/InlineBox.cpp:
        (WebCore::InlineBox::height):
        (WebCore::InlineBox::adjustPosition):
        (WebCore::InlineBox::canAccommodateEllipsis):
        * rendering/InlineBox.h:
        (WebCore::InlineBox::InlineBox):
        (WebCore::InlineBox::isInlineBox):
        (WebCore::InlineBox::hasVirtualHeight):
        (WebCore::InlineBox::setHasVirtualHeight):
        (WebCore::InlineBox::virtualHeight):
        (WebCore::InlineBox::setWidth):
        (WebCore::InlineBox::width):
        (WebCore::InlineBox::setX):
        (WebCore::InlineBox::x):
        (WebCore::InlineBox::setY):
        (WebCore::InlineBox::y):
        (WebCore::InlineBox::baselinePosition):
        (WebCore::InlineBox::lineHeight):
        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::placeBoxesVertically):
        (WebCore::InlineFlowBox::computeVerticalOverflow):
        (WebCore::InlineFlowBox::nodeAtPoint):
        (WebCore::InlineFlowBox::paintBoxDecorations):
        (WebCore::InlineFlowBox::paintMask):
        (WebCore::InlineFlowBox::paintTextDecorations):
        * rendering/InlineFlowBox.h:
        (WebCore::InlineFlowBox::visibleOverflowRect):
        (WebCore::InlineFlowBox::topLayoutOverflow):
        (WebCore::InlineFlowBox::bottomLayoutOverflow):
        (WebCore::InlineFlowBox::leftLayoutOverflow):
        (WebCore::InlineFlowBox::rightLayoutOverflow):
        (WebCore::InlineFlowBox::layoutOverflowRect):
        (WebCore::InlineFlowBox::topVisualOverflow):
        (WebCore::InlineFlowBox::bottomVisualOverflow):
        (WebCore::InlineFlowBox::leftVisualOverflow):
        (WebCore::InlineFlowBox::rightVisualOverflow):
        (WebCore::InlineFlowBox::visualOverflowRect):
        (WebCore::InlineFlowBox::setHorizontalOverflowPositions):
        (WebCore::InlineFlowBox::setVerticalOverflowPositions):
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::selectionRect):
        (WebCore::InlineTextBox::placeEllipsisBox):
        (WebCore::InlineTextBox::nodeAtPoint):
        (WebCore::InlineTextBox::paint):
        (WebCore::InlineTextBox::paintSelection):
        (WebCore::InlineTextBox::paintCompositionBackground):
        (WebCore::InlineTextBox::paintDecoration):
        (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
        (WebCore::InlineTextBox::paintTextMatchMarker):
        (WebCore::InlineTextBox::computeRectForReplacementMarker):
        (WebCore::InlineTextBox::paintCompositionUnderline):
        (WebCore::InlineTextBox::offsetForPosition):
        (WebCore::InlineTextBox::positionForOffset):
        * rendering/InlineTextBox.h:
        (WebCore::InlineTextBox::setSpaceAdd):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::positionForPointWithInlineChildren):
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::computeVerticalPositionsForLine):
        (WebCore::RenderBlock::layoutInlineChildren):
        * rendering/RenderSVGInline.cpp:
        (WebCore::RenderSVGInline::createInlineFlowBox):
        * rendering/RenderSVGInlineText.cpp:
        (WebCore::RenderSVGInlineText::createTextBox):
        * rendering/RenderSVGText.cpp:
        (WebCore::RenderSVGText::createRootInlineBox):
        * rendering/RenderText.cpp:
        (WebCore::RenderText::positionForPoint):
        (WebCore::RenderText::firstRunX):
        (WebCore::RenderText::firstRunY):
        * rendering/RenderTreeAsText.cpp:
        (WebCore::writeTextRun):
        * rendering/RootInlineBox.cpp:
        (WebCore::RootInlineBox::placeEllipsis):
        (WebCore::RootInlineBox::addHighlightOverflow):
        (WebCore::RootInlineBox::closestLeafChildForXPos):
        * rendering/SVGInlineFlowBox.h:
        (WebCore::SVGInlineFlowBox::SVGInlineFlowBox):
        (WebCore::SVGInlineFlowBox::virtualHeight):
        (WebCore::SVGInlineFlowBox::setHeight):
        * rendering/SVGInlineTextBox.h:
        (WebCore::SVGInlineTextBox::virtualHeight):
        (WebCore::SVGInlineTextBox::setHeight):
        (WebCore::SVGInlineTextBox::selectionTop):
        (WebCore::SVGInlineTextBox::selectionHeight):
        * rendering/SVGRootInlineBox.h:
        (WebCore::SVGRootInlineBox::SVGRootInlineBox):
        (WebCore::SVGRootInlineBox::virtualHeight):
        (WebCore::SVGRootInlineBox::setHeight):
        * rendering/TrailingFloatsRootInlineBox.h: Added.
        (WebCore::TrailingFloatsRootInlineBox::TrailingFloatsRootInlineBox):
        (WebCore::TrailingFloatsRootInlineBox::virtualHeight):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-13 Tony Chang <tony@chromium.org>
tony@chromium.org [Mon, 17 May 2010 04:08:56 +0000 (04:08 +0000)]
2010-05-13  Tony Chang  <tony@chromium.org>

        Reviewed by Darin Adler.

        REGRESSION: Crash by pasting to a textarea with white-space:nowrap
        https://bugs.webkit.org/show_bug.cgi?id=38992

        * editing/pasteboard/paste-plaintext-nowrap-expected.txt: Added.
        * editing/pasteboard/paste-plaintext-nowrap.html: Added.
2010-05-13  Tony Chang  <tony@chromium.org>

        Reviewed by Darin Adler.

        REGRESSION: Crash by pasting to a textarea with white-space:nowrap
        https://bugs.webkit.org/show_bug.cgi?id=38992

        Test: editing/pasteboard/paste-plaintext-nowrap.html

        * editing/InsertParagraphSeparatorCommand.cpp:
        (WebCore::highestVisuallyEquivalentDivBelowRoot):
        (WebCore::InsertParagraphSeparatorCommand::doApply):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agohttps://bugs.webkit.org/show_bug.cgi?id=39194
hyatt@apple.com [Mon, 17 May 2010 03:34:48 +0000 (03:34 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=39194

Reviewed by Dan Bernstein.

Fix all of the multi-column painting and hit testing functions to properly account for RTL directionality.

Added fast/multicol/column-count-with-rules.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::paintColumnContents):
(WebCore::RenderBlock::hitTestColumns):
(WebCore::RenderBlock::adjustRectForColumns):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix SVG test failures after r59588.
mitz@apple.com [Mon, 17 May 2010 03:03:46 +0000 (03:03 +0000)]
Fix SVG test failures after r59588.

Reviewed by Dave Hyatt.

Updated SVG InlineBox virtual method overrides to match HTML ones. Removed
SVGInlineFlowBox::verticallyAlignBoxes() since InlineFlowBox no longer declares
verticallyAlignBoxes().

* rendering/SVGInlineFlowBox.cpp:
(WebCore::SVGInlineFlowBox::placeBoxesHorizontally):
* rendering/SVGInlineFlowBox.h:
* rendering/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::placeBoxesHorizontally):
(WebCore::SVGRootInlineBox::verticallyAlignBoxes):
* rendering/SVGRootInlineBox.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMove transient glyph overflow and fallback font data from a global to the stack
mitz@apple.com [Mon, 17 May 2010 01:43:49 +0000 (01:43 +0000)]
Move transient glyph overflow and fallback font data from a global to the stack
https://bugs.webkit.org/show_bug.cgi?id=39050

Reviewed by Darin Adler.

* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::placeBoxesHorizontally): Added a GlyphOverflowAndFallbackFontsMap
parameter. Read glyph overflow from the map.
(WebCore::InlineFlowBox::computeLogicalBoxHeights): Added a GlyphOverflowAndFallbackFontsMap
parameter. Read fallback fonts from the map.
(WebCore::InlineFlowBox::computeVerticalOverflow): Added a GlyphOverflowAndFallbackFontsMap
parameter. Read glyph overflow from the map.
* rendering/InlineFlowBox.h:
* rendering/InlineTextBox.cpp: Removed setFallbackFonts(), fallbackFonts(), setGlyphOverflow(),
and glyphOverflow(). Removed s_glyphOverflowAndFallbackFontsMap.
* rendering/InlineTextBox.h:
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeHorizontalPositionsForLine): Added a GlyphOverflowAndFallbackFontsMap
parameter. Write fallback fonts and glyph overflow into the map.
(WebCore::RenderBlock::computeVerticalPositionsForLine): Added a GlyphOverflowAndFallbackFontsMap
parameter. Pass it down to verticallyAlignBoxes().
(WebCore::RenderBlock::layoutInlineChildren): Create a GlyphOverflowAndFallbackFontsMap on the
stack and pass it down to computeHorizontalPositionsForLine(), computeVerticalPositionsForLine(),
and verticallyAlignBoxes().
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::verticallyAlignBoxes): Added a GlyphOverflowAndFallbackFontsMap parameter.
Pass it down to computeLogicalBoxHeights() and computeVerticalOverflow().
* rendering/RootInlineBox.h:
* rendering/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::layoutInlineBoxes): Updated.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-16 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 17 May 2010 01:02:33 +0000 (01:02 +0000)]
2010-05-16  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        Reduce the size of FunctionExecutable
        https://bugs.webkit.org/show_bug.cgi?id=39180

        Change m_numVariables from a size_t to 31 bits in a bitfield,
        packed with another bit for m_forceUsesArguments (which in turn
        get packed with the base class).

        Reduces the size of FunctionExecutable from 160 to 152 bytes.

        * runtime/Executable.h:
        (JSC::FunctionExecutable::variableCount):
        (JSC::FunctionExecutable::FunctionExecutable):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-16 Tony Chang <tony@chromium.org>
tony@chromium.org [Mon, 17 May 2010 01:00:28 +0000 (01:00 +0000)]
2010-05-16  Tony Chang  <tony@chromium.org>

        Not reviewed, fixing layout test.

        Add tiger and SL results.  Remove Inspect Element from leopard results.

        * platform/mac-leopard/editing/spelling/context-menu-suggestions-expected.txt:
        * platform/mac-snowleopard/editing/spelling/context-menu-suggestions-expected.txt: Added.
        * platform/mac-tiger/editing/spelling/context-menu-suggestions-expected.txt: Added.
2010-05-16  Tony Chang  <tony@chromium.org>

        Not reviewed, fixing layout test.

        Don't output Inspect Element since this is not enabled on the bots,
        but most developers probably have it installed.

        * DumpRenderTree/mac/EventSendingController.mm:
        (-[EventSendingController contextClick:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-12 Tony Chang <tony@chromium.org>
tony@chromium.org [Mon, 17 May 2010 00:26:32 +0000 (00:26 +0000)]
2010-05-12  Tony Chang  <tony@chromium.org>

        Reviewed by Darin Adler.

        Spellcheck disabling does not disable context menu
        https://bugs.webkit.org/show_bug.cgi?id=25639

        * editing/spelling/context-menu-suggestions.html: Added.
        * platform/chromium/test_expectations.txt:
        * platform/gtk/Skipped:
        * platform/mac-leopard/editing/spelling/context-menu-suggestions-expected.txt: Added.
        * platform/qt/Skipped:
        * platform/win/Skipped:
2010-05-12  Tony Chang  <tony@chromium.org>

        Reviewed by Darin Adler.

        Spellcheck disabling does not disable context menu
        https://bugs.webkit.org/show_bug.cgi?id=25639

        Test: editing/spelling/context-menu-suggestions.html

        * platform/ContextMenu.cpp:
        (WebCore::ContextMenu::populate):
2010-05-12  Tony Chang  <tony@chromium.org>

        Reviewed by Darin Adler.

        Spellcheck disabling does not disable context menu
        https://bugs.webkit.org/show_bug.cgi?id=25639

        * DumpRenderTree/mac/EventSendingController.mm:
        (+[EventSendingController isSelectorExcludedFromWebScript:]):
        (+[EventSendingController webScriptNameForSelector:]):
        (-[EventSendingController contextClick:]): add a bool parameter that
              when true, dumps the context menu items to stdout.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agohttps://bugs.webkit.org/show_bug.cgi?id=39190
weinig@apple.com [Sun, 16 May 2010 23:42:41 +0000 (23:42 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=39190
Shave a word off of GlyphPageTreeNode
<rdar://problem/7990428>

Reviewed by Dan Bernstein.

* platform/graphics/GlyphPageTreeNode.h:
(WebCore::GlyphPageTreeNode::GlyphPageTreeNode):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-16 Andreas Kling <andreas.kling@nokia.com>
eric@webkit.org [Sun, 16 May 2010 21:46:10 +0000 (21:46 +0000)]
2010-05-16  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Add a test to verify proper handling of invalid arguments to getImageData().
        Updated old putImageData() test with correct expectations.

        https://bugs.webkit.org/show_bug.cgi?id=39175

        Spec link:
        http://www.whatwg.org/specs/web-apps/current-work/#pixel-manipulation

        * fast/canvas/canvas-getImageData-invalid-expected.txt: Added.
        * fast/canvas/canvas-getImageData-invalid.html: Added.
        * fast/canvas/canvas-putImageData-expected.txt:
        * fast/canvas/canvas-putImageData.js:
        * fast/canvas/script-tests/canvas-getImageData-invalid.js: Added.
2010-05-16  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Properly handle invalid arguments to CanvasRenderingContext2D's getImageData() and putImageData().
        Both should throw NOT_SUPPORTED_ERR when called with nonfinite arguments.
        getImageData() should throw INDEX_SIZE_ERR if either width or height is 0.

        https://bugs.webkit.org/show_bug.cgi?id=39175

        Spec link:
        http://www.whatwg.org/specs/web-apps/current-work/#pixel-manipulation

        Test: fast/canvas/canvas-getImageData-invalid.html

        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::createImageData):
        (WebCore::CanvasRenderingContext2D::getImageData):
        (WebCore::CanvasRenderingContext2D::putImageData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-16 Andreas Kling <andreas.kling@nokia.com>
eric@webkit.org [Sun, 16 May 2010 21:08:53 +0000 (21:08 +0000)]
2010-05-16  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Add a test to verify that Canvas's toDataURL() is case insensitive wrt the mimeType argument.
        https://bugs.webkit.org/show_bug.cgi?id=39153

        Spec link:
        http://www.whatwg.org/specs/web-apps/current-work/#dom-canvas-todataurl

        * fast/canvas/canvas-toDataURL-case-insensitive-mimetype-expected.txt: Added.
        * fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html: Added.
        * fast/canvas/script-tests/canvas-toDataURL-case-insensitive-mimetype.js: Added.
        (tryMimeType):
        * platform/gtk/fast/canvas/canvas-toDataURL-case-insensitive-mimetype-expected.txt: Added.
2010-05-16  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Canvas's toDataURL() should be case insensitive wrt the mimeType argument.
        https://bugs.webkit.org/show_bug.cgi?id=39153

        Spec link:
        http://www.whatwg.org/specs/web-apps/current-work/#dom-canvas-todataurl

        Test: fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html

        * dom/CanvasSurface.cpp:
        (WebCore::CanvasSurface::toDataURL):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Fix FrameLoaderClientQt.cpp to print relative filename paths correctly.
robert@webkit.org [Sun, 16 May 2010 20:13:10 +0000 (20:13 +0000)]
[Qt] Fix FrameLoaderClientQt.cpp to print relative filename paths correctly.

2010-05-16  Robert Hogan  <robert@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        Fix FrameLoaderClientQt.cpp to print relative filename paths correctly.

        Move qt_* functions in FrameLoaderClientQt, EditorClientQt, and NotificationPresenterClientQt
        to DumpRenderTreeSupportQt. Create new functions to replace them in DumpRenderTreeSupportQt.
        Support for the old function names is retained until confirmed that no one uses them outside
        QtWebKit.

        https://bugs.webkit.org/show_bug.cgi?id=38867

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::dumpFrameLoader):
        (DumpRenderTreeSupportQt::dumpResourceLoadCallbacks):
        (DumpRenderTreeSupportQt::dumpResourceLoadCallbacksPath):
        (DumpRenderTreeSupportQt::setWillSendRequestReturnsNullOnRedirect):
        (DumpRenderTreeSupportQt::setWillSendRequestReturnsNull):
        (DumpRenderTreeSupportQt::setWillSendRequestClearHeaders):
        (DumpRenderTreeSupportQt::dumpEditingCallbacks):
        (DumpRenderTreeSupportQt::dumpSetAcceptsEditing):
        (DumpRenderTreeSupportQt::dumpNotification):
        (qt_dump_frame_loader):
        (qt_dump_resource_load_callbacks):
        (qt_dump_resource_load_callbacks_path):
        (qt_set_will_send_request_returns_null_on_redirect):
        (qt_set_will_send_request_returns_null):
        (qt_set_will_send_request_clear_headers):
        (qt_dump_editing_callbacks):
        (qt_dump_set_accepts_editing):
        (qt_dump_notification):
        * WebCoreSupport/DumpRenderTreeSupportQt.h:
        * WebCoreSupport/EditorClientQt.cpp:
        * WebCoreSupport/EditorClientQt.h:
        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (drtDescriptionSuitableForTestResult):
        * WebCoreSupport/FrameLoaderClientQt.h:
        * WebCoreSupport/NotificationPresenterClientQt.cpp:
        * WebCoreSupport/NotificationPresenterClientQt.h:

        Update Qt DRT to use frame loader, editor client and notificaiton presenter
        functions in DumpRenderTreeSupportQt.

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::DumpRenderTree::open):
        (WebCore::DumpRenderTree::dump):
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::LayoutTestController):
        (LayoutTestController::reset):
        (LayoutTestController::dumpEditingCallbacks):
        (LayoutTestController::dumpFrameLoadCallbacks):
        (LayoutTestController::dumpResourceLoadCallbacks):
        (LayoutTestController::setWillSendRequestReturnsNullOnRedirect):
        (LayoutTestController::setWillSendRequestReturnsNull):
        (LayoutTestController::setWillSendRequestClearHeader):

        Unskip fast/loader/main-document-url-for-non-http-loads.html

        * platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-16 Mike Belshe <mbelshe@chromium.org>
eric@webkit.org [Sun, 16 May 2010 18:01:52 +0000 (18:01 +0000)]
2010-05-16  Mike Belshe  <mbelshe@chromium.org>

        Reviewed by Dimitri Glazkov.

        Add a flag to the ResourceResponse for tracking if a request was
        fetched via the TLS/Next-Protocol-Negotiation mechanism.

        Also cleaned up the style in ResourceResponse to group the flags
        together (and alphabetically) and hopefully improve readability of
        the file.

        https://bugs.webkit.org/show_bug.cgi?id=39078

        * public/WebURLResponse.h:
        * src/WebURLResponse.cpp:
        (WebKit::WebURLResponse::wasNpnNegotiated):
        (WebKit::WebURLResponse::setWasNpnNegotiated):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-16 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sun, 16 May 2010 17:50:21 +0000 (17:50 +0000)]
2010-05-16  Eric Seidel  <eric@webkit.org>

        Unreviewed, rolling out r59571.
        http://trac.webkit.org/changeset/59571
        https://bugs.webkit.org/show_bug.cgi?id=39054

        Broke Cr Win, but we didn't notice immediately due to
        https://bugs.webkit.org/show_bug.cgi?id=38926.  It's possible
        that this didn't actually break Cr Win, but rather that bug
        38926 necessitates a clean compile after this and sucessive
        checkins only produced a partial recompile and thus failed to
        build.

        * DEPS:
        * WebKit.gyp:
        * features.gypi:
2010-05-16  Eric Seidel  <eric@webkit.org>

        Unreviewed, rolling out r59571.
        http://trac.webkit.org/changeset/59571
        https://bugs.webkit.org/show_bug.cgi?id=39054

        Broke Cr Win, but we didn't notice immediately due to
        https://bugs.webkit.org/show_bug.cgi?id=38926.  It's possible
        that this didn't actually break Cr Win, but rather that bug
        38926 necessitates a clean compile after this and sucessive
        checkins only produced a partial recompile and thus failed to
        build.

        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::canvas):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-16 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sun, 16 May 2010 17:24:27 +0000 (17:24 +0000)]
2010-05-16  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Anders Carlsson.

        Shrink SimpleFontData
        https://bugs.webkit.org/show_bug.cgi?id=39179

        Change SimpleFontData to have a pointer to the m_glyphToBoundsMap,
        and to allocate this lazily. This reduces the size of the class from
        5632 to 1536 bytes.

        * platform/graphics/SimpleFontData.h:
        (WebCore::SimpleFontData::boundsForGlyph):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-15 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sun, 16 May 2010 15:43:03 +0000 (15:43 +0000)]
2010-05-15  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Maciej Stachowiak.

        Reduce the size of CachedResource
        https://bugs.webkit.org/show_bug.cgi?id=39171

        Make protected data members of CachedResource private, to allow for
        easier rearrangement, and hide the fact that enums are in bitfields.

        Rearrange the data members of CachedResource to save 32 bytes per instance
        in 64-bit. Also modernized the constructor code.

        * loader/CachedCSSStyleSheet.cpp:
        (WebCore::CachedCSSStyleSheet::didAddClient):
        (WebCore::CachedCSSStyleSheet::data):
        (WebCore::CachedCSSStyleSheet::checkNotify):
        (WebCore::CachedCSSStyleSheet::error):
        * loader/CachedFont.cpp:
        (WebCore::CachedFont::load):
        (WebCore::CachedFont::didAddClient):
        (WebCore::CachedFont::data):
        (WebCore::CachedFont::ensureCustomFontData):
        (WebCore::CachedFont::ensureSVGFontData):
        (WebCore::CachedFont::checkNotify):
        (WebCore::CachedFont::error):
        * loader/CachedImage.cpp:
        (WebCore::CachedImage::CachedImage):
        (WebCore::CachedImage::load):
        (WebCore::CachedImage::didAddClient):
        (WebCore::CachedImage::allClientsRemoved):
        (WebCore::CachedImage::image):
        (WebCore::CachedImage::data):
        (WebCore::CachedImage::error):
        (WebCore::CachedImage::checkNotify):
        (WebCore::CachedImage::destroyDecodedData):
        * loader/CachedImage.h:
        (WebCore::CachedImage::stillNeedsLoad):
        * loader/CachedResource.cpp:
        (WebCore::CachedResource::CachedResource):
        * loader/CachedResource.h:
        (WebCore::CachedResource::type):
        (WebCore::CachedResource::preloadResult):
        (WebCore::CachedResource::status):
        (WebCore::CachedResource::setStatus):
        (WebCore::CachedResource::isLoaded):
        (WebCore::CachedResource::isLoading):
        (WebCore::CachedResource::setErrorOccurred):
        * loader/CachedScript.cpp:
        (WebCore::CachedScript::didAddClient):
        (WebCore::CachedScript::data):
        (WebCore::CachedScript::checkNotify):
        (WebCore::CachedScript::error):
        * loader/CachedXSLStyleSheet.cpp:
        (WebCore::CachedXSLStyleSheet::didAddClient):
        (WebCore::CachedXSLStyleSheet::data):
        (WebCore::CachedXSLStyleSheet::checkNotify):
        (WebCore::CachedXSLStyleSheet::error):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-16 Sheriff Bot <webkit.review.bot@gmail.com>
eric@webkit.org [Sun, 16 May 2010 13:44:25 +0000 (13:44 +0000)]
2010-05-16  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r59574.
        http://trac.webkit.org/changeset/59574
        https://bugs.webkit.org/show_bug.cgi?id=39176

        Supposedly broke cr-win, but the errors seems somewhat
        unrelated (Requested by abarth on #webkit).

        * platform/network/chromium/ResourceResponse.h:
        (WebCore::ResourceResponse::ResourceResponse):
        (WebCore::ResourceResponse::setSecurityInfo):
        (WebCore::ResourceResponse::isContentFiltered):
        (WebCore::ResourceResponse::setIsContentFiltered):
        (WebCore::ResourceResponse::setAppCacheID):
        (WebCore::ResourceResponse::setAppCacheManifestURL):
        (WebCore::ResourceResponse::setWasFetchedViaSPDY):
        (WebCore::ResourceResponse::setIsMultipartPayload):
        (WebCore::ResourceResponse::setResponseTime):
2010-05-16  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r59574.
        http://trac.webkit.org/changeset/59574
        https://bugs.webkit.org/show_bug.cgi?id=39176

        Supposedly broke cr-win, but the errors seems somewhat
        unrelated (Requested by abarth on #webkit).

        * public/WebURLResponse.h:
        * src/WebURLResponse.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-16 Mike Belshe <mbelshe@chromium.org>
eric@webkit.org [Sun, 16 May 2010 08:58:17 +0000 (08:58 +0000)]
2010-05-16  Mike Belshe  <mbelshe@chromium.org>

        Reviewed by Dimitri Glazkov.

        Add a flag to the ResourceResponse for tracking if a request was
        fetched via the TLS/Next-Protocol-Negotiation mechanism.

        Also cleaned up the style in ResourceResponse to group the flags
        together (and alphabetically) and hopefully improve readability of
        the file.

        https://bugs.webkit.org/show_bug.cgi?id=39078

        * public/WebURLResponse.h:
        * src/WebURLResponse.cpp:
        (WebKit::WebURLResponse::wasNpnNegotiated):
        (WebKit::WebURLResponse::setWasNpnNegotiated):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt]Unskip security/set-form-autocomplete-attribute.html
robert@webkit.org [Sun, 16 May 2010 08:55:53 +0000 (08:55 +0000)]
[Qt]Unskip security/set-form-autocomplete-attribute.html

2010-05-16  Robert Hogan  <robert@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt]Unskip security/set-form-autocomplete-attribute.html

        Add support for layoutTestController.elementDoesAutoCompleteForElementWithId().

        https://bugs.webkit.org/show_bug.cgi?id=38859

        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::elementDoesAutoCompleteForElementWithId):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:
        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::elementDoesAutoCompleteForElementWithId):
        * WebCoreSupport/DumpRenderTreeSupportQt.h:
        * platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Prospective Qt/Mac build fix.
hausmann@webkit.org [Sun, 16 May 2010 08:49:45 +0000 (08:49 +0000)]
[Qt] Prospective Qt/Mac build fix.

The friend declaration of QGraphicsWidget confuses gcc and thinks that it's an implicit
forward declaration, moving the class into the WebCore namespace (WebCore::QGraphicsWidget).

The declaration seems useless as no method of QGraphicsWidget is going to call anything
in this class.

* WebCoreSupport/PageClientQt.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-16 Kent Tamura <tkent@chromium.org>
eric@webkit.org [Sun, 16 May 2010 08:47:14 +0000 (08:47 +0000)]
2010-05-16  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        [DRT/Chromium] Fix repaint, WebGL, textarea tests
        https://bugs.webkit.org/show_bug.cgi?id=39054

        * DEPS: Update to Chromium r47248 to use a fix for CommandLine assertion
          and textAreaResizeCorner.png
        * WebKit.gyp: Add textAreaResizeCorner.png as a Mac resource
        * features.gypi: Enable ENABLE_3D_CANVAS.
2010-05-16  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        [DRT/Chromium] Fix repaint, WebGL, textarea tests
        https://bugs.webkit.org/show_bug.cgi?id=39054

        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::canvas): Remove m_paintRect initialization in canvas().
         This line updated m_paintRect unexpectedly during paintRect().
         We don't need to initialize m_paintRect because show() does it.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-16 Dan Bernstein <mitz@apple.com>
eric@webkit.org [Sun, 16 May 2010 08:10:09 +0000 (08:10 +0000)]
2010-05-16  Dan Bernstein  <mitz@apple.com>

        Reviewed by Darin Adler.

        Scalar types allocated on the heap due to misuse of DEFINE_STATIC_LOCAL
        https://bugs.webkit.org/show_bug.cgi?id=39086

        Use global variables directly.

        * bindings/v8/ScriptCallStack.cpp:
        (WebCore::ScriptCallStack::createUtilityContext):
        * platform/ScrollView.cpp:
        (WebCore::ScrollView::wheelEvent):
        * platform/graphics/mac/ComplexTextController.cpp:
        (WebCore::shouldUseATSUIAPI):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-16 Andreas Kling <andreas.kling@nokia.com>
eric@webkit.org [Sun, 16 May 2010 07:58:48 +0000 (07:58 +0000)]
2010-05-16  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Add a test to check proper return value (null) from invalid canvas getContext() calls.

        https://bugs.webkit.org/show_bug.cgi?id=39150

        * fast/canvas/canvas-getContext-invalid-expected.txt: Added.
        * fast/canvas/canvas-getContext-invalid.html: Added.
        * fast/canvas/script-tests/canvas-getContext-invalid.js: Added.
2010-05-16  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Canvas's getContext() must return null when called with an invalid/unsupported parameter.
        (HTML5 spec 4.8.11): http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#dom-canvas-getcontext

        https://bugs.webkit.org/show_bug.cgi?id=39150

        Test: fast/canvas/canvas-getContext-invalid.html

        * bindings/js/JSHTMLCanvasElementCustom.cpp:
        (WebCore::JSHTMLCanvasElement::getContext):
        * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
        (WebCore::V8HTMLCanvasElement::getContextCallback):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-16 Sergio Villar Senin <svillar@igalia.com>
eric@webkit.org [Sun, 16 May 2010 07:44:35 +0000 (07:44 +0000)]
2010-05-16  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        Removed 5 http/history tests from Skipped file

        [GTK] Improve reporting of frame loader callbacks in DRT
        https://bugs.webkit.org/show_bug.cgi?id=36454

        * platform/gtk/Skipped:
2010-05-16  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Improve reporting of frame loader callbacks in DRT
        https://bugs.webkit.org/show_bug.cgi?id=36454

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (webViewLoadStatusNotified):
        (createWebView): added connection to notify::load-status and
        signal callback

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-15 Sheriff Bot <webkit.review.bot@gmail.com>
eric@webkit.org [Sun, 16 May 2010 06:57:00 +0000 (06:57 +0000)]
2010-05-15  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r59565.
        http://trac.webkit.org/changeset/59565
        https://bugs.webkit.org/show_bug.cgi?id=39173

        Broke GTK (Requested by abarth on #webkit).

        * fast/canvas/canvas-toDataURL-case-insensitive-mimetype-expected.txt: Removed.
        * fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html: Removed.
        * fast/canvas/script-tests/canvas-toDataURL-case-insensitive-mimetype.js: Removed.
2010-05-15  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r59565.
        http://trac.webkit.org/changeset/59565
        https://bugs.webkit.org/show_bug.cgi?id=39173

        Broke GTK (Requested by abarth on #webkit).

        * dom/CanvasSurface.cpp:
        (WebCore::CanvasSurface::toDataURL):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-15 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Sun, 16 May 2010 03:50:17 +0000 (03:50 +0000)]
2010-05-15  Daniel Bates  <dbates@rim.com>

        Reviewed by Chris Jerdonek.

        https://bugs.webkit.org/show_bug.cgi?id=39170

        Add function parseSvnPropertyValue to parse single-line and multi-line
        property values of an SVN property change.

        * Scripts/VCSUtils.pm:
            Added function parseSvnPropertyValue. We will use this as part of
            Bug #38885 <https://bugs.webkit.org/show_bug.cgi?id=38885>.
        * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-15 Andreas Kling <andreas.kling@nokia.com>
eric@webkit.org [Sun, 16 May 2010 03:15:25 +0000 (03:15 +0000)]
2010-05-15  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Add a test to verify that Canvas's toDataURL() is case insensitive wrt the mimeType argument.
        https://bugs.webkit.org/show_bug.cgi?id=39153

        Spec link:
        http://www.whatwg.org/specs/web-apps/current-work/#dom-canvas-todataurl

        * fast/canvas/canvas-toDataURL-case-insensitive-mimetype-expected.txt: Added.
        * fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html: Added.
        * fast/canvas/script-tests/canvas-toDataURL-case-insensitive-mimetype.js: Added.
        (tryMimeType):
2010-05-15  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Canvas's toDataURL() should be case insensitive wrt the mimeType argument.
        https://bugs.webkit.org/show_bug.cgi?id=39153

        Spec link:
        http://www.whatwg.org/specs/web-apps/current-work/#dom-canvas-todataurl

        Test: fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html

        * dom/CanvasSurface.cpp:
        (WebCore::CanvasSurface::toDataURL):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-15 Anders Bakken <agbakken@gmail.com>
eric@webkit.org [Sun, 16 May 2010 03:03:41 +0000 (03:03 +0000)]
2010-05-15  Anders Bakken  <agbakken@gmail.com>

        Reviewed by Kenneth Rohde Christiansen.

        QObject::objectName() returns a QString and QtField::name()
        creates a temporary QByteArray object and returns constData() from it.
        This is not safe.

        This patch changes the signature of the function to return a
        QByteArray instead of const char *.

        https://bugs.webkit.org/show_bug.cgi?id=39010

        * bridge/qt/qt_instance.cpp:
        (JSC::Bindings::QtInstance::getPropertyNames):
        (JSC::Bindings::QtField::name):
        * bridge/qt/qt_runtime.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-15 Anders Bakken <agbakken@gmail.com>
eric@webkit.org [Sun, 16 May 2010 02:52:23 +0000 (02:52 +0000)]
2010-05-15  Anders Bakken  <agbakken@gmail.com>

        Reviewed by Kenneth Rohde Christiansen.

        Don't unnecessarily copy data when searching for methods in QtClass.

        [Qt] JSValue QtClass::fallbackObject can be optimized
        https://bugs.webkit.org/show_bug.cgi?id=37684

        * bridge/qt/qt_class.cpp:
        (JSC::Bindings::QtClass::fallbackObject):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-15 Anders Bakken <agbakken@gmail.com>
eric@webkit.org [Sun, 16 May 2010 02:34:08 +0000 (02:34 +0000)]
2010-05-15  Anders Bakken  <agbakken@gmail.com>

        Reviewed by Kenneth Rohde Christiansen.

        Identifier::ascii() is not threadsafe and shouldn't be used for
        converting to and from QString/QByteArray.

        https://bugs.webkit.org/show_bug.cgi?id=39009

        * bridge/qt/qt_class.cpp:
        (JSC::Bindings::QtClass::fallbackObject):
        (JSC::Bindings::QtClass::fieldNamed):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-15 Chang Shu <chang.shu@nokia.com>
eric@webkit.org [Sun, 16 May 2010 02:22:51 +0000 (02:22 +0000)]
2010-05-15  Chang Shu  <chang.shu@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Based on the spec and Philip Taylor's test suite, createImageData() should throw
        an INDEX_SIZE_ERR exception if either the sw or sh arguments are zero.
        The link to the spec:
        http://philip.html5.org/tests/canvas/suite/tests/spec.html#testrefs.2d.imageData.getcreate.zero

        https://bugs.webkit.org/show_bug.cgi?id=39166

        The complete test suite is in the process of checking in.
        https://bugs.webkit.org/show_bug.cgi?id=20553

        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::createImageData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-15 Darin Fisher <darin@chromium.org>
eric@webkit.org [Sun, 16 May 2010 02:08:53 +0000 (02:08 +0000)]
2010-05-15  Darin Fisher  <darin@chromium.org>

        Reviewed by Adam Barth.

        [chromium] Expose element accessor on WebPluginContainer
        https://bugs.webkit.org/show_bug.cgi?id=39152

        * public/WebPluginContainer.h:
        * src/WebPluginContainerImpl.cpp:
        (WebKit::WebPluginContainerImpl::element):
        * src/WebPluginContainerImpl.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-15 Adam Barth <abarth@webkit.org>
eric@webkit.org [Sun, 16 May 2010 01:43:59 +0000 (01:43 +0000)]
2010-05-15  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        XMLHttpRequest.getResponseHeader doesn't need to be custom
        https://bugs.webkit.org/show_bug.cgi?id=39125

        I don't see any reason this method needs to be custom.  No new tests
        because there's no behavior change.

        * bindings/js/JSXMLHttpRequestCustom.cpp:
        * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
        * xml/XMLHttpRequest.idl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59559 268f45cc-cd09-0410-ab3c-d52691b4dbfc