WebKit.git
7 years agoWeb Inspector: more robust treeoutline.findTreeElement
commit-queue@webkit.org [Wed, 5 Dec 2012 17:45:56 +0000 (17:45 +0000)]
Web Inspector: more robust treeoutline.findTreeElement
https://bugs.webkit.org/show_bug.cgi?id=103911

Patch by John J. Barton <johnjbarton@chromium.org> on 2012-12-05
Reviewed by Vsevolod Vlasov.

Non-recursive algorithm to populate the treeoutline given an DOMNode
as representedObject. Walk up the parents from the desired object
until we find one that is currently represented in the treeoutline
cache. Then walk down, putting children in the cache until we get
to the desired object again.
With Pavel Feldeman <pfeldman@chromium.org>

No new tests, refactoring, no new function

       * inspector/front-end/treeoutline.js:
(TreeOutline.prototype.findTreeElement):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][GTK] List value response headers are not handled in RespourceResponse (libsoup...
commit-queue@webkit.org [Wed, 5 Dec 2012 17:44:40 +0000 (17:44 +0000)]
[EFL][GTK] List value response headers are not handled in RespourceResponse (libsoup specific)
https://bugs.webkit.org/show_bug.cgi?id=95181

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-12-05
Reviewed by Martin Robinson.

Source/WebCore:

When list-value response headers are received, they are handled as single
value headers. This patch fixes incorrect behavior. New test was added to
verify list-value header handling.

Test: http/tests/xmlhttprequest/xmlhttprequest-test-custom-headers.html

* platform/network/soup/ResourceResponseSoup.cpp:
(WebCore::ResourceResponse::updateFromSoupMessage):

LayoutTests:

Added test that checks if list-value response headers handled correctly.

* http/tests/xmlhttprequest/resources/custom-headers.php: Added.
* http/tests/xmlhttprequest/xmlhttprequest-test-custom-headers-expected.txt: Added.
* http/tests/xmlhttprequest/xmlhttprequest-test-custom-headers.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Introduce WebKit-EFL to Assistive Technologies - new baselines
commit-queue@webkit.org [Wed, 5 Dec 2012 17:42:27 +0000 (17:42 +0000)]
[EFL][WK2] Introduce WebKit-EFL to Assistive Technologies - new baselines
https://bugs.webkit.org/show_bug.cgi?id=104000

Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-12-05
Reviewed by Chris Fleizach.

Added EFL baselines for accessibility/table-cells.html and accessibility/table-cell-spans.html.

* platform/efl-wk2/TestExpectations:
* platform/efl-wk2/accessibility/table-cell-spans-expected.txt: Added.
* platform/efl-wk2/accessibility/table-cells-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Don't include error message text in the editor buffer.
pfeldman@chromium.org [Wed, 5 Dec 2012 17:41:01 +0000 (17:41 +0000)]
Web Inspector: Don't include error message text in the editor buffer.
https://bugs.webkit.org/show_bug.cgi?id=103932

Reviewed by Alexander Pavlov.

Source/WebCore:

Skip entire decoration content when collecting dirty regions.

* inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.prototype._collectLinesFromDOM):

LayoutTests:

* inspector/editor/editor-test.js:
(initialize_EditorTests.InspectorTest.getLineElement):
(initialize_EditorTests):
* inspector/editor/text-editor-type-over-decoration-expected.txt: Added.
* inspector/editor/text-editor-type-over-decoration.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, adding my new email address to watchlist for blackberry.
yoli@rim.com [Wed, 5 Dec 2012 17:34:04 +0000 (17:34 +0000)]
Unreviewed, adding my new email address to watchlist for blackberry.

 * Scripts/webkitpy/common/config/watchlist:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Wed, 5 Dec 2012 17:26:43 +0000 (17:26 +0000)]
Unreviewed GTK gardening.

Skipping back the Media Stream layout tests, they're not behaving well.
Removing a few failure expectations for tests that are passing.

* platform/gtk/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] meta viewport pages are rendered at a bad initial scale
zhajiang@rim.com [Wed, 5 Dec 2012 17:25:15 +0000 (17:25 +0000)]
[BlackBerry] meta viewport pages are rendered at a bad initial scale
https://bugs.webkit.org/show_bug.cgi?id=104122

Patch by Jacky Jiang <zhajiang@rim.com>.
Reviewed by Rob Buis.
Internally reviewed by Arvid Nilsson.

PR: 240378
Many websites are rendered at a very bad initial scale because they
both specify meta viewport tag and have large width elements. In such
a case we will think the meta viewport tag is broken if the width of
any element is larger than the calculated layout viewport width.
The fix to this is straightforward that we will zoom the page to fit
the screen to have better user experience instead of respecting the
meta viewport. This can fix the issue on the websites such as
www.travelpod.com, www.forbes.com, interfacelift.com, www.sky.com,
raphaeljs.com and so on.
If non-empty m_userViewportArguments is applied, then we will force to
respect the viewport arguments. In this way we will restrict the fix to
browser only.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPagePrivate::respectViewport):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::initialScale):
(BlackBerry::WebKit::WebPagePrivate::maximumScale):
(BlackBerry::WebKit::WebPagePrivate::dispatchViewportPropertiesDidChange):
* Api/WebPage_p.h:
(BlackBerry::WebKit::WebPagePrivate::isUserScalable):
(WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::minimumScale):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium rebaselines.
eae@chromium.org [Wed, 5 Dec 2012 17:22:23 +0000 (17:22 +0000)]
Unreviewed chromium rebaselines.

* platform/chromium-mac/plugins/npp-set-window-called-during-destruction-expected.txt: Added.
* platform/chromium-win-xp/css3/flexbox: Added.
* platform/chromium-win-xp/css3/flexbox/repaint-column-reverse-expected.png: Added.
* platform/chromium-win/css3/filters/effect-reference-hw-expected.png:
* platform/chromium-win/plugins/npp-set-window-called-during-destruction-expected.txt:
* platform/chromium/plugins/npp-set-window-called-during-destruction-expected.txt: Removed.
* platform/win-7sp0/plugins: Added.
* platform/win-7sp0/plugins/npp-set-window-called-during-destruction-expected.txt: Added.
* platform/win/plugins/npp-set-window-called-during-destruction-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Unreviewed gardening.
thiago.santos@intel.com [Wed, 5 Dec 2012 17:20:54 +0000 (17:20 +0000)]
[EFL] Unreviewed gardening.

* platform/efl-wk2/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Gtk] navigator.plugins contains too many plugin entries. First one are garbages
commit-queue@webkit.org [Wed, 5 Dec 2012 17:09:34 +0000 (17:09 +0000)]
[Gtk] navigator.plugins contains too many plugin entries. First one are garbages
https://bugs.webkit.org/show_bug.cgi?id=102438

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-12-05
Reviewed by Xan Lopez.

Source/WebKit/gtk:

In getPluginInfo, outPlugins is resized to plugins.size and then,
plugins are appended to it. So at the end, outPlugins will be twice
too large, and first half will contain null objects. As outPlugins
size is 0 when calling getPluginInfo, we don't need to resize it.

* WebCoreSupport/PlatformStrategiesGtk.cpp:
(PlatformStrategiesGtk::getPluginInfo):

LayoutTests:

Add a test to check that navigator.plugins only contain valid plugin
objects.

* plugins/navigator-plugins-expected.txt: Added.
* plugins/navigator-plugins.html: Added.
* plugins/script-tests/navigator-plugins.js: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Replace use of ScriptExecutionContext::Task (Part 2)
jsbell@chromium.org [Wed, 5 Dec 2012 17:06:27 +0000 (17:06 +0000)]
IndexedDB: Replace use of ScriptExecutionContext::Task (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=103931

Reviewed by Tony Chang.

Source/WebCore:

Actually drop use of ScriptExecutionContext::Task and remove incorrect usage of
ThreadSafeRefCounted<>. Define a new IDBTransactionBackendImpl::Operation base class
for operations; storage of per-operation data becomes explicit.

No new tests - just a refactor.

* Modules/indexeddb/IDBCallbacks.h: Remove bogus "ThreadSafe"
* Modules/indexeddb/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::CursorIterationOperation::create):
(IDBCursorBackendImpl::CursorIterationOperation):
(WebCore::IDBCursorBackendImpl::CursorIterationOperation::CursorIterationOperation):
(WebCore::IDBCursorBackendImpl::CursorAdvanceOperation::create):
(IDBCursorBackendImpl::CursorAdvanceOperation):
(WebCore::IDBCursorBackendImpl::CursorAdvanceOperation::CursorAdvanceOperation):
(WebCore::IDBCursorBackendImpl::CursorPrefetchIterationOperation::create):
(IDBCursorBackendImpl::CursorPrefetchIterationOperation):
(WebCore::IDBCursorBackendImpl::CursorPrefetchIterationOperation::CursorPrefetchIterationOperation):
(WebCore::IDBCursorBackendImpl::CursorAdvanceOperation::perform):
(WebCore::IDBCursorBackendImpl::CursorIterationOperation::perform):
(WebCore::IDBCursorBackendImpl::CursorPrefetchIterationOperation::perform):
* Modules/indexeddb/IDBCursorBackendInterface.h: Remove bogus "ThreadSafe"
* Modules/indexeddb/IDBDatabase.cpp:
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::CreateObjectStoreOperation::create):
(IDBDatabaseBackendImpl::CreateObjectStoreOperation):
(WebCore::IDBDatabaseBackendImpl::CreateObjectStoreOperation::CreateObjectStoreOperation):
(WebCore::IDBDatabaseBackendImpl::DeleteObjectStoreOperation::create):
(IDBDatabaseBackendImpl::DeleteObjectStoreOperation):
(WebCore::IDBDatabaseBackendImpl::DeleteObjectStoreOperation::DeleteObjectStoreOperation):
(WebCore::IDBDatabaseBackendImpl::VersionChangeOperation::create):
(IDBDatabaseBackendImpl::VersionChangeOperation):
(WebCore::IDBDatabaseBackendImpl::VersionChangeOperation::VersionChangeOperation):
(WebCore::IDBDatabaseBackendImpl::CreateObjectStoreAbortOperation::create):
(IDBDatabaseBackendImpl::CreateObjectStoreAbortOperation):
(WebCore::IDBDatabaseBackendImpl::CreateObjectStoreAbortOperation::CreateObjectStoreAbortOperation):
(WebCore::IDBDatabaseBackendImpl::DeleteObjectStoreAbortOperation::create):
(IDBDatabaseBackendImpl::DeleteObjectStoreAbortOperation):
(WebCore::IDBDatabaseBackendImpl::DeleteObjectStoreAbortOperation::DeleteObjectStoreAbortOperation):
(WebCore::IDBDatabaseBackendImpl::VersionChangeAbortOperation::create):
(IDBDatabaseBackendImpl::VersionChangeAbortOperation):
(WebCore::IDBDatabaseBackendImpl::VersionChangeAbortOperation::VersionChangeAbortOperation):
(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::CreateObjectStoreOperation::perform):
(WebCore::IDBDatabaseBackendImpl::deleteObjectStore):
(WebCore::IDBDatabaseBackendImpl::DeleteObjectStoreOperation::perform):
(WebCore::IDBDatabaseBackendImpl::VersionChangeOperation::perform):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):
(WebCore::IDBDatabaseBackendImpl::CreateObjectStoreAbortOperation::perform):
(WebCore::IDBDatabaseBackendImpl::DeleteObjectStoreAbortOperation::perform):
(WebCore::IDBDatabaseBackendImpl::VersionChangeAbortOperation::perform):
* Modules/indexeddb/IDBDatabaseBackendInterface.h: Remove bogus "ThreadSafe"
* Modules/indexeddb/IDBDatabaseCallbacks.h: Remove bogus "ThreadSafe"
* Modules/indexeddb/IDBFactoryBackendImpl.cpp:
* Modules/indexeddb/IDBFactoryBackendInterface.h: Remove bogus "ThreadSafe"
* Modules/indexeddb/IDBIndexBackendImpl.cpp:
(WebCore::IDBIndexBackendImpl::OpenIndexCursorOperation::create):
(IDBIndexBackendImpl::OpenIndexCursorOperation):
(WebCore::IDBIndexBackendImpl::OpenIndexCursorOperation::OpenIndexCursorOperation):
(WebCore::IDBIndexBackendImpl::IndexCountOperation::create):
(IDBIndexBackendImpl::IndexCountOperation):
(WebCore::IDBIndexBackendImpl::IndexCountOperation::IndexCountOperation):
(WebCore::IDBIndexBackendImpl::IndexReferencedValueRetrievalOperation::create):
(IDBIndexBackendImpl::IndexReferencedValueRetrievalOperation):
(WebCore::IDBIndexBackendImpl::IndexReferencedValueRetrievalOperation::IndexReferencedValueRetrievalOperation):
(WebCore::IDBIndexBackendImpl::IndexValueRetrievalOperation::create):
(IDBIndexBackendImpl::IndexValueRetrievalOperation):
(WebCore::IDBIndexBackendImpl::IndexValueRetrievalOperation::IndexValueRetrievalOperation):
(WebCore::IDBIndexBackendImpl::OpenIndexCursorOperation::perform):
(WebCore::IDBIndexBackendImpl::openCursor):
(WebCore::IDBIndexBackendImpl::openKeyCursor):
(WebCore::IDBIndexBackendImpl::IndexCountOperation::perform):
(WebCore::IDBIndexBackendImpl::count):
(WebCore::IDBIndexBackendImpl::IndexReferencedValueRetrievalOperation::perform):
(WebCore::IDBIndexBackendImpl::IndexValueRetrievalOperation::perform):
(WebCore::IDBIndexBackendImpl::get):
(WebCore::IDBIndexBackendImpl::getKey):
* Modules/indexeddb/IDBIndexBackendInterface.h: Remove bogus "ThreadSafe"
* Modules/indexeddb/IDBKey.h: Remove bogus "ThreadSafe"
(IDBKey):
* Modules/indexeddb/IDBKeyRange.h: Remove bogus "ThreadSafe"
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreRetrievalOperation::create):
(IDBObjectStoreBackendImpl::ObjectStoreRetrievalOperation):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreRetrievalOperation::ObjectStoreRetrievalOperation):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreStorageOperation::create):
(IDBObjectStoreBackendImpl::ObjectStoreStorageOperation):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreStorageOperation::ObjectStoreStorageOperation):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreIndexesReadyOperation::create):
(IDBObjectStoreBackendImpl::ObjectStoreIndexesReadyOperation):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreIndexesReadyOperation::ObjectStoreIndexesReadyOperation):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreDeletionOperation::create):
(IDBObjectStoreBackendImpl::ObjectStoreDeletionOperation):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreDeletionOperation::ObjectStoreDeletionOperation):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreClearOperation::create):
(IDBObjectStoreBackendImpl::ObjectStoreClearOperation):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreClearOperation::ObjectStoreClearOperation):
(WebCore::IDBObjectStoreBackendImpl::CreateIndexOperation::create):
(IDBObjectStoreBackendImpl::CreateIndexOperation):
(WebCore::IDBObjectStoreBackendImpl::CreateIndexOperation::CreateIndexOperation):
(WebCore::IDBObjectStoreBackendImpl::DeleteIndexOperation::create):
(IDBObjectStoreBackendImpl::DeleteIndexOperation):
(WebCore::IDBObjectStoreBackendImpl::DeleteIndexOperation::DeleteIndexOperation):
(WebCore::IDBObjectStoreBackendImpl::OpenObjectStoreCursorOperation::create):
(IDBObjectStoreBackendImpl::OpenObjectStoreCursorOperation):
(WebCore::IDBObjectStoreBackendImpl::OpenObjectStoreCursorOperation::OpenObjectStoreCursorOperation):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreCountOperation::create):
(IDBObjectStoreBackendImpl::ObjectStoreCountOperation):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreCountOperation::ObjectStoreCountOperation):
(WebCore::IDBObjectStoreBackendImpl::CreateIndexAbortOperation::create):
(IDBObjectStoreBackendImpl::CreateIndexAbortOperation):
(WebCore::IDBObjectStoreBackendImpl::CreateIndexAbortOperation::CreateIndexAbortOperation):
(WebCore::IDBObjectStoreBackendImpl::DeleteIndexAbortOperation::create):
(IDBObjectStoreBackendImpl::DeleteIndexAbortOperation):
(WebCore::IDBObjectStoreBackendImpl::DeleteIndexAbortOperation::DeleteIndexAbortOperation):
(WebCore::IDBObjectStoreBackendImpl::get):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreRetrievalOperation::perform):
(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::setIndexesReady):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreIndexesReadyOperation::perform):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreStorageOperation::perform):
(WebCore::IDBObjectStoreBackendImpl::deleteFunction):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreDeletionOperation::perform):
(WebCore::IDBObjectStoreBackendImpl::clear):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreClearOperation::perform):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::CreateIndexOperation::perform):
(WebCore::IDBObjectStoreBackendImpl::deleteIndex):
(WebCore::IDBObjectStoreBackendImpl::DeleteIndexOperation::perform):
(WebCore::IDBObjectStoreBackendImpl::openCursor):
(WebCore::IDBObjectStoreBackendImpl::OpenObjectStoreCursorOperation::perform):
(WebCore::IDBObjectStoreBackendImpl::count):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreCountOperation::perform):
(WebCore::IDBObjectStoreBackendImpl::CreateIndexAbortOperation::perform):
(WebCore::IDBObjectStoreBackendImpl::DeleteIndexAbortOperation::perform):
* Modules/indexeddb/IDBObjectStoreBackendInterface.h: Remove bogus "ThreadSafe"
* Modules/indexeddb/IDBRequest.h: Remove bogus "ThreadSafe"
(IDBRequest):
* Modules/indexeddb/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl): Appease RefPtr<> adoption strictness.
(WebCore::IDBTransactionBackendImpl::scheduleTask):
(WebCore::IDBTransactionBackendImpl::abort):
(WebCore::IDBTransactionBackendImpl::taskTimerFired):
* Modules/indexeddb/IDBTransactionBackendImpl.h:
(Operation):
(WebCore::IDBTransactionBackendImpl::Operation::~Operation):
(IDBTransactionBackendImpl):
(WebCore::IDBTransactionBackendImpl::scheduleTask):
* Modules/indexeddb/IDBTransactionBackendInterface.h: Remove bogus "ThreadSafe"

Source/WebKit/chromium:

Now that IDBCallbacks uses real RefPtr<> a mock class needs to be heap allocated.

* tests/IDBAbortOnCorruptTest.cpp:
(WebCore::MockIDBCallbacks::create):
(WebCore::MockIDBCallbacks::MockIDBCallbacks):
(MockIDBCallbacks):
(WebCore::TEST):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoExtend StringHasher to take a stream of characters
jonlee@apple.com [Wed, 5 Dec 2012 17:06:26 +0000 (17:06 +0000)]
Extend StringHasher to take a stream of characters
https://bugs.webkit.org/show_bug.cgi?id=104076
<rdar://problem/12811887>

Reviewed by Darin Adler.

We essentially move computeHash() to a member function of StringHasher. This allows clients of the
hasher to append strings to the general hash, without having to first concatenate the strings.

* wtf/StringHasher.h:
(WTF::StringHasher::addCharacters): Same as computeHash(), except also take into account the possibility
that there is a pending character to hash. If this is the case, we align the word boundary by consuming the
first character in data, adjust the length, move the data pointer forward one, and update the hasher's
pending character state. Also add an early return so that we are guaranteed at least one character in case
we run into this situation.
(WTF::StringHasher::computeHash): Refactor into addCharacters().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] GeolocationClientBB only holding the latest geolocation permission request
commit-queue@webkit.org [Wed, 5 Dec 2012 16:48:22 +0000 (16:48 +0000)]
[BlackBerry] GeolocationClientBB only holding the latest geolocation permission request
https://bugs.webkit.org/show_bug.cgi?id=104123

PR 256089

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-12-05
Reviewed by Yong Li.

Add a mapping between origin URL and it's geolocation object so we could
respond to the correct geolocation when libwebview responds with onPermission
in GeolocationClient.

Using the mapping, we could also prevent requestGeolocation requests from the same origin
to be sent twice. This prevents pages that hold two iframes to the same resource to request
geolocation permission on the same security origin twice.

Tested this by running a page that includes 2 or more iframes that requests geolocation
permission.

* WebCoreSupport/GeolocationClientBlackBerry.cpp:
(GeolocationClientBlackBerry::requestPermission):
(GeolocationClientBlackBerry::cancelPermissionRequest):
(GeolocationClientBlackBerry::onPermission):
* WebCoreSupport/GeolocationClientBlackBerry.h:
(GeolocationClientBlackBerry):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoENABLE(IMAGE_DECODER_DOWN_SAMPLING): Don't swizzle decode down sampled images
noel.gordon@gmail.com [Wed, 5 Dec 2012 16:36:19 +0000 (16:36 +0000)]
ENABLE(IMAGE_DECODER_DOWN_SAMPLING): Don't swizzle decode down sampled images
https://bugs.webkit.org/show_bug.cgi?id=103856

Reviewed by Yong Li.

For ports using ENABLE(IMAGE_DECODER_DOWN_SAMPLING), turbo swizzle decodes provide
no speed-up when the decoded image will be down sampled because the data must pass
through the buffer.setRGBA() slow path. That is not the swizzled path. Instead use
JCS_RGB decodes to clarify the output color space handling in outputScanlines().

No new tests. Covered by existing JPEG decoding tests.

* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::JPEGImageReader::decode): libjpeg-turbo swizzle decodes provides no real
speed-up if the image will be down sampled. Revert to using JCS_RGA in this case.
(WebCore::setPixel): Remove the libjpeg-turbo JCS_EXT_BGRA and JCS_EXT_RGBA cases.
(WebCore::JPEGImageDecoder::outputScanlines): ditto.
* platform/image-decoders/jpeg/JPEGImageDecoder.h:
(WebCore::JPEGImageDecoder::willDownSample): Return true if image down sampling
will be applied to the decoded image (m_scaled). Note: the willDownSample() return
value is valid only after setSize() has been called: add an ASSERT for that.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Wed, 5 Dec 2012 16:27:07 +0000 (16:27 +0000)]
Unreviewed GTK gardening.

Moving some expectations for expected failures under the appropriate section.

Rather than skipping expected failures, they should be run (as long as they
don't time out in great numbers) just to get the extra test coverage (mostly
to confirm they don't crash unexpectably). Most of such expectations are being
unskipped and changed into a proper failure expectation, but more can folllow.

* platform/gtk/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] EWK2UnitTestBase.ewk_favicon_database_async_icon_get is crashing with...
christophe.dumez@intel.com [Wed, 5 Dec 2012 16:10:37 +0000 (16:10 +0000)]
[EFL][WK2] EWK2UnitTestBase.ewk_favicon_database_async_icon_get is crashing with new Ewk_Context
https://bugs.webkit.org/show_bug.cgi?id=104110

Reviewed by Laszlo Gombos.

Unregister the WKFaviconDatabase client in EwkFaviconDatabase
destructor to avoid crashing if the callbacks get called
after the EwkFaviconDatabase object has been destroyed (i.e.
the parent EwkContext object was destroyed).

* UIProcess/API/efl/ewk_favicon_database.cpp:
(EwkFaviconDatabase::~EwkFaviconDatabase):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening.
senorblanco@chromium.org [Wed, 5 Dec 2012 15:57:42 +0000 (15:57 +0000)]
[Chromium] Unreviewed gardening.

* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Avoid showing FCC on empty text field in a different way
commit-queue@webkit.org [Wed, 5 Dec 2012 15:52:50 +0000 (15:52 +0000)]
[BlackBerry] Avoid showing FCC on empty text field in a different way
https://bugs.webkit.org/show_bug.cgi?id=104019

Patch by Yongxin Dai <yodai@rim.com> on 2012-12-05
Reviewed by Rob Buis.

PR #222796

Add text field empty flag along with the caret change notification so that
FineCursorContnrol is able to avoid showing FCC on empty text filed.
Previous approach, notifying client with empty caret on empty text field,
causes problem. Its code is removed.

Reviewed Internally by Mike Fenton.

* Api/WebPageClient.h:
* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::caretPositionChanged):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening, updating baselines after r136657 and r136672.
zandobersek@gmail.com [Wed, 5 Dec 2012 15:51:13 +0000 (15:51 +0000)]
Unreviewed GTK gardening, updating baselines after r136657 and r136672.

* platform/gtk/http/tests/inspector/console-websocket-error-expected.txt:
* platform/gtk/http/tests/xmlhttprequest/access-control-preflight-async-header-denied-expected.txt: Removed.
* platform/gtk/http/tests/xmlhttprequest/access-control-preflight-async-method-denied-expected.txt: Removed.
* platform/gtk/http/tests/xmlhttprequest/access-control-preflight-async-not-supported-expected.txt: Removed.
* platform/gtk/http/tests/xmlhttprequest/origin-whitelisting-https-expected.txt: Removed.
* platform/gtk/http/tests/xmlhttprequest/simple-cross-origin-denied-events-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTools: [WK2] InjectedBundle should check Intent url for null
commit-queue@webkit.org [Wed, 5 Dec 2012 15:43:14 +0000 (15:43 +0000)]
Tools: [WK2] InjectedBundle should check Intent url for null
https://bugs.webkit.org/show_bug.cgi?id=104117

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-12-05
Reviewed by Kenneth Rohde Christiansen.

WKIntentServiceInfoCopyHref() can return null, we need to check
for that in InjectedBundlePage::registerIntentServiceForFrame()
to avoid crashing.

* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::registerIntentServiceForFrame):

LayoutTests: [EFL] InjectedBundle should check Intent url for null
https://bugs.webkit.org/show_bug.cgi?id=104117

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-12-05
Reviewed by Kenneth Rohde Christiansen.

EFL is slightly more verbose than chromium on this one.

* platform/efl/fast/images/crossfade-client-not-removed-crash-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Implement IndexedDB bindings for JSC
commit-queue@webkit.org [Wed, 5 Dec 2012 15:37:44 +0000 (15:37 +0000)]
IndexedDB: Implement IndexedDB bindings for JSC
https://bugs.webkit.org/show_bug.cgi?id=103484

Patch by Michael Pruett <michael@68k.org> on 2012-12-05
Reviewed by Kentaro Hara.

IndexedDB is currently implemented only for V8. This change adds
the bindings necessary for IndexedDB to work with JSC. With this
patch, IndexedDB for JSC passes 112 out of the 196 layout tests in
storage/indexeddb. IndexedDB is still not enabled for any JSC port.

Tests: storage/indexeddb/*

* CMakeLists.txt:
* GNUmakefile.list.am:
* Modules/indexeddb/IDBOpenDBRequest.idl:
* Modules/indexeddb/IDBVersionChangeRequest.idl:
* UseJSC.cmake:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/DOMRequestState.h: Added to match bindings/v8/DOMRequestState.h.
(WebCore):
(DOMRequestState):
(WebCore::DOMRequestState::DOMRequestState):
(WebCore::DOMRequestState::clear):
(Scope):
(WebCore::DOMRequestState::Scope::Scope):
(WebCore::DOMRequestState::exec):
* bindings/js/IDBBindingUtilities.cpp: Add utility functions matching those in bindings/v8/IDBBindingUtilities.cpp.
(WebCore::get):
(WebCore):
(WebCore::canSet):
(WebCore::set):
(WebCore::createIDBKeyFromValue):
(WebCore::getNthValueOnKeyPath):
(WebCore::createIDBKeyFromScriptValueAndKeyPath):
(WebCore::ensureNthValueOnKeyPath):
(WebCore::canInjectNthValueOnKeyPath):
(WebCore::injectIDBKeyIntoScriptValue):
(WebCore::canInjectIDBKeyIntoScriptValue):
(WebCore::deserializeIDBValue):
(WebCore::idbKeyToScriptValue):
* bindings/js/IDBBindingUtilities.h: Add utility functions matching those in bindings/v8/IDBBindingUtilities.h.
(WebCore):
* bindings/js/JSIDBAnyCustom.cpp:
(WebCore::toJS):
* bindings/js/JSIDBKeyCustom.cpp:
(WebCore::toJS):
* bindings/js/JSIDBVersionChangeRequestCustom.cpp: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][Mac] QWebView disappears when the system tries to hide the scrollbars.
zeno.albisser@digia.com [Wed, 5 Dec 2012 15:31:09 +0000 (15:31 +0000)]
[Qt][Mac] QWebView disappears when the system tries to hide the scrollbars.
https://bugs.webkit.org/show_bug.cgi?id=104116

This is a workaround for an issue in Qt that was
caused by Change-Id: I2000fa50d46b153e981ceafc12a53932a196382e
in qtbase.
Since we are drawing the scrollbars by ourselves, there is no
widget available that needs to be hidden by the style.
Therefore we have to disable transient scrollbar
animations on Mac.

Patch by: J-P Nurmi <jpnurmi@digia.com>

Reviewed by Simon Hausmann.

* WidgetSupport/QStyleFacadeImp.cpp:
(WebKit::QStyleFacadeImp::paintScrollBar):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTextTrackCue's .endTime property should fire a TypeError when NaN is assigned
commit-queue@webkit.org [Wed, 5 Dec 2012 15:25:22 +0000 (15:25 +0000)]
TextTrackCue's .endTime property should fire a TypeError when NaN is assigned
https://bugs.webkit.org/show_bug.cgi?id=103413

Patch by Antoine Quint <graouts@apple.com> on 2012-12-05
Reviewed by Eric Carlson.

Source/WebCore:

Check whether the new time passed to setStartTime() and setEndTime() is none of NaN or Infinity,
otherwise throwing a TypeError.

Thanks to this fix, we're no longer skipping media/track/opera/interfaces/TextTrackCue/endTime.html and
media/track/opera/interfaces/TextTrackCue/startTime.html.

* html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::setStartTime):
(WebCore::TextTrackCue::setEndTime):
* html/track/TextTrackCue.h:
(TextTrackCue):
* html/track/TextTrackCue.idl:

LayoutTests:

Stop skipping two tests that now have new passing conditions, only held back from
passing altogether by https://bugs.webkit.org/show_bug.cgi?id=103258.

* media/track/opera/interfaces/TextTrackCue/endTime-expected.txt: Added.
* media/track/opera/interfaces/TextTrackCue/startTime-expected.txt: Added.
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS3 Backgrounds and Borders] Allow the CSS3 background position offset for backgrou...
alexis@webkit.org [Wed, 5 Dec 2012 15:10:32 +0000 (15:10 +0000)]
[CSS3 Backgrounds and Borders] Allow the CSS3 background position offset for background shorthand.
https://bugs.webkit.org/show_bug.cgi?id=104014

Reviewed by Dirk Schulze.

Source/WebCore:

Add the support of the new <position> type if set from within the
background shorthand. The patch just modify the way we count the values
of the current context by checking wether we encounter a comma (it is
then the next background layer), or if we encounter a '/' (which is in the
background shorthand context the background-size) or any value that is
not a valid background-position keyword or length (which means we are
already parsing the next property of the background shorthand).

Tests: LayoutTests/fast/backgrounds/background-position-parsing-2.html
has been modified to cover this use case.

* css/CSSParser.cpp:
(WebCore::CSSParser::isPositionValue):
(WebCore):
(WebCore::CSSParser::parseFillBackgroundPosition):
(WebCore::CSSParser::parseFillProperty):
* css/CSSParser.h:

LayoutTests:

Extend the current parsing tests of background-position to cover the
case when it is set part of the background shorthand.

* fast/backgrounds/background-position-parsing-2-expected.txt:
* fast/backgrounds/background-position-parsing-2.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Rebaseline suggestion picker tests because of CSS change in r136674
keishi@webkit.org [Wed, 5 Dec 2012 14:30:57 +0000 (14:30 +0000)]
[Chromium] Rebaseline suggestion picker tests because of CSS change in r136674

Unreviewed.

* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMarking *-suggestion-picker-appearance-locale-hebrew.html tests as Missing
keishi@webkit.org [Wed, 5 Dec 2012 14:22:59 +0000 (14:22 +0000)]
Marking *-suggestion-picker-appearance-locale-hebrew.html tests as Missing

Unreviewed.

* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening.
kkristof@inf.u-szeged.hu [Wed, 5 Dec 2012 14:05:31 +0000 (14:05 +0000)]
[Qt] Unreviewed gardening.

Revert some update of r136670, and update the generic expecteds.

Patch by Nandor Huszka <hnandor@inf.u-szeged.hu> on 2012-12-05

* fast/media/mq-resolution-dpi-dpcm-warning-expected.txt:
* fast/media/mq-resolution-expected.txt:
* fast/media/w3c/test_media_queries-expected.txt:
* platform/qt/fast/media/mq-resolution-dpi-dpcm-warning-expected.txt: Removed.
* platform/qt/fast/media/mq-resolution-expected.txt: Removed.
* platform/qt/fast/media/w3c/test_media_queries-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Unreviewed gardening.
thiago.santos@intel.com [Wed, 5 Dec 2012 13:55:31 +0000 (13:55 +0000)]
[EFL] Unreviewed gardening.

Removed duplicated test expectations.

* platform/efl-wk1/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Removed.
* platform/efl-wk1/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png: Removed.
* platform/efl-wk1/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png: Removed.
* platform/efl-wk1/compositing/repaint/composited-document-element-expected.png: Removed.
* platform/efl-wk1/dom/xhtml/level3/core/documentnormalizedocument10-expected.txt: Removed.
* platform/efl-wk1/fast/dom/DOMException/prototype-object-expected.txt: Removed.
* platform/efl-wk1/fast/dom/DOMException/stack-trace-expected.txt: Removed.
* platform/efl-wk1/mathml/presentation/roots-expected.txt: Removed.
* platform/efl-wk1/mathml/presentation/row-alignment-expected.txt: Removed.
* platform/efl-wk1/mathml/presentation/sub-expected.txt: Removed.
* platform/efl-wk1/mathml/presentation/subsup-expected.txt: Removed.
* platform/efl-wk1/media/video-aspect-ratio-expected.png: Removed.
* platform/efl-wk1/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png: Removed.
* platform/efl-wk2/dom/xhtml/level3/core/documentnormalizedocument10-expected.txt: Removed.
* platform/efl-wk2/fast/dom/DOMException/prototype-object-expected.txt: Removed.
* platform/efl-wk2/fast/dom/DOMException/stack-trace-expected.txt: Removed.
* platform/efl-wk2/fast/media/mq-resolution-dpi-dpcm-warning-expected.txt: Removed.
* platform/efl-wk2/fast/media/mq-resolution-expected.txt: Removed.
* platform/efl-wk2/fast/media/w3c/test_media_queries-expected.txt: Removed.
* platform/efl-wk2/http/tests/loading/text-content-type-with-binary-extension-expected.txt: Removed.
* platform/efl/fast/canvas/fillText-shadow-expected.txt: Removed.
* platform/efl/fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt: Removed.
* platform/efl/fast/forms/005-expected.png: Removed.
* platform/efl/fast/forms/range/range-thumb-height-percentage-expected.txt: Removed.
* platform/efl/fast/forms/range/slider-thumb-stylability-expected.txt: Removed.
* platform/efl/fast/images/exif-orientation-image-document-expected.txt: Removed.
* platform/efl/fast/media/mq-resolution-dpi-dpcm-warning-expected.txt: Renamed from LayoutTests/platform/efl-wk1/fast/media/mq-resolution-dpi-dpcm-warning-expected.txt.
* platform/efl/fast/media/mq-resolution-expected.txt: Renamed from LayoutTests/platform/efl-wk1/fast/media/mq-resolution-expected.txt.
* platform/efl/fast/media/w3c/test_media_queries-expected.txt: Renamed from LayoutTests/platform/efl-wk1/fast/media/w3c/test_media_queries-expected.txt.
* platform/efl/fast/multicol/overflow-across-columns-expected.png: Removed.
* platform/efl/fast/multicol/overflow-across-columns-percent-height-expected.png: Removed.
* platform/efl/fast/regions/absolute-pos-elem-in-named-flow-expected.txt: Removed.
* platform/efl/fast/regions/autowidth-attachedinvalidregion-expected.txt: Removed.
* platform/efl/fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
* platform/efl/fast/regions/content-flowed-into-regions-no-scroll-expected.txt: Removed.
* platform/efl/fast/regions/content-webkit-from-flow-parsing-expected.txt: Removed.
* platform/efl/fast/regions/element-region-overset-state-expected.txt: Removed.
* platform/efl/fast/regions/element-region-overset-state-negative-letter-spacing-expected.txt: Removed.
* platform/efl/fast/regions/element-region-overset-state-vertical-rl-expected.txt: Removed.
* platform/efl/fast/regions/element-region-overset-state-vertical-rl-negative-letter-spacing-expected.txt: Removed.
* platform/efl/fast/regions/fixed-pos-elem-in-named-flow-expected.txt: Removed.
* platform/efl/fast/regions/fixed-pos-elem-in-named-flow2-expected.txt: Removed.
* platform/efl/fast/regions/flexbox-in-region-crash-expected.txt: Removed.
* platform/efl/fast/regions/flow-anonymous-children-expected.txt: Removed.
* platform/efl/fast/regions/flow-region-into-itself-crash-expected.txt: Removed.
* platform/efl/fast/regions/flowed-content-bounding-client-rect-expected.txt: Removed.
* platform/efl/fast/regions/flowed-content-bounding-client-rect-horizontal-bt-expected.txt: Removed.
* platform/efl/fast/regions/flowed-content-bounding-client-rect-vertical-expected.txt: Removed.
* platform/efl/fast/regions/flowed-content-bounding-client-rect-vertical-rl-expected.txt: Removed.
* platform/efl/fast/regions/flowed-content-transform-bounding-client-rect-expected.txt: Removed.
* platform/efl/fast/regions/get-region-flow-ranges-absolute-pos-expected.txt: Removed.
* platform/efl/fast/regions/get-region-flow-ranges-content-nodes-expected.txt: Removed.
* platform/efl/fast/regions/get-region-flow-ranges-display-none-expected.txt: Removed.
* platform/efl/fast/regions/get-region-flow-ranges-empty-regions-expected.txt: Removed.
* platform/efl/fast/regions/get-region-flow-ranges-expected.txt: Removed.
* platform/efl/fast/regions/get-region-flow-ranges-fixed-pos-expected.txt: Removed.
* platform/efl/fast/regions/get-region-flow-ranges-horiz-bt-expected.txt: Removed.
* platform/efl/fast/regions/get-region-flow-ranges-inline-only-expected.txt: Removed.
* platform/efl/fast/regions/get-region-flow-ranges-text-expected.txt: Removed.
* platform/efl/fast/regions/get-region-flow-ranges-text-vert-lr-expected.txt: Removed.
* platform/efl/fast/regions/get-region-flow-ranges-vert-lr-expected.txt: Removed.
* platform/efl/fast/regions/get-region-flow-ranges-vert-rl-expected.txt: Removed.
* platform/efl/fast/regions/get-region-flow-ranges-writing-modes-rl-rb-lr-expected.txt: Removed.
* platform/efl/fast/regions/get-region-flow-ranges-writing-modes-tb-rl-lr-expected.txt: Removed.
* platform/efl/fast/regions/get-regions-by-content-expected.txt: Removed.
* platform/efl/fast/regions/get-regions-by-content-horiz-bt-expected.txt: Removed.
* platform/efl/fast/regions/get-regions-by-content-horiz-tb-expected.txt: Removed.
* platform/efl/fast/regions/get-regions-by-content-vert-lr-expected.txt: Removed.
* platform/efl/fast/regions/get-regions-by-content-vert-rl-expected.txt: Removed.
* platform/efl/fast/regions/get-regions-by-content2-expected.txt: Removed.
* platform/efl/fast/regions/hit-test-float-expected.txt: Removed.
* platform/efl/fast/regions/hit-test-region-expected.txt: Removed.
* platform/efl/fast/regions/imbricated-flow-threads-crash-expected.txt: Removed.
* platform/efl/fast/regions/move-anonymous-block-inside-named-flow-crash-expected.txt: Removed.
* platform/efl/fast/regions/moved-content-node-crash-expected.txt: Removed.
* platform/efl/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png: Removed.
* platform/efl/fast/regions/no-split-line-box-expected.txt: Removed.
* platform/efl/fast/regions/overflow-in-uniform-regions-dynamic-expected.png: Removed.
* platform/efl/fast/regions/overflow-in-variable-width-regions-expected.png: Removed.
* platform/efl/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.png: Removed.
* platform/efl/fast/regions/overflow-rtl-in-variable-width-regions-expected.png: Removed.
* platform/efl/fast/regions/overflow-size-change-in-variable-width-regions-expected.png: Removed.
* platform/efl/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.png: Removed.
* platform/efl/fast/regions/parse-incomplete-region-rule-expected.txt: Removed.
* platform/efl/fast/regions/parsing-region-style-rule-expected.txt: Removed.
* platform/efl/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.png: Removed.
* platform/efl/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.png: Removed.
* platform/efl/fast/regions/percentage-margins-rtl-variable-width-regions-expected.png: Removed.
* platform/efl/fast/regions/percentage-margins-variable-width-regions-expected.png: Removed.
* platform/efl/fast/regions/positioned-vrl-in-named-flow-expected.txt: Removed.
* platform/efl/fast/regions/positioned-vrl-in-parent-named-flow-expected.txt: Removed.
* platform/efl/fast/regions/positioned-with-vrl-parent-in-named-flow-expected.txt: Removed.
* platform/efl/fast/regions/region-attached-wrong-flow-crash-expected.txt: Removed.
* platform/efl/fast/regions/region-element-display-change-expected.txt: Removed.
* platform/efl/fast/regions/region-element-display-restriction-expected.txt: Removed.
* platform/efl/fast/regions/region-element-dynamic-attach-flow-expected.txt: Removed.
* platform/efl/fast/regions/region-element-dynamic-detach-flow-expected.txt: Removed.
* platform/efl/fast/regions/region-flow-reattach-crash-expected.txt: Removed.
* platform/efl/fast/regions/region-range-for-box-crash-expected.txt: Removed.
* platform/efl/fast/regions/remove-flow-thread-crash-expected.txt: Removed.
* platform/efl/fast/regions/removed-element-style-in-region-crash-expected.txt: Removed.
* platform/efl/fast/regions/select-in-region-crash-expected.txt: Removed.
* platform/efl/fast/regions/set-box-style-in-region-crash-expected.txt: Removed.
* platform/efl/fast/regions/svg-root-element-collected-expected.txt: Removed.
* platform/efl/fast/regions/symbol-in-named-flow-crash-expected.txt: Removed.
* platform/efl/fast/regions/text-region-breaks-expected.txt: Removed.
* platform/efl/fast/regions/text-region-split-after-resize-expected.txt: Removed.
* platform/efl/fast/regions/text-region-split-expected.txt: Removed.
* platform/efl/fast/regions/text-region-split-horizontal-bt-expected.txt: Removed.
* platform/efl/fast/regions/text-region-split-vertical-expected.txt: Removed.
* platform/efl/fast/regions/text-region-split-vertical-rl-expected.txt: Removed.
* platform/efl/fast/regions/top-overflow-out-of-second-region-expected.png: Removed.
* platform/efl/fast/regions/webkit-flow-double-pagination-float-push-expected.png: Removed.
* platform/efl/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png: Removed.
* platform/efl/fast/regions/webkit-flow-float-unable-to-push-expected.png: Removed.
* platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.png: Removed.
* platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.png: Removed.
* platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.png: Removed.
* platform/efl/fast/regions/webkit-flow-parsing-expected.txt: Removed.
* platform/efl/fast/regions/webkit-region-overflow-parsing-expected.txt: Removed.
* platform/efl/fast/regions/webkit-region-rule-expected.txt: Removed.
* platform/efl/fast/repaint/background-generated-expected.png: Removed.
* platform/efl/fast/repaint/line-flow-with-floats-1-expected.png: Removed.
* platform/efl/fast/repaint/line-flow-with-floats-10-expected.png: Removed.
* platform/efl/fast/repaint/line-flow-with-floats-2-expected.png: Removed.
* platform/efl/fast/repaint/line-flow-with-floats-3-expected.png: Removed.
* platform/efl/fast/repaint/line-flow-with-floats-4-expected.png: Removed.
* platform/efl/fast/repaint/line-flow-with-floats-5-expected.png: Removed.
* platform/efl/fast/repaint/line-flow-with-floats-6-expected.png: Removed.
* platform/efl/fast/repaint/line-flow-with-floats-7-expected.png: Removed.
* platform/efl/fast/repaint/line-flow-with-floats-8-expected.png: Removed.
* platform/efl/fast/repaint/line-flow-with-floats-9-expected.png: Removed.
* platform/efl/fast/repaint/slider-thumb-float-expected.txt: Removed.
* platform/efl/fast/selectors/unqualified-hover-strict-expected.txt: Removed.
* platform/efl/fast/table/025-expected.png: Removed.
* platform/efl/fast/text/international/bidi-layout-across-linebreak-expected.txt: Removed.
* platform/efl/fast/text/international/bidi-listbox-expected.txt: Removed.
* platform/efl/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: Removed.
* platform/efl/fast/text/international/bidi-override-expected.txt: Removed.
* platform/efl/svg/clip-path/clip-in-mask-objectBoundingBox-expected.png: Removed.
* platform/efl/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.png: Removed.
* platform/efl/svg/css/path-gradient-stroke-shadow-expected.txt: Removed.
* platform/efl/svg/dom/css-transforms-expected.txt: Removed.
* platform/efl/svg/text/font-size-below-point-five-2-expected.png: Removed.
* platform/efl/svg/text/scaled-font-expected.png: Removed.
* platform/efl/svg/text/text-hkern-expected.png: Removed.
* platform/efl/svg/text/text-vkern-on-horizontal-text-expected.png: Removed.
* platform/efl/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Removed.
* platform/efl/svg/zoom/text/zoom-svg-float-border-padding-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug1055-1-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug10565-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug10633-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug106816-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug11026-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug113235-1-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug113235-2-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug113424-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug120107-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug126742-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug1271-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug12908-1-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug12908-2-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug1296-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug13118-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug13169-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug139524-2-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug1430-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug154780-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug15544-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug159108-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug17130-1-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug17130-2-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug17138-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug19061-1-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug19061-2-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug196870-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug215629-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug26553-expected.png: Removed.
* platform/efl/tables/mozilla/bugs/bug26553-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug27038-1-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug27038-2-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug2886-2-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug29314-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug2981-2-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug3309-1-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug3309-2-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug33137-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug4093-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug42187-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug4284-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug46480-1-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug46480-2-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug50695-2-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug5538-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug56563-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug5797-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug625-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug67915-1-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug69187-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug7112-1-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug7112-2-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug8032-1-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug82946-2-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug83786-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug9024-expected.txt: Removed.
* platform/efl/tables/mozilla/core/bloomberg-expected.txt: Removed.
* platform/efl/tables/mozilla/core/col_widths_auto_autoFix-expected.txt: Removed.
* platform/efl/tables/mozilla/core/misc-expected.txt: Removed.
* platform/efl/tables/mozilla/core/row_span-expected.txt: Removed.
* platform/efl/tables/mozilla/marvin/backgr_index-expected.txt: Removed.
* platform/efl/tables/mozilla/marvin/tbody_valign_baseline-expected.txt: Removed.
* platform/efl/tables/mozilla/marvin/tbody_valign_bottom-expected.txt: Removed.
* platform/efl/tables/mozilla/marvin/tbody_valign_middle-expected.txt: Removed.
* platform/efl/tables/mozilla/marvin/tbody_valign_top-expected.txt: Removed.
* platform/efl/tables/mozilla/marvin/td_valign_baseline-expected.txt: Removed.
* platform/efl/tables/mozilla/marvin/td_valign_bottom-expected.txt: Removed.
* platform/efl/tables/mozilla/marvin/td_valign_middle-expected.txt: Removed.
* platform/efl/tables/mozilla/marvin/td_valign_top-expected.txt: Removed.
* platform/efl/tables/mozilla/marvin/tfoot_valign_baseline-expected.txt: Removed.
* platform/efl/tables/mozilla/marvin/tfoot_valign_bottom-expected.txt: Removed.
* platform/efl/tables/mozilla/marvin/tfoot_valign_middle-expected.txt: Removed.
* platform/efl/tables/mozilla/marvin/tfoot_valign_top-expected.txt: Removed.
* platform/efl/tables/mozilla/marvin/th_valign_baseline-expected.txt: Removed.
* platform/efl/tables/mozilla/marvin/th_valign_bottom-expected.txt: Removed.
* platform/efl/tables/mozilla/marvin/th_valign_middle-expected.txt: Removed.
* platform/efl/tables/mozilla/marvin/th_valign_top-expected.txt: Removed.
* platform/efl/tables/mozilla/marvin/thead_valign_baseline-expected.txt: Removed.
* platform/efl/tables/mozilla/marvin/thead_valign_bottom-expected.txt: Removed.
* platform/efl/tables/mozilla/marvin/thead_valign_middle-expected.txt: Removed.
* platform/efl/tables/mozilla/marvin/thead_valign_top-expected.txt: Removed.
* platform/efl/tables/mozilla/marvin/tr_valign_baseline-expected.txt: Removed.
* platform/efl/tables/mozilla/marvin/tr_valign_bottom-expected.txt: Removed.
* platform/efl/tables/mozilla/marvin/tr_valign_middle-expected.txt: Removed.
* platform/efl/tables/mozilla/marvin/tr_valign_top-expected.txt: Removed.
* platform/efl/tables/mozilla/marvin/x_table_align_center-expected.txt: Removed.
* platform/efl/tables/mozilla/other/cell_widths-expected.txt: Removed.
* platform/efl/tables/mozilla_expected_failures/collapsing_borders/bug41262-1-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening.
kkristof@inf.u-szeged.hu [Wed, 5 Dec 2012 13:49:59 +0000 (13:49 +0000)]
[Qt] Unreviewed gardening.

Skip a test and update an other one.

Patch by Nandor Huszka <hnandor@inf.u-szeged.hu> on 2012-12-05

* platform/qt/TestExpectations:
* platform/qt/fast/images/crossfade-client-not-removed-crash-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled DEPS.
senorblanco@chromium.org [Wed, 5 Dec 2012 13:42:25 +0000 (13:42 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] New baselines after http://webkit.org/b/103906. Unreviewed.
senorblanco@chromium.org [Wed, 5 Dec 2012 13:27:17 +0000 (13:27 +0000)]
[chromium] New baselines after webkit.org/b/103906.  Unreviewed.

* platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.png: Copied from LayoutTests/platform/chromium-linux/compositing/shadows/shadow-drawing-expected.png.
* platform/chromium-linux/compositing/geometry/clipping-foreground-expected.png:
* platform/chromium-linux/compositing/iframes/composited-iframe-alignment-expected.png:
* platform/chromium-linux/compositing/masks/masked-ancestor-expected.png:
* platform/chromium-linux/compositing/shadows/shadow-drawing-expected.png:
* platform/chromium-linux/fast/borders/border-radius-constraints-expected.png:
* platform/chromium-linux/fast/borders/border-radius-split-inline-expected.png:
* platform/chromium-linux/fast/borders/mixed-border-styles-radius-expected.png:
* platform/chromium-linux/fast/box-shadow/basic-shadows-expected.png:
* platform/chromium-linux/fast/box-shadow/box-shadow-clipped-slices-expected.png:
* platform/chromium-linux/fast/box-shadow/box-shadow-transformed-expected.png:
* platform/chromium-linux/fast/box-shadow/inset-box-shadows-expected.png:
* platform/chromium-linux/fast/box-shadow/inset-expected.png:
* platform/chromium-linux/fast/box-shadow/shadow-tiling-artifact-expected.png:
* platform/chromium-linux/fast/css/background-clip-radius-values-expected.png:
* platform/chromium-linux/fast/css/box-shadow-and-border-radius-expected.png:
* platform/chromium-linux/fast/css/color-correction-on-box-shadow-expected.png:
* platform/chromium-linux/fast/css/color-correction-on-text-shadow-expected.png:
* platform/chromium-linux/fast/css/shadow-multiple-expected.png:
* platform/chromium-linux/fast/forms/validation-message-appearance-expected.png:
* platform/chromium-linux/fast/multicol/shadow-breaking-expected.png:
* platform/chromium-linux/fast/repaint/box-shadow-h-expected.png:
* platform/chromium-linux/fast/repaint/box-shadow-v-expected.png:
* platform/chromium-linux/fast/repaint/moving-shadow-on-path-expected.png:
* platform/chromium-linux/fast/repaint/shadow-multiple-horizontal-expected.png:
* platform/chromium-linux/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
* platform/chromium-linux/fast/repaint/shadow-multiple-strict-vertical-expected.png:
* platform/chromium-linux/fast/repaint/shadow-multiple-vertical-expected.png:
* platform/chromium-linux/fast/text/shadow-translucent-fill-expected.png:
* platform/chromium-linux/fast/text/stroking-decorations-expected.png:
* platform/chromium-linux/fast/text/stroking-expected.png:
* platform/chromium-linux/fast/transforms/shadows-expected.png:
* platform/chromium-linux/fast/writing-mode/box-shadow-horizontal-bt-expected.png:
* platform/chromium-linux/fast/writing-mode/box-shadow-vertical-lr-expected.png:
* platform/chromium-linux/fast/writing-mode/box-shadow-vertical-rl-expected.png:
* platform/chromium-linux/fast/writing-mode/english-lr-text-expected.png:
* platform/chromium-linux/ietestcenter/css3/text/textshadow-001-expected.png:
* platform/chromium-linux/ietestcenter/css3/text/textshadow-002-expected.png:
* platform/chromium-linux/ietestcenter/css3/text/textshadow-003-expected.png:
* platform/chromium-linux/ietestcenter/css3/text/textshadow-004-expected.png:
* platform/chromium-linux/ietestcenter/css3/text/textshadow-010-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png:
* platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/clipping-foreground-expected.png:
* platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/composited-iframe-alignment-expected.png:
* platform/chromium-linux/platform/chromium/virtual/softwarecompositing/masks/masked-ancestor-expected.png:
* platform/chromium-linux/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.png:
* platform/chromium-linux/svg/css/circle-in-mask-with-shadow-expected.png:
* platform/chromium-linux/svg/css/stars-with-shadow-expected.png:
* platform/chromium-linux/svg/css/text-gradient-shadow-expected.png:
* platform/chromium-linux/svg/css/text-shadow-multiple-expected.png:
* platform/chromium-linux/transitions/svg-text-shadow-transition-expected.png:
* platform/chromium-mac-lion/compositing/geometry/clipping-foreground-expected.png:
* platform/chromium-mac-lion/compositing/iframes/composited-iframe-alignment-expected.png:
* platform/chromium-mac-lion/compositing/masks/masked-ancestor-expected.png:
* platform/chromium-mac-lion/compositing/shadows/shadow-drawing-expected.png:
* platform/chromium-mac-lion/fast/borders/border-radius-constraints-expected.png:
* platform/chromium-mac-lion/fast/borders/border-radius-split-inline-expected.png:
* platform/chromium-mac-lion/fast/box-shadow/basic-shadows-expected.png:
* platform/chromium-mac-lion/fast/box-shadow/box-shadow-transformed-expected.png:
* platform/chromium-mac-lion/fast/box-shadow/inset-expected.png:
* platform/chromium-mac-lion/fast/css/color-correction-on-box-shadow-expected.png:
* platform/chromium-mac-lion/fast/css/color-correction-on-text-shadow-expected.png:
* platform/chromium-mac-lion/fast/css/shadow-multiple-expected.png:
* platform/chromium-mac-lion/fast/forms/validation-message-appearance-expected.png:
* platform/chromium-mac-lion/fast/multicol/shadow-breaking-expected.png:
* platform/chromium-mac-lion/fast/repaint/box-shadow-h-expected.png:
* platform/chromium-mac-lion/fast/repaint/box-shadow-v-expected.png:
* platform/chromium-mac-lion/fast/repaint/moving-shadow-on-path-expected.png:
* platform/chromium-mac-lion/fast/repaint/shadow-multiple-horizontal-expected.png:
* platform/chromium-mac-lion/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
* platform/chromium-mac-lion/fast/repaint/shadow-multiple-strict-vertical-expected.png:
* platform/chromium-mac-lion/fast/repaint/shadow-multiple-vertical-expected.png:
* platform/chromium-mac-lion/fast/text/shadow-translucent-fill-expected.png:
* platform/chromium-mac-lion/fast/text/stroking-decorations-expected.png:
* platform/chromium-mac-lion/fast/text/stroking-expected.png:
* platform/chromium-mac-lion/fast/transforms/shadows-expected.png:
* platform/chromium-mac-lion/fast/writing-mode/box-shadow-horizontal-bt-expected.png:
* platform/chromium-mac-lion/fast/writing-mode/box-shadow-vertical-lr-expected.png:
* platform/chromium-mac-lion/fast/writing-mode/box-shadow-vertical-rl-expected.png:
* platform/chromium-mac-lion/fast/writing-mode/english-lr-text-expected.png:
* platform/chromium-mac-lion/ietestcenter/css3/text/textshadow-001-expected.png:
* platform/chromium-mac-lion/ietestcenter/css3/text/textshadow-002-expected.png:
* platform/chromium-mac-lion/ietestcenter/css3/text/textshadow-003-expected.png:
* platform/chromium-mac-lion/ietestcenter/css3/text/textshadow-004-expected.png:
* platform/chromium-mac-lion/ietestcenter/css3/text/textshadow-010-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png:
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/clipping-foreground-expected.png:
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/masks/masked-ancestor-expected.png:
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.png:
* platform/chromium-mac-lion/svg/css/stars-with-shadow-expected.png:
* platform/chromium-mac-lion/svg/css/text-gradient-shadow-expected.png:
* platform/chromium-mac-lion/svg/css/text-shadow-multiple-expected.png:
* platform/chromium-mac-lion/svg/custom/repaint-shadow-expected.png:
* platform/chromium-mac-lion/transitions/svg-text-shadow-transition-expected.png:
* platform/chromium-mac-snowleopard/compositing/geometry/clipping-foreground-expected.png:
* platform/chromium-mac-snowleopard/compositing/iframes/composited-iframe-alignment-expected.png:
* platform/chromium-mac-snowleopard/compositing/masks/masked-ancestor-expected.png:
* platform/chromium-mac-snowleopard/compositing/shadows/shadow-drawing-expected.png:
* platform/chromium-mac-snowleopard/fast/borders/border-radius-constraints-expected.png:
* platform/chromium-mac-snowleopard/fast/borders/border-radius-split-inline-expected.png:
* platform/chromium-mac-snowleopard/fast/box-shadow/basic-shadows-expected.png:
* platform/chromium-mac-snowleopard/fast/box-shadow/box-shadow-transformed-expected.png:
* platform/chromium-mac-snowleopard/fast/css/color-correction-on-box-shadow-expected.png:
* platform/chromium-mac-snowleopard/fast/css/color-correction-on-text-shadow-expected.png:
* platform/chromium-mac-snowleopard/fast/css/shadow-multiple-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
* platform/chromium-mac-snowleopard/fast/multicol/shadow-breaking-expected.png:
* platform/chromium-mac-snowleopard/fast/repaint/box-shadow-h-expected.png:
* platform/chromium-mac-snowleopard/fast/repaint/box-shadow-v-expected.png:
* platform/chromium-mac-snowleopard/fast/repaint/moving-shadow-on-path-expected.png:
* platform/chromium-mac-snowleopard/fast/text/shadow-translucent-fill-expected.png:
* platform/chromium-mac-snowleopard/fast/writing-mode/box-shadow-vertical-lr-expected.png:
* platform/chromium-mac-snowleopard/fast/writing-mode/box-shadow-vertical-rl-expected.png:
* platform/chromium-mac-snowleopard/ietestcenter/css3/text/textshadow-001-expected.png:
* platform/chromium-mac-snowleopard/ietestcenter/css3/text/textshadow-002-expected.png:
* platform/chromium-mac-snowleopard/ietestcenter/css3/text/textshadow-003-expected.png:
* platform/chromium-mac-snowleopard/ietestcenter/css3/text/textshadow-004-expected.png:
* platform/chromium-mac-snowleopard/ietestcenter/css3/text/textshadow-010-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/clipping-foreground-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/iframes/composited-iframe-alignment-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/masks/masked-ancestor-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.png:
* platform/chromium-mac-snowleopard/svg/css/stars-with-shadow-expected.png:
* platform/chromium-mac-snowleopard/svg/css/text-shadow-multiple-expected.png:
* platform/chromium-mac-snowleopard/transitions/svg-text-shadow-transition-expected.png:
* platform/chromium-mac/compositing/culling/scrolled-within-boxshadow-expected.png: Added.
* platform/chromium-mac/compositing/culling/translated-boxshadow-expected.png: Added.
* platform/chromium-mac/compositing/culling/unscrolled-within-boxshadow-expected.png: Added.
* platform/chromium-mac/compositing/geometry/clipping-foreground-expected.png:
* platform/chromium-mac/compositing/geometry/foreground-layer-expected.png:
* platform/chromium-mac/compositing/iframes/composited-iframe-alignment-expected.png:
* platform/chromium-mac/compositing/masks/masked-ancestor-expected.png:
* platform/chromium-mac/compositing/shadows/shadow-drawing-expected.png:
* platform/chromium-mac/fast/borders/border-radius-constraints-expected.png:
* platform/chromium-mac/fast/borders/border-radius-split-inline-expected.png:
* platform/chromium-mac/fast/borders/mixed-border-styles-radius-expected.png:
* platform/chromium-mac/fast/box-shadow/basic-shadows-expected.png:
* platform/chromium-mac/fast/box-shadow/box-shadow-clipped-slices-expected.png:
* platform/chromium-mac/fast/box-shadow/box-shadow-radius-expected.png:
* platform/chromium-mac/fast/box-shadow/box-shadow-transformed-expected.png:
* platform/chromium-mac/fast/box-shadow/inset-box-shadow-radius-expected.png:
* platform/chromium-mac/fast/box-shadow/inset-box-shadows-expected.png:
* platform/chromium-mac/fast/box-shadow/inset-expected.png:
* platform/chromium-mac/fast/box-shadow/scaled-box-shadow-expected.png:
* platform/chromium-mac/fast/box-shadow/shadow-buffer-partial-expected.png:
* platform/chromium-mac/fast/box-shadow/shadow-tiling-artifact-expected.png:
* platform/chromium-mac/fast/box-shadow/single-pixel-shadow-expected.png:
* platform/chromium-mac/fast/canvas/fillText-shadow-expected.txt: Removed.
* platform/chromium-mac/fast/css/box-shadow-and-border-radius-expected.png:
* platform/chromium-mac/fast/css/color-correction-on-box-shadow-expected.png:
* platform/chromium-mac/fast/css/color-correction-on-text-shadow-expected.png:
* platform/chromium-mac/fast/css/shadow-multiple-expected.png:
* platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
* platform/chromium-mac/fast/multicol/shadow-breaking-expected.png:
* platform/chromium-mac/fast/repaint/box-shadow-h-expected.png:
* platform/chromium-mac/fast/repaint/box-shadow-v-expected.png:
* platform/chromium-mac/fast/repaint/moving-shadow-on-path-expected.png:
* platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.png:
* platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
* platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png:
* platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.png:
* platform/chromium-mac/fast/repaint/transform-replaced-shadows-expected.png:
* platform/chromium-mac/fast/text/shadow-translucent-fill-expected.png:
* platform/chromium-mac/fast/text/stroking-decorations-expected.png:
* platform/chromium-mac/fast/text/stroking-expected.png:
* platform/chromium-mac/fast/transforms/shadows-expected.png:
* platform/chromium-mac/fast/writing-mode/box-shadow-horizontal-bt-expected.png:
* platform/chromium-mac/fast/writing-mode/box-shadow-vertical-lr-expected.png:
* platform/chromium-mac/fast/writing-mode/box-shadow-vertical-rl-expected.png:
* platform/chromium-mac/fast/writing-mode/english-lr-text-expected.png:
* platform/chromium-mac/ietestcenter/css3/text/textshadow-001-expected.png:
* platform/chromium-mac/ietestcenter/css3/text/textshadow-002-expected.png:
* platform/chromium-mac/ietestcenter/css3/text/textshadow-003-expected.png:
* platform/chromium-mac/ietestcenter/css3/text/textshadow-004-expected.png:
* platform/chromium-mac/ietestcenter/css3/text/textshadow-010-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png:
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/culling/scrolled-within-boxshadow-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/culling/translated-boxshadow-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/culling/unscrolled-within-boxshadow-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/clipping-foreground-expected.png:
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/foreground-layer-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/iframes/composited-iframe-alignment-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/masks/masked-ancestor-expected.png:
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.png:
* platform/chromium-mac/svg/css/circle-in-mask-with-shadow-expected.png:
* platform/chromium-mac/svg/css/path-with-shadow-expected.png:
* platform/chromium-mac/svg/css/shadow-and-opacity-expected.png:
* platform/chromium-mac/svg/css/shadow-with-large-radius-expected.png:
* platform/chromium-mac/svg/css/shadow-with-negative-offset-expected.png:
* platform/chromium-mac/svg/css/stars-with-shadow-expected.png:
* platform/chromium-mac/svg/css/text-gradient-shadow-expected.png:
* platform/chromium-mac/svg/css/text-shadow-multiple-expected.png:
* platform/chromium-mac/svg/custom/repaint-shadow-expected.png:
* platform/chromium-mac/svg/filters/shadow-on-rect-with-filter-expected.png:
* platform/chromium-mac/transitions/svg-text-shadow-transition-expected.png:
* platform/chromium-win-xp/compositing/shadows/shadow-drawing-expected.png:
* platform/chromium-win-xp/fast/repaint/box-shadow-h-expected.png:
* platform/chromium-win-xp/fast/repaint/box-shadow-v-expected.png:
* platform/chromium-win-xp/fast/text/stroking-decorations-expected.png:
* platform/chromium-win-xp/fast/text/stroking-expected.png:
* platform/chromium-win-xp/fast/writing-mode/english-lr-text-expected.png:
* platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/masks/masked-ancestor-expected.png: Removed.
* platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.png:
* platform/chromium-win/compositing/culling/scrolled-within-boxshadow-expected.png: Copied from LayoutTests/platform/chromium-win/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png.
* platform/chromium-win/compositing/culling/translated-boxshadow-expected.png: Copied from LayoutTests/platform/chromium-win/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png.
* platform/chromium-win/compositing/culling/unscrolled-within-boxshadow-expected.png: Copied from LayoutTests/platform/chromium-win/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png.
* platform/chromium-win/compositing/geometry/clipping-foreground-expected.png:
* platform/chromium-win/compositing/geometry/foreground-layer-expected.png:
* platform/chromium-win/compositing/iframes/composited-iframe-alignment-expected.png:
* platform/chromium-win/compositing/masks/masked-ancestor-expected.png:
* platform/chromium-win/compositing/shadows/shadow-drawing-expected.png:
* platform/chromium-win/fast/borders/border-radius-constraints-expected.png:
* platform/chromium-win/fast/borders/border-radius-split-inline-expected.png:
* platform/chromium-win/fast/borders/mixed-border-styles-radius-expected.png:
* platform/chromium-win/fast/box-shadow/basic-shadows-expected.png:
* platform/chromium-win/fast/box-shadow/box-shadow-clipped-slices-expected.png:
* platform/chromium-win/fast/box-shadow/box-shadow-radius-expected.png:
* platform/chromium-win/fast/box-shadow/box-shadow-transformed-expected.png:
* platform/chromium-win/fast/box-shadow/inset-box-shadow-radius-expected.png:
* platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.png:
* platform/chromium-win/fast/box-shadow/inset-expected.png:
* platform/chromium-win/fast/box-shadow/scaled-box-shadow-expected.png:
* platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.png:
* platform/chromium-win/fast/box-shadow/shadow-tiling-artifact-expected.png:
* platform/chromium-win/fast/box-shadow/single-pixel-shadow-expected.png:
* platform/chromium-win/fast/css/box-shadow-and-border-radius-expected.png:
* platform/chromium-win/fast/css/color-correction-on-box-shadow-expected.png:
* platform/chromium-win/fast/css/color-correction-on-text-shadow-expected.png:
* platform/chromium-win/fast/css/shadow-multiple-expected.png:
* platform/chromium-win/fast/forms/validation-message-appearance-expected.png:
* platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
* platform/chromium-win/fast/repaint/box-shadow-h-expected.png:
* platform/chromium-win/fast/repaint/box-shadow-v-expected.png:
* platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.png:
* platform/chromium-win/fast/repaint/shadow-multiple-horizontal-expected.png:
* platform/chromium-win/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
* platform/chromium-win/fast/repaint/shadow-multiple-strict-vertical-expected.png:
* platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.png:
* platform/chromium-win/fast/repaint/transform-replaced-shadows-expected.png:
* platform/chromium-win/fast/text/shadow-translucent-fill-expected.png:
* platform/chromium-win/fast/text/stroking-decorations-expected.png:
* platform/chromium-win/fast/text/stroking-expected.png:
* platform/chromium-win/fast/transforms/shadows-expected.png:
* platform/chromium-win/fast/writing-mode/box-shadow-horizontal-bt-expected.png:
* platform/chromium-win/fast/writing-mode/box-shadow-vertical-lr-expected.png:
* platform/chromium-win/fast/writing-mode/box-shadow-vertical-rl-expected.png:
* platform/chromium-win/fast/writing-mode/english-lr-text-expected.png:
* platform/chromium-win/ietestcenter/css3/text/textshadow-001-expected.png:
* platform/chromium-win/ietestcenter/css3/text/textshadow-002-expected.png:
* platform/chromium-win/ietestcenter/css3/text/textshadow-003-expected.png:
* platform/chromium-win/ietestcenter/css3/text/textshadow-004-expected.png:
* platform/chromium-win/ietestcenter/css3/text/textshadow-010-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png:
* platform/chromium-win/platform/chromium/virtual/softwarecompositing/culling/scrolled-within-boxshadow-expected.png: Copied from LayoutTests/platform/chromium-win/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png.
* platform/chromium-win/platform/chromium/virtual/softwarecompositing/culling/translated-boxshadow-expected.png: Copied from LayoutTests/platform/chromium-win/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png.
* platform/chromium-win/platform/chromium/virtual/softwarecompositing/culling/unscrolled-within-boxshadow-expected.png: Copied from LayoutTests/platform/chromium-win/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png.
* platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/clipping-foreground-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/foreground-layer-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/softwarecompositing/iframes/composited-iframe-alignment-expected.png:
* platform/chromium-win/platform/chromium/virtual/softwarecompositing/masks/masked-ancestor-expected.png:
* platform/chromium-win/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.png:
* platform/chromium-win/svg/css/circle-in-mask-with-shadow-expected.png:
* platform/chromium-win/svg/css/path-with-shadow-expected.png:
* platform/chromium-win/svg/css/shadow-and-opacity-expected.png:
* platform/chromium-win/svg/css/shadow-with-large-radius-expected.png:
* platform/chromium-win/svg/css/shadow-with-negative-offset-expected.png:
* platform/chromium-win/svg/css/stars-with-shadow-expected.png:
* platform/chromium-win/svg/css/text-gradient-shadow-expected.png:
* platform/chromium-win/svg/css/text-shadow-multiple-expected.png:
* platform/chromium-win/svg/custom/repaint-shadow-expected.png:
* platform/chromium-win/svg/filters/shadow-on-rect-with-filter-expected.png:
* platform/chromium-win/transitions/svg-text-shadow-transition-expected.png:
* platform/chromium/TestExpectations:
* platform/efl-wk1/compositing/geometry/clipping-foreground-expected.png: Renamed from LayoutTests/platform/efl/compositing/geometry/clipping-foreground-expected.png.
* platform/efl-wk1/compositing/geometry/foreground-layer-expected.png: Renamed from LayoutTests/platform/efl/compositing/geometry/foreground-layer-expected.png.
* platform/efl-wk1/fast/borders/border-radius-constraints-expected.png: Renamed from LayoutTests/platform/efl/fast/borders/border-radius-constraints-expected.png.
* platform/efl-wk1/fast/borders/border-radius-split-inline-expected.png: Renamed from LayoutTests/platform/efl/fast/borders/border-radius-split-inline-expected.png.
* platform/efl-wk1/fast/borders/mixed-border-styles-radius-expected.png: Renamed from LayoutTests/platform/efl/fast/borders/mixed-border-styles-radius-expected.png.
* platform/efl-wk1/fast/box-shadow/inset-box-shadows-expected.png: Renamed from LayoutTests/platform/efl/fast/box-shadow/inset-box-shadows-expected.png.
* platform/efl-wk1/fast/box-shadow/inset-expected.png: Renamed from LayoutTests/platform/efl/fast/box-shadow/inset-expected.png.
* platform/efl-wk1/fast/css/box-shadow-and-border-radius-expected.png: Renamed from LayoutTests/platform/efl/fast/css/box-shadow-and-border-radius-expected.png.
* platform/efl-wk1/fast/css/shadow-multiple-expected.png: Renamed from LayoutTests/platform/efl/fast/css/shadow-multiple-expected.png.
* platform/efl-wk1/fast/multicol/shadow-breaking-expected.png: Renamed from LayoutTests/platform/efl/fast/multicol/shadow-breaking-expected.png.
* platform/efl-wk1/fast/repaint/moving-shadow-on-path-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/moving-shadow-on-path-expected.png.
* platform/efl-wk1/fast/text/shadow-translucent-fill-expected.png: Renamed from LayoutTests/platform/efl/fast/text/shadow-translucent-fill-expected.png.
* platform/efl-wk1/fast/text/stroking-decorations-expected.png: Renamed from LayoutTests/platform/efl/fast/text/stroking-decorations-expected.png.
* platform/efl-wk1/fast/text/stroking-expected.png: Renamed from LayoutTests/platform/efl/fast/text/stroking-expected.png.
* platform/efl-wk1/fast/writing-mode/box-shadow-horizontal-bt-expected.png: Renamed from LayoutTests/platform/efl/fast/writing-mode/box-shadow-horizontal-bt-expected.png.
* platform/efl-wk1/fast/writing-mode/box-shadow-vertical-lr-expected.png: Renamed from LayoutTests/platform/efl/fast/writing-mode/box-shadow-vertical-lr-expected.png.
* platform/efl-wk1/fast/writing-mode/box-shadow-vertical-rl-expected.png: Renamed from LayoutTests/platform/efl/fast/writing-mode/box-shadow-vertical-rl-expected.png.
* platform/efl-wk1/fast/writing-mode/english-lr-text-expected.png: Renamed from LayoutTests/platform/efl/fast/writing-mode/english-lr-text-expected.png.
* platform/efl-wk1/ietestcenter/css3/text/textshadow-001-expected.png: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-001-expected.png.
* platform/efl-wk1/ietestcenter/css3/text/textshadow-002-expected.png: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-002-expected.png.
* platform/efl-wk1/ietestcenter/css3/text/textshadow-003-expected.png: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-003-expected.png.
* platform/efl-wk1/ietestcenter/css3/text/textshadow-004-expected.png: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-004-expected.png.
* platform/efl-wk1/ietestcenter/css3/text/textshadow-010-expected.png: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-010-expected.png.
* platform/efl-wk1/svg/css/circle-in-mask-with-shadow-expected.png: Renamed from LayoutTests/platform/efl/svg/css/circle-in-mask-with-shadow-expected.png.
* platform/efl-wk1/svg/css/path-with-shadow-expected.png: Renamed from LayoutTests/platform/efl/svg/css/path-with-shadow-expected.png.
* platform/efl-wk1/svg/css/shadow-with-large-radius-expected.png: Renamed from LayoutTests/platform/efl/svg/css/shadow-with-large-radius-expected.png.
* platform/efl-wk1/svg/css/shadow-with-negative-offset-expected.png: Renamed from LayoutTests/platform/efl/svg/css/shadow-with-negative-offset-expected.png.
* platform/efl-wk1/svg/css/stars-with-shadow-expected.png: Renamed from LayoutTests/platform/efl/svg/css/stars-with-shadow-expected.png.
* platform/efl-wk1/svg/css/text-gradient-shadow-expected.png: Renamed from LayoutTests/platform/efl/svg/css/text-gradient-shadow-expected.png.
* platform/efl-wk1/svg/css/text-shadow-multiple-expected.png: Renamed from LayoutTests/platform/efl/svg/css/text-shadow-multiple-expected.png.
* platform/efl/fast/canvas/fillText-shadow-expected.txt: Removed.
* platform/gtk/fast/canvas/fillText-shadow-expected.txt: Removed.
* platform/gtk/svg/css/shadow-and-opacity-expected.png: Removed.
* svg/css/shadow-and-opacity-expected.png: Renamed from LayoutTests/platform/efl/svg/css/shadow-and-opacity-expected.png.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoShadowRoot should recalcStyle for itself
commit-queue@webkit.org [Wed, 5 Dec 2012 13:11:58 +0000 (13:11 +0000)]
ShadowRoot should recalcStyle for itself
https://bugs.webkit.org/show_bug.cgi?id=103933

Patch by Elliott Sprehn <esprehn@gmail.com> on 2012-12-05
Reviewed by Hajime Morita.

ShadowRoot should support recalcStyle just like Element instead of
having the code inside ElementShadow. This was once the case and
the dead method prototype for recalcShadowTreeStyle is still in
ShadowRoot.h.

No new tests, just refactoring.

* dom/ElementShadow.cpp:
(WebCore::ElementShadow::recalcStyle):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::recalcStyle):
* dom/ShadowRoot.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix text direction in datalist popup for time controls
keishi@webkit.org [Wed, 5 Dec 2012 12:56:29 +0000 (12:56 +0000)]
Fix text direction in datalist popup for time controls
https://bugs.webkit.org/show_bug.cgi?id=103853

Reviewed by Kent Tamura.

Source/WebCore:

The datalist entry value should be displayed with the same text direction as the date/time format.

Tests: platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew.html
       platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew.html
       platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew.html

* Resources/pagepopups/calendarPicker.js: Renamed isCalendarRTL to isLocaleRTL.
(CalendarPicker.prototype._layout):
(CalendarPicker.prototype.fixWindowSize):
(DaysTable.prototype._handleKey):
(MonthPickerDaysTable.prototype._handleKey):
(WeekPickerDaysTable.prototype._handleKey):
* Resources/pagepopups/suggestionPicker.css:
(.suggestion-list-entry .title): Title should have the same text direction as the locale.
(.locale-rtl .suggestion-list-entry .title):
* Resources/pagepopups/suggestionPicker.js:
(SuggestionPicker.prototype._layout): Add locale-rtl class if the isLocaleRTL is true.

Source/WebKit/chromium:

* src/DateTimeChooserImpl.cpp:
(WebKit::DateTimeChooserImpl::writeDocument): Renamed isCalendarRTL to isLocaleRTL.

LayoutTests:

* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium/TestExpectations:
* platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.txt: Added.
* platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew.html: Added.
* platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.txt: Added.
* platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew.html: Added.
* platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.txt: Added.
* platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[mac][chromium] Unreviewed gardening.
mkwst@chromium.org [Wed, 5 Dec 2012 12:54:28 +0000 (12:54 +0000)]
[mac][chromium] Unreviewed gardening.

Rebaselining tests after r136657 to pick up changes to console messages.

* platform/chromium-linux/http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt: Removed.
* platform/chromium-win/http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt: Removed.
* platform/mac-wk2/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[gtk] Unreviewed gardening.
mkwst@chromium.org [Wed, 5 Dec 2012 12:46:43 +0000 (12:46 +0000)]
[gtk] Unreviewed gardening.

Rebaselining tests after r136657 to pick up changes to console messages.

* platform/chromium-win/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt: Removed.
* platform/chromium/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt: Renamed from LayoutTests/platform/chromium-mac/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt.
* platform/gtk/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
* platform/gtk/http/tests/xmlhttprequest/access-control-preflight-async-header-denied-expected.txt: Added.
* platform/gtk/http/tests/xmlhttprequest/access-control-preflight-async-not-supported-expected.txt: Added.
* platform/gtk/svg/custom/polyline-setattribute-points-null-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix flickering when hiding page popup
keishi@webkit.org [Wed, 5 Dec 2012 12:38:47 +0000 (12:38 +0000)]
Fix flickering when hiding page popup
https://bugs.webkit.org/show_bug.cgi?id=104100

Reviewed by Kent Tamura.

Moving the page popup while hiding was causing flickering in some environments.

No new tests. Can't reproduce in layout test.

* Resources/pagepopups/pickerCommon.js:
(hideWindow): Don't move and just resize.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[qt] Unreviewed gardening.
mkwst@chromium.org [Wed, 5 Dec 2012 12:38:20 +0000 (12:38 +0000)]
[qt] Unreviewed gardening.

Rebaselining tests after r136657 to pick up changes to console messages.

* platform/qt/fast/media/mq-resolution-dpi-dpcm-warning-expected.txt: Added.
* platform/qt/fast/media/mq-resolution-expected.txt: Added.
* platform/qt/fast/media/w3c/test_media_queries-expected.txt: Added.
* platform/qt/svg/custom/polyline-setattribute-points-null-expected.txt:
    These shouldn't have had line numbers; they were all pointing to the
    end of the style or script block in which the message was generated.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Don't rely on QMimeDatabase for essential MIME types
allan.jensen@digia.com [Wed, 5 Dec 2012 12:37:27 +0000 (12:37 +0000)]
[Qt] Don't rely on QMimeDatabase for essential MIME types
https://bugs.webkit.org/show_bug.cgi?id=103865

Based on patch by Pierre Rossi.
Reviewed by Jocelyn Turcotte.

Extend the short static list to also include MIME types essential to WebKit,
and detect these first before checking the system mimedatabase.

* platform/qt/MIMETypeRegistryQt.cpp:
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
(WebCore::MIMETypeRegistry::getMIMETypeForPath):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] REGRESSION(r135399): It made qmltests::DoubleTapToZoom::test_double_zoomInA...
abecsi@webkit.org [Wed, 5 Dec 2012 12:32:00 +0000 (12:32 +0000)]
[Qt][WK2] REGRESSION(r135399): It made qmltests::DoubleTapToZoom::test_double_zoomInAndBack() API test fail
https://bugs.webkit.org/show_bug.cgi?id=103889

Reviewed by Jocelyn Turcotte.

The client should always be notified in PageViewportController::didChangeViewportAttributes
about the changed attributes not only if the minimum scale changed. This ensures that these
changes are propagated to QWebKitTest and the zoom stack of double-tap-to-zoom is reset correctly.
Also increase precision of scale comparisons since the current value resulted in flakyness in
scale related API tests.

* UIProcess/PageViewportController.cpp:
(WebKit::PageViewportController::didChangeViewportAttributes):
(WebKit::PageViewportController::updateMinimumScaleToFit):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[efl] Unreviewed gardening.
thiago.santos@intel.com [Wed, 5 Dec 2012 12:09:51 +0000 (12:09 +0000)]
[efl] Unreviewed gardening.

Rebaselining tests after r136657 to pick up changes to console messages.

Patch by Mike West <mkwst@chromium.org> on 2012-12-05

* platform/efl-wk1/fast/media/mq-resolution-dpi-dpcm-warning-expected.txt: Added.
* platform/efl-wk1/fast/media/mq-resolution-expected.txt: Added.
* platform/efl-wk1/fast/media/w3c/test_media_queries-expected.txt: Added.
* platform/efl-wk1/inspector/console/console-object-constructor-name-expected.txt: Added.
* platform/efl-wk2/fast/media/mq-resolution-dpi-dpcm-warning-expected.txt: Added.
* platform/efl-wk2/fast/media/mq-resolution-expected.txt: Added.
* platform/efl-wk2/fast/media/w3c/test_media_queries-expected.txt: Added.
    These shouldn't have had line numbers; they were all pointing to the
    end of the style or script block in which the message was generated.
* platform/efl-wk1/http/tests/xmlhttprequest/access-control-preflight-async-method-denied-expected.txt: Added.
* platform/efl-wk1/http/tests/xmlhttprequest/origin-whitelisting-https-expected.txt: Added.
    New stack trace.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[efl] Unreviewed gardening.
mkwst@chromium.org [Wed, 5 Dec 2012 11:45:09 +0000 (11:45 +0000)]
[efl] Unreviewed gardening.

Rebaselining tests after r136657 to pick up changes to console messages.

* platform/efl-wk1/fast/media/mq-resolution-dpi-dpcm-warning-expected.txt: Added.
* platform/efl-wk1/fast/media/mq-resolution-expected.txt: Added.
* platform/efl-wk1/fast/media/w3c/test_media_queries-expected.txt: Added.
* platform/efl-wk1/inspector/console/console-object-constructor-name-expected.txt: Added.
* platform/efl-wk2/fast/media/mq-resolution-dpi-dpcm-warning-expected.txt: Added.
* platform/efl-wk2/fast/media/mq-resolution-expected.txt: Added.
* platform/efl-wk2/fast/media/w3c/test_media_queries-expected.txt: Added.
    These shouldn't have had line numbers; they were all pointing to the
    end of the style or script block in which the message was generated.
* platform/efl-wk1/http/tests/xmlhttprequest/access-control-preflight-async-method-denied-expected.txt: Added.
* platform/efl-wk1/http/tests/xmlhttprequest/origin-whitelisting-https-expected.txt: Added.
    New stack trace.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLayout Test fast/forms/*-multiple-fields/*-multiple-fields-preserve-value-after-histo...
tkent@chromium.org [Wed, 5 Dec 2012 11:34:42 +0000 (11:34 +0000)]
Layout Test fast/forms/*-multiple-fields/*-multiple-fields-preserve-value-after-history-back.html are slow
https://bugs.webkit.org/show_bug.cgi?id=104094

Reviewed by Kentaro Hara.

Make them faster by spliting them into the main frame HTML files
and the sub frame HTML files. The sub frame HTML files are loaded
five times in one test, and don't need to load
js-test-pre/post.js. This change makes them about 2x faster on my
local machine.

* fast/forms/date-multiple-fields/date-multiple-fields-preserve-value-after-history-back.html:
* fast/forms/date-multiple-fields/resources/preserve-value-after-history-back-frame.html: Copied from LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-preserve-value-after-history-back.html.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-preserve-value-after-history-back.html:
* fast/forms/datetimelocal-multiple-fields/resources/preserve-value-after-history-back-frame.html: Copied from LayoutTests/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-preserve-value-after-history-back.html.
* fast/forms/month-multiple-fields/month-multiple-fields-preserve-value-after-history-back.html:
* fast/forms/month-multiple-fields/resources/preserve-value-after-history-back-frame.html: Copied from LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-preserve-value-after-history-back.html.
* fast/forms/time-multiple-fields/resources/preserve-value-after-history-back-frame.html: Copied from LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back.html.
* fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back.html:
* fast/forms/week-multiple-fields/resources/preserve-value-after-history-back-frame.html: Copied from LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-preserve-value-after-history-back.html.
* fast/forms/week-multiple-fields/week-multiple-fields-preserve-value-after-history-back.html:
* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening.
zandobersek@gmail.com [Wed, 5 Dec 2012 11:32:40 +0000 (11:32 +0000)]
Unreviewed gardening.

Moving Chromium's baseline for media/track/opera/interfaces/TextTrack/addCue.html
(that contains correct, platform-agnostic results) alongside the test.

* media/track/opera/interfaces/TextTrack/addCue-expected.txt: Copied from LayoutTests/platform/chromium/media/track/opera/interfaces/TextTrack/addCue-expected.txt.
* platform/chromium/media/track/opera/interfaces/TextTrack/addCue-expected.txt: Removed.
* platform/efl/TestExpectations: Removed the missing expectation for this test.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Wed, 5 Dec 2012 11:12:48 +0000 (11:12 +0000)]
Unreviewed GTK gardening.

Adding a platform-specific baseline for fast/css/image-set-value-not-removed-crash.html.
Adding a failure expectation for svg/custom/use-href-update-crash.html.

* platform/gtk/TestExpectations:
* platform/gtk/fast/css/image-set-value-not-removed-crash-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening.
mkwst@chromium.org [Wed, 5 Dec 2012 10:45:17 +0000 (10:45 +0000)]
Unreviewed gardening.

fast/frames/viewsource-on-image-file.html and
fast/overflow/scrollbar-click-retains-focus.html are failing on every
port. Skipping.

* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoOptimize ColorMatrix filter
zherczeg@webkit.org [Wed, 5 Dec 2012 10:35:59 +0000 (10:35 +0000)]
Optimize ColorMatrix filter
https://bugs.webkit.org/show_bug.cgi?id=103728

Reviewed by Dirk Schulze.

ColorMatrix filter recalculates several constants for
every pixel. It is enough to do these calculations only
once during the initialization. Style issues also fixed.

Existing tests cover this feature.

* platform/graphics/filters/FEColorMatrix.cpp:
(WebCore::matrix):
(WebCore::saturateAndHueRotate):
(WebCore::effectType):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFlex item auto margins in the cross direction should safe center
carlosgc@webkit.org [Wed, 5 Dec 2012 10:24:55 +0000 (10:24 +0000)]
Flex item auto margins in the cross direction should safe center
https://bugs.webkit.org/show_bug.cgi?id=103919

Reviewed by Ojan Vafai.

Source/WebCore:

Do not apply auto margins for cross axis if there's no alignment
space available.

Test: css3/flexbox/flex-flow-auto-margins-no-available-space.html

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::alignChildren): Make sure we pass a
positive value for availableAlignmentSpace to
updateAutoMarginsInCrossAxis().

LayoutTests:

* css3/flexbox/flex-flow-auto-margins-no-available-space-expected.txt: Added.
* css3/flexbox/flex-flow-auto-margins-no-available-space.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[mac][gtk] Unreviewed gardening.
mkwst@chromium.org [Wed, 5 Dec 2012 10:22:52 +0000 (10:22 +0000)]
[mac][gtk] Unreviewed gardening.

fast/overflow/scrollbar-click-retains-focus.html was added in r136646
and fails only on Mac WK1, and GTK. Skipping.

* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CoordinatedGraphics] Use unsigned integers for CoordinatedTile IDs
christophe.dumez@intel.com [Wed, 5 Dec 2012 10:11:40 +0000 (10:11 +0000)]
[CoordinatedGraphics] Use unsigned integers for CoordinatedTile IDs
https://bugs.webkit.org/show_bug.cgi?id=103816

Reviewed by Jocelyn Turcotte.

Use unsigned integer for CoordinatedTile identifier type.
CoordinatedTile was previously using signed integers for
its identifier which is unsafe because the generated ID
will overflow at some point and the C and C++ language
standards say that overflow of a signed value is undefined
behaviour.

* UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp:
(WebKit::CoordinatedBackingStore::createTile):
(WebKit::CoordinatedBackingStore::removeTile):
(WebKit::CoordinatedBackingStore::removeAllTiles):
(WebKit::CoordinatedBackingStore::updateTile):
(WebKit::CoordinatedBackingStore::texture):
(WebKit::CoordinatedBackingStore::paintToTextureMapper):
(WebKit::CoordinatedBackingStore::commitTileOperations):
* UIProcess/CoordinatedGraphics/CoordinatedBackingStore.h:
(CoordinatedBackingStore):
* UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:
(WebKit::LayerTreeCoordinatorProxy::createTileForLayer):
(WebKit::LayerTreeCoordinatorProxy::updateTileForLayer):
(WebKit::LayerTreeCoordinatorProxy::removeTileForLayer):
* UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.h:
(LayerTreeCoordinatorProxy):
* UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.messages.in:
* UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
(WebKit::LayerTreeRenderer::createTile):
(WebKit::LayerTreeRenderer::removeTile):
(WebKit::LayerTreeRenderer::updateTile):
* UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:
(LayerTreeRenderer):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::createTile):
(WebCore::CoordinatedGraphicsLayer::updateTile):
(WebCore::CoordinatedGraphicsLayer::removeTile):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayerClient):
(CoordinatedGraphicsLayer):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedTile.cpp:
(WebKit):
(WebKit::CoordinatedTile::CoordinatedTile):
(WebKit::CoordinatedTile::~CoordinatedTile):
(WebKit::CoordinatedTile::updateBackBuffer):
(WebKit::CoordinatedTile::isReadyToPaint):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedTile.h:
(CoordinatedTile):
(CoordinatedTileClient):
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::createTile):
(WebKit::LayerTreeCoordinator::updateTile):
(WebKit::LayerTreeCoordinator::removeTile):
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:
(LayerTreeCoordinator):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Autogenerate stack traces and line numbers when possible.
mkwst@chromium.org [Wed, 5 Dec 2012 10:02:25 +0000 (10:02 +0000)]
Web Inspector: Autogenerate stack traces and line numbers when possible.
https://bugs.webkit.org/show_bug.cgi?id=100650

Reviewed by Yury Semikhatsky.

Source/WebCore:

Console messages generated in WebCore generally are asked to do a bit of
work in order to provide a developer with a detailed report. We ask the
caller to either generate stack traces, or pass in a url/line number
pair, which can be a bit of work. Predictably, most callers don't pass
in what we'd like to see.

This patch creates a new, simpler console message generation API that we
expect most call sites to use. Source, type, level, and message are
required, and an optional request ID can be passed in. Everything else
will be autogenerated inside ConsoleMessage when appropriate.

In a subsequent patch, we expect to be able to trim down more of the
external call sites (ContentSecurityPolicy springs to mind) in order to
further consolidate the external interface. Simple is good.

* Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::connect):
* Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::didFailSocketStream):
    Drop the now-redundant URL parameter from various WebSocket errors.
* css/MediaList.cpp:
(WebCore::addResolutionWarningMessageToConsole):
    Switch to Document::addConsoleMessage, which means that we can move
    line-number generation out of MediaList.
* dom/Document.cpp:
(WebCore::Document::logExceptionToConsole):
    Use the long-form 'addMessage()' rather than the public interface.
(WebCore::Document::processHttpEquiv):
    Drop the URL parameter, as it's now autogenerated.
(WebCore::Document::addConsoleMessage):
(WebCore):
* dom/Document.h:
(Document):
    Override the pure virtual method on ScriptExecutionContext, and pass
    the call through to the new Console::addMessage, which accepts a
    pointer to the Document in order to do line-number generation.
* dom/ScriptExecutionContext.h:
(ScriptExecutionContext):
    Add a pure virtual variant of addConsoleMessage which accepts only
    bare minimum data, and expects autogeneration of the rest.
    Additionally, ensure that the other variants always have either a
    URL/line number, or a stack trace.
* dom/ViewportArguments.cpp:
(WebCore::reportViewportWarning):
    Drop line numbers and URLs from Viewport warnings. We can generate
    these now.
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::validateInteractively):
    Drop the URL from form autofocus warnings
* html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::parseAttribute):
    Drop the URL and line from sandbox attribute warnings.
* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::printWarningToConsole):
    Drop the URL from WebGL warnings.
* inspector/ConsoleMessage.cpp:
(WebCore::ConsoleMessage::ConsoleMessage):
    Call 'autogenerateMetadata' to ensure that a stack trace is
    generated if one isn't provided. Create a new constructor that
    accepts a ScriptState/ScriptArguments pair, and use it for console
    API calls.
(WebCore):
(WebCore::ConsoleMessage::autogenerateMetadata):
    Generate a stack trace given whatever information we've got.
* inspector/ConsoleMessage.h:
(ConsoleMessage):
    Create a new constructor that accepts a ScriptState/ScriptArguments
    pair, and use it for console API calls.
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::enable):
    Use the short-form ConsoleMessage constructor.
(WebCore::InspectorConsoleAgent::addMessageToConsole):
    Use the stack-only constructor, or the ScriptState
    constructor, as appropriate.
(WebCore::InspectorConsoleAgent::count):
    We generated a stack, pass it in.
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::isWorkerAgent):
* inspector/PageConsoleAgent.h:
(WebCore::PageConsoleAgent::isWorkerAgent):
* inspector/PageConsoleAgent.h:
(WebCore::PageConsoleAgent::isWorkerAgent):
    We only want to generate call stacks for non-Workers (because
    createScriptCallStack explodes in JSC if we're not on the main
    thread). This method will allow us to distinguish between those
    messages generated from Workers, and those from Pages.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions):
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::didReceiveResponse):
    Drop the URL parameter from the console message for X-Frame-Options
    parsing errors.
* page/Console.cpp:
(WebCore::Console::addMessage):
    When given a Document*, generate a line number if: 1) the document
    is still being parsed, 2) the document is not in document.write(),
    3) the parser isn't waiting for script, and 4) the parser isn't
    executing script. Many callsites didn't check all of these, which
    is why the SVG rebaseline (for example) drops lots and lots of line
    numbers which point at a closing '</script>' tag.
(WebCore):
* page/Console.h:
(WebCore):
(Console):
    Update the public API to accept a Document* and little else.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::printErrorMessage):
    Don't generate a stack here. We can do it later.
* svg/SVGDocumentExtensions.cpp:
(WebCore::reportMessage):
    Drop the URL and line number. We'll generate them. It'll be sweet.
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::addConsoleMessage):
(WebCore):
* workers/WorkerContext.h:
(WorkerContext):
    Implement the new addConsoleMessage variant.

LayoutTests:

New line numbers! Huzzah! (Also, removing some that shouldn't be there).

* http/tests/inspector/console-xhr-logging-expected.txt:
* platform/chromium/http/tests/inspector/console-xhr-logging-expected.txt:
    One new stack trace! OMG!
* fast/frames/sandboxed-iframe-autofocus-denied-expected.txt:
* fast/frames/sandboxed-iframe-parsing-space-characters-expected.txt:
* fast/frames/xss-auditor-handles-file-urls-expected.txt:
* html5lib/run-test11-expected.txt:
* http/tests/misc/bubble-drag-events-expected.txt:
* http/tests/misc/drag-over-iframe-invalid-source-crash-expected.txt:
* http/tests/misc/iframe-invalid-source-crash-expected.txt:
* http/tests/misc/image-blocked-src-change-expected.txt:
* http/tests/misc/image-blocked-src-no-change-expected.txt:
* http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
* http/tests/security/frame-loading-via-document-write-expected.txt:
* http/tests/security/mixedContent/insecure-css-in-iframe-expected.txt:
* http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt:
* http/tests/security/mixedContent/insecure-image-in-main-frame-expected.txt:
* http/tests/security/xss-DENIED-xml-external-entity-expected.txt:
* http/tests/security/xssAuditor/base-href-control-char-expected.txt:
* http/tests/security/xssAuditor/base-href-expected.txt:
* http/tests/security/xssAuditor/base-href-null-char-expected.txt:
* http/tests/security/xssAuditor/base-href-scheme-relative-expected.txt:
* http/tests/security/xssAuditor/cookie-injection-expected.txt:
* http/tests/security/xssAuditor/embed-tag-code-attribute-2-expected.txt:
* http/tests/security/xssAuditor/embed-tag-code-attribute-expected.txt:
* http/tests/security/xssAuditor/embed-tag-control-char-expected.txt:
* http/tests/security/xssAuditor/embed-tag-expected.txt:
* http/tests/security/xssAuditor/embed-tag-javascript-url-expected.txt:
* http/tests/security/xssAuditor/embed-tag-null-char-expected.txt:
* http/tests/security/xssAuditor/form-action-expected.txt:
* http/tests/security/xssAuditor/full-block-base-href-expected.txt:
* http/tests/security/xssAuditor/full-block-get-from-iframe-expected.txt:
* http/tests/security/xssAuditor/full-block-iframe-javascript-url-expected.txt:
* http/tests/security/xssAuditor/full-block-iframe-no-inherit-expected.txt:
* http/tests/security/xssAuditor/full-block-javascript-link-expected.txt:
* http/tests/security/xssAuditor/full-block-link-onclick-expected.txt:
* http/tests/security/xssAuditor/full-block-object-tag-expected.txt:
* http/tests/security/xssAuditor/full-block-post-from-iframe-expected.txt:
* http/tests/security/xssAuditor/full-block-script-tag-expected.txt:
* http/tests/security/xssAuditor/full-block-script-tag-with-source-expected.txt:
* http/tests/security/xssAuditor/get-from-iframe-expected.txt:
* http/tests/security/xssAuditor/iframe-injection-expected.txt:
* http/tests/security/xssAuditor/iframe-javascript-url-expected.txt:
* http/tests/security/xssAuditor/iframe-javascript-url-more-encoding-expected.txt:
* http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode-expected.txt:
* http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode2-expected.txt:
* http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode3-expected.txt:
* http/tests/security/xssAuditor/iframe-javascript-url-url-encoded-expected.txt:
* http/tests/security/xssAuditor/iframe-onload-GBK-char-expected.txt:
* http/tests/security/xssAuditor/iframe-onload-in-svg-tag-expected.txt:
* http/tests/security/xssAuditor/iframe-srcdoc-expected.txt:
* http/tests/security/xssAuditor/img-onerror-GBK-char-expected.txt:
* http/tests/security/xssAuditor/img-onerror-accented-char-expected.txt:
* http/tests/security/xssAuditor/img-onerror-non-ASCII-char-default-encoding-expected.txt:
* http/tests/security/xssAuditor/img-onerror-non-ASCII-char-expected.txt:
* http/tests/security/xssAuditor/img-onerror-non-ASCII-char2-default-encoding-expected.txt:
* http/tests/security/xssAuditor/img-onerror-non-ASCII-char2-expected.txt:
* http/tests/security/xssAuditor/inline-event-HTML-entities-expected.txt:
* http/tests/security/xssAuditor/javascript-link-HTML-entities-control-char-expected.txt:
* http/tests/security/xssAuditor/javascript-link-HTML-entities-expected.txt:
* http/tests/security/xssAuditor/javascript-link-HTML-entities-named-expected.txt:
* http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt:
* http/tests/security/xssAuditor/javascript-link-ampersand-expected.txt:
* http/tests/security/xssAuditor/javascript-link-control-char-expected.txt:
* http/tests/security/xssAuditor/javascript-link-expected.txt:
* http/tests/security/xssAuditor/javascript-link-null-char-expected.txt:
* http/tests/security/xssAuditor/javascript-link-one-plus-one-expected.txt:
* http/tests/security/xssAuditor/javascript-link-url-encoded-expected.txt:
* http/tests/security/xssAuditor/link-onclick-ampersand-expected.txt:
* http/tests/security/xssAuditor/link-onclick-control-char-expected.txt:
* http/tests/security/xssAuditor/link-onclick-entities-expected.txt:
* http/tests/security/xssAuditor/link-onclick-expected.txt:
* http/tests/security/xssAuditor/link-onclick-null-char-expected.txt:
* http/tests/security/xssAuditor/link-opens-new-window-expected.txt:
* http/tests/security/xssAuditor/malformed-HTML-expected.txt:
* http/tests/security/xssAuditor/malformed-xss-protection-header-1-expected.txt:
* http/tests/security/xssAuditor/malformed-xss-protection-header-2-expected.txt:
* http/tests/security/xssAuditor/malformed-xss-protection-header-3-expected.txt:
* http/tests/security/xssAuditor/malformed-xss-protection-header-4-expected.txt:
* http/tests/security/xssAuditor/malformed-xss-protection-header-5-expected.txt:
* http/tests/security/xssAuditor/malformed-xss-protection-header-6-expected.txt:
* http/tests/security/xssAuditor/malformed-xss-protection-header-7-expected.txt:
* http/tests/security/xssAuditor/malformed-xss-protection-header-8-expected.txt:
* http/tests/security/xssAuditor/malformed-xss-protection-header-9-expected.txt:
* http/tests/security/xssAuditor/meta-tag-http-refresh-javascript-url-expected.txt:
* http/tests/security/xssAuditor/object-embed-tag-control-char-expected.txt:
* http/tests/security/xssAuditor/object-embed-tag-expected.txt:
* http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt:
* http/tests/security/xssAuditor/object-tag-expected.txt:
* http/tests/security/xssAuditor/object-tag-javascript-url-expected.txt:
* http/tests/security/xssAuditor/open-attribute-body-expected.txt:
* http/tests/security/xssAuditor/open-event-handler-iframe-expected.txt:
* http/tests/security/xssAuditor/open-iframe-src-expected.txt:
* http/tests/security/xssAuditor/open-script-src-expected.txt:
* http/tests/security/xssAuditor/post-from-iframe-expected.txt:
* http/tests/security/xssAuditor/property-escape-comment-expected.txt:
* http/tests/security/xssAuditor/property-escape-entity-expected.txt:
* http/tests/security/xssAuditor/property-escape-expected.txt:
* http/tests/security/xssAuditor/property-escape-long-expected.txt:
* http/tests/security/xssAuditor/property-escape-quote-expected.txt:
* http/tests/security/xssAuditor/report-script-tag-expected.txt:
* http/tests/security/xssAuditor/script-tag-Big5-char-expected.txt:
* http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-16bit-unicode-expected.txt:
* http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-expected.txt:
* http/tests/security/xssAuditor/script-tag-Big5-char2-expected.txt:
* http/tests/security/xssAuditor/script-tag-addslashes-backslash-expected.txt:
* http/tests/security/xssAuditor/script-tag-addslashes-double-quote-expected.txt:
* http/tests/security/xssAuditor/script-tag-addslashes-null-char-expected.txt:
* http/tests/security/xssAuditor/script-tag-addslashes-single-quote-expected.txt:
* http/tests/security/xssAuditor/script-tag-control-char-expected.txt:
* http/tests/security/xssAuditor/script-tag-convoluted-expected.txt:
* http/tests/security/xssAuditor/script-tag-entities-expected.txt:
* http/tests/security/xssAuditor/script-tag-expected.txt:
* http/tests/security/xssAuditor/script-tag-inside-svg-tag-expected.txt:
* http/tests/security/xssAuditor/script-tag-inside-svg-tag2-expected.txt:
* http/tests/security/xssAuditor/script-tag-inside-svg-tag3-expected.txt:
* http/tests/security/xssAuditor/script-tag-null-char-expected.txt:
* http/tests/security/xssAuditor/script-tag-open-redirect-expected.txt:
* http/tests/security/xssAuditor/script-tag-post-control-char-expected.txt:
* http/tests/security/xssAuditor/script-tag-post-expected.txt:
* http/tests/security/xssAuditor/script-tag-post-null-char-expected.txt:
* http/tests/security/xssAuditor/script-tag-redirect-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-16bit-unicode-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-16bit-unicode-surrogate-pair-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-16bit-unicode2-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-16bit-unicode3-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-16bit-unicode4-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-16bit-unicode5-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-actual-comma-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-callbacks-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-comma-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-fancy-unicode-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-invalid-closing-tag-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-invalid-url-encoding-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-source-control-char-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-source-data-url-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-source-data-url2-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-source-data-url3-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-source-double-quote-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-source-entities-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-source-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-source-no-quote-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-source-null-char-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-source-relative-scheme-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-source-same-host-with-query-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-source-unterminated-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-three-times-url-encoded-16bit-unicode-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-trailing-comment-U2028-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-trailing-comment-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-trailing-comment2-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-trailing-comment3-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-trailing-comment4-expected.txt:
* http/tests/security/xssAuditor/xss-filter-bypass-big5-expected.txt:
* http/tests/security/xssAuditor/xss-filter-bypass-long-string-expected.txt:
* http/tests/security/xssAuditor/xss-filter-bypass-sjis-expected.txt:
* http/tests/security/xssAuditor/xss-protection-parsing-01-expected.txt:
* http/tests/security/xssAuditor/xss-protection-parsing-02-expected.txt:
* http/tests/security/xssAuditor/xss-protection-parsing-03-expected.txt:
* http/tests/security/xssAuditor/xss-protection-parsing-04-expected.txt:
* platform/chromium-mac/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
* platform/chromium/http/tests/misc/bubble-drag-events-expected.txt:
* platform/chromium/http/tests/misc/drag-over-iframe-invalid-source-crash-expected.txt:
* platform/chromium/http/tests/misc/iframe-invalid-source-crash-expected.txt:
* platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-allowed-expected.txt:
* platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-blocked-expected.txt:
* platform/chromium/http/tests/security/xssAuditor/javascript-link-control-char2-expected.txt:
* platform/chromium/svg/custom/polyline-setattribute-points-null-expected.txt:
* platform/mac/svg/custom/clip-path-referencing-use2-expected.txt:
* platform/mac/svg/custom/polyline-setattribute-points-null-expected.txt:
* svg/custom/invalid-length-units-expected.txt:
* svg/custom/poly-parsing-error-expected.txt:
* svg/dom/SVGScriptElement/script-onerror-bubbling-expected.txt:
* svg/dom/fuzz-path-parser-expected.txt:
* svg/dom/path-parser-expected.txt:
* svg/dom/points-parser-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReduce the children repaints when moved multiple times during the layout
carlosgc@webkit.org [Wed, 5 Dec 2012 09:54:12 +0000 (09:54 +0000)]
Reduce the children repaints when moved multiple times during the layout
https://bugs.webkit.org/show_bug.cgi?id=103510

Reviewed by Darin Adler.

Source/WebCore:

Cache the children positions before the layout and move to the
final position after the layout.

Test: css3/flexbox/repaint-column-reverse.html

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::OrderIterator::OrderIterator): Do not
call first() on the consructor.
(WebCore::RenderFlexibleBox::layoutBlock): Use a Vector with the
children frame rects before the layout and call
repaintChildrenDuringLayoutIfMoved() to repaint the children that
have been moved.
(WebCore::RenderFlexibleBox::appendChildrenFrameRects): Return a
Vector with children frame rects.
(WebCore::RenderFlexibleBox::repaintChildrenDuringLayoutIfMoved):
Call repaintDuringLayoutIfMoved() for every children using the old
frame rects.
(WebCore::RenderFlexibleBox::setFlowAwareLocationForChild): Do not
call repaintDuringLayoutIfMoved().
(WebCore::RenderFlexibleBox::layoutFlexItems): Make sure the
passed iterator points to the first child.
* rendering/RenderFlexibleBox.h:

LayoutTests:

Add test to check that for flex items moved multiple times during the
layout, only the initial and final positions are repainted.

* css3/flexbox/repaint-column-reverse-expected.txt: Added.
* css3/flexbox/repaint-column-reverse.html: Added.
* platform/chromium-linux/css3/flexbox/repaint-column-reverse-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Unreviewed gardening.
dominik.rottsches@intel.com [Wed, 5 Dec 2012 09:42:18 +0000 (09:42 +0000)]
[EFL] Unreviewed gardening.

Rebaselining viewsource* after r126683.
Adding new baseline for orientation-sideways, new test.
Moving addCue test to TestExpectations until it's fixed in bug 103925.

* platform/efl-wk2/fast/frames/viewsource-attribute-expected.png: Added.
* platform/efl-wk2/fast/frames/viewsource-attribute-expected.txt: Added.
* platform/efl-wk2/fast/frames/viewsource-on-image-file-expected.png: Added.
* platform/efl-wk2/fast/frames/viewsource-on-image-file-expected.txt: Added.
* platform/efl/TestExpectations:
* platform/efl/fast/text/orientation-sideways-expected.png: Added.
* platform/efl/fast/text/orientation-sideways-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Add APIs to get/set private browsing.
commit-queue@webkit.org [Wed, 5 Dec 2012 09:38:32 +0000 (09:38 +0000)]
[EFL][WK2] Add APIs to get/set private browsing.
https://bugs.webkit.org/show_bug.cgi?id=102052

Patch by Yuni Jeong <yhnet.jung@samsung.com> on 2012-12-05
Reviewed by Gyuyoung Kim.

Private Browsing allows a user to browse the Internet without saving any information about which sites and pages a user has visited.

* UIProcess/API/efl/ewk_settings.cpp:
(ewk_settings_private_browsing_enabled_set):
(ewk_settings_private_browsing_enabled_get):
* UIProcess/API/efl/ewk_settings.h:
* UIProcess/API/efl/tests/test_ewk2_settings.cpp:
(TEST_F):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed gardening.
mkwst@chromium.org [Wed, 5 Dec 2012 09:03:53 +0000 (09:03 +0000)]
[chromium] Unreviewed gardening.

fast/text/hyphenate-character.html, fast/text/hyphenate-first-word.html
fast/text/hyphenate-locale.html, and fast/text/hyphens.html have started
failing on Linux. Widening the skip to cover that platform as well (they
were already skipped for Windows, Mac, and Android.

* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] toV8Fast for all classes with ScriptWrapper Holder objects
jochen@chromium.org [Wed, 5 Dec 2012 09:03:33 +0000 (09:03 +0000)]
[V8] toV8Fast for all classes with ScriptWrapper Holder objects
https://bugs.webkit.org/show_bug.cgi?id=102686

Patch by Dan Carney <dcarney@google.com> on 2012-12-05
Reviewed by Adam Barth.

This patch makes most generated bindings use toV8Fast
by adding a fast path to the main world DOMDataStore.
Additionally, toV8Fast is now being called on callbacks
which use v8::Arguments.

No new tests. No change in functionality.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateNormalAttrGetter):
(GenerateFunctionCallString):
(NativeToJSValue):
* bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::mainWorldStore):
(WebCore::DOMDataStore::current):
* bindings/v8/DOMDataStore.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Canvas] nit: add more typization for js compiler
aandrey@chromium.org [Wed, 5 Dec 2012 08:45:29 +0000 (08:45 +0000)]
Web Inspector: [Canvas] nit: add more typization for js compiler
https://bugs.webkit.org/show_bug.cgi?id=103994

Reviewed by Pavel Feldman.

* inspector/InjectedScriptCanvasModuleSource.js:
(.):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoURL schemes registered as local, no access, display isolated and as CORS enabled...
commit-queue@webkit.org [Wed, 5 Dec 2012 08:26:37 +0000 (08:26 +0000)]
URL schemes registered as local, no access, display isolated and as CORS enabled are not registered again after a web process crash
https://bugs.webkit.org/show_bug.cgi?id=104013

Patch by Joaquim Rocha <jrocha@igalia.com> on 2012-12-05
Reviewed by Darin Adler.

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess): Iterate through the schemes stored in
urlSchemesRegisteredAsLocal, urlSchemesRegisteredAsNoAccess,
urlSchemesRegisteredAsDisplayIsolated and urlSchemesRegisteredAsCORSEnabled and
call the respective (already existing) methods for registering them.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, WebKit gardening.
tasak@google.com [Wed, 5 Dec 2012 08:26:27 +0000 (08:26 +0000)]
Unreviewed, WebKit gardening.
https://bugs.webkit.org/show_bug.cgi?id=103487

* platform/chromium/TestExpectations:
fast/forms/placeholder-position.html is flaky on linux.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, WebKit gardening.
tasak@google.com [Wed, 5 Dec 2012 08:13:57 +0000 (08:13 +0000)]
Unreviewed, WebKit gardening.
https://bugs.webkit.org/show_bug.cgi?id=104092

* platform/chromium/TestExpectations:
Mark fast/frames/paint-iframe-background.html as flaky.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Exclusions] ExclusionShape inlines should use isFlippedBlocksWritingMode()
commit-queue@webkit.org [Wed, 5 Dec 2012 08:03:58 +0000 (08:03 +0000)]
[CSS Exclusions] ExclusionShape inlines should use isFlippedBlocksWritingMode()
https://bugs.webkit.org/show_bug.cgi?id=103939

Patch by Hans Muller <hmuller@adobe.com> on 2012-12-05
Reviewed by Dirk Schulze.

Just a minor cleanup: the protected ExclusionShape inlines, like minYForLogicalLine(),
now use isFlippedBlocksWritingMode() instead of testing for RightToLeftWritingMode directly.
This changeimproves consistency with the rest of WebKit and will work correctly
if "horizontal-bt" writing-mode support is ever added.

No new tests were added since the existing tests cover these methods.

* rendering/ExclusionShape.h:
(WebCore::ExclusionShape::minYForLogicalLine):
(WebCore::ExclusionShape::maxYForLogicalLine):
(WebCore::ExclusionShape::internalToLogicalBoundingBox):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAbsolutely positioned non-replaced elements should resolve vertical margins against
commit-queue@webkit.org [Wed, 5 Dec 2012 08:02:47 +0000 (08:02 +0000)]
Absolutely positioned non-replaced elements should resolve vertical margins against
their containing block's logical width
https://bugs.webkit.org/show_bug.cgi?id=103576

Patch by Bear Travis <betravis@adobe.com> on 2012-12-05
Reviewed by Emil A Eklund.

Source/WebCore:

According to the CSS box model specification, all percentage margin & padding values,
including top & bottom, should be resolved based on the containing block's width.
http://www.w3.org/TR/CSS2/box.html#margin-properties
The writing modes specification has refined this definition to use the containing
block's logical width to resolve percentage margin & padding values.
http://dev.w3.org/csswg/css3-writing-modes/#dimension-mapping

Previously, positioned elements measured their container in the element's block
direction (containerLogicalHeight) to resolve margin-before/after, and in the inline
direction (containerLogicalWidth) to resolve margin-start/end. This patch measures the
container's logical width in its own inline direction (containerRelativeLogicalWidth)
to resolve all margin percentage values.

Test: fast/writing-mode/percentage-margins-absolute.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computePositionedLogicalWidthUsing): Calculate the logical width
of the container, and use it to calculate margins.
(WebCore::RenderBox::computePositionedLogicalHeightUsing): Ditto.

LayoutTests:

Test that different writing mode combinations between a parent and child correctly
compute percentage margins for an absolutely positioned child.

* fast/writing-mode/percentage-margins-absolute-expected.txt: Added.
* fast/writing-mode/percentage-margins-absolute.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Replace String::New("symbol") with String::NewSymbol("symbol") (part 2)
haraken@chromium.org [Wed, 5 Dec 2012 08:01:33 +0000 (08:01 +0000)]
[V8] Replace String::New("symbol") with String::NewSymbol("symbol") (part 2)
https://bugs.webkit.org/show_bug.cgi?id=104082

Reviewed by Adam Barth.

V8 can look up symbols faster than strings.

No tests. No change in behavior.

* bindings/v8/custom/V8ArrayBufferViewCustom.cpp:
(WebCore::getHiddenCopyMethod):
(WebCore::installHiddenCopyMethod):
* bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore::constructWebGLArray):
(WebCore::setWebGLArrayHelper):
* bindings/v8/custom/V8CustomXPathNSResolver.cpp:
(WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::DialogHandler::dialogCreated):
(WebCore::DialogHandler::returnValue):
* bindings/v8/custom/V8GeolocationCustom.cpp:
(WebCore::createPositionOptions):
* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::V8HTMLDocument::wrapInShadowObject):
(WebCore::V8HTMLDocument::openCallback):
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::V8HTMLImageElementConstructor::GetTemplate):
* bindings/v8/custom/V8SQLTransactionCustom.cpp:
(WebCore::V8SQLTransaction::executeSqlCallback):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, WebKit gardening.
tasak@google.com [Wed, 5 Dec 2012 07:07:51 +0000 (07:07 +0000)]
Unreviewed, WebKit gardening.
https://bugs.webkit.org/show_bug.cgi?id=104090

* platform/chromium/TestExpectations:
Mark fast/css-grid-layout/grid-columns-rows-get-set-multiple.html and
fast/css-grid-layout/grid-columns-rows-get-set.html as crash on Mac
Debug.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, WebKit gardening.
tasak@google.com [Wed, 5 Dec 2012 06:30:46 +0000 (06:30 +0000)]
Unreviewed, WebKit gardening.

* platform/chromium/TestExpectations:
Mark fast/frames/viewsource-attribute.html and
viewsource-on-image-file.html as failure.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: Clicking a scrollbar unfocuses the current activeElement
commit-queue@webkit.org [Wed, 5 Dec 2012 06:23:16 +0000 (06:23 +0000)]
Source/WebCore: Clicking a scrollbar unfocuses the current activeElement
https://bugs.webkit.org/show_bug.cgi?id=96335

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-12-04
Reviewed by Ojan Vafai.

Previously we only tested for clicks inside frame scrollbars before
moving the focus, this patch expands the check to overflow scrollbars.
Now clicking inside a scrollbar only moves the focus when the scrollbar
has an ancestor that is mouse focusable.

This matches Gecko behavior, and was agreed to be the most sensible for now:
http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2012-October/037759.html

Test: fast/overflow/scrollbar-click-retains-focus.html

* page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEvent):
  Never start selections inside scrollbars because it would cause asserts.
  This wasn't a problem before because we always moved the focus when clicking a scrollbar.
(WebCore::EventHandler::dispatchMouseEvent):
  Check that the click is not inside a scrollbar before moving the focus.
(WebCore::EventHandler::isInsideScrollbar): Tests if a point is in a scrollbar.
(WebCore):
(WebCore::EventHandler::sendContextMenuEvent):
  Never start selections inside scrollbars because it would cause asserts.
* page/EventHandler.h:
(EventHandler):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTestOverflowControls):

LayoutTests: Clicking a scrollbar unfocuses the current activeElement
https://bugs.webkit.org/show_bug.cgi?id=96335

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-12-04
Reviewed by Ojan Vafai.

Add test that ensures clicking inside a scrollbar doesn't move the
focus unless the scrollbar is inside a mouse focusable element.

* fast/overflow/scrollbar-click-retains-focus-expected.txt: Added.
* fast/overflow/scrollbar-click-retains-focus.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Replace String::New("symbol") with String::NewSymbol("symbol")
haraken@chromium.org [Wed, 5 Dec 2012 06:20:57 +0000 (06:20 +0000)]
[V8] Replace String::New("symbol") with String::NewSymbol("symbol")
https://bugs.webkit.org/show_bug.cgi?id=104084

Reviewed by Adam Barth.

V8 can look up symbols faster than strings. This is a final patch for the replacement.

No tests. No change in behavior.

* bindings/v8/DateExtension.cpp:
(WebCore::DateExtension::setAllowSleep):
(WebCore::DateExtension::GetNativeFunction):
* bindings/v8/NPV8Object.cpp:
(WebCore::npIdentifierToV8Identifier):
(_NPN_Invoke):
* bindings/v8/PageScriptDebugServer.cpp:
(WebCore::PageScriptDebugServer::addListener):
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::setContextDebugId):
* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::callDebuggerMethod):
(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore::ScriptDebugServer::clearBreakpoints):
(WebCore::ScriptDebugServer::setBreakpointsActivated):
(WebCore::ScriptDebugServer::handleV8DebugEvent):
(WebCore::ScriptDebugServer::dispatchDidParseSource):
* bindings/v8/ScriptObject.cpp:
(WebCore::ScriptGlobalObject::set):
(WebCore::ScriptGlobalObject::get):
(WebCore::ScriptGlobalObject::remove):
* bindings/v8/V8Binding.h:
(WebCore::toV8Sequence):
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::setInjectedScriptContextDebugId):
(WebCore::V8DOMWindowShell::updateDocumentProperty):
(WebCore::V8DOMWindowShell::clearDocumentProperty):
* bindings/v8/V8NPObject.cpp:
(WebCore::npObjectPropertyEnumerator):
* bindings/v8/V8NodeFilterCondition.cpp:
(WebCore::V8NodeFilterCondition::acceptNode):
* bindings/v8/V8PerIsolateData.cpp:
(WebCore::V8PerIsolateData::constructorOfToString):
* bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::initializeContextIfNeeded):
* bindings/v8/WorkerScriptDebugServer.cpp:
(WebCore::WorkerScriptDebugServer::addListener):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSupport text-orientation: sideways-right (and sideways when it maps to sideways-right)
mitz@apple.com [Wed, 5 Dec 2012 06:18:22 +0000 (06:18 +0000)]
Support text-orientation: sideways-right (and sideways when it maps to sideways-right)
https://bugs.webkit.org/show_bug.cgi?id=104035

Reviewed by Anders Carlsson.

Test: fast/text/orientation-sideways.html

* GNUmakefile.list.am: Updated for rename of TextOrientation.h.

* WebCore.gypi: Ditto.

* WebCore.xcodeproj/project.pbxproj: Ditto.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Changed to retrieve
text-orientation from RenderStyle rather than from the font description.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue): Added sideways and sideways-right as acceptable
text-orientation values.

* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added mappings for sideways and
sideways-right.
(WebCore::CSSPrimitiveValue::operator TextOrientation): Ditto.

* css/CSSValueKeywords.in: Added sideways and sideways-right.

* css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder): Removed text-orientation property handler, as it is
now handled in CSSStyleResolver.

* css/StyleResolver.cpp:
(WebCore::getFontAndGlyphOrientation): Added this helper function that determines the font
orientation and non-CJK glyph orientation based on writing-mode and text-orientation.
(WebCore::StyleResolver::styleForDocument): Added code to set the font orientation and
non-CJK glyph orientation in the document style.
(WebCore::checkForOrientationChange): Added. Sets the font orientation and non-CJK glyph
orientation in the child style if the difference between the parent and child styles requires
doing so.
(WebCore::StyleResolver::updateFont): Added call to checkForOrientationChange().
(WebCore::StyleResolver::applyProperty): Changed the writing-mode case to call the new
setWritingMode helper, which dirties the font as needed, rather than changing the font
here. Moved handling of text-orientation here, by calling setTextOrientation, which also
dirties the font as needed.

* css/StyleResolver.h:
(WebCore::StyleResolver::setWritingMode): Added. Dirties the font if the writing mode changes.
(WebCore::StyleResolver::setTextOrientation): Ditto for text orientation.

* platform/graphics/FontDescription.h:
(WebCore::FontDescription::FontDescription): Updated initializer for rename.
(WebCore::FontDescription::nonCJKGlyphOrientation): Renamed textOrientation to this.
(WebCore::FontDescription::setNonCJKGlyphOrientation): Renamed setTextOrientation to this.
(FontDescription): Renamed member variable m_textOrientation to m_nonCJKGlyphOrientation.
(WebCore::FontDescription::operator==): Updated for rename.

* platform/graphics/FontFastPath.cpp:
(WebCore::glyphDataAndPageForNonCJKCharacterWithGlyphOrientation): Renamed
glyphDataAndPageForCharacterWithTextOrientation to this and changed the parameter type from
TextOrientation to NonCJKGlyphOrientation.
(WebCore::Font::glyphDataAndPageForCharacter): Updated for above rename.

* platform/graphics/mac/FontComplexTextMac.cpp:
(WebCore::Font::fontDataForCombiningCharacterSequence): Updated for rename of
FontDescription::textOrientation().

* platform/text/NonCJKGlyphOrientation.h: Renamed TextOrientation.h to this, and renamed
the enum and its values to better reflect that they describe how glyphs for non-CJK
characters are to be rendered in vertical text.

* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::requiresIdeographicBaseline): Updated for rename of
FontDescription::textOrientation().

* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff): Made text-orientation change a layout change.

* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::setTextOrientation): Added.

* rendering/style/RenderStyleConstants.h: Added a new TextOrientation enum here.

* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData): Added initialization and copying
of m_textOrientation member variable.
(WebCore::StyleRareInheritedData::operator==): Added comparing of m_textOrientation.

* rendering/style/StyleRareInheritedData.h:
(StyleRareInheritedData): Added m_textOrientation member variable.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChange email address of Jonathan Dong
jonathan.dong@torchmobile.com.cn [Wed, 5 Dec 2012 05:51:45 +0000 (05:51 +0000)]
Change email address of Jonathan Dong
https://bugs.webkit.org/show_bug.cgi?id=103976

Unreviewed, change my email address from jonathan.dong@torchmobile.com.cn
to jonathan.dong.webkit@gmail.com in committers list.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Use ScopedPersistent for IntegerCache::smallIntegers
haraken@chromium.org [Wed, 5 Dec 2012 05:36:06 +0000 (05:36 +0000)]
[V8] Use ScopedPersistent for IntegerCache::smallIntegers
https://bugs.webkit.org/show_bug.cgi?id=104066

Reviewed by Adam Barth.

We can use ScopedPersistent for IntegerCache::smallIntegers
instead of manual Persistent::New().

I confirmed no performance regression in Bindings/scroll-top.html

No tests. No change in behavior.

* bindings/v8/V8PerIsolateData.cpp:
(WebCore::V8PerIsolateData::V8PerIsolateData):
* bindings/v8/V8ValueCache.cpp:
(WebCore::IntegerCache::IntegerCache):
* bindings/v8/V8ValueCache.h:
(IntegerCache):
(WebCore::IntegerCache::v8Integer):
(WebCore::IntegerCache::v8UnsignedInteger):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Add APIs to get/set default font size.
commit-queue@webkit.org [Wed, 5 Dec 2012 05:20:58 +0000 (05:20 +0000)]
[EFL][WK2] Add APIs to get/set default font size.
https://bugs.webkit.org/show_bug.cgi?id=101921

Patch by Yuni Jeong <yhnet.jung@samsung.com> on 2012-12-04
Reviewed by Gyuyoung Kim.

Add setting APIs for default font size and a unit test.

* UIProcess/API/efl/ewk_settings.cpp:
(ewk_settings_default_font_size_set):
(ewk_settings_default_font_size_get):
* UIProcess/API/efl/ewk_settings.h:
* UIProcess/API/efl/tests/test_ewk2_settings.cpp:
(TEST_F):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Resources: domain cookies are not shown for sub-sub domain pages.
commit-queue@webkit.org [Wed, 5 Dec 2012 05:18:55 +0000 (05:18 +0000)]
Web Inspector: Resources: domain cookies are not shown for sub-sub domain pages.
https://bugs.webkit.org/show_bug.cgi?id=104016

Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2012-12-04
Reviewed by Pavel Feldman.

Fixed regexp to allow zero or more subdomain prefix (was zero or one).

* inspector/front-end/CookieParser.js:
(WebInspector.Cookies.cookieDomainMatchesResourceDomain): Fixed regexp.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNot reviewed. Build fix.
hclam@chromium.org [Wed, 5 Dec 2012 05:15:11 +0000 (05:15 +0000)]
Not reviewed. Build fix.

Fix Chromium Windows build.

* platform/graphics/chromium/ImageDecodingStore.h:
(CacheEntry):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Remove toV8Object()
haraken@chromium.org [Wed, 5 Dec 2012 05:11:13 +0000 (05:11 +0000)]
[V8] Remove toV8Object()
https://bugs.webkit.org/show_bug.cgi?id=103987

Reviewed by Adam Barth.

toV8Object() is used only for MessagePort and ArrayBuffer
only by SerializedScriptValue. It is wasteful to generate
toV8Object() for all interfaces.

No tests. No change in behavior.

Source/WebCore:

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
* bindings/scripts/test/V8/V8Float64Array.h:
(WebCore):
* bindings/scripts/test/V8/V8TestActiveDOMObject.h:
* bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
* bindings/scripts/test/V8/V8TestEventConstructor.h:
* bindings/scripts/test/V8/V8TestEventTarget.h:
* bindings/scripts/test/V8/V8TestException.h:
* bindings/scripts/test/V8/V8TestInterface.h:
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
* bindings/scripts/test/V8/V8TestNamedConstructor.h:
* bindings/scripts/test/V8/V8TestNode.h:
* bindings/scripts/test/V8/V8TestObj.h:
* bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
* bindings/v8/SerializedScriptValue.cpp:

Source/WebKit/chromium:

* src/WebArrayBuffer.cpp:
(WebKit::WebArrayBuffer::toV8Value):
* src/WebBlob.cpp:
(WebKit::WebBlob::toV8Value):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] VKB flickers in and out when tapping on webview after text selection...
commit-queue@webkit.org [Wed, 5 Dec 2012 05:11:12 +0000 (05:11 +0000)]
[BlackBerry] VKB flickers in and out when tapping on webview after text selection on URL bar
https://bugs.webkit.org/show_bug.cgi?id=103874
PR245678

Patch by Sean Wang <Xuewen.Wang@torchmobile.com.cn> on 2012-12-04
Reviewed by Rob Buis.
Internally reviewed by Mike Fenton.

When the virtual keyboard is hiding, the viewport is changed and the page needs
to relayout.At the same time, the user interface thread  is executing compositeLayers
and it will dispatch the updateDelegatedOverlays() to webkit thread which will trigger
the selectionPositionChanged() in webkit thread.

When the selectionPositionChanged() calls frame->selection()->selection().
visibleStart() and frame->selection()->selection().visibleEnd(), it will
trigger page relayout and return the relayouted selection start and end position.
These positions are out of the range which is recorded before its relayout.
As a result it think the selection start and end are all clipped out and it send
out an "empty selection"(not selected) changing event.

When the WebPageClient receives the empty selection changing event, it will consider
the selection process aborted and might cancel selection-related user interaction.
This is not what we intend to happen.

This patch stops the changing handling process and returns when the page needs relayout,
and the selection will be updated again when the page finishs relayout.

* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Replace v8::Null(isolate) with v8Null(isolate)
haraken@chromium.org [Wed, 5 Dec 2012 05:02:21 +0000 (05:02 +0000)]
[V8] Replace v8::Null(isolate) with v8Null(isolate)
https://bugs.webkit.org/show_bug.cgi?id=104070

Reviewed by Adam Barth.

v8Null(isolate) is a faster version of v8::Null(isolate).

No tests. No change in behavior.

* bindings/v8/V8Binding.h:
(WebCore::v8StringOrNull):
* bindings/v8/custom/V8ClipboardCustom.cpp:
(WebCore::V8Clipboard::typesAccessorGetter):
* bindings/v8/custom/V8CoordinatesCustom.cpp:
(WebCore::V8Coordinates::altitudeAccessorGetter):
(WebCore::V8Coordinates::altitudeAccuracyAccessorGetter):
(WebCore::V8Coordinates::headingAccessorGetter):
(WebCore::V8Coordinates::speedAccessorGetter):
* bindings/v8/custom/V8DeviceMotionEventCustom.cpp:
(WebCore::V8DeviceMotionEvent::accelerationAccessorGetter):
(WebCore::V8DeviceMotionEvent::accelerationIncludingGravityAccessorGetter):
(WebCore::V8DeviceMotionEvent::rotationRateAccessorGetter):
(WebCore::V8DeviceMotionEvent::intervalAccessorGetter):
* bindings/v8/custom/V8DeviceOrientationEventCustom.cpp:
(WebCore::V8DeviceOrientationEvent::alphaAccessorGetter):
(WebCore::V8DeviceOrientationEvent::betaAccessorGetter):
(WebCore::V8DeviceOrientationEvent::gammaAccessorGetter):
(WebCore::V8DeviceOrientationEvent::absoluteAccessorGetter):
* bindings/v8/custom/V8DocumentLocationCustom.cpp:
(WebCore::V8Document::locationAccessorGetter):
* bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::getContextCallback):
* bindings/v8/custom/V8HistoryCustom.cpp:
(WebCore::V8History::stateAccessorGetter):
* bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::dataAccessorGetter):
* bindings/v8/custom/V8MicroDataItemValueCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::V8Node::insertBeforeCallback):
(WebCore::V8Node::replaceChildCallback):
(WebCore::V8Node::removeChildCallback):
(WebCore::V8Node::appendChildCallback):
* bindings/v8/custom/V8PopStateEventCustom.cpp:
(WebCore::V8PopStateEvent::stateAccessorGetter):
* bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
(WebCore::V8SQLResultSetRowList::itemCallback):
* bindings/v8/custom/V8TrackEventCustom.cpp:
(WebCore::V8TrackEvent::trackAccessorGetter):
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):
(WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
(WebCore::V8WebGLRenderingContext::getSupportedExtensionsCallback):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Detach the frame and destroy the page immediately upon request to closeHel...
commit-queue@webkit.org [Wed, 5 Dec 2012 04:55:38 +0000 (04:55 +0000)]
[Chromium] Detach the frame and destroy the page immediately upon request to closeHelperPlugin().
https://bugs.webkit.org/show_bug.cgi?id=103947

Patch by David Dorwin <ddorwin@chromium.org> on 2012-12-04
Reviewed by Kent Tamura.

In the case that the host page is being destroyed, some of the objects
the page depends on, specifically RenderViewImpl, may be destroyed by
the time close() is called asynchronously.
The frameDetached() calling code was originally copied from
WebViewImpl::close(), but WebViewImpl does not have an asynchronous
closing mechanism like the WebWidgets.

This is the fix for http://crbug.com/160650

* src/WebHelperPluginImpl.cpp:
(WebKit::WebHelperPluginImpl::init):
(WebKit::WebHelperPluginImpl::closeHelperPlugin):
(WebKit::WebHelperPluginImpl::destoryPage):
(WebKit):
(WebKit::WebHelperPluginImpl::close):.
(WebKit::WebHelperPlugin::create):
* src/WebHelperPluginImpl.h:
(WebHelperPluginImpl):
* src/WebPagePopupImpl.cpp: Made similar changes since it follows the same model. (I think the way popups are closed has prevented the race condition from occurring for popups.)
(WebKit::WebPagePopupImpl::destoryPage):
(WebKit):
(WebKit::WebPagePopupImpl::close):
(WebKit::WebPagePopupImpl::closePopup):
* src/WebPagePopupImpl.h:
(WebPagePopupImpl):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake LazyDecodingPixelRef inherit from skia::LazyPixelRef so that cc thread can access it
commit-queue@webkit.org [Wed, 5 Dec 2012 04:49:51 +0000 (04:49 +0000)]
Make LazyDecodingPixelRef inherit from skia::LazyPixelRef so that cc thread can access it
https://bugs.webkit.org/show_bug.cgi?id=103555

Patch by Min Qin <qinmin@chromium.org> on 2012-12-04
Reviewed by Stephen White.

Expose LazyDecodingPixelRef to the cc thread by inheriting from skia::LazyPixelRef.
No test added for now as impl side paiting is still WIP.

* platform/graphics/chromium/LazyDecodingPixelRef.cpp:
(WebCore::LazyDecodingPixelRef::LazyDecodingPixelRef):
(WebCore::LazyDecodingPixelRef::PrepareToDecode):
(WebCore):
(WebCore::LazyDecodingPixelRef::Decode):
* platform/graphics/chromium/LazyDecodingPixelRef.h:
(LazyDecodingPixelRef):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix compile error when SVG is disabled.
tasak@google.com [Wed, 5 Dec 2012 04:46:52 +0000 (04:46 +0000)]
Fix compile error when SVG is disabled.

Unreviewed gardening.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::sharingCandidateHasIdenticalStyleAffectingAttributes):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] DRT - Tests under "dumpAsText" directory should be dumped as text
commit-queue@webkit.org [Wed, 5 Dec 2012 04:40:49 +0000 (04:40 +0000)]
[BlackBerry] DRT - Tests under "dumpAsText" directory should be dumped as text
https://bugs.webkit.org/show_bug.cgi?id=103986

Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2012-12-04
Reviewed by Rob Buis.

Also move declaration of webSettingTransaction to before any WebSettings
::setXXX() calls so that it works as expected (commit only once in the
function scope).

* DumpRenderTree/blackberry/DumpRenderTree.cpp:
(shouldDumpAsText):
(BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Enable compositing pixel tests that are not fail after EFL WTR snapshot...
commit-queue@webkit.org [Wed, 5 Dec 2012 04:37:53 +0000 (04:37 +0000)]
[EFL][WK2] Enable compositing pixel tests that are not fail after EFL WTR snapshot implementation.
https://bugs.webkit.org/show_bug.cgi?id=104075

Unreviewed, EFL gardening.

Patch by Viatcheslav Ostapenko <v.ostapenko@samsung.com> on 2012-12-04

* platform/efl-wk1/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoStatic code analysis warning fixes
commit-queue@webkit.org [Wed, 5 Dec 2012 04:35:19 +0000 (04:35 +0000)]
Static code analysis warning fixes
https://bugs.webkit.org/show_bug.cgi?id=103837

Patch by Anthony Scian <ascian@rim.com> on 2012-12-04
Reviewed by Rob Buis.

172,174: disable copy ctor, op= in AutofillBackingStore
504,506: disable copy ctor, op= in CookieManager
1488,1491: disable copy ctor, op= in RSSParserBase
1489,1490: disable copy ctor, op= in RSSItem
514,516: disable copy ctor, op= in CredentialBackingStore
1363: m_state not initialized in ctor

* platform/blackberry/CookieManager.h:
* platform/blackberry/PlatformTouchPointBlackBerry.cpp:
(WebCore::PlatformTouchPoint::PlatformTouchPoint):
* platform/network/blackberry/AutofillBackingStore.h:
(AutofillBackingStore):
* platform/network/blackberry/CredentialBackingStore.h:
(CredentialBackingStore):
* platform/network/blackberry/rss/RSSParserBase.h:
(RSSParserBase):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Removed obsolete local variable from WebViewImpl.cpp.
commit-queue@webkit.org [Wed, 5 Dec 2012 04:33:22 +0000 (04:33 +0000)]
[Chromium] Removed obsolete local variable from WebViewImpl.cpp.
https://bugs.webkit.org/show_bug.cgi?id=104050

Patch by David Dorwin <ddorwin@chromium.org> on 2012-12-04
Reviewed by Kent Tamura.

These lines were added with the file in 50739#L761 but the later use
of this variable at L779 has since been removed.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::close):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[v8] Improve worker.postMessage() string performance: avoid utf8 conversion
noel.gordon@gmail.com [Wed, 5 Dec 2012 04:28:23 +0000 (04:28 +0000)]
[v8] Improve worker.postMessage() string performance: avoid utf8 conversion
https://bugs.webkit.org/show_bug.cgi?id=102230

Reviewed by Eric Seidel.

Source/WebCore:

Avoid utf8 conversion when serializing strings with SerializedScriptValue. Provide
Ascii and UChar writers for v8 string serialization and provide a UChar reader for
deserialization. Define/use serialization StringUCharTag to indicate UChar strings
in the wire format. Increment the SerializedScriptValue wire format version.

In the wire format, StringUCharTag is followed by the string length in bytes, then
the length/2 UChars of the string.

Note the string length is VarInt encoded. During serialization, compute the number
of bytes used to encode the length and prepend a PaddingTag if needed so the UChar
data appears on an even-byte boundary. This prevents unaligned reads of UChar data
during deserialization (the deserialization buffer is even-byte aligned).

Testing transfers of large strings to and from workers indicates a 10X improvement
in transfer rate for strings, and strings within js objects, with this change. For
example, 500 MByte/s on my test machine (50 MByte/s without this change) for flat,
32 MByte string postMessage() transfers.

Covered by platform/chromium/fast/storage/serialized-script-value.html

* bindings/v8/SerializedScriptValue.cpp:

LayoutTests:

Update serialized-script-value-expected results for the new SerializedScriptValue
wire format version. Add test cases for UChar string serialization to verify that
the UChar string data appears on an even-byte boundary in the wire format, and to
test reading string data from the previous wire format is backward-compatible.

* platform/chromium/fast/storage/serialized-script-value-expected.txt:
* platform/chromium/fast/storage/serialized-script-value.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] V8Binding::v8ExternalString() is redundant
haraken@chromium.org [Wed, 5 Dec 2012 04:25:52 +0000 (04:25 +0000)]
[V8] V8Binding::v8ExternalString() is redundant
https://bugs.webkit.org/show_bug.cgi?id=103979

Reviewed by Adam Barth.

v8String(), v8StringOrNull() and v8StringOrUndefined() are enough.
We can remove V8Binding::v8ExternalString().

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::compileAndRunScript):
* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::compileScript):
* bindings/v8/V8Binding.h:
(WebCore):
(WebCore::v8String):
(WebCore::v8StringOrNull):
(WebCore::v8StringOrUndefined):
* bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::prepareListenerObject):
* bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::evaluate):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Remove v8NonStringValueToWebCoreString() and v8NonStringValueToAtomicWebCoreString()
haraken@chromium.org [Wed, 5 Dec 2012 04:22:29 +0000 (04:22 +0000)]
[V8] Remove v8NonStringValueToWebCoreString() and v8NonStringValueToAtomicWebCoreString()
https://bugs.webkit.org/show_bug.cgi?id=103981

Reviewed by Adam Barth.

v8NonStringValueToWebCoreString() and v8NonStringValueToAtomicWebCoreString()
are equivalent to what StringResource does.

No tests. No change in behavior.

* bindings/v8/V8Binding.cpp:
* bindings/v8/V8Binding.h:
(WebCore::toWebCoreString):
(WebCore):
(WebCore::toWebCoreStringWithNullCheck):
(WebCore::toWebCoreStringWithUndefinedOrNullCheck):
(WebCore::toWebCoreAtomicString):
(WebCore::toWebCoreAtomicStringWithNullCheck):
* bindings/v8/V8StringResource.h:
(WebCore::V8StringResource::V8StringResource):
(V8StringResource):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Scroll adjustments while typing scroll off page, then bounce back.
commit-queue@webkit.org [Wed, 5 Dec 2012 04:21:34 +0000 (04:21 +0000)]
[BlackBerry] Scroll adjustments while typing scroll off page, then bounce back.
https://bugs.webkit.org/show_bug.cgi?id=104045

Patch by Andrew Lo <anlo@rim.com> on 2012-12-04
Reviewed by Rob Buis.
Internally reviewed by Mike Fenton & Jakob Petsovits.

Internal PR253845
The main frame's view should only be temporarily set to
not constrain scrolling to the content edge while the
scroll position is set at the end of the scroll animation.

Remove ensureFocusTextElementVisible from setSpannableTextAndRelativeCursor
in InputHandler since FrameSelection::revealSelection
already implements scroll adjustments due to typing.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::zoomBlock):
(BlackBerry::WebKit::WebPagePrivate::resetBlockZoom):
* Api/WebPage_p.h:
(WebPagePrivate):
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
(BlackBerry::WebKit::InputHandler::setSpannableTextAndRelativeCursor):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove #ifs that are always true
andersca@apple.com [Wed, 5 Dec 2012 04:19:22 +0000 (04:19 +0000)]
Remove #ifs that are always true
https://bugs.webkit.org/show_bug.cgi?id=104080

Reviewed by Andreas Kling.

__MAC_OS_X_VERSION_MIN_REQUIRED >= 1070 is always true, so remove all the #ifs.

* PluginProcess/mac/PluginProcessMac.mm:
(WebKit::initializeSandbox):
(WebKit::PluginProcess::platformInitialize):
* Shared/DictionaryPopupInfo.cpp:
(WebKit::DictionaryPopupInfo::encode):
(WebKit::DictionaryPopupInfo::decode):
* Shared/DictionaryPopupInfo.h:
* Shared/mac/WebEventFactory.mm:
(WebKit::phaseForEvent):
(WebKit::momentumPhaseForEvent):
* SharedWorkerProcess/mac/SharedWorkerProcessMac.mm:
(WebKit::initializeSandbox):
(WebKit::SharedWorkerProcess::platformInitialize):
* UIProcess/API/mac/PDFViewController.mm:
(WebKit::PDFViewScrollView_scrollWheel):
(WebKit::PDFViewController::pdfKitBundle):
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::didPerformDictionaryLookup):
(WebKit::PageClientImpl::dismissDictionaryLookupPanel):
(WebKit::PageClientImpl::recordAutocorrectionResponse):
(WebKit::PageClientImpl::recommendedScrollbarStyleDidChange):
* UIProcess/API/mac/WKView.mm:
(-[WKView displayIfNeeded]):
(-[WKView draggingUpdated:]):
(-[WKView viewDidMoveToWindow]):
(-[WKView _intrinsicDeviceScaleFactor]):
(-[WKView _cacheWindowBottomCornerRect]):
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
(+[WKView hideWordDefinitionWindow]):
* UIProcess/Launcher/mac/EnvironmentVariables.cpp:
* UIProcess/Launcher/mac/EnvironmentVariables.h:
(EnvironmentVariables):
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::addDYLDEnvironmentAdditions):
(WebKit::createWebProcessServiceForWebKitDevelopment):
(WebKit):
(WebKit::tryPreexistingProcess):
(WebKit::createProcess):
(WebKit::ProcessLauncher::launchProcess):
* UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::PluginInfoStore::shouldUsePlugin):
(WebKit::PluginInfoStore::reactivateInactivePlugin):
* UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::platformInitializePluginProcess):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didCommitLoadForFrame):
(WebKit::WebPageProxy::pageDidScroll):
(WebKit::WebPageProxy::processDidCrash):
(WebKit::WebPageProxy::recordAutocorrectionResponse):
(WebKit::WebPageProxy::handleAlternativeTextUIResult):
* UIProcess/WebPageProxy.h:
(WebPageProxy):
* UIProcess/WebPageProxy.messages.in:
* UIProcess/mac/TextCheckerMac.mm:
(WebKit::initializeState):
(WebKit::TextChecker::getGuessesForWord):
* UIProcess/mac/WKFullScreenWindowController.mm:
(convertRectToScreen):
* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformInitializeWebProcess):
* WebKit2Prefix.h:
* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue):
* WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.mm:
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::shouldEraseMarkersAfterChangeSelection):
* WebProcess/WebCoreSupport/WebEditorClient.h:
* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
* WebProcess/WebPage/WebPage.cpp:
(WebKit):
* WebProcess/WebPage/WebPage.h:
(WebPage):
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performDictionaryLookupAtLocation):
(WebKit::WebPage::performDictionaryLookupForSelection):
(WebKit::WebPage::performDictionaryLookupForRange):
* WebProcess/mac/SecItemShimMethods.mm:
* WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::secItemResponse):
* WebProcess/mac/WebProcessMainMac.mm:
(WebKit::WebProcessMain):
* WebProcessService/WebProcessServiceMain.mm:
(main):
* WebProcessServiceForWebKitDevelopment/WebProcessServiceForWebKitDevelopmentMain.mm:
(WebProcessServiceForWebKitDevelopmentEventHandler):
(main):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode
inferno@chromium.org [Wed, 5 Dec 2012 04:18:36 +0000 (04:18 +0000)]
Crash in WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode
https://bugs.webkit.org/show_bug.cgi?id=103515

Reviewed by Ryosuke Niwa.

|current| is weak node pointer that iterates in the hierarchy chain
between |highestAncestor| and |targetNode|. Script executed as part
of iframe onload event can blow away the nodes and we no longer have
|targetNode| in our descendants chain. So, we RefPtr |current| and bail
out when |targetNode| stops being a part of descendant chain.

Test blocked on https://bugs.webkit.org/show_bug.cgi?id=104044.

* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, WebKit gardening. A rebaseline.
tasak@google.com [Wed, 5 Dec 2012 04:18:01 +0000 (04:18 +0000)]
Unreviewed, WebKit gardening. A rebaseline.

* platform/chromium/media/track/opera/interfaces/TextTrack/addCue-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAvoid repeated calls to decorationColor on RenderObject::getTextDecorationColors
bruno.abinader@basyskom.com [Wed, 5 Dec 2012 04:16:44 +0000 (04:16 +0000)]
Avoid repeated calls to decorationColor on RenderObject::getTextDecorationColors
https://bugs.webkit.org/show_bug.cgi?id=94131

Reviewed by Brent Fulgham.

Replaces repeated calls to decorationColor by adding a variable that reads the
return value from that function just once on each loop and gets used upon need.

This change won't affect text decoration behavior, so current tests suffice.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::getTextDecorationColors):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Implement cache eviction logic in ImageDecodingStore
hclam@chromium.org [Wed, 5 Dec 2012 04:15:31 +0000 (04:15 +0000)]
[chromium] Implement cache eviction logic in ImageDecodingStore
https://bugs.webkit.org/show_bug.cgi?id=103480

Reviewed by James Robinson.

Source/WebCore:

This patch implements these features in the new image cache:
- Least-recently-used eviction logic
- Setting cache limit (default is 32MB)
- Remove cache entries when ImageFrameGenerator is removed

New tests in ImageDecodingTestTest. Also covered by platform/chromium/virtual/deferred.

* platform/graphics/chromium/ImageDecodingStore.cpp:
(WebCore::ImageDecodingStore::ImageDecodingStore):
(WebCore::ImageDecodingStore::~ImageDecodingStore):
Code to assert that everything is cleaned up.
(WebCore::ImageDecodingStore::lockCompleteCache):
(WebCore::ImageDecodingStore::unlockCache):
(WebCore::ImageDecodingStore::insertAndLockCache):
(WebCore::ImageDecodingStore::removeCacheIndexedByGenerator):
New method to remove all cache entries index by ImageFrameGenerator.
(WebCore):
(WebCore::ImageDecodingStore::setCacheLimitInBytes):
(WebCore::ImageDecodingStore::memoryUsageInBytes):
(WebCore::ImageDecodingStore::cacheEntries):
(WebCore::ImageDecodingStore::prune):
New code to implement LRU eviction logic.
(WebCore::ImageDecodingStore::insertCacheInternal):
New method to help new cache insertion. This is separately because it touches 3 containers.
(WebCore::ImageDecodingStore::removeFromCacheInternal):
New method to help remove a cache entry from containers.
(WebCore::ImageDecodingStore::removeFromCacheListInternal):
New helper method to help remove cache entry from doubly linked list.
* platform/graphics/chromium/ImageDecodingStore.h:
(ImageDecodingStore):
(CacheEntry):
(WebCore::ImageDecodingStore::CacheEntry::createAndUse):
(WebCore::ImageDecodingStore::CacheEntry::CacheEntry):
(WebCore::ImageDecodingStore::CacheEntry::~CacheEntry):
(WebCore::ImageDecodingStore::CacheEntry::cacheKey):
(WebCore::ImageDecodingStore::CacheEntry::cachedImage):
(WebCore::ImageDecodingStore::CacheEntry::useCount):
(WebCore::ImageDecodingStore::CacheEntry::incrementUseCount):
(WebCore::ImageDecodingStore::CacheEntry::decrementUseCount):
(WebCore::ImageDecodingStore::CacheEntry::memoryUsageInBytes):
(WebCore::ImageDecodingStore::incrementMemoryUsage):
(WebCore::ImageDecodingStore::decrementMemoryUsage):
New helper methods.
* platform/graphics/chromium/ImageFrameGenerator.cpp:
(WebCore::ImageFrameGenerator::~ImageFrameGenerator):

Source/WebKit/chromium:

Added ImageDecodingStoreTest for unit testing new image cache.

New tests:

ImageDecodingStoreTest.evictOneCache

Test eviction of one cache entry by setting a smaller cache limit.

ImageDecodingStoreTest.pruneOrderIsLeastRecentlyUsed

Test eviction order is least recently used.

ImageDecodingStoreTest.pruneCausedByInsertion

Test that eviction is triggered also by cache insertion.

ImageDecodingStoreTest.cacheInUseNotEvicted

Test that cache in use is not evicted.

ImageDecodingStoreTest.destroyImageFrameGenerator

Test that deleting a ImageFrameGenerator causes associated cache
entries to be removed.

* WebKit.gypi:
* tests/ImageDecodingStoreTest.cpp: Added.
(WebCore):
(ImageDecodingStoreTest):
(WebCore::ImageDecodingStoreTest::SetUp):
(WebCore::ImageDecodingStoreTest::TearDown):
(WebCore::ImageDecodingStoreTest::createCompleteImage):
(WebCore::ImageDecodingStoreTest::insertCache):
(WebCore::ImageDecodingStoreTest::lockCache):
(WebCore::ImageDecodingStoreTest::unlockCache):
(WebCore::ImageDecodingStoreTest::evictOneCache):
(WebCore::ImageDecodingStoreTest::isCacheAlive):
(WebCore::TEST_F):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoStyle sharing: Allow sharing between elements with classes not referenced by any...
akling@apple.com [Wed, 5 Dec 2012 04:05:33 +0000 (04:05 +0000)]
Style sharing: Allow sharing between elements with classes not referenced by any selectors.
<http://webkit.org/b/103925>

Reviewed by Antti Koivisto.

When looking for elements that can share style, instead of blindly rejecting candidates with
a different "class" attribute, check if it's actually referenced by any of the tracked style rules.
It's surprisingly common for web pages to have elements with classes to which no rules apply,
mediawiki content is especially good at this.

~2100 new sharing "hits" on <https://en.wikipedia.org/wiki/Steve_Jobs>.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::canShareStyleWithElement):

    Don't bail early if the two elements have different return values for hasClass().

(WebCore::StyleResolver::classNamesAffectedByRules):

    Helper function that returns whether a SpaceSplitString contains a class name referenced
    by any style rules.

(WebCore::StyleResolver::sharingCandidateHasIdenticalStyleAffectingAttributes):

    Make this a member function since we need access to m_features.classesInRules.

* css/StyleResolver.h:
(StyleResolver):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::locateSharedStyle):

    Cache whether the element we're resolving style for has a "class" attribute referenced by style rules.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, WebKit gardening.
tasak@google.com [Wed, 5 Dec 2012 04:01:17 +0000 (04:01 +0000)]
Unreviewed, WebKit gardening.

* platform/chromium/TestExpectations:
Updated css3/filters/effect-reference-hw.html's expectation.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRefactor Media Control Elements to remove code duplication.
commit-queue@webkit.org [Wed, 5 Dec 2012 04:01:13 +0000 (04:01 +0000)]
Refactor Media Control Elements to remove code duplication.
https://bugs.webkit.org/show_bug.cgi?id=101877

Patch by Silvia Pfeiffer <silviapf@chromium.org> on 2012-12-04
Reviewed by Eric Carlson.

Instead of having two different types of inheritance trees for
MediaControlElement and MediaControlInputElement, this
creates a stand-alone virtual class MediaControlElement that
provides the common functions: show(), hide(), isShowing(),
setMediaController(), displayType(), isMediaControlElement(),
shadowPseudoId(), mediaController(), setDisplayType().

The individual elements inherit from MediaControlElement and
either HTMLInputElement or HTMLDivElement. They extend/override
the base functions as appropriate.

As part of this, the RenderXXX classes mixed in between the media
controls in MediaControlElements.cpp are also moved to
rendering/RenderMediaControls.h/cpp to follow common code separation.

No new tests since this is just a refactoring.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
Build files extended with new files.

* html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::textTracksIndexNotFound):
Replaced const with function, since it is used in multiple files.

* html/shadow/MediaControlElementTypes.cpp: new file
* html/shadow/MediaControlElementTypes.h: new file
Added new MediaControlElement class. Moved MediaControlDivElement and MediaControlInputElement
classes into these files from MediaControlElements.cpp/h. Moved MediaControlElementTypes enum
into these. Moved other media control element classes that are the basis for inheriting media
control elements into these (MediaControlTimeDisplayElement, MediaControlMuteButtonElement,
MediaControlSeekButtonElement, MediaControlVolumeSliderElement).

* html/shadow/MediaControlElements.cpp:
* html/shadow/MediaControlElements.h:
Removed common functions between media elements that are now in the common
base class MediaControlElement.
Also moved common base classes to MediaControlElementTypes.h/cpp

* html/shadow/MediaControls.cpp:
* html/shadow/MediaControls.h:
Renamed MediaControlVolumeSliderElement to MediaControlPanelVolumeSliderElement
to be consistent in inheritance tree. Updated copyright date.

* html/shadow/MediaControlsApple.cpp:
* html/shadow/MediaControlsApple.h:
Renamed MediaControlVolumeSliderElement to MediaControlPanelVolumeSliderElement
to be consistent in inheritance tree. Updated copyright dates.n

* html/shadow/MediaControlsChromium.cpp:
* html/shadow/MediaControlsChromium.h:
Renamed MediaControlVolumeSliderElement to MediaControlPanelVolumeSliderElement
to be consistent in inheritance tree.
Moved enclosure element definitions to common MediaControlElements.cpp/h
file through which different media elements are made available to different ports.

* html/shadow/MediaControlsChromiumAndroid.cpp:
* html/shadow/MediaControlsChromiumAndroid.h:
Moved enclosure for overlay button to MediaControlElements.cpp/h files
through which different media elements are made available to different ports.

* rendering/RenderMediaControlElements.cpp: new file
* rendering/RenderMediaControlElements.h: new file
Moved rendering classes for media control elements into these files from
MediaControlElements.cpp/h.

* rendering/RenderThemeMac.mm:
Added new RenderMediaControlElements.h file.

* rendering/RenderingAllInOne.cpp:
Added new RenderMediaControlEleemnt.cpp file.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove more Snow Leopard only code
andersca@apple.com [Wed, 5 Dec 2012 03:53:26 +0000 (03:53 +0000)]
Remove more Snow Leopard only code
https://bugs.webkit.org/show_bug.cgi?id=104079

Reviewed by Andreas Kling.

All of the SecKeychainItem code was Snow Leopard only.

* Shared/mac/SecKeychainItemRequestData.cpp: Removed.
* Shared/mac/SecKeychainItemRequestData.h: Removed.
* Shared/mac/SecKeychainItemResponseData.cpp: Removed.
* Shared/mac/SecKeychainItemResponseData.h: Removed.
* UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.h:
* UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm:
* UIProcess/WebProcessProxy.h:
(WebProcessProxy):
* UIProcess/WebProcessProxy.messages.in:
* UIProcess/mac/WebProcessProxyMac.mm:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:
* WebProcess/mac/KeychainItemShimMethods.h: Removed.
* WebProcess/mac/KeychainItemShimMethods.mm: Removed.
* WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::initializeShim):
* WebProcess/mac/WebProcessShim.mm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove PageClient::didChangeScrollbarsForMainFrame
andersca@apple.com [Wed, 5 Dec 2012 03:29:19 +0000 (03:29 +0000)]
Remove PageClient::didChangeScrollbarsForMainFrame
https://bugs.webkit.org/show_bug.cgi?id=104077

Reviewed by Andreas Kling.

The aforementioned function was only used to implement some Snow Leopard specific behavior that we no longer support.

* UIProcess/API/gtk/PageClientImpl.cpp:
* UIProcess/API/gtk/PageClientImpl.h:
(PageClientImpl):
* UIProcess/API/mac/PageClientImpl.h:
(PageClientImpl):
* UIProcess/API/mac/PageClientImpl.mm:
* UIProcess/API/mac/WKView.mm:
(-[WKView viewWillMoveToWindow:]):
* UIProcess/API/mac/WKViewInternal.h:
* UIProcess/API/qt/raw/qrawwebview_p_p.h:
* UIProcess/PageClient.h:
(PageClient):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didChangeScrollbarsForMainFrame):
* UIProcess/efl/PageClientBase.cpp:
(WebKit):
* UIProcess/efl/PageClientBase.h:
(PageClientBase):
* UIProcess/qt/QtPageClient.h:
* UIProcess/win/WebView.cpp:
* UIProcess/win/WebView.h:
(WebView):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening - skip use-href-update-crash.svg on Win.
fmalita@chromium.org [Wed, 5 Dec 2012 03:25:34 +0000 (03:25 +0000)]
Unreviewed gardening - skip use-href-update-crash.svg on Win.

* platform/win/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAssociate URLs with GraphicsContext3D instances created for WebGL
kbr@google.com [Wed, 5 Dec 2012 02:49:07 +0000 (02:49 +0000)]
Associate URLs with GraphicsContext3D instances created for WebGL
https://bugs.webkit.org/show_bug.cgi?id=103793

Reviewed by Adam Barth.

Source/Platform:

* Platform.gyp/Platform.gyp:
    Allow WebURL.h to be included directly or indirectly from Platform.h.
* chromium/public/WebGraphicsContext3D.h:
(Attributes):
    Add top document's URL to context creation attributes.

Source/WebCore:

Pass down the URL of the topmost frame's document creating the
WebGL context to the platform layer through
GraphicsContext3D::Attributes.

Not feasible to write a layout test for this change; has no
user-visible effect. Tested manually with failure injection in
Chromium port.

* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::create):
    Pass top document's URL in context creation attributes.
* platform/chromium/support/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3D::create):
    Pass URL through WebKit API.
* platform/graphics/GraphicsContext3D.h:
(Attributes):
    Add top document's URL to context creation attributes.

Source/WebKit/chromium:

* WebKit.gyp:
    Allow WebURL.h to be included directly or indirectly from Platform.h.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: simplify reportMemoryUsage signature
yurys@chromium.org [Wed, 5 Dec 2012 02:40:25 +0000 (02:40 +0000)]
Web Inspector: simplify reportMemoryUsage signature
https://bugs.webkit.org/show_bug.cgi?id=104028

Reviewed by Vsevolod Vlasov.

Removed const& modifier from instrumented pointer type. Was const T* const&,
now it is const T*

Source/WebCore:

* platform/graphics/NativeImagePtr.h:
(WebCore):
* platform/graphics/skia/NativeImageSkia.cpp:
(WebCore::reportMemoryUsage):

Source/WTF:

* wtf/MemoryInstrumentation.cpp:
(WTF::MemoryClassInfo::addRawBuffer):
* wtf/MemoryInstrumentation.h:
(MemoryInstrumentation):
(WTF::MemoryInstrumentation::selectInstrumentationMethod):
(WTF::MemoryInstrumentation::reportObjectMemoryUsage):
(MemoryClassInfo):
(WTF::reportMemoryUsage):
(WTF::MemoryInstrumentation::addObjectImpl):
(WTF):
* wtf/MemoryInstrumentationArrayBufferView.h:
(WTF::reportMemoryUsage):
* wtf/MemoryInstrumentationHashCountedSet.h:
(WTF::reportMemoryUsage):
* wtf/MemoryInstrumentationHashMap.h:
(WTF::reportMemoryUsage):
* wtf/MemoryInstrumentationHashSet.h:
(WTF::reportMemoryUsage):
* wtf/MemoryInstrumentationListHashSet.h:
(WTF::reportMemoryUsage):
* wtf/MemoryInstrumentationParsedURL.h:
(WTF::reportMemoryUsage):
* wtf/MemoryInstrumentationString.h:
(WTF::reportMemoryUsage):
* wtf/MemoryInstrumentationVector.h:
(WTF::reportMemoryUsage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, WebKit gardening.
tasak@google.com [Wed, 5 Dec 2012 02:35:37 +0000 (02:35 +0000)]
Unreviewed, WebKit gardening.

* platform/chromium-mac-snowleopard/fast/parser/document-write-ignores-later-network-bytes-expected.txt: Removed, rebaseline.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136607 268f45cc-cd09-0410-ab3c-d52691b4dbfc