WebKit.git
10 years agoAdd WKPopupContextMenu.
andersca@apple.com [Tue, 18 Jan 2011 19:56:25 +0000 (19:56 +0000)]
Add WKPopupContextMenu.

Reviewed by Darin Adler.

* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCall alternate CFHTTPCookie functions if available
aroben@apple.com [Tue, 18 Jan 2011 19:15:03 +0000 (19:15 +0000)]
Call alternate CFHTTPCookie functions if available

Fixes <http://webkit.org/b/52637> <rdar://problem/8878984>.

Reviewed by Darin Adler.

* platform/network/cf/CookieJarCFNet.cpp: Added soft-linking macros to
pull in the alternate CFHTTPCookie functions.

(WebCore::cookieDomain):
(WebCore::cookieExpirationTime):
(WebCore::cookieName):
(WebCore::cookiePath):
(WebCore::cookieValue):
Added these wrappers around the CFHTTPCookie functions. We call the
alternate functions if they exist, otherwise fall back to the current
functions.

(WebCore::filterCookies):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
Changed to use the wrapper functions.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit2: Do not assert that the provisional and committed URLs cannot be empty/null
jberlin@webkit.org [Tue, 18 Jan 2011 19:06:58 +0000 (19:06 +0000)]
WebKit2: Do not assert that the provisional and committed URLs cannot be empty/null
https://bugs.webkit.org/show_bug.cgi?id=52641

Reviewed by Darin Adler.

* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::didStartProvisionalLoad):
(WebKit::WebFrameProxy::didCommitLoad):
(WebKit::WebFrameProxy::didFinishLoad):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-18 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 18 Jan 2011 19:06:10 +0000 (19:06 +0000)]
2011-01-18  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Eric Seidel.

        [GTK] Filenames are converted to URLs during edit drags
        https://bugs.webkit.org/show_bug.cgi?id=52096

        * platform/gtk/Skipped: Unskip passing test. Fix a misspelled
        drag and drop test on the list as well.
2011-01-18  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Eric Seidel.

        [GTK] Filenames are converted to URLs during edit drags
        https://bugs.webkit.org/show_bug.cgi?id=52096

        * platform/gtk/DragDataGtk.cpp: Only advertise and deliver filenames as URLs if the
        conversion policy allows it.
        (WebCore::DragData::containsURL): Ditto.
        (WebCore::DragData::asURL): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-18 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Tue, 18 Jan 2011 18:53:35 +0000 (18:53 +0000)]
2011-01-18  Jeremy Orlow  <jorlow@chromium.org>

        [Chromium] Create baselines for svg/css/text-gradient-shadow.svg
        https://bugs.webkit.org/show_bug.cgi?id=52640

        * platform/chromium-linux/svg/css/text-gradient-shadow-expected.checksum: Added.
        * platform/chromium-linux/svg/css/text-gradient-shadow-expected.png: Added.
        * platform/chromium-mac/svg/css/text-gradient-shadow-expected.checksum: Added.
        * platform/chromium-win/svg/css/text-gradient-shadow-expected.checksum: Added.
        * platform/chromium-win/svg/css/text-gradient-shadow-expected.png: Added.
        * platform/chromium-win/svg/css/text-gradient-shadow-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-18 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 18 Jan 2011 18:49:08 +0000 (18:49 +0000)]
2011-01-18  Martin Robinson  <mrobinson@igalia.com>

        Skip two tests which were incorrectly passing before GTK+
        had support for beginDragWithFiles.

        * platform/gtk/Skipped: Skip failing tests.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-18 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 18 Jan 2011 18:24:13 +0000 (18:24 +0000)]
2011-01-18  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        ASSERT in plug-in code when going to youtube
        https://bugs.webkit.org/show_bug.cgi?id=52638

        * PluginProcess/PluginControllerProxy.cpp:
        (WebKit::PluginControllerProxy::paintEntirePlugin):
        Don't try to paint the plug-in if the plug-in frame is empty.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-18 John Knottenbelt <jknotten@chromium.org>
jknotten@chromium.org [Tue, 18 Jan 2011 18:15:36 +0000 (18:15 +0000)]
2011-01-18  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by Jeremy Orlow.

        [Chromium] Adjust test expectations fast/files/revoke-blob-url.html is flaky on linux.
        https://bugs.webkit.org/show_bug.cgi?id=52633

        Combine test expectations for the test into one line.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-18 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 18 Jan 2011 18:11:15 +0000 (18:11 +0000)]
2011-01-18  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Plug-in hosting WebProcess instances appear in Activity Monitor as WebProcess
        https://bugs.webkit.org/show_bug.cgi?id=52635
        <rdar://problem/8731337>

        * PluginProcess/PluginProcess.cpp:
        (WebKit::PluginProcess::initialize):
        Call platformInitialize.

        * PluginProcess/PluginProcess.h:
        Add platformInitialize.

        * PluginProcess/mac/PluginProcessMac.mm:
        (WebKit::PluginProcess::platformInitialize):
        Set the compositing render server port and the visible application name.

        * Shared/Plugins/PluginProcessCreationParameters.cpp:
        (WebKit::PluginProcessCreationParameters::encode):
        (WebKit::PluginProcessCreationParameters::decode):
        Encode/decode the parent process name.

        * Shared/Plugins/PluginProcessCreationParameters.h:
        Add parentProcessName.

        * Shared/WebProcessCreationParameters.cpp:
        (WebKit::WebProcessCreationParameters::encode):
        (WebKit::WebProcessCreationParameters::decode):
        Encode/decode the parent process name.

        * Shared/WebProcessCreationParameters.h:
        Add parentProcessName.

        * UIProcess/Launcher/mac/ProcessLauncherMac.mm:
        (WebKit::ProcessLauncher::launchProcess):
        Don't pass the parent process name here.

        * UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
        (WebKit::PluginProcessProxy::platformInitializePluginProcess):
        Set the visible name.

        * UIProcess/mac/WebContextMac.mm:
        (WebKit::WebContext::platformInitializeWebProcess):
        Pass along the parent process name.

        * WebProcess/mac/WebProcessMac.mm:
        (WebKit::WebProcess::platformInitializeWebProcess):
        Set the visible name.

        * WebProcess/mac/WebProcessMainMac.mm:
        (WebKit::WebProcessMain):
        Don't set the visible name here. It's done in platformInitializeWebProcess.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-18 Helder Correia <helder@sencha.com>
commit-queue@webkit.org [Tue, 18 Jan 2011 18:10:37 +0000 (18:10 +0000)]
2011-01-18  Helder Correia  <helder@sencha.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Incorrect shadow alpha with semi-transparent solid fillStyle
        https://bugs.webkit.org/show_bug.cgi?id=52611

        This is related to bug 52559. The shadow color alpha must be multiplied
        by the context brush alpha.

        New test to ensure correct behavior of canvas with fillPath using a
        semi-transparent fillStyle color and a shadow.

        * fast/canvas/canvas-fillPath-alpha-shadow-expected.txt: Added.
        * fast/canvas/canvas-fillPath-alpha-shadow.html: Added.
        * fast/canvas/script-tests/canvas-fillPath-alpha-shadow.js: Added.
2011-01-18  Helder Correia  <helder@sencha.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Incorrect shadow alpha with semi-transparent solid fillStyle
        https://bugs.webkit.org/show_bug.cgi?id=52611

        This is related to bug 52559. The shadow color alpha must be multiplied
        by the context brush alpha.

        Test: fast/canvas/canvas-fillPath-alpha-shadow.html

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::fillPath):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-18 John Knottenbelt <jknotten@chromium.org>
jknotten@chromium.org [Tue, 18 Jan 2011 17:56:46 +0000 (17:56 +0000)]
2011-01-18  John Knottenbelt  <jknotten@chromium.org>

        Unreviewed; updated chromium test expectations.

        [Chromium] Adjust test expectations fast/files/revoke-blob-url.html is flaky on linux.
        https://bugs.webkit.org/show_bug.cgi?id=52633

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-18 Adam Bergkvist <adam.bergkvist@ericsson.com> and Martin Robinson <mrobi...
mrobinson@webkit.org [Tue, 18 Jan 2011 17:47:40 +0000 (17:47 +0000)]
2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] The GTK+ EventSender needs support for beginDragWithFiles
        https://bugs.webkit.org/show_bug.cgi?id=40833

        Unskip passing tests, add in a GTK+-specific result and one more result
        which is necessary because GTK+ tests run in Xvfb.

        * platform/gtk/Skipped: Unskip tests that are now passing and organize
        the remaining skipped tests.
        * platform/gtk/fast/forms/input-file-re-render-expected.txt: Added.
        * platform/gtk/http/tests/security/clipboard/clipboard-file-access-expected.txt: Added.
2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] The GTK+ EventSender needs support for beginDragWithFiles
        https://bugs.webkit.org/show_bug.cgi?id=40833

        * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
        GTK+ event sender.
        (dragWithFilesDragDataGetCallback): Added.
        (dragWithFilesDragEndCallback): Added.
        (beginDragWithFilesCallback): Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-18 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Tue, 18 Jan 2011 17:40:28 +0000 (17:40 +0000)]
2011-01-18  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: fail resource.requestContent() immediately for WebSocket resources
        Remove webInspector.resources.Types from test expectations.
        https://bugs.webkit.org/show_bug.cgi?id=52628

        * inspector/extensions-api-expected.txt:
2011-01-18  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: fail resource.requestContent() immediately for WebSocket resources
        https://bugs.webkit.org/show_bug.cgi?id=52628

        * English.lproj/localizedStrings.js: Rename WebSocket -> WebSockets in resource catetegories (rest are in plural, too)
        * inspector/front-end/ExtensionServer.js: Do not expose webInspector.resources.Types in extensions API (obsolete)
        (WebInspector.ExtensionServer.prototype._buildExtensionAPIInjectedScript):
        * inspector/front-end/Resource.js:
        (WebInspector.Resource.Type.toUIString): Remove ResourceType.Media as it's not used.
        (WebInspector.Resource.Type.toString): ditto.
        (WebInspector.Resource.prototype.requestContent): Fail immediately for WebSocket resources.
        * inspector/front-end/inspector.js: Rename WebSocket -> WebSockets in resource catetegories (rest are in plural, too)

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-18 Helder Correia <helder@sencha.com>
commit-queue@webkit.org [Tue, 18 Jan 2011 17:19:15 +0000 (17:19 +0000)]
2011-01-18  Helder Correia  <helder@sencha.com>

        Reviewed by Dirk Schulze.

        REGRESSION(75139): SVG gradients are not applied to texts
        https://bugs.webkit.org/show_bug.cgi?id=52531

        r75139 caused a problem with filling and stroking text with a gradient
        fill in SVG. The order of CGContextConcatCTM and CGContextClipToRect
        was mixed up.

        * platform/mac/svg/css/text-gradient-shadow-expected.checksum: Added.
        * platform/mac/svg/css/text-gradient-shadow-expected.png: Added.
        * platform/mac/svg/css/text-gradient-shadow-expected.txt: Added.
        * svg/css/text-gradient-shadow.svg: Added.
2011-01-18  Helder Correia  <helder@sencha.com>

        Reviewed by Dirk Schulze.

        REGRESSION(75139): SVG gradients are not applied to texts
        https://bugs.webkit.org/show_bug.cgi?id=52531

        r75139 caused a problem with filling and stroking text with a gradient
        fill in SVG. The order of CGContextConcatCTM and CGContextClipToRect
        was mixed up.

        Test: svg/css/text-gradient-shadow.svg

        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::fillRect):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-18 John Knottenbelt <jknotten@chromium.org>
jknotten@chromium.org [Tue, 18 Jan 2011 17:07:13 +0000 (17:07 +0000)]
2011-01-18  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by Jeremy Orlow.

        Add pixel test baseline for svg/custom/use-inherit-style.svg
        https://bugs.webkit.org/show_bug.cgi?id=52630

        * svg/custom/use-inherit-style-expected.checksum: Added.
        * svg/custom/use-inherit-style-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-18 Leo Yang <leo.yang@torchmobile.com.cn>
commit-queue@webkit.org [Tue, 18 Jan 2011 15:56:57 +0000 (15:56 +0000)]
2011-01-18  Leo Yang  <leo.yang@torchmobile.com.cn>

        Reviewed by Nikolas Zimmermann.

        Unable to indirectly animate visibility of SVGUseElement
        https://bugs.webkit.org/show_bug.cgi?id=50240

        Test case to verify if SVGUseElement inherits parent's
        style change.

        * svg/custom/use-inherit-style-expected.txt: Added.
        * svg/custom/use-inherit-style.svg: Added.
2011-01-18  Leo Yang  <leo.yang@torchmobile.com.cn>

        Reviewed by Nikolas Zimmermann.

        Unable to indirectly animate visibility of SVGUseElement
        https://bugs.webkit.org/show_bug.cgi?id=50240

        SVGUseElement::recalcStyle should take care of its shadow
        tree's style recalculation when it is called with change >= Inherit
        or when childNeedsStyleRecalc() is true because in these two
        cases needStyleRecalc() may not be true.

        Test: svg/custom/use-inherit-style.svg

        * svg/SVGUseElement.cpp:
        (WebCore::SVGUseElement::recalcStyle):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-18 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Tue, 18 Jan 2011 15:34:45 +0000 (15:34 +0000)]
2011-01-18  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: provide script length to frontend.
        https://bugs.webkit.org/show_bug.cgi?id=52620

        * inspector/Inspector.idl:
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::didParseSource):
        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerModel.prototype._parsedScriptSource):
        (WebInspector.DebuggerDispatcher.prototype.parsedScriptSource):
        * inspector/front-end/Script.js:
        (WebInspector.Script):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-18 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Tue, 18 Jan 2011 15:30:36 +0000 (15:30 +0000)]
2011-01-18  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, remove wrong chromium expectation for console-xhr-logging test.

        * platform/chromium/http/tests/inspector/console-xhr-logging-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixing ChangeLog
zherczeg@webkit.org [Tue, 18 Jan 2011 14:48:00 +0000 (14:48 +0000)]
Fixing ChangeLog

Rubber-stamped by Csaba Osztrogonác

Removing a line introduced by
http://trac.webkit.org/changeset/75743/trunk/Source/WebCore/ChangeLog
Removing an unnecessary space before a time stamp.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-18 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Tue, 18 Jan 2011 14:34:02 +0000 (14:34 +0000)]
2011-01-18  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, test fix for r76019.

        * http/tests/inspector-enabled/console-log-before-frame-navigation-expected.txt:
        * http/tests/inspector-enabled/console-log-before-frame-navigation.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-17 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Tue, 18 Jan 2011 14:25:34 +0000 (14:25 +0000)]
2011-01-17  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [refactoring] use events to notify NetworkManager clients
        https://bugs.webkit.org/show_bug.cgi?id=52588

        * inspector/front-end/AuditLauncherView.js:
        (WebInspector.AuditLauncherView): Do not expose public interface to resource count. Do not reset resource count upon reset().
        (WebInspector.AuditLauncherView.prototype._resetResourceCount):
        (WebInspector.AuditLauncherView.prototype._onResourceStarted):
        (WebInspector.AuditLauncherView.prototype._onResourceFinished):
        * inspector/front-end/AuditsPanel.js: Do not expose public interface to resource start/finish events.
        * inspector/front-end/ExtensionServer.js:
        (WebInspector.ExtensionServer):
        (WebInspector.ExtensionServer.prototype._notifyResourceFinished):
        (WebInspector.ExtensionServer.prototype.initExtensions):
        * inspector/front-end/NetworkManager.js: Dispatch events rather than directly call clients.
        (WebInspector.NetworkManager):
        (WebInspector.NetworkManager.prototype.willSendRequest):
        (WebInspector.NetworkManager.prototype.markResourceAsCached):
        (WebInspector.NetworkManager.prototype.didReceiveResponse):
        (WebInspector.NetworkManager.prototype.didReceiveContentLength):
        (WebInspector.NetworkManager.prototype.setInitialContent):
        (WebInspector.NetworkManager.prototype.didCommitLoadForFrame):
        (WebInspector.NetworkManager.prototype.willSendWebSocketHandshakeRequest):
        (WebInspector.NetworkManager.prototype.didReceiveWebSocketHandshakeResponse):
        (WebInspector.NetworkManager.prototype._startResource):
        (WebInspector.NetworkManager.prototype._finishResource):
        * inspector/front-end/NetworkPanel.js:
        (WebInspector.NetworkPanel):
        (WebInspector.NetworkPanel.prototype._onResourceStarted):
        (WebInspector.NetworkPanel.prototype._appendResource):
        (WebInspector.NetworkPanel.prototype._onResourceUpdated):
        (WebInspector.NetworkPanel.prototype._refreshResource):
        (WebInspector.NetworkPanel.prototype._onMainResourceChanged):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel):
        (WebInspector.ResourcesPanel.prototype._refreshResource):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-18 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 18 Jan 2011 14:20:08 +0000 (14:20 +0000)]
2011-01-18  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: preserve pause on exception state in settings.
        https://bugs.webkit.org/show_bug.cgi?id=52619

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::getInspectorState):
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState):
        * inspector/InspectorDebuggerAgent.h:
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        (WebInspector.ScriptsPanel.prototype.debuggerWasEnabled):
        (WebInspector.ScriptsPanel.prototype._updatePauseOnExceptionsState):
        (WebInspector.ScriptsPanel.prototype._togglePauseOnExceptions):
        (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
        * inspector/front-end/Settings.js:
        (WebInspector.Settings):
        * inspector/front-end/inspector.js:
        (WebInspector.doLoadedDone.populateInspectorState):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-18 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Tue, 18 Jan 2011 14:09:35 +0000 (14:09 +0000)]
2011-01-18  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: fix flaky debugger tests.
        https://bugs.webkit.org/show_bug.cgi?id=51320

        * http/tests/inspector/debugger-test2.js:
        (initialize_DebuggerTest.InspectorTest.setBreakpoint):
        (initialize_DebuggerTest.InspectorTest.showScriptSource):
        (initialize_DebuggerTest.InspectorTest._showScriptSource):
        * inspector/debugger-pause-on-breakpoint-expected.txt:
        * inspector/debugger-pause-on-breakpoint.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-18 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Tue, 18 Jan 2011 13:54:59 +0000 (13:54 +0000)]
2011-01-18  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [REGRESSION] JavaScript exceptions aren't shown in source frame.
        https://bugs.webkit.org/show_bug.cgi?id=52623

        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleMessage):
        (WebInspector.ConsoleMessage.prototype._formatMessage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-18 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 18 Jan 2011 13:42:26 +0000 (13:42 +0000)]
2011-01-18  Pavel Feldman  <pfeldman@chromium.org>

        Revert r76017. No need to guard InspectorInstrumentation:: in WebCore.

        * page/Page.cpp:
        (WebCore::networkStateChanged):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-18 Konstantin Tokarev <annulen@yandex.ru>
commit-queue@webkit.org [Tue, 18 Jan 2011 12:44:53 +0000 (12:44 +0000)]
2011-01-18  Konstantin Tokarev  <annulen@yandex.ru>

        Reviewed by Kent Tamura.

        Fixed compilation when Inspector is disabled
        https://bugs.webkit.org/show_bug.cgi?id=52564

        * page/Page.cpp:
        (WebCore::networkStateChanged): Added ENABLE(INSPECTOR) guard

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-18 MORITA Hajime <morrita@google.com>
morrita@google.com [Tue, 18 Jan 2011 12:26:48 +0000 (12:26 +0000)]
2011-01-18  MORITA Hajime  <morrita@google.com>

        Unreviewed, rolling out r76004, r76005, r76007, and r76011.
        http://trac.webkit.org/changeset/76004
        http://trac.webkit.org/changeset/76005
        http://trac.webkit.org/changeset/76007
        http://trac.webkit.org/changeset/76011
        https://bugs.webkit.org/show_bug.cgi?id=51664

        The r76004 broke pixel tests.
        (The failure was missed due to the tolerance.)

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::addRoundedRectClip):
        (WebCore::GraphicsContext::clipOutRoundedRect):
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/RoundedIntRect.cpp: Removed.
        * platform/graphics/RoundedIntRect.h: Removed.
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::pushContentsClip):
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintFillLayerExtended):
        (WebCore::RenderBoxModelObject::paintBorder):
        (WebCore::RenderBoxModelObject::clipBorderSidePolygon):
        (WebCore::uniformlyExpandBorderRadii):
        (WebCore::RenderBoxModelObject::paintBoxShadow):
        * rendering/RenderBoxModelObject.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::drawBoxSideFromPath):
        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::paint):
        * rendering/RenderThemeChromiumWin.cpp:
        (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::paintMenuListButtonGradients):
        (WebCore::RenderThemeMac::paintSliderTrack):
        * rendering/RenderThemeSafari.cpp:
        (WebCore::RenderThemeSafari::paintMenuListButtonGradients):
        (WebCore::RenderThemeSafari::paintSliderTrack):
        * rendering/RenderThemeWinCE.cpp:
        (WebCore::RenderThemeWinCE::paintSearchFieldCancelButton):
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::paint):
        * rendering/style/BorderData.h:
        * rendering/style/RenderStyle.cpp:
        (WebCore::constrainCornerRadiiForRect):
        (WebCore::RenderStyle::getBorderRadiiForRect):
        (WebCore::RenderStyle::getInnerBorderRadiiForRectWithBorderWidths):
        * rendering/style/RenderStyle.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-18 Hayato Ito <hayato@chromium.org>
hayato@chromium.org [Tue, 18 Jan 2011 12:19:32 +0000 (12:19 +0000)]
2011-01-18  Hayato Ito  <hayato@chromium.org>

        Reviewed by Kent Tamura.

        Update .gitignore file to reflect a recent WebKit directory movement.

        https://bugs.webkit.org/show_bug.cgi?id=52618

        * .gitignore:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] Not implemented warnings should not break layout tests
kbalazs@webkit.org [Tue, 18 Jan 2011 12:16:40 +0000 (12:16 +0000)]
[Qt][WK2] Not implemented warnings should not break layout tests
https://bugs.webkit.org/show_bug.cgi?id=52616

Reviewed by Csaba Osztrogonác.

* WebKit2Prefix.h: Define DISABLE_NOT_IMPLEMENTED_WARNINGS on Qt.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-17 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Tue, 18 Jan 2011 11:04:57 +0000 (11:04 +0000)]
2011-01-17  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: add source column field to debugger call frames.
        https://bugs.webkit.org/show_bug.cgi?id=52443

        * bindings/js/JavaScriptCallFrame.cpp:
        (WebCore::JavaScriptCallFrame::JavaScriptCallFrame):
        * bindings/js/JavaScriptCallFrame.h:
        (WebCore::JavaScriptCallFrame::create):
        (WebCore::JavaScriptCallFrame::line):
        (WebCore::JavaScriptCallFrame::column):
        (WebCore::JavaScriptCallFrame::update):
        * bindings/js/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::createCallFrameAndPauseIfNeeded):
        (WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):
        (WebCore::ScriptDebugServer::callEvent):
        (WebCore::ScriptDebugServer::atStatement):
        (WebCore::ScriptDebugServer::returnEvent):
        (WebCore::ScriptDebugServer::exception):
        (WebCore::ScriptDebugServer::willExecuteProgram):
        (WebCore::ScriptDebugServer::didExecuteProgram):
        (WebCore::ScriptDebugServer::didReachBreakpoint):
        * bindings/js/ScriptDebugServer.h:
        * bindings/v8/DebuggerScript.js:
        ():
        * bindings/v8/JavaScriptCallFrame.cpp:
        (WebCore::JavaScriptCallFrame::column):
        * bindings/v8/JavaScriptCallFrame.h:
        * inspector/InjectedScriptSource.js:
        ():
        * inspector/JavaScriptCallFrame.idl:

 2011-01-18  Antti Koivisto  <antti@apple.com>

        Reviewed by Dave Hyatt.

        https://bugs.webkit.org/show_bug.cgi?id=52370
        <rdar://problem/8856808>
        Style sharing optimization no longer works on major web sites

        The code in CSSStyleSelector::locateSharedStyle() that tries to share style information between element has been defeated
        by widespread use of certain CSS selectors (:first-child pseudo class and similar). The current implementation disables
        the sharing optimization for the whole page if one of these constructs is seen in any style sheet used by the page.

        This patch gets the style sharing back to 25-40% range on most web sites.

        * css/CSSMutableStyleDeclaration.h:
        (WebCore::CSSMutableStyleDeclaration::propertiesEqual):

            Needed to improve equality checking in NamedNodeMap::mappedMapsEquivalent.

        * css/CSSSelector.h:
        (WebCore::CSSSelector::isSiblingSelector):

            Test for selectors that are affected by the sibling elements.

        * css/CSSStyleSelector.cpp:
        (WebCore::elementCanUseSimpleDefaultStyle):
        (WebCore::collectSiblingRulesInDefaultStyle):
        (WebCore::assertNoSiblingRulesInDefaultStyle):

            Extract sibling rules from the MathML default stylesheet.
            Assert that no other default stylesheet has them.

        (WebCore::CSSStyleSelector::CSSStyleSelector):
        (WebCore::CSSStyleSelector::locateCousinList):
        (WebCore::CSSStyleSelector::matchesSiblingRules):
        (WebCore::CSSStyleSelector::canShareStyleWithElement):
        (WebCore::CSSStyleSelector::locateSharedStyle):
        (WebCore::CSSStyleSelector::styleForElement):
        (WebCore::collectIdsAndSiblingRulesFromList):
        (WebCore::CSSRuleSet::collectIdsAndSiblingRules):

            Track sibling rules and ids used in the stylesheets to allow much more fine-grained rejection of cases
            where style sharing can't be used.

        * css/CSSStyleSelector.h:
        * dom/NamedNodeMap.cpp:
        (WebCore::NamedNodeMap::mappedMapsEquivalent):

            Check also for CSSValue mutation from DOM.

        * mathml/MathMLMathElement.cpp:
        (WebCore::MathMLMathElement::insertedIntoDocument):
        * mathml/MathMLMathElement.h:

            MathML default style sheet has sibling rules which don't get noticed by the normal document
            stylesheet parsing.

        * rendering/style/RenderStyle.h:
        (WebCore::InheritedFlags::setFirstChildState):
        (WebCore::InheritedFlags::setLastChildState):
        (WebCore::InheritedFlags::setChildIndex):

            These all make style non-shareable (unique).

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: 2011-01-18 Antti Koivisto <antti@apple.com>
antti@apple.com [Tue, 18 Jan 2011 10:48:22 +0000 (10:48 +0000)]
Source/WebCore:  2011-01-18  Antti Koivisto  <antti@apple.com>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=52370
<rdar://problem/8856808>
Style sharing optimization no longer works on major web sites

The code in CSSStyleSelector::locateSharedStyle() that tries to share style information between element has been defeated
by widespread use of certain CSS selectors (:first-child pseudo class and similar). The current implementation disables
the sharing optimization for the whole page if one of these constructs is seen in any style sheet used by the page.

This patch gets the style sharing back to 25-40% range on most web sites.

* css/CSSMutableStyleDeclaration.h:
(WebCore::CSSMutableStyleDeclaration::propertiesEqual):

    Needed to improve equality checking in NamedNodeMap::mappedMapsEquivalent.

* css/CSSSelector.h:
(WebCore::CSSSelector::isSiblingSelector):

    Test for selectors that are affected by the sibling elements.

* css/CSSStyleSelector.cpp:
(WebCore::elementCanUseSimpleDefaultStyle):
(WebCore::collectSiblingRulesInDefaultStyle):
(WebCore::assertNoSiblingRulesInDefaultStyle):

    Extract sibling rules from the MathML default stylesheet.
    Assert that no other default stylesheet has them.

(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::locateCousinList):
(WebCore::CSSStyleSelector::matchesSiblingRules):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::locateSharedStyle):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::collectIdsAndSiblingRulesFromList):
(WebCore::CSSRuleSet::collectIdsAndSiblingRules):

    Track sibling rules and ids used in the stylesheets to allow much more fine-grained rejection of cases
    where style sharing can't be used.

* css/CSSStyleSelector.h:
* dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::mappedMapsEquivalent):

    Check also for CSSValue mutation from DOM.

* mathml/MathMLMathElement.cpp:
(WebCore::MathMLMathElement::insertedIntoDocument):
* mathml/MathMLMathElement.h:

    MathML default style sheet has sibling rules which don't get noticed by the normal document
    stylesheet parsing.

* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::setFirstChildState):
(WebCore::InheritedFlags::setLastChildState):
(WebCore::InheritedFlags::setChildIndex):

    These all make style non-shareable (unique).

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=52370
Style sharing optimization no longer works on major web sites

Reviewed by Dave Hyatt.

These are progressions (with no noticable visual change).
MathML code was improperly sharing style.

* platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
* platform/mac/mathml/presentation/subsup-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-18 MORITA Hajime <morrita@google.com>
morrita@google.com [Tue, 18 Jan 2011 10:37:24 +0000 (10:37 +0000)]
2011-01-18  MORITA Hajime  <morrita@google.com>

        Unreviewed crash fix on release builds.

        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintFillLayerExtended):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-18 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Tue, 18 Jan 2011 10:20:20 +0000 (10:20 +0000)]
2011-01-18  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, update localizedStrings.js.

        * English.lproj/localizedStrings.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-11 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Tue, 18 Jan 2011 10:15:32 +0000 (10:15 +0000)]
2011-01-11  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: implement script beautifier prototype.
        https://bugs.webkit.org/show_bug.cgi?id=51588

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/ScriptFormatter.js: Added.
        (WebInspector.ScriptFormatter): Implements JavaScript source beautification and conversion between original and
        formatted line numbers
        (WebInspector.ScriptFormatter.findLineEndings):
        (WebInspector.ScriptFormatter.locationToPosition):
        (WebInspector.ScriptFormatter.positionToLocation):
        (WebInspector.ScriptFormatter.upperBound):
        (WebInspector.ScriptFormatter.prototype.format):
        (WebInspector.ScriptFormatter.prototype.originalLineNumberToFormattedLineNumber):
        (WebInspector.ScriptFormatter.prototype.formattedLineNumberToOriginalLineNumber):
        (WebInspector.ScriptFormatter.prototype.originalPositionToFormattedLineNumber):
        (WebInspector.ScriptFormatter.prototype.formattedLineNumberToOriginalPosition):
        (WebInspector.ScriptFormatter.prototype._convertPosition):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        (WebInspector.ScriptsPanel.prototype._clearCurrentExecutionLine):
        (WebInspector.ScriptsPanel.prototype._callFrameSelected):
        (WebInspector.ScriptsPanel.prototype._formatScript):
        * inspector/front-end/SourceFrame.js: Convert original line numbers to UI line numbers and vice versa
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-18 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Tue, 18 Jan 2011 10:02:52 +0000 (10:02 +0000)]
2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Adam Barth.

        ews: Add additional watcher to efl ews
        https://bugs.webkit.org/show_bug.cgi?id=52613

        Add gyuyoung.kim@samsung.com to watcher list of efl-ews.

        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-18 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 18 Jan 2011 09:32:33 +0000 (09:32 +0000)]
2011-01-18  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, GTK build fix as follow-up of r76004.

        * GNUmakefile.am: Include RoundedIntRect files in the build

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-18 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 18 Jan 2011 09:24:50 +0000 (09:24 +0000)]
2011-01-18  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, rolling out r76002.
        http://trac.webkit.org/changeset/76002
        https://bugs.webkit.org/show_bug.cgi?id=49790

        breaks a bunch of fast/forms tests on mac and GTK

        * fast/forms/select-option-background-color-change.html: Removed.
        * fast/forms/select-option-color-change.html: Removed.
        * fast/forms/select-option-visibility-change.html: Removed.
        * platform/mac/fast/forms/select-option-background-color-change-expected.checksum: Removed.
        * platform/mac/fast/forms/select-option-background-color-change-expected.png: Removed.
        * platform/mac/fast/forms/select-option-background-color-change-expected.txt: Removed.
        * platform/mac/fast/forms/select-option-color-change-expected.checksum: Removed.
        * platform/mac/fast/forms/select-option-color-change-expected.png: Removed.
        * platform/mac/fast/forms/select-option-color-change-expected.txt: Removed.
        * platform/mac/fast/forms/select-option-visibility-change-expected.checksum: Removed.
        * platform/mac/fast/forms/select-option-visibility-change-expected.png: Removed.
        * platform/mac/fast/forms/select-option-visibility-change-expected.txt: Removed.
2011-01-18  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, rolling out r76002.
        http://trac.webkit.org/changeset/76002
        https://bugs.webkit.org/show_bug.cgi?id=49790

        breaks a bunch of fast/forms tests on mac and GTK

        * html/HTMLOptionElement.cpp:
        (WebCore::HTMLOptionElement::setRenderStyle):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-18 MORITA Hajime <morrita@google.com>
morrita@google.com [Tue, 18 Jan 2011 09:13:43 +0000 (09:13 +0000)]
2011-01-18 MORITA Hajime <morrita@google.com>

        Unreviewed windows build fix.

        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-17 MORITA Hajime <morrita@google.com>
morrita@google.com [Tue, 18 Jan 2011 08:59:01 +0000 (08:59 +0000)]
2011-01-17  MORITA Hajime  <morrita@google.com>

        Reviewed by Simon Fraser.

        Refactoring: Extract RoundedIntRect class
        https://bugs.webkit.org/show_bug.cgi?id=51664

        RoundedIntRect is a pair of rect and four IntSize objects which represent
        corner radii of the rectangle. IntSize is grouped into RoundedIntRect::Radii.
        Now RenderStyle::getRoundedBorderFor() and RenderStyle::getRoundedInnerBorderWithBorderWidths()
        return RoundedIntRect and GraphicsContext::addRoundedRectClip(), GraphicsContext::fillRoundedRect()
        and other functions accept RoundedIntRect as an argument.

        No new tests. No behavioral change.

        * Android.mk:
        * CMakeLists.txt:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::addRoundedRectClip):
        (WebCore::GraphicsContext::clipOutRoundedRect):
        (WebCore::GraphicsContext::fillRoundedRect):
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/RoundedIntRect.cpp: Added.
        (WebCore::RoundedIntRect::Radii::isZero):
        (WebCore::RoundedIntRect::Radii::scale):
        (WebCore::RoundedIntRect::Radii::expand):
        (WebCore::RoundedIntRect::Radii::includeLogicalEdges):
        (WebCore::RoundedIntRect::Radii::excludeLogicalEdges):
        (WebCore::RoundedIntRect::RoundedIntRect):
        (WebCore::RoundedIntRect::includeLogicalEdges):
        (WebCore::RoundedIntRect::excludeLogicalEdges):
        * platform/graphics/RoundedIntRect.h: Added.
        (WebCore::RoundedIntRect::Radii::Radii):
        (WebCore::RoundedIntRect::Radii::setTopLeft):
        (WebCore::RoundedIntRect::Radii::setTopRight):
        (WebCore::RoundedIntRect::Radii::setBottomLeft):
        (WebCore::RoundedIntRect::Radii::setBottomRight):
        (WebCore::RoundedIntRect::Radii::topLeft):
        (WebCore::RoundedIntRect::Radii::topRight):
        (WebCore::RoundedIntRect::Radii::bottomLeft):
        (WebCore::RoundedIntRect::Radii::bottomRight):
        (WebCore::RoundedIntRect::Radii::expand):
        (WebCore::RoundedIntRect::Radii::shrink):
        (WebCore::RoundedIntRect::location):
        (WebCore::RoundedIntRect::size):
        (WebCore::RoundedIntRect::x):
        (WebCore::RoundedIntRect::y):
        (WebCore::RoundedIntRect::width):
        (WebCore::RoundedIntRect::height):
        (WebCore::RoundedIntRect::right):
        (WebCore::RoundedIntRect::bottom):
        (WebCore::RoundedIntRect::rect):
        (WebCore::RoundedIntRect::radii):
        (WebCore::RoundedIntRect::isRounded):
        (WebCore::RoundedIntRect::isEmpty):
        (WebCore::RoundedIntRect::setRect):
        (WebCore::RoundedIntRect::setRadii):
        (WebCore::RoundedIntRect::move):
        (WebCore::RoundedIntRect::inflate):
        (WebCore::RoundedIntRect::inflateWithRadii):
        (WebCore::RoundedIntRect::expandRadii):
        (WebCore::RoundedIntRect::shrinkRadii):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::pushContentsClip):
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintFillLayerExtended):
        (WebCore::RenderBoxModelObject::paintBorder):
        (WebCore::RenderBoxModelObject::clipBorderSidePolygon):
        (WebCore::RenderBoxModelObject::paintBoxShadow):
        * rendering/RenderBoxModelObject.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::drawBoxSideFromPath):
        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::paint):
        * rendering/RenderThemeChromiumWin.cpp:
        (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::paintMenuListButtonGradients):
        (WebCore::RenderThemeMac::paintSliderTrack):
        * rendering/RenderThemeSafari.cpp:
        (WebCore::RenderThemeSafari::paintMenuListButtonGradients):
        (WebCore::RenderThemeSafari::paintSliderTrack):
        * rendering/RenderThemeWinCE.cpp:
        (WebCore::RenderThemeWinCE::paintSearchFieldCancelButton):
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::paint):
        * rendering/style/BorderData.h:
        * rendering/style/RenderStyle.cpp:
        (WebCore::calcRadiiFor):
        (WebCore::calcConstraintScaleFor):
        (WebCore::RenderStyle::getRoundedBorderFor):
        (WebCore::RenderStyle::getRoundedInnerBorderWithBorderWidths):
        * rendering/style/RenderStyle.h:
        (WebCore::InheritedFlags::setBorderRadius):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
ossy@webkit.org [Tue, 18 Jan 2011 08:43:30 +0000 (08:43 +0000)]
Unreviewed.

[Qt] Fix LoadHTMLStringItem::invoke() after r75966
https://bugs.webkit.org/show_bug.cgi?id=52614

* platform/qt/Skipped: http/tests/navigation/go-back-to-error-page.html added until fix.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-17 Rob Buis <rwlbuis@gmail.com>
rwlbuis@webkit.org [Tue, 18 Jan 2011 08:00:50 +0000 (08:00 +0000)]
2011-01-17  Rob Buis  <rwlbuis@gmail.com>

        Reviewed by Kent Tamura.

        Color changes to option elements in a select multiple aren't drawn immediately
        https://bugs.webkit.org/show_bug.cgi?id=49790

        Redirect style changes on <option> element to the owner <select> element.

        Tests: fast/forms/select-option-background-color-change.html
               fast/forms/select-option-color-change.html
               fast/forms/select-option-visibility-change.html

        * html/HTMLOptionElement.cpp:
        (WebCore::HTMLOptionElement::setRenderStyle):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-17 MORITA Hajime <morrita@google.com>
morrita@google.com [Tue, 18 Jan 2011 07:12:43 +0000 (07:12 +0000)]
2011-01-17  MORITA Hajime  <morrita@google.com>

        Unreviewed, rolling out r75995.
        http://trac.webkit.org/changeset/75995
        https://bugs.webkit.org/show_bug.cgi?id=51914

        Causes assertion failures.

        * dom/Element.cpp:
        (WebCore::Element::shadowRoot):
        (WebCore::Element::setShadowRoot):
        (WebCore::Element::removeShadowRoot):
        * dom/ElementRareData.h:
        (WebCore::ElementRareData::ElementRareData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-17 MORITA Hajime <morrita@google.com>
morrita@google.com [Tue, 18 Jan 2011 07:08:56 +0000 (07:08 +0000)]
2011-01-17  MORITA Hajime  <morrita@google.com>

        Unreviewed, rolling out r75999.
        http://trac.webkit.org/changeset/75999

        * dom/Element.cpp:
        (WebCore::Element::removeShadowRoot):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-17 MORITA Hajime <morrita@google.com>
morrita@google.com [Tue, 18 Jan 2011 06:52:41 +0000 (06:52 +0000)]
2011-01-17 MORITA Hajime  <morrita@google.com>

        Unreviewed crash fix, which introduced at r75995

        * dom/Element.cpp:
        (WebCore::Element::removeShadowRoot):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-17 Steve Lacey <sjl@chromium.org>
commit-queue@webkit.org [Tue, 18 Jan 2011 05:40:20 +0000 (05:40 +0000)]
2011-01-17  Steve Lacey  <sjl@chromium.org>

        Reviewed by David Levin.

        Rebaseline media/video-zoom-controls for chromium.
        https://bugs.webkit.org/show_bug.cgi?id=52415

        * platform/chromium-linux/media/video-zoom-controls-expected.checksum: Added.
        * platform/chromium-linux/media/video-zoom-controls-expected.png: Added.
        * platform/chromium-mac/media/video-zoom-controls-expected.checksum: Added.
        * platform/chromium-mac/media/video-zoom-controls-expected.png: Added.
        * platform/chromium-mac/media/video-zoom-controls-expected.txt: Added.
        * platform/chromium-win/media/video-zoom-controls-expected.checksum: Added.
        * platform/chromium-win/media/video-zoom-controls-expected.png: Added.
        * platform/chromium-win/media/video-zoom-controls-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-17 MORITA Hajime <morrita@google.com>
morrita@google.com [Tue, 18 Jan 2011 04:30:28 +0000 (04:30 +0000)]
2011-01-17  MORITA Hajime  <morrita@google.com>

        Reviewed by Dimitri Glazkov.

        ElementRareData::m_shadowRoot should not be RefPtr.
        https://bugs.webkit.org/show_bug.cgi?id=51914

        This change makes m_shadowRoot a raw pointer, as Node::m_parent is.
        This change is safe because shadow host pointer is stored as TreeShared::m_parent
        which prevents deletion unless set to null.

        No test, no behavioral change.

        * dom/Element.cpp:
        (WebCore::Element::shadowRoot):
        (WebCore::Element::setShadowRoot):
        (WebCore::Element::removeShadowRoot):
        * dom/ElementRareData.h:
        (WebCore::ElementRareData::ElementRareData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-17 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Tue, 18 Jan 2011 03:49:08 +0000 (03:49 +0000)]
2011-01-17  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Dan Bernstein.

        Some WebKit2 layout tests crash due to focus being on a frame in the page cache
        https://bugs.webkit.org/show_bug.cgi?id=52607

        No new tests. Existing tests crash in WebKit2 without this fix.

        I suspect there are other consequences besides the WebKit2 crash, but I
        was unable to identify any for certain.

        * history/CachedFrame.cpp:
        (WebCore::CachedFrame::CachedFrame): If a frame still has focus when its page
        goes in the page cache, reset focus to the main frame.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Not reviewed, test expectations update.
dimich@chromium.org [Tue, 18 Jan 2011 03:15:17 +0000 (03:15 +0000)]
[Chromium] Not reviewed, test expectations update.
Added TIMEOUT to  fast/canvas/canvas-fillPath-pattern-shadow.html

* platform/chromium-gpu/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-17 Jarred Nicholls <jarred@sencha.com>
commit-queue@webkit.org [Tue, 18 Jan 2011 03:10:32 +0000 (03:10 +0000)]
2011-01-17  Jarred Nicholls  <jarred@sencha.com>

        Reviewed by Csaba Osztrogonác.

        REGRESSION(r75709): Return value of fscanf() shouldn't be ignored.
        https://bugs.webkit.org/show_bug.cgi?id=52585

        gcc 4.4.4+ has warn_unused_value attribute on fscanf, so we should check
        the return value to get around the gcc warning

        * jit/ExecutableAllocatorFixedVMPool.cpp:
        (JSC::maybeModifyVMPoolSize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-17 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Tue, 18 Jan 2011 02:10:15 +0000 (02:10 +0000)]
2011-01-17  Michael Saboff  <msaboff@apple.com>

        Reviewed by Oliver Hunt.

        [regexfuzz] Crash running regex with lookahead
        https://bugs.webkit.org/show_bug.cgi?id=52548

        Eliminated agressive chaining of backtracks.  This code was overwriting
        already valid backtrack information.

        * yarr/YarrJIT.cpp:
        (JSC::Yarr::YarrGenerator::ParenthesesTail::processBacktracks):
2011-01-17  Michael Saboff  <msaboff@apple.com>

        Reviewed by Oliver Hunt.

        [regexfuzz] Crash running regex with lookahead
        https://bugs.webkit.org/show_bug.cgi?id=52548

        New tests from regex fuzzer.

        * fast/regex/parentheses-expected.txt:
        * fast/regex/script-tests/parentheses.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Not reviewed, test expectations update.
dimich@chromium.org [Tue, 18 Jan 2011 02:06:00 +0000 (02:06 +0000)]
[Chromium] Not reviewed, test expectations update.
Same as previous patch, now for -gpu file.

* platform/chromium-gpu/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Not reviewed, test expectations update.
dimich@chromium.org [Tue, 18 Jan 2011 01:55:17 +0000 (01:55 +0000)]
[Chromium] Not reviewed, test expectations update.
fast/canvas/canvas-fillPath-pattern-shadow.html fails on Win and Linux.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSimplify WKCACFLayerRenderer's API
aroben@apple.com [Tue, 18 Jan 2011 01:46:53 +0000 (01:46 +0000)]
Simplify WKCACFLayerRenderer's API

createRenderer/destroyRenderer are now hidden behind setHostWindow.
WKCACFLayerRendererClient::animationsStarted has been removed, as it
was never called. (The work it was supposed to do was already being
accomplished by WKCACFLayerRenderer::render telling each layer that
animations are starting.)

Fixes <http://webkit.org/b/52587> WKCACFLayerRenderer is hard to use

Reviewed by Chris Marrin.

Source/WebCore:

* platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
(WebCore::MediaPlayerPrivateFullscreenWindow::createWindow): Moved the
call to setHostWindow here from the WM_CREATE handler. The WM_CREATE
handler was causing the Direct3D device to be created, but MSDN says
you shouldn't create a device while handling WM_CREATE. Removed
no-longer-needed call to createRenderer (setHostWindow does this now)
and the never-needed call to setNeedsDisplay (we never draw into the
root layer; this was just creating an unnecessary backing store the
size of the screen!).
(WebCore::MediaPlayerPrivateFullscreenWindow::wndProc): Moved WM_CREATE
code, as described above. Removed call to destroyRenderer when handling
WM_DESTROY; setHostWindow does this now. Fixed up our WM_PAINT handler
to do a synchronous paint and to clear our dirty region, while I was in
here.

* platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::~WKCACFLayerRenderer): Changed to call
setHostWindow instead of destroyRenderer; the former calls the latter
if needed.
(WebCore::WKCACFLayerRenderer::setHostWindow): Moved here from the
header file. Destroys our old renderer (i.e., IDirect3DDevice9) if
we're losing our window, or creates a renderer if we're gaining a
window.
(WebCore::WKCACFLayerRenderer::createRenderer): Updated for WKSI function rename.
(WebCore::WKCACFLayerRenderer::destroyRenderer): Changed to clear the
D3D device from our context before releasing the device.

* platform/graphics/win/WKCACFLayerRenderer.h: Removed
WKCACFLayerRendererClient::animationsStarted. Removed setNeedsDisplay.
Make createRenderer, destroyRenderer, and renderSoon private.

WebKit/win:

Update for WKCACFLayerRenderer changes

* WebView.cpp:
(WebView::WebViewWndProc): Removed call to layerRendererBecameVisible
when handling WM_SHOWWINDOW. All this did was try to create the
renderer, but it had already been created in setAcceleratedCompositing,
so wasn't needed.
(WebView::setAcceleratedCompositing): Removed call to createRenderer;
setHostWindow does this for us now.

* WebView.h: Removed animationsStarted and layerRendererBecameVisible.

WebKitLibraries:

Make it possible to both set and clear a wkCACFContext's D3D device

* win/include/WebKitSystemInterface/WebKitSystemInterface.h:
* win/lib/WebKitSystemInterface.lib:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPaint directly into a GraphicsLayer when using accelerated compositing
aroben@apple.com [Tue, 18 Jan 2011 01:45:56 +0000 (01:45 +0000)]
Paint directly into a GraphicsLayer when using accelerated compositing

Before this patch, we were painting into our normal backing store
HBITMAP, wrapping it in a CGImage, and handing it off to Core
Animation. This had at least two disadvantages:
   1) The bitmap could be modified while Core Animation was using it.
   2) It introduced extra complexity.

When entering accelerated compositing mode, WebView now creates a
GraphicsLayer to draw into. This GraphicsLayer sits between the root
layer (owned by WKCACFLayerRenderer) and the RenderView's layer. When
WebView invalidates, it just calls setNeedsDisplayInRect on its
GraphicsLayer. When WebView paints, it just tells its
WKCACFLayerRenderer to paint, which will call back to WebView to draw
into the GraphicsLayer if it has a dirty region. This is very similar
to the current implementation of LayerBackedDrawingArea in WebKit2.

Fixes <http://webkit.org/b/52582> WebView should paint directly into a
GraphicsLayer when in accelerated compositing mode

Reviewed by Simon Fraser and Chris Marrin.

WebCore:

Remove special-cased support for providing content for the root layer

Clients will just have to provide content through the normal
GraphicsLayer channels now!

* platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): Removed
initialization of m_backingStoreDirty, which has itself been removed.
(WebCore::WKCACFLayerRenderer::setNeedsDisplay): Moved code to schedule
a sync from here to syncCompositingStateSoon. We only need to call
renderSoon if we don't call syncCompositingStateSoon; the latter
function calls the former.
(WebCore::WKCACFLayerRenderer::paint): Removed code to handle
m_backingStoreDirty. We don't want to know anything about clients'
backing stores.
(WebCore::WKCACFLayerRenderer::syncCompositingStateSoon): Added. Code
came from setNeedsDisplay.

* platform/graphics/win/WKCACFLayerRenderer.h:
Removed setRootContents[AndDisplay], setBackingStoreDirty, and
m_backingStoreDirty. Made paint() public so that clients can force a
synchronous render (e.g., when handling WM_PAINT).

WebKit/win:

* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::attachRootGraphicsLayer):
(WebChromeClient::scheduleCompositingLayerSync):
Updated for WebView changes.

* WebView.cpp:
(WebView::repaint): When using accelerated compositing, just invalidate
our backing layer. This matches the behavior of LayerBackedDrawingArea.
(WebView::deleteBackingStore): Removed accelerated compositing code.
The WKCACFLayerRenderer doesn't need to know about our backing store
anymore; we don't use it at all when in accelerated compositing mode.
(WebView::addToDirtyRegion): When using accelerated compositing, just
invalidate our backing layer.
(WebView::scrollBackingStore): Added an assertion that this isn't
called in accelerated compositing mode.
(WebView::sizeChanged): Update our backing layer's size, too, and
invalidate it.
(WebView::updateBackingStore): Added an assertion that this isn't
called in accelerated compositing mode.
(WebView::paint): If we're in accelerated compositing mode, sync our
compositing state. If we're *still* in accelerated compositing mode,
just tell our WKCACFLayerRenderer to paint and clear our dirty region.
(The later changes in this function are just un-indenting code that
used to be inside an if.)

(WebView::paintIntoBackingStore):
(WebView::paintIntoWindow):
Added assertions that these aren't called in accelerated compositing
mode.

(WebView::WebViewWndProc): Updated WM_XP_THEMECHANGED handling for
removal of setRootLayerNeedsDisplay.
(WebView::setRootChildLayer): Changed to take a GraphicsLayer. We now
set the layer as a child of our own backing layer.
(WebView::scheduleCompositingLayerSync): Just call through to
WKCACFLayerRenderer.
(WebView::setAcceleratedCompositing): Create our backing layer and set
it as the child of WKCACFLayerRenderer's root layer.
(WebView::notifyAnimationStarted): Added. We never expect this
GraphicsLayerClient override to be called, as we don't use animations
on our backing layer.
(WebView::notifySyncRequired): Added. Just schedule a sync.
(WebView::paintContents): Added. Just clip and paint!

(WebView::showDebugBorders):
(WebView::showRepaintCounter):
Added. These just call through to Settings.

(WebView::syncCompositingState): Changed to first update layout, then
sync state for our backing layer, then sync WebCore's state. This
matches LayerBackedDrawingArea.

* WebView.h: WebView now implements the GraphicsLayerClient interface.
Removed setRootLayerNeedsDisplay; it's been replaced by calling
setNeedsDisplay on our backing layer and calling
syncCompositingStateSoon on WKCACFLayerRenderer as needed. Removed
updateRootLayerContents; that function was used to pass our backing
store to Core Animation, which we no longer do. Added m_backingLayer.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove contexts from WKCACFContextFlusher before destroying them
aroben@apple.com [Tue, 18 Jan 2011 01:45:14 +0000 (01:45 +0000)]
Remove contexts from WKCACFContextFlusher before destroying them

We aren't really using WKCACFContextFlusher for anything useful at the
moment, but that will probably change in the near future.

I couldn't come up with a way to test this because it isn't possible to
resize a window in DumpRenderTree.

Fixes <http://webkit.org/b/52573> REGRESSION (r75262): Crash beneath
WKCACFContextFlusher::flushAllContexts when resizing window on page
that uses accelerated compositing

Reviewed by Simon Fraser.

* platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::~WKCACFLayerRenderer): Remove our
context from WKCACFContextFlusher. (This code was erroneously removed
from WKCACFLayerRenderer::destroyRenderer in r75262. This is a more
sensible place for it.)

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDon't access the CACFLayerRef's sublayers directly from PlatformCALayer
aroben@apple.com [Tue, 18 Jan 2011 01:44:40 +0000 (01:44 +0000)]
Don't access the CACFLayerRef's sublayers directly from PlatformCALayer

There might be a secret extra sublayer (the tile parent layer) that
PlatformCALayer doesn't know about. When PlatformCALayer would
encounter this, it would try to use the tile parent layer's
PlatformCALayer wrapper, which was null, and then would crash. We now
ask PlatformCALayerWinInternal for the sublayer list, since that class
knows about the tile parent layer and can exclude it from the sublayer
list.

Covered by compositing/tiling/huge-layer-resize.html.

Fixes <http://webkit.org/b/52597> Crash beneath
PlatformCALayer::adoptSublayers when switching out of tiling mode
(null-dereference of a PlatformCALayer)

Reviewed by Darin Adler and Chris Marrin.

LayoutTests:

Make compositing/tiling/huge-layer-resize.html faster, more reliable,
and more crashy (when there's a WebKit bug)

This test was trying to cause a layout/paint to happen by returning to
the event loop for a certain amount of time via setTimeout. But this
didn't always result in a layout/paint (at least on Windows). We now
force the layout/paint explicitly, which also lets us speed up the test
by removing the setTimeouts.

* compositing/tiling/huge-layer-resize.html:
(testOnLoad): Changed to use recordLayerTree, which forces a
layout/paint, instead of hoping that setTimeout will do the trick.
(recordLayerTree): Forces a layout/paint, then dumps the layer tree.

Source/WebCore:

* platform/graphics/ca/win/PlatformCALayerWin.cpp:
(PlatformCALayer::adoptSublayers):
(printLayer):
Changed to use PlatformCALayerWinInternal::getSublayers.

* platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:
(PlatformCALayerWinInternal::getSublayers): Added. Retrieves the list
of PlatformCALayers that represent our sublayers. Significantly, this
code knows about the tile parent layer and can thus exclude it.

* platform/graphics/ca/win/PlatformCALayerWinInternal.h: Added
getSublayers.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-17 William Siegrist <wsiegrist@apple.com>
wsiegrist@apple.com [Tue, 18 Jan 2011 01:13:26 +0000 (01:13 +0000)]
2011-01-17 William Siegrist <wsiegrist@apple.com>

Explicitly set mode during file upload to ensure web server can read the files.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-17 Nico Weber <thakis@chromium.org>
thakis@chromium.org [Tue, 18 Jan 2011 01:10:24 +0000 (01:10 +0000)]
2011-01-17  Nico Weber  <thakis@chromium.org>

        Unreviewed.

        Roll chromium DEPS forward to pick up the skia roll to skia r692.
        https://bugs.webkit.org/show_bug.cgi?id=52600

        * DEPS:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-17 Naoki Takano <takano.naoki@gmail.com>
commit-queue@webkit.org [Tue, 18 Jan 2011 00:44:20 +0000 (00:44 +0000)]
2011-01-17  Naoki Takano  <takano.naoki@gmail.com>

        Reviewed by Kent Tamura.

        [Chromium] Fix popup menu re-positioning when the menu is opened upward, above the corresponding form field.
        https://bugs.webkit.org/show_bug.cgi?id=51382
        http://crbug.com/60427

        Calculate correct location of popup window whenever the items in the window change.

        No new tests, because this fix is for Chromium project and hard to test only in WebKit project

        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupContainer::layoutAndCalculateWidgetRect): New Function to layout and calculate popup widget rect.
        (WebCore::PopupContainer::showPopup): Move widgetRect calculation logic to calculateWidgetRect().
        (WebCore::PopupContainer::refresh): Add parameter focusRect to take the location and the size of focus text input field to calculate correct popup window location.
        * platform/chromium/PopupMenuChromium.h: Append new input parameter for refresh().
2011-01-17  Naoki Takano  <takano.naoki@gmail.com>

        Reviewed by Kent Tamura.

        [Chromium] Fix popup menu re-positioning when the menu is opened upward, above the corresponding form field.
        https://bugs.webkit.org/show_bug.cgi?id=51382
        http://crbug.com/60427

        Calculate correct location of popup window whenever the items in the window change.

        No new tests, because this fix is for Chromium project and hard to test only in WebKit project

       * WebKit/chromium/src/WebViewImpl.cpp:
       (WebKit::WebViewImpl::refreshAutoFillPopup): Change the logic in refreshAutoFilPopup() to check both the location and the size of popup window.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build fix. Unreviewed.
jhoneycutt@apple.com [Tue, 18 Jan 2011 00:38:18 +0000 (00:38 +0000)]
Windows build fix. Unreviewed.

* Shared/PrintInfo.cpp:
Use #include, not #import.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Actually wrote a FIXME promised for a review comment.
ap@apple.com [Tue, 18 Jan 2011 00:32:59 +0000 (00:32 +0000)]
    Actually wrote a FIXME promised for a review comment.

        * UIProcess/API/mac/WKView.mm:
        (-[WKView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Anders Carlsson and Darin Adler.
ap@apple.com [Tue, 18 Jan 2011 00:27:12 +0000 (00:27 +0000)]
    Reviewed by Anders Carlsson and Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=52595
        Make basic printing work in WebKit2

        * Shared/WebPreferencesStore.h:
        * UIProcess/API/C/WKPreferences.cpp:
        (WKPreferencesSetShouldPrintBackgrounds):
        (WKPreferencesGetShouldPrintBackgrounds):
        * UIProcess/API/C/WKPreferences.h:
        Implement a preference for printing backgrounds.

        * Shared/PrintInfo.cpp: Added.
        (WebKit::PrintInfo::encode):
        (WebKit::PrintInfo::decode):
        * Shared/PrintInfo.h: Added.
        * Shared/mac/PrintInfoMac.mm: Added.
        (WebKit::PrintInfo::PrintInfo):
        A new class for passing page setup information down to the web process.

        * WebKit2.xcodeproj/project.pbxproj:
        * GNUmakefile.am:
        * WebKit2.pro:
        * win/WebKit2.vcproj:
        Added PrintInfo.

        * Scripts/webkit2/messages.py: Added PrintInfo.h to a list of structs.

        * UIProcess/API/mac/WKView.mm:
        (WKViewData): Cache page count and geometry.
        (WebFrameWrapper): Added a wrapper class for adding a WebFrameProxy to an NSDictionary.
        (-[WKView drawRect:]): Added logging.
        (setFrameBeingPrinted): Store a frame into NSPrintOperation's NSPrintInfo, so that all
        methods invoked for this operation would know what's being printed.
        (frameBeingPrinted): Retrieve this data.
        (-[WKView printOperationWithPrintInfo:forFrame:]): Create a print operation that's appropriate
        for the frame.
        (-[WKView knowsPageRange:]): Ask the web process.
        (-[WKView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
        Take over printing, because I couldn't make drawRect: work correctly with WebKit custom fit
        to page implementation.
        (-[WKView _provideTotalScaleFactorForPrintOperation:]): Help AppKit clip correctly.
        (-[WKView rectForPage:]): Return a pre-calculated rect.

        * UIProcess/WebPageProxy.h: Added m_isInPrintingMode to track whether the web page is in
        printing mode. The UI process controls that.

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::WebPageProxy): Initialize m_isInPrintingMode.
        (WebKit::WebPageProxy::beginPrinting): Change printing mode in web process if the value changes.
        (WebKit::WebPageProxy::endPrinting): Ditto.
        (WebKit::WebPageProxy::computePagesForPrinting): Ask the web process about output page geometry.
        (WebKit::WebPageProxy::drawRectToPDF): Ask the web process about printed page data.

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::close): Delete m_printContext while there is still a Frame pointer.
        (WebKit::WebPage::updatePreferences): Pass through ShouldPrintBackgrounds.
        (WebKit::WebPage::beginPrinting): Switch into printing mode (or update parameters if we're
        already in printing mode).
        (WebKit::WebPage::endPrinting): Delete m_printContext, implicitly calling end().
        (WebKit::WebPage::computePagesForPrinting): Make sure that we're in printing mode, and
        copmute page rects.
        (WebKit::WebPage::drawRectToPDF): Added a CG specific function to create a PDF document out
        of a page rect. It should really work for onscreen content, but we only need it for printing.

        * WebProcess/WebPage/WebPage.h:

        * WebProcess/WebPage/WebPage.messages.in: Added BeginPrinting, EndPrinting,
        ComputePagesForPrinting and DrawRectToPDF.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix the 32-bit build.
mrowe@apple.com [Mon, 17 Jan 2011 23:15:38 +0000 (23:15 +0000)]
Fix the 32-bit build.

* WebCore.exp.in:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUse of invalid hash map key in CSSFontFaceSource::getFontData() with 0-sized remote...
mitz@apple.com [Mon, 17 Jan 2011 23:14:18 +0000 (23:14 +0000)]
Use of invalid hash map key in CSSFontFaceSource::getFontData() with 0-sized remote font
https://bugs.webkit.org/show_bug.cgi?id=52598

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/css/font-face-zero-hash-key.html

* css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData): Add 1 to the font size to avoid a 0 hash key.
* css/CSSSegmentedFontFace.cpp:
(WebCore::CSSSegmentedFontFace::getFontData): Ditto.

LayoutTests:

* fast/css/font-face-zero-hash-key-expected.txt: Added.
* fast/css/font-face-zero-hash-key.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<http://webkit.org/b/52596> Add missing DOMDocument/DOMDocumentFragment headers to...
ddkilzer@apple.com [Mon, 17 Jan 2011 23:03:54 +0000 (23:03 +0000)]
<webkit.org/b/52596> Add missing DOMDocument/DOMDocumentFragment headers to Xcode project

Reviewed by Dan Bernstein.

WebCore:

This fixes two issues:

Add missing DOMDocumentFragmentPrivate.h and
DOMDocumentPrivate.h files to the project.  These files were
never added to the the project although their *Internal.h
counterparts were added in r16548 and r17390.

Add missing DOMDocumentFragmentInternal.h to the Headers
section.  It was moved from Headers to "Copy Generated Headers"
in r31045, but it should have an entry in both sections.

* WebCore.xcodeproj/project.pbxproj:

WebKit/mac:

* MigrateHeaders.make: Copy DOMDocumentFragmentPrivate.h and
DOMDocumentPrivate.h to the PrivateHeaders directory.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-17 Helder Correia <helder@sencha.com>
commit-queue@webkit.org [Mon, 17 Jan 2011 22:54:44 +0000 (22:54 +0000)]
2011-01-17  Helder Correia  <helder@sencha.com>

        Reviewed by Andreas Kling.

        [Qt] Incorrect shadow alpha with pattern fillStyle
        https://bugs.webkit.org/show_bug.cgi?id=52559

        The shadow color opacity needs to be set on the shadow painter.
        This is related to bug 52556.

        * fast/canvas/canvas-fillPath-pattern-shadow-expected.txt: Added.
        * fast/canvas/canvas-fillPath-pattern-shadow.html: Added.
        * fast/canvas/script-tests/canvas-fillPath-pattern-shadow.js: Added.
2011-01-17  Helder Correia  <helder@sencha.com>

        Reviewed by Andreas Kling.

        [Qt] Incorrect shadow alpha with pattern fillStyle
        https://bugs.webkit.org/show_bug.cgi?id=52559

        The shadow color opacity needs to be set on the shadow painter.
        This is related to bug 52556.

        Test: fast/canvas/canvas-fillPath-pattern-shadow.html

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::fillPath):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-17 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Mon, 17 Jan 2011 22:48:13 +0000 (22:48 +0000)]
2011-01-17  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Andreas Kling.

        [GTK] Port a crash fix from libsoup upstream to the libsoup cache code
        https://bugs.webkit.org/show_bug.cgi?id=52586

        No new tests. This is just a merge from upstream.

        * platform/network/soup/cache/soup-http-input-stream.c:
        (webkit_soup_http_input_stream_got_chunk): Properly handle unsigned numbers.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-17 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Mon, 17 Jan 2011 21:38:32 +0000 (21:38 +0000)]
2011-01-17  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Fix some headers with missing or misspelled #ifndef guards
        https://bugs.webkit.org/show_bug.cgi?id=52545

        * wtf/RefPtrHashMap.h:
2011-01-17  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Fix some headers with missing or misspelled #ifndef guards
        https://bugs.webkit.org/show_bug.cgi?id=52545

        No new tests because no new functionality.

        * ForwardingHeaders/runtime/InitializeThreading.h:
        * editing/SmartReplace.h:
        * loader/CrossOriginAccessControl.h:
        * loader/NetscapePlugInStreamLoader.h:
        * platform/chromium/ClipboardUtilitiesChromium.h:
        * platform/graphics/cairo/DrawErrorUnderline.h:
        * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
        * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
        * platform/graphics/cg/PDFDocumentImage.h:
        * platform/win/WebCoreTextRenderer.h:
2011-01-17  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Fix some headers with missing or misspelled #ifndef guards
        https://bugs.webkit.org/show_bug.cgi?id=52545

        * WebKitStatistics.h:
2011-01-17  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Fix some headers with missing or misspelled #ifndef guards
        https://bugs.webkit.org/show_bug.cgi?id=52545

        * Shared/UserMessageCoders.h:
        * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
        * WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:
        * WebProcess/WebProcessMain.h:
2011-01-17  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Fix some headers with missing or misspelled #ifndef guards
        https://bugs.webkit.org/show_bug.cgi?id=52545

        * DumpRenderTree/chromium/TestEventPrinter.h:
        * DumpRenderTree/chromium/WebPreferences.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-17 David Kilzer <ddkilzer@apple.com>
ddkilzer@apple.com [Mon, 17 Jan 2011 21:16:41 +0000 (21:16 +0000)]
2011-01-17  David Kilzer  <ddkilzer@apple.com>

        <http://webkit.org/b/52524> fast/dom/Range/range-clone-contents.html fails only on Windows

        Reviewed by Alexey Proskuryakov.

        * platform/win/Skipped: Removed
        fast/dom/Range/range-clone-contents.html.  It appears the
        Windows buildbots need a clean build.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-17 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 17 Jan 2011 20:59:43 +0000 (20:59 +0000)]
2011-01-17  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: follow-up fix for r52574: do not reuse clear() for navigation.

        * inspector/front-end/NetworkPanel.js:
        (WebInspector.NetworkPanel.prototype.clear):
        (WebInspector.NetworkPanel.prototype.mainResourceChanged):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Build fix.
ap@apple.com [Mon, 17 Jan 2011 20:53:33 +0000 (20:53 +0000)]
    Build fix.

        * Platform/Logging.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-17 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Mon, 17 Jan 2011 20:47:08 +0000 (20:47 +0000)]
2011-01-17  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Martin Robinson.

        [Gtk] No need to content sniff 304 Not Modified responses
        https://bugs.webkit.org/show_bug.cgi?id=52570

        Makes no sense to wait for the outcome of content sniffing when WebCore
        is validating resources. If we get a 304 Not Modified it means that we can
        safely use the cached version of the resource we're asking for.

        No new tests because it does not change functionality, it just
        calls didReceiveResponse sooner for 304 Not Modified responses.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::gotHeadersCallback):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
jberlin@webkit.org [Mon, 17 Jan 2011 20:22:17 +0000 (20:22 +0000)]
REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
navigating back to an unreachable URL
https://bugs.webkit.org/show_bug.cgi?id=52388

Reviewed by Anders Carlsson.

Source/WebCore:

Test: http/tests/navigation/go-back-to-error-page.html

* history/PageCache.cpp:
(WebCore::PageCache::canCachePageContainingThisFrame):
Do not cache any error pages (which we can recognize as having substitute data and/or an
unreachableURL).

Tools:

Add a third parameter (unreachableURL) to queueLoadHTMLString.

* DumpRenderTree/LayoutTestController.cpp:
(queueLoadHTMLStringCallback):
(LayoutTestController::queueLoadHTMLString):
(LayoutTestController::queueLoadAlternateHTMLString):
* DumpRenderTree/LayoutTestController.h:

* DumpRenderTree/WorkQueueItem.h:
(LoadHTMLStringItem::LoadHTMLStringItem):

* DumpRenderTree/chromium/LayoutTestController.cpp:
(WorkItemLoadHTMLString::WorkItemLoadHTMLString):
(WorkItemLoadHTMLString::run):
(LayoutTestController::queueLoadHTMLString):

* DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
(LoadHTMLStringItem::invoke):
* DumpRenderTree/mac/WorkQueueItemMac.mm:
(LoadHTMLStringItem::invoke):
* DumpRenderTree/win/WorkQueueItemWin.cpp:
(LoadHTMLStringItem::invoke):

LayoutTests:

Add a test that loads an alternate HTML String for an "unreachable" URL, loads another
page, and then goes back to the "unreachable" URL, which is now reachable.

This tests two things:
1) No assertion failure when going back to an unreachable URL.
2) There is no page cached for the unreachable URL.

* http/tests/navigation/go-back-to-error-page-expected.txt: Added.
* http/tests/navigation/go-back-to-error-page.html: Added.
* http/tests/navigation/resources/page-to-go-back-from.html: Added.
* http/tests/navigation/resources/page-treated-as-unreachable.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Dan Bernstein.
ap@apple.com [Mon, 17 Jan 2011 20:16:58 +0000 (20:16 +0000)]
    Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=52592
        Add a logging channel for WKView

        * Platform/Logging.cpp:
        * Platform/Logging.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-17 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 17 Jan 2011 20:16:25 +0000 (20:16 +0000)]
2011-01-17  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: fixing typo in r75952.

        * inspector/front-end/NetworkPanel.js:
        (WebInspector.NetworkDataGridNode.prototype._refreshNameCell):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDrag and drop support: refactoring of image from link and image from selection
enrica@apple.com [Mon, 17 Jan 2011 20:12:03 +0000 (20:12 +0000)]
Drag and drop support: refactoring of image from link and image from selection
https://bugs.webkit.org/show_bug.cgi?id=52496

Reviewed by Alexey Proskuryakov.

Source/WebCore:

This work cleans up the Mac code and makes it more similar to the Windows implementation,
avoiding the use of an NSView when the FrameView can be used.
The refactoring is a necessary step towards the complete support of drag and drop
in WebKit2.

* page/mac/FrameMac.mm:
(WebCore::Frame::imageFromRect): Modified to use FrameView instead of NSView
to generate the image for drag.

Source/WebKit/mac:

This work cleans up the Mac code and makes it more similar to the Windows implementation,
avoiding the use of an NSView when the FrameView can be used.
The refactoring is a necessary step towards the complete support of drag and drop
in WebKit2.

* WebCoreSupport/WebDragClient.mm:
(WebDragClient::createDragImageForLink): Added.
* WebView/WebHTMLView.mm: Removed dragImageFromLink and dragImageFromURL.
* WebView/WebHTMLViewPrivate.h: Removed dragImageFromLink and dragImageFromURL.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-17 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 17 Jan 2011 20:01:28 +0000 (20:01 +0000)]
2011-01-17  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Factor bitmap context drawing code out into a shared function
        https://bugs.webkit.org/show_bug.cgi?id=52589

        * Platform/cg/CGUtilities.h: Added.
        * Platform/cg/CGUtilities.cpp: Added.
        (WebKit::paintBitmapContext):
        New function that will paint a bitmap context into a CGContext.

        * Shared/cg/ShareableBitmapCG.cpp:
        (WebKit::ShareableBitmap::paint):
        Use paintBitmapContext.

        * UIProcess/mac/BackingStoreMac.mm:
        (WebKit::BackingStore::paint):
        (WebKit::BackingStore::scroll):
        Use paintBitmapContext.

        * WebKit2.xcodeproj/project.pbxproj:
        * win/WebKit2.vcproj:
        * win/WebKit2Common.vsprops:
        Add CGUtilities.{cpp|h}.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate xcodeproj svn:ignore to include xcuserdata.
mitz@apple.com [Mon, 17 Jan 2011 19:50:32 +0000 (19:50 +0000)]
Update xcodeproj svn:ignore to include xcuserdata.

Rubber-stamped by Mark Rowe.

Examples:

* NetscapeCocoaPlugin/NetscapeCocoaPlugin.xcodeproj: Modified property svn:ignore.
* NetscapeCoreAnimationMoviePlugin/NetscapeCoreAnimationMoviePlugin.xcodeproj: Modified property svn:ignore.
* NetscapeCoreAnimationPlugin/NetscapeCoreAnimationPlugin.xcodeproj: Modified property svn:ignore.
* NetscapeInputMethodPlugin/NetscapeInputMethodPlugin.xcodeproj: Modified property svn:ignore.

Source/JavaScriptCore:

* JavaScriptCore.xcodeproj: Modified property svn:ignore.

Source/JavaScriptGlue:

* JavaScriptGlue.xcodeproj: Modified property svn:ignore.

Source/ThirdParty/ANGLE:

* ANGLE.xcodeproj: Modified property svn:ignore.
* src/build_angle.xcodeproj: Modified property svn:ignore.

Source/WebCore:

* WebCore.xcodeproj: Modified property svn:ignore.
* manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj: Modified property svn:ignore.

Source/WebKit:

* WebKit.xcodeproj: Modified property svn:ignore.

Source/WebKit2:

* WebKit2.xcodeproj: Modified property svn:ignore.

Tools:

* DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
* MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
* TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
* WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
* WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Fixing a typo from a bad merge.
ap@apple.com [Mon, 17 Jan 2011 19:48:53 +0000 (19:48 +0000)]
    Fixing a typo from a bad merge.

        * UIProcess/API/mac/WKView.mm: (-[WKView canChangeFrameLayout:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by John Sullivan.
ap@apple.com [Mon, 17 Jan 2011 19:43:51 +0000 (19:43 +0000)]
    Reviewed by John Sullivan.

        https://bugs.webkit.org/show_bug.cgi?id=52590
        Should pass a frame into -[WKView canPrintHeadersAndFooters]

        * UIProcess/API/mac/WKView.h:
        * UIProcess/API/mac/WKView.mm: (-[WKView canChangeFrameLayout:]): Also, renamed the method
        to canChangeFrameLayout.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Leopard build fix.
ap@apple.com [Mon, 17 Jan 2011 19:36:19 +0000 (19:36 +0000)]
    Leopard build fix.

        * page/PrintContext.cpp: GCC complained about shortening a double value to float.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove a few more empty directories that I missed.
mrowe@apple.com [Mon, 17 Jan 2011 18:47:04 +0000 (18:47 +0000)]
Remove a few more empty directories that I missed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove a large number of empty directories.
mrowe@apple.com [Mon, 17 Jan 2011 18:41:09 +0000 (18:41 +0000)]
Remove a large number of empty directories.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Dan Bernstein.
ap@apple.com [Mon, 17 Jan 2011 18:31:12 +0000 (18:31 +0000)]
    Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=52495

        No change in behavior, so no tests.

        * WebCore.exp.in: Export additional methods, as I'm going to use more code from PrintContext.

        * page/PrintContext.cpp:
        (WebCore::PrintContext::~PrintContext): No need to clear m_pageRects, the object is being
        destroyed already.
        (WebCore::PrintContext::pageCount): Changed page count from int to size_t.
        (WebCore::PrintContext::pageRect): Ditto.
        (WebCore::PrintContext::computePageRects): Pass allowHorizontalTiling as an argument.
        PrintContext already has code to calculate scale factor, so it makes sense to make methods
        that contain it universal (allowHorizontalTiling is always true for Safari).
        Round page height to an integer, because Mac code does that, and because page height is
        treated as integer almost everywhere else in code.
        (WebCore::PrintContext::begin): Allow calling this function multiple times. There is no need
        to return to screen mode if e.g. "print backgounds" option changes.
        (WebCore::PrintContext::computeAutomaticScaleFactor): Expose scale factor computation, so
        that clients don't have to copy it.
        (WebCore::PrintContext::spoolRect): Add a way to spool a precomputed rect - handy if a request
        comes from code that doesn't have page number.
        (WebCore::PrintContext::pageNumberForElement): Page number int -> size_t.

        * page/PrintContext.h: Added comments and FIXMEs. PrintContext needs cleanup, but that
        depends on deciding how it really needs to work (e.g. whether computePageRects() should
        cause relayout).

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-17 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 17 Jan 2011 18:25:37 +0000 (18:25 +0000)]
2011-01-17  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: skip flaky inspector test (will look at it tomorrow).

        * platform/mac-leopard/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-17 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 17 Jan 2011 18:21:06 +0000 (18:21 +0000)]
2011-01-17  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Implement scrolling support
        https://bugs.webkit.org/show_bug.cgi?id=52502

        * Shared/UpdateInfo.cpp:
        (WebKit::UpdateInfo::encode):
        (WebKit::UpdateInfo::decode):
        * Shared/UpdateInfo.h:
        Add scrollRect and scrollDelta member variables.

        * UIProcess/BackingStore.h:
        Add scroll member function.

        * UIProcess/DrawingAreaProxyImpl.cpp:
        (WebKit::DrawingAreaProxyImpl::incorporateUpdate):
        Repaint the scroll rect. Force a display of the view when the update info contains a scroll rect.

        * UIProcess/mac/BackingStoreMac.mm:
        (WebKit::BackingStore::incorporateUpdate):
        Call scroll.

        (WebKit::BackingStore::scroll):
        Paint the backing store into itself.

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::display):
        Pass the scroll information in the update info.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-17 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 17 Jan 2011 17:51:21 +0000 (17:51 +0000)]
2011-01-17  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: unify image data source assignment, add image url
        to the image view properties list.
        https://bugs.webkit.org/show_bug.cgi?id=52584

        * English.lproj/localizedStrings.js:
        * inspector/front-end/ImageView.js:
        (WebInspector.ImageView.prototype._createContentIfNeeded.onImageLoad):
        (WebInspector.ImageView.prototype._createContentIfNeeded):
        * inspector/front-end/NetworkPanel.js:
        (WebInspector.NetworkDataGridNode.prototype._refreshNameCell):
        * inspector/front-end/Resource.js:
        (WebInspector.Resource.prototype.populateImageSource):
        (WebInspector.Resource.prototype._contentURL):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.FrameResourceTreeElement.prototype.onattach):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix up the `make` build on Macs
beidson@apple.com [Mon, 17 Jan 2011 17:28:59 +0000 (17:28 +0000)]
Fix up the `make` build on Macs

Rubberstamped by Adam Roben.

* Makefile: Point to the correct Makefile.shared

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-17 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Mon, 17 Jan 2011 17:10:32 +0000 (17:10 +0000)]
2011-01-17  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Extensions API] webInspector.resources.onFinished is not fired for redirected resources
        Make resource start/finish hanlding more consistent.
        https://bugs.webkit.org/show_bug.cgi?id=52452

        * inspector/front-end/AuditLauncherView.js: Ignore WebSocket resources when displaying progress indicator
        (WebInspector.AuditLauncherView.prototype._resetResourceCount):
        (WebInspector.AuditLauncherView.prototype.resourceStarted):
        (WebInspector.AuditLauncherView.prototype.resourceFinished):
        * inspector/front-end/NetworkManager.js:
        (WebInspector.NetworkManager): Factor out resource start/finish logic to _startResource()/_finishResource()
        (WebInspector.NetworkManager.prototype.identifierForInitialRequest):
        (WebInspector.NetworkManager.prototype.willSendRequest):
        (WebInspector.NetworkManager.prototype.markResourceAsCached):
        (WebInspector.NetworkManager.prototype.didReceiveResponse):
        (WebInspector.NetworkManager.prototype.didReceiveContentLength):
        (WebInspector.NetworkManager.prototype.didFinishLoading):
        (WebInspector.NetworkManager.prototype.didFailLoading):
        (WebInspector.NetworkManager.prototype.didLoadResourceFromMemoryCache):
        (WebInspector.NetworkManager.prototype.didCreateWebSocket):
        (WebInspector.NetworkManager.prototype.willSendWebSocketHandshakeRequest):
        (WebInspector.NetworkManager.prototype.didReceiveWebSocketHandshakeResponse):
        (WebInspector.NetworkManager.prototype.didCloseWebSocket):
        (WebInspector.NetworkManager.prototype._appendRedirect):
        (WebInspector.NetworkManager.prototype._startResource):
        (WebInspector.NetworkManager.prototype._finishResource):

2011-01-17  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Extensions API] webInspector.resources.onFinished is not fired for redirected resources
        Added test for finished event being sent for redirected resources.
        https://bugs.webkit.org/show_bug.cgi?id=52452

        * http/tests/inspector/extensions-resources-redirect-expected.txt:
        * http/tests/inspector/extensions-resources-redirect.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-17 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 17 Jan 2011 16:42:38 +0000 (16:42 +0000)]
2011-01-17  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: restore dom and network state upon frontend reuse.
        https://bugs.webkit.org/show_bug.cgi?id=52574

        * inspector/Inspector.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::restoreInspectorStateFromCookie):
        (WebCore::InspectorController::populateScriptObjects):
        (WebCore::InspectorController::pushDataCollectedOffline):
        (WebCore::InspectorController::didCommitLoad):
        * inspector/InspectorController.h:
        * inspector/front-end/NetworkManager.js:
        (WebInspector.NetworkManager.prototype.reset):
        * inspector/front-end/NetworkPanel.js:
        (WebInspector.NetworkPanel.prototype.clear):
        (WebInspector.NetworkPanel.prototype.mainResourceChanged):
        * inspector/front-end/ResourceTreeModel.js:
        (WebInspector.ResourceTreeModel):
        (WebInspector.ResourceTreeModel.prototype.reloadCachedResources):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype.clear):
        * inspector/front-end/inspector.js:
        (WebInspector.frontendReused):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed fix after r75908.
ossy@webkit.org [Mon, 17 Jan 2011 16:38:40 +0000 (16:38 +0000)]
Unreviewed fix after r75908.

Move WebKit into Source
https://bugs.webkit.org/show_bug.cgi?id=52530

* BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-17 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 17 Jan 2011 16:33:51 +0000 (16:33 +0000)]
2011-01-17  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: first timeline-network-resource flakiness.

        * inspector/timeline-network-resource.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-17 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Mon, 17 Jan 2011 16:19:25 +0000 (16:19 +0000)]
2011-01-17  Andrey Kosyakov  <caseq@chromium.org>

        Unreviewed. Fixed malformed reference to WebKitVSPropsRedirectionDir that broke win build.

        * win/WebKit2.vcproj:
        * win/WebKit2GeneratedCommon.vsprops:
        * win/WebKit2WebProcess.vcproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed buildfix after r75944.
ossy@webkit.org [Mon, 17 Jan 2011 16:18:06 +0000 (16:18 +0000)]
Unreviewed buildfix after r75944.

* WebCore.pro:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-17 Yi Shen <yi.4.shen@nokia.com>
commit-queue@webkit.org [Mon, 17 Jan 2011 16:00:31 +0000 (16:00 +0000)]
2011-01-17  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Extend the Platform Plugin to support full screen video handler
        https://bugs.webkit.org/show_bug.cgi?id=51249

        Make MediaPlayerPrivateQt support a fullscreen player.

        No new tests because LayoutTests/media/media-fullscreen-inline.html already exists.
        However, this test failed for Qt (QtMediaPlayer) due to durationchange event getting fired twice.
        So, still skip it for Qt.

        * WebCore.pro:
        * features.pri:
        * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
        (WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
        (WebCore::MediaPlayerPrivateQt::removeVideoItem):
        (WebCore::MediaPlayerPrivateQt::restoreVideoItem):
        * platform/graphics/qt/MediaPlayerPrivateQt.h:
        (WebCore::MediaPlayerPrivateQt::supportsFullscreen):
        (WebCore::MediaPlayerPrivateQt::mediaPlayer):
2011-01-17  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Extend the Platform Plugin to support full screen video handler
        https://bugs.webkit.org/show_bug.cgi?id=51249

        Add a new webkit platform plugin interface to support full screen video handler.

        * Api/qwebkitplatformplugin.h:
        (QWebFullScreenVideoHandler::QWebFullScreenVideoHandler):
        (QWebFullScreenVideoHandler::~QWebFullScreenVideoHandler):
        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::ChromeClientQt):
        (WebCore::ChromeClientQt::~ChromeClientQt):
        (WebCore::ChromeClientQt::fullScreenVideo):
        (WebCore::ChromeClientQt::supportsFullscreenForNode):
        (WebCore::ChromeClientQt::requiresFullscreenForVideoPlayback):
        (WebCore::ChromeClientQt::enterFullscreenForNode):
        (WebCore::ChromeClientQt::exitFullscreenForNode):
        * WebCoreSupport/ChromeClientQt.h:
        * WebCoreSupport/FullScreenVideoQt.cpp: Added.
        (WebCore::FullScreenVideoQt::FullScreenVideoQt):
        (WebCore::FullScreenVideoQt::~FullScreenVideoQt):
        (WebCore::FullScreenVideoQt::enterFullScreenForNode):
        (WebCore::FullScreenVideoQt::exitFullScreenForNode):
        (WebCore::FullScreenVideoQt::aboutToClose):
        (WebCore::FullScreenVideoQt::mediaPlayer):
        (WebCore::FullScreenVideoQt::mediaPlayerForNode):
        (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
        * WebCoreSupport/FullScreenVideoQt.h: Added.
        (WebCore::FullScreenVideoQt::isValid):
        * WebCoreSupport/QtPlatformPlugin.cpp:
        (WebCore::QtPlatformPlugin::createFullScreenVideoHandler):
        * WebCoreSupport/QtPlatformPlugin.h:
        * examples/platformplugin/WebPlugin.cpp:
        (FullScreenVideoWidget::FullScreenVideoWidget):
        (FullScreenVideoWidget::event):
        (FullScreenVideoWidget::keyPressEvent):
        (FullScreenVideoHandler::FullScreenVideoHandler):
        (FullScreenVideoHandler::~FullScreenVideoHandler):
        (FullScreenVideoHandler::requiresFullScreenForVideoPlayback):
        (FullScreenVideoHandler::enterFullScreen):
        (FullScreenVideoHandler::exitFullScreen):
        (WebPlugin::supportsExtension):
        (WebPlugin::createExtension):
        * examples/platformplugin/WebPlugin.h:
        (FullScreenVideoWidget::~FullScreenVideoWidget):
        * examples/platformplugin/platformplugin.pro:
        * examples/platformplugin/qwebkitplatformplugin.h:
        (QWebFullScreenVideoHandler::QWebFullScreenVideoHandler):
        (QWebFullScreenVideoHandler::~QWebFullScreenVideoHandler):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-17 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Mon, 17 Jan 2011 15:50:16 +0000 (15:50 +0000)]
2011-01-17  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: fix flaky debugger tests.
        https://bugs.webkit.org/show_bug.cgi?id=51320

        * http/tests/inspector/debugger-test2.js:
        (initialize_DebuggerTest.InspectorTest.setBreakpoint):
        * inspector/debugger-breakpoints-not-activated-on-reload.html:
        * inspector/debugger-pause-on-breakpoint-expected.txt:
        * inspector/debugger-pause-on-breakpoint.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
ossy@webkit.org [Mon, 17 Jan 2011 15:42:04 +0000 (15:42 +0000)]
Unreviewed.

Remove accidentally committed debug printing after r75908.

* Scripts/webkitdirs.pm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
ossy@webkit.org [Mon, 17 Jan 2011 15:38:53 +0000 (15:38 +0000)]
Unreviewed.

Add Qt specific expected results for passing CSS tests.
Compared to Mac png files and Mac expected files.

* platform/qt/Skipped: Unskip passing tests.
* platform/qt/css1/[...]: Added.
* platform/qt/css2.1/[...]: Added.
* platform/qt/css3/[...]: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-17 Anthony Ricaud <rik@webkit.org>
rik@webkit.org [Mon, 17 Jan 2011 14:59:40 +0000 (14:59 +0000)]
2011-01-17  Anthony Ricaud  <rik@webkit.org>

        Reviewed by Kent Tamura.

        [HTML5] Revert display:none on datalist
        https://bugs.webkit.org/show_bug.cgi?id=52214

        * fast/forms/datalist-expected.txt:
        * fast/forms/datalist-nonoption-child-expected.txt:
        * fast/forms/datalist.html:
2011-01-17  Anthony Ricaud  <rik@webkit.org>

        Reviewed by Kent Tamura.

        [HTML5] Revert display:none on datalist
        https://bugs.webkit.org/show_bug.cgi?id=52214

        * css/html.css:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-17 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 17 Jan 2011 14:31:13 +0000 (14:31 +0000)]
2011-01-17  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: simplify debugger enabling routine.
        https://bugs.webkit.org/show_bug.cgi?id=52472

        * inspector/Inspector.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::restoreDebugger):
        (WebCore::InspectorController::showAndEnableDebugger):
        (WebCore::InspectorController::enableDebugger):
        * inspector/InspectorController.h:
        * inspector/front-end/DebuggerModel.js:
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.show):
        (WebInspector.ScriptsPanel.prototype._toggleDebugging):
2011-01-17  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: simplify debugger enabling routine.
        https://bugs.webkit.org/show_bug.cgi?id=52472

        * WebInspector/WebInspector.mm:
        (-[WebInspector startDebuggingJavaScript:]):
2011-01-17  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: simplify debugger enabling routine.
        https://bugs.webkit.org/show_bug.cgi?id=52472

        * WebInspector.cpp:
        (WebInspector::toggleDebuggingJavaScript):
2011-01-17  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: simplify debugger enabling routine.
        https://bugs.webkit.org/show_bug.cgi?id=52472

        * WebProcess/WebPage/WebInspector.cpp:
        (WebKit::WebInspector::startJavaScriptDebugging):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75939 268f45cc-cd09-0410-ab3c-d52691b4dbfc