WebKit.git
10 years ago2011-03-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 29 Mar 2011 22:02:10 +0000 (22:02 +0000)]
2011-03-29  Adam Barth  <abarth@webkit.org>

        Update expected results now that we don't have a scrollbar to worry about.

        * platform/mac/fast/block/float/float-forced-below-other-floats-expected.checksum:
        * platform/mac/fast/block/float/float-forced-below-other-floats-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Tue, 29 Mar 2011 22:00:21 +0000 (22:00 +0000)]
2011-03-29  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed. Try to fix Windows build.

        * DOMEventsClasses.cpp: Added initguid.h again.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 29 Mar 2011 22:00:20 +0000 (22:00 +0000)]
2011-03-29  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        test_runner2.py can crash due to undefined variable
        https://bugs.webkit.org/show_bug.cgi?id=57356

        Replace reference to undefined variable with a variable that's actually
        defined.  AFAICT, there's no way to test this code.

        * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 29 Mar 2011 21:57:50 +0000 (21:57 +0000)]
2011-03-29  Adam Barth  <abarth@webkit.org>

        Update expectations.

        * platform/chromium-mac/fast/multicol/margin-collapse-expected.checksum: Added.
        * platform/chromium-mac/fast/multicol/margin-collapse-expected.png: Added.
        * platform/chromium-mac/fast/multicol/max-height-columns-block-expected.checksum: Added.
        * platform/chromium-mac/fast/multicol/max-height-columns-block-expected.png: Added.
        * platform/chromium-mac/fast/multicol/positioned-split-expected.checksum: Added.
        * platform/chromium-mac/fast/multicol/positioned-split-expected.png: Added.
        * platform/chromium-mac/fast/multicol/single-line-expected.checksum: Added.
        * platform/chromium-mac/fast/multicol/single-line-expected.png: Added.
        * platform/chromium-mac/fast/multicol/table-margin-collapse-expected.checksum: Added.
        * platform/chromium-mac/fast/multicol/table-margin-collapse-expected.png: Added.
        * platform/chromium-mac/fast/multicol/unsplittable-inline-block-expected.checksum: Added.
        * platform/chromium-mac/fast/multicol/unsplittable-inline-block-expected.png: Added.
        * platform/chromium-mac/fast/replaced/absolute-image-sizing-expected.checksum:
        * platform/chromium-mac/fast/replaced/absolute-image-sizing-expected.png:
        * platform/chromium-mac/fast/replaced/image-onload-expected.checksum:
        * platform/chromium-mac/fast/replaced/image-onload-expected.png:
        * platform/chromium-mac/fast/replaced/image-sizing-expected.checksum:
        * platform/chromium-mac/fast/replaced/image-sizing-expected.png:
        * platform/chromium-mac/fast/replaced/image-tag-expected.png: Added.
        * platform/chromium-mac/fast/text/basic/002-expected.checksum: Added.
        * platform/chromium-mac/fast/text/basic/002-expected.png: Added.
        * platform/chromium-mac/fast/text/word-break-soft-hyphen-expected.checksum: Added.
        * platform/chromium-mac/fast/text/word-break-soft-hyphen-expected.png: Added.
        * platform/chromium-mac/media/video-transformed-expected.checksum: Added.
        * platform/chromium-mac/media/video-transformed-expected.png: Added.
        * platform/chromium-mac/scrollbars/listbox-scrollbar-combinations-expected.png: Added.
        * platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.png: Added.
        * platform/chromium-mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum: Added.
        * platform/chromium-mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png: Added.
        * platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-01-t-expected.png: Added.
        * platform/chromium-mac/svg/custom/focus-ring-expected.checksum:
        * platform/chromium-mac/svg/custom/focus-ring-expected.png:
        * platform/chromium-mac/svg/custom/use-in-symbol-with-offset-expected.checksum: Added.
        * platform/chromium-mac/svg/custom/use-in-symbol-with-offset-expected.png: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png:
        * platform/chromium-mac/svg/filters/filterRes-expected.checksum: Added.
        * platform/chromium-mac/svg/filters/filterRes-expected.png: Added.
        * platform/chromium-mac/svg/filters/filteredImage-expected.png: Added.
        * platform/chromium-mac/svg/text/foreignObject-text-clipping-bug-expected.png: Added.
        * platform/chromium-mac/svg/zoom/page/zoom-hixie-mixed-008-expected.checksum: Added.
        * platform/chromium-mac/tables/mozilla/bugs/bug120107-expected.png: Added.
        * platform/chromium-mac/tables/mozilla/bugs/bug12908-2-expected.png: Added.
        * platform/chromium-mac/tables/mozilla/bugs/bug13169-expected.png: Added.
        * platform/chromium-mac/tables/mozilla/bugs/bug196870-expected.png: Added.
        * platform/chromium-mac/tables/mozilla/bugs/bug50695-2-expected.png: Added.
        * platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.png: Added.
        * platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug6933-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Tue, 29 Mar 2011 21:50:52 +0000 (21:50 +0000)]
2011-03-29  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Darin Adler.

        ~25% regression on v8-splay in the SunSpider harness
        https://bugs.webkit.org/show_bug.cgi?id=56128

        I'm not sure if this is the root cause of the regression Stephanie
        measured, but it seems to get us back to previous v8-splay times.

        SunSpider reports no change. v8-splay says 41% faster.

        * runtime/Heap.cpp:
        (JSC::Heap::reset): Make marking proportional to 1X the size of the heap,
        not .5X the size of the heap. When the heap is large, this makes a big
        difference. (Our old heap growth policy matched this. You can see by
        looking at resizeBlocks in revisions prior to r77699.)

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Tue, 29 Mar 2011 21:46:03 +0000 (21:46 +0000)]
2011-03-29  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Roben.

        [WIN] Cleanup includes in WebKit files
        https://bugs.webkit.org/show_bug.cgi?id=57381

        Add missing includes to fix build without precompiled header.
        Also fix paths in #include statements (e.g. WTF -> wtf).

        * AccessibleBase.h:
        * AccessibleDocument.h: Replace using statement with a qualified name.
        * CFDictionaryPropertyBag.h:
        * DOMEventsClasses.cpp:
        * DOMHTMLClasses.h:
        * DefaultDownloadDelegate.cpp:
        * DefaultDownloadDelegate.h:
        * DefaultPolicyDelegate.cpp:
        * DefaultPolicyDelegate.h:
        * WebCoreSupport/EmbeddedWidget.h:
        * WebCoreSupport/WebInspectorDelegate.h:
        * WebDataSource.h:
        * WebDatabaseManager.h:
        * WebElementPropertyBag.h:
        * WebFramePolicyListener.h:
        * WebGeolocationPolicyListener.h:
        * WebHistory.h:
        * WebKitClassFactory.h:
        * WebScriptWorld.h:
        * WebSerializedJSValue.h:
        * WebUserContentURLPattern.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Sheriff Bot <webkit.review.bot@gmail.com>
abarth@webkit.org [Tue, 29 Mar 2011 21:33:18 +0000 (21:33 +0000)]
2011-03-29  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r82293.
        http://trac.webkit.org/changeset/82293
        https://bugs.webkit.org/show_bug.cgi?id=57390

        Breaks RetrieveCSSResources (Requested by abarth|gardener on
        #webkit).

        * WebKit.gyp:
        * src/WebPageSerializer.cpp:
        (WebCore::getSubResourceURLFromElement):
        (WebCore::retrieveResourcesForElement):
        (WebCore::retrieveResourcesForFrame):
        (WebKit::WebPageSerializer::retrieveAllResources):
        * tests/WebPageSerializerTest.cpp:
        * tests/data/pageserialization/css_test_page.html: Removed.
        * tests/data/pageserialization/import_style_from_link.css: Removed.
        * tests/data/pageserialization/import_styles.css: Removed.
        * tests/data/pageserialization/link_styles.css: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 29 Mar 2011 21:29:59 +0000 (21:29 +0000)]
2011-03-29  Adam Barth  <abarth@webkit.org>

        Green means pass, AFAICT.

        * platform/chromium-mac/fast/media/media-query-invalid-value-expected.png: Added.
        * platform/chromium-win/fast/media/media-query-invalid-value-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 29 Mar 2011 21:24:56 +0000 (21:24 +0000)]
2011-03-29  Adam Barth  <abarth@webkit.org>

        Update image result due to different text metrics.

        * platform/chromium-win/printing/return-from-printing-mode-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 29 Mar 2011 21:21:00 +0000 (21:21 +0000)]
2011-03-29  Tony Chang  <tony@chromium.org>

        Reviewed by Eric Seidel.

        cleanup rebaseline-chromium-webkit-tests
        https://bugs.webkit.org/show_bug.cgi?id=57375

        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
            - Split _extract_and_add_new_baselines into 3 functions
            - Reduce the amount of line wrapping (the file already has lines
              over 80 col, so may as well try to make the file consistent)
            - Remove unnecessary ()s

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Sheriff Bot <webkit.review.bot@gmail.com>
abarth@webkit.org [Tue, 29 Mar 2011 21:17:07 +0000 (21:17 +0000)]
2011-03-29  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r82317.
        http://trac.webkit.org/changeset/82317
        https://bugs.webkit.org/show_bug.cgi?id=57387

        We do not need these baselines anymore (Requested by
        abarth|gardener on #webkit).

        * platform/chromium-linux/fast/block/float/float-forced-below-other-floats-expected.checksum: Removed.
        * platform/chromium-linux/fast/block/float/float-forced-below-other-floats-expected.png: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Darin Adler.
ap@apple.com [Tue, 29 Mar 2011 21:12:38 +0000 (21:12 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=57379
        Clean up WK1 key event handling logic

        No bugs knowingly fixed, but this makes the code more consistent.

        * WebView/WebHTMLView.mm:
        (struct WebHTMLViewInterpretKeyEventsParameters): Renamed eventWasHandled to
        eventInterpretationHadSideEffects, because "handled" doesn't really mean much.
        (-[WebHTMLView _executeSavedEditingCommands]): Factored out from _interpretKeyEvent for use
        from other functions. We need to execute saved commands when an input method asks for current
        state, because providing stale state could confuse it.
        (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Heavily commented, and updated for other
        changes.
        (-[WebHTMLView characterIndexForPoint:]): Call _executeSavedEditingCommands, because otherwise,
        the answer would be stale.
        (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
        (-[WebHTMLView selectedRange]): Ditto.
        (-[WebHTMLView markedRange]): Ditto.
        (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
        (-[WebHTMLView hasMarkedText]): Ditto.
        (-[WebHTMLView unmarkText]): Call _executeSavedEditingCommands, because otherwise, we'd be
        operating on stale data. Also, updated for eventWasHandled renaming.
        (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
        (-[WebHTMLView doCommandBySelector:]): Removed special handling for noop:. I verified that
        it's no longer needed for bug 14522, presumably due to WebCore level changes. It was also
        fragile, because there is no guarantee about when noop: is sent (also, a custom key binding
        could have a noop: as one of its commands, although that's hardly practical).
        Added the same "from input method" logic that we have in insertText: - I don't know of any
        IMs that call this method, but we clearly need to execute it as part of IM processing when
        there is marked text.
        (-[WebHTMLView insertText:]): Removed a confusing check for [text length]. Always set
        eventInterpretationHadSideEffects to true, becasue there is no reason to try multiple times
        if current selection isn't editable. This is different from doCommandBySelector:, where we
        need to give super class a chance to handle the event if our processing fails.
        Removed a nonsense "consumedByIM = true" assignment - we no longer need it now that the
        return value of _interpretKeyEvent is computed differently.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 29 Mar 2011 21:10:30 +0000 (21:10 +0000)]
2011-03-29  Adam Barth  <abarth@webkit.org>

        Set overflow: hidden so we don't need to have scrollbars in the
        results.  I've tested that this still shows what looks like the
        intended behavior difference before and after the test.

        * fast/block/float/float-forced-below-other-floats.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 29 Mar 2011 21:05:11 +0000 (21:05 +0000)]
2011-03-29  Martin Robinson  <mrobinson@igalia.com>

        [GTK] Build failed with ‘GDK_KEY_KP_Space’ was not declared in this scope
        https://bugs.webkit.org/show_bug.cgi?id=55314

        Build fix for older versions of GTK+. Use the deprecated names for GDK key
        defines and include GtkVersioning.h to allow building on newer versions
        of GTK+.

        * Shared/gtk/WebEventFactory.cpp:
        (WebKit::isGdkKeyCodeFromKeyPad): Update key defines.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 29 Mar 2011 21:04:11 +0000 (21:04 +0000)]
2011-03-29  Adam Barth  <abarth@webkit.org>

        Scrollbars are different on different platforms.  Including scrollbars
        in tests that don't need them is sadness.

        * platform/chromium-linux/fast/block/float/float-forced-below-other-floats-expected.checksum: Added.
        * platform/chromium-linux/fast/block/float/float-forced-below-other-floats-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUse per-configuration vsprops in WebKit to avoid WebKitVSPropsRedirectionDir removal...
sfalken@apple.com [Tue, 29 Mar 2011 20:55:47 +0000 (20:55 +0000)]
Use per-configuration vsprops in WebKit to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
https://bugs.webkit.org/show_bug.cgi?id=57383

Reviewed by Darin Adler.

Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
the IDE. To avoid this, add a separate vsprops file for each project configuration that
contains the required inherited property sheets.

Source/WebKit/win:

* WebKit.vcproj/Interfaces.vcproj:
* WebKit.vcproj/InterfacesDebug.vsprops: Added.
* WebKit.vcproj/InterfacesDebugAll.vsprops: Added.
* WebKit.vcproj/InterfacesDebugCairoCFLite.vsprops: Added.
* WebKit.vcproj/InterfacesRelease.vsprops: Added.
* WebKit.vcproj/InterfacesReleaseCairoCFLite.vsprops: Added.
* WebKit.vcproj/InterfacesReleaseLTCG.vsprops: Added.
* WebKit.vcproj/WebKit.vcproj:
* WebKit.vcproj/WebKitGUID.vcproj:
* WebKit.vcproj/WebKitGUIDDebug.vsprops: Added.
* WebKit.vcproj/WebKitGUIDDebugAll.vsprops: Added.
* WebKit.vcproj/WebKitGUIDDebugCairoCFLite.vsprops: Added.
* WebKit.vcproj/WebKitGUIDRelease.vsprops: Added.
* WebKit.vcproj/WebKitGUIDReleaseCairoCFLite.vsprops: Added.
* WebKit.vcproj/WebKitGUIDReleaseLTCG.vsprops: Added.
* WebKit.vcproj/WebKitLibDebug.vsprops: Added.
* WebKit.vcproj/WebKitLibDebugAll.vsprops: Added.
* WebKit.vcproj/WebKitLibDebugCairoCFLite.vsprops: Added.
* WebKit.vcproj/WebKitLibRelease.vsprops: Added.
* WebKit.vcproj/WebKitLibReleaseCairoCFLite.vsprops: Added.
* WebKit.vcproj/WebKitLibReleaseLTCG.vsprops: Added.

Source/WebKit2:

* win/WebKit2.vcproj:
* win/WebKit2Debug.vsprops: Added.
* win/WebKit2DebugAll.vsprops: Added.
* win/WebKit2DebugCairoCFLite.vsprops: Added.
* win/WebKit2Release.vsprops: Added.
* win/WebKit2ReleaseCairoCFLite.vsprops: Added.
* win/WebKit2ReleaseLTCG.vsprops: Added.
* win/WebKit2WebProcess.vcproj:
* win/WebKit2WebProcessDebug.vsprops: Added.
* win/WebKit2WebProcessDebugAll.vsprops: Added.
* win/WebKit2WebProcessDebugCairoCFLite.vsprops: Added.
* win/WebKit2WebProcessRelease.vsprops: Added.
* win/WebKit2WebProcessReleaseCairoCFLite.vsprops: Added.
* win/WebKit2WebProcessReleaseLTCG.vsprops: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed rollout r82282, part of r82288, r82298.
ossy@webkit.org [Tue, 29 Mar 2011 20:55:27 +0000 (20:55 +0000)]
Unreviewed rollout r82282, part of r82288, r82298.

Source/WebCore:

* css/CSSParser.cpp:
(WebCore::parseColorInt):
(WebCore::isValidDouble):
(WebCore::parseAlphaValue):
(WebCore::CSSParser::parseColor):

LayoutTests:

* fast/canvas/rgba-parsing-expected.txt:
* fast/canvas/script-tests/rgba-parsing.js:
* platform/chromium-mac/fast/canvas/rgba-parsing-expected.txt: Removed.
* platform/chromium-win/fast/canvas/rgba-parsing-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=55981
bfulgham@webkit.org [Tue, 29 Mar 2011 20:54:15 +0000 (20:54 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=55981
Second round of clean-ups, aimed at supporting GTK with the
same unified FontPlatformData header.  This version removes
some unneeded WinCairo code, and aligns the WinCairo and
GTK ports to reduce code duplication.

Reviewed by Dave Hyatt.

* WebCore.vcproj/WebCore.vcproj: Get rid of a dangling reference
  to an old WinCairo file.
* platform/graphics/FontPlatformData.h: Remove unneeded member
  for m_fontFace, which is a member of m_scaledFont.  Switch to
  standard Cairo hashing.
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::font):
(WebCore::FontPlatformData::scaledFont):
(WebCore::FontPlatformData::hash):
(WebCore::FontPlatformData::isHashTableDeletedValue):
(WebCore::FontPlatformData::hashTableDeletedFontValue):
* platform/graphics/win/FontCacheWin.cpp: Update to no longer use
  the unnecessary fontFace() accessor.
(WebCore::FontCache::createFontPlatformData):
* platform/graphics/win/FontCustomPlatformDataCairo.cpp:
* platform/graphics/win/FontPlatformDataCairoWin.cpp:
(WebCore::FontPlatformData::platformDataInit):
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::~FontPlatformData):
(WebCore::FontPlatformData::platformDataAssign):
(WebCore::FontPlatformData::platformIsEqual):
* platform/graphics/win/FontPlatformDataWin.cpp:
(WebCore::FontPlatformData::FontPlatformData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake WinCairo a core builder.
bfulgham@webkit.org [Tue, 29 Mar 2011 20:53:32 +0000 (20:53 +0000)]
Make WinCairo a core builder.
https://bugs.webkit.org/show_bug.cgi?id=57373

Reviewed by Adam Roben.

* Scripts/webkitpy/common/net/buildbot/buildbot.py: Add WinCairo.
* Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Add WinCairo.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit2: The WebProcess should be relaunched if necessary when WebKit2 is asked for
jberlin@webkit.org [Tue, 29 Mar 2011 20:45:20 +0000 (20:45 +0000)]
WebKit2: The WebProcess should be relaunched if necessary when WebKit2 is asked for
information about Cookies, Databases, Local Storage, etc.
https://bugs.webkit.org/show_bug.cgi?id=57374

Reviewed by Anders Carlsson.

Instead of bailing when the WebProcess is not valid, call relaunchProcessIfNecessary().

* UIProcess/Plugins/WebPluginSiteDataManager.cpp:
(WebKit::WebPluginSiteDataManager::getSitesWithData):
(WebKit::WebPluginSiteDataManager::clearSiteData):
* UIProcess/WebApplicationCacheManagerProxy.cpp:
(WebKit::WebApplicationCacheManagerProxy::getApplicationCacheOrigins):
(WebKit::WebApplicationCacheManagerProxy::deleteEntriesForOrigin):
(WebKit::WebApplicationCacheManagerProxy::deleteAllEntries):
* UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::getHostnamesWithCookies):
(WebKit::WebCookieManagerProxy::deleteCookiesForHostname):
(WebKit::WebCookieManagerProxy::deleteAllCookies):
(WebKit::WebCookieManagerProxy::startObservingCookieChanges):
(WebKit::WebCookieManagerProxy::setHTTPCookieAcceptPolicy):
(WebKit::WebCookieManagerProxy::getHTTPCookieAcceptPolicy):
* UIProcess/WebDatabaseManagerProxy.cpp:
(WebKit::WebDatabaseManagerProxy::getDatabasesByOrigin):
(WebKit::WebDatabaseManagerProxy::getDatabaseOrigins):
(WebKit::WebDatabaseManagerProxy::deleteDatabaseWithNameForOrigin):
(WebKit::WebDatabaseManagerProxy::deleteDatabasesForOrigin):
(WebKit::WebDatabaseManagerProxy::deleteAllDatabases):
(WebKit::WebDatabaseManagerProxy::setQuotaForOrigin):
* UIProcess/WebKeyValueStorageManagerProxy.cpp:
(WebKit::WebKeyValueStorageManagerProxy::getKeyValueStorageOrigins):
(WebKit::WebKeyValueStorageManagerProxy::deleteEntriesForOrigin):
(WebKit::WebKeyValueStorageManagerProxy::deleteAllEntries):
* UIProcess/WebMediaCacheManagerProxy.cpp:
(WebKit::WebMediaCacheManagerProxy::getHostnamesWithMediaCache):
(WebKit::WebMediaCacheManagerProxy::clearCacheForHostname):
(WebKit::WebMediaCacheManagerProxy::clearCacheForAllHostnames):
* UIProcess/WebResourceCacheManagerProxy.cpp:
(WebKit::WebResourceCacheManagerProxy::getCacheOrigins):
(WebKit::WebResourceCacheManagerProxy::clearCacheForOrigin):
(WebKit::WebResourceCacheManagerProxy::clearCacheForAllOrigins):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoInline worker powered by blob URL does not work with files URL even if
jianli@chromium.org [Tue, 29 Mar 2011 20:37:52 +0000 (20:37 +0000)]
Inline worker powered by blob URL does not work with files URL even if
allowFileAccessFromFileURLs is enabled
https://bugs.webkit.org/show_bug.cgi?id=56063

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/files/workers/inline-worker-via-blob-url.html

* fileapi/BlobURL.cpp: Removed unneeded getOrigin() method.
* fileapi/BlobURL.h: Removed unneeded getOrigin() method.
* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::SecurityOrigin): Extended the logic to handle
filesystem URL also to blob URL. Also fixed the problem that m_isUnique
is incorrectly set for blob and filesystem URLs.
(WebCore::SecurityOrigin::create): Removed the special logic for blob URL
since we use the same logic in SecurityOrigin constructor as filesystem
URL.
(WebCore::SecurityOrigin::canRequest): Removed the special logic for blob
URL since it is not needed with the fix in SecurityOrigin constructor.

LayoutTests:

* fast/files/workers/inline-worker-via-blob-url-expected.txt: Added.
* fast/files/workers/inline-worker-via-blob-url.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 29 Mar 2011 20:27:12 +0000 (20:27 +0000)]
2011-03-29  Tony Chang  <tony@chromium.org>

        Roll chromium version to r79710 to pick up libpng changes.

        * DEPS:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Jeff Miller <jeffm@apple.com>
jeffm@apple.com [Tue, 29 Mar 2011 20:25:55 +0000 (20:25 +0000)]
2011-03-29  Jeff Miller  <jeffm@apple.com>

        Reviewed by Darin Adler.

        WebKit2: Support setting the client certificate on Windows
        https://bugs.webkit.org/show_bug.cgi?id=57368

        Allow setting the client certificate for a host via the injected bundle.
        This requires the ability for Webkit2 Windows clients to create a WKCertificateInfo from a PCCERT_CONTEXT so they can send it to the web process.

        * Shared/API/c/win/WKCertificateInfoWin.cpp:
        (WKCertificateInfoCreateWithCertificate): Added.
        * Shared/API/c/win/WKCertificateInfoWin.h: Added WKCertificateInfoCreateWithCertificate().
        * WebProcess/InjectedBundle/API/c/WKBundle.cpp:
        (WKBundleSetClientCertificate): Added.
        * WebProcess/InjectedBundle/API/c/WKBundlePrivate.h: Added WKBundleSetClientCertificate().
        * WebProcess/InjectedBundle/InjectedBundle.h: Added setClientCertificate().
        * WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp:
        (WebKit::InjectedBundle::setClientCertificate): Added, should never be called.
        * WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp:
        (WebKit::InjectedBundle::setClientCertificate): Added, should never be called.
        * WebProcess/InjectedBundle/qt/InjectedBundleQt.cpp:
        (WebKit::InjectedBundle::setClientCertificate): Added, should never be called.
        * WebProcess/InjectedBundle/win/InjectedBundleWin.cpp:
        (WebKit::InjectedBundle::setClientCertificate): Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake WebCore and WebKit2 work with update-webkit-localizable-strings.
timothy@apple.com [Tue, 29 Mar 2011 20:24:59 +0000 (20:24 +0000)]
Make WebCore and WebKit2 work with update-webkit-localizable-strings.

Source/WebCore: Update WebCore Localizable.strings to contain WebCore, WebKit/mac and WebKit2 strings.

https://webkit.org/b/57354

Reviewed by Sam Weinig.

* English.lproj/Localizable.strings: Updated.
* StringsNotToBeLocalized.txt: Removed. To hard to maintain in WebCore.
* platform/network/cf/LoaderRunLoopCF.h: Remove a single quote in an #error so
extract-localizable-strings does not complain about unbalanced single quotes.

Source/WebKit: Update WebKit Localizable.strings to only contain WebKit/win strings.

https://webkit.org/b/57354

Reviewed by Sam Weinig.

* English.lproj/Localizable.strings: Updated.

Source/WebKit2: Make WebKit2 work with update-webkit-localizable-strings.

https://webkit.org/b/57354

Reviewed by Sam Weinig.

* PluginProcess/mac/PluginProcessMac.mm: Remove UI_STRING macro. Use WebLocalizableStrings.h.
* Shared/WebLocalizableStrings.h: Added.
* UIProcess/API/mac/WKView.mm: Remove UI_STRING macro. Use WebLocalizableStrings.h.
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformInspectedURLChanged): Use UI_STRING. Remove FIXME.
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: Remove UI_STRING macros.
Use WebLocalizableStrings.h.
* WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:
(registerErrors): Remove UI_STRING macro. Use WebLocalizableStrings.h.
* WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::platformInitializeWebProcess): Use UI_STRING. Remove FIXME.

* GNUmakefile.am: Added Shared/WebLocalizableStrings.h.
* WebKit2.pro: Ditto.
* WebKit2.xcodeproj/project.pbxproj: Ditto.
* win/WebKit2.vcproj: Ditto.

Tools: Update update-webkit-localizable-strings to understand that WebKit and
WebKit2 strings go in WebCore.

Also make extract-localizable-strings optionally use an exclude file. No individual
warnings are produced about unlocalized strings when there is no exclude file. This
is needed for WebCore, since there are too many bare strings.

https://webkit.org/b/57354

Reviewed by Sam Weinig.

* Scripts/extract-localizable-strings: Support "-" to mean no exclude file.
* Scripts/update-webkit-localizable-strings: Update paths to scan WebCore and WebKit2.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Sheriff Bot <webkit.review.bot@gmail.com>
abarth@webkit.org [Tue, 29 Mar 2011 20:18:53 +0000 (20:18 +0000)]
2011-03-29  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r82295 and r82300.
        http://trac.webkit.org/changeset/82295
        http://trac.webkit.org/changeset/82300
        https://bugs.webkit.org/show_bug.cgi?id=57380

        This patch breaks compile on Chromium (Requested by
        abarth|gardener on #webkit).

        * platform/gtk/accessibility/aria-roles-unignored-expected.txt: Removed.
        * platform/gtk/accessibility/aria-roles-unignored.html: Removed.
2011-03-29  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r82295 and r82300.
        http://trac.webkit.org/changeset/82295
        http://trac.webkit.org/changeset/82300
        https://bugs.webkit.org/show_bug.cgi?id=57380

        This patch breaks compile on Chromium (Requested by
        abarth|gardener on #webkit).

        * public/WebAccessibilityRole.h:
        * src/AssertMatchingEnums.cpp:
2011-03-29  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r82295 and r82300.
        http://trac.webkit.org/changeset/82295
        http://trac.webkit.org/changeset/82300
        https://bugs.webkit.org/show_bug.cgi?id=57380

        This patch breaks compile on Chromium (Requested by
        abarth|gardener on #webkit).

        * accessibility/AccessibilityObject.h:
        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (atkRole):
        (webkit_accessible_get_role):
        * accessibility/mac/AccessibilityObjectWrapper.mm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Jeff Miller <jeffm@apple.com>
jeffm@apple.com [Tue, 29 Mar 2011 20:10:56 +0000 (20:10 +0000)]
2011-03-29  Jeff Miller  <jeffm@apple.com>

        Reviewed by Darin Adler.

        CoreIPC::decodeResourceError() leaks a CFDataRef
        https://bugs.webkit.org/show_bug.cgi?id=57366

        * Shared/win/WebCoreArgumentCodersWin.cpp:
        (CoreIPC::decodeResourceError): Don't leak the result of WebCore::copyCertificateToData(), since the ResourceError will retain it.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix clang build.
andersca@apple.com [Tue, 29 Mar 2011 20:10:28 +0000 (20:10 +0000)]
Fix clang build.

* platform/text/BidiResolver.h:
(WebCore::::createBidiRunsForLine):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUse per-configuration vsprops in WebCore to avoid WebKitVSPropsRedirectionDir removal...
sfalken@apple.com [Tue, 29 Mar 2011 20:07:15 +0000 (20:07 +0000)]
Use per-configuration vsprops in WebCore to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
https://bugs.webkit.org/show_bug.cgi?id=57378

Reviewed by Adam Roben.

Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
the IDE. To avoid this, add a separate vsprops file for each project configuration that
contains the required inherited property sheets.

* WebCore.vcproj/QTMovieWin.vcproj:
* WebCore.vcproj/QTMovieWinDebug.vsprops: Added.
* WebCore.vcproj/QTMovieWinDebugAll.vsprops: Added.
* WebCore.vcproj/QTMovieWinDebugCairoCFLite.vsprops: Added.
* WebCore.vcproj/QTMovieWinRelease.vsprops: Added.
* WebCore.vcproj/QTMovieWinReleaseCairoCFLite.vsprops: Added.
* WebCore.vcproj/QTMovieWinReleaseLTCG.vsprops: Added.
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcproj/WebCoreDebug.vsprops: Added.
* WebCore.vcproj/WebCoreDebugAll.vsprops: Added.
* WebCore.vcproj/WebCoreDebugCairoCFLite.vsprops: Added.
* WebCore.vcproj/WebCoreRelease.vsprops: Added.
* WebCore.vcproj/WebCoreReleaseCairoCFLite.vsprops: Added.
* WebCore.vcproj/WebCoreReleaseLTCG.vsprops: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/9194927> REGRESSION (r81691): Page at www.mondaynote.com lays out...
hyatt@apple.com [Tue, 29 Mar 2011 19:47:35 +0000 (19:47 +0000)]
<rdar://problem/9194927> REGRESSION (r81691): Page at mondaynote.com lays out incorrectly

Reviewed by Simon Fraser.

Back out the optimization that stopped when it hit the first float. This was an incorrect optimization
and can't be done without more work.

Source/WebCore:

Added fast/block/float/float-forced-below-other-floats.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):

LayoutTests:

Added fast/block/float/float-below-other-floats.html

* fast/block/float/float-forced-below-other-floats.html: Added.
* platform/mac/fast/block/float/float-forced-below-other-floats-expected.checksum: Added.
* platform/mac/fast/block/float/float-forced-below-other-floats-expected.png: Added.
* platform/mac/fast/block/float/float-forced-below-other-floats-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit2 bundle page needs to offer generated file hooks
ossy@webkit.org [Tue, 29 Mar 2011 19:43:22 +0000 (19:43 +0000)]
WebKit2 bundle page needs to offer generated file hooks
https://bugs.webkit.org/show_bug.cgi?id=57279

Patch by Darin Adler <darin@apple.com> on 2011-03-29
Reviewed by Adam Roben.

(Land missing part of the original patch after r82289.)

* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage): Added new callbacks.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd passing results for a test that passes in WebKit2 but not WebKit1
aroben@apple.com [Tue, 29 Mar 2011 19:43:15 +0000 (19:43 +0000)]
Add passing results for a test that passes in WebKit2 but not WebKit1

The WebKit1 failure is tracked by <http://webkit.org/b/57334>.

* platform/win-wk2/http/tests/uri/username-with-no-hostname-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Tue, 29 Mar 2011 19:38:47 +0000 (19:38 +0000)]
2011-03-29  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Adam Barth.

        REGRESSION(r82295): This patch does not compile on Chromium (Requested by abarth|gardener on #webkit).
        https://bugs.webkit.org/show_bug.cgi?id=57377

        Fix build errors on Chromium bots.

        * public/WebAccessibilityRole.h: Update to reflect newly added roles in WebCore.
        * src/AssertMatchingEnums.cpp: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 29 Mar 2011 19:09:06 +0000 (19:09 +0000)]
2011-03-29  Adam Barth  <abarth@webkit.org>

        Roll Chromium DEPS
        https://bugs.webkit.org/show_bug.cgi?id=57361

        * DEPS:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 29 Mar 2011 19:03:32 +0000 (19:03 +0000)]
2011-03-29  Adam Barth  <abarth@webkit.org>

        Looks like a rounding issue.

        * platform/chromium-mac/fast/canvas/rgba-parsing-expected.txt: Added.
        * platform/chromium-win/fast/canvas/rgba-parsing-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 29 Mar 2011 19:00:21 +0000 (19:00 +0000)]
2011-03-29  Eric Seidel  <eric@webkit.org>

        Reviewed by Ryosuke Niwa.

        Start to clean up BidiResolver::createBidiRunsForLine so that mere mortals can understand it
        https://bugs.webkit.org/show_bug.cgi?id=57338

        I'm attempting to break createBidiRunsForLine into understandable pieces
        so that we can tell what it's actually doing.  Our implementation of the
        unicode bidi algorithm is slightly different from the spec in that we
        run it per-line (instead of over the entire paragraph at once).  This is
        great for performance (our implementation is resumable), but it makes
        things a bit tricky to understand.  Splitting createBidiRunsForLine into
        pieces should help make our UBA implementation more readable.

        * platform/text/BidiResolver.h:
        (WebCore::::updateStatusLastFromCurrentDirection):
        (WebCore::::createBidiRunsForLine):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Tue, 29 Mar 2011 18:50:32 +0000 (18:50 +0000)]
2011-03-29  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Martin Robinson.

        [Gtk] Consistent crash from Google/ARIA combobox click
        https://bugs.webkit.org/show_bug.cgi?id=55883

        Added new layout test to check this doesn't crash anymore in GTK.

        * platform/gtk/accessibility/aria-options-and-menuitems-crash-expected.txt: Added.
        * platform/gtk/accessibility/aria-options-and-menuitems-crash.html: Added.
2011-03-29  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Martin Robinson.

        [Gtk] Consistent crash from Google/ARIA combobox click
        https://bugs.webkit.org/show_bug.cgi?id=55883

        Do not call to firstChild() to avoid entering into infinite loops.

        This would happen when current item is a WebCore Group and some of
        its children have either role 'option' or 'menuitem'. Other than
        that the logic behind that call to firstChild() seems to be no
        longer needed so it's safe to remove it.

        Test: platform/gtk/accessibility/aria-options-and-menuitems-crash.html

        * accessibility/gtk/AccessibilityObjectAtk.cpp:
        (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
        Remove call to firsChild, which was leading to crashes sometimes.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Tue, 29 Mar 2011 18:43:44 +0000 (18:43 +0000)]
2011-03-29  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Chris Fleizach.

        AX: GTK: ARIA role is not respected on <p> <label> <div> and <form>
        https://bugs.webkit.org/show_bug.cgi?id=47636

        Added new layout test to check that roles are correct in GTK.

        * platform/gtk/accessibility/aria-roles-unignored-expected.txt: Added.
        * platform/gtk/accessibility/aria-roles-unignored.html: Added.
2011-03-29  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Chris Fleizach.

        AX: GTK: ARIA role is not respected on <p> <label> <div> and <form>
        https://bugs.webkit.org/show_bug.cgi?id=47636

        Define new roles in WebCore and map them to ATK accordingly.

        Test: platform/gtk/accessibility/aria-roles-unignored.html

        * accessibility/AccessibilityObject.h: Added new roles to
        represent paragraphs, labels, forms and div sections.
        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
        Return ParagraphRole, LabelRole, FormRole and DivRole when needed.
        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (atkRole): Map new WebCore roles to ATK Roles.
        (webkit_accessible_get_role): Remove code to define roles for
        paragraphs, labels, forms and divs based on node's tag name.

        Update mappings for the Mac platform.

        * accessibility/mac/AccessibilityObjectWrapper.mm:
        (createAccessibilityRoleMap): Add explicit mappings from the new
        roles introduced to NSAccessibilityGroupRole.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Tue, 29 Mar 2011 18:40:25 +0000 (18:40 +0000)]
2011-03-29  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Roben.

        Remove #pragma warning push and pop statements
        https://bugs.webkit.org/show_bug.cgi?id=57198

        We do not need to disable warnings via #pragma since we started
        compiling WebCore with the same compiler warnings flags as WebKit.

        * DOMCSSClasses.cpp:
        * DOMCoreClasses.cpp:
        * DOMEventsClasses.cpp:
        * DOMHTMLClasses.cpp:
        * DefaultDownloadDelegate.cpp:
        * DefaultPolicyDelegate.cpp:
        * MarshallingHelpers.cpp:
        * WebActionPropertyBag.cpp:
        * WebActionPropertyBag.h:
        * WebCache.cpp:
        * WebCoreSupport/WebDragClient.cpp:
        * WebCoreSupport/WebEditorClient.cpp:
        * WebCoreSupport/WebEditorClient.h:
        * WebCoreSupport/WebFrameLoaderClient.cpp:
        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebInspectorClient.cpp:
        * WebDocumentLoader.h:
        * WebDownload.cpp:
        * WebDownloadCFNet.cpp:
        * WebDownloadCurl.cpp:
        * WebElementPropertyBag.cpp:
        * WebError.cpp:
        * WebError.h:
        * WebFrame.cpp:
        * WebFrame.h:
        * WebFramePolicyListener.cpp:
        * WebFramePolicyListener.h:
        * WebHistory.cpp:
        * WebHistoryItem.cpp:
        * WebIconDatabase.cpp:
        * WebIconDatabase.h:
        * WebInspector.cpp:
        * WebJavaScriptCollector.cpp:
        * WebKitGraphics.cpp:
        * WebKitSystemBits.cpp:
        * WebLocalizableStrings.cpp:
        * WebMutableURLRequest.cpp:
        * WebMutableURLRequest.h:
        * WebNodeHighlight.cpp:
        * WebNodeHighlight.h:
        * WebNotificationCenter.cpp:
        * WebResource.cpp:
        * WebResource.h:
        * WebScrollBar.cpp:
        * WebScrollBar.h:
        * WebURLAuthenticationChallenge.cpp:
        * WebURLAuthenticationChallenge.h:
        * WebURLAuthenticationChallengeSender.cpp:
        * WebURLAuthenticationChallengeSenderCFNet.cpp:
        * WebURLAuthenticationChallengeSenderCurl.cpp:
        * WebURLCredential.cpp:
        * WebURLCredential.h:
        * WebURLProtectionSpace.cpp:
        * WebURLProtectionSpace.h:
        * WebURLResponse.cpp:
        * WebURLResponse.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Jay Civelli <jcivelli@chromium.org>
jcivelli@chromium.org [Tue, 29 Mar 2011 18:40:20 +0000 (18:40 +0000)]
2011-03-29  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by David Levin.

        Adding retrieval off CSS resources to WebPageSerializer::retrieveAllResources.
        https://bugs.webkit.org/show_bug.cgi?id=56650

        * WebKit.gyp:
        * src/WebPageSerializer.cpp:
        (WebCore::getResourceAttributeForElement):
        (WebCore::retrieveStyleSheetForElement):
        (WebCore::retrieveResourcesForElement):
        (WebCore::retrieveResourcesForFrame):
        (WebCore::retrieveResourcesForCSSRule):
        (WebCore::retrieveResourcesForCSSStyleDeclaration):
        (WebCore::retrieveResourcesForCSSStyleSheet):
        (WebKit::WebPageSerializer::retrieveAllResources):
        * tests/WebPageSerializerTest.cpp:
        (WebKit::TestWebFrameClient::TestWebFrameClient):
        (WebKit::TestWebFrameClient::allowScript):
        (WebKit::WebPageSerializerTest::enableJS):
        (WebKit::WebPageSerializerTest::runOnLoad):
        (WebKit::TEST_F):
        * tests/data/pageserialization/css_test_page.html: Added.
        * tests/data/pageserialization/import_style_from_link.css: Added.
        (#divOrange):
        * tests/data/pageserialization/import_styles.css: Added.
        (#divYellow):
        * tests/data/pageserialization/link_styles.css: Added.
        (#divRed):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Snow Leopard WebKit2 Release Tests] fast/images/move-image-to-new-document.html...
jberlin@webkit.org [Tue, 29 Mar 2011 18:27:22 +0000 (18:27 +0000)]
[Snow Leopard WebKit2 Release Tests] fast/images/move-image-to-new-document.html timing out
since r82087.
https://bugs.webkit.org/show_bug.cgi?id=57347

Unreviewed, add fast/images/move-image-to-new-document.html to the skipped list in order to
get the bots green.

* platform/mac-wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 29 Mar 2011 18:26:10 +0000 (18:26 +0000)]
2011-03-29  Philippe Normand  <pnormand@igalia.com>

        Unreviewed build fix. Remove ASSERT hitting consitently on GTK.

        * rendering/InlineIterator.h:
        (WebCore::InlineIterator::moveToStartOf):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 29 Mar 2011 18:25:13 +0000 (18:25 +0000)]
2011-03-29  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Allow the AppleConnect plug-in to use the QuickDraw drawing model
        https://bugs.webkit.org/show_bug.cgi?id=57365
        <rdar://problem/8712320>

        * Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
        (WebKit::NetscapePluginModule::determineQuirks):
        * Shared/Plugins/PluginQuirks.h:
        * WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
        (WebKit::NetscapePlugin::platformPostInitialize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 29 Mar 2011 18:20:34 +0000 (18:20 +0000)]
2011-03-28  Darin Adler  <darin@apple.com>

        Reviewed by Adam Roben.

        WebKit2 bundle page needs to offer generated file hooks
        https://bugs.webkit.org/show_bug.cgi?id=57279

        * WebProcess/InjectedBundle/API/c/WKBundlePage.h: Added shouldGenerateFileForUpload and
        generateFileForUpload callback pointers.

        * WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
        (WebKit::InjectedBundlePageUIClient::shouldGenerateFileForUpload): Added.
        (WebKit::InjectedBundlePageUIClient::generateFileForUpload): Added.
        * WebProcess/InjectedBundle/InjectedBundlePageUIClient.h: Added functions above.

        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
        (WebKit::WebChromeClient::shouldReplaceWithGeneratedFileForUpload): Implemented by
        calling the functions above.
        (WebKit::WebChromeClient::generateReplacementFile): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix some just-introduced build failures.
darin@apple.com [Tue, 29 Mar 2011 18:20:03 +0000 (18:20 +0000)]
Fix some just-introduced build failures.

* WebCore.pro: Correct spelling of filename.

* css/CSSParser.cpp:
(WebCore::parseColorIntOrPercentage): Fix double/int conversion that fails to compile
on Leopard. Also renamed one local variabel.

* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::didCommitLoad): Removed unused argument names to avoid warning.
(WebCore::InspectorAgent::domContentLoadedEventFired): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build fix after r82247.
bfulgham@webkit.org [Tue, 29 Mar 2011 18:13:35 +0000 (18:13 +0000)]
Unreviewed build fix after r82247.

* WebMutableURLRequest.cpp: The new CertificateCFWin routines
are not CFNetwork-specific. All CF-based ports can use them.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 29 Mar 2011 18:12:50 +0000 (18:12 +0000)]
2011-03-29  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, GTK rebaseline of fast/forms/listbox-bidi-align.html.

        * platform/gtk/fast/forms/listbox-bidi-align-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 29 Mar 2011 18:10:53 +0000 (18:10 +0000)]
2011-03-29  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        Assertion failure in plug-in process with clang-built 32/64-bit WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=57359

        Don't use __alignof when encoding and decoding scalar types.

        Darwin 32-bit, double and unsigned long long are 4-byte aligned but on 64-bit they're
        8-byte aligned which causes problems when doing IPC between 32-bit and 64-bit processes.
        GCC is buggy and returns 8, but clang is correct and returns 4. Use sizeof instead which we know
        is equal to or greater than the alignment.

        * Platform/CoreIPC/ArgumentDecoder.cpp:
        (CoreIPC::ArgumentDecoder::decodeBool):
        (CoreIPC::ArgumentDecoder::decodeUInt32):
        (CoreIPC::ArgumentDecoder::decodeUInt64):
        (CoreIPC::ArgumentDecoder::decodeInt32):
        (CoreIPC::ArgumentDecoder::decodeInt64):
        (CoreIPC::ArgumentDecoder::decodeFloat):
        (CoreIPC::ArgumentDecoder::decodeDouble):
        * Platform/CoreIPC/ArgumentEncoder.cpp:
        (CoreIPC::ArgumentEncoder::encodeBool):
        (CoreIPC::ArgumentEncoder::encodeUInt32):
        (CoreIPC::ArgumentEncoder::encodeUInt64):
        (CoreIPC::ArgumentEncoder::encodeInt32):
        (CoreIPC::ArgumentEncoder::encodeInt64):
        (CoreIPC::ArgumentEncoder::encodeFloat):
        (CoreIPC::ArgumentEncoder::encodeDouble):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Tue, 29 Mar 2011 18:07:50 +0000 (18:07 +0000)]
2011-03-29  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Roben.

        [WIN] Use WCHAR instead of TCHAR
        https://bugs.webkit.org/show_bug.cgi?id=57191

        We always use the UNICODE versions of windows functions, so
        the usage of TCHAR makes no sense and mixing them is bad style.

        * DefaultDownloadDelegate.cpp:
        * WebCoreSupport/WebChromeClient.cpp:
        * WebCoreSupport/WebContextMenuClient.cpp:
        * WebCoreSupport/WebInspectorClient.cpp:
        * WebKitDLL.cpp:
        * WebNotificationCenter.cpp:
        * WebPreferences.cpp:
        * WebURLResponse.cpp:
        * WebView.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build fix after r81928.
bfulgham@webkit.org [Tue, 29 Mar 2011 18:07:25 +0000 (18:07 +0000)]
Unreviewed build fix after r81928.

* win/WebKit2.vcproj: Don't build CG-specific icon routines
for WinCairo port.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Andras Becsi <abecsi@webkit.org>
abecsi@webkit.org [Tue, 29 Mar 2011 18:03:40 +0000 (18:03 +0000)]
2011-03-29  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Darin Adler.

        CSS: Slow parsing of rgb() with percent values
        https://bugs.webkit.org/show_bug.cgi?id=16708

        Implement fast-path parsing for percentage color values.

        Gain ~30% speedup on http://canvex.lazyilluminati.com/misc/3d.html.

        * fast/canvas/script-tests/rgba-parsing.js: Add cases to test the consistency.
2011-03-29  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Darin Adler.

        CSS: Slow parsing of rgb() with percent values
        https://bugs.webkit.org/show_bug.cgi?id=16708

        Implement fast-path parsing for percentage color values.

        Gain ~30% speedup on http://canvex.lazyilluminati.com/misc/3d.html.

        * css/CSSParser.cpp:
        (WebCore::checkForValidDouble): Extend to return the number of characters forming a valid double.
        (WebCore::parseDouble): Function for parsing double values if they are valid.
        (WebCore::parseColorIntOrPercentage): Extend parseColorInt to deal with percentage values.
        (WebCore::parseAlphaValue): Use the new functions.
        (WebCore::CSSParser::parseColor): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Tue, 29 Mar 2011 18:01:10 +0000 (18:01 +0000)]
2011-03-29  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: extract InspectorPageAgent from InspectorAgent.
        https://bugs.webkit.org/show_bug.cgi?id=57327

        There are page related methods and inspector related methods in InspectorAgent.
        It would be nice to extract page specific methods for future usage the rest of methods in workers debugger.

        * GNUmakefile.am:
        * WebCore.gypi:
        * inspector/CodeGeneratorInspector.pm:
        * inspector/Inspector.json:
        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::InspectorAgent):
        (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
        (WebCore::InspectorAgent::didClearWindowObjectInWorld):
        (WebCore::InspectorAgent::setFrontend):
        (WebCore::InspectorAgent::disconnectFrontend):
        (WebCore::InspectorAgent::didCommitLoad):
        (WebCore::InspectorAgent::domContentLoadedEventFired):
        * inspector/InspectorAgent.h:
        (WebCore::InspectorAgent::pageAgent):
        * inspector/InspectorPageAgent.cpp: Added.
        (WebCore::InspectorPageAgent::create):
        (WebCore::InspectorPageAgent::InspectorPageAgent):
        (WebCore::InspectorPageAgent::setFrontend):
        (WebCore::InspectorPageAgent::clearFrontend):
        (WebCore::InspectorPageAgent::addScriptToEvaluateOnLoad):
        (WebCore::InspectorPageAgent::removeAllScriptsToEvaluateOnLoad):
        (WebCore::InspectorPageAgent::reloadPage):
        (WebCore::InspectorPageAgent::openInInspectedWindow):
        (WebCore::InspectorPageAgent::setUserAgentOverride):
        (WebCore::buildObjectForCookie):
        (WebCore::buildArrayForCookies):
        (WebCore::InspectorPageAgent::getCookies):
        (WebCore::InspectorPageAgent::deleteCookie):
        (WebCore::InspectorPageAgent::inspectedURLChanged):
        (WebCore::InspectorPageAgent::restore):
        (WebCore::InspectorPageAgent::didCommitLoad):
        (WebCore::InspectorPageAgent::domContentEventFired):
        (WebCore::InspectorPageAgent::loadEventFired):
        (WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
        (WebCore::InspectorPageAgent::applyUserAgentOverride):
        * inspector/InspectorPageAgent.h: Added.
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::connectFrontend):
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl):
        (WebCore::InspectorInstrumentation::applyUserAgentOverrideImpl):
        (WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl):
        (WebCore::InspectorInstrumentation::loadEventFiredImpl):
        (WebCore::InspectorInstrumentation::didCommitLoadImpl):
        (WebCore::InspectorInstrumentation::retrievePageAgent):
        * inspector/InspectorInstrumentation.h:
        * inspector/InstrumentingAgents.h:
        (WebCore::InstrumentingAgents::InstrumentingAgents):
        (WebCore::InstrumentingAgents::inspectorPageAgent):
        (WebCore::InstrumentingAgents::setInspectorPageAgent):
        * inspector/front-end/AuditsPanel.js:
        (WebInspector.AuditsPanel.prototype._reloadResources):
        * inspector/front-end/CookieItemsView.js:
        (WebInspector.CookieItemsView.prototype._deleteCookie):
        (WebInspector.Cookies.getCookiesAsync):
        * inspector/front-end/ExtensionServer.js:
        (WebInspector.ExtensionServer.prototype._onReload):
        * inspector/front-end/NetworkPanel.js:
        (WebInspector.NetworkDataGridNode.prototype._openInNewTab):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.FrameResourceTreeElement.prototype.ondblclick):
        * inspector/front-end/WorkersSidebarPane.js:
        (WebInspector.WorkersSidebarPane.prototype.setInstrumentation):
        * inspector/front-end/inspector.js:
        (WebInspector.openResource):
        (WebInspector.documentKeyDown):

2011-03-29  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: extract InspectorPageAgent from InspectorAgent.
        https://bugs.webkit.org/show_bug.cgi?id=57327

        There are page related methods and inspector related methods in InspectorAgent.
        It would be nice to extract page specific methods for future usage the rest of methods in workers debugger.

        * http/tests/inspector/inspector-test.js:
        (initialize_InspectorTest.InspectorTest.reloadPage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=57276
hyatt@apple.com [Tue, 29 Mar 2011 17:56:09 +0000 (17:56 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=57276

Reviewed by Darin Adler.

Add optimizations to make the vertical placement of boxes much faster. Whenever a box is added
to a line, compare it with the parent box. If we can determine that the child box has the exact
same height and baseline position as the parent box, then we keep a boolean flag set called
descendantsHaveSameLineHeightAndBaseline(). If the box is different for any reason then we clear the
flag up the line box parent chain.

When it comes time to do computeLogicalboxHeights, we can avoid recurring into the children of
a box whose descendants all have the same position. When we do placeBoxesInBlockDirection, we
can do a simplified recursion that just calls adjustBlockDirectionPosition to offset the boxes
without doing anything else.

Because of the quirks mode rule of only shrinking boxes with no immediate text children, we need
to track whether a box has text descendants now as well.  When we avoid doing the recursion
this flag tells us whether the collection of boxes should have an effect on the ascent and descent
of the line in quirks mode.

* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::addToLine):
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
(WebCore::InlineFlowBox::nodeAtPoint):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):
* rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::InlineFlowBox):
(WebCore::InlineFlowBox::hasTextDescendants):
(WebCore::InlineFlowBox::descendantsHaveSameLineHeightAndBaseline):
(WebCore::InlineFlowBox::clearDescendantsHaveSameLineHeightAndBaseline):
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::createLineBoxes):
(WebCore::RenderBlock::constructLine):
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 29 Mar 2011 17:54:38 +0000 (17:54 +0000)]
2011-03-29  Tony Chang  <tony@chromium.org>

        Reviewed by Ojan Vafai.

        [chromium] NRWT should be able to read checksums from png comments
        https://bugs.webkit.org/show_bug.cgi?id=57280

        * Scripts/read-checksum-from-png: Added. Utility script to read the checksum
            from a file.
        * Scripts/webkitpy/common/system/filesystem.py: Add open_binary_file_for_reading
        * Scripts/webkitpy/common/system/filesystem_mock.py:
        * Scripts/webkitpy/layout_tests/port/base.py: When loading a checksum,
            if the -checksum.txt file doesn't exist, try looking in the png.
        * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/read_checksum_from_png.py: Added. Scan the first
            2k for a png comment with the checksum
        * Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 29 Mar 2011 17:50:25 +0000 (17:50 +0000)]
2011-03-29  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip failing test on GTK.

        * platform/gtk/Skipped: Skip
        fast/loader/onload-willSendRequest-null-for-frame.html.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 29 Mar 2011 17:44:41 +0000 (17:44 +0000)]
2011-03-29  Eric Seidel  <eric@webkit.org>

        Reviewed by Ryosuke Niwa.

        Remove a bunch of duplicate code by adding some InlineIterator helper methods
        https://bugs.webkit.org/show_bug.cgi?id=57326

        Once I started adding these it became clear how much crazy duplicated code
        we had due to treating InlineIterator as a struct and accessing its
        members directly.  We can't quite make the members private yet since
        findNextLineBreak still splits out the members.  But this change
        makes the code much cleaner.

        * rendering/InlineIterator.h:
        (WebCore::InlineIterator::clear):
        (WebCore::InlineIterator::moveToStartOf):i
        (WebCore::InlineIterator::moveTo):
        (WebCore::InlineIterator::increment):
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::tryHyphenating):
        (WebCore::RenderBlock::findNextLineBreak):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Sam Weinig <sam@webkit.org>
weinig@apple.com [Tue, 29 Mar 2011 17:35:59 +0000 (17:35 +0000)]
2011-03-29  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Reproducible crash running under libgmalloc, in -[WKView(Internal) removeTrackingRect:] --&gt; objc_assign_ivar_non_gc
        <rdar://problem/9193352>
        https://bugs.webkit.org/show_bug.cgi?id=57358

        -[WKView removeTrackingRect] can be called from below -[WKView dealloc] after we have
        destroyed _data. So, nil out _data after releasing it and nil check it appropriately.

        * UIProcess/API/mac/WKView.mm:
        (-[WKView dealloc]):
        Nil out _data after releasing it.

        (-[WKView removeTrackingRect:]):
        Add early return for nil _data.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 29 Mar 2011 17:33:21 +0000 (17:33 +0000)]
2011-03-29  Eric Seidel  <eric@webkit.org>

        Reviewed by Ryosuke Niwa.

        Clean up bidiNext by abstracting repeated code
        https://bugs.webkit.org/show_bug.cgi?id=57335

        I also added a comment to explain what bidiNext is actually doing.
        This whole area of code is confusing but need not be.

        * rendering/InlineIterator.h:
        (WebCore::embedCharFromDirection):
        (WebCore::notifyResolverEnteredObject):
        (WebCore::notifyResolverWillExitObject):
        (WebCore::bidiNext):
        (WebCore::bidiFirst):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Tue, 29 Mar 2011 17:31:24 +0000 (17:31 +0000)]
2011-03-29  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Support external CSS stylesheet freeflow text editing
        https://bugs.webkit.org/show_bug.cgi?id=54397

        In this implementation, Ctrl/Cmd-S commits the current changes into the model.

        * inspector/front-end/ResourceView.js:
        (WebInspector.ResourceView.createResourceView):
        (WebInspector.CSSSourceFrameDelegateForResourcesPanel):
        (WebInspector.CSSSourceFrameDelegateForResourcesPanel.prototype.canEditScriptSource):
        (WebInspector.CSSSourceFrameDelegateForResourcesPanel.prototype.editScriptSource):
        (WebInspector.CSSSourceFrameDelegateForResourcesPanel.prototype.editScriptSource.handleInfos):
        (WebInspector.CSSSourceFrameDelegateForResourcesPanel.prototype._saveStyleSheet):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype._applyDiffMarkup):
        (WebInspector.FrameResourceTreeElement.prototype._contentChanged):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._createTextViewer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 29 Mar 2011 17:22:26 +0000 (17:22 +0000)]
2011-03-29  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, GTK baselines for fast/forms/listbox-bidi-align.html,
        added in r82200.

        * platform/gtk/fast/forms/listbox-bidi-align-expected.checksum: Added.
        * platform/gtk/fast/forms/listbox-bidi-align-expected.png: Added.
        * platform/gtk/fast/forms/listbox-bidi-align-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Tue, 29 Mar 2011 17:12:30 +0000 (17:12 +0000)]
2011-03-29  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Dan Bernstein.

        playbackRate should not be set to defaultPlaybackRate in play()
        https://bugs.webkit.org/show_bug.cgi?id=55943

        Test: media/video-playbackrate.html

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::playbackRate): No need to ask the media engine for the current
            rate, we already have the current value cached.
        (WebCore::HTMLMediaElement::playInternal): Don't reset the engine's playback rate to
            the default rate.
        (WebCore::HTMLMediaElement::togglePlayState): Do reset the engine's playback rate to
            the default rate before triggering playback.
        * manual-tests/media-default-playback-rate.html: Added.

2011-03-29  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Dan Bernstein.

        playbackRate should not be set to defaultPlaybackRate in play()
        https://bugs.webkit.org/show_bug.cgi?id=55943

        * media/event-attributes-expected.txt:
        * media/video-playbackrate-expected.txt: Added.
        * media/video-playbackrate.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 29 Mar 2011 17:12:14 +0000 (17:12 +0000)]
2011-03-29  Philippe Normand  <pnormand@igalia.com>

        Rubber-stamped by Gustavo Noronha Silva.

        [GTK] http/tests/uri/username-with-no-hostname.html fails
        https://bugs.webkit.org/show_bug.cgi?id=57325

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (willSendRequestCallback): URI host value check done case-insensitively.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 29 Mar 2011 17:06:03 +0000 (17:06 +0000)]
2011-03-29  Adam Barth  <abarth@webkit.org>

        I need to spend some more quality time with the rebaselining tool to
        figure out how to make it update these (or I can update them manually
        when I catch up).

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 29 Mar 2011 16:53:10 +0000 (16:53 +0000)]
2011-03-29  Adam Barth  <abarth@webkit.org>

        The text renders slightly differently on Snow Leopard.

        * platform/chromium-mac-snowleopard/fast/forms/listbox-bidi-align-expected.checksum: Added.
        * platform/chromium-mac-snowleopard/fast/forms/listbox-bidi-align-expected.png: Added.
        * platform/chromium-mac-snowleopard/fast/text/drawBidiText-expected.checksum: Added.
        * platform/chromium-mac-snowleopard/fast/text/drawBidiText-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Tue, 29 Mar 2011 16:42:56 +0000 (16:42 +0000)]
2011-03-29  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Darin Adler.

        Use per-configuration vsprops in JavaScriptCore to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
        https://bugs.webkit.org/show_bug.cgi?id=57350

        Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
        InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
        the IDE. To avoid this, add a separate vsprops file for each project configuration that
        contains the required inherited property sheets.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreDebug.vsprops: Added.
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreDebugAll.vsprops: Added.
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreDebugCairoCFLite.vsprops: Added.
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreRelease.vsprops: Added.
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreReleaseCairoCFLite.vsprops: Added.
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreReleaseLTCG.vsprops: Added.
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreReleasePGO.vsprops: Added.
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreReleasePGOOptimize.vsprops: Added.
        * JavaScriptCore.vcproj/WTF/WTF.vcproj:
        * JavaScriptCore.vcproj/WTF/WTFDebug.vsprops: Added.
        * JavaScriptCore.vcproj/WTF/WTFDebugAll.vsprops: Added.
        * JavaScriptCore.vcproj/WTF/WTFDebugCairoCFLite.vsprops: Added.
        * JavaScriptCore.vcproj/WTF/WTFRelease.vsprops: Added.
        * JavaScriptCore.vcproj/WTF/WTFReleaseCairoCFLite.vsprops: Added.
        * JavaScriptCore.vcproj/WTF/WTFReleaseLTCG.vsprops: Added.
        * JavaScriptCore.vcproj/WTF/WTFReleasePGO.vsprops: Added.
        * JavaScriptCore.vcproj/jsc/jsc.vcproj:
        * JavaScriptCore.vcproj/jsc/jscDebug.vsprops: Added.
        * JavaScriptCore.vcproj/jsc/jscDebugAll.vsprops: Added.
        * JavaScriptCore.vcproj/jsc/jscDebugCairoCFLite.vsprops: Added.
        * JavaScriptCore.vcproj/jsc/jscRelease.vsprops: Added.
        * JavaScriptCore.vcproj/jsc/jscReleaseCairoCFLite.vsprops: Added.
        * JavaScriptCore.vcproj/jsc/jscReleaseLTCG.vsprops: Added.
        * JavaScriptCore.vcproj/jsc/jscReleasePGO.vsprops: Added.
        * JavaScriptCore.vcproj/testapi/testapi.vcproj:
        * JavaScriptCore.vcproj/testapi/testapiDebug.vsprops: Added.
        * JavaScriptCore.vcproj/testapi/testapiDebugAll.vsprops: Added.
        * JavaScriptCore.vcproj/testapi/testapiDebugCairoCFLite.vsprops: Added.
        * JavaScriptCore.vcproj/testapi/testapiRelease.vsprops: Added.
        * JavaScriptCore.vcproj/testapi/testapiReleaseCairoCFLite.vsprops: Added.
        * JavaScriptCore.vcproj/testapi/testapiReleaseLTCG.vsprops: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 29 Mar 2011 16:38:59 +0000 (16:38 +0000)]
2011-03-29  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] http/tests/uri/username-with-no-hostname.html fails
        https://bugs.webkit.org/show_bug.cgi?id=57325

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (willSendRequestCallback): Check URI before submitting the request
        to WebCore.

        Reviewed by Martin Robinson.

        [GTK] http/tests/uri/username-with-no-hostname.html fails
        https://bugs.webkit.org/show_bug.cgi?id=57325

        * platform/gtk/Skipped: Unskip fixed test.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 29 Mar 2011 16:31:40 +0000 (16:31 +0000)]
2011-03-29  Adam Barth  <abarth@webkit.org>

        This test is flaky on Mac too.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate the WebKitSystemInterface libraries for changes in the implementation.
jberlin@webkit.org [Tue, 29 Mar 2011 16:23:54 +0000 (16:23 +0000)]
Update the WebKitSystemInterface libraries for changes in the implementation.

* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Tue, 29 Mar 2011 16:21:04 +0000 (16:21 +0000)]
2011-03-28  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        Remove specialization of EventDispatcher with inversion of control.
        https://bugs.webkit.org/show_bug.cgi?id=57285

        Since some events have extra logic around their dispatch, allow them
        to dispatch themselves and specialize the logic. This change only
        converts KeyboardEvent to this model.

        No functional change, covered by existing tests.

        * dom/Event.cpp:
        (WebCore::Event::dispatch): Added.
        * dom/Event.h: Updated decls.
        * dom/EventDispatcher.cpp:
        (WebCore::EventDispatcher::dispatchEvent): Changed to ask event to dispatch
            itself.
        * dom/EventDispatcher.h: Updated decls.
        * dom/KeyboardEvent.cpp:
        (WebCore::KeyboardEvent::dispatch): Added, moving code from EventDispatcher.
        * dom/KeyboardEvent.h: Updated decls.
        * dom/Node.cpp:
        (WebCore::Node::dispatchKeyEvent): Changed to use the new ways.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Tue, 29 Mar 2011 16:12:09 +0000 (16:12 +0000)]
2011-03-29  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: InspectorDOMAgent has unnecessary dependency from InspectorAgent.
        https://bugs.webkit.org/show_bug.cgi?id=57329

        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::InspectorAgent):
        (WebCore::InspectorAgent::setFrontend):
        * inspector/InspectorAgent.h:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::inspect):
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::InspectorDOMAgent):
        (WebCore::InspectorDOMAgent::setFrontend):
        (WebCore::InspectorDOMAgent::handleMousePress):
        (WebCore::InspectorDOMAgent::inspect):
        (WebCore::InspectorDOMAgent::focusNode):
        (WebCore::InspectorDOMAgent::highlight):
        (WebCore::InspectorDOMAgent::hideHighlight):
        * inspector/InspectorDOMAgent.h:
        (WebCore::InspectorDOMAgent::create):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 29 Mar 2011 16:04:40 +0000 (16:04 +0000)]
2011-03-29  Adam Barth  <abarth@webkit.org>

        Add missing expectation (looks like a pass).

        * platform/chromium/svg: Added.
        * platform/chromium/svg/custom: Added.
        * platform/chromium/svg/custom/use-in-symbol-with-offset-expected.checksum: Added.
        * platform/chromium/svg/custom/use-in-symbol-with-offset-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Tue, 29 Mar 2011 16:02:31 +0000 (16:02 +0000)]
2011-03-29  Oliver Hunt  <oliver@apple.com>

        Reviewed by Eric Seidel.

        REGRESSION(r82173): Causes assertion and test failures in run-javascriptcore-tests on Windows (Requested by aroben on #webkit).
        https://bugs.webkit.org/show_bug.cgi?id=57333

        constructDate now takes the global object explicitly as it may be called
        by functions other than the constructor itself.

        * API/JSObjectRef.cpp:
        (JSObjectMakeDate):
        * runtime/DateConstructor.cpp:
        (JSC::constructDate):
        (JSC::constructWithDateConstructor):
        * runtime/DateConstructor.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Tue, 29 Mar 2011 16:01:02 +0000 (16:01 +0000)]
2011-03-29  Sergio Villar Senin  <svillar@igalia.com>

        Unreviewed, skipping a test failing on GTK+ bots.

        [GTK] fast/text/justify-ideograph-leading-expansion.html fails on bots
        https://bugs.webkit.org/show_bug.cgi?id=57346

        * platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agowebkit2 does not pass tests that require the window to be focused.
jberlin@webkit.org [Tue, 29 Mar 2011 15:46:56 +0000 (15:46 +0000)]
webkit2 does not pass tests that require the window to be focused.
https://bugs.webkit.org/show_bug.cgi?id=56988

Unreviewed, update the WK2 expected results for pseudo-any.html after r82183.

* platform/mac-wk2/fast/css/pseudo-any-expected.txt:
* platform/win-wk2/fast/css/pseudo-any-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd another test that depends on EventSender to the mac-wk2 Skipped file.
jberlin@webkit.org [Tue, 29 Mar 2011 15:40:02 +0000 (15:40 +0000)]
Add another test that depends on EventSender to the mac-wk2 Skipped file.

* platform/mac-wk2/Skipped:
Add fast/events/mouse-relative-position.html.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Vsevolod Vlasov <vsevik@chromium.org>
pfeldman@chromium.org [Tue, 29 Mar 2011 15:33:31 +0000 (15:33 +0000)]
2011-03-29  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        [Chromium] Inspector does not always shows transferred size correctly (e.g. gzipped/chunked content)
        https://bugs.webkit.org/show_bug.cgi?id=56602

        Added new methods to interface while keeping the old ones to keep
        chromium working until it is also patched.

        * public/WebURLLoaderClient.h:
        (WebKit::WebURLLoaderClient::didReceiveData2):
        * src/AssociatedURLLoader.cpp:
        (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveData):
        * src/ResourceHandle.cpp:
        (WebCore::ResourceHandleInternal::didReceiveData):
        (WebCore::ResourceHandleInternal::didReceiveData2):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 29 Mar 2011 15:30:41 +0000 (15:30 +0000)]
2011-03-29  Eric Seidel  <eric@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Rename InlineIterator::pos to m_pos to match modern style
        https://bugs.webkit.org/show_bug.cgi?id=57342

        Somehow I failed to upload this one earlier, no wonder later patches didn't apply.

        * rendering/InlineIterator.h:
        (WebCore::InlineIterator::InlineIterator):
        (WebCore::operator==):
        (WebCore::operator!=):
        (WebCore::InlineIterator::increment):
        (WebCore::InlineIterator::current):
        (WebCore::InlineBidiResolver::appendRun):
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::checkMidpoints):
        (WebCore::RenderBlock::appendRunsForObject):
        (WebCore::RenderBlock::layoutInlineChildren):
        (WebCore::RenderBlock::matchedEndLine):
        (WebCore::tryHyphenating):
        (WebCore::RenderBlock::findNextLineBreak):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd Windows expected semi-failure results after r82189
aroben@apple.com [Tue, 29 Mar 2011 15:26:37 +0000 (15:26 +0000)]
Add Windows expected semi-failure results after r82189

The test is passing, but we're failing to print out an error message so we don't match the
expected results. Printing the error message is tracked by <http://webkit.org/b/57334>.

* platform/win/http/tests/uri/username-with-no-hostname-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Ben Taylor <bentaylor.solx86@gmail.com>
commit-queue@webkit.org [Tue, 29 Mar 2011 15:25:57 +0000 (15:25 +0000)]
2011-03-29  Ben Taylor  <bentaylor.solx86@gmail.com>

        Reviewed by Benjamin Poulain.

        https://bugs.webkit.org/show_bug.cgi?id=41953

        Fix compile error on Solaris 10/Sun Studio 12 CC emanating from MathExtras.h

        * wtf/MathExtras.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 29 Mar 2011 15:22:37 +0000 (15:22 +0000)]
2011-03-29  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: document BrowserDebugger agent.
        https://bugs.webkit.org/show_bug.cgi?id=57331

        * inspector/Inspector.json:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Tue, 29 Mar 2011 15:09:55 +0000 (15:09 +0000)]
2011-03-29  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Fix handling of the CSSAgent.setStyleSheetText() results in CSSStyleModel.js
        https://bugs.webkit.org/show_bug.cgi?id=56310

        Instead of stylesheet ids, CSSAgent.getAllStyleSheets() now returns metainfo objects containing
        "styleSheetId", "sourceURL", "disabled", and "title" fields. The latter three are not returned
        by CSSAgent.getStyleSheet() anymore.

        Test: inspector/styles/get-set-stylesheet-text.html

        WebCore:
        * inspector/Inspector.json:
        * inspector/InspectorCSSAgent.cpp:
        (WebCore::InspectorCSSAgent::getAllStyleSheets):
        * inspector/InspectorCSSAgent.h:
        * inspector/InspectorStyleSheet.cpp:
        (WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
        (WebCore::InspectorStyleSheet::buildObjectForStyleSheetInfo):
        * inspector/InspectorStyleSheet.h:
        * inspector/front-end/AuditRules.js:
        (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.styleSheetCallback):
        (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.allStylesCallback):
        (WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
        * inspector/front-end/CSSStyleModel.js:
        (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback):
        (WebInspector.CSSStyleModel.prototype._styleSheetChanged):
        (WebInspector.CSSStyleModel.prototype._onRevert):
        (WebInspector.CSSStyleSheet):
        (WebInspector.CSSStyleSheet.prototype.setText):

        LayoutTests:
        * inspector/styles/get-set-stylesheet-text-expected.txt: Added.
        * inspector/styles/get-set-stylesheet-text.html: Added.
        * inspector/styles/resources/get-set-stylesheet-text.css: Added.
        (body):
        (/* comment before selector */body.main1/* comment after selector */):
        (body.main2):
        * inspector/styles/styles-add-blank-property.html: Tentatively fix flakiness by waiting for pending dispatches to finish
        * inspector/styles/styles-new-API.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Vsevolod Vlasov <vsevik@chromium.org>
commit-queue@webkit.org [Tue, 29 Mar 2011 15:07:13 +0000 (15:07 +0000)]
2011-03-29  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] DevTools shows two resources for each plugin resource loaded
        https://bugs.webkit.org/show_bug.cgi?id=57101

        Remove DevToolsAgent network callbacks as this information is now available through ResourceLoader

        * public/WebDevToolsAgent.h:
        * src/WebDevToolsAgentImpl.cpp:
        * src/WebDevToolsAgentImpl.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Jeremy Moskovich <jeremy@chromium.org>
jeremy@chromium.org [Tue, 29 Mar 2011 14:41:01 +0000 (14:41 +0000)]
2011-03-29  Jeremy Moskovich  <jeremy@chromium.org>

        Reviewed by Eric Seidel.

        Implement text-align:match-parent as -webkit-match-parent.
        https://bugs.webkit.org/show_bug.cgi?id=50951

        Add tests to verify that the implementation works as expected.

        * fast/css/text-align-webkit-match-parent-expected.txt: Added.
        * fast/css/text-align-webkit-match-parent-parse-expected.txt: Added.
        * fast/css/text-align-webkit-match-parent-parse.html: Added.
        * fast/css/text-align-webkit-match-parent.html: Added.
2011-03-29  Jeremy Moskovich  <jeremy@chromium.org>

        Reviewed by Eric Seidel.

        Implement text-align:match-parent as -webkit-match-parent.
        https://bugs.webkit.org/show_bug.cgi?id=50951

        Add support to the CSS parser.

        Tests: fast/css/text-align-webkit-match-parent-parse.html
               fast/css/text-align-webkit-match-parent.html

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        * css/CSSValueKeywords.in:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 29 Mar 2011 14:35:02 +0000 (14:35 +0000)]
2011-03-29  Eric Seidel  <eric@webkit.org>

        Reviewed by Ryosuke Niwa.

        Rename InlineIterator::nextBreakablePosition to m_nextBreakablePosition to match modern style
        https://bugs.webkit.org/show_bug.cgi?id=57323

        All of these m_nextBreakablePosition = -1 could probably be replaced with
        some new methods.  But I'll do that in a separate change.  Clearly
        m_nextBreakablePosition is just a cached value which should be cleared
        at the right times.  I suspect we may even fail to clear it sometimes when
        we should due to the current used of direct access instead of smarter functions.

        * rendering/InlineIterator.h:
        (WebCore::InlineIterator::InlineIterator):
        (WebCore::InlineIterator::increment):
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::tryHyphenating):
        (WebCore::RenderBlock::findNextLineBreak):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd Windows results for new test added in r82200
aroben@apple.com [Tue, 29 Mar 2011 14:30:46 +0000 (14:30 +0000)]
Add Windows results for new test added in r82200

Windows differs from Mac due to a different scrollbar width within the listbox.

* platform/win/fast/forms/listbox-bidi-align-expected.checksum: Added.
* platform/win/fast/forms/listbox-bidi-align-expected.png: Added.
* platform/win/fast/forms/listbox-bidi-align-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Jeff Miller <jeffm@apple.com>
jeffm@apple.com [Tue, 29 Mar 2011 14:14:12 +0000 (14:14 +0000)]
2011-03-29  Jeff Miller  <jeffm@apple.com>

        Reviewed by Jon Honeycutt.

        Add WebCore::copyCertificateToData() on Windows
        https://bugs.webkit.org/show_bug.cgi?id=57296

        Remove duplicate code that implemented this functionality in WebMutableURLRequest.cpp and use WebCore::copyCertificateToData() instead.

        * WebMutableURLRequest.cpp:
        (WebMutableURLRequest::setClientCertificate):  Use WebCore::copyCertificateToData().
2011-03-29  Jeff Miller  <jeffm@apple.com>

        Reviewed by Jon Honeycutt.

        Add WebCore::copyCertificateToData() on Windows
        https://bugs.webkit.org/show_bug.cgi?id=57296

        Create a new win directory in platform/cf and add CertificateCFWin.cpp and CertificateCFWin.h to it.

        * WebCore.vcproj/WebCore.vcproj: Added CertificateCFWin.cpp and CertificateCFWin.h.
        * WebCore.vcproj/copyForwardingHeaders.cmd: Copy all header files in \platform\cf\win\.
        * platform/cf/win: Added.
        * platform/cf/win/CertificateCFWin.cpp: Added.
        (WebCore::deallocCertContext): Added.
        (WebCore::createCertContextDeallocator): Added.
        (WebCore::copyCertificateToData): Added.
        * platform/cf/win/CertificateCFWin.h: Added.
2011-03-29  Jeff Miller  <jeffm@apple.com>

        Reviewed by Jon Honeycutt.

        Add WebCore::copyCertificateToData() on Windows
        https://bugs.webkit.org/show_bug.cgi?id=57296

        Remove duplicate code that implemented this functionality in WebCoreArgumentCodersWin.cpp and use WebCore::copyCertificateToData() instead.

        * Shared/win/WebCoreArgumentCodersWin.cpp:
        (CoreIPC::decodeResourceError): Use WebCore::copyCertificateToData().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Noel Gordon <noel.gordon@gmail.com>
commit-queue@webkit.org [Tue, 29 Mar 2011 14:09:37 +0000 (14:09 +0000)]
2011-03-29  Noel Gordon  <noel.gordon@gmail.com>

        Reviewed by Ojan Vafai.

        [chromium] DRT EventSender: remove identity from dragTargetDragEnter() calls
        https://bugs.webkit.org/show_bug.cgi?id=57303

        * DumpRenderTree/chromium/EventSender.cpp:
        (EventSender::doDragDrop):
        (EventSender::beginDragWithFiles):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 29 Mar 2011 14:06:50 +0000 (14:06 +0000)]
2011-03-29  Eric Seidel  <eric@webkit.org>

        Reviewed by Ryosuke Niwa.

        Rename InlineIterator::block to m_block to match modern style
        https://bugs.webkit.org/show_bug.cgi?id=57321

        I could have made m_block private, since it's only accessed in
        one place outside of InlineIterator (for an ASSERT).  But I chose
        not to do so in this change.

        * rendering/InlineIterator.h:
        (WebCore::InlineIterator::InlineIterator):
        (WebCore::InlineIterator::increment):
        (WebCore::InlineBidiResolver::appendRun):
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::findNextLineBreak):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Add -print-loaded-urls option to Qt's MiniBrowser and to QtTestBrowser
zoltan@webkit.org [Tue, 29 Mar 2011 13:36:33 +0000 (13:36 +0000)]
[Qt] Add -print-loaded-urls option to Qt's MiniBrowser and to QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=57314

Reviewed by Andreas Kling.

Provide possibility to print loaded urls to the standard output.

* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::printURL):
* MiniBrowser/qt/BrowserWindow.h:
* MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::handleUserOptions):
* MiniBrowser/qt/MiniBrowserApplication.h:
(WindowOptions::WindowOptions):
* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::initializeView):
(LauncherWindow::printURL):
(LauncherWindow::cloneWindow):
* QtTestBrowser/launcherwindow.h:
(WindowOptions::WindowOptions):
* QtTestBrowser/main.cpp:
(LauncherApplication::handleUserOptions):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Alexis Menard <alexis.menard@openbossa.org>
alexis.menard@openbossa.org [Tue, 29 Mar 2011 13:33:00 +0000 (13:33 +0000)]
2011-03-29  Alexis Menard  <alexis.menard@openbossa.org>

        Unreviewed build fix for build-webkit -minimal.

        Breakage introduced by http://trac.webkit.org/changeset/82238.
        The minimal option has no support for shortcuts.

        * WebCoreSupport/EditorClientQt.cpp:
        (WebCore::EditorClientQt::handleInputMethodKeydown):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Leo Yang <leo.yang@torchmobile.com.cn>
commit-queue@webkit.org [Tue, 29 Mar 2011 13:28:09 +0000 (13:28 +0000)]
2011-03-29  Leo Yang  <leo.yang@torchmobile.com.cn>

        Reviewed by Nikolas Zimmermann.

        Incorrect offset of svg <use> element which is in <symbol> element
        https://bugs.webkit.org/show_bug.cgi?id=57318

        Test case to verify offset of svg <use> element in <symbol> element
        is set correctly.

        * platform/qt/svg/custom/use-in-symbol-with-offset-expected.checksum: Added.
        * platform/qt/svg/custom/use-in-symbol-with-offset-expected.png: Added.
        * svg/custom/use-in-symbol-with-offset-expected.txt: Added.
        * svg/custom/use-in-symbol-with-offset.svg: Added.
2011-03-29  Leo Yang  <leo.yang@torchmobile.com.cn>

        Reviewed by Nikolas Zimmermann.

        Incorrect offset of svg <use> element which is in <symbol> element
        https://bugs.webkit.org/show_bug.cgi?id=57318

        When webkit expanded a svg <symbol> element in the shadow tree it
        would clone the children of the <symbol>. The children may contain
        SVGShadowTreeContainerElement which was expanded from svg <use>
        element. But the clone operation would clone a
        SVGShadowTreeContainerElement as a svg <g> element. This resulted
        that updateContainerOffset wouldn't update offset for those elements
        which were expand from <use> elements.

        This patch implements cloneElementWithoutAttributesAndChildren for
        SVGShadowTreeContainerElement to make the container clone itself
        correctly.

        Test: svg/custom/use-in-symbol-with-offset.svg

        * rendering/svg/SVGShadowTreeElements.cpp:
        (WebCore::SVGShadowTreeContainerElement::cloneElementWithoutAttributesAndChildren):
        * rendering/svg/SVGShadowTreeElements.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 29 Mar 2011 13:18:11 +0000 (13:18 +0000)]
2011-03-29  Eric Seidel  <eric@webkit.org>

        Reviewed by Ryosuke Niwa.

        Rename InlineIterator::obj to m_obj to match modern style
        https://bugs.webkit.org/show_bug.cgi?id=57319

        I started this rename after confusion in InlineBidiResolver::appendRun.
        (Which uses an "obj" local in InlineIterator.h.  It's not actually
        masking m_obj because it's a separate class, but I didn't realize
        that at the time because it's in InlineIterator.h which is itself confusing!)

        * rendering/InlineIterator.h:
        (WebCore::InlineIterator::InlineIterator):
        (WebCore::operator==):
        (WebCore::operator!=):
        (WebCore::InlineIterator::increment):
        (WebCore::InlineIterator::atEnd):
        (WebCore::InlineIterator::current):
        (WebCore::InlineIterator::direction):
        (WebCore::InlineBidiResolver::appendRun):
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::checkMidpoints):
        (WebCore::RenderBlock::appendRunsForObject):
        (WebCore::RenderBlock::layoutInlineChildren):
        (WebCore::RenderBlock::matchedEndLine):
        (WebCore::skipNonBreakingSpace):
        (WebCore::RenderBlock::requiresLineBox):
        (WebCore::RenderBlock::skipTrailingWhitespace):
        (WebCore::RenderBlock::skipLeadingWhitespace):
        (WebCore::tryHyphenating):
        (WebCore::RenderBlock::findNextLineBreak):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Remove modular references after support for the flag was removed.
ossy@webkit.org [Tue, 29 Mar 2011 13:18:05 +0000 (13:18 +0000)]
[Qt] Remove modular references after support for the flag was removed.
https://bugs.webkit.org/show_bug.cgi?id=57018

Rubber-stamped by Andreas Kling.

Symbian buildfix after r82232.

* Source/WebKit.pri: Readd uitools option.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 29 Mar 2011 13:05:07 +0000 (13:05 +0000)]
2011-03-29  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: document Timeline domain, make timeline event types of type string.
        https://bugs.webkit.org/show_bug.cgi?id=57299

        * inspector/timeline/timeline-enum-stability-expected.txt:
        * inspector/timeline/timeline-event-dispatch-expected.txt:
        * inspector/timeline/timeline-layout-expected.txt:
        * inspector/timeline/timeline-mark-timeline-expected.txt:
        * inspector/timeline/timeline-network-resource-expected.txt:
        * inspector/timeline/timeline-paint-expected.txt:
        * inspector/timeline/timeline-parse-html-expected.txt:
        * inspector/timeline/timeline-recalculate-styles-expected.txt:
        * inspector/timeline/timeline-script-tag-1-expected.txt:
        * inspector/timeline/timeline-script-tag-2-expected.txt:
        * inspector/timeline/timeline-test.js:
        (initialize_Timeline.InspectorTest.startTimeline):
        * platform/chromium/inspector/timeline/timeline-event-dispatch-expected.txt:
        * platform/chromium/inspector/timeline/timeline-mark-timeline-expected.txt:
        * platform/chromium/inspector/timeline/timeline-network-resource-expected.txt:
        * platform/chromium/inspector/timeline/timeline-paint-expected.txt:
        * platform/chromium/inspector/timeline/timeline-parse-html-expected.txt:
2011-03-29  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: document Timeline domain, make timeline event types of type string.
        https://bugs.webkit.org/show_bug.cgi?id=57299

        * inspector/Inspector.json:
        * inspector/InspectorTimelineAgent.cpp:
        (WebCore::InspectorTimelineAgent::pushGCEventRecords):
        (WebCore::InspectorTimelineAgent::start):
        (WebCore::InspectorTimelineAgent::stop):
        (WebCore::InspectorTimelineAgent::willCallFunction):
        (WebCore::InspectorTimelineAgent::didCallFunction):
        (WebCore::InspectorTimelineAgent::willDispatchEvent):
        (WebCore::InspectorTimelineAgent::didDispatchEvent):
        (WebCore::InspectorTimelineAgent::willLayout):
        (WebCore::InspectorTimelineAgent::didLayout):
        (WebCore::InspectorTimelineAgent::willRecalculateStyle):
        (WebCore::InspectorTimelineAgent::didRecalculateStyle):
        (WebCore::InspectorTimelineAgent::willPaint):
        (WebCore::InspectorTimelineAgent::didPaint):
        (WebCore::InspectorTimelineAgent::willWriteHTML):
        (WebCore::InspectorTimelineAgent::didWriteHTML):
        (WebCore::InspectorTimelineAgent::didInstallTimer):
        (WebCore::InspectorTimelineAgent::didRemoveTimer):
        (WebCore::InspectorTimelineAgent::willFireTimer):
        (WebCore::InspectorTimelineAgent::didFireTimer):
        (WebCore::InspectorTimelineAgent::willChangeXHRReadyState):
        (WebCore::InspectorTimelineAgent::didChangeXHRReadyState):
        (WebCore::InspectorTimelineAgent::willLoadXHR):
        (WebCore::InspectorTimelineAgent::didLoadXHR):
        (WebCore::InspectorTimelineAgent::willEvaluateScript):
        (WebCore::InspectorTimelineAgent::didEvaluateScript):
        (WebCore::InspectorTimelineAgent::didScheduleResourceRequest):
        (WebCore::InspectorTimelineAgent::willSendResourceRequest):
        (WebCore::InspectorTimelineAgent::willReceiveResourceData):
        (WebCore::InspectorTimelineAgent::didReceiveResourceData):
        (WebCore::InspectorTimelineAgent::willReceiveResourceResponse):
        (WebCore::InspectorTimelineAgent::didReceiveResourceResponse):
        (WebCore::InspectorTimelineAgent::didFinishLoadingResource):
        (WebCore::InspectorTimelineAgent::didMarkTimeline):
        (WebCore::InspectorTimelineAgent::didMarkDOMContentEvent):
        (WebCore::InspectorTimelineAgent::didMarkLoadEvent):
        (WebCore::InspectorTimelineAgent::addRecordToTimeline):
        (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
        (WebCore::InspectorTimelineAgent::pushCurrentRecord):
        * inspector/InspectorTimelineAgent.h:
        (WebCore::InspectorTimelineAgent::TimelineRecordEntry::TimelineRecordEntry):
        * inspector/front-end/TimelineAgent.js:
        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel.prototype.get _recordStyles):
        (WebInspector.TimelinePanel.prototype._createEventDivider):
        (WebInspector.TimelinePanel.prototype._findParentRecord):
        (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
        (WebInspector.TimelineDispatcher.prototype.started):
        (WebInspector.TimelineDispatcher.prototype.stopped):
        (WebInspector.TimelineDispatcher.prototype.eventRecorded):
        (WebInspector.TimelinePanel.FormattedRecord):
        (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
        (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Janne Koskinen <janne.p.koskinen@digia.com>
alexis.menard@openbossa.org [Tue, 29 Mar 2011 13:04:25 +0000 (13:04 +0000)]
2011-03-29  Janne Koskinen  <janne.p.koskinen@digia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Enterkey to go to Newline does not work in the text area(in HTML form)
        https://bugs.webkit.org/show_bug.cgi?id=33179

        Fixed newline generation from Qt::Key_Enter when editting text area using InputMethods.

        * WebCoreSupport/EditorClientQt.cpp:
        (WebCore::EditorClientQt::handleInputMethodKeydown):
        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::inputMethods):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Andrey Adaikin <aandrey@google.com>
podivilov@chromium.org [Tue, 29 Mar 2011 12:58:15 +0000 (12:58 +0000)]
2011-03-29  Andrey Adaikin  <aandrey@google.com>

        Reviewed by Pavel Feldman.

        Web Inspector: Fixing live edits tests on chromium.
        https://bugs.webkit.org/show_bug.cgi?id=57316

        * inspector/debugger/live-edit.html:
2011-03-29  Andrey Adaikin  <aandrey@google.com>

        Reviewed by Pavel Feldman.

        Web Inspector: Fixing live edits tests on chromium.
        https://bugs.webkit.org/show_bug.cgi?id=57316

        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.editScriptSource):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._handleSave.didEditScriptSource):
        (WebInspector.SourceFrame.prototype._handleSave):
        (WebInspector.SourceFrameDelegate.prototype.editScriptSource):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 29 Mar 2011 12:55:02 +0000 (12:55 +0000)]
2011-03-29  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip crashing svg test on GTK.

        * platform/gtk/Skipped: Skip svg/text/text-deco-01-b.svg

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Tue, 29 Mar 2011 12:29:56 +0000 (12:29 +0000)]
2011-03-29  Andreas Kling  <kling@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt] Fix documentation for QWebPage::repaintRequested()

        This signal is always emitted when the page is dirtied, so remove
        reference to old behavior where we would only emit the signal for
        headless QWebPages.

        * Api/qwebpage.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Tue, 29 Mar 2011 12:28:34 +0000 (12:28 +0000)]
2011-03-29  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: fix call frames positions in formatted scripts.
        https://bugs.webkit.org/show_bug.cgi?id=57036

        * inspector/debugger/debugger-eval-while-paused.html:
2011-03-29  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: fix call frames positions in formatted scripts.
        https://bugs.webkit.org/show_bug.cgi?id=57036

        Introduce PresentationCallFrame class that encapsulates source mapping details from UI components.

        * inspector/front-end/CallStackSidebarPane.js:
        (WebInspector.CallStackSidebarPane.prototype.update.didGetSourceLocation):
        (WebInspector.CallStackSidebarPane.prototype.update):
        (WebInspector.CallStackSidebarPane.prototype.set selectedCallFrame):
        (WebInspector.CallStackSidebarPane.prototype._placardSelected):
        (WebInspector.CallStackSidebarPane.prototype._contextMenu):
        (WebInspector.CallStackSidebarPane.prototype._copyStackTrace):
        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerModel.prototype._didEditScriptSource):
        (WebInspector.DebuggerModel.prototype.get debuggerPausedDetails):
        (WebInspector.DebuggerModel.prototype._pausedScript):
        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel):
        (WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didEditScriptSource):
        (WebInspector.DebuggerPresentationModel.prototype.editScriptSource):
        (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
        (WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
        (WebInspector.DebuggerPresentationModel.prototype._debuggerResumed):
        (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
        (WebInspector.DebuggerPresentationModel.prototype.get selectedCallFrame):
        (WebInspector.DebuggerPresentationModel.prototype._reset):
        (WebInspector.PresenationCallFrame): Call frame wrapper for UI.
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
        (WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetSourceLocation):
        (WebInspector.ScriptsPanel.prototype._debuggerPaused):
        (WebInspector.ScriptsPanel.prototype._debuggerResumed):
        (WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):
        (WebInspector.ScriptsPanel.prototype._callFrameSelected.didGetSourceLocation):
        (WebInspector.ScriptsPanel.prototype._callFrameSelected):
        (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.evaluateInSelectedCallFrame):
        * inspector/front-end/SourceFile.js:
        (WebInspector.SourceFile.prototype.get content):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._createTextViewer):
        (WebInspector.SourceFrame.prototype.setExecutionLine):
        (WebInspector.SourceFrame.prototype.clearExecutionLine):
        (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
        (WebInspector.SourceFrame.prototype._showPopup):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Emil A Eklund <eae@chromium.org>
eae@chromium.org [Tue, 29 Mar 2011 12:10:05 +0000 (12:10 +0000)]
2011-03-29  Emil A Eklund  <eae@chromium.org>

        Reviewed by Darin Adler.

        Fix for execCommand("Delete") with an empty selection.
        https://bugs.webkit.org/show_bug.cgi?id=56652

        Add test for deleting an empty selection from an empty container.

        * editing/execCommand/delete-empty-container-expected.txt: Added.
        * editing/execCommand/delete-empty-container.html: Added.
2011-03-29  Emil A Eklund  <eae@chromium.org>

        Reviewed by Darin Adler.

        Fix for execCommand("Delete") with an empty selection.
        https://bugs.webkit.org/show_bug.cgi?id=56652

        Test: editing/execCommand/delete-empty-container.html

        * editing/TypingCommand.cpp:
        (WebCore::TypingCommand::makeEditableRootEmpty): Add check for root element.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Kristian Amlie <kristian.amlie@nokia.com>
commit-queue@webkit.org [Tue, 29 Mar 2011 12:01:25 +0000 (12:01 +0000)]
2011-03-29  Kristian Amlie  <kristian.amlie@nokia.com>

        Reviewed by Andreas Kling.

        Removed modular references after support for the flag was removed.

        Support was removed because the Qt Modularization project decided we
        don't need it. It's better to base decisions on the available
        information, as demonstrated in the patch by checking
        QT.phonon.includes.

        In addition, remove the reference to uitools. It has been moved to
        QtKernel now, and therefore is always available.

        [Qt] Remove modular references after support for the flag was removed.
        https://bugs.webkit.org/show_bug.cgi?id=57018

        * Source/WebKit.pri:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82232 268f45cc-cd09-0410-ab3c-d52691b4dbfc