WebKit.git
9 years agoIgnore more gyp-generated build files in WTF.gyp.
adamk@chromium.org [Tue, 22 Nov 2011 20:28:49 +0000 (20:28 +0000)]
Ignore more gyp-generated build files in WTF.gyp.

* .gitignore:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@101022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEmpty API for web intents
commit-queue@webkit.org [Tue, 22 Nov 2011 19:45:27 +0000 (19:45 +0000)]
Empty API for web intents
https://bugs.webkit.org/show_bug.cgi?id=69870

Patch by Greg Billock <gbillock@google.com> on 2011-11-22
Reviewed by Darin Fisher.

* WebKit.gyp:
* public/WebIntent.h: Added.
* public/WebIntentServiceInfo.h: Added.
* public/WebFrame.h:
* public/WebFrameClient.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@101021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMore rebaselines from Skia roll.
adamk@chromium.org [Tue, 22 Nov 2011 19:39:02 +0000 (19:39 +0000)]
More rebaselines from Skia roll.
Unreviewed gardening.

* platform/chromium-cg-mac-snowleopard/fast/repaint/moving-shadow-on-path-expected.txt: Removed.
* platform/chromium-mac/fast/repaint/moving-shadow-on-path-expected.txt: Removed.
* platform/chromium-win-xp/fast/repaint/moving-shadow-on-path-expected.txt: Removed.
* platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.txt:
* platform/chromium/fast/repaint/moving-shadow-on-path-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/fast/repaint/moving-shadow-on-path-expected.txt.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@101020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate flakiness dashboard for new Chromium builders and tests
commit-queue@webkit.org [Tue, 22 Nov 2011 19:13:38 +0000 (19:13 +0000)]
Update flakiness dashboard for new Chromium builders and tests
https://bugs.webkit.org/show_bug.cgi?id=72931

Patch by Ryan Sleevi <rsleevi@chromium.org> on 2011-11-22
Reviewed by Ojan Vafai.

* TestResultServer/static-dashboards/builders.js:
* TestResultServer/static-dashboards/dashboard_base.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@101019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRoll Chromium DEPS
dpranke@chromium.org [Tue, 22 Nov 2011 19:10:05 +0000 (19:10 +0000)]
Roll Chromium DEPS
https://bugs.webkit.org/show_bug.cgi?id=72972

Add dbus in Chromium as pulled dep and update to HEAD.

Patch by Scott Graham <scottmg@chromium.org> on 2011-11-22
Reviewed by Dirk Pranke.

* DEPS:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@101018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoExpand MISSING expectation for form-associated-element-crash3.html.
adamk@chromium.org [Tue, 22 Nov 2011 19:08:13 +0000 (19:08 +0000)]
Expand MISSING expectation for form-associated-element-crash3.html.
Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@101017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMark file-writer-abort.html as flakily crashing on Mac Debug.
adamk@chromium.org [Tue, 22 Nov 2011 19:02:39 +0000 (19:02 +0000)]
Mark file-writer-abort.html as flakily crashing on Mac Debug.
Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@101016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMark some tests as passing after Skia roll in http://crrev.com/111151.
adamk@chromium.org [Tue, 22 Nov 2011 18:55:34 +0000 (18:55 +0000)]
Mark some tests as passing after Skia roll in crrev.com/111151.

Unreviewed gardening.

* platform/chromium-mac/canvas/philip/tests/2d.shadow.canvas.alpha-expected.txt: Removed.
* platform/chromium-mac/canvas/philip/tests/2d.shadow.canvas.basic-expected.txt: Removed.
* platform/chromium-mac/canvas/philip/tests/2d.shadow.canvas.transparent.2-expected.txt: Removed.
* platform/chromium-mac/canvas/philip/tests/2d.shadow.image.alpha-expected.txt: Removed.
* platform/chromium-mac/canvas/philip/tests/2d.shadow.image.basic-expected.txt: Removed.
* platform/chromium-mac/canvas/philip/tests/2d.shadow.image.scale-expected.txt: Removed.
* platform/chromium-mac/canvas/philip/tests/2d.shadow.image.transparent.2-expected.txt: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@101015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoLayout Test inspector/extensions/extensions-events.html is timing out
caseq@chromium.org [Tue, 22 Nov 2011 18:37:53 +0000 (18:37 +0000)]
Layout Test inspector/extensions/extensions-events.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=72966

Reviewed by Pavel Feldman.

- always bind to {add,remove}EventListener() of event target, not WebInspector.Object

* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._registerAutosubscriptionHandler):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@101014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix .dir-locals.el to only apply to specific modes
commit-queue@webkit.org [Tue, 22 Nov 2011 18:35:41 +0000 (18:35 +0000)]
Fix .dir-locals.el to only apply to specific modes
https://bugs.webkit.org/show_bug.cgi?id=72963

Patch by Andy Wingo <wingo@igalia.com> on 2011-11-22
Reviewed by Xan Lopez.

* .dir-locals.el: Remove `nil' block, as it was causing
makefile-mode not to insert tabs.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@101013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove splitView.css (added in r100991) to the correct target.
adamk@chromium.org [Tue, 22 Nov 2011 18:33:03 +0000 (18:33 +0000)]
Move splitView.css (added in r100991) to the correct target.

* WebCore.gypi:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@101012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRoll Chromium DEPS to r110960 and set the disable_nacl flag.
dpranke@chromium.org [Tue, 22 Nov 2011 18:30:20 +0000 (18:30 +0000)]
Roll Chromium DEPS to r110960 and set the disable_nacl flag.
https://bugs.webkit.org/show_bug.cgi?id=72911

Unreviewed, build fix.

ppapi starts to depend on the NaCl gyp files as of r109739, so
we need to pass disable_nacl when running gyp to avoid pulling
in too much of NaCl.

* DEPS:
* gyp_webkit:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@101011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoLayout Test inspector/extensions/extensions-events.html is timing out
adamk@chromium.org [Tue, 22 Nov 2011 18:10:47 +0000 (18:10 +0000)]
Layout Test inspector/extensions/extensions-events.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=72966

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@101010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaselines after Skia roll (http://crrev.com/111151).
adamk@chromium.org [Tue, 22 Nov 2011 17:55:43 +0000 (17:55 +0000)]
Rebaselines after Skia roll (crrev.com/111151).

Unreviewed gardening.

* platform/chromium-linux-x86/fast/box-shadow/box-shadow-clipped-slices-expected.png: Removed.
* platform/chromium-linux-x86/fast/box-shadow/single-pixel-shadow-expected.png: Removed.
* platform/chromium-linux/fast/box-shadow/single-pixel-shadow-expected.png: Removed.
* platform/chromium-mac-leopard/fast/box-shadow/box-shadow-clipped-slices-expected.png: Removed.
* platform/chromium-mac-leopard/fast/box-shadow/single-pixel-shadow-expected.png: Removed.
* platform/chromium-mac/fast/box-shadow/single-pixel-shadow-expected.png: Removed.
* platform/chromium-win-xp/fast/css/shadow-multiple-expected.png:
* platform/chromium-win-xp/fast/multicol/shadow-breaking-expected.png:
* platform/chromium-win-xp/fast/repaint/moving-shadow-on-path-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.txt.
* platform/chromium-win/fast/box-shadow/box-shadow-clipped-slices-expected.png:
* platform/chromium-win/fast/box-shadow/single-pixel-shadow-expected.png:
* platform/chromium-win/fast/css/shadow-multiple-expected.png:
* platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
* platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.png:
* platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@101009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCSSProperty: Remove unnecessary operator overloads.
commit-queue@webkit.org [Tue, 22 Nov 2011 17:42:42 +0000 (17:42 +0000)]
CSSProperty: Remove unnecessary operator overloads.
<http://webkit.org/b/72953>

Patch by Andreas Kling <kling@webkit.org> on 2011-11-22
Reviewed by Antti Koivisto.

* css/CSSProperty.cpp:
* css/CSSProperty.h:

    Remove operator= and operator== from CSSProperty. They were neither
    implemented correctly nor used anywhere.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@101008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCSSStyleDeclaration: Kill FIXME in setProperty().
commit-queue@webkit.org [Tue, 22 Nov 2011 17:39:54 +0000 (17:39 +0000)]
CSSStyleDeclaration: Kill FIXME in setProperty().
<http://webkit.org/b/72958>

Patch by Andreas Kling <kling@webkit.org> on 2011-11-22
Reviewed by Antonio Gomes.

Remove FIXME about possibly throwing an exception when setProperty()
is called with an invalid property name. CSSOM specifies that the
method should simply return in this case.

Spec: http://dev.w3.org/csswg/cssom/#dom-cssstyledeclaration-setproperty

* css/CSSStyleDeclaration.cpp:
(WebCore::CSSStyleDeclaration::setProperty):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@101007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove some debugging code I accidentally left in r101005
aroben@apple.com [Tue, 22 Nov 2011 17:03:17 +0000 (17:03 +0000)]
Remove some debugging code I accidentally left in r101005

* Scripts/prepare-ChangeLog:
(get_function_line_ranges_for_python):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@101006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTeach prepare-ChangeLog how to find changed classes/methods/functions in Python files
aroben@apple.com [Tue, 22 Nov 2011 16:52:44 +0000 (16:52 +0000)]
Teach prepare-ChangeLog how to find changed classes/methods/functions in Python files

Fixes <http://webkit.org/b/57008> prepare-ChangeLog doesn't find names of modified
classes/methods in Python source files

Reviewed by Dan Bates.

* Scripts/prepare-ChangeLog:
(get_function_line_ranges): Call get_function_line_ranges_for_python for files ending in .py
or that use python as their interpreter. Modified the code that extracts the interpreter to
ignore a leading "/usr/bin/env " in the interpreter line, as is common for our Python
scripts.
(get_function_line_ranges_for_python): Added. Does simple parsing of Python files to look
for class/def lines and generate ranges based on them.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@101005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEnsure web process before starting a download
carlosgc@webkit.org [Tue, 22 Nov 2011 16:43:21 +0000 (16:43 +0000)]
Ensure web process before starting a download
https://bugs.webkit.org/show_bug.cgi?id=72499

Reviewed by Anders Carlsson.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::download): Call ensureWebProcess().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@101004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed buildfix after r101001.
ossy@webkit.org [Tue, 22 Nov 2011 15:40:52 +0000 (15:40 +0000)]
Unreviewed buildfix after r101001.

* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::openInspectorFrontend): Use ASSERT_UNUSED instead of ASSERT.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@101003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Spellcheck should be able to run asynchronously.
commit-queue@webkit.org [Tue, 22 Nov 2011 15:39:57 +0000 (15:39 +0000)]
Source/WebCore: Spellcheck should be able to run asynchronously.
https://bugs.webkit.org/show_bug.cgi?id=71991

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-11-22
Reviewed by Hajime Morita.

Run asynchronous spell checker if both asynchronous flag and unified text checker flag are ON.

When multiple asynchronous spellchecking are requested, only the first request will be processed.

Test: editing/spelling/spellcheck-async.html

* editing/Editor.cpp:
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
  Uses asynchronous spell checker if asynchronous flag is ON.

LayoutTests: Spellcheck should be able to run asynchronously
https://bugs.webkit.org/show_bug.cgi?id=71991

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-11-22
Reviewed by Hajime Morita.

Added asynchronouse spell checking tests.
Fixed tests that fails tearing down.

* editing/spelling/script-tests/spellcheck-paste.js: Fixed tearing down.
* editing/spelling/spellcheck-async-expected.txt: Added.
* editing/spelling/spellcheck-async.html: Added.
* editing/spelling/spelling-unified-emulation.html: Fixed tearing down.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@101002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agocvel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Tue, 22 Nov 2011 15:18:02 +0000 (15:18 +0000)]
cvel Feldman  <pfeldman@google.com>

        Not reviewed: moving inspector frontend creation out of assert in WebKit2.

        * WebProcess/WebCoreSupport/WebInspectorClient.cpp:
        (WebKit::WebInspectorClient::openInspectorFrontend):lean

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@101001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [SuggestBox] Grayed prompt displayed with non-collapsed selection...
apavlov@chromium.org [Tue, 22 Nov 2011 14:43:00 +0000 (14:43 +0000)]
Web Inspector: [SuggestBox] Grayed prompt displayed with non-collapsed selection in place
https://bugs.webkit.org/show_bug.cgi?id=72951

Reviewed by Pavel Feldman.

* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.complete):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@101000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-11-22 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Tue, 22 Nov 2011 14:37:41 +0000 (14:37 +0000)]
2011-11-22  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: fix inspector front-end compilation.

        * inspector/front-end/externs.js:
        (WebInspector.showPanel):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [chromium] fix internactive ui test for scripts panel.
commit-queue@webkit.org [Tue, 22 Nov 2011 14:35:04 +0000 (14:35 +0000)]
Web Inspector: [chromium] fix internactive ui test for scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=72935

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-22
Reviewed by Yury Semikhatsky.

* src/js/Tests.js:
(.TestSuite.prototype.testScriptsTabIsPopulatedOnInspectedPageRefresh.waitUntilScriptIsParsed):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd WebCore platform interface needed by updated MediaStream API design
commit-queue@webkit.org [Tue, 22 Nov 2011 14:26:31 +0000 (14:26 +0000)]
Add WebCore platform interface needed by updated MediaStream API design
https://bugs.webkit.org/show_bug.cgi?id=70895

Patch by Adam Bergkvist <adam.bergkvist@ericsson.com> on 2011-11-22
Reviewed by Adam Barth.

This is one in a series of patches that update the MediaStream feature
to use WebCore platform interfaces.

Tests will be provided by http://webkit.org/b/56587

* GNUmakefile.list.am:
* WebCore.gypi:
* mediastream/LocalMediaStream.cpp:
(WebCore::LocalMediaStream::stopTimerFired):
* mediastream/MediaStream.h:
* mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::setEnabled):
* mediastream/PeerConnection.cpp:
(WebCore::PeerConnection::didRemoveRemoteStream):
* mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::start):
* mediastream/UserMediaRequest.h:
* platform/mediastream/MediaStreamCenter.cpp: Added.
(WebCore::MediaStreamCenter::instance):
(WebCore::MediaStreamCenter::endLocalMediaStream):
(WebCore::MediaStreamCenter::MediaStreamCenter):
(WebCore::MediaStreamCenter::~MediaStreamCenter):
(WebCore::MediaStreamCenter::queryMediaStreamSources):
(WebCore::MediaStreamCenter::didSetMediaStreamTrackEnabled):
(WebCore::MediaStreamCenter::didStopLocalMediaStream):
* platform/mediastream/MediaStreamCenter.h: Added.
(WebCore::MediaStreamSourcesQueryClient::~MediaStreamSourcesQueryClient):
* platform/mediastream/MediaStreamDescriptor.h:
(WebCore::MediaStreamDescriptorOwner::~MediaStreamDescriptorOwner):
(WebCore::MediaStreamDescriptor::owner):
(WebCore::MediaStreamDescriptor::setOwner):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Fix and unskip loadHtml api test
commit-queue@webkit.org [Tue, 22 Nov 2011 14:14:17 +0000 (14:14 +0000)]
[Qt][WK2] Fix and unskip loadHtml api test
https://bugs.webkit.org/show_bug.cgi?id=72916

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2011-11-22
Reviewed by Andreas Kling.

Now that linkHovered events are working again we can fix and unskip this
loadHtml test.

* UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_loadHtml.qml:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: remove Inspector::bringToFront from the protocol.
pfeldman@chromium.org [Tue, 22 Nov 2011 14:11:46 +0000 (14:11 +0000)]
Web Inspector: remove Inspector::bringToFront from the protocol.
https://bugs.webkit.org/show_bug.cgi?id=72937

Source/WebCore:

Inspector::bringToFront protocol method is currently used on the backend
in order to reveal the front-end window. We should do that by means of
the inspector client interface instead.

Reviewed by Yury Semikhatsky.

* inspector/Inspector.json:
* inspector/InspectorClient.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::show):
* loader/EmptyClients.h:
(WebCore::EmptyInspectorClient::bringFrontendToFront):

Source/WebKit/chromium:

Reviewed by Yury Semikhatsky.

* src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::bringFrontendToFront):
* src/InspectorClientImpl.h:
* src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::bringFrontendToFront):
* src/WebDevToolsAgentImpl.h:

Source/WebKit/efl:

Reviewed by Yury Semikhatsky.

* WebCoreSupport/InspectorClientEfl.cpp:
(WebCore::InspectorClientEfl::bringFrontendToFront):
* WebCoreSupport/InspectorClientEfl.h:

Source/WebKit/gtk:

Reviewed by Yury Semikhatsky.

* WebCoreSupport/InspectorClientGtk.cpp:
(WebKit::InspectorClient::bringFrontendToFront):
* WebCoreSupport/InspectorClientGtk.h:

Source/WebKit/mac:

Reviewed by Yury Semikhatsky.

* WebCoreSupport/WebInspectorClient.h:
* WebCoreSupport/WebInspectorClient.mm:
(WebInspectorClient::openInspectorFrontend):
(WebInspectorClient::bringFrontendToFront):

Source/WebKit/qt:

Reviewed by Yury Semikhatsky.

* WebCoreSupport/InspectorClientQt.cpp:
(WebCore::InspectorClientQt::bringFrontendToFront):
* WebCoreSupport/InspectorClientQt.h:

Source/WebKit/win:

Reviewed by Yury Semikhatsky.

* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::bringFrontendToFront):
* WebCoreSupport/WebInspectorClient.h:

Source/WebKit/wince:

Reviewed by Yury Semikhatsky.

* WebCoreSupport/InspectorClientWinCE.cpp:
(WebKit::InspectorClientWinCE::bringFrontendToFront):
* WebCoreSupport/InspectorClientWinCE.h:

Source/WebKit/wx:

Reviewed by Yury Semikhatsky.

* WebKitSupport/InspectorClientWx.cpp:
(WebCore::InspectorClientWx::bringFrontendToFront):
* WebKitSupport/InspectorClientWx.h:

Source/WebKit2:

Reviewed by Yury Semikhatsky.

* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::openInspectorFrontend):
(WebKit::WebInspectorClient::bringFrontendToFront):
* WebProcess/WebCoreSupport/WebInspectorClient.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [Extensions API][refactoring] remove dependencies on the ExtensionsSer...
caseq@chromium.org [Tue, 22 Nov 2011 13:40:41 +0000 (13:40 +0000)]
Web Inspector: [Extensions API][refactoring] remove dependencies on the ExtensionsServer from most of the insepctor
https://bugs.webkit.org/show_bug.cgi?id=72899

Reviewed by Pavel Feldman.

* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._selectedNodeChanged):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._notifyResourceContentCommitted):
(WebInspector.ExtensionServer.prototype._notifyElementsSelectionChanged):
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.addRevision):
* inspector/front-end/externs.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Build fix for MHTML support
zoltan@webkit.org [Tue, 22 Nov 2011 13:38:51 +0000 (13:38 +0000)]
[Qt] Build fix for MHTML support

* Target.pri: Add missing includepath.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] [WK2] Move PageLoadClient related code to QtWebPageLoadClient
caio.oliveira@openbossa.org [Tue, 22 Nov 2011 13:38:40 +0000 (13:38 +0000)]
[Qt] [WK2] Move PageLoadClient related code to QtWebPageLoadClient
https://bugs.webkit.org/show_bug.cgi?id=72928

Reviewed by Andreas Kling.

Split PageLoadClient related code from QtWebPageProxy/ClientImpl. The new
QtWebPageLoadClient registers itself with WKPageRef and it's owned by the
QQuickWebViewPrivate. This is a move to clean up QtWebPageProxy object.

* Target.pri:
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebView::loadProgress):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qquickwebview_p_p.h:
* UIProcess/qt/ClientImpl.cpp:
* UIProcess/qt/ClientImpl.h:
* UIProcess/qt/QtWebPageLoadClient.cpp: Added.
(QtWebPageLoadClient::QtWebPageLoadClient):
(QtWebPageLoadClient::didStartProvisionalLoadForFrame):
(QtWebPageLoadClient::didCommitLoadForFrame):
(QtWebPageLoadClient::didSameDocumentNavigationForFrame):
(QtWebPageLoadClient::didReceiveTitleForFrame):
(QtWebPageLoadClient::didFirstVisuallyNonEmptyLayoutForFrame):
(QtWebPageLoadClient::dispatchLoadSucceeded):
(QtWebPageLoadClient::dispatchLoadFailed):
(QtWebPageLoadClient::setLoadProgress):
(toQtWebPageLoadClient):
(QtWebPageLoadClient::didFailProvisionalLoadWithErrorForFrame):
(QtWebPageLoadClient::didFinishLoadForFrame):
(QtWebPageLoadClient::didFailLoadWithErrorForFrame):
(QtWebPageLoadClient::didStartProgress):
(QtWebPageLoadClient::didChangeProgress):
(QtWebPageLoadClient::didFinishProgress):
* UIProcess/qt/QtWebPageLoadClient.h: Added.
(QtWebPageLoadClient::loadProgress):
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::init):
(QtWebPageProxy::updateNavigationState):
* UIProcess/qt/QtWebPageProxy.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Extract SplitView from Panel.createSidebar() method and reuse in Eleme...
vsevik@chromium.org [Tue, 22 Nov 2011 13:24:48 +0000 (13:24 +0000)]
Web Inspector: Extract SplitView from Panel.createSidebar() method and reuse in Elements and Scripts panels.
https://bugs.webkit.org/show_bug.cgi?id=72920

Reviewed by Pavel Feldman.

Source/WebCore:

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.sh:
* inspector/front-end/ApplicationCacheModel.js:
* inspector/front-end/AuditsPanel.js:
(WebInspector.AuditsPanel):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype.wasShown):
(WebInspector.ElementsPanel.prototype.sidebarResized):
(WebInspector.ElementsPanel.prototype.toggleSearchingForNode):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel.prototype.wasShown):
(WebInspector.NetworkPanel.prototype._showResource):
(WebInspector.NetworkPanel.prototype._closeVisibleResource):
(WebInspector.NetworkPanel.prototype._toggleGridMode):
(WebInspector.NetworkPanel.prototype._toggleViewingResourceMode):
* inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.wasShown):
(WebInspector.Panel.prototype.createSplitView):
(WebInspector.Panel.prototype.createSplitViewWithSidebarTree):
(WebInspector.Panel.prototype.sidebarResized):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype._reset):
(WebInspector.ProfilesPanel.prototype.sidebarResized):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.sidebarResized):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.wasShown):
(WebInspector.ScriptsPanel.prototype.sidebarResized):
* inspector/front-end/SplitView.js: Added.
(WebInspector.SplitView):
* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane.prototype.sidebarResized):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype.sidebarResized):
(WebInspector.TimelinePanel.prototype._refreshRecords):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/auditsPanel.css:
* inspector/front-end/elementsPanel.css:
* inspector/front-end/inspector.css:
(.sidebar):
* inspector/front-end/inspector.html:
* inspector/front-end/networkLogView.css:
* inspector/front-end/networkPanel.css:
(#network-views):
* inspector/front-end/profilesPanel.css:
(#profile-views):
* inspector/front-end/resourcesPanel.css:
* inspector/front-end/scriptsPanel.css:
(#scripts-split-view):
* inspector/front-end/splitView.css: Added.
* inspector/front-end/timelinePanel.css:
(.timeline .sidebar):
(.timeline-sidebar-background):
(#resources-container-content):

LayoutTests:

* http/tests/inspector/network/network-sidebar-width.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] [WK2] Move PageUIClient related code to QtWebPageUIClient
caio.oliveira@openbossa.org [Tue, 22 Nov 2011 13:21:18 +0000 (13:21 +0000)]
[Qt] [WK2] Move PageUIClient related code to QtWebPageUIClient
https://bugs.webkit.org/show_bug.cgi?id=72910

Reviewed by Andreas Kling.

Split PageUIClient related code from QtWebPageProxy/ClientImpl. The new
QtWebPageUIClient registers itself with WKPageRef and it's owned by the
QQuickWebViewPrivate. This is a move to clean up QtWebPageProxy object.

* Target.pri:
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::chooseFiles):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qquickwebview_p_p.h:
* UIProcess/qt/ClientImpl.cpp:
* UIProcess/qt/ClientImpl.h:
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::init):
* UIProcess/qt/QtWebPageProxy.h:
* UIProcess/qt/QtWebPageUIClient.cpp: Added.
(QtWebPageUIClient::QtWebPageUIClient):
(QtWebPageUIClient::runJavaScriptAlert):
(QtWebPageUIClient::runJavaScriptConfirm):
(QtWebPageUIClient::runJavaScriptPrompt):
(QtWebPageUIClient::runOpenPanel):
(QtWebPageUIClient::setStatusText):
(QtWebPageUIClient::mouseDidMoveOverElement):
(toQtWebPageUIClient):
(createNullWKString):
* UIProcess/qt/QtWebPageUIClient.h: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r100988.
kbalazs@webkit.org [Tue, 22 Nov 2011 12:58:20 +0000 (12:58 +0000)]
Unreviewed, rolling out r100988.
http://trac.webkit.org/changeset/100988
https://bugs.webkit.org/show_bug.cgi?id=72941

"Broke pixel tests on Chromium-Linux" (Requested by kbalazs on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-22

Source/JavaScriptCore:

* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* wtf/ParallelJobs.h:
* wtf/ParallelJobsGeneric.cpp:
* wtf/ParallelJobsGeneric.h:
(WTF::ParallelEnvironment::ParallelEnvironment):
(WTF::ParallelEnvironment::execute):
* wtf/Platform.h:

Source/WebCore:

* platform/graphics/filters/FEConvolveMatrix.cpp:
(WebCore::FEConvolveMatrix::platformApplySoftware):
* platform/graphics/filters/FEConvolveMatrix.h:
* platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::platformApply):
* platform/graphics/filters/FEGaussianBlur.h:
* platform/graphics/filters/FELighting.cpp:
(WebCore::FELighting::platformApplyGeneric):
* platform/graphics/filters/FELighting.h:
* platform/graphics/filters/FEMorphology.cpp:
(WebCore::FEMorphology::platformApply):
* platform/graphics/filters/FEMorphology.h:
* platform/graphics/filters/FETurbulence.cpp:
(WebCore::FETurbulence::platformApplySoftware):
* platform/graphics/filters/FETurbulence.h:
* platform/graphics/filters/arm/FELightingNEON.cpp:
* platform/graphics/filters/arm/FELightingNEON.h:
(WebCore::FELighting::platformApplyNeon):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEnable ParallelJobs by default
kbalazs@webkit.org [Tue, 22 Nov 2011 11:42:00 +0000 (11:42 +0000)]
Enable ParallelJobs by default
https://bugs.webkit.org/show_bug.cgi?id=70032

Reviewed by Zoltan Herczeg.

Source/JavaScriptCore:

According to measurements on Mac and Linux it is a
considerable speedup for SVG on multicore.

Remove the ENABLE(PARALLEL_JOBS) guard.
Fix build on Windows and Chromium.

* JavaScriptCore.gypi:  Add the files to the build. It was
missing for the gyp build system.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Export symbols.
* wtf/ParallelJobs.h:
* wtf/ParallelJobsGeneric.cpp:
(WTF::ParallelEnvironment::ParallelEnvironment):
(WTF::ParallelEnvironment::execute):
Deinline these to avoid exporting a lot of symbols.
These are non-trivial and called only once on a given object
so it doesn't seems to be worthwile to inline them.
Additionally fix a signed-unsigned comparison in the constructor.
* wtf/ParallelJobsGeneric.h:
* wtf/Platform.h:

Source/WebCore:

Covered by existing tests.

According to measurements on Mac and Linux it is a
considerable speedup for SVG on multicore.

Remove the ENABLE(PARALLEL_JOBS) guard. Fix the Windows build
by qualifying ParallelJobs with the WTF namespace (otherwise
MSVC believes it belongs to WebCore which is likely a compiler bug).

* platform/graphics/filters/FEConvolveMatrix.cpp:
(WebCore::FEConvolveMatrix::setInteriorPixelsWorker):
(WebCore::FEConvolveMatrix::platformApplySoftware):
* platform/graphics/filters/FEConvolveMatrix.h:
* platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::platformApplyWorker):
(WebCore::FEGaussianBlur::platformApply):
* platform/graphics/filters/FEGaussianBlur.h:
* platform/graphics/filters/FELighting.cpp:
(WebCore::FELighting::platformApplyGenericWorker):
(WebCore::FELighting::platformApplyGeneric):
* platform/graphics/filters/FELighting.h:
* platform/graphics/filters/FEMorphology.cpp:
(WebCore::FEMorphology::platformApplyWorker):
(WebCore::FEMorphology::platformApply):
* platform/graphics/filters/FEMorphology.h:
* platform/graphics/filters/FETurbulence.cpp:
(WebCore::FETurbulence::fillRegionWorker):
(WebCore::FETurbulence::platformApplySoftware):
* platform/graphics/filters/FETurbulence.h:
* platform/graphics/filters/arm/FELightingNEON.cpp:
(WebCore::FELighting::platformApplyNeonWorker):
* platform/graphics/filters/arm/FELightingNEON.h:
(WebCore::FELighting::platformApplyNeon):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [protocol] actual JSON messages do not conform to Inspector.json in CSS
apavlov@chromium.org [Tue, 22 Nov 2011 11:14:54 +0000 (11:14 +0000)]
Web Inspector: [protocol] actual JSON messages do not conform to Inspector.json in CSS
https://bugs.webkit.org/show_bug.cgi?id=72733

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/Inspector.json:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getComputedStyleForNode):
* inspector/InspectorCSSAgent.h:
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::buildArrayForComputedStyle):
* inspector/InspectorStyleSheet.h:
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype.getComputedStyleAsync):
(WebInspector.CSSStyleDeclaration.parseComputedStylePayload):

LayoutTests:

* inspector/styles/styles-new-API.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK rebaseline after r100979.
philn@webkit.org [Tue, 22 Nov 2011 09:57:31 +0000 (09:57 +0000)]
Unreviewed, GTK rebaseline after r100979.

* platform/gtk/accessibility/name-from-label-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: strip unused InspectorController methods.
pfeldman@chromium.org [Tue, 22 Nov 2011 09:52:10 +0000 (09:52 +0000)]
Web Inspector: strip unused InspectorController methods.
https://bugs.webkit.org/show_bug.cgi?id=72886

Source/WebCore:

This is a follow up to the https://bugs.webkit.org/show_bug.cgi?id=63009.
I am now able to remove following InspectorController methods:
::startUserInitiatedProfiling,
::isRecordingUserInitiatedProfile,
::stopUserInitiatedProfiling,
::showAndEnableDebugger,
::debuggerEnabled,
::disableDebugger,
::startTimelineProfiler,
::stopTimelineProfiler,
::timelineProfilerEnabled,
::showConsole.

Reviewed by Yury Semikhatsky.

* WebCore.exp.in:
* WebCore.order:
* inspector/Inspector.json:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::setFrontend):
* inspector/InspectorAgent.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::connectFrontend):
* inspector/InspectorController.h:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::enable):
(WebCore::InspectorDebuggerAgent::disable):
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::resetState):
(WebCore::InspectorProfilerAgent::clearFrontend):
(WebCore::InspectorProfilerAgent::restore):
(WebCore::InspectorProfilerAgent::start):
(WebCore::InspectorProfilerAgent::stop):
* inspector/InspectorProfilerAgent.h:
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::start):
(WebCore::InspectorTimelineAgent::stop):
* inspector/InspectorTimelineAgent.h:
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.enableDebugger):
(WebInspector.DebuggerModel.prototype.disableDebugger):
* inspector/front-end/TimelineManager.js:
(WebInspector.TimelineManager.prototype.start):
(WebInspector.TimelineManager.prototype.stop):
(WebInspector.TimelineManager.prototype._started):
(WebInspector.TimelineManager.prototype._stopped):
* inspector/front-end/inspector.js:

Source/WebKit/gtk:

Reviewed by Yury Semikhatsky.

* webkit/webkitwebinspector.cpp:
(webkit_web_inspector_set_property):
(webkit_web_inspector_get_property):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Route willDraw/setNeedsRedraw to CCInputHandler and fix double-drawing...
nduca@chromium.org [Tue, 22 Nov 2011 09:34:01 +0000 (09:34 +0000)]
[chromium] Route willDraw/setNeedsRedraw to CCInputHandler and fix double-drawing issues that result
https://bugs.webkit.org/show_bug.cgi?id=72688

Source/WebCore:

This allows CCInputFilter and CCLayerTreeHostImpl to
perform requestAnimationFrame-style animations. The bulk of
work here is to make the scheduler recover gracefully when you
call setNeedsRedraw inside scheduledActionDraw.

Reviewed by James Robinson.

* WebCore.gypi:
* platform/graphics/chromium/cc/CCInputHandler.h:
(WebCore::CCInputHandlerTarget::CCInputHandlerTarget):
(WebCore::CCInputHandlerTarget::~CCInputHandlerTarget):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::currentTimeMs):
(WebCore::CCLayerTreeHostImpl::setNeedsRedraw):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
* platform/graphics/chromium/cc/CCScheduler.cpp:
(WebCore::CCScheduler::CCScheduler):
(WebCore::CCScheduler::setVisible):
(WebCore::CCScheduler::setNeedsRedraw):
(WebCore::CCScheduler::beginFrame):
(WebCore::CCScheduler::processScheduledActions):
* platform/graphics/chromium/cc/CCScheduler.h:
* platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:
(WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
(WebCore::CCSchedulerStateMachine::nextAction):
(WebCore::CCSchedulerStateMachine::updateState):
(WebCore::CCSchedulerStateMachine::setInsideVSync):
(WebCore::CCSchedulerStateMachine::setOutsideVSync):
* platform/graphics/chromium/cc/CCSchedulerStateMachine.h:
* platform/graphics/chromium/cc/CCScrollController.h: Removed.
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::scheduledActionDrawAndSwap):

Source/WebKit/chromium:

Reviewed by James Robinson.

* src/WebCompositorImpl.cpp:
(WebCore::CCInputHandler::create):
(WebKit::WebCompositorImpl::WebCompositorImpl):
(WebKit::WebCompositorImpl::handleInputEvent):
(WebKit::WebCompositorImpl::willDraw):
* src/WebCompositorImpl.h:
(WebKit::WebCompositorImpl::create):
* tests/CCFrameRateControllerTest.cpp:
(WebKitTests::FakeCCFrameRateControllerClient::beginFrame):
* tests/CCSchedulerStateMachineTest.cpp:
(WebCore::TEST):
* tests/CCSchedulerTest.cpp:
(WebKitTests::SchedulerClientThatSetNeedsDrawInsideDraw::SchedulerClientThatSetNeedsDrawInsideDraw):
(WebKitTests::SchedulerClientThatSetNeedsDrawInsideDraw::setScheduler):
(WebKitTests::SchedulerClientThatSetNeedsDrawInsideDraw::numDraws):
(WebKitTests::SchedulerClientThatSetNeedsDrawInsideDraw::hasMoreResourceUpdates):
(WebKitTests::SchedulerClientThatSetNeedsDrawInsideDraw::scheduledActionBeginFrame):
(WebKitTests::SchedulerClientThatSetNeedsDrawInsideDraw::scheduledActionDrawAndSwap):
(WebKitTests::SchedulerClientThatSetNeedsDrawInsideDraw::scheduledActionUpdateMoreResources):
(WebKitTests::SchedulerClientThatSetNeedsDrawInsideDraw::scheduledActionCommit):
(WebKitTests::TEST):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2] Modify EFL port's WebEventFactory to use EflKeyboardUtilities's
commit-queue@webkit.org [Tue, 22 Nov 2011 09:32:08 +0000 (09:32 +0000)]
[WK2] Modify EFL port's WebEventFactory to use EflKeyboardUtilities's
keyIdentifierForEvasKeyName() and windowsKeyCodeForEvasKeyName().
https://bugs.webkit.org/show_bug.cgi?id=72850

Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2011-11-22
Reviewed by Anders Carlsson.

The EflKeyboardUtilities has been added, so we can use keyIdentifierForEvasKeyName() and
windowsKeyCodeForEvasKeyName() for EFL port's WebEventFactory.

* Shared/efl/WebEventFactory.cpp:
(WebKit::WebEventFactory::createWebKeyboardEvent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening. Reset test results.
reni@webkit.org [Tue, 22 Nov 2011 09:19:17 +0000 (09:19 +0000)]
Unreviewed gardening. Reset test results.

Patch by Feher Zsolt <feherzs@inf.u-szeged.hu> on 2011-11-22

* platform/qt-5.0/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Added.
* platform/qt-5.0/css2.1/20110323/table-caption-002-expected.txt: Added.
* platform/qt-5.0/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Added.
* platform/qt-5.0/css2.1/20110323/table-caption-optional-001-expected.txt: Added.
* platform/qt-5.0/css2.1/20110323/table-caption-optional-002-expected.txt: Added.
* platform/qt-5.0/fast/multicol/pagination-h-horizontal-bt-expected.txt: Added.
* platform/qt-5.0/fast/multicol/pagination-h-horizontal-tb-expected.txt: Added.
* platform/qt-5.0/fast/multicol/pagination-h-vertical-rl-expected.txt: Added.
* platform/qt-5.0/fast/multicol/pagination-v-horizontal-bt-expected.txt: Added.
* platform/qt-5.0/fast/multicol/pagination-v-vertical-lr-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Design of the autocomplete suggest
apavlov@chromium.org [Tue, 22 Nov 2011 09:18:46 +0000 (09:18 +0000)]
Web Inspector: Design of the autocomplete suggest
https://bugs.webkit.org/show_bug.cgi?id=72798

Reviewed by Pavel Feldman.

Implemented a combination of grayed text for the first/only completion and hid
the suggest box for a single suggestion (the grayed text is displayed instead.)
Drive-by fix for the "trailing spaces in the prompt" issue
(got regressed when the suggest box was introduced for the first time.)

* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView): Fix the "trailing spaces" issue
* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt):
(WebInspector.TextPrompt.prototype.renderAsBlock): Fix the "trailing spaces" issue
(WebInspector.TextPrompt.prototype._attachInternal):
(WebInspector.TextPrompt.prototype.acceptAutoComplete):
(WebInspector.TextPrompt.prototype._completionsReady):
(WebInspector.TextPrompt.prototype.applySuggestion):
(WebInspector.TextPrompt.prototype.acceptSuggestion):
(WebInspector.TextPrompt.SuggestBox.prototype._completionsReady):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] inspector/extensions/extensions-events.html crashing after r100926
reni@webkit.org [Tue, 22 Nov 2011 08:50:59 +0000 (08:50 +0000)]
[Qt] inspector/extensions/extensions-events.html crashing after r100926
https://bugs.webkit.org/show_bug.cgi?id=72932

Unreviewed gardening.

* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] platform/gtk/accessibility/name-from-label.html fails
mario@webkit.org [Tue, 22 Nov 2011 08:30:42 +0000 (08:30 +0000)]
[GTK] platform/gtk/accessibility/name-from-label.html fails
https://bugs.webkit.org/show_bug.cgi?id=71665

Reviewed by Philippe Normand.

Fix layout test to properly consider 'form' accessibility objects.

* platform/gtk/Skipped: Unskip name-from-label.html.
* platform/gtk/accessibility/name-from-label.html: Re-write layout
  test to properly take into account the accessibility hierarchy.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Enable WebSocket hybi tests
yutak@chromium.org [Tue, 22 Nov 2011 03:38:58 +0000 (03:38 +0000)]
[GTK] Enable WebSocket hybi tests
https://bugs.webkit.org/show_bug.cgi?id=72870

Reviewed by Xan Lopez.

Source/WebKit/gtk:

Change the settings value through DumpRenderTreeSupportGtk, because we do not
want to expose this as a public API.

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::setHixie76WebSocketProtocolEnabled):
Change the value of a flag in WebCore::Settings.
* WebCoreSupport/DumpRenderTreeSupportGtk.h:

Tools:

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
Reset the setting value to the default value (true).
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::overridePreference):
Change the setting value through a function in DumpRenderTreeSupportGtk.

LayoutTests:

* platform/gtk/Skipped:
Unskip WebSocket hybi tests. Skip two tests using FileSystem API, which is not yet
supported in GTK port.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r100970.
commit-queue@webkit.org [Tue, 22 Nov 2011 03:19:30 +0000 (03:19 +0000)]
Unreviewed, rolling out r100970.
http://trac.webkit.org/changeset/100970
https://bugs.webkit.org/show_bug.cgi?id=72925

Caused AssociatedURLLoaderTest.Success to fail (Requested by
koz on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-21

* WebKit.gyp:
* public/WebUserMediaClient.h: Removed.
* public/WebUserMediaRequest.h: Removed.
* public/WebViewClient.h:
* src/UserMediaClientImpl.cpp: Removed.
* src/UserMediaClientImpl.h: Removed.
* src/WebUserMediaRequest.cpp: Removed.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
* src/WebViewImpl.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r98542): Chromium: CSS text is rendered on page
commit-queue@webkit.org [Tue, 22 Nov 2011 03:15:51 +0000 (03:15 +0000)]
REGRESSION(r98542): Chromium: CSS text is rendered on page
https://bugs.webkit.org/show_bug.cgi?id=71703

Patch by David Barr <davidbarr@chromium.org> on 2011-11-21
Reviewed by Dimitri Glazkov.

Source/WebCore:

Matched UA declarations uncacheable when using simpleDefaultStyleSheet.

Test: fast/css/style-tag-display-none.html

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::matchUARules):

LayoutTests:

* fast/css/style-tag-display-none-expected.txt: Added.
* fast/css/style-tag-display-none.html: Added.
* fast/css/style-tag-display-none-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG should have richer debug output for CFA and phi processing
fpizlo@apple.com [Tue, 22 Nov 2011 03:02:33 +0000 (03:02 +0000)]
DFG should have richer debug output for CFA and phi processing
https://bugs.webkit.org/show_bug.cgi?id=72922

Reviewed by Gavin Barraclough.

In the default verbose mode, we now print information about variable
state at the bottom of basic blocks in addition to the top, and we
also print local variable linking. In the verbose propagation mode,
the state of phi processing is dumped more richly and CFA merging (the
most subtle part of CFA) is traced as well.

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::endBasicBlock):
(JSC::DFG::AbstractState::mergeStateAtTail):
* dfg/DFGAbstractValue.h:
(JSC::DFG::StructureAbstractValue::dump):
(JSC::DFG::AbstractValue::dump):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::parse):
* dfg/DFGCommon.h:
(JSC::DFG::NodeIndexTraits::dump):
* dfg/DFGDriver.cpp:
(JSC::DFG::compile):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGNode.h:
(JSC::DFG::Node::dumpChildren):
* dfg/DFGOSRExitCompiler.cpp:
* dfg/DFGOperands.h:
(JSC::DFG::OperandValueTraits::dump):
(JSC::DFG::dumpOperands):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIf an event listener is a function, it should be called and not checked for handleEvent.
commit-queue@webkit.org [Tue, 22 Nov 2011 02:59:03 +0000 (02:59 +0000)]
If an event listener is a function, it should be called and not checked for handleEvent.
This also covers callbacks, which follow the same spec but are implemented separately.
https://bugs.webkit.org/show_bug.cgi?id=62518

Patch by Rob Brackett <rob@robbrackett.com> on 2011-11-21
Reviewed by Sam Weinig.

Source/WebCore:

Tests: fast/events/dispatch-to-function-with-handle-event.html
       fast/js/callback-function-with-handle-event.html

* bindings/js/JSCallbackData.cpp:
(WebCore::JSCallbackData::invokeCallback):
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):

LayoutTests:

* fast/events/dispatch-to-function-with-handle-event-expected.txt: Added.
* fast/events/dispatch-to-function-with-handle-event.html: Added.
* fast/js/callback-function-with-handle-event-expected.txt: Added.
* fast/js/callback-function-with-handle-event.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoShould have a test for corner cases of DFG's integer optimization and CSE.
fpizlo@apple.com [Tue, 22 Nov 2011 02:56:00 +0000 (02:56 +0000)]
Should have a test for corner cases of DFG's integer optimization and CSE.
https://bugs.webkit.org/show_bug.cgi?id=72917

Reviewed by Sam Weinig.

* fast/js/dfg-integer-optimization-expected.txt: Added.
* fast/js/dfg-integer-optimization.html: Added.
* fast/js/script-tests/dfg-integer-optimization.js: Added.
(doAdd):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoShowing the data overlay in OpenStreetMap doesn't work, zooming partially broken
fpizlo@apple.com [Tue, 22 Nov 2011 02:15:36 +0000 (02:15 +0000)]
Showing the data overlay in OpenStreetMap doesn't work, zooming partially broken
https://bugs.webkit.org/show_bug.cgi?id=71505

Reviewed by Gavin Barraclough.

It turns out that we were corrupting phi nodes in case of overflow. The bug is
really obvious, but producing a test case that causes the badness is hard. Even
when the phi nodes do get corrupt, there's more that has to happen before it
causes incorrect execution - and I wasn't able to reproduce in any kind of
sensible reduced case.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::processPhiStack):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] MediaStream API: Adding embedding code for GetUserMedia
commit-queue@webkit.org [Tue, 22 Nov 2011 01:20:15 +0000 (01:20 +0000)]
[chromium] MediaStream API: Adding embedding code for GetUserMedia
https://bugs.webkit.org/show_bug.cgi?id=71678

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-11-21
Reviewed by Darin Fisher.

* WebKit.gyp:
* public/WebUserMediaClient.h: Added.
(WebKit::WebUserMediaClient::~WebUserMediaClient):
* public/WebUserMediaRequest.h: Added.
(WebKit::WebUserMediaRequest::WebUserMediaRequest):
(WebKit::WebUserMediaRequest::~WebUserMediaRequest):
(WebKit::WebUserMediaRequest::operator=):
(WebKit::WebUserMediaRequest::isNull):
(WebKit::operator==):
* public/WebViewClient.h:
(WebKit::WebViewClient::userMediaClient):
* src/UserMediaClientImpl.cpp: Added.
(WebKit::UserMediaClientImpl::UserMediaClientImpl):
(WebKit::UserMediaClientImpl::pageDestroyed):
(WebKit::UserMediaClientImpl::requestUserMedia):
(WebKit::UserMediaClientImpl::cancelUserMediaRequest):
* src/UserMediaClientImpl.h: Added.
* src/WebUserMediaRequest.cpp: Added.
(WebKit::WebUserMediaRequest::WebUserMediaRequest):
(WebKit::WebUserMediaRequest::reset):
(WebKit::WebUserMediaRequest::audio):
(WebKit::WebUserMediaRequest::video):
(WebKit::WebUserMediaRequest::cameraPreferenceUser):
(WebKit::WebUserMediaRequest::cameraPreferenceEnvironment):
(WebKit::WebUserMediaRequest::securityOrigin):
(WebKit::WebUserMediaRequest::requestSucceeded):
(WebKit::WebUserMediaRequest::requestFailed):
(WebKit::WebUserMediaRequest::equals):
(WebKit::WebUserMediaRequest::assign):
(WebKit::WebUserMediaRequest::operator PassRefPtr<UserMediaRequest>):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
* src/WebViewImpl.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agocr-linux rebaselines for r100949. Unreviewed gardening.
adamk@chromium.org [Tue, 22 Nov 2011 01:01:58 +0000 (01:01 +0000)]
cr-linux rebaselines for r100949. Unreviewed gardening.

* platform/chromium-linux/css2.1/20110323/empty-inline-001-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/empty-inline-002-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/empty-inline-003-expected.png: Added.
* platform/chromium-linux/fast/css/empty-inline-003-quirksmode-expected.png: Added.
* platform/chromium-linux/fast/css/empty-inline-line-height-first-line-expected.png: Added.
* platform/chromium-linux/fast/css/empty-inline-line-height-first-line-quirksmode-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline after r100958. Unreviewed gardening.
adamk@chromium.org [Tue, 22 Nov 2011 00:25:32 +0000 (00:25 +0000)]
Rebaseline after r100958. Unreviewed gardening.

* platform/chromium-cg-mac-snowleopard/platform/chromium/compositing/huge-layer-rotated-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Layout Test compositing/geometry/clipped-video-controller.html is flaky...
adamk@chromium.org [Mon, 21 Nov 2011 23:31:48 +0000 (23:31 +0000)]
[chromium] Layout Test compositing/geometry/clipped-video-controller.html is flaky on Win/Linux
https://bugs.webkit.org/show_bug.cgi?id=72903

Reviewed by James Robinson.

Make this test dumpAsText(true) since what we really care about here is
pixel output.

* compositing/geometry/clipped-video-controller-expected.txt: Added.
* compositing/geometry/clipped-video-controller.html:
* platform/chromium-win/compositing/geometry/clipped-video-controller-expected.txt: Removed.
* platform/chromium/test_expectations.txt:
* platform/efl/compositing/geometry/clipped-video-controller-expected.txt: Removed.
* platform/mac/compositing/geometry/clipped-video-controller-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoOptimistically remove expectations for a handful of no-longer-failing tests.
adamk@chromium.org [Mon, 21 Nov 2011 23:27:43 +0000 (23:27 +0000)]
Optimistically remove expectations for a handful of no-longer-failing tests.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNeed support for dirname attribute
commit-queue@webkit.org [Mon, 21 Nov 2011 23:13:00 +0000 (23:13 +0000)]
Need support for dirname attribute
https://bugs.webkit.org/show_bug.cgi?id=65542

Patch by Rakesh KN <rakesh.kn@motorola.com> on 2011-11-21
Reviewed by Eric Seidel.

Implemented 'dirname' form attribute.

Source/WebCore:

Tests: fast/forms/form-dirname-attribute.html
       fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute.html
       fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor.html
       fast/forms/submit-form-with-dirname-attribute.html

* html/HTMLAttributeNames.in:
Added "dirname" attribute.
* html/HTMLInputElement.idl:
Add "dirName" property to HTMLInputElement interface.
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::appendFormData):
Append dirname form data.
* html/HTMLTextAreaElement.idl:
Add "dirName" property to HTMLTextAreaElement interface.
* html/HTMLTextFormControlElement.cpp:
(WebCore::parentHTMLElement):
Helper function which returns only HTML parent element.
(WebCore::HTMLTextFormControlElement::directionForFormData):
Helper function for finding directionality of the Element.
* html/HTMLTextFormControlElement.h:
Helper function for finding directionality of the Element.
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::appendFormData):
Append dirname form data.
* html/TextFieldInputType.h:
Append dirname form data.

LayoutTests:

* fast/forms/form-dirname-attribute-expected.txt: Added.
* fast/forms/form-dirname-attribute.html: Added.
* fast/forms/submit-form-with-dirname-attribute-expected.txt: Added.
* fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute-expected.txt: Added.
* fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute.html: Added.
* fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor-expected.txt: Added.
* fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor.html: Added.
* fast/forms/submit-form-with-dirname-attribute.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Fix tiler initialization in TiledLayerChromiumTest
jamesr@google.com [Mon, 21 Nov 2011 23:09:16 +0000 (23:09 +0000)]
[chromium] Fix tiler initialization in TiledLayerChromiumTest
https://bugs.webkit.org/show_bug.cgi?id=72915

Reviewed by Kenneth Russell.

Setting the tile size or tiling option after the tiler is created invalidates it, and by default the newly
created tiler will have border texels so the test doesn't pass. Switch things around in the test so the tiler
is created only after all the options are set, which is closer to what the real code does.

* tests/TiledLayerChromiumTest.cpp:
(WTF::FakeTiledLayerChromium::FakeTiledLayerChromium):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChromium rebaselines after r100949. Unreviewed.
adamk@chromium.org [Mon, 21 Nov 2011 23:06:32 +0000 (23:06 +0000)]
Chromium rebaselines after r100949. Unreviewed.

* platform/chromium-cg-mac-leopard/css2.1/20110323/empty-inline-001-expected.png: Added.
* platform/chromium-cg-mac-leopard/css2.1/20110323/empty-inline-002-expected.png: Added.
* platform/chromium-cg-mac-leopard/css2.1/20110323/empty-inline-003-expected.png: Added.
* platform/chromium-mac-leopard/css2.1/20110323/empty-inline-001-expected.png: Added.
* platform/chromium-mac-leopard/css2.1/20110323/empty-inline-002-expected.png: Added.
* platform/chromium-mac-leopard/css2.1/20110323/empty-inline-003-expected.png: Added.
* platform/chromium-win/css2.1/20110323/empty-inline-001-expected.png: Added.
* platform/chromium-win/css2.1/20110323/empty-inline-001-expected.txt: Copied from LayoutTests/platform/chromium/css2.1/20110323/empty-inline-001-expected.txt.
* platform/chromium-win/css2.1/20110323/empty-inline-002-expected.png: Added.
* platform/chromium-win/css2.1/20110323/empty-inline-002-expected.txt: Copied from LayoutTests/platform/chromium/css2.1/20110323/empty-inline-002-expected.txt.
* platform/chromium-win/css2.1/20110323/empty-inline-003-expected.png: Added.
* platform/chromium-win/css2.1/20110323/empty-inline-003-expected.txt: Copied from LayoutTests/platform/chromium/css2.1/20110323/empty-inline-003-expected.txt.
* platform/chromium-win/fast/css/empty-inline-003-quirksmode-expected.png: Added.
* platform/chromium-win/fast/css/empty-inline-line-height-first-line-expected.png: Added.
* platform/chromium-win/fast/css/empty-inline-line-height-first-line-quirksmode-expected.png: Added.
* platform/chromium/css2.1/20110323/empty-inline-001-expected.png:
* platform/chromium/css2.1/20110323/empty-inline-001-expected.txt:
* platform/chromium/css2.1/20110323/empty-inline-002-expected.png:
* platform/chromium/css2.1/20110323/empty-inline-002-expected.txt:
* platform/chromium/css2.1/20110323/empty-inline-003-expected.png:
* platform/chromium/css2.1/20110323/empty-inline-003-expected.txt:
* platform/chromium/fast/css/empty-inline-003-quirksmode-expected.png: Added.
* platform/chromium/fast/css/empty-inline-line-height-first-line-expected.png: Added.
* platform/chromium/fast/css/empty-inline-line-height-first-line-quirksmode-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChangeLogEntry should be able to parse entries with multiple authors
rniwa@webkit.org [Mon, 21 Nov 2011 23:01:18 +0000 (23:01 +0000)]
ChangeLogEntry should be able to parse entries with multiple authors
https://bugs.webkit.org/show_bug.cgi?id=72690

Reviewed by Eric Seidel.

Support multi-author change log entries in ChangeLogEntry. Split author names using
the same logic as splitting reviewer names. _authors now stores list of dictionaries
with "name" and "email" as keys. Unlike reviewers, we can't always resolve authors to
accounts because some contributors are never listed in committers.py.

* Scripts/webkitpy/common/checkout/changelog.py:
* Scripts/webkitpy/common/checkout/changelog_unittest.py:
* Scripts/webkitpy/common/config/committers.py: Fixed a bug that *_by_{name|email}
throws an exception when the argument is None.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix chromium compile bustage - base interface added a parameter so my fake wasn't...
jamesr@google.com [Mon, 21 Nov 2011 23:00:10 +0000 (23:00 +0000)]
Fix chromium compile bustage - base interface added a parameter so my fake wasn't actually implementing it.

* tests/TiledLayerChromiumTest.cpp:
(WTF::FakeLayerTextureUpdater::prepareToUpdate):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIndexedDB: Close database connections, abort transactions, and terminate requests...
commit-queue@webkit.org [Mon, 21 Nov 2011 22:34:29 +0000 (22:34 +0000)]
IndexedDB: Close database connections, abort transactions, and terminate requests on stop()
https://bugs.webkit.org/show_bug.cgi?id=72066

Patch by Joshua Bell <jsbell@chromium.org> on 2011-11-21
Reviewed by Tony Chang.

No new tests; addresses race conditions on document navigate/script context stop.

* dom/DocumentEventQueue.cpp:
(WebCore::DocumentEventQueue::enqueueEvent):
* dom/DocumentEventQueue.h:
* dom/EventQueue.h:
* storage/IDBDatabase.cpp:
(WebCore::IDBDatabase::IDBDatabase):
(WebCore::IDBDatabase::~IDBDatabase):
(WebCore::IDBDatabase::transaction):
(WebCore::IDBDatabase::close):
(WebCore::IDBDatabase::onVersionChange):
(WebCore::IDBDatabase::enqueueEvent):
(WebCore::IDBDatabase::stop):
* storage/IDBDatabase.h:
* storage/IDBFactory.cpp:
(WebCore::IDBFactory::IDBFactory):
(WebCore::IDBFactory::getDatabaseNames):
(WebCore::IDBFactory::open):
(WebCore::IDBFactory::deleteDatabase):
* storage/IDBFactory.h:
* storage/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::IDBObjectStore):
(WebCore::IDBObjectStore::name):
(WebCore::IDBObjectStore::keyPath):
(WebCore::IDBObjectStore::indexNames):
(WebCore::IDBObjectStore::get):
(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
(WebCore::IDBObjectStore::deleteFunction):
(WebCore::IDBObjectStore::clear):
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::deleteIndex):
(WebCore::IDBObjectStore::openCursor):
* storage/IDBObjectStore.h:
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::abort):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::onSuccessWithContinuation):
(WebCore::IDBRequest::stop):
(WebCore::IDBRequest::dispatchEvent):
(WebCore::IDBRequest::enqueueEvent):
* storage/IDBRequest.h:
* storage/IDBTransaction.cpp:
(WebCore::IDBTransaction::IDBTransaction):
(WebCore::IDBTransaction::abort):
(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::onComplete):
(WebCore::IDBTransaction::dispatchEvent):
(WebCore::IDBTransaction::stop):
(WebCore::IDBTransaction::enqueueEvent):
* storage/IDBTransaction.h:
* storage/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::abort):
(WebCore::IDBTransactionBackendImpl::commit):
* workers/WorkerEventQueue.cpp:
(WebCore::WorkerEventQueue::enqueueEvent):
* workers/WorkerEventQueue.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Avoid pushing dirty tiles to the impl layer
jamesr@google.com [Mon, 21 Nov 2011 22:22:34 +0000 (22:22 +0000)]
[chromium] Avoid pushing dirty tiles to the impl layer
https://bugs.webkit.org/show_bug.cgi?id=72765

Reviewed by Kenneth Russell.

Source/WebCore:

If a tile has invalidations at pushPropertiesTo, then we know the contents of that tile are no longer valid even
if they still have valid backing textures. This avoids pushing that texture to the impl side so it is not
displayed to the user. The texture is still kept around (managed by the TextureManager) so that when we later do
decide to update the contents for that tile we can use partial results if they are still valid.

Covered by new unit test in TiledLayerChromiumTest.cpp

* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::UpdatableTile::isDirty):
(WebCore::TiledLayerChromium::updateTileSizeAndTilingOption):
(WebCore::TiledLayerChromium::setTileSize):
(WebCore::TiledLayerChromium::setLayerTreeHost):
(WebCore::TiledLayerChromium::createTiler):
(WebCore::TiledLayerChromium::updateCompositorResources):
(WebCore::TiledLayerChromium::pushPropertiesTo):
* platform/graphics/chromium/TiledLayerChromium.h:
(WebCore::TiledLayerChromium::setTextureFormat):
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::hasTileAt):
(WebCore::CCTiledLayerImpl::drawTiles):
* platform/graphics/chromium/cc/CCTiledLayerImpl.h:

Source/WebKit/chromium:

Add unit test for TiledLayerChromium's tile pushing behavior. Requires a fair amount of fake classes. If these
fakes are useful in other tests, they should be moved to a shared location.

* WebKit.gypi:
* tests/TiledLayerChromiumTest.cpp: Added.
(::FakeTextureAllocator::createTexture):
(::FakeTextureAllocator::deleteTexture):
(::FakeLayerTextureUpdater::FakeLayerTextureUpdater):
(::FakeLayerTextureUpdater::~FakeLayerTextureUpdater):
(::FakeLayerTextureUpdater::orientation):
(::FakeLayerTextureUpdater::sampledTexelFormat):
(::FakeLayerTextureUpdater::prepareToUpdate):
(::FakeLayerTextureUpdater::updateTextureRect):
(::FakeCCTiledLayerImpl::FakeCCTiledLayerImpl):
(::FakeCCTiledLayerImpl::~FakeCCTiledLayerImpl):
(::FakeCCTiledLayerImpl::hasTileAt):
(::FakeTiledLayerChromium::FakeTiledLayerChromium):
(::FakeTiledLayerChromium::~FakeTiledLayerChromium):
(::FakeTiledLayerChromium::invalidateRect):
(::FakeTiledLayerChromium::prepareToUpdate):
(::FakeTiledLayerChromium::textureManager):
(::FakeTiledLayerChromium::createTextureUpdater):
(::FakeTiledLayerChromium::textureUpdater):
(::TEST):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPlatform-specific results for r100949
robert@webkit.org [Mon, 21 Nov 2011 22:10:32 +0000 (22:10 +0000)]
Platform-specific results for r100949

Unreviewed gardening.

* platform/gtk/css2.1/20110323/empty-inline-001-expected.txt: Added.
* platform/gtk/css2.1/20110323/empty-inline-002-expected.txt: Added.
* platform/gtk/css2.1/20110323/empty-inline-003-expected.txt: Added.
* platform/gtk/fast/css/empty-inline-003-quirksmode-expected.txt: Added.
* platform/gtk/fast/css/empty-inline-line-height-first-line-expected.txt: Added.
* platform/gtk/fast/css/empty-inline-line-height-first-line-quirksmode-expected.txt: Added.
* platform/qt/css2.1/20110323/empty-inline-001-expected.txt: Added.
* platform/qt/css2.1/20110323/empty-inline-002-expected.txt: Added.
* platform/qt/css2.1/20110323/empty-inline-003-expected.txt: Added.
* platform/qt/fast/css/empty-inline-003-quirksmode-expected.txt: Added.
* platform/qt/fast/css/empty-inline-line-height-first-line-expected.txt: Added.
* platform/qt/fast/css/empty-inline-line-height-first-line-quirksmode-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix the SnowLeopard build.
mrowe@apple.com [Mon, 21 Nov 2011 21:58:51 +0000 (21:58 +0000)]
Fix the SnowLeopard build.

* Misc/WebNSFileManagerExtras.mm: Forward-declare DADiskCreateFromVolumePath on SnowLeopard as it was
not yet declared in a public header.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] REGRESSION(100483): It made 2 API tests fail
alexis.menard@openbossa.org [Mon, 21 Nov 2011 21:45:30 +0000 (21:45 +0000)]
[Qt][WK2] REGRESSION(100483): It made 2 API tests fail
https://bugs.webkit.org/show_bug.cgi?id=72612

Reviewed by Kenneth Rohde Christiansen.

Make sure that when the view is focused, the page knows about it.
Also set a the view to be the focused item in the failing tests.

* UIProcess/API/qt/qquickwebpage_p.h:
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebView::focusInEvent):
(QQuickWebView::focusOutEvent):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml:
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::isViewFocused):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<http://webkit.org/b/72661> Switch to a more modern approach to retrieving the startu...
mrowe@apple.com [Mon, 21 Nov 2011 21:40:34 +0000 (21:40 +0000)]
<webkit.org/b/72661> Switch to a more modern approach to retrieving the startup volume name

Use the DiskArbitration framework to retrieve the name of the startup volume rather than using Carbon
File Manager APIs.

Reviewed by Dan Bernstein.

Source/WebKit:

* WebKit.xcodeproj/project.pbxproj: Link against DiskArbitration.framework. It lives in the shared cache
so it should add only negligible launch time overhead.

Source/WebKit/mac:

* Misc/WebNSFileManagerExtras.mm:
(-[NSFileManager _webkit_startupVolumeName]): Retrieve a DADiskRef for the startup volume and copy
the volume name from its description dictionary.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening, remove expectations for no-longer-flakey media tests.
adamk@chromium.org [Mon, 21 Nov 2011 21:32:59 +0000 (21:32 +0000)]
Unreviewed gardening, remove expectations for no-longer-flakey media tests.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Speed up debug builds.
hausmann@webkit.org [Mon, 21 Nov 2011 21:19:24 +0000 (21:19 +0000)]
[Qt] Speed up debug builds.
https://bugs.webkit.org/show_bug.cgi?id=72882

Reviewed by Tor Arne Vestbø.

Source/JavaScriptCore:

* Target.pri: Make BUILDING_JavaScriptCore available earlier, so it can be
used by the build system.

Source/WebCore:

* Target.pri: Make BUILDING_WebCore available earlier, so it can be
used by the build system.

Source/WebKit2:

* Target.pri: Make BUILDING_WebKit2 available, so it can be
used by the build system.

Tools:

Introduce a special type of build that replaces the static jsc/wc/wk2
static libraries with shared libraries, that individually are much faster
to link and don't require relinking into the big library when changing just
one file in one module. It can be enabled with
--qmakearg="CONFIG+=force_static_libs_as_shared"

* qmake/mkspecs/features/force_static_libs_as_shared.prf: Added. With this configuration,
disable symbol visibility, static linkage and enable rpath.
* qmake/mkspecs/features/functions.prf: Add a helper function to determine if
we need to link the convenience libraries together or not and renamed linkStaticLibrary
to just linkLibrary (because linkage is not necessarily static).
* qmake/mkspecs/features/qtwebkit.prf: When using the trick, make sure to also
link against jsc/wc/wk2 when linking app code against QtWebKit.
* qmake/mkspecs/features/javascriptcore.prf: Use new +needToLinkLibrary helper
function.
* qmake/mkspecs/features/webcore.prf: Ditto.
* qmake/mkspecs/features/webkit2.prf: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate flakiness dashboard linkification regexps for crbug.com/100000 and above
adamk@chromium.org [Mon, 21 Nov 2011 21:15:28 +0000 (21:15 +0000)]
Update flakiness dashboard linkification regexps for crbug.com/100000 and above
https://bugs.webkit.org/show_bug.cgi?id=72898

Reviewed by Ojan Vafai.

Also removed a comment that was going to be more trouble to keep up to
date than seemed worthwhile (the code is now the documentation).

* TestResultServer/static-dashboards/flakiness_dashboard.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Remove unnecessary initialize method from QQuickWebView.
alexis.menard@openbossa.org [Mon, 21 Nov 2011 21:06:41 +0000 (21:06 +0000)]
[Qt] Remove unnecessary initialize method from QQuickWebView.
https://bugs.webkit.org/show_bug.cgi?id=72905

Reviewed by Kenneth Rohde Christiansen.

We don't need this level of indirection.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebView::QQuickWebView):
* UIProcess/API/qt/qquickwebview_p_p.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCSS 2.1 failure: empty-inline-003.htm fails
robert@webkit.org [Mon, 21 Nov 2011 21:06:14 +0000 (21:06 +0000)]
CSS 2.1 failure: empty-inline-003.htm fails
https://bugs.webkit.org/show_bug.cgi?id=72638

Reviewed by Ryosuke Niwa.

Source/WebCore:

Empty inline elements need to share their inline height with siblings.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::inlineFlowRequiresLineBox): In strict mode, add a LineBox for an empty element if it is
going to affect the line-height.
(WebCore::requiresLineBox): Pass LineInfo to inlineFlowRequiresLineBox
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Pass LineInfo to inlineFlowRequiresLineBox

LayoutTests:

* css2.1/20110323/empty-inline-001.htm: Added.
* css2.1/20110323/empty-inline-002.htm: Added.
* css2.1/20110323/empty-inline-003.htm: Added.
* fast/css/empty-inline-003-quirksmode-expected.png: Result can
  cover all platforms as there is no text apart from the period.
* fast/css/empty-inline-003-quirksmode-expected.txt: ditto
* fast/css/empty-inline-003-quirksmode.htm: empty-inline-003.htm should only pass in
  strict mode, this ensures it 'fails' in quirks mode.
* fast/css/empty-inline-line-height-first-line-expected.png: Added.
* fast/css/empty-inline-line-height-first-line-expected.txt: Added.
* fast/css/empty-inline-line-height-first-line-quirksmode-expected.png: Added.
* fast/css/empty-inline-line-height-first-line-quirksmode-expected.txt: Result can
  cover all platforms as there is no text apart from the period.
* fast/css/empty-inline-line-height-first-line-quirksmode.htm: Like
  empty-inline-003.htm, empty-inline-line-height-first-line.htm should also fail in quirks mode.
* fast/css/empty-inline-line-height-first-line.htm: Like empty-inline-003.htm but
  ensures first-line style is respected for line-height in empty elements.
* platform/chromium/css2.1/20110323/empty-inline-001-expected.png: Added.
* platform/chromium/css2.1/20110323/empty-inline-001-expected.txt: Added.
* platform/chromium/css2.1/20110323/empty-inline-002-expected.png: Added.
* platform/chromium/css2.1/20110323/empty-inline-002-expected.txt: Added.
* platform/chromium/css2.1/20110323/empty-inline-003-expected.png: Added.
* platform/chromium/css2.1/20110323/empty-inline-003-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] WebAccessibilityNotification should use AssertMatchingEnums.
dmazzoni@google.com [Mon, 21 Nov 2011 21:04:04 +0000 (21:04 +0000)]
[Chromium] WebAccessibilityNotification should use AssertMatchingEnums.
https://bugs.webkit.org/show_bug.cgi?id=72895

Reviewed by Chris Fleizach.

Source/WebKit/chromium:

* public/WebAccessibilityNotification.h:
* src/AssertMatchingEnums.cpp:
* src/ChromeClientImpl.cpp:
(WebKit::toWebAccessibilityNotification):

Tools:

* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::postAccessibilityNotification):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Remove incorrect render surface layer list asserts from compositor
enne@google.com [Mon, 21 Nov 2011 21:01:03 +0000 (21:01 +0000)]
[chromium] Remove incorrect render surface layer list asserts from compositor
https://bugs.webkit.org/show_bug.cgi?id=72744

Reviewed by James Robinson.

These asserts are incorrect, because it's valid for the default render
surface to be created but to have a root layer that doesn't draw. It
won't get added to the single render surface and it'll have an empty
layer list.

Test: compositor_unittests

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed WinCE build fix after r100874.
andreas.kling@nokia.com [Mon, 21 Nov 2011 20:40:02 +0000 (20:40 +0000)]
Unreviewed WinCE build fix after r100874.

* WebCoreSupport/EditorClientWinCE.h:
* WebCoreSupport/EditorClientWinCE.cpp:
(WebKit::EditorClientWinCE::respondToChangedSelection):

    Add WebCore::Frame* parameter to respondToChangedSelection().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline font-face-opentype.html on cr-mac-leopard.
adamk@chromium.org [Mon, 21 Nov 2011 20:36:01 +0000 (20:36 +0000)]
Rebaseline font-face-opentype.html on cr-mac-leopard.

Unreviewed gardening.

* platform/chromium-mac-leopard/fast/css/font-face-opentype-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/css/font-face-opentype-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/css/font-face-opentype-expected.png.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening.
senorblanco@chromium.org [Mon, 21 Nov 2011 20:34:29 +0000 (20:34 +0000)]
Unreviewed gardening.

Updated baselines for two SVG tests.  These tests have been passing for a while, but the expectations were either stale or completely wrong.

* platform/chromium-cg-mac-leopard/svg/custom/use-elementInstance-event-target-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/W3C-SVG-1.1/struct-image-02-b-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/custom/use-elementInstance-event-target-expected.png: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-02-b-expected.png: Added.
* platform/chromium-mac-leopard/svg/custom/use-elementInstance-event-target-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/struct-image-02-b-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/use-elementInstance-event-target-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/struct-image-02-b-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening, broaden expecations for inspector test.
adamk@chromium.org [Mon, 21 Nov 2011 20:24:30 +0000 (20:24 +0000)]
Unreviewed gardening, broaden expecations for inspector test.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoLayout Test http/tests/media/video-served-as-text.html is flaky on cr-win
adamk@chromium.org [Mon, 21 Nov 2011 20:05:33 +0000 (20:05 +0000)]
Layout Test http/tests/media/video-served-as-text.html is flaky on cr-win
https://bugs.webkit.org/show_bug.cgi?id=72904

Unreviewed gardening, marking test as PASS TEXT.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Layout Test compositing/geometry/clipped-video-controller.html is flaky...
adamk@chromium.org [Mon, 21 Nov 2011 19:38:18 +0000 (19:38 +0000)]
[chromium] Layout Test compositing/geometry/clipped-video-controller.html is flaky on Win/Linux
https://bugs.webkit.org/show_bug.cgi?id=72903

Unreviewed gardening.

* platform/chromium/test_expectations.txt: Mark as PASS TEXT

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd GYP-generated WTF.xcodeproj to .gitignore after r100851.
adamk@chromium.org [Mon, 21 Nov 2011 19:22:02 +0000 (19:22 +0000)]
Add GYP-generated WTF.xcodeproj to .gitignore after r100851.

* .gitignore:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoLayout Test perf/array-push-pop.html is slow
adamk@chromium.org [Mon, 21 Nov 2011 19:16:19 +0000 (19:16 +0000)]
Layout Test perf/array-push-pop.html is slow
https://bugs.webkit.org/show_bug.cgi?id=72901

Mark test as SLOW PASS.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, run-gtk-tests temporary workaround after r98500.
philn@webkit.org [Mon, 21 Nov 2011 19:09:58 +0000 (19:09 +0000)]
Unreviewed, run-gtk-tests temporary workaround after r98500.

* Scripts/run-gtk-tests: Try to find the build directory like in
build-gtkdoc, until webkit-build-directory --configuration gets fixed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoInspector tests flakily crashing on Linux dbg canary
steveblock@google.com [Mon, 21 Nov 2011 19:02:40 +0000 (19:02 +0000)]
Inspector tests flakily crashing on Linux dbg canary
https://bugs.webkit.org/show_bug.cgi?id=72651

Add TIMEOUT expectation for
inspector/styles/styles-disable-then-change.html.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse canplay instead of canplaythrough in http/tests/media to prevent timeout
vrk@chromium.org [Mon, 21 Nov 2011 18:59:54 +0000 (18:59 +0000)]
Use canplay instead of canplaythrough in http/tests/media to prevent timeout
https://bugs.webkit.org/show_bug.cgi?id=72758

Reviewed by Eric Carlson.

* http/tests/media/video-cookie-expected.txt:
* http/tests/media/video-cookie.html:
* http/tests/media/video-referer-expected.txt:
* http/tests/media/video-referer.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoStyleSheet: Move completeURL() to CSSStyleSheet.
commit-queue@webkit.org [Mon, 21 Nov 2011 18:46:18 +0000 (18:46 +0000)]
StyleSheet: Move completeURL() to CSSStyleSheet.
<http://webkit.org/b/72888>

Patch by Andreas Kling <kling@webkit.org> on 2011-11-21
Reviewed by Antti Koivisto.

Since completeURL() is only used on CSSStyleSheets, move it there (and make
it non-virtual) to make StyleSheet a little leaner.

* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::completeURL):
* css/CSSStyleSheet.h:
* css/StyleSheet.cpp:
* css/StyleSheet.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Fix image translation calculations.
kevino@webkit.org [Mon, 21 Nov 2011 18:40:48 +0000 (18:40 +0000)]
[wx] Fix image translation calculations.
https://bugs.webkit.org/show_bug.cgi?id=72892

Reviewed by Kevin Ollivier.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd wxWebKit APIs for controlling WebKit caching behavior.
kevino@webkit.org [Mon, 21 Nov 2011 18:35:09 +0000 (18:35 +0000)]
Add wxWebKit APIs for controlling WebKit caching behavior.
https://bugs.webkit.org/show_bug.cgi?id=72891

Reviewed by Kevin Ollivier.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd wxWebKit API for retrieving frame and page URLs.
kevino@webkit.org [Mon, 21 Nov 2011 18:31:48 +0000 (18:31 +0000)]
Add wxWebKit API for retrieving frame and page URLs.
https://bugs.webkit.org/show_bug.cgi?id=72890

Reviewed by Kevin Ollivier.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agocopyright comment style to C from C++ for gamepad module
commit-queue@webkit.org [Mon, 21 Nov 2011 18:17:43 +0000 (18:17 +0000)]
copyright comment style to C from C++ for gamepad module
https://bugs.webkit.org/show_bug.cgi?id=72894

Patch by Scott Graham <scottmg@chromium.org> on 2011-11-21
Reviewed by Sam Weinig.

Just changes comment format, no code/test changes.

* Modules/gamepad/Gamepad.cpp:
* Modules/gamepad/Gamepad.h:
* Modules/gamepad/Gamepad.idl:
* Modules/gamepad/GamepadList.cpp:
* Modules/gamepad/GamepadList.h:
* Modules/gamepad/GamepadList.idl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoConsolidate the many copies of Ahem in our tests
commit-queue@webkit.org [Mon, 21 Nov 2011 17:55:07 +0000 (17:55 +0000)]
Consolidate the many copies of Ahem in our tests
https://bugs.webkit.org/show_bug.cgi?id=72503

Patch by Philip Rogers <pdr@google.com> on 2011-11-21
Reviewed by Andreas Kling.

* css3/flexbox/flex-align-vertical-writing-mode.html:
* css3/flexbox/flex-align.html:
* fast/css/custom-font-xheight.html:
* fast/css/font-face-download-error.html:
* fast/css/font-face-in-shadow-DOM.html-disabled:
* fast/css/font-face-multiple-faces.html:
* fast/css/font-face-multiple-families.html:
* fast/css/font-face-opentype.html:
* fast/css/font-face-remote.html:
* fast/css/font-face-repeated-url.html:
* fast/css/font-face-unicode-range.html:
* fast/css/font-face-unused-source-loaded.html:
* fast/css/font-face-woff.html:
* fast/css/font-face-zero-hash-key.html:
* fast/css/resources/Ahem.otf: Removed.
* fast/css/resources/Ahem.ttf: Removed.
* fast/css/resources/Ahem.woff: Removed.
* inspector/audits/resources/Ahem.ttf: Removed.
* inspector/extensions/extensions-network-expected.txt:
* inspector/extensions/extensions-network.html:
* inspector/extensions/resources/Ahem.ttf: Removed.
* platform/gtk/fonts/font-face-with-complex-text.html:
* platform/gtk/fonts/resources/Ahem.ttf: Removed.
* platform/gtk/fonts/synthetic-oblique-positioning.html:
* resources/Ahem.otf: Added.
* resources/Ahem.woff: Added.
* webarchive/resources/Ahem.ttf: Removed.
* webarchive/test-css-url-resources-in-stylesheets-expected.webarchive:
* webarchive/test-css-url-resources-in-stylesheets.html:
* webarchive/test-css-url-resources-inline-styles-expected.webarchive:
* webarchive/test-css-url-resources-inline-styles.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-11-21 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Mon, 21 Nov 2011 17:50:32 +0000 (17:50 +0000)]
2011-11-21  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: unskip inspector test on chromium.
        https://bugs.webkit.org/show_bug.cgi?id=72887

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-11-21 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Mon, 21 Nov 2011 17:43:08 +0000 (17:43 +0000)]
2011-11-21  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: unskip inspector tests on Qt
        https://bugs.webkit.org/show_bug.cgi?id=70414
        https://bugs.webkit.org/show_bug.cgi?id=70905
        https://bugs.webkit.org/show_bug.cgi?id=72493

        * platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement a setter for UnifiedTextCheckerEnabled.
commit-queue@webkit.org [Mon, 21 Nov 2011 17:40:22 +0000 (17:40 +0000)]
Implement a setter for UnifiedTextCheckerEnabled.
https://bugs.webkit.org/show_bug.cgi?id=72872

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-11-21
Reviewed by Darin Fisher.

* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setUnifiedTextCheckerEnabled): Added.
* src/WebSettingsImpl.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-11-21 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Mon, 21 Nov 2011 17:30:52 +0000 (17:30 +0000)]
2011-11-21  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: unflake inspector test.

        * inspector/extensions/extensions-events.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJSC/CSSOM: Merge root() for style declaration objects.
commit-queue@webkit.org [Mon, 21 Nov 2011 17:24:35 +0000 (17:24 +0000)]
JSC/CSSOM: Merge root() for style declaration objects.
<http://webkit.org/b/72881>

Patch by Andreas Kling <kling@webkit.org> on 2011-11-21
Reviewed by Antti Koivisto.

Fold root(CSSMutableStyleDeclaration*) into root(CSSStyleDeclaration*),
removing a duplicated chunk and making it a little easier on the eyes.

* bindings/js/JSDOMBinding.h:
(WebCore::root):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoInspector tests flakily crashing on Linux dbg canary
steveblock@google.com [Mon, 21 Nov 2011 17:18:09 +0000 (17:18 +0000)]
Inspector tests flakily crashing on Linux dbg canary
https://bugs.webkit.org/show_bug.cgi?id=72651

Add TIMEOUT expectations for
inspector/styles/styles-change-node-while-editing.html and
inspector/styles/styles-disable-inherited.html.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Implement loadHtml API for QQuickWebView
jesus@webkit.org [Mon, 21 Nov 2011 17:15:52 +0000 (17:15 +0000)]
[Qt][WK2] Implement loadHtml API for QQuickWebView
https://bugs.webkit.org/show_bug.cgi?id=72161

Reviewed by Simon Hausmann.

Implement QQuickWebView::loadHtml that calls QtWebPageProxy::loadHTMLString.
This function will use WKPageLoadHTMLString in order to load HTML from a given string.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebView::loadHtml):
* UIProcess/API/qt/qquickwebview.h:
* UIProcess/API/qt/tests/qmltests/WebView/tst_loadHtml.qml: Added.
* UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_loadHtml.qml: Added.
* UIProcess/API/qt/tests/qmltests/qmltests.pro:
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::loadHTMLString):
* UIProcess/qt/QtWebPageProxy.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2][Qt] Move Accelerated Composite animations to UIProcess
igor.oliveira@openbossa.org [Mon, 21 Nov 2011 17:03:06 +0000 (17:03 +0000)]
[WK2][Qt] Move Accelerated Composite animations to UIProcess

Source/WebCore:

Add helper method to synchronize animations in TextureMapper.

Reviewed by Noam Rosenthal

* platform/graphics/texmap/TextureMapperNode.cpp:
(WebCore::TextureMapperNode::syncAnimationsRecursively):
* platform/graphics/texmap/TextureMapperNode.h:

Source/WebKit2:

Currently, all the accelerated compositing animations are applied in WebProcess and
for each frame generated, WebProcess needs to sync with UIProcess.

This patch moves the accelerated compositing animations to UIProcess reducing the
amount of synchronization messages between WebProcess and UIProcess, this is done
sending animations information to UIProcess.

Reviewed by Noam Rosenthal

* Shared/WebCoreArgumentCoders.cpp:
(CoreIPC::::encode):
(CoreIPC::::decode):

Encode/Decode RefPtr<Animation> instead of Animation class. This facilitates
the data serialization.

* Shared/WebCoreArgumentCoders.h:
* Shared/WebLayerTreeInfo.cpp:
(WebKit::WebLayerInfo::encode):
(WebKit::WebLayerInfo::decode):
(WebKit::WebLayerAnimation::encode):
(WebKit::WebLayerAnimation::decode):

Create WebLayerAnimation struct, it is used to send animation information
to UIProcess.

* Shared/WebLayerTreeInfo.h:
(WebKit::WebLayerAnimation::WebLayerAnimation):
* UIProcess/LayerTreeHostProxy.h:
* UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeHostProxy::LayerTreeHostProxy):
(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):
(WebKit::LayerTreeHostProxy::didFireViewportUpdateTimer):
(WebKit::LayerTreeHostProxy::syncLayerParameters):
* WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::addAnimation):
(WebCore::WebGraphicsLayer::pauseAnimation):
(WebCore::WebGraphicsLayer::removeAnimation):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed Mac gardening, rebaselining MediaController failures after r100159.
andreas.kling@nokia.com [Mon, 21 Nov 2011 16:56:24 +0000 (16:56 +0000)]
Unreviewed Mac gardening, rebaselining MediaController failures after r100159.

* fast/dom/constructed-objects-prototypes-expected.txt:
* platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/mac/fast/dom/prototype-inheritance-2-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100921 268f45cc-cd09-0410-ab3c-d52691b4dbfc