WebKit.git
11 years ago2010-02-05 Simon Hausmann <simon.hausmann@nokia.com>
eric@webkit.org [Fri, 5 Feb 2010 15:09:17 +0000 (15:09 +0000)]
2010-02-05  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Tor Arne Vestbø.

        Add .gitattributes file to tell git about files with Windows linefeeds
        https://bugs.webkit.org/show_bug.cgi?id=34645

        On Windows git defaults to "true" for core.autocrlf, meaning all text
        files in the working directory are converted from CRLF to LF on checkin
        time. Some files present in the repository have been checked in with
        CRLF linefeeds and git should not try to convert them. The added
        .gitattributes file tells git to not do any CRLF conversion.

        * .gitattributes: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Build break in QtWebkit on Symbian
hausmann@webkit.org [Fri, 5 Feb 2010 14:10:08 +0000 (14:10 +0000)]
[Qt] Build break in QtWebkit on Symbian
https://bugs.webkit.org/show_bug.cgi?id=34597

Patch by Siddharth Mathur <siddharth.mathur@nokia.com> on 2010-02-05
Reviewed by Ariya Hidayat.

* plugins/PluginView.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-05 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 5 Feb 2010 14:08:31 +0000 (14:08 +0000)]
2010-02-05  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        - Use SerializedScriptValue for passing data between injected script and
        inspector frontend.
        - Remove custom JSON implementation from the instpector utility script.
        - Make sure that only objects created in the same ScriptState can be values
        of ScriptObject/Array properties and arguments to ScriptFunctionCall. We don't
        want ScriptObjects to leak between contexts.
        - Use ScriptState of the 'this' object in ScriptFunctionCall instead of passing
        it as additional parameter.

        https://bugs.webkit.org/show_bug.cgi?id=33592

        * bindings/js/JSInjectedScriptHostCustom.cpp:
        (WebCore::JSInjectedScriptHost::reportDidDispatchOnInjectedScript):
        * bindings/js/ScriptArray.cpp:
        (WebCore::ScriptArray::set):
        * bindings/js/ScriptFunctionCall.cpp:
        (WebCore::ScriptFunctionCall::ScriptFunctionCall):
        (WebCore::ScriptFunctionCall::appendArgument):
        * bindings/js/ScriptFunctionCall.h:
        * bindings/js/ScriptObject.cpp:
        (WebCore::ScriptObject::set):
        * bindings/js/ScriptValue.cpp:
        (WebCore::ScriptValue::serialize):
        (WebCore::ScriptValue::deserialize):
        * bindings/js/ScriptValue.h:
        * bindings/v8/ScriptArray.cpp:
        (WebCore::ScriptArray::set):
        * bindings/v8/ScriptFunctionCall.cpp:
        (WebCore::ScriptFunctionCall::ScriptFunctionCall):
        (WebCore::ScriptFunctionCall::appendArgument):
        * bindings/v8/ScriptFunctionCall.h:
        * bindings/v8/ScriptObject.cpp:
        (WebCore::ScriptObject::set):
        * bindings/v8/ScriptState.h:
        * bindings/v8/ScriptValue.cpp:
        (WebCore::ScriptValue::serialize):
        (WebCore::deserialize):
        * bindings/v8/ScriptValue.h:
        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
        (WebCore::V8InjectedScriptHost::reportDidDispatchOnInjectedScriptCallback):
        * inspector/InjectedScript.cpp:
        (WebCore::InjectedScript::dispatch):
        (WebCore::InjectedScript::callFrames):
        (WebCore::InjectedScript::wrapForConsole):
        (WebCore::InjectedScript::releaseWrapperObjectGroup):
        * inspector/InjectedScript.h:
        * inspector/InjectedScriptHost.cpp:
        (WebCore::InjectedScriptHost::reportDidDispatchOnInjectedScript):
        * inspector/InjectedScriptHost.h:
        * inspector/InjectedScriptHost.idl:
        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::dispatchOnInjectedScript):
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::setFrontendProxyObject):
        (WebCore::InspectorController::didPause):
        (WebCore::InspectorController::didEvaluateForTestInFrontend):
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::InspectorFrontend):
        (WebCore::InspectorFrontend::newScriptArray):
        (WebCore::InspectorFrontend::newScriptObject):
        (WebCore::InspectorFrontend::populateFrontendSettings):
        (WebCore::InspectorFrontend::updateConsoleMessageExpiredCount):
        (WebCore::InspectorFrontend::addConsoleMessage):
        (WebCore::InspectorFrontend::updateConsoleMessageRepeatCount):
        (WebCore::InspectorFrontend::updateResource):
        (WebCore::InspectorFrontend::removeResource):
        (WebCore::InspectorFrontend::didGetResourceContent):
        (WebCore::InspectorFrontend::updateFocusedNode):
        (WebCore::InspectorFrontend::setAttachedWindow):
        (WebCore::InspectorFrontend::addRecordToTimeline):
        (WebCore::InspectorFrontend::parsedScriptSource):
        (WebCore::InspectorFrontend::failedToParseScriptSource):
        (WebCore::InspectorFrontend::addProfileHeader):
        (WebCore::InspectorFrontend::setRecordingProfile):
        (WebCore::InspectorFrontend::didGetProfileHeaders):
        (WebCore::InspectorFrontend::didGetProfile):
        (WebCore::InspectorFrontend::pausedScript):
        (WebCore::InspectorFrontend::setDocument):
        (WebCore::InspectorFrontend::setDetachedRoot):
        (WebCore::InspectorFrontend::setChildNodes):
        (WebCore::InspectorFrontend::childNodeCountUpdated):
        (WebCore::InspectorFrontend::childNodeInserted):
        (WebCore::InspectorFrontend::childNodeRemoved):
        (WebCore::InspectorFrontend::attributesUpdated):
        (WebCore::InspectorFrontend::didRemoveNode):
        (WebCore::InspectorFrontend::didGetChildNodes):
        (WebCore::InspectorFrontend::didApplyDomChange):
        (WebCore::InspectorFrontend::didGetEventListenersForNode):
        (WebCore::InspectorFrontend::didGetCookies):
        (WebCore::InspectorFrontend::didDispatchOnInjectedScript):
        (WebCore::InspectorFrontend::addDatabase):
        (WebCore::InspectorFrontend::selectDatabase):
        (WebCore::InspectorFrontend::didGetDatabaseTableNames):
        (WebCore::InspectorFrontend::addDOMStorage):
        (WebCore::InspectorFrontend::selectDOMStorage):
        (WebCore::InspectorFrontend::didGetDOMStorageEntries):
        (WebCore::InspectorFrontend::didSetDOMStorageItem):
        (WebCore::InspectorFrontend::didRemoveDOMStorageItem):
        (WebCore::InspectorFrontend::updateDOMStorage):
        (WebCore::InspectorFrontend::addNodesToSearchResult):
        (WebCore::InspectorFrontend::contextMenuItemSelected):
        (WebCore::InspectorFrontend::evaluateForTestInFrontend):
        (WebCore::InspectorFrontend::callSimpleFunction):
        * inspector/InspectorFrontend.h:
        (WebCore::InspectorFrontend::scriptState):
        * inspector/front-end/InjectedScript.js:
        (injectedScriptConstructor):
        (injectedScriptConstructor.):
        * inspector/front-end/InjectedScriptAccess.js:
        (InjectedScriptAccess._installHandler.InjectedScriptAccess.prototype.methodName.myCallback):
        (InjectedScriptAccess._installHandler.InjectedScriptAccess.prototype.methodName):
        (InjectedScriptAccess._installHandler):
        * inspector/front-end/inspector.js:
        (WebInspector.pausedScript):
        (WebInspector.addConsoleMessage):

2010-02-05  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Remove unused inmport of ScriptFunctionCall.h

        https://bugs.webkit.org/show_bug.cgi?id=33592

        * Api/qwebelement.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Generate convenience headers (QWebView, etc) using qmake
vestbo@webkit.org [Fri, 5 Feb 2010 13:23:15 +0000 (13:23 +0000)]
[Qt] Generate convenience headers (QWebView, etc) using qmake

Reviewed by Simon Hausmann.

In Qt this is done using syncqt, but we use a pro-file instead
that generates makefile-rules for each of the extra headers.

These extra headers are installed alongside the normal headers.

WebCore:

* WebCore.pro: Use headers.pri based on DerivedSources instead
of the one previously checked in in the source tree.

WebKit/qt:

* Api/DerivedSources.pro: Added. List of headers + pro file magic
* Api/headers.pri: Removed, list of headers is now in the above file

WebKitTools:

* Scripts/webkitdirs.pm: Run qmake and make on new API-DerivedSources

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoDon't call CRASH() in fastMalloc and fastCalloc when the requested memory size is 0
zoltan@webkit.org [Fri, 5 Feb 2010 12:27:35 +0000 (12:27 +0000)]
Don't call CRASH() in fastMalloc and fastCalloc when the requested memory size is 0
https://bugs.webkit.org/show_bug.cgi?id=34569

Patch by Kwang Yul Seo <skyul@company100.net> on 2010-02-05
Reviewed by Alexey Proskuryakov.

With USE_SYSTEM_MALLOC=1, fastMalloc and fastCalloc call CRASH()
if the return value of malloc and calloc is 0.

However, these functions can return 0 when the request size is 0.
Libc manual says, "If size is 0, then malloc() returns either NULL,
or a unique pointer value that can later be successfully passed to free()."
Though malloc returns a unique pointer in most systems,
0 can be returned in some systems. For instance, BREW's MALLOC returns 0
when size is 0.

If malloc or calloc returns 0 due to allocation size, increase the size
to 1 and try again.

* wtf/FastMalloc.cpp:
(WTF::fastMalloc):
(WTF::fastCalloc):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-05 Andras Becsi <abecsi@webkit.org>
abecsi@webkit.org [Fri, 5 Feb 2010 12:20:15 +0000 (12:20 +0000)]
2010-02-05  Andras Becsi  <abecsi@webkit.org>

        Unreviewed typo fix.

        Fix wrong whitespace alignment introduced in r54342.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-05 Mikhail Naganov <mnaganov@chromium.org>
eric@webkit.org [Fri, 5 Feb 2010 12:05:37 +0000 (12:05 +0000)]
2010-02-05  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Enable JAVASCRIPT_DEBUGGER in chromium port.

        https://bugs.webkit.org/show_bug.cgi?id=34638

        * page/Console.cpp:
        * page/Console.h:
        * page/Console.idl:
2010-02-05  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Enable JAVASCRIPT_DEBUGGER in chromium port.

        https://bugs.webkit.org/show_bug.cgi?id=34638

        * features.gypi:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubberstamped by Oliver Hunt.
kenneth@webkit.org [Fri, 5 Feb 2010 11:45:55 +0000 (11:45 +0000)]
Rubberstamped by Oliver Hunt.

[Qt] Make it possible to choose whether the launcher should
use the traditional QWidget based QWebView or the newer
QGraphics based QGraphicsWebView on a QGraphicsView.

* QtLauncher/main.cpp:
(LauncherWindow::LauncherWindow):
(LauncherWindow::eventFilter):
(LauncherWindow::loadStarted):
(LauncherWindow::print):
(LauncherWindow::screenshot):
(LauncherWindow::setEditable):
(LauncherWindow::setupUI):
(main):
* QtLauncher/webview.cpp:
(WebViewGraphicsBased::WebViewGraphicsBased):
(WebViewGraphicsBased::resizeEvent):
(GraphicsWebView::mousePressEvent):
(GraphicsWebView::contextMenuEvent):
* QtLauncher/webview.h:
(WebViewTraditional::WebViewTraditional):
(GraphicsWebView::GraphicsWebView):
(WebViewGraphicsBased::setPage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-05 Pavel Feldman <pfeldman@chromium.org>
eric@webkit.org [Fri, 5 Feb 2010 10:50:42 +0000 (10:50 +0000)]
2010-02-05  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Tab width for javascript source is 8, should be 4

        https://bugs.webkit.org/show_bug.cgi?id=31248

        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame):
        * inspector/front-end/TextEditorModel.js:
        (WebInspector.TextEditorModel.prototype.set replaceTabsWithSpaces):
        (WebInspector.TextEditorModel.prototype._innerSetText):
        (WebInspector.TextEditorModel.prototype._replaceTabsIfNeeded):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-05 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Fri, 5 Feb 2010 09:37:37 +0000 (09:37 +0000)]
2010-02-05  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Alexey Proskuryakov.

        send() should return false, after frame that opened a WebSokcet is detached
        https://bugs.webkit.org/show_bug.cgi?id=34630

        * websocket/tests/send-after-close-on-unload-expected.txt: Added.
        * websocket/tests/send-after-close-on-unload.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-05 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 5 Feb 2010 09:23:06 +0000 (09:23 +0000)]
2010-02-05  Tony Chang  <tony@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=24872
        Add a test to make sure copying from a list and pasting into a list
        keeps the list at the same indention level rather than nesting.

        * editing/pasteboard/paste-list-002-expected.txt: Added.
        * editing/pasteboard/paste-list-002.html: Added.
2010-02-05  Tony Chang  <tony@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=24872
        When pasting a list into another list should not indent another level.
        If the cursor is at the beginning of the line, it should insert the
        list items before the current list item.  If the cursor is at the end
        of the line, it should insert the list items after the current list item.

        This matches Firefox and IE and makes the common activity of reordering a list
        work as expected.

        This also adds a small helper method (isListItem) to htmlediting.h.

        Test: editing/pasteboard/paste-list-002.html

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply):
        (WebCore::ReplaceSelectionCommand::insertAsListItems):
        * editing/ReplaceSelectionCommand.h:
        * editing/htmlediting.cpp:
        (WebCore::isListItem):
        (WebCore::appendedSublist):
        * editing/htmlediting.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Make 'make -f Makefile.DerivedSources qmake' work
vestbo@webkit.org [Fri, 5 Feb 2010 07:45:31 +0000 (07:45 +0000)]
[Qt] Make 'make -f Makefile.DerivedSources qmake' work

Reviewed by Lars Knoll.

Previously this target ended up generating a file named
Makefile.DerivedSources.DerivedSources, and so on.

* DerivedSources.pro:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubber-stamped by Dan Bernstein.
mrowe@apple.com [Fri, 5 Feb 2010 07:34:45 +0000 (07:34 +0000)]
Rubber-stamped by Dan Bernstein.

Fix the ability to #include <WebKit/DOMFile.h>.

* MigrateHeaders.make: Mark DOMBlob.h as a public header since the already-public DOMFile.h depends on it.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-04 Yaar Schnitman <yaar@chromium.org>
eric@webkit.org [Fri, 5 Feb 2010 07:18:10 +0000 (07:18 +0000)]
2010-02-04  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Darin Fisher.

        Upstreaming gtests from chromium: UniscribeHelper and TransparencyWin
        https://bugs.webkit.org/show_bug.cgi?id=34509

        Resubmit: The previous commit (r54333) was rolled back.

        * WebKit.gyp:
        * tests/TransparencyWinTest.cpp: Added.
        (WebCore::RECTToFloatRect):
        (WebCore::drawNativeRect):
        (WebCore::getPixelAt):
        (WebCore::clearTopLayerAlphaChannel):
        (WebCore::clearTopLayerAlphaPixel):
        (WebCore::operator<<):
        (WebCore::TEST):
        * tests/UniscribeHelperTest.cpp: Added.
        (WebCore::UniscribeTest::UniscribeTest):
        (WebCore::UniscribeTest::MakeFont):
        (WebCore::UniscribeTest::SetUp):
        (WebCore::UniscribeTest::TearDown):
        (TEST_F):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-04 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Fri, 5 Feb 2010 06:15:22 +0000 (06:15 +0000)]
2010-02-04  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Alexey Proskuryakov.

        should not crash when document opened websocket is unloaded
        https://bugs.webkit.org/show_bug.cgi?id=34562

        * websocket/tests/close-on-unload-and-force-gc-expected.txt: Added.
        * websocket/tests/close-on-unload-and-force-gc.html: Added.
        * websocket/tests/close-on-unload-reference-in-parent-expected.txt: Added.
        * websocket/tests/close-on-unload-reference-in-parent.html: Added.
        * websocket/tests/resources/close-on-unload-iframe-reference-in-parent.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix. Remove a symbol corresponding to an inline function from the linker export
mrowe@apple.com [Fri, 5 Feb 2010 06:13:23 +0000 (06:13 +0000)]
Build fix.  Remove a symbol corresponding to an inline function from the linker export
file to prevent a weak external failure.

Reviewed by Timothy Hatcher.

JavaScriptCore:

* JavaScriptCore.xcodeproj/project.pbxproj: Accommodate rename of script.

JavaScriptGlue:

* JavaScriptGlue.xcodeproj/project.pbxproj: Accommodate rename of script.

WebCore:

* WebCore.base.exp: Remove symbol.
* WebCore.xcodeproj/project.pbxproj: Accommodate rename of script.

WebKit:

* WebKit.xcodeproj/project.pbxproj: Accommodate rename of script.

WebKitTools:

* Scripts/check-for-weak-vtables-and-externals: Renamed from WebKitTools/Scripts/check-for-weak-vtables.
Teach the script how to detect weak external symbols so that these errors can be caught immediately
in the future.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-04 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Fri, 5 Feb 2010 05:59:44 +0000 (05:59 +0000)]
2010-02-04  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Shinichiro Hamaji.

        websocket/tests/close-on-unload.html failed on Mac Tiger
        https://bugs.webkit.org/show_bug.cgi?id=34563

        * platform/mac-tiger/Skipped: remove websocket/tests/close-on-unload*.html
        * websocket/tests/close-on-unload_wsh.py: use dict instead of set.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-04 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Fri, 5 Feb 2010 05:33:55 +0000 (05:33 +0000)]
2010-02-04  Daniel Bates  <dbates@webkit.org>

        [Qt] Unreviewed, build fix for Qt bot.

        * runtime/JSStringBuilder.h: Changed #include <X.h> notation #include "X.h".

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix: export a header.
ggaren@apple.com [Fri, 5 Feb 2010 03:53:36 +0000 (03:53 +0000)]
Build fix: export a header.

* JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix: Added a forwarding header.
ggaren@apple.com [Fri, 5 Feb 2010 03:47:54 +0000 (03:47 +0000)]
Build fix: Added a forwarding header.

* ForwardingHeaders/runtime/WeakGCPtr.h: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: REGRESSION (r52082): Missing event handlers on JQuery demo page (33383)
ggaren@apple.com [Fri, 5 Feb 2010 03:39:09 +0000 (03:39 +0000)]
WebCore: REGRESSION (r52082): Missing event handlers on JQuery demo page (33383)
https://bugs.webkit.org/show_bug.cgi?id=33383
<rdar://problem/7559449>

Reviewed by Alexey Proskuryakov and Darin Adler.

There were two bugs here:

1. A stale wrapper would invalidate a node's event listeners, even if
the node had a fresh wrapper keeping it alive.

The fix for this is for an event listener to keep a WeakGCPtr back-pointer
to the wrapper it expects to mark it. The wrapper destructor checks this
back-pointer, and only invalidates the event listener in the case of a match.

2. Conversely, a stale wrapper would not invalidate a node's event
listeners soon enough, if its destructor didn't have a chance to run
before an event fired on the node. (This can only happen in cases where
we've made some other error and failed to mark a wrapper that was circuitously
observable in the DOM. But we know we have edge case bugs like this, and
we don't want them to be crashes.)

The fix for this is to check the wrapper back-pointer before firing the
event listener. As long as the the wrapper back-pointer is not null,
it's safe to fire the listener.

* ForwardingHeaders/runtime/WeakGCPtr.h: Added. Appease build gods.

* bindings/js/JSAbstractWorkerCustom.cpp:
(WebCore::JSAbstractWorker::addEventListener):
(WebCore::JSAbstractWorker::removeEventListener):
* bindings/js/JSDOMApplicationCacheCustom.cpp:
(WebCore::JSDOMApplicationCache::addEventListener):
(WebCore::JSDOMApplicationCache::removeEventListener):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::markChildren):
(WebCore::JSDOMWindow::addEventListener):
(WebCore::JSDOMWindow::removeEventListener): Updated to pass a wrapper
to the JSEventListener constructor.

* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::JSEventListener):
(WebCore::JSEventListener::initializeJSFunction):
(WebCore::JSEventListener::invalidateJSFunction):
* bindings/js/JSEventListener.h:
(WebCore::JSEventListener::create):
(WebCore::JSEventListener::isolatedWorld):
(WebCore::JSEventListener::wrapper):
(WebCore::JSEventListener::setWrapper):
(WebCore::JSEventListener::jsFunction):
(WebCore::createJSAttributeEventListener): Implemented the back-pointer
described above. Refactored the jsFunction() accessor to return 0 if
the wrapper back-pointer is 0.

* bindings/js/JSEventSourceCustom.cpp:
(WebCore::JSEventSource::addEventListener):
(WebCore::JSEventSource::removeEventListener):
* bindings/js/JSLazyEventListener.cpp:
(WebCore::JSLazyEventListener::JSLazyEventListener):
(WebCore::JSLazyEventListener::initializeJSFunction):
* bindings/js/JSLazyEventListener.h:
(WebCore::JSLazyEventListener::create):
* bindings/js/JSMessagePortCustom.cpp:
(WebCore::JSMessagePort::markChildren):
(WebCore::JSMessagePort::addEventListener):
(WebCore::JSMessagePort::removeEventListener):
* bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::addEventListener):
(WebCore::JSNode::removeEventListener):
(WebCore::JSNode::markChildren):
* bindings/js/JSSVGElementInstanceCustom.cpp:
(WebCore::JSSVGElementInstance::addEventListener):
(WebCore::JSSVGElementInstance::removeEventListener):
* bindings/js/JSWebSocketCustom.cpp:
(WebCore::JSWebSocket::addEventListener):
(WebCore::JSWebSocket::removeEventListener):
* bindings/js/JSWorkerContextCustom.cpp:
(WebCore::JSWorkerContext::markChildren):
(WebCore::JSWorkerContext::addEventListener):
(WebCore::JSWorkerContext::removeEventListener):
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::markChildren):
(WebCore::JSXMLHttpRequest::addEventListener):
(WebCore::JSXMLHttpRequest::removeEventListener):
* bindings/js/JSXMLHttpRequestUploadCustom.cpp:
(WebCore::JSXMLHttpRequestUpload::markChildren):
(WebCore::JSXMLHttpRequestUpload::addEventListener):
(WebCore::JSXMLHttpRequestUpload::removeEventListener): Updated to pass a wrapper
to the JSEventListener constructor.

* bindings/js/ScriptEventListener.cpp:
(WebCore::createAttributeEventListener): Updated to pass a wrapper
to the JSEventListener constructor.
(WebCore::getEventListenerHandlerBody): Updated for the fact that jsFunction()
is no longer a virtual accessor on the EventHandler base class.

* bindings/scripts/CodeGeneratorJS.pm: Updated for the fact that jsFunction()
is no longer a virtual accessor on the EventHandler base class. Added a "JS"
to invalidateEventListeners and markEventListeners to clarify that these
actions are for JS event listeners only. Added a wrapper parameter to
invalidateEventListeners for the back-pointer check explained above.

* dom/EventListener.h:
(WebCore::EventListener::invalidateJSFunction): ditto

* dom/EventTarget.h:
(WebCore::EventTarget::markJSEventListeners):
(WebCore::EventTarget::invalidateJSEventListeners): ditto

LayoutTests: REGRESSION (r52082): Missing event handlers on JQuery demo page (33383)
https://bugs.webkit.org/show_bug.cgi?id=33383
<rdar://problem/7559449>

Reviewed by Alexey Proskuryakov and Darin Adler.

* fast/events/bogus-event-listener-invalidation-expected.txt: Added.
* fast/events/bogus-event-listener-invalidation.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoVersioning.
mrowe@apple.com [Fri, 5 Feb 2010 03:05:15 +0000 (03:05 +0000)]
Versioning.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoVersioning.
mrowe@apple.com [Fri, 5 Feb 2010 03:03:44 +0000 (03:03 +0000)]
Versioning.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-04 Tony Chang <tony@chromium.org>
eric@webkit.org [Fri, 5 Feb 2010 02:38:21 +0000 (02:38 +0000)]
2010-02-04  Tony Chang  <tony@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=25002
        When inserting a new paragraph, avoid nesting empty divs.  When
        pasting near the end of a paragraph, this prevents each paste
        command for getting nested one level deeper.

        Three paste tests have been rebaselined since this causes the pasted
        content to be outside the last div instead of inside.  E.g.,
        <div>foo<div>bar</div>[pasted content]</div> is now
        <div>foo<div>bar</div></div><div>[pasted content]</div>

        The new test verifies this behavior.

        * editing/inserting/paragraph-outside-nested-divs-expected.txt: Added.
        * editing/inserting/paragraph-outside-nested-divs.html: Added.
        * platform/mac/editing/pasteboard/paste-text-012-expected.txt:
        * platform/mac/editing/pasteboard/paste-text-013-expected.txt:
        * platform/mac/editing/pasteboard/paste-text-017-expected.txt:
2010-02-04  Tony Chang  <tony@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=25002
        When inserting a new paragraph, avoid nesting empty divs.  When
        pasting near the end of a paragraph, this prevents each paste
        command for getting nested one level deeper.

        Test: editing/inserting/paragraph-outside-nested-divs.html

        * editing/InsertParagraphSeparatorCommand.cpp:
        (WebCore::highestVisuallyEquivalentDiv):
        (WebCore::InsertParagraphSeparatorCommand::doApply):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd a JSStringBuilder class (similar-to, and derived-from StringBuilder) to
barraclough@apple.com [Fri, 5 Feb 2010 02:31:35 +0000 (02:31 +0000)]
Add a JSStringBuilder class (similar-to, and derived-from StringBuilder) to
construct JSStrings, throwing a JS exception should we run out of memory whilst
allocating storage for the string.

Reviewed by Oliver Hunt.

Similarly, add jsMakeNontrivialString methods to use in cases where previously
we were calling makeString & passing the result to jsNontrivialString.  Again,
these new methods throw if we hit an out of memory condition.

Move throwOutOfMemoryError into ExceptionHelpers, to make it more widely available.

* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):
* runtime/DateConstructor.cpp:
(JSC::callDate):
* runtime/DatePrototype.cpp:
(JSC::dateProtoFuncToString):
(JSC::dateProtoFuncToUTCString):
(JSC::dateProtoFuncToGMTString):
* runtime/ErrorPrototype.cpp:
(JSC::errorProtoFuncToString):
* runtime/ExceptionHelpers.cpp:
(JSC::throwOutOfMemoryError):
* runtime/ExceptionHelpers.h:
* runtime/JSStringBuilder.h: Added.
(JSC::JSStringBuilder::releaseJSString):
(JSC::jsMakeNontrivialString):
* runtime/NumberPrototype.cpp:
(JSC::numberProtoFuncToPrecision):
* runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncToString):
* runtime/Operations.cpp:
* runtime/Operations.h:
* runtime/RegExpPrototype.cpp:
(JSC::regExpProtoFuncToString):
* runtime/StringBuilder.h:
(JSC::StringBuilder::append):
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncBig):
(JSC::stringProtoFuncSmall):
(JSC::stringProtoFuncBlink):
(JSC::stringProtoFuncBold):
(JSC::stringProtoFuncFixed):
(JSC::stringProtoFuncItalics):
(JSC::stringProtoFuncStrike):
(JSC::stringProtoFuncSub):
(JSC::stringProtoFuncSup):
(JSC::stringProtoFuncFontcolor):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncAnchor):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: 1. Fix a bug in SQLiteTransaction: do not assume that COMMIT always
dumi@chromium.org [Fri, 5 Feb 2010 02:09:21 +0000 (02:09 +0000)]
WebCore: 1. Fix a bug in SQLiteTransaction: do not assume that COMMIT always
succeeds.
2. Jump straight to the transaction error callback when a
statement fails in a way that makes sqlite automatically rollback
the transaction.
3. Fix the code that handles the "quota reached" failure, as it is
one of the failures that lead to an automatic transaction
rollback.

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=34280

* platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::isAutoCommitOn):
* platform/sql/SQLiteDatabase.h:
* platform/sql/SQLiteTransaction.cpp:
(WebCore::SQLiteTransaction::begin):
(WebCore::SQLiteTransaction::commit):
(WebCore::SQLiteTransaction::rollback):
(WebCore::SQLiteTransaction::transactionWasRolledBackBySqlite):
* platform/sql/SQLiteTransaction.h:
* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::SQLTransaction):
(WebCore::SQLTransaction::runStatements):
(WebCore::SQLTransaction::runCurrentStatement):
(WebCore::SQLTransaction::handleCurrentStatementError):
(WebCore::SQLTransaction::deliverQuotaIncreaseCallback):

LayoutTests: 1. Enhance quota-tracking.html: if sqlite automatically rolls back
a transaction because of a statement failure, make sure the rest
of the statements in the transaction are not executed.
2. Fix the expectations for quota-tracking.html. Sqlite cannot
recover from reaching a DB's max size.

Reviewed by Eric Seidel.

* storage/quota-tracking-expected.txt:
* storage/quota-tracking.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNot reviewed, rollback.
pkasting@chromium.org [Fri, 5 Feb 2010 01:50:59 +0000 (01:50 +0000)]
Not reviewed, rollback.

Rollback r54387, it doesn't fix builds and Chromium doesn't want this behavior.

* platform/chromium/ScrollbarThemeChromiumMac.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWindows build fix.
sfalken@apple.com [Fri, 5 Feb 2010 01:41:34 +0000 (01:41 +0000)]
Windows build fix.

* wtf/MathExtras.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-04 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 5 Feb 2010 01:01:45 +0000 (01:01 +0000)]
2010-02-04  Darin Adler  <darin@apple.com>

        Reviewed by David Levin.

        Make MathExtras.h compatible with <cmath>
        https://bugs.webkit.org/show_bug.cgi?id=34618

        * wtf/MathExtras.h: Include <cmath> instead of <math.h>.
        Use "using" as we do elsewhere in WTF for the four functions from <cmath>
        we want to use without the prefix. Later we could consider making the std
        explicit at call sites instead.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-04 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Fri, 5 Feb 2010 00:52:25 +0000 (00:52 +0000)]
2010-02-04  Stephen White  <senorblanco@chromium.org>

        Unreviewed, build fix.

        Fix for Chromium/Mac after palindromic scrollbar change (54345).

        Covered by many layout tests.

        * platform/chromium/ScrollbarThemeChromiumMac.h:
        (WebCore::ScrollbarThemeChromiumMac::maxOverlapBetweenPages):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-04 Clemmitt Sigler <cmsigler@gmail.com>
eric@webkit.org [Fri, 5 Feb 2010 00:35:57 +0000 (00:35 +0000)]
2010-02-04  Clemmitt Sigler  <cmsigler@gmail.com>

        Reviewed by David Levin.

        WebKitGTK doesn't build GtkLauncher when --enable-mathml is specified.
        Updated WebCore/GNUmakefile.am to include needed files in build.

        https://bugs.webkit.org/show_bug.cgi?id=34387

        No new tests.

        * GNUmakefile.am:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-04 Stephan Aßmus <superstippi@gmx.de>
eric@webkit.org [Fri, 5 Feb 2010 00:19:45 +0000 (00:19 +0000)]
2010-02-04  Stephan Aßmus  <superstippi@gmx.de>

        Reviewed by David Levin.

        Misc coding style fixes in Haiku port code.
        https://bugs.webkit.org/show_bug.cgi?id=34527

        No tests needed.

        * platform/haiku/ContextMenuItemHaiku.cpp: Trailing white space, NULL -> 0
        * platform/haiku/DragImageHaiku.cpp: Trailing white space.
        * platform/haiku/FileChooserHaiku.cpp: Sorted headers.
        * platform/haiku/LocalizedStringsHaiku.cpp: Needed to include NotImplemented.h

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed typo fix for r54379.
ossy@webkit.org [Thu, 4 Feb 2010 23:50:05 +0000 (23:50 +0000)]
Unreviewed typo fix for r54379.

* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-04 Drew Wilson <atwilson@chromium.org>
eric@webkit.org [Thu, 4 Feb 2010 23:43:20 +0000 (23:43 +0000)]
2010-02-04  Drew Wilson  <atwilson@chromium.org>

        Reviewed by David Levin.

        WorkerContext.close() does not work in the chromium port
        https://bugs.webkit.org/show_bug.cgi?id=34551

        Test: Adding new downstream test.

        * src/WebWorkerBase.cpp:
        (WebKit::WebWorkerBase::workerContextClosedTask):
        Now shuts down the worker thread when WorkerContext::close() is invoked.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoediting/pasteboard/drop-inputtext-acquires-style.html
ossy@webkit.org [Thu, 4 Feb 2010 23:36:32 +0000 (23:36 +0000)]
editing/pasteboard/drop-inputtext-acquires-style.html
introduced in r54368 skipped because of missing DnD support.

* platform/gtk/Skipped:
* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-04 Christian Dywan <christian@twotoasts.de>
christian@webkit.org [Thu, 4 Feb 2010 23:33:55 +0000 (23:33 +0000)]
2010-02-04  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Add and cleanup return values of signals in view and frame
        https://bugs.webkit.org/show_bug.cgi?id=33484

        Add missing and cleanup return values of web frame and web view signals.

        * webkit/webkitwebframe.cpp:
        (webkit_web_frame_class_init):
        * webkit/webkitwebview.cpp:
        (DNDContentsRequest::webkit_web_view_class_init):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFixed crash on QT introduced with the fix for
enrica@apple.com [Thu, 4 Feb 2010 23:30:35 +0000 (23:30 +0000)]
Fixed crash on QT introduced with the fix for
https://bugs.webkit.org/show_bug.cgi?id=34609

Reviewed by Csaba Osztrogonac.

The test has been added with the original patch.

* platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::writePlainText): Added missing allocation of m_writeData.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agohttps://bugs.webkit.org/show_bug.cgi?id=34612 " MSAA: accSelect returns error
alice.liu@apple.com [Thu, 4 Feb 2010 23:29:19 +0000 (23:29 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=34612 " MSAA: accSelect returns error
codes for most elements that arent listbox or menupopup related"
<rdar://problem/7436861>

Reviewed by Jon Honeycutt.

* AccessibleBase.cpp:
(AccessibleBase::accSelect):
- Stop sending E_INVALIDARG for elements that request TAKE_SELECTION that
  aren't beneath listboxes or menupopups.  This was too restrictive since
  any element can be selectable.
- Correct the misinterpretation of MSDN's stipulation of situations involving
  adding, removing, and extending selection on single-select elements

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-04 Christian Dywan <christian@twotasts.de>
christian@webkit.org [Thu, 4 Feb 2010 22:51:12 +0000 (22:51 +0000)]
2010-02-04  Christian Dywan  <christian@twotasts.de>

        Reviewed by Xan Lopez.

        Require either libsoup 2.28.2 or 2.29.90.

        * configure.ac:

2010-02-04  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Xan Lopez.

        Conditionalize third party cookie policy for libsoup 2.29.90.

        * platform/network/soup/CookieJarSoup.cpp:
        (WebCore::setCookies):
        * platform/network/soup/DNSSoup.cpp:
        (WebCore::prefetchDNS):
        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::restartedCallback):
        (WebCore::startHttp):
        * platform/network/soup/ResourceRequestSoup.cpp:
        (WebCore::ResourceRequest::toSoupMessage):
        (WebCore::ResourceRequest::updateFromSoupMessage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-04 Christian Dywan <christian@twotoasts.de>
christian@webkit.org [Thu, 4 Feb 2010 22:50:59 +0000 (22:50 +0000)]
2010-02-04  Christian Dywan  <christian@twotoasts.de>

        Rubber-stamped by Gustavo Noronha Silva.

        Add ENABLE(VIDEO) guards around freeOwnedGPtr<GstElement> implementation.

        * platform/gtk/GOwnPtrGtk.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoCorrect a mistake in ChangeLog entry.
ap@apple.com [Thu, 4 Feb 2010 22:35:08 +0000 (22:35 +0000)]
Correct a mistake in ChangeLog entry.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@apple.com [Thu, 4 Feb 2010 22:12:56 +0000 (22:12 +0000)]
    Reviewed by Darin Adler.

        Assertion failure in CheckedRadioButtons::removeButton when using jQuery 1.4.1
        https://bugs.webkit.org/show_bug.cgi?id=34520

        Test: fast/dom/HTMLInputElement/cloned-input-checked-state.html

        * dom/Element.cpp: (WebCore::Element::cloneElementWithoutChildren): Copy non-attribute
        properties before attributes. Otherwise, copying "checked" property would make the cloned
        node checked, unchecking original (they share a name, and are thus in the same radio group).
        We do want the original to be unchecked, but we also want to know its original state in
        HTMLInputElement::copyNonAttributeProperties().

        * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::copyNonAttributeProperties):
        Use setChecked instead of plain assignment to prevent m_checked getting out of sync with
        checkedRadioButtons. Also, copy field related to default checked state, so that m_checked
        won't be overridden when copying attributes.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[wx] Build fix after addition of Clipboard::writePlainText method.
kevino@webkit.org [Thu, 4 Feb 2010 22:12:02 +0000 (22:12 +0000)]
[wx] Build fix after addition of Clipboard::writePlainText method.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoProperly handle margin settings when printing Plugins in WinCairo.
bfulgham@webkit.org [Thu, 4 Feb 2010 22:10:24 +0000 (22:10 +0000)]
Properly handle margin settings when printing Plugins in WinCairo.
https://bugs.webkit.org/show_bug.cgi?id=34613

Reviewed by Adam Roben.

* WebFrame.cpp:
(WebFrame::spoolPage): Adjust the GraphicsContext passed to the
  paintContents method so that the World Transform is properly
  positioned to account for margin settings at the time that
  PluginViewWin.cpp processes the drawing operations.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUpdate auto-version.sh to better handle major version numbers with fewer than three...
mrowe@apple.com [Thu, 4 Feb 2010 22:07:14 +0000 (22:07 +0000)]
Update auto-version.sh to better handle major version numbers with fewer than three digits,
and the case when WEBKITLIBRARIESDIR is not set.

Reviewed by Steve Falkenburg.

* win/tools/scripts/auto-version.sh:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoREGRESSION: Dragging plain text into a styled text region does not acquire the correc...
enrica@apple.com [Thu, 4 Feb 2010 21:50:23 +0000 (21:50 +0000)]
REGRESSION: Dragging plain text into a styled text region does not acquire the correct style info.
<rdar://problem/7595685>
https://bugs.webkit.org/show_bug.cgi?id=34609

Reviewed by Oliver Hunt.

WebCore:

Test: editing/pasteboard/drop-inputtext-acquires-style.html

The dragging code did not distinguish the case of dragging the content of an input control
as a special case. The markup placed in the pasteboard included the style information.
I've modified the Clipboard class interface adding a new method writePlainText to match the
behavior of the copy and cut commands and modified the drag code to detect the special case.
I've modified all the platform specific implementations of the Clipboard class.

* dom/Clipboard.h: Added writePlainText pure virtual function.
* editing/Editor.cpp:
(WebCore::Editor::cut): Renamed nodeIsTextFormControl to isNodeInTextFormControl.
(WebCore::Editor::copy): Renamed nodeIsTextFormControl to isNodeInTextFormControl.
* editing/htmlediting.cpp:
(WebCore::isNodeInTextFormControl): Added, after removing the implementation with the old name
in Editor.cpp
* editing/htmlediting.h:
* page/DragController.cpp:
(WebCore::DragController::startDrag):
* platform/Pasteboard.h:
* platform/android/ClipboardAndroid.cpp:
(WebCore::ClipboardAndroid::writePlainText): Added.
* platform/android/ClipboardAndroid.h:
* platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::writePlainText): Added.
* platform/chromium/ClipboardChromium.h:
* platform/gtk/ClipboardGtk.cpp:
(WebCore::ClipboardGtk::writePlainText): Added.
* platform/gtk/ClipboardGtk.h:
* platform/haiku/ClipboardHaiku.cpp:
(WebCore::ClipboardHaiku::writePlainText): Added.
* platform/haiku/ClipboardHaiku.h:
* platform/mac/ClipboardMac.h:
* platform/mac/ClipboardMac.mm:
(WebCore::ClipboardMac::writePlainText): Added.
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writePlainText): Added helper function.
* platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::writePlainText): Added.
* platform/qt/ClipboardQt.h:
* platform/win/ClipboardWin.cpp:
(WebCore::ClipboardWin::writePlainText): Added.
* platform/win/ClipboardWin.h:

LayoutTests:

* editing/pasteboard/drop-inputtext-acquires-style-expected.txt: Added.
* editing/pasteboard/drop-inputtext-acquires-style.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agohttps://bugs.webkit.org/show_bug.cgi?id=34611
sullivan@apple.com [Thu, 4 Feb 2010 21:45:26 +0000 (21:45 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=34611
WebLocalizedString() could use an assertion that it is being called on the main thread

Reviewed by Tim Hatcher.

WebKit:

* WebKit.xcodeproj/project.pbxproj:
Updated for renamed file (WebLocalizableStrings.m -> WebLocalizableStrings.mm)

WebKit/mac:

* Misc/WebLocalizableStrings.m: Removed.
* Misc/WebLocalizableStrings.mm: Copied from mac/Misc/WebLocalizableStrings.m.
Renamed to use .mm extension so it can include a C++ header.
(WebLocalizedString):
Added an assertion that this is being called on the main thread.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-04 Steve Block <steveblock@google.com>
eric@webkit.org [Thu, 4 Feb 2010 21:19:20 +0000 (21:19 +0000)]
2010-02-04  Steve Block  <steveblock@google.com>

        Reviewed by Nate Chapin.

        Fix bug in V8 convertNPVariantToJValue when converting float and double types
        https://bugs.webkit.org/show_bug.cgi?id=34593

        No new tests, build fix only.

        * bridge/jni/v8/JNIUtilityPrivate.cpp: Modified.
        (JSC::Bindings::convertNPVariantToJValue): Modified. Use correct members of 'result' enum.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-04 Chris Guillory <chris.guillory@google.com>
darin@chromium.org [Thu, 4 Feb 2010 20:16:17 +0000 (20:16 +0000)]
2010-02-04  Chris Guillory  <chris.guillory@google.com>

        Reviewed by Darin Fisher.

        [Chromium] Notify ChromeClientChromium of AccessibilityObject state
        change notifications.

        https://bugs.webkit.org/show_bug.cgi?id=34464

        * accessibility/chromium/AXObjectCacheChromium.cpp:
        (WebCore::toChromeClientChromium):
        (WebCore::AXObjectCache::postPlatformNotification):
        * page/chromium/ChromeClientChromium.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-04 Jeremy Moskovich <jeremy@chromium.org>
eric@webkit.org [Thu, 4 Feb 2010 20:10:43 +0000 (20:10 +0000)]
2010-02-04  Jeremy Moskovich  <jeremy@chromium.org>

        Reviewed by Darin Fisher.

        Update comments to better document the possible values of the
        writing direction menu state variables.

        * public/WebContextMenuData.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUse an easily appendable structure for trampolines instead of pointer parameters.
loki@webkit.org [Thu, 4 Feb 2010 20:09:05 +0000 (20:09 +0000)]
Use an easily appendable structure for trampolines instead of pointer parameters.
https://bugs.webkit.org/show_bug.cgi?id=34424

Patch by Tamas Szirbucz <szirbucz@inf.u-szeged.hu> on 2010-02-04
Reviewed by Gavin Barraclough.

* assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::executableCopy):
* jit/JIT.h:
(JSC::JIT::compileCTIMachineTrampolines):
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
* jit/JITStubs.cpp:
(JSC::JITThunks::JITThunks):
* jit/JITStubs.h:
(JSC::JITThunks::ctiStringLengthTrampoline):
(JSC::JITThunks::ctiVirtualCallLink):
(JSC::JITThunks::ctiVirtualCall):
(JSC::JITThunks::ctiNativeCallThunk):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-04 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Thu, 4 Feb 2010 20:05:50 +0000 (20:05 +0000)]
2010-02-04  Stephen White  <senorblanco@chromium.org>

        Unreviewed, build fix for Chromium.

        Revert r54341 ("[v8] Remove clear method from DOM object maps"),
        since it causes the worker tests to fail on Chromium.

        * bindings/v8/DOMData.h:
        (WebCore::DOMData::removeObjectsFromWrapperMap):
        * bindings/v8/DOMDataStore.h:
        (WebCore::ChunkedTable::clear):
        (WebCore::ChunkedTable::clearEntries):
        (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::clear):
        (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::ChunkedTableTraits::clear):
        * bindings/v8/V8DOMMap.cpp:
        (WebCore::removeAllDOMObjectsInCurrentThreadHelper):
        (WebCore::removeAllDOMObjectsInCurrentThread):
        * bindings/v8/V8DOMMap.h:
        (WebCore::WeakReferenceMap::clear):
        * bindings/v8/WorkerScriptController.cpp:
        (WebCore::WorkerScriptController::~WorkerScriptController):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix after changes in r54345.
kevino@webkit.org [Thu, 4 Feb 2010 19:39:55 +0000 (19:39 +0000)]
Build fix after changes in r54345.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-04 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
eric@webkit.org [Thu, 4 Feb 2010 19:29:19 +0000 (19:29 +0000)]
2010-02-04  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        [GTK] Crashes when an invalid hostname is pre-fetched
        https://bugs.webkit.org/show_bug.cgi?id=34602

        * http/tests/misc/dns-prefetch-control-expected.txt:
        * http/tests/misc/dns-prefetch-control.html: Add broken hostname test case.
2010-02-04  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        [GTK] Crashes when an invalid hostname is pre-fetched
        https://bugs.webkit.org/show_bug.cgi?id=34602

        * platform/network/soup/DNSSoup.cpp:
        (WebCore::prefetchDNS): NULL-check the SoupURI that is created
        from the hostname; that will happen for invalid hostnames.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubber-stamped by Dan Bernstein.
bweinstein@apple.com [Thu, 4 Feb 2010 19:10:22 +0000 (19:10 +0000)]
Rubber-stamped by Dan Bernstein.

Add Windows expected results to the new scrollbar test because Windows was trying
to compare to platform/mac first instead of cross-platform.

* platform/win/fast/events/scrollbar-double-click-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubberstamped by Oliver Hunt.
kenneth@webkit.org [Thu, 4 Feb 2010 18:52:49 +0000 (18:52 +0000)]
Rubberstamped by Oliver Hunt.

[Qt] QtLauncher cleanup.

Refactor option handling out in utility functions and make the
arguments more Qt compatible.

* QtLauncher/main.cpp:
(requiresGraphicsView):
(LauncherApplication::handleUserOptions):
* QtLauncher/utils.cpp:
(takeOptionValue):
(formatKeys):
(enumToKeys):
(appQuit):
* QtLauncher/utils.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoProperly handle margin settings in WinCairo.
bfulgham@webkit.org [Thu, 4 Feb 2010 18:42:59 +0000 (18:42 +0000)]
Properly handle margin settings in WinCairo.
https://bugs.webkit.org/show_bug.cgi?id=34545

Reviewed by Adam Roben.

* WebFrame.cpp:
(scaleFactor): Require the margin information as an input
  parameter, and use them when computing the scaling factor.
(WebFrame::drawHeader): Pass margin size to scaleFactor.
(WebFrame::drawFooter): Pass margin size to scaleFactor.
(WebFrame::spoolPage):
  1. Pass margin size to scaleFactor.
  2. Recognize that the return value of printerMarginRect is
     already in device units, and therefore scale it so that
     the Cairo drawing is correct.
  3. Remove scaling call for margins in GDI code, as it is
     already in scaled units.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-04 José Millán Soto <jmillan@igalia.com>
eric@webkit.org [Thu, 4 Feb 2010 18:35:38 +0000 (18:35 +0000)]
2010-02-04  José Millán Soto  <jmillan@igalia.com>

        Reviewed by Xan Lopez.

        [Gtk] webkitgtk crashed when Orca open
        https://bugs.webkit.org/show_bug.cgi?id=34463

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (textForObject):
        Checking if render objects are texts before calling toRenderText

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-04 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 4 Feb 2010 18:09:15 +0000 (18:09 +0000)]
2010-02-04  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Bump minimum libsoup requirement to 2.29.90

        * configure.ac:

WebCore:

2010-02-04  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Set first party URI in all SoupMessages. This allows libsoup to
        implement a "no third party cookies" policy in case it wants
        to. Also start a non-JSC-specific, gtk-specific GOwnPtr module and
        use it for SoupURI.

        * platform/network/soup/CookieJarSoup.cpp:
        (WebCore::setCookies):
        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::restartedCallback):
        (WebCore::startHttp):
        * platform/network/soup/ResourceRequestSoup.cpp:
        (WebCore::ResourceRequest::toSoupMessage):
        (WebCore::ResourceRequest::updateFromSoupMessage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-04 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 4 Feb 2010 18:06:08 +0000 (18:06 +0000)]
2010-02-04  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: group cookies by domains, not frame's domains.

        https://bugs.webkit.org/show_bug.cgi?id=34599

        * inspector/front-end/CookieItemsView.js:
        (WebInspector.CookieItemsView.prototype._cookiesForDomain):
        * inspector/front-end/inspector.js:
        (WebInspector.updateResource):
        (WebInspector._addCookieDomain):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-04 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Thu, 4 Feb 2010 18:01:51 +0000 (18:01 +0000)]
2010-02-04  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        [V8] Delete V8CustomBinding.h and all references to V8Custom

        https://bugs.webkit.org/show_bug.cgi?id=32638

        * bindings/v8/NPV8Object.cpp:
        * bindings/v8/V8DOMWindowShell.h:
        * bindings/v8/V8NPObject.cpp:
        * bindings/v8/V8Utilities.cpp:
        * bindings/v8/custom/V8AbstractWorkerCustom.cpp:
        * bindings/v8/custom/V8AttrCustom.cpp:
        * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
        * bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
        * bindings/v8/custom/V8ClipboardCustom.cpp:
        * bindings/v8/custom/V8CoordinatesCustom.cpp:
        * bindings/v8/custom/V8CustomBinding.h: Removed.
        * bindings/v8/custom/V8DOMApplicationCacheCustom.cpp:
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        * bindings/v8/custom/V8DataGridColumnListCustom.cpp:
        * bindings/v8/custom/V8DatabaseCustom.cpp:
        * bindings/v8/custom/V8ElementCustom.cpp:
        * bindings/v8/custom/V8EventSourceConstructor.cpp:
        * bindings/v8/custom/V8EventSourceCustom.cpp:
        * bindings/v8/custom/V8GeolocationCustom.cpp:
        * bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
        * bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
        (WebCore::v8HTMLAudioElementConstructorCallback):
        (WebCore::V8HTMLAudioElementConstructor::GetTemplate):
        * bindings/v8/custom/V8HTMLCollectionCustom.cpp:
        * bindings/v8/custom/V8HTMLDataGridElementCustom.cpp:
        * bindings/v8/custom/V8HTMLFrameElementCustom.cpp:
        * bindings/v8/custom/V8HTMLIFrameElementCustom.cpp:
        * bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
        (WebCore::v8HTMLImageElementConstructorCallback):
        (WebCore::V8HTMLImageElementConstructor::GetTemplate):
        * bindings/v8/custom/V8HTMLInputElementCustom.cpp:
        * bindings/v8/custom/V8HTMLOptionElementConstructor.cpp:
        (WebCore::v8HTMLOptionElementConstructorCallback):
        (WebCore::V8HTMLOptionElementConstructor::GetTemplate):
        * bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
        * bindings/v8/custom/V8HistoryCustom.cpp:
        * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
        * bindings/v8/custom/V8LocationCustom.cpp:
        * bindings/v8/custom/V8MessagePortCustom.cpp:
        * bindings/v8/custom/V8NodeCustom.cpp:
        * bindings/v8/custom/V8NodeFilterCustom.cpp:
        * bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
        * bindings/v8/custom/V8SQLTransactionCustom.cpp:
        * bindings/v8/custom/V8SVGElementInstanceCustom.cpp:
        * bindings/v8/custom/V8SVGLengthCustom.cpp:
        * bindings/v8/custom/V8SharedWorkerCustom.cpp:
        * bindings/v8/custom/V8StorageCustom.cpp:
        * bindings/v8/custom/V8WebGLArrayBufferCustom.cpp:
        * bindings/v8/custom/V8WebGLArrayCustom.h:
        * bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
        * bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
        * bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
        * bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
        * bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
        * bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
        * bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
        * bindings/v8/custom/V8WebKitPointConstructor.cpp:
        * bindings/v8/custom/V8WorkerContextCustom.cpp:
        * bindings/v8/custom/V8WorkerCustom.cpp:
        * bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
        * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
        * bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWindows build fix for projects not defining WebKitLibrariesDir.
sfalken@apple.com [Thu, 4 Feb 2010 17:56:38 +0000 (17:56 +0000)]
Windows build fix for projects not defining WebKitLibrariesDir.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-04 Ariya Hidayat <ariya.hidayat@gmail.com>
ariya@webkit.org [Thu, 4 Feb 2010 17:43:17 +0000 (17:43 +0000)]
2010-02-04  Ariya Hidayat  <ariya.hidayat@gmail.com>

        Reviewed by Simon Hausmann.

        [Qt] Unnecessary QBrush construction for doing a solid fill
        https://bugs.webkit.org/show_bug.cgi?id=34559

        Use the similar trick like r37421, i.e. use the special brush for
        solid color to avoid creating QBrush again and again.

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::setPlatformFillColor):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoREGRESSION (r53718): When scrolling a tall window by page, the overlap between pages...
mitz@apple.com [Thu, 4 Feb 2010 17:41:58 +0000 (17:41 +0000)]
REGRESSION (r53718): When scrolling a tall window by page, the overlap between pages is too big
https://bugs.webkit.org/show_bug.cgi?id=34371

Reviewed by Simon Fraser.

* platform/mac/fast/events/scrollbar-double-click-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoREGRESSION (r53718): When scrolling a tall window by page, the overlap between pages...
mitz@apple.com [Thu, 4 Feb 2010 17:35:58 +0000 (17:35 +0000)]
REGRESSION (r53718): When scrolling a tall window by page, the overlap between pages is too big
https://bugs.webkit.org/show_bug.cgi?id=34371

Reviewed by Simon Fraser.

WebCore:

Allow ScrollbarTheme to cap the overlap between pages, and set a cap of
40 in ScrollbarThemeMac.

* WebCore.base.exp: Export Scrollbar::maxOverlapBetweenPages().
* editing/EditorCommand.cpp:
(WebCore::verticalScrollDistance): Use Scrollbar methods instead of
constants, and cap the scroll distance if needed.
* platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars): Ditto.
(WebCore::ScrollView::wheelEvent): Ditto.
* platform/Scrollbar.cpp:
(WebCore::Scrollbar::maxOverlapBetweenPages): Added. Returns the
value from the native scrollbar theme.
* platform/Scrollbar.h: Replaced scroll amount constants with static methods.
(WebCore::Scrollbar::pixelsPerLineStep): Replaces cScrollbarPixelsPerLineStep.
(WebCore::Scrollbar::minFractionToStepWhenPaging): Replaces cFractionToStepWhenPaging.
* platform/ScrollbarTheme.h:
(WebCore::ScrollbarTheme::maxOverlapBetweenPages): A base implementation
that returns the largest int.
* platform/gtk/WheelEventGtk.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent): Use Scrollbar methods instead of
constants.
* platform/haiku/PlatformWheelEventHaiku.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent): Use Scrollbar methods instead of
constants.
* platform/mac/ScrollbarThemeMac.h:
(WebCore::ScrollbarThemeMac::maxOverlapBetweenPages): An override
that returns 40.
* platform/mac/WheelEventMac.mm:
(WebCore::PlatformWheelEvent::PlatformWheelEvent): Use
Scrollbar::pixelsPerLineStep() instead of cScrollbarPixelsPerLineStep.
* platform/wx/MouseWheelEventWx.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent): Use Scrollbar methods instead of
constants.
* platform/wx/ScrollViewWx.cpp:
(WebCore::ScrollView::ScrollViewPrivate::OnScrollWinEvents): Use Scrollbar
methods instead of constants, and cap the scroll distance if needed.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateScrollInfoAfterLayout): Ditto.

WebKit/mac:

* WebView/WebFrameView.mm:
(-[WebFrameView _verticalPageScrollDistance]): Use Scrollbar methods instead of
constants, and cap the scroll distance.
(-[WebFrameView initWithFrame:]): Use Scrollbar::pixelsPerLineStep() instead of
cScrollbarPixelsPerLineStep.
(-[WebFrameView _horizontalPageScrollDistance]):Use Scrollbar methods instead of
constants, and cap the scroll distance.

WebKit/wx:

* WebView.cpp:
(wxWebView::OnKeyEvents): Use Scrollbar method instead of constant.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-04 No'am Rosenthal <noam.rosenthal@nokia.com>
eric@webkit.org [Thu, 4 Feb 2010 16:56:18 +0000 (16:56 +0000)]
2010-02-04  No'am Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Ariya Hidayat.

        [Qt] Tuning and optimizations to GraphicsLayerQt. Reduce unnecessary
        recaching, remove QTimer::singleShot and QPixmap::scaled, more
        accurate strategy of handling transform operation blends. Rotating a
        bordered-table, for example, now runs at 50FPS instead of 40FPS on Maemo5.

        https://bugs.webkit.org/show_bug.cgi?id=34062

        This is tested by https://bugs.webkit.org/show_bug.cgi?id=34450, fps measurements.

        * platform/graphics/qt/GraphicsLayerQt.cpp:
        (WebCore::GraphicsLayerQtImpl::flushChanges): Fine-tune caching
        (WebCore::TransformAnimationQt::TransformAnimationQt): transform bugs
        (WebCore::OpacityAnimationQt::updateState): style change
2010-02-04  No'am Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Ariya Hidayat.

        [Qt] Tuning and optimizations to GraphicsLayerQt. Mainly reduced usage
        of QTimer::singleShot, and moved syncLayers() from paint() to update()
        https://bugs.webkit.org/show_bug.cgi?id=34062

        * Api/qgraphicswebview.cpp:
        (QGraphicsWebViewPrivate::update): Moved the sync operation to update
        (QGraphicsWebView::paint): Moved the sync operation to update

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-04 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 4 Feb 2010 16:39:17 +0000 (16:39 +0000)]
2010-02-04  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Cookies for resources are not shown in storage panel.

        https://bugs.webkit.org/show_bug.cgi?id=34594

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::getCookies):
        * inspector/InspectorResource.cpp:
        (WebCore::InspectorResource::updateScriptObject):
        (WebCore::InspectorResource::cachedResource):
        * inspector/InspectorResource.h:
        (WebCore::InspectorResource::requestURL):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-04 Andras Becsi <abecsi@inf.u-szeged.hu>
abecsi@webkit.org [Thu, 4 Feb 2010 14:52:10 +0000 (14:52 +0000)]
2010-02-04  Andras Becsi  <abecsi@inf.u-szeged.hu>

        Reviewed by Tor Arne Vestbø.

        Implement a locking and scheduling mechanism for http testing sessions to be able
        to run multiple instances of run-webkit-tests parallel on the same machine.
        If a test session wants to run http tests and this feature is enabled, the pending
        sessions create lockfiles with sequential lock numbers. These locks are used to schedule
        the running test sessions in first come first served order. An exclusive lock ensures
        that the lock numbers are sequential to avoid deadlocks and starvation.
        Because the buildbot master specifies the flags used by slaves we need an environment
        variable too to be able to use the feature per-slave.
        Exporting WEBKIT_WAIT_FOR_HTTPD=1 before testing or using the --wait-for-httpd
        flag enables this feature, otherwise this patch has no effect on the testing whatsoever.

        https://bugs.webkit.org/show_bug.cgi?id=33153

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-04 Anton Muhin <antonm@chromium.org>
eric@webkit.org [Thu, 4 Feb 2010 12:57:15 +0000 (12:57 +0000)]
2010-02-04  Anton Muhin  <antonm@chromium.org>

        Reviewed by Adam Barth.

        [v8] Remove clear method from DOM object maps
        https://bugs.webkit.org/show_bug.cgi?id=34530

        No new tests. Should be covered by existent testing infrastructure.

        * bindings/v8/DOMData.h:
        * bindings/v8/DOMDataStore.h:
        * bindings/v8/V8DOMMap.cpp:
        * bindings/v8/V8DOMMap.h:
        * bindings/v8/WorkerScriptController.cpp:
        (WebCore::WorkerScriptController::~WorkerScriptController):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-04 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
eric@webkit.org [Thu, 4 Feb 2010 11:15:34 +0000 (11:15 +0000)]
2010-02-04  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>

        Reviewed by Simon Hausmann.

        Increase test coverage for the QScriptValue.

        https://bugs.webkit.org/show_bug.cgi?id=34533

        * qt/tests/qscriptvalue/qscriptvalue.pro:
        * qt/tests/qscriptvalue/tst_qscriptvalue.cpp:
        (tst_QScriptValue::tst_QScriptValue):
        (tst_QScriptValue::~tst_QScriptValue):
        (tst_QScriptValue::dataHelper):
        (tst_QScriptValue::newRow):
        (tst_QScriptValue::testHelper):
        (tst_QScriptValue::ctor):
        * qt/tests/qscriptvalue/tst_qscriptvalue.h: Added.
        * qt/tests/qscriptvalue/tst_qscriptvalue_generated.cpp: Added.
        (tst_QScriptValue::initScriptValues):
        (tst_QScriptValue::isValid_initData):
        (tst_QScriptValue::isValid_makeData):
        (tst_QScriptValue::isValid_test):
        (tst_QScriptValue::isBool_initData):
        (tst_QScriptValue::isBool_makeData):
        (tst_QScriptValue::isBool_test):
        (tst_QScriptValue::isBoolean_initData):
        (tst_QScriptValue::isBoolean_makeData):
        (tst_QScriptValue::isBoolean_test):
        (tst_QScriptValue::isFunction_initData):
        (tst_QScriptValue::isFunction_makeData):
        (tst_QScriptValue::isFunction_test):
        (tst_QScriptValue::isNull_initData):
        (tst_QScriptValue::isNull_makeData):
        (tst_QScriptValue::isNull_test):
        (tst_QScriptValue::isString_initData):
        (tst_QScriptValue::isString_makeData):
        (tst_QScriptValue::isString_test):
        (tst_QScriptValue::isUndefined_initData):
        (tst_QScriptValue::isUndefined_makeData):
        (tst_QScriptValue::isUndefined_test):
        (tst_QScriptValue::isObject_initData):
        (tst_QScriptValue::isObject_makeData):
        (tst_QScriptValue::isObject_test):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMake run-webkit-tests work under Cygwin for the Qt port
vestbo@webkit.org [Thu, 4 Feb 2010 10:55:39 +0000 (10:55 +0000)]
Make run-webkit-tests work under Cygwin for the Qt port

Reviewed by Simon Hausmann.

setPathForRunningWebKitApp() is implemented for the Qt port
by using qmake to query for the location of the Qt libraries.

This requires the original environment (%ENV) to be untouched,
so launchWithCurrentEnv() was refactored to launchWithEnv(),
and the code in openDumpTool() to not use %ENV but a %CLEAN_ENV
instead. This has the added benefit of getting rid of the temp
variables used for storing the current env.

openDumpTool() is also refactored a bit into platform-spesific,
port-spesific, and generic environment variables.

Checks for undef was added a few places to fix Perl concat
warnings when run-webkit-tests is aborted.

https://bugs.webkit.org/show_bug.cgi?id=33895

* Scripts/run-webkit-tests:
* Scripts/webkitdirs.pm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] fast/workers/shared-worker-frame-lifecycle.html failed on Qt Bot
ossy@webkit.org [Thu, 4 Feb 2010 10:50:57 +0000 (10:50 +0000)]
[Qt] fast/workers/shared-worker-frame-lifecycle.html failed on Qt Bot
https://bugs.webkit.org/show_bug.cgi?id=34281

* platform/qt/Skipped: fast/workers/shared-worker-frame-lifecycle.html skipped until fix.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Gtk] Check if the renderer() exists in textForObject.
zecke@webkit.org [Thu, 4 Feb 2010 10:50:16 +0000 (10:50 +0000)]
[Gtk] Check if the renderer() exists in textForObject.

This is fixing a crash in the textForObject method. It can
happen when inspecting AtkObjects in the accerciser, then
navigating to a new page and still inspecting the old tree.

In this case the AccessibilityObjectWrapperAtk was still
valid but the included renderer() was returning 0. Add a
check for the accObject->renderer() before trying to use
the result.

* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(textForObject):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-04 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Thu, 4 Feb 2010 10:20:24 +0000 (10:20 +0000)]
2010-02-04  Yuzo Fujishima  <yuzo@google.com>

        Unreviewed.

        Add Yuzo to the committers list.

        * Scripts/webkitpy/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-04 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Thu, 4 Feb 2010 10:06:11 +0000 (10:06 +0000)]
2010-02-04  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Revert 54333 which broke Chromium build.

        * WebKit.gyp:
        * tests/TransparencyWinTest.cpp: Removed.
        * tests/UniscribeHelperTest.cpp: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-04 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Thu, 4 Feb 2010 09:38:40 +0000 (09:38 +0000)]
2010-02-04  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Provide strongly typed C++ interface for inspector's injected script.

        https://bugs.webkit.org/show_bug.cgi?id=33616

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSInjectedScriptHostCustom.cpp:
        (WebCore::InjectedScriptHost::injectedScriptFor):
        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
        (WebCore::InjectedScriptHost::injectedScriptFor):
        * inspector/InjectedScript.cpp: Added.
        (WebCore::InjectedScript::InjectedScript):
        (WebCore::InjectedScript::dispatch):
        (WebCore::InjectedScript::callFrames):
        (WebCore::InjectedScript::wrapAndStringifyForConsole):
        (WebCore::InjectedScript::releaseWrapperObjectGroup):
        * inspector/InjectedScript.h: Added.
        (WebCore::InjectedScript::InjectedScript):
        (WebCore::InjectedScript::~InjectedScript):
        (WebCore::InjectedScript::hasNoValue):
        * inspector/InjectedScriptHost.cpp:
        (WebCore::InjectedScriptHost::injectedScriptForId):
        (WebCore::InjectedScriptHost::releaseWrapperObjectGroup):
        * inspector/InjectedScriptHost.h:
        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::dispatchOnInjectedScript):
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::~InspectorController):
        (WebCore::InspectorController::inspectedPageDestroyed):
        (WebCore::InspectorController::windowScriptObjectAvailable):
        (WebCore::InspectorController::scriptObjectReady):
        (WebCore::InspectorController::setFrontendProxyObject):
        (WebCore::InspectorController::close):
        (WebCore::InspectorController::getProfile):
        (WebCore::InspectorController::enableDebugger):
        (WebCore::InspectorController::didPause):
        (WebCore::InspectorController::injectedScriptForNodeId):
        * inspector/InspectorController.h:
        (WebCore::InspectorController::frontendScriptState):
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::addConsoleMessage):
        * inspector/front-end/InjectedScript.js:
        (injectedScriptConstructor):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-04 Yaar Schnitman <yaar@chromium.org>
eric@webkit.org [Thu, 4 Feb 2010 09:16:37 +0000 (09:16 +0000)]
2010-02-04  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Darin Fisher.

        Upstreaming gtests from chromium: UniscribeHelper and TransparencyWin.
        https://bugs.webkit.org/show_bug.cgi?id=34509

        * WebKit.gyp:
        * tests/TransparencyWinTest.cpp: Added.
        (WebCore::RECTToFloatRect):
        (WebCore::drawNativeRect):
        (WebCore::getPixelAt):
        (WebCore::clearTopLayerAlphaChannel):
        (WebCore::clearTopLayerAlphaPixel):
        (WebCore::operator<<):
        (WebCore::TEST):
        * tests/UniscribeHelperTest.cpp: Added.
        (WebCore::UniscribeTest::UniscribeTest):
        (WebCore::UniscribeTest::MakeFont):
        (WebCore::UniscribeTest::SetUp):
        (WebCore::UniscribeTest::TearDown):
        (WebCore::TEST_F):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-04 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 4 Feb 2010 09:11:44 +0000 (09:11 +0000)]
2010-02-04  Philippe Normand  <pnormand@igalia.com>

        Rubber stamped by Xan Lopez.

        Missing include, build fix after landing of patch from the bug 34435.

        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-04 Jeremy Moskovich <jeremy@chromium.org>
eric@webkit.org [Thu, 4 Feb 2010 08:41:50 +0000 (08:41 +0000)]
2010-02-04  Jeremy Moskovich  <jeremy@chromium.org>

        Reviewed by David Levin.

        [Chromium] WebKit side of "Writing direction" context menu on OS X.
        https://bugs.webkit.org/show_bug.cgi?id=34524

        * public/WebContextMenuData.h:
        (WebKit::WebContextMenuData::):
        * src/ContextMenuClientImpl.cpp:
        (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-02 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 4 Feb 2010 08:32:14 +0000 (08:32 +0000)]
2010-02-02  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [Gtk] libsoup critical warning in media player http cookies injection code
        https://bugs.webkit.org/show_bug.cgi?id=34435

        Fixed the critical warning and refactored the
        User-Agent/Referer/cookies injection code, in that order. Previous
        order (cookies first) was wrong because if cookies injection could
        not be done neither the User-Agent nor Referer were injected. Also
        started a non-JSC-specific, gtk-specific GOwnPtr module.

        * GNUmakefile.am:
        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::mediaPlayerPrivateSourceChangedCallback):
        * platform/gtk/GOwnPtrGtk.cpp: Added.
        (WTF::SoupURI):
        (WTF::GstElement):
        * platform/gtk/GOwnPtrGtk.h: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-04 Mikhail Naganov <mnaganov@chromium.org>
eric@webkit.org [Thu, 4 Feb 2010 08:25:25 +0000 (08:25 +0000)]
2010-02-04  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Timothy Hatcher.

        Put JSC-specific debugger & profiler code under "USE(JSC)" defines.
        The plan is to enable "JAVASCRIPT_DEBUGGER" in Chromium and then
        make this code engine-agnostic.

        https://bugs.webkit.org/show_bug.cgi?id=34531

        * inspector/InjectedScriptHost.cpp:
        * inspector/InjectedScriptHost.h:
        * inspector/InspectorBackend.cpp:
        * inspector/InspectorBackend.h:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::setWindowVisible):
        (WebCore::InspectorController::scriptObjectReady):
        (WebCore::InspectorController::close):
        (WebCore::InspectorController::didCommitLoad):
        * inspector/InspectorController.h:
        * inspector/InspectorFrontend.cpp:
        * inspector/InspectorFrontend.h:
        * inspector/JavaScriptCallFrame.cpp:
        * inspector/JavaScriptCallFrame.h:
        * inspector/JavaScriptDebugListener.h:
        * inspector/JavaScriptDebugServer.cpp:
        * inspector/JavaScriptDebugServer.h:
        * inspector/JavaScriptProfile.cpp:
        * inspector/JavaScriptProfile.h:
        * inspector/JavaScriptProfileNode.cpp:
        * inspector/JavaScriptProfileNode.h:
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
        * page/Page.cpp:
        (WebCore::Page::Page):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-03 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 4 Feb 2010 07:54:37 +0000 (07:54 +0000)]
2010-02-03  Dirk Pranke  <dpranke@chromium.org>

        Rubber-stamped by Eric Seidel.

        Change "the Chromium name" to "the name of Google Inc." in the licenses

        https://bugs.webkit.org/show_bug.cgi?id=34511

        * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
        * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
        * Scripts/webkitpy/layout_tests/port/__init__.py:
        * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
        * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
        * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
        * Scripts/webkitpy/layout_tests/port/chromium_win.py:
        * Scripts/webkitpy/layout_tests/port/http_server.py:
        * Scripts/webkitpy/layout_tests/port/http_server_base.py:
        * Scripts/webkitpy/layout_tests/port/path_utils.py:
        * Scripts/webkitpy/layout_tests/port/websocket_server.py:
        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
        * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
        * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
        * Scripts/webkitpy/layout_tests/test_types/text_diff.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-03 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 4 Feb 2010 07:51:49 +0000 (07:51 +0000)]
2010-02-03  Dirk Pranke  <dpranke@chromium.org>

        Rubber-stamped by Eric Siedel.

        Rename files as part of refactoring the layout_tests package. All
        the platform_utils* module, the path_utils.py module, and
        the http server and web socket server modules are moved into a new
        port/ package.

        https://bugs.webkit.org/show_bug.cgi?id=34511

        * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
        * Scripts/webkitpy/layout_tests/port/__init__.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/platform_utils.py.
        * Scripts/webkitpy/layout_tests/port/apache_http_server.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py.
        * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py.
        * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py.
        * Scripts/webkitpy/layout_tests/port/chromium_win.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py.
        * Scripts/webkitpy/layout_tests/port/http_server.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/http_server.py.
        * Scripts/webkitpy/layout_tests/port/http_server_base.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/http_server_base.py.
        * Scripts/webkitpy/layout_tests/port/httpd2.pem: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/httpd2.pem.
        * Scripts/webkitpy/layout_tests/port/lighttpd.conf: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf.
        * Scripts/webkitpy/layout_tests/port/path_utils.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/path_utils.py.
        * Scripts/webkitpy/layout_tests/port/websocket_server.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/websocket_server.py.
        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
        * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
        * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
        * Scripts/webkitpy/layout_tests/test_types/text_diff.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-03 Nicholas Young <nicholas.young@nokia.com>
eric@webkit.org [Thu, 4 Feb 2010 07:48:37 +0000 (07:48 +0000)]
2010-02-03  Nicholas Young  <nicholas.young@nokia.com>

        Reviewed by Eric Carlson.

        Defer formatting of times displayed on media controls to the current theme.
        https://bugs.webkit.org/show_bug.cgi?id=34405

        No new tests needed. Refactoring Only.

        * rendering/MediaControlElements.cpp: Removed formatTime()
        (WebCore::MediaControlTimeDisplayElement::setCurrentValue): No longer sets inner text
        * rendering/MediaControlElements.h:
        * rendering/RenderMedia.cpp:
        (WebCore::RenderMedia::updateTimeDisplay): Asks the theme to format the time display elements
        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::formatMediaControlsTime): new virtual method
        (WebCore::RenderTheme::formatMediaControlsCurrentTime): new virtual method
        (WebCore::RenderTheme::formatMediaControlsRemainingTime): new virtual method
        * rendering/RenderTheme.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed fix.
ukai@chromium.org [Thu, 4 Feb 2010 07:30:46 +0000 (07:30 +0000)]
Unreviewed fix.

websocket/tests/close-on-unload.html and
close-on-navigate-new-location.html will fail on mac tiger,
because python on the platform doesn't support set(), which is
used in websocket handler for these tests.

* platform/mac-tiger/Skipped: skip websocket/tests/close-on-unload.html and websocket/tests/close-on-navigate-new-location.html

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-03 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Thu, 4 Feb 2010 07:26:28 +0000 (07:26 +0000)]
2010-02-03  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Alexey Proskuryakov.

        navigating a frame to new location closes websocket in the frame
        https://bugs.webkit.org/show_bug.cgi?id=34557

        * websocket/tests/close-on-navigate-new-location-expected.txt: Added.
        * websocket/tests/close-on-navigate-new-location.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWindows Debug_All build fix.
sfalken@apple.com [Thu, 4 Feb 2010 05:52:11 +0000 (05:52 +0000)]
Windows Debug_All build fix.

* platform/graphics/win/WKCACFLayer.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemove an unnecessary backup file.
mrowe@apple.com [Thu, 4 Feb 2010 03:57:23 +0000 (03:57 +0000)]
Remove an unnecessary backup file.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoREGRESSION (r51644): WebCore/manual-tests/linkjump-1.html fails
beidson@apple.com [Thu, 4 Feb 2010 03:28:12 +0000 (03:28 +0000)]
REGRESSION (r51644): WebCore/manual-tests/linkjump-1.html fails
<rdar://problem/7595694> and https://bugs.webkit.org/show_bug.cgi?id=34550

Reviewed by Alexey Proskuryakov.

WebCore:

Tests: fast/loader/document-with-fragment-url-1.html
       fast/loader/document-with-fragment-url-2.html
       fast/loader/document-with-fragment-url-3.html
       fast/loader/document-with-fragment-url-4.html

* platform/KURL.cpp:
(WebCore::KURL::init): When resolving new URL from an empty reference relative to an absolute URL,
  any fragment identifier from the absolute URL should be removed from the resulting resolution.

LayoutTests:

* fast/loader/document-with-fragment-url-1-expected.txt: Added.
* fast/loader/document-with-fragment-url-1.html: Added.
* fast/loader/document-with-fragment-url-2-expected.txt: Added.
* fast/loader/document-with-fragment-url-2.html: Added.
* fast/loader/document-with-fragment-url-3-expected.txt: Added.
* fast/loader/document-with-fragment-url-3.html: Added.
* fast/loader/document-with-fragment-url-4-expected.txt: Added.
* fast/loader/document-with-fragment-url-4.html: Added.
* fast/loader/resources/document-with-fragment-url-test.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-03 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Thu, 4 Feb 2010 02:49:29 +0000 (02:49 +0000)]
2010-02-03  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Eric Seidel.

        [BREWMP] Define WTF_PLATFORM_BREWMP_SIMULATOR when AEE_SIMULATOR is defined
        https://bugs.webkit.org/show_bug.cgi?id=34514

        PLATFORM(BREWMP_SIMULATOR) guard is needed to make distinction between BREWMP
        and BREWMP simulator.

        * wtf/Platform.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-03 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Thu, 4 Feb 2010 02:24:07 +0000 (02:24 +0000)]
2010-02-03  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Alexey Proskuryakov.

        WebSocket should close the connection when unloading the document
        https://bugs.webkit.org/show_bug.cgi?id=33248

        * websocket/tests/close-on-unload-expected.txt: Added.
        * websocket/tests/close-on-unload.html: Added.
        * websocket/tests/close-on-unload_wsh.py: Added.
        * websocket/tests/resources/close-on-unload-iframe.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-03 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Thu, 4 Feb 2010 02:23:13 +0000 (02:23 +0000)]
2010-02-03  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Eric Seidel.

        [BREWMP] Port TextBreakIteratorInternalICU
        https://bugs.webkit.org/show_bug.cgi?id=34515

        Port TextBreakIteratorInternalICU.

        * platform/text/brew/TextBreakIteratorInternalICUBrew.cpp: Added.
        (WebCore::currentSearchLocaleID):
        (WebCore::currentTextBreakLocaleID):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: Fix for <rdar://problem/7594212>
adele@apple.com [Thu, 4 Feb 2010 01:52:15 +0000 (01:52 +0000)]
WebCore: Fix for <rdar://problem/7594212>
https://bugs.webkit.org/show_bug.cgi?id=34549 - CSS counters crash at http://www.w3.org/TR/css3-content/
CrashTracer: [USER] 20 crashes in Safari at com.apple.WebCore: WebCore::CounterNode::insertAfter + 319

Reviewed by Simon Fraser.

Test: fast/css/counters/counter-before-selector-crash.html

* rendering/RenderCounter.cpp: (WebCore::updateCounters): nil check.

LayoutTests: Test for: <rdar://problem/7594212>
https://bugs.webkit.org/show_bug.cgi?id=34549 - CSS counters crash at http://www.w3.org/TR/css3-content/
CrashTracer: [USER] 20 crashes in Safari at com.apple.WebCore: WebCore::CounterNode::insertAfter + 319

Reviewed by Simon Fraser.

* fast/css/counters/counter-before-selector-crash-expected.txt: Added.
* fast/css/counters/counter-before-selector-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoInitialize the variable in the last checkin to false. I didn't realize DRT relies...
adele@apple.com [Thu, 4 Feb 2010 01:32:32 +0000 (01:32 +0000)]
Initialize the variable in the last checkin to false.  I didn't realize DRT relies on this being false.
So ports that want visited link tracking need to set that flag.

Reviewed by Brady Eidson.

* page/PageGroup.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubber-stamped by Eric Seidel.
ossy@webkit.org [Thu, 4 Feb 2010 01:07:11 +0000 (01:07 +0000)]
Rubber-stamped by Eric Seidel.

Roll back r53559 and r54084 again, because roll out didn't solve flakeyness on the Windows Test bots
https://bugs.webkit.org/show_bug.cgi?id=34399

* Scripts/run-iexploder-tests:
* Scripts/run-webkit-httpd:
* Scripts/run-webkit-tests:
* Scripts/webkitperl/httpd.pm: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=34547
adele@apple.com [Thu, 4 Feb 2010 00:50:08 +0000 (00:50 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=34547
static shouldTrackVisitedLinks is not initialized

Reviewed by Brady Eidson.

For ports that don't call into WebKit to initialize this,
we should initialize to true so they get the visited link behavior by default.

* page/PageGroup.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubber-stamped by Eric Seidel.
ossy@webkit.org [Thu, 4 Feb 2010 00:32:28 +0000 (00:32 +0000)]
Rubber-stamped by Eric Seidel.

Roll out r53559 and r54084, because it might caused flakeyness on the Windows Test bots

* Scripts/run-iexploder-tests:
* Scripts/run-webkit-httpd:
* Scripts/run-webkit-tests:
* Scripts/webkitperl/httpd.pm: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<rdar://problem/7577604> Drag and Drop: background elements are bleeding through
mitz@apple.com [Thu, 4 Feb 2010 00:26:00 +0000 (00:26 +0000)]
<rdar://problem/7577604> Drag and Drop: background elements are bleeding through
https://bugs.webkit.org/show_bug.cgi?id=34546

Reviewed by Simon Fraser.

* manual-tests/drag-image-table-part-decorations.html: Added.
* rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::paintBoxDecorations): Bail out if this object shouldn’t
paint within the current painting root.
* rendering/RenderTable.cpp:
(WebCore::RenderTable::paintBoxDecorations): Ditto.
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paintBackgroundsBehindCell): Ditto.
(WebCore::RenderTableCell::paintBoxDecorations): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Wed, 3 Feb 2010 23:47:09 +0000 (23:47 +0000)]
Reviewed by Kevin Ollivier.

Add wxWebKitWindowFeatures and have createWindow send a notification for
clients to handle.

https://bugs.webkit.org/show_bug.cgi?id=34542

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubber-stamped by Ariya Hidayat.
ossy@webkit.org [Wed, 3 Feb 2010 23:31:02 +0000 (23:31 +0000)]
Rubber-stamped by Ariya Hidayat.

Roll back r53889 again, because roll out didn't solve flakeyness on the Windows Test bots
https://bugs.webkit.org/show_bug.cgi?id=34399

WebKitTools:

* DumpRenderTree/win/EventSender.cpp:
(buildModifierFlags):
(mouseDownCallback):
(mouseUpCallback):
(keyDownCallback):

LayoutTests:

* platform/win/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54307 268f45cc-cd09-0410-ab3c-d52691b4dbfc