WebKit.git
11 years ago2010-04-22 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Fri, 23 Apr 2010 07:00:21 +0000 (07:00 +0000)]
2010-04-22  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Adam Barth.

        Add a test for file URL canonicalization with an http base
        https://bugs.webkit.org/show_bug.cgi?id=38035

        * fast/url/file-http-base-expected.txt: Added.
        * fast/url/file-http-base.html: Added.
        * fast/url/script-tests/file-http-base.js: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix up my immediately previous ChangeLogs.
mjs@apple.com [Fri, 23 Apr 2010 05:59:17 +0000 (05:59 +0000)]
Fix up my immediately previous ChangeLogs.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Fri, 23 Apr 2010 05:47:06 +0000 (05:47 +0000)]
2010-04-22  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Dan Bernstein.

        Links around blocks (e.g. divs) results in too many VoiceOver call outs
        https://bugs.webkit.org/show_bug.cgi?id=37079

        The basic change is to modify the AccessibilityRenderObject tree
        traversal methods to account for inline continuations in the
        render tree and make the accessibility tree look as if
        continuations didn't exist - the same as if CSS blocks could just
        sit in CSS inlines. This is slightly tricky code but creates a
        much saner accessibility tree.

        Tests: accessibility/image-link-inline-cont.html
               accessibility/image-link.html
               accessibility/inline-continuations.html

        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::isInlineWithContinuation): Helper function for traversal functions to use in accounting for continuations.
        (WebCore::firstChildInContinuation): ditto
        (WebCore::firstChildConsideringContinuation): ditto
        (WebCore::lastChildConsideringContinuation): ditto
        (WebCore::startOfContinuations): ditto
        (WebCore::endOfContinuations): ditto
        (WebCore::childBeforeConsideringContinuations): ditto
        (WebCore::firstChildIsInlineContinuation): ditto
        (WebCore::lastChildHasContinuation): ditto
        (WebCore::AccessibilityRenderObject::firstChild): Account for inline continuations.
        (WebCore::AccessibilityRenderObject::lastChild): ditto
        (WebCore::AccessibilityRenderObject::previousSibling): Account for inline continuations
        and their anonymous block parents.
        (WebCore::AccessibilityRenderObject::nextSibling): ditto
        (WebCore::AccessibilityRenderObject::parentObjectIfExists): Account for inline continuations.
        (WebCore::AccessibilityRenderObject::parentObject): Account for inline continuations.
        * rendering/RenderInline.h: Make RenderInline::inlineContinuation public.
2010-04-22  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Dan Bernstein.

        Links around blocks (e.g. divs) results in too many VoiceOver call outs
        https://bugs.webkit.org/show_bug.cgi?id=37079

        The new test cases verify the accessibility tree created by an image inside a link, and verify
        that adding a div with role=presentation now has no effect on the accessibility tree (as expected).

        * accessibility/image-link-inline-cont-expected.txt: Added.
        * accessibility/image-link-inline-cont.html: Added.
        * accessibility/image-link.html: Added.
        * platform/gtk/Skipped:
        * platform/mac/accessibility/image-link-expected.txt: Added.
        * platform/win/Skipped:

        Test to check that accessibility tree doesn't get duplicate content in the presence
        of inline continuations (this was a bug in an earlier version of this patch).

        * accessibility/inline-continuations-expected.txt: Added.
        * accessibility/inline-continuations.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Fri, 23 Apr 2010 04:51:39 +0000 (04:51 +0000)]
2010-04-22  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler.

        REGRESSION: TextIterator may use freed memory
        https://bugs.webkit.org/show_bug.cgi?id=37973

        * platform/chromium/test_expectations.txt:
2010-04-22  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler.

        REGRESSION: TextIterator may use freed memory
        https://bugs.webkit.org/show_bug.cgi?id=37973

        Added TextIterator::m_text to hold the returned String.

        No new tests because there are no behavior change, but
        copy-backslash-with-euc.html on chromium-win should test this.

        * editing/TextIterator.cpp:
        (WebCore::TextIterator::emitText):
        * editing/TextIterator.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Adam Barth <abarth@webkit.org>
eric@webkit.org [Fri, 23 Apr 2010 04:48:24 +0000 (04:48 +0000)]
2010-04-22  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        The new review tools shouldn't clear the comment box automatically
        https://bugs.webkit.org/show_bug.cgi?id=38004

        Instead, we now have a button for doing that explicitly.  If people
        like this tool, we can look at fancier solutions.

        Also, tried to make the tool work on the edit page as well as the review page.

        * PrettyPatch/PrettyPatch.rb:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed fix.
ukai@chromium.org [Fri, 23 Apr 2010 04:32:50 +0000 (04:32 +0000)]
Unreviewed fix.

* Scripts/webkitpy/layout_tests/port/websocket_server.py: fix NameError: global name 'f' is not defined.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 James Robinson <jamesr@chromium.org>
eric@webkit.org [Fri, 23 Apr 2010 04:29:05 +0000 (04:29 +0000)]
2010-04-22  James Robinson  <jamesr@chromium.org>

        Reviewed by Adam Barth.

        Revert 58077 and follow-ups.  It's broken.
        https://bugs.webkit.org/show_bug.cgi?id=37664

        * Scripts/new-run-webkit-httpd:
        * Scripts/new-run-webkit-websocketserver:
        * Scripts/webkitpy/layout_tests/port/chromium_win.py:
        * Scripts/webkitpy/layout_tests/port/http_server.py:
        * Scripts/webkitpy/layout_tests/port/websocket_server.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Michael Forney <mforney@mforney.org>
eric@webkit.org [Fri, 23 Apr 2010 04:20:01 +0000 (04:20 +0000)]
2010-04-22  Michael Forney  <mforney@mforney.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=37761

        Only include JSDatabase.h and JSDatabaseCallback.h when database is
        enabled. This partially fixes building with --disable-database.

        * bindings/js/JSDOMWindowCustom.cpp: Add a check for database around
        database-related headers.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Ray Rischpater <Raymond.Rischpater@Nokia.com>
eric@webkit.org [Fri, 23 Apr 2010 03:39:56 +0000 (03:39 +0000)]
2010-04-22  Ray Rischpater  <Raymond.Rischpater@Nokia.com>

        Reviewed by Darin Adler.

        In HTMLInputElement.cpp, shouldUseInputMethod does not return true for
        some text input types (TELEPHONE, NUMBER, URL, and EMAIL). Addressed
        this by changing shouldUseInputMethod to use internal methods to
        check that the field is a text field that isn't a password field.

        No new tests.

        Fixes <https://bugs.webkit.org/show_bug.cgi?id=37719>

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::shouldUseInputMethod):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Yaar Schnitman <yaar@chromium.org>
eric@webkit.org [Fri, 23 Apr 2010 03:30:22 +0000 (03:30 +0000)]
2010-04-22  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Adam Barth.

        Integrate v8 testing utility with webkit tests
        https://bugs.webkit.org/show_bug.cgi?id=37731

        * bindings/v8/test/run_tests.py: Removed.
2010-04-22  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Adam Barth.

        Integrate v8 testing utility with webkit tests
        https://bugs.webkit.org/show_bug.cgi?id=37731

        * Scripts/run-bindings-tests: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Steve Block <steveblock@google.com>
eric@webkit.org [Fri, 23 Apr 2010 03:10:48 +0000 (03:10 +0000)]
2010-04-22  Steve Block  <steveblock@google.com>

        Reviewed by Adam Barth.

        Update Android to use isfinite, isinf, isnan and signbit from namespace std.
        https://bugs.webkit.org/show_bug.cgi?id=37948

        * wtf/MathExtras.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 John Pavan <john.pavan@nokia.com>
eric@webkit.org [Fri, 23 Apr 2010 02:52:22 +0000 (02:52 +0000)]
2010-04-22  John Pavan  <john.pavan@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] inputMethodQuery returns coordinates in web page coordinates rather than in item coordinates.
        https://bugs.webkit.org/show_bug.cgi?id=37163

        QWebPage::inputMethodQuery is modified so that it
        returns coordinates in the widget's coordinate system.
        Tests are added for QGraphicsWebView and QWebView
        to verify that this behavior is correct after the webpage
        has been scrolled.

        * Api/qwebpage.cpp:
        (QWebPage::inputMethodQuery):
        * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
        (tst_QGraphicsWebView::microFocusCoordinates):
        * tests/qwebview/tst_qwebview.cpp:
        (tst_QWebView::microFocusCoordinates):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Zhenyao Mo <zmo@google.com>
eric@webkit.org [Fri, 23 Apr 2010 02:07:07 +0000 (02:07 +0000)]
2010-04-22  Zhenyao Mo  <zmo@google.com>

        Reviewed by Darin Fisher.

        Add isGLES2Compliant to GraphicsContext3D
        https://bugs.webkit.org/show_bug.cgi?id=37872

        * html/canvas/WebGLRenderingContext.cpp: Add isGLES2Compliant().
        (WebCore::WebGLRenderingContext::isGLES2Compliant):
        * html/canvas/WebGLRenderingContext.h: Ditto.
        * platform/graphics/GraphicsContext3D.h: Ditto.
        * platform/graphics/mac/GraphicsContext3DMac.cpp: Ditto.
        (WebCore::GraphicsContext3D::isGLES2Compliant):
2010-04-22  Zhenyao Mo  <zmo@google.com>

        Reviewed by Darin Fisher.

        Add isGLES2Compliant to GraphicsContext3D
        https://bugs.webkit.org/show_bug.cgi?id=37872

        * public/WebGraphicsContext3D.h: Add isGLES2Compliant().
        * src/GraphicsContext3D.cpp: Ditto.
        * src/WebGraphicsContext3DDefaultImpl.cpp: Ditto.
        (WebKit::WebGraphicsContext3DDefaultImpl::isGLES2Compliant):
        * src/WebGraphicsContext3DDefaultImpl.h: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 23 Apr 2010 01:55:53 +0000 (01:55 +0000)]
2010-04-22  Eric Seidel  <eric@webkit.org>

        Reviewed by Dimitri Glazkov.

        new-run-webkit-tests --verbose shows ever-increasing #EOF lines
        https://bugs.webkit.org/show_bug.cgi?id=37794

        * Scripts/webkitpy/layout_tests/port/webkit.py:
         - Remove the assert() since our ServerProcess code does not always
           seem to be reading the full stderr output (or we're not waiting for it to).

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed build fix.
ukai@chromium.org [Fri, 23 Apr 2010 01:32:22 +0000 (01:32 +0000)]
Unreviewed build fix.

* wtf/MD5.cpp: fix include path of CString.h

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Fri, 23 Apr 2010 01:31:06 +0000 (01:31 +0000)]
2010-04-22  Yuzo Fujishima  <yuzo@google.com>

        Unreviewed. Chromium test expectation change.

        Mark fast/events/touch/send-oncancel-event.html as failing (TEXT).
        https://bugs.webkit.org/show_bug.cgi?id=38020

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Fri, 23 Apr 2010 01:13:42 +0000 (01:13 +0000)]
2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Adam Barth.

        MD5 is required for WebSocket new protocol implementation
        https://bugs.webkit.org/show_bug.cgi?id=37913

        * GNUmakefile.am:
        * JavaScriptCore.exp:
        * JavaScriptCore.gypi:
        * JavaScriptCore.pro:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * JavaScriptCore.vcproj/WTF/WTF.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * wtf/MD5.cpp: Added.
        * wtf/MD5.h: Added.
2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Adam Barth.

        MD5 is required for WebSocket new protocol implementation
        https://bugs.webkit.org/show_bug.cgi?id=37913

        * ForwardingHeaders/wtf/MD5.h: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemove an assert. (It's not valid when resizing).
andersca@apple.com [Fri, 23 Apr 2010 00:44:26 +0000 (00:44 +0000)]
Remove an assert. (It's not valid when resizing).

Reviewed by Sam Weinig.

* WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp:
(WebKit::DrawingAreaUpdateChunk::didUpdate):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoErrk, accidentally committed commenting out two ASSERTs! reverting.
barraclough@apple.com [Fri, 23 Apr 2010 00:16:22 +0000 (00:16 +0000)]
Errk, accidentally committed commenting out two ASSERTs! reverting.

Reviewed by NOBODY (build fix).

* runtime/Collector.cpp:
(JSC::Heap::protect):
(JSC::Heap::unprotect):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agohttps://bugs.webkit.org/show_bug.cgi?id=38006
barraclough@apple.com [Fri, 23 Apr 2010 00:11:37 +0000 (00:11 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=38006
Change lifetime of JSC::IdentifierTables used by WebCores to match AtomicStringTable

Reviewed by Geoff Garen.

Presently JSC's IdentifierTables are owned by the JSGlobalData.  For
JSGlobalData objects created via the API this should continue to be the case,
but for the JSGlobalData objects used by WebCore (the main thread's common
global data, and those for workers) use a IdentifierTable provided (and owned)
by wtfThreadData.  This allow the lifetime of these IdentifierTable to match
those of the corresponding AtomicStringTables.

* API/APIShims.h:
(JSC::APIEntryShim::APIEntryShim):
* API/JSContextRef.cpp:
(JSContextGroupCreate):
* runtime/Collector.cpp:
(JSC::Heap::protect):
(JSC::Heap::unprotect):
(JSC::Heap::markRoots):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):
(JSC::JSGlobalData::createContextGroup):
(JSC::JSGlobalData::create):
(JSC::JSGlobalData::sharedInstance):
* runtime/JSGlobalData.h:
(JSC::JSGlobalData::):
(JSC::JSGlobalData::isSharedInstance):
* runtime/JSLock.cpp:
(JSC::JSLock::JSLock):
(JSC::JSLock::lock):
(JSC::JSLock::unlock):
(JSC::JSLock::DropAllLocks::DropAllLocks):
* wtf/WTFThreadData.cpp:
(WTF::WTFThreadData::WTFThreadData):
(WTF::WTFThreadData::~WTFThreadData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@apple.com [Fri, 23 Apr 2010 00:08:37 +0000 (00:08 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=38012
        REGRESSION: Ctrl- and Option- shortcuts get wrong keyCode on non-QWERTY keyboard

        * platform/mac/KeyEventMac.mm: (WebCore::windowsKeyCodeForKeyEvent): Also look at unmodified
        characters, to avoid falling through to virtual key code lookup for Roman characters.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoDo not get the globaldata for the APIShim via the
barraclough@apple.com [Fri, 23 Apr 2010 00:07:38 +0000 (00:07 +0000)]
Do not get the globaldata for the APIShim via the
global object; global object construction creates identifiers
which results in the ASSERTs checking the thread data's
identifierTable has been set failing.

Rubber stamped by Sam Weinig

* JSUtils.cpp:
(unprotectGlobalObject):
(getThreadGlobalData):
(getThreadGlobalObject):
(JSGlueAPIEntry::JSGlueAPIEntry):
(JSGlueAPICallback::~JSGlueAPICallback):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoVersioning.
mrowe@apple.com [Fri, 23 Apr 2010 00:02:46 +0000 (00:02 +0000)]
Versioning.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 22 Apr 2010 23:46:56 +0000 (23:46 +0000)]
2010-04-22  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add code to help debug new-run-webkit-test hangs on the Chromium bots
        https://bugs.webkit.org/show_bug.cgi?id=38011

        I can see no reasonable way to test this change.
        Stubbing out sys._current_frames() and traceback.extract_stack
        seems folly.  Dumping real data would have line number
        (and possibly other call stack) variance between runs.

        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
         - Add _dump_thread_states and _dump_thread_states_if_necessary
           to have our main thread dump the states of all threads every
           60 seconds when running in verbose mode.
         - Better document what is going on in our main loop.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 James Robinson <jamesr@chromium.org>
jamesr@google.com [Thu, 22 Apr 2010 23:40:27 +0000 (23:40 +0000)]
2010-04-22  James Robinson  <jamesr@chromium.org>

        Unreviewed, expectations only change.
        Land chromium platform-specific results for fast/text/format-control.html

        * platform/chromium-linux/fast/text/format-control-expected.checksum: Added.
        * platform/chromium-linux/fast/text/format-control-expected.png: Added.
        * platform/chromium-mac/fast/text/format-control-expected.checksum: Added.
        * platform/chromium-win/fast/text/format-control-expected.checksum: Added.
        * platform/chromium-win/fast/text/format-control-expected.png: Added.
        * platform/chromium-win/fast/text/format-control-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
eric@webkit.org [Thu, 22 Apr 2010 23:37:17 +0000 (23:37 +0000)]
2010-04-22  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>

        Reviewed by Darin Adler.

        Fix the MSVC 64bit build.
        https://bugs.webkit.org/show_bug.cgi?id=37980

        * platform/text/TextStream.cpp:
        * platform/text/TextStream.h:
        * plugins/win/PluginViewWin.cpp:
        (WebCore::PluginView::platformStart):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMerge the prefix headers.
weinig@apple.com [Thu, 22 Apr 2010 23:35:16 +0000 (23:35 +0000)]
Merge the prefix headers.

Reviewed by Anders Carlsson.

* Configurations/BaseTarget.xcconfig:
* WebKit2.xcodeproj/project.pbxproj:
* WebKit2Prefix.h:
* WebKit2_Prefix.pch: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Leandro Pereira <leandro@profusion.mobi>
eric@webkit.org [Thu, 22 Apr 2010 23:00:23 +0000 (23:00 +0000)]
2010-04-22  Leandro Pereira  <leandro@profusion.mobi>

        Reviewed by Gustavo Noronha Silva.

        Implement findThemePath to locate the correct theme file instead of
        relying on a hardcoded location.
        http://webkit.org/b/37996

        * efl/EWebLauncher/main.c:
        (findThemePath): Fix to locate the correct theme files.
        (main): Use findThemePath() instead of a hardcoded one.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoDon't pass the new size when calling didSetSize, it's possible to get
andersca@apple.com [Thu, 22 Apr 2010 22:58:08 +0000 (22:58 +0000)]
Don't pass the new size when calling didSetSize, it's possible to get
the size from the update chunk.

Reviewed by Sam Weinig.

* UIProcess/mac/DrawingAreaProxyUpdateChunk.h:
* UIProcess/mac/DrawingAreaProxyUpdateChunk.mm:
(WebKit::DrawingAreaProxyUpdateChunk::didSetSize):
(WebKit::DrawingAreaProxyUpdateChunk::didReceiveMessage):
* WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp:
(WebKit::DrawingAreaUpdateChunk::setSize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Leandro Pereira <leandro@profusion.mobi>
eric@webkit.org [Thu, 22 Apr 2010 22:51:09 +0000 (22:51 +0000)]
2010-04-22  Leandro Pereira  <leandro@profusion.mobi>

        Reviewed by Gustavo Noronha Silva.

        Update efl/ewebkit.pc.in to match the variable substitution syntax
        of CMake.
        http://webkit.org/b/37999

        * efl/ewebkit.pc.in: Updated.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Leandro Pereira <leandro@profusion.mobi>
eric@webkit.org [Thu, 22 Apr 2010 22:41:32 +0000 (22:41 +0000)]
2010-04-22  Leandro Pereira  <leandro@profusion.mobi>

        Reviewed by Gustavo Noronha Silva.

        Update EWebKit (EFL port) to match recent API changes.
        http://webkit.org/b/37997

        * efl/ewk/ewk_frame.cpp:
        (ewk_frame_zoom_set): Change to use WebCore::ZoomMode.
        (ewk_frame_zoom_text_only_set): Change to use WebCore::ZoomMode.
        (_ewk_frame_handle_key_scrolling): s/WebCore::VK_/VK_/g
        (ewk_frame_plugin_create): Disable temporarily PluginView-related
        code until a proper plugin implementation is made.
        * efl/ewk/ewk_view.cpp: Fix typo in _parent_sc declaration.
        (ewk_view_selection_get): Fix a reference to WebCore::CString to
        WTF::CString.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Rubber-stamped by Mark Rowe.
ap@apple.com [Thu, 22 Apr 2010 22:33:13 +0000 (22:33 +0000)]
    Rubber-stamped by Mark Rowe.

        <rdar://problem/7805969> REGRESSION: iTunes unable to play trailers

        Undo the changes made for https://bugs.webkit.org/show_bug.cgi?id=35215 (<rdar://problem/7673157>)
        for now. Clients rely on the old behavior, so a fix that changes it will need to account for
        those.

        * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): Pass pluginURL
        instead of baseURL again.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRename SetFrame and DidSetFrame to SetSize and DidSetSize.
andersca@apple.com [Thu, 22 Apr 2010 22:09:03 +0000 (22:09 +0000)]
Rename SetFrame and DidSetFrame to SetSize and DidSetSize.

Reviewed by Sam Weinig.

* Shared/CoreIPCSupport/DrawingAreaMessageKinds.h:
(DrawingAreaMessage::):
* Shared/CoreIPCSupport/DrawingAreaProxyMessageKinds.h:
(DrawingAreaProxyMessage::):
* UIProcess/mac/DrawingAreaProxyUpdateChunk.mm:
(WebKit::DrawingAreaProxyUpdateChunk::drawRectIntoContext):
(WebKit::DrawingAreaProxyUpdateChunk::setSize):
(WebKit::DrawingAreaProxyUpdateChunk::didReceiveMessage):
* WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp:
(WebKit::DrawingAreaUpdateChunk::setSize):
(WebKit::DrawingAreaUpdateChunk::didReceiveMessage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Sheriff Bot <webkit.review.bot@gmail.com>
eric@webkit.org [Thu, 22 Apr 2010 21:44:46 +0000 (21:44 +0000)]
2010-04-22  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r58110.
        http://trac.webkit.org/changeset/58110
        https://bugs.webkit.org/show_bug.cgi?id=38007

        Caused an internal compiler error on Qt (Requested by abarth
        on #webkit).

        * wtf/MathExtras.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=38002
weinig@apple.com [Thu, 22 Apr 2010 20:56:25 +0000 (20:56 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=38002
Add rudimentary statistics gathering for WebKit2

Reviewed by Anders Carlsson.

WebKit2:

* UIProcess/API/C/WKContext.cpp:
(WKContextGetStatistics):
* UIProcess/API/C/WKContextPrivate.h: Copied from WebKit2/UIProcess/API/C/WKContext.h.
* UIProcess/API/C/WKPageNamespace.cpp:
(WKPageNamespaceGetContext):
* UIProcess/API/C/WKPageNamespace.h:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::getStatistics):
* UIProcess/WebContext.h:
* UIProcess/WebPageNamespace.cpp:
(WebKit::WebPageNamespace::getStatistics):
* UIProcess/WebPageNamespace.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::getStatistics):
* UIProcess/WebPageProxy.h:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::numberOfPages):
* UIProcess/WebProcessProxy.h:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:

WebKitTools:

* MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
* MiniBrowser/mac/AppDelegate.h:
* MiniBrowser/mac/AppDelegate.m:
(-[BrowserAppDelegate init]):
(-[BrowserAppDelegate newWindow:]):
(-[BrowserAppDelegate getCurrentPageNamespace]):
(-[BrowserAppDelegate _setProcessModel:]):
(-[BrowserAppDelegate showStatisticsWindow:]):
(-[BrowserAppDelegate applicationWillTerminate:]):
* MiniBrowser/mac/BrowserStatisticsWindow.xib: Added.
* MiniBrowser/mac/BrowserStatisticsWindowController.h: Added.
* MiniBrowser/mac/BrowserStatisticsWindowController.m: Added.
(-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
(-[BrowserStatisticsWindowController dealloc]):
(-[BrowserStatisticsWindowController windowDidLoad]):
(-[BrowserStatisticsWindowController refreshStatistics:]):
* MiniBrowser/mac/BrowserWindowController.h:
* MiniBrowser/mac/English.lproj/MainMenu.xib:
* MiniBrowser/mac/MiniBrowser_Prefix.pch:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago* API/JSWeakObjectMapRefPrivate.cpp:
barraclough@apple.com [Thu, 22 Apr 2010 20:50:36 +0000 (20:50 +0000)]
* API/JSWeakObjectMapRefPrivate.cpp:

Reviewed by NOBODY (windows build fix).

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago* API/JSBase.cpp:
barraclough@apple.com [Thu, 22 Apr 2010 20:42:57 +0000 (20:42 +0000)]
* API/JSBase.cpp:
* API/JSCallbackObject.cpp:

Reviewed by NOBODY (windows build fix).

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agohttps://bugs.webkit.org/show_bug.cgi?id=37978
barraclough@apple.com [Thu, 22 Apr 2010 20:31:04 +0000 (20:31 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=37978
Unify JSC::IdentifierTable and WebCore::AtomicStringTable implementations.

Reviewed by Geoff Garen.

These two classes both implement a HashSet of uniqued StringImpls, with
translator classes to avoid unnecessary object creation. The only difference
between the classes is which flag (isIdentifier or inTable) is set.
Combine the two classes using a template predicated on which flag to use.

New class AtomicStringTable created, containing all the goodness from
IdentifierTable & AtomicStringTable, expect for Identifier's literalTable,
which has been moved onto JSGlobalData. Removed duplicate string translator
classes. Renamed StringImpl's inTable flag to more explicit 'isAtomic',
and set this on the empty string (which matches Identifier behaviour, and
removes a redundant check for zero-length).

* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/Identifier.cpp:
(JSC::createLiteralTable):
(JSC::deleteLiteralTable):
(JSC::Identifier::add):
(JSC::Identifier::addSlowCase):
* runtime/Identifier.h:
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):
* runtime/JSGlobalData.h:
* wtf/WTFThreadData.cpp:
(WTF::WTFThreadData::WTFThreadData):
(WTF::WTFThreadData::~WTFThreadData):
* wtf/WTFThreadData.h:
(WTF::WTFThreadData::atomicStringTable):
* wtf/text/AtomicString.cpp:
(WebCore::table):
(WebCore::operator==):
(WebCore::AtomicString::add):
(WebCore::AtomicString::find):
(WebCore::AtomicString::remove):
* wtf/text/AtomicStringTable.h: Added.
(WTF::CStringTranslator::hash):
(WTF::CStringTranslator::equal):
(WTF::CStringTranslator::translate):
(WTF::UCharBufferTranslator::hash):
(WTF::UCharBufferTranslator::equal):
(WTF::UCharBufferTranslator::translate):
(WTF::HashAndCharactersTranslator::hash):
(WTF::HashAndCharactersTranslator::equal):
(WTF::HashAndCharactersTranslator::translate):
(WTF::IdentifierOrAtomicStringTable::remove):
(WTF::::~IdentifierOrAtomicStringTable):
(WTF::::add):
(WTF::::find):
* wtf/text/StringImpl.cpp:
(WebCore::StringImpl::~StringImpl):
* wtf/text/StringImpl.h:
(WebCore::StringImpl::isAtomic):
(WebCore::StringImpl::setIsAtomic):
(WebCore::equal):
* wtf/text/StringImplBase.h:
(WTF::StringImplBase::StringImplBase):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 MORITA Hajime <morrita@google.com>
morrita@google.com [Thu, 22 Apr 2010 20:17:22 +0000 (20:17 +0000)]
2010-04-22  MORITA Hajime <morrita@google.com>

        Not reviewed.

        Picked a review feedback left on:
        https://bugs.webkit.org/show_bug.cgi?id=37056
        LayoutTests/editing/selection/move-left-right.html is slow

        * editing/selection/move-left-right.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Fix createPlugin() tests in tst_qwebpage to match behaviour of Qt plugins
robert@webkit.org [Thu, 22 Apr 2010 20:12:20 +0000 (20:12 +0000)]
[Qt] Fix createPlugin() tests in tst_qwebpage to match behaviour of Qt plugins
     when PluginsEnabled is false.

2010-04-22  Robert Hogan  <robert@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt] Fix createPlugin() tests in tst_qwebpage to match behaviour of Qt plugins
             when PluginsEnabled is false.

        tst_qwebpage should have been updated as part of r56662.
        (See https://bugs.webkit.org/show_bug.cgi?id=32196)

        Updated documentation of QWebPage::createPlugin and QWebSetting::pluginsEnabled
            to match the new behaviour.

        * Api/qwebpage.cpp: Update docs.
        * Api/qwebsettings.cpp: Update docs.
        * tests/qwebpage/tst_qwebpage.cpp:
        (createPlugin):
        (tst_QWebPage::createPluginWithPluginsEnabled):
        (tst_QWebPage::createPluginWithPluginsDisabled):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Dave Moore <davemoore@chromium.org>
dglazkov@chromium.org [Thu, 22 Apr 2010 20:03:39 +0000 (20:03 +0000)]
2010-04-22  Dave Moore  <davemoore@chromium.org>

        Reviewed by Dimitri Glazkov.

        Add test for icon change notifications.

        https://bugs.webkit.org/show_bug.cgi?id=33812

        * fast/dom/icon-url-property-expected.txt: Added.
        * fast/dom/icon-url-property.html: Added.
        * Skipped on all platforms but Win
2010-04-22  Dave Moore  <davemoore@chromium.org>

        Reviewed by Dimitri Glazkov.

        Added notification when the favicons for a page are changed
        from a script.
        The Document object will notify the frame loader, which will
        notify the client. Implementations of FrameLoaderClient will
        have to add one method; dispatchDidChangeIcons().

        https://bugs.webkit.org/show_bug.cgi?id=33812

        Test: fast/dom/icon-url-property.html

        * dom/Document.cpp:
        (WebCore::Document::setIconURL):
        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::setIconURL):
        * loader/DocumentLoader.h:
        (WebCore::DocumentLoader::iconURL):
        * loader/EmptyClients.h:
        (WebCore::EmptyFrameLoaderClient::dispatchDidChangeIcons):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::setIconURL):
        (WebCore::FrameLoader::didChangeIcons):
        * loader/FrameLoader.h:
        * loader/FrameLoaderClient.h:
2010-04-22  Dave Moore  <davemoore@chromium.org>

        Reviewed by Dimitri Glazkov.

        Added notification when the favicons for a page are changed
        from a script.
        The Document object will notify the frame loader, which will
        notify the client. Implementations of FrameLoaderClient will
        have to add one method; dispatchDidChangeIcons().

        https://bugs.webkit.org/show_bug.cgi?id=33812

        * public/WebFrameClient.h:
        (WebKit::WebFrameClient::didChangeIcons):
        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::dispatchDidChangeIcons):
        * src/FrameLoaderClientImpl.h:
2010-04-22  Dave Moore  <davemoore@chromium.org>

        Reviewed by Dimitri Glazkov.

        Added notification when the favicons for a page are changed
        from a script.
        The Document object will notify the frame loader, which will
        notify the client. Implementations of FrameLoaderClient will
        have to add one method; dispatchDidChangeIcons().

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::dispatchDidChangeIcons):
        * WebCoreSupport/FrameLoaderClientGtk.h:
2010-04-22  Dave Moore  <davemoore@chromium.org>

        Reviewed by Dimitri Glazkov.

        Added notification when the favicons for a page are changed
        from a script.
        The Document object will notify the frame loader, which will
        notify the client. Implementations of FrameLoaderClient will
        have to add one method; dispatchDidChangeIcons().

        https://bugs.webkit.org/show_bug.cgi?id=33812

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::dispatchDidChangeIcons):
2010-04-22  Dave Moore  <davemoore@chromium.org>

        Reviewed by Dimitri Glazkov.

        Added notification when the favicons for a page are changed
        from a script.
        The Document object will notify the frame loader, which will
        notify the client. Implementations of FrameLoaderClient will
        have to add one method; dispatchDidChangeIcons().

        https://bugs.webkit.org/show_bug.cgi?id=33812

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::dispatchDidChangeIcons):
        (WebCore::FrameLoaderClientQt::didChangeTitle):
        * WebCoreSupport/FrameLoaderClientQt.h:
2010-04-22  Dave Moore  <davemoore@chromium.org>

        Reviewed by Dimitri Glazkov.

        Added notification when the favicons for a page are changed
        from a script.
        The Document object will notify the frame loader, which will
        notify the client. Implementations of FrameLoaderClient will
        have to add one method; dispatchDidChangeIcons().

        https://bugs.webkit.org/show_bug.cgi?id=33812

        * Interfaces/IWebFrameLoadDelegatePrivate2.idl:
        * WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebFrameLoaderClient::dispatchDidChangeIcons):
        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebFrame.cpp:
        (WebFrame::didChangeIcons):
        * WebFrame.h:
2010-04-22  Dave Moore  <davemoore@chromium.org>

        Reviewed by Dimitri Glazkov.

        Add test support for icon changes.

        https://bugs.webkit.org/show_bug.cgi?id=33812

        * DumpRenderTree/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (dumpIconChangesCallback):
        (LayoutTestController::staticFunctions):
        * DumpRenderTree/LayoutTestController.h:
        (LayoutTestController::dumpIconChanges):
        (LayoutTestController::setDumpIconChanges):
        * DumpRenderTree/win/FrameLoadDelegate.cpp:
        (FrameLoadDelegate::didChangeIcons):
        * DumpRenderTree/win/FrameLoadDelegate.h:
        * WinLauncher/WinLauncher.h:
        (WinLauncherWebHost::didChangeIcons):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Steve Block <steveblock@google.com>
steveblock@google.com [Thu, 22 Apr 2010 19:55:09 +0000 (19:55 +0000)]
2010-04-22  Steve Block  <steveblock@google.com>

        Reviewed by Adam Barth.

        Update Android to use isfinite, isinf, isnan and signbit from namespace std.
        https://bugs.webkit.org/show_bug.cgi?id=37948

        * wtf/MathExtras.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Thu, 22 Apr 2010 19:46:08 +0000 (19:46 +0000)]
2010-04-22  Eric Carlson  <eric.carlson@apple.com>

        Test fix, no review.

        https://bugs.webkit.org/show_bug.cgi?id=38000
        r58107 causes video-play-stall and video-play-stall-seek to fail

        Skip http/tests/media/video-play-stall.html and http/tests/media/video-play-stall-seek.html
        until we can figure out how to work around QuickTime bug.

        * platform/mac-leopard/Skipped:
        * platform/mac-tiger/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
xan@webkit.org [Thu, 22 Apr 2010 19:39:50 +0000 (19:39 +0000)]
WebCore:

2010-04-22  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] GObject DOM bindings
        https://bugs.webkit.org/show_bug.cgi?id=33590

        Extend the bindings to cover most of Document.idl

        * GNUmakefile.am:
        * bindings/gobject/WebKitDOMBinding.cpp:
        (WebKit::createWrapper):
        (WebKit::kit):
        * bindings/gobject/WebKitDOMBinding.h:
        * bindings/gobject/WebKitHTMLElementWrapperFactory.cpp: Added.
        (WebKit::createAnchorWrapper):
        (WebKit::createAppletWrapper):
        (WebKit::createAreaWrapper):
        (WebKit::createBaseWrapper):
        (WebKit::createBaseFontWrapper):
        (WebKit::createBlockquoteWrapper):
        (WebKit::createBodyWrapper):
        (WebKit::createBRWrapper):
        (WebKit::createButtonWrapper):
        (WebKit::createCanvasWrapper):
        (WebKit::createTableCaptionWrapper):
        (WebKit::createTableColWrapper):
        (WebKit::createModWrapper):
        (WebKit::createDirectoryWrapper):
        (WebKit::createDivWrapper):
        (WebKit::createDListWrapper):
        (WebKit::createEmbedWrapper):
        (WebKit::createFieldSetWrapper):
        (WebKit::createFontWrapper):
        (WebKit::createFormWrapper):
        (WebKit::createFrameWrapper):
        (WebKit::createFrameSetWrapper):
        (WebKit::createHeadingWrapper):
        (WebKit::createHeadWrapper):
        (WebKit::createHRWrapper):
        (WebKit::createHtmlWrapper):
        (WebKit::createIFrameWrapper):
        (WebKit::createImageWrapper):
        (WebKit::createInputWrapper):
        (WebKit::createIsIndexWrapper):
        (WebKit::createLabelWrapper):
        (WebKit::createLegendWrapper):
        (WebKit::createLIWrapper):
        (WebKit::createLinkWrapper):
        (WebKit::createMapWrapper):
        (WebKit::createMarqueeWrapper):
        (WebKit::createMenuWrapper):
        (WebKit::createMetaWrapper):
        (WebKit::createObjectWrapper):
        (WebKit::createOListWrapper):
        (WebKit::createOptGroupWrapper):
        (WebKit::createOptionWrapper):
        (WebKit::createParagraphWrapper):
        (WebKit::createParamWrapper):
        (WebKit::createPreWrapper):
        (WebKit::createQuoteWrapper):
        (WebKit::createScriptWrapper):
        (WebKit::createSelectWrapper):
        (WebKit::createStyleWrapper):
        (WebKit::createTableWrapper):
        (WebKit::createTableSectionWrapper):
        (WebKit::createTableCellWrapper):
        (WebKit::createTextAreaWrapper):
        (WebKit::createTitleWrapper):
        (WebKit::createTableRowWrapper):
        (WebKit::createUListWrapper):
        (WebKit::createHTMLElementWrapper):
        * bindings/gobject/WebKitHTMLElementWrapperFactory.h: Added.
        * bindings/scripts/CodeGeneratorGObject.pm:
        * dom/Node.idl:

WebKit/gtk:

2010-04-22  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] GObject DOM bindings
        https://bugs.webkit.org/show_bug.cgi?id=33590

        Add webkit_web_view_get_document to retrieve the WebKitDOMDocument
        from a WebKitWebView, and a very simple test for it.

        * tests/testwebview.c:
        * webkit/webkitwebview.cpp:
        (webkit_web_view_get_document):
        * webkit/webkitwebview.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Thu, 22 Apr 2010 18:06:07 +0000 (18:06 +0000)]
2010-04-22  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        Do not pause movie when readyState drops below HAVE_FUTURE_DATA
        https://bugs.webkit.org/show_bug.cgi?id=37991
        <rdar://problem/7893937>

        No new tests, we don't have infrastructure in DRT to test with streamed
        movies.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_readyStateMaximum.
        (WebCore::HTMLMediaElement::prepareForLoad): Reset m_readyStateMaximum.
        (WebCore::HTMLMediaElement::setReadyState): Maintain m_readyStateMaximum.
        (WebCore::HTMLMediaElement::potentiallyPlaying): Also return true if the readyState was
        previously >= HAVE_FUTURE_DATA.
        * html/HTMLMediaElement.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Leandro Pereira <leandro@profusion.mobi>
eric@webkit.org [Thu, 22 Apr 2010 17:57:25 +0000 (17:57 +0000)]
2010-04-22  Leandro Pereira  <leandro@profusion.mobi>

        Reviewed by Gustavo Noronha Silva.

        Update EFL port files to match recent API changes.
        http://webkit.org/b/37876

        * efl/WebCoreSupport/ChromeClientEfl.cpp:
        (kit): Added.
        (WebCore::ChromeClientEfl::ChromeClientEfl): Coding style fix.
        (WebCore::ChromeClientEfl::runBeforeUnloadConfirmPanel): Coding
        style fix.
        (WebCore::ChromeClientEfl::mouseDidMoveOverElement): Coding style fix.
        (WebCore::ChromeClientEfl::runOpenPanel): Implemented.
        (WebCore::ChromeClientEfl::cancelGeolocationPermissionRequestForFrame): Stubbed.
        (WebCore::ChromeClientEfl::cancelGeolocationPermissionForFrame): Stubbed.
        (WebCore::ChromeClientEfl::invalidateContents): Stubbed.
        (WebCore::ChromeClientEfl::invalidateWindow): Stubbed.
        (WebCore::ChromeClientEfl::invalidateContentsAndWindow): Implemented.
        (WebCore::ChromeClientEfl::invalidateContentsForSlowScroll): Implemented.
        (WebCore::ChromeClientEfl::scroll): Updated.
        (WebCore::ChromeClientEfl::iconForFiles): Stubbed.
        (WebCore::ChromeClientEfl::chooseIconForFiles): Stubbed.
        * efl/WebCoreSupport/ChromeClientEfl.h: Add new method prototypes.
        * efl/WebCoreSupport/FrameLoaderClientEfl.cpp:
        (WebCore::FrameLoaderClientEfl::committedLoad): Call setEncoding()
        from FrameLoader::writer.
        (WebCore::FrameLoaderClientEfl::finishedLoading): Ditto.
        (WebCore::FrameLoaderClientEfl::dispatchDidFailLoading): Ditto.
        (WebCore::FrameLoaderClientEfl::setMainDocumentError): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
eric@webkit.org [Thu, 22 Apr 2010 17:32:57 +0000 (17:32 +0000)]
2010-04-22  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Remove translatable strings from the hybridPixmap test.
        https://bugs.webkit.org/show_bug.cgi?id=37867

        * tests/hybridPixmap/widget.ui:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
eric@webkit.org [Thu, 22 Apr 2010 17:13:32 +0000 (17:13 +0000)]
2010-04-22  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Remove dependency of JSC to QtGui
        https://bugs.webkit.org/show_bug.cgi?id=37867

        The patch also make sure that hal.h is in the include path on Symbian.
        The dependency to QtGui took care of that before.

        Patch by Thiago Macieira <thiago.macieira@nokia.com>
             and Rohan McGovern <rohan.mcgovern@nokia.com>

        * JavaScriptCore.pri:
        * JavaScriptCore.pro:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Zhenyao Mo <zmo@google.com>
eric@webkit.org [Thu, 22 Apr 2010 17:04:06 +0000 (17:04 +0000)]
2010-04-22  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        Regression: framebufferRenderbuffer crashes with null renderBuffer
        https://bugs.webkit.org/show_bug.cgi?id=37963

        * fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Adding test cases for null renderbuffer input.
        * fast/canvas/webgl/framebuffer-object-attachment.html: Ditto.
2010-04-22  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        Regression: framebufferRenderbuffer crashes with null renderBuffer
        https://bugs.webkit.org/show_bug.cgi?id=37963

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::framebufferRenderbuffer): Dealing with null renderbuffer input.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Zhenyao Mo <zmo@google.com>
eric@webkit.org [Thu, 22 Apr 2010 16:54:00 +0000 (16:54 +0000)]
2010-04-22  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        Emulate GL_IMPLEMENTATION_COLOR_READ_FORMAT/TYPE for glGet
        https://bugs.webkit.org/show_bug.cgi?id=37281

        * fast/canvas/webgl/read-pixels-expected.txt: Add test case for the other supported format/type in readPixels (besides RGBA/UNSIGNED_BYTE); also, changed to a simpler test framework.
        * fast/canvas/webgl/read-pixels.html: Ditto.
2010-04-22  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        Emulate GL_IMPLEMENTATION_COLOR_READ_FORMAT/TYPE for glGet
        https://bugs.webkit.org/show_bug.cgi?id=37281

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::WebGLRenderingContext): Remove error check because two enums are supported now.
        (WebCore::WebGLRenderingContext::getParameter): Add two enums.
        (WebCore::WebGLRenderingContext::readPixels): Fix a tiny bug.
        * platform/graphics/mac/GraphicsContext3DMac.cpp:
        (WebCore::GraphicsContext3D::getIntegerv): Emulate two enums.
2010-04-22  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        Emulate GL_IMPLEMENTATION_COLOR_READ_FORMAT/TYPE for glGet
        https://bugs.webkit.org/show_bug.cgi?id=37281

        * src/WebGraphicsContext3DDefaultImpl.cpp:
        (WebKit::WebGraphicsContext3DDefaultImpl::getIntegerv): Emulate two  enums.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 22 Apr 2010 16:50:00 +0000 (16:50 +0000)]
2010-04-22  Adam Barth  <abarth@webkit.org>

        Unreviewed.  Turns out we need to do more escaping because Ruby was
        explanding our newlines, creating a syntax error.

        * PrettyPatch/PrettyPatch.rb:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
eric@webkit.org [Thu, 22 Apr 2010 16:38:15 +0000 (16:38 +0000)]
2010-04-22  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>

        Reviewed by Tor Arne Vestbø.

        [Qt] Corrects symbols visibility for JavaScriptCore.

        https://bugs.webkit.org/show_bug.cgi?id=37867

        * JavaScriptCore.pro:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Marcus Bulach <bulach@chromium.org>
eric@webkit.org [Thu, 22 Apr 2010 16:28:51 +0000 (16:28 +0000)]
2010-04-22  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Dimitri Glazkov.

        Enable LayoutTests for EventSource on chromium
        https://bugs.webkit.org/show_bug.cgi?id=37863

        * platform/chromium/fast/dom/prototype-inheritance-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Diego Escalante Urrelo <descalante@igalia.com>
eric@webkit.org [Thu, 22 Apr 2010 15:46:20 +0000 (15:46 +0000)]
2010-04-22  Diego Escalante Urrelo  <descalante@igalia.com>

        Reviewed by Xan Lopez.

        [Gtk] Evaluate and create tests for all the AtkRole's implemented by
        WebKitGtk
        https://bugs.webkit.org/show_bug.cgi?id=34449

        Expand testatkroles to test ATK_ROLE_COMBO_BOX.

        * tests/testatkroles.c:
        (test_webkit_atk_get_role_combobox):
        (main):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Diego Escalante Urrelo <descalante@igalia.com>
eric@webkit.org [Thu, 22 Apr 2010 15:36:42 +0000 (15:36 +0000)]
2010-04-22  Diego Escalante Urrelo  <descalante@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Mute/unmute button on <video> elements are backwards
        https://bugs.webkit.org/show_bug.cgi?id=33967

        Fix mute/unmute buttons icons-action relation and explain why their
        variable names and corresponding icons seem to be misleading but are
        actually right. Original patch by Mike Hommey.

        * platform/gtk/RenderThemeGtk.cpp:
        (WebCore::RenderThemeGtk::initMediaStyling):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
eric@webkit.org [Thu, 22 Apr 2010 14:56:10 +0000 (14:56 +0000)]
2010-04-22  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Fix autotests .qrc file paths when built in Qt.

        Compiling auto-tests from qt/tests/auto/qweb* produced
        failing tests since these .pro files include the
        ones in WebKit/qt/tests and the .qrc file was
        not added to RESOURCES

        * tests/benchmarks/loading/loading.pro:
        * tests/benchmarks/painting/painting.pro:
        * tests/qgraphicswebview/qgraphicswebview.pro:
        * tests/qwebelement/qwebelement.pro:
        * tests/qwebframe/qwebframe.pro:
        * tests/qwebhistory/qwebhistory.pro:
        * tests/qwebhistoryinterface/qwebhistoryinterface.pro:
        * tests/qwebinspector/qwebinspector.pro:
        * tests/qwebpage/qwebpage.pro:
        * tests/qwebplugindatabase/qwebplugindatabase.pro:
        * tests/qwebview/qwebview.pro:
        * tests/tests.pri:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Gustavo Sverzut Barbieri <barbieri@profusion.mobi>
eric@webkit.org [Thu, 22 Apr 2010 14:46:11 +0000 (14:46 +0000)]
2010-04-22  Gustavo Sverzut Barbieri  <barbieri@profusion.mobi>

        Reviewed by Eric Seidel.

        Fix build if NPAPI support is disabled
        https://bugs.webkit.org/show_bug.cgi?id=36621

        No new tests, this is a build fix.
        Re-submit r58043 with fix for EFL.

        * plugins/PluginViewNone.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Diego Escalante Urrelo <descalante@igalia.com>
eric@webkit.org [Thu, 22 Apr 2010 14:36:19 +0000 (14:36 +0000)]
2010-04-22  Diego Escalante Urrelo  <descalante@igalia.com>

        Reviewed by Xan Lopez.

        [Gtk] Evaluate and create tests for all the AtkRole's implemented by
        WebKitGtk
        https://bugs.webkit.org/show_bug.cgi?id=34449

        Implement ATK_ROLE_COMBO_BOX.

        * accessibility/gtk/AccessibilityObjectAtk.cpp:
        (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (atkRole):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 22 Apr 2010 13:50:44 +0000 (13:50 +0000)]
2010-04-22  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        SVGPaintServer needs to be converted to the new RenderSVGResource* system
        https://bugs.webkit.org/show_bug.cgi?id=37986

        No functional changes, just move the SVGPaintServer* classes from svg/graphics/ to rendering/, the new location for the RenderSVGResource* classes.
        This is a preparation for the real patch which follows soon.

        * Android.mk: Rename files and move to the right location.
        * GNUmakefile.am: Ditto.
        * WebCore.gypi: Ditto.
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * rendering/RenderSVGResource.cpp: Copied from svg/graphics/SVGPaintServer.cpp.
        * rendering/RenderSVGResourceGradient.cpp: Copied from svg/graphics/SVGPaintServerGradient.cpp.
        * rendering/RenderSVGResourceGradient.h: Copied from svg/graphics/SVGPaintServerGradient.h.
        * rendering/RenderSVGResourceLinearGradient.cpp: Copied from svg/graphics/SVGPaintServerLinearGradient.cpp.
        * rendering/RenderSVGResourceLinearGradient.h: Copied from svg/graphics/SVGPaintServerLinearGradient.h.
        * rendering/RenderSVGResourcePattern.cpp: Copied from svg/graphics/SVGPaintServerPattern.cpp.
        * rendering/RenderSVGResourcePattern.h: Copied from svg/graphics/SVGPaintServerPattern.h.
        * rendering/RenderSVGResourceRadialGradient.cpp: Copied from svg/graphics/SVGPaintServerRadialGradient.cpp.
        * rendering/RenderSVGResourceRadialGradient.h: Copied from svg/graphics/SVGPaintServerRadialGradient.h.
        * rendering/RenderSVGResourceSolidColor.cpp: Copied from svg/graphics/SVGPaintServerSolid.cpp.
        * rendering/RenderSVGResourceSolidColor.h: Copied from svg/graphics/SVGPaintServerSolid.h.
        * rendering/SVGRenderTreeAsText.cpp: Change include file names.
        * svg/SVGFont.cpp: Ditto.
        * svg/SVGGradientElement.cpp: Ditto.
        * svg/SVGGradientElement.h: Ditto.
        * svg/SVGLinearGradientElement.cpp: Ditto.
        * svg/SVGPatternElement.cpp: Ditto.
        * svg/SVGPatternElement.h: Ditto.
        * svg/SVGRadialGradientElement.cpp: Ditto.
        * svg/graphics/SVGPaintServer.cpp: Removed.
        * svg/graphics/SVGPaintServerGradient.cpp: Removed.
        * svg/graphics/SVGPaintServerGradient.h: Removed.
        * svg/graphics/SVGPaintServerLinearGradient.cpp: Removed.
        * svg/graphics/SVGPaintServerLinearGradient.h: Removed.
        * svg/graphics/SVGPaintServerPattern.cpp: Removed.
        * svg/graphics/SVGPaintServerPattern.h: Removed.
        * svg/graphics/SVGPaintServerRadialGradient.cpp: Removed.
        * svg/graphics/SVGPaintServerRadialGradient.h: Removed.
        * svg/graphics/SVGPaintServerSolid.cpp: Removed.
        * svg/graphics/SVGPaintServerSolid.h: Removed.
        * svg/graphics/SVGResourceListener.h: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
eric@webkit.org [Thu, 22 Apr 2010 13:34:38 +0000 (13:34 +0000)]
2010-04-22  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Hide the OpenGL and QtMultimedia dependencies from syncqt.

        This prevents the dependent headers from being included by
        qt/include/QtWebKit/QtWebKit

        * WebCore.pro:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Gabor Loki <loki@webkit.org>
eric@webkit.org [Thu, 22 Apr 2010 13:24:56 +0000 (13:24 +0000)]
2010-04-22  Gabor Loki  <loki@webkit.org>

        Reviewed by Gavin Barraclough.

        Use BLX and BX to keep happy the return stack predictor above ARMv4
        https://bugs.webkit.org/show_bug.cgi?id=37862

        Inspired by Jacob Bramley's patch from JaegerMonkey

        * assembler/ARMAssembler.cpp:
        (JSC::ARMAssembler::executableCopy):
        * assembler/ARMAssembler.h:
        (JSC::ARMAssembler::):
        (JSC::ARMAssembler::bx):
        (JSC::ARMAssembler::blx):
        (JSC::ARMAssembler::loadBranchTarget):
        (JSC::ARMAssembler::jmp):
        (JSC::ARMAssembler::getLdrImmAddress):
        * assembler/MacroAssemblerARM.h:
        (JSC::MacroAssemblerARM::jump):
        (JSC::MacroAssemblerARM::nearCall):
        (JSC::MacroAssemblerARM::call):
        (JSC::MacroAssemblerARM::ret):
        (JSC::MacroAssemblerARM::prepareCall):
        (JSC::MacroAssemblerARM::call32):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Zhenyao Mo <zmo@google.com>
eric@webkit.org [Thu, 22 Apr 2010 12:28:44 +0000 (12:28 +0000)]
2010-04-22  Zhenyao Mo  <zmo@google.com>

        Reviewed by Eric Seidel.

        Turn on antialias and stencil as default canvas attributes.
        https://bugs.webkit.org/show_bug.cgi?id=36972

        * fast/canvas/webgl/resources/webgl-test.js:
        (create3DContext): Turn on antialias and stencil as default canvas attributes.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Gustavo Sverzut Barbieri <barbieri@profusion.mobi>
eric@webkit.org [Thu, 22 Apr 2010 12:09:33 +0000 (12:09 +0000)]
2010-04-22  Gustavo Sverzut Barbieri  <barbieri@profusion.mobi>

        Reviewed by Adam Roben.

        EFL does not support PluginDatabase yet.
        http://webkit.org/b/37854

        No behavior changes, so no new tests were added.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::defaultObjectContentType):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 22 Apr 2010 12:08:29 +0000 (12:08 +0000)]
2010-04-22  Eric Seidel  <eric@webkit.org>

        Unreviewed.  Script fix.  Will ask dpranke to look tomorrow.

        new-run-webkit-tests --verbose shows ever-increasing #EOF lines
        https://bugs.webkit.org/show_bug.cgi?id=37794

        The bots are seeing cases where .error is sometimes empty.
        Lets make the code not crash in that case for now.

        * Scripts/webkitpy/layout_tests/port/webkit.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Ilya Tikhonovsky <loislo@chromium.org>
eric@webkit.org [Thu, 22 Apr 2010 11:21:59 +0000 (11:21 +0000)]
2010-04-22  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Timeline scrolling speed is slow if it has more than 1k timeline marks.
        https://bugs.webkit.org/show_bug.cgi?id=37924

        * inspector/front-end/TimelineGrid.js:
        (WebInspector.TimelineGrid.prototype.updateDividers):
        (WebInspector.TimelineGrid.prototype.addEventDividers):
        * inspector/front-end/TimelineOverviewPane.js:
        (WebInspector.TimelineOverviewPane.prototype.updateEventDividers):
        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel.prototype._updateEventDividers):
        (WebInspector.TimelinePanel.prototype._refresh):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed fix.
ukai@chromium.org [Thu, 22 Apr 2010 11:15:31 +0000 (11:15 +0000)]
Unreviewed fix.

* Scripts/webkitpy/layout_tests/port/websocket_server.py: fix NameError: global name 'f' is not defined.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Kenneth Rohde Christiansen <kenneth@webkit.org>
eric@webkit.org [Thu, 22 Apr 2010 11:11:56 +0000 (11:11 +0000)]
2010-04-22  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Unreviewed expected results update.

        Rename window.media to window.styleMedia
        https://bugs.webkit.org/show_bug.cgi?id=36187

        * fast/dom/Window/window-properties-expected.txt:
        * fast/dom/Window/window-property-descriptors-expected.txt:
        * fast/dom/prototype-inheritance-2-expected.txt:
        * fast/dom/prototype-inheritance-expected.txt:
        * fast/media/print-restores-previous-mediatype-expected.txt:
        * platform/chromium/fast/dom/prototype-inheritance-expected.txt:
        * platform/gtk/fast/dom/Window/window-properties-expected.txt:
        * platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
        * platform/gtk/fast/dom/prototype-inheritance-expected.txt:
        * platform/qt/fast/dom/Window/window-properties-expected.txt:
        * platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
        * platform/qt/fast/dom/prototype-inheritance-expected.txt:
        * platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
        * platform/win/fast/dom/prototype-inheritance-2-expected.txt:
        * platform/win/fast/dom/prototype-inheritance-expected.txt:
2010-04-22  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Simon Fraser.

        Rename window.media to window.styleMedia
        https://bugs.webkit.org/show_bug.cgi?id=36187

        It has been defined that the AbstractView media extension
        defined in the CSSOM View spec should be renamed to styleMedia.
        This patch does that and updates the current layout tests
        making use of it.

        * page/AbstractView.idl:
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::styleMedia):
        * page/DOMWindow.h:
        * page/DOMWindow.idl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Anton Muhin <antonm@chromium.org>
eric@webkit.org [Thu, 22 Apr 2010 10:41:05 +0000 (10:41 +0000)]
2010-04-22  Anton Muhin  <antonm@chromium.org>

        Reviewed by Adam Barth.

        [v8] Do not pass empty handle into SetHiddenValue which would crash.
        https://bugs.webkit.org/show_bug.cgi?id=37801

        * bindings/v8/V8AbstractEventListener.cpp:
        (WebCore::V8AbstractEventListener::handleEvent): add couple of asserts to check for unexpected paths
        (WebCore::V8AbstractEventListener::invokeEventHandler): bail out of jsEvent is empty handle

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Diego Escalante Urrelo <descalante@igalia.com>
eric@webkit.org [Thu, 22 Apr 2010 10:31:34 +0000 (10:31 +0000)]
2010-04-22  Diego Escalante Urrelo  <descalante@igalia.com>

        Reviewed by Xan Lopez.

        [Gtk] Evaluate and create tests for all the AtkRole's implemented by
        WebKitGtk
        https://bugs.webkit.org/show_bug.cgi?id=34449

        Expand testatkroles to test ATK_ROLE_SEPARATOR.

        * tests/testatkroles.c:
        (test_webkit_atk_get_role_separator):
        (main):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed fix.
ukai@chromium.org [Thu, 22 Apr 2010 10:19:25 +0000 (10:19 +0000)]
Unreviewed fix.

* Scripts/new-run-webkit-websocketserver: PyWebSocket no longer takes keyword argument 'register_cygwin'.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed fix.
ukai@chromium.org [Thu, 22 Apr 2010 10:00:18 +0000 (10:00 +0000)]
Unreviewed fix.

* Scripts/webkitpy/layout_tests/port/http_server.py: fix NameError: global name 'env' is not defined.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 22 Apr 2010 09:59:41 +0000 (09:59 +0000)]
2010-04-22  Eric Seidel  <eric@webkit.org>

        Unreviewed.  Restore the Leopard bots to using
        old-run-webkit-tests for now.

        * Scripts/run-webkit-tests:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed fix.
ukai@chromium.org [Thu, 22 Apr 2010 09:48:50 +0000 (09:48 +0000)]
Unreviewed fix.

* Scripts/webkitpy/layout_tests/port/websocket_server.py: fix NameError: global name 'env' is not defined.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Stephan Aßmus <superstippi@gmx.de>
eric@webkit.org [Thu, 22 Apr 2010 09:38:29 +0000 (09:38 +0000)]
2010-04-22  Stephan Aßmus  <superstippi@gmx.de>

        Reviewed by David Levin.

        [Haiku] Implement ImageBuffer support
        https://bugs.webkit.org/show_bug.cgi?id=35288

        Covered by existing tests.

        Complete implementation of ImageBuffer for Haiku. Uses StillImage
        class to export a WebCore::Image and associated GraphicsContext
        to perform arbitrary drawing in the offscreen BBitmap buffer.

        * platform/graphics/haiku/ImageBufferData.h:
        * platform/graphics/haiku/ImageBufferHaiku.cpp,
        (WebCore::ImageBufferData::ImageBufferData),
        (WebCore::ImageBufferData::~ImageBufferData),
        (WebCore::ImageBuffer::ImageBuffer),
        (WebCore::ImageBuffer::~ImageBuffer),
        (WebCore::ImageBuffer::context),
        (WebCore::ImageBuffer::image):
            Implementation uses offscreen BBitmap and BView, wraps StillImage
            around those to provide WebCore::Image interface.
        (WebCore::ImageBuffer::platformTransformColorSpace):
        (WebCore::convertFromData):
            Method just performs BGRA <-> RGBA conversion.
        (WebCore::convertFromInternalData):
            Method just performs BGRA <-> RGBA conversion and handles
            pre-multiplying the color values if requested.
        (WebCore::convertToInternalData):
            Method just performs BGRA <-> RGBA conversion and handles
            de.multiplying the color values if requested.
        (WebCore::getImageData):
            Common code for the next two methods.
        (WebCore::ImageBuffer::getUnmultipliedImageData),
        (WebCore::ImageBuffer::getPremultipliedImageData):
            Implemented.
        (WebCore::putImageData):
            Common code for the next two methods.
        (WebCore::ImageBuffer::putUnmultipliedImageData),
        (WebCore::ImageBuffer::putPremultipliedImageData):
            Implemented.
        (WebCore::ImageBuffer::toDataURL):
            Uses Haiku "Translation Kit" to convert image data to data
            of the requested mime type.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Thu, 22 Apr 2010 09:34:16 +0000 (09:34 +0000)]
2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Adam Barth.

        Chromium: Add --chromium option to new-run-webkit-websocketserver
        https://bugs.webkit.org/show_bug.cgi?id=37664

        Move cygwin setup logic in chromium_win.py.

        * Scripts/new-run-webkit-httpd: remove register_cygwin parameter to pass http_server.
        * Scripts/new-run-webkit-websocketserver: add --chromium flag
        * Scripts/webkitpy/layout_tests/port/chromium_win.py: setup for cygwin
        * Scripts/webkitpy/layout_tests/port/http_server.py: remove cygwin setup logic
        * Scripts/webkitpy/layout_tests/port/websocket_server.py: remove cygwin setup logic

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 22 Apr 2010 09:20:28 +0000 (09:20 +0000)]
2010-04-22  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        new-run-webkit-tests --verbose shows ever-increasing #EOF lines
        https://bugs.webkit.org/show_bug.cgi?id=37794

        * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
         - Fix the log message to explain that this is stderr output, not test output.
        * Scripts/webkitpy/layout_tests/port/webkit.py:
         - Be sure to reset the server_process.error after reading (seems like the wrong
           place to do this, but at least this fixes the bug and dpranke and I can talk
           about better designs later).
         - Also remove the #EOF from the stderr output before returning it.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 22 Apr 2010 09:12:19 +0000 (09:12 +0000)]
2010-04-22  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Hack up PrettyDiff to allow line-by-line comments
        https://bugs.webkit.org/show_bug.cgi?id=37886

        Admittedly a bit of a hack, this is a basic line-by-line editor we can
        play with thanks to Andrew Scherkus.  It's meant to integrate with the
        "review" page at bugs.webkit.org.

        I changed a few things from Andrew's original version:
        1) Trigger text boxes on single click to make iPhone/iPad reviewing
        easier.
        2) Clear the main text box on load.
        3) Reference a version of prototype.js on bugs.webkit.org.

        * PrettyPatch/PrettyPatch.rb:
        * prototype.js: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 22 Apr 2010 08:29:25 +0000 (08:29 +0000)]
2010-04-22  Eric Seidel  <eric@webkit.org>

        Unreviewed.  Fixing new-run-webkit-tests on the bots.

        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
         - Fixing _compat_shim_option to take variable keyword args.
         - Turns out that nargs + callback is ignored unless type is specified.
           So I added the type so that the option was properly consumed.
           This was why new-run-webkit-tests couldn't find any tests, it
           was looking for them under "20" because that was the argument
           which should have been consumed by --exit-after-n-failures.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 22 Apr 2010 08:03:45 +0000 (08:03 +0000)]
2010-04-22  Tony Chang  <tony@chromium.org>

        Not reviewed, build fix for chromium Windows.

        [chromium] fix ImageDiff compile on windows
        https://bugs.webkit.org/show_bug.cgi?id=37979

        * DumpRenderTree/chromium/ImageDiff.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 22 Apr 2010 07:50:36 +0000 (07:50 +0000)]
2010-04-22  Adam Barth  <abarth@webkit.org>

        Unreviewed, rolling out r58069.
        http://trac.webkit.org/changeset/58069
        https://bugs.webkit.org/show_bug.cgi?id=27751

        Broke compile on Windows.

        * editing/execCommand/clipboard-access-expected.txt: Removed.
        * editing/execCommand/clipboard-access.html: Removed.
        * editing/execCommand/script-tests/clipboard-access.js: Removed.
2010-04-22  Adam Barth  <abarth@webkit.org>

        Unreviewed, rolling out r58069.
        http://trac.webkit.org/changeset/58069
        https://bugs.webkit.org/show_bug.cgi?id=27751

        Broke compile on Windows.

        * WebCore.base.exp:
        * editing/EditorCommand.cpp:
        (WebCore::supportedPaste):
        (WebCore::createCommandMap):
        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        * page/Settings.h:
2010-04-22  Adam Barth  <abarth@webkit.org>

        Unreviewed, rolling out r58069.
        http://trac.webkit.org/changeset/58069
        https://bugs.webkit.org/show_bug.cgi?id=27751

        Broke compile on Windows.

        * public/WebSettings.h:
        * src/WebSettingsImpl.cpp:
        * src/WebSettingsImpl.h:
2010-04-22  Adam Barth  <abarth@webkit.org>

        Unreviewed, rolling out r58069.
        http://trac.webkit.org/changeset/58069
        https://bugs.webkit.org/show_bug.cgi?id=27751

        Broke compile on Windows.

        * webkit/webkitwebsettings.cpp:
        (webkit_web_settings_class_init):
        (webkit_web_settings_set_property):
        (webkit_web_settings_get_property):
        (webkit_web_settings_copy):
        * webkit/webkitwebview.cpp:
        (webkit_web_view_update_settings):
        (webkit_web_view_settings_notify):
2010-04-22  Adam Barth  <abarth@webkit.org>

        Unreviewed, rolling out r58069.
        http://trac.webkit.org/changeset/58069
        https://bugs.webkit.org/show_bug.cgi?id=27751

        Broke compile on Windows.

        * WebView/WebPreferenceKeysPrivate.h:
        * WebView/WebPreferences.mm:
        (+[WebPreferences initialize]):
        * WebView/WebPreferencesPrivate.h:
        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]):
2010-04-22  Adam Barth  <abarth@webkit.org>

        Unreviewed, rolling out r58069.
        http://trac.webkit.org/changeset/58069
        https://bugs.webkit.org/show_bug.cgi?id=27751

        Broke compile on Windows.

        * Api/qwebsettings.cpp:
        (QWebSettingsPrivate::apply):
        * Api/qwebsettings.h:
2010-04-22  Adam Barth  <abarth@webkit.org>

        Unreviewed, rolling out r58069.
        http://trac.webkit.org/changeset/58069
        https://bugs.webkit.org/show_bug.cgi?id=27751

        Broke compile on Windows.

        * Interfaces/IWebPreferencesPrivate.idl:
        * WebPreferenceKeysPrivate.h:
        * WebPreferences.cpp:
        (WebPreferences::initializeDefaultSettings):
        * WebPreferences.h:
        * WebView.cpp:
        (WebView::notifyPreferencesChanged):
2010-04-22  Adam Barth  <abarth@webkit.org>

        Unreviewed, rolling out r58069.
        http://trac.webkit.org/changeset/58069
        https://bugs.webkit.org/show_bug.cgi?id=27751

        Broke compile on Windows.

        * DumpRenderTree/LayoutTestController.cpp:
        (LayoutTestController::staticFunctions):
        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (LayoutTestController::overridePreference):
        * DumpRenderTree/chromium/LayoutTestController.h:
        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::resetWebSettings):
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        * DumpRenderTree/mac/DumpRenderTree.mm:
        (resetDefaultsToConsistentValues):
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::WebPage::WebPage):
        (WebCore::WebPage::resetSettings):
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        * DumpRenderTree/qt/LayoutTestControllerQt.h:
        * DumpRenderTree/win/DumpRenderTree.cpp:
        (resetDefaultsToConsistentValues):
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        * DumpRenderTree/wx/LayoutTestControllerWx.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 22 Apr 2010 07:40:49 +0000 (07:40 +0000)]
2010-04-22  Eric Seidel  <eric@webkit.org>

        Unreviewed.  Just adding logging.

        Adding logging to help debug why the Leopard Bot
        can't find any tests to run.

        * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
         - Make it a fatal error to have no tests to run.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 22 Apr 2010 07:40:20 +0000 (07:40 +0000)]
2010-04-22  Tony Chang  <tony@chromium.org>

        Reviewed by Shinichiro Hamaji.

        [chromium] roll chromium deps to pick up some windows build fixes
        https://bugs.webkit.org/show_bug.cgi?id=37972

        * DEPS:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Abhishek Arya <inferno@chromium.org>
abarth@webkit.org [Thu, 22 Apr 2010 07:37:15 +0000 (07:37 +0000)]
2010-04-22  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Adam Barth.

        Manual test to verify that javascript cannot access clipboard.
        https://bugs.webkit.org/show_bug.cgi?id=27751

        * editing/execCommand/clipboard-access-expected.txt: Added.
        * editing/execCommand/clipboard-access.html: Added.
        * editing/execCommand/script-tests/clipboard-access.js: Added.
        (enabled):
        (whenEnabled):
        (runTest):
2010-04-22  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Adam Barth.

        Add support for controlling clipboard access from javascript.
        Clipboard access from javascript is disabled by default.
        https://bugs.webkit.org/show_bug.cgi?id=27751

        Test: editing/execCommand/clipboard-access.html

        * WebCore.base.exp:
        * editing/EditorCommand.cpp:
        (WebCore::supportedCopyCut):
        (WebCore::supportedPaste):
        (WebCore::createCommandMap):
        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        (WebCore::Settings::setJavaScriptCanAccessClipboard):
        * page/Settings.h:
        (WebCore::Settings::javaScriptCanAccessClipboard):
2010-04-22  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Adam Barth.

        Add support for controlling clipboard access from javascript.
        Clipboard access from javascript is disabled by default.
        https://bugs.webkit.org/show_bug.cgi?id=27751

        * public/WebSettings.h:
        * src/WebSettingsImpl.cpp:
        (WebKit::WebSettingsImpl::setJavaScriptCanAccessClipboard):
        * src/WebSettingsImpl.h:
2010-04-22  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Adam Barth.

        Add support for controlling clipboard access from javascript.
        Clipboard access from javascript is disabled by default.
        https://bugs.webkit.org/show_bug.cgi?id=27751

        * webkit/webkitwebsettings.cpp:
        (webkit_web_settings_class_init):
        (webkit_web_settings_set_property):
        (webkit_web_settings_get_property):
        (webkit_web_settings_copy):
        * webkit/webkitwebview.cpp:
        (webkit_web_view_update_settings):
        (webkit_web_view_settings_notify):
2010-04-22  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Adam Barth.

        Add support for controlling clipboard access from javascript.
        Clipboard access from javascript is disabled by default.
        https://bugs.webkit.org/show_bug.cgi?id=27751

        * WebView/WebPreferenceKeysPrivate.h:
        * WebView/WebPreferences.mm:
        (+[WebPreferences initialize]):
        (-[WebPreferences javaScriptCanAccessClipboard]):
        (-[WebPreferences setJavaScriptCanAccessClipboard:]):
        * WebView/WebPreferencesPrivate.h:
        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]):
2010-04-22  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Adam Barth.

        Add support for controlling clipboard access from javascript.
        Clipboard access from javascript is disabled by default.
        https://bugs.webkit.org/show_bug.cgi?id=27751

        * Api/qwebsettings.cpp:
        (QWebSettingsPrivate::apply):
        * Api/qwebsettings.h:
2010-04-22  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Adam Barth.

        Add support for controlling clipboard access from javascript.
        Clipboard access from javascript is disabled by default.
        https://bugs.webkit.org/show_bug.cgi?id=27751

        * Interfaces/IWebPreferencesPrivate.idl:
        * WebPreferenceKeysPrivate.h:
        * WebPreferences.cpp:
        (WebPreferences::initializeDefaultSettings):
        (WebPreferences::javaScriptCanAccessClipboard):
        (WebPreferences::setJavaScriptCanAccessClipboard):
        * WebPreferences.h:
        * WebView.cpp:
        (WebView::notifyPreferencesChanged):
2010-04-22  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Adam Barth.

        Add support for controlling clipboard access from javascript.
        Clipboard access from javascript is enabled in test framework.
        https://bugs.webkit.org/show_bug.cgi?id=27751

        * DumpRenderTree/LayoutTestController.cpp:
        (setJavaScriptCanAccessClipboardCallback):
        (LayoutTestController::staticFunctions):
        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (LayoutTestController::setJavaScriptCanAccessClipboard):
        (LayoutTestController::overridePreference):
        * DumpRenderTree/chromium/LayoutTestController.h:
        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::resetWebSettings):
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::setJavaScriptCanAccessClipboard):
        * DumpRenderTree/mac/DumpRenderTree.mm:
        (resetDefaultsToConsistentValues):
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::setJavaScriptCanAccessClipboard):
        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::WebPage::WebPage):
        (WebCore::WebPage::resetSettings):
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::setJavaScriptCanAccessClipboard):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:
        * DumpRenderTree/win/DumpRenderTree.cpp:
        (resetDefaultsToConsistentValues):
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::setJavaScriptCanAccessClipboard):
        * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
        (LayoutTestController::setJavaScriptCanAccessClipboard):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-22 Stephan Aßmus <superstippi@gmx.de>
eric@webkit.org [Thu, 22 Apr 2010 07:29:58 +0000 (07:29 +0000)]
2010-04-22  Stephan Aßmus  <superstippi@gmx.de>

        Reviewed by David Levin.

        [Haiku] Improve SimpleFontDataHaiku
        https://bugs.webkit.org/show_bug.cgi?id=37411

        Covered by existing tests.

        * platform/graphics/haiku/SimpleFontDataHaiku.cpp:
            - Cleaned up includes
            - Removed prototype "charUnicodeToUTF8HACK"
        (WebCore::SimpleFontData::platformInit):
            - Use const BFont pointer
        (WebCore::SimpleFontData::smallCapsFontData):
            - "fontPlatformData" was leaked. It is only
              used as the key for the font cache lookup.
        (WebCore::SimpleFontData::platformMetricsForGlyph):
            - Use existing WebCore encoding infrastructure
              instead of adding a hack for Haiku.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReference count WebView's backing store bitmap to prevent
aestes@apple.com [Thu, 22 Apr 2010 07:11:39 +0000 (07:11 +0000)]
Reference count WebView's backing store bitmap to prevent
deleteBackingStore() from freeing the bitmap while it is still being
referenced by Core Animation.

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=37954

* WebView.cpp:
(WebView::ensureBackingStore):
(WebView::addToDirtyRegion):
(WebView::scrollBackingStore):
(WebView::updateBackingStore):
(WebView::paint):
(WebView::backingStore):
(releaseBackingStoreCallback): deref m_backingStoreBitmap once Core
Animation has dropeed its reference to the memory.
(WebView::updateRootLayerContents): ref m_backingStoreBitmap before
passing the memory to Core Animation to prevent deleteBackingStore()
from freeing it while it is still referenced by CA.
* WebView.h: Make m_backingStoreBitmap a RefCountedGDIHandle<HBITMAP>,
and make m_backingStoreDirtyRegion a RefCountedGDIHandle<HRGN>.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-21 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 22 Apr 2010 06:59:19 +0000 (06:59 +0000)]
2010-04-21  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        webkit-patch can't fetch attachments on security bugs
        https://bugs.webkit.org/show_bug.cgi?id=37975

        Instead of calling CURL, we just need to use our Mechanize object,
        which understand bugs.webkit.org authentication.

        * Scripts/webkitpy/common/checkout/api.py:
        * Scripts/webkitpy/common/net/bugzilla.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-21 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 22 Apr 2010 06:50:05 +0000 (06:50 +0000)]
2010-04-21  Tony Chang  <tony@chromium.org>

        Reviewed by Shinichiro Hamaji.

        [chromium] gyp_webkit should be executable
        https://bugs.webkit.org/show_bug.cgi?id=37971

        * gyp_webkit: Added property svn:executable.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-21 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 22 Apr 2010 06:49:50 +0000 (06:49 +0000)]
2010-04-21  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        URL LayoutTests don't run on Firefox
        https://bugs.webkit.org/show_bug.cgi?id=37974

        It turns out Firefox doesn't handle base URLs properly if we go through
        the DOM to create the <base> and <a> elements.  If we switch to
        document.write, we can run the tests in Firefox (even though
        document.write is lame).

        * fast/url/resources/utilities.js:
        (canonicalize):
        (setBaseURL):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-21 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 22 Apr 2010 06:48:52 +0000 (06:48 +0000)]
2010-04-21  Eric Seidel  <eric@webkit.org>

        Unreviewed.  Temporary commit, will roll-out before morning.

        Turning on new-run-webkit-tests for the Leopard build bot
        for testing of the harness.
        Users should not noctice (except for the results.html difference).

        * Scripts/run-webkit-tests:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-21 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 22 Apr 2010 06:38:27 +0000 (06:38 +0000)]
2010-04-21  Eric Seidel  <eric@webkit.org>

        Unreviewed.  Fix typo in my previous fix attempt.

        REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
        https://bugs.webkit.org/show_bug.cgi?id=37765

        More on-the-bot debugging, sigh.  I wish I had a local build.

        * Scripts/webkitpy/layout_tests/port/base.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-21 Steve Block <steveblock@google.com>
eric@webkit.org [Thu, 22 Apr 2010 06:32:06 +0000 (06:32 +0000)]
2010-04-21  Steve Block  <steveblock@google.com>

        Reviewed by Kenneth Rohde Christiansen.

        Replace Geolocation::suspend()/resume() which are required by Android.
        https://bugs.webkit.org/show_bug.cgi?id=37942

        These methods were removed in Bug 36255.

        Build fix only, no new tests.

        * page/Geolocation.cpp:
        (WebCore::Geolocation::suspend):
        (WebCore::Geolocation::resume):
        * page/Geolocation.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-21 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 22 Apr 2010 06:29:48 +0000 (06:29 +0000)]
2010-04-21  Eric Seidel  <eric@webkit.org>

        Unreviewed.  Fix typo in my previous fix attempt.

        REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
        https://bugs.webkit.org/show_bug.cgi?id=37765

        * Scripts/webkitpy/layout_tests/port/base.py:
         - Add self. to class variable access.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-21 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 22 Apr 2010 06:18:56 +0000 (06:18 +0000)]
2010-04-21  Eric Seidel  <eric@webkit.org>

        Unreviewed.  Another attempt to fix NRWT for chromium.

        REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
        https://bugs.webkit.org/show_bug.cgi?id=37765

        * Scripts/webkitpy/layout_tests/port/base.py:
         - wdiff_text was returning a byte array instead of a
           unicode string.  The simple fix was to just decode
           the result.  However, seeing so much duplicated code
           with Executive made me cry, so I re-wrote the function
           to be more like pretty_patch_text and use run_command
           (which already knows how to handle unicode).

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-21 Ben Murdoch <benm@google.com>
eric@webkit.org [Thu, 22 Apr 2010 06:02:06 +0000 (06:02 +0000)]
2010-04-21  Ben Murdoch  <benm@google.com>

        Reviewed by Jeremy Orlow.

        send-oncancel-event touch test should use js-test-post-function.js
        https://bugs.webkit.org/show_bug.cgi?id=37830

        Restore reference to js-test-post-function removed erroneously in copy
        when this test was move in http://trac.webkit.org/changeset/54253
        and the corresponding call to the isSuccessfullyParsed function.

        * fast/events/touch/script-tests/send-oncancel-event.js:
        (touchcancelHandler): Call isSuccessfullyParsed.
        * fast/events/touch/send-oncancel-event.html: Add js-test-post-function.js back.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-21 Ray Rischpater <Raymond.Rischpater@Nokia.com>
eric@webkit.org [Thu, 22 Apr 2010 05:49:53 +0000 (05:49 +0000)]
2010-04-21  Ray Rischpater  <Raymond.Rischpater@Nokia.com>

        In HTMLInputElement.cpp there are numerous style
        violations.

        This patch includes style changes to fix existing style
        deviations in this file.

        Rubber stamped by Darin Adler.

        Fixes <https://bugs.webkit.org/show_bug.cgi?id=37881>

        * html/HTMLInputElement.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-21 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 22 Apr 2010 05:49:51 +0000 (05:49 +0000)]
2010-04-21  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Windows tests buildbots are too slow to be core builders
        https://bugs.webkit.org/show_bug.cgi?id=37970

        It's 10:45.  The Windows test bots are still hours behind.  They're too
        slow to be core builders.  When they get fast, we can add them back.

        * Scripts/webkitpy/common/net/buildbot.py:
        * Scripts/webkitpy/common/net/buildbot_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-21 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 22 Apr 2010 05:49:07 +0000 (05:49 +0000)]
2010-04-21  Eric Seidel  <eric@webkit.org>

        Unreviewed.  Attempt one more time to fix NRWT for chromium.

        REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
        https://bugs.webkit.org/show_bug.cgi?id=37765

        I'm debugging in the blind because I don't have a chromium
        build on this laptop.

        * Scripts/webkitpy/layout_tests/port/chromium.py:
         - Apply the previous fix to a second caller.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-21 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 22 Apr 2010 05:40:48 +0000 (05:40 +0000)]
2010-04-21  Eric Seidel  <eric@webkit.org>

        Unreviewed.  Attempt one more time to fix NRWT for chromium.

        REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
        https://bugs.webkit.org/show_bug.cgi?id=37765

        * Scripts/webkitpy/layout_tests/port/chromium.py:
         - Fix handling of test_shell output so that we always
           decode it as utf-8.
           Unlike DumpRenderTree test_shell does not ever return
           pixel data.  It spits out the pixel dumps in a separate
           file, thus all output over stdout is utf-8 text.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-21 Gustavo Sverzut Barbieri <barbieri@profusion.mobi>
eric@webkit.org [Thu, 22 Apr 2010 05:39:54 +0000 (05:39 +0000)]
2010-04-21  Gustavo Sverzut Barbieri  <barbieri@profusion.mobi>

        Reviewed by Adam Roben.

        Add missing EFL WebCore file.
        http://webkit.org/b/37854

        No behavior changes, so no new tests were added.

        * bindings/js/ScriptControllerEfl.cpp: Added.
        (WebCore::ScriptController::createScriptInstanceForWidget):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Shinichiro Hamaji.
ap@apple.com [Thu, 22 Apr 2010 04:45:43 +0000 (04:45 +0000)]
    Reviewed by Shinichiro Hamaji.

        https://bugs.webkit.org/show_bug.cgi?id=37964
        Fix a typo in comments - Korean encoding name is windows-949, not windows-939

        * WebView/WebPreferences.mm: (+[WebPreferences _setInitialDefaultTextEncodingToSystemEncoding]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58052 268f45cc-cd09-0410-ab3c-d52691b4dbfc