WebKit.git
12 years ago2009-07-03 Yong Li <yong.li@torchmobile.com>
mjs@apple.com [Sat, 4 Jul 2009 14:21:30 +0000 (14:21 +0000)]
2009-07-03  Yong Li  <yong.li@torchmobile.com>

        Reviewed by Maciej Stachowiak (and revised slightly)

        RegExp::match to be optimized
        https://bugs.webkit.org/show_bug.cgi?id=26957

        Allow regexp matching to use Vectors with inline capacity instead of
        allocating a new ovector buffer every time.

        ~5% speedup on SunSpider string-unpack-code test, 0.3% on SunSpider overall.

        * runtime/RegExp.cpp:
        (JSC::RegExp::match):
        * runtime/RegExp.h:
        * runtime/RegExpConstructor.cpp:
        (JSC::RegExpConstructorPrivate::RegExpConstructorPrivate):
        (JSC::RegExpConstructorPrivate::lastOvector):
        (JSC::RegExpConstructorPrivate::tempOvector):
        (JSC::RegExpConstructorPrivate::changeLastOvector):
        (JSC::RegExpConstructor::performMatch):
        (JSC::RegExpMatchesArray::RegExpMatchesArray):
        (JSC::RegExpMatchesArray::fillArrayInstance):
        (JSC::RegExpConstructor::getBackref):
        (JSC::RegExpConstructor::getLastParen):
        (JSC::RegExpConstructor::getLeftContext):
        (JSC::RegExpConstructor::getRightContext):
        * runtime/StringPrototype.cpp:
        (JSC::stringProtoFuncSplit):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-03 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Sat, 4 Jul 2009 14:20:51 +0000 (14:20 +0000)]
2009-07-03  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Eric Seidel.

        bugzilla-tool forgot how to obsolete patches
        https://bugs.webkit.org/show_bug.cgi?id=26951

        * Scripts/modules/bugzilla.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdded Radar link I left out by accident the first time.
darin@apple.com [Sat, 4 Jul 2009 04:50:34 +0000 (04:50 +0000)]
Added Radar link I left out by accident the first time.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-03 Darin Adler <darin@apple.com>
darin@apple.com [Sat, 4 Jul 2009 04:48:13 +0000 (04:48 +0000)]
2009-07-03  Darin Adler  <darin@apple.com>

        Reviewed by Adele Peterson.

        REGRESSION (r44670-r44680): Typing is suprisingly slow in password field on reddit.com
        https://bugs.webkit.org/show_bug.cgi?id=26959

        The code to handle iteration boundaries was malfunctioning when the boundary was
        at the edge of a shadow tree. This happens all the time with <input> elements.

        It's not immediately obvious how to make a regression test for this since the
        symptom was a performance problem, not incorrect behavior. I'll add a test if I
        figure out a way to make one.

        * editing/TextIterator.cpp:
        (WebCore::parentCrossingShadowBoundaries): Renamed from parentOrShadowParent.
        (WebCore::depthCrossingShadowBoundaries): Updated for name change.
        (WebCore::nextInPreOrderCrossingShadowBoundaries): Added.
        (WebCore::previousInPostOrderCrossingShadowBoundaries): Added.
        (WebCore::setUpFullyClippedStack): Updated for name change.
        (WebCore::TextIterator::TextIterator): Updated for name change. Use
        nextInPreOrderCrossingShadowBoundaries instead of Range::pastLastNode to fix the bug.
        (WebCore::TextIterator::advance): Updated for name change.
        (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
        Tweaked formatting.
        (WebCore::SimplifiedBackwardsTextIterator::advance): Ditto. Changed code that
        initializes m_pastStartNode to use previousInPostOrderCrossingShadowBoundaries.
        (WebCore::SimplifiedBackwardsTextIterator::handleNonTextNode): Tweaked formatting.
        (WebCore::SimplifiedBackwardsTextIterator::exitNode): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Simon Fraser.
mitz@apple.com [Sat, 4 Jul 2009 03:56:30 +0000 (03:56 +0000)]
    Reviewed by Simon Fraser.

        - fix <rdar://problem/6964278> REGRESSION (r42118): Scrolling redraw
          problem in FileMaker Pro

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
        Perform layout if needed, even on Mac OS X versions that have
        -viewWillDraw. This prevents attempts to draw without layout in case
        -viewWillDraw was not called due to NSView issues or the client
        did something during the display operation that re-invalidated the
        layout.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Bug 26958: Change edit link to review link in request messages
ddkilzer@apple.com [Sat, 4 Jul 2009 03:27:33 +0000 (03:27 +0000)]
    Bug 26958: Change edit link to review link in request messages

        <https://bugs.webkit.org/show_bug.cgi?id=26958>

        Reviewed by Dan Bernstein.

        * template/en/custom/request/email.txt.tmpl: Copied from BugsSite/template/en/default/request/email.txt.tmpl.
        Changed link from "action=edit" to "action=review".

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoNot reviewed. Forgot to land ontimer-inline-event.html results within my last WML...
zimmermann@webkit.org [Sat, 4 Jul 2009 01:09:16 +0000 (01:09 +0000)]
Not reviewed. Forgot to land ontimer-inline-event.html results within my last WML commit.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Bug 26950: Make the summary and alias fields support click-to-edit
ddkilzer@apple.com [Sat, 4 Jul 2009 00:19:47 +0000 (00:19 +0000)]
    Bug 26950: Make the summary and alias fields support click-to-edit
        <https://bugs.webkit.org/show_bug.cgi?id=26950>

        Reviewed by Maciej Stachowiak.

        Original patch by Maciej Stachowiak.

        * js/field.js:
        (hideEditableField): Updated to add click event listeners to the
        alias and short description elements to make them easier to
        edit.  Renamed field_id parameter to field2_id (short
        description id) and added a field1_id parameter (alias id).
        (showEditableField): If a third parameter is passed in the
        ContainerInputArray parameter, use it to find the element to
        focus.  Otherwise, fall back to the original behavior of
        focusing the first input field.
        (hideAliasAndSummary): Changed to pass the id for the alias
        element to hideEditableField().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-03 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 3 Jul 2009 20:54:24 +0000 (20:54 +0000)]
2009-07-03  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Sam Weinig.

        Background audio stops playing when JS GC runs
        https://bugs.webkit.org/show_bug.cgi?id=26956

        Ensure we keep the Audio object around while it is playing, so that it
        doesn't get collected.

        Not testable because there's no way to know whether the audio keeps
        playing without holding a reference to it.

        * bindings/js/JSDOMBinding.cpp:
        (WebCore::isObservableThroughDOM):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-03 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 3 Jul 2009 19:34:21 +0000 (19:34 +0000)]
2009-07-03  Adam Barth  <abarth@webkit.org>

        Reviewed by Sam Weinig.

        Adam and Collin's affiliation is incorrect
        https://bugs.webkit.org/show_bug.cgi?id=26954

        This change corrects their affiliation.

        * security/security-group-members.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-02 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Fri, 3 Jul 2009 14:08:34 +0000 (14:08 +0000)]
2009-07-02  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Jan Alonzo.

        https://bugs.webkit.org/show_bug.cgi?id=26814
        [Gtk] Caret-moved events are not issued for the correct offset
        when text is selected forward

        Report the caret offset from the end of the selection, otherwise
        we'll report the same offset when moving the caret while
        modififying the selection (eg, with Shift + Right).

        * editing/gtk/SelectionControllerGtk.cpp:
        (WebCore::SelectionController::notifyAccessibilityForSelectionChange):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-02 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Fri, 3 Jul 2009 14:08:22 +0000 (14:08 +0000)]
2009-07-02  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Jan Alonzo.

        https://bugs.webkit.org/show_bug.cgi?id=26815
        [Gtk] text-selection-changed events are not issued for the correct
        object when the selection spans multiple objects

        Get the focused node from the end of the selection, not the start,
        so we can detect when we cross object boundaries.

        * editing/gtk/SelectionControllerGtk.cpp:
        (WebCore::SelectionController::notifyAccessibilityForSelectionChange):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-03 Dmitry Titov <dimich@chromium.org>
dimich@chromium.org [Fri, 3 Jul 2009 10:47:41 +0000 (10:47 +0000)]
2009-07-03  Dmitry Titov  <dimich@chromium.org>

        Reviewed by Darin Fisher.

        Increase delay in worker-terminate layout test to make it more reliable.
        https://bugs.webkit.org/show_bug.cgi?id=26917

        This test used time delay to see of terminated worker does not return
        messages (terminated). In some test conditions, the current delay (500ms)
        is too short and test fails. Move setting the delay to the end of initialization
        and increase it 2x to make test more reliable.

        * fast/workers/worker-terminate.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-03 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Fri, 3 Jul 2009 10:24:18 +0000 (10:24 +0000)]
2009-07-03  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Skip tests that require expected results that Gtk doesn't have.

        * platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-03 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Fri, 3 Jul 2009 09:57:39 +0000 (09:57 +0000)]
2009-07-03  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Xan Lopez and Gustavo Noronha.

        Set user-agent from application
        https://bugs.webkit.org/show_bug.cgi?id=17375

        Add 'user-agent' setter/getter API to WebSettings.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::FrameLoaderClient):
        (WebKit::FrameLoaderClient::userAgent):
        * WebCoreSupport/FrameLoaderClientGtk.h:
        * webkit/webkitprivate.h:
        * webkit/webkitversion.h.in:
        * webkit/webkitwebsettings.cpp:
        (webkit_get_user_agent):
        (webkit_web_settings_class_init):
        (webkit_web_settings_finalize):
        (webkit_web_settings_set_property):
        (webkit_web_settings_get_property):
        (webkit_web_settings_copy):
        (webkit_web_settings_get_user_agent):
        * webkit/webkitwebsettings.h:
        * webkit/webkitwebview.cpp:
        (webkit_web_view_dispose):

        Define UA version macros to be used by the UA string.
        Add new WebSettings unit test for the User-Agent string API.

        * GNUmakefile.am:
        * configure.ac:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoEdit WebCore/ChangeLog last entry to fix a spelling typo.
pdherbemont@apple.com [Fri, 3 Jul 2009 05:21:11 +0000 (05:21 +0000)]
Edit WebCore/ChangeLog last entry to fix a spelling typo.

Pointed out by Mark Rowe.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-02 Pierre d'Herbemont <pdherbemont@apple.com>
pdherbemont@apple.com [Fri, 3 Jul 2009 05:12:44 +0000 (05:12 +0000)]
2009-07-02  Pierre d'Herbemont  <pdherbemont@apple.com>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=26947

        Fix the media controls hit tests. They may loose click events.

        Test cases already covered in the video-controls-zoomed tests.

        Don't trust wkHitTestMediaUIPart for the tests. We are accurate enough.

        * rendering/RenderThemeMac.h: Remove hitTestMediaControlPart.
        * rendering/RenderThemeMac.mm: Remove hitTestMediaControlPart.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoIgnore data/template cache directory and update data/params.
ddkilzer@apple.com [Fri, 3 Jul 2009 03:34:57 +0000 (03:34 +0000)]
Ignore data/template cache directory and update data/params.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-02 Brent Fulgham <bfulgham@webkit.org>
bfulgham@webkit.org [Fri, 3 Jul 2009 03:15:32 +0000 (03:15 +0000)]
2009-07-02  Brent Fulgham  <bfulgham@webkit.org>

        Unreviewed build fix (Cairo this time) for DumpRenderTree.
        Put Cairo code back in, but use original include order
        for the CG stuff to avoid compile issues.

        * DumpRenderTree/win/PixelDumpSupportWin.cpp:
        (createBitmapContextFromWebView):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Config file for contrib/recode.pl when upgrading bugs.webkit.org
ddkilzer@apple.com [Fri, 3 Jul 2009 02:14:46 +0000 (02:14 +0000)]
    Config file for contrib/recode.pl when upgrading bugs.webkit.org

        Current as of midday on Wednesday, July 1, 2009.

        * contrib/recode-overrides.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Workaround for WebKit Bug 9630 when running contrib/recode.pl
ddkilzer@apple.com [Fri, 3 Jul 2009 02:14:45 +0000 (02:14 +0000)]
    Workaround for WebKit Bug 9630 when running contrib/recode.pl

        A number of WebKit nightly builds included Bug 9630 which caused
        non-breaking space characters (0xA0) to be submitted within the
        content of textarea elements.

        * contrib/recode.pl: To work around these 0xA0 characters, try
        an encoding of cp1252 and use it if it works.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Don't print "Failed to guess" warning if an override is available
ddkilzer@apple.com [Fri, 3 Jul 2009 02:14:44 +0000 (02:14 +0000)]
    Don't print "Failed to guess" warning if an override is available

        * contrib/recode.pl: Check that %overrides does NOT contain a
        key matching the current digest before printing out the warning
        about a failed charset guess.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Added --[no-]truncate switch to contrib/recode.pl
ddkilzer@apple.com [Fri, 3 Jul 2009 02:14:42 +0000 (02:14 +0000)]
    Added --[no-]truncate switch to contrib/recode.pl

        * contrib/recode.pl: Added --[no-]truncate switch to make
        debugging of failed charset guessing easier.  Often times the
        illegal character was truncated in the output.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Changed Perl scripts to use #!/usr/bin/env perl
ddkilzer@apple.com [Fri, 3 Jul 2009 02:14:39 +0000 (02:14 +0000)]
    Changed Perl scripts to use #!/usr/bin/env perl

        perl -pi -e 's@#\!/usr/bin/perl@#\!/usr/bin/env perl@' *.cgi *.pl */*.pl

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Replace Bugzilla favicon with webkit.org favicon
ddkilzer@apple.com [Fri, 3 Jul 2009 02:14:33 +0000 (02:14 +0000)]
    Replace Bugzilla favicon with webkit.org favicon

        * favicon.ico: Removed.
        * images/favicon.ico: Replaced.  Copied from favicon.ico.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Merged BugsSite to Bugzilla-3.2.3
ddkilzer@apple.com [Fri, 3 Jul 2009 02:14:25 +0000 (02:14 +0000)]
    Merged BugsSite to Bugzilla-3.2.3

        Updated to the latest-and-greatest stable version.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Merged BugsSite to Bugzilla-3.0.3
ddkilzer@apple.com [Fri, 3 Jul 2009 02:13:41 +0000 (02:13 +0000)]
    Merged BugsSite to Bugzilla-3.0.3

        Nothing to see here.  Move along.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-02 Pierre d'Herbemont <pdherbemont@apple.com>
pdherbemont@apple.com [Fri, 3 Jul 2009 01:38:29 +0000 (01:38 +0000)]
2009-07-02  Pierre d'Herbemont  <pdherbemont@apple.com>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=26944

        Make sure we support full page zoom in video controls.

        This is tracked by a the video-controls-zoom test case.

        * css/mediaControlsQT.css: Make sure we don't have any inherited margin.
        * rendering/MediaControlElements.cpp:
        (WebCore::MediaControlElement::updateStyle): Propagate the style to the innertext.
        * rendering/RenderThemeMac.mm: Adjust the painting rect.
        (WebCore::getUnzoomedRectAndAdjustCurrentContext):
        (WebCore::RenderThemeMac::paintMediaSliderTrack):
        (WebCore::RenderThemeMac::paintMediaCurrentTime):
        (WebCore::RenderThemeMac::paintMediaTimeRemaining):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-02 Roland Steiner <rolandsteiner@google.com>
eric@webkit.org [Fri, 3 Jul 2009 01:29:07 +0000 (01:29 +0000)]
2009-07-02  Roland Steiner  <rolandsteiner@google.com>

        Reviewed by Eric Seidel.

        RenderBlock and RenderInline have confusingly named object creation methods:
        RenderBlock::createRootBox/createRootInlineBox
        RenderInline::createFlowBox/createInlineFlowBox
        where the 2nd method in both cases just calls the first and then appends the created object.
        I therefore renamed those methods to something IMHO more informative:

        createRootBox()         -> createRootInlineBox()
        createRootInlineBox()   -> createAndAppendRootInlineBox();
        createFlowBox()         -> createInlineFlowBox();
        createInlineFlowBox()   -> createAndAppendInlineFlowBox();

        https://bugs.webkit.org/show_bug.cgi?id=26828

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::createRootInlineBox):
        (WebCore::RenderBlock::createAndAppendRootInlineBox):
        * rendering/RenderBlock.h:
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::createInlineFlowBox):
        (WebCore::RenderInline::createAndAppendInlineFlowBox):
        * rendering/RenderInline.h:
        * rendering/RenderSVGInline.cpp:
        (WebCore::RenderSVGInline::createInlineFlowBox):
        * rendering/RenderSVGInline.h:
        * rendering/RenderSVGText.cpp:
        (WebCore::RenderSVGText::createRootInlineBox):
        * rendering/RenderSVGText.h:
        * rendering/bidi.cpp:
        (WebCore::createInlineBoxForRenderer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-02 Pavel Feldman <pfeldman@chromium.org>
eric@webkit.org [Fri, 3 Jul 2009 01:23:48 +0000 (01:23 +0000)]
2009-07-02  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        WebInspector: Fix typo in the resource panel enabler caption.

        https://bugs.webkit.org/show_bug.cgi?id=26753

        * English.lproj/localizedStrings.js:
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-02 Erik Arvidsson <arv@chromium.org>
eric@webkit.org [Fri, 3 Jul 2009 01:06:27 +0000 (01:06 +0000)]
2009-07-02  Erik Arvidsson  <arv@chromium.org>

        Reviewed by Adam Roben.

        [Win] HTML5 Drag and drop, dragend is not fired when pressing Esc
        https://bugs.webkit.org/show_bug.cgi?id=26699

        * manual-tests/drag-escape.html: Added.
        * page/EventHandler.cpp:
        (WebCore::EventHandler::dragSourceEndedAt):

2009-07-02  Erik Arvidsson  <arv@chromium.org>

        Reviewed by Adam Roben.

        [Win] HTML5 Drag and drop, dragend is not fired when pressing Esc
        https://bugs.webkit.org/show_bug.cgi?id=26699

        * WebDropSource.cpp:
        (WebDropSource::QueryContinueDrag):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-02 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 3 Jul 2009 00:55:13 +0000 (00:55 +0000)]
2009-07-02  Eric Seidel  <eric@webkit.org>

        Correct blatant typo (missing []), no review.

        * Scripts/modules/scm.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-02 Pierre d'Herbemont <pdherbemont@apple.com>
pdherbemont@apple.com [Fri, 3 Jul 2009 00:54:38 +0000 (00:54 +0000)]
2009-07-02  Pierre d'Herbemont  <pdherbemont@apple.com>

        Added the test result of r45511 for platform/mac.

        * platform/mac/media/controls-strict-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-02 Brent Fulgham <bfulgham@webkit.org>
bfulgham@webkit.org [Fri, 3 Jul 2009 00:37:04 +0000 (00:37 +0000)]
2009-07-02  Brent Fulgham  <bfulgham@webkit.org>

        Windows build fix, no review.

        Reverting PixelDumpSupportWin.cpp change to avoid strange
        error on the build-bot.

        * DumpRenderTree/win/PixelDumpSupportWin.cpp:
        (createBitmapContextFromWebView):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-02 Pierre d'Herbemont <pdherbemont@apple.com>
pdherbemont@apple.com [Fri, 3 Jul 2009 00:18:44 +0000 (00:18 +0000)]
2009-07-02  Pierre d'Herbemont  <pdherbemont@apple.com>

        Fix the Gtk build after r45474. The localized strings should
        have been added there.

        * platform/gtk/LocalizedStringsGtk.cpp:
        (WebCore::mediaElementLoadingStateText):
        (WebCore::mediaElementLiveBroadcastStateText):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
pdherbemont@apple.com [Fri, 3 Jul 2009 00:07:24 +0000 (00:07 +0000)]
WebCore:

2009-07-02  Pierre d'Herbemont  <pdherbemont@apple.com>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=26939

        Media controller is rendered badly at http://www.mozilla.com/en-US/firefox/video/firefox-3.5.html

        We fix two things:
        - We use px instead of em, because px is used everywhere else
        and because 0.09em hit the font size limit.
        - We use -webkit-box instead of inline-block because in strict mode
        inline-block has a different behavior.

        Test: media/controls-strict.html

        * css/mediaControlsQT.css:

LayoutTests:

2009-07-02  Pierre d'Herbemont  <pdherbemont@apple.com>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=26939

        Media controller is rendered badly at http://www.mozilla.com/en-US/firefox/video/firefox-3.5.html

        Test that the controller renders correctly in strict mode as well.

        * media/controls-strict.html: Added.
        * platform/mac/media/controls-strict-mode-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-02 Brent Fulgham <bfulgham@webkit.org>
bfulgham@webkit.org [Fri, 3 Jul 2009 00:03:24 +0000 (00:03 +0000)]
2009-07-02  Brent Fulgham  <bfulgham@webkit.org>

        Build fix, no review.

        * DumpRenderTree/config.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/6939593> REGRESSION (r37793): Hitting back button on Google often...
oliver@apple.com [Thu, 2 Jul 2009 23:55:08 +0000 (23:55 +0000)]
<rdar://problem/6939593> REGRESSION (r37793): Hitting back button on Google often gives non-interactive Google page (26670)
<https://bugs.webkit.org/show_bug.cgi?id=26670>

Reviewed by Anders Carlsson

Make windows loader client match mac behaviour more closely.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-02 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 2 Jul 2009 23:53:16 +0000 (23:53 +0000)]
2009-07-02  Eric Seidel  <eric@webkit.org>

        Reviewed by David Levin.

        bugzilla-tool needs to handle login failure
        https://bugs.webkit.org/show_bug.cgi?id=26913

        We now exit(1) on login failure.

        * Scripts/modules/bugzilla.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-02 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 2 Jul 2009 23:53:01 +0000 (23:53 +0000)]
2009-07-02  David Hyatt  <hyatt@apple.com>

        Reviewed by Dan Bernstein.

        TextIterator should use hasOverflowClip when checking for overflow instead of looking at the style.
        https://bugs.webkit.org/show_bug.cgi?id=26942

        * editing/TextIterator.cpp:
        (WebCore::fullyClipsContents):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebKit/win:
bfulgham@webkit.org [Thu, 2 Jul 2009 23:49:52 +0000 (23:49 +0000)]
WebKit/win:

2009-06-30  Brent Fulgham  <bfulgham@gmail.com>

        Reviewed by Adam Roben.

        Build DumpRenderTree under Cairo.
        https://bugs.webkit.org/show_bug.cgi?id=26457

        * WebKit.vcproj/WebKit.sln: Add Cairo targets to the
          DumpRenderTree build, and use the in the Debug_Cairo
          and Release_Cairo targets.

WebKitTools:

2009-06-30  Brent Fulgham  <bfulgham@webkit.org>

        Reviewed by Adam Roben.

        Add build support for a Windows Cairo version of
        DumpRenderTree.  Share as much logic between the
        CG and Cairo builds as possible.
        https://bugs.webkit.org/show_bug.cgi?id=26457

        * DumpRenderTree/PixelDumpSupport.cpp: Added.
        (dumpWebViewAsPixelsAndCompareWithExpected): Moved common logic
          from CG-specific file.
        (printPNG): Moved common logic from CG-specific file.
        * DumpRenderTree/PixelDumpSupport.h: Add declaration for new
          common printPNG function.
        * DumpRenderTree/cairo: Added.
        * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp: Added.
          Implement cairo-specific logic for dealing with Cairo surfaces.
        (writeFunction):
        (printPNG): Cairo-specific PNG handling logic.
        (computeMD5HashStringForBitmapContext): New Cairo routine using
          the generic BitmapContext signature.
        (dumpBitmap): New function containing Cairo-specific portions of
          the dumping routine.
        * DumpRenderTree/cairo/PixelDumpSupportCairo.h: Added.
          Provide Cairo version of the BitmapContext structure so that
          dumping routines can work on an abstract type.
        (BitmapContext::createByAdoptingBitmapAndContext):
        (BitmapContext::~BitmapContext):
        (BitmapContext::cairoContext):
        (BitmapContext::BitmapContext):
        * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
        (printPNG): CG-specific PNG handling logic.
        (computeMD5HashStringForBitmapContext): Revised to use generic
          BitmapContext signature.
        (dumpBitmap): New function containing CG-specific portions of
          the dumping routine.
        * DumpRenderTree/cg/PixelDumpSupportCG.h: Add new signatures.
        * DumpRenderTree/win/DumpRenderTree.cpp: Disable CFNetwork logic
          when building the non-CFNetwork version.
        (main):
        * DumpRenderTree/win/DumpRenderTree.vcproj:
        * DumpRenderTree/win/PixelDumpSupportWin.cpp:
        (createBitmapContextFromWebView): Provide parallel Cairo implementation
          of CG bitmap/context setup.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-02 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 2 Jul 2009 23:45:32 +0000 (23:45 +0000)]
2009-07-02  Sam Weinig  <sam@webkit.org>

        Reviewed by Dave Hyatt.

        Fix for <rdar://problem/5230700>
        Remove local .xhtml file workaround

        * platform/network/mac/ResourceResponseMac.mm:
        (WebCore::ResourceResponse::platformLazyInit): Work around is no longer necessary.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoVersioning.
mrowe@apple.com [Thu, 2 Jul 2009 23:36:13 +0000 (23:36 +0000)]
Versioning.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
andersca@apple.com [Thu, 2 Jul 2009 23:34:01 +0000 (23:34 +0000)]
WebCore:

2009-07-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Sort, add functions used by WebKit.

        * WebCore.base.exp:

WebKit/mac:

2009-07-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/6978783>
        Software-rendered plug-in does not update correctly when inside a hardware layer

        Replace calls to setNeedsDisplay: and setNeedsDisplayInRect: with a call to the new method
        invalidatePluginContentRect:. This new method will ask WebCore to do the repainting, taking
        transforms into account.

        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::invalidateRect):
        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView pluginHostDied]):
        * Plugins/WebBaseNetscapePluginView.h:
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView windowBecameKey:]):
        (-[WebBaseNetscapePluginView windowResignedKey:]):
        (-[WebBaseNetscapePluginView preferencesHaveChanged:]):
        (-[WebBaseNetscapePluginView invalidatePluginContentRect:]):
        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView invalidateRect:]):
        (-[WebNetscapePluginView invalidateRegion:]):
        (-[WebNetscapePluginView forceRedraw]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-02 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 2 Jul 2009 23:31:39 +0000 (23:31 +0000)]
2009-07-02  David Hyatt  <hyatt@apple.com>

        Reviewed by Mark Rowe.

        Land new results from my change to make replaced elements no longer be overflow:hidden by
        default.  This affected plaintext dumping, which is clearly a bug in and of itself.  For now
        I am just updating the results and will file a followup bug about the fact that text dumping actually
        does something different with overflow on replaced elements (when it clearly should not).

        * fast/block/float/crash-replaced-display-block-expected.txt:
        * fast/dom/Range/acid3-surround-contents-expected.txt:
        * fast/dom/object-embed-plugin-scripting-expected.txt:
        * fast/parser/badentity-expected.txt:
        * http/tests/security/local-video-poster-from-remote-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-02 Brady Eidson <beidson@apple.com>
beidson@apple.com [Thu, 2 Jul 2009 23:28:59 +0000 (23:28 +0000)]
2009-07-02  Brady Eidson  <beidson@apple.com>

        Rubberstamped by Sam Weinig.

        More of <rdar://problem/6969425> Safari 4.0 doesn't recognize text/plain files if their extension is unknown.

        * platform/network/mac/WebCoreURLResponse.mm:
        (webNSURLResponseMIMEType): Give Tiger a chance to query the UTI machinery.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-02 Brady Eidson <beidson@apple.com>
beidson@apple.com [Thu, 2 Jul 2009 23:18:42 +0000 (23:18 +0000)]
2009-07-02  Brady Eidson  <beidson@apple.com>

        Rubberstamped by John Sullivan.

        Add Tiger-specific results for these tests.

        * platform/mac-tiger/Skipped:
        * platform/mac-tiger/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: Added.
        * platform/mac-tiger/platform/mac/fast/loader/file-url-mimetypes-3-expected.txt: Added.
        * platform/mac-tiger/platform/mac/fast/loader/file-url-mimetypes-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-02 Brady Eidson <beidson@apple.com>
beidson@apple.com [Thu, 2 Jul 2009 23:01:22 +0000 (23:01 +0000)]
2009-07-02  Brady Eidson  <beidson@apple.com>

        Skip the correct test names.

        * platform/mac-tiger/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-02 Adam Langley <agl@google.com>
agl@chromium.org [Thu, 2 Jul 2009 22:40:31 +0000 (22:40 +0000)]
2009-07-02  Adam Langley  <agl@google.com>

        Reviewed by Eric Seidel.

        Chromium Linux: fix complex text rendering with line break characters.

        https://bugs.webkit.org/show_bug.cgi?id=26935

        If the CSS white-space property is inhibiting line breaking, we might
        find end-of-line characters rendered via the complex text path. Fonts
        don't provide glyphs for these code points so, if we find one, we
        simulate the space glyph being interposed in this case.  Because the
        input is variable-length per code point, we walk the input in step
        with the output.

        Covered by:
            LayoutTests/fast/text/international/bidi-linebreak-002.html
            LayoutTests/fast/text/international/bidi-linebreak-003.html
            LayoutTests/fast/text/international/hindi-whitespace.html

        * platform/graphics/chromium/HarfbuzzSkia.cpp:
        (WebCore::stringToGlyphs):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-02 Brady Eidson <beidson@apple.com>
beidson@apple.com [Thu, 2 Jul 2009 22:25:26 +0000 (22:25 +0000)]
2009-07-02  Brady Eidson  <beidson@apple.com>

        Rubberstamped by Sam Weinig

        Split up file-url-mimetypes.html into 3 tests to avoid any risk of timing out on slower machines.

        * platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: Added.
        * platform/mac/fast/loader/file-url-mimetypes-2.html: Copied from platform/mac/fast/loader/file-url-mimetypes.html.
        * platform/mac/fast/loader/file-url-mimetypes-3-expected.txt: Added.
        * platform/mac/fast/loader/file-url-mimetypes-3.html: Copied from platform/mac/fast/loader/file-url-mimetypes.html.
        * platform/mac/fast/loader/file-url-mimetypes-expected.txt:
        * platform/mac/fast/loader/file-url-mimetypes.html:
        * platform/mac-tiger/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-02 Victor Wang <victorw@chromium.org>
dglazkov@chromium.org [Thu, 2 Jul 2009 22:22:43 +0000 (22:22 +0000)]
2009-07-02  Victor Wang  <victorw@chromium.org>

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=26521
        Expose file size to chromium.

        Implement getFileSize() for Chromium.

        * platform/chromium/ChromiumBridge.h:
        * platform/chromium/FileSystemChromium.cpp:
        (WebCore::getFileSize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-02 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 2 Jul 2009 22:21:41 +0000 (22:21 +0000)]
2009-07-02  Eric Seidel  <eric@webkit.org>

        No review, just adding Antti as a reviewer.

        * Scripts/modules/bugzilla.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-02 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Thu, 2 Jul 2009 22:21:05 +0000 (22:21 +0000)]
2009-07-02  Nate Chapin  <japhet@chromium.org>

        Unreviewed, build fix.

        * bindings/v8/V8SVGPODTypeWrapper.h: Lost a space in nested template argument list.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-02 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 2 Jul 2009 22:19:02 +0000 (22:19 +0000)]
2009-07-02  Simon Fraser  <simon.fraser@apple.com>

        Build fix: add missing #include.

        * platform/mac/ThemeMac.mm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-02 Brady Eidson <beidson@apple.com>
beidson@apple.com [Thu, 2 Jul 2009 22:17:19 +0000 (22:17 +0000)]
2009-07-02  Brady Eidson  <beidson@apple.com>

        Resolve failing Tiger layout test until I can fix it.

        * platform/mac-tiger/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-02 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 2 Jul 2009 21:56:55 +0000 (21:56 +0000)]
2009-07-02  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt.

        <rdar://problem/7028682> ThemeMac::paintRadio() throws Obj-C exceptions when zoomed

        Add BEGIN_BLOCK_OBJC_EXCEPTIONS/END_BLOCK_OBJC_EXCEPTIONS guards around code
        that can possibly throw Objective-C exceptions when drawing Mac form controls.

        * platform/mac/ThemeMac.mm:
        (WebCore::paintCheckbox):
        (WebCore::paintRadio):
        (WebCore::paintButton):
        (WebCore::ThemeMac::inflateControlPaintRect):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-02 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Thu, 2 Jul 2009 21:47:45 +0000 (21:47 +0000)]
2009-07-02  Nate Chapin  <japhet@chromium.org>

        Reviewed by David Levin.

        Upstream V8SVGPODTypeWrapper.

        https://bugs.webkit.org/show_bug.cgi?id=26907

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-02 Dumitru Daniliuc <dumi@chromium.org>
dglazkov@chromium.org [Thu, 2 Jul 2009 21:40:12 +0000 (21:40 +0000)]
2009-07-02  Dumitru Daniliuc  <dumi@chromium.org>

        Reviewed by Dimitri Glazkov.

        Adds an abstraction layer between the DB classes and the file
        system, which allows us to add our own logic for storing, opening,
        deleting, etc. databases.

        The patch was tested using the tests in WebCore/storage.

        https://bugs.webkit.org/show_bug.cgi?id=26054

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/sql/SQLiteDatabase.cpp:
        (WebCore::SQLiteDatabase::open): Delegating the job of opening DB files to SQLiteFileSystem to allow use of custom VFSs.
        * platform/sql/SQLiteFileSystem.cpp: Added.
        * platform/sql/SQLiteFileSystem.h: Added.
        * platform/win/FileSystemWin.cpp:
        (WebCore::directoryName): Implemented.
        * storage/Database.cpp:
        (WebCore::Database::databaseSize): The code that returns the size of a DB file moved to SQLiteFileSystem.
        * storage/DatabaseTracker.cpp:
        (WebCore::DatabaseTracker::DatabaseTracker): Added the ability to register a custom SQLite VFS.
        (WebCore::DatabaseTracker::trackerDatabasePath): DB file-related operations moved to SQLiteFileSystem.
        (WebCore::DatabaseTracker::openTrackerDatabase): DB file-related operations moved to SQLiteFileSystem.
        (WebCore::DatabaseTracker::originPath): DB file-related operations moved to SQLiteFileSystem.
        (WebCore::DatabaseTracker::fullPathForDatabase): DB file-related operations moved to SQLiteFileSystem.
        (WebCore::DatabaseTracker::usageForDatabase): DB file-related operations moved to SQLiteFileSystem.
        (WebCore::DatabaseTracker::deleteOrigin): DB file-related operations moved to SQLiteFileSystem.
        (WebCore::DatabaseTracker::deleteDatabaseFile): DB file-related operations moved to SQLiteFileSystem.
        * storage/OriginUsageRecord.cpp:
        (WebCore::OriginUsageRecord::diskUsage): DB file-related operations moved to SQLiteFileSystem.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-02 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 2 Jul 2009 20:47:57 +0000 (20:47 +0000)]
2009-07-02  David Hyatt  <hyatt@apple.com>

        Reviewed by Simon Fraser.

        Always clip replaced elements to border radii.
        https://bugs.webkit.org/show_bug.cgi?id=26933

        Make sure to always clip replaced elements to border radii, even when overflow is visible.
        Stop defaulting those elements to overflow:hidden in the UA sheet, since it is now no longer
        necessary.

        Covered by existing tests (since the UA default changing keeps the behavior exactly the same).

        * css/html.css:
        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::paint):
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::paint):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-02 Jeremy Orlow <jorlow@chromium.org>
hyatt@apple.com [Thu, 2 Jul 2009 20:18:53 +0000 (20:18 +0000)]
2009-07-02  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Simon Fraser.

        convertFromScrollbarToContainingView and friends should be in ScrollView
        https://bugs.webkit.org/show_bug.cgi?id=26929

        This is breaking Chromium's build because PopupMenuChromium inherits
        from ScrollView, but these functions are pure virtual in it.  I could
        put it directly in PopupMenuChromium, but that seems a bit silly since
        the functions are fairly generic.

        Passes existing layout tests.

        * page/FrameView.cpp:  Remove the 4 functions Hyatt just added
        (IntRect WebCore::FrameView::convertFromScrollbarToContainingView):
        (IntRect WebCore::FrameView::convertFromContainingViewToScrollBar):
        (IntPoint WebCore::FrameView::convertFromScrollbarToContainingView):
        (IntPoint WebCore::FrameView::convertFromContainingViewToScrollBar):
        * page/FrameView.h: ditto
        * platform/ScrollView.cpp:  Move the 4 functions from FrameView here
        (IntRect WebCore::ScrollView::convertFromScrollbarToContainingView):
        (IntRect WebCore::ScrollView::convertFromContainingViewToScrollBar):
        (IntPoint WebCore::ScrollView::convertFromScrollbarToContainingView):
        (IntPoint WebCore::ScrollView::convertFromContainingViewToScrollBar):
        * platform/ScrollView.h: ditto

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix warnings from update-webkit-localizable-strings
aroben@apple.com [Thu, 2 Jul 2009 18:39:15 +0000 (18:39 +0000)]
Fix warnings from update-webkit-localizable-strings

WebKit:

        Fix warnings from update-webkit-localizable-strings

        Rubber-stamped by Eric Carlson.

        * English.lproj/Localizable.strings: Updated.

WebKit/mac:

        Fix warnings from update-webkit-localizable-strings

        Rubber-stamped by Eric Carlson.

        * WebCoreSupport/WebViewFactory.mm:
        (-[WebViewFactory mediaElementLoadingStateText]):
        (-[WebViewFactory mediaElementLiveBroadcastStateText]):
        Changed the localization comments to match the comments in the Windows
        version of this file, to avoid warnings about different comments for
        the same localized string.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Update StringsNotToBeLocalized.txt for (not so) recent changes
aroben@apple.com [Thu, 2 Jul 2009 18:39:03 +0000 (18:39 +0000)]
    Update StringsNotToBeLocalized.txt for (not so) recent changes

        Bug 26926: StringsNotToBeLocalized.txt is out-of-date
        <https://bugs.webkit.org/show_bug.cgi?id=26926>

        Reviewed by John Sullivan.

        * StringsNotToBeLocalized.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-02 Dirk Pranke <dpranke@chromium.org>
darin@chromium.org [Thu, 2 Jul 2009 18:06:53 +0000 (18:06 +0000)]
2009-07-02  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Darin Fisher.

        Fix https://bugs.webkit.org/show_bug.cgi?id=26088 - TransparencyWin
        doesn't handle errors well at all; revise it to fail silently
        (drawing nothing), and bulletproof FontChromiumWin to handle the
        failure accordingly.

        Tests: fast/text/text-large-negative-letter-spacing-with-opacity.html
               fast/text/text-letter-spacing.html

        * platform/graphics/chromium/FontChromiumWin.cpp:
        (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
        (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
        (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter):
        (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::~TransparencyAwareGlyphPainter):
        (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
        (WebCore::Font::drawGlyphs):
        (WebCore::Font::drawComplexText):
        * platform/graphics/chromium/TransparencyWin.cpp:
        (WebCore::TransparencyWin::TransparencyWin):
        (WebCore::TransparencyWin::setupLayerForNoLayer):
        (WebCore::TransparencyWin::setupLayerForOpaqueCompositeLayer):
        (WebCore::TransparencyWin::setupLayerForWhiteLayer):
        (WebCore::TransparencyWin::setupTransformForKeepTransform):
        (WebCore::TransparencyWin::setupTransformForScaleTransform):
        (WebCore::TransparencyWin::initializeNewContext):
        (WebCore::TransparencyWin::compositeOpaqueComposite):
        (WebCore::TransparencyWin::compositeTextComposite):
        (WebCore::TransparencyWin::makeLayerOpaque):
        * platform/graphics/chromium/TransparencyWin.h:
        (WebCore::TransparencyWin::platformContext):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix build bustage caused by wrong include case.
hyatt@apple.com [Thu, 2 Jul 2009 17:51:50 +0000 (17:51 +0000)]
Fix build bustage caused by wrong include case.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-02 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Thu, 2 Jul 2009 17:41:34 +0000 (17:41 +0000)]
2009-07-02  Eric Carlson  <eric.carlson@apple.com>

        Change #import to #include to fix non-ObjC builds.

        * rendering/MediaControlElements.cpp:

2009-07-02  Eric Carlson  <eric.carlson@apple.com>

        Fix Windows build by including missing localized string methods.

        * WebCoreLocalizedStrings.cpp:
        (WebCore::mediaElementLoadingStateText):
        (WebCore::mediaElementLiveBroadcastStateText):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-02 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 2 Jul 2009 17:32:25 +0000 (17:32 +0000)]
2009-07-02  Anders Carlsson  <andersca@apple.com>

        Build fix.

        * platform/network/mac/WebCoreURLResponse.mm:
        (mimeTypeFromUTITree):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
hyatt@apple.com [Thu, 2 Jul 2009 17:31:42 +0000 (17:31 +0000)]
WebCore:

2009-07-02  David Hyatt  <hyatt@apple.com>

        Reviewed by Simon Fraser.

        Fix for bug 22119, clicks in the scrollbars of transformed content don't work.  Add new
        conversion methods for going across parent/child widget boundaries that can be implemented
        by the FrameView and ScrollbarClient to be transform-aware.

        Test cases added in platform/mac/fast/forms and platform/mac/fast/overflow.

        * WebCore.base.exp:
        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMouseMoveEvent):
        * page/FrameView.cpp:
        (WebCore::FrameView::convertFromScrollbarToContainingView):
        (WebCore::FrameView::convertFromContainingViewToScrollbar):
        (WebCore::FrameView::convertFromRenderer):
        (WebCore::FrameView::convertToRenderer):
        (WebCore::FrameView::convertToContainingView):
        (WebCore::FrameView::convertFromContainingView):
        * page/FrameView.h:
        * platform/ScrollView.h:
        * platform/Scrollbar.cpp:
        (WebCore::Scrollbar::convertToContainingView):
        (WebCore::Scrollbar::convertFromContainingView):
        * platform/Scrollbar.h:
        * platform/ScrollbarClient.h:
        (WebCore::ScrollbarClient::convertFromScrollbarToContainingView):
        (WebCore::ScrollbarClient::convertFromContainingViewToScrollbar):
        * platform/Widget.cpp:
        (WebCore::Widget::convertFromContainingWindow):
        (WebCore::Widget::convertToContainingWindow):
        (WebCore::Widget::convertFromRootToContainingWindow):
        (WebCore::Widget::convertFromContainingWindowToRoot):
        (WebCore::Widget::convertToContainingView):
        (WebCore::Widget::convertFromContainingView):
        * platform/Widget.h:
        * platform/graphics/IntPoint.h:
        (WebCore::IntPoint::move):
        * platform/mac/WidgetMac.mm:
        (WebCore::Widget::convertFromRootToContainingWindow):
        (WebCore::Widget::convertFromContainingWindowToRoot):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::isPointInOverflowControl):
        * rendering/RenderDataGrid.cpp:
        (WebCore::RenderDataGrid::convertFromScrollbarToContainingView):
        (WebCore::RenderDataGrid::convertFromContainingViewToScrollbar):
        * rendering/RenderDataGrid.h:
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::convertFromScrollbarToContainingView):
        (WebCore::RenderLayer::convertFromContainingViewToScrollbar):
        (WebCore::RenderLayer::scrollbarOffset):
        (WebCore::RenderLayer::hitTestOverflowControls):
        * rendering/RenderLayer.h:
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::isPointInOverflowControl):
        (WebCore::RenderListBox::convertFromScrollbarToContainingView):
        (WebCore::RenderListBox::convertFromContainingViewToScrollbar):
        * rendering/RenderListBox.h:

LayoutTests:

2009-07-02  David Hyatt  <hyatt@apple.com>

        Reviewed by Simon Fraser.

        Test cases for bug 22119, clicks in scrollbar of transformed element don't work.

        * platform/mac/fast/forms/listbox-scrollbar-hit-test-expected.txt: Added.
        * platform/mac/fast/forms/listbox-scrollbar-hit-test.html: Added.
        * platform/mac/fast/overflow/overflow-scrollbar-hit-test-expected.txt: Added.
        * platform/mac/fast/overflow/overflow-scrollbar-hit-test.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Thu, 2 Jul 2009 17:19:12 +0000 (17:19 +0000)]
WebCore:

        Reviewed by Dave Hyatt and Simon Fraser.

        - fix <rdar://problem/6933052> SPOD playing video in a div with a box
          shadow

        Test: fast/box-shadow/transform-fringing.html

        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintBoxShadow): Clip out the
        box even if it has an opaque background, but in that case, inset the
        clip path by 1 pixel, to avoid antialiasing artifacts.
        Do not inset the clip rect by 1 pixel if the CTM is purely a
        translation.
        Move the shadow-casting path away in the non-rounded-rect case (it
        was already being done in the rounded-rect case), to avoid a black
        fringe when the CTM is not purely a translation.

LayoutTests:

        Reviewed by Dave Hyatt and Simon Fraser.

        - test for part of <rdar://problem/6933052> SPOD playing video in a div
          with a box shadow

        * fast/box-shadow/transform-fringing.html: Added.
        * platform/mac/fast/box-shadow/transform-fringing-expected.checksum: Added.
        * platform/mac/fast/box-shadow/transform-fringing-expected.png: Added.
        * platform/mac/fast/box-shadow/transform-fringing-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
beidson@apple.com [Thu, 2 Jul 2009 17:00:47 +0000 (17:00 +0000)]
WebCore:

2009-07-02  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig.

        <rdar://problem/6969425> Safari 4.0 doesn't recognize text/plain files if their extension is unknown.

        Walk the CoreTypes UTI tree for extensions with unknown MIME types, using the first MIME type found.

        For many types of text files (such as source code files) this ends up being text/plain.

        * platform/network/mac/ResourceHandleMac.mm:
        (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): Tweak the logging output.

        * platform/network/mac/WebCoreURLResponse.h:
        * platform/network/mac/WebCoreURLResponse.mm:
        (mimeTypeFromUTITree):
        (webNSURLResponseMIMEType): Use mimeTypeFromUTITree() to find a UTI-based MIME type for this file's extension.
        (-[NSURLResponse _webcore_reportedMIMEType]): Return the actual MIME type that CFNetwork gave us.

LayoutTests:

2009-07-02  Brady Eidson  <beidson@apple.com>

        Rubberstamped by Sam Weinig.

        Add more sample files for extensions we should know the MIME types for.

        * platform/mac/fast/loader/file-url-mimetypes.html:
        * platform/mac/fast/loader/file-url-mimetypes-expected.txt:
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-3fr.3fr: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-aaf.aaf: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-ada.ada: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-adb.adb: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-ads.ads: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-app.app: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-applescript.applescript: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-arw.arw: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-as.as: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-aupreset.aupreset: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-c++.c++: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-c.c: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-caf.caf: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-cc.cc: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-cp.cp: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-cpp.cpp: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-cr2.cr2: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-cxx.cxx: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-defs.defs: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-dfont.dfont: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-dlyan.dlyan: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-dng.dng: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-dylib.dylib: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-exp.exp: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-exr.exr: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-f.f: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-f77.f77: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-f90.f90: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-f95.f95: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-fff.fff: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-for.for: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-h++.h++: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-h.h: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-hh.hh: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-hp.hp: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-hpp.hpp: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-hxx.hxx: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-icc.icc: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-icm.icm: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-icns.icns: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-jav.jav: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-java.java: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-jfx.jfx: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-l.l: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-lid.lid: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-lm.lm: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-lmm.lmm: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-lpp.lpp: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-lxx.lxx: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-m.m: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-m4a.m4a: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-m4b.m4b: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-m4v.m4v: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-mig.mig: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-mm.mm: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-mos.mos: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-mrw.mrw: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-nef.nef: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-o.o: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-omf.omf: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-orf.orf: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-pas.pas: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-pch++.pch++: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-pch.pch: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-pef.pef: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-pf.pf: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-pfa.pfa: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-pfb.pfb: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-plist.plist: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-r.r: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-raf.raf: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-raw.raw: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-s.s: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-scpt.scpt: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-sd2.sd2: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-sf2.sf2: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-srf.srf: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-suit.suit: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-tbz.tbz: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-tbz2.tbz2: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-ttc.ttc: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-ttf.ttf: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-ul.ul: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-ulaw.ulaw: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-ulw.ulw: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-war.war: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-y.y: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-ym.ym: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-ymm.ymm: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-ypp.ypp: Added.
        * platform/mac/fast/loader/resources/mimeTypeExamples/example-yxx.yxx: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-02 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 2 Jul 2009 16:33:40 +0000 (16:33 +0000)]
2009-07-02  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Compositing-related preference methods are not public API; should move to WebPreferencesPrivate.h
        <rdar://problem/7027363>

        Move accelerated-compositing pref to WebPreferencesPrivate.h

        * WebView/WebPreferences.h:
        * WebView/WebPreferences.mm:
        (-[WebPreferences acceleratedCompositingEnabled]):
        (-[WebPreferences setAcceleratedCompositingEnabled:]):
        * WebView/WebPreferencesPrivate.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-02 Pierre d'Herbemont <pdherbemont@apple.com>
eric.carlson@apple.com [Thu, 2 Jul 2009 15:47:55 +0000 (15:47 +0000)]
2009-07-02  Pierre d'Herbemont  <pdherbemont@apple.com>

        Reviewed by Simon Fraser.

        <rdar://problem/6518119>

        Add a rewind button and hide the timeline for live broadcasts when
        in MediaUI mode.

        * css/CSSPrimitiveValueMappings.h:
        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Add the new pseudo element.

        * css/CSSSelector.cpp:
        (WebCore::CSSSelector::extractPseudoType): Ditto.
        * css/CSSSelector.h:

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Ditto.

        * css/CSSValueKeywords.in: Ditto.
        * css/mediaControls.css: Ditto.
        * css/mediaControlsQT.css: Ditto.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::rewind): New.
        (WebCore::HTMLMediaElement::returnToRealTime): New.
        (WebCore::HTMLMediaElement::isStreaming): New.
        * html/HTMLMediaElement.h:

        * page/mac/WebCoreViewFactory.h: Declare mediaElementLoadingStateText and mediaElementLiveBroadcastStateText.

        * platform/LocalizedStrings.h: Add localized media state messages.

        * platform/ThemeTypes.h: Add the new pseudo element.

        * platform/mac/LocalizedStringsMac.mm:
        (WebCore::mediaElementLoadingStateText): Add localized media state.
        (WebCore::mediaElementLiveBroadcastStateText): Ditto.

        * platform/mac/WebCoreSystemInterface.h: Change BOOL param wkDrawMediaUIPart to an int to support
           multiple states.
        * platform/mac/WebCoreSystemInterface.mm: Ditto.

        * rendering/MediaControlElements.cpp:
        (WebCore::MediaControlElement::MediaControlElement): Deal with new elements.
        (WebCore::MediaControlElement::attachToParent): Ditto.
        (WebCore::MediaControlElement::update): Ditto.
        (WebCore::MediaControlElement::updateStyle): Ditto.
        (WebCore::MediaControlTimelineContainerElement::MediaControlTimelineContainerElement): Ditto.
        (WebCore::MediaControlTimelineContainerElement::rendererIsNeeded): Ditto.
        (WebCore::MediaControlStatusDisplayElement::MediaControlStatusDisplayElement): Ditto.
        (WebCore::MediaControlStatusDisplayElement::update): Ditto.
        (WebCore::MediaControlStatusDisplayElement::rendererIsNeeded): Ditto.
        (WebCore::MediaControlInputElement::MediaControlInputElement): Ditto.
        (WebCore::MediaControlInputElement::attachToParent): Ditto.
        (WebCore::MediaControlInputElement::updateStyle): Ditto.
        (WebCore::MediaControlRewindButtonElement::MediaControlRewindButtonElement): Ditto.
        (WebCore::MediaControlRewindButtonElement::defaultEventHandler): Ditto.
        (WebCore::MediaControlReturnToRealtimeButtonElement::MediaControlReturnToRealtimeButtonElement): Ditto.
        (WebCore::MediaControlReturnToRealtimeButtonElement::defaultEventHandler): Ditto.
        (WebCore::MediaControlReturnToRealtimeButtonElement::rendererIsNeeded): Ditto.
        (WebCore::MediaControlTimelineElement::defaultEventHandler): Ditto.
        (WebCore::MediaControlTimelineElement::update): Ditto.
        (WebCore::MediaControlFullscreenButtonElement::rendererIsNeeded): Ditto.
        * rendering/MediaControlElements.h: Ditto.

        * rendering/RenderMedia.cpp:
        (WebCore::RenderMedia::styleDidChange): Deal with the new elements.
        (WebCore::RenderMedia::createPanel): Ditto.
        (WebCore::RenderMedia::createRewindButton): Ditto.
        (WebCore::RenderMedia::createReturnToRealtimeButton): Ditto.
        (WebCore::RenderMedia::createStatusDisplay): Ditto.
        (WebCore::RenderMedia::createTimelineContainer): Ditto.
        (WebCore::RenderMedia::createCurrentTimeDisplay): Ditto.
        (WebCore::RenderMedia::createTimeRemainingDisplay): Ditto.
        (WebCore::RenderMedia::updateControls): Ditto.
        (WebCore::RenderMedia::forwardEvent): Ditto.
        * rendering/RenderMedia.h:

        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::paint): Deal with the new elements.

        * rendering/RenderTheme.h:
        (WebCore::RenderTheme::paintMediaRewindButton): Deal with the new elements.
        (WebCore::RenderTheme::paintMediaReturnToRealtimeButton): Ditto.
        (WebCore::RenderTheme::paintMediaControlsBackground): Ditto.

        * rendering/RenderThemeMac.h:
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::paintMediaRewindButton): Deal with the new elements.
        (WebCore::RenderThemeMac::paintMediaReturnToRealtimeButton): Ditto.
        (WebCore::RenderThemeMac::paintMediaControlsBackground): Ditto.

        * rendering/style/RenderStyleConstants.h: Add constants for the new elements.

2009-07-02  Pierre d'Herbemont  <pdherbemont@apple.com>

        Reviewed by Simon Fraser.

        <rdar://problem/6518119>

        Add localized strings for media controller status messages.

        * English.lproj/Localizable.strings: Localized text.

2009-07-02  Pierre d'Herbemont  <pdherbemont@apple.com>

        Reviewed by Simon Fraser.

        <rdar://problem/6518119>

        Add localized strings for media controller status.

        * WebCoreSupport/WebViewFactory.mm: Add new localized text.
        (-[WebViewFactory mediaElementLoadingStateText]):
        (-[WebViewFactory mediaElementLiveBroadcastStateText]):

2009-07-02  Pierre d'Herbemont  <pdherbemont@apple.com>

        Reviewed by Simon Fraser.

        Update WebKitSystemInterface for <rdar://problem/6518119>

        * WebKitSystemInterface.h:
        * libWebKitSystemInterfaceLeopard.a:
        * libWebKitSystemInterfaceSnowLeopard.a:
        * libWebKitSystemInterfaceTiger.a:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebKitTools:
hausmann@webkit.org [Thu, 2 Jul 2009 14:15:35 +0000 (14:15 +0000)]
WebKitTools:

2009-07-02  Antonio Gomes   <antonio.gomes@openbossa.org>

        Reviewed by Simon Hausmann.

        https://bugs.webkit.org/show_bug.cgi?id=26896

        [Qt] Set DRT's default fontsize to 13.

        * DumpRenderTree/qt/DumpRenderTree.cpp:
        (WebCore::WebPage::WebPage):

LayoutTests:

2009-07-02  Antonio Gomes   <antonio.gomes@openbossa.org>

        Reviewed by Simon Hausmann.

        https://bugs.webkit.org/show_bug.cgi?id=26896

        Updated computed-style-expected.txt and computed-style-without-renderer-expected.txt
        files according to the default font size value (13) set in DumpRenderTree/qt/DumpRenderTree.cpp .

        * platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
        * platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-02 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Thu, 2 Jul 2009 14:00:46 +0000 (14:00 +0000)]
2009-07-02  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Ariya Hidayat.

        Improve documentation of QWebFrame::setFocus and hasFocus()
        Added missing Q_PROPERTY for QWebFrame::hasFocus.

        * Api/qwebframe.cpp: Clarify the docs.
        * Api/qwebframe.h: add Q_PROPERTY(focus).

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-02 Joe Ligman <joseph.ligman@nokia.com>
hausmann@webkit.org [Thu, 2 Jul 2009 13:47:15 +0000 (13:47 +0000)]
2009-07-02  Joe Ligman  <joseph.ligman@nokia.com>

        Reviewed by Simon Hausmann.

        Bug 26855: [Qt] New methods for QWebFrame to check and set focus.

        Added new public methods QWebFrame::hasFocus() and QWebFrame::setFocus()
        Added auto test.

        * Api/qwebframe.cpp:
        (QWebFrame::hasFocus):
        (QWebFrame::setFocus):
        * Api/qwebframe.h:
        * tests/qwebframe/tst_qwebframe.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-02 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 2 Jul 2009 11:50:46 +0000 (11:50 +0000)]
2009-07-02  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Holger Freyther.

        Update the new boolean property in FocusController that keeps
        track of whether or not the Page is focused.

        * webkit/webkitwebview.cpp:
        (webkit_web_view_focus_in_event):
        (webkit_web_view_focus_out_event):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-01 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 2 Jul 2009 06:54:37 +0000 (06:54 +0000)]
2009-07-01  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        bugzilla-tool fails for SVN users
        https://bugs.webkit.org/show_bug.cgi?id=26914

        To fix this I moved svn from -F - to using -m
        In order for -m to work I had to move us off of shell=True
        To move off of shell=True all call sites for run_command
        which take args, need to pass their args as an list instead of a string.

        In order for the final bug update to work correctly, I had to
        abstract the way that we parse out revision numbers from the commit text.

        * Scripts/bugzilla-tool:
        * Scripts/modules/scm.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-01 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 2 Jul 2009 06:30:05 +0000 (06:30 +0000)]
2009-07-01  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        <video> fails to show on http://camendesign.com/code/video_for_everybody
        <rdar://problem/7026010>
        https://bugs.webkit.org/show_bug.cgi?id=26919

        Fix an issue introduced in r44961. In that revision we changed to only update
        compositing layer geometry when all siblings had been laid out (i.e. we pushed
        the updates one level down). However, that left out the root layer, so this
        fix ensures that the root layer geometry gets updated at the end.

        Test: compositing/geometry/root-layer-update.html

        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::updateAfterLayout):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-01 John Abd-El-Malek <jam@chromium.org>
darin@chromium.org [Thu, 2 Jul 2009 06:26:45 +0000 (06:26 +0000)]
2009-07-01  John Abd-El-Malek  <jam@chromium.org>

        Reviewed by Darin Fisher.

        Small refactoring of MessagePortChannel so that PlatformMessagePortChannel
        may be defined at the WebKit layer.

        https://bugs.webkit.org/show_bug.cgi?id=26905

        * dom/MessageChannel.cpp:
        (WebCore::MessageChannel::MessageChannel):
        * dom/MessagePortChannel.cpp:
        * dom/MessagePortChannel.h:
        * dom/default/PlatformMessagePortChannel.cpp:
        (WebCore::MessagePortChannel::createChannel):
        (WebCore::MessagePortChannel::create):
        (WebCore::MessagePortChannel::MessagePortChannel):
        (WebCore::MessagePortChannel::~MessagePortChannel):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-01 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 2 Jul 2009 06:04:17 +0000 (06:04 +0000)]
2009-07-01  Xan Lopez  <xlopez@igalia.com>

        Disable accessibility tests until we have the accessibility
        controller.

        * platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-01 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 2 Jul 2009 05:13:50 +0000 (05:13 +0000)]
2009-07-01  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein

        <rdar://problem/7026010> <video> fails to show on http://camendesign.com/code/video_for_everybody

        First part of fix: when outline width changes, don't to a synchronous
        layer update right away, but just set the flag to say that compositing
        layers need updating. The synchronous layer update left the layer geometries
        out of whack when it happened in the middle of layout (e.g. when inside ::first-letter).

        Test: compositing/geometry/outline-change.html

        * rendering/RenderView.cpp:
        (WebCore::RenderView::setMaximalOutlineSize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-01 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 2 Jul 2009 05:13:41 +0000 (05:13 +0000)]
2009-07-01  Eric Seidel  <eric@webkit.org>

        Reviewed by Maciej Stachowiak.

        prepare-ChangeLog should have a --bug= argument and use it for url autofill
        https://bugs.webkit.org/show_bug.cgi?id=26383

        prepare-ChangeLog now knows how to grab the bug title from bugs.webkit.org
        I also added a bit more template text in an effort to get better ChangeLogs
        from casual contributers.

        * Scripts/prepare-ChangeLog:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-01 Robert Hogan <robert@roberthogan.net>
eric@webkit.org [Thu, 2 Jul 2009 02:08:44 +0000 (02:08 +0000)]
2009-07-01  Robert Hogan <robert@roberthogan.net>

        Reviewed by NOBODY.

        Fix Qt segfault when javascript disabled.
        If clients call addToJavaScriptWindowObject even though JavascriptEnabled is false
        webkit will segfault on the assert:
          ASSERTION FAILED: _rootObject
          (../../../WebCore/bridge/runtime.cpp:52
          JSC::Bindings::Instance::Instance(WTF::PassRefPtr<JSC::Bindings::RootObject>))
        Fix is to ensure JavaScript is enabled when client calls addToJavaScriptWindowObject.

        https://bugs.webkit.org/show_bug.cgi?id=26906

        * Api/qwebframe.cpp:
        (QWebFrame::addToJavaScriptWindowObject):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-01 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Thu, 2 Jul 2009 02:01:20 +0000 (02:01 +0000)]
2009-07-01  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=26842
        Build fix when ENABLE_DATABASE is off

        Move Database.h into ENABLE(DATABASE) guard so toggling ENABLE_DATABASE
        off does not break builds.

        * bindings/js/ScriptObjectQuarantine.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
abarth@webkit.org [Thu, 2 Jul 2009 01:35:43 +0000 (01:35 +0000)]
WebCore:

2009-07-01  Daniel Bates  <dbates@intudata.com>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=26899

        Modified XSSAuditor::decodeURL to only remove null characters so that
        it is consistent with the behavior of HTMLTokenizer and prevents
        injected scripts that contain control characters.

        Tests: http/tests/security/xssAuditor/script-tag-control-char.html
               http/tests/security/xssAuditor/script-tag-null-char.html

        * page/XSSAuditor.cpp:
        (WebCore::XSSAuditor::decodeURL): Modified to only remove null characters.
        * page/XSSAuditor.h: Reverted naming of third argument of method XSSAuditor::decodeURL
        from allowControlCharacters back to allowNullCharacters.
        * platform/network/ResourceResponseBase.cpp: Reverted back to rev #45003.
        (WebCore::isControlCharacter):
        * platform/network/ResourceResponseBase.h: Reverted back to rev #45003.

LayoutTests:

2009-07-01  Daniel Bates  <dbates@intudata.com>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=26899

        Tests that XSSAuditor prevents injected scripts that contain control characters.

        * http/tests/security/xssAuditor/script-tag-control-char-expected.txt: Added.
        * http/tests/security/xssAuditor/script-tag-control-char.html: Added.
        * http/tests/security/xssAuditor/script-tag-null-char-expected.txt: Added.
        * http/tests/security/xssAuditor/script-tag-null-char.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-01 Yury Semikhatsky <yurys@chromium.org>
eric@webkit.org [Thu, 2 Jul 2009 01:03:18 +0000 (01:03 +0000)]
2009-07-01  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Timothy Hatcher.

        - supported keyboard shortcuts compatible with Firebug in Scripts Debugger:
        F5, Ctrl+/ (win,lin), Command+/ (mac) - continue
        F10, Ctrl+' (win, lin), Command+' (mac) - step over
        F11, Ctrl+; (win, lin), Command+; (mac) - step into
        Shift+F11, Ctrl+Shift+; (win, lin), Command+Shift+; (mac) - step out

        - added call stack navigation shortcuts:
        Ctrl+. - next call frame
        Ctrl+, - previouse call frame

        https://bugs.webkit.org/show_bug.cgi?id=23849

        * inspector/front-end/CallStackSidebarPane.js:
        (WebInspector.CallStackSidebarPane):
        (WebInspector.CallStackSidebarPane.prototype.handleKeyEvent):
        (WebInspector.CallStackSidebarPane.prototype._selectNextCallFrameOnStack):
        (WebInspector.CallStackSidebarPane.prototype._selectPreviousCallFrameOnStack):
        (WebInspector.CallStackSidebarPane.prototype._selectedPlacardByIndex):
        (WebInspector.CallStackSidebarPane.prototype._selectedCallFrameIndex):
        * inspector/front-end/KeyboardShortcut.js: Added.
        (WebInspector.KeyboardShortcut):
        (WebInspector.KeyboardShortcut.makeKey):
        (WebInspector.KeyboardShortcut.makeKeyFromEvent):
        (WebInspector.KeyboardShortcut.makeKeyFromCodeAndModifiers_):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        (WebInspector.ScriptsPanel.prototype.handleKeyEvent):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-01 Daniel Erat <derat@google.com>
agl@chromium.org [Thu, 2 Jul 2009 00:54:26 +0000 (00:54 +0000)]
2009-07-01  Daniel Erat  <derat@google.com>

        Reviewed by David Levin.

        Chromium Linux: Move the scrollbar thumb on middle-click.

        https://bugs.webkit.org/show_bug.cgi?id=26910
        http://code.google.com/p/chromium/issues/detail?id=11976

        Tested by building Chrome and checking that the scrollbar moves as expected.

        * platform/chromium/ScrollbarThemeChromium.cpp:
        * platform/chromium/ScrollbarThemeChromium.h:
        * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
        * platform/chromium/ScrollbarThemeChromiumLinux.h:
        * platform/chromium/ScrollbarThemeChromiumWin.cpp:
        * platform/chromium/ScrollbarThemeChromiumWin.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
beidson@apple.com [Thu, 2 Jul 2009 00:38:02 +0000 (00:38 +0000)]
WebCore:

2009-07-01  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig.

        Add a preference/setting to toggle whether content sniffing is enabled for file URLs.

        * WebCore.base.exp:

        * page/Settings.cpp:
        (WebCore::Settings::setLocalFileContentSniffingEnabled):
        * page/Settings.h:
        (WebCore::Settings::localFileContentSniffingEnabled):

        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::start):
        (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):

WebKit/mac:

2009-07-01  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig.

        Add a preference/setting to toggle whether content sniffing is enabled for file URLs.

        * WebView/WebPreferenceKeysPrivate.h:

        * WebView/WebPreferences.mm:
        (+[WebPreferences initialize]):
        (-[WebPreferences localFileContentSniffingEnabled]):
        (-[WebPreferences setLocalFileContentSniffingEnabled:]):
        * WebView/WebPreferencesPrivate.h:

        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBug 26909: aria-label needs to be supported
cfleizach@apple.com [Wed, 1 Jul 2009 23:34:54 +0000 (23:34 +0000)]
Bug 26909: aria-label needs to be supported
https://bugs.webkit.org/show_bug.cgi?id=26909

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-01 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 1 Jul 2009 23:31:37 +0000 (23:31 +0000)]
2009-07-01  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Roben.

        prepare-ChangeLog should fail when EMAIL_ADDRESS or REAL_NAME are missing:
        https://bugs.webkit.org/show_bug.cgi?id=26692

        I also made prepare-ChangeLog sanity-check names and email addresses a little.
        Names must contain a space, and email addresses must contain '@'

        Also "fixed" $email_address to $emailAddress.  This script uses mixed variable name styles.

        * Scripts/prepare-ChangeLog:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-01 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Wed, 1 Jul 2009 23:15:30 +0000 (23:15 +0000)]
2009-07-01  David Hyatt  <hyatt@apple.com>

        Reviewed by Oliver Hunt.

        More datagrid columns work.  Make sure columns cache both a style for the column header as well
        as a style for the column background (behind the cells).

        Hook up to CSSStyleSelector methods for obtaining the pseudo styles for columns (stubbed out and
        unimplemented).

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::pseudoStyleForDataGridColumn):
        (WebCore::CSSStyleSelector::pseudoStyleForDataGridColumnHeader):
        * css/CSSStyleSelector.h:
        * html/DataGridColumn.h:
        (WebCore::DataGridColumn::setColumnList):
        (WebCore::DataGridColumn::columnStyle):
        (WebCore::DataGridColumn::setColumnStyle):
        (WebCore::DataGridColumn::headerStyle):
        (WebCore::DataGridColumn::setHeaderStyle):
        * rendering/RenderDataGrid.cpp:
        (WebCore::RenderDataGrid::recalcStyleForColumn):
        (WebCore::RenderDataGrid::columnStyle):
        (WebCore::RenderDataGrid::headerStyle):
        (WebCore::RenderDataGrid::paintColumnHeaders):
        * rendering/RenderDataGrid.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-01 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Wed, 1 Jul 2009 22:33:44 +0000 (22:33 +0000)]
2009-07-01  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Oliver Hunt.

        <rdar://problem/7009870> After <audio> movie finishes playing, Pause button fails to change
        back to Play button

        Grab onto the current time when QTKit "ended" notification fires and use it as
        duration from that point on as QuickTime sometimes refuses to play all the way to
        the time it reports for duration and buffered. HTMLMediaElement assumes that there
        more to play in this situation and tries to restart playback, endlessly.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
            Rename m_duration to m_reportedDuration. Declare m_cachedDuration.
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
            Rename m_duration to m_reportedDuration. Initialize m_cachedDuration.
        (WebCore::MediaPlayerPrivate::duration):
            Return m_cachedDuration once it has been set.
        (WebCore::MediaPlayerPrivate::updateStates):
            Rename m_duration to m_reportedDuration.
        (WebCore::MediaPlayerPrivate::didEnd):
            Set m_cachedDuration to currentTime().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBug 26900: AX: Manual spell check with Command-; does not bring up suggestions
cfleizach@apple.com [Wed, 1 Jul 2009 22:01:16 +0000 (22:01 +0000)]
Bug 26900: AX: Manual spell check with Command-; does not bring up suggestions
https://bugs.webkit.org/show_bug.cgi?id=26900

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoChange how WebKitNightlyEnabler.dylib lies about Safari's identity to LaunchServices.
mrowe@apple.com [Wed, 1 Jul 2009 21:41:04 +0000 (21:41 +0000)]
Change how WebKitNightlyEnabler.dylib lies about Safari's identity to LaunchServices.

This makes WebKit.app behave as expected when set as the default web browser on a wider
range of OS versions.

Reviewed by Simon Fraser.

* WebKitLauncher/WebKitNightlyEnabler.m:
(poseAsWebKitApp):
(enableWebKitNightlyBehaviour):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoShuffle some code around in preparation for a change to how poseAsWebKitApp works.
mrowe@apple.com [Wed, 1 Jul 2009 21:41:01 +0000 (21:41 +0000)]
Shuffle some code around in preparation for a change to how poseAsWebKitApp works.

Reviewed by Simon Fraser.

* WebKitLauncher/WebKitNightlyEnabler.m:
(systemVersion):
(webKitLauncherBundle):
(insideSafari4OnTigerTrampoline):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-01 David Levin <levin@chromium.org>
levin@chromium.org [Wed, 1 Jul 2009 21:06:36 +0000 (21:06 +0000)]
2009-07-01  David Levin  <levin@chromium.org>

        Reviewed by Eric Seidel.

        Remove unused code in SVGTransformList and SVGTransformDistance
        <https://bugs.webkit.org/show_bug.cgi?id=26891>

        * svg/SVGTransformDistance.cpp:
        (WebCore::SVGTransformDistance::SVGTransformDistance):
        * svg/SVGTransformList.cpp:
        * svg/SVGTransformList.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-01 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Wed, 1 Jul 2009 20:59:39 +0000 (20:59 +0000)]
2009-07-01  David Hyatt  <hyatt@apple.com>

        Reviewed by Anders Carlsson.

        Begin stubbing out functions for layout, painting and style/geometry caching on columns.  Not enough
        is implemented for this to do much of anything yet, but it should help keep patch sizes down. :)

        * html/DataGridColumn.cpp:
        (WebCore::DataGridColumn::columnChanged):
        * html/DataGridColumn.h:
        (WebCore::DataGridColumn::setId):
        (WebCore::DataGridColumn::setLabel):
        (WebCore::DataGridColumn::setType):
        (WebCore::DataGridColumn::setSortable):
        (WebCore::DataGridColumn::setSortDirection):
        (WebCore::DataGridColumn::setColumnList):
        (WebCore::DataGridColumn::style):
        (WebCore::DataGridColumn::setStyle):
        (WebCore::DataGridColumn::rect):
        (WebCore::DataGridColumn::setRect):
        * html/DataGridColumnList.cpp:
        (WebCore::DataGridColumnList::DataGridColumnList):
        (WebCore::DataGridColumnList::setDataGridNeedsLayout):
        (WebCore::DataGridColumnList::add):
        (WebCore::DataGridColumnList::remove):
        (WebCore::DataGridColumnList::move):
        (WebCore::DataGridColumnList::clear):
        (WebCore::DataGridColumnList::primaryColumnChanged):
        * html/DataGridColumnList.h:
        (WebCore::DataGridColumnList::create):
        (WebCore::DataGridColumnList::dataGrid):
        (WebCore::DataGridColumnList::clearDataGrid):
        * html/HTMLDataGridColElement.cpp:
        (WebCore::HTMLDataGridColElement::HTMLDataGridColElement):
        (WebCore::HTMLDataGridColElement::findDataGridAncestor):
        (WebCore::HTMLDataGridColElement::insertedIntoTree):
        (WebCore::HTMLDataGridColElement::removedFromTree):
        * html/HTMLDataGridColElement.h:
        (WebCore::HTMLDataGridColElement::dataGrid):
        * html/HTMLDataGridElement.cpp:
        (WebCore::HTMLDataGridElement::HTMLDataGridElement):
        (WebCore::HTMLDataGridElement::~HTMLDataGridElement):
        * rendering/RenderDataGrid.cpp:
        (WebCore::RenderDataGrid::styleDidChange):
        (WebCore::RenderDataGrid::recalcStyleForColumns):
        (WebCore::RenderDataGrid::recalcStyleForColumn):
        (WebCore::RenderDataGrid::styleForColumn):
        (WebCore::RenderDataGrid::layout):
        (WebCore::RenderDataGrid::layoutColumns):
        (WebCore::RenderDataGrid::paintColumnHeaders):
        (WebCore::RenderDataGrid::paintColumnHeader):
        * rendering/RenderDataGrid.h:
        (WebCore::RenderDataGrid::renderName):
        (WebCore::RenderDataGrid::canHaveChildren):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-01 Daniel Bates <dbates@intudata.com>
abarth@webkit.org [Wed, 1 Jul 2009 20:38:51 +0000 (20:38 +0000)]
2009-07-01  Daniel Bates  <dbates@intudata.com>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=26807

        Fixes this address by checking whether frame->document()->decoder() is null.

        * page/XSSAuditor.cpp:
        (WebCore::XSSAuditor::findInRequest):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-01 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
zimmermann@webkit.org [Wed, 1 Jul 2009 19:01:48 +0000 (19:01 +0000)]
2009-07-01  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>

        Reviewed by George Staikos.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=26885
        Correctly reset history length to '0', not '1'. Old relict from early WML days.
        Add some new WML testcases covering the use of history length (by onenterforward event handling)

        Tests: wml/onenterforward-event.html
               wml/onenterforward-inline-event.html
               wml/ontimer-event.html

        * wml/WMLPageState.cpp:
        (WebCore::WMLPageState::reset):

2009-07-01  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>

        Reviewed by George Staikos.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=26885
        Add new WML testcases covering onenterforward/ontimer support.

        * wml/onenterforward-event-expected.txt: Added.
        * wml/onenterforward-event.html: Added.
        * wml/onenterforward-inline-event-expected.txt: Added.
        * wml/onenterforward-inline-event.html: Added.
        * wml/ontimer-event-expected.txt: Added.
        * wml/ontimer-event.html: Added.
        * wml/resources/onenterforward-event.js: Added.
        (setupTestDocument):
        (prepareTest):
        (executeTest):
        * wml/resources/onenterforward-event.wml: Added.
        * wml/resources/onenterforward-inline-event.js: Added.
        (setupTestDocument):
        (prepareTest):
        (executeTest):
        * wml/resources/onenterforward-inline-event.wml: Added.
        * wml/resources/ontimer-event.js: Added.
        (setupTestDocument):
        (prepareTest):
        (executeTest):
        * wml/resources/ontimer-event.wml: Added.
        * wml/resources/ontimer-inline-event.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
hyatt@apple.com [Wed, 1 Jul 2009 18:41:25 +0000 (18:41 +0000)]
WebCore:

2009-07-01  David Hyatt  <hyatt@apple.com>

        Reviewed by Simon Fraser.

        Make sure setting attributes on dcol elements properly updates the corresponding DataGridColumn object.

        Added new test in fast/dom/HTMLDataGridElement.

        * html/HTMLDataGridColElement.cpp:
        (WebCore::HTMLDataGridColElement::parseMappedAttribute):
        * html/HTMLDataGridColElement.h:

LayoutTests:

2009-07-01  David Hyatt  <hyatt@apple.com>

        Reviewed by Simon Fraser.

        Add layout test for being able to set attributes on dcol elements.

        * fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes-expected.txt: Added.
        * fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-07-01 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 1 Jul 2009 18:19:01 +0000 (18:19 +0000)]
2009-07-01  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dimitri Glazkov.

        Add some missing pixel results for compositing tests.

        * platform/mac/compositing/layers-inside-overflow-scroll-expected.checksum: Added.
        * platform/mac/compositing/layers-inside-overflow-scroll-expected.png: Added.
        * platform/mac/compositing/overflow/overflow-scroll-expected.checksum: Added.
        * platform/mac/compositing/overflow/overflow-scroll-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45442 268f45cc-cd09-0410-ab3c-d52691b4dbfc