WebKit.git
14 years ago2008-09-15 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Mon, 15 Sep 2008 10:20:59 +0000 (10:20 +0000)]
2008-09-15  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Cameron Zwarich.

        - fix layout test failure introduced by fix for 20849

        (The failing test was fast/js/delete-then-put.html)

        * kjs/JSObject.cpp:
        (JSC::JSObject::removeDirect): Clear enumeration cache
        in the dictionary case.
        * kjs/JSObject.h:
        (JSC::JSObject::putDirect): Ditto.
        * kjs/StructureID.h:
        (JSC::StructureID::clearEnumerationCache): Inline to handle the
        clear.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-09-15 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Mon, 15 Sep 2008 10:02:56 +0000 (10:02 +0000)]
2008-09-15  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Cameron Zwarich.

        - fix JSC test failures introduced by fix for 20849

        * kjs/PropertyMap.cpp:
        (JSC::PropertyMap::getEnumerablePropertyNames): Use the correct count.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-09-15 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Mon, 15 Sep 2008 09:39:26 +0000 (09:39 +0000)]
2008-09-15  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Maciej Stachowiak.

        Bug 20851: REGRESSION (r36410): fast/js/kde/GlobalObject.html fails
        <https://bugs.webkit.org/show_bug.cgi?id=20851>

        r36410 introduced an optimization for parseInt() that is incorrect when
        its argument is larger than the range of a 32-bit integer. If the
        argument is a number that is not an immediate integer, then the correct
        behaviour is to return the floor of its value, unless it is an infinite
        value, in which case the correct behaviour is to return 0.

        JavaScriptCore:

        * kjs/JSGlobalObjectFunctions.cpp:
        (JSC::globalFuncParseInt):

        LayoutTests:

        * fast/js/numeric-conversion-expected.txt:
        * fast/js/resources/numeric-conversion.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix Qt build bustage.
hyatt@apple.com [Mon, 15 Sep 2008 09:13:11 +0000 (09:13 +0000)]
Fix Qt build bustage.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-09-15 David Smith <catfish.man@gmail.com>
dsmith@webkit.org [Mon, 15 Sep 2008 08:45:35 +0000 (08:45 +0000)]
2008-09-15  David Smith  <catfish.man@gmail.com>

        Reviewed by Dave Hyatt.

        https://bugs.webkit.org/show_bug.cgi?id=20180

        >2x speedup on querySelector[All] with :nth-child by removing the collectRulesOnly argument on SelectorChecker.
        With collectRulesOnly set to true (the default) an optimization is turned off, and no callers were intentionally leaving it true.
        querySelector[All] assumed that the default was probably the right way to go, and so ended up being slow.

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::CSSStyleSelector):
        (WebCore::CSSStyleSelector::SelectorChecker::SelectorChecker):
        * css/CSSStyleSelector.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMake sure ScrollbarThemeQt.cpp accurately reflects copyright information, since it...
hyatt@apple.com [Mon, 15 Sep 2008 08:34:07 +0000 (08:34 +0000)]
Make sure ScrollbarThemeQt.cpp accurately reflects copyright information, since it contains code from PlatformScrollbarQt.cpp

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix Qt build bustage.
hyatt@apple.com [Mon, 15 Sep 2008 08:31:24 +0000 (08:31 +0000)]
Fix Qt build bustage.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-09-15 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 15 Sep 2008 07:27:14 +0000 (07:27 +0000)]
2008-09-15  Sam Weinig  <sam@webkit.org>

        Reviewed by Maciej Stachowiak.

        Patch for https://bugs.webkit.org/show_bug.cgi?id=20849
        Cache property names for getEnumerablePropertyNames in the StructureID.

        ~0.5% speedup on Sunspider overall (9.7% speedup on string-fasta).  ~1% speedup
        on the v8 test suite.

        * kjs/JSObject.cpp:
        (JSC::JSObject::getPropertyNames):
        * kjs/PropertyMap.cpp:
        (JSC::PropertyMap::getEnumerablePropertyNames):
        * kjs/PropertyMap.h:
        * kjs/StructureID.cpp:
        (JSC::StructureID::StructureID):
        (JSC::StructureID::getEnumerablePropertyNames):
        * kjs/StructureID.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRefactor painting of the native windows scrollbar and prepare for code sharing with...
hyatt@apple.com [Mon, 15 Sep 2008 06:33:40 +0000 (06:33 +0000)]
Refactor painting of the native windows scrollbar and prepare for code sharing with the Aqua windows scrollbar.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-09-14 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Mon, 15 Sep 2008 06:26:15 +0000 (06:26 +0000)]
2008-09-14  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Cameron Zwarich.

        - speed up JS construction by extracting "prototype" lookup so PIC applies.

        ~0.5% speedup on SunSpider
        Speeds up some of the V8 tests as well, most notably earley-boyer.

        * VM/CTI.cpp:
        (JSC::CTI::compileOpCall): Account for extra arg for prototype.
        (JSC::CTI::privateCompileMainPass): Account for increased size of op_construct.
        * VM/CodeGenerator.cpp:
        (JSC::CodeGenerator::emitConstruct): Emit separate lookup to get prototype property.
        * VM/Machine.cpp:
        (JSC::Machine::privateExecute): Expect prototype arg in op_construct.
        (JSC::Machine::cti_op_construct_JSConstruct): ditto
        (JSC::Machine::cti_op_construct_NotJSConstruct): ditto

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Moving all resource graphs under the same container for future scalable feature.
timothy@apple.com [Mon, 15 Sep 2008 05:38:00 +0000 (05:38 +0000)]
    Moving all resource graphs under the same container for future scalable feature.
        This is a speedup on resize but maybe a loss on changing the sorting function.

        https://bugs.webkit.org/show_bug.cgi?id=20555

        Reviewed by Timothy Hatcher.

        * page/inspector/ResourcesPanel.js: Added a container for all resource graphs.
        Added WebInspector.ResourceGraph. No more _updateGraphBars on resize.
        * page/inspector/inspector.css: Edited corresponding rules and removed unnecessaries.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric Seidel.
ap@webkit.org [Mon, 15 Sep 2008 05:05:17 +0000 (05:05 +0000)]
    Reviewed by Eric Seidel.

        Add a protected destructor for RefCounted.

        It is wrong to call its destructor directly, because (1) this should be taken care of by
        deref(), and (2) many classes that use RefCounted have non-virtual destructors.

        No change in behavior.

        * wtf/RefCounted.h: (WTF::RefCounted::~RefCounted):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix Qt bustage.
hyatt@apple.com [Mon, 15 Sep 2008 05:00:29 +0000 (05:00 +0000)]
Fix Qt bustage.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej Stachowiak.
ap@webkit.org [Mon, 15 Sep 2008 04:52:44 +0000 (04:52 +0000)]
    Reviewed by Maciej Stachowiak.

        https://bugs.webkit.org/show_bug.cgi?id=20738
        compareBoundaryPoints gives incorrect results

        Test: fast/dom/Range/compareBoundaryPoints-2.html

        * dom/Range.cpp: (WebCore::Range::compareBoundaryPoints): Correct meanings of START_TO_END
        and END_TO_START.
        * page/DOMSelection.cpp: (WebCore::DOMSelection::addRange): Updated for this change.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-09-14 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Mon, 15 Sep 2008 03:10:35 +0000 (03:10 +0000)]
2008-09-14  Maciej Stachowiak  <mjs@apple.com>

        Unreviewed build fix.

        Trying again.

        * bindings/js/JSQuarantinedObjectWrapper.cpp:
        (WebCore::JSQuarantinedObjectWrapper::hasInstance):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-09-14 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Mon, 15 Sep 2008 02:55:16 +0000 (02:55 +0000)]
2008-09-14  Maciej Stachowiak  <mjs@apple.com>

        Unreviewed build fix.

        Blind attempt to fix build. Correct parameters for hasInstance.

        * bindings/js/JSQuarantinedObjectWrapper.cpp:
        (WebCore::JSQuarantinedObjectWrapper::hasInstance):
        * bindings/js/JSQuarantinedObjectWrapper.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz@apple.com [Mon, 15 Sep 2008 02:23:24 +0000 (02:23 +0000)]
WebCore:

        Rubber-stamped by Sam Weinig.

        - revert <http://trac.webkit.org/changeset/36382> because it exposed
          <https://bugs.webkit.org/show_bug.cgi?id=20846> and resulted in crashes
          on Tiger.

        * platform/graphics/mac/FontCacheMac.mm:
        (WebCore::FontCache::getFontDataForCharacters):
        (WebCore::FontCache::getLastResortFallbackFont):

LayoutTests:

        Rubber-stamped by Sam Weinig.

        - revert <http://trac.webkit.org/changeset/36382> because it exposed
          <https://bugs.webkit.org/show_bug.cgi?id=20846> and resulted in crashes
          on Tiger.

        * platform/mac/fast/text/last-resort-font-expected.checksum: Removed.
        * platform/mac/fast/text/last-resort-font-expected.png: Removed.
        * platform/mac/fast/text/last-resort-font-expected.txt: Removed.
        * platform/mac/fast/text/last-resort-font.html: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoNow with all new and improved Changelog in the correct order.
barraclough@apple.com [Mon, 15 Sep 2008 02:21:42 +0000 (02:21 +0000)]
Now with all new and improved Changelog in the correct order.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-09-14 Maciej Stachowiak <mjs@apple.com>
barraclough@apple.com [Mon, 15 Sep 2008 02:18:13 +0000 (02:18 +0000)]
2008-09-14  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Cameron Zwarich.

        - split the "prototype" lookup for hasInstance into opcode stream so it can be cached

        ~5% speedup on v8 earley-boyer test

        * API/JSCallbackObject.h: Add a parameter for the pre-looked-up prototype.
        * API/JSCallbackObjectFunctions.h:
        (JSC::::hasInstance): Ditto.
        * API/JSValueRef.cpp:
        (JSValueIsInstanceOfConstructor): Look up and pass in prototype.
        * JavaScriptCore.exp:
        * VM/CTI.cpp:
        (JSC::CTI::privateCompileMainPass): Pass along prototype.
        * VM/CodeBlock.cpp:
        (JSC::CodeBlock::dump): Print third arg.
        * VM/CodeGenerator.cpp:
        (JSC::CodeGenerator::emitInstanceOf): Implement this, now that there
        is a third argument.
        * VM/CodeGenerator.h:
        * VM/Machine.cpp:
        (JSC::Machine::privateExecute): Pass along the prototype.
        (JSC::Machine::cti_op_instanceof): ditto
        * kjs/JSObject.cpp:
        (JSC::JSObject::hasInstance): Expect to get a pre-looked-up prototype.
        * kjs/JSObject.h:
        * kjs/nodes.cpp:
        (JSC::InstanceOfNode::emitCode): Emit a get_by_id of the prototype
        property and pass that register to instanceof.
        * kjs/nodes.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-09-14 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Mon, 15 Sep 2008 02:13:10 +0000 (02:13 +0000)]
2008-09-14  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Cameron Zwarich.

        - split the "prototype" lookup for hasInstance into opcode stream so it can be cached

        ~5% speedup on v8 earley-boyer test

        * API/JSCallbackObject.h: Add a parameter for the pre-looked-up prototype.
        * API/JSCallbackObjectFunctions.h:
        (JSC::::hasInstance): Ditto.
        * API/JSValueRef.cpp:
        (JSValueIsInstanceOfConstructor): Look up and pass in prototype.
        * JavaScriptCore.exp:
        * VM/CTI.cpp:
        (JSC::CTI::privateCompileMainPass): Pass along prototype.
        * VM/CodeBlock.cpp:
        (JSC::CodeBlock::dump): Print third arg.
        * VM/CodeGenerator.cpp:
        (JSC::CodeGenerator::emitInstanceOf): Implement this, now that there
        is a third argument.
        * VM/CodeGenerator.h:
        * VM/Machine.cpp:
        (JSC::Machine::privateExecute): Pass along the prototype.
        (JSC::Machine::cti_op_instanceof): ditto
        * kjs/JSObject.cpp:
        (JSC::JSObject::hasInstance): Expect to get a pre-looked-up prototype.
        * kjs/JSObject.h:
        * kjs/nodes.cpp:
        (JSC::InstanceOfNode::emitCode): Emit a get_by_id of the prototype
        property and pass that register to instanceof.
        * kjs/nodes.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdd ScrollbarThemeComposite for use by ScrollbarThemeSafari and ScrollbarThemeWin
hyatt@apple.com [Mon, 15 Sep 2008 00:56:11 +0000 (00:56 +0000)]
Add ScrollbarThemeComposite for use by ScrollbarThemeSafari and ScrollbarThemeWin

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix Qt build bustage.
hyatt@apple.com [Mon, 15 Sep 2008 00:53:12 +0000 (00:53 +0000)]
Fix Qt build bustage.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix Win build bustage.
hyatt@apple.com [Mon, 15 Sep 2008 00:36:07 +0000 (00:36 +0000)]
Fix Win build bustage.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-09-14 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Mon, 15 Sep 2008 00:35:40 +0000 (00:35 +0000)]
2008-09-14  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Sam Weinig.

        Remove unnecessary virtual function call from cti_op_call_JSFunction -
        ~5% on richards, ~2.5% on v8-tests, ~0.5% on sunspider.

        * VM/Machine.cpp:
        (JSC::Machine::cti_op_call_JSFunction):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-09-14 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Mon, 15 Sep 2008 00:26:08 +0000 (00:26 +0000)]
2008-09-14  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Maciej Stachowiak.

        Bug 20827: the 'typeof' operator is slow
        <https://bugs.webkit.org/show_bug.cgi?id=20827>

        Optimize the 'typeof' operator when its result is compared to a constant
        string.

        This is a 5.5% speedup on the V8 Earley-Boyer test.

        JavaScriptCore:

        * VM/CTI.cpp:
        (JSC::CTI::privateCompileMainPass):
        * VM/CodeBlock.cpp:
        (JSC::CodeBlock::dump):
        * VM/CodeGenerator.cpp:
        (JSC::CodeGenerator::emitEqualityOp):
        * VM/CodeGenerator.h:
        * VM/Machine.cpp:
        (JSC::jsIsObjectType):
        (JSC::jsIsFunctionType):
        (JSC::Machine::privateExecute):
        (JSC::Machine::cti_op_is_undefined):
        (JSC::Machine::cti_op_is_boolean):
        (JSC::Machine::cti_op_is_number):
        (JSC::Machine::cti_op_is_string):
        (JSC::Machine::cti_op_is_object):
        (JSC::Machine::cti_op_is_function):
        * VM/Machine.h:
        * VM/Opcode.h:
        * kjs/nodes.cpp:
        (JSC::BinaryOpNode::emitCode):
        (JSC::EqualNode::emitCode):
        (JSC::StrictEqualNode::emitCode):
        * kjs/nodes.h:

        LayoutTests:

        * fast/js/resources/typeof-codegen-crash.js: Added.
        * fast/js/typeof-codegen-crash-expected.txt: Added.
        * fast/js/typeof-codegen-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-09-14 Alp Toker <alp@nuanti.com>
alp@webkit.org [Mon, 15 Sep 2008 00:20:15 +0000 (00:20 +0000)]
2008-09-14  Alp Toker  <alp@nuanti.com>

        https://bugs.webkit.org/show_bug.cgi?id=20320
        [GTK] A white rectangle is visible behind widgets with rounded corners

        Sync bundled gtk2drawing.c to the latest version from Mozilla (coding
        style exempt).

        Requested by Michael Monreal.

        * platform/gtk/RenderThemeGtk.cpp:
        (WebCore::RenderThemeGtk::RenderThemeGtk):
        * platform/gtk/gtk2drawing.c:
        (moz_gtk_set_widget_name):
        (ensure_window_widget):
        (setup_widget_prototype):
        (ensure_button_arrow_widget):
        (moz_gtk_get_combo_box_inner_button):
        (moz_gtk_get_combo_box_button_inner_widgets):
        (ensure_combo_box_widgets):
        (moz_gtk_get_combo_box_entry_inner_widgets):
        (moz_gtk_get_combo_box_entry_arrow):
        (ensure_combo_box_entry_widgets):
        (ensure_toolbar_widget):
        (ensure_tooltip_widget):
        (ensure_menu_bar_widget):
        (ensure_menu_bar_item_widget):
        (ensure_menu_popup_widget):
        (ensure_menu_item_widget):
        (ensure_image_menu_item_widget):
        (ensure_menu_separator_widget):
        (ensure_check_menu_item_widget):
        (ensure_tree_header_cell_widget):
        (ensure_scrolled_window_widget):
        (moz_gtk_button_paint):
        (moz_gtk_init):
        (moz_gtk_button_get_inner_border):
        (moz_gtk_toggle_paint):
        (calculate_button_inner_rect):
        (calculate_arrow_rect):
        (moz_gtk_scrollbar_button_paint):
        (moz_gtk_scrollbar_thumb_paint):
        (moz_gtk_caret_paint):
        (moz_gtk_entry_paint):
        (moz_gtk_treeview_paint):
        (moz_gtk_tree_header_cell_paint):
        (moz_gtk_combo_box_paint):
        (moz_gtk_downarrow_paint):
        (moz_gtk_combo_box_entry_button_paint):
        (moz_gtk_toolbar_paint):
        (moz_gtk_tab_scroll_arrow_paint):
        (moz_gtk_menu_bar_paint):
        (moz_gtk_menu_item_paint):
        (moz_gtk_get_widget_border):
        (moz_gtk_get_combo_box_entry_button_size):
        (moz_gtk_get_tab_scroll_arrow_size):
        (moz_gtk_get_downarrow_size):
        (moz_gtk_images_in_menus):
        (moz_gtk_widget_paint):
        (moz_gtk_shutdown):
        * platform/gtk/gtkdrawing.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-09-14 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 15 Sep 2008 00:12:00 +0000 (00:12 +0000)]
2008-09-14  Sam Weinig  <sam@webkit.org>

        Reviewed by Cameron Zwarich.

        Patch for https://bugs.webkit.org/show_bug.cgi?id=20844
        Speed up parseInt for numbers

        Sunspider reports this as 1.029x as fast overall and 1.37x as fast on string-unpack-code.
        No change on the v8 suite.

        * kjs/JSGlobalObjectFunctions.cpp:
        (JSC::globalFuncParseInt): Don't convert numbers to strings just to
        convert them back to numbers.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-09-14 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sun, 14 Sep 2008 23:55:16 +0000 (23:55 +0000)]
2008-09-14  David Hyatt  <hyatt@apple.com>

        Convert Mac, Gtk, wx and Qt over to the new ScrollbarTheme for
        painting.  Mac and Gtk themes don't do anything and just let the
        underlying widget paint.  Qt now uses the theme to paint.  wx doesn't
        do anything yet.

        Reviewed by Sam Weinig

        * platform/ScrollBar.cpp:
        (WebCore::Scrollbar::paint):
        * platform/ScrollBar.h:
        (WebCore::Scrollbar::value):
        (WebCore::Scrollbar::visibleSize):
        (WebCore::Scrollbar::maximum):
        (WebCore::Scrollbar::lineStep):
        (WebCore::Scrollbar::pageStep):
        (WebCore::Scrollbar::pixelStep):
        (WebCore::Scrollbar::pressedPart):
        (WebCore::Scrollbar::hoveredPart):
        (WebCore::Scrollbar::theme):
        * platform/ScrollbarTheme.h:
        (WebCore::ScrollbarTheme::paint):
        (WebCore::ScrollbarTheme::scrollbarThickness):
        (WebCore::ScrollbarTheme::supportsControlTints):
        (WebCore::ScrollbarTheme::themeChanged):
        * platform/gtk/PlatformScrollBar.h:
        * platform/gtk/PlatformScrollBarGtk.cpp:
        * platform/mac/PlatformScrollBar.h:
        * platform/mac/PlatformScrollBarMac.mm:
        * platform/qt/PlatformScrollBar.h:
        * platform/qt/PlatformScrollBarQt.cpp:
        * platform/qt/ScrollbarThemeQt.cpp:
        (WebCore::styleOptionSlider):
        * platform/qt/ScrollbarThemeQt.h:
        (WebCore::ScrollbarThemeQt::paint):
        * platform/win/PlatformScrollBarSafari.cpp:
        (WebCore::PlatformScrollbar::paint):
        * platform/win/ScrollbarThemeSafari.h:
        (WebCore::ScrollbarThemeSafari::supportsControlTints):
        * platform/wx/PlatformScrollBar.h:
        * platform/wx/TemporaryLinkStubs.cpp:
        (PlatformScrollbar::~PlatformScrollbar):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-09-14 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Sun, 14 Sep 2008 23:01:03 +0000 (23:01 +0000)]
2008-09-14  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Oliver Hunt.

        Bug 20816: op_lesseq should be optimized
        <https://bugs.webkit.org/show_bug.cgi?id=20816>

        Add a loop_if_lesseq opcode that is similar to the loop_if_less opcode.

        This is a 9.4% speedup on the V8 Crypto benchmark.

        * VM/CTI.cpp:
        (JSC::CTI::privateCompileMainPass):
        (JSC::CTI::privateCompileSlowCases):
        * VM/CodeBlock.cpp:
        (JSC::CodeBlock::dump):
        * VM/CodeGenerator.cpp:
        (JSC::CodeGenerator::emitJumpIfTrue):
        * VM/Machine.cpp:
        (JSC::Machine::privateExecute):
        (JSC::Machine::cti_op_loop_if_lesseq):
        * VM/Machine.h:
        * VM/Opcode.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-09-14 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sun, 14 Sep 2008 22:15:28 +0000 (22:15 +0000)]
2008-09-14  Sam Weinig  <sam@webkit.org>

        Qt build fix.

        * platform/qt/PlatformScrollBarQt.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
weinig@apple.com [Sun, 14 Sep 2008 22:12:49 +0000 (22:12 +0000)]
JavaScriptCore:

2008-09-14  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Remove extraneous semicolons.

        * kjs/nodes.cpp:
        (JSC::PrefixResolveNode::emitCode):
        * wtf/FastMalloc.cpp:
        (WTF::TCMalloc_PageHeap::GrowHeap):

WebCore:

2008-09-14  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Remove extraneous semicolons.

        * bindings/scripts/CodeGeneratorObjC.pm:
        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::tokenizeRelAttribute):
        * html/HTMLScriptElement.cpp:
        (WebCore::HTMLScriptElement::charsetAttributeValue):
        (WebCore::HTMLScriptElement::typeAttributeValue):
        * platform/graphics/qt/GradientQt.cpp:
        (WebCore::Gradient::platformGradient):
        * platform/qt/ScrollViewQt.cpp:
        (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar):
        * platform/win/ScrollViewWin.cpp:
        (WebCore::ScrollView::updateScrollbars):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paintEllipsisBoxes):
        * svg/SVGPathSegList.cpp:
        (WebCore::SVGPathSegList::toPathData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-09-14 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sun, 14 Sep 2008 22:00:15 +0000 (22:00 +0000)]
2008-09-14  Sam Weinig  <sam@webkit.org>

        Qt build fix.

        * platform/qt/ScrollViewQt.cpp:
        (WebCore::ScrollView::updateScrollbars):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-09-14 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sun, 14 Sep 2008 21:36:11 +0000 (21:36 +0000)]
2008-09-14  Sam Weinig  <sam@webkit.org>

        Qt build fix.

        * platform/qt/PlatformScrollBarQt.cpp:
        (WebCore::PlatformScrollbar::PlatformScrollbar):
        (WebCore::PlatformScrollbar::paint):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBuild fix.
mrowe@apple.com [Sun, 14 Sep 2008 09:33:37 +0000 (09:33 +0000)]
Build fix.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-09-14 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sun, 14 Sep 2008 08:33:03 +0000 (08:33 +0000)]
2008-09-14  Sam Weinig  <sam@webkit.org>

        Reviewed by Cameron Zwarich.

        Cleanup Sampling code.

        * VM/CTI.cpp:
        (JSC::CTI::emitCall):
        (JSC::CTI::privateCompileMainPass):
        * VM/CTI.h:
        (JSC::CTI::execute):
        * VM/SamplingTool.cpp:
        (JSC::):
        (JSC::SamplingTool::run):
        (JSC::SamplingTool::dump):
        * VM/SamplingTool.h:
        (JSC::SamplingTool::callingHostFunction):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBug 20821: Cache property transitions to speed up object initialization
oliver@apple.com [Sun, 14 Sep 2008 08:18:49 +0000 (08:18 +0000)]
Bug 20821: Cache property transitions to speed up object initialization
https://bugs.webkit.org/show_bug.cgi?id=20821

Reviewed by Cameron Zwarich.

Implement a transition cache to improve the performance of new properties
being added to objects.  This is extremely beneficial in constructors and
shows up as a 34% improvement on access-binary-trees in SunSpider (0.8%
overall)

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix Qt bustage.
hyatt@apple.com [Sun, 14 Sep 2008 05:29:13 +0000 (05:29 +0000)]
Fix Qt bustage.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix Windows bustage.
hyatt@apple.com [Sun, 14 Sep 2008 05:05:31 +0000 (05:05 +0000)]
Fix Windows bustage.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix Mac build bustage.
hyatt@apple.com [Sun, 14 Sep 2008 04:53:47 +0000 (04:53 +0000)]
Fix Mac build bustage.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-09-13 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sun, 14 Sep 2008 01:57:13 +0000 (01:57 +0000)]
2008-09-13  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Gtk build fix, not reviewed.

        * platform/gtk/PlatformScrollBarGtk.cpp:
        (PlatformScrollbar::PlatformScrollbar):
        * platform/gtk/ScrollViewGtk.cpp:
        (WebCore::ScrollView::updateScrollbars):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoEliminate Scrollbar's setRect method. Clients can now just use the Widget base class...
hyatt@apple.com [Sun, 14 Sep 2008 01:26:22 +0000 (01:26 +0000)]
Eliminate Scrollbar's setRect method.  Clients can now just use the Widget base class method, setFrameGeometry instead.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRemove setEnabled from all Scrollbar subclasses that were just using their Widget...
hyatt@apple.com [Sun, 14 Sep 2008 01:06:57 +0000 (01:06 +0000)]
Remove setEnabled from all Scrollbar subclasses that were just using their Widget base class methods.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRemove width()/height() from Scrollbar and subclasses that just need to use the Widge...
hyatt@apple.com [Sun, 14 Sep 2008 00:58:29 +0000 (00:58 +0000)]
Remove width()/height() from Scrollbar and subclasses that just need to use the Widget method.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRemove now unused methods from GTK scrollbars.
hyatt@apple.com [Sun, 14 Sep 2008 00:50:24 +0000 (00:50 +0000)]
Remove now unused methods from GTK scrollbars.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRemove now unused methods from GTK scrollbars.
hyatt@apple.com [Sun, 14 Sep 2008 00:49:52 +0000 (00:49 +0000)]
Remove now unused methods from GTK scrollbars.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMove stopTimerIfNeeded out of PlatformScrollbar destructors and into Scrollbar's...
hyatt@apple.com [Sun, 14 Sep 2008 00:32:19 +0000 (00:32 +0000)]
Move stopTimerIfNeeded out of PlatformScrollbar destructors and into Scrollbar's destructor.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix Qt build bustage.
hyatt@apple.com [Sun, 14 Sep 2008 00:22:45 +0000 (00:22 +0000)]
Fix Qt build bustage.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-09-13 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sat, 13 Sep 2008 23:57:08 +0000 (23:57 +0000)]
2008-09-13  David Hyatt  <hyatt@apple.com>

        Move maximum() from Qt's PlatformScrollbar to be a cross-platform
        function on Scrollbar.  Fixes Qt build bustage.

        Reviewed by Sam Weinig

        * platform/ScrollBar.h:
        (WebCore::Scrollbar::orientation):
        (WebCore::Scrollbar::value):
        (WebCore::Scrollbar::maximum):
        * platform/qt/PlatformScrollBar.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix Qt bustage.
hyatt@apple.com [Sat, 13 Sep 2008 23:47:09 +0000 (23:47 +0000)]
Fix Qt bustage.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix wx bustage.
hyatt@apple.com [Sat, 13 Sep 2008 23:34:36 +0000 (23:34 +0000)]
Fix wx bustage.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix Qt bustage.
hyatt@apple.com [Sat, 13 Sep 2008 23:32:37 +0000 (23:32 +0000)]
Fix Qt bustage.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix Qt, Gtk, and Mac build bustage.
hyatt@apple.com [Sat, 13 Sep 2008 23:21:39 +0000 (23:21 +0000)]
Fix Qt, Gtk, and Mac build bustage.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix Qt bustage.
hyatt@apple.com [Sat, 13 Sep 2008 23:10:40 +0000 (23:10 +0000)]
Fix Qt bustage.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix Mac bustage.
hyatt@apple.com [Sat, 13 Sep 2008 23:08:35 +0000 (23:08 +0000)]
Fix Mac bustage.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz@apple.com [Sat, 13 Sep 2008 23:06:59 +0000 (23:06 +0000)]
WebCore:

        Reviewed by Sam Weinig.

        - use the LastResort font for missing glyphs instead of showing the
          primary font's missing glyph

        Test: platform/mac/fast/text/last-resort-font.html

        * platform/graphics/mac/FontCacheMac.mm:
        (WebCore::FontCache::getFontDataForCharacters): Changed to return the
        last resort font if a substitute font cannot be found.
        (WebCore::FontCache::getLastResortFallbackFont): Removed an outdated
        comment (the user's preferred standard font is included in the search
        thanks to code in FontCache::getFontData()) and changed to return the
        LastResort font.

LayoutTests:

        Reviewed by Sam Weinig.

        - test that the LastResort font is used for missing glyphs rather than
          the primary font's missing glyph

        * platform/mac/fast/text/last-resort-font-expected.checksum: Added.
        * platform/mac/fast/text/last-resort-font-expected.png: Added.
        * platform/mac/fast/text/last-resort-font-expected.txt: Added.
        * platform/mac/fast/text/last-resort-font.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdd ScrollbarTheme to control scrollbar metrics (and eventually hit testing and rende...
hyatt@apple.com [Sat, 13 Sep 2008 22:59:55 +0000 (22:59 +0000)]
Add ScrollbarTheme to control scrollbar metrics (and eventually hit testing and rendering.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdd ScrollbarTheme to control scrollbar metrics (and eventually hit testing and rende...
hyatt@apple.com [Sat, 13 Sep 2008 22:59:05 +0000 (22:59 +0000)]
Add ScrollbarTheme to control scrollbar metrics (and eventually hit testing and rendering.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-09-13 Adrien Nader <camaradetux@gmail.com>
jmalonzo@webkit.org [Sat, 13 Sep 2008 21:30:38 +0000 (21:30 +0000)]
2008-09-13  Adrien Nader  <camaradetux@gmail.com>

        Gtk build fix, not reviewed.

        * webkit/webkitwebview.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago<rdar://problem/5060439> Web elements should have an AXTopLevelUIElement
cfleizach@apple.com [Sat, 13 Sep 2008 21:05:18 +0000 (21:05 +0000)]
<rdar://problem/5060439> Web elements should have an AXTopLevelUIElement

expose AXTopLevelUIElement as an attribute

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix Qt build bustage.
hyatt@apple.com [Sat, 13 Sep 2008 20:51:53 +0000 (20:51 +0000)]
Fix Qt build bustage.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix wx build bustage.
hyatt@apple.com [Sat, 13 Sep 2008 20:37:16 +0000 (20:37 +0000)]
Fix wx build bustage.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix Qt build bustage.
hyatt@apple.com [Sat, 13 Sep 2008 20:33:44 +0000 (20:33 +0000)]
Fix Qt build bustage.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Timothy Hatcher.
mitz@apple.com [Sat, 13 Sep 2008 20:27:37 +0000 (20:27 +0000)]
    Reviewed by Timothy Hatcher.

        - fix <rdar://problem/6171280> REGRESSION (r35667): Assertion failure in WebCore::FrameView::scheduleRelayout() when releasing a page with counters from the b/f cache

        No regression test because the back/forward cache is disabled in DumpRenderTree

        * rendering/RenderContainer.cpp:
        (WebCore::RenderContainer::invalidateCounters): Bail out if the document
        is being destroyed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix Mac build bustage.
hyatt@apple.com [Sat, 13 Sep 2008 19:14:49 +0000 (19:14 +0000)]
Fix Mac build bustage.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix Qt build bustage.
hyatt@apple.com [Sat, 13 Sep 2008 18:52:44 +0000 (18:52 +0000)]
Fix Qt build bustage.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agowx build fixes for new methods recently introduced.
kevino@webkit.org [Sat, 13 Sep 2008 18:48:39 +0000 (18:48 +0000)]
wx build fixes for new methods recently introduced.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agomore scrollbar refactoring.
hyatt@apple.com [Sat, 13 Sep 2008 18:41:47 +0000 (18:41 +0000)]
more scrollbar refactoring.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMore scrollbar refactoring.
hyatt@apple.com [Sat, 13 Sep 2008 18:39:58 +0000 (18:39 +0000)]
More scrollbar refactoring.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-09-12 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Sat, 13 Sep 2008 04:57:35 +0000 (04:57 +0000)]
2008-09-12  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Maciej Stachowiak.

        Bug 20819: JSValue::isObject() is slow
        <https://bugs.webkit.org/show_bug.cgi?id=20819>

        Optimize JSCell::isObject() and JSCell::isString() by making them
        non-virtual calls that rely on the StructureID type information.

        This is a 0.7% speedup on SunSpider and a 1.0% speedup on the V8
        benchmark suite.

        * JavaScriptCore.exp:
        * kjs/JSCell.cpp:
        * kjs/JSCell.h:
        (JSC::JSCell::isObject):
        (JSC::JSCell::isString):
        * kjs/JSObject.cpp:
        * kjs/JSObject.h:
        * kjs/JSString.cpp:
        * kjs/JSString.h:
        (JSC::JSString::JSString):
        * kjs/StructureID.h:
        (JSC::StructureID::type):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix Mac build.
sfalken@apple.com [Sat, 13 Sep 2008 02:59:00 +0000 (02:59 +0000)]
    Fix Mac build.

        * css/CSSStyleSelector.cpp:
        (WebCore::getTransformOperationType):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix Windows build bustage.
hyatt@apple.com [Sat, 13 Sep 2008 01:10:42 +0000 (01:10 +0000)]
Fix Windows build bustage.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoCleaning up LayoutTests/ChangeLog.
dino@apple.com [Sat, 13 Sep 2008 00:47:45 +0000 (00:47 +0000)]
Cleaning up LayoutTests/ChangeLog.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoCleaning up WebCore/ChangeLog
dino@apple.com [Sat, 13 Sep 2008 00:45:39 +0000 (00:45 +0000)]
Cleaning up WebCore/ChangeLog

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRoll out r36360 as it broke all non-Mac builds.
mrowe@apple.com [Sat, 13 Sep 2008 00:41:15 +0000 (00:41 +0000)]
Roll out r36360 as it broke all non-Mac builds.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-09-12 Chris Marrin <cmarrin@apple.com>
dino@apple.com [Sat, 13 Sep 2008 00:33:23 +0000 (00:33 +0000)]
2008-09-12  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Dave Hyatt.

        Make transform animation behavior match spec
        https://bugs.webkit.org/show_bug.cgi?id=20770

        Tests: transitions/transform-op-list-match.html
               transitions/transform-op-list-no-match.html

        * css/CSSStyleSelector.cpp:
        * css/CSSStyleSelector.h:
        * page/animation/AnimationBase.cpp:
        * page/animation/AnimationBase.h:
        * page/animation/ImplicitAnimation.cpp:
        * page/animation/ImplicitAnimation.h:
        * page/animation/KeyframeAnimation.cpp:
        * page/animation/KeyframeAnimation.h:
        * rendering/RenderLayer.cpp:
        * rendering/style/RenderStyle.cpp:
        * rendering/style/RenderStyle.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-09-12 John Sullivan <sullivan@apple.com>
sullivan@apple.com [Fri, 12 Sep 2008 23:30:12 +0000 (23:30 +0000)]
2008-09-12  John Sullivan  <sullivan@apple.com>

        Fixed <rdar://problem/6110941> Clicking the print button in PDF content does nothing

        Reviewed by Darin Adler

        * WebView/WebPDFView.mm:
        (-[WebPDFView PDFViewPerformPrint:]):
        Implemented PDFKit delegate method that's called after a Print action in the PDF content

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago<rdar://problem/4003789> Expose lists as AXList
cfleizach@apple.com [Fri, 12 Sep 2008 23:27:22 +0000 (23:27 +0000)]
<rdar://problem/4003789> Expose lists as AXList
<rdar://problem/5707399> VO: Definition lists not announced in Safari

Exposes <ol>, <ul> and <dl> lists as AXLists through accessibility

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Properly escape contents of links added to the inspector.
timothy@apple.com [Fri, 12 Sep 2008 22:43:38 +0000 (22:43 +0000)]
    Properly escape contents of links added to the inspector.
        For now, just build the link with the DOM and get the
        outerHTML. Eventually, we probably just want to do
        this entirely with the DOM.

        Reviewed by Timothy Hatcher.

        https://bugs.webkit.org/show_bug.cgi?id=20684

        * manual-tests/inspector/escape-links.html: Added.
        * page/inspector/StylesSidebarPane.js:
        * page/inspector/inspector.js:
        * page/inspector/utilities.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-09-12 Adele Peterson <adele@apple.com>
adele@apple.com [Fri, 12 Sep 2008 22:14:13 +0000 (22:14 +0000)]
2008-09-12  Adele Peterson  <adele@apple.com>

        Reviewed by John Sullivan and Kevin McCullough.

        Fix for <rdar://problem/6216951> REGRESSION (r36000?): Crash due to infinite recursion into EventHandler::hitTestResultAtPoint() with disconnected frames

        * page/EventHandler.cpp: (WebCore::EventHandler::hitTestResultAtPoint):
        Hit testing again on the main frame will only work if we aren't already on the main frame.  If we are already on the main frame, that will
        cause infinite recursion.  This change checks that we're not already on the main frame before hit testing again.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
kmccullough@apple.com [Fri, 12 Sep 2008 22:08:56 +0000 (22:08 +0000)]
WebCore:

2008-09-12  Kevin McCullough  <kmccullough@apple.com>

        RS by Tim .

        Re-introducing the code since it was not the cause of the crash.
        See r36343.

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::canBeProgramaticallyScrolled):
        * rendering/RenderObject.h:

LayoutTests:

2008-09-12  Kevin McCullough  <kmccullough@apple.com>

        RS by Tim.

        Re-introducing the code since it was not the cause of the crash.
        See r36343.

        * fast/events/autoscroll-with-non-scrollable-parent.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-09-12 Chris Marrin <cmarrin@apple.com>
dino@apple.com [Fri, 12 Sep 2008 21:54:57 +0000 (21:54 +0000)]
2008-09-12  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Dave Hyatt.

        When changing one animation in a list, don't reset other animations
        https://bugs.webkit.org/show_bug.cgi?id=20675

        Test: animations/change-one-anim.html

        * page/animation/AnimationBase.cpp:
        (WebCore::AnimationBase::getNumProperties):
        * page/animation/AnimationBase.h:
        * page/animation/AnimationController.cpp:
        * page/animation/CompositeAnimation.cpp:
        (WebCore::CompositeAnimation::updateKeyframeAnimations):
        * page/animation/CompositeAnimation.h:
        * page/animation/ImplicitAnimation.cpp:
        * page/animation/KeyframeAnimation.cpp:
        * page/animation/KeyframeAnimation.h:
        (WebCore::KeyframeAnimation::setIndex):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix Gtk build bustage.
hyatt@apple.com [Fri, 12 Sep 2008 21:43:21 +0000 (21:43 +0000)]
Fix Gtk build bustage.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix Qtbuild bustage.
hyatt@apple.com [Fri, 12 Sep 2008 21:42:11 +0000 (21:42 +0000)]
Fix Qtbuild bustage.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-09-12 Brady Eidson <beidson@apple.com>
beidson@apple.com [Fri, 12 Sep 2008 18:40:03 +0000 (18:40 +0000)]
2008-09-12  Brady Eidson  <beidson@apple.com>

        Reviewed by Mitz Pettel

        Fix the ASSERT and failure in webarchive/archive-empty-frame-source.html

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::mainResource): Further restoration of original WebArchive behavior.
          Subresources can never be created from nil data, but there is always a MainResource, whether
          or not there's any data.  So in the case where the main resource has no data, fake it for the
          sake of creating the ArchiveResource.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMake Scrollbar derive from Widget. Remove isWidget guards on Scrollbars.
hyatt@apple.com [Fri, 12 Sep 2008 18:37:23 +0000 (18:37 +0000)]
Make Scrollbar derive from Widget.  Remove isWidget guards on Scrollbars.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Sam Weinig.
mitz@apple.com [Fri, 12 Sep 2008 18:22:07 +0000 (18:22 +0000)]
    Reviewed by Sam Weinig.

        - https://bugs.webkit.org/show_bug.cgi?id=20793 clean up page/animation

        * page/animation/AnimationController.cpp:
        * page/animation/AnimationController.h:
        * page/animation/CompositeAnimation.cpp:
        * page/animation/CompositeAnimation.h:
        * page/animation/ImplicitAnimation.cpp:
        * page/animation/ImplicitAnimation.h:
        * page/animation/KeyframeAnimation.cpp:
        * page/animation/KeyframeAnimation.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John Sullivan.
mitz@apple.com [Fri, 12 Sep 2008 17:58:28 +0000 (17:58 +0000)]
    Reviewed by John Sullivan.

        - fix a crash in -visibleRect when it is called during WebFrameView deallocation

        * WebView/WebFrameView.mm:
        (-[WebFrameView visibleRect]): Added an early return if _private is 0.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Add a renderedImage method to DOMNode to get an image
timothy@apple.com [Fri, 12 Sep 2008 04:44:40 +0000 (04:44 +0000)]
    Add a renderedImage method to DOMNode to get an image
        of the rendering for the node and it's descendants.

        <rdar://problem/5849349> Would like API to create
        an image for a DOM node

        Reviewed by Oliver Hunt.

        * bindings/objc/DOM.mm:
        (-[DOMNode renderedImage]): Call Frame::nodeImage.
        * bindings/objc/DOMPrivate.h:
        * page/Frame.h:
        * page/mac/FrameMac.mm:
        (WebCore::Frame::nodeImage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-09-11 Dean Jackson <dino@apple.com>
dino@apple.com [Fri, 12 Sep 2008 01:25:09 +0000 (01:25 +0000)]
2008-09-11  Dean Jackson  <dino@apple.com>

        Unfortunately the fix for
        https://bugs.webkit.org/show_bug.cgi?id=20680
        didn't update the relevant test

        * css3/keyframes-rule-expected.txt:
        * css3/keyframes-rule.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-09-08 Chris Marrin <cmarrin@apple.com>
dino@apple.com [Fri, 12 Sep 2008 00:36:31 +0000 (00:36 +0000)]
2008-09-08  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Dave Hyatt

        Need to support comma separated list of key times in keyframes selectors
        https://bugs.webkit.org/show_bug.cgi?id=20680

        Test: animations/keyframes-comma-separated.html

        * css/CSSGrammar.y:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::createKeyframeRule):
        * css/CSSParser.h:
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::addKeyframeStyle):
        * css/WebKitCSSKeyframeRule.cpp:
        (WebCore::WebKitCSSKeyframeRule::WebKitCSSKeyframeRule):
        (WebCore::WebKitCSSKeyframeRule::cssText):
        (WebCore::WebKitCSSKeyframeRule::parseKeyString):
        * css/WebKitCSSKeyframeRule.h:
        (WebCore::WebKitCSSKeyframeRule::keyText):
        (WebCore::WebKitCSSKeyframeRule::setKeyText):
        (WebCore::WebKitCSSKeyframeRule::getKeys):
        * css/WebKitCSSKeyframesRule.cpp:
        (WebCore::WebKitCSSKeyframesRule::append):
        (WebCore::WebKitCSSKeyframesRule::insertRule):
        (WebCore::WebKitCSSKeyframesRule::deleteRule):
        (WebCore::WebKitCSSKeyframesRule::findRule):
        (WebCore::WebKitCSSKeyframesRule::findRuleIndex):
        * css/WebKitCSSKeyframesRule.h:
        * page/animation/AnimationBase.cpp:
        (WebCore::AnimationBase::blendProperties):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
kmccullough@apple.com [Thu, 11 Sep 2008 22:57:09 +0000 (22:57 +0000)]
WebCore:

2008-09-11  Kevin McCullough  <kmccullough@apple.com>

        RS by Tim.

        Reverting because this caused a crash.

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::canBeProgramaticallyScrolled):
        (WebCore::RenderObject::hasScrollableView):
        * rendering/RenderObject.h:

LayoutTests:

2008-09-11  Kevin McCullough  <kmccullough@apple.com>

        RS = Tim.

        Reverted because this caused a crash.

        * fast/events/autoscroll-with-non-scrollable-parent.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-09-11 Stephanie Lewis <slewis@apple.com>
slewis@apple.com [Thu, 11 Sep 2008 22:32:12 +0000 (22:32 +0000)]
2008-09-11  Stephanie Lewis  <slewis@apple.com>

        Reviewed by Oliver Hunt.

        Turn off PGO Optimization on CTI.cpp -> <rdar://problem/6207709>.  Fixes
        crash on CNN and on Dromaeo.
        Fix Missing close tag in vcproj.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-09-11 Dean Jackson <dino@apple.com>
dino@apple.com [Thu, 11 Sep 2008 21:59:08 +0000 (21:59 +0000)]
2008-09-11  Dean Jackson  <dino@apple.com>

        Reviewed by Dan Bernstein.

        Fix assertion on transition property "none"
        https://bugs.webkit.org/show_bug.cgi?id=20751

        Test: transitions/transition-end-event-set-none.html

        * page/animation/CompositeAnimation.cpp:
        (WebCore::CompositeAnimation::updateTransitions):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-09-11 David Smith <catfish.man@gmail.com>
dsmith@webkit.org [Thu, 11 Sep 2008 21:54:30 +0000 (21:54 +0000)]
2008-09-11  David Smith  <catfish.man@gmail.com>

        Rubber-stamped by mitzpettel.

        Remove an accidentally added extra file.

        * WebCore: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-09-11 David Smith <catfish.man@gmail.com>
dsmith@webkit.org [Thu, 11 Sep 2008 21:41:33 +0000 (21:41 +0000)]
2008-09-11  David Smith  <catfish.man@gmail.com>

        Reviewed by Darin

        https://bugs.webkit.org/show_bug.cgi?id=20180

        This speeds up :nth-child matching as tested by querySelectorAll by around 10% by inlining the common case of Node::renderStyle(). Many thanks to mitzpettel and othermaciej for suggestions and help.

        * WebCore.xcodeproj/project.pbxproj: Add NodeRenderStyle.h
        * css/CSSStyleSelector.cpp: include NodeRenderStyle.h
        * dom/Element.cpp: include NodeRenderStyle.h
        * dom/Node.cpp: Remove the definition of renderStyle()
        (WebCore::Node::nonRendererRenderStyle):
        * dom/Node.h: Make renderStyle() nonvirtual and add nonRendererRenderStyle()
        * dom/NodeRenderStyle.h: Added.
        (WebCore::Node::renderStyle): Inline the common case of this, call nonRendererRenderStyle for the part that needed to be virtual
        * html/HTMLOptGroupElement.cpp: include NodeRenderStyle.h
        * html/HTMLOptGroupElement.h:
        (WebCore::HTMLOptGroupElement::nonRendererRenderStyle): override to return m_style
        * html/HTMLOptionElement.cpp: include NodeRenderStyle.h
        * html/HTMLOptionElement.h:
        (WebCore::HTMLOptionElement::nonRendererRenderStyle): override to return m_style
        * rendering/RenderListBox.cpp: include NodeRenderStyle.h
        * rendering/RenderMenuList.cpp: include NodeRenderStyle.h
        * svg/SVGUseElement.cpp: include NodeRenderStyle.h

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-09-11 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Thu, 11 Sep 2008 21:15:57 +0000 (21:15 +0000)]
2008-09-11  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Not reviewed.

        Correct an SVN problem with the last commit and actually add the new
        files.

        * wrec/CharacterClassConstructor.cpp: Added.
        (JSC::):
        (JSC::getCharacterClassNewline):
        (JSC::getCharacterClassDigits):
        (JSC::getCharacterClassSpaces):
        (JSC::getCharacterClassWordchar):
        (JSC::getCharacterClassNondigits):
        (JSC::getCharacterClassNonspaces):
        (JSC::getCharacterClassNonwordchar):
        (JSC::CharacterClassConstructor::addSorted):
        (JSC::CharacterClassConstructor::addSortedRange):
        (JSC::CharacterClassConstructor::put):
        (JSC::CharacterClassConstructor::flush):
        (JSC::CharacterClassConstructor::append):
        * wrec/CharacterClassConstructor.h: Added.
        (JSC::CharacterClassConstructor::CharacterClassConstructor):
        (JSC::CharacterClassConstructor::isUpsideDown):
        (JSC::CharacterClassConstructor::charClass):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-09-11 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Thu, 11 Sep 2008 21:13:01 +0000 (21:13 +0000)]
2008-09-11  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Maciej Stachowiak.

        Bug 20788: Split CharacterClassConstructor into its own file
        <https://bugs.webkit.org/show_bug.cgi?id=20788>

        Split CharacterClassConstructor into its own file and clean up some
        style issues.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * wrec/CharacterClassConstructor.cpp: Added.
        (JSC::):
        (JSC::getCharacterClassNewline):
        (JSC::getCharacterClassDigits):
        (JSC::getCharacterClassSpaces):
        (JSC::getCharacterClassWordchar):
        (JSC::getCharacterClassNondigits):
        (JSC::getCharacterClassNonspaces):
        (JSC::getCharacterClassNonwordchar):
        (JSC::CharacterClassConstructor::addSorted):
        (JSC::CharacterClassConstructor::addSortedRange):
        (JSC::CharacterClassConstructor::put):
        (JSC::CharacterClassConstructor::flush):
        (JSC::CharacterClassConstructor::append):
        * wrec/CharacterClassConstructor.h: Added.
        (JSC::CharacterClassConstructor::CharacterClassConstructor):
        (JSC::CharacterClassConstructor::isUpsideDown):
        (JSC::CharacterClassConstructor::charClass):
        * wrec/WREC.cpp:
        (JSC::WRECParser::parseCharacterClass):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John Sullivan.
mitz@apple.com [Thu, 11 Sep 2008 20:29:08 +0000 (20:29 +0000)]
    Reviewed by John Sullivan.

        - eliminate excessive repainting when a clipped iframe is moved (noticed in <rdar://problem/6204032>)

        * WebView/WebFrame.mm:
        (-[WebFrame _getVisibleRect:]): Added. If the frame is in a RenderPart
        and has layout, gets the visible rect of the RenderPart and returns
        YES. Returns NO otherwise.
        * WebView/WebFrameInternal.h:
        * WebView/WebFrameView.mm:
        (-[WebFrameView visibleRect]): Added. Overrides this NSView method to
        take clipping in the render tree into account.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
kmccullough@apple.com [Thu, 11 Sep 2008 17:39:12 +0000 (17:39 +0000)]
WebCore:

2008-09-11  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Adele and Tim.

        <rdar://problem/6100597> REGRESSION: clicking on search results in Web
        Inspector does not scroll to the line of the results (20167)
        - This was put in by Max to fix auto scrolling but is not correct for
        the whole web: rdar://problem/6213098

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::canBeProgramaticallyScrolled):
        * rendering/RenderObject.h:

LayoutTests:

2008-09-11  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Adele and Tim.

        <rdar://problem/6100597> REGRESSION: clicking on search results in Web
        Inspector does not scroll to the line of the results (20167)
        - This was put in by Max to fix some auto scroll behavior but is not
        correct for the whole web: rdar://problem/6213098

        * fast/events/autoscroll-with-non-scrollable-parent.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago<rdar://problem/6210511> AX: if a frame has a title, that should be reported as the...
cfleizach@apple.com [Thu, 11 Sep 2008 16:24:09 +0000 (16:24 +0000)]
<rdar://problem/6210511> AX: if a frame has a title, that should be reported as the AXWebArea's title

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36334 268f45cc-cd09-0410-ab3c-d52691b4dbfc