14 years ago2008-06-05 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Thu, 5 Jun 2008 17:54:59 +0000 (17:54 +0000)]
2008-06-05  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Hyatt.

        - force inlining of a template function that only has one call site per specialization
        1.3% speedup on SunSpider

        * kjs/collector.cpp:
        (KJS::Collector::heapAllocate): This template function is only
        called from allocate() and allocateNumber() (once per
        specialization) and the extra call overhead for GC allocation
        shows up, so force inlining.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz@apple.com [Thu, 5 Jun 2008 16:55:13 +0000 (16:55 +0000)]

        Reviewed by Darin Adler.

        - fix https://bugs.webkit.org/show_bug.cgi?id=19397
          REGRESSION (3.1-TOT): Box-shadow renders weird when rotating a div with border radius

        Test: fast/transforms/shadows.html

        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::setPlatformShadow): In Core Graphics, shadow
        dimensions are always in device space. Account for that, and apply the
        current context transform to shadow offset, and multiply the blur radius
        by the inverse of the operator norm of the inverse transform (which is
        the radius of the circle inscribed in the transformed unit circle).
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::paintBoxShadow): Added 1px separation between
        the edge of the filled shape and the edge of the clipped-out shape,
        because in a transformed context, due to antialiasing, the fill can
        bleed into the clip if they touch.


        Reviewed by Darin Adler.

        - pixel test for https://bugs.webkit.org/show_bug.cgi?id=19397
          REGRESSION (3.1-TOT): Box-shadow renders weird when rotating a div with border radius

        * fast/transforms/shadows.html: Added.
        * platform/mac/fast/transforms/shadows-expected.checksum: Added.
        * platform/mac/fast/transforms/shadows-expected.png: Added.
        * platform/mac/fast/transforms/shadows-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-05 Tor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Thu, 5 Jun 2008 11:45:46 +0000 (11:45 +0000)]
2008-06-05  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon

        Update layout tests on Mac based on the changes to html4.css
        in r34299. The missing backgroundClip and outlineClip in the
        new results is strange, but visually it looks the same.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-05 Tor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Thu, 5 Jun 2008 10:36:03 +0000 (10:36 +0000)]
2008-06-05  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon.

        Prevent cycles when converting from DOM objects to
        QVariant, due to cycles in the DOM tree.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-05 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Thu, 5 Jun 2008 10:30:06 +0000 (10:30 +0000)]
2008-06-05  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Alexey and Oliver.

        - remove profiler fetch hack
        I measure an 0.5% progression from this, others show a wash. It seems not needed any more.

        * VM/Machine.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-05 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Thu, 5 Jun 2008 09:19:48 +0000 (09:19 +0000)]
2008-06-05  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Maciej.

        Bug 19400: subscript operator does not protect base when necessary

        Use a temporary for the base in BracketAccessorNode if the subscript
        might possibly modify it.


        * kjs/grammar.y:
        * kjs/nodes.cpp:
        * kjs/nodes.h:


        * fast/js/codegen-temporaries-expected.txt:
        * fast/js/resources/codegen-temporaries.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-04 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 5 Jun 2008 05:36:55 +0000 (05:36 +0000)]
2008-06-04  Sam Weinig  <sam@webkit.org>

        Reviewed by Maciej Stachowiak.

        Big cleanup of formatting and whitespace.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-04 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Thu, 5 Jun 2008 04:39:09 +0000 (04:39 +0000)]
2008-06-04  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Oliver.

        Add an option to dump statistics on executed instructions.


        * VM/Machine.cpp:
        * VM/Opcode.cpp:
        * VM/Opcode.h:


        * Scripts/check-for-global-initializers:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-04 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 5 Jun 2008 01:03:35 +0000 (01:03 +0000)]
2008-06-04  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mitz.

        Get rid of DeprecatedPtrList from StyleSheetList.

        * css/CSSStyleSelector.cpp:
        * css/StyleSheetList.cpp:
        * css/StyleSheetList.h:
        * dom/Document.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-04 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 5 Jun 2008 00:31:18 +0000 (00:31 +0000)]
2008-06-04  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        Convert more classes over to start out with a ref count of 1.

        * css/CSSImageGeneratorValue.cpp:
        * css/CSSImageValue.cpp:
        * css/CSSMediaRule.cpp:
        * css/CSSParser.cpp:
        * css/CSSRuleList.cpp:
        * css/CSSRuleList.h:
        * css/CSSStyleSelector.cpp:
        * css/CSSStyleSelector.h:
        * css/CSSStyleSheet.cpp:
        * css/CSSStyleSheet.h:
        * css/Pair.h:
        * html/HTMLMediaElement.cpp:
        * html/TimeRanges.cpp:
        * html/TimeRanges.h:
        * rendering/style/RenderStyle.cpp:
        * rendering/style/RenderStyle.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago<rdar://problem/5983804> Editable web areas do not properly report the AXFocused...
cfleizach@apple.com [Wed, 4 Jun 2008 23:45:57 +0000 (23:45 +0000)]
<rdar://problem/5983804> Editable web areas do not properly report the AXFocused attribute

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-03 Beth Dakin <bdakin@apple.com>
bdakin@apple.com [Wed, 4 Jun 2008 22:04:32 +0000 (22:04 +0000)]
2008-06-03  Beth Dakin  <bdakin@apple.com>

        Reviewed by Adele.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=19381 WebKit
        Crashing Constantly on Gmail with accessibility turned on

        There was a missing null-check!

        * page/AccessibilityRenderObject.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-04 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 4 Jun 2008 21:12:16 +0000 (21:12 +0000)]
2008-06-04  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam.

        Convert more classes to start with a ref count of 1.

        * bindings/js/JSCustomVoidCallback.cpp:
        * bindings/js/JSCustomVoidCallback.h:
        * css/StyleSheetList.cpp:
        * css/StyleSheetList.h:
        * dom/Document.cpp:
        * dom/NodeIterator.h:
        * dom/Traversal.cpp:
        * dom/Traversal.h:
        * dom/TreeWalker.h:
        * history/CachedPage.cpp:
        * html/CanvasGradient.cpp:
        * html/CanvasGradient.h:
        * html/CanvasRenderingContext2D.cpp:
        * html/CanvasRenderingContext2D.h:
        * html/HTMLCanvasElement.cpp:
        * html/VoidCallback.h:
        * loader/FormState.cpp:
        * platform/text/RegularExpression.cpp:
        * storage/SQLResultSet.cpp:
        * storage/SQLResultSetRowList.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz@apple.com [Wed, 4 Jun 2008 20:47:24 +0000 (20:47 +0000)]

        Reviewed by Dave Hyatt.

        - fix <rdar://problem/5962118> Crash in RenderBlock::calcColumnWidth()

        Test: fast/multicol/gap-non-negative.html

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue): Changed to not allow negative
        values for column-gap, per


        Reviewed by Dave Hyatt.

        - test for <rdar://problem/5962118> Crash in RenderBlock::calcColumnWidth()

        * fast/multicol/gap-non-negative-expected.txt: Added.
        * fast/multicol/gap-non-negative.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz@apple.com [Wed, 4 Jun 2008 20:45:46 +0000 (20:45 +0000)]

        Reviewed by Dave Hyatt.

        - fix <rdar://problem/5962270> Crash in WebCore::RenderTableCell::computeAbsoluteRepaintRect()

        Test: fast/reflections/table-cell.html

        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::computeAbsoluteRepaintRect): Null-check
        (WebCore::RenderTableCell::absolutePosition): Ditto.


        Reviewed by Dave Hyatt.

        - test for <rdar://problem/5962270> Crash in WebCore::RenderTableCell::computeAbsoluteRepaintRect()

        * fast/reflections/table-cell.html: Added.
        * platform/mac/fast/reflections/table-cell-expected.checksum: Added.
        * platform/mac/fast/reflections/table-cell-expected.png: Added.
        * platform/mac/fast/reflections/table-cell-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdded index.html files to specification directories so
dino@apple.com [Wed, 4 Jun 2008 20:00:48 +0000 (20:00 +0000)]
Added index.html files to specification directories so
things are easier to find.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-04 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Wed, 4 Jun 2008 18:53:10 +0000 (18:53 +0000)]
2008-06-04  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Geoff.

        <rdar://problem/5969992> JSProfiler: Remove the recursion limit in the
        - This patch removes the use of recursion for the sort functions.

        * JavaScriptCore.exp: Change the signatures of the functions being
        * profiler/Profile.cpp:
        (KJS::Profile::sort): This generic function will accept any of the
        static sort functions and apply them to the whole tree.
        * profiler/Profile.h: All of the sorting functions now call the new
        sort() function.
        * profiler/ProfileNode.cpp:
        (KJS::ProfileNode::ProfileNode): m_head used to point to the head node
        if this was the head node.  It now points to null to make iteration easy
        (KJS::ProfileNode::willExecute): Now must check if m_head is null, this
        check used to happend in the constructor.
        (KJS::ProfileNode::stopProfiling): Again the check is slightly different
        to determine if this is the head.
        (KJS::ProfileNode::traverseNextNode): This function returns the next
        node in post order.
        (KJS::ProfileNode::sort): This generic function will sort according to
        the comparator passed in, then reset the children pointers to macth the
        new order.
        * profiler/ProfileNode.h: The sorting function were removed from the
        definition file and instead use the new generic sort() function
        (KJS::ProfileNode::totalPercent): because the head can now be empty we
        need to check here too for the head node.
        (KJS::ProfileNode::selfPercent): Ditto
        (KJS::ProfileNode::firstChild): This function is necessary for the
        iterative algorithm in Profile.cpp.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
ap@webkit.org [Wed, 4 Jun 2008 18:10:15 +0000 (18:10 +0000)]
    Reviewed by Darin.

        Fix JSClassCreate to work with old JSCore API threading model.

        No change on SunSpider.

        * API/JSClassRef.cpp: (OpaqueJSClass::OpaqueJSClass): Since JSClass is constructed without
        a context, there is no way for it to create Identifiers.
        Also, added initializeThreading(), just for good measure.

        * API/JSCallbackObjectFunctions.h: (KJS::::getPropertyNames): Make an Identifier out of the
        string here, because propertyNames.add() needs that.

        * kjs/identifier.cpp:
        * kjs/identifier.h:
        * kjs/ustring.cpp:
        Moved equal() from identifier.h to ustring.h, because it's not really about Identifiers,
        and to make it possible to use it from StrHash.
        Include StrHash.h from ustring.h to avoid having the behavior depend on headers that happen
        to be included.

        * wtf/StrHash.h: Removed.
        * kjs/ustring.h: Made RefPtr<UString::Rep> use the same default hash as UString::Rep* (it
        used to default to pointer equality). Moved the whole StrHash header into ustring.h.

        * JavaScriptCore.exp: Export equal() for WebCore use (this StrHash is used in c_class.cpp,
        jni_class.cpp, and npruntime.cpp).

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubber-stamped by Darin.
ap@webkit.org [Wed, 4 Jun 2008 16:29:49 +0000 (16:29 +0000)]
    Rubber-stamped by Darin.

        Fix spacing in collector.{h,cpp}.

        * kjs/collector.cpp:
        * kjs/collector.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-04 Tor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Wed, 4 Jun 2008 13:40:54 +0000 (13:40 +0000)]
2008-06-04  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon.

        Fix a failing assertion when calling QWebFrame::evaluateJavaScript.

        The starting line number has to be 1 instead of 0.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
antti@apple.com [Wed, 4 Jun 2008 02:57:46 +0000 (02:57 +0000)]

2008-06-03  Antti Koivisto  <antti@apple.com>

        Reviewed by Darin.

        Implement path morphing for SVG animation

        You can animate smoothly between paths that have equal number of control points of matching type.

        Test: svg/custom/animate-path-morphing.svg

        * svg/SVGAnimateElement.cpp:
        * svg/SVGAnimateElement.h:
        * svg/SVGPathSegList.cpp:
        * svg/SVGPathSegList.h:


2008-06-03  Antti Koivisto  <antti@apple.com>

        Reviewed by Darin.


        Test for path morphing.

        * platform/mac/svg/custom/animate-path-morphing-expected.txt: Added.
        * svg/custom/animate-path-morphing.svg: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-03 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 4 Jun 2008 02:09:09 +0000 (02:09 +0000)]
2008-06-03  Darin Adler  <darin@apple.com>

        - try to fix the Qt build

        * bridge/qt/qt_runtime.cpp:
        (KJS::Bindings::QtRuntimeMetaMethod::lengthGetter): Remove the originalObject argument.
        (KJS::Bindings::QtRuntimeMetaMethod::connectGetter): Ditto.
        (KJS::Bindings::QtRuntimeMetaMethod::disconnectGetter): Ditto.
        (KJS::Bindings::QtRuntimeConnectionMethod::lengthGetter): Ditto.
        (KJS::Bindings::QtConnectionObject::execute): Use callAsFunction.
        * bridge/qt/qt_runtime.h: More of the same.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-03 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Wed, 4 Jun 2008 01:03:37 +0000 (01:03 +0000)]
2008-06-03  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Maciej.

        Build fix. The cleanup in r34355 missed a method.

        * kjs/nodes.cpp:
        * kjs/nodes.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
darin@apple.com [Wed, 4 Jun 2008 00:40:47 +0000 (00:40 +0000)]

2008-06-03  Darin Adler  <darin@apple.com>

        Reviewed by Geoff.

        - https://bugs.webkit.org/show_bug.cgi?id=19269
          speed up SunSpider by eliminating the toObject call for most get/put/delete

        Makes standalone SunSpider 1.025x as fast as before.

        The getOwnPropertySlot virtual function now takes care of the toObject call
        for get. Similarly, the put function (and later deleteProperty) does the
        same for those operations. To do this, the virtual functions were moved from
        the JSObject class to the JSCell class. Also, since the caller no longer knows
        the identity of the "original object", which is used by JavaScript-function
        based getters, changed the PropertySlot class so the original object is
        already stored in the slot when getOwnPropertySlot is called, if the caller
        intends to call getValue.

        This affected the old interpreter code enough that the easiest thing for me
        was to just delete it. While I am not certain the mysterious slowdown is not
        still occurring, the net change is definitely a significant speedup.

        * JavaScriptCore.exp: Updated.

        * VM/Machine.cpp: Moved the UNLIKELY macro into AlwaysInline.h.
        (KJS::resolve): Set up the originalObject in the PropertySlot before
        calling getPropertySlot. Also removed the originalObject argument from
        (KJS::resolve_skip): Ditto.
        (KJS::resolveBaseAndProperty): Ditto.
        (KJS::resolveBaseAndFunc): Ditto.
        (KJS::Machine::privateExecute): Removed the toObject calls from the get and
        put functions where possible, instead calling directly with JSValue and letting
        the JSValue and JSCell calls handle toObject. Same for toThisObject.

        * kjs/ExecState.h: Removed OldInterpreterExecState.

        * API/JSBase.cpp: Updated includes.

        * kjs/LocalStorageEntry.h: Removed contents. Later we can remove the file too.

        * kjs/array_instance.cpp:
        (KJS::ArrayInstance::lengthGetter): Removed originalObject argumet.
        (KJS::ArrayInstance::inlineGetOwnPropertySlot): Don't pass a base value to
        setValueSlot. Also use UNLIKELY around the "getting elements past the end of
        the array" code path; less common than successfully getting an element.

        * kjs/array_object.cpp:
        (KJS::getProperty): Initialize the PropertySlot with the original object.
        Don't pass the original object to the get function.
        (KJS::arrayProtoFuncFilter): Ditto.
        (KJS::arrayProtoFuncMap): Ditto.
        (KJS::arrayProtoFuncEvery): Ditto.
        (KJS::arrayProtoFuncForEach): Ditto.
        (KJS::arrayProtoFuncSome): Ditto.

        * kjs/function_object.cpp:
        (KJS::FunctionObjectImp::construct): Removed an obsolete comment.

        * kjs/grammar.y: Eliminated support for some of the node types that were
        used to optimize executing from the syntax tree.

        * kjs/internal.cpp:
        (KJS::StringImp::toThisObject): Added. Same as toObject.
        (KJS::NumberImp::toThisObject): Ditto.
        (KJS::GetterSetterImp::getOwnPropertySlot): Added. Not reached.
        (KJS::GetterSetterImp::put): Ditto.
        (KJS::GetterSetterImp::toThisObject): Ditto.

        * kjs/internal.h: Added toThisObject to NumberImp for speed.

        * kjs/lexer.cpp:
        (KJS::Lexer::shift): Changed shift to just do a single character, to unroll
        the loop and especially to make the one character case faster.
        (KJS::Lexer::setCode): Call shift multiple times instead of passing a number.
        (KJS::Lexer::lex): Ditto.
        (KJS::Lexer::matchPunctuator): Ditto. Also removed unneeded elses after returns.
        (KJS::Lexer::scanRegExp): Ditto.
        * kjs/lexer.h: Removed the count argument from shift.

        * kjs/math_object.cpp:
        (KJS::mathProtoFuncPow): Call jsNaN instead of jsNumber(NaN).

        * kjs/nodes.cpp: Removed some of the things needed only for the pre-SquirrelFish
        execution model.
        (KJS::ForNode::emitCode): Handle cases where some expressions are missing by
        not emitting any code at all. The old way was to emit code for "true", but
        this is an unnecessary remnant of the old way of doing things.

        * kjs/nodes.h: Removed some of the things needed only for the pre-SquirrelFish
        execution model.

        * kjs/object.cpp:
        (KJS::JSObject::fillGetterPropertySlot): Changed to only pass in the getter
        function. The old code passed in a base, but it was never used when
        actually getting the property; the toThisObject call was pointless. Also
        changed to not pass a base for setUndefined.

        * kjs/object.h: Added the new JSCell operations to GetterSetterImp.
        Never called.
        (KJS::JSObject::get): Initialize the object in the PropertySlot and don't
        pass it in getValue.
        (KJS::JSObject::getOwnPropertySlotForWrite): Removed the base argument
        in calls to setValueSlot.
        (KJS::JSObject::getOwnPropertySlot): Ditto.
        (KJS::JSValue::get): Added. Here because it calls through to JSObject.
        A version of JSObject::get that also handles the other types of JSValue
        by creating the appropriate wrapper. Saves the virtual call to toObject.
        (KJS::JSValue::put): Ditto.
        (KJS::JSValue::deleteProperty): Ditto.

        * kjs/property_slot.cpp:
        (KJS::PropertySlot::undefinedGetter): Removed the originalObject argument.
        (KJS::PropertySlot::ungettableGetter): Ditto.
        (KJS::PropertySlot::functionGetter): Ditto. Use the value in the base
        as the "this" object, which will be set to the original object by the new
        PropertySlot initialization code. Also call toThisObject. The old code did
        not do this, but needed to so we can properly handle the activation object
        like the other similar code paths.

        * kjs/property_slot.h:
        (KJS::PropertySlot::PropertySlot): Added a constructor that takes a base
        object. In debug builds, set the base to 0 if you don't pass one.
        (KJS::PropertySlot::getValue): Don't take or pass the originalObject.
        (KJS::PropertySlot::setValueSlot): Don't take a base object, and clear the
        base object in debug builds.
        (KJS::PropertySlot::setGetterSlot): Ditto.
        (KJS::PropertySlot::setUndefined): Ditto.
        (KJS::PropertySlot::setUngettable): Ditto.
        (KJS::PropertySlot::slotBase): Assert that a base object is present.
        This will fire if someone actually calls the get function without having
        passed in a base object and the getter needs it.
        (KJS::PropertySlot::setBase): Added. Used by the code that implements
        toObject so it can supply the original object after the fact.
        (KJS::PropertySlot::clearBase): Added. Clears the base, but is debug-only
        code because it's an error to fetch the base if you don't have a guarantee
        it was set.

        * API/JSCallbackObject.h:
        * API/JSCallbackObjectFunctions.h:
        * kjs/JSActivation.cpp:
        * kjs/JSActivation.h:
        * kjs/JSVariableObject.h:
        * kjs/array_instance.h:
        * kjs/function.cpp:
        * kjs/function.h:
        * kjs/lookup.h:
        * kjs/string_object.cpp:
        * kjs/string_object.h:
        Removed originalObject arguments from getters. Don't pass base values to
        the various PropertySlot functions that no longer take them.

        * kjs/value.cpp:
        (KJS::JSCell::getOwnPropertySlot): Added. Calls toObject and then sets the slot.
        This function has to always return true, because the caller can't walk the prototype
        chain. Because of that, we do a getPropertySlot, not getOwnPropertySlot, which works
        for the caller. This is private, only called by getOwnPropertySlotInternal.
        (KJS::JSCell::put): Added. Calls toObject and then put.
        (KJS::JSCell::toThisObject): Added. Calls toObject.

        * kjs/value.h: Added get, put, and toThisObject to both JSValue
        and JSCell. These take care of the toObject operation without an additional virtual
        function call, and so make the common "already an object" case faster.

        * wtf/AlwaysInline.h: Moved the UNLIKELY macro here for now. Maybe we can find a
        better place later, or rename this header.


2008-06-03  Darin Adler  <darin@apple.com>

        - update for JavaScriptCore changes for https://bugs.webkit.org/show_bug.cgi?id=19269
          speed up SunSpider by eliminating the toObject call for most get/put/delete

        * UserObjectImp.cpp:
        (UserObjectImp::userObjectGetter): Removed originalObject argument.
        * UserObjectImp.h: Ditto.


2008-06-03  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by John.

        <rdar://problem/5763082> GMail: Hang when removing indent from nested list
        <rdar://problem/5775449> In Gmail and GoogleDocs, a hang occurs when I attempt to apply a list style to a large selection of text
        <rdar://problem/5937624> 9D32: Hang in Safari. Using 100% of processor

        * editing/InsertListCommand.cpp:
        (WebCore::InsertListCommand::modifyRange): doApply() may operate on and remove
        the last paragraph of the selection from the document if it's in the same list
        item as startOfCurrentParagraph.  Return early to avoid an infinite loop and
        because there is no more work to be done.  Added a FIXME (<rdar://problem/5983974>)
        about the incorrect endingSelection()s.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
justin.garcia@apple.com [Wed, 4 Jun 2008 00:36:28 +0000 (00:36 +0000)]

2008-06-03  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by John.

        <rdar://problem/5763082> GMail: Hang when removing indent from nested list
        <rdar://problem/5775449> In Gmail and GoogleDocs, a hang occurs when I attempt to apply a list style to a large selection of text
        <rdar://problem/5937624> 9D32: Hang in Safari. Using 100% of processor

        * editing/InsertListCommand.cpp:
        (WebCore::InsertListCommand::modifyRange): doApply() may operate on and remove
        the last paragraph of the selection from the document if it's in the same list
        item as startOfCurrentParagraph.  Return early to avoid an infinite loop and
        because there is no more work to be done.  Added a FIXME (<rdar://problem/5983974>)
        about the incorrect endingSelection()s.


2008-06-03  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by John.

        <rdar://problem/5763082> GMail: Hang when removing indent from nested list

        * editing/execCommand/5763082-expected.txt: Added.
        * editing/execCommand/5763082.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBug 12983: Web Inspector break on the debugger keyword
oliver@apple.com [Tue, 3 Jun 2008 22:48:52 +0000 (22:48 +0000)]
Bug 12983: Web Inspector break on the debugger keyword

Reviewed by Tim

Added a DebuggerStatementNode to handle codegen, and added a new
DidReachBreakPoint debug event (which will hopefully be useful
if we ever move breakpoint management into JSC proper).  Also
added didReachBreakpoint to Debugger to allow us to actually respond
to this event.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-03 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 3 Jun 2008 21:43:44 +0000 (21:43 +0000)]
2008-06-03  Darin Adler  <darin@apple.com>

        Fix build with GCC.

        * page/AccessibilityRenderObject.cpp:
        Put a default case back in the switch statement so we don't get warned about
        all the unhandled cases with GCC. Remove the unreachable code that was causing
        a warning in Visual Studio.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-03 Jonathon Jongsma <jonathon.jongsma@collabora.co.uk>
darin@apple.com [Tue, 3 Jun 2008 21:01:22 +0000 (21:01 +0000)]
2008-06-03  Jonathon Jongsma  <jonathon.jongsma@collabora.co.uk>

        Reviewed by Darin.

        * Api/qwebhistoryinterface.cpp: Remove WebCore::historyContains().  This
        function is not used anywhere internally and is only a convenience
        function that can still be accomplished using

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-03 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 3 Jun 2008 19:25:59 +0000 (19:25 +0000)]
2008-06-03  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.


        In 64-bit Web Kit, converting between float and double, can cause rounding errors which in turn causes
        newBottom to be larger than oldBottom which is illegal.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-30 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Tue, 3 Jun 2008 18:46:16 +0000 (18:46 +0000)]
2008-05-30  Steve Falkenburg  <sfalken@apple.com>

        Registry-free COM.

        WebKit no longer requires COM registration.
        Registry-free COM information is read from the application manifest.

        Only 1 set of CLSIDs are now used, since we don't need to worry about registry collisions.
        The second set remains, but only temporarily so nightlies continue to work.

        This is supported for XPSP2 and later.  Earlier systems require an installer
        to write the required registry keys.  Nightlies and developer builds require
        XPSP2, Server 2003, or later.

        Reviewed by Adam.

        * ForEachCoClass.cpp: Moved COM registration code here from WebKitDLL.cpp. This is ONLY used in the nightly case.
        (substituteGUID): Moved here from WebKitDLL.cpp.
        (registerWebKit): Moved here from WebKitDLL.cpp.
        (setUseOpenSourceWebKit): Call registerWebKit instead of swapping progids. There is only 1 set of progids now - for the nightly.
        * ForEachCoClass.h: Removed production progids.
        * Interfaces/WebKit.idl: Added prototype for shutDownWebKit.
        * WebKit.vcproj/Interfaces.vcproj: Changed path to type library to move it out of project directory.
        * WebKit.vcproj/WebKit.vcproj: Changed path to type library to move it out of project directory.
        * WebKitDLL.cpp:
        (DllUnregisterServer): Does nothing. Entry point is still present for backward compatibility.
        (DllRegisterServer): Does nothing. Entry point is still present for backward compatibility.
        (RunAsLocalServer): Does nothing. Entry point is still present for backward compatibility.
        (shutDownWebKit): Moved from ForEachCoClass.
        * WebKitDLL.h:

2008-05-30  Steve Falkenburg  <sfalken@apple.com>

        Generate an isolated COM manifest for registry free COM.

        * DumpRenderTree/win/DumpRenderTree.vcproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix build.
sfalken@apple.com [Tue, 3 Jun 2008 18:29:03 +0000 (18:29 +0000)]
Fix build.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-03 Justin Garcia <justin.garcia@apple.com>
justin.garcia@apple.com [Tue, 3 Jun 2008 17:12:37 +0000 (17:12 +0000)]
2008-06-03  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by John Sullivan.

        <rdar://problem/5943515> SelectionController()->modify Backward/Forward with LineGranularity sometimes don't work

        next/previousLinePosition didn't work if the input position was the last line in its
        block.  The code for handling such a position assumed that the input position was
        editable, and that the position to be returned needed to also be editable.  Changed
        this code to just maintain the same editability.

        No test case for now because we haven't enabled selection extension operations for
        non-editable selections.  I enabled them temporarily to test the fix, however.

        * dom/Node.cpp: Removed the now unused nextEditable(int).
        * dom/Node.h:
        * editing/visible_units.cpp:
        (WebCore::previousLeafWithSameEditability): Added.  Like previousEditable but just returns
        a node of the same editability.
        (WebCore::previousLinePosition): Call previousLeaf instead of previousEditable.
        (WebCore::nextLeafWithSameEditability): Added.
        (WebCore::nextLinePosition): Same as above.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
andersca@apple.com [Tue, 3 Jun 2008 17:07:58 +0000 (17:07 +0000)]

2008-06-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by John and Sam.

        Assertion failure in ApplicationCacheGroup::addEntry when reloading a page with a cache manifest (19182)

        * loader/appcache/ApplicationCacheGroup.h:
        Add new accessor.

        * loader/appcache/ApplicationCacheStorage.cpp:
        Don't call newestCache since it will always be null. Instead, call hasNewestCache which returns the saved newest cache pointer.


2008-06-03  Anders Carlsson  <andersca@apple.com>

        Reviewed by John and Sam.

        Assertion failure in ApplicationCacheGroup::addEntry when reloading a page with a cache manifest (19182)

        * http/tests/appcache/crash-when-navigating-away-then-back-expected.txt: Added.
        * http/tests/appcache/crash-when-navigating-away-then-back.html: Added.
        * http/tests/appcache/resources/crash-when-navigating-away-then-back.html: Added.
        * http/tests/appcache/resources/crash-when-navigating-away-then-back.manifest: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubber-stamped by Mark Rowe.
ap@webkit.org [Tue, 3 Jun 2008 15:56:01 +0000 (15:56 +0000)]
    Rubber-stamped by Mark Rowe.

        Roll out r31215 - with Mac OS X 10.5.3, there is no need to pause update daemon any more.

        * sunspider:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz@apple.com [Tue, 3 Jun 2008 15:29:14 +0000 (15:29 +0000)]

        Reviewed by Dave Hyatt.

        - fix <rdar://problem/5965410>
          In fixed table layout, the width of cells with auto width should be
          proportional to their column span, to match Firefox and IE.

        Test: fast/table/fixed-with-auto-with-colspan.html

        * rendering/FixedTableLayout.cpp:


        Reviewed by Dave Hyatt.

        - test and updated results for <rdar://problem/5965410>
          In fixed table layout, the width of cells with auto width should be
          proportional to their column span, to match Firefox and IE.

        * fast/table/fixed-with-auto-with-colspan.html: Added.
        * platform/mac/fast/table/fixed-with-auto-with-colspan-expected.checksum: Added.
        * platform/mac/fast/table/fixed-with-auto-with-colspan-expected.png: Added.
        * platform/mac/fast/table/fixed-with-auto-with-colspan-expected.txt: Added.
        * platform/mac/tables/mozilla_expected_failures/bugs/bug220653-expected.checksum:
        * platform/mac/tables/mozilla_expected_failures/bugs/bug220653-expected.png:
        * platform/mac/tables/mozilla_expected_failures/bugs/bug220653-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-03 Alp Toker <alp@nuanti.com>
alp@webkit.org [Tue, 3 Jun 2008 09:01:58 +0000 (09:01 +0000)]
2008-06-03  Alp Toker  <alp@nuanti.com>

        Rubber-stamped by Alexey.

        Remove GenerateNativeConverter added in r34331 to fix JS regressions.
        (JSTextCustom.cpp added in r34141 is now unused in any code path.)

        * dom/Text.idl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-03 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Tue, 3 Jun 2008 08:47:23 +0000 (08:47 +0000)]
2008-06-03  Maciej Stachowiak  <mjs@apple.com>

        Add a snapshot of the squirrelfish bytecode docs.

        * specs/squirrelfish-bytecode.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-03 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Tue, 3 Jun 2008 08:44:55 +0000 (08:44 +0000)]
2008-06-03  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Oliver.

        - document remaining opcodes.

        * VM/Machine.cpp:
        (KJS::Machine::privateExecute): Document call, call_eval,
        construct, ret and end opcodes.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago <rdar://problem/5621979> editing/selection/5241148.html crashes on Windows
ap@webkit.org [Tue, 3 Jun 2008 08:42:42 +0000 (08:42 +0000)]
    <rdar://problem/5621979> editing/selection/5241148.html crashes on Windows

        Try removing it from the Skipped list, as this is not reproducible with current closed
        source libraries.

        * platform/win/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-03 Alexander Vassilev <avasilev@voipgate.com>
ap@webkit.org [Tue, 3 Jun 2008 07:56:36 +0000 (07:56 +0000)]
2008-06-03  Alexander Vassilev <avasilev@voipgate.com>

        Reviewed, tweaked and landed by Alexey.

        Compiler error in Entity.h

        * dom/Entity.h:
        (WebCore::Entity::Entity): Add a private constructor to shut down the errors.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-03 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Tue, 3 Jun 2008 07:46:41 +0000 (07:46 +0000)]
2008-06-03  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Oliver.

        * VM/Machine.cpp:
        (KJS::Machine::privateExecute): Document throw and catch opcodes.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
ggaren@apple.com [Tue, 3 Jun 2008 06:26:54 +0000 (06:26 +0000)]

2008-06-02  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Alexey Proskuryakov.

        Removed JSObject::call, since it just called JSObject::callAsFunction.

        SunSpider reports no change.


2008-06-02  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Alexey Proskuryakov.

        Removed JSObject::call, since it just called JSObject::callAsFunction.

        SunSpider reports no change.


2008-06-02  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Alexey Proskuryakov.

        Removed JSObject::call, since it just called JSObject::callAsFunction.

        SunSpider reports no change.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-02 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Tue, 3 Jun 2008 03:48:18 +0000 (03:48 +0000)]
2008-06-02  Maciej Stachowiak  <mjs@apple.com>

        * config.ini: Correct URL for just-added blog.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-02 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Tue, 3 Jun 2008 03:15:11 +0000 (03:15 +0000)]
2008-06-02  Maciej Stachowiak  <mjs@apple.com>

        Rubber stamped by Mark.

        * config.ini: Add Camerom's Summer of JavaScriptCore blog.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-02 Alp Toker <alp@nuanti.com>
alp@webkit.org [Tue, 3 Jun 2008 02:17:15 +0000 (02:17 +0000)]
2008-06-02  Alp Toker  <alp@nuanti.com>

        Reviewed by Maciej.

        Two of the toJSNewlyCreated() optimisations in r34141 were never
        reached due to a generator bug and missing IDL attribute.

        Fix header generation to provide the necessary toJSNewlyCreated()

        Patch includes a related build fix by Jan Michael Alonzo.

        * GNUmakefile.am:
        * bindings/scripts/CodeGeneratorJS.pm:
        * dom/Text.idl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-02 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Tue, 3 Jun 2008 01:05:12 +0000 (01:05 +0000)]
2008-06-02  Geoffrey Garen  <ggaren@apple.com>

        Transparent background!

        * blog-files/squirrelfish.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-02 Alp Toker <alp@nuanti.com>
alp@webkit.org [Tue, 3 Jun 2008 00:30:19 +0000 (00:30 +0000)]
2008-06-02  Alp Toker  <alp@nuanti.com>

        GTK+/autotools Windows build system fixes.

        * GNUmakefile.am:
        * configure.ac:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-02 Alice Liu <alice.liu@apple.com>
alice.liu@apple.com [Mon, 2 Jun 2008 23:04:13 +0000 (23:04 +0000)]
2008-06-02  Alice Liu  <alice.liu@apple.com>

        Reviewed by Beth Dakin.

        Some ARIA roles are designated to have presentational children, which
        means that their descendants aren't exposed to assistive technologies
        on an individual basis.  What this means in webcore is that descendants
        of such roles need to be ignored in terms of accessibility.

        * page/AccessibilityObject.cpp:
        * page/AccessibilityObject.h:
        * page/AccessibilityRenderObject.cpp:
        * page/AccessibilityRenderObject.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-02 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Mon, 2 Jun 2008 22:28:15 +0000 (22:28 +0000)]
2008-06-02  Geoffrey Garen  <ggaren@apple.com>


        * blog-files/squirrelfish-webkit-graph.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-02 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Mon, 2 Jun 2008 22:07:13 +0000 (22:07 +0000)]
2008-06-02  Geoffrey Garen  <ggaren@apple.com>

        Renamed this file quiet down the peanut gallery.

        * blog-files/squirrelfish-webkit-graph.png: Copied from blog-files/webkit-graph.png.
        * blog-files/webkit-graph.png: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-02 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Mon, 2 Jun 2008 22:02:51 +0000 (22:02 +0000)]
2008-06-02  Geoffrey Garen  <ggaren@apple.com>

        Added a graph.

        * blog-files/webkit-graph.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-02 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Mon, 2 Jun 2008 21:54:23 +0000 (21:54 +0000)]
2008-06-02  David Hyatt  <hyatt@apple.com>

        Fix for https://bugs.webkit.org/show_bug.cgi?id=19303

        When the right slice value is omitted in border-image it should use the value of the left slice and not
        the top slice.

        Reviewed by darin

        Added fast/borders/border-image-omit-right-slice.html

        * css/CSSParser.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
andersca@apple.com [Mon, 2 Jun 2008 21:46:17 +0000 (21:46 +0000)]

2008-06-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by David Hyatt and Mitz.

        repro crash in WebCore::RenderPart::setWidget (plugin-related?)

        Test: platform/mac/plugins/update-widget-from-style-recalc.html

        Make sure to update the document's rendering before calling updateWidget.

        * html/HTMLEmbedElement.cpp:
        * html/HTMLObjectElement.cpp:


2008-06-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by David Hyatt and Mitz.

        repro crash in WebCore::RenderPart::setWidget (plugin-related?)

        Call -[WebView display] in the "plug-in" failed delegate method, simulating
        the sheet that Safari puts up.

        * DumpRenderTree/mac/ResourceLoadDelegate.mm:
        (-[ResourceLoadDelegate webView:plugInFailedWithError:dataSource:]):


2008-06-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by David Hyatt and Mitz.

        repro crash in WebCore::RenderPart::setWidget (plugin-related?)

        * platform/mac/plugins/update-widget-from-style-recalc-expected.txt: Added.
        * platform/mac/plugins/update-widget-from-style-recalc.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-02 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Mon, 2 Jun 2008 21:45:59 +0000 (21:45 +0000)]
2008-06-02  Geoffrey Garen  <ggaren@apple.com>

        Moved the squirrelfish mascot to the right place.

        * blog-files/squirrelfish.png: Copied from images/squirrelfish.png.
        * images/squirrelfish.png: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-02 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Mon, 2 Jun 2008 21:41:10 +0000 (21:41 +0000)]
2008-06-02  Geoffrey Garen  <ggaren@apple.com>

        Uploaded the squirrelfish mascot.

        * images/squirrelfish.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
jchaffraix@webkit.org [Mon, 2 Jun 2008 20:47:54 +0000 (20:47 +0000)]

2008-06-02  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Darin.

        Bug 18655: [XHR] OnProgress needs more test case

        * http/tests/xmlhttprequest/resources/five-tiny-chunk-one-second-delay.php: Added.
        * http/tests/xmlhttprequest/resources/noContentLength.asis: Added.
        * http/tests/xmlhttprequest/xmlhttprequest-LSProgressEvent-ProgressEvent-should-match-expected.txt: Added.
        * http/tests/xmlhttprequest/xmlhttprequest-LSProgressEvent-ProgressEvent-should-match.html: Added.
        * http/tests/xmlhttprequest/xmlhttprequest-addEventListener-onProgress-expected.txt: Added.
        * http/tests/xmlhttprequest/xmlhttprequest-addEventListener-onProgress.html: Added.
        * http/tests/xmlhttprequest/xmlhttprequest-no-content-length-onProgress-expected.txt: Added.
        * http/tests/xmlhttprequest/xmlhttprequest-no-content-length-onProgress.html: Added.
        * http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length-expected.txt: Added.
        * http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-02 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Mon, 2 Jun 2008 20:45:13 +0000 (20:45 +0000)]
2008-06-02  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Darin Adler.

        A little cleanup in the CodeGenerator.

        * VM/CodeGenerator.cpp: A few changes here.

        (1) Removed remaining cases of the old hack of putting "this" into the
        symbol table; replaced with explicit tracking of m_thisRegister.

        (2) Made m_thisRegister behave the same for function, eval, and program
        code, removing the static programCodeThis() function.

        (3) Added a feature to nix a ScopeNode's declaration stacks when done
        compiling, to save memory.

        (4) Removed code that copied eval declarations into special vectors: we
        just use the originals in the ScopeNode now.

        * VM/CodeGenerator.h: Removed unneded parameters from the CodeGenerator
        constructor: we just use get that data from the ScopeNode now.

        * VM/Machine.cpp:
        (KJS::Machine::execute): When executing an eval node, don't iterate a
        special copy of its declarations; iterate the originals, instead.

        * kjs/nodes.cpp: Moved responsibility for knowing what AST data to throw
        away into the CodeGenerator. Nodes no longer call shrinkCapacity on
        their data directly.

        * kjs/nodes.h: Changed FunctionStack to ref its contents, so declaration
        data stays around even after we've thrown away the AST, unless we explicitly
        throw away the declaration data, too. This is useful for eval code, which
        needs to reference its declaration data at execution time. (Soon, it will
        be useful for program code, too, since program code should do the same.)

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-02 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Mon, 2 Jun 2008 20:15:16 +0000 (20:15 +0000)]
2008-06-02  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Adam.

        <rdar://problem/5954226> JSProfiler: Move the calls from
        JavaScriptProfileNode to JavaScriptProfile in WebCore (19231)
        - This Makes the profiler now call sorting function s on a per-profile
        basis instead of on a node in the profile.
        - This is also needed to remove the recursion limit in the profiler
        <rdar://problem/5969992> JSProfiler: Remove the recursion limit in the
        since once the limit is removed calling sort on a node will only sort
        that node's children not the entire sub-tree of that node.

        * page/JavaScriptProfile.cpp: All of these functions were moved from
        * page/JavaScriptProfileNode.cpp:
        * page/inspector/ProfileView.js: Change uses of JavaScriptProfileNode
        for sorting to JavaScriptProfile.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz@apple.com [Mon, 2 Jun 2008 20:00:34 +0000 (20:00 +0000)]

        Reviewed by Oliver Hunt.

        - fix more cases of https://bugs.webkit.org/show_bug.cgi?id=19344
          <rdar://problem/5977300> Regression: Shadow offsets seem to have changed in 10.5.3 in canvas

        Tests: fast/canvas/shadow-offset-1.html

        * html/CanvasRenderingContext2D.cpp:
        (WebCore::adjustedShadowSize): Added this helper function.
        (WebCore::CanvasRenderingContext2D::setShadow): Changed to call
        (WebCore::CanvasRenderingContext2D::applyShadow): Ditto.


        Reviewed by Oliver Hunt.

        - additional tests for https://bugs.webkit.org/show_bug.cgi?id=19344
          <rdar://problem/5977300> Regression: Shadow offsets seem to have changed in 10.5.3 in canvas

        * fast/canvas/resources/shadow-offset.js: Added.
        * fast/canvas/shadow-offset-1.html: Copied from LayoutTests/fast/canvas/shadow-offset.html.
        * fast/canvas/shadow-offset-2.html: Added.
        * fast/canvas/shadow-offset-3.html: Added.
        * fast/canvas/shadow-offset-4.html: Added.
        * fast/canvas/shadow-offset-5.html: Added.
        * fast/canvas/shadow-offset-6.html: Added.
        * fast/canvas/shadow-offset-7.html: Added.
        * fast/canvas/shadow-offset.html: Removed.
        * platform/mac/fast/canvas/shadow-offset-1-expected.checksum: Added.
        * platform/mac/fast/canvas/shadow-offset-1-expected.png: Added.
        * platform/mac/fast/canvas/shadow-offset-1-expected.txt: Added.
        * platform/mac/fast/canvas/shadow-offset-2-expected.checksum: Added.
        * platform/mac/fast/canvas/shadow-offset-2-expected.png: Added.
        * platform/mac/fast/canvas/shadow-offset-2-expected.txt: Added.
        * platform/mac/fast/canvas/shadow-offset-3-expected.checksum: Added.
        * platform/mac/fast/canvas/shadow-offset-3-expected.png: Added.
        * platform/mac/fast/canvas/shadow-offset-3-expected.txt: Added.
        * platform/mac/fast/canvas/shadow-offset-4-expected.checksum: Added.
        * platform/mac/fast/canvas/shadow-offset-4-expected.png: Added.
        * platform/mac/fast/canvas/shadow-offset-4-expected.txt: Added.
        * platform/mac/fast/canvas/shadow-offset-5-expected.checksum: Added.
        * platform/mac/fast/canvas/shadow-offset-5-expected.png: Added.
        * platform/mac/fast/canvas/shadow-offset-5-expected.txt: Added.
        * platform/mac/fast/canvas/shadow-offset-6-expected.checksum: Added.
        * platform/mac/fast/canvas/shadow-offset-6-expected.png: Added.
        * platform/mac/fast/canvas/shadow-offset-6-expected.txt: Added.
        * platform/mac/fast/canvas/shadow-offset-7-expected.checksum: Added.
        * platform/mac/fast/canvas/shadow-offset-7-expected.png: Added.
        * platform/mac/fast/canvas/shadow-offset-7-expected.txt: Added.
        * platform/mac/fast/canvas/shadow-offset-expected.checksum: Removed.
        * platform/mac/fast/canvas/shadow-offset-expected.png: Removed.
        * platform/mac/fast/canvas/shadow-offset-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Build fix for non-AllInOne builds
aroben@apple.com [Mon, 2 Jun 2008 19:58:02 +0000 (19:58 +0000)]
    Build fix for non-AllInOne builds

        * kjs/array_object.cpp: Added a missing #include.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
jchaffraix@webkit.org [Mon, 2 Jun 2008 19:51:32 +0000 (19:51 +0000)]

2008-06-02  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Darin.

        Bug 18066: REGRESSION: createAttribute throws NAMESPACE_ERR exception

        Test: fast/dom/createAttribute-exception.html

        * dom/Document.cpp:
        * dom/Document.h: Add a bool parameter shouldIgnoreNamespaceChecks
        to createNamespaceNS() used by createAttribute() to bypass namespace


2008-06-02  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Darin.

        Bug 18066: REGRESSION: createAttribute throws NAMESPACE_ERR exception

        * fast/dom/createAttribute-exception-expected.txt: Added.
        * fast/dom/createAttribute-exception.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-02 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 2 Jun 2008 18:13:34 +0000 (18:13 +0000)]
2008-06-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mitz.

        Speculative fix for <rdar://problem/5661112>
        CrashTracer: [USER] 49 crashes in DashboardClient at com.apple.WebCore: WebCore::RenderPart::setWidget + 62

        Defer loads while calling NPP_New. Some plug-ins start a run-loop inside NPP_New and finished loads could cause
        layouts to be triggered.

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView _createPlugin]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-02 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Mon, 2 Jun 2008 17:32:19 +0000 (17:32 +0000)]
2008-06-02  Kevin McCullough  <kmccullough@apple.com>

        Took out accidental confilct lines I checked in.

        * ChangeLog:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
darin@apple.com [Mon, 2 Jun 2008 17:30:48 +0000 (17:30 +0000)]

2008-06-02  Darin Adler  <darin@apple.com>

        Reviewed by John Sullivan.

        - fix https://bugs.webkit.org/show_bug.cgi?id=18799
          apl.aip.org menu does not work (property names should be case sensitive)

        Test: fast/dom/CSSStyleDeclaration/css-properties-case-sensitive.html

        * bindings/js/JSCSSStyleDeclarationCustom.cpp:
        (WebCore::hasCSSPropertyNamePrefix): Tweak implementation a tiny bit for
        improved performance when the first character does not match.
        (WebCore::cssPropertyName): Reject property names with a leading uppercase


2008-06-02  Darin Adler  <darin@apple.com>

        Reviewed by John Sullivan.

        - test for https://bugs.webkit.org/show_bug.cgi?id=18799
          apl.aip.org menu does not work (property names should be case sensitive)

        * fast/dom/CSSStyleDeclaration: Added.

        * fast/dom/CSSStyleDeclaration/css-properties-case-sensitive-expected.txt: Added.
        * fast/dom/CSSStyleDeclaration/css-properties-case-sensitive.html: Added.
        * fast/dom/CSSStyleDeclaration/resources: Added.
        * fast/dom/CSSStyleDeclaration/resources/TEMPLATE.html: Copied from LayoutTests/fast/dom/Element/resources/TEMPLATE.html.
        * fast/dom/CSSStyleDeclaration/resources/css-properties-case-sensitive.js: Added.

        * fast/dom/CSSStyleDeclaration-empty-string-property-expected.txt: Removed.
        * fast/dom/CSSStyleDeclaration-empty-string-property.html: Removed.
        * fast/dom/CSSStyleDeclaration/empty-string-property-expected.txt: Copied from LayoutTests/fast/dom/CSSStyleDeclaration-empty-string-property-expected.txt.
        * fast/dom/CSSStyleDeclaration/empty-string-property.html: Copied from LayoutTests/fast/dom/CSSStyleDeclaration-empty-string-property.html.

        * fast/js/duplicate-param-crash.html: Allowed the make-js-test-wrappers script to update this file.
        * fast/js/duplicate-param-gc-crash.html: Ditto.
        * fast/js/resources/tostring-exception-in-property-access.js: Ditto.
        * fast/js/var-shadows-arg-crash.html: Ditto.
        * fast/js/var-shadows-arg-gc-crash.html: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
darin@apple.com [Mon, 2 Jun 2008 17:26:04 +0000 (17:26 +0000)]

2008-06-02  Darin Adler  <darin@apple.com>

        Reviewed by Mitz.

        - fix https://bugs.webkit.org/show_bug.cgi?id=19358
          <rdar://problem/5951986> first line break in <pre> elements ignored
          (chess boards at http://rankzero.de/)

        Test: fast/parser/pre-first-line-break.html

        * editing/markup.cpp:
        (WebCore::appendStartMarkup): Fix handling of <listing>. Not part of the
        bug mentioned above, but uncovered by the regression test.

        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::write): Clear the "discardLF" flag when
        processing a new tag.


2008-06-02  Darin Adler  <darin@apple.com>

        Reviewed by Mitz.

        - test for https://bugs.webkit.org/show_bug.cgi?id=19358
          <rdar://problem/5951986> first line break in <pre> elements ignored
          (chess boards at http://rankzero.de/)

        * fast/parser/pre-first-line-break-expected.txt: Added.
        * fast/parser/pre-first-line-break.html: Added.
        * fast/parser/resources/TEMPLATE.html: Copied from fast/dom/resources/TEMPLATE.html.
        * fast/parser/resources/pre-first-line-break.js: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-02 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Mon, 2 Jun 2008 17:11:35 +0000 (17:11 +0000)]
2008-06-02  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Darin.

        <rdar://problem/5969992> JSProfiler: Remove the recursion limit in the
        Implement Next Sibling pointers as groundwork for removing the recursion
        limit in the profiler.

        * profiler/ProfileNode.cpp: Also I renamed parentNode and headNode since
        'node' is redundant.
        (KJS::ProfileNode::ProfileNode): Initialize the nextSibling.
        (KJS::ProfileNode::willExecute): If there are already children then the
        new child needs to be the nextSibling of the last child.
        (KJS::ProfileNode::addChild): Ditto.
        (KJS::ProfileNode::sortTotalTimeDescending): For all of the sorting
        algorithms once the children are sorted their nextSibling pointers need
        to be reset to reflect the new order.
        (KJS::ProfileNode::resetChildrensSiblings): This new function simply
        loops over all of the children and sets their nextSibling pointers to
        the next child in the Vector
        * profiler/ProfileNode.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-02 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Mon, 2 Jun 2008 17:08:42 +0000 (17:08 +0000)]
2008-06-02  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Maciej Stachowiak.

        Removed the recursion limit from JSObject::call, since the VM does
        recursion checking now.

        This should allow us to remove JSObject::call entirely, netting a small

        * kjs/object.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fixes a bug where only the last breakpoint would be hit after reloading
timothy@apple.com [Mon, 2 Jun 2008 16:40:17 +0000 (16:40 +0000)]
    Fixes a bug where only the last breakpoint would be hit after reloading
        the page. Also fixes a bug where disabled breakpoints would be hit
        after reloading the page.

        Reviewed by Darin Adler.

        * page/inspector/BreakpointsSidebarPane.js:
        (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint): Don't call
        InspectorController.addBreakpoint() unless the breakpoint is enabled.
        * page/inspector/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.addScript): Move the addBreakpoint()
        call inside the for loop so each breakpoint is added. Also check the
        breakpoint's enabled state before calling addBreakpoint().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fixes a bug where the line highlight and the execution line were conflicting.
timothy@apple.com [Mon, 2 Jun 2008 16:40:07 +0000 (16:40 +0000)]
    Fixes a bug where the line highlight and the execution line were conflicting.
        The line highlight no longer shows up when the execution line changes, only
        when showResource or showScript is called with a line number.

        Reviewed by Darin Adler.

        * page/inspector/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.showScript): Pass true for shouldHighlightLine.
        (WebInspector.ScriptsPanel.prototype.showResource): Ditto.
        (WebInspector.ScriptsPanel.prototype._showScriptOrResource): Added a shouldHighlightLine
        argument that triggers the highlightLine() call on the SourceFrame.
        (WebInspector.ScriptsPanel.prototype._goBack): Pass false for shouldHighlightLine since
        we need to pass true for fromBackForwardAction.
        (WebInspector.ScriptsPanel.prototype._goForward): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Bring the Web Inspector forward when the debugger pauses.
timothy@apple.com [Mon, 2 Jun 2008 16:39:58 +0000 (16:39 +0000)]
    Bring the Web Inspector forward when the debugger pauses.


        Reviewed by Darin Adler.

        * page/inspector/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.debuggerPaused): Call window.focus() and
        make the Scripts panel the current panel.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-02 Jan Michael Alonzo <jmalonzo@webkit.org>
alp@webkit.org [Mon, 2 Jun 2008 16:36:32 +0000 (16:36 +0000)]
2008-06-02  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Alp Toker.

        Build WebCore GTK+ sources as part of WebCore, not WebKit.
        Split common and GTK+-specific sources into separate file lists.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-02 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Mon, 2 Jun 2008 16:36:01 +0000 (16:36 +0000)]
2008-06-02  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Adele Peterson.

        Added a specific affordance for avoiding stack overflow when converting
        recursive arrays to string, in preparation for removing generic stack
        overflow checking from JSObject::call.

        Tested by fast/js/toString-stack-overflow.html.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-02 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Mon, 2 Jun 2008 16:32:15 +0000 (16:32 +0000)]
2008-06-02  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Alice Liu.

        Refactored some hand-rolled code to call ScopeChain::globalObject instead.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
ggaren@apple.com [Mon, 2 Jun 2008 16:30:10 +0000 (16:30 +0000)]

2008-06-02  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Darin Adler.

        Fixed ASSERT due to execution continuing after an exception is thrown
        during array sort.

        * kjs/array_instance.cpp:
        (KJS::AVLTreeAbstractorForArrayCompare::compare_key_key): Don't call the
        custom comparator function if an exception has been thrown. Just return
        1 for everything, so the sort completes quickly. (The result will be
        thrown away.)


2008-06-02  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Darin Adler.

        Test for an exception thrown from an array sort comparator function.

        * fast/js/throw-from-array-sort-expected.txt: Added.
        * fast/js/throw-from-array-sort.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-02 Simon Pieters <zcorpan@hotmail.com>
ap@webkit.org [Mon, 2 Jun 2008 13:39:41 +0000 (13:39 +0000)]
2008-06-02  Simon Pieters <zcorpan@hotmail.com>

        Reviewed and landed by Alexey.

        createElement() with colon and localName

        WebKit behavior has changed to expected during Acid3 work (r31230, r31231), but this
        specific case appears to have been an untested side effect, landing it now.

        * fast/dom/createElement-with-column-expected.txt: Added.
        * fast/dom/createElement-with-column.xml: Added.
        * fast/dom/createElement-with-column.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-30 Tor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Mon, 2 Jun 2008 10:23:22 +0000 (10:23 +0000)]
2008-05-30  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon.

        Implement basic media element controls for the QtWebKit port.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-30 Tor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Mon, 2 Jun 2008 10:23:01 +0000 (10:23 +0000)]
2008-05-30  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon.

        Change default styling of media elements to allow controls
        to be placed at any position within the media element

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-30 Tor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Mon, 2 Jun 2008 10:17:06 +0000 (10:17 +0000)]
2008-05-30  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon.

        Use intrinsic size for media elements with no natural size.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-28 Tor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Mon, 2 Jun 2008 10:16:47 +0000 (10:16 +0000)]
2008-05-28  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon.

        Allow platform specific adjustments to the default style sheet.

        Clients will change the ifdef in RenderTheme.cpp and implement
        any platform specific adjustments in RenderThemeXXX.cpp, either
        by loading a file as the Qt port does, or by modifying the style

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-02 Siraj Razick <siraj.razick@collabora.co.uk>
hausmann@webkit.org [Mon, 2 Jun 2008 10:08:24 +0000 (10:08 +0000)]
2008-06-02  Siraj Razick  <siraj.razick@collabora.co.uk>

        Reviewed by Simon

        Allow button fonts to scale based on the text size multiplier.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
rwlbuis@webkit.org [Mon, 2 Jun 2008 06:44:45 +0000 (06:44 +0000)]
    Reviewed by Darin.

        getPropertyValue for border returns null, should compute the shorthand value

        Compute the value for the border shorthand property by computing
        its shorthand subproperties.

        Test: fast/css/getPropertyValue-border.html

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-01 Josh Triplett <josh@freedesktop.org>
alp@webkit.org [Mon, 2 Jun 2008 02:08:34 +0000 (02:08 +0000)]
2008-06-01  Josh Triplett  <josh@freedesktop.org>

        Reviewed by Alp Toker.

        [GTK] autotools build is slow

        Add dolt revision 5e9eef10 to the autotools build system. Speeds up
        the build, often by a factor of two or more on supported platforms,
        otherwise falls back to libtool.

        See http://dolt.freedesktop.org for details.

        * acinclude.m4: Added.
        * configure.ac:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdded Radar URLs
mitz@apple.com [Sun, 1 Jun 2008 19:48:28 +0000 (19:48 +0000)]
Added Radar URLs

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz@apple.com [Sun, 1 Jun 2008 19:46:24 +0000 (19:46 +0000)]

        Reviewed by Darin Adler.

        - fix https://bugs.webkit.org/show_bug.cgi?id=19344
          Regression: Shadow offsets seem to have changed in 10.5.3 in canvas

        Test: fast/canvas/shadow-offset.html

        * html/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::applyShadow): Slightly increase the
        magnitude of the offsets passed to CGContextSetShadow* to ensure that
        the end result after truncation is the desired integer offsets. This is
        the same workaround for <rdar://problem/5539388> that is used in
        GraphicsContext::setShadow(). Also correct a recent regression where
        shadow Y offsets were flipped.


        Reviewed by Darin Adler.

        - test for https://bugs.webkit.org/show_bug.cgi?id=19344
          Regression: Shadow offsets seem to have changed in 10.5.3 in canvas

        * fast/canvas/shadow-offset.html: Added.
        * platform/mac/fast/canvas/shadow-offset-expected.checksum: Added.
        * platform/mac/fast/canvas/shadow-offset-expected.png: Added.
        * platform/mac/fast/canvas/shadow-offset-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-01 Alp Toker <alp@nuanti.com>
alp@webkit.org [Sun, 1 Jun 2008 09:37:47 +0000 (09:37 +0000)]
2008-06-01  Alp Toker  <alp@nuanti.com>

        Suggested by Christian Dywan.

        Use float literals for zoom values and improve documentation wording.

        * webkit/webkitwebsettings.cpp:
        * webkit/webkitwebview.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-01 Alp Toker <alp@nuanti.com>
alp@webkit.org [Sun, 1 Jun 2008 09:24:55 +0000 (09:24 +0000)]
2008-06-01  Alp Toker  <alp@nuanti.com>

        Reviewed by Oliver.

        Remove webkit_web_view_go_backward(),
        webkit_web_view_can_go_backward(). These have been obsoleted by
        the back() versions for quite a while.

        * webkit/webkitwebview.cpp:
        * webkit/webkitwebview.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-31 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Sat, 31 May 2008 22:33:46 +0000 (22:33 +0000)]
2008-05-31  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Sam.

        - avoid assertion in updateDocument() when running debug

        * bindings/js/kjs_proxy.cpp:
        (WebCore::KJSProxy::updateDocument): Exit early if the document is null. We
        don't need to update in this case.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-31 Alp Toker <alp@nuanti.com>
alp@webkit.org [Sat, 31 May 2008 20:46:53 +0000 (20:46 +0000)]
2008-05-31  Alp Toker  <alp@nuanti.com>

        Fix inconsistent zoom docs and enum name landed in r34249. Issue
        noticed by Marco Barisione.

        * webkit/webkitwebview.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz@apple.com [Sat, 31 May 2008 06:28:21 +0000 (06:28 +0000)]

        Reviewed by Darin Adler.

        - fix https://bugs.webkit.org/show_bug.cgi?id=19278
          <rdar://problem/5968621> REGRESSION (r31114-r31132): image float disappears on refresh

        Test: fast/dynamic/float-in-trailing-whitespace-after-last-line-break.html

        * rendering/bidi.cpp:
        (WebCore::RenderBlock::layoutInlineChildren): Ensured that floats
        occurring in trailing whitespace after a line break are added to the
        last line's floats vector.


        Reviewed by Darin Adler.

        - test for https://bugs.webkit.org/show_bug.cgi?id=19278
          <rdar://problem/5968621> REGRESSION (r31114-r31132): image float disappears on refresh

        * fast/dynamic/float-in-trailing-whitespace-after-last-line-break.html: Added.
        * platform/mac/fast/dynamic/float-in-trailing-whitespace-after-last-line-break-expected.checksum: Added.
        * platform/mac/fast/dynamic/float-in-trailing-whitespace-after-last-line-break-expected.png: Added.
        * platform/mac/fast/dynamic/float-in-trailing-whitespace-after-last-line-break-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Implements the back and forward buttons in the Scripts panel.
timothy@apple.com [Sat, 31 May 2008 06:06:11 +0000 (06:06 +0000)]
    Implements the back and forward buttons in the Scripts panel.

        Reviewed by Adam Roben.

        * page/inspector/ScriptsPanel.js:
        (WebInspector.ScriptsPanel): Add the back and forward button elements
        and remove the FIXMEs.
        (WebInspector.ScriptsPanel.prototype.reset): Reset _backForwardList
        and _currentBackForwardIndex. Then call _updateBackAndForwardButtons().
        Added a fromBackForwardAction argument. If fromBackForwardAction is false
        then update the _currentBackForwardIndex and _backForwardList.
        Update the disabled state of the buttons.
        (WebInspector.ScriptsPanel.prototype._goBack): Update the _currentBackForwardIndex
        and call _showScriptOrResource() and _updateBackAndForwardButtons().
        (WebInspector.ScriptsPanel.prototype._goForward): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Made clicking a Console message URL originating from a JavaScript
timothy@apple.com [Sat, 31 May 2008 06:05:57 +0000 (06:05 +0000)]
    Made clicking a Console message URL originating from a JavaScript
        source show the Resource in the Scripts panel. This only happens
        when the debugger is attached.

        Reviewed by Adam Roben.

        * page/inspector/Console.js:
        Add a preferredPanel of "scripts".
        Add a preferredPanel of "scripts" when the source is JS.
        * page/inspector/ScriptView.js:
        (WebInspector.ScriptView.prototype.highlightLine): Added.
        Calls through to the sourceFrame. Matches SourceView.
        * page/inspector/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.canShowResource): Added.
        Returns true if the debugger is attached and the resource has scripts.
        (WebInspector.ScriptsPanel.prototype._showScriptOrResource): Call
        highlightLine on the view.
        * page/inspector/inspector.js:
        (WebInspector.documentClick): Pass the preferredPanel to showResourceForURL.
        (WebInspector.showResourceForURL): Resolve the preferredPanel from the string
        passed in. Checks if the panel implements showResource and canShowResource.
        Reverts to the Resources panel if any of that is false or not implemented.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fixed an "undefined type" exception that was being thrown when
timothy@apple.com [Sat, 31 May 2008 06:05:43 +0000 (06:05 +0000)]
    Fixed an "undefined type" exception that was being thrown when
        selecting a eval script from the file menu in the Scripts panel.
        This would also happen when stepping into an eval which would
        break other parts of the Inspector interface.

        Reviewed by Adam Roben.

        * page/inspector/ScriptsPanel.js:
        Use the scriptOrResource variable instead of the undefined script variable.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMade the starting line number of scripts be 1-based throughout the engine.
timothy@apple.com [Sat, 31 May 2008 06:05:28 +0000 (06:05 +0000)]
Made the starting line number of scripts be 1-based throughout the engine.


2008-05-30  Timothy Hatcher  <timothy@apple.com>

        Made the starting line number of scripts be 1-based throughout the engine.
        This cleans up script line numbers so they are all consistent now and fixes
        some cases where script execution was shown as off by one line in the debugger.

        No change in SunSpider.

        Reviewed by Oliver Hunt.

        * API/minidom.c:
        (main): Pass a line number of 1 instead of 0 to parser().parse().
        * API/testapi.c:
        (main): Ditto. And removes a FIXME and changed an assertEqualsAsNumber
        to use 1 instead of 2 for the line number.
        * VM/Machine.cpp:
        (KJS::callEval): Pass a line number of 1 instead of 0.
        (KJS::Machine::debug): Use firstLine for WillExecuteProgram instead of
        lastLine. Use lastLine for DidExecuteProgram instead of firstLine.
        * kjs/DebuggerCallFrame.cpp:
        (KJS::DebuggerCallFrame::evaluate): Pass a line number of 1 instead of
        0 to parser().parse().
        * kjs/Parser.cpp:
        (KJS::Parser::parse): ASSERT startingLineNumber is greatter than 0. Change
        the startingLineNumber to be 1 if it was less than or equal to 0. This is needed
        for release builds to maintain compatibility with the JavaScriptCore API.
        * kjs/function.cpp:
        (KJS::globalFuncEval): Pass a line number of 1 instead of 0 to parser().parse().
        * kjs/function_object.cpp:
        (FunctionObjectImp::construct): Pass a line number of 1 instead of 0 to construct().
        * kjs/lexer.cpp:
        (Lexer::setCode): Made yylineno = startingLineNumber instead of adding 1.
        * kjs/testkjs.cpp:
        (functionRun): Pass a line number of 1 instead of 0 to Interpreter::evaluate().
        (functionLoad): Ditto.
        (prettyPrintScript): Ditto.
        (runWithScripts): Ditto.
        * profiler/Profiler.cpp:
        (WebCore::createCallIdentifier): Removed a plus 1 of startingLineNumber.


2008-05-30  Timothy Hatcher  <timothy@apple.com>

        Made the starting line number of scripts be 1-based throughout the engine.
        This cleans up script line numbers so they are all consistent now and fixes
        some cases where script execution was shown as off by one line in the debugger.

        Doing this also exposed a bug where JSLazyEventListener created in XHML or SVG
        documents would always have a line number of 0. So this change fixed that bug
        to pass all the SVG and XHTML tests.

        All layout tests pass.

        Reviewed by Oliver Hunt.

        * bindings/js/kjs_events.cpp:
        (WebCore::JSLazyEventListener::JSLazyEventListener): Set the line number to 1
        if it was passed in as 0. This can happen when listeners are created with
        a setAttribute call from JavaScript.
        (WebCore::JSLazyEventListener::parseCode): Add a FIXME about the URL being
        incorrect when listeners are created with a setAttribute call from JavaScript.
        * bindings/js/kjs_events.h: Remove the default value for lineNumber, since no
        callers need it.
        * bindings/objc/WebScriptObject.mm:
        (-[WebScriptObject evaluateWebScript:]): Pass a line number of 1 instead of 0
        to Interpreter::evaluate().
        * bridge/NP_jsobject.cpp:
        (_NPN_Evaluate): Ditto.
        * bridge/jni/jni_jsobject.mm:
        (JavaJSObject::eval): Ditto.
        * dom/XMLTokenizer.cpp:
        (WebCore::XMLTokenizer::startElementNs): Call KJSProxy::setEventHandlerLineno()
        around the call to handleElementAttributes, so any JSLazyEventListener created
        from those attributes have line numbers.
        (WebCore::XMLTokenizer::endElementNs): Remove a minus 1 of the line number.
        (WebCore::XMLTokenizer::notifyFinished): Pass a line number of 1 instead of 0.
        (WebCore::XMLTokenizer::parseEndElement): Remove a minus 1 of the line number.
        * html/HTMLScriptElement.cpp:
        (WebCore::HTMLScriptElement::evaluateScript): Add a FIXME about the starting
        line number being incorrect in some cases when this function is called.
        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::parseSpecial): Add a plus 1 to the line number when
        setting scriptStartLineno so it is 1-based. Same for calling setEventHandlerLineno().
        (WebCore::HTMLTokenizer::processToken): Ditto.
        * html/HTMLTokenizer.h: Change the default line number on scriptExecution() to 1 from 0.
        * loader/FrameLoader.cpp:
        (FrameLoader::executeIfJavaScriptURL): Pass a line number of 1 instead of 0 to executeScript().


2008-05-30  Timothy Hatcher  <timothy@apple.com>

        Made the starting line number of scripts be 1-based throughout the engine.
        This cleans up script line numbers so they are all consistent now.

        Reviewed by Oliver Hunt.

        * DumpRenderTree/mac/ObjCController.m:
        (runJavaScriptThread): Pass a line number of 1 instead of 0 to JSEvaluateScript.
        * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
        (runJavaScriptThread): Ditto.
        * DumpRenderTree/win/DumpRenderTree.cpp:
        (runJavaScriptThread): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fixes the regression where image resources don't have a preview icon.
timothy@apple.com [Sat, 31 May 2008 06:05:04 +0000 (06:05 +0000)]
    Fixes the regression where image resources don't have a preview icon.


        Reviewed by Adam Roben.

        * page/inspector/ResourcesPanel.js:
        (WebInspector.ResourceSidebarTreeElement): Call createIconElement before
        calling the superclass.
        Create an iconElement, if the category is images then make a div that
        contains a preview image. Otherwise just make an img element. If there
        was a previous iconElement, then replace it.
        (WebInspector.ResourceSidebarTreeElement.prototype.refresh): Call
        createIconElement if the category changed.
        * page/inspector/SidebarTreeElement.js:
        (WebInspector.SidebarTreeElement): Create an iconElement if one hasn't
        been made already by a subclass.
        (WebInspector.SidebarTreeElement.prototype.onattach): Append the iconElement
        instead of creating one each time.
        * page/inspector/inspector.css: New and updated style rules.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-30 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Sat, 31 May 2008 05:37:03 +0000 (05:37 +0000)]
2008-05-30  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Oliver (earlier version reviewed by Alexey).

        - speculative fix for "REGRESSION(r34143?): Frequent crash while browsing"

        ("This Time for Sure" Edition)

        I'm pretty sure this fixes it but I have not been able to
        reproduce and am unsure if my theory of the bug is right.

        I belive the bug was because JSDOMWindowBase accessed
        JSDOMWindowShell in its destructor to remove itself from a
        hashtable, but GC destructor order is not guaranteed, so the
        hashtable may have been freed already. This patch changes things
        so that a non-GC object (the KJSProxy) does the tracking of live
        window objects for a frame. JSDOMWindowBase can null check the frame
        pointer to verify if it is still good.

        In addition, we must create a similar setup between DOMWindow and
        Frame; since the DOMWindow of a given frame can now change over
        time, we must ensure that the Frame disconnects every live
        DOMWindow when destroyed, not just the last.

        * bindings/js/JSDOMWindowBase.cpp:
        * bindings/js/JSDOMWindowShell.cpp:
        * bindings/js/JSDOMWindowShell.h:
        * bindings/js/kjs_proxy.cpp:
        * bindings/js/kjs_proxy.h:
        * page/DOMWindow.cpp:
        * page/Frame.cpp:
        * page/Frame.h:
        * page/FramePrivate.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz@apple.com [Fri, 30 May 2008 21:34:30 +0000 (21:34 +0000)]

        Reviewed by Darin Adler and Dave Hyatt.

        - eliminate excessive repainting when an object's final position
          after layout is unchanged

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutBlockChildren): Removed the full repaint
        for the case that the final position is unchanged but the position at
        which an intermediate layout occurred was different. Any repainting
        done during the intermediate layout would have happened at the object's
        initial (and also final) coordinates, since layoutDelta is factored
        into repaint rect calculations.


        Reviewed by Darin Adler.

        - updated pixel results for "eliminate excessive repainting when an
          object's final position after layout is unchanged"

        * platform/mac/fast/repaint/intermediate-layout-position-clip-expected.checksum:
        * platform/mac/fast/repaint/intermediate-layout-position-clip-expected.png:
        * platform/mac/fast/repaint/intermediate-layout-position-expected.checksum:
        * platform/mac/fast/repaint/intermediate-layout-position-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-29 Justin Garcia <justin.garcia@apple.com>
justin.garcia@apple.com [Fri, 30 May 2008 21:30:39 +0000 (21:30 +0000)]
2008-05-29  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Darin.

        <rdar://problem/5949462> REGRESSION: Can't paste screen captures into Mail

        AppKit started putting PNG instead of PICT onto the pasteboard for screen
        captures.  Added support for PNG with kUTTypePNG.  Tiger doesn't support
        setting and retrieving pasteboard types with UTIs, but we don't know of any
        applications on Tiger that put only PNG on the pasteboard.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
        (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
ap@webkit.org [Fri, 30 May 2008 20:10:38 +0000 (20:10 +0000)]
    Reviewed by Darin.

        speed up SunSpider by optimizing immediate number cases

        Also fixed a JavaScriptCore regression seen on PowerPC - we didn't clip left shift
        parameter to 0...31.

        0.5% improvement on SunSpider overall, although a 8.5 regression on bitops-3bit-bits-in-byte.

        * VM/Machine.cpp:
        Added fast paths for >>> and <<.

        * kjs/JSImmediate.h:
        (KJS::JSImmediate::toTruncatedUInt32): Added. Same as getTruncatedInt32, but casts the result
        to unsigned.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago<rdar://problem/5959478> r34079: AX: crash at stringForReplacedNode
cfleizach@apple.com [Fri, 30 May 2008 18:05:04 +0000 (18:05 +0000)]
<rdar://problem/5959478> r34079: AX: crash at stringForReplacedNode

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-30 Carlos Martín Nieto <carlos@cmartin.tk>
jmalonzo@webkit.org [Fri, 30 May 2008 14:15:35 +0000 (14:15 +0000)]
2008-05-30  Carlos Martín Nieto  <carlos@cmartin.tk>

        Reviewed by Alp Toker.

        [GTK] The "hovering-over-link" signal arguments aren't documented.

        * webkit/webkitwebview.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34263 268f45cc-cd09-0410-ab3c-d52691b4dbfc