WebKit.git
10 years ago2009-09-30 Kent Tamura <tkent@chromium.org>
eric@webkit.org [Thu, 1 Oct 2009 05:49:39 +0000 (05:49 +0000)]
2009-09-30  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Add ValidityState.tooLong support for <input> and <textarea>.
        https://bugs.webkit.org/show_bug.cgi?id=27454

        * fast/forms/ValidityState-tooLong-input-expected.txt: Added.
        * fast/forms/ValidityState-tooLong-input.html: Added.
        * fast/forms/ValidityState-tooLong-textarea-expected.txt: Added.
        * fast/forms/ValidityState-tooLong-textarea.html: Added.
        * fast/forms/script-tests/ValidityState-tooLong-input.js: Added.
        * fast/forms/script-tests/ValidityState-tooLong-textarea.js: Added.
2009-09-30  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Adds ValidityState.tooLong support for <input> and <textarea>.

        Introduces tooLong() in HTMLFormControlElement and it always returns false.
        HTMLInputElement and HTMLTextAreaElement overrides it and checks the text
        length and maxLength.  tooLong() should work only for `dirty' values.
        So, introduces m_isDirty flag for HTMLTextAreaElement, and
        !m_data.value().isNull() works as a dirty flag for HTMLInputElement.

        Renames parameter names of setMaxLength().

        https://bugs.webkit.org/show_bug.cgi?id=27454

        Tests: fast/forms/ValidityState-tooLong-input.html
               fast/forms/ValidityState-tooLong-textarea.html

        * html/HTMLFormControlElement.h:
        (WebCore::HTMLFormControlElement::tooLong):
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::tooLong):
        (WebCore::HTMLInputElement::setMaxLength):
        * html/HTMLInputElement.h:
        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::HTMLTextAreaElement):
        (WebCore::HTMLTextAreaElement::reset):
        (WebCore::HTMLTextAreaElement::updateValue):
        (WebCore::HTMLTextAreaElement::setMaxLength):
        (WebCore::HTMLTextAreaElement::tooLong):
        * html/HTMLTextAreaElement.h:
        * html/ValidityState.h:
        (WebCore::ValidityState::tooLong):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-30 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 1 Oct 2009 04:25:41 +0000 (04:25 +0000)]
2009-09-30  Adam Barth  <abarth@webkit.org>

        Reviewed by Maciej Stachowiak.

        Factor RedirectScheduler out of FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=29948

        This change introduces a new sub-object of Frame, redirectScheduler.
        The redirectScheduler is responsible for scheduling redirects.

        This change leaves the code for the redirectScheduler in
        FrameLoader.cpp.  A future change will move the class into its own
        file.

        No behavior change (hopefully!).

        * loader/FrameLoader.cpp:
        (WebCore::RedirectScheduler::RedirectScheduler):
        (WebCore::RedirectScheduler::~RedirectScheduler):
        (WebCore::RedirectScheduler::redirectScheduledDuringLoad):
        (WebCore::RedirectScheduler::clear):
        (WebCore::FrameLoader::FrameLoader):
        (WebCore::FrameLoader::setDefersLoading):
        (WebCore::FrameLoader::stopLoading):
        (WebCore::FrameLoader::didOpenURL):
        (WebCore::FrameLoader::didExplicitOpen):
        (WebCore::FrameLoader::cancelAndClear):
        (WebCore::FrameLoader::clear):
        (WebCore::FrameLoader::checkCompleted):
        (WebCore::FrameLoader::isScheduledLocationChangePending):
        (WebCore::FrameLoader::scheduleHTTPRedirection):
        (WebCore::RedirectScheduler::scheduleRedirect):
        (WebCore::RedirectScheduler::mustLockBackForwardList):
        (WebCore::FrameLoader::scheduleLocationChange):
        (WebCore::RedirectScheduler::scheduleLocationChange):
        (WebCore::FrameLoader::scheduleFormSubmission):
        (WebCore::RedirectScheduler::scheduleFormSubmission):
        (WebCore::FrameLoader::scheduleRefresh):
        (WebCore::RedirectScheduler::scheduleRefresh):
        (WebCore::RedirectScheduler::locationChangePending):
        (WebCore::FrameLoader::scheduleHistoryNavigation):
        (WebCore::RedirectScheduler::scheduleHistoryNavigation):
        (WebCore::RedirectScheduler::timerFired):
        (WebCore::FrameLoader::provisionalLoadStarted):
        (WebCore::RedirectScheduler::schedule):
        (WebCore::RedirectScheduler::startTimer):
        (WebCore::RedirectScheduler::cancel):
        (WebCore::FrameLoader::completed):
        (WebCore::FrameLoader::open):
        * loader/FrameLoader.h:
        (WebCore::FrameLoader::committedFirstRealDocumentLoad):
        * page/Frame.cpp:
        (WebCore::Frame::Frame):
        (WebCore::Frame::redirectScheduler):
        * page/Frame.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix, not reviewed.
mjs@apple.com [Thu, 1 Oct 2009 03:37:01 +0000 (03:37 +0000)]
Build fix, not reviewed.

More Windows build fixes for https://bugs.webkit.org/show_bug.cgi?id=29943

* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::willSendRequest):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix, not reviewed.
mjs@apple.com [Thu, 1 Oct 2009 03:14:09 +0000 (03:14 +0000)]
Build fix, not reviewed.

Fix windows build for fix for https://bugs.webkit.org/show_bug.cgi?id=29943

* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::willSendRequest):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-30 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 1 Oct 2009 02:59:33 +0000 (02:59 +0000)]
2009-09-30  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Fisher.

        [V8] HTMLAudioElement, HTMLImageElement, and HTMLOptionElement are constructable, but they shouldn't be.
        Only Audio, Image, and Option should be constructable.
        https://bugs.webkit.org/show_bug.cgi?id=29940

        Test: fast/dom/dom-constructor.html

        * WebCore.gypi: Added new files to project.
        * bindings/scripts/CodeGeneratorV8.pm: Modified to generate custom constructors.
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::getTemplate): Removed handling of HTMLImageElement, HTMLOptionElement
          and HTMLAudioElement construction.
        * bindings/v8/V8HTMLAudioElementConstructor.h: Added.
        * bindings/v8/V8HTMLImageElementConstructor.h: Added.
        * bindings/v8/V8HTMLOptionElementConstructor.h: Added.
        * bindings/v8/V8Index.cpp: Added new headers.
        * bindings/v8/V8Index.h: Added Audio, Image and Option decls.
        * bindings/v8/custom/V8CustomBinding.h: Ditto.
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::ACCESSOR_GETTER): Added custom constructors.
        * bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
        (WebCore::V8HTMLImageElementConstructor::GetTemplate): Added custom template creator.
        * bindings/v8/custom/V8HTMLOptionElementConstructor.cpp:
        (WebCore::V8HTMLOptionElementConstructor::GetTemplate): Ditto.
        * bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
        (WebCore::V8HTMLImageElementConstructor::GetTemplate): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-30 Gabor Loki <loki@inf.u-szeged.hu>
eric@webkit.org [Thu, 1 Oct 2009 01:13:02 +0000 (01:13 +0000)]
2009-09-30  Gabor Loki  <loki@inf.u-szeged.hu>

        Reviewed by George Staikos.

        Defines two pseudo-platforms for ARM and Thumb-2 instruction set.
        https://bugs.webkit.org/show_bug.cgi?id=29122

        Introduces WTF_PLATFORM_ARM_TRADITIONAL and WTF_PLATFORM_ARM_THUMB2
        macros on ARM platforms. The PLATFORM(ARM_THUMB2) should be used
        when Thumb-2 instruction set is the required target. The
        PLATFORM(ARM_TRADITIONAL) is for generic ARM instruction set. In
        case where the code is common the PLATFORM(ARM) have to be used.

        Modified by George Wright  <gwright@rim.com> to correctly work
        with the RVCT-defined __TARGET_ARCH_ARM and __TARGET_ARCH_THUMB
        compiler macros, as well as adding readability changes.

        * wtf/Platform.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-30 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Thu, 1 Oct 2009 01:09:09 +0000 (01:09 +0000)]
2009-09-30  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Brady Eidson.

        307 redirects should pass along http body and Content-Type header
        https://bugs.webkit.org/show_bug.cgi?id=29943

        Follow-up fix for:
        <rdar://problem/3802660> SAP: 307 (Temporary Redirect) responses should use POST, not GET

        Test: http/tests/loading/resources/redirect-methods-result.php

        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::willSendRequest): Pass along http body and Content-Type header.
        * platform/network/mac/ResourceHandleMac.mm:
        (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): ditto
2009-09-30  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Brady Eidson.

        307 redirects should pass along http body and Content-Type header
        https://bugs.webkit.org/show_bug.cgi?id=29943

        Follow-up fix for:
        <rdar://problem/3802660> SAP: 307 (Temporary Redirect) responses should use POST, not GET

        * http/tests/loading/redirect-methods.html: Updated test to show the http body and content-type header.
        * http/tests/loading/redirect-methods-expected.txt:
        * http/tests/loading/resources/redirect-methods-result.php:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixed https://bugs.webkit.org/show_bug.cgi?id=29941
ggaren@apple.com [Thu, 1 Oct 2009 00:40:10 +0000 (00:40 +0000)]
Fixed https://bugs.webkit.org/show_bug.cgi?id=29941
REGRESSION (r48882-r48888): Many memory leaks on SnowLeopard leaks bot

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-30
Reviewed by Mark Rowe.

Forgot to implement a destructor for JSDOMWindowBaseData, so it was
leaking its RefPtr data member.

* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::destroyJSDOMWindowBaseData):
* bindings/js/JSDOMWindowBase.h:
(WebCore::JSDOMWindowBase::JSDOMWindowBaseData::JSDOMWindowBaseData::JSDOMWindowBaseData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake sure the removal of user stylesheets results in all of the WebViews being updated to
hyatt@apple.com [Thu, 1 Oct 2009 00:13:39 +0000 (00:13 +0000)]
Make sure the removal of user stylesheets results in all of the WebViews being updated to
reflect the changes.

Reviewed by Tim Hatcher.

* page/PageGroup.cpp:
(WebCore::PageGroup::removeUserContentWithURLForWorld):
(WebCore::PageGroup::removeUserContentForWorld):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-30 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Wed, 30 Sep 2009 22:30:46 +0000 (22:30 +0000)]
2009-09-30  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Dimitri Glazkov.

        Use a script-tests directory rather than a resources directory for DOM Storage
        https://bugs.webkit.org/show_bug.cgi?id=29938

        Use a script-tests directory rather than a resources directory for DOM Storage.
        This matches up with what's been done elsewhere in the tree.

        * storage/domstorage/localstorage/clear.html:
        * storage/domstorage/resources: Removed.
        * storage/domstorage/resources/clear.js: Removed.
        * storage/domstorage/script-tests: Copied from LayoutTests/storage/domstorage/resources.
        * storage/domstorage/sessionstorage/clear.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-30 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 30 Sep 2009 22:06:17 +0000 (22:06 +0000)]
2009-09-30  Eric Seidel  <eric@webkit.org>

        No review, just adding Geoff to the list of reviewers.

        * Scripts/modules/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDevirtualise array toString conversion
oliver@apple.com [Wed, 30 Sep 2009 21:32:51 +0000 (21:32 +0000)]
Devirtualise array toString conversion

Reviewed by Geoff Garen.

Tweak the implementation of Array.prototype.toString to have a fast path
when acting on a true JSArray.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION(r47440): drop down menus at americanexpress.com disappear on mouse out
mitz@apple.com [Wed, 30 Sep 2009 21:15:03 +0000 (21:15 +0000)]
REGRESSION(r47440): drop down menus at americanexpress.com disappear on mouse out
https://bugs.webkit.org/show_bug.cgi?id=29209

Reviewed by Sam Weinig.

WebCore:

Test: fast/inline/relative-positioned-overflow.html

* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::computeVerticalOverflow): Add self-painting
inlines to overflow to ensure that they are included in hit-testing.

LayoutTests:

* fast/inline/relative-positioned-overflow-expected.txt: Added.
* fast/inline/relative-positioned-overflow.html: Added.
* platform/mac/fast/repaint/transform-absolute-in-positioned-container-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix for <rdar://problem/7259706>
weinig@apple.com [Wed, 30 Sep 2009 20:56:33 +0000 (20:56 +0000)]
Fix for <rdar://problem/7259706>
Need WebKit API or SPI on Mac and Windows to test whether it's safe to load a page in a new tab/window

Reviewed by Dan Bernstein.

WebKit/mac:

* WebView/WebFrame.mm:
(-[WebFrame _allowsFollowingLink:]):
* WebView/WebFramePrivate.h:

WebKit/win:

* Interfaces/IWebFramePrivate.idl:
* WebFrame.cpp:
(WebFrame::allowsFollowingLink):
* WebFrame.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-30 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 30 Sep 2009 20:19:35 +0000 (20:19 +0000)]
2009-09-30  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Mark Rowe.

        transforms/3d tests are not run in Release builds
        https://bugs.webkit.org/show_bug.cgi?id=29827

        Make sure we export the WebCoreHas3DRendering symbol in Release builds,
        because this symbols is used by run-webkit-tests (via 'nm') to detect whether
        WebCore was built with ENABLE_3D_RENDERING turned on.

        * DerivedSources.make:
        * WebCore.3DRendering.exp: Added.
        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdded the WebKit Layout Tests fonts that are referenced in
mitz@apple.com [Wed, 30 Sep 2009 19:44:34 +0000 (19:44 +0000)]
Added the WebKit Layout Tests fonts that are referenced in
LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css

Reviewed by Sam Weinig.

* DumpRenderTree/fonts/WebKit Layout Tests 2.ttf: Added.
* DumpRenderTree/fonts/WebKit Layout Tests.ttf: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd the failed URL to the ErrorPageExtension, as it is quite
kenneth@webkit.org [Wed, 30 Sep 2009 19:38:05 +0000 (19:38 +0000)]
Add the failed URL to the ErrorPageExtension, as it is quite
useful for creating error pages.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-30
Reviewed by David Hyatt.

* Api/qwebpage.h:
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::callErrorPageExtension):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix for QT. Didn't know WebCore.pro existed.
jorlow@chromium.org [Wed, 30 Sep 2009 19:33:02 +0000 (19:33 +0000)]
Build fix for QT.  Didn't know WebCore.pro existed.

Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-09-30
* WebCore.pro:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Add a method for removal of user scripts and stylesheets by URL from a speci...
hyatt@apple.com [Wed, 30 Sep 2009 19:25:57 +0000 (19:25 +0000)]
WebCore: Add a method for removal of user scripts and stylesheets by URL from a specific world.

Reviewed by Adam Roben.

* page/PageGroup.cpp:
(WebCore::PageGroup::removeUserContentURLForWorld):
* page/PageGroup.h:

WebKit/mac: Add the ability to remove user stylesheets and scripts by URL.

Reviewed by Adam Roben.

* WebView/WebView.mm:
(+[WebView _removeUserContentFromGroup:url:worldID:]):
* WebView/WebViewPrivate.h:

WebKit/win: Add the ability to remove user stylesheets and scripts by URL.

Reviewed by Adam Roben.

* Interfaces/IWebViewPrivate.idl:
* WebView.cpp:
(WebView::removeUserContentWithURLFromGroup):
* WebView.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-30 Chris Hawk <hawk@chromium.org>
eric@webkit.org [Wed, 30 Sep 2009 19:01:12 +0000 (19:01 +0000)]
2009-09-30  Chris Hawk  <hawk@chromium.org>

        Reviewed by Dimitri Glazkov.

        Fix for conditionals in the WebCore gyp file, which contained two separate
        'conditions' values for the webcore target. The first entry was ignored,
        resulting in some missine defines.
        https://bugs.webkit.org/show_bug.cgi?id=29907

        * WebCore.gyp/WebCore.gyp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-21 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Wed, 30 Sep 2009 18:52:39 +0000 (18:52 +0000)]
2009-09-21  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Adam Barth.

        DOM Storage needs to be more careful about where "ThreadSafe" objects are destroyed.
        https://bugs.webkit.org/show_bug.cgi?id=29265

        DOM Storage needs to be more careful about where "ThreadSafe" objects are
        destroyed.  With the current code, there actually isn't a race condition, but
        it sure would be easy for someone to introduce one.  A bunch of
        ThreadSafeShared objects have RefPtrs to objects that are NOT ThreadSafeShared
        objects.  If it were possible any of these objects' destructors to be fired off
        the main thread, then the you'd have a race condition.  The code should be more
        clear and self-documenting about how things related to each other.

        Since the lifetime of a LocalStorageTask is bounded by the LocalStorageThread
        which is bounded by the StorageSyncManager, StorageAreaImpl, and
        StorageAreaSync, there's no reason for LocalStorageTask to store anything other
        than pointers.  By breaking this dependency, we can eliminate the risk.

        Note that we _could_ have LocalStorageThread's task queue just store
        LocalStorageTask*'s rather than RefPtr<LocalStorageTask>s but then we'd need to
        manually take care of deleting.  It'd probably also be possible to change
        LocalStorageThread around so that it needn't hold onto a reference of itself
        and have a more deterministic shutdown, but my initial attempts to do so
        failed, and I decided it wasn't worth changing.  The queue is killed before
        hand, so the thread is 100% impotent before the main thread continues anyway.

        The constructors and destructors of StorageSyncManager, StorageAreaImpl, and
        StorageAreaSync now have ASSERTs to verify they're running on the main thread.
        I'm fairly positive that it'd be impossible to hit these asserts and the fact
        that these classes are no longer ThreadSafeShared should make it clear how
        they're meant to be used, but I think it's worth it to be extra sure.  Of
        course, ideally, we'd have such an assert every time a ref is incremented or
        decremented.

        Behavior should be unchanged and this is just an internal code cleanup, so no
        new tests.

        * storage/LocalStorageTask.cpp:
        (WebCore::LocalStorageTask::LocalStorageTask):
        (WebCore::LocalStorageTask::performTask):
        * storage/LocalStorageTask.h:
        (WebCore::LocalStorageTask::createImport):
        (WebCore::LocalStorageTask::createSync):
        (WebCore::LocalStorageTask::createTerminate):
        * storage/LocalStorageThread.cpp:
        (WebCore::LocalStorageThread::scheduleImport):
        (WebCore::LocalStorageThread::scheduleSync):
        * storage/LocalStorageThread.h:
        * storage/StorageArea.h:
        * storage/StorageAreaImpl.cpp:
        (WebCore::StorageAreaImpl::~StorageAreaImpl):
        (WebCore::StorageAreaImpl::StorageAreaImpl):
        * storage/StorageAreaSync.cpp:
        (WebCore::StorageAreaSync::StorageAreaSync):
        (WebCore::StorageAreaSync::~StorageAreaSync):
        * storage/StorageSyncManager.cpp:
        (WebCore::StorageSyncManager::StorageSyncManager):
        (WebCore::StorageSyncManager::~StorageSyncManager):
        (WebCore::StorageSyncManager::scheduleImport):
        (WebCore::StorageSyncManager::scheduleSync):
        * storage/StorageSyncManager.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuildfix for platforms using JSVALUE32.
ggaren@apple.com [Wed, 30 Sep 2009 18:26:28 +0000 (18:26 +0000)]
Buildfix for platforms using JSVALUE32.
https://bugs.webkit.org/show_bug.cgi?id=29915

Patch by Csaba Osztrogonac <oszi@inf.u-szeged.hu> on 2009-09-30
Reviewed by Geoffrey Garen.

After http://trac.webkit.org/changeset/48905 the build broke in JSVALUE32 case.
Also removed unreachable code.

* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_add):
 - Declaration of "OperandTypes types" moved before first use.
 - Typos fixed: dst modified to result, regT2 added.
 - Unreachable code removed.
(JSC::JIT::emitSlow_op_add):
 - Missing declaration of "OperandTypes types" added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-28 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Wed, 30 Sep 2009 18:17:12 +0000 (18:17 +0000)]
2009-09-28  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Fisher.

        Chromium needs to be able to override the way storage events are delivered
        https://bugs.webkit.org/show_bug.cgi?id=29655

        Chromium needs to be able to override the way storage events are delivered.
        This replaced https://bugs.webkit.org/show_bug.cgi?id=29257 because it'll be
        faster (no vtables and extra allocation) and somewhat cleaner (no dependency
        injection).  This is necessary because Chromium needs to transport events across
        a process barrier and then dispatch them without use of a Frame*.

        Behavior should not change with this, so no updates to tests.

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * storage/StorageAreaImpl.cpp:
        (WebCore::StorageAreaImpl::setItem):
        (WebCore::StorageAreaImpl::removeItem):
        (WebCore::StorageAreaImpl::clear):
        * storage/StorageAreaImpl.h:
        * storage/StorageEventDispatcher.cpp: Copied from WebCore/storage/StorageAreaImpl.cpp.
        (WebCore::StorageEventDispatcher::dispatch):
        * storage/StorageEventDispatcher.h: Added.  (Well, technically in the other half of this patch.)

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoVersioning.
mrowe@apple.com [Wed, 30 Sep 2009 18:15:19 +0000 (18:15 +0000)]
Versioning.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNeed to check NULL frame in EventHandler::updateDragAndDrop.
jianli@chromium.org [Wed, 30 Sep 2009 17:52:33 +0000 (17:52 +0000)]
Need to check NULL frame in EventHandler::updateDragAndDrop.
https://bugs.webkit.org/show_bug.cgi?id=29929

Reviewed by Darin Adler.

WebCore:

Test: http/tests/misc/drag-over-iframe-invalid-source-crash.html

* page/EventHandler.cpp:
(WebCore::EventHandler::updateDragAndDrop):

LayoutTests:

Add a new test for the bug.

* http/tests/misc/drag-over-iframe-invalid-source-crash-expected.txt: Added.
* http/tests/misc/drag-over-iframe-invalid-source-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSet the svn:mime-type property of recently-added PNG files to image/png.
mitz@apple.com [Wed, 30 Sep 2009 17:33:54 +0000 (17:33 +0000)]
Set the svn:mime-type property of recently-added PNG files to image/png.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 30 Sep 2009 17:21:48 +0000 (17:21 +0000)]
2009-09-29  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        ASSERTION FAILED: !repaintContainer || repaintContainer == this
        https://bugs.webkit.org/show_bug.cgi?id=29755

        Generalize the fix for this bug to account for cases where there may be multiple
        containing blocks between the repaint container, and the container of the element
        being repainted.

        Test: compositing/repaint/opacity-between-absolute2.html

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::mapLocalToContainer):
        Call offsetFromAncestorContainer() to get the correct offset.

        (WebCore::RenderBox::computeRectForRepaint): Ditto
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::computeRectForRepaint): Ditto.

        * rendering/RenderObject.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::offsetFromAncestorContainer):
        New method that computes an offset from some object in the ancestor container() chain.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-30 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
ddkilzer@apple.com [Wed, 30 Sep 2009 17:15:22 +0000 (17:15 +0000)]
2009-09-30  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>

        Reviewed by David Kilzer.

        Make sunspider scripts work on Windows platform.
        https://bugs.webkit.org/show_bug.cgi?id=29656

        * Scripts/run-sunspider: Perl scripts invoked with same Perl interpreter.
        * Scripts/sunspider-compare-results: Perl scripts invoked with same Perl interpreter.
        * Scripts/webkitdirs.pm: currentPerlPath() added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-30 Yaar Schnitman <yaar@chromium.org>
eric@webkit.org [Wed, 30 Sep 2009 17:13:11 +0000 (17:13 +0000)]
2009-09-30  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Dimitri Glazkov.

        1. Keeping up with downstream revisions.
        2. Turning off v8 snapshot build step.

        https://bugs.webkit.org/show_bug.cgi?id=29928

        * chromium/DEPS

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-30 Andras Becsi <becsi.andras@stud.u-szeged.hu>
eric@webkit.org [Wed, 30 Sep 2009 15:35:10 +0000 (15:35 +0000)]
2009-09-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>

        Reviewed by Simon Hausmann.

        [Qt] Fix TextCodecQt::decode method after r48752 to return a non-null string if the length of the input is 0.
        This fixes https://bugs.webkit.org/show_bug.cgi?id=29736.

        * platform/text/qt/TextCodecQt.cpp:
        (WebCore::TextCodecQt::decode):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReduce heap size on Symbian from 64MB to 8MB.
hausmann@webkit.org [Wed, 30 Sep 2009 14:20:07 +0000 (14:20 +0000)]
Reduce heap size on Symbian from 64MB to 8MB.

Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2009-09-30
Reviewed by Simon Hausmann.

This is not a perfect fix, it requires more fine tuning.
But this makes it possible again to debug in the emulator,
which is more important in order to be able to fix other
run-time issues.

* runtime/Collector.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Update Skipped after #48873 and some expected files, whose
hausmann@webkit.org [Wed, 30 Sep 2009 12:16:33 +0000 (12:16 +0000)]
[Qt] Update Skipped after #48873 and some expected files, whose
problems are the same (default font size reconciliation
16px/13px), but the previous update didn't contain them.

Patch by Renata Hodovan <hodovan.renata@stud.u-szeged.hu> on 2009-09-30
Reviewed by Simon Hausmann.

* platform/qt/Skipped:
* platform/qt/css2.1/t040103-ident-04-c-expected.txt:
* platform/qt/css2.1/t0402-c71-fwd-parsing-00-f-expected.txt:
* platform/qt/css2.1/t040304-c64-uri-00-a-g-expected.txt:
* platform/qt/css2.1/t040306-syntax-01-f-expected.txt:
* platform/qt/css2.1/t1202-counter-05-b-expected.txt:
* platform/qt/css2.1/t140201-c535-bg-fixd-00-b-g-expected.txt:
* platform/qt/css2.1/t1507-c526-font-sz-03-f-a-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-00-d-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-30 Shinichiro Hamaji <hamaji@chromium.org>
eric@webkit.org [Wed, 30 Sep 2009 12:02:00 +0000 (12:02 +0000)]
2009-09-30  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by David Levin.

        Move message-port-multi.js from resources to script-tests
        https://bugs.webkit.org/show_bug.cgi?id=29798

        Revert r48823. message-port-multi.js needs custom HTML.

        * fast/events/message-port-multi-expected.txt:
        * fast/events/message-port-multi.html:
        * fast/events/resources/message-port-multi.js: Added.
        (channel.port2.onmessage):
        * fast/events/script-tests/message-port-multi.js: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-30 Shinichiro Hamaji <hamaji@chromium.org>
eric@webkit.org [Wed, 30 Sep 2009 10:49:08 +0000 (10:49 +0000)]
2009-09-30  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by David Kilzer.

        Change remaining references in tests from bugzilla.opendarwin.org to bugs.webkit.org
        https://bugs.webkit.org/show_bug.cgi?id=12140

        Fixes for JS files.

        * fast/js/date-preserve-milliseconds-expected.txt:
        * fast/js/script-tests/array-float-delete.js:
        * fast/js/script-tests/array-tostring-ignore-separator.js:
        * fast/js/script-tests/date-big-setmonth.js:
        * fast/js/script-tests/date-negative-setmonth.js:
        * fast/js/script-tests/date-preserve-milliseconds.js:
        * fast/js/script-tests/number-tofixed.js:
        * fast/js/script-tests/object-extra-comma.js:
        * fast/js/script-tests/object-prototype-constructor.js:
        * fast/js/script-tests/object-prototype-toLocaleString.js:
        * fast/js/script-tests/regexp-lastindex.js:
        * fast/js/script-tests/regexp-stack-overflow.js:
        * fast/js/script-tests/string-split-ignore-case.js:
        * fast/js/script-tests/toString-exception.js:
        * fast/js/script-tests/toString-overrides.js:
        * fast/js/script-tests/toString-stack-overflow.js:
        * fast/js/toString-stack-overflow-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-30 Steve Block <steveblock@google.com>
eric@webkit.org [Wed, 30 Sep 2009 08:55:48 +0000 (08:55 +0000)]
2009-09-30  Steve Block  <steveblock@google.com>

        Reviewed by Darin Adler.

        Geolocation LayoutTests should use an HTML template.
        https://bugs.webkit.org/show_bug.cgi?id=29179

        Updates Geolocation LayoutTests to correctly use an HTML template so that
        individual HTML files can be generated using make-script-test-wrappers.
        This requires a new js-test-post.js which allows for asynchronous tests.

        * fast/dom/Geolocation/resources/TEMPLATE.html: Modified. Updated to use new js-test-post.js.
        * fast/dom/Geolocation/resources/js-test-post.js: Added. Allows for asynchronous tests.

        * fast/dom/Geolocation/resources/argument-types.js: Modified. Sepcifies synchronous test.
        * fast/dom/Geolocation/argument-types.html: Modified. Updated to use new js-test-post.js.

        * fast/dom/Geolocation/resources/callback-exception.js: Modified. Specifies asynchronous test.
        * fast/dom/Geolocation/callback-exception.html: Modified. Updated to use new js-test-post.js.
        * fast/dom/Geolocation/callback-exception-expected.txt: Modified. Adds successfullyParsed.

        * fast/dom/Geolocation/resources/enabled.js: Modified. Sepcifies synchronous test.
        * fast/dom/Geolocation/enabled.html: Modified. Updated to use new js-test-post.js.

        * fast/dom/Geolocation/resources/error.js: Modified. Specifies asynchronous test.
        * fast/dom/Geolocation/error.html: Modified. Updated to use new js-test-post.js.
        * fast/dom/Geolocation/error-expected.txt: Modified. Adds successfullyParsed.

        * fast/dom/Geolocation/resources/permission-denied.js: Modified. Specifies asynchronous test.
        * fast/dom/Geolocation/permission-denied.html: Modified. Updated to use new js-test-post.js.
        * fast/dom/Geolocation/permission-denied-expected.txt: Modified. Adds successfullyParsed.

        * fast/dom/Geolocation/resources/permission-denied-stops-watches.js: Modified. Specifies asynchronous test.
        * fast/dom/Geolocation/permission-denied-stops-watches.html: Modified. Updated to use new js-test-post.js.
        * fast/dom/Geolocation/permission-denied-stops-watches-expected.txt: Modified. Adds successfullyParsed.

        * fast/dom/Geolocation/resources/position-string.js: Modified. Specifies asynchronous test.
        * fast/dom/Geolocation/position-string.html: Modified. Updated to use new js-test-post.js.
        * fast/dom/Geolocation/position-string-expected.txt: Modified. Adds successfullyParsed.

        * fast/dom/Geolocation/resources/reentrant-error.js: Modified. Specifies asynchronous test.
        * fast/dom/Geolocation/reentrant-error.html: Modified. Updated to use new js-test-post.js.
        * fast/dom/Geolocation/reentrant-error-expected.txt: Modified. Adds successfullyParsed.

        * fast/dom/Geolocation/resources/reentrant-success.js: Modified. Specifies asynchronous test.
        * fast/dom/Geolocation/reentrant-success.html: Modified. Updated to use new js-test-post.js.
        * fast/dom/Geolocation/reentrant-success-expected.txt: Modified. Adds successfullyParsed.

        * fast/dom/Geolocation/resources/success.js: Modified. Specifies asynchronous test.
        * fast/dom/Geolocation/success.html: Modified. Updated to use new js-test-post.js.
        * fast/dom/Geolocation/success-expected.txt: Modified. Adds successfullyParsed.

        * fast/dom/Geolocation/resources/timeout.js: Modified. Specifies asynchronous test.
        * fast/dom/Geolocation/timeout.html: Modified. Updated to use new js-test-post.js.
        * fast/dom/Geolocation/timeout-expected.txt: Modified. Adds successfullyParsed.

        * fast/dom/Geolocation/resources/timeout-zero.js: Modified. Specifies asynchronous test.
        * fast/dom/Geolocation/timeout-zero.html: Modified. Updated to use new js-test-post.js.
        * fast/dom/Geolocation/timeout-zero-expected.txt: Modified. Adds successfullyParsed.

        * fast/dom/Geolocation/resources/watch.js: Modified. Specifies asynchronous test.
        * fast/dom/Geolocation/watch.html: Updated to use new js-test-post.js.
        * fast/dom/Geolocation/watch-expected.txt: Modified. Adds successfullyParsed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-30 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
eric@webkit.org [Wed, 30 Sep 2009 08:13:03 +0000 (08:13 +0000)]
2009-09-30  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>

        Reviewed by Darin Adler.

        Platform specific null device replaced with a platform independent.
        https://bugs.webkit.org/show_bug.cgi?id=29544

        * sunspider: Using File::Spec->devnull() instead of /dev/null and NUL.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix CRASH() macro for Symbian build.
hausmann@webkit.org [Wed, 30 Sep 2009 07:48:40 +0000 (07:48 +0000)]
Fix CRASH() macro for Symbian build.

Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2009-09-30
Reviewed by Simon Hausmann.

* wtf/Assertions.h: Added missing }

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Wed, 30 Sep 2009 06:55:11 +0000 (06:55 +0000)]
2009-09-29  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Eric Seidel.

        Change remaining references in tests from bugzilla.opendarwin.org to bugs.webkit.org
        https://bugs.webkit.org/show_bug.cgi?id=12140

        Remove opendarwin URLs from href="".
        This change doesn't change pixel test results.

        * editing/pasteboard/display-block-on-spans.html:
        * editing/pasteboard/drop-text-without-selection.html:
        * editing/pasteboard/paste-text-019.html:
        * editing/selection/6476.html:
        * editing/selection/7152-1.html:
        * editing/selection/7152-2.html:
        * editing/selection/after-line-wrap.html:
        * editing/selection/click-start-of-line.html:
        * editing/selection/leave-requested-block.html:
        * editing/selection/select-from-textfield-outwards.html:
        * fast/block/basic/text-indent-rtl.html:
        * fast/block/float/nopaint-after-layer-destruction.html:
        * fast/block/float/nopaint-after-layer-destruction2.html:
        * fast/block/float/table-relayout.html:
        * fast/block/float/vertical-move-relayout.html:
        * fast/block/positioning/height-change.html:
        * fast/block/positioning/relayout-on-position-change.html:
        * fast/block/positioning/window-height-change.html:
        * fast/css-generated-content/hover-style-change.html: Added property allow-tabs.
        * fast/css/error-in-last-decl.html:
        * fast/css/ex-after-font-variant.html:
        * fast/css/find-next-layer.html:
        * fast/css/first-letter-detach.html:
        * fast/css/font-shorthand-weight-only.html:
        * fast/css/hover-subselector.html:
        * fast/css/invalidation-errors-2.html:
        * fast/css/invalidation-errors-3.html:
        * fast/css/invalidation-errors.html:
        * fast/css/resize-corner-tracking.html:
        * fast/css/rtl-ordering.html:
        * fast/css/universal-hover-quirk.html:
        * fast/dom/Element/class-attribute-whitespace.html: Added property allow-tabs.
        * fast/dom/HTMLHeadElement/head-link-style-href-check.html:
        * fast/dom/HTMLLinkElement/pending-stylesheet-count.html:
        * fast/dynamic/layer-hit-test-crash.html:
        * fast/dynamic/selection-highlight-adjust.html:
        * fast/encoding/resources/%25%u0435 0 %xx%%%ulike.html:
        * fast/events/event-sender-mouse-moved.html:
        * fast/events/resources/drag-outside-window-frame.html:
        * fast/forms/button-cannot-be-nested.html:
        * fast/forms/button-generated-content.html:
        * fast/forms/button-inner-block-reuse.html:
        * fast/forms/button-white-space.html:
        * fast/forms/floating-textfield-relayout.html:
        * fast/forms/form-hides-table.html:
        * fast/forms/visual-hebrew-text-field.html:
        * fast/history/clicked-link-is-visited.html:
        * fast/history/resources/clicked-link-is-visited-2.html:
        * fast/inline-block/overflow-clip.html:
        * fast/invalid/missing-address-end-tag.html:
        * fast/invalid/missing-dl-end-tag.html:
        * fast/invalid/missing-dt-end-tag.html:
        * fast/invalid/missing-font-end-tag.html:
        * fast/js/exception-linenums-in-html-3.html:
        * fast/js/missing-style-end-tag-js.html:
        * fast/layers/opacity-outline.html:
        * fast/lists/list-style-none-crash.html:
        * fast/lists/markers-in-selection.html:
        * fast/lists/scrolled-marker-paint.html:
        * fast/overflow/image-selection-highlight.html:
        * fast/overflow/overflow-rtl-inline-scrollbar.html:
        * fast/parser/broken-comments-vs-parsing-mode.html:
        * fast/parser/nofoo-tags-inside-paragraph.html:
        * fast/parser/remove-block-in-residual-style.html:
        * fast/repaint/backgroundSizeRepaint.html:
        * fast/repaint/border-repaint-glitch.html:
        * fast/repaint/bugzilla-3509.html:
        * fast/repaint/bugzilla-5699.html:
        * fast/repaint/bugzilla-6278.html:
        * fast/repaint/bugzilla-6388.html:
        * fast/repaint/bugzilla-6473.html:
        * fast/repaint/bugzilla-7235.html:
        * fast/repaint/clipped-relative.html:
        * fast/repaint/containing-block-position-change.html:
        * fast/repaint/flexible-box-overflow-horizontal.html:
        * fast/repaint/flexible-box-overflow.html:
        * fast/repaint/float-move-during-layout.html:
        * fast/repaint/inline-outline-repaint.html:
        * fast/repaint/layer-outline-horizontal.html:
        * fast/repaint/layer-outline.html:
        * fast/repaint/line-overflow.html:
        * fast/repaint/outline-repaint-glitch.html:
        * fast/repaint/outline-shrinking.html:
        * fast/repaint/repaint-resized-overflow.html:
        * fast/repaint/static-to-positioned.html:
        * fast/repaint/table-cell-move.html:
        * fast/repaint/table-extra-bottom-grow.html:
        * fast/repaint/text-shadow-horizontal.html:
        * fast/repaint/text-shadow.html:
        * fast/replaced/applet-rendering-java-disabled.html:
        * fast/replaced/image-solid-color-with-alpha.html:
        * fast/replaced/inline-box-wrapper-handover.html:
        * fast/replaced/pdf-as-image.html:
        * fast/table/absolute-table-at-bottom.html:
        * fast/table/add-before-anonymous-child.html:
        * fast/table/border-collapsing/003.html:
        * fast/table/border-collapsing/border-collapsing-head-foot.html:
        * fast/table/border-collapsing/rtl-border-collapsing.html:
        * fast/table/cell-absolute-child.html:
        * fast/table/click-near-anonymous-table.html:
        * fast/table/edge-offsets.html:
        * fast/table/empty-section-crash.html:
        * fast/table/fixed-table-non-cell-in-row.html:
        * fast/table/form-with-table-style.html:
        * fast/table/row-height-recalc.html:
        * fast/table/rtl-cell-display-none-assert.html:
        * fast/table/text-field-baseline.html:
        * fast/text/atsui-small-caps-punctuation-size.html:
        * fast/text/atsui-spacing-features.html:
        * fast/text/basic/015.html:
        * fast/text/capitalize-empty-generated-string.html:
        * fast/text/in-rendered-text-rtl.html:
        * fast/text/international/rtl-caret.html:
        * fast/text/midword-break-hang.html:
        * fast/text/whitespace/pre-wrap-overflow-selection.html:
        * fast/text/whitespace/pre-wrap-spaces-after-newline.html:
        * fast/tokenizer/missing-style-end-tag-1.html:
        * fast/tokenizer/missing-style-end-tag-2.html:
        * fast/tokenizer/missing-title-end-tag-1.html:
        * fast/tokenizer/missing-title-end-tag-2.html:
        * http/tests/misc/iframe404.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoInlined a few math operations.
ggaren@apple.com [Wed, 30 Sep 2009 04:46:57 +0000 (04:46 +0000)]
Inlined a few math operations.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-29
Reviewed by Gavin Barraclough.

~1% SunSpider speedup.

* jit/JIT.h:
* jit/JITArithmetic.cpp:
(JSC::JIT::compileBinaryArithOpSlowCase):
(JSC::JIT::emitSlow_op_add):
(JSC::JIT::emitSlow_op_mul):
(JSC::JIT::emit_op_sub):
(JSC::JIT::emitSlow_op_sub): Don't take a stub call when operating on
a constant int and a double.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix a couple of bugs with patterns. Move the setting of the document URL to before...
hyatt@apple.com [Wed, 30 Sep 2009 02:46:52 +0000 (02:46 +0000)]
Fix a couple of bugs with patterns.  Move the setting of the document URL to before the style
selector gets constructed so that pattern match testing gets the correct URL.

Reviewed by Jon Honeycutt.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::begin):
* page/UserContentURLPattern.cpp:
(WebCore::UserContentURLPattern::parse):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Rubber-stamped by Brady Eidson.
ap@apple.com [Wed, 30 Sep 2009 02:02:47 +0000 (02:02 +0000)]
    Rubber-stamped by Brady Eidson.

        Assertion failure in http/tests/xmlhttprequest/failed-auth.html.

        I couldn't find out why this only started to happen now, but it was incorrect to check
        persistence of a credential returned by CredentialStorage::get() without checking that it
        was non-null. When there is no credential for the protection space in storage, get()
        returns a new object, and Credentil constructor doesn't initialize m_persistence.

        * platform/network/mac/ResourceHandleMac.mm:
        (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): Moved the
        assertion after credential null check.
        (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Added the same persistence
        assertion, matching sync code (and CF one, as well).

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubberstamped by Dan Bernstein.
beidson@apple.com [Wed, 30 Sep 2009 02:00:44 +0000 (02:00 +0000)]
Rubberstamped by Dan Bernstein.

Fix license and some sorting in new files.

WebKit/mac:

* WebView/WebHistoryDelegate.h:
* WebView/WebNavigationData.h:
* WebView/WebNavigationData.mm:

WebKitTools:

* DumpRenderTree/mac/HistoryDelegate.h:
* DumpRenderTree/mac/HistoryDelegate.mm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Yaar Schnitman <yaar@chromium.org>
eric@webkit.org [Wed, 30 Sep 2009 01:46:26 +0000 (01:46 +0000)]
2009-09-29  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by David Kilzer.

        Fixed how error codes are handled.
        https://bugs.webkit.org/show_bug.cgi?id=29898

        * Scripts/update-webkit:
        * Scripts/update-webkit-chromium:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdated way-out-of-date sorting throughout the dump methods/flags.
beidson@apple.com [Wed, 30 Sep 2009 01:36:42 +0000 (01:36 +0000)]
Updated way-out-of-date sorting throughout the dump methods/flags.

Reviewed by John Sullivan.

* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(dumpAsPDFCallback):
(dumpAsTextCallback):
(dumpFrameLoadCallbacksCallback):
(dumpResourceLoadCallbacksCallback):
(LayoutTestController::staticFunctions):

* DumpRenderTree/LayoutTestController.h:
(LayoutTestController::dumpAsText):
(LayoutTestController::setDumpAsText):
(LayoutTestController::dumpFrameLoadCallbacks):
(LayoutTestController::setDumpFrameLoadCallbacks):
(LayoutTestController::dumpSelectionRect):
(LayoutTestController::setDumpSelectionRect):
(LayoutTestController::dumpSourceAsWebArchive):
(LayoutTestController::setDumpSourceAsWebArchive):
(LayoutTestController::dumpStatusCallbacks):
(LayoutTestController::setDumpStatusCallbacks):
(LayoutTestController::dumpTitleChanges):
(LayoutTestController::setDumpTitleChanges):
(LayoutTestController::dumpWillCacheResponse):
(LayoutTestController::setDumpWillCacheResponse):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit Mac API should provide a delegate interface for global history.
beidson@apple.com [Wed, 30 Sep 2009 01:35:33 +0000 (01:35 +0000)]
WebKit Mac API should provide a delegate interface for global history.
<rdar://problem/7042773> and https://webkit.org/b/29904

Reviewed by John Sullivan.

WebKit:

* WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

* WebView/WebHistoryDelegate.h: Added. New interface for WebKit clients to implement to manage
  their own global history store.

Object to store all of the bits of data relevant to a page visit:
* WebView/WebNavigationData.h: Added.
* WebView/WebNavigationData.mm: Added.
(-[WebNavigationDataPrivate dealloc]):
(-[WebNavigationData initWithURLString:title:originalRequest:response:hasSubstituteData:clientRedirectSource:]):
(-[WebNavigationData url]):
(-[WebNavigationData title]):
(-[WebNavigationData originalRequest]):
(-[WebNavigationData response]):
(-[WebNavigationData hasSubstituteData]):
(-[WebNavigationData clientRedirectSource]):
(-[WebNavigationData dealloc]):

* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::updateGlobalHistory): If the delegate exists, don't use the built-in WebHistory.
  If the implementation for this method exists, call it.
(WebFrameLoaderClient::updateGlobalHistoryRedirectLinks): Ditto

* WebView/WebDelegateImplementationCaching.h:
* WebView/WebDelegateImplementationCaching.mm:
(WebViewGetHistoryDelegateImplementations):
(CallHistoryDelegate):

* WebView/WebView.mm:
(-[WebView _cacheHistoryDelegateImplementations]):
(-[WebView setHistoryDelegate:]):
(-[WebView historyDelegate]):
* WebView/WebViewData.h:
* WebView/WebViewPrivate.h:

WebKitTools:

Adding the dumping of global history delegate callbacks.

* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

Automatically dump history delegate callbacks for tests with "globalhistory/" in their URL:
* DumpRenderTree/mac/DumpRenderTree.mm:
(createWebViewAndOffscreenWindow):
(allocateGlobalControllers):
(shouldLogFrameLoadDelegates):
(shouldLogHistoryDelegates):
(runTest):

Dump history delegate callbacks:
* DumpRenderTree/mac/HistoryDelegate.h: Added.
* DumpRenderTree/mac/HistoryDelegate.mm: Added.
(-[HistoryDelegate webView:didNavigateWithNavigationData:inFrame:]):
(-[HistoryDelegate webView:didPerformClientRedirectFromURL:toURL:inFrame:]):
(-[HistoryDelegate webView:didPerformServerRedirectFromURL:toURL:inFrame:]):

LayoutTests:

* http/tests/globalhistory: Added.
* http/tests/globalhistory/history-delegate-basic-302-redirect-expected.txt: Added.
* http/tests/globalhistory/history-delegate-basic-302-redirect.html: Added.
* http/tests/globalhistory/history-delegate-basic-refresh-redirect-expected.txt: Added.
* http/tests/globalhistory/history-delegate-basic-refresh-redirect.html: Added.
* http/tests/resources/notify-done.html: Added.
* http/tests/resources/redirect.php: Augment to optionally do "Refresh:"-style redirects.

Skip these new tests on all platforms that don't have history delegates (yet):
* platform/gtk/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Yong Li <yong.li@torchmobile.com>
yong.li@torchmobile.com [Wed, 30 Sep 2009 01:07:29 +0000 (01:07 +0000)]
2009-09-29  Yong Li  <yong.li@torchmobile.com>

        Reviewed by Darin Adler.

        Add an ASSERT for UTF8Encoding().isValid()
        https://bugs.webkit.org/show_bug.cgi?id=29908

        * platform/text/TextEncoding.cpp:
        (WebCore::UTF8Encoding):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=29892
hyatt@apple.com [Wed, 30 Sep 2009 00:32:38 +0000 (00:32 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=29892
Add support for whitelist patterns to control conditional injection of user scripts and
user stylesheets.

Reviewed by Jon Honeycutt.

No new tests. Not testable until WebKit portion is added in followup patch.

* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/Document.cpp:
(WebCore::Document::pageGroupUserSheets):
* page/Frame.cpp:
(WebCore::Frame::injectUserScriptsForWorld):
* page/UserContentURLPattern.cpp: Added.
(WebCore::UserContentURLPattern::matchesPatterns):
(WebCore::UserContentURLPattern::parse):
(WebCore::UserContentURLPattern::matches):
(WebCore::UserContentURLPattern::matchesHost):
(WebCore::MatchTester::MatchTester):
(WebCore::MatchTester::testStringFinished):
(WebCore::MatchTester::patternStringFinished):
(WebCore::MatchTester::eatWildcard):
(WebCore::MatchTester::eatSameChars):
(WebCore::MatchTester::test):
(WebCore::UserContentURLPattern::matchesPath):
* page/UserContentURLPattern.h: Added.
(WebCore::UserContentURLPattern::UserContentURLPattern):
(WebCore::UserContentURLPattern::scheme):
(WebCore::UserContentURLPattern::host):
(WebCore::UserContentURLPattern::path):
(WebCore::UserContentURLPattern::matchSubdomains):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Tue, 29 Sep 2009 23:20:17 +0000 (23:20 +0000)]
2009-09-29  Daniel Bates  <dbates@webkit.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=29837

        More tests for the XSSAuditor.

        * http/tests/security/xssAuditor/embed-tag-javascript-url-expected.txt: Added.
        * http/tests/security/xssAuditor/embed-tag-javascript-url.html: Added.
        * http/tests/security/xssAuditor/meta-tag-http-refresh-javascript-url-expected.txt: Added.
        * http/tests/security/xssAuditor/meta-tag-http-refresh-javascript-url.html: Added.
        * http/tests/security/xssAuditor/object-tag-javascript-url-expected.txt: Added.
        * http/tests/security/xssAuditor/object-tag-javascript-url.html: Added.
        * http/tests/security/xssAuditor/property-escape-noquotes-expected.txt: Added.
        * http/tests/security/xssAuditor/property-escape-noquotes-tab-slash-chars-expected.txt: Added.
        * http/tests/security/xssAuditor/property-escape-noquotes-tab-slash-chars.html: Added.
        * http/tests/security/xssAuditor/property-escape-noquotes.html: Added.
        * http/tests/security/xssAuditor/property-inject-expected.txt: Added.
        * http/tests/security/xssAuditor/property-inject.html: Added.
        * http/tests/security/xssAuditor/resources/echo-head.pl: Added.
        * http/tests/security/xssAuditor/resources/echo-inner-tag.pl: Added.
        * http/tests/security/xssAuditor/resources/echo-property-noquotes.pl: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Enrica Casucci <enrica@apple.com>
eric@webkit.org [Tue, 29 Sep 2009 23:10:01 +0000 (23:10 +0000)]
2009-09-29  Enrica Casucci  <enrica@apple.com>

        Reviewed by Adele Peterson.

        Test case for <rdar://problem/7085453>.

        * editing/selection/blockquote-crash-expected.txt: Added.
        * editing/selection/blockquote-crash.html: Added.
2009-09-29  Enrica Casucci  <enrica@apple.com>

        Reviewed by Adele Peterson.

        Reproducible crash pressing return inside quoted content
        at WebCore::BreakBlockquoteCommand::doApply.
        <rdar://problem/7085453>
        In some case, like the one provided in the test case, m_downStreamEnd
        refers to a node that gets deleted when executing the DeleteSelectionCommand.
        We shouldn't use m_downStreamEnd to recalculate the new m_endPosition when
        pruning is needed, because it may be point to a node that has been deleted, but
        rather rely on removeNode in CompositeEditCommand to update m_endPosition correctly.

        Test: editing/selection/blockquote-crash.html

        * editing/BreakBlockquoteCommand.cpp:
        (WebCore::BreakBlockquoteCommand::doApply): Added check for invalid position
        to avoid dereferencing a null node pointer.
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::mergeParagraphs): Don't reset m_endPosition
        using the value in m_downStreamEnd when it is necessary to prune the start block.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Brady Eidson.
ap@apple.com [Tue, 29 Sep 2009 22:58:48 +0000 (22:58 +0000)]
    Reviewed by Brady Eidson.

        Basic authentication credentials are not sent automatically to top resources
        https://bugs.webkit.org/show_bug.cgi?id=29901

        No new tests - I don't want to pollute root directory of http tests to check for this rather
        minor issue.

        * platform/network/CredentialStorage.cpp:
        (WebCore::CredentialStorage::set): Changed to always preserve leading slash.
        (WebCore::CredentialStorage::getDefaultAuthenticationCredential): Made breaking out of the
        loop more explicit.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build fix.
bweinstein@apple.com [Tue, 29 Sep 2009 22:27:32 +0000 (22:27 +0000)]
Windows build fix.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 29 Sep 2009 22:10:06 +0000 (22:10 +0000)]
2009-09-29  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Oliver Hunt.

        Web Inspector REGRESSION(r47820-r47822): Profiles aren't
        added to the inspector unless the inspector is already open
        when the profile completes.

        https://bugs.webkit.org/show_bug.cgi?id=29897

        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype._populateProfiles):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubberstamped by David Hyatt.
kenneth@webkit.org [Tue, 29 Sep 2009 22:06:59 +0000 (22:06 +0000)]
Rubberstamped by David Hyatt.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-29
Fix to logic of earlier commit 48902.

When merging two if's before committing, I forgot to invert the
bool check.

* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::ignoreHttpError):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTidy up codeblock sampler
oliver@apple.com [Tue, 29 Sep 2009 21:48:52 +0000 (21:48 +0000)]
Tidy up codeblock sampler
https://bugs.webkit.org/show_bug.cgi?id=29836

Reviewed by Gavin Barraclough.

Some rather simple refactoring of codeblock sampler so that
it's easier for us to use it to find problems in non-jsc
environments

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, build fix.
senorblanco@chromium.org [Tue, 29 Sep 2009 21:43:57 +0000 (21:43 +0000)]
Unreviewed, build fix.

Fixing Chromium build, following r48884.

[https://bugs.webkit.org/show_bug.cgi?id=29894]

* bindings/v8/V8AbstractEventListener.cpp:
(WebCore::V8AbstractEventListener::handleEvent):
* bindings/v8/V8AbstractEventListener.h:
* bindings/v8/V8WorkerContextEventListener.cpp:
(WebCore::V8WorkerContextEventListener::handleEvent):
* bindings/v8/V8WorkerContextEventListener.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Kent Tamura <tkent@chromium.org>
eric@webkit.org [Tue, 29 Sep 2009 21:25:54 +0000 (21:25 +0000)]
2009-09-29  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Update for .maxLength behavior change.
        https://bugs.webkit.org/show_bug.cgi?id=29796

        * fast/forms/input-maxlength-expected.txt:
        * fast/forms/input-maxlength.html:
        * fast/forms/script-tests/textarea-maxlength.js:
        * fast/forms/textarea-maxlength-expected.txt:
2009-09-29  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Follows HTML5's maxLength change in September 2009.
        - Change HTMLTextAreaElement.maxLength type to signed.
        - HTMLTextAreaElement.maxLength returns -1 if maxlength= attribute is missing.
        - HTMLTextAreaElement.maxLength and HTMLInputElement.maxLength
          throw INDEX_SIZE_ERR for setting negative values.
        https://bugs.webkit.org/show_bug.cgi?id=29796

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::setMaxLength):
        * html/HTMLInputElement.h:
        * html/HTMLInputElement.idl:
        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::handleBeforeTextInsertedEvent):
        (WebCore::HTMLTextAreaElement::maxLength):
        (WebCore::HTMLTextAreaElement::setMaxLength):
        * html/HTMLTextAreaElement.h:
        * html/HTMLTextAreaElement.idl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDon't rely on QNetworkReply::NetworkError codes, but
kenneth@webkit.org [Tue, 29 Sep 2009 21:07:50 +0000 (21:07 +0000)]
Don't rely on QNetworkReply::NetworkError codes, but
on HTTP error codes instead.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-29
Reviewed by Simon Hausmann.

* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::ignoreHttpError):
(WebCore::QNetworkReplyHandler::finish):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUse const references when using Qt's foreach.
kenneth@webkit.org [Tue, 29 Sep 2009 21:07:26 +0000 (21:07 +0000)]
Use const references when using Qt's foreach.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-29
Reviewed by Simon Hausmann.

* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix handling of QNetworkReply errors.
kenneth@webkit.org [Tue, 29 Sep 2009 21:07:00 +0000 (21:07 +0000)]
Fix handling of QNetworkReply errors.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-29
Reviewed by Simon Hausmann.

In the QNetworkReplyHandler::finish() a response was sent even when
the reply contained an error. This resulted in a sendResponseIfNeeded()
calling didReceiveResponse on the client, leading to the destruction
of the m_resourceHandle, discontinuing further processing in finish(),
and thus not calling didFail on the client.

Instead it continued as everything went fine, and
FrameLoaderClientQt::dispatchDecidePolicyForMIMEType() changed the
policy to PolicyDownload due to not being able to show the non existing
MIMEType. As the download also obviously fails, it ended up with a
policy change error.

* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::finish):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Tue, 29 Sep 2009 21:01:39 +0000 (21:01 +0000)]
2009-09-29  Daniel Bates  <dbates@webkit.org>

        Reviewed by Adam Roben.

        https://bugs.webkit.org/show_bug.cgi?id=28902

        Fixes an issue where the drop effect returned by Window Dump Render Tree
        was always DROPEFFECT_NONE (since it was hard coded to do so).

        This patch corrects this issue by determining the actual drop effect
        performed by the corresponding drag-and-drop operation so that we can
        return it.

        * DumpRenderTree/win/DraggingInfo.h: Added field m_dropEffect to store performed drop effect.
        (DraggingInfo::DraggingInfo):
        (DraggingInfo::performedDropEffect): Added method.
        (DraggingInfo::setPerformedDropEffect): Added method.
        * DumpRenderTree/win/EventSender.cpp:
        (doMouseUp): Calls method DraggingInfo::setPerformedDropEffect with performed drop effect.
        Moved delete draggingInfo to UIDelegate::doDragDrop.
        * DumpRenderTree/win/UIDelegate.cpp:
        (UIDelegate::doDragDrop): Sets performedDropEffect to DraggingInfo::performedDropEffect().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Tue, 29 Sep 2009 20:48:16 +0000 (20:48 +0000)]
2009-09-29  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Dimitri Glazkov.

        Add GYP generated files to svn:ignore
        https://bugs.webkit.org/show_bug.cgi?id=29895

        The following files are generated by JavaScriptCore's GYP file and should be ignored:

        pcre.mk
        wtf.scons
        wtf.mk
        SConstruct
        wtf_config.scons
        wtf_config.mk
        pcre.scons

        * JavaScriptCore.gyp: Changed property svn:ignore.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Tue, 29 Sep 2009 20:42:27 +0000 (20:42 +0000)]
2009-09-29  Dimitri Glazkov  <dglazkov@chromium.org>

        No review, rolling out r48894, because review discussion was not complete.
        http://trac.webkit.org/changeset/48894

        * platform/sql/SQLiteTransaction.cpp:
        (WebCore::SQLiteTransaction::begin):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Tue, 29 Sep 2009 20:29:30 +0000 (20:29 +0000)]
2009-09-29  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG Filter feComposite implementation is missing
        [https://bugs.webkit.org/show_bug.cgi?id=28362]

        feComposite implementation for SVG.

        Test: svg/filters/feComposite.svg

        * platform/graphics/filters/FEComposite.cpp:
        (WebCore::arithmetic):
        (WebCore::FEComposite::apply):

        Tests the feComposite implementation for SVG.

        * platform/mac/svg/filters/feComposite-expected.checksum: Added.
        * platform/mac/svg/filters/feComposite-expected.png: Added.
        * platform/mac/svg/filters/feComposite-expected.txt: Added.
        * svg/filters/feComposite.svg: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoStandardized an optimization for adding non-numbers.
ggaren@apple.com [Tue, 29 Sep 2009 20:28:00 +0000 (20:28 +0000)]
Standardized an optimization for adding non-numbers.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-29
Reviewed by Sam Weinig.

SunSpider says maybe a tiny speedup.

* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_add):
(JSC::JIT::emitSlow_op_add):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Dumitru Daniliuc <dumi@chromium.org>
eric@webkit.org [Tue, 29 Sep 2009 20:05:11 +0000 (20:05 +0000)]
2009-09-29  Dumitru Daniliuc  <dumi@chromium.org>

        Reviewed by Dimitri Glazkov.

        Starting all read-only transactions with an explicit BEGIN
        DEFERRED command instead of BEGIN, since some ports (chromium)
        might compile their own SQLite library and set BEGIN to BEGIN
        IMMEDIATE by default; which would result in a deadlock in case of
        two concurrent read-only transactions on the same DB, and would
        unnecessarily delay other potential transactions to the same DB.

        https://bugs.webkit.org/show_bug.cgi?id=29729

        * platform/sql/SQLiteTransaction.cpp:
        (WebCore::SQLiteTransaction::begin):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore:
dglazkov@chromium.org [Tue, 29 Sep 2009 19:49:13 +0000 (19:49 +0000)]
WebCore:

2009-09-29  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        Add support for run-time flag for 3D canvas
        https://bugs.webkit.org/show_bug.cgi?id=29826

        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::getContext): Check page settings for
        experimental WebGL flag before returning 3D graphics context.
        * page/Settings.cpp:
        (WebCore::Settings::Settings): Initialize new flag to false.
        (WebCore::Settings::setExperimentalWebGLEnabled):
        * page/Settings.h: Set new flag.
        (WebCore::Settings::experimentalWebGLEnabled): Return new flag.

WebKit/mac:

2009-09-29  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        Add support for run-time flag for 3D canvas
        https://bugs.webkit.org/show_bug.cgi?id=29826

        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]): Enable experimental
        WebGL flag when 3D_CANVAS is enabled in the build.

WebKit/win:

2009-09-29  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        Add support for run-time flag for 3D canvas
        https://bugs.webkit.org/show_bug.cgi?id=29826

        * WebView.cpp:
        (WebView::notifyPreferencesChanged): Enable experimental WebGL
        flag when 3D_CANVAS is enabled in the build.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Tue, 29 Sep 2009 19:39:42 +0000 (19:39 +0000)]
2009-09-29  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Fisher.

        Chromium needs to be able to override the way storage events are delivered - part 1
        https://bugs.webkit.org/show_bug.cgi?id=29889

        Chromium needs to be able to override the way storage events are delivered.
        This replaced https://bugs.webkit.org/show_bug.cgi?id=29257 because it'll be
        faster (no vtables and extra allocation) and somewhat cleaner (no dependency
        injection).  This is necessary because Chromium needs to transport events across
        a process barrier and then dispatch them without use of a Frame*.

        This patch should be a no-op for all ports other than Chromium.

        * WebCore.gypi:
        * storage/StorageEventDispatcher.h: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Shinichiro Hamaji <hamaji@chromium.org>
eric@webkit.org [Tue, 29 Sep 2009 19:15:13 +0000 (19:15 +0000)]
2009-09-29  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by David Kilzer.

        Change remaining references in tests from bugzilla.opendarwin.org to bugs.webkit.org
        https://bugs.webkit.org/show_bug.cgi?id=12140

        Change the URLs in dumpAsText tests.

        * editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
        * editing/deleting/delete-all-text-in-text-field-assertion.html:
        * fast/dom/Document/doc-open-while-parsing.html:
        * fast/dom/Document/document-reopen.html:
        * fast/dom/Element/setAttribute-case-insensitivity.html:
        * fast/dom/HTMLHeadElement/head-check.html:
        * fast/dom/HTMLImageElement/image-without-renderer-width-expected.txt:
        * fast/dom/HTMLImageElement/image-without-renderer-width.html:
        * fast/dom/HTMLScriptElement/script-load-events-expected.txt:
        * fast/dom/HTMLScriptElement/script-load-events.html:
        * fast/dom/clone-node-form-elements-with-attr.html:
        * fast/dom/document-dir-property-expected.txt:
        * fast/dom/document-dir-property.html:
        * fast/dom/everything-to-string.html:
        * fast/dom/generic-form-element-assert-expected.txt:
        * fast/dom/generic-form-element-assert.html:
        * fast/dom/inner-text-rtl-expected.txt:
        * fast/dom/inner-text-rtl.html:
        * fast/dom/navigator-vendorSub.html:
        * fast/dom/option-properties-expected.txt:
        * fast/dom/option-properties.html:
        * fast/dom/replace-child-siblings-expected.txt:
        * fast/dom/replace-child-siblings.html:
        * fast/dom/replace-first-child.html:
        * fast/dom/setAttribute-using-initial-input-value.html:
        * fast/dom/space-to-text.html:
        * fast/dynamic/hovered-detach-expected.txt:
        * fast/dynamic/hovered-detach.html:
        * fast/encoding/charset-koi8-u.html:
        * fast/encoding/css-charset-dom.html:
        * fast/encoding/css-charset-evil.html:
        * fast/encoding/css-charset.html:
        * fast/encoding/latin1-winlatin.html:
        * fast/encoding/mispositioned-meta.html:
        * fast/encoding/percent-escaping.html:
        * fast/encoding/pseudo-xml-2.html:
        * fast/encoding/pseudo-xml-3.html:
        * fast/encoding/pseudo-xml-4.html:
        * fast/encoding/pseudo-xml.html:
        * fast/events/init-event-null-view.html:
        * fast/events/mouseover-mouseout.html:
        * fast/events/mouseover-mouseout2.html:
        * fast/events/onload-webkit-before-webcore.html:
        * fast/forms/button-in-forms-collection.html:
        * fast/forms/document-write.html:
        * fast/forms/domstring-replace-crash-expected.txt:
        * fast/forms/domstring-replace-crash.html:
        * fast/forms/element-by-name.html:
        * fast/forms/empty-get.html:
        * fast/forms/form-data-encoding-normalization-overrun.html:
        * fast/forms/radio-button-no-change-event.html:
        * fast/forms/selected-index-assert-expected.txt:
        * fast/forms/selected-index-assert.html:
        * fast/forms/textarea-hard-linewrap-empty-expected.txt:
        * fast/forms/textarea-hard-linewrap-empty.html:
        * fast/forms/textfield-focus-out-expected.txt:
        * fast/forms/textfield-focus-out.html:
        * fast/frames/empty-frame-document-expected.txt:
        * fast/frames/empty-frame-document.html:
        * fast/frames/frame-name-reset.html:
        * fast/frames/frame-set-same-location.html:
        * fast/frames/frame-set-same-src.html:
        * fast/frames/frameElement-widthheight.html:
        * fast/frames/iframe-name-and-id-expected.txt:
        * fast/frames/iframe-name-and-id.html:
        * fast/frames/iframe-set-same-location.html:
        * fast/frames/iframe-set-same-src.html:
        * fast/frames/repaint-display-none-crash-expected.txt:
        * fast/frames/repaint-display-none-crash.html:
        * fast/js/exception-linenums-in-html-2.html:
        * fast/js/missing-title-end-tag-js.html:
        * fast/loader/link-no-URL.html:
        * fast/loader/url-strip-cr-lf-tab.html:
        * fast/overflow/generated-content-crash-expected.txt:
        * fast/overflow/generated-content-crash.html:
        * fast/parser/number-sign-in-map-name.html:
        * fast/parser/remove-current-node-parent.html:
        * fast/parser/script-after-frameset-assert.html:
        * fast/tokenizer/image-empty-crash-expected.txt:
        * fast/tokenizer/image-empty-crash.html:
        * fast/tokenizer/nested-cached-scripts-expected.txt:
        * fast/tokenizer/nested-cached-scripts.html:
        * fast/tokenizer/write-unclosed-script-expected.txt:
        * fast/tokenizer/write-unclosed-script.html:
        * fast/xsl/transformToFragment-XML-declaration.html:
        * http/tests/misc/text-refresh.html:
        * http/tests/plugins/npapi-response-headers.html:
        * http/tests/uri/utf8-path.html:
        * http/tests/xmlhttprequest/cache-override.html:
        * http/tests/xmlhttprequest/event-listener-gc-expected.txt:
        * http/tests/xmlhttprequest/event-listener-gc.html:
        * http/tests/xmlhttprequest/event-target.html:
        * http/tests/xmlhttprequest/frame-load-cancelled-abort.html:
        * http/tests/xmlhttprequest/interactive-state.html:
        * http/tests/xmlhttprequest/methods-async.html:
        * http/tests/xmlhttprequest/methods-lower-case.html:
        * http/tests/xmlhttprequest/methods.html:
        * http/tests/xmlhttprequest/post-content-type.html:
        * http/tests/xmlhttprequest/readystatechange.html:
        * http/tests/xmlhttprequest/supported-xml-content-types.html:
        * http/tests/xmlhttprequest/xhr-onunload.html:
        * http/tests/xmlhttprequest/zero-length-response.html:
        * platform/mac/fast/events/objc-event-api.html:
        * platform/mac/fast/events/objc-keyboard-event-creation.html:
        * plugins/get-empty-url.html:
        * plugins/geturl-replace-query.html:
        * plugins/invoke.html:
        * plugins/mouse-events.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdding file missed in previous commit.
oliver@apple.com [Tue, 29 Sep 2009 19:01:58 +0000 (19:01 +0000)]
Adding file missed in previous commit.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Tue, 29 Sep 2009 18:51:22 +0000 (18:51 +0000)]
2009-09-29  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Fisher.

        [V8] Correct an issue with XMLHttpRequest attribute event listeners never being cleared.
        https://bugs.webkit.org/show_bug.cgi?id=29888

        Test: LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-abort-readyState-shouldDispatchEvent.html

        * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
        (WebCore::getEventListener): Added isAttribute parameter.
        (WebCore::ACCESSOR_SETTER): Made all event listener setters create attribute listeners.
        (WebCore::CALLBACK_FUNC_DECL): Made addEventListener create object listener.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] REGRESSION: BitmapImage::getGdkPixbuf fails for non-square images
oliver@apple.com [Tue, 29 Sep 2009 18:40:51 +0000 (18:40 +0000)]
[GTK] REGRESSION: BitmapImage::getGdkPixbuf fails for non-square images
https://bugs.webkit.org/show_bug.cgi?id=29654

Patch by Martin Robinson  <martin.james.robinson@gmail.com>
Reviewed by Eric Seidel

Added an additional manual-test for this issue to the existing Gtk
cursor image test.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Timothy Hatcher.
ap@apple.com [Tue, 29 Sep 2009 18:39:43 +0000 (18:39 +0000)]
    Reviewed by Timothy Hatcher.

        Build fix - pass a proper ScriptExecutipnContext to getEventListenerHandlerBody()

        * bindings/js/ScriptEventListener.cpp:
        (WebCore::getEventListenerHandlerBody):
        * bindings/js/ScriptEventListener.h:
        * bindings/v8/ScriptEventListener.cpp:
        (WebCore::getEventListenerHandlerBody):
        * bindings/v8/ScriptEventListener.h:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::buildObjectForEventListener):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Tue, 29 Sep 2009 18:37:36 +0000 (18:37 +0000)]
2009-09-29  Nate Chapin  <japhet@chromium.org>

        Reviewed by Eric Seidel.

        Ensure that we don't scroll lock to an anchor node after a
        user-initiated scroll, even if that scroll doesn't propagate
        all the way up to FrameView.

        Test: fast/events/node-event-anchor-lock.html

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build fix: export a new symbol.
ggaren@apple.com [Tue, 29 Sep 2009 18:12:33 +0000 (18:12 +0000)]
Windows build fix: export a new symbol.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-29
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Darin Adler and Sam Weinig.
ap@apple.com [Tue, 29 Sep 2009 18:05:08 +0000 (18:05 +0000)]
    Reviewed by Darin Adler and Sam Weinig.

        Onclick not fired for an element copied with cloneContents() or cloneNode()
        https://bugs.webkit.org/show_bug.cgi?id=25130

        The change here is that JS event listeners don't keep a reference to a global object from
        where they were created, and instead take it as a parameter when parsing source code. Also,
        the listener creation won't fail just because it happens for an element in a frameless
        document.
        Thus, moving nodes between documents no longer results in having incorrect registered
        lazy event listeners on them.

        Tests: fast/events/attribute-listener-cloned-from-frameless-doc-context-2.html
               fast/events/attribute-listener-cloned-from-frameless-doc-context.html
               fast/events/attribute-listener-cloned-from-frameless-doc.xhtml
               fast/events/attribute-listener-extracted-from-frameless-doc-context-2.html
               fast/events/attribute-listener-extracted-from-frameless-doc-context.html

        * bindings/js/JSEventListener.cpp:
        (WebCore::JSEventListener::JSEventListener): Don't take a reference to JSDOMGlobalObject.
        (WebCore::JSEventListener::jsFunction): Take ScriptExecutionContext as a parameter for
        getting to JSDOMGlobalObject. It's not used in base class, but is in JSLazyEventListner.
        (WebCore::JSEventListener::markJSFunction): Don't mark the global object.
        (WebCore::JSEventListener::handleEvent): Get global object from ScriptExecutionContext.
        (WebCore::JSEventListener::reportError): Ditto.

        * bindings/js/JSEventListener.h: (WebCore::JSEventListener::create): Don't keep a reference
        to JSDOMGlobalObject.

        * bindings/js/JSLazyEventListener.cpp: (WebCore::JSLazyEventListener::parseCode): Listener
        creation was split between this function and ScriptEventListener; moved it here, as JS
        global object can be different now.

        * bindings/js/JSLazyEventListener.h: (WebCore::JSLazyEventListener::create): Keep source URL,
        which can not be determined at parsing time.

        * bindings/js/ScriptEventListener.cpp: (WebCore::createAttributeEventListener): Moved code
        for listener creation to JSLazyEventListener. XSSAuditor code remains here, because tests
        expect that errors are logged at document parsing time, and because I don't know what other
        side effects moving it vould have.

        * dom/EventListener.h: handleEvent() and reportError() now take ScriptExecutionContext,
        because JSC needs a global context here.

        * bindings/js/JSAbstractWorkerCustom.cpp:
        (WebCore::JSAbstractWorker::addEventListener):
        (WebCore::JSAbstractWorker::removeEventListener):
        * bindings/js/JSDOMApplicationCacheCustom.cpp:
        (WebCore::JSDOMApplicationCache::addEventListener):
        (WebCore::JSDOMApplicationCache::removeEventListener):
        * bindings/js/JSDOMGlobalObject.cpp:
        (WebCore::JSDOMGlobalObject::createJSAttributeEventListener):
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::addEventListener):
        (WebCore::JSDOMWindow::removeEventListener):
        * bindings/js/JSEventSourceCustom.cpp:
        (WebCore::JSEventSource::addEventListener):
        (WebCore::JSEventSource::removeEventListener):
        * bindings/js/JSMessagePortCustom.cpp:
        (WebCore::JSMessagePort::addEventListener):
        (WebCore::JSMessagePort::removeEventListener):
        * bindings/js/JSNodeCustom.cpp:
        (WebCore::JSNode::addEventListener):
        (WebCore::JSNode::removeEventListener):
        * bindings/js/JSSVGElementInstanceCustom.cpp:
        (WebCore::JSSVGElementInstance::addEventListener):
        (WebCore::JSSVGElementInstance::removeEventListener):
        * bindings/js/JSWorkerContextCustom.cpp:
        (WebCore::JSWorkerContext::addEventListener):
        (WebCore::JSWorkerContext::removeEventListener):
        * bindings/js/JSXMLHttpRequestCustom.cpp:
        (WebCore::JSXMLHttpRequest::addEventListener):
        (WebCore::JSXMLHttpRequest::removeEventListener):
        * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
        (WebCore::JSXMLHttpRequestUpload::addEventListener):
        (WebCore::JSXMLHttpRequestUpload::removeEventListener):
        * bindings/objc/ObjCEventListener.h:
        * bindings/objc/ObjCEventListener.mm:
        (WebCore::ObjCEventListener::handleEvent):
        * bindings/scripts/CodeGeneratorJS.pm:
        * dom/EventTarget.cpp:
        (WebCore::EventTarget::fireEventListeners):
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::handleEvent):
        * inspector/InspectorDOMAgent.h:
        * inspector/InspectorDOMStorageResource.cpp:
        (WebCore::InspectorDOMStorageResource::handleEvent):
        * inspector/InspectorDOMStorageResource.h:
        * loader/ImageDocument.cpp:
        (WebCore::ImageEventListener::handleEvent):
        * svg/animation/SVGSMILElement.cpp:
        (WebCore::ConditionEventListener::handleEvent):
        * workers/WorkerContext.cpp:
        (WebCore::WorkerContext::reportException):
        Don't pass global object to JSEventListener::create(), which no longer needs it.
        Note that some of these functions still have an early return for null global object, which
        can probably be removed in a later patch.
        Pass ScriptExecutionContext to EventListener methods that now need it.

        * bindings/scripts/CodeGeneratorCOM.pm: Don't force EventTarget implementation on Node -
        it doesn't work yet (it didn't quite work before this patch, too, because it assumed that
        any object implementing EventTarget COM interface originated from WebCore).

        * dom/EventListener.idl: Just like in ObjC, EventListener should be a pure interface in
        COM bindings.

WebKit/win:
        * DOMCreateInstance.cpp: GEN_DOMEventListener is a pure interface now.

        * WebKit.vcproj/WebKit.vcproj: Removed GEN_DOMEventListener.cpp.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemoved virtual destructor from JSGlobalObjectData to eliminate pointer
ggaren@apple.com [Tue, 29 Sep 2009 17:54:39 +0000 (17:54 +0000)]
Removed virtual destructor from JSGlobalObjectData to eliminate pointer
fix-ups when accessing JSGlobalObject::d.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-28
Reviewed by Sam Weinig.

JavaScriptCore:

Replaced with an explicit destructor function pointer.

6% speedup on bench-alloc-nonretained.js.

* JavaScriptCore.exp:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::~JSGlobalObject):
(JSC::JSGlobalObject::destroyJSGlobalObjectData):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData):
(JSC::JSGlobalObject::JSGlobalObject):

JavaScriptGlue:

Replaced with an explicit destructor function pointer.

* JSRun.cpp:
(JSGlueGlobalObject::destroyData):
* JSRun.h:
(JSGlueGlobalObject::Data::Data):

WebCore:

Replaced with an explicit destructor function pointer.

* bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::destroyJSDOMGlobalObjectData):
* bindings/js/JSDOMGlobalObject.h:
(WebCore::JSDOMGlobalObject::JSDOMGlobalObjectData::JSDOMGlobalObjectData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoThe code for showing error pages when the response was
kenneth@webkit.org [Tue, 29 Sep 2009 17:44:37 +0000 (17:44 +0000)]
The code for showing error pages when the response was
a 401/403/404, was not actually doing so. This patch
fixes that.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-29
Reviewed by Simon Hausmann.

* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::finish):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove copying of unnecessary or nonexistent files from the ImageDiff
mitz@apple.com [Tue, 29 Sep 2009 16:43:55 +0000 (16:43 +0000)]
Remove copying of unnecessary or nonexistent files from the ImageDiff
post-build event.

Reviewed by Adam Roben.

* DumpRenderTree/win/ImageDiff.vcproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
eric@webkit.org [Tue, 29 Sep 2009 16:19:09 +0000 (16:19 +0000)]
2009-09-29  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>

        Reviewed by David Kilzer.

        [Qt] Make build-webkit script work on Windows
        https://bugs.webkit.org/show_bug.cgi?id=29802

        * Scripts/run-webkit-tests:
        * Scripts/webkitdirs.pm:
         - Removed unnecessary -p switch for mkdir on Windows.
         - Use canonical path, which uses slashes or backslashes depends on platform.
         - isWindows() only test for Windows and not for Cyqwin.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Brady Eidson.
ap@apple.com [Tue, 29 Sep 2009 16:19:03 +0000 (16:19 +0000)]
    Reviewed by Brady Eidson.

        <rdar://problem/7259965> REGRESSION: http/tests/xmlhttprequest/cross-origin-authorization.html
        is failing/crashing intermittently
        https://bugs.webkit.org/show_bug.cgi?id=29322

        This was caused by CStringBuffer::encodeBase64() returning a buffer that wasn't zero terminated.
        The code had other issues as well, so I removed it altogether:
        - it claimed to avoid some buffer copies, but it didn't;
        - and I don't think that base64 encoding should be part of CString interface.

WebCore:
        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::encodeBasicAuthorization): Encode username and password using Base64.h directly.
        (WebCore::ResourceHandle::start): Use encodeBasicAuthorization().
        (+[WebCoreSynchronousLoader loadRequest:allowStoredCredentials:returningResponse:error:]): Ditto.
        (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]): Extended logging
        to synchronous case.
        (-[WebCoreSynchronousLoader connectionShouldUseCredentialStorage:]): Ditto.
        (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): Ditto.
        (-[WebCoreSynchronousLoader connection:didReceiveResponse:]): Ditto.
        (-[WebCoreSynchronousLoader connection:didReceiveData:]): Ditto.
        (-[WebCoreSynchronousLoader connectionDidFinishLoading:]): Ditto.
        (-[WebCoreSynchronousLoader connection:didFailWithError:]): Ditto.

        * platform/network/cf/ResourceHandleCFNet.cpp: Matched Mac changes.

        * platform/text/CString.cpp:
        * platform/text/CString.h:
        (WebCore::CStringBuffer::create):
        (WebCore::CStringBuffer::CStringBuffer):
        Removed code that was added for Base64 in r48363.

LayoutTests:
        * http/tests/xmlhttprequest/cross-origin-authorization.html: While at it, made the test
        detect more error conditions

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Janne Koskinen <janne.p.koskinen@digia.com>
eric@webkit.org [Tue, 29 Sep 2009 16:10:02 +0000 (16:10 +0000)]
2009-09-29  Janne Koskinen  <janne.p.koskinen@digia.com>

        Reviewed by David Kilzer.

        [Qt] Assert messages prints visible in Symbian
        https://bugs.webkit.org/show_bug.cgi?id=29808

        Asserts use vprintf to print the messages to stderr.
        In Symbian Open C it is not possible to see stderr so
        I routed the messages to stdout instead.

        * wtf/Assertions.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 29 Sep 2009 15:18:56 +0000 (15:18 +0000)]
2009-09-29  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Do not set a non-default parent window for child widgets. We are
        just doing the same than the default path does, and on top of that
        if the widget's window changes (for example, during DnD widgets
        are usually unrealized/realized) the child widget will we left
        pointing to a dead window.

        For examples of crashers caused by this see
        https://bugzilla.gnome.org/show_bug.cgi?id=596397 and
        https://bugzilla.gnome.org/show_bug.cgi?id=596398

        * webkit/webkitwebview.cpp:
        (webkit_web_view_container_add):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
eric@webkit.org [Tue, 29 Sep 2009 15:00:48 +0000 (15:00 +0000)]
2009-09-29  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>

        Reviewed by Simon Hausmann.

        Fix typo in Localizations.cpp

        https://bugs.webkit.org/show_bug.cgi?id=29872

        * platform/qt/Localizations.cpp:
        (WebCore::localizedMediaControlElementHelpText):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake the XSLT conditional in DOMWindow.idl's xsltProcessor
hausmann@webkit.org [Tue, 29 Sep 2009 14:45:12 +0000 (14:45 +0000)]
Make the XSLT conditional in DOMWindow.idl's xsltProcessor
attribute conditional in the generated files, similar to
r44116.

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-09-29
Reviewed by Tor Arne Vestbø.

* page/DOMWindow.idl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Andras Becsi <becsi.andras@stud.u-szeged.hu>
zoltan@webkit.org [Tue, 29 Sep 2009 14:40:10 +0000 (14:40 +0000)]
2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>

        Reviewed by Simon Hausmann.

        Fix time measurement in build-webkit after refactoring done in r48853.

        * Scripts/build-webkit:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Default font size reconciliation to 16px/13px to match other platform's de-facto...
vestbo@webkit.org [Tue, 29 Sep 2009 14:25:21 +0000 (14:25 +0000)]
[Qt] Default font size reconciliation to 16px/13px to match other platform's de-facto standard.

This fixes https://bugs.webkit.org/show_bug.cgi?id=19674.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-09-29
Reviewed by Tor Arne Vestbø.

Done together with Renata Hodovan <renata.hodovan@stud.u-szeged.hu>

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=29844
hausmann@webkit.org [Tue, 29 Sep 2009 14:06:36 +0000 (14:06 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=29844

Patch by Jedrzej Nowacki <jedrzej.nowacki@nokia.com> on 2009-09-29
Reviewed by Simon Hausmann.

QWebPage dependency autotest fix.

Fix for database() autotest. All opened databases should be removed at
end of test.

* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::database):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSome QWebHistory and QWebPage autotest crash fixes.
hausmann@webkit.org [Tue, 29 Sep 2009 14:06:27 +0000 (14:06 +0000)]
Some QWebHistory and QWebPage autotest crash fixes.

Patch by Jedrzej Nowacki <jedrzej.nowacki@nokia.com> on 2009-09-29
Reviewed by Simon Hausmann.

Some checking for m_mainFrame were added. MainFrame should be created
at some point of QWebPage live cicle.

https://bugs.webkit.org/show_bug.cgi?id=29803

* Api/qwebpage.cpp:
(QWebPage::~QWebPage):
(QWebPage::currentFrame):
(QWebPage::history):
(QWebPage::selectedText):
(QWebPage::updatePositionDependentActions):
* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::crashTests_LazyInitializationOfMainFrame):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Use the ResourceError as it is supposed to and handle
kenneth@webkit.org [Tue, 29 Sep 2009 13:55:34 +0000 (13:55 +0000)]
WebCore: Use the ResourceError as it is supposed to and handle
not HTTP errors from QNetworkReply.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-29
Reviewed by Simon Hausmann.

Thanks to Adam Roben for his input.

* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::finish):

WebKit/qt: Implement QWebPage Extension for error pages, incl.
an example on how to use it in QtLauncher.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-29
Reviewed by Simon Hausmann.

Correct our use of ResourceError.

* Api/qwebpage.h:
(ExtensionOption::):
(ExtensionOption::ErrorPageExtensionReturn::ErrorPageExtensionReturn):
* QtLauncher/main.cpp:
(WebPage::supportsExtension):
(MainWindow::MainWindow):
(MainWindow::selectElements):
(WebPage::extension):
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::cancelledError):
(WebCore::FrameLoaderClientQt::blockedError):
(WebCore::FrameLoaderClientQt::cannotShowURLError):
(WebCore::FrameLoaderClientQt::interruptForPolicyChangeError):
(WebCore::FrameLoaderClientQt::cannotShowMIMETypeError):
(WebCore::FrameLoaderClientQt::fileDoesNotExistError):
(WebCore::FrameLoaderClientQt::callErrorPageExtension):
(WebCore::FrameLoaderClientQt::dispatchDidFailProvisionalLoad):
(WebCore::FrameLoaderClientQt::dispatchDidFailLoad):
* WebCoreSupport/FrameLoaderClientQt.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Janne Koskinen <janne.p.koskinen@digia.com>
eric@webkit.org [Tue, 29 Sep 2009 12:20:23 +0000 (12:20 +0000)]
2009-09-29  Janne Koskinen  <janne.p.koskinen@digia.com>

        Reviewed by Darin Adler.

        [Qt] Symbian CRASH macro implementation

        Added Symbian specific crash macro that
        stops to crash line if JIT debugging is used.
        Additional differentiation of access violation
        (KERN-EXEC 3) and CRASH panic.

        * wtf/Assertions.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Andras Becsi <becsi.andras@stud.u-szeged.hu>
zoltan@webkit.org [Tue, 29 Sep 2009 11:43:30 +0000 (11:43 +0000)]
2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>

        Reviewed by Simon Hausmann.

        [Qt] Update Skipped list after test refactoring done in r48806.

        * platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Jakub Wieczorek <faw217@gmail.com>
eric@webkit.org [Tue, 29 Sep 2009 09:56:14 +0000 (09:56 +0000)]
2009-09-29  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Simon Hausmann.

        [Qt] Unskip the passing tests that make use of eventSender.contextClick().
        https://bugs.webkit.org/show_bug.cgi?id=29821

        * platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 29 Sep 2009 09:53:24 +0000 (09:53 +0000)]
2009-09-29  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Encapsulate JS listeners specifics into ScriptEventListener.

        https://bugs.webkit.org/show_bug.cgi?id=29816

        * bindings/js/ScriptEventListener.cpp:
        (WebCore::getEventListenerHandlerBody):
        * bindings/js/ScriptEventListener.h:
        * bindings/v8/ScriptEventListener.cpp:
        (WebCore::getEventListenerHandlerBody):
        * bindings/v8/ScriptEventListener.h:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::buildObjectForEventListener):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 29 Sep 2009 09:48:56 +0000 (09:48 +0000)]
2009-09-29  Xan Lopez  <xlopez@igalia.com>

        Unreviewed attempt to fix the build.

        * page/Settings.cpp:
        (WebCore::Settings::Settings):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Jakub Wieczorek <faw217@gmail.com>
eric@webkit.org [Tue, 29 Sep 2009 09:48:55 +0000 (09:48 +0000)]
2009-09-29  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Simon Hausmann.

        [Qt] Implement eventSender.contextClick().
        https://bugs.webkit.org/show_bug.cgi?id=29821

        * DumpRenderTree/qt/jsobjects.cpp:
        (EventSender::contextClick):
        * DumpRenderTree/qt/jsobjects.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-29 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Tue, 29 Sep 2009 08:57:01 +0000 (08:57 +0000)]
2009-09-29  Fumitoshi Ukai  <ukai@chromium.org>

        Unreviewed.  Fix 4 layout test failures by webkit r48861.
        http://bugs.webkit.org/show_bug.cgi?id=29840

        r48861 introduced experimentalWebSocketsEnabled, and false by default.
        When experimentalWebSocketsEnabled is false, window.WebSocket is
        undefined, instead of a constructor.

        * fast/dom/Window/window-properties-expected.txt:
        * fast/dom/prototype-inheritance-2-expected.txt:
        * fast/dom/prototype-inheritance-expected.txt:
        * fast/js/global-constructors-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix the build by fixing a typo.
bweinstein@apple.com [Tue, 29 Sep 2009 07:22:11 +0000 (07:22 +0000)]
Fix the build by fixing a typo.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-28 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Tue, 29 Sep 2009 07:02:18 +0000 (07:02 +0000)]
2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Eric Seidel.

        Add experimentalWebSocketsEnabled in Settings.
        https://bugs.webkit.org/show_bug.cgi?id=28941

        * WebCore.base.exp:
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::webSocket):
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::getConstructor):
        * bindings/v8/custom/V8WebSocketCustom.cpp:
        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        (WebCore::Settings::setExperimentalWebSocketsEnabled):
        * page/Settings.h:
        (WebCore::Settings::experimentalWebSocketsEnabled):

2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Eric Seidel.

        Add experimentalWebSocketsEnabled in WebPreferences.
        https://bugs.webkit.org/show_bug.cgi?id=28941

        * WebView/WebPreferenceKeysPrivate.h:
        * WebView/WebPreferences.mm:
        (+[WebPreferences initialize]):
        (-[WebPreferences experimentalWebSocketsEnabled]):
        (-[WebPreferences setExperimentalWebSocketsEnabled:]):
        * WebView/WebPreferencesPrivate.h:
        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]):

2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Eric Seidel.

        Add experimentalWebSocketsEnabled in WebPreferences.
        https://bugs.webkit.org/show_bug.cgi?id=28941

        * Interfaces/IWebPreferencesPrivate.idl:
        * WebPreferenceKeysPrivate.h:
        * WebPreferences.cpp:
        (WebPreferences::initializeDefaultSettings):
        (WebPreferences::setExperimentalWebSocketsEnabled):
        (WebPreferences::experimentalWebSocketsEnabled):
        * WebPreferences.h:
        * WebView.cpp:
        (WebView::notifyPreferencesChanged):
        (core):

2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Eric Seidel.

        Add experimentalWebSocketsEnabled in WebPreferences.
        https://bugs.webkit.org/show_bug.cgi?id=28941

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (resetDefaultsToConsistentValues):
        * DumpRenderTree/win/DumpRenderTree.cpp:
        (resetDefaultsToConsistentValues):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix the PowerPC build.
mrowe@apple.com [Tue, 29 Sep 2009 05:51:58 +0000 (05:51 +0000)]
Fix the PowerPC build.

* JavaScriptCore.exp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-11 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Tue, 29 Sep 2009 05:42:58 +0000 (05:42 +0000)]
2009-09-11  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Adam Barth.

        Add platform code to support WebSocket for chromium.
        https://bugs.webkit.org/show_bug.cgi?id=29171

        To build within chromium tree, it requires a patch in bug 29174.
        Real implementation will be landed in chromium tree.

        * WebCore.gypi:
        * platform/network/chromium/SocketStreamError.h: Added.
        (WebCore::SocketStreamError::SocketStreamError):
        * platform/network/chromium/SocketStreamHandle.h: Added.
        (WebCore::SocketStreamHandle::create):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48859 268f45cc-cd09-0410-ab3c-d52691b4dbfc