From: mjs@apple.com Date: Fri, 17 Oct 2008 22:26:44 +0000 (+0000) Subject: 2008-10-17 Maciej Stachowiak X-Git-Url: https://git.webkit.org/?p=WebKit.git;a=commitdiff_plain;h=6e72e89585552905451892b68f7de57c47278206 2008-10-17 Maciej Stachowiak Reviewed by Cameron Zwarich - don't bother to do arguments tearoff when it will have no effect ~1% on v8 raytrace * VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitReturn): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37664 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- diff --git a/JavaScriptCore/ChangeLog b/JavaScriptCore/ChangeLog index 58b612fe95b1..330e71704b5f 100644 --- a/JavaScriptCore/ChangeLog +++ b/JavaScriptCore/ChangeLog @@ -1,3 +1,14 @@ +2008-10-17 Maciej Stachowiak + + Reviewed by Cameron Zwarich + + - don't bother to do arguments tearoff when it will have no effect + + ~1% on v8 raytrace + + * VM/CodeGenerator.cpp: + (JSC::CodeGenerator::emitReturn): + 2008-10-17 Marco Barisione Reviewed by Sam Weinig. Landed by Jan Alonzo. diff --git a/JavaScriptCore/VM/CodeGenerator.cpp b/JavaScriptCore/VM/CodeGenerator.cpp index 0f7b5370e111..4cfa7d78bde1 100644 --- a/JavaScriptCore/VM/CodeGenerator.cpp +++ b/JavaScriptCore/VM/CodeGenerator.cpp @@ -1168,7 +1168,7 @@ RegisterID* CodeGenerator::emitReturn(RegisterID* src) if (m_codeBlock->needsFullScopeChain) { emitOpcode(op_tear_off_activation); instructions().append(m_activationRegisterIndex); - } else if (m_codeBlock->usesArguments) + } else if (m_codeBlock->usesArguments && m_codeBlock->numParameters > 1) emitOpcode(op_tear_off_arguments); return emitUnaryNoDstOp(op_ret, src);