2011-03-29 Adam Barth <abarth@webkit.org>

        Reviewed by Darin Adler.

        test_runner2.py can crash due to undefined variable
        https://bugs.webkit.org/show_bug.cgi?id=57356

        Replace reference to undefined variable with a variable that's actually
        defined.  AFAICT, there's no way to test this code.

        * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Tools/ChangeLog b/Tools/ChangeLog
index 5400dc1654f66cf27a37e14f02483ced70fe318f..fd3b4fd84c74b7d594e60ae861becbee1e1dbfd2 100644 (file)
--- a/Tools/ChangeLog
+++ b/Tools/ChangeLog
@@ -1,3 +1,15 @@
+2011-03-29  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Darin Adler.
+
+        test_runner2.py can crash due to undefined variable
+        https://bugs.webkit.org/show_bug.cgi?id=57356
+
+        Replace reference to undefined variable with a variable that's actually
+        defined.  AFAICT, there's no way to test this code.
+
+        * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
+
 2011-03-29  Tony Chang  <tony@chromium.org>
 
         Reviewed by Eric Seidel.

diff --git a/Tools/Scripts/webkitpy/layout_tests/layout_package/test_runner2.py b/Tools/Scripts/webkitpy/layout_tests/layout_package/test_runner2.py
index 0522d39f69a099f5721a9dc4e5c8b3bb209d5c7d..5a6344c1a4ea9ceb32f3aa9310d6461dcb4a50f4 100644 (file)
--- a/Tools/Scripts/webkitpy/layout_tests/layout_package/test_runner2.py
+++ b/Tools/Scripts/webkitpy/layout_tests/layout_package/test_runner2.py
@@ -224,7 +224,7 @@ class TestRunner2(test_runner.TestRunner):
 
         if worker_state.wedged:
             # This shouldn't happen if we have our timeouts tuned properly.
-            _log.error("%s unwedged", w.name)
+            _log.error("%s unwedged", source)
 
         self._all_results.append(result)
         self._update_summary_with_result(self._current_result_summary, result)