Attempt to fix timeout failure of test plugins/navigator-plugin-crash.html in WebKit1
authordbates@webkit.org <dbates@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 12 May 2017 22:47:55 +0000 (22:47 +0000)
committerdbates@webkit.org <dbates@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 12 May 2017 22:47:55 +0000 (22:47 +0000)
following <http://trac.webkit.org/changeset/216789>
(https://bugs.webkit.org/show_bug.cgi?id=171712)

In r216798 I inadvertently added testRunner.setPopupBlockingEnabled(true) instead
instead of testRunner.setPopupBlockingEnabled(false) to disable the popup blocker.

* plugins/navigator-plugin-crash.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@216799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/plugins/navigator-plugin-crash.html

index a3fa557..03b34e3 100644 (file)
@@ -4,12 +4,23 @@
         following <http://trac.webkit.org/changeset/216789>
         (https://bugs.webkit.org/show_bug.cgi?id=171712)
 
+        In r216798 I inadvertently added testRunner.setPopupBlockingEnabled(true) instead
+        instead of testRunner.setPopupBlockingEnabled(false) to disable the popup blocker.
+
+        * plugins/navigator-plugin-crash.html:
+
+2017-05-12  Daniel Bates  <dabates@apple.com>
+
+        Attempt to fix timeout failure of test plugins/navigator-plugin-crash.html in WebKit1
+        following <http://trac.webkit.org/changeset/216789>
+        (https://bugs.webkit.org/show_bug.cgi?id=171712)
+
         On WebKit1 we need to explicitly allow the test tool to open windows by calling
         testRunner.setCanOpenWindows(). We should also call testRunner.setCloseRemainingWindowsWhenComplete(true)
         to have the test tool close any open windows after running the test.
 
         It is also good practice to explicitly disable the popup blocker by calling
-        testRunner.setPopupBlockingEnabled(true);.
+        testRunner.setPopupBlockingEnabled(false).
 
         * plugins/navigator-plugin-crash.html:
 
index dd5544b..1a56838 100644 (file)
@@ -8,7 +8,7 @@
     if (window.testRunner) {
         testRunner.dumpAsText();
         testRunner.setCanOpenWindows();
-        testRunner.setPopupBlockingEnabled(true);
+        testRunner.setPopupBlockingEnabled(false);
         testRunner.setCloseRemainingWindowsWhenComplete(true);
         testRunner.waitUntilDone();
     }