2011-01-25 Dimitri Glazkov <dglazkov@chromium.org>

        Reviewed by Kent Tamura.

        Reduce ref-count churn in shadowPseudoId.
        https://bugs.webkit.org/show_bug.cgi?id=53136

        Refactoring, so no new tests.

        * dom/Element.h:
        (WebCore::Element::shadowPseudoId): Changed signature to use const AtomicString&
        * html/ValidationMessage.cpp:
        (WebCore::ElementWithPseudoId::shadowPseudoId): Ditto.
        * html/shadow/SliderThumbElement.cpp:
        (WebCore::SliderThumbElement::shadowPseudoId): Ditto, plus moved from the header file.
        * html/shadow/SliderThumbElement.h: Ditto.
        * rendering/MediaControlElements.cpp:
        (WebCore::MediaControlMuteButtonElement::shadowPseudoId): Ditto.
        (WebCore::MediaControlVolumeSliderMuteButtonElement::shadowPseudoId): Ditto.
        (WebCore::MediaControlPlayButtonElement::shadowPseudoId): Ditto.
        (WebCore::MediaControlSeekForwardButtonElement::shadowPseudoId): Ditto.
        (WebCore::MediaControlSeekBackButtonElement::shadowPseudoId): Ditto.
        (WebCore::MediaControlRewindButtonElement::shadowPseudoId): Ditto.
        (WebCore::MediaControlReturnToRealtimeButtonElement::shadowPseudoId): Ditto.
        (WebCore::MediaControlToggleClosedCaptionsButtonElement::shadowPseudoId): Ditto.
        (WebCore::MediaControlTimelineElement::shadowPseudoId): Ditto.
        (WebCore::MediaControlVolumeSliderElement::shadowPseudoId): Ditto.
        (WebCore::MediaControlFullscreenButtonElement::shadowPseudoId): Ditto.
        * rendering/MediaControlElements.h: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
index 7a603570b966ca8d9f4dc58172d27faeb1ae8d20..b16e581fa6b48e46010874e4cbd8e9a33ca93e1c 100644 (file)
--- a/Source/WebCore/ChangeLog
+++ b/Source/WebCore/ChangeLog
@@ -1,3 +1,33 @@
+2011-01-25  Dimitri Glazkov  <dglazkov@chromium.org>
+
+        Reviewed by Kent Tamura.
+
+        Reduce ref-count churn in shadowPseudoId.
+        https://bugs.webkit.org/show_bug.cgi?id=53136
+
+        Refactoring, so no new tests.
+
+        * dom/Element.h:
+        (WebCore::Element::shadowPseudoId): Changed signature to use const AtomicString&
+        * html/ValidationMessage.cpp:
+        (WebCore::ElementWithPseudoId::shadowPseudoId): Ditto.
+        * html/shadow/SliderThumbElement.cpp:
+        (WebCore::SliderThumbElement::shadowPseudoId): Ditto, plus moved from the header file.
+        * html/shadow/SliderThumbElement.h: Ditto.
+        * rendering/MediaControlElements.cpp:
+        (WebCore::MediaControlMuteButtonElement::shadowPseudoId): Ditto.
+        (WebCore::MediaControlVolumeSliderMuteButtonElement::shadowPseudoId): Ditto.
+        (WebCore::MediaControlPlayButtonElement::shadowPseudoId): Ditto.
+        (WebCore::MediaControlSeekForwardButtonElement::shadowPseudoId): Ditto.
+        (WebCore::MediaControlSeekBackButtonElement::shadowPseudoId): Ditto.
+        (WebCore::MediaControlRewindButtonElement::shadowPseudoId): Ditto.
+        (WebCore::MediaControlReturnToRealtimeButtonElement::shadowPseudoId): Ditto.
+        (WebCore::MediaControlToggleClosedCaptionsButtonElement::shadowPseudoId): Ditto.
+        (WebCore::MediaControlTimelineElement::shadowPseudoId): Ditto.
+        (WebCore::MediaControlVolumeSliderElement::shadowPseudoId): Ditto.
+        (WebCore::MediaControlFullscreenButtonElement::shadowPseudoId): Ditto.
+        * rendering/MediaControlElements.h: Ditto.
+
 2011-01-26  Dave Hyatt  <hyatt@apple.com>
 
         Reviewed by Dan Bernstein.

diff --git a/Source/WebCore/dom/Element.h b/Source/WebCore/dom/Element.h
index 45104787f6d6f6ace380b37460f5bb278eac0bc8..de42a5f99503dad1672809afd4bcef6a6277fbb1 100644 (file)
--- a/Source/WebCore/dom/Element.h
+++ b/Source/WebCore/dom/Element.h
@@ -232,7 +232,7 @@ public:
 
     Node* shadowRoot();
     void setShadowRoot(PassRefPtr<Node>);
-    virtual AtomicString shadowPseudoId() const;
+    virtual const AtomicString& shadowPseudoId() const;
 
     RenderStyle* computedStyle(PseudoId = NOPSEUDO);
 
@@ -510,9 +510,9 @@ inline void Element::setIdAttribute(const AtomicString& value)
     setAttribute(document()->idAttributeName(), value);
 }
 
-inline AtomicString Element::shadowPseudoId() const
+inline const AtomicString& Element::shadowPseudoId() const
 {
-    return AtomicString();
+    return nullAtom;
 }
 
 } // namespace

diff --git a/Source/WebCore/html/ValidationMessage.cpp b/Source/WebCore/html/ValidationMessage.cpp
index 2c441c744700f499cd824170975d5c4bed4beab4..f772b92428dcbde2b0887b6a32cf4f78108361eb 100644 (file)
--- a/Source/WebCore/html/ValidationMessage.cpp
+++ b/Source/WebCore/html/ValidationMessage.cpp
@@ -105,7 +105,7 @@ protected:
     ElementWithPseudoId(Document* doc, const AtomicString& pseudoName)
         : HTMLElement(divTag, doc)
         , m_pseudoName(pseudoName) { };
-    virtual AtomicString shadowPseudoId() const { return m_pseudoName; }
+    virtual const AtomicString& shadowPseudoId() const { return m_pseudoName; }
 
 private:
     AtomicString m_pseudoName;

diff --git a/Source/WebCore/html/shadow/SliderThumbElement.cpp b/Source/WebCore/html/shadow/SliderThumbElement.cpp
index 762edda449b57ae76f610ec64cba7dcb15ee3af7..83148d0c5e960ae166de8a2510bb776cd7828f4c 100644 (file)
--- a/Source/WebCore/html/shadow/SliderThumbElement.cpp
+++ b/Source/WebCore/html/shadow/SliderThumbElement.cpp
@@ -184,5 +184,11 @@ void SliderThumbElement::detach()
     HTMLDivElement::detach();
 }
 
+const AtomicString& SliderThumbElement::shadowPseudoId() const
+{
+    DEFINE_STATIC_LOCAL(AtomicString, sliderThumb, ("-webkit-slider-thumb"));
+    return sliderThumb;
+}
+
 }
 

diff --git a/Source/WebCore/html/shadow/SliderThumbElement.h b/Source/WebCore/html/shadow/SliderThumbElement.h
index 1f1c869e51de85830e56330095841e6300d71591..7c4c179a607708956f3ab4fd2d036380f2e32ef4 100644 (file)
--- a/Source/WebCore/html/shadow/SliderThumbElement.h
+++ b/Source/WebCore/html/shadow/SliderThumbElement.h
@@ -53,7 +53,7 @@ public:
     void dragFrom(const IntPoint&);
     virtual void defaultEventHandler(Event*);
     virtual void detach();
-    virtual AtomicString shadowPseudoId() const;
+    virtual const AtomicString& shadowPseudoId() const;
 
 private:
     SliderThumbElement(Document*);
@@ -77,12 +77,6 @@ inline PassRefPtr<SliderThumbElement> SliderThumbElement::create(Document* docum
     return adoptRef(new SliderThumbElement(document));
 }
 
-inline AtomicString SliderThumbElement::shadowPseudoId() const
-{
-    DEFINE_STATIC_LOCAL(AtomicString, sliderThumb, ("-webkit-slider-thumb"));
-    return sliderThumb;
-}
-
 inline SliderThumbElement* toSliderThumbElement(Node* node)
 {
     ASSERT(!node || node->isHTMLElement());