The commit log viewer can overlap the analysis results viewer
authorrniwa@webkit.org <rniwa@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 24 May 2017 23:52:06 +0000 (23:52 +0000)
committerrniwa@webkit.org <rniwa@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 24 May 2017 23:52:06 +0000 (23:52 +0000)
https://bugs.webkit.org/show_bug.cgi?id=172534

Rubber-stamped by Chris Dumez.

Allocate the padding on the right for the commit log viewer, and add a horizontal scrollbar
to the analysis results viewer instead of letting it expand beneath the commit log viewer.

* public/v3/pages/analysis-task-page.js:
(AnalysisTaskResultsPane.htmlTemplate):
(AnalysisTaskResultsPane.cssTemplate):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@217396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Websites/perf.webkit.org/ChangeLog
Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js

index e795f18..e707417 100644 (file)
@@ -1,5 +1,19 @@
 2017-05-24  Ryosuke Niwa  <rniwa@webkit.org>
 
+        The commit log viewer can overlap the analysis results viewer
+        https://bugs.webkit.org/show_bug.cgi?id=172534
+
+        Rubber-stamped by Chris Dumez.
+
+        Allocate the padding on the right for the commit log viewer, and add a horizontal scrollbar
+        to the analysis results viewer instead of letting it expand beneath the commit log viewer.
+
+        * public/v3/pages/analysis-task-page.js:
+        (AnalysisTaskResultsPane.htmlTemplate):
+        (AnalysisTaskResultsPane.cssTemplate):
+
+2017-05-24  Ryosuke Niwa  <rniwa@webkit.org>
+
         Sycning script build fix after r217378.
 
         * tools/sync-buildbot.js:
index 10a2dd2..b6ea89e 100644 (file)
@@ -160,7 +160,9 @@ class AnalysisTaskResultsPane extends ComponentBase {
     {
         return `
             <div id="results-container">
-                <analysis-results-viewer id="results-viewer"></analysis-results-viewer>
+                <div id="results-viewer-container">
+                    <analysis-results-viewer id="results-viewer"></analysis-results-viewer>
+                </div>
                 <div id="commit-pane">
                     <select id="commit-viewer-repository"></select>
                     <commit-log-viewer id="commit-viewer"></commit-log-viewer>
@@ -176,6 +178,11 @@ class AnalysisTaskResultsPane extends ComponentBase {
             #results-container {
                 position: relative;
                 text-align: center;
+                padding-right: 20rem;
+            }
+            #results-viewer-container {
+                overflow-x: scroll;
+                overflow-y: hidden;
             }
             #commit-pane {
                 position: absolute;