Update expectations for bufferedAmount-unchanged-by-sync-xhr.any.worker.html
authorsihui_liu@apple.com <sihui_liu@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 19 Nov 2019 16:51:33 +0000 (16:51 +0000)
committersihui_liu@apple.com <sihui_liu@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 19 Nov 2019 16:51:33 +0000 (16:51 +0000)
https://bugs.webkit.org/show_bug.cgi?id=204313

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

* web-platform-tests/websockets/bufferedAmount-unchanged-by-sync-xhr.any.worker-expected.txt:

Source/WebCore:

Add some logging to help debug the flaky timeout of bufferedAmount-unchanged-by-sync-xhr.any.worker.html on
commit-queue bot.

* Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::fail):
(WebCore::WebSocketChannel::didFailSocketStream):
* platform/network/cf/SocketStreamHandleImplCFNet.cpp:
(WebCore::SocketStreamHandleImpl::scheduleStreams):
(WebCore::SocketStreamHandleImpl::readStreamCallback):
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::restoreTo):Remove a duplicate setting.

Tools:

* DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebViewToConsistentStateBeforeTesting):

LayoutTests:

* platform/ios-wk2/TestExpectations:
* platform/mac-wk2/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@252633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/imported/w3c/ChangeLog
LayoutTests/imported/w3c/web-platform-tests/websockets/bufferedAmount-unchanged-by-sync-xhr.any.worker-expected.txt
LayoutTests/platform/ios-wk2/TestExpectations
LayoutTests/platform/mac-wk2/TestExpectations
Source/WebCore/ChangeLog
Source/WebCore/Modules/websockets/WebSocketChannel.cpp
Source/WebCore/platform/network/cf/SocketStreamHandleImplCFNet.cpp
Source/WebCore/testing/InternalSettings.cpp
Tools/ChangeLog
Tools/DumpRenderTree/mac/DumpRenderTree.mm

index b8ed8de..2fd04da 100644 (file)
@@ -1,3 +1,13 @@
+2019-11-19  Sihui Liu  <sihui_liu@apple.com>
+
+        Update expectations for bufferedAmount-unchanged-by-sync-xhr.any.worker.html
+        https://bugs.webkit.org/show_bug.cgi?id=204313
+
+        Reviewed by Alex Christensen.
+
+        * platform/ios-wk2/TestExpectations:
+        * platform/mac-wk2/TestExpectations:
+
 2019-11-19  Eric Carlson  <eric.carlson@apple.com>
 
         OverConstrainedError is missing 'name' property
index 38f93e3..5e0f194 100644 (file)
@@ -1,3 +1,12 @@
+2019-11-19  Sihui Liu  <sihui_liu@apple.com>
+
+        Update expectations for bufferedAmount-unchanged-by-sync-xhr.any.worker.html
+        https://bugs.webkit.org/show_bug.cgi?id=204313
+
+        Reviewed by Alex Christensen.
+
+        * web-platform-tests/websockets/bufferedAmount-unchanged-by-sync-xhr.any.worker-expected.txt:
+
 2019-11-19  Eric Carlson  <eric.carlson@apple.com>
 
         OverConstrainedError is missing 'name' property
index 1460cf7..f06b04e 100644 (file)
@@ -1314,8 +1314,6 @@ webkit.org/b/196633 imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getSyn
 
 webkit.org/b/197662 [ Debug ] imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-getStats.https.html [ Pass Failure ]
 
-webkit.org/b/198774 imported/w3c/web-platform-tests/websockets/bufferedAmount-unchanged-by-sync-xhr.any.worker.html [ Failure ]
-
 webkit.org/b/176030 http/tests/websocket/tests/hybi/send-object-tostring-check.html [ Pass Failure ]
 
 webkit.org/b/199013 [ Debug ] imported/w3c/web-platform-tests/websockets/Create-Secure-verify-url-set-non-default-port.any.html [ Pass Failure ]
index 181ef92..cb31595 100644 (file)
@@ -913,8 +913,6 @@ webkit.org/b/198661 scrollingcoordinator/mac/nested-sticky.html [ Pass ImageOnly
 
 webkit.org/b/198663 http/tests/storageAccess/request-and-grant-access-then-navigate-same-site-should-have-access.html [ Pass Timeout ]
 
-webkit.org/b/198774 imported/w3c/web-platform-tests/websockets/bufferedAmount-unchanged-by-sync-xhr.any.worker.html [ Failure ]
-
 webkit.org/b/176030 [ Debug ] http/tests/websocket/tests/hybi/send-object-tostring-check.html [ Pass Failure ]
 
 webkit.org/b/198921 [ Mojave+ ] webgpu/blend-color-triangle-strip.html [ Pass ImageOnlyFailure ]
index 20cb1a9..c0ed5b8 100644 (file)
@@ -1,3 +1,22 @@
+2019-11-19  Sihui Liu  <sihui_liu@apple.com>
+
+        Update expectations for bufferedAmount-unchanged-by-sync-xhr.any.worker.html
+        https://bugs.webkit.org/show_bug.cgi?id=204313
+
+        Reviewed by Alex Christensen.
+
+        Add some logging to help debug the flaky timeout of bufferedAmount-unchanged-by-sync-xhr.any.worker.html on 
+        commit-queue bot.
+
+        * Modules/websockets/WebSocketChannel.cpp:
+        (WebCore::WebSocketChannel::fail):
+        (WebCore::WebSocketChannel::didFailSocketStream):
+        * platform/network/cf/SocketStreamHandleImplCFNet.cpp:
+        (WebCore::SocketStreamHandleImpl::scheduleStreams):
+        (WebCore::SocketStreamHandleImpl::readStreamCallback):
+        * testing/InternalSettings.cpp:
+        (WebCore::InternalSettings::Backup::restoreTo):Remove a duplicate setting.
+
 2019-11-19  Eric Carlson  <eric.carlson@apple.com>
 
         OverConstrainedError is missing 'name' property
index db74a07..623fe39 100644 (file)
@@ -203,7 +203,7 @@ void WebSocketChannel::close(int code, const String& reason)
 
 void WebSocketChannel::fail(const String& reason)
 {
-    LOG(Network, "WebSocketChannel %p fail() reason='%s'", this, reason.utf8().data());
+    RELEASE_LOG(Network, "WebSocketChannel %p fail() reason='%s'", this, reason.utf8().data());
     ASSERT(!m_suspended);
     if (m_document) {
         InspectorInstrumentation::didReceiveWebSocketFrameError(m_document.get(), m_identifier, reason);
@@ -363,6 +363,7 @@ void WebSocketChannel::didFailSocketStream(SocketStreamHandle& handle, const Soc
             message = "WebSocket network error: " + error.localizedDescription();
         InspectorInstrumentation::didReceiveWebSocketFrameError(m_document.get(), m_identifier, message);
         m_document->addConsoleMessage(MessageSource::Network, MessageLevel::Error, message);
+        LOG_ERROR("%s", message.utf8().data());
     }
     m_shouldDiscardReceivedData = true;
     if (m_client)
index 9e14181..545c28e 100644 (file)
@@ -154,6 +154,7 @@ void SocketStreamHandleImpl::scheduleStreams()
         removePACRunLoopSource();
 
     m_connectingSubstate = WaitingForConnect;
+    RELEASE_LOG(Network, "SocketStreamHandleImpl::scheduleStreams - m_connectionSubState is WaitingForConnect");
 }
 
 void* SocketStreamHandleImpl::retainSocketStreamHandle(void* info)
@@ -578,6 +579,7 @@ void SocketStreamHandleImpl::readStreamCallback(CFStreamEventType type)
                     return;
                 }
             }
+            RELEASE_LOG(Network, "SocketStreamHandleImpl::readStreamCallback - m_connectionSubState is Connected");
             m_connectingSubstate = Connected;
             m_state = Open;
             m_client.didOpenSocketStream(*this);
index d6d7dd4..0758b75 100644 (file)
@@ -207,7 +207,6 @@ void InternalSettings::Backup::restoreTo(Settings& settings)
     settings.setForcedDisplayIsMonochromeAccessibilityValue(m_forcedDisplayIsMonochromeAccessibilityValue);
     settings.setForcedPrefersReducedMotionAccessibilityValue(m_forcedPrefersReducedMotionAccessibilityValue);
     settings.setFontLoadTimingOverride(m_fontLoadTimingOverride);
-    DeprecatedGlobalSettings::setAllowsAnySSLCertificate(false);
     RenderTheme::singleton().setShouldMockBoldSystemFontForAccessibility(m_shouldMockBoldSystemFontForAccessibility);
     FontCache::singleton().setShouldMockBoldSystemFontForAccessibility(m_shouldMockBoldSystemFontForAccessibility);
     settings.setFrameFlattening(m_frameFlattening);
index 59e52e0..305174e 100644 (file)
@@ -1,3 +1,13 @@
+2019-11-19  Sihui Liu  <sihui_liu@apple.com>
+
+        Update expectations for bufferedAmount-unchanged-by-sync-xhr.any.worker.html
+        https://bugs.webkit.org/show_bug.cgi?id=204313
+
+        Reviewed by Alex Christensen.
+
+        * DumpRenderTree/mac/DumpRenderTree.mm:
+        (resetWebViewToConsistentStateBeforeTesting):
+
 2019-11-19  Paulo Matos  <pmatos@igalia.com>
 
         Setup EWS queues for JSConly 32bits ARMv7 and MIPSel
index 24c32f8..2ca08bf 100644 (file)
@@ -1900,7 +1900,7 @@ static void resetWebViewToConsistentStateBeforeTesting(const TestOptions& option
 #endif
 
     TestRunner::setSerializeHTTPLoads(false);
-    TestRunner::setAllowsAnySSLCertificate(false);
+    TestRunner::setAllowsAnySSLCertificate(true);
 
     setlocale(LC_ALL, "");