2011-01-25 Hans Wennborg <hans@chromium.org>
authorhans@chromium.org <hans@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 25 Jan 2011 19:07:09 +0000 (19:07 +0000)
committerhans@chromium.org <hans@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 25 Jan 2011 19:07:09 +0000 (19:07 +0000)
        Reviewed by Jeremy Orlow.

        IndexedDB: Remove PlatformBridge::idbShutdown()
        https://bugs.webkit.org/show_bug.cgi?id=53077

        Since Chromium r72157, this is not used anymore. The previous use was
        to signal to the embedder that IndexedDB was shutting down, but we
        agreed it is better if the embedder keeps track of that itself.

        No new tests: this does not change any functionality.

        * platform/chromium/PlatformBridge.h:
        * storage/IDBFactoryBackendInterface.cpp:
        * storage/IDBFactoryBackendInterface.h:
        (WebCore::IDBFactoryBackendInterface::~IDBFactoryBackendInterface):
        * storage/chromium/IDBFactoryBackendInterface.cpp:
2011-01-25  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        IndexedDB: Remove PlatformBridge::idbShutdown()
        https://bugs.webkit.org/show_bug.cgi?id=53077

        Since Chromium r72157, this is not used anymore. Chromium keeps track
        of when it shuts down IndexedDB itself.

        * public/WebKitClient.h:
        * src/PlatformBridge.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/platform/chromium/PlatformBridge.h
Source/WebCore/storage/IDBFactoryBackendInterface.cpp
Source/WebCore/storage/IDBFactoryBackendInterface.h
Source/WebCore/storage/chromium/IDBFactoryBackendInterface.cpp
Source/WebKit/chromium/ChangeLog
Source/WebKit/chromium/public/WebKitClient.h
Source/WebKit/chromium/src/PlatformBridge.cpp

index 2e4024c132ebbde76f90e94418de8e943cce2394..bdff19f5342ca6edc7762abd1ce0dcbc3424eaa2 100644 (file)
@@ -1,3 +1,22 @@
+2011-01-25  Hans Wennborg  <hans@chromium.org>
+
+        Reviewed by Jeremy Orlow.
+
+        IndexedDB: Remove PlatformBridge::idbShutdown()
+        https://bugs.webkit.org/show_bug.cgi?id=53077
+
+        Since Chromium r72157, this is not used anymore. The previous use was
+        to signal to the embedder that IndexedDB was shutting down, but we
+        agreed it is better if the embedder keeps track of that itself.
+
+        No new tests: this does not change any functionality.
+
+        * platform/chromium/PlatformBridge.h:
+        * storage/IDBFactoryBackendInterface.cpp:
+        * storage/IDBFactoryBackendInterface.h:
+        (WebCore::IDBFactoryBackendInterface::~IDBFactoryBackendInterface):
+        * storage/chromium/IDBFactoryBackendInterface.cpp:
+
 2011-01-25  Darin Adler  <darin@apple.com>
 
         Reviewed by Anders Carlsson.
index f6a2564418b64aa1b9283932fcf75b48cf398d1d..c6085f1b234c149daec91ebf0cd6f56c1e617adf 100644 (file)
@@ -171,7 +171,6 @@ public:
 
     // IndexedDB ----------------------------------------------------------
     static PassRefPtr<IDBFactoryBackendInterface> idbFactory();
-    static void idbShutdown();
     // Extracts keyPath from values and returns the corresponding keys.
     static void createIDBKeysFromSerializedValuesAndKeyPath(const Vector<RefPtr<SerializedScriptValue> >& values, const String& keyPath, Vector<RefPtr<IDBKey> >& keys);
 
index 935ccac84deaf8fc37977680a8a17e584df598ff..ac136521f68b710d2abefe118fc3a46dbaeb5f31 100644 (file)
@@ -43,10 +43,6 @@ PassRefPtr<IDBFactoryBackendInterface> IDBFactoryBackendInterface::create()
     return IDBFactoryBackendImpl::create();
 }
 
-IDBFactoryBackendInterface::~IDBFactoryBackendInterface()
-{
-}
-
 } // namespace WebCore
 
 #endif // ENABLE(INDEXED_DATABASE)
index 166d5170deccc0c5c01ac43a41d1b6d819a4cac3..e05f316999ac18ca845f56282767580346886328 100644 (file)
@@ -49,7 +49,7 @@ class SecurityOrigin;
 class IDBFactoryBackendInterface : public ThreadSafeShared<IDBFactoryBackendInterface> {
 public:
     static PassRefPtr<IDBFactoryBackendInterface> create();
-    virtual ~IDBFactoryBackendInterface();
+    virtual ~IDBFactoryBackendInterface() { }
 
     virtual void open(const String& name, PassRefPtr<IDBCallbacks>, PassRefPtr<SecurityOrigin>, Frame*, const String& dataDir, int64_t maximumSize) = 0;
 };
index 92e9a7bf43793cece48285f385e7bcd3fa920291..81eeb3e19d86ad558edaf6ab98b50301fb433abd 100644 (file)
@@ -39,11 +39,6 @@ PassRefPtr<IDBFactoryBackendInterface> IDBFactoryBackendInterface::create()
     return PlatformBridge::idbFactory();
 }
 
-IDBFactoryBackendInterface::~IDBFactoryBackendInterface()
-{
-    PlatformBridge::idbShutdown();
-}
-
 } // namespace WebCore
 
 #endif // ENABLE(INDEXED_DATABASE)
index 76309581ea91298d105cc7091c761caa28a0dd5a..d98c00f9a0d8fce95f91d3bd9496e71494b59753 100644 (file)
@@ -1,3 +1,16 @@
+2011-01-25  Hans Wennborg  <hans@chromium.org>
+
+        Reviewed by Jeremy Orlow.
+
+        IndexedDB: Remove PlatformBridge::idbShutdown()
+        https://bugs.webkit.org/show_bug.cgi?id=53077
+
+        Since Chromium r72157, this is not used anymore. Chromium keeps track
+        of when it shuts down IndexedDB itself.
+
+        * public/WebKitClient.h:
+        * src/PlatformBridge.cpp:
+
 2011-01-25  Ilya Sherman  <isherman@chromium.org>
 
         Reviewed by Darin Fisher.
index ae7892d76892267683d8f952a77fe979d43e2d69..d8ead238ed3bd1e03b653789a9ec802a783e4490 100644 (file)
@@ -143,7 +143,6 @@ public:
     // Indexed Database ----------------------------------------------------
 
     virtual WebIDBFactory* idbFactory() { return 0; }
-    virtual void idbShutdown() { };
     virtual void createIDBKeysFromSerializedValuesAndKeyPath(const WebVector<WebSerializedScriptValue>& values,  const WebString& keyPath, WebVector<WebIDBKey>& keys) { }
 
 
index 04016fcb7611cb18812df3ee8e9050b64144df10..4dde3caac7693acf829014b72bb6b31453ddfab7 100644 (file)
@@ -509,12 +509,6 @@ PassRefPtr<IDBFactoryBackendInterface> PlatformBridge::idbFactory()
     return IDBFactoryBackendProxy::create();
 }
 
-void PlatformBridge::idbShutdown()
-{
-    // In the browser process, this shuts down the utility process. In the renderer process, it does nothing.
-    webKitClient()->idbShutdown();
-}
-
 void PlatformBridge::createIDBKeysFromSerializedValuesAndKeyPath(const Vector<RefPtr<SerializedScriptValue> >& values, const String& keyPath, Vector<RefPtr<IDBKey> >& keys)
 {
     WebVector<WebSerializedScriptValue> webValues = values;