Stop generating stripped symbols for Release builds

It turns out we can strip the symbols after-the-fact using PDBCopy.

Fixes <http://webkit.org/b/42085>.

Reviewed by Steve Falkenburg.

JavaScriptCore:

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
Removed the pre-link event, which just created the public\sym
directory.

WebKit2:

* win/WebKit2.vcproj: Removed the no-longer-needed Release override of
the StripPrivateSymbols attribute. (This attribute is no longer set in
release.vsprops, so doesn't need to be overridden.)

WebKitLibraries:

* win/tools/vsprops/release.vsprops: Removed the StripPrivateSymbols
attribute, which caused link.exe to generate a stripped PDB file for
each project.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/JavaScriptCore/ChangeLog b/JavaScriptCore/ChangeLog
index cbf783e9351000c0b5e96940f921b5207aa2a5c4..3be8f7766c345846a212a1f6e7e862f4f6579f07 100644 (file)
--- a/JavaScriptCore/ChangeLog
+++ b/JavaScriptCore/ChangeLog
@@ -1,3 +1,17 @@
+2010-07-12  Adam Roben  <aroben@apple.com>
+
+        Stop generating stripped symbols for Release builds
+
+        It turns out we can strip the symbols after-the-fact using PDBCopy.
+
+        Fixes <http://webkit.org/b/42085>.
+
+        Reviewed by Steve Falkenburg.
+
+        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
+        Removed the pre-link event, which just created the public\sym
+        directory.
+
 2010-07-12  Anders Carlsson  <andersca@apple.com>
 
         Reviewed by Dan Bernstein.

diff --git a/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops b/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops
index e940511f583feb770dda64e6ad26c03c829a5315..ad81c363357b358934de2a29c5a182926a688062 100644 (file)
--- a/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops
+++ b/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops
@@ -23,8 +23,4 @@
                Name="VCPreBuildEventTool"
                CommandLine="%SystemDrive%\cygwin\bin\which.exe bash
if errorlevel 1 set PATH=%SystemDrive%\cygwin\bin;%PATH%
cmd /c
if exist "$(WebKitOutputDir)\buildfailed" grep XX$(ProjectName)XX "$(WebKitOutputDir)\buildfailed"
if errorlevel 1 exit 1
echo XX$(ProjectName)XX > "$(WebKitOutputDir)\buildfailed"

bash "$(WebKitLibrariesDir)\tools\scripts\auto-version.sh" "$(IntDir)"
"
        />
-       <Tool
-               Name="VCPreLinkEventTool"
-               CommandLine="if not exist &quot;$(WebKitOutputDir)\public\sym&quot; mkdir &quot;$(WebKitOutputDir)\public\sym&quot;"
-       />
 </VisualStudioPropertySheet>

diff --git a/WebKit2/ChangeLog b/WebKit2/ChangeLog
index 138966fad4a751c0cfeba5cbc3d6488c6a57922c..4a347533d84a37a577dcae16d466601347134528 100644 (file)
--- a/WebKit2/ChangeLog
+++ b/WebKit2/ChangeLog
@@ -1,3 +1,17 @@
+2010-07-12  Adam Roben  <aroben@apple.com>
+
+        Stop generating stripped symbols for Release builds
+
+        It turns out we can strip the symbols after-the-fact using PDBCopy.
+
+        Fixes <http://webkit.org/b/42085>.
+
+        Reviewed by Steve Falkenburg.
+
+        * win/WebKit2.vcproj: Removed the no-longer-needed Release override of
+        the StripPrivateSymbols attribute. (This attribute is no longer set in
+        release.vsprops, so doesn't need to be overridden.)
+
 2010-07-12  Brian Weinstein  <bweinstein@apple.com>
 
         WebKit2 build fix for Windows.

diff --git a/WebKit2/win/WebKit2.vcproj b/WebKit2/win/WebKit2.vcproj
index e4adb5f3d78c5b5180b75b30bac1bb444898f738..752f36950956b1375c7c4012f94c3cc26ad2441a 100755 (executable)
--- a/WebKit2/win/WebKit2.vcproj
+++ b/WebKit2/win/WebKit2.vcproj
@@ -139,7 +139,6 @@
                                OutputFile="$(OutDir)\$(ProjectName)$(WebKitDLLConfigSuffix).dll"\r
                                AdditionalLibraryDirectories="$(DXSDK_DIR)\Lib\x86"\r
                                DelayLoadDLLs="usp10.dll;comctl32.dll;version.dll;libxslt$(LibraryConfigSuffix).dll;SQLite3$(LibraryConfigSuffix).dll;msimg32.dll;QTMovieWin$(WebKitConfigSuffix).dll;iphlpapi.dll"\r
-                               StripPrivateSymbols=""\r
                        />\r
                        <Tool\r
                                Name="VCALinkTool"\r

diff --git a/WebKitLibraries/ChangeLog b/WebKitLibraries/ChangeLog
index c9127755f0099b94402705bdc56b910ecc7d9c03..bc2150bf3ed8d15680bb05b2e22f3913c0899da1 100644 (file)
--- a/WebKitLibraries/ChangeLog
+++ b/WebKitLibraries/ChangeLog
@@ -1,3 +1,17 @@
+2010-07-12  Adam Roben  <aroben@apple.com>
+
+        Stop generating stripped symbols for Release builds
+
+        It turns out we can strip the symbols after-the-fact using PDBCopy.
+
+        Fixes <http://webkit.org/b/42085>.
+
+        Reviewed by Steve Falkenburg.
+
+        * win/tools/vsprops/release.vsprops: Removed the StripPrivateSymbols
+        attribute, which caused link.exe to generate a stripped PDB file for
+        each project.
+
 2010-07-08  Eric Carlson  <eric.carlson@apple.com>
 
         Reviewed by Dan Bernstein.

diff --git a/WebKitLibraries/win/tools/vsprops/release.vsprops b/WebKitLibraries/win/tools/vsprops/release.vsprops
index 109176dd3f39f8770c25e248833777b3f33cfd90..8b38b7361d3733ab01772bbe4f97f2244df737fd 100644 (file)
--- a/WebKitLibraries/win/tools/vsprops/release.vsprops
+++ b/WebKitLibraries/win/tools/vsprops/release.vsprops
@@ -13,7 +13,6 @@
        <Tool
                Name="VCLinkerTool"
                LinkIncremental="1"
-               StripPrivateSymbols="$(WebKitOutputDir)\public\sym\$(TargetName).pdb"
                OptimizeReferences="2"
                EnableCOMDATFolding="2"
                OptimizeForWindows98="1"