2011-02-05 Sheriff Bot <webkit.review.bot@gmail.com>
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 5 Feb 2011 17:19:53 +0000 (17:19 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 5 Feb 2011 17:19:53 +0000 (17:19 +0000)
        Unreviewed, rolling out r77720.
        http://trac.webkit.org/changeset/77720
        https://bugs.webkit.org/show_bug.cgi?id=53854

        "Broke nrwt on Chromium win." (Requested by dglazkov|away on
        #webkit).

        * Scripts/webkitpy/common/system/executive.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/Scripts/webkitpy/common/system/executive.py

index ebbb116cc5084570c207f50487df8b3526c3d070..a8857b16a450aeb7406be5a31452724a64add42e 100644 (file)
@@ -1,3 +1,14 @@
+2011-02-05  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r77720.
+        http://trac.webkit.org/changeset/77720
+        https://bugs.webkit.org/show_bug.cgi?id=53854
+
+        "Broke nrwt on Chromium win." (Requested by dglazkov|away on
+        #webkit).
+
+        * Scripts/webkitpy/common/system/executive.py:
+
 2011-02-05  Sheriff Bot  <webkit.review.bot@gmail.com>
 
         Unreviewed, rolling out r77725.
index 9155350e806bcae25909bcec79a590afe0b17fdd..02619db4d5d7b41bd7744c46ea94953659dee2b3 100644 (file)
@@ -111,11 +111,6 @@ class Executive(object):
         # shows up on Mac and Linux.
         return sys.platform not in ('win32', 'cygwin')
 
-    def _should_use_shell(self):
-        # On Windows, if we don't use the shell, we don't search %PATH% to
-        # find the command-- an absolute path is required.
-        return sys.platform.startswith('win')
-
     def _run_command_with_teed_output(self, args, teed_output):
         args = map(unicode, args)  # Popen will throw an exception if args are non-strings (like int())
         args = map(self._encode_argument_if_needed, args)
@@ -123,8 +118,7 @@ class Executive(object):
         child_process = subprocess.Popen(args,
                                          stdout=subprocess.PIPE,
                                          stderr=subprocess.STDOUT,
-                                         close_fds=self._should_close_fds(),
-                                         shell=self._should_use_shell())
+                                         close_fds=self._should_close_fds())
 
         # Use our own custom wait loop because Popen ignores a tee'd
         # stderr/stdout.
@@ -357,8 +351,7 @@ class Executive(object):
                                    stdout=subprocess.PIPE,
                                    stderr=stderr,
                                    cwd=cwd,
-                                   close_fds=self._should_close_fds(),
-                                   shell=self._should_use_shell())
+                                   close_fds=self._should_close_fds())
         output = process.communicate(string_to_communicate)[0]
 
         # run_command automatically decodes to unicode() unless explicitly told not to.