Revert: Add logging when splashboardd enables WebThread
authorddkilzer@apple.com <ddkilzer@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 19 Jun 2018 18:31:56 +0000 (18:31 +0000)
committerddkilzer@apple.com <ddkilzer@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 19 Jun 2018 18:31:56 +0000 (18:31 +0000)
<https://webkit.org/b/186793>
<rdar://problem/41213255>

Turns out this isn't needed, so reverting r232959.

* platform/RuntimeApplicationChecks.h:
* platform/cocoa/RuntimeApplicationChecksCocoa.mm:
(WebCore::IOSApplication::isSplashBoardd): Deleted.
* platform/ios/wak/WebCoreThread.mm:
(WebThreadEnable):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@232969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/platform/RuntimeApplicationChecks.h
Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm
Source/WebCore/platform/ios/wak/WebCoreThread.mm

index e53c2e8..4e7ad30 100644 (file)
@@ -1,3 +1,17 @@
+2018-06-19  David Kilzer  <ddkilzer@apple.com>
+
+        Revert: Add logging when splashboardd enables WebThread
+        <https://webkit.org/b/186793>
+        <rdar://problem/41213255>
+
+        Turns out this isn't needed, so reverting r232959.
+
+        * platform/RuntimeApplicationChecks.h:
+        * platform/cocoa/RuntimeApplicationChecksCocoa.mm:
+        (WebCore::IOSApplication::isSplashBoardd): Deleted.
+        * platform/ios/wak/WebCoreThread.mm:
+        (WebThreadEnable):
+
 2018-06-19  Wenson Hsieh  <wenson_hsieh@apple.com>
 
         [WebKit on watchOS] Vend username text content type when using scribble in login fields
index 7fe2116..94e28f8 100644 (file)
@@ -78,7 +78,6 @@ WEBCORE_EXPORT bool isMobileSafari();
 WEBCORE_EXPORT bool isWebBookmarksD();
 bool isDumpRenderTree();
 bool isMobileStore();
-bool isSplashBoardd();
 bool isSpringBoard();
 WEBCORE_EXPORT bool isWebApp();
 WEBCORE_EXPORT bool isWebProcess();
index 6dd9151..2f379a3 100644 (file)
@@ -206,12 +206,6 @@ bool IOSApplication::isMobileStore()
     return isMobileStore;
 }
 
-bool IOSApplication::isSplashBoardd()
-{
-    static bool isSplashBoardd = applicationBundleIsEqualTo(ASCIILiteral("splashboardd"));
-    return isSplashBoardd;
-}
-
 bool IOSApplication::isSpringBoard()
 {
     static bool isSpringBoard = applicationBundleIsEqualTo(ASCIILiteral("com.apple.springboard"));
index d8ff806..43bb32a 100644 (file)
@@ -866,9 +866,7 @@ WebThreadContext* WebThreadCurrentContext(void)
 void WebThreadEnable(void)
 {
     RELEASE_ASSERT_WITH_MESSAGE(!WebCore::IOSApplication::isWebProcess(), "The WebProcess should never run a Web Thread");
-    if (WebCore::IOSApplication::isSplashBoardd())
-        RELEASE_LOG_FAULT(Threading, "splashboardd enabled WebThread.");
-    else if (WebCore::IOSApplication::isSpringBoard())
+    if (WebCore::IOSApplication::isSpringBoard())
         RELEASE_LOG_FAULT(Threading, "SpringBoard enabled WebThread.");
 
     static std::once_flag flag;