AX: Can't set accessibility overridden attributes on web objects
authorcfleizach@apple.com <cfleizach@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 4 Feb 2011 18:47:41 +0000 (18:47 +0000)
committercfleizach@apple.com <cfleizach@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 4 Feb 2011 18:47:41 +0000 (18:47 +0000)
https://bugs.webkit.org/show_bug.cgi?id=53725

Reviewed by Darin Adler.

accessibilitySetOverriddenValue does not work on AX objects from WebCore because
the right method needed to be overridden (accessibilitySupportsOverriddenAttributes).
Unfortunately, there's no way to test this from DRT, since AppKit returns the overridden
attribute only when an AX client asks for it through the AX frameworks.

* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilitySupportsOverriddenAttributes]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/accessibility/mac/AccessibilityObjectWrapper.mm

index 04870a5d0f8cac68712d5385e8bf37a68fe5d8da..b38e29541b089a3819bd59c39451b017015ee6ee 100644 (file)
@@ -1,3 +1,18 @@
+2011-02-04  Chris Fleizach  <cfleizach@apple.com>
+
+        Reviewed by Darin Adler.
+
+        AX: Can't set accessibility overridden attributes on web objects
+        https://bugs.webkit.org/show_bug.cgi?id=53725
+
+        accessibilitySetOverriddenValue does not work on AX objects from WebCore because 
+        the right method needed to be overridden (accessibilitySupportsOverriddenAttributes).
+        Unfortunately, there's no way to test this from DRT, since AppKit returns the overridden
+        attribute only when an AX client asks for it through the AX frameworks.
+
+        * accessibility/mac/AccessibilityObjectWrapper.mm:
+        (-[AccessibilityObjectWrapper accessibilitySupportsOverriddenAttributes]):
+
 2011-02-03  Dimitri Glazkov  <dglazkov@chromium.org>
 
         Reviewed by Kent Tamura.
index 5d20acbe11fa8e074d52d2a96b8f26c426be24b7..6a920adf00f793961be28c5644d7dee4e3d7c4d4 100644 (file)
@@ -2731,6 +2731,11 @@ static RenderObject* rendererForView(NSView* view)
     return [super accessibilityAttributeValue:attribute forParameter:parameter];
 }
 
+- (BOOL)accessibilitySupportsOverriddenAttributes
+{
+    return YES;
+}
+
 - (BOOL)accessibilityShouldUseUniqueId
 {
     return m_object->accessibilityShouldUseUniqueId();