Web Inspector: Title of "Record Timeline" status button on "Timeline
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 6 Dec 2012 07:28:05 +0000 (07:28 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 6 Dec 2012 07:28:05 +0000 (07:28 +0000)
Panel" should reflect the recording state.
https://bugs.webkit.org/show_bug.cgi?id=104108

Patch by Sankeerth V S <sankeerth.vs@samsung.com> on 2012-12-05
Reviewed by Alexander Pavlov.

Title should be toggled between "Record"/"Stop" to reflect current
state of the Status bar button.

No new tests as UI related change.

* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype.get _toggleTimelineButtonClicked):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/inspector/front-end/TimelinePanel.js

index d7299c4..0220e80 100644 (file)
@@ -1,3 +1,19 @@
+2012-12-05  Sankeerth V S  <sankeerth.vs@samsung.com>
+
+        Web Inspector: Title of "Record Timeline" status button on "Timeline
+        Panel" should reflect the recording state.
+        https://bugs.webkit.org/show_bug.cgi?id=104108
+
+        Reviewed by Alexander Pavlov.
+
+        Title should be toggled between "Record"/"Stop" to reflect current
+        state of the Status bar button.
+
+        No new tests as UI related change.
+
+        * inspector/front-end/TimelinePanel.js:
+        (WebInspector.TimelinePanel.prototype.get _toggleTimelineButtonClicked):
+
 2012-12-03  Kent Tamura  <tkent@chromium.org>
 
         INPUT_MULTIPLE_FIELDS_UI doesn't show digits well in RTL locales
index f616d42..8e06f2f 100644 (file)
@@ -546,10 +546,13 @@ WebInspector.TimelinePanel.prototype = {
     {
         if (this._operationInProgress)
             return;
-        if (this.toggleTimelineButton.toggled)
+        if (this.toggleTimelineButton.toggled) {
             this._model.stopRecord();
+            this.toggleTimelineButton.title = WebInspector.UIString("Record");
+        }
         else {
             this._model.startRecord();
+            this.toggleTimelineButton.title = WebInspector.UIString("Stop");
             WebInspector.userMetrics.TimelineStarted.record();
         }
         this.toggleTimelineButton.toggled = !this.toggleTimelineButton.toggled;