<rdar://problem/10346980> REGRESSION: Cannot enter text in Dashboard widget fields...
authormrowe@apple.com <mrowe@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 28 Apr 2012 05:31:32 +0000 (05:31 +0000)
committermrowe@apple.com <mrowe@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 28 Apr 2012 05:31:32 +0000 (05:31 +0000)
Remove a dashboard backwards compatibility quirk that was in place to support an old version
of the Stocks widget. It prevented the pointer-events property from being applied in Dashboard
widgets, which caused -webkit-input-placeholder elements to eat mouse clicks rather than giving
focus to the containing input elements. The offending widget has long since been fixed.

Reviewed by Dan Bernstein.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/css/StyleResolver.cpp

index 4131e8b..bbba2c8 100644 (file)
@@ -1,3 +1,17 @@
+2012-04-27  Mark Rowe  <mrowe@apple.com>
+
+        <rdar://problem/10346980> REGRESSION: Cannot enter text in Dashboard widget fields that have placeholder attribute
+
+        Remove a dashboard backwards compatibility quirk that was in place to support an old version
+        of the Stocks widget. It prevented the pointer-events property from being applied in Dashboard
+        widgets, which caused -webkit-input-placeholder elements to eat mouse clicks rather than giving
+        focus to the containing input elements. The offending widget has long since been fixed.
+
+        Reviewed by Dan Bernstein.
+
+        * css/StyleResolver.cpp:
+        (WebCore::StyleResolver::collectMatchingRulesForList):
+
 2012-04-27  Dean Jackson  <dino@apple.com>
 
         Support reverse and alternate-reverse in CA animations
index ff6f70c..78488a3 100644 (file)
@@ -3706,13 +3706,6 @@ void StyleResolver::applyProperty(CSSPropertyID id, CSSValue *value)
         return;
     case CSSPropertyPointerEvents:
     {
-#if ENABLE(DASHBOARD_SUPPORT)
-        // <rdar://problem/6561077> Work around the Stocks widget's misuse of the
-        // pointer-events property by not applying it in Dashboard.
-        Settings* settings = m_checker.document()->settings();
-        if (settings && settings->usesDashboardBackwardCompatibilityMode())
-            return;
-#endif
         HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE(pointerEvents, PointerEvents)
         return;
     }