V3 Perf Dashboard should automatically select initial range when creating a new task

https://bugs.webkit.org/show_bug.cgi?id=155677

Reviewed by Joseph Pecoraro.

Select the entire range of points for which the analysis task is created by default so that creating
a test group to confirm the regression / progression is easy.

* public/v3/pages/analysis-task-page.js:
(AnalysisTaskPage): Added a boolean flag which indicates the user had modified main chart's selection.
* public/v3/pages/analysis-task-page.js:
(AnalysisTaskPage.prototype.render): Set the main chart's selection to the entire range of points in
the analysis task if the user had never modified selection.
(AnalysisTaskPage.prototype._chartSelectionDidChange): This callback is invoked only when the user had
modified the selection so set _selectionWasModifiedByUser true here unconditionally.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@198495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Websites/perf.webkit.org/ChangeLog b/Websites/perf.webkit.org/ChangeLog
index 088e37b..5c7e9ee 100644 (file)
--- a/Websites/perf.webkit.org/ChangeLog
+++ b/Websites/perf.webkit.org/ChangeLog
@@ -1,3 +1,21 @@
+2016-03-21  Ryosuke Niwa  <rniwa@webkit.org>
+
+        V3 Perf Dashboard should automatically select initial range when creating a new task
+        https://bugs.webkit.org/show_bug.cgi?id=155677
+
+        Reviewed by Joseph Pecoraro.
+
+        Select the entire range of points for which the analysis task is created by default so that creating
+        a test group to confirm the regression / progression is easy.
+
+        * public/v3/pages/analysis-task-page.js:
+        (AnalysisTaskPage): Added a boolean flag which indicates the user had modified main chart's selection.
+        * public/v3/pages/analysis-task-page.js:
+        (AnalysisTaskPage.prototype.render): Set the main chart's selection to the entire range of points in
+        the analysis task if the user had never modified selection.
+        (AnalysisTaskPage.prototype._chartSelectionDidChange): This callback is invoked only when the user had
+        modified the selection so set _selectionWasModifiedByUser true here unconditionally.
+
 2016-03-19  Ryosuke Niwa  <rniwa@webkit.org>
 
         Associated commits don't immediately show up on an analysis task page

diff --git a/Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js b/Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js
index 8875c9e..e38dfe4 100644 (file)
--- a/Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js
+++ b/Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js
@@ -46,6 +46,7 @@ class AnalysisTaskPage extends PageWithHeading {
         this._currentTestGroup = null;
         this._filteredTestGroups = null;
         this._showHiddenTestGroups = false;
+        this._selectionWasModifiedByUser = false;
 
         this._chartPane = this.content().querySelector('analysis-task-chart-pane').component();
         this._chartPane.setPage(this);
@@ -291,6 +292,9 @@ class AnalysisTaskPage extends PageWithHeading {
         this._renderTestGroupList();
         this._renderTestGroupDetails();
 
+        if (!this._renderedCurrentTestGroup && !this._selectionWasModifiedByUser && this._startPoint && this._endPoint)
+            this._chartPane.setMainSelection([this._startPoint.time, this._endPoint.time]);
+
         var points = this._chartPane.selectedPoints();
         this._newTestGroupFormForChart.setRootSetMap(points && points.length >= 2 ?
                 {'A': points[0].rootSet(), 'B': points[points.length - 1].rootSet()} : null);
@@ -521,6 +525,7 @@ class AnalysisTaskPage extends PageWithHeading {
 
     _chartSelectionDidChange()
     {
+        this._selectionWasModifiedByUser = true;
         this.render();
     }