Fix flakiness of fast/visual-viewport/ios/zoomed-focus-in-fixed.html
authorsimon.fraser@apple.com <simon.fraser@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 16 Dec 2016 00:46:27 +0000 (00:46 +0000)
committersimon.fraser@apple.com <simon.fraser@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 16 Dec 2016 00:46:27 +0000 (00:46 +0000)
https://bugs.webkit.org/show_bug.cgi?id=165930

Reviewed by Tim Horton.

The test zooms when focussing the input, which completes after the keyboard shows,
so we need to wait for zooming to finish using the uiController.didEndZoomingCallback.

* fast/visual-viewport/ios/zoomed-focus-in-fixed-expected.txt:
* fast/visual-viewport/ios/zoomed-focus-in-fixed.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@209887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/fast/visual-viewport/ios/zoomed-focus-in-fixed-expected.txt
LayoutTests/fast/visual-viewport/ios/zoomed-focus-in-fixed.html

index d8b3273..697bf51 100644 (file)
@@ -1,3 +1,16 @@
+2016-12-15  Simon Fraser  <simon.fraser@apple.com>
+
+        Fix flakiness of fast/visual-viewport/ios/zoomed-focus-in-fixed.html
+        https://bugs.webkit.org/show_bug.cgi?id=165930
+
+        Reviewed by Tim Horton.
+
+        The test zooms when focussing the input, which completes after the keyboard shows,
+        so we need to wait for zooming to finish using the uiController.didEndZoomingCallback.
+
+        * fast/visual-viewport/ios/zoomed-focus-in-fixed-expected.txt:
+        * fast/visual-viewport/ios/zoomed-focus-in-fixed.html:
+
 2016-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
 
         [Cocoa] Implement font-synthesis: small-caps
index 57fdd3d..621be2e 100644 (file)
@@ -1,3 +1,3 @@
-Layout viewport: {"top":746.703125,"right":320,"bottom":1314.703125,"left":0,"width":320,"height":568}
-Visual viewport: {"top":747,"right":220,"bottom":1138,"left":0,"width":220,"height":391}
+Layout viewport: {"top":659.734375,"right":320,"bottom":1227.734375,"left":0,"width":320,"height":568}
+Visual viewport: {"top":660,"right":220,"bottom":1051,"left":0,"width":220,"height":391}
 
index cc9e1fc..1cf3780 100644 (file)
@@ -31,7 +31,7 @@
         function getFocusInputUIScript(x, y)
         {
             return `(function() {
-                uiController.didShowKeyboardCallback = function() {
+                uiController.didEndZoomingCallback = function() {
                     uiController.uiScriptComplete();
                 }