2010-11-04 Dirk Pranke <dpranke@chromium.org>

        Reviewed by James Robinson.

        new-run-webkit-tests wasn't using DRT by default for
        --platform chromium-gpu

        The default value was set to False instead of None, which meant
        that the platform specific logic wasn't firing to change the
        value to True (b/c we were afraid we'd be overriding the user
        preference).

        https://bugs.webkit.org/show_bug.cgi?id=49038

        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
index 8fef675315163617be676468fc7acafdb8325b70..e4eb4dc11aff2309bcba48aedc48954e486b64e1 100644 (file)
--- a/WebKitTools/ChangeLog
+++ b/WebKitTools/ChangeLog
@@ -1,3 +1,19 @@
+2010-11-04  Dirk Pranke  <dpranke@chromium.org>
+
+        Reviewed by James Robinson.
+
+        new-run-webkit-tests wasn't using DRT by default for
+        --platform chromium-gpu
+
+        The default value was set to False instead of None, which meant
+        that the platform specific logic wasn't firing to change the
+        value to True (b/c we were afraid we'd be overriding the user
+        preference).
+
+        https://bugs.webkit.org/show_bug.cgi?id=49038
+
+        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
+
 2010-11-04  Tony Chang  <tony@chromium.org>
 
         Reviewed by Adam Barth.

diff --git a/WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py b/WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
index 9deec98fb1152c25464454b3023e5ad350cc39de..1f7a0ad9de3d3e15d5e6dde032de21284ab9a6f1 100755 (executable)
--- a/WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
+++ b/WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
@@ -1530,7 +1530,7 @@ def parse_args(args=None):
             default=False,
             help="Don't check the system dependencies (themes)"),
         optparse.make_option("--use-drt", action="store_true",
-            default=False,
+            default=None,
             help="Use DumpRenderTree instead of test_shell"),
         optparse.make_option("--accelerated-compositing",
             action="store_true",