Reviewed by Tony Chang.
Fix bug introduced in r72688 / bug 52768 that broke the
generation of the output filename links in the results.html
output. Apparently none of the unit tests actually checked to
make sure the generated links were correct :(
https://bugs.webkit.org/show_bug.cgi?id=52854
* Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
* Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76311
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
+2011-01-20 Dirk Pranke <dpranke@chromium.org>
+
+ Reviewed by Tony Chang.
+
+ Fix bug introduced in r72688 / bug 52768 that broke the
+ generation of the output filename links in the results.html
+ output. Apparently none of the unit tests actually checked to
+ make sure the generated links were correct :(
+
+ https://bugs.webkit.org/show_bug.cgi?id=52854
+
+ * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
+ * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
+
2011-01-20 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
# FIXME: technically this breaks if files don't use ".ext" to indicate
# the extension, but passing in a Filesystem object here is a huge
# hassle.
- return filename[filename.rfind('.')] + modifier
+ return filename[:filename.rfind('.')] + modifier
class FailureWithType(TestFailure):
crash_set = set([FailureCrash(), "FailureCrash"])
self.assertEqual(len(crash_set), 2)
+ def test_relative_output_filename(self):
+ # This could be any Failure* object, since we're testing a method
+ # on the base class.
+ failure_obj = FailureTextMismatch()
+ actual_filename = failure_obj.relative_output_filename("fast/html/article-element.html", "-actual.txt")
+ self.assertEquals(actual_filename, "fast/html/article-element-actual.txt")
if __name__ == '__main__':
unittest.main()