Add horizontal between categories of tests
authorrniwa@webkit.org <rniwa@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 8 May 2016 04:57:09 +0000 (04:57 +0000)
committerrniwa@webkit.org <rniwa@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 8 May 2016 04:57:09 +0000 (04:57 +0000)
https://bugs.webkit.org/show_bug.cgi?id=157386

Reviewed by Darin Adler.

Wrap tests in each category by tbody and add a horizontal bar between each category.

* public/v3/pages/summary-page.js:
(SummaryPage.prototype._constructTable):
(SummaryPage.cssTemplate):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@200551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Websites/perf.webkit.org/ChangeLog
Websites/perf.webkit.org/public/v3/pages/summary-page.js

index f9f0d62..089f6ad 100644 (file)
@@ -1,3 +1,16 @@
+2016-05-07  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Add horizontal between categories of tests
+        https://bugs.webkit.org/show_bug.cgi?id=157386
+
+        Reviewed by Darin Adler.
+
+        Wrap tests in each category by tbody and add a horizontal bar between each category.
+
+        * public/v3/pages/summary-page.js:
+        (SummaryPage.prototype._constructTable):
+        (SummaryPage.cssTemplate):
+
 2016-05-04  Dewei Zhu  <dewei_zhu@apple.com>
 
         Summary page should show warnings when current or baseline data is missing.
index 55169e9..ffd844d 100644 (file)
@@ -74,13 +74,13 @@ class SummaryPage extends PageWithHeading {
                     this._table.heading.map(function (label) { return element('td', label); }),
                 ])),
             this._table.groups.map(function (rowGroup) {
-                return rowGroup.rows.map(function (row, rowIndex) {
+                return element('tbody', rowGroup.rows.map(function (row, rowIndex) {
                     var headings;
                     headings = [element('th', {class: 'minorHeader'}, row.name)];
                     if (!rowIndex)
                         headings.unshift(element('th', {class: 'majorHeader', rowspan: rowGroup.rows.length}, rowGroup.name));
                     return element('tr', [headings, row.cells.map(self._constructRatioGraph.bind(self))]);
-                });
+                }));
             }),
         ];
     }
@@ -124,8 +124,8 @@ class SummaryPage extends PageWithHeading {
             .summary-table {
                 border-collapse: collapse;
                 border: none;
-                margin: 0 1rem;
-                width: calc(100% - 2rem - 2px);
+                margin: 0;
+                width: 100%;
             }
 
             .summary-table td,
@@ -146,7 +146,11 @@ class SummaryPage extends PageWithHeading {
                 padding-left: 5rem;
             }
 
-            .summary-table > tr:nth-child(even) > *:not(.majorHeader) {
+            .summary-table tbody tr:first-child > * {
+                border-top: solid 1px #ddd;
+            }
+
+            .summary-table tbody tr:nth-child(even) > *:not(.majorHeader) {
                 background: #f9f9f9;
             }