Allow OjbC Weak References when building TestAPI
authormsaboff@apple.com <msaboff@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 24 Oct 2017 22:59:51 +0000 (22:59 +0000)
committermsaboff@apple.com <msaboff@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 24 Oct 2017 22:59:51 +0000 (22:59 +0000)
https://bugs.webkit.org/show_bug.cgi?id=178748

Reviewed by Dan Bernstein.

Set TestAPI build flag Weak References in Manual Retain Release to true.

* JavaScriptCore.xcodeproj/project.pbxproj: Reverted.
* Configurations/ToolExecutable.xcconfig: Changed the flag here instead.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@223937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/JavaScriptCore/ChangeLog
Source/JavaScriptCore/Configurations/ToolExecutable.xcconfig
Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj

index 3e063ed..5e57503 100644 (file)
@@ -1,3 +1,15 @@
+2017-10-24  Michael Saboff  <msaboff@apple.com>
+
+        Allow OjbC Weak References when building TestAPI
+        https://bugs.webkit.org/show_bug.cgi?id=178748
+
+        Reviewed by Dan Bernstein.
+
+        Set TestAPI build flag Weak References in Manual Retain Release to true.
+
+        * JavaScriptCore.xcodeproj/project.pbxproj: Reverted.
+        * Configurations/ToolExecutable.xcconfig: Changed the flag here instead.
+
 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
 
         Web Inspector: Enable WebKit logging configuration and display
index ccfe1b4..bb7a376 100644 (file)
@@ -51,6 +51,8 @@ CLANG_ENABLE_OBJC_ARC_armv7s = YES;
 CLANG_ENABLE_OBJC_ARC_arm64 = YES;
 CLANG_ENABLE_OBJC_ARC_arm64e = YES;
 
+CLANG_ENABLE_OBJC_WEAK = YES;
+
 OTHER_CFLAGS = $(ASAN_OTHER_CFLAGS) -isystem icu;
 OTHER_LDFLAGS = $(ASAN_OTHER_LDFLAGS);
 
index cb4bb67..a91f165 100644 (file)
                        isa = XCBuildConfiguration;
                        baseConfigurationReference = BC021BF2136900C300FC5467 /* ToolExecutable.xcconfig */;
                        buildSettings = {
-                               CLANG_ENABLE_OBJC_WEAK = YES;
                        };
                        name = Debug;
                };
                        isa = XCBuildConfiguration;
                        baseConfigurationReference = BC021BF2136900C300FC5467 /* ToolExecutable.xcconfig */;
                        buildSettings = {
-                               CLANG_ENABLE_OBJC_WEAK = YES;
                        };
                        name = Release;
                };
                        isa = XCBuildConfiguration;
                        baseConfigurationReference = BC021BF2136900C300FC5467 /* ToolExecutable.xcconfig */;
                        buildSettings = {
-                               CLANG_ENABLE_OBJC_WEAK = YES;
                        };
                        name = Production;
                };
                        isa = XCBuildConfiguration;
                        baseConfigurationReference = BC021BF2136900C300FC5467 /* ToolExecutable.xcconfig */;
                        buildSettings = {
-                               CLANG_ENABLE_OBJC_WEAK = YES;
                        };
                        name = Profiling;
                };