An analysis task should be closed if a progression cause is identified

https://bugs.webkit.org/show_bug.cgi?id=155549

Reviewed by Chris Dumez.

Since a progression is desirable, we should close an analysis task once its cause is identified.

Also fix some typos.

* init-database.sql: Fixed a typo.
* public/api/analysis-tasks.php:
* public/v3/models/analysis-task.js:
(AnalysisTask.prototype.dissociateBug): Renamed from dissociateBug.
* public/v3/pages/analysis-task-page.js:
(AnalysisTaskPage.prototype.render):
(AnalysisTaskPage.prototype._dissociateBug): Renamed from _dissociateBug.
(AnalysisTaskPage.prototype._dissociateCommit): Fixed the typo in the alert.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@198351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Websites/perf.webkit.org/ChangeLog b/Websites/perf.webkit.org/ChangeLog
index 4ec2ff7..8611b1d 100644 (file)
--- a/Websites/perf.webkit.org/ChangeLog
+++ b/Websites/perf.webkit.org/ChangeLog
@@ -1,3 +1,23 @@
+2016-03-17  Ryosuke Niwa  <rniwa@webkit.org>
+
+        An analysis task should be closed if a progression cause is identified
+        https://bugs.webkit.org/show_bug.cgi?id=155549
+
+        Reviewed by Chris Dumez.
+
+        Since a progression is desirable, we should close an analysis task once its cause is identified.
+
+        Also fix some typos.
+
+        * init-database.sql: Fixed a typo.
+        * public/api/analysis-tasks.php:
+        * public/v3/models/analysis-task.js:
+        (AnalysisTask.prototype.dissociateBug): Renamed from dissociateBug.
+        * public/v3/pages/analysis-task-page.js:
+        (AnalysisTaskPage.prototype.render):
+        (AnalysisTaskPage.prototype._dissociateBug): Renamed from _dissociateBug.
+        (AnalysisTaskPage.prototype._dissociateCommit): Fixed the typo in the alert.
+
 2016-03-16  Ryosuke Niwa  <rniwa@webkit.org>
 
         Analysis task page should allow specifying commits that caused or fixed a regression or a progression

diff --git a/Websites/perf.webkit.org/init-database.sql b/Websites/perf.webkit.org/init-database.sql
index 9271549..28b51c9 100644 (file)
--- a/Websites/perf.webkit.org/init-database.sql
+++ b/Websites/perf.webkit.org/init-database.sql
@@ -206,7 +206,7 @@ CREATE TABLE analysis_tasks (
 CREATE TABLE task_commits (
     taskcommit_task integer NOT NULL REFERENCES analysis_tasks ON DELETE CASCADE,
     taskcommit_commit integer NOT NULL REFERENCES commits ON DELETE CASCADE,
-    taskcommit_is_fix boolean NOT NULL
+    taskcommit_is_fix boolean NOT NULL,
     CONSTRAINT task_commit_must_be_unique UNIQUE(taskcommit_task, taskcommit_commit));
 
 CREATE TABLE bugs (

diff --git a/Websites/perf.webkit.org/public/api/analysis-tasks.php b/Websites/perf.webkit.org/public/api/analysis-tasks.php
index f15a823..f0d8681 100644 (file)
--- a/Websites/perf.webkit.org/public/api/analysis-tasks.php
+++ b/Websites/perf.webkit.org/public/api/analysis-tasks.php
@@ -116,7 +116,7 @@ function determine_category($task) {
     $category = 'unconfirmed';
 
     $result = $task['result'];
-    if ($result == 'unchanged' || $result == 'inconclusive' || $task['fixes'])
+    if ($result == 'unchanged' || $result == 'inconclusive' || $task['fixes'] || ($result == 'progression' && $task['causes']))
         $category = 'closed';
     else if ($task['causes'])
         $category = 'identified';

diff --git a/Websites/perf.webkit.org/public/v3/models/analysis-task.js b/Websites/perf.webkit.org/public/v3/models/analysis-task.js
index c29049e..4228860 100644 (file)
--- a/Websites/perf.webkit.org/public/v3/models/analysis-task.js
+++ b/Websites/perf.webkit.org/public/v3/models/analysis-task.js
@@ -100,7 +100,7 @@ class AnalysisTask extends LabeledObject {
         });
     }
 
-    disassociateBug(bug)
+    dissociateBug(bug)
     {
         console.assert(bug instanceof Bug);
         console.assert(this.bugs().includes(bug));

diff --git a/Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js b/Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js
index 9fa5339..53d9bdf 100644 (file)
--- a/Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js
+++ b/Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js
@@ -238,7 +238,7 @@ class AnalysisTaskPage extends PageWithHeading {
             var self = this;
             this._bugList.setList(this._task.bugs().map(function (bug) {
                 return new MutableListItem(bug.bugTracker(), bug.label(), bug.title(), bug.url(),
-                    'Disassociate this bug', self._disassociateBug.bind(self, bug));
+                    'Disassociate this bug', self._dissociateBug.bind(self, bug));
             }));
 
             this._causeList.setList(this._task.causes().map(this._makeCommitListItem.bind(this)));
@@ -478,12 +478,12 @@ class AnalysisTaskPage extends PageWithHeading {
         });
     }
 
-    _disassociateBug(bug)
+    _dissociateBug(bug)
     {
         var render = this.render.bind(this);
-        return this._task.disassociateBug(bug).then(render, function (error) {
+        return this._task.dissociateBug(bug).then(render, function (error) {
             render();
-            alert('Failed to disassociate the bug: ' + error);
+            alert('Failed to dissociate the bug: ' + error);
         });
     }
 
@@ -501,7 +501,7 @@ class AnalysisTaskPage extends PageWithHeading {
         var render = this.render.bind(this);
         return this._task.dissociateCommit(commit).then(render, function (error) {
             render();
-            alert('Failed to disassociate the commit: ' + error);
+            alert('Failed to dissociate the commit: ' + error);
         });
     }